[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517615#comment-17517615
]
Jogesh Anand commented on CASSANDRA-16916:
--
Hurrah! thanks a lot [~bereng] . Glad we landed this in trunk. #elated
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.1
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516620#comment-17516620
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~blerer] - thanks for approving the PR. I rebased
[trunk-16916|https://github.com/apache/cassandra/pull/1422] on the latest
apache:trunk . Can this be merged now ? cc: [~bereng]
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.1, 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510268#comment-17510268
]
Jogesh Anand edited comment on CASSANDRA-16916 at 3/22/22, 7:14 AM:
thank you for the direction & reviews [~bereng] . Updated adoc files. Could
you please review ?
was (Author: djanand):
thank you for the direction [~bereng] . Updated adoc files. Could you please
review ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.1, 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jogesh Anand updated CASSANDRA-16916:
-
Fix Version/s: 4.1
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.1, 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510268#comment-17510268
]
Jogesh Anand commented on CASSANDRA-16916:
--
thank you for the direction [~bereng] . Updated adoc files. Could you please
review ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17447) Add support for Alter materialized View in CQL3 statements
[ https://issues.apache.org/jira/browse/CASSANDRA-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jogesh Anand updated CASSANDRA-17447: - Complexity: Low Hanging Fruit > Add support for Alter materialized View in CQL3 statements > -- > > Key: CASSANDRA-17447 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17447 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, CQL/Semantics >Reporter: Jogesh Anand >Priority: Normal > > Add support for ALTER MATERIALIZED VIEW stmts in CQL3. > Make changes to cql3handling.py and ensure correctness > Acceptance Criteria: > * should have the similar semantics as in parser.q antlr > * tests should run in python3 venv locally . refer: [development testing > wiki| https://cassandra.apache.org/_/development/testing.html ] > * check if additional tests need to be added in cassandra-dtests wrt to this > change -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17447) Add support for Alter materialized View in CQL3 statements
[ https://issues.apache.org/jira/browse/CASSANDRA-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jogesh Anand updated CASSANDRA-17447: - Description: Add support for ALTER MATERIALIZED VIEW stmts in CQL3. Make changes to cql3handling.py and ensure correctness Acceptance Criteria: * should have the similar semantics as in parser.q antlr * tests should run in python3 venv locally . refer: [development testing wiki| https://cassandra.apache.org/_/development/testing.html ] * check if additional tests need to be added in cassandra-dtests wrt to this change was: Add support for ALTER MATERIALIZED VIEW stmts in CQL3. Make changes to cql3handling.py and ensure correctness Acceptance Criteria: * should have the similar semantics as in parser.q antlr * tests should run in python3 venv locally * check if additional tests need to be added in cassandra-dtests wrt to this change > Add support for Alter materialized View in CQL3 statements > -- > > Key: CASSANDRA-17447 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17447 > Project: Cassandra > Issue Type: Improvement > Components: CQL/Interpreter, CQL/Semantics >Reporter: Jogesh Anand >Priority: Normal > > Add support for ALTER MATERIALIZED VIEW stmts in CQL3. > Make changes to cql3handling.py and ensure correctness > Acceptance Criteria: > * should have the similar semantics as in parser.q antlr > * tests should run in python3 venv locally . refer: [development testing > wiki| https://cassandra.apache.org/_/development/testing.html ] > * check if additional tests need to be added in cassandra-dtests wrt to this > change -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508013#comment-17508013
]
Jogesh Anand edited comment on CASSANDRA-16916 at 3/17/22, 7:51 AM:
[~e.dimitrova] - thank you so much for the guidance on this ticket and tagging
relevant folks. Appreciate it. Thanks for pushing Jenkins build. If I could get
limited access to Jenkins, such as, can only run once a day, that would be huge
for newcomers/budding enthusiasts. I did try CircleCI but..
Thanks [~bereng] for taking time to review. Glad that Jenkins looks good
(1) Did a rebase and can see the previous SHAs from git log. Did not squash
commits this time. (2) addressed and updated review comments, when you get
sometime. (3) added entry in CHANGES.txt with the assumption that the change
would be part of 4.1 release. (4) Could you let me know how and where can I
update docs for this ?
was (Author: djanand):
[~e.dimitrova] - thank you so much for the guidance on this ticket and tagging
relevant folks. Appreciate it. Thanks for pushing Jenkins build. If I could get
limited access to Jenkins, such as, can only run once a day, that would be huge
for newcomers/budding enthusiasts. I did try CircleCI but..
Thanks [~bereng] for taking time to review. Glad that Jenkins looks good
(1) Did a rebase and can see the previous SHAs from git log. Did not squash
commits this time. (2) addressed and updated review comments, when you get
sometime. (3) add entry in CHANGES.txt with the assumption that the change
would be part of 4.1 release. (4) Could you let me know how and where can I
update docs for ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-17447) Add support for Alter materialized View in CQL3 statements
Jogesh Anand created CASSANDRA-17447: Summary: Add support for Alter materialized View in CQL3 statements Key: CASSANDRA-17447 URL: https://issues.apache.org/jira/browse/CASSANDRA-17447 Project: Cassandra Issue Type: Improvement Components: CQL/Interpreter, CQL/Semantics Reporter: Jogesh Anand Add support for ALTER MATERIALIZED VIEW stmts in CQL3. Make changes to cql3handling.py and ensure correctness Acceptance Criteria: * should have the similar semantics as in parser.q antlr * tests should run in python3 venv locally * check if additional tests need to be added in cassandra-dtests wrt to this change -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508013#comment-17508013
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~e.dimitrova] - thank you so much for the guidance on this ticket and tagging
relevant folks. Appreciate it. Thanks for pushing Jenkins build. If I could get
limited access to Jenkins, such as, can only run once a day, that would be huge
for newcomers/budding enthusiasts. I did try CircleCI but..
Thanks [~bereng] for taking time to review. Glad that Jenkins looks good
(1) Did a rebase and can see the previous SHAs from git log. Did not squash
commits this time. (2) addressed and updated review comments, when you get
sometime. (3) add entry in CHANGES.txt with the assumption that the change
would be part of 4.1 release. (4) Could you let me know how and where can I
update docs for ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502542#comment-17502542
]
Jogesh Anand edited comment on CASSANDRA-16916 at 3/7/22, 8:19 PM:
---
Thanks [~e.dimitrova] - rebased the PR on latest trunk, after squashing my
commits into 1. Can see all latest commits from upstream
_apache/cassandra:trunk_ in my
[branch|https://github.com/djanand/cassandra/commits/trunk-16916] . Could you
please review ?
was (Author: djanand):
Thanks [~e.dimitrova] - rebased the PR on latest trunk, after squashing my
commits into 1. Can see all latest commits from upstream
_apache/cassandra:trunk _in my
[branch|https://github.com/djanand/cassandra/commits/trunk-16916] . Could you
please review ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17502542#comment-17502542
]
Jogesh Anand commented on CASSANDRA-16916:
--
Thanks [~e.dimitrova] - rebased the PR on latest trunk, after squashing my
commits into 1. Can see all latest commits from upstream
_apache/cassandra:trunk _in my
[branch|https://github.com/djanand/cassandra/commits/trunk-16916] . Could you
please review ?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501125#comment-17501125
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~e.dimitrova] - No worries at all. I didn't know I could update the ticket
status, thought reviewers/committers change that status. Will do so next time
onwards. Sorry about that
I can re-base this weekend so if you decide to run CI it's up-to-date. Let me
know how you would like. thanks again!
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501125#comment-17501125
]
Jogesh Anand edited comment on CASSANDRA-16916 at 3/4/22, 3:21 AM:
---
[~e.dimitrova] - No worries at all. I didn't know I could update the ticket
status, thought reviewers/committers change that status. Will do so next time
onwards. Sorry about that
I can re-base this weekend so if you decide to run CI on Monday it's
up-to-date. Let me know how you would like. thanks again!
was (Author: djanand):
[~e.dimitrova] - No worries at all. I didn't know I could update the ticket
status, thought reviewers/committers change that status. Will do so next time
onwards. Sorry about that
I can re-base this weekend so if you decide to run CI it's up-to-date. Let me
know how you would like. thanks again!
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501112#comment-17501112
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~blerer] , [~e.dimitrova] , @mentors - gentle ping!
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481587#comment-17481587
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~e.dimitrova] & [~blerer]- thanks! I cherry-picked the commits onto trunk PFA.
Re-ran java tests, cqlsh tests locally.
The dtest on ALTER USER was failing because
[here|https://github.com/apache/cassandra/pull/1422/files#diff-5435f01c80d135f7b28666e74015cc78777fd2e3deb395c56ff2e9d088e71716R1195]
I had ifExists=true and instead of throwing an exception, it assumed that IF
EXISTS clause was present. This suppressed the exception. Re-ran the failed
dtests after the fix.
ran a rebase on top of the latest trunk.
* Could you please review and run CI ?
* Out of curiosity, when we release a new C* version, do we pick specific
commits from trunk and then apply them on a new branch? Or do we branch off
from trunk and cut the release from there. If the process is more involved skip
this question. :)
* Unlike, ALTER table _testcases_ in AlterTest.java, wherein we execute the
stmt on a local node, I couldn't find testcases for ALTER USER stmts that run
on the local node. These tests are present in dtests though. Is that
intentional?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477492#comment-17477492
]
Jogesh Anand commented on CASSANDRA-16916:
--
thanks [~e.dimitrova] for clarifying that information. No worries. Yeah, I
will cherry-pick commits on top of trunk and the post in the thread. I'm
planning to have it this week and update here for you/Benjamin to run CI/
review.
Yeah, I ran pytests locally on virtualenv and using a single node ccm cluster,
but wasn't very aware of dtests repo. Thanks for making me aware. Since, dtests
were the ones failing, I'll use the latest trunk, make my changes on top of it
and then run dtests. Do you think these changes require some new dtests?
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
> Fix For: 4.x
>
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17474336#comment-17474336
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~blerer] - thanks for taking the time to review. (y) Addressed & pushed the
changes. Also, updated PR with my comments. Please take a look.
[~e.dimitrova] - thank you for running CI. :) please review and would wait for
your review comments. I see some failures on CI and maybe those are related to
the changes. Would be great if you could share some info on those as well.
Once, I address the review comments, I was thinking of rebasing with
_cassandra-4.0_ branch, squashing commits and force-push.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449955#comment-17449955
]
Jogesh Anand commented on CASSANDRA-16916:
--
thanks [~blerer] for the review and for the slack invite. Working on addressing
them.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443485#comment-17443485
]
Jogesh Anand edited comment on CASSANDRA-16916 at 11/14/21, 11:06 PM:
--
[~blerer] / @ mentors - thanks for your patience. I modified some alter
statements as mentioned in the Jira above. Please have an initial look when you
get some time. Here's [CI
link|https://app.circleci.com/pipelines/github/djanand/cassandra?branch=CASSANDRA-16916]
(currently running). I have had issues with test cases in previous tickets
(pre 4.0 merge or thereabouts) that run fine locally but the CircleCI breaks.
I'll keep an eye out. Can you please help with the below:-
* Would it be helpful to have IF EXISTS on ALTER TABLE %s RENAME statements?
* ALTER ROLE, ALTER MATERIALIZED VIEW, and ALTER USER is WIP and will be
sharing those changes in a couple of days.
* I'm not sure how I could join #cassandra-dev slack channel. I don't have an
@apache.org email, so if someone sends an invite my way that would be pretty
helpful.
was (Author: djanand):
[~blerer] / @ mentors - thanks for your patience. I modified some alter
statements as mentioned in the Jira above. Please have an initial look when you
get some time. Here's [CI
link|https://app.circleci.com/pipelines/github/djanand/cassandra?branch=CASSANDRA-16916]
(currently running). I have had issues with test cases that run fine locally
but the CircleCI breaks. I'll keep an eye out. Can you please help with the
below:-
* Would it be helpful to have IF EXISTS on ALTER TABLE %s RENAME statements?
* ALTER ROLE, ALTER MATERIALIZED VIEW, and ALTER USER is WIP and will be
sharing those changes in a couple of days.
* I'm not sure how I could join #cassandra-dev slack channel. I don't have an
@apache.org email, so if someone sends an invite my way that would be pretty
helpful.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17443485#comment-17443485
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~blerer] / @ mentors - thanks for your patience. I modified some alter
statements as mentioned in the Jira above. Please have an initial look when you
get some time. Here's [CI
link|https://app.circleci.com/pipelines/github/djanand/cassandra?branch=CASSANDRA-16916]
(currently running). I have had issues with test cases that run fine locally
but the CircleCI breaks. I'll keep an eye out. Can you please help with the
below:-
* Would it be helpful to have IF EXISTS on ALTER TABLE %s RENAME statements?
* ALTER ROLE, ALTER MATERIALIZED VIEW, and ALTER USER is WIP and will be
sharing those changes in a couple of days.
* I'm not sure how I could join #cassandra-dev slack channel. I don't have an
@apache.org email, so if someone sends an invite my way that would be pretty
helpful.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17425359#comment-17425359
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~subkanthi], [~blerer] - Hey folks, sorry for the delay in getting to it ( was
caught up with office work a bit). Yeah I'm working on it and will get the
initial set out in a week or two. Appreciate the patience on this ticket. Will
get back on this.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Assignee: Jogesh Anand
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16916) Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
[
https://issues.apache.org/jira/browse/CASSANDRA-16916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17410924#comment-17410924
]
Jogesh Anand commented on CASSANDRA-16916:
--
[~blerer] - thanks! It does look interesting. Started to look into this.
> Add support for IF EXISTS and IF NOT EXISTS in ALTER statements
> ---
>
> Key: CASSANDRA-16916
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16916
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
>Reporter: Benjamin Lerer
>Priority: Normal
>
> It would make sense to add support for {{IF EXISTS}} and {{IF NOT EXISTS}} in
> the different {{ALTER}} statements.
> For example:
> * {{ALTER TABLE IF EXISTS myTable ...}}
> * {{ALTER TABLE myTable ADD IF NOT EXISTS ...}}
> * {{ALTER TABLE myTable DROP IF EXISTS ...}}
> * {{ALTER TYPE IF EXISTS myType ...}}
> * {{ALTER TYPE myType ADD IF NOT EXISTS ...}}
> +Additional info for newcomers:+
> In order to implement this change you will need to change the {{Parser.g}}
> ANTLR file located in the src/antlr directory and the java classes
> corresponding to the different alter statements located in the
> {{org.apache.cassandra.cql3.statements.schema}} package. You can look at the
> CreateTableStatement class to see how it was done there.
> The unit test for the CQL logic are located under
> {{org.apache.cassandra.cql3.validation}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17409177#comment-17409177 ] Jogesh Anand commented on CASSANDRA-16621: -- [~bereng] - (y) thanks for the great communication and help on this. There goes the commit to trunk and 4.0. :) Yeah, I did hit the CI bottleneck but found quick help from you and Andres. I would be happy to look into some other tickets as well. I see we have other low-hanging fruits but many don't have details on the ticket. Would rather comment on those for additional info. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17401259#comment-17401259 ] Jogesh Anand commented on CASSANDRA-16621: -- [~bereng] & [~adelapena] +1. thanks so much and lgtm. (y) > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382407#comment-17382407 ] Jogesh Anand commented on CASSANDRA-16621: -- [~bereng] - running into some of the same failures that I encountered before even after rebase. Unsure. Would you mind? > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17382371#comment-17382371 ] Jogesh Anand commented on CASSANDRA-16621: -- That's nice. thanks! I would prefer to do it. Yeah, I did rebase the PR on 4.0. Also, updated the changes for trunk CI. ||branch || CI || |CI 4.0 || [j11|https://app.circleci.com/pipelines/github/djanand/cassandra/11/workflows/40ae1eb3-5292-4637-ac17-271cac1738e6] & [j8|https://app.circleci.com/pipelines/github/djanand/cassandra/11/workflows/a730dc81-11bb-413c-adaa-584ca9de8e37]| |CI trunk || [j11|https://app.circleci.com/pipelines/github/djanand/cassandra/12/workflows/abe8f0c5-f98d-448f-828a-092af41f02db] & [j8|https://app.circleci.com/pipelines/github/djanand/cassandra/12/workflows/abe8f0c5-f98d-448f-828a-092af41f02db]| Tracking both runs. I wonder what fixed the errors that we were getting earlier > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381622#comment-17381622 ] Jogesh Anand edited comment on CASSANDRA-16621 at 7/16/21, 3:55 AM: +1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly assumed that Awaitility would check the condition right before timeout, but that's clearly not the case. Updated to use a fixed poll interval of ~100ms in the PR. Thanks [~bereng] for sharing. was (Author: djanand): +1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly assumed that Awaitility would check the condition right before timeout, but that's clearly not the case. Updated to use a fixed poll interval of ~100ms in the PR. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381622#comment-17381622 ] Jogesh Anand commented on CASSANDRA-16621: -- +1 [~adelapena] - It does seem that fibonacci wouldn't work here. I implicitly assumed that Awaitility would check the condition right before timeout, but that's clearly not the case. Updated to use a fixed poll interval of ~100ms in the PR. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17381073#comment-17381073
]
Jogesh Anand commented on CASSANDRA-16621:
--
{quote}
Regarding the poll interval, even though 1ms is probably the most similar thing
to the original implementation, I wonder whether it would be too low. Perhaps
we could use Awaitility's default interval of 100ms and then add an optimistic
poll delay of zero?{quote}
{quote}But moving to 100ms would might even make more sense to avoid spinning
the CPU on yields{quote}
Agree that 1ms is too low. 100ms sgtm. I also think fibonacci polling interval
might also be a good option. Thoughts?
{code:java}
.pollInterval(fibonacci(TimeUnit.MILLISECONDS))
{code}
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17379626#comment-17379626 ] Jogesh Anand commented on CASSANDRA-16621: -- [~bereng] - thanks! that's very considerate of you :) Yeah I have been following the email updates on 4.0.0 release. :) > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17377878#comment-17377878 ] Jogesh Anand commented on CASSANDRA-16621: -- [~bereng] - thanks! I have also been trying out some changes (unrelated to the awaitility fix for this ticket) to fix the failing tests. Looks like something similar was mentioned in CASSANDRA-16670. Regardless, will let keep you posted if I get those tests working. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Assignee: Jogesh Anand >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375977#comment-17375977
]
Jogesh Anand edited comment on CASSANDRA-16621 at 7/7/21, 6:04 AM:
---
[~bereng] - thanks! yeah there are some failures. When I run the failed tests
locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they
succeed on every run.
The exception that I get on the
[circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C]
tests is:
{code:java}
com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error
occurred on host localhost/127.0.0.1:36945. This is a bug in this library,
please report: Must not send frame with WARNING flag for native protocol
version < 4
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66)
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27)
[junit-timeout] at
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
[junit-timeout] at
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293)
{code}
-When debugging locally, I see that DriverThrowables class loads from
cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.-
-This leads me to believe that the build on circle-ci is using a different
version of driver than local.-
ps: I'm using the default .circleci/config.yml
was (Author: djanand):
[~bereng] - thanks! yeah there are some failures. When I run the failed tests
locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they
succeed on every run.
The exception that I get on the
[circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C]
tests is:
{code:java}
com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error
occurred on host localhost/127.0.0.1:36945. This is a bug in this library,
please report: Must not send frame with WARNING flag for native protocol
version < 4
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66)
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27)
[junit-timeout] at
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
[junit-timeout] at
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293)
{code}
When debugging locally, I see that DriverThrowables class loads from
cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.
This leads me to believe that the build on circle-ci is using a different
version of driver than local.
ps: I'm using the default .circleci/config.yml
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375977#comment-17375977
]
Jogesh Anand edited comment on CASSANDRA-16621 at 7/6/21, 7:50 PM:
---
[~bereng] - thanks! yeah there are some failures. When I run the failed tests
locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they
succeed on every run.
The exception that I get on the
[circle-ci|https://circleci.com/api/v1.1/project/github/djanand/cassandra/3/output/104/0?file=true=60deafb9c3492162b60b9b5e-0-build%2F58BCD97C]
tests is:
{code:java}
com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error
occurred on host localhost/127.0.0.1:36945. This is a bug in this library,
please report: Must not send frame with WARNING flag for native protocol
version < 4
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66)
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27)
[junit-timeout] at
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
[junit-timeout] at
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293)
{code}
When debugging locally, I see that DriverThrowables class loads from
cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.
This leads me to believe that the build on circle-ci is using a different
version of driver than local.
ps: I'm using the default .circleci/config.yml
was (Author: djanand):
[~bereng] - thanks! yeah there are some failures. When I run the failed tests
locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they
succeed on every run.
The exception that I get on the circle-ci tests is:
{code:java}
com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error
occurred on host localhost/127.0.0.1:36945. This is a bug in this library,
please report: Must not send frame with WARNING flag for native protocol
version < 4
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66)
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27)
[junit-timeout] at
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
[junit-timeout] at
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293)
{code}
When debugging locally, I see that DriverThrowables class loads from
cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.
This leads me to believe that the build on circle-ci is using a different
version of driver than local.
ps: I'm using the default .circleci/config.yml
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[
https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375977#comment-17375977
]
Jogesh Anand commented on CASSANDRA-16621:
--
[~bereng] - thanks! yeah there are some failures. When I run the failed tests
locally ie ViewComplexLivenessTest and ViewFilteringClustering1Test they
succeed on every run.
The exception that I get on the circle-ci tests is:
{code:java}
com.datastax.driver.core.exceptions.ProtocolError: An unexpected protocol error
occurred on host localhost/127.0.0.1:36945. This is a bug in this library,
please report: Must not send frame with WARNING flag for native protocol
version < 4
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:66)
[junit-timeout] at
com.datastax.driver.core.exceptions.ProtocolError.copy(ProtocolError.java:27)
[junit-timeout] at
com.datastax.driver.core.DriverThrowables.propagateCause(DriverThrowables.java:35)
[junit-timeout] at
com.datastax.driver.core.DefaultResultSetFuture.getUninterruptibly(DefaultResultSetFuture.java:293)
{code}
When debugging locally, I see that DriverThrowables class loads from
cassandra-driver-core-3.11.0-shaded.jar which has no line:35 in it.
This leads me to believe that the build on circle-ci is using a different
version of driver than local.
ps: I'm using the default .circleci/config.yml
> Replace spinAsserts code with Awaitility code
> -
>
> Key: CASSANDRA-16621
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16621
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
>Reporter: Berenguer Blasi
>Assignee: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
> Fix For: 4.0.x
>
>
> Currently spinAsserts does a similar thing to Awaitility which is being used
> more and more. We have now 2 ways of doing the same thing so it would be good
> to consolidate
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373262#comment-17373262 ] Jogesh Anand commented on CASSANDRA-16621: -- thanks [~bereng] for taking a look. Attached the PR with 4.0 as base. ||[CircleCi|https://app.circleci.com/pipelines/github/djanand/cassandra/1/workflows/395a1c77-b7d9-4ad3-8641-7ce353e7d90f]||[CircleCi|https://app.circleci.com/pipelines/github/djanand/cassandra/1/workflows/29b1c542-e954-4695-8f2c-7872e62a0d46]|| I think these tests would take a while. Please guide, if you think I need to run some more CI tests as I'm not super familiar with the ecosystem. > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-16621) Replace spinAsserts code with Awaitility code
[ https://issues.apache.org/jira/browse/CASSANDRA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371016#comment-17371016 ] Jogesh Anand commented on CASSANDRA-16621: -- The change seems reasonable and attaching a PR. Can someone please review ? > Replace spinAsserts code with Awaitility code > - > > Key: CASSANDRA-16621 > URL: https://issues.apache.org/jira/browse/CASSANDRA-16621 > Project: Cassandra > Issue Type: Bug > Components: Test/unit >Reporter: Berenguer Blasi >Priority: Normal > Labels: low-hanging-fruit > Fix For: 4.0.x > > > Currently spinAsserts does a similar thing to Awaitility which is being used > more and more. We have now 2 ways of doing the same thing so it would be good > to consolidate -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-16766) Development docs are not upto to date
[
https://issues.apache.org/jira/browse/CASSANDRA-16766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jogesh Anand updated CASSANDRA-16766:
-
Labels: low-hanging-fruit (was: )
> Development docs are not upto to date
> -
>
> Key: CASSANDRA-16766
> URL: https://issues.apache.org/jira/browse/CASSANDRA-16766
> Project: Cassandra
> Issue Type: Improvement
> Components: Documentation/Website
>Reporter: Jogesh Anand
>Priority: Normal
> Labels: low-hanging-fruit
>
> The latest developers guide for unit testing isn't accurate
> [link|https://cassandra.apache.org/doc/latest/development/testing.html]
> For e.g
> {code:java}
> ant test -Dtest.name=
> {code}
> isn't valid. It's now
> {code:java}
> ant testsome -Dtest.name=
> {code}
> Similarly, we also have `ant long-testsome` & `ant burn-testsome` for e.g. I
> would be nice to have these documented as well for developers or users.
> AC:
> * The website accurately represents all testing scenarios present in
> build.xml or otherwise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-16766) Development docs are not upto to date
Jogesh Anand created CASSANDRA-16766:
Summary: Development docs are not upto to date
Key: CASSANDRA-16766
URL: https://issues.apache.org/jira/browse/CASSANDRA-16766
Project: Cassandra
Issue Type: Improvement
Components: Documentation/Website
Reporter: Jogesh Anand
The latest developers guide for unit testing isn't accurate
[link|https://cassandra.apache.org/doc/latest/development/testing.html]
For e.g
{code:java}
ant test -Dtest.name=
{code}
isn't valid. It's now
{code:java}
ant testsome -Dtest.name=
{code}
Similarly, we also have `ant long-testsome` & `ant burn-testsome` for e.g. I
would be nice to have these documented as well for developers or users.
AC:
* The website accurately represents all testing scenarios present in build.xml
or otherwise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426478#comment-16426478
]
Jogesh Anand commented on CASSANDRA-13653:
--
Hi [~djoshi3] - Thank you. Removed them and squashed the [commit
|https://github.com/djanand/cassandra/commit/f9d6982c9d54d07938aaec84d54c4e4b536b0ed9]
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421500#comment-16421500
]
Jogesh Anand edited comment on CASSANDRA-13653 at 4/3/18 1:06 AM:
--
[~djoshi3] / [~jjirsa] / [~dbrosius] - I have incorporated the feedback with
the latest trunk. Could you please take a look at it .
[13653-trunk|https://github.com/djanand/cassandra/commit/4366955769dcda39fba6e4bf427045f3da9ac457].
I am open to any suggestions to make changes. Feel free to comment on the
commits/per file for any specific file related issues. Please suggest any
benchmarks which can be run if you think otherwise.
was (Author: djanand):
[~djoshi3] / [~jjirsa] - I have incorporated the feedback with the latest
trunk. Could you please take a look at it .
[13653-updated-trunk|https://github.com/djanand/cassandra/commit/4366955769dcda39fba6e4bf427045f3da9ac457]
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421500#comment-16421500
]
Jogesh Anand edited comment on CASSANDRA-13653 at 3/31/18 11:01 PM:
[~djoshi3] / [~jjirsa] - I have incorporated the feedback with the latest
trunk. Could you please take a look at it .
[13653-updated-trunk|https://github.com/djanand/cassandra/commit/4366955769dcda39fba6e4bf427045f3da9ac457]
was (Author: djanand):
[~djoshi3] / [~jjirsa] - I have incorporated the feedback. Could you please
take a look at it .
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421500#comment-16421500
]
Jogesh Anand commented on CASSANDRA-13653:
--
[~djoshi3] / [~jjirsa] - I have incorporated the feedback. Could you please
take a look at it .
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415042#comment-16415042
]
Jogesh Anand commented on CASSANDRA-13653:
--
[~djoshi3] - Thanks for the feedback. I went through the links provided and my
reasoning is based on these two points. One, this will be used for debugging
purposes and there are not many places where we would log/print the entire
class. Second, if there are additions/deletions to the class variables
developers need not worry about the toString() implementation. Having said that
please help me understand if there will be plenty of logging in cql3.statements
package in which case this might effect performance as you mentioned.
ps:sorry for the inconvenience on the patch. Will address Nate's feedback
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413214#comment-16413214
]
Jogesh Anand edited comment on CASSANDRA-13653 at 3/26/18 7:03 PM:
---
[~djoshi3] - Thank you. I have made the changes against trunk now
([13653-trunk|https://github.com/djanand/cassandra/tree/13653-trunk]).
toString() changes have been made in the following packages cql3.statements ,
cql3.restrictions, cql3, cql3.conditions. Could you please review the same ?
was (Author: djanand):
[~djoshi3] - Thank you. I have made the changes against trunk now
([13653-trunk|https://github.com/djanand/cassandra/tree/13653-trunk]). Could
you please review the same ? Please let me know if any changes are required.
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413214#comment-16413214
]
Jogesh Anand commented on CASSANDRA-13653:
--
[~djoshi3] - Thank you. I have made the changes against trunk now
([13653-trunk|https://github.com/djanand/cassandra/tree/13653-trunk]). Could
you please review the same ? Please let me know if any changes are required.
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Jogesh Anand
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178540#comment-16178540
]
Jogesh Anand edited comment on CASSANDRA-13653 at 3/25/18 3:55 AM:
---
Hi I am new to open source contribution as well. Though the ticket is already
assigned I tired to take a stab at this.
[13653-3.11|https://github.com/djanand/cassandra/tree/13653-3.11]
[~jjirsa]/[~varuna]/[~dbrosius] - Could you please review ? Please let me know
if there other classes which require toString() impl. I can make changes the
required changes. Are there any other branches where I need to propagate this
change ?
was (Author: djanand):
Hi I am new to open source as well. Though the ticket is already assigned I
tired to take a stab at this.
https://github.com/djanand/cassandra/commit/37619dc2890e05758052ab52d3fa24a9c3bae7c6?diff=split
Please have a look.
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Chandan Kumar Agarwal
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178540#comment-16178540
]
Jogesh Anand edited comment on CASSANDRA-13653 at 3/25/18 3:55 AM:
---
Hi I am new to open source contribution as well. Though the ticket is already
assigned I tired to take a stab at this.
[13653-3.11|https://github.com/djanand/cassandra/tree/13653-3.11]
[~jjirsa]/[~varuna]/[~dbrosius] - Could you please review ? Please let me know
if there other classes which require toString() impl. I can make the required
changes. Are there any other branches where I need to propagate this change ?
was (Author: djanand):
Hi I am new to open source contribution as well. Though the ticket is already
assigned I tired to take a stab at this.
[13653-3.11|https://github.com/djanand/cassandra/tree/13653-3.11]
[~jjirsa]/[~varuna]/[~dbrosius] - Could you please review ? Please let me know
if there other classes which require toString() impl. I can make changes the
required changes. Are there any other branches where I need to propagate this
change ?
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Chandan Kumar Agarwal
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-13653) Create meaningful toString() methods
[
https://issues.apache.org/jira/browse/CASSANDRA-13653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178540#comment-16178540
]
Jogesh Anand commented on CASSANDRA-13653:
--
Hi I am new to open source as well. Though the ticket is already assigned I
tired to take a stab at this.
https://github.com/djanand/cassandra/commit/37619dc2890e05758052ab52d3fa24a9c3bae7c6?diff=split
Please have a look.
> Create meaningful toString() methods
>
>
> Key: CASSANDRA-13653
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13653
> Project: Cassandra
> Issue Type: Bug
>Reporter: Jeff Jirsa
>Assignee: Chandan Kumar Agarwal
>Priority: Trivial
> Labels: lhf, low-hanging-fruit
>
> True low-hanging fruit, good for a first-time contributor:
> There are a lot of classes without meaningful {{toString()}} implementations.
> Some of these would be very nice to have for investigating bug reports.
> Some good places to start:
> - CQL3 statements (UpdateStatement, DeleteStatement, etc), QueryOptions, and
> Restrictions
> Some packages not to worry about:
> - Deep internals that don't already have them
> (org.apache.cassandra.db.rows/partitions/etc)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
