[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17482298#comment-17482298 ] Berenguer Blasi commented on CASSANDRA-17009: - All praise and glory to [~bhouser] for driving this. Thanks for your work. And thanks to [~adelapena] for helping me drive it across the finish line. :-) > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.2, 4.1 > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481783#comment-17481783
]
Andres de la Peña commented on CASSANDRA-17009:
---
Great, both PRs look good to me, +1. I have left a couple of formatting nits
that can be addressed during commit.
Here are some additional multiplexer runs for the new
{{StandaloneVerifierOnSSTablesTest}}:
||branch||CI||
|[4.0|https://github.com/adelapena/cassandra/tree/17009-4.0-review]
|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1253/workflows/2c174af1-c2ec-4c20-bd73-2e32026eb1d8]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1253/workflows/26933022-7c32-426d-b064-2c572a6f2ac1]|
|[trunk|https://github.com/adelapena/cassandra/tree/17009-trunk-review]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1252/workflows/6e9b6d4b-d928-43c9-9cf3-97d7c8a4b733]
[j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1252/workflows/4b376c0b-39e9-4ea6-81bf-d79291d1127c]|
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481639#comment-17481639 ] Berenguer Blasi commented on CASSANDRA-17009: - Correct [~adelapena]. I wanted a first review round before jumping into the other PR. I have put up both now squashed & rebased. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17481295#comment-17481295
]
Andres de la Peña commented on CASSANDRA-17009:
---
The patch looks good to me, I have only left a few trivial suggestions on the
[~bereng]'s PR.
[Here|https://app.circleci.com/pipelines/github/adelapena/cassandra/1251/workflows/23420982-3892-4a77-a93c-c3c2cf7da317]
are a few runs of the new {{StandaloneVerifierOnSSTablesTest}} in the
multiplexer. I think we would need a PR for trunk with a CI run.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Fix For: 4.0.x, 4.x
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477698#comment-17477698 ] Berenguer Blasi commented on CASSANDRA-17009: - New rebased & squashed PR for committer review [here|https://github.com/apache/cassandra/pull/1405] > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477065#comment-17477065 ] Berenguer Blasi commented on CASSANDRA-17009: - Hi [~bhouser] I'll take over to get this one across the finish line. I hope you don't mind. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471688#comment-17471688 ] Berenguer Blasi commented on CASSANDRA-17009: - Hi [~bhouser] do you still plan to look into this or do you prefer me to take over? > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435244#comment-17435244 ] Berenguer Blasi commented on CASSANDRA-17009: - Hi [~bhouser] I noticed you pushed. Is this ready for review again? Feel free to ask for help if you're too busy etc > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Fix For: 4.0.x, 4.x > > Time Spent: 3.5h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428037#comment-17428037 ] Berenguer Blasi commented on CASSANDRA-17009: - Dropped a couple nits. Did you rebase? The PR doesn't mention it. It is failing to run tests locally on some rat report failure. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Time Spent: 3h 10m > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424335#comment-17424335 ] Berenguer Blasi commented on CASSANDRA-17009: - Btw I see you pinged me on Slack a few times and I didn't reply. This is bc your ASF Slack is not snoozed and every time I am about to answer it's 3 or 4 am for you! So I don't do it in the end. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Time Spent: 2h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424005#comment-17424005 ] Brian Houser commented on CASSANDRA-17009: -- Great! no problem on all counts. I'll work through this today. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Time Spent: 2h > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423135#comment-17423135
]
Berenguer Blasi commented on CASSANDRA-17009:
-
> I accidentally turned off the spell checker in the ide as it turns out...
> blerg I'll fix them, sorry about that.
No need to apologize! I do these sort of things all the time unfortunately lol!
> The fix for this is small, but I was trying to keep the change small,
> incremental and focused on the unit test. No sweat though, I can fix it
> (basically just force an early exit).
And you're absolutely right. But from experience I can tell you each ticket is
sandwiched between CI and contributor review cycle time. That tends to be not
negligible so if it's a few loc of a related fix that'd be my suggestion to
keep things moving. But feel free to do whatever you think is best ofc!
> The issue with the git ignore of test/data sounds weird to me it didn't came
> up sooner. I have to give it another thought.
Ok I'll buy that.
> On the {{Verifier}} and coverage discussion
Icwym and I think you are right. Still I would suggest:
- Adding to all verify test classes a javadoc detailing all the files involved:
VerifyTest, StandaloneVerifierOnSSTablesTest, etc This way a reader will learn
immediately about coverage and what classes are involved instead of wondering
around and finding it out himself. Wdyt?
- Yes replicating those tests would be redundant and we already have existing
tests on the cmd line options making sure the tool doesn't explode but
- The -c test we need to add to {{StandaloneVerifierTest}} bc we have no test
proving this option doesn't explode the tool or that the tool is ignoring it
i.e. Same as with the token option which in this case is another ticket. But
-c, being minimal effort, I'd suggest doing in this ticket.
Wdyt makes sense? I'll move the state of the ticket to help me track things if
you don't mind.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17423035#comment-17423035
]
Brian Houser commented on CASSANDRA-17009:
--
> I noted a few minor typos in the PR
I accidentally turned off the spell checker in the ide as it turns out... blerg
I'll fix them, sorry about that.
> Sthg weird happened with the file {{cassandra.in.sh}}. Make sure you're
> branching off the right place etc
not sure how that ended up in the mix and it has no changes, I'll remove it. I
was branching off cassandra-4.0 at the time of submitting
> I would use this opportunity to add {{assertOnCleanExit()}} on the already
> existing test when possible
Np, I'll go ahead and do that.
>That bug on the return code I would fix in this ticket. Bear in mind CI is
>heavy and we'll need to ping more people to review this ticket. The less we go
>back and forth the better. So if we can pack it here, within reason, I'd do
>that. Seems to me It'd be a few loc only.
The fix for this is small, but I was trying to keep the change small,
incremental and focused on the unit test. No sweat though, I can fix it
(basically just force an early exit).
> The issue with the git ignore of {{test/data}} sounds weird to me it didn't
> came up sooner. I have to give it another thought.
Yeah it was a weird thing to me when I found it, pretty anti-intuitive and I
had to look up the git docs for fear I was being nutty. I mentioned it on the
slack channel before doing this. We have are ignoring "data/" which ignores
any folder containing data. It hasn't come up because any time that I guess we
added to it we just used the force option (also older files will avoid the
gitignore by virtue of being grandfathered in). It seemed like a good idea to
file an exception, and chatting with folk they said I should just jump on it.
From [https://git-scm.com/docs/gitignore] * If there is a separator at the end
of the pattern then the pattern will only match directories, otherwise the
pattern can match both files and directories.
* For example, a pattern {{doc/frotz/}} matches {{doc/frotz}} directory, but
not {{a/doc/frotz}} directory; however {{frotz/}} matches {{frotz}} and
{{a/frotz}} that is a directory (all paths are relative from the {{.gitignore}}
file).
I think this is the {{frotz/}} case here.Just to make sure I wasn’t crazy, I
created a file inside of test/data to see if was being tracked, my git ignored
it.
I called this “helloworld”. added some text and then ran…
$ git check-ignore -v helloworld
.gitignore:8:data/ helloworld
>The already existing tests only 'scratch the surface'. They pass an argument
>and check the tool doesn't explode. But they don't check the sstables
>themselves to make sure the argument was effective. I.e does '-r' really have
>an effect?
For the most part, this is a verifier, so its job is to tell you if something
is messed up, not necessarily do much about it(or at least that was my
thought). The tests verify you get a verify result. Though I could see about
adding a `-r` as that has the potential to mutate.
There is already a verifyer test (which is mainly all this class exercises)
called VerifyTest, this test already covers said cases. I thought it would be
somewhat redundant to replicate most of the same tests in a unit test. I
thought better to make sure that the happy and unhappy verifyer results are
caught and verify the execution paths.
> The new tests you added are really nice! but for completion purposes I would
> combine them with -q, -e, etc and any other params to make sure they all work
> with corrupted data i.e.
> We seem to be missing a -c test.
I can add these, though as I said, at that point I am mostly doing similar
tests as in VerifyTest (they really unit test that component through the
verifier). It won't add to the coverage of the suite.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail:
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422550#comment-17422550
]
Berenguer Blasi commented on CASSANDRA-17009:
-
[~bhouser] here is my first pass:
- I noted a few minor typos in the PR
- Sthg weird happened with the file {cassandra.in.sh}}. Make sure you're
branching off the right place etc
- I would use this opportunity to add {{assertOnCleanExit()}} on the already
existing test when possible
- That bug on the return code I would fix in this ticket. Bear in mind CI is
heavy and we'll need to ping more people to review this ticket. The less we go
back and forth the better. So if we can pack it here, within reason, I'd do
that. Seems to be It'd be a few loc only.
- The issue with the git ignore of {{test/data}} sounds weird to me it didn't
came up sooner. I have to give it another thought.
- The already existing tests only 'scratch the surface'. They pass an argument
and check the tool doesn't explode. But they don't check the sstables
themselves to make sure the argument was effective. I.e does '-r' really have
an effect?
- The new tests you added are really nice! but for completion purposes I would
combine them with -q, -e, etc and any other params to make sure they all work
with corrupted data i.e.
- We seem to be missing a -c test.
Wdyt, does this make sense to you? Sounds like a lot but what you did already
is all the heavy lifting of coming up with the test. That is very nice. I think
with a few additions we'd be there. Let me know what you think.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Time Spent: 2h
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422039#comment-17422039 ] Berenguer Blasi commented on CASSANDRA-17009: - [~bhouser] I had missed this until Benjamin moved it to 'Patch available'. It's better if you move states yourself in the ticket when you are ready so they don't get missed. I'll try to review asap unless sbdy beats me to it. Thx for the PR. > Sstableverify unit test operate on SSTables > --- > > Key: CASSANDRA-17009 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17009 > Project: Cassandra > Issue Type: Sub-task > Components: Tool/sstable >Reporter: Brian Houser >Assignee: Brian Houser >Priority: Normal > Time Spent: 40m > Remaining Estimate: 0h > > as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit > coverage is a bit lax and doesn't run through the verifier (based on my > coverage results). > There should be a unit test that exercises the internal verifier both for a > corrupt example and a working example. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables
[
https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17421626#comment-17421626
]
Brian Houser commented on CASSANDRA-17009:
--
Added a new test which does more deeper verification
{color:#b57614}StandaloneVerifierOnSSTablesTest{color}
Raises coverage an addtional 20%.
[https://github.com/apache/cassandra/pull/1231]
Did find a few minor bugs as a result of doing this, but thought it best to
address them separately as this is a unit test jira. This includes a loading
error resulting in successful return code, as well as error written to stdout,
as opposed to stderr.
Verified by running unit tests on desktop.
> Sstableverify unit test operate on SSTables
> ---
>
> Key: CASSANDRA-17009
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
> Project: Cassandra
> Issue Type: Sub-task
> Components: Tool/sstable
>Reporter: Brian Houser
>Assignee: Brian Houser
>Priority: Normal
> Time Spent: 20m
> Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit
> coverage is a bit lax and doesn't run through the verifier (based on my
> coverage results).
> There should be a unit test that exercises the internal verifier both for a
> corrupt example and a working example.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
