[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534998#comment-17534998 ] Josh McKenzie commented on CASSANDRA-17557: --- I need to update this script to check across all branches for a failure; all but test_dead_sync_participant are failing on trunk as well so should have a > 1 count on failures. test_dead_sync_participant looks like it might be flaky on 4.1 based on the butler data; strongly doubt it's related to this ticket; looks good on ASF infra relative to this work here. [CI Results] Branch: 4.1, build number: 14 butler url: [https://butler.cassandra.apache.org/#/ci/upstream/compare/Cassandra-4.1/Cassandra-4.1] jenkins url: [https://ci-cassandra.apache.org/job/Cassandra-4.1/14/] JIRA: CASSANDRA-17557 commit url: [https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=f57c8d2c25f3a7c2b845ad9205ad25a9b04cca34] affected paths: * src/java/org/apache/cassandra/service/StorageService.java * src/java/org/apache/cassandra/config/DatabaseDescriptor.java * CHANGES.txt * src/java/org/apache/cassandra/net/Verb.java * src/java/org/apache/cassandra/config/Config.java * src/java/org/apache/cassandra/service/StorageServiceMBean.java Build Result: UNSTABLE Passing Tests: 46901 Failing Tests: 8 ||Test|Failures|JIRA| |org.apache.cassandra.cql3.KeywordTest.test[keyword ROLES isReserved false]|2 of 12|CASSANDRA-17615?| |org.apache.cassandra.db.commitlog.CommitLogSegmentManagerCDCTest.testSwitchingCDCWriteModes|4 of 12|CASSANDRA-17542?| |org.apache.cassandra.cql3.KeywordTest.test[keyword CLUSTER isReserved false]|1 of 12|CASSANDRA-17615?| |org.apache.cassandra.transport.CQLConnectionTest.handleCorruptionOfLargeMessageFrame-cdc|3 of 12|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| |org.apache.cassandra.db.virtual.GossipInfoTableTest.testSelectAllWithStateTransitions-cdc|1 of 12|CASSANDRA-17584?| |dtest-offheap.auth_test.TestAuth.test_system_auth_ks_is_alterable|2 of 12|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestAuth*%22]| |dtest.repair_tests.repair_test.TestRepair.test_dead_sync_participant|1 of 12|[Multiple JIRAs found|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CASSANDRA%20and%20resolution%20%3D%20unresolved%20and%20summary%20~%20%22*TestRepair*%22]| |org.apache.cassandra.net.proxy.ProxyHandlerTest.testNormalDelivery-cdc|1 of 12|[No JIRA found|https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=496=2252]| > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1, 4.2 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534631#comment-17534631 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Committed: To https://github.com/apache/cassandra.git 89fbb1acf4..f57c8d2c25 cassandra-4.1 -> cassandra-4.1 9e49a2b21d..e0247d6833 trunk -> trunk > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x, 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534628#comment-17534628 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - There were new commits so I had to rerun CI but luckily there were only two flaky known tests failing on trunk, 4.1 all green. [trunk CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17557-trunk=all] [4.1 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17557-4.1=all] Starting commit > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x, 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534584#comment-17534584 ] Benedict Elliott Smith commented on CASSANDRA-17557: All sounds fine to me Ekaterina, thanks. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x, 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534357#comment-17534357 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - I just opened a ticket for _org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest_ before I forget - CASSANDRA-17618 > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534348#comment-17534348 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - *4.1 failures without trace in Jira or any CI:* _org.apache.cassandra.distributed.test.TopPartitionsTest:_ clean 4.1 - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1599/workflows/8bf42a23-dea8-4619-9eec-07d0910e7c67 patched 4.1 - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1600/workflows/e2d4d218-c984-419c-a57c-0395517338ba basicRangeTombstonesTest[Incremental] - It didn't manage to reproduce, I guess it is super rare and unrelated? configChangeTest[Incremental] - seems extremely rare, I managed to reproduce once in a blue moon -[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1599/workflows/8bf42a23-dea8-4619-9eec-07d0910e7c67/jobs/10902/tests] _org.apache.cassandra.distributed.test.InternodeEncryptionEnforcementTest:_ clean 4.1 - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1604/workflows/243a20a5-eda2-4c28-95e8-ab6c4f85a891 patched 4.1 - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1603/workflows/5f9e828b-5011-4253-8a0c-e1b32dfa1612] Seems like flaky test on the current 4.1 that requires a ticket. *trunk failures without trace in Jira or any CI:* _org.apache.cassandra.distributed.test.repair.ForceRepairTest:_ clean trunk - https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1598/workflows/95f834ba-fd64-41b9-8eb8-f5410cd012f9 patched trunk - [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1597/workflows/9da50b66-12a5-42b0-8449-6680e15b66e7] Managed to reproduce _forceWithDifference_ in the same class with the same error, there is a ticket opened for that one. Not 100% sure wether we can just link them. [~benedict] , please, let me know if you have any concerns around those failures or we can commit it. Thanks > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533918#comment-17533918 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Applied the patch to 4.1 and trunk and just submitted CI. Commit pending CI: [4.1|https://github.com/apache/cassandra/compare/cassandra-4.1...ekaterinadimitrova2:17557-4.1%C2%A0] | [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17557-4.1=all] [trunk|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:17557-trunk] | [CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=17557-trunk=all] > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530142#comment-17530142 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Ops, seems our comments crashed [~brandon.williams] :) > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530140#comment-17530140 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Well, freeze means to me no more API changes, that is what I was told. Otherwise, definitely no release before voting, etc. I am even personally not sure whether it will be alpha or beta, I guess we will get to know next week when discussions start :) I will try to run CI later and if it looks good (no new failures) commit if that is fine with you and [~bdeggleston] . Thanks for pushing the patch > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530139#comment-17530139 ] Brandon Williams commented on CASSANDRA-17557: -- The branch will be cut on the 1st, but that just makes it bugfix-only, and this ticket is a bug, so while I would strive to have these things squared away sooner, I think it's okay to wait in this instance too. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530131#comment-17530131 ] Benedict Elliott Smith commented on CASSANDRA-17557: There is no requirement to cut a release on the 1st, only the freeze (and, I think, branch creation) has been agreed to take effect then? I would think we would want to merge all known outstanding bug fixes beforehand anyway. But I don't really have a strong feeling either way. If it helps at all, I have pushed the necessary change Blake pointed out, so this patch is ready to commit modulo CI. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530119#comment-17530119 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - I don't think it is fair to delay it. What I can suggest is I commit now the removal of the unused parameter and then you can fix the bug around the other one as not an API change. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530115#comment-17530115 ] Benedict Elliott Smith commented on CASSANDRA-17557: Or the release can be delayed by a day. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530113#comment-17530113 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - I wish I knew that yesterday when we discussed you will check it with Blake and commit. I am swamped today and it will need final check before commit. CC [~mck] as he is planning to cut a branch around the 1st, for awareness. I hope it is not an issue that we will remove a not released parameter later. Otherwise, it will have to be deprecate it and keep it. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530069#comment-17530069 ] Benedict Elliott Smith commented on CASSANDRA-17557: Hi Ekaterina, I have a long weekend here, I'm afraid. I can get to this on Tuesday. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17530052#comment-17530052 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - [~benedict] if you two are aligned on the change around the second parameter, do you think you can take over to finish this, please? > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529523#comment-17529523 ] Benedict Elliott Smith commented on CASSANDRA-17557: 臘♂️ > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17529521#comment-17529521 ] Blake Eggleston commented on CASSANDRA-17557: - Gave this a look at Benedict's request. Everything looks fine except for the change to read repair timeouts. Since those are part of a client query, and aren't part of any repair process as intended by this patch, I think they should be reverted to writeTimeout. > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.1 > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527221#comment-17527221 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Did a quick skim, seems to me all are known failures. I will double check with their respective tickets on Monday > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526504#comment-17526504 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - Thanks, I rebased your branch and pushed a new CI run: [J8|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1566/workflows/393c8917-1d44-41be-afec-8ab6a97b7ede], [J11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1566/workflows/23ff50bf-a946-4097-b6d6-d624983c932c] - pending results, just started it. >From config perspective looks good, I guess for the Verb class change someone >more familiar with your latest work than me should say. [~barnie] or >[~ifesdjeen] maybe? > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525566#comment-17525566 ] Benedict Elliott Smith commented on CASSANDRA-17557: Thanks Ekaterina. I think there are two mistakes here in the original patch: the inclusion of an unnecessary property, and the failure to utilise a necessary property. The repair rpc timeout was intended to be kept, and utilised for both standard repair verbs and paxos repair verbs. I have pushed my suggested variation on this patch [here|https://github.com/belliottsmith/cassandra/commits/17557-trunk] > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17557) Fix a few config parameters after the Paxos improvements commit
[ https://issues.apache.org/jira/browse/CASSANDRA-17557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523440#comment-17523440 ] Ekaterina Dimitrova commented on CASSANDRA-17557: - [Trunk pach|https://github.com/apache/cassandra/compare/trunk...ekaterinadimitrova2:17557-trunk?expand=1] | [J8 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1548/workflows/72d0120b--44bd-b013-f7bc5eaf589c] | [j11 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1548/workflows/92fcf8f7-b9e3-41bf-b607-69f454709add] There was some issue with J11 on J8 unit tests, one container has failed but I cannot see what test failed and no results were stored, as it does normally. I reran the suite, and everything finished successfully [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1548/workflows/72d0120b--44bd-b013-f7bc5eaf589c/jobs/10100/steps]. The compression unit tests also have two failing containers without being able to identify which tests failed. Restarted [here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1548/workflows/72d0120b--44bd-b013-f7bc5eaf589c/jobs/10101] The rest of the failures are known ones: test_oversized_mutation - CASSANDRA-17456 utests_system_keyspace_directory - CASSANDRA-17489 I didn't run upgrade tests as those parameters were added as a patch committed only to trunk. [~benedict] , as agreed in Slack the other day, please, review :) > Fix a few config parameters after the Paxos improvements commit > --- > > Key: CASSANDRA-17557 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17557 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > After committing the Paxos improvements, it was identified that the following > configuration parameters need additional work: > * repair_request_timeout_in_ms - can be removed > * paxos_auto_repair_threshold_mb - I think it can be also removed; to be > confirmed with the author > Discussed a bit in Slack and on this PR - > https://github.com/apache/cassandra/commit/d2923275e360a1ee9db498e748c269f701bb3a8b -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
