[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679240#comment-17679240 ] Ekaterina Dimitrova commented on CASSANDRA-18139: - Oh wait, we didn't change the printed units in CASSANDRA-15234! They were already printed as TiB, MiB, etc changed in CASSANDRA-9692. Those are printed that way since 3.6 We changed in [this|https://github.com/apache/cassandra/commit/1315d0c96f4625a76296f58d431f97669e5178c2] and [this|https://github.com/apache/cassandra/commit/23138252f20891c26a3692664c6affaf99e86541] commits the constants ONE_KB to ONE_KIB etc. I do not believe that this is considered a breaking change, is it? We didn't change the nodetool output? [~ifesdjeen] did you actually refer to the constants? Is FileUtils considered API that will be used by tools? Is this documented? What do I miss? > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678787#comment-17678787 ] Ekaterina Dimitrova commented on CASSANDRA-18139: - Looking into the usages of this method - it is used in new and old commands, features. I think in new usages for 4.1 we should leave the change KB -> KiB etc I am thinking the safest way is to revert the changes made to stringifyFileSize and create a new stringifyFileSizeBinaryUnits method to be used with any new features - exceptions and trace logs for Guardrails for example. I will try to find time to create a patch later today or tomorrow. > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 4.x > > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17675650#comment-17675650 ] Caleb Rackliffe commented on CASSANDRA-18139: - bq. On the other hand flag or not we will break those people in a patch release. Not sure how many are those with new clusters using already that output though My two cents...probably few enough for it not to be an issue. +1 for a flag to opt-in to the new behavior > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Priority: Normal > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656316#comment-17656316 ] Ekaterina Dimitrova commented on CASSANDRA-18139: - I agree with your points. On the other hand after CASSANDRA-18139 I made some effort to get back and revert other units changes in nodetool output with the support of other community members, FileUtils#stringifyFileSize was an honest miss so if we revert in theory we should be consistent with the current nodetool state which should still have the old format of units in output. The reason I suggest a flag is for people who might have been using it in 4.1.0 already so they can switch to it at least. On the other hand flag or not we will break those people in a patch release. Not sure how many are those with new clusters using already that output though... considering we just released before Christmas. I am wondering if it makes sense to hit the dev and/or user list to gather some more feedback from people before moving forward one way or another. > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Priority: Normal > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656202#comment-17656202 ] Alex Petrov commented on CASSANDRA-18139: - Not sure if it's a good argument, but it could be that there's much more tooling that predates 4.1.0. I do agree that hiding it behind a flag is potentially a way to go. I'm mostly concerned that people will be hitting this as they upgrade, which may slow down adoption, but on the other hand if we hide it behind a flag there's a chance no-one will actually use the new feature. > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Priority: Normal > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656162#comment-17656162 ] Ekaterina Dimitrova commented on CASSANDRA-18139: - Maybe flags and option to print it also with the new format? It will still be a change but people will have some choice at least, maybe > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Priority: Normal > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
[ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656160#comment-17656160 ] Ekaterina Dimitrova commented on CASSANDRA-18139: - CC [~ifesdjeen] and [~dcapwell] This seems like a regression but it made me think... if someone started using it in 4.1.0, reverting will break them in this case so I am not sure what is the correct way to handle it... Seems to me reverting/not reverting, it will be a regression for someone in any case but at the same time 4.1.0 was recently released so I expect less people maybe affected. I have to think about it. > Revert changes to units output in FileUtils#stringifyFileSize post > CASSANDRA-15234 > -- > > Key: CASSANDRA-18139 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18139 > Project: Cassandra > Issue Type: Bug >Reporter: Ekaterina Dimitrova >Priority: Normal > > As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in > nodetool output which can break people parsing the nodetool output -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
