[GitHub] [cloudstack] blueorangutan removed a comment on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan removed a comment on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-466094673 Trillian test result (tid-3408) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35219 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3075-t3408-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_iso.py Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py Intermittent failure detected: /marvin/tests/smoke/test_templates.py Intermittent failure detected: /marvin/tests/smoke/test_volumes.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py Smoke tests completed. 63 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_Iso | `Failure` | 1.08 | test_iso.py test_05_stop_ssvm | `Error` | 941.09 | test_ssvm.py test_06_stop_cpvm | `Error` | 960.26 | test_ssvm.py test_07_reboot_ssvm | `Error` | 912.64 | test_ssvm.py test_08_reboot_cpvm | `Error` | 912.72 | test_ssvm.py test_04_extract_template | `Failure` | 1.08 | test_templates.py test_06_download_detached_volume | `Failure` | 11.43 | test_volumes.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.37 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan removed a comment on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan removed a comment on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-465891041 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (50869fe -> 4d9206a)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 50869fe Merge branch '4.12' add 41f569e router: Fix rule duplication with non-VPC static NAT rules (#3366) add 8fb388e router: support multi-homed VMs in VPC (#3373) add ff23131 Merge remote-tracking branch 'origin/4.11' into 4.12 new 4d9206a Merge remote-tracking branch 'origin/4.12' The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../main/java/com/cloud/network/element/VirtualRouterElement.java | 1 + systemvm/debian/opt/cloud/bin/configure.py| 8 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py| 8 +++- systemvm/debian/opt/cloud/bin/cs_dhcp.py | 5 - 4 files changed, 8 insertions(+), 14 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.12'
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 4d9206aef57051e545178dd53e6070dec2b6527a Merge: 50869fe ff23131 Author: Rohit Yadav AuthorDate: Wed Jun 5 10:06:08 2019 +0530 Merge remote-tracking branch 'origin/4.12' .../main/java/com/cloud/network/element/VirtualRouterElement.java | 1 + systemvm/debian/opt/cloud/bin/configure.py| 8 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py| 8 +++- systemvm/debian/opt/cloud/bin/cs_dhcp.py | 5 - 4 files changed, 8 insertions(+), 14 deletions(-)
[cloudstack] 01/01: Merge remote-tracking branch 'origin/4.11' into 4.12
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ff23131701f493928b303cde484677249825ab41 Merge: bea627a 8fb388e Author: Rohit Yadav AuthorDate: Wed Jun 5 10:00:45 2019 +0530 Merge remote-tracking branch 'origin/4.11' into 4.12 Signed-off-by: Rohit Yadav .../main/java/com/cloud/network/element/VirtualRouterElement.java | 1 + systemvm/debian/opt/cloud/bin/configure.py| 8 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py| 8 +++- systemvm/debian/opt/cloud/bin/cs_dhcp.py | 5 - 4 files changed, 8 insertions(+), 14 deletions(-) diff --cc server/src/main/java/com/cloud/network/element/VirtualRouterElement.java index a6a4e0a,000..b78dcfd mode 100644,00..100644 --- a/server/src/main/java/com/cloud/network/element/VirtualRouterElement.java +++ b/server/src/main/java/com/cloud/network/element/VirtualRouterElement.java @@@ -1,1343 -1,0 +1,1344 @@@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +package com.cloud.network.element; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import javax.inject.Inject; + +import org.apache.commons.collections.CollectionUtils; +import org.apache.log4j.Logger; +import org.cloud.network.router.deployment.RouterDeploymentDefinition; +import org.cloud.network.router.deployment.RouterDeploymentDefinitionBuilder; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.beans.factory.annotation.Qualifier; + +import com.google.gson.Gson; + +import org.apache.cloudstack.api.command.admin.router.ConfigureOvsElementCmd; +import org.apache.cloudstack.api.command.admin.router.ConfigureVirtualRouterElementCmd; +import org.apache.cloudstack.api.command.admin.router.CreateVirtualRouterElementCmd; +import org.apache.cloudstack.api.command.admin.router.ListOvsElementsCmd; +import org.apache.cloudstack.api.command.admin.router.ListVirtualRouterElementsCmd; +import org.apache.cloudstack.framework.config.dao.ConfigurationDao; +import org.apache.cloudstack.network.topology.NetworkTopology; +import org.apache.cloudstack.network.topology.NetworkTopologyContext; + +import com.cloud.agent.api.to.LoadBalancerTO; +import com.cloud.configuration.ConfigurationManager; +import com.cloud.dc.DataCenter; +import com.cloud.dc.DataCenter.NetworkType; +import com.cloud.dc.DataCenterVO; +import com.cloud.dc.dao.DataCenterDao; +import com.cloud.deploy.DeployDestination; +import com.cloud.exception.ConcurrentOperationException; +import com.cloud.exception.InsufficientCapacityException; +import com.cloud.exception.InvalidParameterValueException; +import com.cloud.exception.ResourceUnavailableException; +import com.cloud.host.dao.HostDao; +import com.cloud.hypervisor.Hypervisor.HypervisorType; +import com.cloud.network.Network; +import com.cloud.network.Network.Capability; +import com.cloud.network.Network.Provider; +import com.cloud.network.Network.Service; +import com.cloud.network.NetworkMigrationResponder; +import com.cloud.network.NetworkModel; +import com.cloud.network.Networks; +import com.cloud.network.Networks.TrafficType; +import com.cloud.network.OvsProvider; +import com.cloud.network.PhysicalNetworkServiceProvider; +import com.cloud.network.PublicIpAddress; +import com.cloud.network.RemoteAccessVpn; +import com.cloud.network.VirtualRouterProvider; +import com.cloud.network.VirtualRouterProvider.Type; +import com.cloud.network.VpnUser; +import com.cloud.network.as.AutoScaleCounter; +import com.cloud.network.as.AutoScaleCounter.AutoScaleCounterType; +import com.cloud.network.dao.IPAddressDao; +import com.cloud.network.dao.LoadBalancerDao; +import com.cloud.network.dao.NetworkDao; +import com.cloud.network.dao.NetworkDetailVO; +import com.cloud.network.dao.NetworkDetailsDao; +import com.cloud.network.dao.OvsProviderDao; +import com.cloud.network.dao.VirtualRouterProviderDao; +import com.cloud.network.lb.LoadBalancingRule;
[cloudstack] branch 4.12 updated (bea627a -> ff23131)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from bea627a Merge branch '4.11' into 4.12 add 41f569e router: Fix rule duplication with non-VPC static NAT rules (#3366) add 8fb388e router: support multi-homed VMs in VPC (#3373) new ff23131 Merge remote-tracking branch 'origin/4.11' into 4.12 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../main/java/com/cloud/network/element/VirtualRouterElement.java | 1 + systemvm/debian/opt/cloud/bin/configure.py| 8 systemvm/debian/opt/cloud/bin/cs/CsDhcp.py| 8 +++- systemvm/debian/opt/cloud/bin/cs_dhcp.py | 5 - 4 files changed, 8 insertions(+), 14 deletions(-)
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating keystore on provisionCertificate API
rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating
keystore on provisionCertificate API
URL: https://github.com/apache/cloudstack/pull/3075#discussion_r290569474
##
File path: scripts/util/keystore-cert-import
##
@@ -38,9 +38,6 @@ if [ -z "${KS_PASS// }" ]; then
exit 1
fi
-# Use a new keystore file
-NEW_KS_FILE="$KS_FILE.new"
Review comment:
I'll also need to test for certificate renewal.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating keystore on provisionCertificate API
rhtyd commented on a change in pull request #3075: KVM: Prevent regenerating
keystore on provisionCertificate API
URL: https://github.com/apache/cloudstack/pull/3075#discussion_r290569265
##
File path: scripts/util/keystore-cert-import
##
@@ -38,9 +38,6 @@ if [ -z "${KS_PASS// }" ]; then
exit 1
fi
-# Use a new keystore file
-NEW_KS_FILE="$KS_FILE.new"
Review comment:
The script was create to be idempotent for jks creation and cert import.
I'll have to test concurrent cases and see if this script would pass/fail. I'll
test and review today and keep you posted @nvazquez thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-498923949 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2844 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3273: VR DHCP VPC multihomed VM broken
rhtyd closed issue #3273: VR DHCP VPC multihomed VM broken URL: https://github.com/apache/cloudstack/issues/3273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: router: support multi-homed VMs in VPC (#3373)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 8fb388e router: support multi-homed VMs in VPC (#3373)
8fb388e is described below
commit 8fb388e9312b917a8f36c7d7e3f45985a95ce773
Author: Rohit Yadav
AuthorDate: Wed Jun 5 08:47:05 2019 +0530
router: support multi-homed VMs in VPC (#3373)
This does not remove VM entries in dbags when hostnames match. The
current codebase already removes entry when a VM is stopped/removed so
we don't need to handle lazy removal. This will allow a VM on
multiple-tiers in a VPC to get dns/dhcp rules as expected.
This also fixes the issue of dhcp_release based on a specific interface and
removes dhcp/dns entry when a nic is removed on a guest VM.
Fixes #3273
Signed-off-by: Rohit Yadav
---
server/src/com/cloud/network/element/VirtualRouterElement.java | 1 +
systemvm/debian/opt/cloud/bin/cs/CsDhcp.py | 8 +++-
systemvm/debian/opt/cloud/bin/cs_dhcp.py | 5 -
3 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/server/src/com/cloud/network/element/VirtualRouterElement.java
b/server/src/com/cloud/network/element/VirtualRouterElement.java
index 11a553c..a854d14 100644
--- a/server/src/com/cloud/network/element/VirtualRouterElement.java
+++ b/server/src/com/cloud/network/element/VirtualRouterElement.java
@@ -895,6 +895,7 @@ NetworkMigrationResponder, AggregatedCommandExecutor,
RedundantResource, DnsServ
@Override
public boolean release(final Network network, final NicProfile nic, final
VirtualMachineProfile vm, final ReservationContext context) throws
ConcurrentOperationException,
ResourceUnavailableException {
+removeDhcpEntry(network, nic, vm);
return true;
}
diff --git a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
index 6ea9174..e7abb90 100755
--- a/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
+++ b/systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
@@ -118,7 +118,6 @@ class CsDhcp(CsDataBag):
def delete_leases(self):
macs_dhcphosts = []
-interfaces = filter(lambda x: x.startswith('eth'),
os.listdir('/sys/class/net'))
try:
logging.info("Attempting to delete entries from dnsmasq.leases
file for VMs which are not on dhcphosts file")
for host in open(DHCP_HOSTS):
@@ -130,10 +129,9 @@ class CsDhcp(CsDataBag):
mac = lease[1]
ip = lease[2]
if mac not in macs_dhcphosts:
-for interface in interfaces:
-cmd = "dhcp_release %s %s %s" % (interface, ip, mac)
-logging.info(cmd)
-CsHelper.execute(cmd)
+cmd = "dhcp_release $(ip route get %s | grep eth | head -1
| awk '{print $3}') %s %s" % (ip, ip, mac)
+logging.info(cmd)
+CsHelper.execute(cmd)
removed = removed + 1
self.del_host(ip)
logging.info("Deleted %s entries from dnsmasq.leases file" %
str(removed))
diff --git a/systemvm/debian/opt/cloud/bin/cs_dhcp.py
b/systemvm/debian/opt/cloud/bin/cs_dhcp.py
index 735f847..bb2ff7b 100755
--- a/systemvm/debian/opt/cloud/bin/cs_dhcp.py
+++ b/systemvm/debian/opt/cloud/bin/cs_dhcp.py
@@ -28,11 +28,6 @@ def merge(dbag, data):
else:
remove_keys = set()
for key, entry in dbag.iteritems():
-if key != 'id' and entry['host_name'] == data['host_name']:
-remove_keys.add(key)
-break
-
-for key, entry in dbag.iteritems():
if key != 'id' and entry['mac_address'] == data['mac_address']:
remove_keys.add(key)
break
[GitHub] [cloudstack] rhtyd merged pull request #3373: router: support multi-homed VMs in VPC
rhtyd merged pull request #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3273: VR DHCP VPC multihomed VM broken
rhtyd commented on issue #3273: VR DHCP VPC multihomed VM broken URL: https://github.com/apache/cloudstack/issues/3273#issuecomment-498923528 Fixed and merged in https://github.com/apache/cloudstack/pull/3373 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3373: router: support multi-homed VMs in VPC
rhtyd commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498923328 Thanks @nvazquez and @ustcweizhou I'll merge this based on the latest test results and reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-498920704 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #3374: KVM: Enhancements for direct download feature
nvazquez opened a new pull request #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374 ## Description Extend improvements on PR #2995 and #3075 - Add an API method to revoke certificates from hosts - Add a background task to sync missing certificates to hosts (which for some reason could not be uploaded before) ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3374: KVM: Enhancements for direct download feature
nvazquez commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-498920622 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498914407 Trillian test result (tid-3644) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27722 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3373-t3644-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] falcon78921 edited a comment on issue #3195: Python 3 compatibility
falcon78921 edited a comment on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-498865598 @rhtyd @wido I would love to help with moving over to Python 3, if that's still the plan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] falcon78921 commented on issue #3195: Python 3 compatibility
falcon78921 commented on issue #3195: Python 3 compatibility URL: https://github.com/apache/cloudstack/issues/3195#issuecomment-498865598 @rhytd @wido I would love to help with moving over to Python 3, if that's still the plan. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498855154 Trillian test result (tid-3642) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 32057 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3373-t3642-kvm-centos7.zip Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py Smoke tests completed. 68 look OK, 1 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Failure` | 945.70 | test_privategw_acl.py This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3373: router: support multi-homed VMs in VPC
ustcweizhou commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498849991 code LGTM did not test it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] ustcweizhou commented on issue #3366: Fix rule duplication with static NAT rules
ustcweizhou commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498844958 I was just testing it. it works fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: router: Fix rule duplication with non-VPC static NAT rules (#3366)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 41f569e router: Fix rule duplication with non-VPC static NAT rules
(#3366)
41f569e is described below
commit 41f569e8a853cb4503646d06cadc4c9c1aea82b2
Author: Richard Lawley
AuthorDate: Tue Jun 4 21:51:03 2019 +0100
router: Fix rule duplication with non-VPC static NAT rules (#3366)
The VR code has provision for inserting rules at the top or bottom by
specifying "front" as the second parameter to self.fw.append. However, there
are a number of cases where someone has been unaware of this and added a rule
with the pattern self.fw.append(["mangle", "", "-I PREROUTING" This causes
the code to check for the rule already being present to fail, and duplicate
rules end up being added.
This PR fixes two of these cases which apply to adding static NAT rules. I
am aware of more of these cases, but I don't have the ability to easily test
the outcome of fixing them. I'm happy to add these in if you're confident that
the automated tests will be sufficient. Searching for "-I (case sensitive)
finds these.
The code for dealing with "front" is included below to show that this
shouldn't have any ill effects:
if fw[1] == "front":
cpy = cpy.replace('-A', '-I')
Fixes #3177
---
systemvm/debian/opt/cloud/bin/configure.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/systemvm/debian/opt/cloud/bin/configure.py
b/systemvm/debian/opt/cloud/bin/configure.py
index 4df9911..a7f297e 100755
--- a/systemvm/debian/opt/cloud/bin/configure.py
+++ b/systemvm/debian/opt/cloud/bin/configure.py
@@ -922,11 +922,11 @@ class CsForwardingRules(CsDataBag):
if device is None:
raise Exception("Ip address %s has no device in the ips databag" %
rule["public_ip"])
-self.fw.append(["mangle", "",
-"-I PREROUTING -s %s/32 -m state --state NEW -j
CONNMARK --save-mark --nfmask 0x --ctmask 0x" %
+self.fw.append(["mangle", "front",
+"-A PREROUTING -s %s/32 -m state --state NEW -j
CONNMARK --save-mark --nfmask 0x --ctmask 0x" %
rule["internal_ip"]])
-self.fw.append(["mangle", "",
-"-I PREROUTING -s %s/32 -m state --state NEW -j MARK
--set-xmark %s/0x" %
+self.fw.append(["mangle", "front",
+"-A PREROUTING -s %s/32 -m state --state NEW -j MARK
--set-xmark %s/0x" %
(rule["internal_ip"], hex(100 +
int(device[len("eth"):])))])
self.fw.append(["nat", "front",
"-A PREROUTING -d %s/32 -j DNAT --to-destination %s" %
(rule["public_ip"], rule["internal_ip"])])
[GitHub] [cloudstack] rhtyd closed issue #3177: Static NAT causes duplicate firewall rules to be added
rhtyd closed issue #3177: Static NAT causes duplicate firewall rules to be added URL: https://github.com/apache/cloudstack/issues/3177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3177: Static NAT causes duplicate firewall rules to be added
rhtyd commented on issue #3177: Static NAT causes duplicate firewall rules to be added URL: https://github.com/apache/cloudstack/issues/3177#issuecomment-498838829 Merged in https://github.com/apache/cloudstack/pull/3366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3366: Fix rule duplication with static NAT rules
rhtyd merged pull request #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules
blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498836075 Trillian test result (tid-3641) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 29513 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3366-t3641-kvm-centos7.zip Smoke tests completed. 69 look OK, 0 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498816770 @rhtyd this is ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498816251 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
nvazquez commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498815882 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API
blueorangutan commented on issue #3075: KVM: Prevent regenerating keystore on provisionCertificate API URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498814310 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates
blueorangutan commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498807829 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates
nvazquez commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498807491 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498784858 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3373: router: support multi-homed VMs in VPC
nvazquez commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498784751 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498778124 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498770930 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez commented on issue #3373: router: support multi-homed VMs in VPC
nvazquez commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498770854 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2983: WIP: KVM live storage migration intra cluster from NFS source and destination
rhtyd commented on issue #2983: WIP: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983#issuecomment-498734754 @nvazquez is this ready for review/merging? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] nvazquez opened a new pull request #2983: WIP: KVM live storage migration intra cluster from NFS source and destination
nvazquez opened a new pull request #2983: WIP: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983 ## Description Feature Specification: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=95653548 Live storage migration on KVM under these conditions: - From source and destination hosts within the same cluster - From NFS primary storage to NFS cluster-wide primary storage - Source NFS and destination NFS storage mounted on hosts In order to enable this functionality, database should be updated in order to enable live storage capacibilty for KVM, if previous conditions are met. This is due to existing conflicts between qemu and libvirt versions. This has been tested on CentOS 6 hosts. Additional notes: 1. To use this feature set the `storage_motion_supported=1` in the hypervisor_capability table for KVM. This is done by default as the feature may not work in some environments, read below. 2. This feature of online storage+VM migration for KVM will only work with CentOS6 and possible Ubuntu as KVM hosts but not with CentOS7 due to: - https://bugs.centos.org/view.php?id=14026 - https://bugzilla.redhat.com/show_bug.cgi?id=1219541 On CentOS7 the error we see is: `" error: unable to execute QEMU command 'migrate': this feature or command is not currently supported"` (reference https://ask.openstack.org/en/question/94186/live-migration-unable-to-execute-qemu-command-migrate/). Reading through various lists looks like the migrate feature with qemu may be available with paid versions of RHEL-EV but not centos7 however this works with CentOS6. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [x] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? Tested on environment having 2 KVM CentOS 6 hosts. Note: CentOS 7 hosts report an issue around qemu version: `org.libvirt.LibvirtException: internal error: unable to execute QEMU command 'migrate': this feature or command is not currently supported` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #2983: WIP: KVM live storage migration intra cluster from NFS source and destination
rhtyd closed pull request #2983: WIP: KVM live storage migration intra cluster from NFS source and destination URL: https://github.com/apache/cloudstack/pull/2983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #2913: Deactivate ehcache
rhtyd commented on issue #2913: Deactivate ehcache URL: https://github.com/apache/cloudstack/pull/2913#issuecomment-498733887 I'm in favour of merging this as the ehcache does not work with currently CloudStack at all, all queries end up on the mysql server. What do others think - @wido @rafaelweingartner @DaanHoogland ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3373: router: support multi-homed VMs in VPC
rhtyd commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498731089 Thanks for testing and reviewing @nvazquez - it's likely that when nic is removed the rules are not removed from the VR. I'll test and try to fix the case you've found tomorrow. Cheers! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier edited a comment on issue #3294: Set default service offering over api and ui
pbankonier edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus I looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. The global settings are just used to check if there is already an offering with the given id existing in the database. There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced. There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings do nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] pbankonier commented on issue #3294: Set default service offering over api and ui
pbankonier commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498716577 @svenvogel @DennisKonrad @rafaelweingartner @PaulAngus looked into the code for the global default offering settings and found that the only place where this global config variables are used is in the ManagerImpls for the different offering types. The global settings are just used to check if there is already an offering with the given id existing in the database. There is no code which sets an offering to a default one with this configs. So maybe this was implemented to prevent that a new default offering was created at the start of the application before the uniquenames were introduced. There is no need for a migration path with this PR. There will be no changes which will break existing functionality. After my analysis the global default settings do nothing in the current state of the software and we can remove them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498697729 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] gmueller-ewerk commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC
gmueller-ewerk commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-498689127 @DaanHoogland I'm already working on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
blueorangutan commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498689049 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498688681 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC
DaanHoogland commented on issue #3186: [WIP DO NOT MERGE] Add possibility to set KVM MTU size for NIC URL: https://github.com/apache/cloudstack/pull/3186#issuecomment-498688504 @gmueller-ewerk new conflicts, sorry. can you please resolve them? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command
DaanHoogland commented on issue #3297: Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-498682996 This may not be on your PR @anuragaw, but since it is both tag related better look at it anyway: test_15_project_tag is failing! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498680738 > @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498680738 > @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel removed a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498680084 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498680084 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498679582 @rhtyd can you rekick a test for me? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rafaelweingartner commented on issue #3294: Set default service offering over api and ui
rafaelweingartner commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-498671734 @svenvogel can you describe how this migration path would work for people that are currently using the "configurations" table when they start to use the code introduced by this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch master updated (3e4c55c -> 50869fe)
This is an automated email from the ASF dual-hosted git repository.
nvazquez pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 3e4c55c Merge remote-tracking branch 'origin/4.12'
add 12c850e KVM: Improvements on upload direct download certificates
(#2995)
add 42501ce ssvm: apply MTU value on storage/management nic if available
(#3370)
add c94ee14 kvm: suspend a VM before snapshot deletion (see PR #3193)
(#3194)
add bea627a Merge branch '4.11' into 4.12
new 50869fe Merge branch '4.12'
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
agent/src/main/java/com/cloud/agent/Agent.java | 28 ---
...ploadTemplateDirectDownloadCertificateCmd.java} | 182 +
... => SetupDirectDownloadCertificateCommand.java} | 4 +-
...tupDirectDownloadCertificateCommandWrapper.java | 136
.../com/cloud/server/ManagementServerImpl.java | 4 +-
.../direct/download/DirectDownloadManagerImpl.java | 76 ++-
.../download/DirectDownloadManagerImplTest.java| 33 +++
test/integration/smoke/test_direct_download.py | 227 +
ui/l10n/en.js | 2 +-
9 files changed, 562 insertions(+), 130 deletions(-)
rename
api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/{UploadTemplateDirectDownloadCertificate.java
=> UploadTemplateDirectDownloadCertificateCmd.java} (93%)
mode change 100644 => 100755
rename
core/src/main/java/org/apache/cloudstack/agent/directdownload/{SetupDirectDownloadCertificate.java
=> SetupDirectDownloadCertificateCommand.java} (89%)
create mode 100644
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtSetupDirectDownloadCertificateCommandWrapper.java
create mode 100644 test/integration/smoke/test_direct_download.py
[cloudstack] 01/01: Merge branch '4.12'
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 50869fec9208a8973d59e5d5831e241c50923646 Merge: 3e4c55c bea627a Author: nvazquez AuthorDate: Tue Jun 4 09:49:39 2019 -0300 Merge branch '4.12' agent/src/main/java/com/cloud/agent/Agent.java | 28 --- ...ploadTemplateDirectDownloadCertificateCmd.java} | 182 + ... => SetupDirectDownloadCertificateCommand.java} | 4 +- ...tupDirectDownloadCertificateCommandWrapper.java | 136 .../com/cloud/server/ManagementServerImpl.java | 4 +- .../direct/download/DirectDownloadManagerImpl.java | 76 ++- .../download/DirectDownloadManagerImplTest.java| 33 +++ test/integration/smoke/test_direct_download.py | 227 + ui/l10n/en.js | 2 +- 9 files changed, 562 insertions(+), 130 deletions(-)
[cloudstack] branch 4.12 updated (3f2399f -> bea627a)
This is an automated email from the ASF dual-hosted git repository.
nvazquez pushed a change to branch 4.12
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 3f2399f server: Fix forward merge missing import causing build failure
add 12c850e KVM: Improvements on upload direct download certificates
(#2995)
add 42501ce ssvm: apply MTU value on storage/management nic if available
(#3370)
add c94ee14 kvm: suspend a VM before snapshot deletion (see PR #3193)
(#3194)
new bea627a Merge branch '4.11' into 4.12
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
agent/src/main/java/com/cloud/agent/Agent.java | 28 ---
...ploadTemplateDirectDownloadCertificateCmd.java} | 182 +
... => SetupDirectDownloadCertificateCommand.java} | 4 +-
...tupDirectDownloadCertificateCommandWrapper.java | 136
.../com/cloud/server/ManagementServerImpl.java | 4 +-
.../direct/download/DirectDownloadManagerImpl.java | 76 ++-
.../download/DirectDownloadManagerImplTest.java| 33 +++
test/integration/smoke/test_direct_download.py | 227 +
ui/l10n/en.js | 2 +-
9 files changed, 562 insertions(+), 130 deletions(-)
rename
api/src/main/java/org/apache/cloudstack/api/command/admin/direct/download/{UploadTemplateDirectDownloadCertificate.java
=> UploadTemplateDirectDownloadCertificateCmd.java} (93%)
mode change 100644 => 100755
rename
core/src/main/java/org/apache/cloudstack/agent/directdownload/{SetupDirectDownloadCertificate.java
=> SetupDirectDownloadCertificateCommand.java} (89%)
create mode 100644
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtSetupDirectDownloadCertificateCommandWrapper.java
create mode 100644 test/integration/smoke/test_direct_download.py
[GitHub] [cloudstack] rhtyd commented on issue #3373: router: support multi-homed VMs in VPC
rhtyd commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498648166 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498648235 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498647661 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3372: Add to listRouters response the scriptsversion
blueorangutan commented on issue #3372: Add to listRouters response the scriptsversion URL: https://github.com/apache/cloudstack/pull/3372#issuecomment-498645630 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on a change in pull request #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command
anuragaw commented on a change in pull request #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#discussion_r290263718 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java ## @@ -203,6 +203,10 @@ @Parameter(name = ApiConstants.EXTRA_CONFIG, type = CommandType.STRING, since = "4.12", description = "an optional URL encoded string that can be passed to the virtual machine upon successful deployment", length = 5120) private String extraConfig; +@Parameter(name = "copyimagetagstovm", type = CommandType.BOOLEAN, description = "if true we copy the image tags to the deployed Vm; defaulted to false if not specified") +private Boolean copyImageTagsToVm; + + Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules
blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498641121 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3366: Fix rule duplication with static NAT rules
rhtyd commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498640802 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd edited a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd edited a comment on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498640405 @svenvogel to setup a dev-test env; If you're on Mac/Windows, the basic process is to setup a VM that has a hypervisor (such as KVM, XenServer or VMware) with its own private/host network with a NAT and setup the host, storage on the system. If you're on Linux you can use https://github.com/rhtyd/monkeybox I would encourage that you validate, iterate and test your changes on a local env, as the changes in the file still remove flags from the script and can potentially fail the env deployment again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
rhtyd commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498640405 @svenvogel to setup a dev-test env; If you're on Mac/Windows, the basic process is to setup a VM with its own private/host network with a NAT and setup the host, storage on the system. If you're on Linux you can use https://github.com/rhtyd/monkeybox I would encourage that you validate, iterate and test your changes on a local env, as the changes in the file still remove flags from the script and can potentially fail the env deployment again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3373: router: support multi-homed VMs in VPC
rhtyd commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498639503 Can you help review this - @ustcweizhou @shwstppr @anuragaw, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC
blueorangutan commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498639334 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3373: router: support multi-homed VMs in VPC
rhtyd commented on issue #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373#issuecomment-498639209 To test it, I deployed a VM with a VPC with two tiers. By adding two nics on the VPC's tier1 and tier2, I could confirm that VM gets dhcp/dns rules:  Outputs from the VPC VR: ``` root@r-3-VM:/opt/cloud/bin# cat /etc/dhcphosts.txt 02:00:3e:91:00:04,set:10_21_2_53,10.21.2.53,VM-91dd442b-d87f-482c-889f-76e6da5bae17,750h 02:00:7d:b9:00:05,10.21.1.175,VM-91dd442b-d87f-482c-889f-76e6da5bae17,735h root@r-3-VM:/opt/cloud/bin# cat /etc/hosts ff02::1 ip6-allnodes ff02::2 ip6-allrouters 10.21.1.175 VM-91dd442b-d87f-482c-889f-76e6da5bae17 ::1 localhost ip6-localhost ip6-loopback 10.21.2.53 VM-91dd442b-d87f-482c-889f-76e6da5bae17 127.0.0.1 localhost r-3-VM root@r-3-VM:/opt/cloud/bin# cat /var/lib/misc/dnsmasq.leases 1562348805 02:00:3e:91:00:04 10.21.2.53 VM-91dd442b-d87f-482c-889f-76e6da5bae17 * 1562294389 02:00:7d:b9:00:05 10.21.1.175 * 01:02:00:7d:b9:00:05 ``` @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd opened a new pull request #3373: router: support multi-homed VMs in VPC
rhtyd opened a new pull request #3373: router: support multi-homed VMs in VPC URL: https://github.com/apache/cloudstack/pull/3373 This does not remove VM entries in dbags when hostnames match. The current codebase already removes entry when a VM is stopped/removed so we don't need to handle lazy removal. This will allow a VM on multiple-tiers in a VPC to get dns/dhcp rules as expected. This also fixes the issue of dhcp_release based on a specific interface. Fixes #3273 ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3372: Add to listRouters response the scriptsversion
blueorangutan commented on issue #3372: Add to listRouters response the scriptsversion URL: https://github.com/apache/cloudstack/pull/3372#issuecomment-498636394 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw commented on issue #3372: Add to listRouters response the scriptsversion
anuragaw commented on issue #3372: Add to listRouters response the scriptsversion URL: https://github.com/apache/cloudstack/pull/3372#issuecomment-498636074 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] anuragaw opened a new pull request #3372: Add to listRouters response the scriptsversion
anuragaw opened a new pull request #3372: Add to listRouters response the scriptsversion URL: https://github.com/apache/cloudstack/pull/3372 Add missing scriptsversion field to list router api call response. Fixes: #3357 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498632771 @rhtyd how can i test it by self with "@blue"? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3273: VR DHCP VPC multihomed VM broken
rhtyd commented on issue #3273: VR DHCP VPC multihomed VM broken URL: https://github.com/apache/cloudstack/issues/3273#issuecomment-498630239 Reproduced on latest 4.11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules
blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498627631 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2838 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh
svenvogel commented on issue #3371: Fix template size for managed storage / refactor cloud-install-sys-tmplt and createtmplt.sh URL: https://github.com/apache/cloudstack/pull/3371#issuecomment-498626344 @rhtyd @syed thanks for help. i will introduce a flag for managed storage and revert the necessary changes back for createtemplt.sh script. after that there should be not a problem. after that we can run the next test. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3366: Fix rule duplication with static NAT rules
rhtyd commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498622614 Nevermind I compared your changes with what Jayapal was trying to do, LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3366: Fix rule duplication with static NAT rules
rhtyd commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498622455 Thanks for the PR @richardlawley - do you think it can cause regression when the VR has multiple public IPs (i.e multiple public nics) as this reverts changes from https://github.com/apache/cloudstack/commit/40d77460386342126fb5533a9139bf6d08137d1d This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules
blueorangutan commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498621720 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3366: Fix rule duplication with static NAT rules
rhtyd commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498621704 Can you review this - @ustcweizhou @anuragaw @shwstppr ? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] richardlawley opened a new pull request #3366: Fix rule duplication with static NAT rules
richardlawley opened a new pull request #3366: Fix rule duplication with static
NAT rules
URL: https://github.com/apache/cloudstack/pull/3366
## Description
The VR code has provision for inserting rules at the top or bottom by
specifying "front" as the second parameter to `self.fw.append`. However, there
are a number of cases where someone has been unaware of this and added a rule
with the pattern `self.fw.append(["mangle", "", "-I PREROUTING"...`. This
causes the code to check for the rule already being present to fail, and
duplicate rules end up being added.
This PR fixes two of these cases which apply to adding static NAT rules. I
am aware of more of these cases, but I don't have the ability to easily test
the outcome of fixing them. I'm happy to add these in if you're confident that
the automated tests will be sufficient. Searching for "-I (case sensitive)
finds these.
The [code for dealing with
"front"](https://github.com/apache/cloudstack/blob/master/systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py#L166)
is included below to show that this shouldn't have any ill effects:
~~~
if fw[1] == "front":
cpy = cpy.replace('-A', '-I')
~~~
Fixes: #3177
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
Local tests were performed (see #3177 for details of symptoms), and we have
had this fix deployed in production on advanced networks for a couple of months.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd removed a comment on issue #3366: Fix rule duplication with static NAT rules
rhtyd removed a comment on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498621358 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3366: Fix rule duplication with static NAT rules
rhtyd commented on issue #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366#issuecomment-498621358 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed pull request #3366: Fix rule duplication with static NAT rules
rhtyd closed pull request #3366: Fix rule duplication with static NAT rules URL: https://github.com/apache/cloudstack/pull/3366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3193: qcow2 images are being corrupted
rhtyd closed issue #3193: qcow2 images are being corrupted URL: https://github.com/apache/cloudstack/issues/3193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3193: qcow2 images are being corrupted
rhtyd commented on issue #3193: qcow2 images are being corrupted URL: https://github.com/apache/cloudstack/issues/3193#issuecomment-498617254 Merged in https://github.com/apache/cloudstack/pull/3194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3194: Suspending a VM before snapshot deletion (see PR #3193)
rhtyd merged pull request #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated: kvm: suspend a VM before snapshot deletion (see PR #3193) (#3194)
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new c94ee14 kvm: suspend a VM before snapshot deletion (see PR #3193)
(#3194)
c94ee14 is described below
commit c94ee1454d3ecdf1bf371fd18c8e3ec0631d3092
Author: Vladimir Melnik
AuthorDate: Tue Jun 4 13:34:45 2019 +0300
kvm: suspend a VM before snapshot deletion (see PR #3193) (#3194)
To make sure that a qemu2-image won't be corrupted by the snapshot deletion
procedure which is being performed after copying the snapshot to a secondary
store, I'd propose to put a VM in to suspended state.
Additional reference: https://bugzilla.redhat.com/show_bug.cgi?id=920020#c5
Fixes #3193
---
.../src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java | 6 ++
ui/l10n/en.js | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
index 36be2d3..53a2278 100644
---
a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
+++
b/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
@@ -996,6 +996,12 @@ public class KVMStorageProcessor implements
StorageProcessor {
primaryStore.getUuid());
if (state == DomainInfo.DomainState.VIR_DOMAIN_RUNNING &&
!primaryStorage.isExternalSnapshot()) {
final DomainSnapshot snap =
vm.snapshotLookupByName(snapshotName);
+try {
+vm.suspend();
+} catch(final Exception e) {
+s_logger.debug("Failed to suspend the VM: " + e);
+throw e;
+}
snap.delete(0);
/*
diff --git a/ui/l10n/en.js b/ui/l10n/en.js
index 86a8606..b9f3682 100644
--- a/ui/l10n/en.js
+++ b/ui/l10n/en.js
@@ -1922,7 +1922,7 @@ var dictionary = {"ICMP.code":"ICMP Code",
"message.action.take.snapshot":"Please confirm that you want to take a
snapshot of this volume.",
"message.action.unmanage.cluster":"Please confirm that you want to unmanage
the cluster.",
"message.action.vmsnapshot.create":"Please confirm that you want to take a
snapshot of this instance. Please notice that the instance will be paused
during the snapshoting, and resumed after snapshotting, if it runs on KVM.",
-"message.action.vmsnapshot.delete":"Please confirm that you want to delete
this VM snapshot.",
+"message.action.vmsnapshot.delete":"Please confirm that you want to delete
this VM snapshot. Please notice that the instance will be paused before the
snapshot deletion, and resumed after deletion, if it runs on KVM.",
"message.action.vmsnapshot.revert":"Revert VM snapshot",
"message.activate.project":"Are you sure you want to activate this project?",
"message.add.VPN.gateway":"Please confirm that you want to add a VPN Gateway",
[GitHub] [cloudstack] ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
ustcweizhou commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498616755 @rhtyd good lgtm now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193)
rhtyd commented on issue #3194: Suspending a VM before snapshot deletion (see PR #3193) URL: https://github.com/apache/cloudstack/pull/3194#issuecomment-498616612 Looks like it is already handled. The UI already says this:  I've updated the text for snapshot deletion confirmation. Will merge based on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates
rhtyd commented on issue #3075: [WIP]: Prevent regenerating keystore and add background task to upload certificates URL: https://github.com/apache/cloudstack/pull/3075#issuecomment-498615186 @nvazquez can you rebase and advise the latest state, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd closed issue #3369: MTU for storage interface on SSVM is not honored
rhtyd closed issue #3369: MTU for storage interface on SSVM is not honored URL: https://github.com/apache/cloudstack/issues/3369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3369: MTU for storage interface on SSVM is not honored
rhtyd commented on issue #3369: MTU for storage interface on SSVM is not honored URL: https://github.com/apache/cloudstack/issues/3369#issuecomment-498614818 Fixed and merged in https://github.com/apache/cloudstack/pull/3370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[cloudstack] branch 4.11 updated (12c850e -> 42501ce)
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 12c850e KVM: Improvements on upload direct download certificates (#2995) add 42501ce ssvm: apply MTU value on storage/management nic if available (#3370) No new revisions were added by this update. Summary of changes: .../resource/NfsSecondaryStorageResource.java | 25 ++ 1 file changed, 25 insertions(+)
[GitHub] [cloudstack] rhtyd merged pull request #3370: ssvm: apply MTU value on storage/management nic if available
rhtyd merged pull request #3370: ssvm: apply MTU value on storage/management nic if available URL: https://github.com/apache/cloudstack/pull/3370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
