[GitHub] rhtyd commented on issue #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC
rhtyd commented on issue #1981: CLOUDSTACK-9806: Nuage domain template selection per VPC URL: https://github.com/apache/cloudstack/pull/1981#issuecomment-329949973 @prashanthvarma can you see and fix CI failures? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
rhtyd commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-329949932 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API
rhtyd commented on issue #2242: CLOUDSTACK-9958:Include tags of resources in listUsageRecords API URL: https://github.com/apache/cloudstack/pull/2242#issuecomment-329949945 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
rhtyd commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-329949909 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
blueorangutan commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-329949948 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance
rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-329949923 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
blueorangutan commented on issue #2028: CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets URL: https://github.com/apache/cloudstack/pull/2028#issuecomment-329949944 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance
blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-329949946 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system
rhtyd commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system URL: https://github.com/apache/cloudstack/pull/2252#issuecomment-329949894 This is strictly scripts used in guest VMs, manual tests and reviews are requested. @remibergsma are you LGTM on this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329949835 @wido can you check/verify the failing libvirt tests? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329949842 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329949857 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2248: CLOUDSTACK-10056
rhtyd closed pull request #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056
rhtyd commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329949659 Test LGTM, merging now. Thanks @nathanejohnson This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
ulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.03 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.06 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.04 | test_hostha_simulator.py test_hostha_kvm_host_degraded | Skipped | 36.40 | test_hostha_kvm.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2248: CLOUDSTACK-10056
blueorangutan commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329846263 Trillian test result (tid-1512) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39474 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2248-t1512-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 60 look OK, 2 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 66.20 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 443.06 | test_privategw_acl.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.04 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.07 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.03 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.05 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.07 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.09 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.04 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.03 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.03 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.08 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.10 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on issue #2248: CLOUDSTACK-10056
GabrielBrascher commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329778911 Thanks @nathanejohnson. Code LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2248: CLOUDSTACK-10056
blueorangutan commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329693891 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056
rhtyd commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329693827 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2248: CLOUDSTACK-10056
blueorangutan commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329693744 Packaging result: ?centos6 ?centos7 ?debian. JID-1085 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329689764 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2248: CLOUDSTACK-10056
blueorangutan commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329689767 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329689641 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056
rhtyd commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329689595 LGTM, I'll kick one final test run and then we can merge based on test results. Thanks @nathanejohnson @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2248: CLOUDSTACK-10056
rhtyd commented on a change in pull request #2248: CLOUDSTACK-10056
URL: https://github.com/apache/cloudstack/pull/2248#discussion_r139069450
##
File path: server/src/com/cloud/vm/UserVmManagerImpl.java
##
@@ -3619,8 +3619,14 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
_vmDao.persist(vm);
for (String key : customParameters.keySet()) {
-//handle double byte strings.
-vm.setDetail(key,
Integer.toString(Integer.parseInt(customParameters.get(key;
+if( key.equalsIgnoreCase(VmDetailConstants.CPU_NUMBER) ||
+key.equalsIgnoreCase(VmDetailConstants.CPU_SPEED)
||
+key.equalsIgnoreCase(VmDetailConstants.MEMORY)) {
+// handle double byte strings.
+vm.setDetail(key,
Integer.toString(Integer.parseInt(customParameters.get(key;
+} else {
Review comment:
Fantastic thanks for fixing @nathanejohnson
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139068658 ## File path: test/integration/component/test_host.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __builtin__ import False +""" BVT tests for Hosts Test +""" + +# Import Local Modules +from marvin.codes import FAILED +from marvin.cloudstackTestCase import * +from marvin.cloudstackAPI import * +from marvin.lib.utils import * +from marvin.lib.base import * +from marvin.lib.common import * +from nose.plugins.attrib import attr +from marvin.sshClient import SshClient +import time +from time import sleep + +_multiprocess_shared_ = False + + +class TestHostHA(cloudstackTestCase): Review comment: @mrunalinikankariya please send a new PR with requested changes ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329688178 I reviewed the code, as @koushik-das mentioned further investigation may be needed to look into why hosts would not be accepted immediately. The solution might work, however, we may need further analysis. @mrunalinikankariya @SudharmaJain @yvsubhash @vedulasantosh JIRA ticket does not mention, can you comment which hypervisors/hosts you had seen this issue? It seems only direct agents such as xen, vmware resources may be affected, then indirect agents such as KVM (agents). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139067324 ## File path: test/integration/component/test_host.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __builtin__ import False +""" BVT tests for Hosts Test +""" + +# Import Local Modules +from marvin.codes import FAILED +from marvin.cloudstackTestCase import * +from marvin.cloudstackAPI import * +from marvin.lib.utils import * +from marvin.lib.base import * +from marvin.lib.common import * +from nose.plugins.attrib import attr +from marvin.sshClient import SshClient +import time +from time import sleep + +_multiprocess_shared_ = False + + +class TestHostHA(cloudstackTestCase): Review comment: @mrunalinikankariya the ping timeout/intervals are configurable to speed up wait time, also in the code you've put `wait_until(10,10` if this already passes then the test should run in likely 100seconds or less, that less than 10 minutes and qualifies the test to be put in smoke tests. I also see an outstanding comment from Koushik which was not answered. ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
mrunalinikankariya commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r139063678 ## File path: test/integration/component/test_host.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __builtin__ import False +""" BVT tests for Hosts Test +""" + +# Import Local Modules +from marvin.codes import FAILED +from marvin.cloudstackTestCase import * +from marvin.cloudstackAPI import * +from marvin.lib.utils import * +from marvin.lib.base import * +from marvin.lib.common import * +from nose.plugins.attrib import attr +from marvin.sshClient import SshClient +import time +from time import sleep + +_multiprocess_shared_ = False + + +class TestHostHA(cloudstackTestCase): Review comment: This test wait for management-server to be up and hence it takes long time to run. So this cannot be move to smoke tests ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nathanejohnson commented on issue #2248: CLOUDSTACK-10056
nathanejohnson commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329600465 @rthyd that sounds like a better approach. I'll get this updated ASAP This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329591545 Trillian test result (tid-1510) Environment: kvm-centos6 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35164 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1510-kvm-centos6.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_list_ids_parameter.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 57 look OK, 5 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 61.02 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 395.96 | test_privategw_acl.py test_05_iso_permissions | `Failure` | 0.05 | test_iso.py test_02_edit_iso | `Failure` | 0.14 | test_iso.py test_05_change_vm_ostype_restart | `Failure` | 16.17 | test_deploy_virtio_scsi_vm.py test_03_verify_libvirt_attach_disk | `Failure` | 10.88 | test_deploy_virtio_scsi_vm.py test_02_verify_libvirt_after_restart | `Failure` | 141.72 | test_deploy_virtio_scsi_vm.py test_01_verify_libvirt | `Failure` | 0.65 | test_deploy_virtio_scsi_vm.py ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_02_list_snapshots_with_removed_data_store | Skipped | 0.00 | test_snapshots.py test_01_snapshot_root_disk | Skipped | 0.00 | test_snapshots.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.04 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.04 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.02 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.02 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.02 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.03 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329473928 Packaging result: ?centos6 ?centos7 ?debian. JID-1084 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329473736 Packaging result: ?centos6 ?centos7 ?debian. JID-1083 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879584 ## File path: test/integration/component/test_host.py ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __builtin__ import False +""" BVT tests for Hosts Test +""" + +# Import Local Modules +from marvin.codes import FAILED +from marvin.cloudstackTestCase import * +from marvin.cloudstackAPI import * +from marvin.lib.utils import * +from marvin.lib.base import * +from marvin.lib.common import * +from nose.plugins.attrib import attr +from marvin.sshClient import SshClient +import time +from time import sleep + +_multiprocess_shared_ = False + + +class TestHostHA(cloudstackTestCase): Review comment: @mrunalinikankariya @harikrishna-patnala advise if this test can run rather quickly -- if so let's include them in smoke tests folder instead? Also, the PR has no test results/reports from this new test. ---- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After
restarting cloudstack-management , It takes time to connect hosts
URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879356
##
File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
##
@@ -991,7 +995,9 @@ public boolean updateState(Status oldStatus, Event event,
Status newStatus, Host
}
}
if (event.equals(Event.ManagementServerDown)) {
-ub.set(host, _pingTimeAttr, ((System.currentTimeMillis() >> 10) -
(10 * 60)));
+Float pingTimeout =
NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"), 2.5f);
Review comment:
@mrunalinikankariya please move towards using ConfigKeys, refactorings are
requested.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on a change in pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#discussion_r138879256 ## File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ## @@ -144,6 +146,8 @@ protected HostTransferMapDao _hostTransferDao; @Inject protected ClusterDao _clusterDao; +@Inject +private ConfigurationDao _configDao; Review comment: @mrunalinikankariya please re-submit a PR that uses a ConfigKey based approach than use direct read/manipulation based on `configDao`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
rhtyd commented on issue #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054#issuecomment-329467492 @harikrishna-patnala why was this PR merged without tests? This affects clustering of management servers and the code/commit was pushed after last BVT test results/reports, in which case a fresh test run would be been perfect. In future you or anyone may ping @borisstoyanov or I and we can help with reviewing and running tests. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2248: CLOUDSTACK-10056
rhtyd commented on issue #2248: CLOUDSTACK-10056 URL: https://github.com/apache/cloudstack/pull/2248#issuecomment-329466076 @bvbharat @bvbharatk comment please? @nathanejohnson can you change the implementation to restrict the double bye handling code to work only for details keys - `cpuNumber`, `cpuSpeed` and `memory`? For rest we should simply read the string value with no addtional transformations. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
blueorangutan commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465920 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type
rhtyd commented on issue #2246: CLOUDSTACK-10046 checksum validation for any java supported Digests-type URL: https://github.com/apache/cloudstack/pull/2246#issuecomment-329465744 @DaanHoogland @borisstoyanov @nvazquez we happy with the review, tests? @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id
rhtyd closed pull request #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
blueorangutan commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465465 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id
rhtyd commented on issue #2243: CLOUDSTACK-10019:template.properties has hardcoded id URL: https://github.com/apache/cloudstack/pull/2243#issuecomment-329465479 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID
rhtyd commented on issue #2238: [CLOUDSTACK-10053] Performance improvement: caching of NuageVsp ID URL: https://github.com/apache/cloudstack/pull/2238#issuecomment-329465338 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?
rhtyd closed pull request #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and? URL: https://github.com/apache/cloudstack/pull/2261 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and?
rhtyd commented on issue #2261: CLOUDSTACK-10068 - Fixing test_iso.py assertions are equating srt and? URL: https://github.com/apache/cloudstack/pull/2261#issuecomment-329465084 @borisstoyanov let's revisit if we've any future issues, merging this now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329464938 @wido @GabrielBrascher sure, I've already kicked a final test run with Trillian and centos6 boxes; I can merge as soon as the results come clean. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329461735 Ok, thanks! I added the label so that it can be merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329461603 I find it hard to believe a test failure is related to these changes. It doesn't change anything to the default behavior of the Agent. Still, I could be wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system
larstobi commented on issue #2252: CLOUDSTACK-10067: Fix a case where a user 'ro' or 'roo' exists on the system URL: https://github.com/apache/cloudstack/pull/2252#issuecomment-329455934 @GabrielBrascher Check! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852 How about the load balancer @bwsw ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
borisstoyanov commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329442852 How about the internal load balancer @bwsw ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts
harikrishna-patnala closed pull request #2054: CLOUDSTACK-9886 : After restarting cloudstack-management , It takes time to connect hosts URL: https://github.com/apache/cloudstack/pull/2054 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437500 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos6) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437377 @blueorangutan test centos7 kvm-centos6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329437124 Packaging result: ?centos6 ?centos7 ?debian. JID-1082 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329432167 @borisstoyanov okay I've rekicked the failing job, can you compare the test time take for each of the jobs and try to consolidate them (rearrange tests) such that each job may be completed in less or equal to 50 minutes? Some tests that run in 20-25 minutes are prime targets. The first job may be refactored to get more tests as well (that run quite quickly?). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430475 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329430510 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873
@borisstoyanov
```
sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud
-ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.3.66
/usr/local/cloud/systemvm/ssvm-check.sh |grep -e ERROR -e WARNING -e FAIL via
Host: 10.2.2.67} {returns: [u'WARNING: cannot ping DNS server', u'Tests
Complete. Look for ERROR or WARNING above.']}
paramiko.transport: DEBUG: EOF in transport thread
test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): DEBUG: SSVM script
output: [u'WARNING: cannot ping DNS server', u'Tests Complete. Look for ERROR
or WARNING above.']
test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): CRITICAL: FAILED:
test_07_reboot_ssvm: ['Traceback (most recent call last):\n', ' File
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n',
' File "/marvin/tests/smoke/test_ssvm.py", line 929, in test_07_reboot_ssvm\n
self.test_03_ssvm_internals()\n', ' File "/marvin/tests/smoke/test_ssvm.py",
line 449, in test_03_ssvm_internals\n"Check for warnings in tests"\n', '
File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n
assertion_func(first, second, msg=msg)\n', ' File
"/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: Check for warnings in
tests\n']
```
In test log before failure. I don't know if it's relevant to the case,
because If it affected it would affect on VM start, beacause external
specification doesn't change at all and default value for new parameter is 0,
so it doesn't affect on actual test results.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
wido commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329418016 Thanks @rhtyd I addressed @GaborApatiNagy his comment, the XML parser now skips the entry if the model is null or empty. We got back a invalid XML from libvirt then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329417873
@borisstoyanov
```
sshClient: DEBUG: {Cmd: ssh -i ~/.ssh/id_rsa.cloud
-ostricthostkeychecking=no -oUserKnownHostsFile=/dev/null -p 3922 169.254.3.66
/usr/local/cloud/systemvm/ssvm-check.sh |grep -e ERROR -e WARNING -e FAIL via
Host: 10.2.2.67} {returns: [u'WARNING: cannot ping DNS server', u'Tests
Complete. Look for ERROR or WARNING above.']}
paramiko.transport: DEBUG: EOF in transport thread
test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): DEBUG: SSVM script
output: [u'WARNING: cannot ping DNS server', u'Tests Complete. Look for ERROR
or WARNING above.']
test_07_reboot_ssvm (tests.smoke.test_ssvm.TestSSVMs): CRITICAL: FAILED:
test_07_reboot_ssvm: ['Traceback (most recent call last):\n', ' File
"/usr/lib64/python2.7/unittest/case.py", line 369, in run\ntestMethod()\n',
' File "/marvin/tests/smoke/test_ssvm.py", line 929, in test_07_reboot_ssvm\n
self.test_03_ssvm_internals()\n', ' File "/marvin/tests/smoke/test_ssvm.py",
line 449, in test_03_ssvm_internals\n"Check for warnings in tests"\n', '
File "/usr/lib64/python2.7/unittest/case.py", line 553, in assertEqual\n
assertion_func(first, second, msg=msg)\n', ' File
"/usr/lib64/python2.7/unittest/case.py", line 546, in _baseAssertEqual\n
raise self.failureException(msg)\n', 'AssertionError: Check for warnings in
tests\n']
```
In test log before failure. I don't know if it's relevant to the case,
because If it affects it should affect on VM start, beacause external
specification doesn't change at all and default value for new parameter is 0,
so it doesn't affect on actual test results.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
wido commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog
timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138831591
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
##
@@ -237,6 +241,23 @@ public boolean parseDomainXML(String domXML) {
rngDefs.add(def);
}
+NodeList watchDogs = devices.getElementsByTagName("watchdog");
+for (int i = 0; i < watchDogs.getLength(); i++) {
+WatchDogDef def = null;
+Element watchDog = (Element)watchDogs.item(i);
+String action = watchDog.getAttribute("action");
+String model = watchDog.getAttribute("model");
+
+if (Strings.isNullOrEmpty(action)) {
+def = new
WatchDogDef(WatchDogModel.valueOf(model.toUpperCase()));
+} else {
+def = new
WatchDogDef(WatchDogAction.valueOf(action.toUpperCase()),
+
WatchDogModel.valueOf(model.toUpperCase()));
+}
+
+watchDogDefs.add(def);
+}
Review comment:
I can do a check for that, but it's libvirt which will always return a model
there. I'll add a if-statement around it, but that shouldn't make a huge
difference. Thanks for the feedback!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
wido commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329413011 LGTM based on the code Interesting idea using 3D-Xpoint SSDs as SWAP :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329412375 @rhtyd current travis failure is not related to the changes I've made This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329381439 test LGTM. @wido there is one outstanding comment, please @GabrielBrascher 's comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add
Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138802639
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
##
@@ -237,6 +241,23 @@ public boolean parseDomainXML(String domXML) {
rngDefs.add(def);
}
+NodeList watchDogs = devices.getElementsByTagName("watchdog");
+for (int i = 0; i < watchDogs.getLength(); i++) {
+WatchDogDef def = null;
+Element watchDog = (Element)watchDogs.item(i);
+String action = watchDog.getAttribute("action");
+String model = watchDog.getAttribute("model");
+
+if (Strings.isNullOrEmpty(action)) {
+def = new
WatchDogDef(WatchDogModel.valueOf(model.toUpperCase()));
+} else {
+def = new
WatchDogDef(WatchDogAction.valueOf(action.toUpperCase()),
+
WatchDogModel.valueOf(model.toUpperCase()));
+}
+
+watchDogDefs.add(def);
+}
Review comment:
I think by default the action is None, so it might work, however, let's
confirm with @wido ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on a change in pull request #1707: CLOUDSTACK-9397: Add
Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138802589
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -870,6 +875,16 @@ public boolean configure(final String name, final
Map<String, Object> params) th
_rngRatePeriod = NumbersUtil.parseInt(value, new
Integer(_rngRatePeriod));
}
+value = (String) params.get("vm.watchdog.model");
+if (!Strings.isNullOrEmpty(value)) {
Review comment:
@GabrielBrascher I think using `isNullOrEmpty` is alright
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER
blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-329367289 Packaging result: ?centos6 ?centos7 ?debian. JID-1081 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
bwsw commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329364159 @wido I tried to follow all the recommendations. Take a look please. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER
blueorangutan commented on issue #2204: [CLOUDSTACK-10025] Adding Support for NoVNC Console for KVM and XENSERVER URL: https://github.com/apache/cloudstack/pull/2204#issuecomment-329363713 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning
blueorangutan commented on issue #2266: CLOUDSTACK-10073: KVM host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329332137 Trillian test result (tid-1508) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51173 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2266-t1508-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 54 look OK, 8 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 45.84 | test_vpc_vpn.py test_05_rvpc_multi_tiers | `Failure` | 196.25 | test_vpc_redundant.py test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 389.09 | test_vpc_redundant.py test_07_reboot_ssvm | `Failure` | 143.71 | test_ssvm.py test_04_rvpc_privategw_static_routes | `Failure` | 310.28 | test_privategw_acl.py test_01_create_iso | `Failure` | 1513.43 | test_iso.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1734.53 | test_routers_network_ops.py ContextSuite context=TestISO>:setup | `Error` | 3031.94 | test_iso.py ContextSuite context=TestInternalLb>:setup | `Error` | 0.00 | test_internal_lb.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_list_ha_for_host_valid | Skipped | 0.02 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.04 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.02 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.03 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.02 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.03 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.03 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.06 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.05 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.02 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.02 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.03 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.03 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.02 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.03 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.04 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.03 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.03 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.04 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rafaelweingartner commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain
rafaelweingartner commented on issue #2124: CLOUDSTACK-9432: cluster/host dedicated to a domain is owned by the root domain URL: https://github.com/apache/cloudstack/pull/2124#issuecomment-329285933 From me you have an LGTM. @remibergsma what do you think here? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329274970 Trillian test result (tid-1507) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35487 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1707-t1507-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py Intermitten failure detected: /marvin/tests/smoke/test_iso.py Intermitten failure detected: /marvin/tests/smoke/test_outofbandmanagement.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Test completed. 59 look OK, 3 have error(s) Test | Result | Time (s) | Test File --- | --- | --- | --- test_01_vpc_remote_access_vpn | `Failure` | 62.14 | test_vpc_vpn.py test_04_rvpc_privategw_static_routes | `Failure` | 373.91 | test_privategw_acl.py test_05_iso_permissions | `Failure` | 0.10 | test_iso.py test_02_edit_iso | `Failure` | 0.08 | test_iso.py test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py test_09_copy_delete_template | Skipped | 0.02 | test_templates.py test_06_copy_template | Skipped | 0.00 | test_templates.py test_static_role_account_acls | Skipped | 0.06 | test_staticroles.py test_11_ss_nfs_version_on_ssvm | Skipped | 0.05 | test_ssvm.py test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py test_01_primary_storage_iscsi | Skipped | 0.26 | test_primary_storage.py test_vm_nic_adapter_vmxnet3 | Skipped | 0.00 | test_nic_adapter_type.py test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py test_06_copy_iso | Skipped | 0.00 | test_iso.py test_list_ha_for_host_valid | Skipped | 0.08 | test_hostha_simulator.py test_list_ha_for_host_invalid | Skipped | 0.11 | test_hostha_simulator.py test_list_ha_for_host | Skipped | 0.09 | test_hostha_simulator.py test_hostha_enable_feature_without_setting_provider | Skipped | 0.22 | test_hostha_simulator.py test_hostha_enable_feature_valid | Skipped | 0.04 | test_hostha_simulator.py test_hostha_disable_feature_valid | Skipped | 0.12 | test_hostha_simulator.py test_hostha_configure_invalid_provider | Skipped | 0.08 | test_hostha_simulator.py test_hostha_configure_default_driver | Skipped | 0.10 | test_hostha_simulator.py test_ha_verify_fsm_recovering | Skipped | 0.09 | test_hostha_simulator.py test_ha_verify_fsm_fenced | Skipped | 0.08 | test_hostha_simulator.py test_ha_verify_fsm_degraded | Skipped | 0.10 | test_hostha_simulator.py test_ha_verify_fsm_available | Skipped | 0.06 | test_hostha_simulator.py test_ha_multiple_mgmt_server_ownership | Skipped | 0.10 | test_hostha_simulator.py test_ha_list_providers | Skipped | 0.08 | test_hostha_simulator.py test_ha_enable_feature_invalid | Skipped | 0.10 | test_hostha_simulator.py test_ha_disable_feature_invalid | Skipped | 0.10 | test_hostha_simulator.py test_ha_configure_enabledisable_across_clusterzones | Skipped | 0.08 | test_hostha_simulator.py test_configure_ha_provider_valid | Skipped | 0.09 | test_hostha_simulator.py test_configure_ha_provider_invalid | Skipped | 0.08 | test_hostha_simulator.py test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py test_3d_gpu_support | Skipped | 0.08 | test_deploy_vgpu_enabled_vm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397:
Add Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138649341
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
##
@@ -237,6 +241,23 @@ public boolean parseDomainXML(String domXML) {
rngDefs.add(def);
}
+NodeList watchDogs = devices.getElementsByTagName("watchdog");
+for (int i = 0; i < watchDogs.getLength(); i++) {
+WatchDogDef def = null;
+Element watchDog = (Element)watchDogs.item(i);
+String action = watchDog.getAttribute("action");
+String model = watchDog.getAttribute("model");
+
+if (Strings.isNullOrEmpty(action)) {
+def = new
WatchDogDef(WatchDogModel.valueOf(model.toUpperCase()));
+} else {
+def = new
WatchDogDef(WatchDogAction.valueOf(action.toUpperCase()),
+
WatchDogModel.valueOf(model.toUpperCase()));
+}
+
+watchDogDefs.add(def);
+}
Review comment:
Shouldn't it check if the 'model' is null/empty/blank (as the one applied to
the 'action')? Thanks @wido!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397:
Add Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138649341
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java
##
@@ -237,6 +241,23 @@ public boolean parseDomainXML(String domXML) {
rngDefs.add(def);
}
+NodeList watchDogs = devices.getElementsByTagName("watchdog");
+for (int i = 0; i < watchDogs.getLength(); i++) {
+WatchDogDef def = null;
+Element watchDog = (Element)watchDogs.item(i);
+String action = watchDog.getAttribute("action");
+String model = watchDog.getAttribute("model");
+
+if (Strings.isNullOrEmpty(action)) {
+def = new
WatchDogDef(WatchDogModel.valueOf(model.toUpperCase()));
+} else {
+def = new
WatchDogDef(WatchDogAction.valueOf(action.toUpperCase()),
+
WatchDogModel.valueOf(model.toUpperCase()));
+}
+
+watchDogDefs.add(def);
+}
Review comment:
Shouldn't it have a test if the 'model' is null/empty/blank (as the one
applied to the 'action')? Thanks @wido!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
GabrielBrascher commented on a change in pull request #1707: CLOUDSTACK-9397:
Add Watchdog timer to KVM Instance
URL: https://github.com/apache/cloudstack/pull/1707#discussion_r138640094
##
File path:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##
@@ -870,6 +875,16 @@ public boolean configure(final String name, final
Map<String, Object> params) th
_rngRatePeriod = NumbersUtil.parseInt(value, new
Integer(_rngRatePeriod));
}
+value = (String) params.get("vm.watchdog.model");
+if (!Strings.isNullOrEmpty(value)) {
Review comment:
@wido what about replace 'Strings.isNullOrEmpty' with 'StringUtils.isBlank'?
It returns true in case of a null, empty, or blank String. However, I am not
sure if a blank string is possible when getting the param.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on issue #2266: Kvm host RAM overprovisioning
wido commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329136311 Looks good! Could you create a JIRA ticket and update the title of this PR? In addition squash all commits and add the JIRA ticket to the subject/commit as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning
bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#discussion_r138582009
##
File path:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
##
@@ -523,14 +523,7 @@ public Date startOfNextDay(Date dt) {
@Override
public Date startOfNextDay() {
-Calendar c = Calendar.getInstance();
-c.setTime(new Date());
-c.add(Calendar.DATE, 1);
-c.set(Calendar.HOUR, 0);
-c.set(Calendar.MINUTE, 0);
-c.set(Calendar.SECOND, 0);
-c.set(Calendar.MILLISECOND, 0);
-return c.getTime();
+return startOfNextDay(new Date());
Review comment:
@wido unrelated code is removed from PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning
bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#discussion_r138580781 ## File path: agent/conf/agent.properties ## @@ -156,3 +156,7 @@ hypervisor.type=kvm #router.aggregation.command.each.timeout=600 #timeout value for aggregation commands send to virtual router # +# host.overcommit.mem.mb = 0 +# allows to increase amount of ram available on host virtually to utilize Zswap, KSM features +# and modern fast SSD/3D XPoint devices Review comment: @wido fixed, take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning
bwsw commented on a change in pull request #2266: Kvm host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#discussion_r138579688
##
File path:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
##
@@ -523,14 +523,7 @@ public Date startOfNextDay(Date dt) {
@Override
public Date startOfNextDay() {
-Calendar c = Calendar.getInstance();
-c.setTime(new Date());
-c.add(Calendar.DATE, 1);
-c.set(Calendar.HOUR, 0);
-c.set(Calendar.MINUTE, 0);
-c.set(Calendar.SECOND, 0);
-c.set(Calendar.MILLISECOND, 0);
-return c.getTime();
+return startOfNextDay(new Date());
Review comment:
@wido As today our Java guys found bug in Quota plugin related to the code
above I ask them to fix it and we send a different PR for it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wido commented on a change in pull request #2266: Kvm host RAM overprovisioning
wido commented on a change in pull request #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#discussion_r138578559 ## File path: agent/conf/agent.properties ## @@ -156,3 +156,7 @@ hypervisor.type=kvm #router.aggregation.command.each.timeout=600 #timeout value for aggregation commands send to virtual router # +# host.overcommit.mem.mb = 0 +# allows to increase amount of ram available on host virtually to utilize Zswap, KSM features +# and modern fast SSD/3D XPoint devices Review comment: You might want to add that it adds these X amount of memory to the memory it reports to the Management Server This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wido commented on a change in pull request #2266: Kvm host RAM overprovisioning
wido commented on a change in pull request #2266: Kvm host RAM overprovisioning
URL: https://github.com/apache/cloudstack/pull/2266#discussion_r138578709
##
File path:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
##
@@ -523,14 +523,7 @@ public Date startOfNextDay(Date dt) {
@Override
public Date startOfNextDay() {
-Calendar c = Calendar.getInstance();
-c.setTime(new Date());
-c.add(Calendar.DATE, 1);
-c.set(Calendar.HOUR, 0);
-c.set(Calendar.MINUTE, 0);
-c.set(Calendar.SECOND, 0);
-c.set(Calendar.MILLISECOND, 0);
-return c.getTime();
+return startOfNextDay(new Date());
Review comment:
I wouldn't fix this in the same PR. Probably a separate PR for this fix
would be better. It's not related to this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] blueorangutan commented on issue #2266: Kvm host RAM overprovisioning
blueorangutan commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329119544 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2266: Kvm host RAM overprovisioning
borisstoyanov commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329119487 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2266: Kvm host RAM overprovisioning
blueorangutan commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329119209 Packaging result: ?centos6 ?centos7 ?debian. JID-1080 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw commented on issue #2266: Kvm host RAM overprovisioning
bwsw commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329118616 @borisstoyanov I added the code with analogy of _dom0minMem parameter, It seems that there are no tests for it also and I don't feel comfortable enough with ACS background to determine the right place to implement units for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329117218 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
rhtyd commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329116972 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #2266: Kvm host RAM overprovisioning
blueorangutan commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329112635 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2266: Kvm host RAM overprovisioning
borisstoyanov commented on issue #2266: Kvm host RAM overprovisioning URL: https://github.com/apache/cloudstack/pull/2266#issuecomment-329112582 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on a change in pull request #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis
borisstoyanov commented on a change in pull request #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#discussion_r138539791 ## File path: .travis.yml ## @@ -100,15 +100,19 @@ env: component/test_acl_listvm component/test_acl_listvolume component/test_acl_sharednetwork - component/test_acl_sharednetwork_deployVM-impersonation" + component/test_acl_sharednetwork_deployVM-impersonationa Review comment: yes will fix This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis
borisstoyanov commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329076689 I got this in the logs: ``` The job exceeded the maximum time limit for jobs, and has been terminated. ``` Looks like I'll need to rearrange the execution batch definitions in the yml. Can I just add them in new jobs? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw opened a new pull request #2266: Kvm host overprovisioning
bwsw opened a new pull request #2266: Kvm host overprovisioning URL: https://github.com/apache/cloudstack/pull/2266 The PR introduces new cloudstack agent KVM property host.overcommit.mem.mb which allows increasing KVM host RAM more than physical RAM exists. It is necessary to utilize KSM and ZSwap features which extend RAM with deduplication and compression. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw closed pull request #2265: KVM host memory overprovisioning feature.
bwsw closed pull request #2265: KVM host memory overprovisioning feature. URL: https://github.com/apache/cloudstack/pull/2265 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw opened a new pull request #2265: KVM host memory overprovisioning feature.
bwsw opened a new pull request #2265: KVM host memory overprovisioning feature. URL: https://github.com/apache/cloudstack/pull/2265 Commit enables a new feature for KVM hypervisor which purpose is to increase virtually amount of RAM available beyond the actual limit. There is a new parameter in agent.properties: ```host.overcommit.mem.mb``` which enables adding specified amount of RAM to actually available. Also, there is a small refactoring for QuotaResponseBuilderImpl class which deduplicates the code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw closed pull request #2264: KVM host memory overprovision parameter
bwsw closed pull request #2264: KVM host memory overprovision parameter URL: https://github.com/apache/cloudstack/pull/2264 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bwsw opened a new pull request #2264: KVM host memory overprovision parameter
bwsw opened a new pull request #2264: KVM host memory overprovision parameter URL: https://github.com/apache/cloudstack/pull/2264 Commit enables a new feature for KVM hypervisor which purpose is to increase virtually amount of RAM available beyond the actual limit. There is a new parameter in agent.properties: host.overcommit.mem.mb which enables adding specified amount of RAM to actually available. Also, there is a small refactoring for QuotaResponseBuilderImpl class which deduplicates the code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance
blueorangutan commented on issue #1707: CLOUDSTACK-9397: Add Watchdog timer to KVM Instance URL: https://github.com/apache/cloudstack/pull/1707#issuecomment-329063345 Packaging result: ?centos6 ?centos7 ?debian. JID-1079 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis
rhtyd commented on issue #2263: CLOUDSTACK-10070: Fixing some component tests and adding them in travis URL: https://github.com/apache/cloudstack/pull/2263#issuecomment-329060006 @borisstoyanov there seems to be some travis job failures, please see This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
