Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-26 Thread via GitHub


BiteThet merged PR #35136:
URL: https://github.com/apache/doris/pull/35136


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-26 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2132554069

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129188973

   
   
   ClickBench: Total hot run time: 30.22 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.040.04
   query3   0.230.060.06
   query4   1.660.080.10
   query5   0.510.490.49
   query6   1.130.720.72
   query7   0.020.010.02
   query8   0.050.040.05
   query9   0.530.490.48
   query10  0.540.540.54
   query11  0.160.110.11
   query12  0.140.110.12
   query13  0.590.580.59
   query14  0.770.770.76
   query15  0.820.820.81
   query16  0.340.360.37
   query17  0.961.000.95
   query18  0.220.230.25
   query19  1.761.701.68
   query20  0.010.010.02
   query21  15.71   0.660.65
   query22  4.757.621.71
   query23  18.28   1.401.22
   query24  1.630.290.21
   query25  0.140.080.08
   query26  0.260.180.17
   query27  0.080.080.08
   query28  13.40   1.021.06
   query29  12.93   3.383.33
   query30  0.240.060.06
   query31  2.860.390.36
   query32  3.300.460.46
   query33  2.822.852.90
   query34  17.14   4.424.46
   query35  4.434.474.51
   query36  0.660.460.46
   query37  0.170.150.15
   query38  0.160.150.15
   query39  0.050.030.03
   query40  0.150.140.14
   query41  0.090.040.04
   query42  0.050.040.05
   query43  0.040.030.04
   Total cold run time: 109.9 s
   Total hot run time: 30.22 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129179114

   
   
   TPC-DS: Total hot run time: 172071 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   913 374 359 359
   query2   6450233823512338
   query3   6665202 203 202
   query4   19850   17236   17389   17236
   query5   4164421 432 421
   query6   254 157 163 157
   query7   4587306 298 298
   query8   252 192 184 184
   query9   8512238023642364
   query10  458 288 283 283
   query11  10682   10069   99049904
   query12  136 90  87  87
   query13  1649391 383 383
   query14  8598771075937593
   query15  243 170 173 170
   query16  8103276 267 267
   query17  1822537 550 537
   query18  2037288 277 277
   query19  216 167 164 164
   query20  95  91  85  85
   query21  204 133 132 132
   query22  4286384638653846
   query23  33781   32947   32799   32799
   query24  11698   288827992799
   query25  674 370 380 370
   query26  1780161 158 158
   query27  2930323 322 322
   query28  7487204321162043
   query29  1020611 599 599
   query30  311 170 182 170
   query31  962 770 749 749
   query32  91  54  55  54
   query33  764 271 288 271
   query34  992 472 476 472
   query35  728 597 594 594
   query36  1058922 892 892
   query37  172 68  74  68
   query38  2850281227542754
   query39  874 800 794 794
   query40  269 123 123 123
   query41  46  44  43  43
   query42  101 94  95  94
   query43  591 544 564 544
   query44  1268726 753 726
   query45  177 163 162 162
   query46  1062743 700 700
   query47  1881175517671755
   query48  365 308 310 308
   query49  1158372 389 372
   query50  756 396 396 396
   query51  6713657165506550
   query52  113 96  98  96
   query53  351 283 275 275
   query54  914 445 420 420
   query55  78  70  70  70
   query56  265 241 254 241
   query57  1113104910651049
   query58  241 208 215 208
   query59  3508330833143308
   query60  273 250 255 250
   query61  91  87  87  87
   query62  648 439 447 439
   query63  315 276 280 276
   query64  9780222516761676
   query65  3157308031533080
   query66  1213329 329 329
   query67  15236   14822   15242   14822
   query68  4681539 542 539
   query69  442 273 271 271
   query70  1038107911091079
   query71  412 270 266 266
   query72  7167550853045304
   query73  720 325 323 323
   query74  6072570555785578
   query75  3438261326192613
   query76  28431051952 952
   query77  394 268 270 268
   query78  10567   991896909690
   query79  2780509 510 509
   query80  2031438 425 425
   query81  550 246 246 246
   query82  778 97  96  96
   query83  279 174 168 168
   query84  260 93  88  88
   query85  2131277 260 260
   query86  506 323 273 273
   query87  3364313231163116
   query88  4220244024382438
   query89  476 389 381 381
   query90  2008248 184 184
   query91  124 96  95  95
   query92  62  49  51  49
   query93  2813524 493 493
   query94  1258187 183 183
   query95  406 310 310 310
   query96  575 267 271 267
   query97  3218295730172957
   query98  236 226 212 212
   query99  1256853 844 844
   Total cold run time: 277136 ms
   Total hot run time: 172071 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129158793

   TeamCity be ut coverage result:
Function Coverage: 35.74% (9009/25205) 
Line Coverage: 27.34% (74542/272679)
Region Coverage: 26.56% (38577/145267)
Branch Coverage: 23.41% (19686/84090)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/0e92377f8e5425953e32925175352f15d3ce83b1_0e92377f8e5425953e32925175352f15d3ce83b1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129157095

   
   
   TPC-H: Total hot run time: 40098 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   -- Round 1 --
   q1   7522421542654215
   q2   656 195 196 195
   q3   3873118911571157
   q4   7789818 844 818
   q5   2658286329322863
   q6   227 137 149 137
   q7   992 615 597 597
   q8   2014202820412028
   q9   6653647964996479
   q10  3900376037063706
   q11  348 242 237 237
   q12  376 220 223 220
   q13  18003   301329862986
   q14  270 226 217 217
   q15  511 479 475 475
   q16  483 375 400 375
   q17  952 700 700 700
   q18  7942760574637463
   q19  1729154014761476
   q20  504 306 301 301
   q21  4932317239263172
   q22  350 281 282 281
   Total cold run time: 72684 ms
   Total hot run time: 40098 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4226421941844184
   q2   370 279 274 274
   q3   2986274627032703
   q4   1862161616061606
   q5   5321529952505250
   q6   214 131 129 129
   q7   2101178717661766
   q8   3178330033283300
   q9   8410838883898388
   q10  3849365236583652
   q11  577 485 510 485
   q12  751 595 597 595
   q13  15648   298529922985
   q14  283 257 258 257
   q15  503 481 489 481
   q16  474 418 415 415
   q17  1757149114841484
   q18  7696759874397439
   q19  1645155315891553
   q20  1989180117461746
   q21  4884476547194719
   q22  590 488 496 488
   Total cold run time: 69314 ms
   Total hot run time: 53899 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129099677

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129017016

   
   
   ClickBench: Total hot run time: 30.76 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   0.040.030.03
   query2   0.080.040.05
   query3   0.230.050.07
   query4   1.660.100.10
   query5   0.490.510.53
   query6   1.120.720.72
   query7   0.020.020.01
   query8   0.040.040.04
   query9   0.540.490.49
   query10  0.540.550.55
   query11  0.160.120.11
   query12  0.150.120.12
   query13  0.600.600.60
   query14  0.790.780.79
   query15  0.830.830.82
   query16  0.360.370.36
   query17  1.001.020.98
   query18  0.220.240.26
   query19  1.771.651.69
   query20  0.010.020.01
   query21  15.74   0.660.65
   query22  4.267.811.95
   query23  18.32   1.381.34
   query24  1.630.260.26
   query25  0.160.090.08
   query26  0.270.170.17
   query27  0.080.080.08
   query28  13.34   1.010.99
   query29  13.01   3.373.34
   query30  0.240.050.06
   query31  2.880.390.38
   query32  3.280.480.47
   query33  2.922.872.97
   query34  17.04   4.374.40
   query35  4.504.484.52
   query36  0.670.490.49
   query37  0.180.160.16
   query38  0.160.140.15
   query39  0.040.030.04
   query40  0.160.140.14
   query41  0.090.040.04
   query42  0.060.040.04
   query43  0.030.030.04
   Total cold run time: 109.71 s
   Total hot run time: 30.76 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129009161

   TeamCity be ut coverage result:
Function Coverage: 35.75% (9010/25205) 
Line Coverage: 27.34% (74560/272693)
Region Coverage: 26.56% (38589/145270)
Branch Coverage: 23.42% (19691/84092)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/0e92377f8e5425953e32925175352f15d3ce83b1_0e92377f8e5425953e32925175352f15d3ce83b1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2129006020

   
   
   TPC-DS: Total hot run time: 169004 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   918 378 375 375
   query2   6448253123132313
   query3   6650203 205 203
   query4   19023   17219   17198   17198
   query5   4134418 404 404
   query6   237 152 153 152
   query7   4580300 292 292
   query8   238 189 187 187
   query9   8546237523482348
   query10  453 287 270 270
   query11  10618   10080   10050   10050
   query12  138 91  87  87
   query13  1649377 372 372
   query14  9719673782996737
   query15  234 179 176 176
   query16  7858269 266 266
   query17  1715588 541 541
   query18  2010295 285 285
   query19  201 161 162 161
   query20  94  90  88  88
   query21  198 129 129 129
   query22  4323385439193854
   query23  33554   33033   33091   33033
   query24  6650285728382838
   query25  476 383 369 369
   query26  695 153 155 153
   query27  1901323 328 323
   query28  3698207520902075
   query29  844 611 602 602
   query30  244 168 177 168
   query31  939 751 753 751
   query32  63  53  55  53
   query33  512 272 261 261
   query34  869 479 493 479
   query35  707 607 598 598
   query36  1088925 901 901
   query37  110 71  73  71
   query38  2849280327632763
   query39  842 795 801 795
   query40  195 125 124 124
   query41  46  43  42  42
   query42  100 94  99  94
   query43  574 551 542 542
   query44  1115743 763 743
   query45  176 164 184 164
   query46  1051731 689 689
   query47  1847175417801754
   query48  369 295 308 295
   query49  771 378 378 378
   query50  770 395 388 388
   query51  6817666066456645
   query52  103 92  90  90
   query53  349 287 289 287
   query54  553 450 439 439
   query55  75  71  75  71
   query56  260 243 244 243
   query57  1100103510761035
   query58  247 208 211 208
   query59  3469316733793167
   query60  272 272 253 253
   query61  90  90  89  89
   query62  565 452 468 452
   query63  307 296 283 283
   query64  2756174717451745
   query65  3172311331153113
   query66  779 334 321 321
   query67  15308   14667   14993   14667
   query68  4515543 551 543
   query69  445 283 273 273
   query70  1172105311161053
   query71  392 272 267 267
   query72  7603533227092709
   query73  713 326 323 323
   query74  6045561956125612
   query75  3315264125852585
   query76  2196989 965 965
   query77  386 267 271 267
   query78  10289   10025   96869686
   query79  1975525 584 525
   query80  1129436 440 436
   query81  527 243 240 240
   query82  650 100 93  93
   query83  262 176 188 176
   query84  253 83  87  83
   query85  1583268 262 262
   query86  531 301 278 278
   query87  3307309631453096
   query88  4130243424512434
   query89  491 398 393 393
   query90  2017190 239 190
   query91  126 97  100 97
   query92  69  49  48  48
   query93  3007540 510 510
   query94  1203186 186 186
   query95  411 316 317 316
   query96  602 279 268 268
   query97  3212298529812981
   query98  254 219 214 214
   query99  1127865 853 853
   Total cold run time: 253198 ms
   Total hot run time: 169004 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128976460

   
   
   TPC-H: Total hot run time: 42138 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   -- Round 1 --
   q1   17609   447742494249
   q2   2032196 202 196
   q3   10453   122512061206
   q4   10197   789 758 758
   q5   7513279126512651
   q6   220 135 139 135
   q7   983 625 629 625
   q8   9221215921162116
   q9   9336670967206709
   q10  9384397639043904
   q11  472 235 247 235
   q12  555 232 241 232
   q13  17247   331732683268
   q14  275 224 222 222
   q15  528 489 479 479
   q16  499 403 416 403
   q17  1014723 779 723
   q18  8493794178627862
   q19  5137151715481517
   q20  643 325 323 323
   q21  5170404640404040
   q22  355 285 285 285
   Total cold run time: 117336 ms
   Total hot run time: 42138 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4514447844814478
   q2   381 262 261 261
   q3   3185292829502928
   q4   1992176516231623
   q5   5335553355965533
   q6   223 126 128 126
   q7   2233183218341832
   q8   3233341834073407
   q9   8701869986678667
   q10  4143377937413741
   q11  592 482 508 482
   q12  785 621 654 621
   q13  16872   318431323132
   q14  304 281 272 272
   q15  525 472 492 472
   q16  496 430 447 430
   q17  1810153215441532
   q18  7975771775367536
   q19  1647160715991599
   q20  1997179217881788
   q21  4868467047764670
   q22  601 489 493 489
   Total cold run time: 72412 ms
   Total hot run time: 55619 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-24 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128773883

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128507200

   TeamCity be ut coverage result:
Function Coverage: 35.75% (9010/25202) 
Line Coverage: 27.34% (74544/272651)
Region Coverage: 26.57% (38589/145248)
Branch Coverage: 23.42% (19688/84078)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/0e92377f8e5425953e32925175352f15d3ce83b1_0e92377f8e5425953e32925175352f15d3ce83b1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128504819

   
   
   ClickBench: Total hot run time: 30.28 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   0.040.030.04
   query2   0.090.040.04
   query3   0.240.050.05
   query4   1.660.070.07
   query5   0.480.480.55
   query6   1.120.730.72
   query7   0.020.020.01
   query8   0.050.040.04
   query9   0.540.470.50
   query10  0.550.550.54
   query11  0.160.110.11
   query12  0.150.120.13
   query13  0.590.590.61
   query14  0.760.790.78
   query15  0.840.810.82
   query16  0.370.340.37
   query17  0.941.001.02
   query18  0.210.240.27
   query19  1.801.761.66
   query20  0.010.020.01
   query21  15.56   0.670.65
   query22  4.497.741.77
   query23  18.34   1.451.26
   query24  1.990.200.21
   query25  0.140.070.08
   query26  0.270.160.16
   query27  0.080.080.08
   query28  13.34   1.011.01
   query29  13.12   3.383.35
   query30  0.240.080.05
   query31  2.850.390.37
   query32  3.270.460.48
   query33  2.892.882.87
   query34  17.07   4.414.37
   query35  4.494.484.46
   query36  0.640.460.45
   query37  0.170.150.16
   query38  0.160.150.14
   query39  0.040.030.04
   query40  0.170.150.15
   query41  0.100.040.04
   query42  0.050.050.05
   query43  0.040.040.03
   Total cold run time: 110.13 s
   Total hot run time: 30.28 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128500766

   
   
   TPC-DS: Total hot run time: 171223 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   928 387 385 385
   query2   6457242123692369
   query3   6650207 203 203
   query4   19873   17288   17399   17288
   query5   4145413 413 413
   query6   251 163 152 152
   query7   4583300 305 300
   query8   243 199 187 187
   query9   8619246824302430
   query10  449 296 269 269
   query11  10759   10211   10177   10177
   query12  144 90  89  89
   query13  1657386 372 372
   query14  10149   685167416741
   query15  208 177 175 175
   query16  7836279 276 276
   query17  1810539 531 531
   query18  1968322 275 275
   query19  206 155 155 155
   query20  90  84  80  80
   query21  198 132 129 129
   query22  4184393238763876
   query23  33856   33218   33134   33134
   query24  12030   280328292803
   query25  686 352 359 352
   query26  1830161 157 157
   query27  3019327 327 327
   query28  7707209020772077
   query29  1185617 615 615
   query30  329 193 174 174
   query31  976 761 733 733
   query32  90  54  58  54
   query33  763 270 263 263
   query34  1042484 485 484
   query35  742 583 596 583
   query36  1092919 906 906
   query37  280 72  71  71
   query38  2893275827752758
   query39  858 805 786 786
   query40  283 124 126 124
   query41  49  47  44  44
   query42  101 94  95  94
   query43  593 537 546 537
   query44  1211721 744 721
   query45  176 163 164 163
   query46  1078757 734 734
   query47  1846176917911769
   query48  379 302 325 302
   query49  1178371 383 371
   query50  776 395 392 392
   query51  68176817
   query52  97  90  86  86
   query53  357 277 285 277
   query54  921 440 432 432
   query55  76  74  72  72
   query56  261 234 242 234
   query57  1163104810461046
   query58  226 205 210 205
   query59  3337329032233223
   query60  276 252 249 249
   query61  86  84  117 84
   query62  661 440 447 440
   query63  305 279 283 279
   query64  9763220317111711
   query65  3205313531283128
   query66  1401339 317 317
   query67  15282   14786   14724   14724
   query68  6157545 557 545
   query69  494 315 273 273
   query70  1207113311161116
   query71  470 269 268 268
   query72  7540532144634463
   query73  755 327 333 327
   query74  6134556856145568
   query75  3983265326042604
   query76  3753945 1009945
   query77  663 265 263 263
   query78  10394   10080   96749674
   query79  2634523 510 510
   query80  2016448 433 433
   query81  524 240 243 240
   query82  132499  95  95
   query83  356 171 171 171
   query84  264 93  83  83
   query85  1545321 260 260
   query86  468 280 301 280
   query87  3336307430703070
   query88  4032244324572443
   query89  471 390 387 387
   query90  1949185 181 181
   query91  124 97  95  95
   query92  62  48  47  47
   query93  2873530 515 515
   query94  1203187 182 182
   query95  392 310 316 310
   query96  603 270 267 267
   query97  3214299930072999
   query98  253 231 220 220
   query99  1227840 816 816
   Total cold run time: 283109 ms
   Total hot run time: 171223 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128492923

   
   
   TPC-H: Total hot run time: 40260 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   -- Round 1 --
   q1   17616   447442444244
   q2   2024196 197 196
   q3   10535   126911841184
   q4   10685   821 808 808
   q5   7570273627282728
   q6   228 136 136 136
   q7   962 601 615 601
   q8   9283212720942094
   q9   9040662866306628
   q10  9041373536913691
   q11  456 240 250 240
   q12  460 224 212 212
   q13  17778   301529892989
   q14  258 224 216 216
   q15  506 478 478 478
   q16  493 388 381 381
   q17  967 675 684 675
   q18  8116754974207420
   q19  4722156315361536
   q20  662 308 341 308
   q21  4910321933433219
   q22  337 276 282 276
   Total cold run time: 116649 ms
   Total hot run time: 40260 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4290420042834200
   q2   364 270 267 267
   q3   2990275527542754
   q4   1884157415861574
   q5   5263529152505250
   q6   210 122 124 122
   q7   2082172817321728
   q8   3157333033133313
   q9   8362838182928292
   q10  3886371437103710
   q11  573 502 481 481
   q12  789 616 607 607
   q13  17039   295730402957
   q14  300 270 272 270
   q15  504 477 477 477
   q16  466 427 413 413
   q17  1767149714611461
   q18  7762751774987498
   q19  1654153415411534
   q20  1992180417741774
   q21  4959477547364736
   q22  564 496 495 495
   Total cold run time: 70857 ms
   Total hot run time: 53913 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2128426978

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2127036263

   
   
   ClickBench: Total hot run time: 30.77 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   0.040.040.03
   query2   0.070.040.04
   query3   0.230.050.06
   query4   1.670.070.07
   query5   0.490.500.49
   query6   1.130.720.73
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.540.480.49
   query10  0.530.550.53
   query11  0.150.110.11
   query12  0.150.120.12
   query13  0.590.590.59
   query14  0.790.770.78
   query15  0.830.800.81
   query16  0.370.370.37
   query17  0.941.030.95
   query18  0.220.240.24
   query19  1.811.771.73
   query20  0.010.010.01
   query21  15.43   0.710.69
   query22  4.296.532.04
   query23  18.31   1.401.27
   query24  1.550.310.20
   query25  0.140.080.08
   query26  0.270.180.16
   query27  0.070.060.07
   query28  13.41   1.021.00
   query29  12.69   3.453.41
   query30  0.250.060.05
   query31  2.860.380.38
   query32  3.290.490.46
   query33  2.872.842.97
   query34  16.88   4.424.44
   query35  4.504.514.55
   query36  0.650.460.46
   query37  0.180.160.15
   query38  0.160.150.14
   query39  0.050.040.04
   query40  0.170.130.14
   query41  0.090.050.05
   query42  0.050.050.05
   query43  0.040.040.03
   Total cold run time: 108.83 s
   Total hot run time: 30.77 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2127036196

   TeamCity be ut coverage result:
Function Coverage: 35.76% (9008/25187) 
Line Coverage: 27.35% (74523/272504)
Region Coverage: 26.57% (38564/145140)
Branch Coverage: 23.42% (19679/84038)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/0e92377f8e5425953e32925175352f15d3ce83b1_0e92377f8e5425953e32925175352f15d3ce83b1/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2127025076

   
   
   TPC-DS: Total hot run time: 172835 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   query1   931 383 373 373
   query2   6450238823362336
   query3   6654212 217 212
   query4   19425   17412   17223   17223
   query5   4208424 409 409
   query6   255 162 153 153
   query7   4593301 291 291
   query8   242 180 185 180
   query9   8684240123892389
   query10  457 279 282 279
   query11  10634   10148   10152   10148
   query12  140 90  86  86
   query13  1637359 363 359
   query14  9207720775077207
   query15  213 176 171 171
   query16  7760270 266 266
   query17  1801541 511 511
   query18  1885275 272 272
   query19  222 158 156 156
   query20  92  88  86  86
   query21  197 125 127 125
   query22  4275405539943994
   query23  33740   33681   33204   33204
   query24  11100   284728662847
   query25  636 347 352 347
   query26  1630151 157 151
   query27  2954326 321 321
   query28  7644204520552045
   query29  1001596 598 596
   query30  317 174 175 174
   query31  971 736 760 736
   query32  88  52  56  52
   query33  778 280 293 280
   query34  940 472 474 472
   query35  697 604 602 602
   query36  1053911 870 870
   query37  135 69  69  69
   query38  2847277127652765
   query39  855 777 780 777
   query40  277 124 124 124
   query41  46  44  46  44
   query42  100 98  97  97
   query43  587 547 537 537
   query44  1237729 731 729
   query45  178 162 162 162
   query46  1079722 718 718
   query47  1869173617821736
   query48  367 287 292 287
   query49  1154384 376 376
   query50  778 387 423 387
   query51  6739668467166684
   query52  102 95  91  91
   query53  349 288 282 282
   query54  852 457 420 420
   query55  79  77  74  74
   query56  256 234 262 234
   query57  1147104710851047
   query58  228 197 211 197
   query59  3457319332493193
   query60  273 256 253 253
   query61  91  88  95  88
   query62  626 459 457 457
   query63  317 294 288 288
   query64  9856222817121712
   query65  3188309930833083
   query66  1231326 325 325
   query67  15497   15064   14957   14957
   query68  4599519 531 519
   query69  446 267 266 266
   query70  1147112910751075
   query71  399 258 269 258
   query72  7776555356255553
   query73  709 326 319 319
   query74  5949567155545554
   query75  3327265426002600
   query76  2723970 1017970
   query77  649 266 266 266
   query78  10287   975697409740
   query79  2079522 508 508
   query80  830 451 431 431
   query81  521 254 246 246
   query82  643 95  93  93
   query83  267 170 169 169
   query84  239 86  88  86
   query85  1600327 372 327
   query86  464 326 281 281
   query87  3370312731263126
   query88  4084234323132313
   query89  497 391 390 390
   query90  1825183 178 178
   query91  123 98  94  94
   query92  56  49  48  48
   query93  2293505 482 482
   query94  941 181 181 181
   query95  392 307 301 301
   query96  580 261 261 261
   query97  3205303830593038
   query98  232 226 215 215
   query99  1097856 831 831
   Total cold run time: 272657 ms
   Total hot run time: 172835 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2127003528

   
   
   TPC-H: Total hot run time: 40386 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 0e92377f8e5425953e32925175352f15d3ce83b1, 
data reload: false
   
   -- Round 1 --
   q1   17828   463643764376
   q2   2506199 193 193
   q3   11153   125412691254
   q4   10246   812 839 812
   q5   7569275426932693
   q6   231 137 140 137
   q7   976 629 616 616
   q8   9443212521322125
   q9   9067656765106510
   q10  8992377036893689
   q11  446 248 242 242
   q12  483 230 224 224
   q13  17785   299129802980
   q14  268 230 225 225
   q15  510 480 469 469
   q16  486 382 393 382
   q17  981 664 767 664
   q18  8199767374297429
   q19  6619155515421542
   q20  656 313 317 313
   q21  5094322838543228
   q22  351 283 288 283
   Total cold run time: 119889 ms
   Total hot run time: 40386 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4326422241964196
   q2   366 266 273 266
   q3   2995281727812781
   q4   1873155516241555
   q5   5291526952575257
   q6   216 130 131 130
   q7   2146178517161716
   q8   3195333233253325
   q9   8384837284078372
   q10  3846365836303630
   q11  605 500 503 500
   q12  772 620 603 603
   q13  16286   297430202974
   q14  305 268 258 258
   q15  530 472 483 472
   q16  482 407 422 407
   q17  1801149914911491
   q18  7756753574917491
   q19  3346158415941584
   q20  2026181717921792
   q21  4803470147984701
   q22  584 514 493 493
   Total cold run time: 71934 ms
   Total hot run time: 53994 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2126886147

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2126870621

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-23 Thread via GitHub


BiteThet commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1611489729


##
be/src/vec/columns/column_nullable.h:
##
@@ -353,23 +349,41 @@ class ColumnNullable final : public COWHelper {
 
 if (!nullable_rhs.is_null_at(row)) {
 nested_column->replace_column_data(*nullable_rhs.nested_column, 
row, self_row);
-} else {
-nested_column->replace_column_data_default(self_row);
 }
 }
 
-void replace_column_data_default(size_t self_row = 0) override {
-LOG(FATAL) << "should not call the method in column nullable";
-__builtin_unreachable();
-}
-
 MutableColumnPtr convert_to_predicate_column_if_dictionary() override {
 nested_column = 
get_nested_column().convert_to_predicate_column_if_dictionary();
 return get_ptr();
 }
 
 double get_ratio_of_default_rows(double sample_ratio) const override {

Review Comment:
   used on ColumnObject



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


HappenLee commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1610939565


##
be/src/vec/columns/column_nullable.h:
##
@@ -353,23 +349,41 @@ class ColumnNullable final : public COWHelper {
 
 if (!nullable_rhs.is_null_at(row)) {
 nested_column->replace_column_data(*nullable_rhs.nested_column, 
row, self_row);
-} else {
-nested_column->replace_column_data_default(self_row);
 }
 }
 
-void replace_column_data_default(size_t self_row = 0) override {
-LOG(FATAL) << "should not call the method in column nullable";
-__builtin_unreachable();
-}
-
 MutableColumnPtr convert_to_predicate_column_if_dictionary() override {
 nested_column = 
get_nested_column().convert_to_predicate_column_if_dictionary();
 return get_ptr();
 }
 
 double get_ratio_of_default_rows(double sample_ratio) const override {

Review Comment:
   should we really need the func? seems unless in doris code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


HappenLee commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1610937321


##
be/src/vec/columns/column_nullable.h:
##
@@ -353,23 +349,41 @@ class ColumnNullable final : public COWHelper {
 
 if (!nullable_rhs.is_null_at(row)) {
 nested_column->replace_column_data(*nullable_rhs.nested_column, 
row, self_row);
-} else {
-nested_column->replace_column_data_default(self_row);
 }
 }
 
-void replace_column_data_default(size_t self_row = 0) override {
-LOG(FATAL) << "should not call the method in column nullable";
-__builtin_unreachable();
-}
-
 MutableColumnPtr convert_to_predicate_column_if_dictionary() override {
 nested_column = 
get_nested_column().convert_to_predicate_column_if_dictionary();
 return get_ptr();
 }
 
 double get_ratio_of_default_rows(double sample_ratio) const override {
-return get_ratio_of_default_rows_impl(sample_ratio);
+if (sample_ratio <= 0.0 || sample_ratio > 1.0) {
+LOG(FATAL) << "Value of 'sample_ratio' must be in interval (0.0; 
1.0], but got: "
+   << sample_ratio;
+}
+static constexpr auto max_number_of_rows_for_full_search = 1000;

Review Comment:
   MAX_NUMBER



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


HappenLee commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1610937154


##
be/src/vec/columns/column_nullable.h:
##
@@ -353,23 +349,41 @@ class ColumnNullable final : public COWHelper {
 
 if (!nullable_rhs.is_null_at(row)) {
 nested_column->replace_column_data(*nullable_rhs.nested_column, 
row, self_row);
-} else {
-nested_column->replace_column_data_default(self_row);
 }
 }
 
-void replace_column_data_default(size_t self_row = 0) override {
-LOG(FATAL) << "should not call the method in column nullable";
-__builtin_unreachable();
-}
-
 MutableColumnPtr convert_to_predicate_column_if_dictionary() override {
 nested_column = 
get_nested_column().convert_to_predicate_column_if_dictionary();
 return get_ptr();
 }
 
 double get_ratio_of_default_rows(double sample_ratio) const override {
-return get_ratio_of_default_rows_impl(sample_ratio);
+if (sample_ratio <= 0.0 || sample_ratio > 1.0) {
+LOG(FATAL) << "Value of 'sample_ratio' must be in interval (0.0; 
1.0], but got: "

Review Comment:
   throw Exception ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


HappenLee commented on code in PR #35136:
URL: https://github.com/apache/doris/pull/35136#discussion_r1610936251


##
be/src/vec/columns/column_fixed_length_object.h:
##
@@ -159,60 +161,65 @@ class ColumnFixedLengthObject final : public 
COWHelper

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2126158000

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2126157987

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2125130438

   TeamCity be ut coverage result:
Function Coverage: 35.76% (9007/25185) 
Line Coverage: 27.33% (74500/272563)
Region Coverage: 26.56% (38559/145184)
Branch Coverage: 23.40% (19674/84068)
Coverage Report: 
http://coverage.selectdb-in.cc/coverage/a0b0a4fe8f83e6ab465d9b489f59a17827212ec3_a0b0a4fe8f83e6ab465d9b489f59a17827212ec3/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124790454

   
   
   ClickBench: Total hot run time: 31.24 s
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit a0b0a4fe8f83e6ab465d9b489f59a17827212ec3, 
data reload: false
   
   query1   0.030.030.03
   query2   0.080.030.04
   query3   0.240.050.05
   query4   1.680.060.06
   query5   0.490.490.52
   query6   1.120.720.72
   query7   0.020.010.02
   query8   0.050.040.04
   query9   0.540.480.51
   query10  0.550.550.54
   query11  0.170.110.11
   query12  0.150.110.12
   query13  0.600.590.60
   query14  0.770.760.79
   query15  0.820.810.81
   query16  0.360.350.37
   query17  1.000.950.93
   query18  0.200.260.24
   query19  1.871.761.75
   query20  0.020.010.01
   query21  15.74   0.650.64
   query22  4.366.542.52
   query23  18.32   1.381.30
   query24  1.800.280.20
   query25  0.130.090.09
   query26  0.260.170.16
   query27  0.080.080.08
   query28  13.31   1.010.99
   query29  13.49   3.383.35
   query30  0.260.050.06
   query31  2.870.400.40
   query32  3.240.460.46
   query33  2.902.902.91
   query34  16.97   4.444.45
   query35  4.534.514.55
   query36  0.670.460.46
   query37  0.170.150.15
   query38  0.160.140.14
   query39  0.050.030.04
   query40  0.160.120.15
   query41  0.090.050.05
   query42  0.050.050.05
   query43  0.040.040.04
   Total cold run time: 110.41 s
   Total hot run time: 31.24 s
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124778043

   
   
   TPC-DS: Total hot run time: 171409 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit a0b0a4fe8f83e6ab465d9b489f59a17827212ec3, 
data reload: false
   
   query1   907 383 369 369
   query2   6467256122602260
   query3   6635213 211 211
   query4   19529   17363   17466   17363
   query5   4153415 419 415
   query6   263 174 149 149
   query7   4591294 287 287
   query8   260 186 177 177
   query9   8692238823762376
   query10  456 279 274 274
   query11  10677   10046   99599959
   query12  141 91  91  91
   query13  1645375 355 355
   query14  10056   669468516694
   query15  208 170 169 169
   query16  7745262 255 255
   query17  1504518 505 505
   query18  1953268 279 268
   query19  199 153 160 153
   query20  97  86  87  86
   query21  196 126 128 126
   query22  4162399538893889
   query23  33902   33158   33107   33107
   query24  7005279027612761
   query25  567 348 360 348
   query26  705 155 158 155
   query27  2059334 317 317
   query28  3518206720672067
   query29  849 598 611 598
   query30  256 174 178 174
   query31  975 781 725 725
   query32  85  51  53  51
   query33  533 273 263 263
   query34  863 479 470 470
   query35  693 599 584 584
   query36  1067907 908 907
   query37  106 69  75  69
   query38  2917278727772777
   query39  843 806 790 790
   query40  199 131 131 131
   query41  49  43  46  43
   query42  108 97  102 97
   query43  597 558 564 558
   query44  1099734 750 734
   query45  178 171 168 168
   query46  1064703 733 703
   query47  1886175517911755
   query48  369 299 298 298
   query49  821 395 423 395
   query50  769 376 387 376
   query51  7014672668816726
   query52  102 91  93  91
   query53  353 284 288 284
   query54  536 446 431 431
   query55  76  72  73  72
   query56  268 264 248 248
   query57  1118106010621060
   query58  228 205 214 205
   query59  3366322434783224
   query60  264 259 251 251
   query61  121 88  87  87
   query62  569 445 441 441
   query63  307 279 287 279
   query64  8436223817031703
   query65  3143307131163071
   query66  825 326 328 326
   query67  15107   14608   14933   14608
   query68  4527527 546 527
   query69  438 277 279 277
   query70  1176110510771077
   query71  383 269 265 265
   query72  7153530353785303
   query73  719 321 320 320
   query74  5931553356435533
   query75  3303260026502600
   query76  2215101410361014
   query77  385 266 263 263
   query78  10288   990195919591
   query79  2178522 514 514
   query80  1025452 450 450
   query81  535 241 248 241
   query82  876 100 98  98
   query83  246 200 187 187
   query84  246 92  89  89
   query85  1281333 342 333
   query86  456 291 315 291
   query87  3245314131313131
   query88  4054234323382338
   query89  465 380 369 369
   query90  2051191 188 188
   query91  125 95  94  94
   query92  62  51  50  50
   query93  2720513 502 502
   query94  1217189 185 185
   query95  407 311 309 309
   query96  587 267 263 263
   query97  3238297730132977
   query98  257 225 214 214
   query99  1124857 857 857
   Total cold run time: 259364 ms
   Total hot run time: 171409 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp

Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


doris-robot commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124756228

   
   
   TPC-H: Total hot run time: 42140 ms
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit a0b0a4fe8f83e6ab465d9b489f59a17827212ec3, 
data reload: false
   
   -- Round 1 --
   q1   17597   436343504350
   q2   2009190 185 185
   q3   10473   116411951164
   q4   10197   900 808 808
   q5   7469279927282728
   q6   223 135 137 135
   q7   973 614 619 614
   q8   9234211921142114
   q9   9442675267176717
   q10  9340393739253925
   q11  461 243 245 243
   q12  416 222 247 222
   q13  17309   325432673254
   q14  263 215 209 209
   q15  505 470 472 470
   q16  474 396 421 396
   q17  984 657 713 657
   q18  8603785578777855
   q19  4362155015331533
   q20  688 330 334 330
   q21  5176402139543954
   q22  341 289 277 277
   Total cold run time: 116539 ms
   Total hot run time: 42140 ms
   
   - Round 2, with runtime_filter_mode=off -
   q1   4575444744074407
   q2   397 280 283 280
   q3   3122293327872787
   q4   1869166516481648
   q5   5502550255095502
   q6   212 127 128 127
   q7   2219183918051805
   q8   3269344333703370
   q9   8706868886818681
   q10  3956376438923764
   q11  601 497 481 481
   q12  809 612 624 612
   q13  16872   318931593159
   q14  289 287 292 287
   q15  552 483 457 457
   q16  507 429 435 429
   q17  1841152414671467
   q18  7759766874777477
   q19  1662150415521504
   q20  2027178017911780
   q21  9470471746814681
   q22  584 489 476 476
   Total cold run time: 76800 ms
   Total hot run time: 55181 ms
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124593925

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


github-actions[bot] commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124586550

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124579168

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org



Re: [PR] [Chore](column) support all column method on column_fixed_object and remove some method about IColumn [doris]

2024-05-22 Thread via GitHub


BiteThet commented on PR #35136:
URL: https://github.com/apache/doris/pull/35136#issuecomment-2124571273

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org