[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views
vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287163630
##
File path: web-console/src/views/servers-view/servers-view.tsx
##
@@ -21,18 +21,20 @@ import { IconNames } from '@blueprintjs/icons';
import axios from 'axios';
import { sum } from 'd3-array';
import * as React from 'react';
+import SplitterLayout from 'react-splitter-layout';
import ReactTable from 'react-table';
import { Filter } from 'react-table';
import { TableColumnSelection, ViewControlBar } from '../../components/index';
import {
addFilter,
formatBytes,
- formatBytesCompact, LocalStorageKeys,
+ formatBytesCompact, localStorageGet, LocalStorageKeys, localStorageSet,
queryDruidSql,
QueryManager, TableColumnSelectionHandler
} from '../../utils';
+import 'react-splitter-layout/lib/index.css';
Review comment:
import this only once in entry.scss
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views
vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287164070
##
File path: web-console/src/views/task-view/tasks-view.tsx
##
@@ -697,59 +705,71 @@ ORDER BY "rank" DESC, "created_time" DESC`);
/>
;
-return
-
- this.supervisorQueryManager.rerunLastQuery()}
-/>
- this.setState({ supervisorSpecDialogOpen: true })}
-/>
-
supervisorTableColumnSelectionHandler.changeTableColumnSelection(column)}
-
tableColumnsHidden={supervisorTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderSupervisorTable()}
-
-
-
-
-Group by
-
-
this.setState({ groupTasksBy: null })}>None
-
this.setState({ groupTasksBy: 'type' })}>Type
-
this.setState({ groupTasksBy: 'datasource' })}>Datasource
-
this.setState({ groupTasksBy: 'status' })}>Status
-
- this.taskQueryManager.rerunLastQuery()}
-/>
-{
- !noSqlMode &&
- goToSql(this.taskQueryManager.getLastQuery())}
- />
-}
-
-
-
-
taskTableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={taskTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderTaskTable()}
+// tslint:disable-next-line:radix
+return<>
Review comment:
add space please
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views
vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287164040
##
File path: web-console/src/views/task-view/tasks-view.tsx
##
@@ -697,59 +705,71 @@ ORDER BY "rank" DESC, "created_time" DESC`);
/>
;
-return
-
- this.supervisorQueryManager.rerunLastQuery()}
-/>
- this.setState({ supervisorSpecDialogOpen: true })}
-/>
-
supervisorTableColumnSelectionHandler.changeTableColumnSelection(column)}
-
tableColumnsHidden={supervisorTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderSupervisorTable()}
-
-
-
-
-Group by
-
-
this.setState({ groupTasksBy: null })}>None
-
this.setState({ groupTasksBy: 'type' })}>Type
-
this.setState({ groupTasksBy: 'datasource' })}>Datasource
-
this.setState({ groupTasksBy: 'status' })}>Status
-
- this.taskQueryManager.rerunLastQuery()}
-/>
-{
- !noSqlMode &&
- goToSql(this.taskQueryManager.getLastQuery())}
- />
-}
-
-
-
-
taskTableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={taskTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderTaskTable()}
+// tslint:disable-next-line:radix
Review comment:
this is not needed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views
vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r287161036
##
File path: web-console/src/views/servers-view/servers-view.tsx
##
@@ -415,49 +424,58 @@ WHERE "server_type" = 'historical'`);
const { groupByTier } = this.state;
const { serverTableColumnSelectionHandler,
middleManagerTableColumnSelectionHandler } = this;
-return
-
- this.serverQueryManager.rerunLastQuery()}
-/>
-{
- !noSqlMode &&
+return
+
+
goToSql(this.serverQueryManager.getLastQuery())}
+icon={IconNames.REFRESH}
+text="Refresh"
+onClick={() => this.serverQueryManager.rerunLastQuery()}
/>
-}
- this.setState({ groupByTier: !groupByTier })}
-/>
-
serverTableColumnSelectionHandler.changeTableColumnSelection(column)}
- tableColumnsHidden={serverTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderServersTable()}
-
-
-
-
- this.middleManagerQueryManager.rerunLastQuery()}
-/>
-
middleManagerTableColumnSelectionHandler.changeTableColumnSelection(column)}
-
tableColumnsHidden={middleManagerTableColumnSelectionHandler.hiddenColumns}
-/>
-
- {this.renderMiddleManagerTable()}
-;
+ {
+!noSqlMode &&
+ goToSql(this.serverQueryManager.getLastQuery())}
+/>
+ }
+ this.setState({ groupByTier: !groupByTier })}
+ />
+
serverTableColumnSelectionHandler.changeTableColumnSelection(column)}
+
tableColumnsHidden={serverTableColumnSelectionHandler.hiddenColumns}
+ />
+
+{this.renderServersTable()}
+
+
Review comment:
`bottom-pane` plz
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7723: Web-console: add resizable split screen layout to tasks and servers views
vogievetsky commented on a change in pull request #7723: Web-console: add
resizable split screen layout to tasks and servers views
URL: https://github.com/apache/incubator-druid/pull/7723#discussion_r286199454
##
File path: web-console/package.json
##
@@ -35,6 +35,7 @@
},
"dependencies": {
"@blueprintjs/core": "^3.15.1",
+"@types/react-splitter-layout": "^3.0.0",
Review comment:
the types are dev dependancies
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
