[GitHub] [pulsar] congbobo184 commented on issue #5570: Transaction log implemention

[GitBox]

congbobo184 commented on issue #5570: Transaction log implemention
URL: https://github.com/apache/pulsar/pull/5570#issuecomment-563911094
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

svn commit: r37160 [1/2] - in /dev/pulsar/pulsar-2.5.0-candidate-1: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

[sijie]

Author: sijie
Date: Tue Dec 10 07:52:09 2019
New Revision: 37160

Log:
Staging artifacts and signature for Pulsar release 2.5.0

Added:
dev/pulsar/pulsar-2.5.0-candidate-1/
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/Packages.gz   (with props)
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/Packages.gz.asc
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/Packages.gz.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client-dev.deb   
(with props)
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client-dev.deb.asc
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client-dev.deb.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client.deb   (with 
props)
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client.deb.asc
dev/pulsar/pulsar-2.5.0-candidate-1/DEB/apache-pulsar-client.deb.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-2.5.0-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-2.5.0-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-2.5.0-1.x86_64.rpm.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-debuginfo-2.5.0-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-debuginfo-2.5.0-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-debuginfo-2.5.0-1.x86_64.rpm.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-devel-2.5.0-1.x86_64.rpm
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-devel-2.5.0-1.x86_64.rpm.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/apache-pulsar-client-devel-2.5.0-1.x86_64.rpm.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/4dbc2e5e6909ad5c90aa3056b5b6e5d3e2ea05684dc7de9dfe899408db4a89e9-filelists.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/4dbc2e5e6909ad5c90aa3056b5b6e5d3e2ea05684dc7de9dfe899408db4a89e9-filelists.sqlite.bz2.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/4dbc2e5e6909ad5c90aa3056b5b6e5d3e2ea05684dc7de9dfe899408db4a89e9-filelists.sqlite.bz2.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/923534688e8790db826d40479f16f1f41e7cbc74493bdac340a3febfb2c7fc4f-filelists.xml.gz
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/923534688e8790db826d40479f16f1f41e7cbc74493bdac340a3febfb2c7fc4f-filelists.xml.gz.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/923534688e8790db826d40479f16f1f41e7cbc74493bdac340a3febfb2c7fc4f-filelists.xml.gz.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/961c8e56d4fd25890d343e1a6d650b627c85c62612bf1ec148b8fce91a70b520-other.xml.gz
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/961c8e56d4fd25890d343e1a6d650b627c85c62612bf1ec148b8fce91a70b520-other.xml.gz.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/961c8e56d4fd25890d343e1a6d650b627c85c62612bf1ec148b8fce91a70b520-other.xml.gz.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/a27edd82873af28ae34efa055fd9a90111bc868bdcf6a8e17f2b942ac4749671-primary.xml.gz
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/a27edd82873af28ae34efa055fd9a90111bc868bdcf6a8e17f2b942ac4749671-primary.xml.gz.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/a27edd82873af28ae34efa055fd9a90111bc868bdcf6a8e17f2b942ac4749671-primary.xml.gz.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/ee61df6431d6802db8988375904e561e77af1800114f9501b1805b7f3d802077-primary.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/ee61df6431d6802db8988375904e561e77af1800114f9501b1805b7f3d802077-primary.sqlite.bz2.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/ee61df6431d6802db8988375904e561e77af1800114f9501b1805b7f3d802077-primary.sqlite.bz2.sha512

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/feba6e9835863cfc562f0965c1216568e53dab93adbac2b58192b3aceba5ce02-other.sqlite.bz2
   (with props)

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/feba6e9835863cfc562f0965c1216568e53dab93adbac2b58192b3aceba5ce02-other.sqlite.bz2.asc

dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/feba6e9835863cfc562f0965c1216568e53dab93adbac2b58192b3aceba5ce02-other.sqlite.bz2.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/repomd.xml
dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/repomd.xml.asc
dev/pulsar/pulsar-2.5.0-candidate-1/RPMS/repodata/repomd.xml.sha512
dev/pulsar/pulsar-2.5.0-candidate-1/apache-pulsar-2.5.0-bin.tar.gz   (with 
props)
dev/pulsar/pulsar-2.5.0-candidate-1/apache-pulsar-2.5.0-bin.tar.gz.asc
dev/pulsar/pulsar-2.5.0-candidate-1/apache-pulsar-2.5.0-bin.tar.gz.sha512

svn commit: r37160 [2/2] - in /dev/pulsar/pulsar-2.5.0-candidate-1: ./ DEB/ RPMS/ RPMS/repodata/ connectors/

[sijie]

Added: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-file-2.5.0.nar.sha512
==
--- 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-file-2.5.0.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-file-2.5.0.nar.sha512 
Tue Dec 10 07:52:09 2019
@@ -0,0 +1 @@
+5c1ff31c066c114243798c1b641503cb859a7dd85150f3d383623b06c023ba00eb941f789e5404836a2058734cd3376c8c21843d422ef65be9982113d93a25bd
  ./connectors/pulsar-io-file-2.5.0.nar

Added: dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.asc
==
--- 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.asc 
(added)
+++ 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.asc 
Tue Dec 10 07:52:09 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCgAdFiEE2k3oIDhnJWi8g07gWz+9tP10QCwFAl3vRHQACgkQWz+9tP10
+QCz9cg//fY60JvHIVrHJLKKOuH7Ikc7aLzPH1tX1trWh3XWZ2vJpqy3WJJS47/UX
+rzA0CjN80t4XJugelpOylS6hhebxyca4cwCt1GL51hVDOg6dKqkVXzN9AfiBo+8l
+YzA6j0rdrn8oMnZffbNbKQQXpycShlNmaNMUlETt9WSZcvQUkB8PREE6jLQw2x8H
+f9fESWeYrKj+uWsBbonbmacXjqwIk0h9SL40C0quKN2RKN/nQOA2EarTm+me/KQ0
+bBzxH6p4sP1CnF9gq8qgHfu6t3mXZAPPA3AfyeIlVxoZawV4lmn78vmvu9DAFfqQ
+jZ2GHFYJRlkLfOX1Gk/6v1xJBzuebtMSsl32hjZrI7ytDREd0pX7GqmyKBfb9sig
+KSNqK6BzI8ua1V+mVad/zdQAFbb0eTYuG+oAATYB1hoPJzkHNl0O8qkTMSILsDv5
+GDtaR0KoSyTZhRDQdpSXRztP6TKv+X29TKRFURczSqZA7RnUNqlkfcnyzhTHUMDz
+chgIYhDlsfnvvuPCYQxav6V70tNHNSZ3uPi96Rgm+pGMSvH4RVC2QFPt7xp/hi53
+gtvdq4U7EsQyrpCeMKZ/Po4m+89ntRE3XejrQ0XnGaUQSPm+c0+kiyDnK1AZd0+J
+0cCU7/vEpxNaj79Jbu5L7aNo9heBHYdkcRT0vB6YXOLr7ctvsWw=
+=GluW
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.sha512
==
--- 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-flume-2.5.0.nar.sha512 
Tue Dec 10 07:52:09 2019
@@ -0,0 +1 @@
+69a77289c1ca3b9001364bda072835e39147867be44b24830d4b1ef83b58b6fa003a3a118582fffddca92928749ac0f4dbfea304f6c448df54848671042fe42c
  ./connectors/pulsar-io-flume-2.5.0.nar

Added: dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar
==
Binary file - no diff available.

Propchange: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar
--
svn:mime-type = application/octet-stream

Added: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.asc
==
--- 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.asc 
(added)
+++ 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.asc 
Tue Dec 10 07:52:09 2019
@@ -0,0 +1,16 @@
+-BEGIN PGP SIGNATURE-
+
+iQIzBAABCgAdFiEE2k3oIDhnJWi8g07gWz+9tP10QCwFAl3vRHYACgkQWz+9tP10
+QCxlQQ/+PJTGTNAGa606Dy3jb2CrsrLkekU3UREyxf9UEEc99aSh7iNkp1U1Qfg3
+4bGOV5wJ7vM0kvcn36mwS87cn2VaJ/T2Mo29b6w7Kng3c9MltJrUfIJCu50G4f/4
+iFAY7ProvtDwoovpp/QJpCkofaVdIjyBZ7Xs3cb8kHrYFTjxcmXu4cqWjO8QHY7k
+9o+zwYYSQ+KaC730MStpxUF5qhY55rQGzwUL/+tDd2f7tYakWcuVXnVEFFxu3eWF
+CAJYA0B9KHboCKN/LpFp66NHwcqonkZwXfK2KJemesskbvG9ieFQ9wHdET0Mkoyb
+li98mKakq4wR01rBolpIBoJKcCZ3O1YkQc7AJ7fKifFRhHsjUkrM74d+5SEFaqRA
+oGkCagYIzDqgE64negsJxriTh6ci+Gi3zi2wHgHoK6KZbpX9Q5A8LwxK7QUIRsIK
+7eomY5Wo6Cw1URdaDMX8eONdvOOUZh/gI8Z6x+DqooombpVn/aF9Ct+Ax4fTi7SG
+JfmR2rz7OlCxsb60wVVwWK3urFuTZxgS9bXis8B1v4SO+KWXrVGgf6VKU7JPVksS
+TlNWNTBFvcZ+SVBF8L3TqkzVxig2xWxqC39yHpyeSCnmola3myyCdmT6aJrpFSjt
+E9ZKyuXiy7k7m94EU1Q0AvxSHf3qQM4NmULGH2JJw13JK26m5OA=
+=yT4E
+-END PGP SIGNATURE-

Added: 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.sha512
==
--- 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.sha512 
(added)
+++ 
dev/pulsar/pulsar-2.5.0-candidate-1/connectors/pulsar-io-hbase-2.5.0.nar.sha512 
Tue Dec 10 07:52:09 2019
@@ -0,0 +1 @@
+684ba872bc0323a50d8a9cd6b5e85c8e07a22801f7e8676b89b8b191afc6df5f743f5ba954a057255605120442cd1efa8df404db8cd05196713d93d972d75fa6
  ./connectors/pulsar-io-hbase-2.5.0.nar

Added: 

[GitHub] [pulsar-translation] sijia-w commented on issue #12: functions-deploy: sijia-w

[GitBox]

sijia-w commented on issue #12: functions-deploy: sijia-w
URL: https://github.com/apache/pulsar-translation/pull/12#issuecomment-563908650
 
 
   Sylvia,
   感谢你给出的详细解答。
   1. 我已经在本地将 .Rhistory 文件删除；
   2. 关于翻译的问题，我进入 crowdin 网页看到的翻译仍然是正常语序的
   
   [image: WeChatd4cf4cf0032e2966caf7fca369084c05.png]
   谢谢！
   
   On Tue, Dec 10, 2019 at 5:11 AM Sylvia  wrote:
   
   > @sijia-w  上边提到的就是两个问题：
   > 1.你提的这个pr里应该只有 schedule.md 这个文档，不应该出现这个
   > [image: image]
   > 

   > 2.你文档中翻译的有个问题。应该翻译成：可以在 kube、amazon等进行部署，你翻译成了在
   > [image: image]
   > 

   > 然后 Jennifer 已经在 crowdin 的翻译页面给你留言了，你可以去看一下～修改一下就可以。
   >
   > 针对问题1，如果你这个 pr 是在网页端提交的，那你可能需要把这个PR关闭然后重新提交一个只有md
   > 文件的PR；如果你的PR是在本地进行提交的，那你直接去电脑里此repo库的文件夹里删除那个额外的文件即可。
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] gbensa commented on a change in pull request #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector

[GitBox]

gbensa commented on a change in pull request #5829: [Issue 5827][Issue 
5828][netty] Fixes for UDP protocol support in netty connector
URL: https://github.com/apache/pulsar/pull/5829#discussion_r355878236
 
 

 ##
 File path: 
pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
 ##
 @@ -96,7 +96,7 @@ private void runUdp() throws InterruptedException {
 Bootstrap bootstrap = new Bootstrap();
 bootstrap.group(workerGroup);
 bootstrap.channel(NioDatagramChannel.class);
-bootstrap.handler(new NettyChannelInitializer(new 
NettyServerHandler(this.nettySource)))
+bootstrap.handler(new NettyChannelInitializer(new 
NettyUDPServerHandler(this.nettySource)))
 
 Review comment:
   No, the NettyUDPServerHandler is specific to UDP to manage DatagramPacket 
instead of byte[] payloads.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie closed issue #4554: [docs] Improve the structure of Pulsar Functions

[GitBox]

sijie closed issue #4554: [docs] Improve the structure of Pulsar Functions
URL: https://github.com/apache/pulsar/issues/4554
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version

[GitBox]

congbobo184 commented on issue #4847: Pulsar sql avro support schema version
URL: https://github.com/apache/pulsar/pull/4847#issuecomment-563880463
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #5570: Transaction log implemention

[GitBox]

congbobo184 commented on issue #5570: Transaction log implemention
URL: https://github.com/apache/pulsar/pull/5570#issuecomment-563879515
 
 
   run java8 tests
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Sunkwan-Kwon commented on issue #5799: Using the latest release version of pulsar-client-go module from pulsar-function-go

[GitBox]

Sunkwan-Kwon commented on issue #5799: Using the latest release version of 
pulsar-client-go module from pulsar-function-go
URL: https://github.com/apache/pulsar/issues/5799#issuecomment-563876225
 
 
   @wolfstudy Thank you for considering.
   
   By the way, I have a question.
   There is another git repository `https://github.com/apache/pulsar-client-go`.
   What is the difference between that and 
`https://github.com/apache/pulsar/pulsar-client-go`?
   And what would you recommend using for go application?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar-manager] branch master updated: Switch from field injection to constructor injection for beans (#230)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-manager.git


The following commit(s) were added to refs/heads/master by this push:
 new 55693a2  Switch from field injection to constructor injection for 
beans (#230)
55693a2 is described below

commit 55693a2531d82c2466ebc972ae1d6599a9d34a92
Author: Sergii Zhevzhyk 
AuthorDate: Tue Dec 10 05:23:58 2019 +0100

Switch from field injection to constructor injection for beans (#230)

## Motivation

Field injection is not recommended in Spring (for example, IntelliJ shows a 
warning). There are a couple of articles and discussions showing the advantages 
of Constructor-based dependency injection and Setter-based dependency 
injection. For this project, I recommend switching from Field-based dependency 
injection to Constructor-based injection. It should bring better testability, 
immutability, and show problems in design.

## Change

Initialization of all fields which were injected with the `@Autowired` 
annotation was moved to constructors.
---
 .../manager/controller/BookiesController.java  |  6 ++-
 .../manager/controller/BrokerStatsController.java  | 17 ---
 .../manager/controller/BrokerTokensController.java |  9 ++--
 .../manager/controller/BrokersController.java  | 17 ---
 .../manager/controller/ClustersController.java | 17 ---
 .../manager/controller/EnvironmentsController.java | 13 +++--
 .../pulsar/manager/controller/LoginController.java |  6 ++-
 .../manager/controller/NamespacesController.java   | 17 ---
 .../manager/controller/TenantsController.java  | 17 ---
 .../ThirdPartyLoginCallbackController.java |  6 ++-
 .../manager/controller/TopicsController.java   | 17 ---
 .../interceptor/AdminHandlerInterceptor.java   |  9 ++--
 .../service/impl/BrokerStatsServiceImpl.java   | 56 +++---
 .../manager/service/impl/ClustersServiceImpl.java  |  6 ++-
 .../service/impl/EnvironmentCacheServiceImpl.java  |  8 ++--
 .../service/impl/NamespacesServiceImpl.java| 11 +++--
 .../manager/service/impl/TopicsServiceImpl.java| 12 ++---
 .../pulsar/manager/zuul/EnvironmentForward.java|  9 +++-
 .../zuul/LocationHeaderRewritingFilter.java| 11 +++--
 19 files changed, 169 insertions(+), 95 deletions(-)

diff --git 
a/src/main/java/org/apache/pulsar/manager/controller/BookiesController.java 
b/src/main/java/org/apache/pulsar/manager/controller/BookiesController.java
index 7794659..c42f9ac 100644
--- a/src/main/java/org/apache/pulsar/manager/controller/BookiesController.java
+++ b/src/main/java/org/apache/pulsar/manager/controller/BookiesController.java
@@ -34,8 +34,12 @@ import java.util.Map;
 @Validated
 public class BookiesController {
 
+private final BookiesService bookiesService;
+
 @Autowired
-private BookiesService bookiesService;
+public BookiesController(BookiesService bookiesService) {
+this.bookiesService = bookiesService;
+}
 
 @ApiOperation(value = "Get the list of existing bookies, support paging, 
the default is 10 per page")
 @ApiResponses({
diff --git 
a/src/main/java/org/apache/pulsar/manager/controller/BrokerStatsController.java 
b/src/main/java/org/apache/pulsar/manager/controller/BrokerStatsController.java
index 0f75bf3..5f06089 100644
--- 
a/src/main/java/org/apache/pulsar/manager/controller/BrokerStatsController.java
+++ 
b/src/main/java/org/apache/pulsar/manager/controller/BrokerStatsController.java
@@ -38,14 +38,19 @@ import javax.servlet.http.HttpServletRequest;
 @RestController
 public class BrokerStatsController {
 
-@Autowired
-private BrokerStatsService brokerStatsService;
-
-@Autowired
-private EnvironmentCacheService environmentCacheService;
+private final BrokerStatsService brokerStatsService;
+private final EnvironmentCacheService environmentCacheService;
+private final HttpServletRequest request;
 
 @Autowired
-private HttpServletRequest request;
+public BrokerStatsController(
+BrokerStatsService brokerStatsService,
+EnvironmentCacheService environmentCacheService,
+HttpServletRequest request) {
+this.brokerStatsService = brokerStatsService;
+this.environmentCacheService = environmentCacheService;
+this.request = request;
+}
 
 @ApiOperation(value = "Get the broker stats metrics")
 @ApiResponses({
diff --git 
a/src/main/java/org/apache/pulsar/manager/controller/BrokerTokensController.java
 
b/src/main/java/org/apache/pulsar/manager/controller/BrokerTokensController.java
index ab3296d..7cb973b 100644
--- 
a/src/main/java/org/apache/pulsar/manager/controller/BrokerTokensController.java
+++ 
b/src/main/java/org/apache/pulsar/manager/controller/BrokerTokensController.java
@@ -38,11 +38,14 @@ import java.util.Optional;
 @RestController
 public 

[GitHub] [pulsar-translation] SylviaBABY commented on issue #12: functions-deploy: sijia-w

[GitBox]

SylviaBABY commented on issue #12: functions-deploy: sijia-w
URL: https://github.com/apache/pulsar-translation/pull/12#issuecomment-563743352
 
 
   @sijia-w 上边提到的就是两个问题：
   1.你提的这个pr里应该只有 schedule.md 这个文档，不应该出现这个
   
![image](https://user-images.githubusercontent.com/39793568/70494243-8bc72900-1b45-11ea-89c9-1065a08722fd.png)
   2.你文档中翻译的有个问题。应该翻译成：可以在 kube、amazon等进行部署，你翻译成了在
   
![image](https://user-images.githubusercontent.com/39793568/70494308-c8932000-1b45-11ea-89bf-be8f8825164f.png)
   然后 Jennifer 已经在 crowdin 的翻译页面给你留言了，你可以去看一下～修改一下就可以。
   
   针对问题1，如果你这个 pr 是在网页端提交的，那你可能需要把这个PR关闭然后重新提交一个只有md 
文件的PR；如果你的PR是在本地进行提交的，那你直接去电脑里此repo库的文件夹里删除那个额外的文件即可。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar.wiki] branch master updated: Updated Release process (markdown)

[rxl]

This is an automated email from the ASF dual-hosted git repository.

rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 0797c75  Updated Release process (markdown)
0797c75 is described below

commit 0797c7513e76ff55bdc952251cf2b8625506d925
Author: 冉小龙 
AuthorDate: Tue Dec 10 11:43:02 2019 +0800

Updated Release process (markdown)
---
 Release-process.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Release-process.md b/Release-process.md
index 64f9cb3..1b67641 100644
--- a/Release-process.md
+++ b/Release-process.md
@@ -67,6 +67,7 @@ be the final one.
 git commit -m 'Release 2.X.0' -a
 
 # Create a "candidate" tag
+export GPG_TTY=$(tty)
 git tag -u $u...@apache.org v2.X.0-candidate-1 -m 'Release v2.X.0-candidate-1'
 
 # Push both the branch and the tag to Github repo

[pulsar.wiki] branch master updated: Updated Release process (markdown)

[rxl]

This is an automated email from the ASF dual-hosted git repository.

rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 28776b7  Updated Release process (markdown)
28776b7 is described below

commit 28776b748d99e6af4942d8a26cc96e353ecb9f39
Author: 冉小龙 
AuthorDate: Tue Dec 10 11:39:45 2019 +0800

Updated Release process (markdown)
---
 Release-process.md | 14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/Release-process.md b/Release-process.md
index eef9ab4..64f9cb3 100644
--- a/Release-process.md
+++ b/Release-process.md
@@ -263,9 +263,11 @@ will now be made available on Maven central.
 
  11. Publish Docker Images
 
-- a) Trigger the 
[pulsar-release-binaries](https://builds.apache.org/job/pulsar-release-binaries/)
 with the tag name.
-- b) once it is done, check https://hub.docker.com/r/apachepulsar/pulsar/tags/ 
to make sure the docker image is published.
-- c) try to run `docker pull apachepulsar/pulsar:` to fetch the image, 
run the docker in standalone mode and make sure the docker image is okay.
+- a) Run `cd $PULSAR_HOME/docker && ./build.sh` build docker images.
+- b) Run `cd $PULSAR_HOME/docker && ./publish.sh` publish all images, once it 
is done,  check https://hub.docker.com/r/apachepulsar/pulsar/tags/ to make sure 
the docker image is published.
+- c) Try to run `docker pull apachepulsar/pulsar:` to fetch the image, 
run the docker in standalone mode and make sure the docker image is okay.
+
+> Note: ask Matteo or Sijie for adding you as a maintainer for publishing the 
docker images
 
  12. Publish Python Clients
 
@@ -273,7 +275,7 @@ will now be made available on Maven central.
 >
 > 1. you need to create an account on PyPI: 
 > https://pypi.org/project/pulsar-client/
 >
-> 2. ask Matteo or Sijie for adding you as a maintainer for pulsar-client on 
PyPI
+> 2. ask Matteo or Sijie for adding you as a maintainer for pulsar-docker on 
PyPI
 
 # Linux
 
@@ -291,7 +293,7 @@ Run following command to push the built wheel files.
 
 ```shell
 $ cd pulsar-client-cpp/python/wheelhouse
-
+$ pip install twine
 $ twine upload pulsar_client-*.whl
 ```
 
@@ -349,6 +351,8 @@ yarn install
 yarn run version 
 ```
 
+> Note: once it is done, the `versions.json` will be fixed, please move the 
latest version under the old version. Make sure the Algolia index works before 
moving 2.X.0 as the current stable.
+
 After this command, a directory `version-` will be added 
under `site2/website/versioned_docs`. Then,
 
 ```shell

[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version

[GitBox]

congbobo184 commented on issue #4847: Pulsar sql avro support schema version
URL: https://github.com/apache/pulsar/pull/4847#issuecomment-563684906
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version

[GitBox]

congbobo184 commented on issue #4847: Pulsar sql avro support schema version
URL: https://github.com/apache/pulsar/pull/4847#issuecomment-563684732
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version

[GitBox]

congbobo184 commented on issue #4847: Pulsar sql avro support schema version
URL: https://github.com/apache/pulsar/pull/4847#issuecomment-563683549
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on a change in pull request #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector

[GitBox]

jiazhai commented on a change in pull request #5829: [Issue 5827][Issue 
5828][netty] Fixes for UDP protocol support in netty connector
URL: https://github.com/apache/pulsar/pull/5829#discussion_r355825080
 
 

 ##
 File path: 
pulsar-io/netty/src/main/java/org/apache/pulsar/io/netty/server/NettyServer.java
 ##
 @@ -96,7 +96,7 @@ private void runUdp() throws InterruptedException {
 Bootstrap bootstrap = new Bootstrap();
 bootstrap.group(workerGroup);
 bootstrap.channel(NioDatagramChannel.class);
-bootstrap.handler(new NettyChannelInitializer(new 
NettyServerHandler(this.nettySource)))
+bootstrap.handler(new NettyChannelInitializer(new 
NettyUDPServerHandler(this.nettySource)))
 
 Review comment:
   This change lgtm. 
   Just have a question maybe not related with this issue. Since this is 
replaced with `NettyUDPServerHandler`, Is there a need to replace the 
`NettyServerHandler` in function `runTcp` below in line 108?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam commented on issue #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

massakam commented on issue #5823: [pulsar-client] Ensure that the same message 
ID is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823#issuecomment-563661283
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar.wiki] branch master updated: Updated Create GPG keys to sign release artifacts (markdown)

[rxl]

This is an automated email from the ASF dual-hosted git repository.

rxl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 004d480  Updated Create GPG keys to sign release artifacts (markdown)
004d480 is described below

commit 004d4804c484863e714ac1dfa0e06f811bfced52
Author: 冉小龙 
AuthorDate: Tue Dec 10 11:07:24 2019 +0800

Updated Create GPG keys to sign release artifacts (markdown)
---
 Create-GPG-keys-to-sign-release-artifacts.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Create-GPG-keys-to-sign-release-artifacts.md 
b/Create-GPG-keys-to-sign-release-artifacts.md
index 19a670f..3030ef8 100644
--- a/Create-GPG-keys-to-sign-release-artifacts.md
+++ b/Create-GPG-keys-to-sign-release-artifacts.md
@@ -110,6 +110,8 @@ svn ci -m "Added gpg key for $USER"
 
 Repeat the same operation for the release KEYS file:
 
+> If you are not PMC, you can ignore it.
+
 ```shell
 svn co https://dist.apache.org/repos/dist/release/incubator/pulsar 
pulsar-dist-release
 cd pulsar-dist-release

[GitHub] [pulsar] jiazhai commented on issue #5828: Netty UDP connector doesn't work

[GitBox]

jiazhai commented on issue #5828: Netty UDP connector doesn't work
URL: https://github.com/apache/pulsar/issues/5828#issuecomment-563652319
 
 
   Thanks @gbensa for the issue and PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5832: NullPointerException throwed by Debezium Connector when a row deleted

[GitBox]

jiazhai commented on issue #5832: NullPointerException throwed by Debezium 
Connector  when  a row deleted
URL: https://github.com/apache/pulsar/issues/5832#issuecomment-563648051
 
 
   Thanks @xiemeilong for help reporting this issue. This is a special case 
that we should fix. And seems it is clear that we need to fix the Null value in 
`KeyValue.encode(KeyValue.java:101)`.  
   
   @tuteng  to help take a look.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] congbobo184 commented on issue #4847: Pulsar sql avro support schema version

[GitBox]

congbobo184 commented on issue #4847: Pulsar sql avro support schema version
URL: https://github.com/apache/pulsar/pull/4847#issuecomment-563596889
 
 
   run java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] xiemeilong opened a new issue #5832: NullPointerException throwed by Debezium Connector when there is a row deleted

[GitBox]

xiemeilong opened a new issue #5832: NullPointerException throwed by Debezium 
Connector  when there is a row deleted
URL: https://github.com/apache/pulsar/issues/5832
 
 
   **Describe the bug**
   Debezium Connector will throw NullPointerException and shutdown  when a row 
is deleted anytime.
   
   **To Reproduce**
   1. run a new Debezium Connector  pulsar io instance
   2. delete a row in mysql
   3. NullPointerException is throwed by Connector  
   
   **Expected behavior**
   delete transaction in bin log is write into pulsar normally
   
   **Screenshots**
   
   
   **Desktop (please complete the following information):**
- k8s
   -  apachepulsar/pulsar-all:2.4.2
   
   **Additional context**
   log
   ```
   02:04:28.729 [iot/pipe/iot-mysql-log-test1-source-0] INFO  
org.apache.pulsar.functions.instance.JavaInstanceRunnable - Encountered 
exception in sink write: 
   java.lang.NullPointerException: null
   at 
org.apache.pulsar.common.schema.KeyValue.encode(KeyValue.java:101) 
~[java-instance.jar:?]
   at 
org.apache.pulsar.client.impl.schema.KeyValueSchema.encode(KeyValueSchema.java:128)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.client.impl.schema.KeyValueSchema.encode(KeyValueSchema.java:37)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.client.impl.TypedMessageBuilderImpl.value(TypedMessageBuilderImpl.java:116)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.functions.sink.PulsarSink.write(PulsarSink.java:282) 
~[org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.sendOutputMessage(JavaInstanceRunnable.java:445)
 [org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.processResult(JavaInstanceRunnable.java:428)
 [org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:282)
 [org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]
   02:04:28.735 [iot/pipe/iot-mysql-log-test1-source-0] WARN  
org.apache.pulsar.functions.instance.JavaInstanceRunnable - Failed to process 
result of message 
org.apache.pulsar.io.kafka.connect.KafkaConnectSource$KafkaSourceRecord@6b986037
   java.lang.RuntimeException: java.lang.NullPointerException
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.sendOutputMessage(JavaInstanceRunnable.java:449)
 ~[org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.processResult(JavaInstanceRunnable.java:428)
 ~[org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.run(JavaInstanceRunnable.java:282)
 [org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]
   Caused by: java.lang.NullPointerException
   at 
org.apache.pulsar.common.schema.KeyValue.encode(KeyValue.java:101) 
~[java-instance.jar:?]
   at 
org.apache.pulsar.client.impl.schema.KeyValueSchema.encode(KeyValueSchema.java:128)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.client.impl.schema.KeyValueSchema.encode(KeyValueSchema.java:37)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.client.impl.TypedMessageBuilderImpl.value(TypedMessageBuilderImpl.java:116)
 ~[org.apache.pulsar-pulsar-client-original-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.functions.sink.PulsarSink.write(PulsarSink.java:282) 
~[org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:2.4.2]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.sendOutputMessage(JavaInstanceRunnable.java:445)
 ~[org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   ... 3 more
   02:04:28.742 [iot/pipe/iot-mysql-log-test1-source-0] INFO  
org.apache.pulsar.functions.instance.JavaInstanceRunnable - Encountered 
exception in source read: 
   java.util.concurrent.ExecutionException: java.lang.Exception: Sink Error
   at 
java.util.concurrent.CompletableFuture.reportGet(CompletableFuture.java:357) 
~[?:1.8.0_232]
   at 
java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1908) 
~[?:1.8.0_232]
   at 
org.apache.pulsar.io.kafka.connect.KafkaConnectSource.read(KafkaConnectSource.java:148)
 ~[pulsar-io-kafka-connect-adaptor-2.4.2.jar:?]
   at 
org.apache.pulsar.functions.instance.JavaInstanceRunnable.readInput(JavaInstanceRunnable.java:461)
 [org.apache.pulsar-pulsar-functions-instance-2.4.2.jar:?]
   at 

[GitHub] [pulsar-client-go] jiazhai closed issue #31: Talk about `send` interface logic

[GitBox]

jiazhai closed issue #31: Talk about `send` interface logic 
URL: https://github.com/apache/pulsar-client-go/issues/31
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #31: Talk about `send` interface logic

[GitBox]

jiazhai commented on issue #31: Talk about `send` interface logic 
URL: https://github.com/apache/pulsar-client-go/issues/31#issuecomment-563578823
 
 
   seems already get a conclusion. would like to close this issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] sunlc210 commented on issue #76: Transfer data is blocked by flush

[GitBox]

sunlc210 commented on issue #76: Transfer data is blocked by flush
URL: https://github.com/apache/pulsar-client-go/issues/76#issuecomment-563575383
 
 
   @reugn In fact, I've set false too, which seems useless


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam commented on issue #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

massakam commented on issue #5823: [pulsar-client] Ensure that the same message 
ID is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823#issuecomment-563573426
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] sunlc210 commented on issue #114: The pulsar go client missing data when transfer

[GitBox]

sunlc210 commented on issue #114:  The pulsar go client missing data when 
transfer
URL: 
https://github.com/apache/pulsar-client-go/issues/114#issuecomment-563572107
 
 
   I'm sorry, I can't use goclient, but I sent the data file to @xiaolong and 
@tuteng


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] fanyunbojerry commented on issue #5713: avoid unsafe split when validate hostname which might be ipv6 address

[GitBox]

fanyunbojerry commented on issue #5713: avoid unsafe split when validate 
hostname which might be ipv6 address
URL: https://github.com/apache/pulsar/pull/5713#issuecomment-563568929
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] merlimat merged pull request #116: [Issue #112] Move license_test from project root; change package name

[GitBox]

merlimat merged pull request #116: [Issue #112] Move license_test from project 
root; change package name
URL: https://github.com/apache/pulsar-client-go/pull/116
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar-client-go] branch master updated: move license_test from project root; change package name (#116)

[mmerli]

This is an automated email from the ASF dual-hosted git repository.

mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-client-go.git


The following commit(s) were added to refs/heads/master by this push:
 new e65b479  move license_test from project root; change package name 
(#116)
e65b479 is described below

commit e65b4795a5928d7989c3089dca5e5243439160dd
Author: Reugn 
AuthorDate: Tue Dec 10 03:47:35 2019 +0200

move license_test from project root; change package name (#116)
---
 go.mod   | 1 -
 go.sum   | 2 --
 license_test.go => integration-tests/license_test.go | 6 +++---
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/go.mod b/go.mod
index 339748e..bdbadf1 100644
--- a/go.mod
+++ b/go.mod
@@ -16,5 +16,4 @@ require (
github.com/spf13/cobra v0.0.3
github.com/spf13/pflag v1.0.3 // indirect
github.com/stretchr/testify v1.3.0
-   github.com/valyala/gozstd v1.4.1
 )
diff --git a/go.sum b/go.sum
index c3fdcf6..3d8be2a 100644
--- a/go.sum
+++ b/go.sum
@@ -34,7 +34,5 @@ github.com/stretchr/objx v0.1.1/go.mod 
h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+
 github.com/stretchr/testify v1.2.2/go.mod 
h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=
 github.com/stretchr/testify v1.3.0 
h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
 github.com/stretchr/testify v1.3.0/go.mod 
h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
-github.com/valyala/gozstd v1.4.1 
h1:3/+pPStlV5Py2TsGhzNUItnYgX2yaX2tHMw/32c/0dM=
-github.com/valyala/gozstd v1.4.1/go.mod 
h1:oYOS+oJovjw9ewtrwEYb9+ybolEXd6pHyLMuAWN5zts=
 golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33 
h1:I6FyU15t786LL7oL/hn43zqTuEGr4PN7F4XJ1p4E3Y8=
 golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod 
h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
diff --git a/license_test.go b/integration-tests/license_test.go
similarity index 95%
rename from license_test.go
rename to integration-tests/license_test.go
index 84998c5..2613e25 100644
--- a/license_test.go
+++ b/integration-tests/license_test.go
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package main
+package license_test
 
 import (
"io/ioutil"
@@ -65,11 +65,11 @@ var otherCheck = regexp.MustCompile(`#
 `)
 
 var skip = map[string]bool{
-   "pkg/pb/PulsarApi.pb.go": true,
+   "../pkg/pb/PulsarApi.pb.go": true,
 }
 
 func TestLicense(t *testing.T) {
-   err := filepath.Walk(".", func(path string, fi os.FileInfo, err error) 
error {
+   err := filepath.Walk("../.", func(path string, fi os.FileInfo, err 
error) error {
if skip[path] {
return nil
}

[GitHub] [pulsar] massakam commented on issue #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

massakam commented on issue #5823: [pulsar-client] Ensure that the same message 
ID is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823#issuecomment-563512341
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] cckellogg opened a new pull request #117: Add metadata to produce and subscribe commands.

[GitBox]

cckellogg opened a new pull request #117: Add metadata to produce and subscribe 
commands.
URL: https://github.com/apache/pulsar-client-go/pull/117
 
 
   ### Motivation
   
   Add the metadata to the produce and subscribe commands (the other clients 
support this) so the properties from the configs will show up in the topic 
stats response from the brokers.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie opened a new issue #5831: [doc] Add a section to document function types and schema

[GitBox]

sijie opened a new issue #5831: [doc] Add a section to document function types 
and schema
URL: https://github.com/apache/pulsar/issues/5831
 
 
    Problem
   
   This task is used for tracking adding a section in functions documentation 
about the function argument types and schema.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar.wiki] branch master updated: Updated Tools and Tips (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 2204ab1  Updated Tools and Tips (markdown)
2204ab1 is described below

commit 2204ab124ee5e99782e05c220c909caf7c4b54b8
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:41:25 2019 -0800

Updated Tools and Tips (markdown)
---
 Tools-and-Tips.md | 4 
 1 file changed, 4 insertions(+)

diff --git a/Tools-and-Tips.md b/Tools-and-Tips.md
index c8272a0..55202a3 100644
--- a/Tools-and-Tips.md
+++ b/Tools-and-Tips.md
@@ -1,5 +1,9 @@
 This page documents the tools that Pulsar PMC used for project management.
 
+### Gitbox
+
+Committers can use [Gitbox](https://gitbox.apache.org/setup/) to link their 
Github accounts with Apache Ids.
+
 ### Github
 
 Github is used for issue and pull request management.

[pulsar.wiki] branch master updated: Created Tools and Tips (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new c607a95  Created Tools and Tips (markdown)
c607a95 is described below

commit c607a95f16fd9c347ad36bd02d50420c429211b4
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:40:16 2019 -0800

Created Tools and Tips (markdown)
---
 Tools-and-Tips.md | 51 +++
 1 file changed, 51 insertions(+)

diff --git a/Tools-and-Tips.md b/Tools-and-Tips.md
new file mode 100644
index 000..c8272a0
--- /dev/null
+++ b/Tools-and-Tips.md
@@ -0,0 +1,51 @@
+This page documents the tools that Pulsar PMC used for project management.
+
+### Github
+
+Github is used for issue and pull request management.
+
+### CI
+
+Currently Pulsar is using [ASF jenkins](https://builds.apache.org/) for CI. 
The community is working on moving to using Github Actions for Pulsar CI jobs.
+
+### Docker
+
+All the docker images are published to [Docker 
Hub](https://hub.docker.com/u/apachepulsar).
+
+A new release manager should request other committers to grant write 
permissions to this docker organization when doing a release.
+
+### Crowdin
+
+We use [Crowdin](https://crowdin.com/) for managing translations for Pulsar 
documentation.
+
+Everyone can join the [pulsar 
project](https://crowdin.com/project/apache-pulsar) to help translations.
+
+Pulsar Committers can request other committers (who are Manager of the Pulsar 
crowdin project) to become *Managers*.
+
+### PyPI
+
+We publish python clients to [PyPI](https://pypi.org/project/pulsar/).
+
+A new release manager should request other committers to grant write 
permissions to Pulsar pypi repo prior to doing a release.
+
+### Vagrant
+
+We use Vagrant images for building python clients for different osx versions.
+
+Those Vagrant images are available 
[here](https://app.vagrantup.com/apachepulsar).
+
+If a Pulsar committer wants to update the images, please reach out to PMC for 
granting corresponding permissions.
+
+### Slack
+
+We use Slack for instant communication. The apache pulsar slack channel is 
managed under Pulsar PMC. 
+
+If a Pulsar PMC member wants to administrate the slack channel, reach out to 
PMC for granting the permissions.
+
+### Twitter
+
+The `@apache_pulsar` twitter account is managed under Pulsar PMC. If a Pulsar 
PMC member wants to use this account to tweet project updates, please reach out 
the PMC for granting the permissions.
+
+### Google Analytics
+
+We used Google Analytics for tracking and analyzing traffic to Pulsar website. 
The Google Analytics account is managed under Pulsar PMC. If a Pulsar PMC 
member wants to use this account, please reach out the PMC for granting the 
permissions. 
\ No newline at end of file

[pulsar.wiki] branch master updated: Updated Home (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new f1a0c53  Updated Home (markdown)
f1a0c53 is described below

commit f1a0c53442697556189de805d58de06ff087deb8
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:23:54 2019 -0800

Updated Home (markdown)
---
 Home.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Home.md b/Home.md
index 37a2826..9866939 100644
--- a/Home.md
+++ b/Home.md
@@ -74,4 +74,4 @@ We encourage to document any big change or feature or any 
addition to public use
  * [Create GPG keys to sign release 
artifacts](https://github.com/apache/incubator-pulsar/wiki/Create-GPG-keys-to-sign-release-artifacts)
  * [Release 
process](https://github.com/apache/incubator-pulsar/wiki/Release-process)
  * [Client features 
matrix](https://github.com/apache/incubator-pulsar/wiki/Client-Features-Matrix)
- * [[Committer and PMC member onboarding process]]
+ * [[Tools and Tips]]

[pulsar.wiki] branch master updated: Updated Home (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 6037194  Updated Home (markdown)
6037194 is described below

commit 60371945d1f9f005895360abb4b00aea2920eef5
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:22:14 2019 -0800

Updated Home (markdown)
---
 Home.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Home.md b/Home.md
index 85f3e23..37a2826 100644
--- a/Home.md
+++ b/Home.md
@@ -74,4 +74,4 @@ We encourage to document any big change or feature or any 
addition to public use
  * [Create GPG keys to sign release 
artifacts](https://github.com/apache/incubator-pulsar/wiki/Create-GPG-keys-to-sign-release-artifacts)
  * [Release 
process](https://github.com/apache/incubator-pulsar/wiki/Release-process)
  * [Client features 
matrix](https://github.com/apache/incubator-pulsar/wiki/Client-Features-Matrix)
- * [[Committer & PMC Member Onboarding Process]]
+ * [[Committer and PMC member onboarding process]]

[pulsar.wiki] branch master updated: Updated Home (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new fe54c26  Updated Home (markdown)
fe54c26 is described below

commit fe54c267af81a7079b2aa9e2b559378baeab2d3e
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:20:09 2019 -0800

Updated Home (markdown)
---
 Home.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Home.md b/Home.md
index acfe4d1..85f3e23 100644
--- a/Home.md
+++ b/Home.md
@@ -74,3 +74,4 @@ We encourage to document any big change or feature or any 
addition to public use
  * [Create GPG keys to sign release 
artifacts](https://github.com/apache/incubator-pulsar/wiki/Create-GPG-keys-to-sign-release-artifacts)
  * [Release 
process](https://github.com/apache/incubator-pulsar/wiki/Release-process)
  * [Client features 
matrix](https://github.com/apache/incubator-pulsar/wiki/Client-Features-Matrix)
+ * [[Committer & PMC Member Onboarding Process]]

[pulsar.wiki] branch master updated: Updated Home (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new 3943270  Updated Home (markdown)
3943270 is described below

commit 3943270f807eb0629fbebba97dd3350700d0a1d7
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:08:42 2019 -0800

Updated Home (markdown)
---
 Home.md | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Home.md b/Home.md
index 99127f9..acfe4d1 100644
--- a/Home.md
+++ b/Home.md
@@ -74,4 +74,3 @@ We encourage to document any big change or feature or any 
addition to public use
  * [Create GPG keys to sign release 
artifacts](https://github.com/apache/incubator-pulsar/wiki/Create-GPG-keys-to-sign-release-artifacts)
  * [Release 
process](https://github.com/apache/incubator-pulsar/wiki/Release-process)
  * [Client features 
matrix](https://github.com/apache/incubator-pulsar/wiki/Client-Features-Matrix)
- * [[Committer Onboard Process]]

[pulsar.wiki] branch master updated: Updated Home (markdown)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.wiki.git


The following commit(s) were added to refs/heads/master by this push:
 new b6ecb57  Updated Home (markdown)
b6ecb57 is described below

commit b6ecb571588bf4cf34e7c99223edff8d7ab98bd9
Author: Sijie Guo 
AuthorDate: Mon Dec 9 12:07:44 2019 -0800

Updated Home (markdown)
---
 Home.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Home.md b/Home.md
index acfe4d1..99127f9 100644
--- a/Home.md
+++ b/Home.md
@@ -74,3 +74,4 @@ We encourage to document any big change or feature or any 
addition to public use
  * [Create GPG keys to sign release 
artifacts](https://github.com/apache/incubator-pulsar/wiki/Create-GPG-keys-to-sign-release-artifacts)
  * [Release 
process](https://github.com/apache/incubator-pulsar/wiki/Release-process)
  * [Client features 
matrix](https://github.com/apache/incubator-pulsar/wiki/Client-Features-Matrix)
+ * [[Committer Onboard Process]]

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #116: [Issue #112] Move license_test from project root; change package name

[GitBox]

cckellogg commented on a change in pull request #116: [Issue #112] Move 
license_test from project root; change package name
URL: https://github.com/apache/pulsar-client-go/pull/116#discussion_r355657873
 
 

 ##
 File path: integration-tests/license_test.go
 ##
 @@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-package main
+package license_test
 
 Review comment:
   Will this fix the go get build issue? Is there a way to test it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

sijie commented on issue #5823: [pulsar-client] Ensure that the same message ID 
is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823#issuecomment-563391703
 
 
   moved this to 2.5.1 since I have cut branch-2.5.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] Jim-Lambert-Bose commented on issue #112: Can't install go module.

[GitBox]

Jim-Lambert-Bose commented on issue #112: Can't install go module.
URL: 
https://github.com/apache/pulsar-client-go/issues/112#issuecomment-563390752
 
 
   I agree, your solution is better and should fix the issue.  `go get` was 
able to download @latest version of the module, but since the "build" failed 
(with only test files in the root dir) the go tooling would not update the 
go.mod file in my project that used the pulsar client... effectively, the 
module was "installed" but the tooling didn't auto-magically update the go.mod 
file... this meant I could test locally, but there's no way I'd be able to use 
the @latest version in my deployments.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] Jim-Lambert-Bose commented on issue #112: Can't install go module.

[GitBox]

Jim-Lambert-Bose commented on issue #112: Can't install go module.
URL: 
https://github.com/apache/pulsar-client-go/issues/112#issuecomment-563390978
 
 
   Feel free to close my PR since it's superseded by your PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] reugn commented on issue #76: Transfer data is blocked by flush

[GitBox]

reugn commented on issue #76: Transfer data is blocked by flush
URL: https://github.com/apache/pulsar-client-go/issues/76#issuecomment-563390089
 
 
   @sunlc210 why do you set flushImmediately flag to true and then explicitly 
call the blocking Flush method?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] wolfstudy commented on issue #29: Talk about `Buffer` interface

[GitBox]

wolfstudy commented on issue #29: Talk about `Buffer` interface
URL: https://github.com/apache/pulsar-client-go/issues/29#issuecomment-563387307
 
 
   The issue has been resolved.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] wolfstudy closed issue #29: Talk about `Buffer` interface

[GitBox]

wolfstudy closed issue #29: Talk about `Buffer` interface
URL: https://github.com/apache/pulsar-client-go/issues/29
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] wolfstudy closed issue #15: [Consumer && Message Impl] Thinking about some code design

[GitBox]

wolfstudy closed issue #15: [Consumer && Message Impl] Thinking about some code 
design
URL: https://github.com/apache/pulsar-client-go/issues/15
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] wolfstudy commented on issue #15: [Consumer && Message Impl] Thinking about some code design

[GitBox]

wolfstudy commented on issue #15: [Consumer && Message Impl] Thinking about 
some code design
URL: https://github.com/apache/pulsar-client-go/issues/15#issuecomment-563386705
 
 
   > @wolfstudy Is this issue still need?
   
   Yes, will close the issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5824: Publish a blog post to apache pulsar blog

[GitBox]

wolfstudy commented on issue #5824: Publish a blog post to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#issuecomment-563381135
 
 
   Thanks @codelipenghui work for this, fixed done, please take a look again, 
thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy opened a new pull request #5830: Update website stable version to 2.4.2

[GitBox]

wolfstudy opened a new pull request #5830: Update website stable version to 
2.4.2
URL: https://github.com/apache/pulsar/pull/5830
 
 
   Signed-off-by: xiaolong.ran 
   
   ### Motivation
   
   Apache Pulsar 2.4.2 has been done, but we can see that the stable version of 
the [website](https://pulsar.apache.org/en/) is 2.4.1. That was done 
intentionally to get around the website indexing issue. 
   
   Currently, Apache Pulsar's website indexing uses the **Algolia** framework, 
which takes some time. In Apache Pulsar 2.4.1,  users are complaining the 
website search is broken, this is the problem.
   
   So in release 2.4.2, we published 2.4.2 documentation but didn't promote it 
as the current stable. We will make sure the  **Algolia** index works before 
moving 2.4.2 as the current stable.
   
   In next release, we can think about how to improve the website update 
process for a release.
   
   ### Modifications
   
   - Update website stable version to 2.4.2
   
   > NOTE: Please don't merge the pull request before the  **Algolia** index 
works.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] reugn commented on issue #112: Can't install go module.

[GitBox]

reugn commented on issue #112: Can't install go module.
URL: 
https://github.com/apache/pulsar-client-go/issues/112#issuecomment-563374374
 
 
   @Jim-Lambert-Bose why do you need to build it?
   And what do you mean by 
   > go.mod file is not updated to reflect the new version.
   
   I think this dummy main file is redundant.
   Opened a PR #116 to tidy this out a bit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] reugn opened a new pull request #116: [Issue #112] Move license_test from project root; change package name

[GitBox]

reugn opened a new pull request #116: [Issue #112] Move license_test from 
project root; change package name
URL: https://github.com/apache/pulsar-client-go/pull/116
 
 
   Master Issue: #112 
   
   ### Motivation
   Dummy main file is not a good solution
   
   ### Modifications
   1. Move license_test file from project root
   2. Change file package
   3. go mod tidy
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #5821: [build] Allow skipping deploying docker artifacts to maven repo

[GitBox]

sijie merged pull request #5821: [build] Allow skipping deploying docker 
artifacts to maven repo
URL: https://github.com/apache/pulsar/pull/5821
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (702790a -> 9a650a4)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 702790a  Bump version to 2.6.0 (#5820)
 add 9a650a4  [build] Allow skipping deploying docker artifacts to maven 
repo (#5821)

No new revisions were added by this update.

Summary of changes:
 dashboard/pom.xml | 11 +++
 docker/pom.xml| 11 +++
 2 files changed, 22 insertions(+)

[GitHub] [pulsar] digi691 commented on issue #5417: Broker hangs and crashes when listing non-persistent topics

[GitBox]

digi691 commented on issue #5417: Broker hangs and crashes when listing 
non-persistent topics
URL: https://github.com/apache/pulsar/issues/5417#issuecomment-563350359
 
 
   @tuteng will talk to my team about upgrading our test environment.  
Hopefully I will be able to get to testing 2.4.2 within the next couple of 
weeks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] gbensa opened a new pull request #5829: [Issue 5827][Issue 5828][netty] Fixes for UDP protocol support in netty connector

[GitBox]

gbensa opened a new pull request #5829: [Issue 5827][Issue 5828][netty] Fixes 
for UDP protocol support in netty connector
URL: https://github.com/apache/pulsar/pull/5829
 
 
   Fixes #5827
   Fixes #5828
   
   ### Motivation
   UDP protocol is not working for netty connector
   
   ### Modifications
   Added a specific handler for UDP and use Channel instead of SocketChannel in 
NettyChannelInitializer
   
   Successfully tested
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (8a20d9a -> 702790a)

[sijie]

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from 8a20d9a  [Issue:4753] Add encryption docs to Functions develop (#5781)
 add 702790a  Bump version to 2.6.0 (#5820)

No new revisions were added by this update.

Summary of changes:
 buildtools/pom.xml| 2 +-
 dashboard/pom.xml | 2 +-
 distribution/io/pom.xml   | 2 +-
 distribution/offloaders/pom.xml   | 2 +-
 distribution/pom.xml  | 2 +-
 distribution/server/pom.xml   | 2 +-
 docker/grafana/pom.xml| 2 +-
 docker/pom.xml| 2 +-
 docker/pulsar-all/pom.xml | 2 +-
 docker/pulsar-standalone/pom.xml  | 2 +-
 docker/pulsar/pom.xml | 2 +-
 examples/flink/pom.xml| 2 +-
 examples/pom.xml  | 2 +-
 examples/spark/pom.xml| 2 +-
 jclouds-shaded/pom.xml| 2 +-
 managed-ledger/pom.xml| 2 +-
 pom.xml   | 2 +-
 protobuf-shaded/pom.xml   | 4 ++--
 pulsar-broker-auth-athenz/pom.xml | 2 +-
 pulsar-broker-auth-sasl/pom.xml   | 2 +-
 pulsar-broker-common/pom.xml  | 2 +-
 pulsar-broker-shaded/pom.xml  | 2 +-
 pulsar-broker/pom.xml | 2 +-
 pulsar-client-1x-base/pom.xml | 2 +-
 pulsar-client-1x-base/pulsar-client-1x/pom.xml| 2 +-
 pulsar-client-1x-base/pulsar-client-2x-shaded/pom.xml | 2 +-
 pulsar-client-admin-shaded/pom.xml| 2 +-
 pulsar-client-admin/pom.xml   | 2 +-
 pulsar-client-all/pom.xml | 2 +-
 pulsar-client-api/pom.xml | 2 +-
 pulsar-client-auth-athenz/pom.xml | 2 +-
 pulsar-client-auth-sasl/pom.xml   | 2 +-
 pulsar-client-kafka-compat/pom.xml| 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-shaded/pom.xml | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-shaded_0_8/pom.xml | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-shaded_0_9/pom.xml | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-tests/pom.xml  | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-tests_0_8/pom.xml  | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka-tests_0_9/pom.xml  | 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka/pom.xml| 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka_0_8/pom.xml| 2 +-
 pulsar-client-kafka-compat/pulsar-client-kafka_0_9/pom.xml| 2 +-
 pulsar-client-shaded/pom.xml  | 2 +-
 pulsar-client-tools-test/pom.xml  | 2 +-
 pulsar-client-tools/pom.xml   | 2 +-
 pulsar-client/pom.xml | 2 +-
 pulsar-common/pom.xml | 2 +-
 pulsar-discovery-service/pom.xml  | 2 +-
 pulsar-flink/pom.xml  | 2 +-
 pulsar-functions/api-java/pom.xml | 2 +-
 pulsar-functions/instance/pom.xml | 2 +-
 pulsar-functions/java-examples/pom.xml| 2 +-
 pulsar-functions/localrun-shaded/pom.xml  | 2 +-
 pulsar-functions/localrun/pom.xml | 2 +-
 pulsar-functions/pom.xml  | 2 +-
 pulsar-functions/proto/pom.xml| 2 +-
 pulsar-functions/runtime-all/pom.xml  | 2 +-
 pulsar-functions/runtime/pom.xml  | 2 +-
 pulsar-functions/secrets/pom.xml  | 2 +-
 pulsar-functions/utils/pom.xml| 2 +-
 pulsar-functions/worker/pom.xml   | 2 +-
 pulsar-io/aerospike/pom.xml   | 2 +-
 pulsar-io/canal/pom.xml   

[GitHub] [pulsar] sijie merged pull request #5820: Bump version to 2.6.0

[GitBox]

sijie merged pull request #5820: Bump version to 2.6.0
URL: https://github.com/apache/pulsar/pull/5820
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #5821: [build] Allow skipping deploying docker artifacts to maven repo

[GitBox]

tuteng commented on issue #5821: [build] Allow skipping deploying docker 
artifacts to maven repo
URL: https://github.com/apache/pulsar/pull/5821#issuecomment-563296791
 
 
   run cpp tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-translation] July-liu opened a new pull request #14: Administration-upgrade

[GitBox]

July-liu opened a new pull request #14: Administration-upgrade
URL: https://github.com/apache/pulsar-translation/pull/14
 
 
   
   ### Motivation
   
   Translate administration-upgrade file
   
   ### Modifications
   
   Update the translation schedule
   To check the translated file, refer to 
https://crowdin.com/translate/apache-pulsar/768/en-zhcn#158642
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] gbensa opened a new issue #5828: Netty UDP connector doesn't work

[GitBox]

gbensa opened a new issue #5828: Netty UDP connector doesn't work
URL: https://github.com/apache/pulsar/issues/5828
 
 
   NettyServerHandler doesn't work for UDP as it will receive DatagramPacket 
instead of byte[]
   
   I managed to make the UDP connector working using a new 
NettyUDPServerHandler :
   
   public class NettyUDPServerHandler extends 
SimpleChannelInboundHandler {
   
   private static final Logger logger = 
LoggerFactory.getLogger(NettyUDPServerHandler.class);
   private NettySource nettySource;
   
   public NettyUDPServerHandler(NettySource nettySource) {
   this.nettySource = nettySource;
   }
   
   @Override
   protected void channelRead0(ChannelHandlerContext channelHandlerContext, 
DatagramPacket packet) throws Exception {
   ByteBuf buf = packet.content();
   byte[] bytes = new byte[buf.readableBytes()];
   buf.readBytes(bytes);
   buf.retain();
   nettySource.consume(new NettyRecord(Optional.ofNullable(""), bytes));
   }
   
   @Override
   public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
   logger.error("Error when processing incoming data", cause);
   ctx.close();
   }
   
   @Data
   static private class NettyRecord implements Record, Serializable 
{
   private final Optional key;
   private final byte[] value;
   }
   
   }


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] Jim-Lambert-Bose opened a new pull request #115: [Issue #112] Fix installation of go module

[GitBox]

Jim-Lambert-Bose opened a new pull request #115: [Issue #112] Fix installation 
of go module
URL: https://github.com/apache/pulsar-client-go/pull/115
 
 
   <--
   ### Contribution Checklist
 
 - Name the pull request in the form "[Issue XYZ][component] Title of the 
pull request", where *XYZ* should be replaced by the actual issue number.
   Skip *Issue XYZ* if there is no associated github issue for this pull 
request.
   Skip *component* if you are unsure about which is the best component. 
E.g. `[docs] Fix typo in produce method`.
   
 - Fill out the template below to describe the changes contributed by the 
pull request. That will give reviewers the context they need to do the review.
 
 - Each pull request should address only one issue, not mix up code from 
multiple issues.
 
 - Each commit in the pull request has a meaningful commit message
   
 - Once all items of the checklist are addressed, remove the above text and 
this checklist, leaving only the filled out template below.
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   *(If this PR fixes a github issue, please add `Fixes #`.)*
   
   Fixes #
   
   *(or if this PR is one task of a github issue, please add `Master Issue: 
#` to link to the master issue.)*
   
   Master Issue: #
   
   ### Motivation
   
   Fix the installation of the client's go module: 
github.com/apache/pulsar-client-go
   With this change, no one can install the client using the standard `go get` 
tool chain
   
   ### Modifications
   
   Added a no_code.go source file to the root directory.  This is required the 
module currently won't install because the only source in the root directory is 
licence_test.go (which walks the source tree looking for license txt in each 
file).
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API:  no
 - The schema: no 
 - The default values of configurations: no
 - The wire protocol: no
   
   ### Documentation
   
   No need for documentation besides the comments in the no_code.go source 
file.  If the project changes how licensing is checked, then this change can be 
reverted.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] gbensa opened a new issue #5827: Netty UDP connector ClassCastException

[GitBox]

gbensa opened a new issue #5827: Netty UDP connector ClassCastException
URL: https://github.com/apache/pulsar/issues/5827
 
 
   When trying to create a Netty udp connector, a ClassCastException is thrown
   
   configs:
   type: "udp"
   host: "127.0.0.1"
   port: 10999
   numberOfThreads: 1
   
   Exception : 
   12:50:43.259 [nioEventLoopGroup-6-1] WARN  
io.netty.channel.ChannelInitializer - Failed to initialize a channel. Closing: 
[id: 0xbeba8942]
   java.lang.ClassCastException: io.netty.channel.socket.nio.NioDatagramChannel 
cannot be cast to io.netty.channel.socket.SocketChannel
at 
org.apache.pulsar.io.netty.server.NettyChannelInitializer.initChannel(NettyChannelInitializer.java:29)
 ~[pulsar-io-netty-2.4.2.nar-unpacked/:?]
at 
io.netty.channel.ChannelInitializer.initChannel(ChannelInitializer.java:115) 
[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.ChannelInitializer.handlerAdded(ChannelInitializer.java:107) 
[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.DefaultChannelPipeline.callHandlerAdded0(DefaultChannelPipeline.java:637)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.DefaultChannelPipeline.access$000(DefaultChannelPipeline.java:46)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.DefaultChannelPipeline$PendingHandlerAddedTask.execute(DefaultChannelPipeline.java:1487)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.DefaultChannelPipeline.callHandlerAddedForAllHandlers(DefaultChannelPipeline.java:1161)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.DefaultChannelPipeline.invokeHandlerAddedIfNeeded(DefaultChannelPipeline.java:686)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.AbstractChannel$AbstractUnsafe.register0(AbstractChannel.java:514)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.AbstractChannel$AbstractUnsafe.access$200(AbstractChannel.java:427)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.channel.AbstractChannel$AbstractUnsafe$1.run(AbstractChannel.java:486) 
[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:474) 
[io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:909)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at 
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
 [io.netty-netty-all-4.1.32.Final.jar:4.1.32.Final]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]
   
   
   Proposed solution :
   In NettyChannelInitializer.java SocketChannel chould be replaced by Channel
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] jiazhai commented on issue #5683: Cannot create topic under sample/standalone/ns1

[GitBox]

jiazhai commented on issue #5683: Cannot create topic under 
sample/standalone/ns1
URL: https://github.com/apache/pulsar/issues/5683#issuecomment-563212199
 
 
   as mentioned in #5791, 
   
   ``` 
   Adding this note in user doc doesn't address the problem raised in #5683 . 
It is actually making documentation much confused.
   
   The fundamental problem is the restful API documentation lacks versioning. 
We need to generate the rest api documentation by versions. So people can 
select the right version when they are using restful API. Hence a better 
approach to address #5683 : 
   
   - figure out a way to generate swagger file by different versions.
   - change the website to display restful api by different versions.  
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam commented on issue #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

massakam commented on issue #5823: [pulsar-client] Ensure that the same message 
ID is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823#issuecomment-563204825
 
 
   rerun java8 tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] bigbang489 commented on issue #5807: When CryptoFailureAction is FAIL, after a number of redeliver a message, the message is not move to deadletter topic

[GitBox]

bigbang489 commented on issue #5807: When CryptoFailureAction is FAIL, after a 
number of redeliver a message, the message is not move to deadletter topic
URL: https://github.com/apache/pulsar/issues/5807#issuecomment-563190425
 
 
   In the case of CONSUME, I don’t know If The payload I received is decryptEd 
successfully or not. How can I get that information?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] Jennifer88huang commented on issue #5819: [discussion] Pulsar release 2.6.0

[GitBox]

Jennifer88huang commented on issue #5819: [discussion] Pulsar release 2.6.0
URL: https://github.com/apache/pulsar/issues/5819#issuecomment-563181286
 
 
   Some users are expecting Pulsar transaction and KOP in the new release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-translation] Jennifer88huang commented on issue #12: functions-deploy: sijia-w

[GitBox]

Jennifer88huang commented on issue #12: functions-deploy: sijia-w
URL: https://github.com/apache/pulsar-translation/pull/12#issuecomment-563178773
 
 
   @SylviaBABY could you please help her on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie edited a comment on issue #4554: [docs] Improve the structure of Pulsar Functions

[GitBox]

sijie edited a comment on issue #4554: [docs] Improve the structure of Pulsar 
Functions
URL: https://github.com/apache/pulsar/issues/4554#issuecomment-503760528
 
 
   IMO "Deployment" and "Function Deployment" will confuse users.
   
   I actually have a slight different opinion after looking into the 
documentation of Azure Functions. I think we should differentiate the audience 
when categorizing the documentations
   
   Here is the layout I suggest. 
   
   - [x] Overview : Basically describe the concepts for Pulsar Functions. This 
is for all audiences.
   - [x] Setup: Setup or configure a Pulsar cluster to run Pulsar Functions. It 
includes how to run Function workers and configure the runtime. This is for 
administrators.
  - [x] Pulsar Function Worker
  - [x] Configure Runtime
   - [x] How-to: The how-to guide for developers
  - [x] Develop: How to develop a pulsar function. (introduction of API)
  - [x] Debug: How to unit test or debugging a pulsar function during 
development
  - [x] Deploy: How to run/deploy a pulsar function.
  - [ ] Configure: How to configure to run a pulsar function
  - [ ] Monitor: How to monitor pulsar functions
  - [x] Secure: How to secure or access secrets in pulsar functions (it is 
missing documentation at this moment)
  - [ ] Troubleshoot: How to trouble shoot running pulsar functions.
   - [ ] References
  - [x] CLI
  - [ ] Function Config
   
   Since we only have one depth for the left navigation bar (due to the 
limitation of current documentation framework we use), the real name of the nav 
items can be different from the one I proposed. Mine is just an example.
   
   The `how-to` guide can be organized using the tabs for different languages 
as what @jerrypeng proposed. Or we can just organize per-language how-to guide 
as what @Jennifer88huang proposed. Either works for me. 
   
   Though the per-language how-to guide might be easier to implement given the 
current documentation framework and the frontend skills the community has.
   
   https://user-images.githubusercontent.com/1217863/59803342-09e5f980-92a0-11e9-8b4f-b2105b1d9902.png;>
   
   https://docs.microsoft.com/en-in/azure/azure-functions/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.

[GitBox]

sijie commented on issue #4976: Pulsar SQL can not query the latest ingested 
event in a topic , but  Pulsar Consumer/Read always can.   
URL: https://github.com/apache/pulsar/issues/4976#issuecomment-563170244
 
 
   You are right!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355366927
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355368565
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
+- The windowed functions were broken when we changed java function 
instance to use classLoaders. 
+- When using the `--output-serde-classname` option, functionClassLoader is 
not set correctly.  
+
+  In Pulsar 2.4.2, we fixed this issue to make sure them works. 
+
+- In Pulsar 2.4.1, Broker fails to start with function worker enabled and 
broker client using TLS. Looking at the 
+startup code when running the function worker with the broker, it is checking 
for TLS enabled in the `function_worker.yml`
+file to determine whether or not to use the TLS port, but when setting TLS 
enabled on the function worker, 
+it is checking the `broker.conf`. Since the function worker is running with 
the broker, it makes sense to look to 
+the `broker.conf` as the single source of truth about whether or not to use 
TLS. In Pulsar 2.4.2 changed the code to 
+check the broker client is configured to use TLS. If it is, then use TLS for 
the function worker, otherwise use plain text.
+
+- In Pulsar Functions, we support the use of Bookkeeper to store the state of 
functions. But when user attempts to 
+fetch from function state a key that doesn't exist, an NPE will happen. In 
Pulsar 2.4.2, we add the correct error 
+handling for keys that don't exist.
+
+- Since deduplication drops messages based on the the largest sequence id 
recorded pre-persist, if there’s an error persisting 
+to BK, a retry attempt will just be “deduplicated” with no message ever 
getting persisted. The fix is two-fold: 
  
+- Double check the pending messages and return error to producer when the 
dup status is uncertain (eg. message is still pending)
+- Sync back the lastPushed map with the lastStored map after the failures
+
+- In Pulsar Sinks, the data in topics is consumed from the latest location by 
default. But in some scenarios, users want to 
+consume earliest data in sink topic. In Pulsar 2.4.2, we add `--subs-position` 
for Pulsar Sinks, allow users to consume 
+data from specified locations.
+
+- When the cursor is recovered from a ledger, the ledgerHandle is kept open so 
that we can delete that ledger after 
+we update the cursor status. If we attempt to close the cursor before having 
had any updates on the cursor itself, we 
+would end up having a harmless error, saying that we're trying to append to a 
read-only ledger. Also, when we append on 
+the ledger during the close operation, we need to explicitly close the ledger 
to avoid the expensive recovery when loading the topic.
+
+- If the subscription type on a topic changes, a new dispatcher is created and 
the old one is discarded. However, this 
+old dispatcher is not closed. This will cause a memory leak. If cursor is not 
durable, the subscription is closed and removed 
+from the topic when all consumers are removed. The dispatcher also needs to be 
closed at this time. Otherwise, 
+RateLimiter instances will not be garbage collected, causing a memory leak. In 
pulsar 2.4.2, When the type of a subscription changes 
+and a new dispatcher is created, close the previous one, avoiding memory leaks.
+
+- Instead of sorting the consumers based on priority level and consumer name 
then pick a active consumer, which could 
+cause subscription getting into a flaky state, where the "active" consumer 
joins and leaves, no consumer is actually 
+elected as "active" and consuming the messages. In Pulsar 2.4.2, fixed logic 
to always pick the first consumer in 
+the consumer list without sorting consumers. So consumers will be picked as 
acive consumer based on the order of 
+their subscription.
+
+- In Pulsar 2.4.1, broker tries to clean up stale failed-producer from the 
connection however, while cleaning up 
 
 Review comment:
   ```suggestion
   - Before Pulsar 

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355367684
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
+- The windowed functions were broken when we changed java function 
instance to use classLoaders. 
+- When using the `--output-serde-classname` option, functionClassLoader is 
not set correctly.  
+
+  In Pulsar 2.4.2, we fixed this issue to make sure them works. 
+
+- In Pulsar 2.4.1, Broker fails to start with function worker enabled and 
broker client using TLS. Looking at the 
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355366201
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
+- The windowed functions were broken when we changed java function 
instance to use classLoaders. 
+- When using the `--output-serde-classname` option, functionClassLoader is 
not set correctly.  
+
+  In Pulsar 2.4.2, we fixed this issue to make sure them works. 
+
+- In Pulsar 2.4.1, Broker fails to start with function worker enabled and 
broker client using TLS. Looking at the 
+startup code when running the function worker with the broker, it is checking 
for TLS enabled in the `function_worker.yml`
+file to determine whether or not to use the TLS port, but when setting TLS 
enabled on the function worker, 
+it is checking the `broker.conf`. Since the function worker is running with 
the broker, it makes sense to look to 
+the `broker.conf` as the single source of truth about whether or not to use 
TLS. In Pulsar 2.4.2 changed the code to 
+check the broker client is configured to use TLS. If it is, then use TLS for 
the function worker, otherwise use plain text.
+
+- In Pulsar Functions, we support the use of Bookkeeper to store the state of 
functions. But when user attempts to 
+fetch from function state a key that doesn't exist, an NPE will happen. In 
Pulsar 2.4.2, we add the correct error 
+handling for keys that don't exist.
+
+- Since deduplication drops messages based on the the largest sequence id 
recorded pre-persist, if there’s an error persisting 
+to BK, a retry attempt will just be “deduplicated” with no message ever 
getting persisted. The fix is two-fold: 
  
+- Double check the pending messages and return error to producer when the 
dup status is uncertain (eg. message is still pending)
+- Sync back the lastPushed map with the lastStored map after the failures
+
+- In Pulsar Sinks, the data in topics is consumed from the latest location by 
default. But in some scenarios, users want to 
+consume earliest data in sink topic. In Pulsar 2.4.2, we add `--subs-position` 
for Pulsar Sinks, allow users to consume 
+data from specified locations.
+
+- When the cursor is recovered from a ledger, the ledgerHandle is kept open so 
that we can delete that ledger after 
+we update the cursor status. If we attempt to close the cursor before having 
had any updates on the cursor itself, we 
+would end up having a harmless error, saying that we're trying to append to a 
read-only ledger. Also, when we append on 
+the ledger during the close operation, we need to explicitly close the ledger 
to avoid the expensive recovery when loading the topic.
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355365344
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
+- The windowed functions were broken when we changed java function 
instance to use classLoaders. 
+- When using the `--output-serde-classname` option, functionClassLoader is 
not set correctly.  
+
+  In Pulsar 2.4.2, we fixed this issue to make sure them works. 
+
+- In Pulsar 2.4.1, Broker fails to start with function worker enabled and 
broker client using TLS. Looking at the 
 
 Review comment:
   ```suggestion
   - Before Pulsar 2.4.2, Broker fails to start with function worker enabled 
and broker client using TLS. Looking at the 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355367096
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355367742
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
+- The windowed functions were broken when we changed java function 
instance to use classLoaders. 
+- When using the `--output-serde-classname` option, functionClassLoader is 
not set correctly.  
+
+  In Pulsar 2.4.2, we fixed this issue to make sure them works. 
+
+- In Pulsar 2.4.1, Broker fails to start with function worker enabled and 
broker client using TLS. Looking at the 
+startup code when running the function worker with the broker, it is checking 
for TLS enabled in the `function_worker.yml`
+file to determine whether or not to use the TLS port, but when setting TLS 
enabled on the function worker, 
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355367184
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
+load the internal pulsar code, user code, and the interfaces that the two 
interacts with each other. This is a good 
+change, but this change will cause the following two problems:
 
 Review comment:
   We may not need a new line here


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on a change in pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

codelipenghui commented on a change in pull request #5824: Publish a blog post 
to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#discussion_r355365258
 
 

 ##
 File path: site2/website/blog/2019-12-04-Apache-Pulsar-2-4-2.md
 ##
 @@ -0,0 +1,103 @@
+---
+author: Xiaolong Ran
+authorURL: https://twitter.com/wolf4j1
+title: Apache Pulsar 2.4.2
+---
+
+We are glad to publish Apache Pulsar 2.4.2. This is the result of a huge 
+effort from the community, with over 110 commits, general improvements and bug 
fixes.
+
+Check out the [release notes](../release-notes.md/) for a detailed list 
of 
+the changes, with links to the relevant pull requests, discussions and 
documentation.
+
+Regarding improvements and bug fixes introduced, I just want to highlight here 
a tiny subset of them:
+
+
+
+- In Pulsar 2.4.1, we instead of using a shaded JAR to start a java function 
instance, use different classLoaders to 
 
 Review comment:
   ```suggestion
   - before Pulsar 2.4.2, we instead of using a shaded JAR to start a java 
function instance, use different classLoaders to 
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy commented on issue #5824: Publish a blog post to apache pulsar blog

[GitBox]

wolfstudy commented on issue #5824: Publish a blog post to apache pulsar blog
URL: https://github.com/apache/pulsar/pull/5824#issuecomment-563162856
 
 
   @Anonymitaet PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy edited a comment on issue #5824: Publish a blog post to apache pulsar blog

[GitBox]

wolfstudy edited a comment on issue #5824: Publish a blog post to apache pulsar 
blog
URL: https://github.com/apache/pulsar/pull/5824#issuecomment-563162856
 
 
   @Anonymitaet PTAL
   
   @sijie @jiazhai PTAL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.

[GitBox]

codelipenghui commented on issue #4976: Pulsar SQL can not query the latest 
ingested event in a topic , but  Pulsar Consumer/Read always can.   
URL: https://github.com/apache/pulsar/issues/4976#issuecomment-563162192
 
 
   @sijie I think we need to use `explicitLacInterval`, this is the name in 
Bookkeeper client configuration. The `bookkeeperExplicitLacIntervalInMills` is 
named in broker side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie opened a new issue #5826: Provide commands to delete or reformat cluster metadata

[GitBox]

sijie opened a new issue #5826: Provide commands to delete or reformat cluster 
metadata
URL: https://github.com/apache/pulsar/issues/5826
 
 
   *Problem*
   
   Sometimes a tool to delete or reformat cluster metadata would be very 
helpful for testing purposes.
   
   This is related to #5825 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie opened a new issue #5825: Improve PulsarClusterMetadataSetup to make it idempotent

[GitBox]

sijie opened a new issue #5825: Improve PulsarClusterMetadataSetup to make it 
idempotent
URL: https://github.com/apache/pulsar/issues/5825
 
 
   *Problem*
   
   Currently the cluster metadata setup can be interrupted if `/namespace` 
znode already exists.
   
   *Change*
   
   We need to improve the program to make it idempotent.
   
   1) try to use zookeeper `multi` to ensure certain atomicity if possible.
   2) make sure the program handle znode already exists correct.
   3) add a test case to cover the change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] wolfstudy opened a new pull request #5824: Publish a blog post to apache pulsar blog

[GitBox]

wolfstudy opened a new pull request #5824: Publish a blog post to apache pulsar 
blog
URL: https://github.com/apache/pulsar/pull/5824
 
 
   Signed-off-by: xiaolong.ran 
   
   ### Motivation
   
   Publish a blog post to apache pulsar blog:
   
   - http://pulsar.apache.org/blog/
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.

[GitBox]

sijie commented on issue #4976: Pulsar SQL can not query the latest ingested 
event in a topic , but  Pulsar Consumer/Read always can.   
URL: https://github.com/apache/pulsar/issues/4976#issuecomment-563154968
 
 
   @frank-dkvan 
   
   I think you can add `bookkeeperExplicitLacIntervalInMills=5` in the JVM 
system properties when starting the broker.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[pulsar] branch master updated (a8c8a7e -> 8a20d9a)

[hjf]

This is an automated email from the ASF dual-hosted git repository.

hjf pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git.


from a8c8a7e  Add more info in the error messages (#5714)
 add 8a20d9a  [Issue:4753] Add encryption docs to Functions develop (#5781)

No new revisions were added by this update.

Summary of changes:
 site2/docs/functions-develop.md | 62 +
 1 file changed, 62 insertions(+)

[GitHub] [pulsar] Jennifer88huang closed issue #4753: [docs] Add documentation for Functions develop: encryption

[GitBox]

Jennifer88huang closed issue #4753: [docs] Add documentation for Functions 
develop: encryption
URL: https://github.com/apache/pulsar/issues/4753
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5814: [Issue 5808][documentation]fix example code

[GitBox]

codelipenghui commented on issue #5814: [Issue 5808][documentation]fix example 
code
URL: https://github.com/apache/pulsar/pull/5814#issuecomment-563152314
 
 
   run integration tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #32: Support multi-topics and pattern topics logic

[GitBox]

jiazhai commented on issue #32: Support multi-topics and pattern topics logic
URL: https://github.com/apache/pulsar-client-go/issues/32#issuecomment-563150834
 
 
   This seems be a sub-task of #52 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] massakam opened a new pull request #5823: [pulsar-client] Ensure that the same message ID is not added to UnAckedMessageTracker multiple times

[GitBox]

massakam opened a new pull request #5823: [pulsar-client] Ensure that the same 
message ID is not added to UnAckedMessageTracker multiple times
URL: https://github.com/apache/pulsar/pull/5823
 
 
   ### Motivation
   
   When a message ID is added to `UnAckedMessageTracker`, it is added as an 
instance of `MessageIdImpl`, not `BatchMessageIdImpl`. Since the batch index 
information is deleted at this time, the same message ID will be added to 
`UnAckedMessageTracker` multiple times when consumer receives batched messages.
   
https://github.com/apache/pulsar/blob/a8c8a7ee1559bc607b3454fa55134094d8a2c208/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java#L1124-L1134
   
   There is no problem even if the same message ID is added without taking too 
much time. However, if the interval between these message IDs is long, the 
message IDs may be added to other elements of `timePartitions`.
   
https://github.com/apache/pulsar/blob/09360682953d0cbc154630a470492c11a4f83184/pulsar-client/src/main/java/org/apache/pulsar/client/impl/UnAckedMessageTracker.java#L163-L172
   
   As a result, even if the consumer sends ack, some message IDs remain without 
being deleted from `timePartitions`, and an unnecessary ack timeout event 
occurs.
   
   ### Modifications
   
   When adding a message ID to `UnAckedMessageTracker`, check if the same 
message ID is already included in` timePartitions`, and if it is included, do 
nothing.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #15: [Consumer && Message Impl] Thinking about some code design

[GitBox]

jiazhai commented on issue #15: [Consumer && Message Impl] Thinking about some 
code design
URL: https://github.com/apache/pulsar-client-go/issues/15#issuecomment-563149132
 
 
   @wolfstudy Is this issue still need?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #114: The pulsar go client missing data when transfer

[GitBox]

jiazhai commented on issue #114:  The pulsar go client missing data when 
transfer
URL: 
https://github.com/apache/pulsar-client-go/issues/114#issuecomment-563147916
 
 
   @sunlc210 Thanks for reporting this issue. 
   Is it reproduce-able to simulate the filebeat behavior by purely pulsar go 
client, This is very helpful to the fix. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #52: Catch up Java client function list

[GitBox]

jiazhai commented on issue #52: Catch up Java client function list
URL: https://github.com/apache/pulsar-client-go/issues/52#issuecomment-563146172
 
 
   @wolfstudy Is this updated with latest master?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #4976: Pulsar SQL can not query the latest ingested event in a topic , but Pulsar Consumer/Read always can.

[GitBox]

codelipenghui commented on issue #4976: Pulsar SQL can not query the latest 
ingested event in a topic , but  Pulsar Consumer/Read always can.   
URL: https://github.com/apache/pulsar/issues/4976#issuecomment-563145723
 
 
   @frank-dkvan @sijie I have create a new pull request #5822 for expose the 
config in broker.conf. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar-client-go] jiazhai commented on issue #68: Use ConfigOption withxxxx for simple usage

[GitBox]

jiazhai commented on issue #68: Use ConfigOption with for simple usage
URL: https://github.com/apache/pulsar-client-go/issues/68#issuecomment-563145928
 
 
   Thanks @xujianhai666 for your help on this issue and PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac configuration in broker.conf

[GitBox]

codelipenghui commented on issue #5822: Expose bookkeeper expose explicit lac 
configuration in broker.conf
URL: https://github.com/apache/pulsar/pull/5822#issuecomment-563145006
 
 
   related to #3828 #4976


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui opened a new pull request #5822: Expose bookkeeper expose explicit lac configuration in broker.conf

[GitBox]

codelipenghui opened a new pull request #5822: Expose bookkeeper expose 
explicit lac configuration in broker.conf
URL: https://github.com/apache/pulsar/pull/5822
 
 
   ### Motivation
   
   Expose bookkeeper expose explicit lac configuration in broker.conf
   
   ### Verifying this change
   
   Added unit tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
 - Dependencies (does it add or upgrade a dependency): (no)
 - The public API: (no)
 - The schema: (no)
 - The default values of configurations: (yes)
 - The wire protocol: (no)
 - The rest endpoints: (no)
 - The admin cli options: (no)
 - Anything that affects deployment: (no)
   
   ### Documentation
   
 - Does this pull request introduce a new feature? (no)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services