[jira] [Updated] (HADOOP-9623) Update jets3t dependency
[ https://issues.apache.org/jira/browse/HADOOP-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amandeep Khurana updated HADOOP-9623: - Attachment: HADOOP-9623_2.patch Fixing for javac warnings related to using deprecated API from jets3t Update jets3t dependency Key: HADOOP-9623 URL: https://issues.apache.org/jira/browse/HADOOP-9623 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 3.0.0, 2.1.0-beta Reporter: Timothy St. Clair Labels: maven Attachments: HADOOP-9623_2.patch, HADOOP-9623.patch, HADOOP-9623.patch Current version referenced in pom is 0.6.1 (Aug 2008), updating to 0.9.0 enables mvn-rpmbuild to build against system dependencies. http://jets3t.s3.amazonaws.com/RELEASE_NOTES.html -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9623) Update jets3t dependency
[ https://issues.apache.org/jira/browse/HADOOP-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793956#comment-13793956 ] Hadoop QA commented on HADOOP-9623: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608242/HADOOP-9623_2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3211//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3211//console This message is automatically generated. Update jets3t dependency Key: HADOOP-9623 URL: https://issues.apache.org/jira/browse/HADOOP-9623 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 3.0.0, 2.1.0-beta Reporter: Timothy St. Clair Labels: maven Attachments: HADOOP-9623_2.patch, HADOOP-9623.patch, HADOOP-9623.patch Current version referenced in pom is 0.6.1 (Aug 2008), updating to 0.9.0 enables mvn-rpmbuild to build against system dependencies. http://jets3t.s3.amazonaws.com/RELEASE_NOTES.html -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9984) FileSystem#globStatus and FileSystem#listStatus should resolve symlinks by default
[ https://issues.apache.org/jira/browse/HADOOP-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794224#comment-13794224 ] Steve Watt commented on HADOOP-9984: Following on from my previous comment - some of the glusterfs-hadoop devs spent some time reviewing this thread and the proposals within it. I wanted to weigh in and state that in our opinion the broader Hadoop FileSystem community aren't impacted if you add new methods (such as symlink support) to the Hadoop FileSystem interface as we simply add support for that new operation in a new release of our Hadoop FS plugin and we're both currently and backwards compatible. I suspect the other out-of-tree Hadoop FileSystem implementors would feel the same way. FileSystem#globStatus and FileSystem#listStatus should resolve symlinks by default -- Key: HADOOP-9984 URL: https://issues.apache.org/jira/browse/HADOOP-9984 Project: Hadoop Common Issue Type: Sub-task Components: fs Affects Versions: 2.1.0-beta Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Blocker Attachments: HADOOP-9984.001.patch, HADOOP-9984.003.patch, HADOOP-9984.005.patch, HADOOP-9984.007.patch, HADOOP-9984.009.patch, HADOOP-9984.010.patch, HADOOP-9984.011.patch, HADOOP-9984.012.patch, HADOOP-9984.013.patch, HADOOP-9984.014.patch, HADOOP-9984.015.patch During the process of adding symlink support to FileSystem, we realized that many existing HDFS clients would be broken by listStatus and globStatus returning symlinks. One example is applications that assume that !FileStatus#isFile implies that the inode is a directory. As we discussed in HADOOP-9972 and HADOOP-9912, we should default these APIs to returning resolved paths. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794278#comment-13794278 ] Hudson commented on HADOOP-10040: - SUCCESS: Integrated in Hadoop-trunk-Commit #4596 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4596/]) HADOOP-10040. Revert svn propset for CRLF line endings on Windows files. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1531977) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/start-all.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/stop-all.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.sln * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.vcxproj * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.vcxproj * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/winutils.sln * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/winutils.vcxproj * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs-config.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/bin/mapred-config.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/bin/mapred.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/conf/mapred-env.cmd * /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/bin/cat.cmd * /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/bin/xargs_cat.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/start-yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn-config.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/conf/yarn-env.cmd hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794292#comment-13794292 ] Hudson commented on HADOOP-10040: - SUCCESS: Integrated in Hadoop-trunk-Commit #4597 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4597/]) HADOOP-10040. svn propset to native line endings on Windows files. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1531983) * /hadoop/common/trunk/.gitattributes * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop-config.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/start-all.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/bin/stop-all.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.cmd * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.sln * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.vcxproj * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.vcxproj * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/winutils.sln * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/winutils.vcxproj * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs-config.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.cmd * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/bin/mapred-config.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/bin/mapred.cmd * /hadoop/common/trunk/hadoop-mapreduce-project/conf/mapred-env.cmd * /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/bin/cat.cmd * /hadoop/common/trunk/hadoop-tools/hadoop-streaming/src/test/bin/xargs_cat.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/start-yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn-config.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/bin/yarn.cmd * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/conf/yarn-env.cmd hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated HADOOP-6350: -- Attachment: HADOOP-6350.4.patch Attaching updated patch. Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated HADOOP-6350: -- Labels: metrics (was: ) Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated HADOOP-6350: -- Component/s: metrics documentation Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794313#comment-13794313 ] Akira AJISAKA commented on HADOOP-6350: --- I created a github repository for developing this patch. https://github.com/aajisaka/hadoop-common/tree/HADOOP-6350 I'm looking forward to your pull requests! Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated HADOOP-6350: -- Target Version/s: 3.0.0, 2.3.0 Affects Version/s: 3.0.0 2.1.0-beta Status: Patch Available (was: Open) Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Affects Versions: 2.1.0-beta, 3.0.0 Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth resolved HADOOP-10040. Resolution: Fixed I have committed the changes described above. I waited for the git sync and refreshed by git repos. I don't see any problems. I think this worked. Luke, thanks again for help with this. hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794319#comment-13794319 ] Hudson commented on HADOOP-10040: - SUCCESS: Integrated in Hadoop-trunk-Commit #4598 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4598/]) HADOOP-10040. Correct merge error on native.vcxproj. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1531994) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.vcxproj hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (HADOOP-10045) QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1
Akira AJISAKA created HADOOP-10045: -- Summary: QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1 Key: HADOOP-10045 URL: https://issues.apache.org/jira/browse/HADOOP-10045 Project: Hadoop Common Issue Type: Bug Components: metrics Affects Versions: 1.2.1 Environment: branch-1 Reporter: Akira AJISAKA Priority: Minor In branch-1, maps/reduces_failed metric will be incremented when map/reduce task is failed or killed, otherwise maps/reduces_killed metric won't be incremented then. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9494) Excluded auto-generated and examples code from clover reports
[ https://issues.apache.org/jira/browse/HADOOP-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794340#comment-13794340 ] Jonathan Eagles commented on HADOOP-9494: - +1. Looks great! Thanks everybody. Excluded auto-generated and examples code from clover reports - Key: HADOOP-9494 URL: https://issues.apache.org/jira/browse/HADOOP-9494 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7 Reporter: Dennis Y Assignee: Andrey Klochkov Attachments: HADOOP-9494--n5.patch, HADOOP-9494--n6.patch, HADOOP-9494-trunk--N3.patch, HADOOP-9494-trunk--N4.patch applicable to branch-0.23, branch-2, trunk -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9494) Excluded auto-generated and examples code from clover reports
[ https://issues.apache.org/jira/browse/HADOOP-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated HADOOP-9494: Resolution: Fixed Fix Version/s: 2.3.0 3.0.0 Status: Resolved (was: Patch Available) Excluded auto-generated and examples code from clover reports - Key: HADOOP-9494 URL: https://issues.apache.org/jira/browse/HADOOP-9494 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7 Reporter: Dennis Y Assignee: Andrey Klochkov Fix For: 3.0.0, 2.3.0 Attachments: HADOOP-9494--n5.patch, HADOOP-9494--n6.patch, HADOOP-9494-trunk--N3.patch, HADOOP-9494-trunk--N4.patch applicable to branch-0.23, branch-2, trunk -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10045) QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1
[ https://issues.apache.org/jira/browse/HADOOP-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated HADOOP-10045: --- Description: In branch-1, maps/reduces_failed metric will be incremented when map/reduce task is failed or killed, otherwise maps/reduces_killed metric won't be incremented then. I found 'maps_killed' and 'reduces_killed' metrics are never incremented not only in QueueMetrics but also in JobTrackerMetrics. was:In branch-1, maps/reduces_failed metric will be incremented when map/reduce task is failed or killed, otherwise maps/reduces_killed metric won't be incremented then. QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1 - Key: HADOOP-10045 URL: https://issues.apache.org/jira/browse/HADOOP-10045 Project: Hadoop Common Issue Type: Bug Components: metrics Affects Versions: 1.2.1 Environment: branch-1 Reporter: Akira AJISAKA Priority: Minor Labels: metrics In branch-1, maps/reduces_failed metric will be incremented when map/reduce task is failed or killed, otherwise maps/reduces_killed metric won't be incremented then. I found 'maps_killed' and 'reduces_killed' metrics are never incremented not only in QueueMetrics but also in JobTrackerMetrics. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-6350) Documenting Hadoop metrics
[ https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794343#comment-13794343 ] Hadoop QA commented on HADOOP-6350: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608306/HADOOP-6350.4.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3212//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3212//console This message is automatically generated. Documenting Hadoop metrics -- Key: HADOOP-6350 URL: https://issues.apache.org/jira/browse/HADOOP-6350 Project: Hadoop Common Issue Type: Improvement Components: documentation, metrics Affects Versions: 3.0.0, 2.1.0-beta Reporter: Hong Tang Assignee: Akira AJISAKA Labels: metrics Attachments: HADOOP-6350.4.patch, HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch, HADOOP-6350-sample-3.patch, sample1.png Metrics should be part of public API, and should be clearly documented similar to HADOOP-5073, so that we can reliably build tools on top of them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9291) enhance unit-test coverage of package o.a.h.metrics2
[ https://issues.apache.org/jira/browse/HADOOP-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794348#comment-13794348 ] Nathan Roberts commented on HADOOP-9291: Ivan, thanks for the update. A couple of comments on the patch. # In the following code I don't think there is any guarantee on the order of the tags or the metrics (In fact I saw it fail once because testTag2 was emitted first). The testMetrics2=1 part of the comment is also not correct. {code} // Check the out file content. Should be something like the following: //1360244820087 test1.testRecord1: Context=test1, testTag1=testTagValue1, testTag2=testTagValue2, Hostname=myhost, testMetric1=1, testMetric2=1 //1360244820089 test1.testRecord2: Context=test1, testTag22=testTagValue22, Hostname=myhost Pattern expectedContentPattern = Pattern.compile( ^\\d+\\s+test1.testRecord1:\\s+Context=test1,\\s+testTag1=testTagValue1, + \\s+testTag2=testTagValue2,\\s+Hostname=.*,\\s+testMetric1=1,\\s+testMetric2=2 + $[\\n\\r]*^\\d+\\s+test1.testRecord2:\\s+Context=test1, + \\s+testTag22=testTagValue22,\\s+Hostname=.*$[\\n\\r]*, Pattern.MULTILINE); System.out.println(expectedContentPattern.matcher(outFileContent).matches()); assertTrue(expectedContentPattern.matcher(outFileContent).matches()); {code} # This is minor - In TestpatternFilter, it might have been nice to have shouldAccept(wl, tags) actually specifically state which elements of the array are supposed to be accepted vs. rejected (currently it just counts the number of accepts/rejects and assumes the right ones were accepted/rejected). I think there are enough test case combinations that we would catch something wrong, but I didn't study it long enough to be 100% convinced of that. enhance unit-test coverage of package o.a.h.metrics2 Key: HADOOP-9291 URL: https://issues.apache.org/jira/browse/HADOOP-9291 Project: Hadoop Common Issue Type: Test Affects Versions: 3.0.0, 2.3.0 Reporter: Ivan A. Veselovsky Assignee: Ivan A. Veselovsky Attachments: HADOOP-9291-branch-0.23--N4.patch, HADOOP-9291--N7.patch, HADOOP-9291-trunk--N4.patch, HADOOP-9291-trunk--N5.patch, HADOOP-9291-trunk--N6.patch, HADOOP-9291-trunk--N6.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9494) Excluded auto-generated and examples code from clover reports
[ https://issues.apache.org/jira/browse/HADOOP-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794351#comment-13794351 ] Hudson commented on HADOOP-9494: SUCCESS: Integrated in Hadoop-trunk-Commit #4599 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4599/]) HADOOP-9494. Excluded auto-generated and examples code from clover reports (Andrey Klochkov via jeagles) (jeagles: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532013) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/pom.xml Excluded auto-generated and examples code from clover reports - Key: HADOOP-9494 URL: https://issues.apache.org/jira/browse/HADOOP-9494 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.7 Reporter: Dennis Y Assignee: Andrey Klochkov Fix For: 3.0.0, 2.3.0 Attachments: HADOOP-9494--n5.patch, HADOOP-9494--n6.patch, HADOOP-9494-trunk--N3.patch, HADOOP-9494-trunk--N4.patch applicable to branch-0.23, branch-2, trunk -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Created] (HADOOP-10046) Print a log message when SSL is enabled
David S. Wang created HADOOP-10046: -- Summary: Print a log message when SSL is enabled Key: HADOOP-10046 URL: https://issues.apache.org/jira/browse/HADOOP-10046 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0 Reporter: David S. Wang Priority: Trivial It would be nice to have a log message that indicates that SSL is enabled in org.apache.hadoop.http.HttpServer. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10046) Print a log message when SSL is enabled
[ https://issues.apache.org/jira/browse/HADOOP-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David S. Wang updated HADOOP-10046: --- Attachment: HADOOP-10046.patch Print a log message when SSL is enabled --- Key: HADOOP-10046 URL: https://issues.apache.org/jira/browse/HADOOP-10046 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0 Reporter: David S. Wang Priority: Trivial Attachments: HADOOP-10046.patch It would be nice to have a log message that indicates that SSL is enabled in org.apache.hadoop.http.HttpServer. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10046) Print a log message when SSL is enabled
[ https://issues.apache.org/jira/browse/HADOOP-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David S. Wang updated HADOOP-10046: --- Status: Patch Available (was: Open) Proposed patch. Print a log message when SSL is enabled --- Key: HADOOP-10046 URL: https://issues.apache.org/jira/browse/HADOOP-10046 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0 Reporter: David S. Wang Priority: Trivial Attachments: HADOOP-10046.patch It would be nice to have a log message that indicates that SSL is enabled in org.apache.hadoop.http.HttpServer. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10046) Print a log message when SSL is enabled
[ https://issues.apache.org/jira/browse/HADOOP-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794384#comment-13794384 ] Hadoop QA commented on HADOOP-10046: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608318/HADOOP-10046.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3213//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3213//console This message is automatically generated. Print a log message when SSL is enabled --- Key: HADOOP-10046 URL: https://issues.apache.org/jira/browse/HADOOP-10046 Project: Hadoop Common Issue Type: Improvement Affects Versions: 3.0.0 Reporter: David S. Wang Priority: Trivial Attachments: HADOOP-10046.patch It would be nice to have a log message that indicates that SSL is enabled in org.apache.hadoop.http.HttpServer. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9219) coverage fixing for org.apache.hadoop.tools.rumen
[ https://issues.apache.org/jira/browse/HADOOP-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794492#comment-13794492 ] Andrey Klochkov commented on HADOOP-9219: - I submitted a patch for MAPREDUCE-3860 which restores old Rumen tests. Those old tests cover pretty much all Rumen codebase so as soon as MAPREDUCE-3860 is accepted, this Jira may be closed as non actual anymore. coverage fixing for org.apache.hadoop.tools.rumen - Key: HADOOP-9219 URL: https://issues.apache.org/jira/browse/HADOOP-9219 Project: Hadoop Common Issue Type: Test Components: tools Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6 Reporter: Aleksey Gorshkov Assignee: Aleksey Gorshkov Attachments: HADOOP-9219-trunk-a.patch, HADOOP-9219-trunk-b.patch, HADOOP-9219-trunk.patch Original Estimate: 168h Remaining Estimate: 168h coverage fixing for org.apache.hadoop.tools.rumen HADOOP-9219-trunk.patch for trunk, brunch-2 and branch-0.23 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794596#comment-13794596 ] Luke Lu commented on HADOOP-10040: -- Chris, thanks for taking care of this! Some notes for posterity: Due to the different ways subversion and git handle text EOLs. The build artifacts are currently VCS (version control system) dependent. Currently if a release is built with git on either windows and \*nix platforms, the result will be correct (windows text (\*.cmd etc.) will have CRLF as EOL). If a release is built with subversion on *nix platforms, windows text will have LF as EOL. This is not a major issue yet, as people typically build windows releases on windows boxes (required for windows native bits) and \*nix releases on corresponding machines. hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HADOOP-10044: --- Attachment: HADOOP-10044.20131014.patch Thanks Sanjay! The javadoc is very helpful to understand the RPC code. Some minor comments about the current patch: # In RpcConstants.java, {code} /** * The Rpc-connection header is as follows * +--+ * | hrpc 4 bytes | * +--+ * | Version (1 byte)| * +--+ * | Service Class (1 byte) | * +--+ * | AuthProtocol (1 byte) | * +--+ */ {code} can be moved to somewhere in Server.java (e.g., as javadoc for Connection or Connection#readAndProcess) ? # In Connection#saslProcess, the AccessCotnrolException thrown by processSaslMessage will be caught by the outside try-catch, and will be wrapped as a WrappedRpcServerException. Thus we do not need to add it to signature and javadoc. # Do we need to javadoc the mechanism about how to create SASL server based on different auth methods? Besides there're some typos and I just modify them directly on the original patch. Upload a new patch fixing typos. Improve the javadoc of rpc code --- Key: HADOOP-10044 URL: https://issues.apache.org/jira/browse/HADOOP-10044 Project: Hadoop Common Issue Type: Improvement Reporter: Sanjay Radia Assignee: Sanjay Radia Priority: Minor Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9982) Fix broken hyperlinks in hadoop document
[ https://issues.apache.org/jira/browse/HADOOP-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794619#comment-13794619 ] Akira AJISAKA commented on HADOOP-9982: --- I filed HDFS-5297 to fix dead links in HDFS document and I attached a patch. I found no dead link in YARN documents and just a few dead links in MAPREDUCE documents, which are missing 'Go Back'. Fix broken hyperlinks in hadoop document Key: HADOOP-9982 URL: https://issues.apache.org/jira/browse/HADOOP-9982 Project: Hadoop Common Issue Type: Bug Components: documentation Affects Versions: 3.0.0, 2.1.0-beta, 2.0.6-alpha Reporter: Akira AJISAKA Assignee: Akira AJISAKA Priority: Minor Attachments: HADOOP-9982.patch For example, the hyperlink 'Single Node Setup' doesn't work correctly in ['Cluster Setup' document|http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/ClusterSetup.html]. I also found other dead links. I'll try to fix them. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794633#comment-13794633 ] Chris Nauroth commented on HADOOP-10040: I just made one more commit related to this. It turns out that while correcting this I accidentally reverted one line from native.vcxproj to compile lz4hc.c. This ultimately caused unresolved external symbol errors in the Windows native build. I didn't catch it earlier, because I did my testing on branch-2.2, and lz4hc.c only exists on trunk and branch-2. I re-committed the native.vcxproj change shown in HADOOP-9319 to trunk and branch-2. Sorry if this caused churn for anyone. hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10040) hadoop.cmd in UNIX format and would not run by default on Windows
[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794644#comment-13794644 ] Hudson commented on HADOOP-10040: - SUCCESS: Integrated in Hadoop-trunk-Commit #4604 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4604/]) HADOOP-10040. Correct native.vcxproj for inclusion of lz4hc.c. Contributed by Chris Nauroth. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532136) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/native.vcxproj hadoop.cmd in UNIX format and would not run by default on Windows - Key: HADOOP-10040 URL: https://issues.apache.org/jira/browse/HADOOP-10040 Project: Hadoop Common Issue Type: Bug Reporter: Yingda Chen Assignee: Chris Nauroth Fix For: 3.0.0, 2.2.1 The hadoop.cmd currently checked in into hadoop-common is in UNIX format, same as most of other src files. However, the hadoop.cmd is meant to be used on Windows only, the fact that it is in UNIX format makes it unrunnable as is on Window platform. An exception shall be made on hadoop.cmd (and other cmd files for what matters) to make sure they are in DOS format, for them to be runnable as is when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794650#comment-13794650 ] Karthik Kambatla commented on HADOOP-10043: --- The changes look good. Nit: Instead of actual strings for defining the name of the service, it might be better to use ClassName.class.getName(). Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[ https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794659#comment-13794659 ] Chris Nauroth commented on HADOOP-9897: --- Hi, [~decster]. Thanks for the reminder. I think there are just a couple of minor things left: {code} // Add path components explicitly, because simply contact two path string // is not safe, for example: {code} I think contact was meant to be concatenating. While reviewing this, I ended up writing some additional tests of {{Path#isWindowsAbsolutePath}} to verify that they passed before and after the patch. Could you please fold these into {{TestPath}} in your patch? We might as well keep them around. {code} @Test public void testIsWindowsAbsolutePath() { if (!Shell.WINDOWS) return; assertTrue(Path.isWindowsAbsolutePath(C:\\test, false)); assertTrue(Path.isWindowsAbsolutePath(C:/test, false)); assertTrue(Path.isWindowsAbsolutePath(/C:/test, true)); assertFalse(Path.isWindowsAbsolutePath(/test, false)); assertFalse(Path.isWindowsAbsolutePath(/test, true)); assertFalse(Path.isWindowsAbsolutePath(C:test, false)); assertFalse(Path.isWindowsAbsolutePath(/C:test, true)); } {code} Can we please also add similar tests covering {{Path#getParent}} when the path has a Windows drive spec? After that's done, I'll take the patch for a full test run across the whole project tree on my Windows VM. Add method to get path start position without drive specifier in o.a.h.fs.Path Key: HADOOP-9897 URL: https://issues.apache.org/jira/browse/HADOOP-9897 Project: Hadoop Common Issue Type: Improvement Reporter: Binglin Chang Assignee: Binglin Chang Priority: Trivial Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch, HADOOP-9897.v2.patch There are a lot of code in Path to get start position after skipping drive specifier, like: {code} int start = hasWindowsDrive(uri.getPath()) ? 3 : 0; {code} Also there is a minor bug in mergePaths: mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri authority, not path. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10044) Improve the javadoc of rpc code
[ https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794682#comment-13794682 ] Hadoop QA commented on HADOOP-10044: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608377/HADOOP-10044.20131014.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3214//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3214//console This message is automatically generated. Improve the javadoc of rpc code --- Key: HADOOP-10044 URL: https://issues.apache.org/jira/browse/HADOOP-10044 Project: Hadoop Common Issue Type: Improvement Reporter: Sanjay Radia Assignee: Sanjay Radia Priority: Minor Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsuyoshi OZAWA updated HADOOP-10043: Attachment: HADOOP-10043.2.patch Thank you for your review, Karthik! Updated a patch to use ClassName.class.getName() instead of using actual strings. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Assigned] (HADOOP-10045) QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1
[ https://issues.apache.org/jira/browse/HADOOP-10045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA reassigned HADOOP-10045: -- Assignee: Akira AJISAKA QueueMetrics 'maps_killed' and 'reduces_killed' are never incremented in branch-1 - Key: HADOOP-10045 URL: https://issues.apache.org/jira/browse/HADOOP-10045 Project: Hadoop Common Issue Type: Bug Components: metrics Affects Versions: 1.2.1 Environment: branch-1 Reporter: Akira AJISAKA Assignee: Akira AJISAKA Priority: Minor Labels: metrics In branch-1, maps/reduces_failed metric will be incremented when map/reduce task is failed or killed, otherwise maps/reduces_killed metric won't be incremented then. I found 'maps_killed' and 'reduces_killed' metrics are never incremented not only in QueueMetrics but also in JobTrackerMetrics. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794706#comment-13794706 ] Karthik Kambatla commented on HADOOP-10043: --- The updated patch doesn't capture all the changes. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794707#comment-13794707 ] Hadoop QA commented on HADOOP-10043: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608391/HADOOP-10043.2.patch against trunk revision . {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3215//console This message is automatically generated. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsuyoshi OZAWA updated HADOOP-10043: Attachment: HADOOP-10043.3.patch Sorry, the last patch was wrong one. This is the correct one. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, HADOOP-10043.3.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794715#comment-13794715 ] Karthik Kambatla commented on HADOOP-10043: --- Pending Jenkins, the patch looks good to me. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, HADOOP-10043.3.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794721#comment-13794721 ] Tsuyoshi OZAWA commented on HADOOP-10043: - Thank you for the review. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, HADOOP-10043.3.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Attachment: Token definition and implementation 1.0.doc Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch, Token definition and implementation 1.0.doc We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Attachment: HADOOP-9836.patch Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch, Token definition and implementation 1.0.doc We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Status: Patch Available (was: Open) submit the patch Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch, Token definition and implementation 1.0.doc We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9838) Token Implementation for HAS
[ https://issues.apache.org/jira/browse/HADOOP-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9838: --- Attachment: HADOOP-9838.patch Token Implementation for HAS Key: HADOOP-9838 URL: https://issues.apache.org/jira/browse/HADOOP-9838 Project: Hadoop Common Issue Type: Task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9838.patch This issue is Token Implementation for HAS. We will implement Identity token and Access Token. Identity token is gotten after client is authenticated and is issued by Identity token service and is required when client requests access token. Access token is issued by Authorization service, and is used when client accesses Hadoop service. In this GIRA, we'll • Implement Identity Token: contains identity attributes of client, it's signed and can be verified, and it's valid in lifecycle. • Implement Access Token: contains more attributes which can be used for authorization, it's signed and can be verified, and it's valid in lifecycle. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794805#comment-13794805 ] Hadoop QA commented on HADOOP-9836: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608417/Token%20definition%20and%20implementation%201.0.doc against trunk revision . {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3217//console This message is automatically generated. Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch, Token definition and implementation 1.0.doc We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Attachment: HADOOP-9836.patch Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Status: Open (was: Patch Available) Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Attachment: (was: Token definition and implementation 1.0.doc) Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Attachment: (was: HADOOP-9836.patch) Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Liu updated HADOOP-9836: --- Status: Patch Available (was: Open) submit patch Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9836) Token definition and API
[ https://issues.apache.org/jira/browse/HADOOP-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794823#comment-13794823 ] Hadoop QA commented on HADOOP-9836: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608422/HADOOP-9836.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:red}-1 javac{color:red}. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3218//console This message is automatically generated. Token definition and API Key: HADOOP-9836 URL: https://issues.apache.org/jira/browse/HADOOP-9836 Project: Hadoop Common Issue Type: Sub-task Components: security Affects Versions: 3.0.0 Reporter: Yi Liu Labels: Rhino Attachments: HADOOP-9836.patch We need to define common token attributes and APIs for TokenAuth framework which makes the arbitrary token format can be adopted into the framework. This JIRA is a sub-task of TokenAuth framework. Common token properties, APIs and facilities that identity/access token requires will be defined. In this JIRA, we'll: • Define Token generation API, includes Token serialization/deserialization, Token encryption/sign and Token revoke/expire/renew. • Define Token validation API, includes Token decryption/verify and Token check(timestamp, audience, etc) • Define Token Attribute API, includes attributes setting, query and so on. • Define required attributes and optional attributes for identity token and access token. • Implement Token Utilities, such as print/debug. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794836#comment-13794836 ] Hadoop QA commented on HADOOP-10043: {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608397/HADOOP-10043.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3216//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3216//console This message is automatically generated. Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, HADOOP-10043.3.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-10043) Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService
[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794912#comment-13794912 ] Suresh Srinivas commented on HADOOP-10043: -- I have not looked at the patch closely. [~ozawa], can you please add more details about this. SecretManager and AbstractDelegationTokenSecretManager are used in MapReduce/Yarn, HDFS and even in Hive. I am not convinced for YARN related changes we need to make this change that impacts all the other users. The main motivation seems to be - Convert *SecretManagers in the RM to services Why can't this be done using composition instead of inheritance? Convert org.apache.hadoop.security.token.SecretManager to be an AbstractService --- Key: HADOOP-10043 URL: https://issues.apache.org/jira/browse/HADOOP-10043 Project: Hadoop Common Issue Type: Improvement Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, HADOOP-10043.3.patch I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related task). The sentence as follows is a quoted from YARN-1172's my comment: {quote} I've found that it requires org.apache.hadoop.security.token.SecretManager to be an AbstractService, because both AbstractService and org.apache.hadoop.security.token.SecretManager are abstract class and we cannot extend both of them at the same time. {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)