[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153092#comment-14153092 ] Hudson commented on HADOOP-11049: - FAILURE: Integrated in Hadoop-Yarn-trunk #696 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/696/]) HADOOP-11049. javax package system class default is too broad. Contributed by Sangjin Lee (jlowe: rev cf4631d7c9448205f4952341c071e1650e7922dc) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ApplicationClassLoader.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/resources/org.apache.hadoop.application-classloader.properties * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Fix For: 2.6.0 Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153206#comment-14153206 ] Hudson commented on HADOOP-11049: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1887 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1887/]) HADOOP-11049. javax package system class default is too broad. Contributed by Sangjin Lee (jlowe: rev cf4631d7c9448205f4952341c071e1650e7922dc) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ApplicationClassLoader.java * hadoop-common-project/hadoop-common/src/main/resources/org.apache.hadoop.application-classloader.properties * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java * hadoop-common-project/hadoop-common/CHANGES.txt javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Fix For: 2.6.0 Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153263#comment-14153263 ] Hudson commented on HADOOP-11049: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1912 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1912/]) HADOOP-11049. javax package system class default is too broad. Contributed by Sangjin Lee (jlowe: rev cf4631d7c9448205f4952341c071e1650e7922dc) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ApplicationClassLoader.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java * hadoop-common-project/hadoop-common/src/main/resources/org.apache.hadoop.application-classloader.properties javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Fix For: 2.6.0 Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151733#comment-14151733 ] Jason Lowe commented on HADOOP-11049: - +1 lgtm. Committing this. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151746#comment-14151746 ] Hudson commented on HADOOP-11049: - FAILURE: Integrated in Hadoop-trunk-Commit #6136 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6136/]) HADOOP-11049. javax package system class default is too broad. Contributed by Sangjin Lee (jlowe: rev cf4631d7c9448205f4952341c071e1650e7922dc) * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/test/java/org/apache/hadoop/mapreduce/v2/util/TestMRApps.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ApplicationClassLoader.java * hadoop-common-project/hadoop-common/src/main/resources/org.apache.hadoop.application-classloader.properties * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestRunJar.java * hadoop-common-project/hadoop-common/CHANGES.txt javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Fix For: 2.6.0 Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152635#comment-14152635 ] Sangjin Lee commented on HADOOP-11049: -- Thanks Jason! javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Fix For: 2.6.0 Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149615#comment-14149615 ] Jason Lowe commented on HADOOP-11049: - Thanks for the patch, Sangjin! I think application-classloader.properties might be too generic. Maybe we should add the org.apache.hadoop. prefix or otherwise make it more unique? Having one giant property line is not great for maintenance, as every patch against it will be a big blob of text changing to another big blob of text. We should split the value on multiple lines so it's easier to read and easier to maintain. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14149765#comment-14149765 ] Sangjin Lee commented on HADOOP-11049: -- Hi Jason, thanks for the review as always! Those are both good suggestions. I'll make those changes, and submit a new patch soon. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150038#comment-14150038 ] Hadoop QA commented on HADOOP-11049: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12671514/HADOOP-11049.patch against trunk revision 3a1f981. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.ha.TestZKFailoverControllerStress org.apache.hadoop.mapreduce.lib.input.TestMRCJCFileInputFormat {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4813//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4813//console This message is automatically generated. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150206#comment-14150206 ] Sangjin Lee commented on HADOOP-11049: -- Test failures unrelated. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122522#comment-14122522 ] Hadoop QA commented on HADOOP-11049: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/1261/HADOOP-11049.patch against trunk revision 6104520. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.v2.util.TestMRApps {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4655//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4655//console This message is automatically generated. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123419#comment-14123419 ] Hadoop QA commented on HADOOP-11049: {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12666821/HADOOP-11049.patch against trunk revision 45efc96. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.TestJavaSerialization {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4659//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4659//console This message is automatically generated. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11049) javax package system class default is too broad
[ https://issues.apache.org/jira/browse/HADOOP-11049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123465#comment-14123465 ] Sangjin Lee commented on HADOOP-11049: -- The test failure appears unrelated with the patch. javax package system class default is too broad --- Key: HADOOP-11049 URL: https://issues.apache.org/jira/browse/HADOOP-11049 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 2.6.0 Reporter: Sangjin Lee Assignee: Sangjin Lee Priority: Minor Attachments: HADOOP-11049.patch, HADOOP-11049.patch The system class default defined in ApplicationClassLoader has javax.. This is too broad. The intent of the system classes is to exempt classes that are provided by the JDK along with hadoop and minimally necessary dependencies that are guaranteed to be on the system classpath. javax. is too broad for that. For example, JSR-330 which is part of JavaEE (not JavaSE) has javax.inject. Packages like them should not be declared as system classes, as they will result in ClassNotFoundException if they are needed and present on the user classpath. -- This message was sent by Atlassian JIRA (v6.3.4#6332)