[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098749#comment-15098749
]
Colin Patrick McCabe commented on HADOOP-8887:
--
So, the two issues from the plugin I saw were this deprecation warning:
{code}
[WARNING]
/testptch/hadoop/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java:[207,30]
[deprecation] getExecutionProperties() in MavenSession has been deprecated
[WARNING]
/testptch/hadoop/hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java:[225,29]
[deprecation] getExecutionProperties() in MavenSession has been deprecated
{code}
and a complaint about the use of a hard tab in {{TestMojo.java}}. I opened
HADOOP-12712 to fix these warnings.
Aside from that, we have the usual Jenkins weirdness on one of the test runs.
{code}
java.lang.RuntimeException: Error while running command to get file permissions
: ExitCodeException exitCode=127: /bin/ls: error while loading shared
libraries: libdl.so.2: failed to map segment from shared object: Permission
denied
{code}
{{libdl.so.2}} is a Linux system library-- nothing to do with anything in this
patch. Best guess is that someone ran "apt-get update" concurrently with
Jenkins and hosed this particular unit test.
Does that cover all the issues?
> Use a Maven plugin to build the native code using CMake
> ---
>
> Key: HADOOP-8887
> URL: https://issues.apache.org/jira/browse/HADOOP-8887
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
>Affects Versions: 2.0.3-alpha
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.9.0
>
> Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
> HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch,
> HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch,
> HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch
>
>
> Currently, we build the native code using ant-build invocations. Although
> this works, it has some limitations:
> * compiler warning messages are hidden, which can cause people to check in
> code with warnings unintentionally
> * there is no framework for running native unit tests; instead, we use ad-hoc
> constructs involving shell scripts
> * the antrun code is very platform specific
> * there is no way to run a specific native unit test
> * it's more or less impossible for scripts like test-patch.sh to separate a
> native test failing from the build itself failing (no files are created) or
> to enumerate which native tests failed.
> Using a native Maven plugin would overcome these limitations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098770#comment-15098770 ] Andrew Wang commented on HADOOP-8887: - There's a bunch of checkstyle stuff, and findbugs looks like it's broken because of some kafka stuff. CC warnings, I'm guessing you're handling at HADOOP-12712 which I'll review. Overall it seems okay, it's just there's a lot more "-1" than I'm used to in a precommit run, and it's not just flaky unit tests. The whitespace/checkstyle stuff is onerous, but one more precommit run will fix it. If you want to take care of all this in HADOOP-12712, I'm okay with that. Nothing functionally wrong in what was committed, so okay to do it in a follow-on. > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.9.0 > > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098787#comment-15098787 ] Hudson commented on HADOOP-8887: FAILURE: Integrated in Hadoop-trunk-Commit #9113 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/9113/]) HADOOP-8887. Use a Maven plugin to build the native code using CMake (cmccabe: rev b1ed28fa77cb2fab80c54f9dfeb5d8b7139eca34) * hadoop-common-project/hadoop-common/pom.xml * hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/TestMojo.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * hadoop-hdfs-project/hadoop-hdfs-native-client/pom.xml * BUILDING.txt * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/cmakebuilder/CompileMojo.java * hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml * hadoop-maven-plugins/src/main/java/org/apache/hadoop/maven/plugin/util/Exec.java * hadoop-tools/hadoop-pipes/pom.xml > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.9.0 > > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098790#comment-15098790 ] Colin Patrick McCabe commented on HADOOP-8887: -- Yes, let's take care of the whitespace / etc. stuff on HADOOP-12712. There are also some flaky native unit tests, which I also think should be fixed in a follow-on. > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.9.0 > > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098678#comment-15098678 ] Andrew Wang commented on HADOOP-8887: - Hey Colin, I think commit was a little premature, since precommit flagged a bunch of issues. Could you take a look? > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Fix For: 2.9.0 > > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch, HADOOP-8887.014.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097206#comment-15097206 ] Andrew Wang commented on HADOOP-8887: - Nice work here Colin! Just a few review comments: * Rather than hardcoding 4, we could use this Java API to get the # of processors: https://docs.oracle.com/javase/7/docs/api/java/lang/Runtime.html#availableProcessors() * Nit: validateSourceParams, switch the order of arguments? Left to right I'd normally read input then output. * Would be good to update BUILDING.txt with your "-DallNative" and "-Dtest_bulk_crc32" invocations as documentation Otherwise looks great. I ran the native tests, some Java tests that use the native libs, and did a sanity check on a dist tarball too (libs were in the right place). +1 pending this and a Jenkins run. > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097278#comment-15097278 ] Colin Patrick McCabe commented on HADOOP-8887: -- bq. Rather than hardcoding 4, we could use this Java API to get the # of processors: https://docs.oracle.com/javase/7/docs/api/java/lang/Runtime.html#availableProcessors() Cool. I didn't know this API existed... will add. bq. Nit: validateSourceParams, switch the order of arguments? Left to right I'd normally read input then output. OK. bq. Would be good to update BUILDING.txt with your "-DallNative" and "-Dtest_bulk_crc32" invocations as documentation Added > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch, HADOOP-8887.013.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097554#comment-15097554
]
Hadoop QA commented on HADOOP-8887:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 54s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
2s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 59s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 26s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
4s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
54s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 21m 57s
{color} | {color:red} root in trunk failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 24s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 11m 5s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 16s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 25s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 18m 38s {color} |
{color:red} root-jdk1.8.0_66 with JDK v1.8.0_66 generated 1 new issues (was 13,
now 13). {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 8m 25s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 18m 38s
{color} | {color:red} root-jdk1.8.0_66 with JDK v1.8.0_66 generated 2 new
issues (was 730, now 732). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 25s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 38s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} cc {color} | {color:red} 27m 17s {color} |
{color:red} root-jdk1.7.0_91 with JDK v1.7.0_91 generated 3 new issues (was 23,
now 23). {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 8m 38s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 27m 17s
{color} | {color:red} root-jdk1.7.0_91 with JDK v1.7.0_91 generated 2 new
issues (was 724, now 726). {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 38s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 15s
{color} | {color:red} Patch generated 25 new checkstyle issues in root (total
was 3, now 28). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 11m
21s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
46s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 2 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 22m 41s
{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 17s
{color} | {color:red} root in the patch
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095458#comment-15095458 ] Kai Zheng commented on HADOOP-8887: --- This sounds so good to have! I felt the same pain and necessity during working on ISA-L integration, having been wondering if it's possible to unify the native building process for both Linux and Windows, provide much easier setup for adding new unit tests until finding this. Would very happily lend a hand in this aspect if necessary. Thanks! > Use a Maven plugin to build the native code using CMake > --- > > Key: HADOOP-8887 > URL: https://issues.apache.org/jira/browse/HADOOP-8887 > Project: Hadoop Common > Issue Type: Improvement > Components: build >Affects Versions: 2.0.3-alpha >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe >Priority: Minor > Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, > HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, > HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch, > HADOOP-8887.012.patch > > > Currently, we build the native code using ant-build invocations. Although > this works, it has some limitations: > * compiler warning messages are hidden, which can cause people to check in > code with warnings unintentionally > * there is no framework for running native unit tests; instead, we use ad-hoc > constructs involving shell scripts > * the antrun code is very platform specific > * there is no way to run a specific native unit test > * it's more or less impossible for scripts like test-patch.sh to separate a > native test failing from the build itself failing (no files are created) or > to enumerate which native tests failed. > Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14364466#comment-14364466 ] Colin Patrick McCabe commented on HADOOP-8887: -- Please, -1 on automatic downloading of cmake. The build takes long enough as-is, and cmake takes forever to download and install. Plus we would have to somehow find the correct version for each different Linux distribution / BSD / Mac OS release, which puts this firmly in Not Happening territory. And building cmake from source takes a really long time, maybe almost as much as Hadoop itself! I don't remember exactly how long it took last time I did it. I think we could move off of supporting cmake 2.6 in branch-2 today if we wanted to. We only supported it earlier because people wanted to run on Red Hat 5, but that is no longer a concern. We could bump the minimum version up to 2.8 and get rid of a bunch of quirks code. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361458#comment-14361458 ] Haohui Mai commented on HADOOP-8887: Either approach looks reasonable to me. The only benefit of the cmake-maven-project plugin is that it downloads cmake 2.8 automatically thus it is possible to remove a bunch of quirks for cmake 2.6 we have today. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361355#comment-14361355 ] Colin Patrick McCabe commented on HADOOP-8887: -- I did try to work with cmake-maven-project in the past. I wasn't able to get it working. The biggest issues were the lack of support for JDK6 (which would no longer be an issue, of course), and the fact that it was mainly tested and developed on Windows. I wasn't able to get it to work on UNIX at all, after spending some time with it a few years ago. It looks like the project has not been very active (last commit was more than a year ago), so I don't think there is a big benefit over just using cmake-maven-ng. cmake-maven-ng also supported a mode which allowed all tests to be run, or just a specific native test, something that a large project like Hadoop really needs. Now that we are bundling other maven plugins in the Hadoop repo, we should probably just bundle the cmake-maven-ng plugin there. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353524#comment-14353524 ] Haohui Mai commented on HADOOP-8887: I just came across https://code.google.com/p/cmake-maven-project/ today. [~cmccabe], do you have any experience on the cmake-maven-project? Do you think it makes sense to adopt the plugin in the current POMs? Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.7.0 Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch, HADOOP-8887.008.patch, HADOOP-8887.011.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479942#comment-13479942 ] Hudson commented on HADOOP-8887: Integrated in Hadoop-Yarn-trunk #8 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/8/]) reverting commit 1399898 (HADOOP-8887) (Revision 1399972) HADOOP-8887. Use a Maven plugin to build the native code using CMake. (cmccabe via tucu) (Revision 1399898) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399972 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399898 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/pom.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/CompileMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/TestMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/Utils.java * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480005#comment-13480005 ] Hudson commented on HADOOP-8887: Integrated in Hadoop-Hdfs-trunk #1200 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1200/]) reverting commit 1399898 (HADOOP-8887) (Revision 1399972) HADOOP-8887. Use a Maven plugin to build the native code using CMake. (cmccabe via tucu) (Revision 1399898) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399972 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399898 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/pom.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/CompileMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/TestMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/Utils.java * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480038#comment-13480038 ] Hudson commented on HADOOP-8887: Integrated in Hadoop-Mapreduce-trunk #1230 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1230/]) reverting commit 1399898 (HADOOP-8887) (Revision 1399972) HADOOP-8887. Use a Maven plugin to build the native code using CMake. (cmccabe via tucu) (Revision 1399898) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399972 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399898 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/pom.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/CompileMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/TestMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/Utils.java * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479198#comment-13479198 ] Colin Patrick McCabe commented on HADOOP-8887: -- test failures are unrelated Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479446#comment-13479446 ] Hudson commented on HADOOP-8887: Integrated in Hadoop-trunk-Commit #2889 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2889/]) HADOOP-8887. Use a Maven plugin to build the native code using CMake. (cmccabe via tucu) (Revision 1399898) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399898 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/dev-support/findbugsExcludeFile.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/pom.xml * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/CompileMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/TestMojo.java * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin/src/main/java/org/apache/hadoop/cmake/maven/ng/Utils.java * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479571#comment-13479571 ] Tsz Wo (Nicholas), SZE commented on HADOOP-8887: How about the javadoc warnings? Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479570#comment-13479570 ] Suresh Srinivas commented on HADOOP-8887: - I reverted the branch-2 patch. Some build issues and version number issues have been identified with that merge. Perhaps you need a separate patch for branch-2. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479602#comment-13479602 ] Suresh Srinivas commented on HADOOP-8887: - @Alejandro no worries. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479642#comment-13479642 ] Hudson commented on HADOOP-8887: Integrated in Hadoop-trunk-Commit #2893 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/2893/]) reverting commit 1399898 (HADOOP-8887) (Revision 1399972) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1399972 Files : * /hadoop/common/trunk/dev-support * /hadoop/common/trunk/dev-support/cmake-maven-ng-plugin * /hadoop/common/trunk/dev-support/pom.xml * /hadoop/common/trunk/dev-support/test-patch.sh * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/pom.xml * /hadoop/common/trunk/hadoop-project/pom.xml * /hadoop/common/trunk/hadoop-tools/hadoop-pipes/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml * /hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c * /hadoop/common/trunk/pom.xml Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Fix For: 2.0.3-alpha Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch, HADOOP-8887.006.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478267#comment-13478267 ] Alejandro Abdelnur commented on HADOOP-8887: +1 pending jenkins. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478341#comment-13478341
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548991/HADOOP-8887.005.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 2031 javac
compiler warnings (more than the trunk's current 2030 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1641//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1641//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1641//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13478550#comment-13478550
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549601/HADOOP-8887.006.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 4
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:
org.apache.hadoop.hdfs.server.namenode.ha.TestInitializeSharedEdits
org.apache.hadoop.hdfs.server.balancer.TestBalancer
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1642//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1642//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch,
HADOOP-8887.006.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475480#comment-13475480
]
Colin Patrick McCabe commented on HADOOP-8887:
--
By the way, one thing that's cool about this patch is that you can now run
{code}
mvn test -Pnative -Dtest=test_native_mini_dfs
{code}
and it will run the native test, just like you would expect.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13475481#comment-13475481 ] Colin Patrick McCabe commented on HADOOP-8887: -- oh, also, I added the default parameters as tucu suggested. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch, HADOOP-8887.005.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13473251#comment-13473251 ] Tom White commented on HADOOP-8887: --- bq. Does it make sense to put it in Hadoop for now, and then spin it off into another project later? If we do that we should at least put it in a org.apache.hadoop package since the Hadoop PMC doesn't control the org.apache.maven namespace. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472272#comment-13472272 ] Tom White commented on HADOOP-8887: --- This plugin looks general purpose and it's in the org.apache.maven package, so perhaps it should go in the Maven Plugins project? Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472758#comment-13472758 ] Colin Patrick McCabe commented on HADOOP-8887: -- It would be nice to spin it off as a separate project, but that seems like it would just make it more difficult to iterate on the design in the short term, which is what we will need to get it truly polished. If it's a separate project, we'll have backwards compatibility constraints, and also need two changes (one to add a feature to it, another to update Hadoop to use the new version and features) for every change. Does it make sense to put it in Hadoop for now, and then spin it off into another project later? Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472786#comment-13472786
]
Alejandro Abdelnur commented on HADOOP-8887:
* plugin root package should be org.apache.hadoop if in Hadoop.
* source directory should be settable via an 'source' property which defaults
to ${basedir}/src/main/native
* build directory should be settable via an 'outputDirectory' property which
defaults to ${project.build.directory}/native if not set.
* what is the diff between the output and target params in the CompileMojo? Do
we need both? see prev comment on naming.
* CleanMojo, why do we need this one? 'mvn clean' already takes care of it.
* what is the diff between cmake-generate and cmake-compile? Do we need 2
different Mojos? Do we gain something from it?
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472842#comment-13472842
]
Colin Patrick McCabe commented on HADOOP-8887:
--
bq. plugin root package should be org.apache.hadoop if in Hadoop.
OK.
bq. source directory should be settable via an 'source' property which defaults
to ${basedir}/src/main/native
It is, via GenerateMojo#source
bq. build directory should be settable via an 'outputDirectory' property which
defaults to ${project.build.directory}/native if not set.
It is, via GenerateMojo#output and CompileMojo#output.
bq. what is the diff between the output and target params in the CompileMojo?
Do we need both? see prev comment on naming.
Build target would be something like Debug, Production, etc. output is a
directory. I will add a comment explaining this.
bq. CleanMojo, why do we need this one? 'mvn clean' already takes care of it.
'mvn clean' will delete the 'target' directory, but we don't enforce the
concept that the CMake-ng output directory is inside that directory. We could
enforce this, and then make get rid of the clean target? However, we also
might need this for when we're supporting Windows, maybe?
bq. what is the diff between cmake-generate and cmake-compile? Do we need 2
different Mojos? Do we gain something from it?
cmake-generate runs the cmake application to create the Makefiles.
cmake-compile actually runs Make on these generated files. It seems natural to
separate these two steps. However, I don't have a specific reason why it has
to be implemented this way -- we could combine both steps into one. I was
trying to go with the spirit of Maven, which separates code generation and
compilation.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472857#comment-13472857
]
Alejandro Abdelnur commented on HADOOP-8887:
* Unless I'm missing something, I don't see patch anything like the following
to define defaults:
{code}
* @parameter expression=${source}
default-value=${basedir}/src/main/native
* @parameter expression=${output}
default-value=${project.build.directory}/native
{code}
* CleanMojo for windows, I don't see how, but if that is the case we should
introduce it then if needed, not now just in case.
* generate/make, I'd merge them in a single Mojo as there are not usecases for
using them apart, plus generate does not generate sources but make files.
* where test code lives? does compiled test stuff need to be segregated in
target/test-native?
As an additional reason for removing clean merging generate/make is that the
amount of plugins config in the POMs are reduced from 3 to 1.
I have not run the patch yet, but I assume that ALL generated/created files are
done under output and the source tree is not polluted with files created at
build time.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472864#comment-13472864 ] Colin Patrick McCabe commented on HADOOP-8887: -- bq. [defaults] I'll add defaults for those parameters. bq. CleanMojo for windows, I don't see how, but if that is the case we should introduce it then if needed, not now just in case. My big concern is just that people will put their output directories somewhere other than in a directory that gets auto-cleaned. I think if we skip the clean step, we have to somehow enforce the constraint that the output directory gets cleared by mvn clean; otherwise we're just creating hidden dangers for the future. bq. generate/make, I'd merge them in a single Mojo as there are not usecases for using them apart, plus generate does not generate sources but make files. OK. I'm fine with merging the cmake and make steps. It probably will make the pom.xml files shorter, which we can always use. bq. I have not run the patch yet, but I assume that ALL generated/created files are done under output and the source tree is not polluted with files created at build time. Yep. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472866#comment-13472866 ] Alejandro Abdelnur commented on HADOOP-8887: got it, ok on clean. on the defaults, make sure you have tests for them. You've missed one question from prev comment: where test code lives? does compiled test stuff need to be segregated in target/test-native? Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[ https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472875#comment-13472875 ] Colin Patrick McCabe commented on HADOOP-8887: -- bq. does compiled test stuff need to be segregated in target/test-native? No. Use a Maven plugin to build the native code using CMake --- Key: HADOOP-8887 URL: https://issues.apache.org/jira/browse/HADOOP-8887 Project: Hadoop Common Issue Type: Improvement Components: build Affects Versions: 2.0.3-alpha Reporter: Colin Patrick McCabe Assignee: Colin Patrick McCabe Priority: Minor Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch, HADOOP-8887.003.patch, HADOOP-8887.004.patch Currently, we build the native code using ant-build invocations. Although this works, it has some limitations: * compiler warning messages are hidden, which can cause people to check in code with warnings unintentionally * there is no framework for running native unit tests; instead, we use ad-hoc constructs involving shell scripts * the antrun code is very platform specific * there is no way to run a specific native unit test * it's more or less impossible for scripts like test-patch.sh to separate a native test failing from the build itself failing (no files are created) or to enumerate which native tests failed. Using a native Maven plugin would overcome these limitations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471990#comment-13471990
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548319/HADOOP-8887.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 2061 javac
compiler warnings (more than the trunk's current 2053 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1577//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1577//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1577//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472096#comment-13472096
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548345/HADOOP-8887.004.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1584//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1584//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch,
HADOOP-8887.003.patch, HADOOP-8887.004.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470538#comment-13470538
]
Colin Patrick McCabe commented on HADOOP-8887:
--
A word of explanation about the {{test-container-executor.c}} change: it seems
that when launched directly from Maven rather than from a shell, {{SIGQUIT}}
starts off blocked, causing the test to fail. The change manually unblocks
this signal-- always a good idea to do before you start using a signal.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470646#comment-13470646
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548020/HADOOP-8887.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 2057 javac
compiler warnings (more than the trunk's current 2053 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 15 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1566//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1566//artifact/trunk/patchprocess/newPatchFindbugsWarningscmake-maven-ng-plugin.html
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1566//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1566//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8887) Use a Maven plugin to build the native code using CMake
[
https://issues.apache.org/jira/browse/HADOOP-8887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13470853#comment-13470853
]
Hadoop QA commented on HADOOP-8887:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12548065/HADOOP-8887.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 javac{color}. The applied patch generated 2057 javac
compiler warnings (more than the trunk's current 2053 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 8
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 10 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
dev-support/cmake-maven-ng-plugin hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1569//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1569//artifact/trunk/patchprocess/newPatchFindbugsWarningscmake-maven-ng-plugin.html
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1569//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1569//console
This message is automatically generated.
Use a Maven plugin to build the native code using CMake
---
Key: HADOOP-8887
URL: https://issues.apache.org/jira/browse/HADOOP-8887
Project: Hadoop Common
Issue Type: Improvement
Components: build
Affects Versions: 2.0.3-alpha
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
Attachments: HADOOP-8887.001.patch, HADOOP-8887.002.patch
Currently, we build the native code using ant-build invocations. Although
this works, it has some limitations:
* compiler warning messages are hidden, which can cause people to check in
code with warnings unintentionally
* there is no framework for running native unit tests; instead, we use ad-hoc
constructs involving shell scripts
* the antrun code is very platform specific
* there is no way to run a specific native unit test
* it's more or less impossible for scripts like test-patch.sh to separate a
native test failing from the build itself failing (no files are created) or
to enumerate which native tests failed.
Using a native Maven plugin would overcome these limitations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
