RE: [Collection] Moving tx map wrappers into Collection Component?
Understood! I was just hoping to let them be a free rider on the success of [collections] ;) -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Sat 6/12/2004 1:40 AM To: Jakarta Commons Developers List Subject: Re: [Collection] Moving tx map wrappers into Collection Component? [collections] currently faces issues with size, ie some OSS people believe its too large. In v3.0 we kicked out the primitive collections code to [primitives] and the event based work to the sandbox [events]. It would seem to me that this sets a precedent for keeping clearly identifiable collections/groups of collections out of [collections]. So I'm -1 to adding them at the moment. Stephen - Original Message - From: Oliver Zeigermann [EMAIL PROTECTED] I was wondering if you collection people would like to have the transactional map wrappers I have developed in the transaction component moved into the collection component. They might be a good supplement and get more attention this way. Those wrappers work fine and each has some basic JUnit test. The wrappes include - a basic version doing read committed isolation that never blocks and never fails upon commit - an extended version allowing for serializable isolation using pessimistic locks; the drawback is this wrapper might deadlock - and extended verion allowing for serializable isolation using an optimictic strategy; the drawback is this wrapper might fail upon commit when conflicts occur All wrappers take any kind of map to be wrapped. In case you use LRUMap or anything similar you can even implement a transactional cache with it. What do you folks say? Cheers, Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29440] - [Collections] MultiSortedMap / MultiTreeMap
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29440. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29440 [Collections] MultiSortedMap / MultiTreeMap --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 08:00 --- I agree, but of course MultiKeyMap doesn't help here, what's needed would be a MultiValueMap. Do you plan to add something like that? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/dbcp project.xml
dirkv 2004/06/12 06:25:31 Modified:dbcp project.xml Log: prepare release 1.2.1 Revision ChangesPath 1.33 +6 -1 jakarta-commons/dbcp/project.xml Index: project.xml === RCS file: /home/cvs/jakarta-commons/dbcp/project.xml,v retrieving revision 1.32 retrieving revision 1.33 diff -u -r1.32 -r1.33 --- project.xml 8 Jun 2004 20:33:00 - 1.32 +++ project.xml 12 Jun 2004 13:25:31 - 1.33 @@ -19,7 +19,7 @@ idcommons-dbcp/id inceptionYear2001/inceptionYear - currentVersion1.3-dev/currentVersion + currentVersion1.2.1/currentVersion nameCommons DBCP/name shortDescriptionCommons Database Connection Pooling/shortDescription descriptionCommons Database Connection Pooling/description @@ -83,6 +83,11 @@ id1.2/id name1.2/name tagDBCP_1_2/tag +/version +version + id1.2.1/id + name1.2.1/name + tagDBCP_1_2_1/tag /version /versions branches - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/dbcp/xdocs release-notes-1.2.1.xml downloads.xml
dirkv 2004/06/12 06:25:56 Modified:dbcp/xdocs downloads.xml Added: dbcp/xdocs release-notes-1.2.1.xml Log: prepare release 1.2.1 Revision ChangesPath 1.7 +2 -1 jakarta-commons/dbcp/xdocs/downloads.xml Index: downloads.xml === RCS file: /home/cvs/jakarta-commons/dbcp/xdocs/downloads.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- downloads.xml 7 Jun 2004 17:56:43 - 1.6 +++ downloads.xml 12 Jun 2004 13:25:56 - 1.7 @@ -25,6 +25,7 @@ section name=Releases pThe following releases are available:/p ul + liVersion 1.2.1 - 14 June 2004 - a href=release-notes-1.2.1.html(release notes)/a/li liVersion 1.2 - 7 June 2004 - a href=release-notes-1.2.html(release notes)/a/li liVersion 1.1 - 20 October 2003 - a href=release-notes-1.1.html(release notes)/a/li liVersion 1.0 - 12 August 2002/li 1.1 jakarta-commons/dbcp/xdocs/release-notes-1.2.1.xml Index: release-notes-1.2.1.xml === ?xml version=1.0? !-- Copyright 2003-2004 The Apache Software Foundation Licensed under the Apache License, Version 2.0 (the License); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -- document properties titleRelease notes for Commons-DBCP 1.2.1/title author email=[EMAIL PROTECTED]Commons Documentation Team/author revision$Id: release-notes-1.2.1.xml,v 1.1 2004/06/12 13:25:56 dirkv Exp $/revision /properties body section name=Release notes for Commons-DBCP 1.2.1 p bNOTE:/b DBCP v1.2.1 requires Pool v1.2, make sure you use the correct version! /p hr/ pDBCP 1.2.1 is a maintenance release to restore full JDK 1.3 compatibility./p pThe problem lies in the improper use of a JDK 1.4 method: java.lang.Boolean.valueOf(boolean)/p pThis method was used in the defaultReadOnly property processing./p pWe recommend to upgrade to DBCP 1.2.1 to avoid this problem altogether./p hr/ pIf you use the defaultReadOnly property in a JRE lt;1.4, you will get the following error: source java.lang.NoSuchMethodError at org.apache.commons.dbcp.BasicDataSource.setDefaultReadOnly(BasicDataSource.java:75) at org.apache.commons.dbcp.BasicDataSourceFactory.createDataSource(BasicDataSourceFactory.java:162) at org.apache.commons.dbcp.BasicDataSourceFactory.getObjectInstance(BasicDataSourceFactory.java:144) at org.apache.naming.factory.ResourceFactory.getObjectInstance(ResourceFactory.java:176) /source /p pThe simple workaround is not to use this property. For example remove the following from the tomcat config.xml. source![CDATA[ parameter namedefaultReadOnly/name valuetrue/value /parameter ]]/source /p /section /body /document - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/test/src/java/org/apache/commons/test/collection CollectionTest.java
ozeigermann2004/06/12 06:33:36
Modified:test/src/java/org/apache/commons/test/file FileTest.java
test/src/java/org/apache/commons/test/concurrent
RendezvousBarrier.java
test/src/java/org/apache/commons/test/collection
CollectionTest.java
Log:
Removed author tag to indicate community is responsible
Revision ChangesPath
1.2 +4 -4
jakarta-commons-sandbox/test/src/java/org/apache/commons/test/file/FileTest.java
Index: FileTest.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/test/src/java/org/apache/commons/test/file/FileTest.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- FileTest.java 11 Jun 2004 12:48:40 - 1.1
+++ FileTest.java 12 Jun 2004 13:33:36 - 1.2
@@ -31,7 +31,7 @@
/**
* Test helpers for collections.
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
*/
public class FileTest {
1.2 +4 -4
jakarta-commons-sandbox/test/src/java/org/apache/commons/test/concurrent/RendezvousBarrier.java
Index: RendezvousBarrier.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/test/src/java/org/apache/commons/test/concurrent/RendezvousBarrier.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- RendezvousBarrier.java11 Jun 2004 12:22:56 - 1.1
+++ RendezvousBarrier.java12 Jun 2004 13:33:36 - 1.2
@@ -27,7 +27,7 @@
* Simple barrier that blocks until all parties have either called or have arrived
at the meeting point.
* Very useful for testing that require to make concurrent settings deterministic.
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
*/
public class RendezvousBarrier {
1.3 +4 -4
jakarta-commons-sandbox/test/src/java/org/apache/commons/test/collection/CollectionTest.java
Index: CollectionTest.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/test/src/java/org/apache/commons/test/collection/CollectionTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- CollectionTest.java 11 Jun 2004 12:47:58 - 1.2
+++ CollectionTest.java 12 Jun 2004 13:33:36 - 1.3
@@ -31,7 +31,7 @@
/**
* Test helpers for collections.
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
*/
public class CollectionTest {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/transaction/src/test/org/apache/commons/transaction/file FileResourceManagerTest.java
ozeigermann2004/06/12 06:39:25
Modified:transaction/src/java/org/apache/commons/transaction/locking
MultiLevelLock.java GenericLockManager.java
GenericLock.java LockManager.java
transaction/src/java/org/apache/commons/transaction/memory/jca
MapManagedConnection.java
MemoryMapResourceManager.java
MapConnectionSpec.java MapLocalTransaction.java
MapConnection.java MapConnectionFactory.java
MapXAResource.java MapManagedConnectionFactory.java
transaction/src/java/org/apache/commons/transaction/memory
HashMapFactory.java LockException.java
SetFactory.java MapFactory.java
TransactionalMapWrapper.java ConflictException.java
HashSetFactory.java OptimisticMapWrapper.java
PessimisticMapWrapper.java
transaction/src/java/org/apache/commons/transaction/file
ResourceManagerException.java
ResourceManagerErrorCodes.java
ResourceManagerSystemException.java
FileResourceManager.java ResourceManager.java
FileSequence.java
transaction/src/java/org/apache/commons/transaction/util
RendezvousBarrier.java LoggerFacade.java
Jdk14Logger.java Log4jLogger.java FileHelper.java
XidWrapper.java
transaction/src/test/org/apache/commons/transaction/memory
PessimisticMapWrapperTest.java MapWrapperTest.java
OptimisticMapWrapperTest.java
transaction/src/test/org/apache/commons/transaction/file
FileResourceManagerTest.java
Log:
Removed author tag to indicate community is responsible
Revision ChangesPath
1.2 +4 -4
jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/MultiLevelLock.java
Index: MultiLevelLock.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/MultiLevelLock.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- MultiLevelLock.java 14 May 2004 13:06:45 - 1.1
+++ MultiLevelLock.java 12 Jun 2004 13:39:24 - 1.2
@@ -27,7 +27,7 @@
*
* A multi level lock. Depending on the implementation more than one owner may own
a certain lock level on the same lock.
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
* @see LockManager
*/
public interface MultiLevelLock {
1.2 +4 -4
jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/GenericLockManager.java
Index: GenericLockManager.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/GenericLockManager.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- GenericLockManager.java 14 May 2004 13:06:45 - 1.1
+++ GenericLockManager.java 12 Jun 2004 13:39:24 - 1.2
@@ -32,7 +32,7 @@
/**
* Manager for [EMAIL PROTECTED] GenericLock}s on resources.
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
*/
public class GenericLockManager implements LockManager {
1.3 +4 -4
jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/GenericLock.java
Index: GenericLock.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/GenericLock.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- GenericLock.java 5 Jun 2004 16:50:00 - 1.2
+++ GenericLock.java 12 Jun 2004 13:39:24 - 1.3
@@ -100,7 +100,7 @@
* forgets to release a lock or is not able to do so due to error states or
abnormal termination.
* /ul
*
- * @author a href=mailto:[EMAIL PROTECTED]Oliver Zeigermann/a
+ * @version $Revision$
*/
public class GenericLock implements MultiLevelLock {
1.2 +4 -4
jakarta-commons-sandbox/transaction/src/java/org/apache/commons/transaction/locking/LockManager.java
Index: LockManager.java
===
RCS file:
[VOTE][DBCP] Release commons-dbcp v1.2.1
DBCP 1.2.1 is a maintenance release to restore full JDK 1.3 compatibility. Details can be found here: http://cvs.apache.org/~dirkv/dbcp/release-notes-1.2.1.html CVS head tagged as DBCP_1_2_1 Distribution can be previewed here: http://cvs.apache.org/~dirkv/builds/ Cast your votes please: [ ] +1 Go for it! [ ] -1 I found another issue -- Dirk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE][DBCP] Release commons-dbcp v1.2.1
+1 from me of course -- Dirk Dirk Verbeeck wrote: DBCP 1.2.1 is a maintenance release to restore full JDK 1.3 compatibility. Details can be found here: http://cvs.apache.org/~dirkv/dbcp/release-notes-1.2.1.html CVS head tagged as DBCP_1_2_1 Distribution can be previewed here: http://cvs.apache.org/~dirkv/builds/ Cast your votes please: [ ] +1 Go for it! [ ] -1 I found another issue -- Dirk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections/xdocs compatibility.xml index.xml
scolebourne2004/06/12 07:43:16 Modified:collections/xdocs compatibility.xml index.xml Log: Update website docs Revision ChangesPath 1.2 +4 -2 jakarta-commons/collections/xdocs/compatibility.xml Index: compatibility.xml === RCS file: /home/cvs/jakarta-commons/collections/xdocs/compatibility.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- compatibility.xml 29 May 2004 14:23:25 - 1.1 +++ compatibility.xml 12 Jun 2004 14:43:16 - 1.2 @@ -48,8 +48,8 @@ /li /ul p -Releases of Apache projects, including collections, aim to be source and binary compatible -within minor versions, and to avoid breakages as much as possible between major versions. +Releases of commons collections aim to be source and binary compatible within minor versions, +and to avoid breakages as much as possible between major versions. /p p @@ -62,6 +62,8 @@ bexcept for certain methods on one class/b. As the release was a major version, this is permitted, however it was unintentional and an error. The problem is in the bcodeIteratorUtils/code/b class (see methods below). +(Strictly speaking, there are some minor incompatibilities on other classes, but these +changes were deliberate and have not caused any known issues.) /p p 1.15 +6 -2 jakarta-commons/collections/xdocs/index.xml Index: index.xml === RCS file: /home/cvs/jakarta-commons/collections/xdocs/index.xml,v retrieving revision 1.14 retrieving revision 1.15 diff -u -r1.14 -r1.15 --- index.xml 29 May 2004 14:23:25 - 1.14 +++ index.xml 12 Jun 2004 14:43:16 - 1.15 @@ -53,8 +53,8 @@ /ul /p p -Patch version 2.1.1 has just been released. -The provides a work around to a a href=compatibility.htmlversion compatibility/a issue between v2.1 and v3.0. +Preview version 3.1-RC1 and patch version 2.1.1 have just been released. +These provides a work around to a a href=compatibility.htmlversion compatibility/a issue between v2.1 and v3.0. /p /section @@ -82,6 +82,10 @@ Version 3.0/2.1.1 - a href=http://jakarta.apache.org/site/binindex.cgi#commons-collections;Binary/a - a href=http://jakarta.apache.org/site/sourceindex.cgi#commons-collections;Source/a +/p +p +Version 3.1-RC1 (preview for testing - not for production use) - + a href=http://www.apache.org/~scolebourne/coll31/;Source and binary/a /p p For previous releases, see the a href=http://archive.apache.org/dist/jakarta/commons/collections/;Apache Archive/a - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/collections README.txt
scolebourne2004/06/12 07:45:33 Modified:collections README.txt Log: Emphasise Ant as main build tool Revision ChangesPath 1.7 +1 -1 jakarta-commons/collections/README.txt Index: README.txt === RCS file: /home/cvs/jakarta-commons/collections/README.txt,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- README.txt10 Jun 2004 22:17:42 - 1.6 +++ README.txt12 Jun 2004 14:45:33 - 1.7 @@ -43,7 +43,7 @@ Maven - -The component can also be built using Maven. +The component can also be built using Maven. (Ant is the primary build tool.) It can be found here : http://maven.apache.org/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE][DBCP] Release commons-dbcp v1.2.1
+1 - Original Message - From: Dirk Verbeeck [EMAIL PROTECTED] DBCP 1.2.1 is a maintenance release to restore full JDK 1.3 compatibility. Details can be found here: http://cvs.apache.org/~dirkv/dbcp/release-notes-1.2.1.html CVS head tagged as DBCP_1_2_1 Distribution can be previewed here: http://cvs.apache.org/~dirkv/builds/ Cast your votes please: [ ] +1 Go for it! [ ] -1 I found another issue -- Dirk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[ANOUNCEMENT] Commons Collections 3.1-RC1 and 2.1.1 released
The Commons Collections team announces the release of Commons Collections 3.1-RC1. This is a preview of v3.1 to enable users to test the release against their own code. We advise waiting for the formal 3.1 release before putting the code into production. Please direct any feedback on issues or bugs to [EMAIL PROTECTED] Read the release notes - http://www.apache.org/~scolebourne/coll31/RELEASE-NOTES.html Download the distribution - http://www.apache.org/~scolebourne/coll31/ The Commons Collections team also announces the release of Commons Collections 2.1.1. This is a patch release to v2.1 to enable a workaround of issues in IteratorUtils v3.0. If you are still using v2.1 please upgrade to v2.1.1, especially if you run an Open Source project. See the release notes for full details of the patch and why it was produced. Read the release notes - http://www.apache.org/dist/jakarta/commons/collections/RELEASE-NOTES-2.1.1.h tml Download the binary distribution - http://jakarta.apache.org/site/binindex.cgi#commons-collections Download the source distribution - http://jakarta.apache.org/site/sourceindex.cgi#commons-collections Stephen Colebourne http://jakarta.apache.org/commons/collections/index.html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Graduate Commons Chain to Commons Proper
+1 I'm just starting to use struts myself and am trying to work out workflow issues between actions. Any way we can speed up Struts workflow development efforts gets a +1 from me. -Mark Diggory Dion Gillard wrote: +1 On Wed, 9 Jun 2004 23:07:14 -0700, Martin Cooper [EMAIL PROTECTED] wrote: -Original Message- From: Don Brown [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 09, 2004 3:40 PM To: Jakarta Commons Developers List Subject: [VOTE] Graduate Commons Chain to Commons Proper I propose Commons Chain should graduate to Commons Proper. I'm not sure what justification I should give other than Struts is planning on including it in future releases, and I personally am, as I've already mentioned, using commons-chain in a production application to help decompose complex data importing/transformation processes in addition to using it with struts-chain in a different application. I don't see any bugs against it in bugzilla, and have personally experienced no problems. The justification you should give is the following set of criteria: 1) The component has attracted a community of users and developers that is likely to continue to exist, and that contributes to the future development of the component. 2) The external API of the component is sufficiently stable that it is unlikely to change, in more than minor ways, between now and a final release. 3) The code base is sufficiently stable that, barring bug fixes, it would be suitable for a production release as is. Since I believe Commons Chain meets these criteria, here is my +1. -- Martin Cooper Don - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Mark Diggory Software Developer Harvard MIT Data Center http://www.hmdc.harvard.edu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[math] DoubleArray changes
I would like to make the following changes to the DoubleArray utilities. This is partly to make maintenance and documentation easier and to limit what we release to what we are actually using. 1. Drop FixedDoubleArray. It is not used anywhere in [math] and its implementation of addElementRolling makes it hard to correctly document what this method means at the DoubleArray level. 2. Make setInitialCapacity protected (should only be invoked by constructors) 3. Address TODO regarding additive expansion in ExpandableDoubleArray by adding a property, expansionMode with (int) values ADDITIVE_MODE and MULTIPLICATIVE_MODE determining whether expansion means adding expansionFactor elements or multiplying the size by this factor. I have written code, documenation and test cases for this. 4. Combine ExpandableDoubleArray and ContractableDoubleArray. The latter is what we use in [math] and the addElementRolling impl in ExpandableDoubleArray is dangerous (the internal array just keeps growing). Alternatively, if others feel strongly that ExpandableDoubleArray provides an important extension point, we could make this class abstract. I just don't see practical use cases for concrete instances of ExpandableDoubleArray. Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [math] DoubleArray changes
Go for it... +1 Phil Steitz wrote: I would like to make the following changes to the DoubleArray utilities. This is partly to make maintenance and documentation easier and to limit what we release to what we are actually using. 1. Drop FixedDoubleArray. It is not used anywhere in [math] and its implementation of addElementRolling makes it hard to correctly document what this method means at the DoubleArray level. 2. Make setInitialCapacity protected (should only be invoked by constructors) 3. Address TODO regarding additive expansion in ExpandableDoubleArray by adding a property, expansionMode with (int) values ADDITIVE_MODE and MULTIPLICATIVE_MODE determining whether expansion means adding expansionFactor elements or multiplying the size by this factor. I have written code, documenation and test cases for this. 4. Combine ExpandableDoubleArray and ContractableDoubleArray. The latter is what we use in [math] and the addElementRolling impl in ExpandableDoubleArray is dangerous (the internal array just keeps growing). Alternatively, if others feel strongly that ExpandableDoubleArray provides an important extension point, we could make this class abstract. I just don't see practical use cases for concrete instances of ExpandableDoubleArray. Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Mark Diggory Software Developer Harvard MIT Data Center http://www.hmdc.harvard.edu - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [RESULT] /avail/ change needed Was: [VOTE] Leo Sutic Commit Status
Leo's in. Could someone with avail access add him into Commons? Done. Leo, please verify. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/validator/src/test/org/apache/commons/validator EmailTest.java
leosutic2004/06/12 11:18:39
Modified:validator/src/test/org/apache/commons/validator
EmailTest.java
Log:
Minor changes to JavaDocs.
Revision ChangesPath
1.27 +11 -10
jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java
Index: EmailTest.java
===
RCS file:
/home/cvs/jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27
--- EmailTest.java8 Jun 2004 14:48:35 - 1.26
+++ EmailTest.java12 Jun 2004 18:18:38 - 1.27
@@ -151,8 +151,8 @@
}
/**
-* pTests the e-mail validation with a dot at the end of
-* the address./p
+* Tests the e-mail validation with a dot at the end of
+* the address.
*/
public void testEmailWithDotEnd() throws ValidatorException {
// Create bean to run test on.
@@ -164,8 +164,8 @@
}
/**
- * pTests the e-mail validation with an RCS-noncompliant character in
- * the address./p
+ * Tests the e-mail validation with an RCS-noncompliant character in
+ * the address.
*/
public void testEmailWithBogusCharacter() throws ValidatorException {
// Create bean to run test on.
@@ -199,10 +199,11 @@
/**
* Write this test according to parts of RFC, as opposed to the type of
character
* that is being tested.
- * @throws ValidatorException
- *
- * FIXME This test fails so disable it with a leading _ for 1.1.2 release.
+ *
+ * pbFIXME/b: This test fails so disable it with a leading _ for 1.1.2
release.
* The real solution is to fix the email parsing.
+ *
+ * @throws ValidatorException
*/
public void _testEmailUserName() throws ValidatorException {
ValueBean info = new ValueBean();
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [RESULT] /avail/ change needed Was: [VOTE] Leo Sutic Commit Status
OK, confirmed. Apologies to all for being pushy about this, but it is my experience that if a subject drops off the mailing list, it tends to be forgotten. /LS On Sat, 12 Jun 2004 13:49:15 -0400, Noel J. Bergman [EMAIL PROTECTED] wrote: Leo's in. Could someone with avail access add him into Commons? Done. Leo, please verify. --- Noel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29541] New: - EmailValidator allows apostrophes in domain name
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29541.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=29541
EmailValidator allows apostrophes in domain name
Summary: EmailValidator allows apostrophes in domain name
Product: Commons
Version: 1.1 Final
Platform: All
OS/Version: All
Status: NEW
Severity: Major
Priority: Other
Component: Validator
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
JavaMail rejects addresses with apostrophes in the domain name
(javax.mail.SendFailedException: 501 Syntax error in recipient address). Here
is a patch to reject all domains with apostrophes.
-micah
Index: src/share/org/apache/commons/validator/EmailValidator.java
===
RCS file:
/home/cvspublic/jakarta-commons/validator/src/share/org/apache/commons/validator/EmailValidator.java,v
retrieving revision 1.15
diff -u -r1.15 EmailValidator.java
--- src/share/org/apache/commons/validator/EmailValidator.java 8 Jun 2004
14:48:35 - 1.15
+++ src/share/org/apache/commons/validator/EmailValidator.java 12 Jun 2004
20:26:37 -
@@ -187,6 +187,10 @@
* @param domain symbolic domain name
*/
protected boolean isValidSymbolicDomain(String domain) {
+if(domain.indexOf('\'') != -1) {
+return false;
+}
+
String[] domainSegment = new String[10];
boolean match = true;
int i = 0;
Index: src/test/org/apache/commons/validator/EmailTest.java
===
RCS file:
/home/cvspublic/jakarta-commons/validator/src/test/org/apache/commons/validator/EmailTest.java,v
retrieving revision 1.27
diff -u -r1.27 EmailTest.java
--- src/test/org/apache/commons/validator/EmailTest.java12 Jun 2004 18:18:38
- 1.27
+++ src/test/org/apache/commons/validator/EmailTest.java12 Jun 2004 20:26:37
-
@@ -174,9 +174,13 @@
info.setValue([EMAIL PROTECTED]);
valueTest(info, false);
-// The ' character is valid in an email address.
+// The ' character is valid in an email username.
info.setValue(andy.o'[EMAIL PROTECTED]);
valueTest(info, true);
+
+// But not in the domain name.
+info.setValue([EMAIL PROTECTED]'reilly.data-workshop.com);
+valueTest(info, false);
info.setValue([EMAIL PROTECTED]);
valueTest(info, true);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29541] - EmailValidator allows apostrophes in domain name
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29541. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29541 EmailValidator allows apostrophes in domain name --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 20:50 --- Created an attachment (id=11836) reject apostrophes in domain names - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] mutables
First thought when looking at the code is that we could simplify things with a protected Number in MutableNumber, and move the intValue etc methods up into MutableNumber. The getValue/ setValue(Object) can go up too, and all that would be left in the mutable subclass is the primitive override and the constructor. Pro: Less code in the subclasses. Con: A protected rather than private variable. More memory is taken up with the mutable part being an Object and not a primitive. Just a thought. Hen On Thu, 10 Jun 2004, matthew.hawthorne wrote: I just made a checkin of some initial code for mutables. I haven't used CVS in a few months now (switched to subversion) so let's hope I didn't screw anything up. I have to admit that I haven't looked at this code for a good time, since around August maybe. So all are welcome to take a look and make improvements. I don't really have a solid use case for these classes anymore, so I'd imagine that others will have a better insight in that regard. The test coverage is pretty good, I think in the 70% range. I remember learning some weird things about the way Java handles primitive number conversions, as I was trying to get the tests to pass. If something looks bizarre give a yell and I'll investigate. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@brutus]: jakarta-commons-sandbox/commons-resources failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project commons-resources has an issue affecting its community integration, and has been outstanding for 5 runs. Project State : 'Failed', Reason 'Build Failed' Full details are available at: http://brutus.apache.org:8080/gump/jakarta-commons-sandbox/commons-resources/index.html That said, some snippets follow: The following annotations were provided: -DEBUG- Sole jar [commons-resources-20040612.jar] identifier set to project name -INFO- Enable verbose output, due to 4 previous error(s). -INFO- Failed with reason build failed -INFO- Enable debug output, due to build failure. The following work was performed: http://brutus.apache.org:8080/gump/jakarta-commons-sandbox/commons-resources/gump_work/build_jakarta-commons-sandbox_commons-resources.html Work Name: build_jakarta-commons-sandbox_commons-resources (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 2 seconds Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -verbose -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-resources-20040612 dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources] CLASSPATH : /usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/target/classes:/usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar- [javac] import net.sf.hibernate.cfg.Configuration; [javac] ^ [javac] /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/HibernateResources.java:114: cannot resolve symbol [javac] symbol : class Session [javac] location: class org.apache.commons.resources.impl.HibernateResources [javac] Session session = null; [javac] ^ [javac] /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/HibernateResources.java:117: cannot resolve symbol [javac] symbol : class SessionFactory [javac] location: class org.apache.commons.resources.impl.HibernateResources [javac] SessionFactory sessionFactory = [javac] ^ [javac] /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/HibernateResources.java:118: cannot resolve symbol [javac] symbol : class Configuration [javac] location: class org.apache.commons.resources.impl.HibernateResources [javac] new Configuration().configure().buildSessionFactory(); [javac] ^ [javac] /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/HibernateResources.java:120: cannot resolve symbol [javac] symbol : class Query [javac] location: class org.apache.commons.resources.impl.HibernateResources [javac] Query q = session.getNamedQuery(QueryByLocale); [javac] ^ [javac] /usr/local/gump/public/workspace/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/HibernateResources.java:130: cannot resolve symbol [javac] symbol : class HibernateException [javac] location
[GUMP@brutus]: jelly-tags/commons-jelly-tags-jetty failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project commons-jelly-tags-jetty has an issue affecting its community integration, and has been outstanding for 6 runs. Project State : 'Failed', Reason 'Build Failed' Full details are available at: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-jetty/index.html That said, some snippets follow: The following annotations were provided: -DEBUG- Sole jar [commons-jelly-tags-jetty-20040612.jar] identifier set to project name -INFO- Enable verbose output, due to 5 previous error(s). -INFO- Failed with reason build failed -INFO- Enable debug output, due to build failure. The following work was performed: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-jetty/gump_work/build_jelly-tags_commons-jelly-tags-jetty.html Work Name: build_jelly-tags_commons-jelly-tags-jetty (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 2 seconds Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -verbose -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-jetty-20040612 jar [Working Directory: /usr/local/gump/public/workspace/jelly-tags/jetty] CLASSPATH : /usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jelly-tags/jetty/target/classes:/usr/local/gump/public/workspace/jelly-tags/jetty/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons/jelly/target/commons-jelly-20040612.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/packages/dom4j-1.4/dom4j-full.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtmlXni.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtml.jar:/usr/local/gump/public/workspace/jakarta-commons/httpclient/dist/commons-httpclient.jar:/usr/local/gump/public/workspace/jetty/lib/org.mortbay.jetty.jar:/usr/local/gump/public/workspace/jelly-tags/http/target/commons-jelly-tags-http-20040612.jar- [javac] _logSink = new OutputStreamLogSink(DEFAULT_LOG_FILE); [javac]^ [javac] /usr/local/gump/public/workspace/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/JettyHttpServerTag.java:75: cannot resolve symbol [javac] symbol : variable Log [javac] location: class org.apache.commons.jelly.tags.jetty.JettyHttpServerTag [javac] Log.instance().add(_logSink); [javac] ^ [javac] /usr/local/gump/public/workspace/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:191: cannot resolve symbol [javac] symbol : variable Code [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Code.warning(Unknown user-data-constraint:+guarantee); [javac] ^ [javac] /usr/local/gump/public/workspace/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:236: cannot resolve symbol [javac] symbol : class Authenticator [javac] location: class org.apache.commons.jelly.tags.jetty.SecurityHandlerTag [javac] Authenticator authenticator=null; [javac] ^ [javac] /usr/local/gump/public/workspace/jelly-tags/jetty/src/java/org/apache/commons/jelly/tags/jetty/SecurityHandlerTag.java:248: cannot resolve symbol [javac] symbol : variable Code [javac] location: class
[GUMP@brutus]: jelly-tags/commons-jelly-tags-jsl failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project commons-jelly-tags-jsl has an issue affecting its community integration, and has been outstanding for 6 runs. Project State : 'Failed', Reason 'Build Failed' Full details are available at: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-jsl/index.html That said, some snippets follow: The following annotations were provided: -DEBUG- Sole jar [commons-jelly-tags-jsl-20040612.jar] identifier set to project name -INFO- Enable verbose output, due to 5 previous error(s). -INFO- Failed with reason build failed -INFO- Enable debug output, due to build failure. The following work was performed: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-jsl/gump_work/build_jelly-tags_commons-jelly-tags-jsl.html Work Name: build_jelly-tags_commons-jelly-tags-jsl (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 6 seconds Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -verbose -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-jsl-20040612 jar [Working Directory: /usr/local/gump/public/workspace/jelly-tags/jsl] CLASSPATH : /usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jelly-tags/jsl/target/classes:/usr/local/gump/public/workspace/jelly-tags/jsl/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons/jelly/target/commons-jelly-20040612.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/packages/dom4j-1.4/dom4j-full.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtmlXni.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtml.jar:/usr/local/gump/public/workspace/jelly-tags/xml/target/commons-jelly-tags-xml-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/junit/target/commons-jelly-tags-junit-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/ant/target/commons-jelly-tags-ant-20040612.jar:/usr/local/gump/public/workspace/commons-grant/target/commons-grant-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/log/target/commons-jelly-tags-log-20040612.jar- [junit] at org.apache.commons.jelly.impl.StaticTag.doTag(StaticTag.java:65) [junit] at org.apache.commons.jelly.impl.StaticTagScript.run(StaticTagScript.java:102) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.tags.jsl.TemplateTag$1.run(TemplateTag.java:160) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:51) [junit] at org.dom4j.rule.Mode.applyTemplates(Mode.java:71) [junit] at org.dom4j.rule.RuleManager$1.run(RuleManager.java:148) [junit] at org.dom4j.rule.Mode.fireRule(Mode.java:51) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:73) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:65) [junit] at org.dom4j.rule.Stylesheet.run(Stylesheet.java:57) [junit] at org.apache.commons.jelly.tags.jsl.StylesheetTag.doTag(StylesheetTag.java:124) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit
[GUMP@brutus]: jelly-tags/commons-jelly-tags-define failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact folk at [EMAIL PROTECTED] Project commons-jelly-tags-define has an issue affecting its community integration, and has been outstanding for 6 runs. Project State : 'Failed', Reason 'Build Failed' Full details are available at: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-define/index.html That said, some snippets follow: The following annotations were provided: -DEBUG- Sole jar [commons-jelly-tags-define-20040612.jar] identifier set to project name -INFO- Enable verbose output, due to 5 previous error(s). -INFO- Failed with reason build failed -INFO- Enable debug output, due to build failure. The following work was performed: http://brutus.apache.org:8080/gump/jelly-tags/commons-jelly-tags-define/gump_work/build_jelly-tags_commons-jelly-tags-define.html Work Name: build_jelly-tags_commons-jelly-tags-define (Type: Build) State: Failed Elapsed: 0 hours, 0 minutes, 5 seconds Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -verbose -Dgump.merge=/usr/local/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-define-20040612 jar [Working Directory: /usr/local/gump/public/workspace/jelly-tags/define] CLASSPATH : /usr/local/j2sdk1.4.2_04/lib/tools.jar:/usr/local/gump/public/workspace/jelly-tags/define/target/classes:/usr/local/gump/public/workspace/jelly-tags/define/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons/jelly/target/commons-jelly-20040612.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/packages/dom4j-1.4/dom4j-full.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-20040612.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtmlXni.jar:/usr/local/gump/packages/nekohtml-0.9.2/nekohtml.jar:/usr/local/gump/public/workspace/jelly-tags/dynabean/target/commons-jelly-tags-dynabean-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/junit/target/commons-jelly-tags-junit-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/log/target/commons-jelly-tags-log-20040612.jar:/usr/local/gump/public/workspace/jelly-tags/xml/target/commons-jelly-tags-xml-20040612.jar- [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.TagSupport.invokeBody(TagSupport.java:186) [junit] at org.apache.commons.jelly.TagSupport.getBodyText(TagSupport.java:236) [junit] at org.apache.commons.jelly.tags.core.SetTag.doTag(SetTag.java:90) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit] at org.apache.commons.jelly.tags.junit.CaseTag$1.runTest(CaseTag.java:59) [junit] Caused by: java.lang.NullPointerException [junit] at org.apache.commons.jelly.tags.define.SuperTag.doTag(SuperTag.java:44) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] ... 20 more [junit] Root cause [junit] java.lang.NullPointerException [junit] at org.apache.commons.jelly.tags.define.SuperTag.doTag(SuperTag.java:44) [junit] at org.apache.commons.jelly.impl.TagScript.run(TagScript.java:233) [junit] at org.apache.commons.jelly.impl.ScriptBlock.run(ScriptBlock.java:89) [junit
cvs commit: jakarta-commons/httpclient release_notes.txt
olegk 2004/06/12 16:00:40 Modified:httpclient release_notes.txt Log: Release notes updated to include PR #29439 Revision ChangesPath 1.27 +3 -0 jakarta-commons/httpclient/release_notes.txt Index: release_notes.txt === RCS file: /home/cvs/jakarta-commons/httpclient/release_notes.txt,v retrieving revision 1.26 retrieving revision 1.27 diff -u -r1.26 -r1.27 --- release_notes.txt 11 Jun 2004 19:18:54 - 1.26 +++ release_notes.txt 12 Jun 2004 23:00:40 - 1.27 @@ -2,6 +2,9 @@ --- Changes since Alpha 1: + * 29439 - Cleaner interface to define authentication scope, handle credentials in HttpState. + Contributed by Oleg Kalnichevski olegk at apache.org + * 29377 - Cookies with names containing blanks or starting with $ rejected by RFC2109 spec only. Contributed by Oleg Kalnichevski olegk at apache.org - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl Expression.java ExpressionImpl.java JexlContext.java JexlHelper.java JexlExprResolver.java
tobrien 2004/06/12 16:53:17
Modified:jexl/src/java/org/apache/commons/jexl Expression.java
ExpressionImpl.java JexlContext.java
JexlHelper.java JexlExprResolver.java
Log:
Updating JavaDoc in the commons.jexl package. We need much more
clarification about pre and post resolvers.
Revision ChangesPath
1.5 +13 -5
jakarta-commons/jexl/src/java/org/apache/commons/jexl/Expression.java
Index: Expression.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/Expression.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- Expression.java 28 Feb 2004 13:45:20 - 1.4
+++ Expression.java 12 Jun 2004 23:53:17 - 1.5
@@ -18,20 +18,28 @@
/**
- * Inferface for expression object.
+ * Represents a single JEXL expression. This simple interface
+ * provides access to the underlying expression through getExpression(),
+ * and it provides hooks to add a pre- and post- expression resolver.
*
- * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
- * @version $Id$
+ * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
+ * @version $Id$
*/
public interface Expression
{
/**
- * Evaluates the expression, returning the return value;
+ * Evaluates the expression with the variables contained in the
+ * supplied [EMAIL PROTECTED] JexlContext}.
+ *
+ * @param context A JexlContext containing variables.
+ * @return The result of this evaluation
*/
public Object evaluate(JexlContext context) throws Exception;
/**
- * returns the expression used
+ * Returns the JEXL expression this Expression was created with.
+ *
+ * @return The JEXL expression to be evaluated
*/
public String getExpression();
1.7 +3 -1
jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionImpl.java
Index: ExpressionImpl.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionImpl.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- ExpressionImpl.java 28 Feb 2004 13:45:20 - 1.6
+++ ExpressionImpl.java 12 Jun 2004 23:53:17 - 1.7
@@ -58,6 +58,8 @@
/**
* evaluate the expression and return the value
*
+ * @todo Under what conditions will pre and post resolvers be called
+ *
* @param context Context containing objects/data used for evaluation
* @return value of expression
*/
1.4 +18 -3
jakarta-commons/jexl/src/java/org/apache/commons/jexl/JexlContext.java
Index: JexlContext.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/JexlContext.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- JexlContext.java 28 Feb 2004 13:45:20 - 1.3
+++ JexlContext.java 12 Jun 2004 23:53:17 - 1.4
@@ -18,14 +18,29 @@
import java.util.Map;
/**
- * Right now, just steal the j.u.Map interface as the JexlContext interface
- * this might be a pain going forward - we might want to do something simpler
+ * Holds a Map of variables which are referenced in a JEXL expression.
*
* @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
* @version $Id$
*/
public interface JexlContext
{
+ /**
+ * Replaces variables in a JexlContext with the variables contained
+ * in the supplied Map. When setVars() is called on a JexlContext,
+ * it clears the current Map and puts each entry of the
+ * supplied Map into the current variable Map.
+ *
+ * @param vars Contents of vars will be replaced with the content of this Map
+ */
public void setVars(Map vars);
+
+/**
+ * Retrives the Map of variables associated with this JexlContext. The
+ * keys of this map correspond to variable names referenced in a
+ * JEXL expression.
+ *
+ * @return A reference to the variable Map associated with this JexlContext.
+ */
public Map getVars();
}
1.4 +19 -12
jakarta-commons/jexl/src/java/org/apache/commons/jexl/JexlHelper.java
Index: JexlHelper.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/JexlHelper.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- JexlHelper.java 28 Feb 2004 13:45:20 - 1.3
+++ JexlHelper.java 12
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl/util LogAdapter.java
tobrien 2004/06/12 18:38:03 Removed: jexl/src/java/org/apache/commons/jexl/util LogAdapter.java Log: Removed the LogAdapter class, it was not referenced in commons-jexl - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl/junit package.html Asserter.java
tobrien 2004/06/12 18:39:47
Modified:jexl/src/java/org/apache/commons/jexl/junit Asserter.java
Added: jexl/src/java/org/apache/commons/jexl/junit package.html
Log:
Fixed typo in Asserter and added a package.html to the jexl.junit package
Revision ChangesPath
1.4 +3 -4
jakarta-commons/jexl/src/java/org/apache/commons/jexl/junit/Asserter.java
Index: Asserter.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/junit/Asserter.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Asserter.java 28 Feb 2004 13:45:20 - 1.3
+++ Asserter.java 13 Jun 2004 01:39:47 - 1.4
@@ -39,11 +39,10 @@
private Map variables = new HashMap();
private JexlContext context = JexlHelper.createContext();
-public Asserter() {
-}
+public Asserter() {}
/**
- * This consstructor will register the given variableValue as the
+ * This constructor will register the given variableValue as the
* this variable.
*
* @param variableValue
1.1
jakarta-commons/jexl/src/java/org/apache/commons/jexl/junit/package.html
Index: package.html
===
html
head
titlePackage Documentation for org.apache.commons.jexl.junit Package/title
/head
body bgcolor=white
Using JEXL expressions in JUnit assertions
brbr
p
ul
lia href=#introIntroduction/a/li
/ul
/p
h2a name=introIntroduction/a/h2
p
This package only contains one class, Asserter, which
allows you to use a JEXL expression in a JUnit assertion.
The following example demonstrates the use of the Asserter
class. An instance is created, and the internal JexlContext
is populated via calls to setVariable(). Calls to
assertExpression() succeed if the expression evaluates to
the value of the second parameter, otherwise an
AssertionFailedException is thrown.
/p
pre
Asserter asserter = new Asserter();
asserter.setVariable(foo, new Foo());
asserter.setVariable(person, James);
asserter.assertExpression(person, James);
asserter.assertExpression(size(person), new Integer(5));
asserter.assertExpression(foo.getCount(), new Integer(5));
asserter.assertExpression(foo.count, new Integer(5));
/pre
/body
/html
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl/context package.html
tobrien 2004/06/12 18:40:18 Added: jexl/src/java/org/apache/commons/jexl/parser package.html jexl/src/java/org/apache/commons/jexl package.html jexl/src/java/org/apache/commons/jexl/context package.html Log: Added package.html to the jexl, jexl.context, and jexl.parser packages Revision ChangesPath 1.1 jakarta-commons/jexl/src/java/org/apache/commons/jexl/parser/package.html Index: package.html === html head titlePackage Documentation for org.apache.commons.jexl.parser Package/title /head body bgcolor=white Contains the Parser for JEXL script. brbr p ul lia href=#introIntroduction/a/li /ul /p h2a name=introIntroduction/a/h2 p This package contains the Parser for JEXL script. /p /body /html 1.1 jakarta-commons/jexl/src/java/org/apache/commons/jexl/package.html Index: package.html === html head titlePackage Documentation for org.apache.commons.jexl Package/title /head body bgcolor=white Provides a framework for evaluating JEXL expressions. brbr p ul lia href=#introIntroduction/a/li lia href=#exampleBrief Example/a/li /ul /p h2a name=introIntroduction/a/h2 p Java Expression Language (JEXL) is an expression language engine which can be embedded in applications and frameworks. JEXL is inspired by Jakarta Velocity and the Expression Language defined in the JavaServer Pages Standard Tag Library version 1.1 (JSTL) and JavaServer Pages version 2.0 (JSP). /p p JEXL attempts to bring some of the lessons learned by the Velocity community about expression languages in templating to a wider audience. a href=http://jakarta.apache.org/commons/jelly;Commons Jelly needed/a Velocity-ish method access, it just had to have it. /p p It must be noted that JEXL is not a compatibile implementation of EL as defined in JSTL 1.1 (JSR-052) or JSP 2.0 (JSR-152). For a compatible implementation of these specifications, see the a href=http://jakarta.apache.org/commons/el; Commons EL/a project. /p h2a name=exampleA Brief Example/a/h2 p When evaluating expressions, JEXL merges an a href=http://jakarta.apache.org/commons/jexl/apidocs/org/apache/commons/jexl/Expression.html;Expression/a with a a href=http://jakarta.apache.org/commons/jexl/apidocs/org/apache/commons/jexl/JexlContext.html;JexlContext/a. An Expression is created using a href=http://jakarta.apache.org/commons/jexl/apidocs/org/apache/commons/jexl/ExpressionFactory.html#createExpression(java.lang.String)ExpressionFactory.createExpression()/a, passing a String containing valid JEXL syntax. A JexlContext is created using a href=http://jakarta.apache.org/commons/jexl/apidocs/org/apache/commons/jexl/JexlHelper.html#createContext()JexlHelper.createContext()/a, and variables are put into a map exposed through the a href=http://jakarta.apache.org/commons/jexl/apidocs/org/apache/commons/jexl/JexlContext.html#getVars()getVars()/a method on JexlContext. The following example, takes a variable named foo, and invokes the bar() method on the property innerFoo: /p pre // Create an expression object String jexlExp = foo.innerFoo.bar(); Expression e = ExpressionFactory.createExpression( jexlExp ); // Create a context and add data JexlContext jc = JexlHelper.createContext(); jc.getVars().put(foo, new Foo() ); // Now evaluate the expression, getting the result Object o = e.evaluate(jc);/pre /pre /body /html 1.1 jakarta-commons/jexl/src/java/org/apache/commons/jexl/context/package.html Index: package.html === html head titlePackage Documentation for org.apache.commons.jexl.context Package/title /head body bgcolor=white Simple JexlContext implementations. brbr p ul lia href=#introIntroduction/a/li /ul /p h2a name=introIntroduction/a/h2 p This package only contains one JexlContext implementation, the HashMapContext. A HashMapContext is simply an extension of HashMap which implements the JexlContext interface. /p /body /html - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl ExpressionFactory.java
tobrien 2004/06/12 18:41:49
Modified:jexl/src/java/org/apache/commons/jexl ExpressionFactory.java
Log:
General refactor of ExpressionFactory. Instead of two separate checks for reference
and expression
node, there is a single check. Comments have been cleaned up.
Revision ChangesPath
1.5 +83 -46
jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionFactory.java
Index: ExpressionFactory.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionFactory.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ExpressionFactory.java28 Feb 2004 13:45:20 - 1.4
+++ ExpressionFactory.java13 Jun 2004 01:41:49 - 1.5
@@ -21,94 +21,131 @@
import org.apache.commons.jexl.parser.ASTReferenceExpression;
import org.apache.commons.jexl.parser.Parser;
import org.apache.commons.jexl.parser.SimpleNode;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
/**
- * Used to create Expression objects
- * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
- * @version $Id$
+ * p
+ * Creates Expression objects. To create a JEXL Expression object, pass
+ * valid JEXL syntax to the static createExpression() method:
+ * /p
+ *
+ * pre
+ * String jexl = array[1];
+ * Expression expression = ExpressionFactory.createExpression( jexl );
+ * /pre
+ *
+ * p
+ * When an [EMAIL PROTECTED] Expression} object is created, the JEXL syntax is
+ * parsed and verified. If the supplied expression is neither an
+ * expression not a reference, an exception is thrown from createException().
+ * /p
+ * @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
+ * @version $Id$
*/
public class ExpressionFactory
{
/**
- * our parser - we share it
+ * The Log to which all ExpressionFactory messages will be logged.
*/
-protected static Parser parser = new Parser(new StringReader(;));
+protected static Log log =
+LogFactory.getLog(org.apache.commons.jexl.ExpressionFactory);
/**
- * We Be Singleton
+ * The singleton ExpressionFactory also holds a single instance of [EMAIL
PROTECTED] Parser}.
+ * When parsing expressions, ExpressionFactory synchronizes on Parser.
+ */
+protected static Parser parser = new Parser(new StringReader(;));
//$NON-NLS-1$
+
+/**
+ * ExpressionFactory is a single and this is the private
+ * status instance fufilling that pattern.
*/
protected static ExpressionFactory ef = new ExpressionFactory();
-private ExpressionFactory()
+/**
+ * Private constructor, the single instance is always obtained
+ * with a call to getInstance().
+ */
+private ExpressionFactory(){}
+
+/**
+ * Returns the single instance of ExpressionFactory.
+ * @return the instance of ExpressionFactory.
+ */
+protected static ExpressionFactory getInstance()
{
+return ef;
}
+/**
+ * Creates an Expression from a String containing valid
+ * JEXL syntax. This method parses the expression which
+ * must contain either a reference or an expression.
+ * @param expression A String containing valid JEXL syntax
+ * @return An Expression object which can be evaluated with a JexlContext
+ * @throws Exception An exception can be thrown if there is a problem parsing
+ * his expression, or if the expression is neither an
+ * expression or a reference.
+ */
public static Expression createExpression(String expression)
throws Exception
{
return getInstance().createNewExpression(expression);
}
-protected static ExpressionFactory getInstance()
-{
-return ef;
-}
/**
* Creates a new Expression based on the expression string.
*
- * @param expresison valid Jexl expression
+ * @param expression valid Jexl expression
* @return Expression
* @throws Exception for a variety of reasons - mostly malformed
* Jexl expression
*/
protected Expression createNewExpression(String expression)
-throws Exception
-{
-String expr = expression.trim();
+throws Exception {
+
+ String expr = cleanExpression(expression);
-/*
- * make sure a valid statement
- */
-if (!expr.endsWith(;))
-{
-expr = expr + ;;
-}
-
-/*
- * now parse - we want to protect the parser for now
- */
+// Parse the Expression
SimpleNode tree;
-
cvs commit: jakarta-commons/jexl/src/java/org/apache/commons/jexl Expression.java ExpressionImpl.java
tobrien 2004/06/12 18:42:21
Modified:jexl/src/java/org/apache/commons/jexl Expression.java
ExpressionImpl.java
Log:
Cleaning Javadoc in Expression and ExpressionImpl
Revision ChangesPath
1.6 +9 -2
jakarta-commons/jexl/src/java/org/apache/commons/jexl/Expression.java
Index: Expression.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/Expression.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- Expression.java 12 Jun 2004 23:53:17 - 1.5
+++ Expression.java 13 Jun 2004 01:42:21 - 1.6
@@ -18,10 +18,17 @@
/**
+ * p
* Represents a single JEXL expression. This simple interface
* provides access to the underlying expression through getExpression(),
- * and it provides hooks to add a pre- and post- expression resolver.
+ * and it provides hooks to add a pre- and post- expression resolver.
+ * /p
*
+ * p
+ * An expression is different than a script - it is simply a reference of
+ * an expression.
+ * /p
+ *
* @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
* @version $Id$
*/
1.8 +5 -6
jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionImpl.java
Index: ExpressionImpl.java
===
RCS file:
/home/cvs/jakarta-commons/jexl/src/java/org/apache/commons/jexl/ExpressionImpl.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- ExpressionImpl.java 12 Jun 2004 23:53:17 - 1.7
+++ ExpressionImpl.java 13 Jun 2004 01:42:21 - 1.8
@@ -22,17 +22,16 @@
import org.apache.commons.jexl.parser.SimpleNode;
/**
- * Implelmentation of an Expression. Created by the ExpressionFactory.
- *
- * The expression is different than a script - it's really just either
- * a reference or expression that we can get the value of.
+ * Instances of ExpressionImpl are created by the [EMAIL PROTECTED]
ExpressionFactory},
+ * and this is the default implementation of the [EMAIL PROTECTED] Expression}
interface.
*
* @author a href=mailto:[EMAIL PROTECTED]Geir Magnusson Jr./a
* @version $Id$
*/
class ExpressionImpl implements Expression
{
-List preResolvers;
+
+ List preResolvers;
List postResolvers;
/**
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [lang] mutables
Henri Yandell wrote: First thought when looking at the code is that we could simplify things with a protected Number in MutableNumber, and move the intValue etc methods up into MutableNumber. The getValue/ setValue(Object) can go up too, and all that would be left in the mutable subclass is the primitive override and the constructor. Pro: Less code in the subclasses. Con: A protected rather than private variable. More memory is taken up with the mutable part being an Object and not a primitive. Just a thought. I think the pro of simpler code may be bigger than the con of memory loss. Those involved in hardcore performance tweaking may disagree. For me, the mutable classes were more about the added functionality than the savings in memory, so I'm in agreement with you here. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/io/src/java/org/apache/commons/io FilenameUtils.java
bayard 2004/06/12 22:17:11
Modified:io/src/java/org/apache/commons/io FilenameUtils.java
Log:
removed deprecated methods that are not intended to ever be released
Revision ChangesPath
1.11 +2 -141
jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java
Index: FilenameUtils.java
===
RCS file:
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/FilenameUtils.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- FilenameUtils.java13 Jun 2004 05:13:57 - 1.10
+++ FilenameUtils.java13 Jun 2004 05:17:11 - 1.11
@@ -414,22 +414,7 @@
}
-
-//
-// Deprecated methods
-//
-
-/**
- * Returns the filename portion of a file specification string.
- * Matches the equally named unix command.
- * @param filename filename to inspect
- * @return The filename string without extension.
- * @deprecated This method will be deleted before a 1.0 release
- * TODO DELETE before 1.0
- */
-public static String basename(String filename) {
-return basename(filename, extension(filename));
-}
+// DEPRECATED. Though no replacement exists.
/**
* Returns the filename portion of a file specification string.
@@ -454,130 +439,6 @@
} else {
return filename; // else returns all (no path and no extension)
}
-}
-
-/**
- * Delete a file. If file is directory delete it and all sub-directories.
- * @param file file or directory to delete.
- * @throws IOException in case deletion is unsuccessful
- * @deprecated Use [EMAIL PROTECTED] FileUtils#forceDelete(File)}
- */
-public static void forceDelete( String file) throws IOException {
-FileUtils.forceDelete(new File(file));
-}
-
-
-
-/**
- * Clean a directory without deleting it.
- * @param directory directory to clean
- * @throws IOException in case cleaning is unsuccessful
- * @deprecated Use [EMAIL PROTECTED] FileUtils#cleanDirectory(File)}
- */
-public static void cleanDirectory( String directory)
-throws IOException {
-FileUtils.cleanDirectory(new File(directory));
-}
-
-/**
- * Recursively count size of a directory (sum of the length of all files).
- *
- * @param directory directory to inspect
- * @return size of directory in bytes.
- * @deprecated Use [EMAIL PROTECTED] FileUtils#sizeOfDirectory(File)}
- */
-public static long sizeOfDirectory( String directory) {
-return FileUtils.sizeOfDirectory(new File(directory));
-}
-
-/**
- * Copy file from source to destination. If codedestinationDirectory/code
does not exist, it
- * (and any parent directories) will be created. If a file codesource/code
in
- * codedestinationDirectory/code exists, it will be overwritten.
- *
- * @param source An existing codeFile/code to copy.
- * @param destinationDirectory A directory to copy codesource/code into.
- *
- * @throws FileNotFoundException if codesource/code isn't a normal file.
- * @throws IllegalArgumentException if codedestinationDirectory/code isn't
a directory.
- * @throws IOException if codesource/code does not exist, the file in
- * codedestinationDirectory/code cannot be written to, or an IO error
occurs during copying.
- *
- * @deprecated Use [EMAIL PROTECTED] FileUtils#copyFileToDirectory(File, File)}
- */
-public static void copyFileToDirectory(
-String source,
-String destinationDirectory)
-throws IOException, FileNotFoundException {
-FileUtils.copyFileToDirectory(new File(source), new
File(destinationDirectory));
-}
-
-/**
- * Recursively delete a directory.
- * @param directory directory to delete
- * @throws IOException in case deletion is unsuccessful
- * @deprecated Use [EMAIL PROTECTED] FileUtils#deleteDirectory(File)}
- */
-public static void deleteDirectory( String directory)
-throws IOException {
-FileUtils.deleteDirectory(new File(directory));
-}
-
-/**
- * Returns the directory path portion of a file specification string.
- * Matches the equally named unix command.
- * @param filename filename to inspect
- * @return The directory portion excluding the ending file separator.
- * @deprecated Use [EMAIL PROTECTED] FileUtils#getPath(File)}
- * TODO DELETE before 1.0
- */
-public static String dirname(String filename) {
-
cvs commit: jakarta-commons/io/src/test/org/apache/commons/io/output CountingOutputStreamTest.java
bayard 2004/06/12 22:35:44
Modified:io/src/java/org/apache/commons/io/input
CountingInputStream.java
io/src/java/org/apache/commons/io/output
CountingOutputStream.java
io/src/test/org/apache/commons/io/input
CountingInputStreamTest.java
io/src/test/org/apache/commons/io/output
CountingOutputStreamTest.java
Log:
reset feature added to counting classes as requested by Lars Beuster
Revision ChangesPath
1.9 +12 -1
jakarta-commons/io/src/java/org/apache/commons/io/input/CountingInputStream.java
Index: CountingInputStream.java
===
RCS file:
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/input/CountingInputStream.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -r1.8 -r1.9
--- CountingInputStream.java 23 Feb 2004 04:38:52 - 1.8
+++ CountingInputStream.java 13 Jun 2004 05:35:44 - 1.9
@@ -78,4 +78,15 @@
return this.count;
}
+/**
+ * Set the count back to 0.
+ *
+ * @return the count previous to resetting.
+ */
+public synchronized int resetCount() {
+int tmp = this.count;
+this.count = 0;
+return tmp;
+}
+
}
1.6 +11 -1
jakarta-commons/io/src/java/org/apache/commons/io/output/CountingOutputStream.java
Index: CountingOutputStream.java
===
RCS file:
/home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/output/CountingOutputStream.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- CountingOutputStream.java 23 Feb 2004 04:40:29 - 1.5
+++ CountingOutputStream.java 13 Jun 2004 05:35:44 - 1.6
@@ -63,4 +63,14 @@
return this.count;
}
+/**
+ * Set the count back to 0.
+ *
+ * @return the count previous to resetting.
+ */
+public synchronized int resetCount() {
+int tmp = this.count;
+this.count = 0;
+return tmp;
+}
}
1.5 +16 -0
jakarta-commons/io/src/test/org/apache/commons/io/input/CountingInputStreamTest.java
Index: CountingInputStreamTest.java
===
RCS file:
/home/cvs/jakarta-commons/io/src/test/org/apache/commons/io/input/CountingInputStreamTest.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- CountingInputStreamTest.java 23 Feb 2004 05:02:25 - 1.4
+++ CountingInputStreamTest.java 13 Jun 2004 05:35:44 - 1.5
@@ -62,5 +62,21 @@
String textResult = new String(result).trim();
assertEquals(textResult, text);
}
+
+public void testResetting() throws Exception {
+String text = A piece of text;
+byte[] bytes = text.getBytes();
+ByteArrayInputStream bais = new ByteArrayInputStream(bytes);
+CountingInputStream cis = new CountingInputStream(bais);
+
+byte[] result = new byte[bytes.length];
+
+int found = cis.read(result, 0, 5);
+assertEquals( found, cis.getCount() );
+
+int count = cis.resetCount();
+found = cis.read(result, 6, 5);
+assertEquals( found, cis.getCount() );
+}
}
1.3 +12 -6
jakarta-commons/io/src/test/org/apache/commons/io/output/CountingOutputStreamTest.java
Index: CountingOutputStreamTest.java
===
RCS file:
/home/cvs/jakarta-commons/io/src/test/org/apache/commons/io/output/CountingOutputStreamTest.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- CountingOutputStreamTest.java 23 Feb 2004 05:02:25 - 1.2
+++ CountingOutputStreamTest.java 13 Jun 2004 05:35:44 - 1.3
@@ -59,15 +59,21 @@
cos.write(array, 5, 5);
assertByteArrayEquals(CountingOutputStream.write(byte[], int, int),
baos.toByteArray(), 0, 35);
assertEquals(CountingOutputStream.getCount(), cos.getCount(), 35);
+
+int count = cos.resetCount();
+assertEquals(CountingOutputStream.resetCount(), count, 35);
+
+for(int i = 0; i 10; i++) {
+cos.write(i);
+}
+assertByteArrayEquals(CountingOutputStream.write(int),
baos.toByteArray(), 35, 45);
+assertEquals(CountingOutputStream.getCount(), cos.getCount(), 10);
+
}
private void assertByteArrayEquals(String msg, byte[] array, int start, int
end) {
-assertEquals(msg+: array size mismatch, end-start,
-array.length );
-
DO NOT REPLY [Bug 28976] - CountingOutputStream: make count protected
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=28976. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=28976 CountingOutputStream: make count protected [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-06-13 05:36 --- resetCount() method added, along with unit tests to CountingOutputStream and CountingInputStream. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/io/src/java/org/apache/commons/io IOUtils.java
bayard 2004/06/12 22:38:07 Modified:io/src/java/org/apache/commons/io IOUtils.java Log: deprecated toByteArray Revision ChangesPath 1.16 +2 -1 jakarta-commons/io/src/java/org/apache/commons/io/IOUtils.java Index: IOUtils.java === RCS file: /home/cvs/jakarta-commons/io/src/java/org/apache/commons/io/IOUtils.java,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- IOUtils.java 13 Jun 2004 04:45:25 - 1.15 +++ IOUtils.java 13 Jun 2004 05:38:07 - 1.16 @@ -240,6 +240,7 @@ * @param input the codeString/code to convert * @return the requested byte array * @throws IOException In case of an I/O problem + * @deprecated This is reundant, use java.lang.String.toByteArray. */ public static byte[] toByteArray( String input ) throws IOException - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta Commons Wiki] Updated: IO
Date: 2004-06-12T22:38:30 Editor: 12.220.74.99 Wiki: Jakarta Commons Wiki Page: IO URL: http://wiki.apache.org/jakarta-commons/IO no comment Change Log: -- @@ -12,6 +12,10 @@ * /FrequentlyAskedQuestions +== Next release todo == + + * (29140) NPE in FileUtils.listFiles(dir, extensions, recursive) + Up to FrontPage - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta Commons Wiki] Updated: IO
Date: 2004-06-12T22:39:51 Editor: 12.220.74.99 Wiki: Jakarta Commons Wiki Page: IO URL: http://wiki.apache.org/jakarta-commons/IO no comment Change Log: -- @@ -15,6 +15,8 @@ == Next release todo == * (29140) NPE in FileUtils.listFiles(dir, extensions, recursive) + * Get FilenameUtils release ready. + * Get ClassLoaderObjectInputStream release ready. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Invalid RSA modulus size
Tim, This is believed to be a limitation of all Sun's JCE/JSSE implementations up to Java version 1.5. You can try testing your application with Java 1.5-b2 to see if the problem has indeed been fixed. Alternatively consider using IBM Java 1.4 or 3rd party JCE/JSSE implementations which _may_ not exhibit the same limitation HTH Oleg On Sat, 2004-06-12 at 05:36, Tim Wild wrote: Hi, I'm using HttpClient to connect to an apache server that requires certificates. When I use client and server certificates from my own CA with 1024 bit keys it works perfectly. When I get a commercial certificate with a longer key (4096 bits), I get the following error (full message below) when I connect to apache: javax.net.ssl.SSLProtocolException: java.io.IOException: subject key, Unknown key spec: Invalid RSA modulus size. Google produced one result, which talked about a maximum key size using the JCE of 2048 bits using the JDK 1.4.2 default policy files. Another site suggested getting the unrestricted policy files, so I got and installed them, but it doesn't seem to make any difference at all. Does anyone have any thought or suggestions? Half formed thoughs or ideas are welcome as it might give me a lead that I can follow myself. Thanks Tim Wild - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29439] - Credentials ignored if realm specified in preemptive authentication
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29439. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29439 Credentials ignored if realm specified in preemptive authentication --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 17:28 --- Created an attachment (id=11834) Patch against CVS HEAD (take 1) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29439] - Credentials ignored if realm specified in preemptive authentication
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29439. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29439 Credentials ignored if realm specified in preemptive authentication --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 17:36 --- Here's my first stab at it Changelog: * HttpAuthRealm was a poor choice of a name. Renamed to AuthScope * ANY_HOST, ANY_PORT, ANY_REALM ANY_SCHEME static variables can be used instead of non-descriptive null, -1, null, null to assign and retrieve credentials * HttpState#setCredentials(String, String, Credentials) HttpState#getCredentials(String, String) HttpState#setProxyCredentials(String, String, Credentials) HttpState#getProxyCredentials(String, String) * Extra warning logs in case of preemptive authentication failure due to missing default credentials * Extra test case Let me know what you think Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29439] - Credentials ignored if realm specified in preemptive authentication
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29439. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29439 Credentials ignored if realm specified in preemptive authentication --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 19:13 --- - The various static variables in AuthScope should be final I think My oversight. Will be corrected. - HttpState.matchCredentials() doesn't handle all combinations of AuthScopes. HttpState.matchCredentials() is clearly broken as it is. Besides, it generates unnecessary garbage pretty much per every invocation. Do you mind if I submit the patch and deal with broken HttpState.matchCredentials() separately? Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29540] - HttpState#matchCredentials is broken
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29540. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29540 HttpState#matchCredentials is broken [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED Target Milestone|--- |3.0 Alpha 2 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29439] - Credentials ignored if realm specified in preemptive authentication
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29439. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29439 Credentials ignored if realm specified in preemptive authentication --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 21:13 --- Do you mind if I submit the patch and deal with broken HttpState.matchCredentials() separately? Not at all. Sounds like a plan. Mike - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 29439] - Credentials ignored if realm specified in preemptive authentication
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=29439. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29439 Credentials ignored if realm specified in preemptive authentication [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-06-12 22:49 --- Patch committed to CVS HEAD. Oleg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
