[GUMP@brutus]: Project commons-net (in module jakarta-commons) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-net has an issue affecting its community integration. This issue affects 2 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-net : Commons Net - james-server : James Server Full details are available at: http://brutus.apache.org/gump/public/jakarta-commons/commons-net/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-net-14112004.jar] identifier set to project name -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/classes] -INFO- Made directory [/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes] -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://brutus.apache.org/gump/public/jakarta-commons/commons-net/gump_work/build_jakarta-commons_commons-net.html Work Name: build_jakarta-commons_commons-net (Type: Build) Work ended in a state of : Failed Elapsed: 22 secs Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-net-14112004 dist [Working Directory: /usr/local/gump/public/workspace/jakarta-commons/net] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/net/target/classes:/usr/local/gump/public/workspace/jakarta-commons/net/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-oro/jakarta-oro-14112004.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar - [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileEntryParserImpl.java:31: warning: org.apache.commons.net.ftp.FTPFileListParser in org.apache.commons.net.ftp has been deprecated [javac] implements FTPFileEntryParser, FTPFileListParser [javac]^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileIterator.java:75: warning: org.apache.commons.net.ftp.FTPFileList in org.apache.commons.net.ftp has been deprecated [javac] FTPFileIterator (FTPFileList rawlist) [javac] ^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileIterator.java:88: warning: org.apache.commons.net.ftp.FTPFileList in org.apache.commons.net.ftp has been deprecated [javac] FTPFileIterator (FTPFileList rawlist, [javac] ^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileList.java:151: warning: org.apache.commons.net.ftp.FTPFileIterator in org.apache.commons.net.ftp has been deprecated [javac] public FTPFileIterator iterator() [javac]^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileList.java:163: warning: org.apache.commons.net.ftp.FTPFileIterator in org.apache.commons.net.ftp has been deprecated [javac] public FTPFileIterator iterator(FTPFileEntryParser parser) [javac]^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileEntryParserImpl.java:57: warning: org.apache.commons.net.ftp.FTPFileList in org.apache.commons.net.ftp has been deprecated [javac] FTPFileList ffl = FTPFileList.create(listStream, this); [javac] ^ [javac] /home/gump/workspaces2/public/workspace/jakarta-commons/net/src/java/org/apache/commons/net/ftp/FTPFileEntryParserImpl.java:57: warning: org.apache.commons.net.ftp.FTPFileList in org.apache.commons.net.ftp has been deprecated [javac]
[GUMP@brutus]: Project commons-betwixt (in module jakarta-commons) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at [EMAIL PROTECTED]
Project commons-betwixt has an issue affecting its community integration.
This issue affects 3 projects,
and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- commons-betwixt : Commons Betwixt Package
- commons-jelly-tags-betwixt : This is a Jelly interface for Betwixt.
- jakarta-turbine-stratum : Turbine Components
Full details are available at:
http://brutus.apache.org/gump/public/jakarta-commons/commons-betwixt/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Sole output [commons-betwixt-14112004.jar] identifier set to project
name
-INFO- Failed with reason build failed
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://brutus.apache.org/gump/public/jakarta-commons/commons-betwixt/gump_work/build_jakarta-commons_commons-betwixt.html
Work Name: build_jakarta-commons_commons-betwixt (Type: Build)
Work ended in a state of : Failed
Elapsed: 6 secs
Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true
-Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar
org.apache.tools.ant.Main
-Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml
-Dbuild.sysclasspath=only -Dfinal.name=commons-betwixt-14112004
-Dresourcedir=/usr/local/gump/public/workspace/jakarta-commons/betwixt jar
[Working Directory: /usr/local/gump/public/workspace/jakarta-commons/betwixt]
CLASSPATH:
/opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/classes:/usr/local/gump/public/workspace/jakarta-commons/betwixt/target/test-classes:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/digester/dist/commons-digester.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar
-
[javac] ^
[javac]
/home/gump/workspaces2/public/workspace/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanCreateRule.java:496:
warning: isWrapCollectionsInElement() in
org.apache.commons.betwixt.ElementDescriptor has been deprecated
[javac] if
(childDescriptor.isWrapCollectionsInElement()) {
[javac]^
[javac]
/home/gump/workspaces2/public/workspace/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanCreateRule.java:507:
warning: org.apache.commons.betwixt.digester.XMLIntrospectorHelper in
org.apache.commons.betwixt.digester has been deprecated
[javac] if ( XMLIntrospectorHelper.isPrimitiveType(
beanClass ) ) {
[javac] ^
[javac]
/home/gump/workspaces2/public/workspace/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanCreateRule.java:507:
warning: isPrimitiveType(java.lang.Class) in
org.apache.commons.betwixt.digester.XMLIntrospectorHelper has been deprecated
[javac] if ( XMLIntrospectorHelper.isPrimitiveType(
beanClass ) ) {
[javac] ^
[javac]
/home/gump/workspaces2/public/workspace/jakarta-commons/betwixt/src/java/org/apache/commons/betwixt/io/BeanCreateRule.java:574:
warning: body(java.lang.String) in org.apache.commons.digester.Rule has been
deprecated
[javac] public void body(String text) throws Exception {
[javac] ^
[javac] 10 warnings
[copy] Copying 12 files to
/home/gump/workspaces2/public/workspace/jakarta-commons/betwixt/target/classes
[copy] Copying 31 files to
[GUMP@brutus]: Project commons-jelly-tags-junit (in module jelly-tags) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-junit has an issue affecting its community integration. This issue affects 16 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-ant : This is a Jelly interface for Ant. - commons-jelly-tags-bean : A tag library for mapping tags to beans using a similar appr... - commons-jelly-tags-beanshell : This is a Jelly interface for BeanShell. - commons-jelly-tags-define : This is a Jelly taglib for defining new tags and tag librari... - commons-jelly-tags-dynabean : This is a Jelly taglib for defining new tags and tag librari... - commons-jelly-tags-fmt : This is a set of Jelly i18n tags. - commons-jelly-tags-html : These Jelly tags can scrub commons errors in HTML syntax. - commons-jelly-tags-jsl : The Jelly Stylesheet Library (JSL) - commons-jelly-tags-junit : The Jelly Unit Test Tags - commons-jelly-tags-log : The Jelly Logging Tags - commons-jelly-tags-sql : This is a Jelly interface for SQL - commons-jelly-tags-threads : A library for processing Jelly scripts using multiple thread... - commons-jelly-tags-util : This is a set of Jelly utility tags. - commons-jelly-tags-validate : This is a Jelly interface for XML validation. - commons-jelly-tags-xml : ??? - commons-jelly-tags-xmlunit : This is a Jelly interface for unit testing XML applications. Full details are available at: http://brutus.apache.org/gump/public/jelly-tags/commons-jelly-tags-junit/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-junit-14112004.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://brutus.apache.org/gump/public/jelly-tags/commons-jelly-tags-junit/gump_work/build_jelly-tags_commons-jelly-tags-junit.html Work Name: build_jelly-tags_commons-jelly-tags-junit (Type: Build) Work ended in a state of : Failed Elapsed: 3 secs Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-junit-14112004 jar [Working Directory: /usr/local/gump/public/workspace/jelly-tags/junit] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jelly-tags/junit/target/classes:/usr/local/gump/public/workspace/jelly-tags/junit/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons/jelly/target/commons-jelly-14112004.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/packages/dom4j-1.4/dom4j-full.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/standard.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/jstl.jar:/usr/local/gump/packages/nekohtml-0.9.3/nekohtmlXni.jar:/usr/local/gump/packages/nekohtml-0.9.3/nekohtml.jar - Buildfile:
[GUMP@brutus]: Project commons-jelly-tags-swing (in module jelly-tags) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-jelly-tags-swing has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 7 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-jelly-tags-swing : This is a Jelly interface for configuring Swing applications... Full details are available at: http://brutus.apache.org/gump/public/jelly-tags/commons-jelly-tags-swing/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-jelly-tags-swing-14112004.jar] identifier set to project name -INFO- Failed with reason build failed -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://brutus.apache.org/gump/public/jelly-tags/commons-jelly-tags-swing/gump_work/build_jelly-tags_commons-jelly-tags-swing.html Work Name: build_jelly-tags_commons-jelly-tags-swing (Type: Build) Work ended in a state of : Failed Elapsed: 4 secs Command Line: java -Djava.awt.headless=true -Dbuild.clonevm=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-xerces2/java/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dfinal.name=commons-jelly-tags-swing-14112004 jar [Working Directory: /usr/local/gump/public/workspace/jelly-tags/swing] CLASSPATH: /opt/jdk1.4/lib/tools.jar:/usr/local/gump/public/workspace/jelly-tags/swing/target/classes:/usr/local/gump/public/workspace/jelly-tags/swing/target/test-classes:/usr/local/gump/public/workspace/jakarta-commons/jelly/target/commons-jelly-14112004.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-stylebook.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/beanutils/dist/commons-beanutils-core.jar:/usr/local/gump/public/workspace/jakarta-commons/collections/build/commons-collections-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/jexl/dist/commons-jexl-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/lang/dist/commons-lang-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/dist/commons-logging-api.jar:/usr/local/gump/packages/dom4j-1.4/dom4j-full.jar:/usr/local/gump/public/workspace/dist/junit/junit.jar:/usr/local/gump/public/workspace/jakarta-commons/cli/target/commons-cli-14112004.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr154/dist/lib/servlet-api.jar:/usr/local/gump/public/workspace/jakarta-servletapi-5/jsr152/dist/lib/jsp-api.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/standard.jar:/usr/local/gump/public/workspace/jakarta-taglibs/dist/standard/lib/jstl.jar:/usr/local/gump/packages/nekohtml-0.9.3/nekohtmlXni.jar:/usr/local/gump/packages/nekohtml-0.9.3/nekohtml.jar - Buildfile: build.xml init: [mkdir] Created dir: /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/lib get-deps: compile: [mkdir] Created dir: /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/classes [javac] Compiling 35 source files to /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/classes [copy] Copying 10 files to /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/test-classes compile-tests: [javac] Compiling 5 source files to /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/test-classes internal-test: [mkdir] Created dir: /home/gump/workspaces2/public/workspace/jelly-tags/swing/target/test-reports [junit] Running org.apache.commons.jelly.swing.TestConverters BUILD FAILED /home/gump/workspaces2/public/workspace/jelly-tags/swing/build.xml:97: Invalid attribute: builtin Total time: 3 seconds - To subscribe to this information via syndicated feeds: - RSS: http://brutus.apache.org/gump/public/jelly-tags/commons-jelly-tags-swing/rss.xml - Atom:
DO NOT REPLY [Bug 32230] New: - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. Summary: [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. Product: Commons Version: unspecified Platform: Other OS/Version: Linux Status: NEW Severity: Minor Priority: Other Component: Bean Utilities AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, I was examining the source for beanutils using Eclipse. There were several warnings given, which I have fixed with the attached patches. These patches are pretty straightforeward, I think. :-) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:52 --- Created an attachment (id=13436) fixes local variable not read warning - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:53 --- Created an attachment (id=13437) fix warnings - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:54 --- Created an attachment (id=13438) fixes private never used warnings - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:55 --- Created an attachment (id=13440) fixes empty block should be commented warnings, NOTE: needs better comments - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:56 --- Created an attachment (id=13441) fixes static used improperly warnings - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:57 --- Created an attachment (id=13442) removes unused imports from beanutils/src/java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32230] - [PATCH] BeanUtils (CurrentCVS): Easy warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32230. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32230 [PATCH] BeanUtils (CurrentCVS): Easy warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 10:57 --- Created an attachment (id=13443) fixes unnecessary semicolon warnings - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32232] New: - [PATCH] BeanUtils (CurrentCVS): Larger warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32232. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32232 [PATCH] BeanUtils (CurrentCVS): Larger warning fixes. Summary: [PATCH] BeanUtils (CurrentCVS): Larger warning fixes. Product: Commons Version: unspecified Platform: Other OS/Version: Linux Status: NEW Severity: Minor Priority: Other Component: Bean Utilities AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, I was examining the source for beanutils using Eclipse. There were several warnings given, these patches are larger than the ones in bug#32230. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32232] - [PATCH] BeanUtils (CurrentCVS): Larger warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32232. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32232 [PATCH] BeanUtils (CurrentCVS): Larger warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 11:01 --- Created an attachment (id=13446) fixes unnecessary else statement warnings for beanutils/src/java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32232] - [PATCH] BeanUtils (CurrentCVS): Larger warning fixes.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32232. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32232 [PATCH] BeanUtils (CurrentCVS): Larger warning fixes. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 11:02 --- Created an attachment (id=13447) fixes unnecessary semicolon warnings for beanutils/src/test - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32233] New: - [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32233 [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?. Summary: [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?. Product: Commons Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Bean Utilities AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi, I was examining the source for beanutils using Eclipse. There were several warnings given. These patches fix the warnings, but I'm not sure if they corrupt anything. The unittests pass 100%. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32233] - [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32233 [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 11:04 --- Created an attachment (id=13448) fixes unnecessary cast warnings for beanutils/src/java - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32233] - [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32233 [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?. --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 11:05 --- Created an attachment (id=13449) fixes unnecessary cast warnings for beanutils/src/test - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32233] - [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32233. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32233 [PATCH] BeanUtils (CurrentCVS): Warning fixes, are these a good idea?. [EMAIL PROTECTED] changed: What|Removed |Added Severity|Normal |Minor OS/Version|Other |Linux --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 11:12 --- oops, setting priority to minor. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/xdocs applications.xml
olegk 2004/11/14 04:58:05 Modified:httpclient/xdocs applications.xml Log: The url for the Laszlo Presentation Server changed per Eric Bloch's request Revision ChangesPath 1.21 +8 -9 jakarta-commons/httpclient/xdocs/applications.xml Index: applications.xml === RCS file: /home/cvs/jakarta-commons/httpclient/xdocs/applications.xml,v retrieving revision 1.20 retrieving revision 1.21 diff -u -r1.20 -r1.21 --- applications.xml 30 Sep 2004 03:20:52 - 1.20 +++ applications.xml 14 Nov 2004 12:58:05 - 1.21 @@ -79,6 +79,13 @@ X-Smiles is an Open-Source XML parser, that has extensive standards support. /dd + dta href=http://www.openlaszlo.org/;Laszlo Presentation Server/a/dt +dd + The Laszlo Presentation Server is an XML-native platform for the + development and delivery of a new generation of Rich Internet + Applications. + /dd + dta href=http://www.nortelnetworks.com/;Nortel Networks/a/dt dd Operator Simulation Tool (OST) - A server side performance and scalability testing tool @@ -165,14 +172,6 @@ Delosis Psytools is a flexible platform for distributed cognitive research. Study participants perform tasks using the Psytools smart client, which relies on the HttpClient library for HTTPS communication of research tasks and resultant data. - /dd - - dta href=http://www.laszlosystems.com/lps/laszlo-in-ten-minutes/;Laszlo Presentation - Server/a/dt -dd - The Laszlo Presentation Server is an XML-native platform for the - development and delivery of a new generation of Rich Internet - Applications. /dd dta href=http://www.celcorp.com/webrecorder.html;Celware WebRecorder/a/dt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/xdocs applications.xml
olegk 2004/11/14 04:58:47 Modified:httpclient/xdocs Tag: HTTPCLIENT_2_0_BRANCH applications.xml Log: The url for the Laszlo Presentation Server changed per Eric Bloch's request Revision ChangesPath No revision No revision 1.14.2.8 +8 -9 jakarta-commons/httpclient/xdocs/applications.xml Index: applications.xml === RCS file: /home/cvs/jakarta-commons/httpclient/xdocs/applications.xml,v retrieving revision 1.14.2.7 retrieving revision 1.14.2.8 diff -u -r1.14.2.7 -r1.14.2.8 --- applications.xml 23 Oct 2004 15:59:22 - 1.14.2.7 +++ applications.xml 14 Nov 2004 12:58:47 - 1.14.2.8 @@ -79,6 +79,13 @@ X-Smiles is an Open-Source XML parser, that has extensive standards support. /dd + dta href=http://www.openlaszlo.org/;Laszlo Presentation Server/a/dt +dd + The Laszlo Presentation Server is an XML-native platform for the + development and delivery of a new generation of Rich Internet + Applications. + /dd + dta href=http://www.nortelnetworks.com/;Nortel Networks/a/dt dd Operator Simulation Tool (OST) - A server side performance and scalability testing tool @@ -165,14 +172,6 @@ Delosis Psytools is a flexible platform for distributed cognitive research. Study participants perform tasks using the Psytools smart client, which relies on the HttpClient library for HTTPS communication of research tasks and resultant data. - /dd - - dta href=http://www.laszlosystems.com/lps/laszlo-in-ten-minutes/;Laszlo Presentation - Server/a/dt -dd - The Laszlo Presentation Server is an XML-native platform for the - development and delivery of a new generation of Rich Internet - Applications. /dd dta href=http://www.celcorp.com/webrecorder.html;Celware WebRecorder/a/dt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Bug report for Commons [2004/11/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=CriticalMAJ=Major | | | | MIN=Minor NOR=Normal ENH=Enhancement | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 6508|Ass|Enh|2002-02-17|HttpClient now supports proxyHost and proxyPort - | | 6826|Ass|Enh|2002-03-04|Need to have xml files validated against DTDs as p| | 6829|Ass|Enh|2002-03-04|Allow easier way of user specified tests | | 7069|Ass|Enh|2002-03-13|DTD and DOM Validators| | 7135|Opn|Enh|2002-03-14|[beanutils] Misleading error message when beaninfo| | 7226|Opn|Enh|2002-03-19|Nested Bean Collection| | 7367|New|Nor|2002-03-22|[unspecified] ServiceManager not actually serializ| | 7465|New|Nor|2002-03-25|Need better 'dist' build | | 7981|Ver|Nor|2002-04-11|[codec][PATCH] add 2 new methods for encoding stri| |10319|New|Enh|2002-06-28|Instantiate property if null in form bean | |12807|New|Nor|2002-09-19|[PATCH] x 2 Update build.xml to use commons-loggin| |13390|New|Nor|2002-10-07|ResponseHeaderHandler and ResponseHeaderValidator | |13426|New|Enh|2002-10-08|[PATCH] xml-reference.xml responseHeader addition | |13743|Opn|Enh|2002-10-17|Need getPropertyType(Class theClass, String propNa| |14394|Ver|Nor|2002-11-08|Excessive exceptions log under security manager | |14471|Opn|Enh|2002-11-12|validator-rules.xml JavaScript fails when field no| |14667|Ver|Maj|2002-11-19|PropertyUtils.copyProperties does not copy to Dyna| |15451|Opn|Enh|2002-12-17|Multiple mapped properties not possible / Direct m| |15519|Ver|Maj|2002-12-19|PropertyUtils.getPropertyType() for java.util.Coll| |15744|New|Nor|2002-12-31|[unspecified] Scaffold ResultSet used after statem| |15895|Unc|Nor|2003-01-08|In BeanMap all properties are writable (some with | |16038|Opn|Enh|2003-01-13|[beanutils] LocaleBeanUtils.copyProperties() does | |16132|New|Maj|2003-01-15|[Jelly] core:file convert html to lt;htmlgt; | |16394|New|Enh|2003-01-24|Enhance the IndexedListProperty to handle nested l| |16525|Opn|Enh|2003-01-29|BeanUtils.setProperty is over-zealous at convertin| |16600|New|Nor|2003-01-30|JUnitTestAdapter throws SAXException because no DT| |16873|New|Enh|2003-02-07|Specifying a different latka.properties file | |16920|Opn|Enh|2003-02-10|Declaration of Locale (language/country) in valida| |17002|Opn|Enh|2003-02-12|Problem with index property | |17102|New|Enh|2003-02-15|Can't embed characters in paramValue data. | |17306|Opn|Enh|2003-02-22|extend field tag with forward attribute for er| |17501|New|Enh|2003-02-27|Add dynamic discovery of mapped properties to Prop| |17619|New|Nor|2003-03-03|[jelly] ClassLoader Problems with XMLParser and XM| |17650|New|Nor|2003-03-04|[unspecified] Make Messages pay attention to retur| |17662|New|Nor|2003-03-05|unknown options are ignored instead of throwing Un| |17663|Opn|Nor|2003-03-05|getArrayProperty does not use ConvertUtils| |17682|New|Nor|2003-03-05|HelpFormatter does not wrap lines correctly after | |17769|New|Blk|2003-03-07|[unspecified] pre-mature closing of Statement and | |17956|Ass|Nor|2003-03-13|[jelly] resource lookup in compiled scripts does n| |17957|New|Cri|2003-03-13|[launcher] - on OutOfMemoryError no message | |18087|New|Enh|2003-03-18|Add BeanFactory class for dynamic factories. | |18194|Opn|Enh|2003-03-20|[Resources] Enhance MessageResources to enable sev| |18773|New|Enh|2003-04-07|[reflect] Can add a method cache in MethodUtils | |18811|New|Min|2003-04-08|Misleading error message in ConvertingWrapDynaBean| |18942|New|Enh|2003-04-11|Add t/f to BooleanConverter | |18968|Opn|Enh|2003-04-11|[email] Support SMTP Envelope From (bounce address| |19383|New|Nor|2003-04-28|Missing arguments in HelpFormatter.renderOptions(.| |19781|New|Nor|2003-05-08|PropertyUtils.copyProperties throws exceptions con| |19857|New|Enh|2003-05-12|Methods ConvertUtilsBean.convert could check for c| |20015|Ass|Nor|2003-05-18|[lang] Make Entities public and unit test | |20027|New|Enh|2003-05-19|ConvertUtils enhancements |
RE: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java
Welcome aboard Oliver!
Should we go through the bug list, clean it out and maybe release 1.0.1?
Build on the momentum of getting 1.0 out the door? It would also allow us
to have a version released with no deprecated methods...
Eric
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Saturday, November 13, 2004 5:03 PM
To: [EMAIL PROTECTED]
Subject: cvs commit:
jakarta-commons/configuration/src/java/org/apache/commons/configuration
HierarchicalConfiguration.java
oheger 2004/11/13 09:02:51
Modified:configuration/src/java/org/apache/commons/configuration
HierarchicalConfiguration.java
Log:
Fix for Bug 31745
Revision ChangesPath
1.13 +36 -2
jakarta-commons/configuration/src/java/org/apache/commons/configur
ation/HierarchicalConfiguration.java
Index: HierarchicalConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/common
s/configuration/HierarchicalConfiguration.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- HierarchicalConfiguration.java 18 Oct 2004 10:19:26 - 1.12
+++ HierarchicalConfiguration.java 13 Nov 2004 17:02:51 - 1.13
@@ -387,7 +387,7 @@
*/
public Iterator getKeys(String prefix)
{
-DefinedKeysVisitor visitor = new DefinedKeysVisitor();
+DefinedKeysVisitor visitor = new DefinedKeysVisitor(prefix);
List nodes = fetchNodeList(prefix);
ConfigurationKey key = new ConfigurationKey();
@@ -990,6 +990,9 @@
{
/** Stores the list to be filled.*/
private Set keyList;
+
+/** Stores a prefix for the keys.*/
+private String prefix;
/**
* Default constructor.
@@ -998,6 +1001,18 @@
{
keyList = new HashSet();
}
+
+/**
+ * Creates a new codeDefinedKeysVisitor/code
instance and sets the
+ * prefix for the keys to fetch.
+ *
+ * @param prefix the prefix
+ */
+public DefinedKeysVisitor(String prefix)
+{
+this();
+this.prefix = prefix;
+}
/**
* Returns the list with all defined keys.
@@ -1020,7 +1035,26 @@
{
if (node.getValue() != null key != null)
{
+addKey(key);
+}
+}
+
+/**
+ * Adds the specified key to the internal list.
+ *
+ * @param key the key to add
+ */
+protected void addKey(ConfigurationKey key)
+{
+if(prefix == null)
+{
keyList.add(key.toString());
+}
+else
+{
+StringBuffer buf = new StringBuffer(prefix);
+buf.append('.').append(key);
+keyList.add(buf.toString());
}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java
Eric Pugh wrote: Welcome aboard Oliver! Should we go through the bug list, clean it out and maybe release 1.0.1? Build on the momentum of getting 1.0 out the door? It would also allow us to have a version released with no deprecated methods... Eric Welcome :) With many enhancements currently in CVS I think we can even plan a 1.1 release. I would like to finish the implementation of INIConfiguration for 1.1, but I've no problem postponing it for the 1.2 release if you want to push a new release earlier. Emmanuel Bourg smime.p7s Description: S/MIME Cryptographic Signature
Re: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java
Emmanuel Bourg wrote: Eric Pugh wrote: Welcome aboard Oliver! Should we go through the bug list, clean it out and maybe release 1.0.1? Build on the momentum of getting 1.0 out the door? It would also allow us to have a version released with no deprecated methods... Eric Welcome :) With many enhancements currently in CVS I think we can even plan a 1.1 release. I would like to finish the implementation of INIConfiguration for 1.1, but I've no problem postponing it for the 1.2 release if you want to push a new release earlier. Emmanuel Bourg Thank you, it's a good feeling :) I think it is a good idea to get out a new release soon. We have indeed a couple of new features, which would justify a 1.1 release. I had a look at the bug list, most of the entries are enhancement requests. I would like to add a save() method to HierarchicalXMLConfiguration (Bug 31130), and I have a solution for 31797 (optional configurations). For the latter documentation could be updated, too. Which other issues should be addresed? Maybe 30858, this could confuse users. There was recently a posting on the user list of somebody who got a NPE when loading a file based configuration and the specified file does not exist. I would like to check this; in this case a ConfigurationException should be thrown. Something else? Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 18968] - [email] Support SMTP Envelope From (bounce address)
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=18968. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=18968 [email] Support SMTP Envelope From (bounce address) --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:01 --- Joe, I am happy to have you apply this fix, I think I understand better. The one thing I would ask is that you put a bit of documentation into either the javadocs, or even better, into /xdocs describing this behavior. I agree that is shouldn't be a system property. System properties often have a habit of causing nasty head scratching bugs as you wonder why the bounce isn't working properly! Since we are moving to promote from commons-sandbox, are you also a commons committer? Can I list you on the STATUS document? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java
I would like to add a save() method to HierarchicalXMLConfiguration (Bug 31130), and I have a solution for 31797 (optional configurations). For the latter documentation could be updated, too. Which other issues should be addresed? Maybe 30858, this could confuse users. There was recently a posting on the user list of somebody who got a NPE when loading a file based configuration and the specified file does not exist. I would like to check this; in this case a ConfigurationException should be thrown. Agreed, missing files should throw ConfigurationException. However, if we add 31797, then it wouldn't. I would like to see 31797 as I think it would help the usability for lots of people. I am not going to finish my JNDIConfiguration setProperty stuff, I got screwed up in it and frustrated, so I ended up working around it. Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 30973] - [email] [patch] HTML email with plain text alternative and attachments
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30973. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30973 [email] [patch] HTML email with plain text alternative and attachments [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:07 --- Okay.. I think we can close this now! I applied it, but changed the name of the new testcase, I don't like test cases named after bugs, as then you need to go look at the bug to see what the testcase is about. I did add the bug id in the description though.. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons-sandbox/email/src/test/org/apache/commons/mail SendWithAttachmentsTest.java BaseEmailTestCase.java
epugh 2004/11/14 10:07:43
Modified:email/src/java/org/apache/commons/mail MultiPartEmail.java
HtmlEmail.java
email/src/test/org/apache/commons/mail/mocks
MockHtmlEmailConcrete.java
email/src/test/org/apache/commons/mail
BaseEmailTestCase.java
Added: email/src/test/org/apache/commons/mail
SendWithAttachmentsTest.java
Log:
Bug 30973
HTML email with plain text alternative and attachments
Revision ChangesPath
1.12 +22 -2
jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MultiPartEmail.java
Index: MultiPartEmail.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/MultiPartEmail.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- MultiPartEmail.java 1 Nov 2004 13:55:02 - 1.11
+++ MultiPartEmail.java 14 Nov 2004 18:07:43 - 1.12
@@ -60,6 +60,9 @@
/** Indicates if the message has been initialized */
private boolean initialized = false;
+/** Indicates if attachments have been added to the message */
+private boolean boolHasAttachments = false;
+
/**
* Set the MIME subtype of the email.
* @param aSubType MIME subtype of the email
@@ -363,7 +366,8 @@
mbp.setFileName(name);
mbp.setDescription(description);
mbp.setDataHandler(new DataHandler(ds));
-
+this.boolHasAttachments = true;
+
return this;
}
@@ -405,6 +409,22 @@
init();
}
return container;
+}
+
+/**
+ * @return boolHasAttachments
+ */
+public boolean isBoolHasAttachments()
+{
+return boolHasAttachments;
+}
+
+/**
+ * @param b boolHasAttachments
+ */
+public void setBoolHasAttachments(boolean b)
+{
+boolHasAttachments = b;
}
}
1.16 +124 -19
jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/HtmlEmail.java
Index: HtmlEmail.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/HtmlEmail.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- HtmlEmail.java2 Nov 2004 11:13:26 - 1.15
+++ HtmlEmail.java14 Nov 2004 18:07:43 - 1.16
@@ -199,15 +199,64 @@
*/
public void send() throws MessagingException
{
-MimeMultipart container = this.getContainer();
-container.setSubType(related);
+// if the email has attachments then the base type is mixed,
+// otherwise it should be related
+if (this.isBoolHasAttachments())
+{
+this.buildAttachments();
+}
+else
+{
+this.buildNoAttachments();
+}
-BodyPart msgText = null;
+super.send();
+}
+
+/**
+ * @throws MessagingException MessagingException
+ */
+private void buildAttachments() throws MessagingException
+{
+MimeMultipart container = this.getContainer();
+MimeMultipart subContainer = null;
+ MimeMultipart subContainerHTML = new MimeMultipart(related);
BodyPart msgHtml = null;
+BodyPart msgText = null;
+
+container.setSubType(mixed);
+subContainer = new MimeMultipart(alternative);
+
+if (StringUtils.isNotEmpty(this.text))
+{
+msgText = new MimeBodyPart();
+subContainer.addBodyPart(msgText);
+
+if (StringUtils.isNotEmpty(this.charset))
+{
+msgText.setContent(
+this.text,
+Email.TEXT_PLAIN + ; charset= + this.charset);
+}
+else
+{
+msgText.setContent(this.text, Email.TEXT_PLAIN);
+}
+}
if (StringUtils.isNotEmpty(this.html))
{
-msgHtml = this.getPrimaryBodyPart();
+ if (this.inlineImages.size() 0)
+ {
+ msgHtml = new MimeBodyPart();
+ subContainerHTML.addBodyPart(msgHtml);
+ }
+ else
+ {
+ msgHtml = new MimeBodyPart();
+ subContainer.addBodyPart(msgHtml);
+ }
+
if (StringUtils.isNotEmpty(this.charset))
{
msgHtml.setContent(
@@ -220,38
DO NOT REPLY [Bug 32007] - [email] dumpster bogus smtp server fails on tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32007. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32007 [email] dumpster bogus smtp server fails on tests --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:09 --- Can we close this now? I think everything is working properly now that I applied 30973 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32068] - [email] create test email directory
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32068. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32068 [email] create test email directory [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX Summary|[email] create test email |[email] create test email |directory |directory --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:11 --- The tests right now generate the directory if it is missing. I like that because it makes the tests run better in Ant... The maven Ant script generator doesn't know about anything in maven.xml, so we want to do any directory creating inside the test.. A bit icky, as this is cleaner, but simpler for the Ant build. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32091] - [email] exception testing in unit test better in a ExceptionTestCase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32091 [email] exception testing in unit test better in a ExceptionTestCase --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:12 --- Shouldn't this then be asserting the comments of the exception? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration HierarchicalConfiguration.java
Eric Pugh wrote: Agreed, missing files should throw ConfigurationException. However, if we add 31797, then it wouldn't. I would like to see 31797 as I think it would help the usability for lots of people. I am not going to finish my JNDIConfiguration setProperty stuff, I got screwed up in it and frustrated, so I ended up working around it. Eric The NPE is a bit different from the enhancement 31797 because the former relates to constructors of file based configurations and the latter is a new feature of ConfigurationFactory. I will open a new bugzilla ticket for the NPEs, direct the reporting user to it and provide a fix. I will then commit my patch for bug 31797. Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32236] New: - [configuration] File based configurations throw NPE when file does not exist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32236. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32236 [configuration] File based configurations throw NPE when file does not exist Summary: [configuration] File based configurations throw NPE when file does not exist Product: Commons Version: Nightly Builds Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Configuration AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] If a file based configuration like PropertiesConfiguration is constructed with a file name and the specified file does not exist, a NullPointerException is thrown instead of a ConfigurationException. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32091] - [email] exception testing in unit test better in a ExceptionTestCase
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32091. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32091 [email] exception testing in unit test better in a ExceptionTestCase --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:14 --- What do you mean? I just moved exception testing into a specialsed test for doing so.. Tell me what you need and i'll submit it. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32007] - [email] dumpster bogus smtp server fails on tests
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32007. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32007 [email] dumpster bogus smtp server fails on tests --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:17 --- I think most the problems were with the smtp.jat issue.. So to my knowledge it all works now.. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration AbstractFileConfiguration.java
oheger 2004/11/14 10:29:02
Modified:configuration/src/test/org/apache/commons/configuration
TestPropertiesConfiguration.java
configuration/src/java/org/apache/commons/configuration
AbstractFileConfiguration.java
Log:
Bug 32236: Fixed NPE for file based configurations when constructed with
invalid file name
Revision ChangesPath
1.16 +14 -1
jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestPropertiesConfiguration.java
Index: TestPropertiesConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestPropertiesConfiguration.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- TestPropertiesConfiguration.java 18 Oct 2004 21:38:45 - 1.15
+++ TestPropertiesConfiguration.java 14 Nov 2004 18:29:02 - 1.16
@@ -207,6 +207,19 @@
assertEquals(true, conf.getString(configuration.loaded));
}
+
+public void testLoadUnexistingFile()
+{
+try
+{
+conf = new PropertiesConfiguration(Unexisting file);
+fail(Unexisting file was loaded.);
+}
+catch(ConfigurationException cex)
+{
+// fine
+}
+}
public void testGetStringWithEscapedChars()
{
1.8 +5 -1
jakarta-commons/configuration/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
Index: AbstractFileConfiguration.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- AbstractFileConfiguration.java19 Oct 2004 11:44:31 - 1.7
+++ AbstractFileConfiguration.java14 Nov 2004 18:29:02 - 1.8
@@ -80,6 +80,10 @@
// locate the file
url = ConfigurationUtils.locate(fileName);
+if(url == null)
+{
+throw new ConfigurationException(fileName + could not be
found!);
+}
// update the base path
setBasePath(ConfigurationUtils.getBasePath(url));
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32094] - [email] All exceptions seem to be thrown as messagingExceptions
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32094 [email] All exceptions seem to be thrown as messagingExceptions [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:29 --- Interesting.. I like the addressexception idea. However, I don't like that adding this starts causing us to throw UnsupportedEncodingException everywhere. The idea of commons-email is to hide the details. What do you think of introcucing an org.apache.commons.email.EmailException and AddressException extending EmailException? EmailException could extend NestableException, and then anything we need would be put in there. Regardless of wether its an javax.mail.internet.AddressException, javax.mail.MessagingException, or UnsupportedEncodingException. If you care about what the underlying exception is, then you can dig it out of the NestableException. Really, the only exceptions I can see most users wanting are 1) a bad addresss, 2) some sort of smtp error. and you could just througw EmailException, and then dig the details out if you cared from there.. ERic - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32236] - [configuration] File based configurations throw NPE when file does not exist
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32236. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32236 [configuration] File based configurations throw NPE when file does not exist [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:38 --- A fix and an additional unit test for PropertiesConfiguration were provided. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/configuration project.xml
oheger 2004/11/14 11:06:32
Modified:configuration/xdocs changes.xml
configuration/src/test/org/apache/commons/configuration
TestConfigurationFactory.java
configuration/src/java/org/apache/commons/configuration
ConfigurationFactory.java
configuration project.xml
Added: configuration/conf testDigesterOptionalConfiguration.xml
Log:
Added support for optional configurations in configuration definition files
for ConfigurationFactory.
Revision ChangesPath
1.69 +9 -0 jakarta-commons/configuration/xdocs/changes.xml
Index: changes.xml
===
RCS file: /home/cvs/jakarta-commons/configuration/xdocs/changes.xml,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -r1.68 -r1.69
--- changes.xml 21 Oct 2004 18:36:14 - 1.68
+++ changes.xml 14 Nov 2004 19:06:32 - 1.69
@@ -71,6 +71,15 @@
AppletConfiguration, ServletConfiguration,
ServletContextConfiguration,
ServletRequestConfiguration, ServletFilterConfiguration.
/action
+ action dev=oheger type=fix issue=32236
+ Fixed NPE that where caused in the constructors of file based
+ configurations if an invalid file name was specified.
+ /action
+ action dev=oheger type=add issue=31797
+ Added support for optional configuration sources in definition
files for
+ ConfigurationFactory. A new required attribute allows to
specify whether a
+ configuration source is mandatory or optional.
+ /action
/release
release version=1.0.1-dev date=in CVS
1.17 +12 -1
jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestConfigurationFactory.java
Index: TestConfigurationFactory.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestConfigurationFactory.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- TestConfigurationFactory.java 18 Oct 2004 12:50:41 - 1.16
+++ TestConfigurationFactory.java 14 Nov 2004 19:06:32 - 1.17
@@ -44,6 +44,8 @@
new File(conf/testDigesterConfiguration2.xml);
private File testDigesterFileComplete =
new File(conf/testDigesterConfiguration3.xml);
+private File testDigesterFileOptional =
+new File(conf/testDigesterOptionalConfiguration.xml);
private File testDigesterBadXML = new
File(conf/testDigesterBadXML.xml);
@@ -237,6 +239,15 @@
// test SystemConfiguration
assertNotNull(config.getProperty(java.version));
assertEquals(System.getProperty(java.version),
config.getString(java.version));
+}
+
+// Checks if optional configurations work
+public void testOptionalConfigurations() throws Exception
+{
+factory.setConfigurationURL(testDigesterFileOptional.toURL());
+Configuration config = factory.getConfiguration();
+assertTrue(config.getBoolean(test.boolean));
+assertEquals(value, config.getProperty(element));
}
private void checkUnionConfig() throws Exception
1.1
jakarta-commons/configuration/conf/testDigesterOptionalConfiguration.xml
Index: testDigesterOptionalConfiguration.xml
===
?xml version=1.0 encoding=ISO-8859-1 ?
!-- Configuration test file that demonstrates
optional configurations --
configuration
properties fileName=test.properties/
xml fileName=test.xml required=true/
hierarchicalXml fileName=nonExistingHierarchicalXML1.xml
required=false/
properties fileName=nonExistingProperties1.properties required=no/
xml fileName=nonExistingXML1.xml required=false/
additional
properties fileName=nonExistingProperties2.properties required=no/
hierarchicalXml fileName=nonExistingHierarchicalXML2.xml
required=false/
xml fileName=nonExistingXML2.xml required=false/
/additional
/configuration
1.18 +28 -7
jakarta-commons/configuration/src/java/org/apache/commons/configuration/ConfigurationFactory.java
Index: ConfigurationFactory.java
===
RCS file:
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/ConfigurationFactory.java,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
--- ConfigurationFactory.java 18 Oct 2004 12:50:41 - 1.17
+++ ConfigurationFactory.java 14 Nov 2004 19:06:32 - 1.18
@@ -57,9 +57,12 @@
DO NOT REPLY [Bug 31797] - [configuration] Optional configurations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31797. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31797 [configuration] Optional configurations --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 19:09 --- Patch applied. I leave this open for discussion. The howtos for ConfigurationFactory need to be updated, too. I can do this if everybody is happy with this patch. Oliver - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[email] Website has been updated
Hey all, Just wanted to let you know I updated the website. Check out that 97% code coverage! We should take a spin through the current examples and make sure they are up to snuff. I *think* this is the last step before I can start a thread for promotion out of sandbox. Eric - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration
Emmanuel Bourg [EMAIL PROTECTED] writes: I thinky you both are right :-) 1.0.1 should be a maintenance release for 1.0, removing a few bugs and the deprecated methods but not have much new functionality. So yes, if we close the bugs as Eric mentioned, I'm all +1 for having a soon release. Your stuff would go into 1.1 and I would target that at 1Q05 timeframe. Regards Henning --ms030201010601060102090201 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Eric Pugh wrote: Welcome aboard Oliver! Should we go through the bug list, clean it out and maybe release 1.0.1? Build on the momentum of getting 1.0 out the door? It would also allow us to have a version released with no deprecated methods... Eric Welcome :) With many enhancements currently in CVS I think we can even plan a 1.1 release. I would like to finish the implementation of INIConfiguration for 1.1, but I've no problem postponing it for the 1.2 release if you want to push a new release earlier. Emmanuel Bourg --ms030201010601060102090201 Content-Type: application/x-pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=smime.p7s Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIII4TCC AsswggI0oAMCAQICAwt8LDANBgkqhkiG9w0BAQQFADBiMQswCQYDVQQGEwJaQTElMCMGA1UE ChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNv bmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwHhcNMDQwMTE1MjI0MzM4WhcNMDUwMTE0MjI0MzM4 WjBBMR8wHQYDVQQDExZUaGF3dGUgRnJlZW1haWwgTWVtYmVyMR4wHAYJKoZIhvcNAQkBFg9z bWFudXhAbGZqci5uZXQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDvvsq86rHp 7QoLv7HunaTubs7yrH2jgUrNe6M0UREZfkfgTKkakkN0DdsuD1LfYL+h58vS6a3YlaB5/ATz gfEyfQQSMM3p5Zv2HcG76RoLRxNawENV6tjJJ98/fVS4meBLZL5EJxPTCrZbwUqtwB8cFV/X oXzS1wr5AyqCSrpDBWZtPRfsJZJaw/swtzrHfbPMzd6Ri+o0jeCb/PywTCNbE7F7vyUo860S redLbc1pXIgrSeazRcur/yvMgMW31BE1qWDXYMHE+2xv3AEmJ7HCX6vAMo+/lznpPngtONee RodC7flgeqK4q7bb7agnAICdcKEOmSK6y4It4ImS9Wo/AgMBAAGjLDAqMBoGA1UdEQQTMBGB D3NtYW51eEBsZmpyLm5ldDAMBgNVHRMBAf8EAjAAMA0GCSqGSIb3DQEBBAUAA4GBAKuPshYf GbFZjHJEnrsKiZeZha4ox0kCEpDGJ18lxggllUzqmZhwBio0bmnbCUXUGpId+bLUaqjWSy4G ArapBWc9p5R0LSsKwgtPSVMA83xNhbu2IDL0q+vmNu7JN36YN4fSMFF1hrRUQPrhF1JL9zlP 184GvhqDuHKUPrl2CQPtMIICyzCCAjSgAwIBAgIDC3wsMA0GCSqGSIb3DQEBBAUAMGIxCzAJ BgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5KSBMdGQuMSwwKgYD VQQDEyNUaGF3dGUgUGVyc29uYWwgRnJlZW1haWwgSXNzdWluZyBDQTAeFw0wNDAxMTUyMjQz MzhaFw0wNTAxMTQyMjQzMzhaMEExHzAdBgNVBAMTFlRoYXd0ZSBGcmVlbWFpbCBNZW1iZXIx HjAcBgkqhkiG9w0BCQEWD3NtYW51eEBsZmpyLm5ldDCCASIwDQYJKoZIhvcNAQEBBQADggEP ADCCAQoCggEBAO++yrzqsentCgu/se6dpO5uzvKsfaOBSs17ozRRERl+R+BMqRqSQ3QN2y4P Ut9gv6Hny9LprdiVoHn8BPOB8TJ9BBIwzenlm/YdwbvpGgtHE1rAQ1Xq2Mkn3z99VLiZ4Etk vkQnE9MKtlvBSq3AHxwVX9ehfNLXCvkDKoJKukMFZm09F+wlklrD+zC3Osd9s8zN3pGL6jSN 4Jv8/LBMI1sTsXu/JSjzrRKt50ttzWlciCtJ5rNFy6v/K8yAxbfUETWpYNdgwcT7bG/cASYn scJfq8Ayj7+XOek+eC04155Gh0Lt+WB6orirttvtqCcAgJ1woQ6ZIrrLgi3giZL1aj8CAwEA AaMsMCowGgYDVR0RBBMwEYEPc21hbnV4QGxmanIubmV0MAwGA1UdEwEB/wQCMAAwDQYJKoZI hvcNAQEEBQADgYEAq4+yFh8ZsVmMckSeuwqJl5mFrijHSQISkMYnXyXGCCWVTOqZmHAGKjRu adsJRdQakh35stRqqNZLLgYCtqkFZz2nlHQtKwrCC09JUwDzfE2Fu7YgMvSr6+Y27sk3fpg3 h9IwUXWGtFRA+uEXUkv3OU/Xzga+GoO4cpQ+uXYJA+0wggM/MIICqKADAgECAgENMA0GCSqG SIb3DQEBBQUAMIHRMQswCQYDVQQGEwJaQTEVMBMGA1UECBMMV2VzdGVybiBDYXBlMRIwEAYD VQQHEwlDYXBlIFRvd24xGjAYBgNVBAoTEVRoYXd0ZSBDb25zdWx0aW5nMSgwJgYDVQQLEx9D ZXJ0aWZpY2F0aW9uIFNlcnZpY2VzIERpdmlzaW9uMSQwIgYDVQQDExtUaGF3dGUgUGVyc29u YWwgRnJlZW1haWwgQ0ExKzApBgkqhkiG9w0BCQEWHHBlcnNvbmFsLWZyZWVtYWlsQHRoYXd0 ZS5jb20wHhcNMDMwNzE3MDAwMDAwWhcNMTMwNzE2MjM1OTU5WjBiMQswCQYDVQQGEwJaQTEl MCMGA1UEChMcVGhhd3RlIENvbnN1bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3Rl IFBlcnNvbmFsIEZyZWVtYWlsIElzc3VpbmcgQ0EwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJ AoGBAMSmPFVzVftOucqZWh5owHUEcJ3f6f+jHuy9zfVb8hp2vX8MOmHyv1HOAdTlUAow1wJj WiyJFXCO3cnwK4Vaqj9xVsuvPAsH5/EfkTYkKhPPK9Xzgnc9A74r/rsYPge/QIACZNenpruf ZdHFKlSFD0gEf6e20TxhBEAeZBlyYLf7AgMBAAGjgZQwgZEwEgYDVR0TAQH/BAgwBgEB/wIB ADBDBgNVHR8EPDA6MDigNqA0hjJodHRwOi8vY3JsLnRoYXd0ZS5jb20vVGhhd3RlUGVyc29u YWxGcmVlbWFpbENBLmNybDALBgNVHQ8EBAMCAQYwKQYDVR0RBCIwIKQeMBwxGjAYBgNVBAMT EVByaXZhdGVMYWJlbDItMTM4MA0GCSqGSIb3DQEBBQUAA4GBAEiM0VCD6gsuzA2jZqxnD3+v rL7CF6FDlpSdf0whuPg2H6otnzYvwPQcUCCTcDz9reFhYsPZOhl+hLGZGwDFGguCdJ4lUJRi x9sncVcljd2pnDmOjCBPZV+V2vf3h9bGCE6u9uo05RAaWzVNd+NWIXiC3CEZNd4ksdMdRv9d X2VPMYIDOzCCAzcCAQEwaTBiMQswCQYDVQQGEwJaQTElMCMGA1UEChMcVGhhd3RlIENvbnN1 bHRpbmcgKFB0eSkgTHRkLjEsMCoGA1UEAxMjVGhhd3RlIFBlcnNvbmFsIEZyZWVtYWlsIElz c3VpbmcgQ0ECAwt8LDAJBgUrDgMCGgUAoIIBpzAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0wNDExMTQxNjExMTFaMCMGCSqGSIb3DQEJBDEWBBTEsBHefqz/ 1FcoM2dZVZYAtQSS1TBSBgkqhkiG9w0BCQ8xRTBDMAoGCCqGSIb3DQMHMA4GCCqGSIb3DQMC AgIAgDANBggqhkiG9w0DAgIBQDAHBgUrDgMCBzANBggqhkiG9w0DAgIBKDB4BgkrBgEEAYI3 EAQxazBpMGIxCzAJBgNVBAYTAlpBMSUwIwYDVQQKExxUaGF3dGUgQ29uc3VsdGluZyAoUHR5
cvs commit: jakarta-commons-sandbox/email/src/java/org/apache/commons/mail Email.java
germuska2004/11/14 13:15:33
Modified:email/xdocs examples.xml
email/src/java/org/apache/commons/mail Email.java
Log:
add support for bounce handling and document in examples.xml
Revision ChangesPath
1.4 +32 -1 jakarta-commons-sandbox/email/xdocs/examples.xml
Index: examples.xml
===
RCS file: /home/cvs/jakarta-commons-sandbox/email/xdocs/examples.xml,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- examples.xml 19 Feb 2004 23:21:41 - 1.3
+++ examples.xml 14 Nov 2004 21:15:33 - 1.4
@@ -193,6 +193,37 @@
/p
/section
+section name=Handling Bounced Messages
+ p
+Normally, messages which cannot be delivered to a recipient are
returned to the
+sender (specified with the codefrom/code property). However, in
some cases,
+you'll want these to be sent to a different address. To do this,
simply call the
+codesetBounceAddress(emailAddressString)/code method before
sending
+your email.
+ /p
+ p
+Technical notes: When SMTP servers cannot deliver mail, they do not
pay any attention
+to the contents of the message to determine where the error
notification should be
+sent. Rather, they refer to the SMTP envelope sender value.
JavaMail sets this
+value according to the value of the codemail.smtp.from/code
property on the
+JavaMail codeSession/code. (Commons Email initializes the
JavaMail
+codeSession/code using codeSystem.getProperties()/code)
+If this property has not been set, then JavaMail
+uses the from address. If your email bean has the
codebounceAddress/code
+property set, then Commons Email uses it to set the value of
codemail.smtp.from/code
+when the codeSession/code is initialized, overriding any other
value
+which might have been set.
+ /p
+ p
+emNote: /em This is the only way to control the handling of
bounced email.
+Specifically, the Errors-to: SMTP header is deprecated and cannot
be trusted
+to control how a bounced message will be handled. Also note that it
is considered bad
+practice to send email with an untrusted from address unless you
also set the
+bounce address. If your application allows users to enter an
address which is used
+as the from address on an email, you should be sure to set the
bounce address
+to a known good address.
+ /p
+/section
/body
/document
1.26 +31 -2
jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/Email.java
Index: Email.java
===
RCS file:
/home/cvs/jakarta-commons-sandbox/email/src/java/org/apache/commons/mail/Email.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- Email.java29 Oct 2004 12:06:40 - 1.25
+++ Email.java14 Nov 2004 21:15:33 - 1.26
@@ -162,6 +162,14 @@
/** List of replyTo email adresses */
protected ArrayList replyList = new ArrayList();
+/**
+ * Address to which undeliverable mail should be sent.
+ * Because this is handled by JavaMail as a String property
+ * in the mail session, this property is of type codeString/code
+ * rather than codeInternetAddress/code.
+ */
+protected String bounceAddress = null;
+
/**
* Used to specify the mail headers. Example:
*
@@ -172,7 +180,7 @@
protected Hashtable headers = new Hashtable();
/**
- * Used to determine wether to use pop3 before smtp, and if so the
settings.
+ * Used to determine whether to use pop3 before smtp, and if so the
settings.
*/
/** */
@@ -357,6 +365,11 @@
properties.setProperty(MAIL_SMTP_AUTH, true);
}
+if (this.bounceAddress != null)
+{
+properties.setProperty(MAIL_SMTP_FROM, this.bounceAddress);
+}
+
// changed this (back) to getInstance due to security exceptions
// caused when testing using maven
this.session =
@@ -725,6 +738,22 @@
this.subject = aSubject;
return this;
}
+
+/**
+ * Set the bounce address - the address to which undeliverable messages
+ * will be returned. If this value is never set, then the message will
be
+ * sent to the address specified with the System property
mail.smtp.from,
+ * or if that value is not set, then to the from address.
+ *
+ * @param email A String.
+ * @return An Email.
+ */
+
Re: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to be thrown as messagingExceptions
I wanted to add a new exception or group of exception for handling stuff, but didn't want to start submitting patches that would have no chance of getting commited. I agree throwing an addressing exception is good (at least use it as a validation measure). I started playing with having the UnSupportedexception only when setting the Charset. I don't think i got around to submitting it. I think an EmailException would be just the thing, but if one did want just to wrap the javamail api and use what it provides then setting the charset to a default and then throwing UnSupportedCharSetexception only when setCharSet is called. Then even if catching the UnSupportedCharSetexception it would never be thrown. Mark On 14 Nov 2004 18:29:59 -, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32094. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32094 [email] All exceptions seem to be thrown as messagingExceptions [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Additional Comments From [EMAIL PROTECTED] 2004-11-14 18:29 --- Interesting.. I like the addressexception idea. However, I don't like that adding this starts causing us to throw UnsupportedEncodingException everywhere. The idea of commons-email is to hide the details. What do you think of introcucing an org.apache.commons.email.EmailException and AddressException extending EmailException? EmailException could extend NestableException, and then anything we need would be put in there. Regardless of wether its an javax.mail.internet.AddressException, javax.mail.MessagingException, or UnsupportedEncodingException. If you care about what the underlying exception is, then you can dig it out of the NestableException. Really, the only exceptions I can see most users wanting are 1) a bad addresss, 2) some sort of smtp error. and you could just througw EmailException, and then dig the details out if you cared from there.. ERic - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[email] Handling bounces (was Re: DO NOT REPLY [Bug 18968] - [email] Support SMTP Envelope From (bounce address))
I updated Email.java and added some notes at the bottom of xdocs/examples.xml. I couldn't figure out any way to have Dumbster simulate a bounce, but I did write a trivial Java app that sent a message with and without setting the bounce address value and confirmed that it did what I intended it to do. I haven't yet got karma for any Commons-proper projects, but I'd be happy to be on STATUS and continue to try to help keep email going after it graduates from the sandbox. Joe I am happy to have you apply this fix, I think I understand better. The one thing I would ask is that you put a bit of documentation into either the javadocs, or even better, into /xdocs describing this behavior. I agree that is shouldn't be a system property. System properties often have a habit of causing nasty head scratching bugs as you wonder why the bounce isn't working properly! Since we are moving to promote from commons-sandbox, are you also a commons committer? Can I list you on the STATUS document? -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com Narrow minds are weapons made for mass destruction -The Ex - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-commons/httpclient/src/test/org/apache/commons/httpclient TestNoncompliant.java TestWebapp.java TestNoHost.java TestWebappNoncompliant.java
mbecke 2004/11/14 15:38:01
Modified:httpclient/src/test/org/apache/commons/httpclient
TestWebapp.java TestNoHost.java
Added: httpclient/src/test/org/apache/commons/httpclient
TestNoncompliant.java
Removed: httpclient/src/test/org/apache/commons/httpclient
TestWebappNoncompliant.java
Log:
Moved more test cases away from the webapp.
Submitted by: Michael Becke
Revision ChangesPath
1.14 +4 -5
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestWebapp.java
Index: TestWebapp.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestWebapp.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- TestWebapp.java 9 Nov 2004 04:25:05 - 1.13
+++ TestWebapp.java 14 Nov 2004 23:38:00 - 1.14
@@ -65,7 +65,6 @@
suite.addTest(TestWebappParameters.suite());
suite.addTest(TestWebappHeaders.suite());
suite.addTest(TestWebappPostMethod.suite());
-suite.addTest(TestWebappNoncompliant.suite());
suite.addTest(TestProxy.suite());
return suite;
}
1.46 +6 -4
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestNoHost.java
Index: TestNoHost.java
===
RCS file:
/home/cvs/jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestNoHost.java,v
retrieving revision 1.45
retrieving revision 1.46
diff -u -r1.45 -r1.46
--- TestNoHost.java 7 Nov 2004 12:31:42 - 1.45
+++ TestNoHost.java 14 Nov 2004 23:38:01 - 1.46
@@ -96,6 +96,8 @@
suite.addTest(TestPostMethod.suite());
suite.addTest(TestPartsNoHost.suite());
suite.addTest(TestMultipartPost.suite());
+
+suite.addTest(TestNoncompliant.suite());
return suite;
}
1.1
jakarta-commons/httpclient/src/test/org/apache/commons/httpclient/TestNoncompliant.java
Index: TestNoncompliant.java
===
/*
*
*
* Copyright 2003-2004 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*
* This software consists of voluntary contributions made by many
* individuals on behalf of the Apache Software Foundation. For more
* information on the Apache Software Foundation, please see
* http://www.apache.org/.
*
* [Additional notices, if required by prior licensing conditions]
*
*/
package org.apache.commons.httpclient;
import java.io.IOException;
import junit.framework.*;
import org.apache.commons.httpclient.methods.*;
import org.apache.commons.httpclient.params.HttpMethodParams;
import org.apache.commons.httpclient.server.HttpRequestHandler;
import org.apache.commons.httpclient.server.ResponseWriter;
import org.apache.commons.httpclient.server.SimpleHttpServerConnection;
import org.apache.commons.httpclient.server.SimpleRequest;
/**
* Tests handling of non-compliant responses.
*
* @author Oleg Kalnichevski
* @author Jeff Dever
*/
public class TestNoncompliant extends HttpClientTestBase {
public TestNoncompliant(String s) throws IOException {
super(s);
}
public static Test suite() {
TestSuite suite = new TestSuite(TestNoncompliant.class);
return suite;
}
/**
* Tests if client is able able to recover gracefully when HTTP server or
* proxy fails to send 100 status code when expected. The client should
* resume sending the request body after a defined timeout without having
* received continue code.
*/
public void testNoncompliantPostMethodString() {
this.server.setRequestHandler(new HttpRequestHandler() {
public boolean processRequest(SimpleHttpServerConnection conn,
SimpleRequest request) throws IOException {
ResponseWriter out = conn.getWriter();
[math] inefficient percentile implementation
The docs for org.apache.commons.math.stat.descriptive.rank.Percentile state that To compute percentiles, the data must be (totally) ordered. This is flat out wrong. Sorting first with quicksort leads to O(n lg n) time, and there are selection algorithms for selection that are O(n). Details can be found in the standard texts such as Introduction To Algorithms or Numerical Recipes. If no one else cares to implement this, I certainly will within the next several weeks. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [math] inefficient percentile implementation
Ken Geis wrote:
The docs for org.apache.commons.math.stat.descriptive.rank.Percentile
state that To compute percentiles, the data must be (totally) ordered.
This is flat out wrong.
Sorted, no, ordered, yes. The comment says, To compute percentiles, the
data must be (totally) ordered. Input arrays are copied and then sorted
using Arrays.sort(double[]). The ordering used by Arrays.sort(double[]) is
the one determined by Double.compareTo(Double). This ordering makes
Double.NaN larger than any other value (including
Double.POSITIVE_INFINITY). Therefore, for example, the median (50th
percentile) of {0, 1, 2, 3, 4, Double.NaN} evaluates to 2.5.
In order for order statistics to be *defined*, you need to have a total
ordering defined over the set of values. That was the intention of the
first sentence above. The last part of the comment effectively
communicates what ordering we are using. Whatever implementation we use,
we will still need to define and document a total ordering (natural one to
use the one above). I understand that the first sentence could be
interpreted to mean that there is no way to compute percentiles without
copying and sorting the data, which I agree is not true.
Sorting first with quicksort leads to O(n lg
n) time, and there are selection algorithms for selection that are O(n).
Details can be found in the standard texts such as Introduction To
Algorithms or Numerical Recipes.
If no one else cares to implement this, I certainly will within the next
several weeks.
Patches welcome :-) Pls make sure to fully document the algorithm
(similar to the current javadoc) and avoid lifting anything directly from
Numerical Recipes (there are copyright restrictions on their algorithms
and code / pseudocode). Thanks in advance.
Phil
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JELLY-163) Allow Expressions to throw exceptions
Allow Expressions to throw exceptions - Key: JELLY-163 URL: http://nagoya.apache.org/jira/browse/JELLY-163 Project: jelly Type: Improvement Components: core / taglib.core Versions: 1.1-beta-1 Reporter: Hans Gilde Per a recent email from Paul Libbrecht, we should allow expressions to throw an exception. Currently, the Expression interface doesn't throw exceptions. Issues: * currently, the script evaluation isn't terminated because of an expression exception. should it be? by default, I mean. could this be another flag in the environment? * should the tag itself be given a way to intercept exceptions from Expressions? Expressions are evaluated before the tag is run, so it normally wouldn't know anything about them. Email from Paul Libbrecht [EMAIL PROTECTED]: Hi, One of the most frustrating place in jelly, to my taste, is when a jexl exception occurs... Jelly complains (at least with good logging settings) but does not throw. Moreover, this complaint doesn't have a jelly line-number which makes it somewhat hard. Is there really any wish that such an exception is not thrown ? thanks paul ~~~ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://nagoya.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Jakarta Commons Wiki] Updated: Jelly
Date: 2004-11-14T18:03:15 Editor: HansGilde [EMAIL PROTECTED] Wiki: Jakarta Commons Wiki Page: Jelly URL: http://wiki.apache.org/jakarta-commons/Jelly no comment Change Log: -- @@ -14,5 +14,5 @@ ||Do you have a good example, add it here!|| = FAQ = - - ||Add your questions/answers here.|| +1. Where should I report issues/suggestions for Jelly? + Report issues using Jira: http://nagoya.apache.org/jira/browse/JELLY - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32238] New: - Can't escape two consecutive single quotes in an EL string
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32238.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=32238
Summary: Can't escape two consecutive single quotes in an EL
string
Product: Commons
Version: 1.0 Final
Platform: Macintosh
OS/Version: Mac OS X 10.3
Status: NEW
Severity: normal
Priority: P2
Component: EL
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
This EL expressions:
${'a\'\'c'}
causes this error: Unterminated ${ tag
It should output a''c as it does in resin.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31429] - [configuration] Messed file on saving an XMLConfiguration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31429. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31429 [EMAIL PROTECTED] changed: What|Removed |Added Priority||P1 --- Additional Comments From [EMAIL PROTECTED] 2004-11-15 01:19 --- I have a similar problem, and was able to produce test code: XMLConfiguration conf = new XMLConfiguration(); conf.addProperty(bla.test,SomeValue); System.out.println(conf); Will output (jdk 1.4.2, cvs checkout from 11/14/04): ?xml version=1.0 encoding=UTF-8? configuration testSomeValue/test /configuration What the error here is: Instead of creating a node bla and then adding the subnode test it seems to totally ignore everything before the last dot. Similar things happen to larger paths, such as bla.blup.test and so on. hope this helps Max -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [logging]: WeakHashtable
I've attached a patch that adds a couple more tests and fixes a problem found by one of them. New test LogFactoryTest.testHoldsFactories() shows that WeakHashtable does not keep a LogFactory from being gc'ed even if the ClassLoader associated with it is still alive. So, calls to LogFactory.getFactory() result in new factories being created. The patch to WeakHashtable is largely designed to fix that. The patched WeakHashtable holds values in the table until the WeakReference to the associated ClassLoader is removed, even if the classloader itself has been gc'ed. Because of this, the potential amount of garbage left in the table is greater than it was before. The patch partly tries to remedy that by doing a purge before each rehash. The patch also switches the purge mechanism to one that uses a ReferenceQueue. This should be more performant, as it allows the purging process to only deal with items (if any) that definitely need to be removed from the hashtable, rather than iterating through all entries in the map. ReferenceQueue.poll() itself is quite fast, basically consisting of popping off the first element in a linked list. In this patch the way LogFactories are kept from being dropped from the hashtable is not ideal. Basically the keys in the map hold hard references to the LogFactories, keeping the WeakReferences to the LogFactories from being cleared. This approach is a leftover remnant of a failed attempt on my part at getting the hashtable itself to clear unneeded factories without the need for a call to purge(). It would be much cleaner to just have the hashtable hold normal hard references to the LogFactories. I didn't include such a change in this patch as 1) it may have made the patch overly complicated, and 2) I didn't have time ;-) If the powers that be agree that the LogFactories should be held directly by the Hashtable, I would be happy to create another patch. (Also, there's some funky stuff in the test cases where I try to handle OutOfMemoryError. It works on my environment (Eclipse 3.0, Sun JDK 1.4.2_03), but if others have thoughts about this, they would be much appreciated). Best, Brian --- Brian Stansberry [EMAIL PROTECTED] wrote: --- robert burrell donkin wrote: On 11 Nov 2004, at 07:40, Brian Stansberry wrote: A couple things occurred to me as I looked. 1) The instances of Referenced are not cleared from the underlying table if their underlying references are cleared. 2) Passing null keys/values to put() does not result in a NPE. One thought on #1 is to make Referenced a subclass of WeakReference instead of a wrapper. You can then keep a ReferenceQueue and poll it to remove cleared references from the hashtable whenever get() is called. This is similar to what WeakHashMap does. i had a bit of a think about the best way to do this. i think the approach outlined would be best if this were a general implementation. in this case, though, the majority of calls are going to be to get with somewhat less going to put and very few to any others. i can't think of any occasions when the symantics of put and get are influenced by the presence of extra entries. so i've opted for code that simply purges entries that have lost their referants which is called at the start of other interrogative methods. the data returned will be more stale than using a reference queue but i think that liveliness for put and get should be improved. Yep, slowing down the critical get() just to sweep up some dust in the corners makes no sense. i'd be grateful if people would take a look at the code and try to find any holes in this approach or reasons why using a ReferenceQueue might improve liveliness (preferably with patches)... I was thinking about this and concluded that the approach of iterating the Hashtable.entrySet() would be faster since you're checking if either the key or the value has been cleared. Using a ReferenceQueue for values would force you to use a reverse lookup map, which seems inefficient. But then I thought, wait, should the values be held in WeakReferences? In a typical case where the application just calls LogFactory.getLog(), won't the only reference to the LogFactory instance be the value in the map? In this case a lot of calls to getLog() will end up going through the getFactory() discovery mechanism as the GC keeps clearing the values from the hashtable. Brian __ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com Index:
DO NOT REPLY [Bug 30973] - [email] [patch] HTML email with plain text alternative and attachments
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=30973. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=30973 [EMAIL PROTECTED] changed: What|Removed |Added Priority||P1 --- Additional Comments From [EMAIL PROTECTED] 2004-11-15 07:08 --- All sounds great to me Eric, sorry about the name of the test case, I just feel like being creative at the time :-) -Corey -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: DO NOT REPLY [Bug 32094] - [email] All exceptions seem to be thrown as messagingExceptions
I also like these ideas and am happy to help you implement them if you would like. However there is one thing we may want to be aware of. I dont think that the setCharset causes the UnsupportedCharsetException to be throw, I believe that it doesn't check it and therefore allows for any value to be set. As we are trying to keep email small and maintainable, I dont think it is a good idea to try to added verfication to our classes. That said, I believe that the only value I came accross during testing that did throw this exception was the setName part of the addresses. Therefore the unsupported charset exception is thrown for all of the setFrom, addTo, addCc, addBcc, etc functions only at the moment. I hope this helps, Corey - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [email] Handling bounces (was Re: DO NOT REPLY [Bug 18968] - [email] Support SMTP Envelope From (bounce address))
Thanks Joe, it would be nice to not have to burden Eric so much with committing all of Mark and my changes :-) Regards, Corey On Sun, 14 Nov 2004 15:17:57 -0600, Joe Germuska [EMAIL PROTECTED] wrote: I updated Email.java and added some notes at the bottom of xdocs/examples.xml. I couldn't figure out any way to have Dumbster simulate a bounce, but I did write a trivial Java app that sent a message with and without setting the bounce address value and confirmed that it did what I intended it to do. I haven't yet got karma for any Commons-proper projects, but I'd be happy to be on STATUS and continue to try to help keep email going after it graduates from the sandbox. Joe I am happy to have you apply this fix, I think I understand better. The one thing I would ask is that you put a bit of documentation into either the javadocs, or even better, into /xdocs describing this behavior. I agree that is shouldn't be a system property. System properties often have a habit of causing nasty head scratching bugs as you wonder why the bounce isn't working properly! Since we are moving to promote from commons-sandbox, are you also a commons committer? Can I list you on the STATUS document? -- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com Narrow minds are weapons made for mass destruction -The Ex - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [email] Website has been updated
Eric, Do you know why the commons-email SNAPSHOT.jar is very old on the maven repo? Do we have to do something to keep this up to date? Thanks, Corey - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 31429] - [configuration] Messed file on saving an XMLConfiguration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=31429. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=31429 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
