[jira] Commented: (JELLY-188) tag library xml does not correctly parse body

2005-01-03 Thread dion gillard (JIRA)
 [ 
http://issues.apache.org/jira/browse/JELLY-188?page=comments#action_57249 ]
 
dion gillard commented on JELLY-188:


For the xmlunit taglibrary:

If I invoke some Jelly script within an xml tag this "body" will not be parsed
correctly. As far as I understand the code the sequence

handler.startDocument();
invokeBody( newOutput);
handler.endDocument();

will always create an empty document since no tag will ever be reported and thus
all writes will be ignored.

The whole code in the body of the parseBody method in XMLUnitTagSupport.java
should be replaced by

protected Document parseBody(XMLOutput output) throws JellyTagException {
return parseText(getBodyText(false));
}

> tag library xml does not correctly parse body
> -
>
>  Key: JELLY-188
>  URL: http://issues.apache.org/jira/browse/JELLY-188
>  Project: jelly
> Type: Bug
>   Components: taglib.xml
> Reporter: dion gillard

>
> If I invoke some Jelly script within an xml tag this "body" will not be parsed
> correctly. As far as I understand the code the sequence
> handler.startDocument();
> invokeBody( newOutput);
> handler.endDocument();
> will always create an empty document since no tag will ever be reported and 
> thus
> all writes will be ignored.
> The whole code in the body of the parseBody method in ParseTagSupport.java
> should be replaced by
> protected Document parseBody(XMLOutput output) throws JellyTagException {
> return parseText(getBodyText(false));
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JELLY-188) tag library xml does not correctly parse body

2005-01-03 Thread dion gillard (JIRA)
tag library xml does not correctly parse body
-

 Key: JELLY-188
 URL: http://issues.apache.org/jira/browse/JELLY-188
 Project: jelly
Type: Bug
  Components: taglib.xml  
Reporter: dion gillard


If I invoke some Jelly script within an xml tag this "body" will not be parsed
correctly. As far as I understand the code the sequence

handler.startDocument();
invokeBody( newOutput);
handler.endDocument();

will always create an empty document since no tag will ever be reported and thus
all writes will be ignored.

The whole code in the body of the parseBody method in ParseTagSupport.java
should be replaced by

protected Document parseBody(XMLOutput output) throws JellyTagException {
return parseText(getBodyText(false));
}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31542] - [jelly] Extending soap invoke tag to allow literal-style inline paramters

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31542


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:41 ---
Moved to JIRA. See JELLY-154

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [jelly] Bugzilla cleanup

2005-01-03 Thread Dion Gillard
Zarro Boogs found. 


On Tue, 14 Dec 2004 13:56:20 +0100, Emmanuel Bourg <[EMAIL PROTECTED]> wrote:
> Hi, is there a Jelly developper available to take a quick look at the
> remaining bugs open for Jelly in Bugzilla ?
> 
> http://issues.apache.org/bugzilla/buglist.cgi?product=Commons&component=Jelly&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED
> 
> There are 16 bugs left here, I haven't been able to find the
> corresponding bugs in JIRA. Could someone knowledgeable to Jelly take
> care of them by:
> 
> - closing the bugs fixed
> 
> - for open bugs with an equivalent in JIRA, add a comment with the URL
> of the corresponding entry in JIRA and mark them as RESOLVED LATER
> 
> - for open bugs with no equivalent in JIRA, create new JIRA entries and
> mark the bugs as RESOLVED LATER with a link to JIRA
> 
> Of course there is still the alternative of closing all bugs and asking
> the reporters to fill new entries in JIRA :)
> 
> Thank you,
> 
> Emmanuel Bourg
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
> 


-- 
http://www.multitask.com.au/people/dion/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17956] - [jelly] resource lookup in compiled scripts does not work properly

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17956


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:45 ---
Moved to JELLY-45

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31544] - [jelly] tag library xmlunit does not correctly parse body

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31544


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:44 ---
Moved to JELLY-188

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31543] - [jelly] tag library xml does not correctly parse body

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31543


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:43 ---
Moved to JELLY-188

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (JELLY-186) JellySWT doesn't support the FormLayout

2005-01-03 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-186?page=history ]

dion gillard updated JELLY-186:
---

Attachment: LayoutDataTag.java
LayoutDataTag-2.java
LayoutDataTag-3.java

In date/time order

> JellySWT doesn't support the FormLayout
> ---
>
>  Key: JELLY-186
>  URL: http://issues.apache.org/jira/browse/JELLY-186
>  Project: jelly
> Type: Bug
>   Components: taglib.swt
> Reporter: dion gillard
>  Attachments: LayoutDataTag-2.java, LayoutDataTag-3.java, LayoutDataTag.java, 
> LayoutTagSupport-2.java, LayoutTagSupport.java, SWTTagLibrary-2.java, 
> SWTTagLibrary.java
>
> -- Moved from Bugzilla 30403 --
> With the attached files, it now does. Here's an example:
> 
>   
>   
>  
>  
>  
>   
> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JELLY-186) JellySWT doesn't support the FormLayout

2005-01-03 Thread dion gillard (JIRA)
JellySWT doesn't support the FormLayout
---

 Key: JELLY-186
 URL: http://issues.apache.org/jira/browse/JELLY-186
 Project: jelly
Type: Bug
  Components: taglib.swt  
Reporter: dion gillard
 Attachments: LayoutDataTag-2.java, LayoutDataTag-3.java, LayoutDataTag.java, 
LayoutTagSupport-2.java, LayoutTagSupport.java, SWTTagLibrary-2.java, 
SWTTagLibrary.java

-- Moved from Bugzilla 30403 --
With the attached files, it now does. Here's an example:




   
   
   




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31411] - [jelly] Wrong composite expression evaluation

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31411


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:39 ---
Moved to JELLY-187

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30403] - [jelly] JellySWT doesn't support the FormLayout

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30403


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:38 ---
Moved to JELLY-186

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JELLY-182) Add parameter contentType to the EmailTag

2005-01-03 Thread dion gillard (JIRA)
Add parameter contentType to the EmailTag
-

 Key: JELLY-182
 URL: http://issues.apache.org/jira/browse/JELLY-182
 Project: jelly
Type: New Feature
  Components: taglib.email  
Reporter: dion gillard


-- Moved from Bugzilla 26630 --

It would be nice if it were possible to specify the content type for
the email message.  text/plain can be the default, but in some cases
text/html, etc. is useful.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Updated: (JELLY-181) SWT wallpaper support

2005-01-03 Thread dion gillard (JIRA)
 [ http://issues.apache.org/jira/browse/JELLY-181?page=history ]

dion gillard updated JELLY-181:
---

Attachment: wallpaper.patch

> SWT wallpaper support
> -
>
>  Key: JELLY-181
>  URL: http://issues.apache.org/jira/browse/JELLY-181
>  Project: jelly
> Type: New Feature
>   Components: taglib.swt
> Reporter: dion gillard
>  Attachments: wallpaper.patch
>
> -- Moved from Bugzilla 24466 --
> Attached is a patch that adds support for a 'wallpaper' attribute on Controls,
> which one can use to set a wallpaper image (similar to a web page).
> eg:
> 
> ...
> 
> Was useful for me, maybe it's useful for others.
> Cheers,
> Marcus

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30402] - [jelly] type attribute for any layout other than FillLayout doesn't work in the SWT tag library.

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30402


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:27 ---
Move to JELLY-185 in Jira

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 29818] - [jelly] Using namespace-prefixes breaks Jelly

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29818


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:26 ---
Move to JELLY-184 in JIRA

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 28812] - [jelly] jelly-ant-tags TaskContainer Support

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28812


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:24 ---
Move to JELLY-183 in Jira

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 26630] - [jelly] Add parameter contentType to the EmailTag

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26630


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:21 ---
Moved to JELLY-182 in Jira

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24825] - [jelly] MenuBar not shown in JellySWT

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24825


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:19 ---
Fixed in JELLY-97

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24466] - [PATCH] JellySWT: SWT wallpaper support

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=24466


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:18 ---
Moved to JELLY-181 in Jira

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JELLY-181) SWT wallpaper support

2005-01-03 Thread dion gillard (JIRA)
SWT wallpaper support
-

 Key: JELLY-181
 URL: http://issues.apache.org/jira/browse/JELLY-181
 Project: jelly
Type: New Feature
  Components: taglib.swt  
Reporter: dion gillard


-- Moved from Bugzilla 24466 --

Attached is a patch that adds support for a 'wallpaper' attribute on Controls,
which one can use to set a wallpaper image (similar to a web page).

eg:


...


Was useful for me, maybe it's useful for others.

Cheers,

Marcus

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[jira] Created: (JELLY-180) ClassLoader Problems with XMLParser and XMLParser reuse

2005-01-03 Thread dion gillard (JIRA)
ClassLoader Problems with XMLParser and XMLParser reuse
---

 Key: JELLY-180
 URL: http://issues.apache.org/jira/browse/JELLY-180
 Project: jelly
Type: Bug
  Components: core / taglib.core  
Reporter: dion gillard


-- Moved from bugzilla issue 17619 --

Hello,

i had problems integrating jelly because of the ClassLoader set to the 
JellyContext is not promoted to the XMLParser. That leads to 
ClassNotFoundExceptions in resolving custom TagLibs. This should be added in 
JellyContext compileScript methods.

The use of XMLParser in JellyContext needs a little more documentation not 
only because of 
a new XMLParser is always instantiated in compileScript(String uri) and 
compileScript(URL url) uses the per thread instance. Is it ok that the 
ImportTag therefore indirectly uses the same thread instance parser?



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 17619] - [jelly] ClassLoader Problems with XMLParser and XMLParser reuse

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=17619


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 08:14 ---
Moved to JIRA. JELLY-180.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31790] - [validator] The JavaScript function validateDate() does not distinguish between datePattern and datePatternStrict

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31790





--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 07:35 ---
A fix for the javascript is just posted in bug# 22384, so that the proper regex
is used for datePattern and datePatternStrict.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [svn] progress?

2005-01-03 Thread Henri Yandell
And upon sending that I remembered that Tim is out for holiday stuff
until tomorrow; so the status is that things are on hold until
tomorrow.

There's a test svn repo; but it's his own and not an official asf one
so I won't push that now.

Hen

On Mon, 3 Jan 2005 22:23:57 -0500, Henri Yandell <[EMAIL PROTECTED]> wrote:
> also.ping?
> 
> 
> On Sun, 2 Jan 2005 13:12:39 +, robert burrell donkin
> <[EMAIL PROTECTED]> wrote:
> > ping?
> >
> > - robert
> >
> > -
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [svn] progress?

2005-01-03 Thread Henri Yandell
also.ping?


On Sun, 2 Jan 2005 13:12:39 +, robert burrell donkin
<[EMAIL PROTECTED]> wrote:
> ping?
> 
> - robert
> 
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
> 
>

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [net] Submission of Configurable Timestamp parsing for FTP Listings

2005-01-03 Thread Steve Cohen
Hi, Mario, Happy New Year!
I certainly did think about your suggestions.  And I am not the least
surprised that you immediately want to implement a composite.  You do
seem to be in love with the Composite pattern! :-)
But here is where I drew the line.  I think we are talking about
entirely different use cases.
My use case is a user who has to talk to a particular non-"standard" FTP
server.  He already knows or can easily discover its properties.  He
wants to write a program (or Ant Script, once Ant supports the new
FTPClientConfig way of doing things) and that is that.  Runtime
discovery of the properties of the server he is working with are not the
point for such a user and will only slow his application down.  Such a
user doesn't even need the system-type autodetection, let alone a
composite. Configuration via calls to a few String setters fits within
this scenario.  Configuration via passing objects around does not.  ike
Ant should not have to create parser objects in order to use commons-net
for its ftp task.
I presume that your use case is the use case of VFS, although I must
admit that I really don't understand its utility.  I'm not sure what
problems this vastly self-configuring parser solves.  But that is really
beside the point.
In any case, the autodetection mechanism you need could be built outside
of commons-net as well as within it. There is the method
FTPClientConfig.getSupportedLanguageCodes() to help you query the
capabilities of the system.  You could use it to build an array
of SimpleDateFormats and build some sort of scheme to iterate through
the whole bunch, trying each one in order, or whatever you want to do.
That is the approach I would recommend to you.  The point is that your
use case and my use case are different, and I can't implement yours
without making the FTPClient more unwieldy and more confusing for the
user than I want it to be.
But there is also a second possibility.  There is nothing preventing you
from building your system as an alternative WITHIN the commons-net
package structure, if working through the default FTPClientConfig
mechanism is too prosaic for your tastes:
First, note that FTPClient itself now implements the new Configurable
interface.  You could define a composite version of FTPClientConfig as
an extension of FTPClientConfig and define alternative factory class
other to DefaultFTPEntryParserFactory, and specify this in the
FTPClient.configure() method itself.
if (config instanceof SuperDuperFTPClientConfig) {
__parserFactory =
Class.forName(((SuperDuperFTPClientConfig)config).getFactoryClass()).
newInstance();
}
Then initiateListParsing() would invoke your factory instead of the
default one which could do whatever you need it to do.  Actually, you
don't even need and FTPClientConfig in order to do that, you could just
call FTPClient.setParserFactory().
My logic is simple, and works for my use case.  The composite pattern
previously introduced made developing the Configurable setup harder than
it needed to be.  It wasn't until I realized that users in my use case
neither needed nor wanted any autodetection, that I was able to cut the
cord.  Take a look at the changes I had to make to
DefaultFTPFileEntryParserFactory to accomodate your Composite patterns
and the new ones.  That's as far as I  want to go in that direction.  If
you want different functionality, you should develop your own factory.
That's what the FTPFileEntryParserFactory interface is for.
So to reiterate, I see two options.
1) work within the current setup from the outside, passing in
FTPClientConfigs and build your composite detection scheme outside of Net or
2) write your own Parser Factory and possibly FTPClientConfig subclass
and then, with just a small change to the current system, you could hook
your factory in with the logic you need, unencumbered by the
restrictions of the old system.
If I still don't have enough hooks for you, I can consider ways of
building them in.  And some further refactoring - extracting interfaces,
if that buys you anything.  Try either approach and let me know where
the bottlenecks are.  We can certainly make changes.
But I won't be willing to change the default FTPClientConfig to pass
objects more complicated than strings around.  It confuses the issue of
my use case and violates the simple and clear design of the class which
is a simple container of configuration strings.
Mario Ivankovits wrote:
Hi Steve!
Lot of work!
But there is one thing is miss. After a first look at your checkins it 
seems it is not possible to replace the FTPTimestampParserImpl by a 
custom implementation.
It would be nice to have this to build a CompositeFTPTimestampParser 
which is able to hold multiple FTPTimestampParserImpls configured for a 
couple of languages one has to deal with. You know ;-) I would like to 
"guess" the right one.

I know you are against this strategy ...
Said that I would like to suggest to change the FTPClientConfig to not 
to hold the configuration of the 

test

2005-01-03 Thread Steve Cohen
test
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/javac - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/javac - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/problems - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/problems - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/bin - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/bin - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/gcj - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/gcj - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/lib - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/lib - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/classes - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/classes - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/pizza - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/pizza - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/lib - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/lib - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32914] - [collections] Comparable on AbstractKeyValue

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32914


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 01:17 ---
To make these classes Comparable would imply quite a lot for what would appear
to be an unusual case. In general, implementing additional interfaces in core
classes would be something I would deem a Bad Idea. Instead, the better approach
is to write a smaller, focussed Comparator, even though it seems to be a pain
intially.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/eclipse - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/eclipse - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/stores - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/stores - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/groovy - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/groovy - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/jikes - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/compilers/jikes - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32366] - [collections] MultiHashMap.remove(key, value) always returns a value

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32366


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 01:13 ---
Fixed, thanks

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections MultiHashMap.java

2005-01-03 Thread scolebourne
scolebourne2005/01/03 16:13:25

  Modified:collections RELEASE-NOTES.html
   collections/src/test/org/apache/commons/collections
TestMultiHashMap.java
   collections/src/java/org/apache/commons/collections
MultiHashMap.java
  Log:
  Fix MultiHashMap to return null when nothing removed
  bug 32366, reported by Tad Marko
  
  Revision  ChangesPath
  1.76  +1 -0  jakarta-commons/collections/RELEASE-NOTES.html
  
  Index: RELEASE-NOTES.html
  ===
  RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v
  retrieving revision 1.75
  retrieving revision 1.76
  diff -u -r1.75 -r1.76
  --- RELEASE-NOTES.html4 Jan 2005 00:01:31 -   1.75
  +++ RELEASE-NOTES.html4 Jan 2005 00:13:25 -   1.76
  @@ -52,6 +52,7 @@
   
   FastArrayList - Fix iterators and views to work better in multithreaded 
environments
   BoundedFifoBuffer/CircularFifoBuffer - Fix serialization to work in case 
where buffer serialized when full [31433]
  +MultiHashMap.remove(key, item) - Was returning the item even when 
nothing was removed [32366]
   
   
   JAVADOC
  
  
  
  1.21  +15 -2 
jakarta-commons/collections/src/test/org/apache/commons/collections/TestMultiHashMap.java
  
  Index: TestMultiHashMap.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/test/org/apache/commons/collections/TestMultiHashMap.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- TestMultiHashMap.java 9 Jun 2004 22:11:54 -   1.20
  +++ TestMultiHashMap.java 4 Jan 2005 00:13:25 -   1.21
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2001-2004 The Apache Software Foundation
  + *  Copyright 2001-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -415,6 +415,19 @@
   assertEquals(3, map.size());
   assertEquals(2, newMap.size());
   assertEquals(1, newColl.size());
  +}
  +
  +public void testRemove_KeyItem() {
  +MultiHashMap map = new MultiHashMap();
  +map.put("A", "AA");
  +map.put("A", "AB");
  +map.put("A", "AC");
  +assertEquals(null, map.remove("C", "CA"));
  +assertEquals(null, map.remove("A", "AD"));
  +assertEquals("AC", map.remove("A", "AC"));
  +assertEquals("AB", map.remove("A", "AB"));
  +assertEquals("AA", map.remove("A", "AA"));
  +assertEquals(new MultiHashMap(), map);
   }
   
   }
  
  
  
  1.21  +6 -4  
jakarta-commons/collections/src/java/org/apache/commons/collections/MultiHashMap.java
  
  Index: MultiHashMap.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/MultiHashMap.java,v
  retrieving revision 1.20
  retrieving revision 1.21
  diff -u -r1.20 -r1.21
  --- MultiHashMap.java 9 Jun 2004 22:11:54 -   1.20
  +++ MultiHashMap.java 4 Jan 2005 00:13:25 -   1.21
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2001-2004 The Apache Software Foundation
  + *  Copyright 2001-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -314,8 +314,10 @@
   if (valuesForKey == null) {
   return null;
   }
  -valuesForKey.remove(item);
  -
  +boolean removed = valuesForKey.remove(item);
  +if (removed == false) {
  +return null;
  +}
   // remove the list if it is now empty
   // (saves space, and allows equals to work)
   if (valuesForKey.isEmpty()){
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/bin/org/apache/javaflow - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/bin/org/apache/javaflow - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src/java/org/apache - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src/java/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/bin - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/bin - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/analyser - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/analyser - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32073] - [collections] ListOrderedSet broken or documentation wrong.

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32073


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 01:02 ---
The class is behaving as intended,, although I can see why you might have been
confused. I have added extra javadoc.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/set ListOrderedSet.java

2005-01-03 Thread scolebourne
scolebourne2005/01/03 16:01:31

  Modified:collections RELEASE-NOTES.html
   collections/src/java/org/apache/commons/collections/set
ListOrderedSet.java
  Log:
  Clarify comment on ListOrderedSet
  bug 32073
  
  Revision  ChangesPath
  1.75  +1 -0  jakarta-commons/collections/RELEASE-NOTES.html
  
  Index: RELEASE-NOTES.html
  ===
  RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v
  retrieving revision 1.74
  retrieving revision 1.75
  diff -u -r1.74 -r1.75
  --- RELEASE-NOTES.html3 Jan 2005 23:53:48 -   1.74
  +++ RELEASE-NOTES.html4 Jan 2005 00:01:31 -   1.75
  @@ -57,6 +57,7 @@
   JAVADOC
   
   MapUtils.safeAddToMap - Better comment
  +ListOrderedSet.decorate(List) - Better comment [32073]
   
   
   
  
  
  
  1.10  +7 -2  
jakarta-commons/collections/src/java/org/apache/commons/collections/set/ListOrderedSet.java
  
  Index: ListOrderedSet.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/set/ListOrderedSet.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- ListOrderedSet.java   7 Jun 2004 21:42:12 -   1.9
  +++ ListOrderedSet.java   4 Jan 2005 00:01:31 -   1.10
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2003-2004 The Apache Software Foundation
  + *  Copyright 2003-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -59,6 +59,8 @@
   
   /**
* Factory method to create an ordered set specifying the list and set 
to use.
  + * 
  + * The list and set must both be empty.
* 
* @param set  the set to decorate, must be empty and not null
* @param list  the list to decorate, must be empty and not null
  @@ -95,6 +97,9 @@
* Factory method to create an ordered set using the supplied list to 
retain order.
* 
* A HashSet is used for the set behaviour.
  + * 
  + * NOTE: If the list contains duplicates, the duplicates are removed,
  + * altering the specified list.
* 
* @param list  the list to decorate, must not be null
* @throws IllegalArgumentException if list is null
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/classes/org/vafer - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/classes/org/vafer - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/readers - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/readers - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/classes/org - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/classes/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/monitor - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org/apache/jci/monitor - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31519] - [collections] Getting rid of some javadoc warn messages (3.2-dev)

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31519


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 00:54 ---
Patches applied, thanks.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org/apache/jci/stores FileResourceStore.java MemoryResourceStore.java ResourceStore.java TransactionalResourceStore.java

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:54:19

  Added:   javaflow .classpath .project LICENSE.txt TODO
project.properties project.xml
   javaflow/lib jakarta-bcel-20040329.jar jci-20041213.jar
   javaflow/src/java/org/apache/javaflow ClassTransformer.java
Continuable.java Continuation.java
ContinuationCapable.java
ContinuationClassLoader.java
ContinuationClassTransformer.java
ContinuationContext.java ContinuationStack.java
DecompilingVisitor.java EmptyStackException.java
Main.java RewritingResourceStore.java
TestClassLoader.java
   javaflow/src/java/org/apache/javaflow/analyser
ControlFlowGraph.java ExceptionHandler.java
ExceptionHandlers.java ExecutionVisitor.java
Frame.java InstructionContext.java
LocalVariables.java OperandStack.java
Subroutine.java Subroutines.java
UninitializedObjectType.java
   jci  .classpath .project LICENSE.txt TODO
project.properties project.xml
   jci/classes/org/vafer MyInterface.java MyObject.java
Test.java
   jci/lib  jakarta-bcel-20040329.jar
   jci/src/java/org/apache/jci CompilingClassLoader.java
ResourceStoreClassLoader.java
   jci/src/java/org/apache/jci/compilers JavaCompiler.java
   jci/src/java/org/apache/jci/compilers/eclipse
EclipseJavaCompiler.java
   jci/src/java/org/apache/jci/compilers/groovy
GroovyJavaCompiler.java
   jci/src/java/org/apache/jci/monitor AlterationListener.java
AlterationMonitor.java Test.java
   jci/src/java/org/apache/jci/problems CompilationProblem.java
CompilationProblemHandler.java
ConsoleCompilationProblemHandler.java
   jci/src/java/org/apache/jci/readers FileResourceReader.java
ResourceReader.java
   jci/src/java/org/apache/jci/stores FileResourceStore.java
MemoryResourceStore.java ResourceStore.java
TransactionalResourceStore.java
  Log:
  initial import from cocoon-trunk
  
  Revision  ChangesPath
  1.1  jakarta-commons-sandbox/javaflow/.classpath
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/.classpath?rev=1.1
  
  
  1.1  jakarta-commons-sandbox/javaflow/.project
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/.project?rev=1.1
  
  
  1.1  jakarta-commons-sandbox/javaflow/LICENSE.txt
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/LICENSE.txt?rev=1.1
  
  
  1.1  jakarta-commons-sandbox/javaflow/TODO
  
  http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/TODO?rev=1.1
  
  
  1.1  jakarta-commons-sandbox/javaflow/project.properties
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/project.properties?rev=1.1
  
  
  1.1  jakarta-commons-sandbox/javaflow/project.xml
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/project.xml?rev=1.1
  
  
  1.1  
jakarta-commons-sandbox/javaflow/lib/jakarta-bcel-20040329.jar
  
<>
  
  
  1.1  jakarta-commons-sandbox/javaflow/lib/jci-20041213.jar
  
<>
  
  
  1.1  
jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ClassTransformer.java
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ClassTransformer.java?rev=1.1
  
  
  1.1  
jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/Continuable.java
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/Continuable.java?rev=1.1
  
  
  1.1  
jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/Continuation.java
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/Continuation.java?rev=1.1
  
  
  1.1  
jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ContinuationCapable.java
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ContinuationCapable.java?rev=1.1
  
  
  1.1  
jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ContinuationClassLoader.java
  
  
http://cvs.apache.org/viewcvs/jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow/ContinuationClassLoader.java?rev=1.1
  
  
  1.1  

cvs commit: jakarta-commons/collections RELEASE-NOTES.html project.xml

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:53:48

  Modified:collections RELEASE-NOTES.html project.xml
  Log:
  Year 2005
  
  Revision  ChangesPath
  1.74  +1 -1  jakarta-commons/collections/RELEASE-NOTES.html
  
  Index: RELEASE-NOTES.html
  ===
  RCS file: /home/cvs/jakarta-commons/collections/RELEASE-NOTES.html,v
  retrieving revision 1.73
  retrieving revision 1.74
  diff -u -r1.73 -r1.74
  --- RELEASE-NOTES.html24 Dec 2004 11:10:24 -  1.73
  +++ RELEASE-NOTES.html3 Jan 2005 23:53:48 -   1.74
  @@ -1,5 +1,5 @@

cvs commit: jakarta-commons/collections/src/java/org/apache/commons/collections/list TreeList.java

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:52:49

  Modified:collections/src/java/org/apache/commons/collections/bidimap
TreeBidiMap.java
   collections/src/java/org/apache/commons/collections/map
AbstractInputCheckedMapDecorator.java
   collections/src/java/org/apache/commons/collections/list
TreeList.java
  Log:
  Javadoc
  bug 31519, from Olaf Krische
  
  Revision  ChangesPath
  1.16  +5 -5  
jakarta-commons/collections/src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java
  
  Index: TreeBidiMap.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/bidimap/TreeBidiMap.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- TreeBidiMap.java  12 Nov 2004 00:02:58 -  1.15
  +++ TreeBidiMap.java  3 Jan 2005 23:52:49 -   1.16
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2001-2004 The Apache Software Foundation
  + *  Copyright 2001-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -1376,7 +1376,7 @@
* Compares for equals as per the API.
*
* @param obj  the object to compare to
  - * @param index  the KEY or VALUE int
  + * @param type  the KEY or VALUE int
* @return true if equal
*/
   private boolean doEquals(Object obj, final int type) {
  @@ -1412,7 +1412,7 @@
   /**
* Gets the hash code value for this map as per the API.
*
  - * @param index  the KEY or VALUE int
  + * @param type  the KEY or VALUE int
* @return the hash code value for this map
*/
   private int doHashCode(final int type) {
  @@ -1430,7 +1430,7 @@
   /**
* Gets the string form of this map as per AbstractMap.
*
  - * @param index  the KEY or VALUE int
  + * @param type  the KEY or VALUE int
* @return the string form of this map
*/
   private String doToString(final int type) {
  
  
  
  1.3   +3 -3  
jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractInputCheckedMapDecorator.java
  
  Index: AbstractInputCheckedMapDecorator.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/map/AbstractInputCheckedMapDecorator.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- AbstractInputCheckedMapDecorator.java 21 May 2004 22:01:04 -  
1.2
  +++ AbstractInputCheckedMapDecorator.java 3 Jan 2005 23:52:49 -   
1.3
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2004 The Apache Software Foundation
  + *  Copyright 2004-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -88,7 +88,7 @@
* 
* This implementation returns true.
* 
  - * @param value  the value to check
  + * @return true always
*/
   protected boolean isSetValueChecking() {
   return true;
  
  
  
  1.4   +2 -4  
jakarta-commons/collections/src/java/org/apache/commons/collections/list/TreeList.java
  
  Index: TreeList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/collections/src/java/org/apache/commons/collections/list/TreeList.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- TreeList.java 26 May 2004 21:56:05 -  1.3
  +++ TreeList.java 3 Jan 2005 23:52:49 -   1.4
  @@ -1,5 +1,5 @@
   /*
  - *  Copyright 2004 The Apache Software Foundation
  + *  Copyright 2004-2005 The Apache Software Foundation
*
*  Licensed under the Apache License, Version 2.0 (the "License");
*  you may not use this file except in compliance with the License.
  @@ -762,8 +762,6 @@
* #previous()}. Set to null if [EMAIL PROTECTED] 
#next()} or [EMAIL PROTECTED]
* #previous()} haven't been called, or if the node has been removed
* with [EMAIL PROTECTED] #remove()} or a new node added with [EMAIL 
PROTECTED] #add(Object)}.
  - * Should be accessed through [EMAIL PROTECTED] 
#getLastNodeReturned()} to enforce
  - * this behaviour.
*/
   protected AVLNode current;
   /**
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/collections project.xml

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:51:41

  Modified:collections project.xml
  Log:
  Remove nagoya references
  
  Revision  ChangesPath
  1.48  +2 -2  jakarta-commons/collections/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-commons/collections/project.xml,v
  retrieving revision 1.47
  retrieving revision 1.48
  diff -u -r1.47 -r1.48
  --- project.xml   12 Nov 2004 00:02:59 -  1.47
  +++ project.xml   3 Jan 2005 23:51:41 -   1.48
  @@ -57,13 +57,13 @@
 Commons Dev List
 [EMAIL PROTECTED]
 [EMAIL PROTECTED]
  -  http://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]
  +  http://mail-archives.apache.org/eyebrowse/[EMAIL 
PROTECTED]
   
   
 Commons User List
 [EMAIL PROTECTED]
 [EMAIL PROTECTED]
  -  http://nagoya.apache.org/eyebrowse/[EMAIL PROTECTED]
  +  http://mail-archives.apache.org/eyebrowse/[EMAIL 
PROTECTED]
   
 
   
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java/org - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src/java - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src/java - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/jci/src - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:50:06

  jakarta-commons-sandbox/jci/src - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/bin/org - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/bin/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/bin/org/apache/javaflow/analyser - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/bin/org/apache/javaflow/analyser - New 
directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/bin/org/apache - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/bin/org/apache - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src/java/org/apache/javaflow - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27659] - [io] FilenameUtils.catPath shouldn't use the system separator

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27659


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 00:42 ---
This method has been completely rewritten.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 30604] - [primitives] ArrayIntList.addAll() performance is terrible

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30604





--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 00:41 ---
(In reply to comment #4)
> Thanks. Your patch was in reverse however (it tried to remove the methods from
> CVS, whereas you needed your patch to add them - note the minus signs which
> needed to be plus signs). Anyway, patch applied.

Sorry about that; glad to help, though.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 31528] - [primitives] Initialize ArrayIntList with int[]

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=31528


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 00:41 ---
Constructors added to Array*List classes.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src/java - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src/java - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow/src/java/org - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow/src/java/org - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons-sandbox/javaflow - New directory

2005-01-03 Thread tcurdt
tcurdt  2005/01/03 15:41:31

  jakarta-commons-sandbox/javaflow - New directory

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/primitives/src/test/org/apache/commons/collections/primitives TestArrayDoubleList.java TestArrayIntList.java TestArrayBooleanList.java TestArrayCharList.java TestArrayLongList.java TestArrayShortList.java TestArrayByteList.java TestArrayFloatList.java

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:41:05

  Modified:primitives/src/java/org/apache/commons/collections/primitives
ArrayFloatList.java ArrayShortList.java
ArrayDoubleList.java ArrayCharList.java
ArrayByteList.java ArrayBooleanList.java
ArrayIntList.java ArrayLongList.java
   primitives/src/test/org/apache/commons/collections/primitives
TestArrayDoubleList.java TestArrayIntList.java
TestArrayBooleanList.java TestArrayCharList.java
TestArrayLongList.java TestArrayShortList.java
TestArrayByteList.java TestArrayFloatList.java
  Log:
  Add array based constructor
  bug 31528
  
  Revision  ChangesPath
  1.7   +13 -1 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayFloatList.java
  
  Index: ArrayFloatList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayFloatList.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ArrayFloatList.java   3 Jan 2005 23:20:42 -   1.6
  +++ ArrayFloatList.java   3 Jan 2005 23:41:04 -   1.7
  @@ -69,6 +69,18 @@
   addAll(that);
   }
   
  +/**
  + * Constructs a list by copying the specified array.
  + * 
  + * @param array  the array to initialize the collection with
  + * @throws NullPointerException if the array is null
  + */
  +public ArrayFloatList(float[] array) { 
  +this(array.length);
  +System.arraycopy(array, 0, _data, 0, array.length);
  +_size = array.length;
  +}
  +
   // FloatList methods
   
//-
   
  
  
  
  1.7   +13 -1 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayShortList.java
  
  Index: ArrayShortList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayShortList.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ArrayShortList.java   3 Jan 2005 23:20:42 -   1.6
  +++ ArrayShortList.java   3 Jan 2005 23:41:04 -   1.7
  @@ -69,6 +69,18 @@
   addAll(that);
   }
   
  +/**
  + * Constructs a list by copying the specified array.
  + * 
  + * @param array  the array to initialize the collection with
  + * @throws NullPointerException if the array is null
  + */
  +public ArrayShortList(short[] array) { 
  +this(array.length);
  +System.arraycopy(array, 0, _data, 0, array.length);
  +_size = array.length;
  +}
  +
   // ShortList methods
   
//-
   
  
  
  
  1.7   +13 -1 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayDoubleList.java
  
  Index: ArrayDoubleList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayDoubleList.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ArrayDoubleList.java  3 Jan 2005 23:20:42 -   1.6
  +++ ArrayDoubleList.java  3 Jan 2005 23:41:04 -   1.7
  @@ -69,6 +69,18 @@
   addAll(that);
   }
   
  +/**
  + * Constructs a list by copying the specified array.
  + * 
  + * @param array  the array to initialize the collection with
  + * @throws NullPointerException if the array is null
  + */
  +public ArrayDoubleList(double[] array) { 
  +this(array.length);
  +System.arraycopy(array, 0, _data, 0, array.length);
  +_size = array.length;
  +}
  +
   // DoubleList methods
   
//-
   
  
  
  
  1.7   +13 -1 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayCharList.java
  
  Index: ArrayCharList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayCharList.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ArrayCharList.java3 Jan 2005 23:20:42 -   1.6
  +++ ArrayCharList.java3 Jan 2005 23:41:04 -   1.7
  @@ -69,6 +69,18 @@
   addAll(that);
   }
   
  +/**
  + * Constructs a list by copying the specified array.
  + * 
  + * @param array  t

DO NOT REPLY [Bug 30604] - [primitives] ArrayIntList.addAll() performance is terrible

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30604


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-04 00:22 ---
Thanks. Your patch was in reverse however (it tried to remove the methods from
CVS, whereas you needed your patch to add them - note the minus signs which
needed to be plus signs). Anyway, patch applied.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives ArrayCharList.java ArrayFloatList.java ArrayByteList.java ArrayShortList.java ArrayBooleanList.java ArrayIntList.java ArrayLongList.java ArrayDoubleList.java

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:20:42

  Modified:primitives/src/java/org/apache/commons/collections/primitives
ArrayCharList.java ArrayFloatList.java
ArrayByteList.java ArrayShortList.java
ArrayBooleanList.java ArrayIntList.java
ArrayLongList.java ArrayDoubleList.java
  Log:
  Improve performance of addAll
  bug 30604, from Robert Fischer
  
  Revision  ChangesPath
  1.6   +26 -2 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayCharList.java
  
  Index: ArrayCharList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayCharList.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- ArrayCharList.java25 Feb 2004 20:46:25 -  1.5
  +++ ArrayCharList.java3 Jan 2005 23:20:42 -   1.6
  @@ -1,5 +1,5 @@
   /*
  - * Copyright 2002-2004 The Apache Software Foundation
  + * Copyright 2002-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
  @@ -155,6 +155,30 @@
   public void clear() {
   incrModCount();
   _size = 0;
  +}
  +
  +public boolean addAll(CharCollection collection) {
  +return addAll(size(), collection);
  +}
  +
  +public boolean addAll(int index, CharCollection collection) {
  +if (collection.size() == 0) {
  +return false;
  +}
  +checkRangeIncludingEndpoint(index);
  +incrModCount();
  +ensureCapacity(_size + collection.size());
  +if (index != _size) {
  +// Need to move some elements
  +System.arraycopy(_data, index, _data, index + collection.size(), 
_size - index);
  +}
  +int ptr = index;
  +for (CharIterator it = collection.iterator(); it.hasNext();) {
  +_data[index] = it.next();
  +index++;
  +}
  +_size += collection.size();
  +return true;
   }
   
   // capacity methods
  
  
  
  1.6   +26 -2 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayFloatList.java
  
  Index: ArrayFloatList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayFloatList.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- ArrayFloatList.java   25 Feb 2004 20:46:25 -  1.5
  +++ ArrayFloatList.java   3 Jan 2005 23:20:42 -   1.6
  @@ -1,5 +1,5 @@
   /*
  - * Copyright 2002-2004 The Apache Software Foundation
  + * Copyright 2002-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
  @@ -155,6 +155,30 @@
   public void clear() {
   incrModCount();
   _size = 0;
  +}
  +
  +public boolean addAll(FloatCollection collection) {
  +return addAll(size(), collection);
  +}
  +
  +public boolean addAll(int index, FloatCollection collection) {
  +if (collection.size() == 0) {
  +return false;
  +}
  +checkRangeIncludingEndpoint(index);
  +incrModCount();
  +ensureCapacity(_size + collection.size());
  +if (index != _size) {
  +// Need to move some elements
  +System.arraycopy(_data, index, _data, index + collection.size(), 
_size - index);
  +}
  +int ptr = index;
  +for (FloatIterator it = collection.iterator(); it.hasNext();) {
  +_data[index] = it.next();
  +index++;
  +}
  +_size += collection.size();
  +return true;
   }
   
   // capacity methods
  
  
  
  1.6   +26 -2 
jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayByteList.java
  
  Index: ArrayByteList.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/primitives/src/java/org/apache/commons/collections/primitives/ArrayByteList.java,v
  retrieving revision 1.5
  retrieving revision 1.6
  diff -u -r1.5 -r1.6
  --- ArrayByteList.java25 Feb 2004 20:46:25 -  1.5
  +++ ArrayByteList.java3 Jan 2005 23:20:42 -   1.6
  @@ -1,5 +1,5 @@
   /*
  - * Copyright 2002-2004 The Apache Software Foundation
  + * Copyright 2002-2005 The Apache Software Foundation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
  @@ -157,6 +157,30 @@
 

cvs commit: jakarta-commons/primitives project.xml

2005-01-03 Thread scolebourne
scolebourne2005/01/03 15:18:11

  Modified:primitives project.xml
  Log:
  Remove nagoya references, add Robert Fischer
  
  Revision  ChangesPath
  1.20  +6 -3  jakarta-commons/primitives/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-commons/primitives/project.xml,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- project.xml   29 Jul 2004 22:30:55 -  1.19
  +++ project.xml   3 Jan 2005 23:18:11 -   1.20
  @@ -1,6 +1,6 @@
   
   

DO NOT REPLY [Bug 30604] - [primitives] ArrayIntList.addAll() performance is terrible

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30604


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #13855|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 22:18 ---
Created an attachment (id=13881)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=13881&action=view)
Diff -ub of patch to fix this problem

Still hasn't been tested with the jUnit tests, but now it's in the requested
format.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [logging] Enterprise Common Logging... dare we say 2.0?

2005-01-03 Thread robert burrell donkin
On 3 Jan 2005, at 17:03, Ceki Gülcü wrote:
At 05:53 PM 1/3/2005, robert burrell donkin wrote:
nope (but don't ask me to find the references). distributing an api 
jar which requires runtime dependencies was a mistake. this issue 
hasn't arisen for quite a while since we try to keep quiet about the 
existing of the api jar.
I do not understand. How can JCL *not* require runtime dependencies 
given that it is a wrapper around various logging APIs? In other 
words, how can JCL wrap API x without runtime dependencies on API x?
a minimal core should have robust behaviour when deployed without any 
support (rather than die horribly). for example, IIRC log4j prints up a 
message to System.err and then silently swallows all messages when it 
cannot configure itself.

JCL core should do something similar (though i'd advocate logging fatal 
- and possibly error level messages - to System.err for the reasons 
explained well in james strachan's blog 
http://radio.weblogs.com/0112098/2004/10/06.html).

- robert
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 32350] - [chain] Consider making lookup commands default to same chain

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32350





--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 20:48 ---
I'm looking at this again in light of one of my teammates getting hung up on the
same issue in upgrading a Struts app to use the newer forms of chain.  I've had
an idea which I might as well float.

We could add an interface, "CatalogAware", which simply specifies a setCatalog
method.  CatalogBase could test commands when they are added and call
setCatalog(this) for any commands which implement the interface.

Not glamorous, but I think it'd do the job.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



[PATCH] 32925: XML Rule for stack param takes useless boolean instead of int as arg

2005-01-03 Thread Blake Meike
Posted to developer's group, per instructions.  This patch is attached
to the bug, as well.

Blake Meike



--- DigesterRuleParser.java.origMon Jan  3 13:16:10 2005
+++ DigesterRuleParser.java Mon Jan  3 13:16:25 2005
@@ -578,7 +578,7 @@
 
 } else {
 
-callParamRule = new CallParamRule( paramIndex,
Boolean.valueOf(fromStack).booleanValue());
+callParamRule = new CallParamRule( paramIndex,
Integer.parseInt(fromStack));
 
 }
 } else {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32925] - [digester] XML Rule for stack param takes useless boolean instead of int arg

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32925


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|XML Rule for stack param|[digester] XML Rule for
   |takes useless boolean   |stack param takes useless
   |instead of int arg  |boolean instead of int arg




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32318] - [configuration] Implement Java 5.0 XML properties

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32318


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 19:35 ---
XMLPropertiesConfiguration is now in CVS! It doesn't support included
configurations. Configuration has to be modified to support this new
configuration, I suggest switching to XMLPropertiesConfiguration when the
fileName attribute of the  element points to an XML file.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration XMLPropertiesConfiguration.java

2005-01-03 Thread ebourg
ebourg  2005/01/03 10:32:47

  Modified:configuration/xdocs changes.xml
   configuration project.xml
  Added:   configuration/conf properties.dtd test.properties.xml
   configuration/src/test/org/apache/commons/configuration
TestXMLPropertiesConfiguration.java
   configuration/src/java/org/apache/commons/configuration
XMLPropertiesConfiguration.java
  Log:
  Added XMLPropertiesConfiguration to support the new XML format for 
java.util.Properties introduced in Java 1.5
  
  Revision  ChangesPath
  1.81  +5 -0  jakarta-commons/configuration/xdocs/changes.xml
  
  Index: changes.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/changes.xml,v
  retrieving revision 1.80
  retrieving revision 1.81
  diff -u -r1.80 -r1.81
  --- changes.xml   3 Jan 2005 16:51:29 -   1.80
  +++ changes.xml   3 Jan 2005 18:32:46 -   1.81
  @@ -8,6 +8,11 @@
 
   
   
  +  
  +Added a new configuration, XMLPropertiesConfiguration, supporting the
  +new XML format for java.util.Properties introduced in Java 1.5.
  +A 1.5 runtime is not required to use this class.
  +  
 
   Added a comment header to PropertiesConfiguration. The header is not
   parsed when the file is loaded yet.
  
  
  
  1.42  +6 -2  jakarta-commons/configuration/project.xml
  
  Index: project.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/project.xml,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- project.xml   1 Jan 2005 14:02:16 -   1.41
  +++ project.xml   3 Jan 2005 18:32:46 -   1.42
  @@ -60,6 +60,7 @@
   scm:cvs:pserver:[EMAIL 
PROTECTED]:/home/cvspublic:jakarta-commons/${pom.artifactId.substring(8)}
   
http://cvs.apache.org/viewcvs/jakarta-commons/${pom.artifactId.substring(8)}/
 
  +
 
   
 1.0-rc1
  @@ -77,6 +78,7 @@
 CONFIGURATION_1_0
   
 
  +
 
   
 Commons Dev List
  @@ -357,7 +359,7 @@
   
   
 
  -**/Test*.java
  +**/*Test*.java
 
 
   **/TestBasePropertiesConfiguration.java
  @@ -377,6 +379,7 @@
   testClasspath.properties
   testdb.script
   *.properties
  +*.dtd
 
   
   
  @@ -402,6 +405,7 @@
   conf
   
 digesterRules.xml
  +  properties.dtd
   
 
   
  
  
  
  1.1  jakarta-commons/configuration/conf/properties.dtd
  
  Index: properties.dtd
  ===
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  
  1.1  jakarta-commons/configuration/conf/test.properties.xml
  
  Index: test.properties.xml
  ===
  
  http://java.sun.com/dtd/properties.dtd";>
  
Description of the property list
value1
value2
value3
  
  
  
  
  1.1  
jakarta-commons/configuration/src/test/org/apache/commons/configuration/TestXMLPropertiesConfiguration.java
  
  Index: TestXMLPropertiesConfiguration.java
  ===
  /*
   * Copyright 2004 The Apache Software Foundation.
   *
   * Licensed under the Apache License, Version 2.0 (the "License")
   * you may not use this file except in compliance with the License.
   * You may obtain a copy of the License at
   *
   * http://www.apache.org/licenses/LICENSE-2.0
   *
   * Unless required by applicable law or agreed to in writing, software
   * distributed under the License is distributed on an "AS IS" BASIS,
   * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   * See the License for the specific language governing permissions and
   * limitations under the License.
   */
  
  package org.apache.commons.configuration;
  
  import junit.framework.TestCase;
  
  /**
   * @author Emmanuel Bourg
   * @version $Revision: 1.1 $, $Date: 2005/01/03 18:32:46 $
   */
  public class TestXMLPropertiesConfiguration extends TestCase
  {
  public void testLoad() throws Exception
  {
  XMLPropertiesConfiguration conf = new 
XMLPropertiesConfiguration("test.properties.xml");
  
  assertEquals("header", "Description of the property list", 
conf.getHeader());
  
  assertFalse("The configuration is empty", conf.isEmpty());
  assertEquals("'key1' property", "value1", conf.getProperty("key1"));
  assertEquals("'key2' property", "value2", conf.getProperty("key2"));
  assertEquals("'key3' property", "value3", conf.getProperty("key3"));
  }
  
  public vo

DO NOT REPLY [Bug 32925] - XML Rule for stack param takes useless boolean instead of int arg

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32925





--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 19:30 ---
Created an attachment (id=13880)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=13880&action=view)
Trivial fix

Trivial fix.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32925] New: - XML Rule for stack param takes useless boolean instead of int arg

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32925

   Summary: XML Rule for stack param takes useless boolean instead
of int arg
   Product: Commons
   Version: 1.6 Final
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Digester
AssignedTo: commons-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


The XML version of a method parameter rule, to take an argument from the stack,
takes a boolean "true" or "false" as argument.  This means that it is possible,
only, to specify the top of the stack as a parameter.  Since the eventual method
call is always made to the object on top of the stack, this is particularly
useless.  If the argument were, instead, an integer specifying the stack offset,
the XML rule creation would have the same functionality as the programatic 
analogue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [logging] Enterprise Common Logging... dare we say 2.0?

2005-01-03 Thread Ceki Gülcü
At 05:53 PM 1/3/2005, robert burrell donkin wrote:
nope (but don't ask me to find the references). distributing an api jar 
which requires runtime dependencies was a mistake. this issue hasn't 
arisen for quite a while since we try to keep quiet about the existing of 
the api jar.
I do not understand. How can JCL *not* require runtime dependencies given 
that it is a wrapper around various logging APIs? In other words, how can 
JCL wrap API x without runtime dependencies on API x?


- robert
--
Ceki Gülcü
  The complete log4j manual: http://www.qos.ch/log4j/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 26092] - [configuration] .properties header

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26092


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 17:53 ---
I applied the patch, the header is not parsed yet when the file is loaded.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: [logging] Enterprise Common Logging... dare we say 2.0?

2005-01-03 Thread robert burrell donkin
On 3 Jan 2005, at 16:25, Ceki Gülcü wrote:
At 09:23 PM 1/2/2005, robert burrell donkin wrote:
i'm in definitely agreement with craig's assessment (a long while 
ago) that one of the fundamental flaws with the current JCL is that 
we ship an unusable API distribution with runtime dependencies.
Robert,
Are you by any chance referring to Craig's comments [1] on the
"commons-logging & classloading" thread [2]?
nope (but don't ask me to find the references). distributing an api jar 
which requires runtime dependencies was a mistake. this issue hasn't 
arisen for quite a while since we try to keep quiet about the existing 
of the api jar.

- robert
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


cvs commit: jakarta-commons/configuration/src/java/org/apache/commons/configuration PropertiesConfiguration.java

2005-01-03 Thread ebourg
ebourg  2005/01/03 08:51:29

  Modified:configuration/xdocs changes.xml
   configuration/src/java/org/apache/commons/configuration
PropertiesConfiguration.java
  Log:
  Added a comment header to PropertiesConfiguration (bug 26092).
  The header is not parsed when the file is loaded yet.
  
  Revision  ChangesPath
  1.80  +4 -0  jakarta-commons/configuration/xdocs/changes.xml
  
  Index: changes.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/changes.xml,v
  retrieving revision 1.79
  retrieving revision 1.80
  diff -u -r1.79 -r1.80
  --- changes.xml   3 Jan 2005 16:35:04 -   1.79
  +++ changes.xml   3 Jan 2005 16:51:29 -   1.80
  @@ -8,6 +8,10 @@
 
   
   
  +  
  +Added a comment header to PropertiesConfiguration. The header is not
  +parsed when the file is loaded yet.
  +  
 
   Added the setEncoding(String) and the getEncoding() methods to the
   FileConfiguration interface to control the encoding of the
  
  
  
  1.19  +40 -3 
jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java
  
  Index: PropertiesConfiguration.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- PropertiesConfiguration.java  3 Jan 2005 11:58:46 -   1.18
  +++ PropertiesConfiguration.java  3 Jan 2005 16:51:29 -   1.19
  @@ -22,6 +22,8 @@
   import java.io.LineNumberReader;
   import java.io.Reader;
   import java.io.Writer;
  +import java.io.StringReader;
  +import java.io.BufferedReader;
   import java.net.URL;
   import java.util.Date;
   import java.util.Iterator;
  @@ -141,6 +143,9 @@
   /** Allow file inclusion or not */
   private boolean includesAllowed = true;
   
  +/** Comment header of the .properties file */
  +private String header;
  +
   /**
* Creates an empty PropertyConfiguration object which can be
* used to synthesize a new Properties file by adding values and
  @@ -237,6 +242,26 @@
   }
   
   /**
  + * Return the comment header.
  + *
  + * @since 1.1
  + */
  +public String getHeader()
  +{
  +return header;
  +}
  +
  +/**
  + * Set the comment header.
  + *
  + * @since 1.1
  + */
  +public void setHeader(String header)
  +{
  +this.header = header;
  +}
  +
  +/**
* Load the properties from the given input stream and using the 
specified
* encoding.
*
  @@ -306,8 +331,20 @@
   {
   PropertiesWriter out = new PropertiesWriter(writer, 
getDelimiter());
   
  +if (header != null)
  +{
  +BufferedReader reader = new BufferedReader(new 
StringReader(header));
  +String line;
  +while ((line = reader.readLine()) != null)
  +{
  +out.writeComment(line);
  +}
  +out.write("\n");
  +}
  +
   out.writeComment("written by PropertiesConfiguration");
   out.writeComment(new Date().toString());
  +out.write("\n");
   
   Iterator keys = getKeys();
   while (keys.hasNext())
  @@ -387,8 +424,8 @@
   
   line = line.trim();
   
  -if (StringUtils.isEmpty(line)
  -|| (line.charAt(0) == '#'))
  +// skip comments and empty lines
  +if (StringUtils.isEmpty(line) || (line.charAt(0) == '#'))
   {
   continue;
   }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/configuration/src/test-cactus/org/apache/commons/configuration TestConfigurationFactoryWithJNDI.java TestJNDIAndCompositeConfiguration.java

2005-01-03 Thread ebourg
ebourg  2005/01/03 08:35:05

  Modified:configuration/xdocs changes.xml
   configuration/src/test/org/apache/commons/configuration
MockStaticMemoryInitialContextFactory.java
TestBaseNullConfiguration.java
TestCompositeConfigurationNonStringProperties.java
TestConfigurationFactory.java
TestDatabaseConfiguration.java
TestNonStringProperties.java
TestXMLConfiguration.java
   configuration/src/test-cactus/org/apache/commons/configuration
TestConfigurationFactoryWithJNDI.java
TestJNDIAndCompositeConfiguration.java
  Log:
  Tabulations removal
  
  Revision  ChangesPath
  1.79  +27 -27jakarta-commons/configuration/xdocs/changes.xml
  
  Index: changes.xml
  ===
  RCS file: /home/cvs/jakarta-commons/configuration/xdocs/changes.xml,v
  retrieving revision 1.78
  retrieving revision 1.79
  diff -u -r1.78 -r1.79
  --- changes.xml   3 Jan 2005 12:42:31 -   1.78
  +++ changes.xml   3 Jan 2005 16:35:04 -   1.79
  @@ -13,26 +13,26 @@
   FileConfiguration interface to control the encoding of the
   configuration file.
 
  -   
  - Access to the top leven element of the XML document is now 
provided. For
  - newly created configurations this element can be changed before 
the
  - document is written.
  -   
  -   
  - Merged the two XML related configuration classes into one new 
class
  - XMLConfiguration. This new class should provide the best of its
  - ancestors.
  -   
  +  
  +Access to the top leven element of the XML document is now provided. 
For
  +newly created configurations this element can be changed before the
  +document is written.
  +  
  +  
  +Merged the two XML related configuration classes into one new class
  +XMLConfiguration. This new class should provide the best of its
  +ancestors.
  +  
 
   Replaced the PropertyTokenizer inner class in AbstractConfiguration
   with the split method in PropertyConverter. Also moved the method
   building an iterator on the elements of a composite value in
   PropertyConverter as toIterator().
 
  -   
  - Some cleanup of the handling of the base path in file based 
configurations.
  - The base path is now always taken into account.
  -   
  +  
  +Some cleanup of the handling of the base path in file based 
configurations.
  +The base path is now always taken into account.
  +  
 
   Calling getProperties on a JNDIConfiguration no longer throws an
   UnsupportedOperationException.
  @@ -42,9 +42,9 @@
   concrete configurations now implement directly the getProperty method
   from the Configuration interface.
 
  -   
  - Added implementation of a save() method for 
HierarchicalXMLConfiguration.
  -   
  +  
  +Added implementation of a save() method for 
HierarchicalXMLConfiguration.
  +  
 
   Constructing a file based configuration with a File no longer throws
   an exception when the file doesn't exist.
  @@ -61,15 +61,15 @@
   This fixes a bug preventing configuration files from being found if
   the configuration descriptor is in a JAR file (reported by Grant 
Ingersoll).
 
  -   
  - Fixed NPE that were caused in the constructors of file based
  - configurations if an invalid file name was specified.
  -   
  -   
  - Added support for optional configuration sources in definition 
files for
  - ConfigurationFactory. A new optional attribute allows to 
specify whether a
  - configuration source is mandatory or optional.
  -   
  +  
  +Fixed NPE that were caused in the constructors of file based
  +configurations if an invalid file name was specified.
  +  
  +  
  +Added support for optional configuration sources in definition files 
for
  +ConfigurationFactory. A new optional attribute allows to specify 
whether a
  +configuration source is mandatory or optional.
  +  
 
   JNDIConfiguration.getKeys() now returns an empty iterator instead of
   throwing a ConfigurationRuntimeException when a NamingException 
occurs.
  @@ -244,7 +244,7 @@
 
   ConfigurationXMLDocument removed until post 1.0.
 
  -   
  +  
   DatabaseConfiguration doesn't support List properties.
 
 
  
  
  
  1.2   +2 -2

Re: [logging] Enterprise Common Logging... dare we say 2.0?

2005-01-03 Thread Ceki Gülcü
At 09:23 PM 1/2/2005, robert burrell donkin wrote:
i'm in definitely agreement with craig's assessment (a long while ago) 
that one of the fundamental flaws with the current JCL is that we ship an 
unusable API distribution with runtime dependencies.
Robert,
Are you by any chance referring to Craig's comments [1] on the
"commons-logging & classloading" thread [2]?
[1] http://marc.theaimsgroup.com/?l=jakarta-commons-dev&m=106608349829350&w=2
[2] http://marc.theaimsgroup.com/?t=10632904081&r=1&w=2

- robert
--
Ceki Gülcü
  The complete log4j manual: http://www.qos.ch/log4j/

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: test

2005-01-03 Thread robert burrell donkin
very low but it does seem like it's working. AFAIK no problems reported 
on infrastructure.

- robert
On 3 Jan 2005, at 07:30, Chris Lambrou wrote:
Works for me. Not a lot of traffic, though.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


DO NOT REPLY [Bug 32860] - [configuration] Saving back the changed configuration

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32860





--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 15:44 ---
Sagar,

this seems to be a valid request. Unfortunately, the way CompositeConfiguration
is implemented at the moment makes it really difficult to implement such a
feature. We plan to refactor this class, and then we can think about a solution.

As a workaround: Is it possible to access the configurations contained in the
composite directly (using the getConfiguration(int index) method) and make the
changes there?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 32799] - [configuration] HierarchicalXMLConfiguration: Phantom-Keys with ...[@xml:base] when using nested XML-Files

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32799


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 15:31 ---
Some more information about xml:base attributes can be found e.g. here:
http://xml.apache.org/xerces2-j/faq-xinclude.html or here:
www.w3.org/TR/xmlbase/

They are obviously important parts of specifications like XLink or XInclude,
which indicates that they indeed should be treated as normal attributes and kept
in the set of configuration properties.

As another workaround to your problem: Would it be possible to avoid the direct
include in your XML document and instead use a ConfigurationFactory that reads
the two XML documents from its definition file? If you place these files inside
an  section, a HierarchicalConfiguration will be constructed with
the union of both documents.

If this doesn't help, there is an enhancement request to provide a filter
decorator (Issue 31281). This should be a solution because it would allow to
transparently filter out the undesired attributes.

Anyway, I am marking this bug as Wontfix because there is nothing we can do
about these attributes directly.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 27998] - [daemon] jsvc compile failed due to Unsupported CPU architecture

2005-01-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=27998


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WORKSFORME




--- Additional Comments From [EMAIL PROTECTED]  2005-01-03 14:57 ---
Without help or access to such a machine no chances to fix the problem.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



cvs commit: jakarta-commons/configuration/xdocs changes.xml

2005-01-03 Thread ebourg
ebourg  2005/01/03 04:42:31

  Modified:configuration/src/java/org/apache/commons/configuration
AbstractFileConfiguration.java
FileConfiguration.java XMLConfiguration.java
   configuration/xdocs changes.xml
  Log:
  Added the setEncoding(String) and the getEncoding() methods to the 
FileConfiguration interface to control the encoding of the configuration file.
  
  Revision  ChangesPath
  1.13  +20 -8 
jakarta-commons/configuration/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java
  
  Index: AbstractFileConfiguration.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/AbstractFileConfiguration.java,v
  retrieving revision 1.12
  retrieving revision 1.13
  diff -u -r1.12 -r1.13
  --- AbstractFileConfiguration.java4 Dec 2004 15:45:40 -   1.12
  +++ AbstractFileConfiguration.java3 Jan 2005 12:42:30 -   1.13
  @@ -59,8 +59,7 @@
* @version $Revision$, $Date$
* @since 1.0-rc2
*/
  -public abstract class AbstractFileConfiguration extends BaseConfiguration 
implements
  -FileConfiguration
  +public abstract class AbstractFileConfiguration extends BaseConfiguration 
implements FileConfiguration
   {
   protected String fileName;
   
  @@ -72,6 +71,8 @@
   
   private Object reloadLock = new Object();
   
  +private String encoding;
  +
   /**
* Default constructor
*
  @@ -240,8 +241,8 @@
   }
   
   /**
  - * Load the configuration from the specified stream, using the default
  - * platform specific encoding.
  + * Load the configuration from the specified stream, using the encoding
  + * returned by [EMAIL PROTECTED] #getEncoding()}.
*
* @param in the input stream
*
  @@ -249,7 +250,7 @@
*/
   public void load(InputStream in) throws ConfigurationException
   {
  -load(in, null);
  +load(in, getEncoding());
   }
   
   /**
  @@ -382,7 +383,8 @@
   }
   
   /**
  - * Save the configuration to the specified stream.
  + * Save the configuration to the specified stream, using the encoding
  + * returned by [EMAIL PROTECTED] #getEncoding()}.
*
* @param out
*
  @@ -390,7 +392,7 @@
*/
   public void save(OutputStream out) throws ConfigurationException
   {
  -save(out, null);
  +save(out, getEncoding());
   }
   
   /**
  @@ -654,5 +656,15 @@
   }
   }
   }
  +}
  +
  +public String getEncoding()
  +{
  +return encoding;
  +}
  +
  +public void setEncoding(String encoding)
  +{
  +this.encoding = encoding;
   }
   }
  
  
  
  1.4   +21 -4 
jakarta-commons/configuration/src/java/org/apache/commons/configuration/FileConfiguration.java
  
  Index: FileConfiguration.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/FileConfiguration.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- FileConfiguration.java18 Oct 2004 15:45:10 -  1.3
  +++ FileConfiguration.java3 Jan 2005 12:42:30 -   1.4
  @@ -70,8 +70,8 @@
   void load(URL url) throws ConfigurationException;
   
   /**
  - * Load the configuration from the specified stream, using the default
  - * platform specific encoding.
  + * Load the configuration from the specified stream, using the encoding
  + * returned by [EMAIL PROTECTED] #getEncoding()}.
*
* @param in the input stream
*
  @@ -134,7 +134,8 @@
   void save(URL url) throws ConfigurationException;
   
   /**
  - * Save the configuration to the specified stream.
  + * Save the configuration to the specified stream, using the encoding
  + * returned by [EMAIL PROTECTED] #getEncoding()}.
*
* @param out
*
  @@ -245,5 +246,21 @@
* @since 1.1
*/
   void reload();
  +
  +/**
  + * Return the encoding used to store the configuration file. If the value
  + * is null the default encoding is used.
  + *
  + * @since 1.1
  + */
  +String getEncoding();
  +
  +/**
  + * Set the encoding used to store the configuration file. Set the 
encoding
  + * to null to use the default encoding.
  + *
  + * @since 1.1
  + */
  +void setEncoding(String encoding);
   
   }
  
  
  
  1.22  +11 -1 
jakarta-commons/configuration/src/java/org/apache/commons/configuration/XMLConfiguration.java
  
  Index: XMLConfiguration.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/configuration/sr

cvs commit: jakarta-commons/configuration/src/test/org/apache/commons/configuration TestPropertiesConfiguration.java

2005-01-03 Thread ebourg
ebourg  2005/01/03 03:58:46

  Modified:configuration/src/java/org/apache/commons/configuration
PropertiesConfiguration.java
   configuration/src/test/org/apache/commons/configuration
TestPropertiesConfiguration.java
  Log:
  Changed PropertyWriter and unescapeJava to make them independant from the 
static delimiter. This will allow instance specific delimiters.
  
  Revision  ChangesPath
  1.18  +16 -13
jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java
  
  Index: PropertiesConfiguration.java
  ===
  RCS file: 
/home/cvs/jakarta-commons/configuration/src/java/org/apache/commons/configuration/PropertiesConfiguration.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- PropertiesConfiguration.java  4 Dec 2004 15:45:40 -   1.17
  +++ PropertiesConfiguration.java  3 Jan 2005 11:58:46 -   1.18
  @@ -34,7 +34,7 @@
* This is the "classic" Properties loader which loads the values from
* a single or multiple files (which can be chained with "include =".
* All given path references are either absolute or relative to the
  - * file name supplied in the Constructor.
  + * file name supplied in the constructor.
* 
* In this class, empty PropertyConfigurations can be built, properties
* added and later saved. include statements are (obviously) not supported
  @@ -72,16 +72,16 @@
*   If a property is named "include" (or whatever is defined by
*   setInclude() and getInclude() and the value of that property is
*   the full path to a file on disk, that file will be included into
  - *   the ConfigurationsRepository. You can also pull in files relative
  - *   to the parent configuration file. So if you have something
  - *   like the following:
  + *   the configuration. You can also pull in files relative to the parent
  + *   configuration file. So if you have something like the following:
*
*   include = additional.properties
*
*   Then "additional.properties" is expected to be in the same
*   directory as the parent configuration file.
*
  - *   Duplicate name values will be replaced, so be careful.
  + *   The properties in the included file are added to the parent 
configuration,
  + *   they do not replace existing properties with the same key.
*
*  
* 
  @@ -284,7 +284,7 @@
   }
   else
   {
  -addProperty(key, unescapeJava(value));
  +addProperty(key, unescapeJava(value, 
getDelimiter()));
   }
   }
   }
  @@ -304,7 +304,7 @@
   {
   try
   {
  -PropertiesWriter out = new PropertiesWriter(writer);
  +PropertiesWriter out = new PropertiesWriter(writer, 
getDelimiter());
   
   out.writeComment("written by PropertiesConfiguration");
   out.writeComment(new Date().toString());
  @@ -413,14 +413,17 @@
*/
   public static class PropertiesWriter extends FilterWriter
   {
  +private char delimiter;
  +
   /**
* Constructor.
*
* @param writer a Writer object providing the underlying stream
*/
  -public PropertiesWriter(Writer writer) throws IOException
  +public PropertiesWriter(Writer writer, char delimiter)
   {
   super(writer);
  +this.delimiter = delimiter;
   }
   
   /**
  @@ -437,7 +440,7 @@
   if (value != null)
   {
   String v = 
StringEscapeUtils.escapeJava(String.valueOf(value));
  -v = StringUtils.replace(v, String.valueOf(getDelimiter()), 
"\\" + getDelimiter());
  +v = StringUtils.replace(v, String.valueOf(delimiter), "\\" + 
delimiter);
   write(v);
   }
   
  @@ -480,7 +483,7 @@
*
* @throws IllegalArgumentException if the Writer is null
*/
  -protected static String unescapeJava(String str)
  +protected static String unescapeJava(String str, char delimiter)
   {
   if (str == null)
   {
  @@ -548,9 +551,9 @@
   else if (ch=='b'){
   out.append('\b');
   }
  -else if (ch==getDelimiter()){
  +else if (ch==delimiter){
   out.append('\\');
  -out.append(getDelimiter());
  +out.append(delimiter);
   }
   else if (ch=='u'){
   //  uh-oh, we're in unicode country
  
  
  
  1.18  +2 -2  
jakarta-commons/configuration/src/test/org/apache/commons/configuration

  1   2   >