[jira] Commented: (BEANUTILS-284) Locale aware Converters doesn't handle conversion direction Object->String
[ https://issues.apache.org/jira/browse/BEANUTILS-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503751 ] Josef Cacek commented on BEANUTILS-284: --- Sorry for the wrong comment in source file (it was copy/paste and I've uploaded the file before saving). Comment should contain sth. like: // following code throws ConversionException, because BigDecimalLocaleConverter doesn't handle // conversion direction BigDecimal->String > Locale aware Converters doesn't handle conversion direction Object->String > --- > > Key: BEANUTILS-284 > URL: https://issues.apache.org/jira/browse/BEANUTILS-284 > Project: Commons BeanUtils > Issue Type: Bug > Components: Locale BeanUtils / Converters >Affects Versions: Nightly Builds > Environment: sources from SVN head >Reporter: Josef Cacek > Attachments: Test.java > > > Locale aware Converters doesn't handle conversion direction Object->String > according to new implementation of lookup method in ConvertUtilsBean class. > E.g. BigDecimalLocaleConverter handles conversion String->BigDecimal but not > BigDecimal->String -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (BEANUTILS-284) Locale aware Converters doesn't handle conversion direction Object->String
[ https://issues.apache.org/jira/browse/BEANUTILS-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josef Cacek updated BEANUTILS-284: -- Attachment: Test.java Sample to reproduce bug. > Locale aware Converters doesn't handle conversion direction Object->String > --- > > Key: BEANUTILS-284 > URL: https://issues.apache.org/jira/browse/BEANUTILS-284 > Project: Commons BeanUtils > Issue Type: Bug > Components: Locale BeanUtils / Converters >Affects Versions: Nightly Builds > Environment: sources from SVN head >Reporter: Josef Cacek > Attachments: Test.java > > > Locale aware Converters doesn't handle conversion direction Object->String > according to new implementation of lookup method in ConvertUtilsBean class. > E.g. BigDecimalLocaleConverter handles conversion String->BigDecimal but not > BigDecimal->String -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (BEANUTILS-284) Locale aware Converters doesn't handle conversion direction Object->String
Locale aware Converters doesn't handle conversion direction Object->String --- Key: BEANUTILS-284 URL: https://issues.apache.org/jira/browse/BEANUTILS-284 Project: Commons BeanUtils Issue Type: Bug Components: Locale BeanUtils / Converters Affects Versions: Nightly Builds Environment: sources from SVN head Reporter: Josef Cacek Attachments: Test.java Locale aware Converters doesn't handle conversion direction Object->String according to new implementation of lookup method in ConvertUtilsBean class. E.g. BigDecimalLocaleConverter handles conversion String->BigDecimal but not BigDecimal->String -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
ftp over ssl 3
I am trying to implement FTP over SSL 3.0 and i want to know * 'Does apache commons-net support FTP over SSL3?' If not, how to implement the same? If it supports then how it can be implemented? * thanx in advance...
svn commit: r546382 - in /jakarta/commons/proper/cli/branches/cli-1.0.x: build.xml project.xml
Author: bayard
Date: Mon Jun 11 22:23:16 2007
New Revision: 546382
URL: http://svn.apache.org/viewvc?view=rev&rev=546382
Log:
Preparing for 1.1 rc by changing 1.1-snapshot to 1.1
Modified:
jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml
jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml
Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml?view=diff&rev=546382&r1=546381&r2=546382
==
--- jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml (original)
+++ jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml Mon Jun 11 22:23:16
2007
@@ -1,44 +1,32 @@
-
+
-
-
-
-
-
-
-
-
-
-
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
+
-
-
-
-
-
+
-
-
+
+
+
+
@@ -51,25 +39,13 @@
-
-
-
-
-
-
-
-
-
-
-
-
-
+
@@ -103,7 +79,7 @@
-
+
@@ -119,7 +95,7 @@
-
+
@@ -136,7 +112,7 @@
-
+
@@ -154,43 +130,24 @@
-
+
-
+
-
+
-
-
-
-http://repo1.maven.org/maven/junit/jars/junit-3.8.1.jar";>
-
-
-
-
-
-
-
-
-
-
-
+
-Proxy used :
-Proxy host [${proxy.host}]
-Proxy port [${proxy.port}]
-Proxy user [${proxy.username}]
-
+
-
-
-Proxy not used.
+http://repo1.maven.org/maven/junit/jars/junit-3.8.1.jar";>
+
@@ -198,4 +155,4 @@
-
\ No newline at end of file
+
Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml?view=diff&rev=546382&r1=546381&r2=546382
==
--- jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml (original)
+++ jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml Mon Jun 11
22:23:16 2007
@@ -19,7 +19,7 @@
commons-cli
commons-cli
CLI
- 1.1-SNAPSHOT
+ 1.1
2002
Commons CLI
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (FILEUPLOAD-136) FileUpload race condition with used with Jetty 6
[
https://issues.apache.org/jira/browse/FILEUPLOAD-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Kowalczykowski updated FILEUPLOAD-136:
Attachment: FileUploadTest.zip
Here is a full zip of the eclipse project.
> FileUpload race condition with used with Jetty 6
>
>
> Key: FILEUPLOAD-136
> URL: https://issues.apache.org/jira/browse/FILEUPLOAD-136
> Project: Commons FileUpload
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Running on Windows XP SP2 with Jetty 6 embedded and
> Firefox 2.0.0.4
>Reporter: Keith Kowalczykowski
>Priority: Critical
> Attachments: FileUploadTest.zip
>
>
> When running commons file upload with Jetty 6, ServletFileUpload.parseRequest
> spins and never returns when the user clicks the "stop" button in their
> browser while an upload is in progress.
> Reproduction Steps:
> * Create a simple servlet / html form which accepts a file upload using
> commons file upload (or use the example code below).
> * Upload a sufficiently large file that you have time to click the stop
> button before the upload completes.
> * Observe that the thread is now stuck within file upload.
> Other Information:
> Using jstack, I was able to get the following trace of where it is blocking.
> It looks like it is on a read() call that file upload is making.
> at org/mortbay/jetty/HttpParser$Input.blockForContent(HttpParser.java:922)
> at org/mortbay/jetty/HttpParser$Input.read(HttpParser.java:897)
> at
> org/apache/commons/fileupload/MultipartStream$ItemInputStream.makeAvailable(MultipartStream.java:959)
> at
> org/apache/commons/fileupload/MultipartStream$ItemInputStream.close(MultipartStream.java:910)
> at org/apache/commons/fileupload/util/Streams.copy(Streams.java:119)
> at org/apache/commons/fileupload/util/Streams.copy(Streams.java:64)
> at
> org/apache/commons/fileupload/FileUploadBase.parseRequest(FileUploadBase.java:354)
> at
> org/apache/commons/fileupload/servlet/ServletFileUpload.parseRequest(ServletFileUpload.java:126)
> at test/Main$1.handle(Main.java:43)
> at
> org/mortbay/jetty/handler/HandlerWrapper.handle(HandlerWrapper.java:139)
> at org/mortbay/jetty/Server.handle(Server.java:285)
> at org/mortbay/jetty/HttpConnection.handleRequest(HttpConnection.java:502)
> at
> org/mortbay/jetty/HttpConnection$RequestHandler.content(HttpConnection.java:835)
> at org/mortbay/jetty/HttpParser.parseNext(HttpParser.java:641)
> at org/mortbay/jetty/HttpParser.parseAvailable(HttpParser.java:208)
> at org/mortbay/jetty/HttpConnection.handle(HttpConnection.java:378)
> at
> org/mortbay/jetty/bio/SocketConnector$Connection.run(SocketConnector.java:226)
> at
> org/mortbay/thread/BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
> at jrockit/vm/RNI.c2java()V(Native Method)
> -- end of trac
> Originally I thought this was an issue with our code, however, I have since
> isolated it to a simple test case. Bellow is a class file called Main which
> when run will instantiate an instance of Jetty on port 8080 and an HTML
> document that will post a file upload to the servlet. When the stop button is
> pressed, you will see that the line "Starting processing" is printed, but
> neither the "Exception occured in processing" or "Processing completed" are
> printed. I have a full eclipse project (jars and all) on my machine that I
> was planning on uploading with this ticket, however, I don't see a way to
> attach a file. Therefore, I have copied and pasted the two files bellow. Let
> me know if you want the full project.
> === Main.java ===
> /**
> *
> */
> package test;
> import java.io.IOException;
> import java.util.List;
> import javax.servlet.ServletException;
> import javax.servlet.http.HttpServletRequest;
> import javax.servlet.http.HttpServletResponse;
> import org.apache.commons.fileupload.FileItem;
> import org.apache.commons.fileupload.disk.DiskFileItemFactory;
> import org.apache.commons.fileupload.servlet.ServletFileUpload;
> import org.mortbay.jetty.Handler;
> import org.mortbay.jetty.Server;
> import org.mortbay.jetty.handler.AbstractHandler;
> /**
> * @author Keith Kowalczykowski
> *
> */
> public class Main {
> public static void main(String[] args) {
> Handler handler = new AbstractHandler() {
> public void handle(String arg0, HttpServletRequest arg1,
> HttpServletResponse arg2, int arg3)
> throws IOException,
> ServletException
> {
> System.out.println("Starting processing");
> try
> {
>
[jira] Created: (FILEUPLOAD-136) FileUpload race condition with used with Jetty 6
FileUpload race condition with used with Jetty 6
Key: FILEUPLOAD-136
URL: https://issues.apache.org/jira/browse/FILEUPLOAD-136
Project: Commons FileUpload
Issue Type: Bug
Affects Versions: 1.2
Environment: Running on Windows XP SP2 with Jetty 6 embedded and
Firefox 2.0.0.4
Reporter: Keith Kowalczykowski
Priority: Critical
When running commons file upload with Jetty 6, ServletFileUpload.parseRequest
spins and never returns when the user clicks the "stop" button in their browser
while an upload is in progress.
Reproduction Steps:
* Create a simple servlet / html form which accepts a file upload using
commons file upload (or use the example code below).
* Upload a sufficiently large file that you have time to click the stop button
before the upload completes.
* Observe that the thread is now stuck within file upload.
Other Information:
Using jstack, I was able to get the following trace of where it is blocking. It
looks like it is on a read() call that file upload is making.
at org/mortbay/jetty/HttpParser$Input.blockForContent(HttpParser.java:922)
at org/mortbay/jetty/HttpParser$Input.read(HttpParser.java:897)
at
org/apache/commons/fileupload/MultipartStream$ItemInputStream.makeAvailable(MultipartStream.java:959)
at
org/apache/commons/fileupload/MultipartStream$ItemInputStream.close(MultipartStream.java:910)
at org/apache/commons/fileupload/util/Streams.copy(Streams.java:119)
at org/apache/commons/fileupload/util/Streams.copy(Streams.java:64)
at
org/apache/commons/fileupload/FileUploadBase.parseRequest(FileUploadBase.java:354)
at
org/apache/commons/fileupload/servlet/ServletFileUpload.parseRequest(ServletFileUpload.java:126)
at test/Main$1.handle(Main.java:43)
at org/mortbay/jetty/handler/HandlerWrapper.handle(HandlerWrapper.java:139)
at org/mortbay/jetty/Server.handle(Server.java:285)
at org/mortbay/jetty/HttpConnection.handleRequest(HttpConnection.java:502)
at
org/mortbay/jetty/HttpConnection$RequestHandler.content(HttpConnection.java:835)
at org/mortbay/jetty/HttpParser.parseNext(HttpParser.java:641)
at org/mortbay/jetty/HttpParser.parseAvailable(HttpParser.java:208)
at org/mortbay/jetty/HttpConnection.handle(HttpConnection.java:378)
at
org/mortbay/jetty/bio/SocketConnector$Connection.run(SocketConnector.java:226)
at
org/mortbay/thread/BoundedThreadPool$PoolThread.run(BoundedThreadPool.java:442)
at jrockit/vm/RNI.c2java()V(Native Method)
-- end of trac
Originally I thought this was an issue with our code, however, I have since
isolated it to a simple test case. Bellow is a class file called Main which
when run will instantiate an instance of Jetty on port 8080 and an HTML
document that will post a file upload to the servlet. When the stop button is
pressed, you will see that the line "Starting processing" is printed, but
neither the "Exception occured in processing" or "Processing completed" are
printed. I have a full eclipse project (jars and all) on my machine that I was
planning on uploading with this ticket, however, I don't see a way to attach a
file. Therefore, I have copied and pasted the two files bellow. Let me know if
you want the full project.
=== Main.java ===
/**
*
*/
package test;
import java.io.IOException;
import java.util.List;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.mortbay.jetty.Handler;
import org.mortbay.jetty.Server;
import org.mortbay.jetty.handler.AbstractHandler;
/**
* @author Keith Kowalczykowski
*
*/
public class Main {
public static void main(String[] args) {
Handler handler = new AbstractHandler() {
public void handle(String arg0, HttpServletRequest arg1,
HttpServletResponse arg2, int arg3)
throws IOException,
ServletException
{
System.out.println("Starting processing");
try
{
// Create a factory for disk-based
file items
DiskFileItemFactory factory = new
DiskFileItemFactory();
// Create a new file upload handler
ServletFileUpload upload = new
ServletFileUpload(factory);
// Parse the request
List items = upload.parseRequest(arg1);
for (int i = 0
svn commit: r546345 - in /jakarta/commons/proper/cli/trunk/xdocs: building.xml examples/cp.xml examples/cvs.xml examples/index.xml examples/ls.xml index.xml navigation.xml
Author: bayard Date: Mon Jun 11 18:25:02 2007 New Revision: 546345 URL: http://svn.apache.org/viewvc?view=rev&rev=546345 Log: Updating site. Bringing some of the 2.0 content in; removing the stubbed out 2.0 examples; updating the nav and adding the all important '1.x vs 2.x?' section to the front page Removed: jakarta/commons/proper/cli/trunk/xdocs/building.xml jakarta/commons/proper/cli/trunk/xdocs/examples/cp.xml jakarta/commons/proper/cli/trunk/xdocs/examples/cvs.xml jakarta/commons/proper/cli/trunk/xdocs/examples/ls.xml Modified: jakarta/commons/proper/cli/trunk/xdocs/examples/index.xml jakarta/commons/proper/cli/trunk/xdocs/index.xml jakarta/commons/proper/cli/trunk/xdocs/navigation.xml Modified: jakarta/commons/proper/cli/trunk/xdocs/examples/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/examples/index.xml?view=diff&rev=546345&r1=546344&r2=546345 == --- jakarta/commons/proper/cli/trunk/xdocs/examples/index.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/examples/index.xml Mon Jun 11 18:25:02 2007 @@ -39,5 +39,11 @@ found on the [EMAIL PROTECTED] mailing list. + + + +ant + + Modified: jakarta/commons/proper/cli/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/index.xml?view=diff&rev=546345&r1=546344&r2=546345 == --- jakarta/commons/proper/cli/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/index.xml Mon Jun 11 18:25:02 2007 @@ -29,8 +29,19 @@ The Jakarta Commons CLI library provides an API for processing command line interfaces. -It was formed by the merger of ideas and code from three different libraries - -Werken, Avalon and Optz. + + + + + +Commons CLI 1.0 was formed from the merger of ideas and code from three different libraries - +Werken, Avalon and Optz. In dealing with the bugs and the feature requests a freshly designed and not backwards compatible +CLI 2.0 was created, but never finished or released. Since then a CLI 1.1 bugfix release has been made. + + +There are currently no plans to continue the 1.x line beyond bugfixes. The 2.x design is generally preferred and is in use, +however there is no current activity to make a 2.0 release. To this end, the 1.1 release is recommended to most users +while the 2.x line is recommended for anyone interested in helping to get this better API released. Modified: jakarta/commons/proper/cli/trunk/xdocs/navigation.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/navigation.xml?view=diff&rev=546345&r1=546344&r2=546345 == --- jakarta/commons/proper/cli/trunk/xdocs/navigation.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/navigation.xml Mon Jun 11 18:25:02 2007 @@ -27,44 +27,26 @@ - http://jakarta.apache.org/site/downloads/downloads_commons-cli.cgi"/> - + http://jakarta.apache.org/site/downloads/downloads_commons-cli.cgi"/> + http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/"/> + - - - - - - + - - - - - - - - - ---> - - - - - - - http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/cli/trunk/"/> + - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546343 - /jakarta/commons/proper/cli/trunk/project.xml
Author: bayard Date: Mon Jun 11 18:01:42 2007 New Revision: 546343 URL: http://svn.apache.org/viewvc?view=rev&rev=546343 Log: Adding Brian Egge to the list of contributors Modified: jakarta/commons/proper/cli/trunk/project.xml Modified: jakarta/commons/proper/cli/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/project.xml?view=diff&rev=546343&r1=546342&r2=546343 == --- jakarta/commons/proper/cli/trunk/project.xml (original) +++ jakarta/commons/proper/cli/trunk/project.xml Mon Jun 11 18:01:42 2007 @@ -115,6 +115,12 @@ + Brian Egge + +made the 1.1 release happen + + + Berin Loritsch [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546340 - /jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java
Author: bayard Date: Mon Jun 11 17:55:11 2007 New Revision: 546340 URL: http://svn.apache.org/viewvc?view=rev&rev=546340 Log: Removing unused import Modified: jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java Modified: jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java?view=diff&rev=546340&r1=546339&r2=546340 == --- jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java (original) +++ jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java Mon Jun 11 17:55:11 2007 @@ -20,7 +20,6 @@ import java.text.ParsePosition; import java.util.Date; -import java.util.Iterator; import java.util.List; import java.util.ListIterator; - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546339 - /jakarta/commons/proper/cli/trunk/project.properties
Author: bayard Date: Mon Jun 11 17:54:15 2007 New Revision: 546339 URL: http://svn.apache.org/viewvc?view=rev&rev=546339 Log: Setting the JIRA format Modified: jakarta/commons/proper/cli/trunk/project.properties Modified: jakarta/commons/proper/cli/trunk/project.properties URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/project.properties?view=diff&rev=546339&r1=546338&r2=546339 == --- jakarta/commons/proper/cli/trunk/project.properties (original) +++ jakarta/commons/proper/cli/trunk/project.properties Mon Jun 11 17:54:15 2007 @@ -5,6 +5,8 @@ maven.changelog.factory=org.apache.maven.svnlib.SvnChangeLogFactory +maven.changes.issue.template=http://issues.apache.org/jira/browse/%ISSUE% + compile.debug = on compile.optimize = off compile.deprecation = off - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546337 - in /jakarta/commons/proper/cli/branches/cli-1.0.x: CLI2Converter.java CLI2ConverterTest.java maven.xml project.xml
Author: bayard Date: Mon Jun 11 17:50:34 2007 New Revision: 546337 URL: http://svn.apache.org/viewvc?view=rev&rev=546337 Log: Updating license header Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2Converter.java jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2ConverterTest.java jakarta/commons/proper/cli/branches/cli-1.0.x/maven.xml jakarta/commons/proper/cli/branches/cli-1.0.x/project.xml Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2Converter.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2Converter.java?view=diff&rev=546337&r1=546336&r2=546337 == --- jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2Converter.java (original) +++ jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2Converter.java Mon Jun 11 17:50:34 2007 @@ -1,9 +1,10 @@ /** - * Copyright 2004 The Apache Software Foundation - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2ConverterTest.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2ConverterTest.java?view=diff&rev=546337&r1=546336&r2=546337 == --- jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2ConverterTest.java (original) +++ jakarta/commons/proper/cli/branches/cli-1.0.x/CLI2ConverterTest.java Mon Jun 11 17:50:34 2007 @@ -1,9 +1,10 @@ /** - * Copyright 2004 The Apache Software Foundation - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/maven.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/maven.xml?view=diff&rev=546337&r1=546336&r2=546337 == --- jakarta/commons/proper/cli/branches/cli-1.0.x/maven.xml (original) +++ jakarta/commons/proper/cli/branches/cli-1.0.x/maven.xml Mon Jun 11 17:50:34 2007 @@ -1,9 +1,10 @@
svn commit: r546335 - /jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml
Author: bayard
Date: Mon Jun 11 17:46:20 2007
New Revision: 546335
URL: http://svn.apache.org/viewvc?view=rev&rev=546335
Log:
Updating 'maven ant'
Modified:
jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml
Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml?view=diff&rev=546335&r1=546334&r2=546335
==
--- jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml (original)
+++ jakarta/commons/proper/cli/branches/cli-1.0.x/build.xml Mon Jun 11 17:46:20
2007
@@ -1,32 +1,44 @@
+ on date June 11 2007, time 1738-->
-
+
+
+
+
+
-
+
+
+
-
+
-
+
-
+
-
+
-
+
-
+
+
+
+
+
+
+
+
+
-
-
-
-
+
+
@@ -39,13 +51,25 @@
+
+
+
+
+
+
+
+
+
+
+
+
-
+
@@ -79,7 +103,7 @@
-
+
@@ -95,9 +119,7 @@
-
-
-
+
@@ -114,7 +136,7 @@
-
+
@@ -136,20 +158,39 @@
-
+
-
+
+
+
+http://repo1.maven.org/maven/junit/jars/junit-3.8.1.jar";>
+
+
+
+
+
+
+
+
+
+
+
-
+Proxy used :
+Proxy host [${proxy.host}]
+Proxy port [${proxy.port}]
+Proxy user [${proxy.username}]
+
-http://repo1.maven.org/maven/junit/jars/junit-3.8.1.jar";>
-
+
+
+Proxy not used.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546332 - /jakarta/commons/proper/cli/trunk/project.xml
Author: bayard Date: Mon Jun 11 17:37:28 2007 New Revision: 546332 URL: http://svn.apache.org/viewvc?view=rev&rev=546332 Log: Tighter list of projects, though I imagine we'll move to m2 asap Modified: jakarta/commons/proper/cli/trunk/project.xml Modified: jakarta/commons/proper/cli/trunk/project.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/project.xml?view=diff&rev=546332&r1=546331&r2=546332 == --- jakarta/commons/proper/cli/trunk/project.xml (original) +++ jakarta/commons/proper/cli/trunk/project.xml Mon Jun 11 17:37:28 2007 @@ -194,23 +194,15 @@ - - - - +maven-changes-plugin maven-jdepend-plugin -maven-checkstyle-plugin + maven-javadoc-plugin maven-jdepend-plugin maven-junit-report-plugin maven-jxr-plugin maven-license-plugin -maven-tasklist-plugin maven-pmd-plugin - - - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546329 - in /jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2: commandline/Parser.java option/ArgumentImpl.java validation/DateValidator.java
Author: bayard
Date: Mon Jun 11 17:32:30 2007
New Revision: 546329
URL: http://svn.apache.org/viewvc?view=rev&rev=546329
Log:
Removing three unused imports (Parser/ArgumentImpl), and a pointless iteration
through a list in DateValidator
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/commandline/Parser.java
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/option/ArgumentImpl.java
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/commandline/Parser.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/commandline/Parser.java?view=diff&rev=546329&r1=546328&r2=546329
==
---
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/commandline/Parser.java
(original)
+++
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/commandline/Parser.java
Mon Jun 11 17:32:30 2007
@@ -16,8 +16,6 @@
*/
package org.apache.commons.cli2.commandline;
-import java.io.IOException;
-
import java.util.LinkedList;
import java.util.List;
import java.util.ListIterator;
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/option/ArgumentImpl.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/option/ArgumentImpl.java?view=diff&rev=546329&r1=546328&r2=546329
==
---
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/option/ArgumentImpl.java
(original)
+++
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/option/ArgumentImpl.java
Mon Jun 11 17:32:30 2007
@@ -16,10 +16,8 @@
*/
package org.apache.commons.cli2.option;
-import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
-import java.util.Iterator;
import java.util.List;
import java.util.ListIterator;
import java.util.Set;
Modified:
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java?view=diff&rev=546329&r1=546328&r2=546329
==
---
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java
(original)
+++
jakarta/commons/proper/cli/trunk/src/java/org/apache/commons/cli2/validation/DateValidator.java
Mon Jun 11 17:32:30 2007
@@ -101,10 +101,6 @@
*a List of DateFormats which dates must conform to
*/
public DateValidator(final List formats) {
-for (Iterator iter = formats.iterator(); iter.hasNext();) {
-DateFormat format = (DateFormat) iter.next();
-}
-
setFormats(formats);
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546327 - /jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/
Author: bayard Date: Mon Jun 11 17:31:39 2007 New Revision: 546327 URL: http://svn.apache.org/viewvc?view=rev&rev=546327 Log: Removing xdocs from the cli-1.0 side of things. The website lives in trunk. Removed: jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503689 ] Jörg Heinicke commented on TRANSACTION-16: -- It was more a rhetorical question to answer it directly with your mail. The point of the patch/this issue was just missing. Since I can edit the description of this issue I have moved the quote of your mail into it. Did you have a look at the XA stuff in ctx that's already there? I know it's not much, just the maps ... I also worked on TRANSACTION-13, but didn't find the time to complete it recently. I might add the stuff I already have to that issue. It misses the connection management. Maybe you can have a look at it. What I found strange from a short look on your code was the access to the TransactionManager. IMO this should not happen. It's up to the TransactionManager to enlist a resource, not the other way around. But thanks for your contribution anyway. I'm looking forward to your future involvement. > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > (Quoted from the original message: > http://marc.info/?l=jakarta-commons-dev&m=118129603213307&w=4): > I would like to donate an implementation of some transaction enabled > collections and resources. > The implementation is (more or less) JTA compliant, and mostly finished. It > is not well-tested, robust or mature. > The code includes: > 1) TX collections: Map, Set and List wrappers for transactional > protection/isolation. Supported nested collections such that for instance a > List or Set in a transactional Map is wrapped in the appropriate wrapper. > Copy-on-tx-start and locking. > 2) TX object model: An object is passed to the wrapper and after that only > used when retrieved from the wrapper. The object is wrapped in a dynamic > proxy which makes sure all returned objects from reachable instances are also > wrapped. Copy-on-write and locking. I have some additional ideas on this one. > - > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546325 - in /jakarta/commons/proper/cli/trunk/xdocs: changes.xml index.xml issue-tracking.xml
Author: bayard Date: Mon Jun 11 17:28:17 2007 New Revision: 546325 URL: http://svn.apache.org/viewvc?view=rev&rev=546325 Log: Updating the website. Instead of doing things in the xdocs on the 1.0 branch, I'm going to keep the 'one true xdoc' here in trunk and have it support both 1.0 and 2.0 Added: jakarta/commons/proper/cli/trunk/xdocs/changes.xml Modified: jakarta/commons/proper/cli/trunk/xdocs/index.xml jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml Added: jakarta/commons/proper/cli/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/changes.xml?view=auto&rev=546325 == --- jakarta/commons/proper/cli/trunk/xdocs/changes.xml (added) +++ jakarta/commons/proper/cli/trunk/xdocs/changes.xml Mon Jun 11 17:28:17 2007 @@ -0,0 +1,54 @@ + + + + + +Commons CLI Release Notes + + + + + Parameter value "-something" misinterpreted as a parameter. + CLI_1_BRANCH build.xml doesn't work. + No Javadoc for HelpFormatter!. + Options should not be able to be added more than once. + Infinite Loop in Command-Line processing. + Documentation errors. + A weakness of parser. + CommandLine.getOptionValue() behaves contrary to docs. + Dependecy on commons-lang-2.0 but commons-lang-1.0 is obtained. + Document enhancement. + Error parsing option arguments. + HelpFormatter doesn't function correctly for options with only LongOpt. + Line separator as first char for helpformatter (footer) throws exception. + Missing arguments in HelpFormatter.renderOptions(..). + Only long options without short option seems to be noticed. + Parser breaks up command line parms into single characters. + Passing properties in Parser does not work for options with a single argument. + Wrong usage summary. + clone method in Option should use super.clone(). + clone() method doesn't fully clone contents. + HelpFormatter doesn't sort options properly. + Remove the Commons Lang dependency. + Setting description of a Option. + + + + + Modified: jakarta/commons/proper/cli/trunk/xdocs/index.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/index.xml?view=diff&rev=546325&r1=546324&r2=546325 == --- jakarta/commons/proper/cli/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/index.xml Mon Jun 11 17:28:17 2007 @@ -43,21 +43,21 @@ The JavaDoc API documents are available online: -The current release 1.0 - -The latest SVN +The current release 1.1 +The previous version 1.0 +The latest SVN (2.0-SNAPSHOT) The subversion repository can be -http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/cli/trunk/";>browsed. +http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/";>browsed. -The latest version is v1.0. - +The latest version is v1.1. - http://jakarta.apache.org/site/downloads/downloads_commons-cli.cgi";>Download now! -The release notes are also available. +The release notes are also available. For previous releases, see the http://archive.apache.org/dist/jakarta/commons/cli/";>Apache Archive Modified: jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml?view=diff&rev=546325&r1=546324&r2=546325 == --- jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/issue-tracking.xml Mon Jun 11 17:28:17 2007 @@ -12,7 +12,7 @@ Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific iouage governing permissions and +See the License for the specific language governing permissions and limitations under the License. --> @@ -24,19 +24,25 @@ - Commons CLI uses the http://issues.apache.org/jira/";>ASF JIRA for tracking issues. - To use JIRA you may need to https://issues.apache.org/jira/secure/Signup!default.jspa";>create an account. + Commons CLI uses the http://issues.apache.org/jira/browse/CLI";>ASF JIRA for tracking issues. + + + To use JIRA you may need to http://issues.apache.org/jira/secure/Signup!default.jspa";>create an account + (if you have previously created/updated Commons issues using Bugzilla an account will have been automatically + created and you can use the http://issues.apache.org/jira/secure/ForgotPassword!default.jspa";>Forgot Password + page to get a new password). If you would like to report a bug, or raise an enhancement request wit
svn commit: r546324 - /jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml
Author: bayard Date: Mon Jun 11 17:23:38 2007 New Revision: 546324 URL: http://svn.apache.org/viewvc?view=rev&rev=546324 Log: Fixing link to viewvc Modified: jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml Modified: jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml?view=diff&rev=546324&r1=546323&r2=546324 == --- jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml (original) +++ jakarta/commons/proper/cli/trunk/xdocs/cvs-usage.xml Mon Jun 11 17:23:38 2007 @@ -33,7 +33,7 @@ The best way to view the repository is via the - http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/cli/trunk/";>subversion viewer. + http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/";>subversion viewer. The alternative is to use the - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546323 - /jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml
Author: bayard Date: Mon Jun 11 17:22:59 2007 New Revision: 546323 URL: http://svn.apache.org/viewvc?view=rev&rev=546323 Log: Fixing link to viewvc Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml Modified: jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml URL: http://svn.apache.org/viewvc/jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml?view=diff&rev=546323&r1=546322&r2=546323 == --- jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml (original) +++ jakarta/commons/proper/cli/branches/cli-1.0.x/xdocs/cvs-usage.xml Mon Jun 11 17:22:59 2007 @@ -32,7 +32,7 @@ The best way to view the repository is via the - http://svn.apache.org/viewcvs.cgi/jakarta/commons/proper/cli/trunk/";>subversion viewer. + http://svn.apache.org/viewvc/jakarta/commons/proper/cli/trunk/";>subversion viewer. The alternative is to use the - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Heinicke updated TRANSACTION-16: - Comment: was deleted > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > (Quoted from the original message: > http://marc.info/?l=jakarta-commons-dev&m=118129603213307&w=4): > I would like to donate an implementation of some transaction enabled > collections and resources. > The implementation is (more or less) JTA compliant, and mostly finished. It > is not well-tested, robust or mature. > The code includes: > 1) TX collections: Map, Set and List wrappers for transactional > protection/isolation. Supported nested collections such that for instance a > List or Set in a transactional Map is wrapped in the appropriate wrapper. > Copy-on-tx-start and locking. > 2) TX object model: An object is passed to the wrapper and after that only > used when retrieved from the wrapper. The object is wrapped in a dynamic > proxy which makes sure all returned objects from reachable instances are also > wrapped. Copy-on-write and locking. I have some additional ideas on this one. > - > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Heinicke updated TRANSACTION-16: - Description: (Quoted from the original message: http://marc.info/?l=jakarta-commons-dev&m=118129603213307&w=4): I would like to donate an implementation of some transaction enabled collections and resources. The implementation is (more or less) JTA compliant, and mostly finished. It is not well-tested, robust or mature. The code includes: 1) TX collections: Map, Set and List wrappers for transactional protection/isolation. Supported nested collections such that for instance a List or Set in a transactional Map is wrapped in the appropriate wrapper. Copy-on-tx-start and locking. 2) TX object model: An object is passed to the wrapper and after that only used when retrieved from the wrapper. The object is wrapped in a dynamic proxy which makes sure all returned objects from reachable instances are also wrapped. Copy-on-write and locking. I have some additional ideas on this one. - I hereby donate the attached source code for inclusion in or inspiration for commons-transaction. I will be happy to participate further in the development of these features. Some of the stuff in the project can be considered experimental, and not yet done, but most is fully implemented. -dennis was: I hereby donate the attached source code for inclusion in or inspiration for commons-transaction. I will be happy to participate further in the development of these features. Some of the stuff in the project can be considered experimental, and not yet done, but most is fully implemented. -dennis > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > (Quoted from the original message: > http://marc.info/?l=jakarta-commons-dev&m=118129603213307&w=4): > I would like to donate an implementation of some transaction enabled > collections and resources. > The implementation is (more or less) JTA compliant, and mostly finished. It > is not well-tested, robust or mature. > The code includes: > 1) TX collections: Map, Set and List wrappers for transactional > protection/isolation. Supported nested collections such that for instance a > List or Set in a transactional Map is wrapped in the appropriate wrapper. > Copy-on-tx-start and locking. > 2) TX object model: An object is passed to the wrapper and after that only > used when retrieved from the wrapper. The object is wrapped in a dynamic > proxy which makes sure all returned objects from reachable instances are also > wrapped. Copy-on-write and locking. I have some additional ideas on this one. > - > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (LANG-339) StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, Japanes, etc.
[ https://issues.apache.org/jira/browse/LANG-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503687 ] Henri Yandell commented on LANG-339: Probably the same code as LANG-66, but leaving open so a separate unit test can be written. > StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, > Japanes, etc. > --- > > Key: LANG-339 > URL: https://issues.apache.org/jira/browse/LANG-339 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 2.3 > Environment: Operating System: All > Platform: All >Reporter: Guo Yong > Fix For: 3.0 > > > StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, > Japanes, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-339) StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, Japanes, etc.
[ https://issues.apache.org/jira/browse/LANG-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell updated LANG-339: --- Fix Version/s: 3.0 > StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, > Japanes, etc. > --- > > Key: LANG-339 > URL: https://issues.apache.org/jira/browse/LANG-339 > Project: Commons Lang > Issue Type: Bug >Affects Versions: 2.3 > Environment: Operating System: All > Platform: All >Reporter: Guo Yong > Fix For: 3.0 > > > StringEscapeUtils.escapeHtml() escapes multibyte characters like Chinese, > Japanes, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-337) Utility class constructor javadocs should acknowledge that they may sometimes be used, e.g. with Velocity.
[
https://issues.apache.org/jira/browse/LANG-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henri Yandell updated LANG-337:
---
Fix Version/s: 2.3.1
> Utility class constructor javadocs should acknowledge that they may sometimes
> be used, e.g. with Velocity.
> --
>
> Key: LANG-337
> URL: https://issues.apache.org/jira/browse/LANG-337
> Project: Commons Lang
> Issue Type: Wish
>Affects Versions: 2.3
>Reporter: Keith R. Bennett
>Priority: Minor
> Fix For: 2.3.1
>
>
> Utility class constructors currently have javadoc comments that say:
> "StringUtils instances should NOT be constructed in standard programming."
> However, there are some cases where it is necessary to use them to create
> instances. For example, using the utility methods in a Velocity context
> requires that an instance be created.
> It is true that the current comment does not exclude this use, but the
> emphasis ("NOT") implies that there is a possibility it will be deprecated,
> removed, or otherwise be made inaccessible in the future.
> I'd like to suggest modifying the message to more explicitly acknowledge that
> the constructor's use is approved in some cases, so as to reassure developers
> that it will continue to be available in the future.
> One possible wording would be to retain the existing comment, and add to it:
> "However, in some cases (for example, for use with Velocity), it is necessary
> to create an instance of this class. It is recommended that this constructor
> be used only in special cases such as this."
> (This issue really applies to all projects with utility classes with this
> javadoc, so feel free to copy it them as well.)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (LANG-333) ArrayUtils.toClass
[ https://issues.apache.org/jira/browse/LANG-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Yandell updated LANG-333: --- Fix Version/s: 3.0 Another 'wish we had closures' one :) > ArrayUtils.toClass > -- > > Key: LANG-333 > URL: https://issues.apache.org/jira/browse/LANG-333 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jörg Gottschling > Fix For: 3.0 > > > ArrayUtils should have a Method toClass(array : Object[]) : Class[] which > creates a new Array with the Class-Objects of the Objects in the Array. Very > nice for Reflection. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546321 - /jakarta/commons/trunks-proper/
Author: bayard Date: Mon Jun 11 16:58:19 2007 New Revision: 546321 URL: http://svn.apache.org/viewvc?view=rev&rev=546321 Log: Removing the CLI avalon implementation from trunks-proper Modified: jakarta/commons/trunks-proper/ (props changed) Propchange: jakarta/commons/trunks-proper/ -- --- svn:externals (original) +++ svn:externals Mon Jun 11 16:58:19 2007 @@ -3,7 +3,6 @@ betwixt https://svn.apache.org/repos/asf/jakarta/commons/proper/betwixt/trunk chain https://svn.apache.org/repos/asf/jakarta/commons/proper/chain/trunk cli https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/trunk -cli-avalon https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/branches/avalon-implementation cli-1.0.x https://svn.apache.org/repos/asf/jakarta/commons/proper/cli/branches/cli-1.0.x codec https://svn.apache.org/repos/asf/jakarta/commons/proper/codec/trunk collections https://svn.apache.org/repos/asf/jakarta/commons/proper/collections/trunk - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] logging failed.
On 6/11/07, Ben Speakmon <[EMAIL PROTECTED]> wrote: Phil actually had to fix a bug in commons-nightly before the maven 2 file would be honored, so after I asked about getting email working, logging started working too. On 6/11/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > > I'm unsure why, but it seems that Commons Logging has been built using > Maven 1 up until June 9. even though it was listed in the > nightly_proper_maven2_list.txt file. > > When Ben added Email to the list of Maven 2 builds, it triggered Logging > to be built with Maven 2 as well. Hopefully my patch to the nightly > build script will fix the nightly M2 build of Logging. That is correct. The problem was that the script was svn-upping the wrong directory (ever since it was moved from commons-build to commons-nightly several months back) so it had not picked up changes to the nightly list files until I fixed it a couple of days ago. It will pick up changes now. Phil - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] logging failed.
Phil actually had to fix a bug in commons-nightly before the maven 2 file would be honored, so after I asked about getting email working, logging started working too. On 6/11/07, Dennis Lundberg <[EMAIL PROTECTED]> wrote: I'm unsure why, but it seems that Commons Logging has been built using Maven 1 up until June 9. even though it was listed in the nightly_proper_maven2_list.txt file. When Ben added Email to the list of Maven 2 builds, it triggered Logging to be built with Maven 2 as well. Hopefully my patch to the nightly build script will fix the nightly M2 build of Logging. Phil Steitz wrote: > Failed build logs: > http://vmbuild.apache.org/~commons/nightly/logs//20070611/logging.log > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [nightly build] logging failed.
I'm unsure why, but it seems that Commons Logging has been built using Maven 1 up until June 9. even though it was listed in the nightly_proper_maven2_list.txt file. When Ben added Email to the list of Maven 2 builds, it triggered Logging to be built with Maven 2 as well. Hopefully my patch to the nightly build script will fix the nightly M2 build of Logging. Phil Steitz wrote: Failed build logs: http://vmbuild.apache.org/~commons/nightly/logs//20070611/logging.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Dennis Lundberg - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546301 - /jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh
Author: dennisl Date: Mon Jun 11 15:06:10 2007 New Revision: 546301 URL: http://svn.apache.org/viewvc?view=rev&rev=546301 Log: Make sure that the site is built before the assembly is built, for Maven 2 builds. Commons Logging requires this, as the site is a part of the assembly. Modified: jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh Modified: jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh URL: http://svn.apache.org/viewvc/jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh?view=diff&rev=546301&r1=546300&r2=546301 == --- jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh (original) +++ jakarta/commons/proper/commons-nightly/trunk/commons_nightly.sh Mon Jun 11 15:06:10 2007 @@ -244,6 +244,7 @@ # Create source and binary distributions mvn clean > $log_location/$component.log 2>&1 +mvn site:site >> $log_location/$component.log 2>&1 mvn assembly:assembly -DdescriptorId=bin >> $log_location/$component.log 2>&1 mvn assembly:assembly -DdescriptorId=src >> $log_location/$component.log 2>&1 # Rename files - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] 3rd attempt: Release commons-io 1.3.2
While checking the distros I noticed the following minor things:
- The source distro does not unpack in a directory with the "-src"
suffix. This is standard for other commons components.
- The md5 files do not contain the file name. (Maybe this is a maven
standard. However the commons release instructions [1] use a different
format).
- The main site has a wrong title ("validator").
None of these points are blocking IMO. It is up to you whether you want
to address (some of) them before the release. Here is my +1.
Oliver
[1] http://jakarta.apache.org/commons/releases/release.html
Jochen Wiedmann wrote:
How to handle this? We have only three votes:
[+1] Sebb, Jochen
[-0] Stephen
but we need at least three positive votes from PMC members?
Jochen
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] 3rd attempt: Release commons-io 1.3.2
How to handle this? We have only three votes: [+1] Sebb, Jochen [-0] Stephen but we need at least three positive votes from PMC members? Jochen -- "Besides, manipulating elections is under penalty of law, resulting in a preventative effect against manipulating elections. The german government justifying the use of electronic voting machines and obviously believing that we don't need a police, because all illegal actions are forbidden. http://dip.bundestag.de/btd/16/051/1605194.pdf - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503462 ] Dennis Thrysøe commented on TRANSACTION-16: --- Yes, certainly. The mailing list seems kind of high-volume, but I'll try to write a post that details some further aspects of the code. > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503448
]
Niall Pemberton commented on BEANUTILS-283:
---
Sorry - DateConverter is new - not refactored!
(see BEANUTILS-255)
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
>Assignee: Niall Pemberton
> Fix For: 1.8.0
>
> Attachments: Test.java
>
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Resolved: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niall Pemberton resolved BEANUTILS-283.
---
Resolution: Fixed
Fix Version/s: 1.8.0
Assignee: Niall Pemberton
I've fixed this and added a test case using the DateConverter:
http://svn.apache.org/viewvc?view=rev&revision=546174
Thanks for providing the demonstration of the issue - as a side note the
DateConverter has been re-factored and you can create and register it to use a
specified Locale - either with the default (SHORT) pattern for that locale or
for a specified pattern or set of patterns.
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
>Assignee: Niall Pemberton
> Fix For: 1.8.0
>
> Attachments: Test.java
>
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546174 - in /jakarta/commons/proper/beanutils/trunk/src: java/org/apache/commons/beanutils/ConvertUtilsBean.java test/org/apache/commons/beanutils/ConvertUtilsTestCase.java
Author: niallp
Date: Mon Jun 11 08:42:53 2007
New Revision: 546174
URL: http://svn.apache.org/viewvc?view=rev&rev=546174
Log:
Fix for BEANUTILS-283 - ConvertUtilsBean doesn't handle conversion to String
correctly - thanks to Josef Cacek
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/ConvertUtilsTestCase.java
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java?view=diff&rev=546174&r1=546173&r2=546174
==
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java
Mon Jun 11 08:42:53 2007
@@ -542,8 +542,8 @@
}
converted = converter.convert(targetType, value);
}
-if (targetType == String.class && value != null) {
-converted = value.toString();
+if (targetType == String.class && converted != null) {
+converted = converted.toString();
}
return converted;
Modified:
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/ConvertUtilsTestCase.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/ConvertUtilsTestCase.java?view=diff&rev=546174&r1=546173&r2=546174
==
---
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/ConvertUtilsTestCase.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/test/org/apache/commons/beanutils/ConvertUtilsTestCase.java
Mon Jun 11 08:42:53 2007
@@ -21,6 +21,10 @@
import java.sql.Date;
import java.sql.Time;
import java.sql.Timestamp;
+import java.text.DateFormat;
+import java.text.SimpleDateFormat;
+import java.util.Locale;
+import org.apache.commons.beanutils.converters.DateConverter;
import junit.framework.TestCase;
import junit.framework.Test;
import junit.framework.TestSuite;
@@ -607,6 +611,27 @@
ConvertUtils.deregister(Boolean.TYPE);
assertNull("Converter should be
null",ConvertUtils.lookup(Boolean.TYPE));
+}
+
+public void testConvertToString() throws Exception {
+
+ConvertUtilsBean utils = new ConvertUtilsBean();
+
+// Register a DateConverter using Locale.US
+DateConverter dateConverter = new DateConverter();
+dateConverter.setLocale(Locale.US);
+utils.register(dateConverter, java.util.Date.class);
+
+java.util.Date today = new java.util.Date();
+DateFormat fmt = new SimpleDateFormat("M/d/yy"); /* US Short Format */
+String expected = fmt.format(today);
+
+assertEquals("date M/d/yy", expected, utils.convert(today,
String.class));
+
+// Remove the registered DateConverter
+utils.deregister(java.util.Date.class);
+assertEquals("Date.toString()", today.toString(), utils.convert(today,
String.class));
+
}
// Private Methods
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503436 ] Oliver Zeigermann commented on TRANSACTION-16: -- Cool. That fits into ctx's picture. Maybe this could even be a starting point for the 2.0 version. Would you be willing to participate in further discussion and refactoring of your code? > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503431
]
Niall Pemberton commented on BEANUTILS-283:
---
Sorry I mis-understood you're original post - you are correct it should be
referencing the "converted" value - not the original one. Thanks for spotting
this.
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
> Attachments: Test.java
>
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josef Cacek updated BEANUTILS-283:
--
Attachment: Test.java
Sample app for reproducing bug.
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
> Attachments: Test.java
>
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503425
]
Josef Cacek commented on BEANUTILS-283:
---
toString could be OK, but only if it's used for the right value. Here it is not.
The simplest solution for this bug could be:
if (targetType == String.class && value != null) {
converted = converted.toString();
}
or
if (converted==null && targetType == String.class && value != null) {
converted = value.toString();
}
I will attach sample application.
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[dbutils] ResultSetIterator should utilize ResultSetHandler, not RowProcessor?
ResultSetIterator can take a RowProcessor as an argument but then the RowProcessor.toArray() method is always used in ResultSetIterator.next(). If ResultSetIterator utilized a ResultSetHandler instead, it's handle() method could be invoked on next() and then the ResultSet row could be processed in a number of different ways, including the RowProcessor's toArray, toBean, toBeanList and toMap methods. Regards, ~Mark. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
[
https://issues.apache.org/jira/browse/BEANUTILS-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503413
]
Niall Pemberton commented on BEANUTILS-283:
---
My understanding of String's toString() method is that it just returns a
reference to itself - so why is this a bug?
Just for the record the reason for using the converted values toString() method
is because Converter implementations in BeanUtils in the past have not taken
any account of the "target type" passed to the Converter's convert() method.
Also ConvertUtils used to delegate to StringConverter for conversions to
Strings - now ConvertUtils delegates to the converter for the type of the value
being converted. Hence the reason for using toString() - to try and ensure that
conversion to String still works with existing user Converter implementations.
> ConvertUtilsBean doesn't handl conversion to String correctly
> -
>
> Key: BEANUTILS-283
> URL: https://issues.apache.org/jira/browse/BEANUTILS-283
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: ConvertUtils & Converters
>Affects Versions: Nightly Builds
> Environment: commons-beanutils-20070610-src.zip
>Reporter: Josef Cacek
>
> Either lookup(Class, Class) or convert(Object, Class) method doesn't work
> correctly in class ConvertUtilsBean.
> Problematic is the case when target class is String.
> The code from convert(..) which doesn't work:
> Object converted = value;
> Converter converter = lookup(sourceType, targetType);
> if (converter != null) {
> if (log.isTraceEnabled()) {
> log.trace(" Using converter " + converter);
> }
> converted = converter.convert(targetType, value);
> }
> // here we already have converted value (String), but we will rewrite it by
> default .toString() - it's a bug
> if (targetType == String.class && value != null) {
> converted = value.toString();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (BEANUTILS-283) ConvertUtilsBean doesn't handl conversion to String correctly
ConvertUtilsBean doesn't handl conversion to String correctly
-
Key: BEANUTILS-283
URL: https://issues.apache.org/jira/browse/BEANUTILS-283
Project: Commons BeanUtils
Issue Type: Bug
Components: ConvertUtils & Converters
Affects Versions: Nightly Builds
Environment: commons-beanutils-20070610-src.zip
Reporter: Josef Cacek
Either lookup(Class, Class) or convert(Object, Class) method doesn't work
correctly in class ConvertUtilsBean.
Problematic is the case when target class is String.
The code from convert(..) which doesn't work:
Object converted = value;
Converter converter = lookup(sourceType, targetType);
if (converter != null) {
if (log.isTraceEnabled()) {
log.trace(" Using converter " + converter);
}
converted = converter.convert(targetType, value);
}
// here we already have converted value (String), but we will rewrite it by
default .toString() - it's a bug
if (targetType == String.class && value != null) {
converted = value.toString();
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JXPATH-88) Add getPrefix(String namespaceURI) to JXPathContext
Add getPrefix(String namespaceURI) to JXPathContext --- Key: JXPATH-88 URL: https://issues.apache.org/jira/browse/JXPATH-88 Project: Commons JXPath Issue Type: Improvement Affects Versions: 1.2 Final Reporter: Sergey Vladimirov Priority: Minor There is function getNamespaceURI(String prefix), but there is no inverted one. Need this in following case: - reading XML - check, if prefix for particular namespace is defined (using getPrefix) - if defined - using prefix, specified in XML - if not defined - define prefix and using it Usual way - to define prefix always - is not good, since prefix can already be used in XML file with another namespace. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[nightly build] logging failed.
Failed build logs: http://vmbuild.apache.org/~commons/nightly/logs//20070611/logging.log - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r546121 - in /jakarta/commons/proper/jci/trunk: ./ assembly/ assembly/src/ assembly/src/assembly/ compilers/eclipse/ compilers/groovy/ compilers/janino/ compilers/javac/ compilers/rhino/ c
Author: tcurdt
Date: Mon Jun 11 05:23:17 2007
New Revision: 546121
URL: http://svn.apache.org/viewvc?view=rev&rev=546121
Log:
sort of working assembly construction
Added:
jakarta/commons/proper/jci/trunk/assembly/
jakarta/commons/proper/jci/trunk/assembly/pom.xml (with props)
jakarta/commons/proper/jci/trunk/assembly/src/
jakarta/commons/proper/jci/trunk/assembly/src/assembly/
jakarta/commons/proper/jci/trunk/assembly/src/assembly/bin.xml (with
props)
jakarta/commons/proper/jci/trunk/assembly/src/assembly/src.xml (with
props)
Removed:
jakarta/commons/proper/jci/trunk/src/assembly/
Modified:
jakarta/commons/proper/jci/trunk/compilers/eclipse/pom.xml
jakarta/commons/proper/jci/trunk/compilers/groovy/pom.xml
jakarta/commons/proper/jci/trunk/compilers/janino/pom.xml
jakarta/commons/proper/jci/trunk/compilers/javac/pom.xml
jakarta/commons/proper/jci/trunk/compilers/rhino/pom.xml
jakarta/commons/proper/jci/trunk/core/pom.xml
jakarta/commons/proper/jci/trunk/examples/pom.xml
jakarta/commons/proper/jci/trunk/pom.xml
Added: jakarta/commons/proper/jci/trunk/assembly/pom.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jci/trunk/assembly/pom.xml?view=auto&rev=546121
==
--- jakarta/commons/proper/jci/trunk/assembly/pom.xml (added)
+++ jakarta/commons/proper/jci/trunk/assembly/pom.xml Mon Jun 11 05:23:17 2007
@@ -0,0 +1,72 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+4.0.0
+
+org.apache.commons
+commons-jci
+1.0-SNAPSHOT
+
+pom
+commons-jci-assemblies
+1.0-SNAPSHOT
+assemblies
+
+Commons JCI assemblies.
+
+
+true
+
+
+
+org.apache.commons
+commons-jci-core
+1.0-SNAPSHOT
+
+
+org.apache.commons
+commons-jci-eclipse
+1.0-SNAPSHOT
+
+
+
+
+
+
+maven-assembly-plugin
+
+commons-jci-${project.version}
+
+src/assembly/bin.xml
+src/assembly/src.xml
+
+gnu
+
+
+
+package
+
+attached
+
+
+
+
+
+
+
Propchange: jakarta/commons/proper/jci/trunk/assembly/pom.xml
--
svn:eol-style = native
Propchange: jakarta/commons/proper/jci/trunk/assembly/pom.xml
--
svn:keywords = Date Revision Author HeadURL Id
Propchange: jakarta/commons/proper/jci/trunk/assembly/pom.xml
--
svn:mime-type = text/xml
Added: jakarta/commons/proper/jci/trunk/assembly/src/assembly/bin.xml
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/jci/trunk/assembly/src/assembly/bin.xml?view=auto&rev=546121
==
--- jakarta/commons/proper/jci/trunk/assembly/src/assembly/bin.xml (added)
+++ jakarta/commons/proper/jci/trunk/assembly/src/assembly/bin.xml Mon Jun 11
05:23:17 2007
@@ -0,0 +1,108 @@
+
+
+bin
+
+tar.gz
+zip
+
+commons-jci-${project.version}-bin
+false
+
+
+
+
+
+../LICENSE.txt
+../NOTICE.txt
+../README.txt
+
+
+
+../target/site/apidocs
+apidocs
+
+
+lib
+../core/target
+
+*.jar
+
+
+
+lib
+../fam/target
+
+*.jar
+
+
+
+lib
+../compilers/eclipse/target
+
+*.jar
+
+
+
+lib
+../compilers/groovy/target
+
+*.jar
+
+
+
+lib
+../compilers/janino/target
+
+*.jar
+
+
+
+lib
+../compilers/javac/target
+
+*.jar
+
+
+
+lib
+../compilers/rhino/target
+
+*.jar
+
+
+
+lib
+../examples/target
+
+
[EMAIL PROTECTED]: Project commons-id (in module jakarta-commons-sandbox) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-id has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-id : Commons Identifier Package Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons-sandbox/commons-id/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-id-10062007.jar] identifier set to project name -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/project.properties -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons-sandbox/commons-id/gump_work/build_jakarta-commons-sandbox_commons-id.html Work Name: build_jakarta-commons-sandbox_commons-id (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 7 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062007.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062007.jar:/usr/local/gump/public/workspace/junit/dist/junit-10062007.jar:/usr/local/gump/packages/maven-cobertura-plugin/maven-cobertura-plugin-1.1.jar:/usr/local/gump/packages/maven-xdoc-plugin/maven-xdoc-plugin-1.9.2.jar - [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.975 sec [junit] Running org.apache.commons.id.serial.PrefixedLeftPaddedNumericGeneratorTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 1.032 sec [junit] Running org.apache.commons.id.serial.TimeBasedAlphanumericIdentifierGeneratorTest [junit] Tests run: 12, Failures: 1, Errors: 0, Time elapsed: 1.432 sec [junit] [ERROR] TEST org.apache.commons.id.serial.TimeBasedAlphanumericIdentifierGeneratorTest FAILED [junit] Running org.apache.commons.id.serial.AlphanumericGeneratorTest [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 1.033 sec [junit] Running org.apache.commons.id.serial.LongGeneratorTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.99 sec [junit] Running org.apache.commons.id.serial.NumericGeneratorTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.973 sec [junit] Running org.apache.commons.id.uuid.state.StateHelperTest [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 1.292 sec [junit] Running org.apache.commons.id.uuid.state.NodeTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 1.218 sec [junit] Running org.apache.commons.id.uuid.state.InMemoryStateImplTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.253 sec [junit] Running org.apache.commons.id.uuid.state.ReadOnlyResourceStateImplTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.511 sec [junit] Running org.apache.commons.id.uuid.state.ReadWriteFileStateImplTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.841 sec [junit] Running org.apache.commons.id.uuid.clock.SystemClockImplTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1.028 sec [junit] Running org.apache.commons.id.uuid.clock.ThreadClockImplTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1.075 sec [junit] Running org.apache.commons.id.uuid.NodeManagerImplTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.51 sec [junit] Running org.apache.commons.id.uuid.UUIDTest [junit] Tests run: 17, Failures: 0, Errors: 0, Time elapsed: 1.155 sec
[EMAIL PROTECTED]: Project commons-id (in module jakarta-commons-sandbox) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project commons-id has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - commons-id : Commons Identifier Package Full details are available at: http://vmgump.apache.org/gump/public/jakarta-commons-sandbox/commons-id/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [commons-id-10062007.jar] identifier set to project name -DEBUG- (Gump generated) Maven Properties in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/build.properties -INFO- Failed with reason build failed -DEBUG- Maven POM in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/project.xml -DEBUG- Maven project properties in: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id/project.properties -INFO- Failed to extract fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-commons-sandbox/commons-id/gump_work/build_jakarta-commons-sandbox_commons-id.html Work Name: build_jakarta-commons-sandbox_commons-id (Type: Build) Work ended in a state of : Failed Elapsed: 1 min 7 secs Command Line: maven --offline jar [Working Directory: /usr/local/gump/public/workspace/jakarta-commons-sandbox/id] CLASSPATH: /opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/public/workspace/jakarta-commons/discovery/dist/commons-discovery.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-10062007.jar:/usr/local/gump/public/workspace/jakarta-commons/logging/target/commons-logging-api-10062007.jar:/usr/local/gump/public/workspace/junit/dist/junit-10062007.jar:/usr/local/gump/packages/maven-cobertura-plugin/maven-cobertura-plugin-1.1.jar:/usr/local/gump/packages/maven-xdoc-plugin/maven-xdoc-plugin-1.9.2.jar - [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 0.975 sec [junit] Running org.apache.commons.id.serial.PrefixedLeftPaddedNumericGeneratorTest [junit] Tests run: 4, Failures: 0, Errors: 0, Time elapsed: 1.032 sec [junit] Running org.apache.commons.id.serial.TimeBasedAlphanumericIdentifierGeneratorTest [junit] Tests run: 12, Failures: 1, Errors: 0, Time elapsed: 1.432 sec [junit] [ERROR] TEST org.apache.commons.id.serial.TimeBasedAlphanumericIdentifierGeneratorTest FAILED [junit] Running org.apache.commons.id.serial.AlphanumericGeneratorTest [junit] Tests run: 9, Failures: 0, Errors: 0, Time elapsed: 1.033 sec [junit] Running org.apache.commons.id.serial.LongGeneratorTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.99 sec [junit] Running org.apache.commons.id.serial.NumericGeneratorTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 0.973 sec [junit] Running org.apache.commons.id.uuid.state.StateHelperTest [junit] Tests run: 6, Failures: 0, Errors: 0, Time elapsed: 1.292 sec [junit] Running org.apache.commons.id.uuid.state.NodeTest [junit] Tests run: 8, Failures: 0, Errors: 0, Time elapsed: 1.218 sec [junit] Running org.apache.commons.id.uuid.state.InMemoryStateImplTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.253 sec [junit] Running org.apache.commons.id.uuid.state.ReadOnlyResourceStateImplTest [junit] Tests run: 5, Failures: 0, Errors: 0, Time elapsed: 1.511 sec [junit] Running org.apache.commons.id.uuid.state.ReadWriteFileStateImplTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.841 sec [junit] Running org.apache.commons.id.uuid.clock.SystemClockImplTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1.028 sec [junit] Running org.apache.commons.id.uuid.clock.ThreadClockImplTest [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 1.075 sec [junit] Running org.apache.commons.id.uuid.NodeManagerImplTest [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.51 sec [junit] Running org.apache.commons.id.uuid.UUIDTest [junit] Tests run: 17, Failures: 0, Errors: 0, Time elapsed: 1.155 sec
[jira] Commented: (BEANUTILS-282) BigDecimalLocaleConverter returns Long object
[
https://issues.apache.org/jira/browse/BEANUTILS-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503361
]
Josef Cacek commented on BEANUTILS-282:
---
Yes I use the latest release 1.7.0, I will try the nightly build. Thanx.
> BigDecimalLocaleConverter returns Long object
> -
>
> Key: BEANUTILS-282
> URL: https://issues.apache.org/jira/browse/BEANUTILS-282
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: Locale BeanUtils / Converters
>Affects Versions: 1.7.0
>Reporter: Josef Cacek
>
> BigDecimalLocaleConverter returns Long object instead of BigDecimal when no
> decimal places are in the parsed number.
> Problem is in the method DecimalLocaleConverter.parse(Object, String) which
> uses DecimalFormat.getInstance(locale).parse(String). The getInstance method
> is factory method from NumberFormat and not DecimalFormat, so there is no
> guarantee of returned type.
> Here is the sample which shows the problem:
> import java.math.BigDecimal;
> import java.text.NumberFormat;
> import java.util.Locale;
> import
> org.apache.commons.beanutils.locale.converters.BigDecimalLocaleConverter;
> public class Test {
>
> public static void main(String args[]) {
> Locale tmpLoc = new Locale("de","AT");
> NumberFormat nf = NumberFormat.getNumberInstance(tmpLoc);
> String tmpNr = nf.format(new BigDecimal("5"));
> BigDecimalLocaleConverter tmpBdlc = new
> BigDecimalLocaleConverter(tmpLoc);
> Object tmpConverted = tmpBdlc.convert(tmpNr);
> System.out.println("String value: " + tmpNr);
> System.out.println("Number value: " + tmpConverted);
> System.out.println(tmpConverted==null?"No class":"Class: " +
> tmpConverted.getClass());
> }
> }
> Output is:
> String value: 5
> Number value: 5
> Class: class java.lang.Long
> Correct handling is implemented e.g. in BigDecimalValidator class of
> commons-validator package. It uses an additional method processParsedValue to
> convert number to the right type:
> /**
> * Convert the parsed value to a BigDecimal.
> *
> * @param value The parsed Number object created.
> * @param formatter The Format used to parse the value with.
> * @return The parsed Number converted to a
> * BigDecimal.
> */
> protected Object processParsedValue(Object value, Format formatter) {
> BigDecimal decimal = null;
> if (value instanceof Long) {
> decimal = BigDecimal.valueOf(((Long)value).longValue());
> } else {
> decimal = new BigDecimal(value.toString());
> }
> int scale = determineScale((NumberFormat)formatter);
> if (scale >= 0) {
> decimal = decimal.setScale(scale, BigDecimal.ROUND_DOWN);
> }
> return decimal;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (BEANUTILS-282) BigDecimalLocaleConverter returns Long object
[
https://issues.apache.org/jira/browse/BEANUTILS-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503356
]
Niall Pemberton commented on BEANUTILS-282:
---
I assume you are looking at the source for the 1.7 release because
BigDecimalLocaleConverter has been changed in the current trunk for issue#
BEANUTILS-131 ?
> BigDecimalLocaleConverter returns Long object
> -
>
> Key: BEANUTILS-282
> URL: https://issues.apache.org/jira/browse/BEANUTILS-282
> Project: Commons BeanUtils
> Issue Type: Bug
> Components: Locale BeanUtils / Converters
>Affects Versions: 1.7.0
>Reporter: Josef Cacek
>
> BigDecimalLocaleConverter returns Long object instead of BigDecimal when no
> decimal places are in the parsed number.
> Problem is in the method DecimalLocaleConverter.parse(Object, String) which
> uses DecimalFormat.getInstance(locale).parse(String). The getInstance method
> is factory method from NumberFormat and not DecimalFormat, so there is no
> guarantee of returned type.
> Here is the sample which shows the problem:
> import java.math.BigDecimal;
> import java.text.NumberFormat;
> import java.util.Locale;
> import
> org.apache.commons.beanutils.locale.converters.BigDecimalLocaleConverter;
> public class Test {
>
> public static void main(String args[]) {
> Locale tmpLoc = new Locale("de","AT");
> NumberFormat nf = NumberFormat.getNumberInstance(tmpLoc);
> String tmpNr = nf.format(new BigDecimal("5"));
> BigDecimalLocaleConverter tmpBdlc = new
> BigDecimalLocaleConverter(tmpLoc);
> Object tmpConverted = tmpBdlc.convert(tmpNr);
> System.out.println("String value: " + tmpNr);
> System.out.println("Number value: " + tmpConverted);
> System.out.println(tmpConverted==null?"No class":"Class: " +
> tmpConverted.getClass());
> }
> }
> Output is:
> String value: 5
> Number value: 5
> Class: class java.lang.Long
> Correct handling is implemented e.g. in BigDecimalValidator class of
> commons-validator package. It uses an additional method processParsedValue to
> convert number to the right type:
> /**
> * Convert the parsed value to a BigDecimal.
> *
> * @param value The parsed Number object created.
> * @param formatter The Format used to parse the value with.
> * @return The parsed Number converted to a
> * BigDecimal.
> */
> protected Object processParsedValue(Object value, Format formatter) {
> BigDecimal decimal = null;
> if (value instanceof Long) {
> decimal = BigDecimal.valueOf(((Long)value).longValue());
> } else {
> decimal = new BigDecimal(value.toString());
> }
> int scale = determineScale((NumberFormat)formatter);
> if (scale >= 0) {
> decimal = decimal.setScale(scale, BigDecimal.ROUND_DOWN);
> }
> return decimal;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (BEANUTILS-282) BigDecimalLocaleConverter returns Long object
BigDecimalLocaleConverter returns Long object
-
Key: BEANUTILS-282
URL: https://issues.apache.org/jira/browse/BEANUTILS-282
Project: Commons BeanUtils
Issue Type: Bug
Components: Locale BeanUtils / Converters
Affects Versions: 1.7.0
Reporter: Josef Cacek
BigDecimalLocaleConverter returns Long object instead of BigDecimal when no
decimal places are in the parsed number.
Problem is in the method DecimalLocaleConverter.parse(Object, String) which
uses DecimalFormat.getInstance(locale).parse(String). The getInstance method is
factory method from NumberFormat and not DecimalFormat, so there is no
guarantee of returned type.
Here is the sample which shows the problem:
import java.math.BigDecimal;
import java.text.NumberFormat;
import java.util.Locale;
import org.apache.commons.beanutils.locale.converters.BigDecimalLocaleConverter;
public class Test {
public static void main(String args[]) {
Locale tmpLoc = new Locale("de","AT");
NumberFormat nf = NumberFormat.getNumberInstance(tmpLoc);
String tmpNr = nf.format(new BigDecimal("5"));
BigDecimalLocaleConverter tmpBdlc = new
BigDecimalLocaleConverter(tmpLoc);
Object tmpConverted = tmpBdlc.convert(tmpNr);
System.out.println("String value: " + tmpNr);
System.out.println("Number value: " + tmpConverted);
System.out.println(tmpConverted==null?"No class":"Class: " +
tmpConverted.getClass());
}
}
Output is:
String value: 5
Number value: 5
Class: class java.lang.Long
Correct handling is implemented e.g. in BigDecimalValidator class of
commons-validator package. It uses an additional method processParsedValue to
convert number to the right type:
/**
* Convert the parsed value to a BigDecimal.
*
* @param value The parsed Number object created.
* @param formatter The Format used to parse the value with.
* @return The parsed Number converted to a
* BigDecimal.
*/
protected Object processParsedValue(Object value, Format formatter) {
BigDecimal decimal = null;
if (value instanceof Long) {
decimal = BigDecimal.valueOf(((Long)value).longValue());
} else {
decimal = new BigDecimal(value.toString());
}
int scale = determineScale((NumberFormat)formatter);
if (scale >= 0) {
decimal = decimal.setScale(scale, BigDecimal.ROUND_DOWN);
}
return decimal;
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503336 ] Dennis Thrysøe commented on TRANSACTION-16: --- Oliver: dk.cmd.xa.* and dk.cmd.clone.* has to do with implementing the transaction collections etc. You could try to have a look at the tests, to get an idea of where I wan't to go with this. I don't think JDK 1.5 is necesarry, except perhaps for a single annotation. This code could easily be "backported" to 1.4. I think this coude could fit in as either inspiration or a starting base for implementing various transactionally enabled building blocks that would make implementing concurrent usage of shared resources a breeze. Jörg: Not really a "patch", but rather something that can be used for inspiration and/or as a starting point for implementing common transaction controlling collections/encapsulations for shared (memory) resources. > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Issue Comment Edited: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503335 ] Dennis Thrysøe edited comment on TRANSACTION-16 at 6/11/07 2:04 AM: Attached a new version where I removed the irrelavant stuff, and some of the jars. There is a notes.txt in the zip which explains a few details. was: Attached a new version where I removed the irrelavant stuff, and some of the jars. > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Thrysøe updated TRANSACTION-16: -- Attachment: buzz.zip Attached a new version where I removed the irrelavant stuff, and some of the jars. > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (TRANSACTION-16) TX collections / TX object model
[ https://issues.apache.org/jira/browse/TRANSACTION-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Thrysøe updated TRANSACTION-16: -- Attachment: (was: buzz.zip) > TX collections / TX object model > > > Key: TRANSACTION-16 > URL: https://issues.apache.org/jira/browse/TRANSACTION-16 > Project: Commons Transaction > Issue Type: Wish >Reporter: Dennis Thrysøe >Assignee: Oliver Zeigermann > Attachments: buzz.zip > > > I hereby donate the attached source code for inclusion in or inspiration for > commons-transaction. > I will be happy to participate further in the development of these features. > Some of the stuff in the project can be considered experimental, and not yet > done, but most is fully implemented. > -dennis -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
