Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread huizhe wang 

Thanks Lance, Daniel!

-Joe

On 2/14/2017 10:53 AM, Lance Andersen wrote:

Looks good… ship it.

On Feb 14, 2017, at 1:41 PM, Daniel Fuchs > wrote:


On 14/02/17 17:21, huizhe wang wrote:

Thanks!

Here's an updated webrev:
http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ 



+1

-- daniel



-Joe

On 2/14/2017 4:07 AM, Lance Andersen wrote:

Looks good overall Joe.  I would agree that I would clean up the minor
comment alignment issues.

Best
Lance
On Feb 13, 2017, at 9:27 PM, huizhe wang 

> wrote:

A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for
the coming development deadline.

JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ 




Checking whether a space follows "




Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com  













Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread Lance Andersen 
Looks good… ship it.

> On Feb 14, 2017, at 1:41 PM, Daniel Fuchs  wrote:
> 
> On 14/02/17 17:21, huizhe wang wrote:
>> Thanks!
>> 
>> Here's an updated webrev:
>> http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
> 
> +1
> 
> -- daniel
> 
>> 
>> -Joe
>> 
>> On 2/14/2017 4:07 AM, Lance Andersen wrote:
>>> Looks good overall Joe.  I would agree that I would clean up the minor
>>> comment alignment issues.
>>> 
>>> Best
>>> Lance
 On Feb 13, 2017, at 9:27 PM, huizhe wang >>> > wrote:
 
 A quick fix for the error parsing xml declaration. This is one of the
 three outstanding issues in the xml area that must be addressed for
 the coming development deadline.
 
 JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
 
 
 Checking whether a space follows ">>> for which the base parser was originally created since the xml
 declaration was normalized during version detection. StAX, sharing
 the base parser after it was added to the JDK, however, does not use
 the same version detection/normalization process and would
 incorrectly parse the declaration if there are other whitespaces.
 
 Thanks,
 Joe
 
 
>>> 
>>> 
>>> 
>>> 
>>> Lance
>>> Andersen| Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering
>>> 1 Network Drive
>>> Burlington, MA 01803
>>> lance.ander...@oracle.com 
>>> 
>>> 
>>> 
>> 
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread Daniel Fuchs 

On 14/02/17 17:21, huizhe wang wrote:

Thanks!

Here's an updated webrev:
http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/


+1

-- daniel



-Joe

On 2/14/2017 4:07 AM, Lance Andersen wrote:

Looks good overall Joe.  I would agree that I would clean up the minor
comment alignment issues.

Best
Lance

On Feb 13, 2017, at 9:27 PM, huizhe wang mailto:huizhe.w...@oracle.com>> wrote:

A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for
the coming development deadline.

JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/


Checking whether a space follows "




Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread huizhe wang 

Thanks!

Here's an updated webrev: 
http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/


-Joe

On 2/14/2017 4:07 AM, Lance Andersen wrote:
Looks good overall Joe.  I would agree that I would clean up the minor 
comment alignment issues.


Best
Lance
On Feb 13, 2017, at 9:27 PM, huizhe wang > wrote:


A quick fix for the error parsing xml declaration. This is one of the 
three outstanding issues in the xml area that must be addressed for 
the coming development deadline.


JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/ 



Checking whether a space follows "for which the base parser was originally created since the xml 
declaration was normalized during version detection. StAX, sharing 
the base parser after it was added to the JDK, however, does not use 
the same version detection/normalization process and would 
incorrectly parse the declaration if there are other whitespaces.


Thanks,
Joe






Lance 
Andersen| Principal Member of Technical Staff | +1.781.442.2037

Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread huizhe wang 



On 2/14/2017 3:16 AM, Daniel Fuchs wrote:

Looks good Joe.

I wonder about this though (which may be an issue for
another time):

102 [25] Eq ::= S? '=' S?

Do we support space (new line?) before and after the '=' sign?


Yes, we do. I've added a couple of test cases to cover this.

Best,
Joe



best regards,

-- daniel

On 14/02/17 02:27, huizhe wang wrote:

A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for the
coming development deadline.

JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/

Checking whether a space follows "

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread huizhe wang 

Thanks Christoph.  Will fix those comments.

-Joe

On 2/13/2017 11:56 PM, Langer, Christoph wrote:

Hi Joe,

this looks right to me, quite straightforward.

I just have some formatting nits for the test:

1. Line 107 (XMLInputFactory xif=): space missing before '='

2. Method comments on test methods would look nicer if formatted like:
/*
* line 1
* line 2
* ...
*/
... I want to say that the '*' is missing in the beginning of the middle lines

3. Several whitespace at the end of lines - but jcheck should find out

Best regards
Christoph



-Original Message-
From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
Behalf Of huizhe wang
Sent: Dienstag, 14. Februar 2017 03:28
To: core-libs-dev@openjdk.java.net
Subject: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml
declaration

A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for the
coming development deadline.

JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/

Checking whether a space follows "

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread Lance Andersen 
Looks good overall Joe.  I would agree that I would clean up the minor comment 
alignment issues.

Best
Lance
> On Feb 13, 2017, at 9:27 PM, huizhe wang  wrote:
> 
> A quick fix for the error parsing xml declaration. This is one of the three 
> outstanding issues in the xml area that must be addressed for the coming 
> development deadline.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
> 
> Checking whether a space follows " the base parser was originally created since the xml declaration was 
> normalized during version detection. StAX, sharing the base parser after it 
> was added to the JDK, however, does not use the same version 
> detection/normalization process and would incorrectly parse the declaration 
> if there are other whitespaces.
> 
> Thanks,
> Joe
> 
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com

Re: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-14 Thread Daniel Fuchs 

Looks good Joe.

I wonder about this though (which may be an issue for
another time):

102 [25] Eq ::= S? '=' S?

Do we support space (new line?) before and after the '=' sign?

best regards,

-- daniel

On 14/02/17 02:27, huizhe wang wrote:

A quick fix for the error parsing xml declaration. This is one of the
three outstanding issues in the xml area that must be addressed for the
coming development deadline.

JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/

Checking whether a space follows "

RE: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml declaration

2017-02-13 Thread Langer, Christoph 
Hi Joe,

this looks right to me, quite straightforward.

I just have some formatting nits for the test:

1. Line 107 (XMLInputFactory xif=): space missing before '='

2. Method comments on test methods would look nicer if formatted like:
/*
* line 1
* line 2
* ...
*/
... I want to say that the '*' is missing in the beginning of the middle lines

3. Several whitespace at the end of lines - but jcheck should find out

Best regards
Christoph


> -Original Message-
> From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On
> Behalf Of huizhe wang
> Sent: Dienstag, 14. Februar 2017 03:28
> To: core-libs-dev@openjdk.java.net
> Subject: RFR (JAXP) 8169450: StAX parse error if there is a newline in xml
> declaration
> 
> A quick fix for the error parsing xml declaration. This is one of the
> three outstanding issues in the xml area that must be addressed for the
> coming development deadline.
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8169450
> webrev: http://cr.openjdk.java.net/~joehw/jdk9/8169450/webrev/
> 
> Checking whether a space follows " which the base parser was originally created since the xml declaration
> was normalized during version detection. StAX, sharing the base parser
> after it was added to the JDK, however, does not use the same version
> detection/normalization process and would incorrectly parse the
> declaration if there are other whitespaces.
> 
> Thanks,
> Joe
>