Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
Hi Alan,
On 21/06/2019 12:34, Alan Bateman wrote:
> I saw Joe's comment on the CSR. This refinement looks good to me.
I have pushed the doc fix to jdk13.
Once it percolates to jdk14 I will post a new webrev for the JEP 352
implementation which accomodates this change. That webrev will also
include the changes pending after Joe's review of the implementation CSR
leaving (I hope) only my recently proposed JEP updates and endorsement
to finish before it can be pushed.
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
On 21/06/2019 10:42, Andrew Dinn wrote:
:
+ * If this buffer was not mapped in read/write mode
+ * ({@link java.nio.channels.FileChannel.MapMode#READ_WRITE})
+ * then invoking this method may have no effect. In particular,
+ * the method has no effect for buffers mapped in read-only or
+ * private mapping modes. This method may or may not have an
+ * effect for implementation-specific mapping modes.
Would you agree with that change or do you prefer to stick with the
original? If necessary I'll amend the patch and CSR then push whichever
version you prefer to JDK13.
I saw Joe's comment on the CSR. This refinement looks good to me.
-Alan
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
Hi Alan,
On 19/06/2019 14:11, Alan Bateman wrote:
> On 19/06/2019 11:07, Andrew Dinn wrote:
>> :
>> Do I still need to wait for confirmation for the CSR from Joe Darcy
>> before pushing to the jdk13 repo? (He already knows about the CSR).
>>
> Yes, anything that has a CSR needs to wait until it is approved.
Joe Darcy has approved the CSR. However, he suggested by way of code
review that the comment be tweaked to explicitly state that the force
method does have an effect when the buffer was mapped with mode
READ_WRITE e.g. instead of
* This method has no effect for buffers mapped in read-only
* or private mapping modes. It may also have no effect for other
* implementation specific map modes.
this
+ * If this buffer was not mapped in read/write mode
+ * ({@link java.nio.channels.FileChannel.MapMode#READ_WRITE})
+ * then invoking this method may have no effect. In particular,
+ * the method has no effect for buffers mapped in read-only or
+ * private mapping modes. This method may or may not have an
+ * effect for implementation-specific mapping modes.
Would you agree with that change or do you prefer to stick with the
original? If necessary I'll amend the patch and CSR then push whichever
version you prefer to JDK13.
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
On 19/06/2019 11:07, Andrew Dinn wrote: : Do I still need to wait for confirmation for the CSR from Joe Darcy before pushing to the jdk13 repo? (He already knows about the CSR). Yes, anything that has a CSR needs to wait until it is approved. -Alan
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
On 19/06/2019 11:03, Alan Bateman wrote:
> I added myself as Reviewer to the the CSR so you can finalize. The
> webrev looks good.
Thanks, Alan. I have finalized the CSR.
Do I still need to wait for confirmation for the CSR from Joe Darcy
before pushing to the jdk13 repo? (He already knows about the CSR).
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
On 19/06/2019 10:21, Andrew Dinn wrote: : I raised this CSR: CSR:https://bugs.openjdk.java.net/browse/JDK-8226385 and tagged it for jdk13. Also, I labelled it SE -- but is it, perhaps, meant to be JDK? (apologies, I am still a noob to this process). Yes, it's "SE" as it's normative text in Java SE API spec. I added myself as Reviewer to the the CSR so you can finalize. The webrev looks good. -Alan
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
Hi Alan,
On 18/06/2019 18:08, Alan Bateman wrote:
> This looks good. Will you create a CSR for this? I think it can be fixed
> in jdk/jdk13 as it follows JDK-8221397 and JDK-8221696 (and there is no
> risk as it's javadoc only).
I raised this CSR:
CSR:https://bugs.openjdk.java.net/browse/JDK-8226385
and tagged it for jdk13.
Also, I labelled it SE -- but is it, perhaps, meant to be JDK?
(apologies, I am still a noob to this process).
Bug:https://bugs.openjdk.java.net/browse/JDK-8226203
Webrev: http://cr.openjdk.java.net/~adinn/8226203/webrev.00/
regards,
Andrew Dinn
---
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Re: RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
On 18/06/2019 17:15, Andrew Dinn wrote: Could I please have a review for the following trivial change to the javadoc for the two MappedByteBuffer.force methods: JIRA: https://bugs.openjdk.java.net/browse/JDK-8226203 webrev: http://cr.openjdk.java.net/~adinn/8226203/webrev.00/ It allows for the possibility of failures when extended map modes are used to create the MappedByteBuffer. The case documented here will not actually arise in JDK13 since nothing in the JDK creates, let alone exposes extended map modes. However, it would be better if the javadoc reflected that possibility. Is it still possible to push this? If that is a problem then I am happy for it to go into jdk14. This looks good. Will you create a CSR for this? I think it can be fixed in jdk/jdk13 as it follows JDK-8221397 and JDK-8221696 (and there is no risk as it's javadoc only). -Alan
RFR (T): 8226203: MappedByteBuffer.force method may have no effect on implementation specific map modes
Could I please have a review for the following trivial change to the javadoc for the two MappedByteBuffer.force methods: JIRA: https://bugs.openjdk.java.net/browse/JDK-8226203 webrev: http://cr.openjdk.java.net/~adinn/8226203/webrev.00/ It allows for the possibility of failures when extended map modes are used to create the MappedByteBuffer. The case documented here will not actually arise in JDK13 since nothing in the JDK creates, let alone exposes extended map modes. However, it would be better if the javadoc reflected that possibility. Is it still possible to push this? If that is a problem then I am happy for it to go into jdk14. regards, Andrew Dinn ---
