Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-24 Thread Lance Andersen 
Looks good Frank

Best
Lance
> On Nov 23, 2016, at 9:29 PM, Frank Yuan <frank.y...@oracle.com> wrote:
> 
> Hi Jon
> 
> 
> 
> Thank you for your advice!
> 
> 
> 
> Please check the update http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/ 
> , which contains jcommander.jar and removes the extra
> blank lines following Christoph's suggestion.
> 
> 
> 
> Frank
> 
> 
> 
> From: Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com] 
> Sent: Thursday, November 24, 2016 4:26 AM
> Subject: Re: RFR JDK-8170192 [JAXP] [TESTBUG] 
> test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant 
> permissions
> to jtreg, javatest, and testng jars
> 
> 
> 
> Frank,
> 
> More recent builds of testng.jar, such as the builds available on Maven,  
> have separated out the jcommander component so that two
> jar files are required: testng.jar and jcommander.jar.
> 
> You should consider taking jcommander.jar into account.  This will be more 
> important/noticeable to folk outside Oracle who build
> their own copy of jtreg to use.
> 
> -- Jon
> 
> On 11/22/2016 08:41 PM, Frank Yuan wrote:
> 
> Hi All
> 
> 
> 
> Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/
> <http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/> ?
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170192
> 
> 
> 
> This patch is fully same as Daniel provided except a few lines of additional 
> cleaning, thanks to Daniel for providing the patch!
> 
> 
> 
> Thanks
> 
> Frank
> 
> 
> 
> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> 
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>

Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-24 Thread Daniel Fuchs 

Hi Frank,

Looks good to me.
Thanks for the advice Jon!

best regards,

-- daniel

On 24/11/16 02:29, Frank Yuan wrote:

Hi Jon



Thank you for your advice!



Please check the update
http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/ , which contains
jcommander.jar and removes the extra blank lines following Christoph’s
suggestion.



Frank



*From:*Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com]
*Sent:* Thursday, November 24, 2016 4:26 AM
*Subject:* Re: RFR JDK-8170192 [JAXP] [TESTBUG]
test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should
grant permissions to jtreg, javatest, and testng jars



Frank,

More recent builds of testng.jar, such as the builds available on
Maven,  have separated out the jcommander component so that two jar
files are required: testng.jar and jcommander.jar.

You should consider taking jcommander.jar into account.  This will be
more important/noticeable to folk outside Oracle who build their own
copy of jtreg to use.

-- Jon

On 11/22/2016 08:41 PM, Frank Yuan wrote:

Hi All



Would you like to review
http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/
<http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/>?

Bug: https://bugs.openjdk.java.net/browse/JDK-8170192



This patch is fully same as Daniel provided except a few lines of
additional cleaning, thanks to Daniel for providing the patch!



Thanks

Frank

RE: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-23 Thread Frank Yuan 
Hi Jon

 

Thank you for your advice!

 

Please check the update http://cr.openjdk.java.net/~fyuan/8170192/webrev.01/ , 
which contains jcommander.jar and removes the extra
blank lines following Christoph's suggestion.

 

Frank

 

From: Jonathan Gibbons [mailto:jonathan.gibb...@oracle.com] 
Sent: Thursday, November 24, 2016 4:26 AM
Subject: Re: RFR JDK-8170192 [JAXP] [TESTBUG] 
test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant 
permissions
to jtreg, javatest, and testng jars

 

Frank,

More recent builds of testng.jar, such as the builds available on Maven,  have 
separated out the jcommander component so that two
jar files are required: testng.jar and jcommander.jar.

You should consider taking jcommander.jar into account.  This will be more 
important/noticeable to folk outside Oracle who build
their own copy of jtreg to use.

-- Jon

On 11/22/2016 08:41 PM, Frank Yuan wrote:

Hi All

 

Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/
<http://cr.openjdk.java.net/%7Efyuan/8170192/webrev.00/> ?

Bug: https://bugs.openjdk.java.net/browse/JDK-8170192

 

This patch is fully same as Daniel provided except a few lines of additional 
cleaning, thanks to Daniel for providing the patch!

 

Thanks

Frank

Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-23 Thread Jonathan Gibbons 

Frank,

More recent builds of testng.jar, such as the builds available on 
Maven,  have separated out the jcommander component so that two jar 
files are required: testng.jar and jcommander.jar.


You should consider taking jcommander.jar into account.  This will be 
more important/noticeable to folk outside Oracle who build their own 
copy of jtreg to use.


-- Jon

On 11/22/2016 08:41 PM, Frank Yuan wrote:


Hi All

Would you like to review 
http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/ 
?


Bug: https://bugs.openjdk.java.net/browse/JDK-8170192

This patch is fully same as Daniel provided except a few lines of 
additional cleaning, thanks to Daniel for providing the patch!


Thanks

Frank

Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-23 Thread Joe Wang 

+1. Thanks Frank!

-Joe

On 11/23/16, 6:00 AM, Daniel Fuchs wrote:

Hi Frank,

Thanks for taking this on.
Looks good to me.

-- daniel

On 23/11/16 04:41, Frank Yuan wrote:

Hi All



Would you like to review
http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?

Bug: https://bugs.openjdk.java.net/browse/JDK-8170192



This patch is fully same as Daniel provided except a few lines of
additional cleaning, thanks to Daniel for providing the patch!



Thanks

Frank

Re: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-23 Thread Daniel Fuchs 

Hi Frank,

Thanks for taking this on.
Looks good to me.

-- daniel

On 23/11/16 04:41, Frank Yuan wrote:

Hi All



Would you like to review
http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?

Bug: https://bugs.openjdk.java.net/browse/JDK-8170192



This patch is fully same as Daniel provided except a few lines of
additional cleaning, thanks to Daniel for providing the patch!



Thanks

Frank

RE: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-22 Thread Langer, Christoph 
Hi Frank,

to me this looks fine. Maybe a small cosmetical thing: Around lines 212 and 240 
you could remove the additional empty lines to have one blank line between 
methods as in the rest of the file.

Note that I'm not a reviewer.

Best regards
Christoph

From: Frank Yuan [mailto:frank.y...@oracle.com]
Sent: Mittwoch, 23. November 2016 05:41
To: core-libs-dev@openjdk.java.net; 'Daniel Fuchs' <daniel.fu...@oracle.com>; 
Langer, Christoph <christoph.lan...@sap.com>; 'Volker Simonis' 
<volker.simo...@gmail.com>; 'Joe Wang' <huizhe.w...@oracle.com>
Cc: code-tools-...@openjdk.java.net; jtreg-...@openjdk.java.net
Subject: RFR JDK-8170192 [JAXP] [TESTBUG] 
test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant 
permissions to jtreg, javatest, and testng jars

Hi All

Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?
Bug: https://bugs.openjdk.java.net/browse/JDK-8170192

This patch is fully same as Daniel provided except a few lines of additional 
cleaning, thanks to Daniel for providing the patch!

Thanks
Frank

RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars

2016-11-22 Thread Frank Yuan 
Hi All

 

Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?

Bug: https://bugs.openjdk.java.net/browse/JDK-8170192

 

This patch is fully same as Daniel provided except a few lines of additional 
cleaning, thanks to Daniel for providing the patch!

 

Thanks

Frank