Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 13:47:43 GMT, Eirik Bjørsnøs wrote: > Yes, you'll need to run all tests to make sure that there aren't any others, > e.g. test/hotspot/jtreg/compiler/stable/TestUnstableStable.java. Alan, With @jaikiran running Oracle CI tier1, tier2, tier3 and observing only the now-fixed `TestUnstableStable.java` test fail, would you consider re-approving the current state of this PR? - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1988559676
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 10:17:23 GMT, Jaikiran Pai wrote: >> Eirik Bjørsnøs has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use getAndSetReference instead of getAndSetObject in >> test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java > > Hello Eirik, I've triggered internal CI testing of the current state of this > PR to run tier1, tier2 and tier3. > @jaikiran Expect TestUnstableStable above to fail your CI run. Right, that's the only test that failed (with a compilation error) on all platforms. - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1987254844
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 12:18:02 GMT, Alan Bateman wrote: > Yes, you'll need to run all tests to make sure that there aren't any others, > e.g. test/hotspot/jtreg/compiler/stable/TestUnstableStable.java. I've updated `TestUnstableStable` to use `putReference` and also fixed a stray code comment reference to `Unsafe.compareAndSetObject` in `BufferedInputStream`. @jaikiran Expect `TestUnstableStable` above to fail your CI run. - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1987238716
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 08:24:42 GMT, Eirik Bjørsnøs wrote: > GHA revealed two call sites for `getAndSetObject` in the test > `test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java`. > > I have replaced these with the `getAndSetReference`, grepped for any > remaining uses without finding anything. Let's see what GHA says. Yes, you'll need to run all tests to make sure that there aren't any others, e.g. test/hotspot/jtreg/compiler/stable/TestUnstableStable.java. - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1987207527
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 08:14:02 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which removes the 19 deprecated `xxObject*` alias >> methods from `jdk.internal.misc.Unsafe`. >> >> These methods were added in JDK-8213043 (JDK 12), presumably to allow >> `jsr166.jar` to be used across JDK versions. This was a follow-up fix after >> JDK-8207146 had renamed these methods to `xxReference*'. >> >> Since OpenJDK is now the single source of truth for `java.util.concurrent`, >> time has come to remove these deprecated alias methods. >> >> This change was initially discussed here: >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-March/119993.html >> >> Testing: This is a pure deletion of deprecated methods, so the PR includes >> no test changes and the `noreg-cleanup` label is added in the JBS. I have >> verified that all `test/jdk/java/util/concurrent/*` tests pass. >> >> Tagging @DougLea and @Martin-Buchholz to verify that this removal is timely. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Use getAndSetReference instead of getAndSetObject in > test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java Hello Eirik, I've triggered internal CI testing of the current state of this PR to run tier1, tier2 and tier3. - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1987173153
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
On Sun, 10 Mar 2024 08:14:02 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which removes the 19 deprecated `xxObject*` alias >> methods from `jdk.internal.misc.Unsafe`. >> >> These methods were added in JDK-8213043 (JDK 12), presumably to allow >> `jsr166.jar` to be used across JDK versions. This was a follow-up fix after >> JDK-8207146 had renamed these methods to `xxReference*'. >> >> Since OpenJDK is now the single source of truth for `java.util.concurrent`, >> time has come to remove these deprecated alias methods. >> >> This change was initially discussed here: >> https://mail.openjdk.org/pipermail/core-libs-dev/2024-March/119993.html >> >> Testing: This is a pure deletion of deprecated methods, so the PR includes >> no test changes and the `noreg-cleanup` label is added in the JBS. I have >> verified that all `test/jdk/java/util/concurrent/*` tests pass. >> >> Tagging @DougLea and @Martin-Buchholz to verify that this removal is timely. > > Eirik Bjørsnøs has updated the pull request incrementally with one additional > commit since the last revision: > > Use getAndSetReference instead of getAndSetObject in > test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java Thanks for reviewing, Martin and Alan. GHA revealed two call sites for ` getAndSetObject` in the test `test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java`. I have replaced these with the `getAndSetReference`, grepped for any remaining uses without finding anything. Let's see what GHA says. - PR Comment: https://git.openjdk.org/jdk/pull/18176#issuecomment-1987141915
Re: RFR: 8327729: Remove deprecated xxxObject methods from jdk.internal.misc.Unsafe [v2]
> Please review this PR which removes the 19 deprecated `xxObject*` alias > methods from `jdk.internal.misc.Unsafe`. > > These methods were added in JDK-8213043 (JDK 12), presumably to allow > `jsr166.jar` to be used across JDK versions. This was a follow-up fix after > JDK-8207146 had renamed these methods to `xxReference*'. > > Since OpenJDK is now the single source of truth for `java.util.concurrent`, > time has come to remove these deprecated alias methods. > > This change was initially discussed here: > https://mail.openjdk.org/pipermail/core-libs-dev/2024-March/119993.html > > Testing: This is a pure deletion of deprecated methods, so the PR includes no > test changes and the `noreg-cleanup` label is added in the JBS. I have > verified that all `test/jdk/java/util/concurrent/*` tests pass. > > Tagging @DougLea and @Martin-Buchholz to verify that this removal is timely. Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision: Use getAndSetReference instead of getAndSetObject in test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeLoadStoreMergedHeapStableTests.java - Changes: - all: https://git.openjdk.org/jdk/pull/18176/files - new: https://git.openjdk.org/jdk/pull/18176/files/997056d5..a333ed30 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18176&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18176&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18176.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18176/head:pull/18176 PR: https://git.openjdk.org/jdk/pull/18176
