Re: [darktable-dev] Can't test locally generated noise profile
Hi, On 05/18/2016 02:18 PM, Pedro Côrte-Real wrote: > On Wed, May 18, 2016 at 10:38 AM, Terry Duell wrote: >> but I'm only guessing how the 'gen-profile' script uses this info. I'm not >> sure if the 'mode="dng" ' is appropriate as the raw files may be dng or pef. > If the camera also does PEF then a full entry is needed. Did you open > a camera support issue with a sample PEF file? According to the specifications[1], PEF is not supported. This was also the case for the last APS-C Pentax cameras, they are now all DNG-only :) Sebastian [1]: http://www.ricoh-imaging.co.uk/en/digital-mirrorless/specifications/K01.html -- python programming - mail server - photo - video - https://sebix.at cryptographic key at https://sebix.at/DC9B463B.asc and on public keyservers signature.asc Description: OpenPGP digital signature
[darktable-dev] Re: PSA: OpenSUSE nightly builds have moved.
Thanks ... got it now should have known to use the distro specific ... sorry 'bout that Thanks for the quick help David On 05/18/2016 01:35 PM, Roman Lebedev wrote: On Wed, May 18, 2016 at 11:29 PM, David Vincent-Jones wrote: The repos are not accepting this url currently ... maybe I need to be patient? (i'm using debian, so it was impossible for me to change anything) I guess, i should have linked this, but i fear the url is too long: https://software.opensuse.org/download.html?project=home%3Adarix%3Adarktable%3Amaster&package=darktable Otherwise, in the url i linked in the mail, are you trying to add it itself, instead of one of the distro-specific links that is listed on that page? David Roman. On 05/18/2016 01:23 PM, Roman Lebedev wrote: Hello all users of darktable on opensuse :) From now on, the recommended repository for darktable nightly builds is http://download.opensuse.org/repositories/home:/darix:/darktable:/master/ https://www.darktable.org/install/#opensuse has been updated. Roman. On Wed, May 18, 2016 at 10:35 PM, David Vincent-Jones wrote: This should tell all!! http://download.opensuse.org/repositories/home:/toganm:/photography/ As referenced on the dt site. David On 05/18/2016 12:31 PM, Roman Lebedev wrote: On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones wrote: Not sure why I am getting that version information ... I am using the OpenSUSE nightly build and it appears to me to include all of the latest bells and whistles. Okay, which one specifically? https://build.opensuse.org/package/show/home:darix:darktable:master/darktable ? I reported the result of $darktable --version which is the same that I see on the dt screen. Good. But that is broken and needs to be fixed. So we'd like to know who provides those nightly builds :) David Roman. On 05/18/2016 11:51 AM, Roman Lebedev wrote: On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Re: PSA: OpenSUSE nightly builds have moved.
On Wed, May 18, 2016 at 11:29 PM, David Vincent-Jones wrote: > The repos are not accepting this url currently ... maybe I need to be > patient? (i'm using debian, so it was impossible for me to change anything) I guess, i should have linked this, but i fear the url is too long: https://software.opensuse.org/download.html?project=home%3Adarix%3Adarktable%3Amaster&package=darktable Otherwise, in the url i linked in the mail, are you trying to add it itself, instead of one of the distro-specific links that is listed on that page? > David Roman. > On 05/18/2016 01:23 PM, Roman Lebedev wrote: >> >> Hello all users of darktable on opensuse :) >> >> From now on, the recommended repository for darktable nightly builds is >> http://download.opensuse.org/repositories/home:/darix:/darktable:/master/ >> >> https://www.darktable.org/install/#opensuse has been updated. >> >> Roman. >> >> On Wed, May 18, 2016 at 10:35 PM, David Vincent-Jones >> wrote: >>> >>> This should tell all!! >>> >>> http://download.opensuse.org/repositories/home:/toganm:/photography/ >>> >>> As referenced on the dt site. >>> >>> David >>> >>> >>> On 05/18/2016 12:31 PM, Roman Lebedev wrote: On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones wrote: > > Not sure why I am getting that version information ... I am using the > OpenSUSE nightly build and it appears to me to include all of the > latest > bells and whistles. Okay, which one specifically? https://build.opensuse.org/package/show/home:darix:darktable:master/darktable ? > I reported the result of $darktable --version which is the same that I > see > on the dt screen. Good. But that is broken and needs to be fixed. So we'd like to know who provides those nightly builds :) > David Roman. > On 05/18/2016 11:51 AM, Roman Lebedev wrote: >> >> On Wed, May 18, 2016 at 9:37 PM, David >> Vincent-Jones >> wrote: I am running on a fresh install ver:1.7.0.1463568662.d724dea >> >> Huh? >> How do you build darktable? >> It should be 2.1.0something >> > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Re: PSA: OpenSUSE nightly builds have moved.
The repos are not accepting this url currently ... maybe I need to be patient? David On 05/18/2016 01:23 PM, Roman Lebedev wrote: Hello all users of darktable on opensuse :) From now on, the recommended repository for darktable nightly builds is http://download.opensuse.org/repositories/home:/darix:/darktable:/master/ https://www.darktable.org/install/#opensuse has been updated. Roman. On Wed, May 18, 2016 at 10:35 PM, David Vincent-Jones wrote: This should tell all!! http://download.opensuse.org/repositories/home:/toganm:/photography/ As referenced on the dt site. David On 05/18/2016 12:31 PM, Roman Lebedev wrote: On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones wrote: Not sure why I am getting that version information ... I am using the OpenSUSE nightly build and it appears to me to include all of the latest bells and whistles. Okay, which one specifically? https://build.opensuse.org/package/show/home:darix:darktable:master/darktable ? I reported the result of $darktable --version which is the same that I see on the dt screen. Good. But that is broken and needs to be fixed. So we'd like to know who provides those nightly builds :) David Roman. On 05/18/2016 11:51 AM, Roman Lebedev wrote: On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] PSA: OpenSUSE nightly builds have moved.
Hello all users of darktable on opensuse :) >From now on, the recommended repository for darktable nightly builds is http://download.opensuse.org/repositories/home:/darix:/darktable:/master/ https://www.darktable.org/install/#opensuse has been updated. Roman. On Wed, May 18, 2016 at 10:35 PM, David Vincent-Jones wrote: > This should tell all!! > > http://download.opensuse.org/repositories/home:/toganm:/photography/ > > As referenced on the dt site. > > David > > > On 05/18/2016 12:31 PM, Roman Lebedev wrote: >> >> On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones >> wrote: >>> >>> Not sure why I am getting that version information ... I am using the >>> OpenSUSE nightly build and it appears to me to include all of the latest >>> bells and whistles. >> >> Okay, which one specifically? >> >> https://build.opensuse.org/package/show/home:darix:darktable:master/darktable >> ? >> >>> I reported the result of $darktable --version which is the same that I >>> see >>> on the dt screen. >> >> Good. But that is broken and needs to be fixed. >> So we'd like to know who provides those nightly builds :) >> >>> David >> >> Roman. >> >>> On 05/18/2016 11:51 AM, Roman Lebedev wrote: On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: >> >> I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
This should tell all!! http://download.opensuse.org/repositories/home:/toganm:/photography/ As referenced on the dt site. David On 05/18/2016 12:31 PM, Roman Lebedev wrote: On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones wrote: Not sure why I am getting that version information ... I am using the OpenSUSE nightly build and it appears to me to include all of the latest bells and whistles. Okay, which one specifically? https://build.opensuse.org/package/show/home:darix:darktable:master/darktable ? I reported the result of $darktable --version which is the same that I see on the dt screen. Good. But that is broken and needs to be fixed. So we'd like to know who provides those nightly builds :) David Roman. On 05/18/2016 11:51 AM, Roman Lebedev wrote: On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
On Wed, May 18, 2016 at 10:15 PM, David Vincent-Jones wrote: > Not sure why I am getting that version information ... I am using the > OpenSUSE nightly build and it appears to me to include all of the latest > bells and whistles. Okay, which one specifically? https://build.opensuse.org/package/show/home:darix:darktable:master/darktable ? > I reported the result of $darktable --version which is the same that I see > on the dt screen. Good. But that is broken and needs to be fixed. So we'd like to know who provides those nightly builds :) > David Roman. > On 05/18/2016 11:51 AM, Roman Lebedev wrote: >> >> On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones >> wrote: >>> >>> >I am running on a fresh install ver:1.7.0.1463568662.d724dea >> >> Huh? >> How do you build darktable? >> It should be 2.1.0something >> > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF
Am 18.05.2016 um 21:08 schrieb Tobias Ellinghaus: >>> Please open src/libs/metadata_view.c in a text editor and make sure that >>> SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and >>> check the image information of the PNG. There should be a line "Flags" >>> now. What does it say for the PNG? >> >> It says: Flags 0..l...ap... >> The same flags are shown for the TIF. >> >> Both, PNG and TIF, have been created by DT. > > That means that darktable doesn't think those are raw files. So it must be > something else. Could you upload a sample image exported from darktable that > shows the wrong behaviour please? Here is a small example PNG (800x534) : https://www.dropbox.com/s/b7t6pufeym70b3q/IMG_4339-800.png?dl=0 Matthias ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
Not sure why I am getting that version information ... I am using the OpenSUSE nightly build and it appears to me to include all of the latest bells and whistles. I reported the result of $darktable --version which is the same that I see on the dt screen. David On 05/18/2016 11:51 AM, Roman Lebedev wrote: On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: >I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF
Am Mittwoch, 18. Mai 2016, 20:39:41 schrieb Matthias Bodenbinder: > Am 18.05.2016 um 11:05 schrieb Tobias Ellinghaus: > > Am Mittwoch, 18. Mai 2016, 08:05:35 schrieb Matthias Bodenbinder: > >> Am 17.05.2016 um 22:44 schrieb Matthias Bodenbinder: > >>> Am 17.05.2016 um 10:36 schrieb Tobias Ellinghaus: > Am Samstag, 14. Mai 2016, 15:34:41 schrieb Matthias Bodenbinder: > > Hi, > > > > I am struggling with my presets (DT 2.0.4). I have a basecurve preset > > that > > is applied to all my RAW (CR2). Unfortunately the same preset is also > > applied to the exported PNG, JPG and TIF when I import them. How can I > > prevent that? > > > > I found this issue report https://redmine.darktable.org/issues/9540 > > which is describing exactly my problem. It is from 2013 and the last > > comment is that it is fixed. But I can not find it. > > > > My basecurve presets are always applied. The attached screenshot shows > > the > > preset dialog. I have only selected "Format: RAW" but that does not > > help. > > It might be that the exported files look like a raw to darktable for > some > reason, maybe because of embedded metadata copied over from the > original > file. > > Do you have a way to compile darktable yourself? That would make it > easier to find out what is happening. > >>> > >>> I do compile myself. > >>> > >>> Matthias > >> > >> What should I test? > > > > Please open src/libs/metadata_view.c in a text editor and make sure that > > SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and > > check the image information of the PNG. There should be a line "Flags" > > now. What does it say for the PNG? > > It says: Flags 0..l...ap... > The same flags are shown for the TIF. > > Both, PNG and TIF, have been created by DT. That means that darktable doesn't think those are raw files. So it must be something else. Could you upload a sample image exported from darktable that shows the wrong behaviour please? > Matthias Tobias signature.asc Description: This is a digitally signed message part.
Re: [darktable-dev] weird colours when using several color modules
On Wed, May 18, 2016 at 9:37 PM, David Vincent-Jones wrote: > I am running on a fresh install ver:1.7.0.1463568662.d724dea Huh? How do you build darktable? It should be 2.1.0something > Opensuse/gnome and NO OpenCL is installed > Problem is very intermittent on my system ... comes and goes as I move > primary or blend slider. Ok, so i guess this is some kind of race condition, much more reproducible on less powerful machines. > David Roman. > On 05/17/2016 11:28 AM, Ulrich Pegelow wrote: >> >> Am 17.05.2016 um 20:21 schrieb Roman Lebedev: >>> >>> On Tue, May 17, 2016 at 9:13 PM, Ulrich Pegelow >>> wrote: Hi, I can confirm your issue. You are running with OpenCL enabled? It looks like >>> >>> I have introduced an issue when porting xtrans demosaicing to OpenCL. >>> >>> >>> Are you really sure? >> >> >> No, not sure. You are probably right, the issue has been introduced >> lately. If I go back in time a few days (commit >> 1b955380447ac717674ce05f3e9c6e6f0a3b8cc6) all seems good. >> >> Unfortunately I cannot bisect as my gcc 4.8.3 has issues compiling >> in-between commits. >> >> Maybe you can try to do that. At least here the problem can be quickly >> reproduced when quickly wheel-scrolling a few times over the exposure slider >> in the exposure module. >> >> Best wishes >> >> Ulrich >> >> >>> I'm somewhat expecting this to be due to >>> >>> https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c >>> and >>> >>> https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 >>> >>> but i do not understand what is missing... >>> >>> FWIW i was able to reproduce the issue without opencl, and only rarely, >>> when loading image in darkroom and just only changing colorzones once. >>> What I see are spurious color distortions (typically towards magenta) when quickly changing some slider value like the exposure compensation. At the moment I cannot really say why we have these intermittent errors. This needs some in depth investigations. Ulrich >>> >>> Roman. >> >> >> >> ___ >> darktable developer mailing list >> to unsubscribe send a mail to >> darktable-dev+unsubscr...@lists.darktable.org >> > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
[darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF
Am 18.05.2016 um 11:05 schrieb Tobias Ellinghaus: > Am Mittwoch, 18. Mai 2016, 08:05:35 schrieb Matthias Bodenbinder: >> Am 17.05.2016 um 22:44 schrieb Matthias Bodenbinder: >>> Am 17.05.2016 um 10:36 schrieb Tobias Ellinghaus: Am Samstag, 14. Mai 2016, 15:34:41 schrieb Matthias Bodenbinder: > Hi, > > I am struggling with my presets (DT 2.0.4). I have a basecurve preset > that > is applied to all my RAW (CR2). Unfortunately the same preset is also > applied to the exported PNG, JPG and TIF when I import them. How can I > prevent that? > > I found this issue report https://redmine.darktable.org/issues/9540 > which is describing exactly my problem. It is from 2013 and the last > comment is that it is fixed. But I can not find it. > > My basecurve presets are always applied. The attached screenshot shows > the > preset dialog. I have only selected "Format: RAW" but that does not > help. It might be that the exported files look like a raw to darktable for some reason, maybe because of embedded metadata copied over from the original file. Do you have a way to compile darktable yourself? That would make it easier to find out what is happening. >>> >>> I do compile myself. >>> >>> Matthias >> >> What should I test? > > Please open src/libs/metadata_view.c in a text editor and make sure that > SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and check > the image information of the PNG. There should be a line "Flags" now. What > does it say for the PNG? It says: Flags 0..l...ap... The same flags are shown for the TIF. Both, PNG and TIF, have been created by DT. Matthias ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
I am running on a fresh install ver:1.7.0.1463568662.d724dea Opensuse/gnome and NO OpenCL is installed Problem is very intermittent on my system ... comes and goes as I move primary or blend slider. David On 05/17/2016 11:28 AM, Ulrich Pegelow wrote: Am 17.05.2016 um 20:21 schrieb Roman Lebedev: On Tue, May 17, 2016 at 9:13 PM, Ulrich Pegelow wrote: Hi, I can confirm your issue. You are running with OpenCL enabled? It looks like I have introduced an issue when porting xtrans demosaicing to OpenCL. Are you really sure? No, not sure. You are probably right, the issue has been introduced lately. If I go back in time a few days (commit 1b955380447ac717674ce05f3e9c6e6f0a3b8cc6) all seems good. Unfortunately I cannot bisect as my gcc 4.8.3 has issues compiling in-between commits. Maybe you can try to do that. At least here the problem can be quickly reproduced when quickly wheel-scrolling a few times over the exposure slider in the exposure module. Best wishes Ulrich I'm somewhat expecting this to be due to https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c and https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 but i do not understand what is missing... FWIW i was able to reproduce the issue without opencl, and only rarely, when loading image in darkroom and just only changing colorzones once. What I see are spurious color distortions (typically towards magenta) when quickly changing some slider value like the exposure compensation. At the moment I cannot really say why we have these intermittent errors. This needs some in depth investigations. Ulrich Roman. ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
I've been debugging various codepaths but nothing definitive -- it happens every few parameter changes, with no apparent pattern to occurrences. I don't have a deep understanding of the pixelpipe. Could it be the piece->pipe->xtrans for some mosaic-dependent iop after rawprepare gets initialized to the non-shifted CFA and never catches the shift done in rawprepare? Could there be a race condition with pipe/iop initializations which could cause this? This definitely is in a083e4c and successive commits including 5590478. Roman Lebedev writes: > On Wed, May 18, 2016 at 6:20 PM, Dan Torop wrote: >> From here a bisect suggests >> https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c >> as the troublemaking commit. > Not surprising. Thanks for bisecting it though. > (but does it still happen with the next commit > https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 > i guess it does) > >> Fiddling with color balance seems a good way to cause this. I've also seen >> it when fiddling with white balance. > >>The preview in the navigation panel shows correct color, while the full image >>view shows the weird colors. > Yep, because preview is demosaiced way before any pipe runs on it. > >> I can see this when the view is "fit to screen" or 100%. > >>In the later case, the image looks suspiciously like a CFA problem.See >>https://i.imgur.com/NG4G1y6.jpg. > It definitely is. > Either i forgot to change something to use piece->pipe->xtrans > instead of xtrans field in dt_image_t, > or missed some codepath that leads to it being set to wrong values. > >> >> This is with OpenCL disabled and an X-Trans image. Will keep looking into >> this. > No opencl here, and so far i have not seen this on bayer images. > >> Dan > Roman. > >> Ulrich Pegelow writes: >> >>> Am 17.05.2016 um 20:21 schrieb Roman Lebedev: On Tue, May 17, 2016 at 9:13 PM, Ulrich Pegelow wrote: > Hi, > > I can confirm your issue. You are running with OpenCL enabled? It looks > like > I have introduced an issue when porting xtrans demosaicing to OpenCL. Are you really sure? >>> >>> No, not sure. You are probably right, the issue has been introduced >>> lately. If I go back in time a few days (commit >>> 1b955380447ac717674ce05f3e9c6e6f0a3b8cc6) all seems good. >>> >>> Unfortunately I cannot bisect as my gcc 4.8.3 has issues compiling >>> in-between commits. >>> >>> Maybe you can try to do that. At least here the problem can be quickly >>> reproduced when quickly wheel-scrolling a few times over the exposure >>> slider in the exposure module. >>> >>> Best wishes >>> >>> Ulrich >>> >>> I'm somewhat expecting this to be due to https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c and https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 but i do not understand what is missing... FWIW i was able to reproduce the issue without opencl, and only rarely, when loading image in darkroom and just only changing colorzones once. > What I > see are spurious color distortions (typically towards magenta) when > quickly > changing some slider value like the exposure compensation. At the moment I > cannot really say why we have these intermittent errors. This needs some > in > depth investigations. > > Ulrich Roman. >>> >>> ___ >>> darktable developer mailing list >>> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org >> ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
On 18/05/2016 17:57, Roman Lebedev wrote: > On Wed, May 18, 2016 at 6:20 PM, Dan Torop wrote: >> From here a bisect suggests >> https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c >> as the troublemaking commit. > Not surprising. Thanks for bisecting it though. > (but does it still happen with the next commit > https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 > i guess it does) > >> Fiddling with color balance seems a good way to cause this. I've also seen >> it when fiddling with white balance. >> The preview in the navigation panel shows correct color, while the full >> image view shows the weird colors. > Yep, because preview is demosaiced way before any pipe runs on it. > >> I can see this when the view is "fit to screen" or 100%. >> In the later case, the image looks suspiciously like a CFA problem.See >> https://i.imgur.com/NG4G1y6.jpg. > It definitely is. > Either i forgot to change something to use piece->pipe->xtrans > instead of xtrans field in dt_image_t, > or missed some codepath that leads to it being set to wrong values. > >> This is with OpenCL disabled and an X-Trans image. Will keep looking into >> this. > No opencl here, and so far i have not seen this on bayer images. > I don't know if this of any importance… I'm using OpenCL… and have the problem of course, as I reported it :) ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
On Wed, May 18, 2016 at 6:20 PM, Dan Torop wrote: > From here a bisect suggests > https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c > as the troublemaking commit. Not surprising. Thanks for bisecting it though. (but does it still happen with the next commit https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 i guess it does) > Fiddling with color balance seems a good way to cause this. I've also seen it > when fiddling with white balance. >The preview in the navigation panel shows correct color, while the full image >view shows the weird colors. Yep, because preview is demosaiced way before any pipe runs on it. > I can see this when the view is "fit to screen" or 100%. >In the later case, the image looks suspiciously like a CFA problem.See >https://i.imgur.com/NG4G1y6.jpg. It definitely is. Either i forgot to change something to use piece->pipe->xtrans instead of xtrans field in dt_image_t, or missed some codepath that leads to it being set to wrong values. > > This is with OpenCL disabled and an X-Trans image. Will keep looking into > this. No opencl here, and so far i have not seen this on bayer images. > Dan Roman. > Ulrich Pegelow writes: > >> Am 17.05.2016 um 20:21 schrieb Roman Lebedev: >>> On Tue, May 17, 2016 at 9:13 PM, Ulrich Pegelow >>> wrote: Hi, I can confirm your issue. You are running with OpenCL enabled? It looks like >>> I have introduced an issue when porting xtrans demosaicing to OpenCL. >>> >>> Are you really sure? >> >> No, not sure. You are probably right, the issue has been introduced >> lately. If I go back in time a few days (commit >> 1b955380447ac717674ce05f3e9c6e6f0a3b8cc6) all seems good. >> >> Unfortunately I cannot bisect as my gcc 4.8.3 has issues compiling >> in-between commits. >> >> Maybe you can try to do that. At least here the problem can be quickly >> reproduced when quickly wheel-scrolling a few times over the exposure >> slider in the exposure module. >> >> Best wishes >> >> Ulrich >> >> >>> I'm somewhat expecting this to be due to >>> https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c >>> and >>> https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 >>> >>> but i do not understand what is missing... >>> >>> FWIW i was able to reproduce the issue without opencl, and only rarely, >>> when loading image in darkroom and just only changing colorzones once. >>> What I see are spurious color distortions (typically towards magenta) when quickly changing some slider value like the exposure compensation. At the moment I cannot really say why we have these intermittent errors. This needs some in depth investigations. Ulrich >>> Roman. >> >> ___ >> darktable developer mailing list >> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] weird colours when using several color modules
>From here a bisect suggests >https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c > as the troublemaking commit. Fiddling with color balance seems a good way to cause this. I've also seen it when fiddling with white balance. The preview in the navigation panel shows correct color, while the full image view shows the weird colors. I can see this when the view is "fit to screen" or 100%. In the later case, the image looks suspiciously like a CFA problem. See https://i.imgur.com/NG4G1y6.jpg. This is with OpenCL disabled and an X-Trans image. Will keep looking into this. Dan Ulrich Pegelow writes: > Am 17.05.2016 um 20:21 schrieb Roman Lebedev: >> On Tue, May 17, 2016 at 9:13 PM, Ulrich Pegelow >> wrote: >>> Hi, >>> >>> I can confirm your issue. You are running with OpenCL enabled? It looks like >> >>> I have introduced an issue when porting xtrans demosaicing to OpenCL. >> >> Are you really sure? > > No, not sure. You are probably right, the issue has been introduced > lately. If I go back in time a few days (commit > 1b955380447ac717674ce05f3e9c6e6f0a3b8cc6) all seems good. > > Unfortunately I cannot bisect as my gcc 4.8.3 has issues compiling > in-between commits. > > Maybe you can try to do that. At least here the problem can be quickly > reproduced when quickly wheel-scrolling a few times over the exposure > slider in the exposure module. > > Best wishes > > Ulrich > > >> I'm somewhat expecting this to be due to >> https://github.com/darktable-org/darktable/commit/a083e4c0f9ffc0423613f3a75e5e3457aa11430c >> and >> https://github.com/darktable-org/darktable/commit/5590478c7bede4061ab06b013d8d227135d08005 >> >> but i do not understand what is missing... >> >> FWIW i was able to reproduce the issue without opencl, and only rarely, >> when loading image in darkroom and just only changing colorzones once. >> >>> What I >>> see are spurious color distortions (typically towards magenta) when quickly >>> changing some slider value like the exposure compensation. At the moment I >>> cannot really say why we have these intermittent errors. This needs some in >>> depth investigations. >>> >>> Ulrich >> Roman. > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Can't test locally generated noise profile
On Wed, May 18, 2016 at 10:38 AM, Terry Duell wrote: > OK, you understand this much better than I, but from what I have seen in the > exif and my manual edits to the presets file that work, I would guess it may > need to be more like... > > > Pentax K-1 I just copied the Pentax 645 entry, it needs to match the exif exactly so yours is probably the correct one. > but I'm only guessing how the 'gen-profile' script uses this info. I'm not > sure if the 'mode="dng" ' is appropriate as the raw files may be dng or pef. If the camera also does PEF then a full entry is needed. Did you open a camera support issue with a sample PEF file? Pedro ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Can't test locally generated noise profile
Hello Pedro, On Wed, 18 May 2016 18:50:35 +1000, Pedro Côrte-Real wrote: On Wed, May 18, 2016 at 4:13 AM, Terry Duell wrote: So that part is more or less sorted at this end, but it does suggest that the profiling script 'gen-profile' isn't working correctly with the K-1 sample images, i.e. it is collecting the wrong maker and model strings. The script just guesses what name we want to use. In this case it seems to have guessed correctly the pattern we have been using lately. To make it match you need something like this in cameras.xml: PENTAX K1 OK, you understand this much better than I, but from what I have seen in the exif and my manual edits to the presets file that work, I would guess it may need to be more like... Pentax K-1 but I'm only guessing how the 'gen-profile' script uses this info. I'm not sure if the 'mode="dng" ' is appropriate as the raw files may be dng or pef. Hopefully, someone can update 'cameras.xml' so the K-1 is properly supported and we don't continue to have the problems I have come across. Thanks for your help. Cheers, -- Regards, Terry Duell ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Re: RAW presets get applied to JPG, PNG and TIF
Am Mittwoch, 18. Mai 2016, 08:05:35 schrieb Matthias Bodenbinder: > Am 17.05.2016 um 22:44 schrieb Matthias Bodenbinder: > > Am 17.05.2016 um 10:36 schrieb Tobias Ellinghaus: > >> Am Samstag, 14. Mai 2016, 15:34:41 schrieb Matthias Bodenbinder: > >>> Hi, > >>> > >>> I am struggling with my presets (DT 2.0.4). I have a basecurve preset > >>> that > >>> is applied to all my RAW (CR2). Unfortunately the same preset is also > >>> applied to the exported PNG, JPG and TIF when I import them. How can I > >>> prevent that? > >>> > >>> I found this issue report https://redmine.darktable.org/issues/9540 > >>> which is describing exactly my problem. It is from 2013 and the last > >>> comment is that it is fixed. But I can not find it. > >>> > >>> My basecurve presets are always applied. The attached screenshot shows > >>> the > >>> preset dialog. I have only selected "Format: RAW" but that does not > >>> help. > >> > >> It might be that the exported files look like a raw to darktable for some > >> reason, maybe because of embedded metadata copied over from the original > >> file. > >> > >> Do you have a way to compile darktable yourself? That would make it > >> easier to find out what is happening. > > > > I do compile myself. > > > > Matthias > > What should I test? Please open src/libs/metadata_view.c in a text editor and make sure that SHOW_FLAGS is defined as 1 (around line 39). Then recompile/install and check the image information of the PNG. There should be a line "Flags" now. What does it say for the PNG? > One more important info regarding this problem: > > It is only the basecurve preset which is applied to PNG/TIF files. Presets > like for denoise and sharpening are not applied automatically although they > have a similar filter. > > See the two screenshots. History stack was removed before opening the > pictures in darkroom: (1) Modules applied to PNG file (2) Modules applied > to CR2 files > > > Matthias > > ___ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org signature.asc Description: This is a digitally signed message part.
Re: [darktable-dev] Can't test locally generated noise profile
On Wed, May 18, 2016 at 4:13 AM, Terry Duell wrote: > So that part is more or less sorted at this end, but it does suggest that > the profiling script 'gen-profile' isn't working correctly with the K-1 > sample images, i.e. it is collecting the wrong maker and model strings. The script just guesses what name we want to use. In this case it seems to have guessed correctly the pattern we have been using lately. To make it match you need something like this in cameras.xml: PENTAX K1 Pedro ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
