[darktable-dev] What is the gamma.c IOP ?

[Aurélien Pierre]

Hi Jo !

Thanks for your answer.

So this doesn't explain why the global colorpicker readings change
depending on the display ICC profile, nor why using a log encoding
between -2.5 and 2.5 EV, the grey gets remapped to L = 77 instead of 50.

I believe there is a gamma correction where it doesn't belong. Where is
the code for the colorpicker ?

Regards,

Aurélien.

Le 02/11/2018 à 06:17, johannes hanika a écrit :
> heya,
>
> it used to do the gamma in the olden days. now it just does what you
> observed: convert to uint8 for display and any marshalling of data at
> the end of the pipeline in gui mode can take place here. it's
> certainly not applying gamma. i suppose we could delete these old
> gamma lut table lines of code and just round directly in process().
>
> cheers,
>  jo
> On Thu, Nov 1, 2018 at 3:52 PM Aurélien Pierre
>  wrote:
>> Hi,
>>
>> there is in dt an hidden IOP named gamma.c that is the last one in the 
>> pixelpipe. Looking at the code, it is useful to display the masks and 
>> convert the pixels to uint8 values.
>>
>> However, it does a gamma conversion too, with a linear and gamma parameters. 
>> First of all, this conversion seems damaging in a calibrated and linear 
>> workflow because it (seems to) prevents the color picker to get accurate 
>> pixel values readings.
>>
>> Then, I don't see where the gamma and linear parameters are grabbed. Could 
>> anyone tell me what it does and how ? Having an arbitrary gamma conversion 
>> there could be redundant with the display gamma and is a serious matter for 
>> color management.
>>
>> Thanks,
>>
>> Aurélien.
>>
>>
>> ___ 
>> darktable developer mailing list to unsubscribe send a mail to 
>> darktable-dev+unsubscr...@lists.darktable.org
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Compile error: rawspeed/src/librawspeed/common/Common.h:87:1: error: body of ‘constexpr’ function

[Postmaster]

It does appear that cmake requires rawspeed. I can only presume that 
darktable requires it. cmake lets u know that it wants rawspeed/ anyway 
someone created the cmake scripts. Anyway someone created the error 
messages. It was not cmake that created them.


On 11/2/18 8:41 AM, Sturm Flut wrote:

in librawspeed and has little to do with CMake or even darktable at first.



watt kaan i do but to resolve these cmake scripts gotcha's


-- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1")
-- Found msgfmt to convert .po file. Translation enabled
CMake Error at src/external/CMakeLists.txt:11 (message):
  RawSpeed submodule not found.  You probably want to run:

  $ git submodule init

  and then

  $ git submodule update


-- Configuring incomplete, errors occurred!
See also 
"/home/Photographer/Devel/darktable-release-2.4.4/build/CMakeFiles/CMakeOutput.log".
See also 
"/home/Photographer/Devel/darktable-release-2.4.4/build/CMakeFiles/CMakeError.log".


so far i have not compiled anything.

from:https://www.darktable.org/install/ ::Install from source
where does

"rawspeed (supplied), "

come from? Cant use "git submodule init" as it errors out. :(
src from : > 
https://github.com/darktable-org/darktable/archive/release-2.4.4.tar.gz



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable lag on a 4K monitor.

[Sturm Flut]

Hi Andreas,

Am 02.11.18 um 13:23 schrieb Andreas Schneider:
> On Friday, 2 November 2018 12:58:52 CET Sturm Flut wrote:
>> Dear list,
>>
>> I guess this can also depend a lot on the hardware and the specific
>> X.Org/Mesa/GTK/driver version combinations. I've been using darktable on
>> a 4K display with Arch Linux running on a Ryzen 1600X for one and a half
>> years and there haven't been any noticeable lags, neither with the old
>> NVIDIA GTX950 nor the new AMD RX570 GPU.
> 
> There definitely is, I'm running on openSUSE Tumbleweed, which is likely the 
> same as you're running. And yes there is an event storm going on if you move 
> the mouse.

I don't doubt that you experience lags and that there is an event storm
going on :)

I just wanted to add the data point that at least on my specific setup I
never really felt impaired by UI lags, at least not to the point where I
suspected that something might be wrong. Would be nice to know why.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Compile error: rawspeed/src/librawspeed/common/Common.h:87:1: error: body of ‘constexpr’ function

[Sturm Flut]

Hi,

Am 31.10.18 um 16:50 schrieb Postmaster:

> Its not so easy to make this work. cmake seems to be an issue.

>From what I've been seeing in a couple of mails now, it feels like you
might be running into issues which seem to be more specific to RHEL and
Fedora than to darktable and the general GNU/Linux ecosystem. CMake is a
build system, the error message in your last e-mail is a compiler error
in librawspeed and has little to do with CMake or even darktable at first.

Especially Fedora 28 has a lot of bleeding-edge stuff and seems to do
some things differently than everyone else, which has already caused
compilation failures for multiple projects in the past (see e.g.
https://www.mail-archive.com/darktable-dev@lists.darktable.org/msg03229.html).
There don't seem to be too many developers and users around who use
Fedora on a regular basis, so someone might know how to build the
packages, but darktable's own documentation might lack behind.

It might be easier to try to build darktable on one of the "more common"
and "better supported" distributions, especially if you've never done it
before.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable lag on a 4K monitor.

[Andreas Schneider]

On Friday, 2 November 2018 12:58:52 CET Sturm Flut wrote:
> Dear list,
> 
> I guess this can also depend a lot on the hardware and the specific
> X.Org/Mesa/GTK/driver version combinations. I've been using darktable on
> a 4K display with Arch Linux running on a Ryzen 1600X for one and a half
> years and there haven't been any noticeable lags, neither with the old
> NVIDIA GTX950 nor the new AMD RX570 GPU.

There definitely is, I'm running on openSUSE Tumbleweed, which is likely the 
same as you're running. And yes there is an event storm going on if you move 
the mouse.


Andreas

-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable lag on a 4K monitor.

[Sturm Flut]

Dear list,

I guess this can also depend a lot on the hardware and the specific
X.Org/Mesa/GTK/driver version combinations. I've been using darktable on
a 4K display with Arch Linux running on a Ryzen 1600X for one and a half
years and there haven't been any noticeable lags, neither with the old
NVIDIA GTX950 nor the new AMD RX570 GPU.

kind regards,
Simon




Am 02.11.18 um 05:05 schrieb August Schwerdfeger:
> Darktable 2.4.3 and .4, MacOS and Fedora.
> 
> When using Darktable on a 4K monitor, I am experiencing a UI lag that
> seems dependent on the size of the application window.
> 
> For example, when I size the window with dimensions that are half those
> of the screen, the image highlight in the light table follows my mouse
> pointer with no noticeable lag. Resizing to three-quarters of the screen
> dimensions introduces a delay of about half a second between the time
> the pointer moves and the time the highlight changes. Resizing to full
> screen increases this lag to about a second.
> 
> Does anyone know what is causing this?
> 
> --
> August Schwerdfeger
> aug...@schwerdfeger.name 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] What is the gamma.c IOP ?

[johannes hanika]

heya,

it used to do the gamma in the olden days. now it just does what you
observed: convert to uint8 for display and any marshalling of data at
the end of the pipeline in gui mode can take place here. it's
certainly not applying gamma. i suppose we could delete these old
gamma lut table lines of code and just round directly in process().

cheers,
 jo
On Thu, Nov 1, 2018 at 3:52 PM Aurélien Pierre
 wrote:
>
> Hi,
>
> there is in dt an hidden IOP named gamma.c that is the last one in the 
> pixelpipe. Looking at the code, it is useful to display the masks and convert 
> the pixels to uint8 values.
>
> However, it does a gamma conversion too, with a linear and gamma parameters. 
> First of all, this conversion seems damaging in a calibrated and linear 
> workflow because it (seems to) prevents the color picker to get accurate 
> pixel values readings.
>
> Then, I don't see where the gamma and linear parameters are grabbed. Could 
> anyone tell me what it does and how ? Having an arbitrary gamma conversion 
> there could be redundant with the display gamma and is a serious matter for 
> color management.
>
> Thanks,
>
> Aurélien.
>
>
> ___ 
> darktable developer mailing list to unsubscribe send a mail to 
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable lag on a 4K monitor.

[Pascal Obry]

Hi August,

Right, I have a "workaround" for this:

https://github.com/TurboGit/darktable/commit/8506770fef89e8750320efec9e8c633fe3097dc1

Not sure if it still apply or not. But the idea was to skip as much as
possible Gtk event when moving over the lighttable. This is not a real
solution, just a workaround.

I don't know what could be the real solution, probably have each thumbs a
separate "widget" and so have a single enter or leave Gtk event for each
one.

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://photos.obry.net
  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Darktable lag on a 4K monitor.

[Andreas Schneider]

On Friday, 2 November 2018 05:05:51 CET August Schwerdfeger wrote:
> Darktable 2.4.3 and .4, MacOS and Fedora.
> 
> When using Darktable on a 4K monitor, I am experiencing a UI lag that seems
> dependent on the size of the application window.
> 
> For example, when I size the window with dimensions that are half those of
> the screen, the image highlight in the light table follows my mouse pointer
> with no noticeable lag. Resizing to three-quarters of the screen dimensions
> introduces a delay of about half a second between the time the pointer
> moves and the time the highlight changes. Resizing to full screen increases
> this lag to about a second.
> 
> Does anyone know what is causing this?

Yes, the lighttable code isn't as good as it could be :-)

See https://redmine.darktable.org/issues/10764


It probably need a rewrite but I have no clue about GTK. If someone knows GTK 
I'm happy to do some pair-programming to fix it.


Andreas


-- 
Andreas Schneider a...@cryptomilk.org
GPG-ID: 8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org