Re: [darktable-dev] dtstyle.net

2019-09-02 Thread sturmflut
Hi,

as far as I know it is was created by Kees Guequierre .

cheers,
Simon



Am 02.09.19 um 10:39 schrieb Maurizio Paglia:
> Hi,
> anyone can tell me how to get in touch with people behind dtstyle.net
> ?
> 
> Thanks,
> Maurizio
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] JPG compression

2019-03-12 Thread sturmflut
Hi,

it looks like the E-Mail storage module doesn't store and read its
configuration, and also doesn't make sure the internal values are in
sync with the GUI elements. You have to re-set the compression level and
output size every time you switch to that output type.

cheers,
Simon



Am 27.02.19 um 00:44 schrieb David Vincent-Jones:
> After exporting to JPG format (95%) on the desktop at full (0,0)
> resolution, when I later export to email at lower (1500,1500) res. the
> compression does not change and I get a very large Mb. size output.
> 
> In order to get the correct email output I need to export to the desktop
> at a lower size and then go back to email export.
> 
> This has been an ongoing problem for some time.
> 
> darktable 2.7.0+497~g38a7407bb ... Manjaro with Arch Repos.
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL memory usage on integrated graphics

2019-03-12 Thread sturmflut
Hi,
Am 11.03.19 um 18:45 schrieb David Vincent-Jones:
> correctly but with 2 monitors the system is failing. Is it possible for
> me to blacklist my primary monitor in a way that memory is freed-up for
> the graphics display? If so, how would I do that .. can I do it through
> the Nvidia X Server Settings?

You should be able to simply disable it in the display settings of your
desktop environment (KDE, GNOME etc.), and the system should remember
that choice.

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens correction with FF lenses used on APS-C

2019-02-25 Thread sturmflut
Hi,

Am 24.02.19 um 13:32 schrieb Florian W:

> 1 This reasoning is mixing description of digital features with analog
> ones . A lens quality and specs is not defined by MP resolution (rather
> by like purity of the glass, glass curvature homogeneity, CoC, TCA, and
> so on).

You are right, things work a bit differently on the optics side before
the sensor. Hence my use of "oversimplyfing it a bit". But the
resolution of an optical system can still be measured (see e.g. Optical
transer function [1]), and you can specify how much contrast you expect
to see in details and what level of details you expect to still be visible.

It's hard to make exact quantitative statements like "this lens has an
optical transfer function which gives enough contrast for x line pairs
per millimeter, and that would be enough for an x megapixel sensor of
this and this size". Especially because glass quality even differs
within the same manufacturing batch. But for example with my blurry
70-300 it's easy to judge that it would probably be sharp enough for a
12 to 16 megapixel sensor, but nothing better.


> 2 Some of the lenses we're talking about were developed and (partially)
> targeted to FF cameras having a sensor with less MP than a current APS-C
> (for example in Canon, the 6D is a 2012 FF with 20MP).
> 
> If the reasoning is valid, a lens released at times of FF with 24MP or
> higher wouldn't be a good match to the previous cameras with less MP.
> Which doesn't seems to be the case.
>
> What I mean by this is that at some point, to ensure a lens will perform
> well on FF cameras that will be released the following decade, one can
> assume that the optical manufacturing quality is probably one order of
> magnitude above the quality required to fit the current camera sensor
> capabilities. Maybe explaining why you can see problems in older lenses.
I'm not saying that I see a general problem with older lenses, and I
already noted that your prime lenses probably won't cause much of problem.

There's simply a very, very wide range of lenses out there, and the
pricing, engineering and manufacturing decisions can lead to extremely
different optical properties. There are some prime lenses from the 1980s
which are still extremely sharp on today's sensors, but primes are easy.
Most have just seven or eight glass elements.

My Nikon 24-70/2.8 on the other hand has 20 lens elements in 16 groups.
The older Canon 70-200/2.8 has 23 lenses in 19 groups. Even the Nikon
16-35/4 has 17 lens elements. Obviously it is much harder to keep the
optical resolution at the same level when light has to pass through that
many pieces of glass and the lens still has to be affordable. So there
are FF lenses out there which will give good results on APS-C bodies,
but not all will. And you can easily end up getting worse image quality
with a FF lens on an APS-C body when you expected a better one because
the FF lens was more expensive and is supposed to be better.

Also manufacturers don't generally design lenses so thewy will work
perfectly with cameras released a decade later. They will design the
current top model so it has enough room to still be good on the next
model, but they still want you to buy the new "sharper than ever" lens
every five years.

cheers,
Simon










[1] https://en.wikipedia.org/wiki/Optical_transfer_function
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Crop tool is awkward for my use case

2019-02-18 Thread sturmflut
Hi,

the comment holds some validity in this particular case since darktable
can't losslessly crop a JPEG file, but other tools can. If the original
poster ended up just cropping (and not rotating) most files, something
like cropgui[1] would actually yield better image quality.

(Obviously this is an extreme edge case and I fully support the solution
with the modifier key proposed in the other thread. I just added this
for future reference.)

cheers,
Simon



[1] https://github.com/jepler/cropgui


Am 18.02.19 um 14:49 schrieb Moritz Mœller:
> On February 17, 2019 23:01:58 David Vincent-Jones 
> wrote:
>>
>> Although darktable handles JPG images very well, I think that its
>> primary market was targeted towards users who shoot RAW [...]
>>
> That's a typical developer answer. Amusing and sad at the same time.
> 
> The user brings up an UX issue that is very real. For the record: I
> think the crop tool in DT could be improved a lot too.
> 
> In return they get lectured about the input data the developer presumes
> DT should be fed with, a topic completely and utterly unrelated to the
> issue raised.
> 
> Pardon my use of weasel words.
> 
> Cheers,
> 
> .mm
> 
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] No blend mode 'Luminance' (Translation issue?)

2019-02-13 Thread sturmflut
Hello Christian,

'Helligkeit' is the German translation for 'lightness':


#: ../src/develop/blend_gui.c:2085
msgctxt "blendmode"
msgid "lightness"
msgstr "Helligkeit"


There is no blend mode called "Luminance". This is a list of all defined
blend modes:

DEVELOP_BLEND_MASK_FLAG
DEVELOP_BLEND_DISABLED
DEVELOP_BLEND_NORMAL
DEVELOP_BLEND_LIGHTEN
DEVELOP_BLEND_DARKEN
DEVELOP_BLEND_MULTIPLY
DEVELOP_BLEND_AVERAGE
DEVELOP_BLEND_ADD
DEVELOP_BLEND_SUBSTRACT
DEVELOP_BLEND_DIFFERENCE
DEVELOP_BLEND_SCREEN
DEVELOP_BLEND_OVERLAY
DEVELOP_BLEND_SOFTLIGHT
DEVELOP_BLEND_HARDLIGHT
DEVELOP_BLEND_VIVIDLIGHT
DEVELOP_BLEND_LINEARLIGHT
DEVELOP_BLEND_PINLIGHT
DEVELOP_BLEND_LIGHTNESS
DEVELOP_BLEND_CHROMA
DEVELOP_BLEND_HUE
DEVELOP_BLEND_COLOR
DEVELOP_BLEND_INVERSE
DEVELOP_BLEND_UNBOUNDED
DEVELOP_BLEND_COLORADJUST
DEVELOP_BLEND_DIFFERENCE2
DEVELOP_BLEND_NORMAL2
DEVELOP_BLEND_BOUNDED
DEVELOP_BLEND_LAB_LIGHTNESS
DEVELOP_BLEND_LAB_COLOR
DEVELOP_BLEND_HSV_LIGHTNESS
DEVELOP_BLEND_HSV_COLOR
DEVELOP_BLEND_LAB_L
DEVELOP_BLEND_LAB_A
DEVELOP_BLEND_LAB_B
DEVELOP_BLEND_RGB_R
DEVELOP_BLEND_RGB_G
DEVELOP_BLEND_RGB_B


I don't know enough about darktable's implementation to answer the
question if "lightness" is equivalent to "luminance" in this case.

cheers,
Simon



Am 13.02.19 um 11:59 schrieb Christian:
> Hi,
> I'm using the german version of darktable and I'm missing the
> blend mode 'Luminance/Leuchtkraft' in darktable's layermask blending
> modes.
> 
> I'm seeing 'LAB Helligkeit' and 'Helligkeit' but this is a different
> thing as luminance/Leuchtkraft in my understanding.
> 
> Chris
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] JPG .. spot removal .. !!

2019-02-08 Thread sturmflut
Hi,

if there is a bug in the spot removal tool, it should affect all images
from all sources and not just JPEGs.

Can you add more information about the operating system, compiler, etc.?

cheers,
Simon


Am 09.02.19 um 06:03 schrieb David Vincent-Jones:
> I realize after I had done it that spot-removal should not be used on a
> JPG file. The result was a nasty dt crash. It might be a good idea at
> some point to simply not allow some modules to be used with JPG files.
> 
> David
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Re: Map find location issue for windows

2019-02-02 Thread sturmflut
Hi,

on my Ubuntu 18.04.1 system (and probably most others), libcurl is
linked against OpenSSL 1.1.0, which defaults to /usr/lib/ssl (see
OPENSSLDIR):


sturmflut:~$ openssl version -a
OpenSSL 1.1.0g  2 Nov 2017
built on: reproducible build, date unspecified
platform: debian-amd64
compiler: gcc -DDSO_DLFCN -DHAVE_DLFCN_H -DNDEBUG -DOPENSSL_THREADS
-DOPENSSL_NO_STATIC_ENGINE -DOPENSSL_PIC -DOPENSSL_IA32_SSE2
-DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -DOPENSSL_BN_ASM_GF2m
-DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DRC4_ASM -DMD5_ASM -DAES_ASM
-DVPAES_ASM -DBSAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DPADLOCK_ASM
-DPOLY1305_ASM -DOPENSSLDIR="\"/usr/lib/ssl\""
-DENGINESDIR="\"/usr/lib/x86_64-linux-gnu/engines-1.1\""
OPENSSLDIR: "/usr/lib/ssl"
ENGINESDIR: "/usr/lib/x86_64-linux-gnu/engines-1.1"


Debian/Ubuntu then set the necessary symlinks to default to /etc/ssl/ ,
which most distributions are using as the system-wide certificate store:


mr2515@scc-scs-sr-lt:~$ ls -la /usr/lib/ssl/
insgesamt 20
drwxr-xr-x   3 root root  4096 Dez 13 11:19 .
drwxr-xr-x 151 root root 12288 Jan 30 17:22 ..
lrwxrwxrwx   1 root root14 Dez 13 11:30 certs -> /etc/ssl/certs
drwxr-xr-x   2 root root  4096 Dez 13 11:19 misc
lrwxrwxrwx   1 root root20 Dez  5 16:59 openssl.cnf ->
/etc/ssl/openssl.cnf
lrwxrwxrwx   1 root root16 Dez 13 11:30 private -> /etc/ssl/private


There doesn't seem to be such a simple, system-wide solution for
Windows, which is why the cURL author offers a CA bundle for easy use
[1] or you can extract the Windows certificate store data manually.

MinGW should probably ship and set up all of this correctly, just like
it works on Linux, but I don't know anything about MinGW (or more recent
Windows versions, for that matter).

cheers,
Simon



[1] https://curl.haxx.se/docs/caextract.html


Am 01.02.19 um 08:17 schrieb philippe.weyl...@libertysurf.fr:
> On Linux, how libcurl does find the CA bundle ?
> Is the path given when the library is generated ?
> Is there any other mechanism ? default location ?
> Thanks
> Philippe
> 
> - Mail original -
> De: "philippe weyland" 
> À: darktable-dev@lists.darktable.org
> Envoyé: Mercredi 30 Janvier 2019 15:17:28
> Objet: Map find location issue for windows
> 
> Tweaking location.c file I've found two ways to make it work under windows.
> 
> 1. curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
> Without checking the certificate that works ... but that is not what we want 
> really.
> 
> 2. curl_easy_setopt(curl, CURLOPT_CAINFO, 
> "C:\\msys64\\mingw64\\ssl\\certs\\ca-bundle.crt");
> When the path for CA bundle is given that works too. But the path will 
> different from an OS to the other.
> ... could be set to dartable\bin\ca-bundle.crt...
> 
> I haven't found if libcurl had a default location on windows. I've made some 
> checks without success.
> 
> I've found on https://github.com/curl/curl/issues/1538:
> "it will still be possible to do getenv("CURL_CA_BUNDLE") yourself and pass 
> that to CURLOPT_CAINFO"
> 
> To set CURL_CA_BUNDLE path is not enough alone (for what I've tried).
> 
> Any suggestion ?
> 
> Philippe
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] minor issues in git master (and probably in rc0 too)

2018-12-05 Thread sturmflut
Hi,

On 04.12.18 23:57, Patrick Shanahan wrote:
> yes, using kde/plasma5 I don't even see the option to "rename" a module.
> git master 13aa37e80
is this maybe a KDE-GTK theming issue which also caused the triangle at
the top not being fully visible as reported in the "Missing buttons in
lighttable​" thread?

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Bugs in Cinema DNG?

2018-11-06 Thread sturmflut
Hi,

just my two cents: this sounds like the white balance is not being
read/applied correctly.

The correct place to upload the picture is (currently) the issue tracker
at https://redmine.darktable.org/projects/darktable/issues .

kind regards,
Simon


On 21.10.18 00:32, Marc Draco wrote:
> Not sure where to post this so I hope someone can guide me (or say this
> is already in process).
> 
> I've got a RAW video convertor to convert from Magic Lantern RAW files
> (14-bit video) into cinema DNG which is just a stream of RAW frames.
> Darktable seems to be unable to correctly decode these. I can see the
> images are there under a lot of noise but it looks predominately purple.
> 
> The only comparison I have is Affinity Photo (Windows) and that handles
> these files without any problem (ignoring the fact that it's nowhere
> near as good as Darktable!) I can easily post an example but I expect
> the mailing list isn't the correct place.
> 
> Marc
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Plugin-SDK

2018-11-06 Thread sturmflut
Hi,

On 06.11.18 09:11, johannes hanika wrote:

> with an open SDK there is the problem of backward compatibility. how
> would you deal with that? don't offer support? what if the plugin
> author disappears and the code rots? you'd be making old history
> stacks useless. i like how we are committed to keeping old image edits
> alive.

this is literally my number one reason for using darktable. If I wanted
to live in a world where I can only open old pictures if I manage a host
of maybe outdated external plugins of dubious quality, I would use
Lightroom.

Just remember what happened to the Nik Plugins. First they were
maintained by a company, then Google bought them, distributed them for
free and ceased development. It's just sheer luck that DxO bought them
from Google and maintains them again. Also you can't be sure that you
will be able to run an older Lightroom version in a VM should the need
arise.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens recognition of Tamron 24-70 mm lens in lens correction module of darktable version 2.4.4

2018-11-06 Thread sturmflut
Hi,

On 05.11.18 23:58, J. Kilchert wrote:

> I have downloaded exiv2 lib and executables from their website and can
> run exiv2 exe it on my machine.
> The question is how do I make darktable use this library?

I see that you seem to be using the darktable build from Pascal de
Bruijn's Ubuntu PPA
(https://launchpad.net/~pmjdebruijn/+archive/ubuntu/darktable-release).
That PPA also contains an updated exiv2 package, so maybe contacting him
and asking for a version bump might be the easiest way to go.

If that is not an option: Just overwriting the older library installed
by the system is probably not going to be a good idea. So building and
installing libexiv2 to /usr/local and then building darktable from
source against it sounds like the way to go. That requires that you know
how to build software from source, though.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] OpenCL issues

2018-10-30 Thread sturmflut
Dear list,

On 30.10.18 11:16, Andreas Schneider wrote:

> Normally you need to select "very fast gpu" that darktable runs more stuff 
> via 
> OpenCL and this bright a huge boost when processing.
> 
> However this doesn't work for me right now. I've started to use the ROCm open 
> soruce stuff from AMD but it doesn't have image support yet.

I'm using AMDGPU-PRO for my RX570 (likely everybody else, probably). It
would be nice if the whole ROCm open source stuff was easy to install,
fully featured and reliable, but as it is even AMDGPU-PRO still has its
problems. Darktable with OpenCL works fine, but e.g. Blender crashes if
I activate the OpenCL backend.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Darkroom UI refactoring

2018-10-29 Thread sturmflut
Hi,

On 28.10.18 15:51, Jason Polak wrote:
> Make a new preset where the base curve has no nodes (i.e. is a line).
> When you are making the preset check 'auto apply this preset to matching
> images'. Then click OK. It will still be on from now on but do nothing.

This is what I did. Then I created a Tone Curve preset for each of my
cameras and configured those to auto-apply based on the manufacturer and
model.

Worked fine for the last ~1100 pictures.

regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] curiosity about raw formats

2018-10-25 Thread sturmflut
Hi Jason,

if every device out there fully conformed to DNG, DNG supported all the
specifics of each and every device, and all software fully supported
DNG: Yes.

In practice that's not the case. RAW formats are tied to the actual
implementation of the camera sensor itself. There have been several
attempts to come up with a standard format which supports every image
sensor imaginable, DNG for example is an extension of the earlier TIFF/EP.

There will always be something missing from the common standard, e.g.
TIFF/EP and DNG assume that the image sensor has a color filter array
which uses Red, Green, Blue, Cyan, Magenta, Yellow or White filters.
This is not true for all sensors out there, e.g. Sigma cameras with a
Foveon sensors don't have a color filter array, SuperCCD sensors have
color filters which are rotated by 45 degrees, etc. Some manufacturers
also use specific or proprietary algorithms which not every piece of
software can implement, so you couldn't read the image even though the
software supports DNG. If you go the level where you care about the RAW
data instead of RGB pixels, everybody does something different all the time.

The same is true for device options, settings, metdata values etc. which
do not exist on all devices yet have to be stored. A good example for
this are all the proprietary extensions to the Exif standard
(https://sno.phy.queensu.ca/~phil/exiftool/TagNames/) which were created
because people couldn't find a way to store their data in the standard tags.

I can't say much about how long it takes to implement support for all
the different RAW formats, but most manufacturers try to stick to their
existing RAW formats as long as possible. So not every new device
requires a full re-write.

cheers,
Simon



On 23.10.18 01:26, Jason Polak wrote:
> Dear List,
> 
> This is mainly for the devs: I was just wondering if all cameras shot in
> DNG format, would that make adding support for cameras much easier? In
> other words, does it take a lot of time to add new support for each
> camera's Raw format?
> 
> Jason
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Will the real developer package stand up?

2018-09-27 Thread sturmflut
Hi,

I just checked in an OpenSUSE Leap VM and had to install the following
packages:

gcc
gcc-c++
llvm-devel
clang
intltool
glib2-devel
gtk3-devel
libxml2-devel
lensfun-devel
pugixml-devel
libjpeg8-devel
openexr-devel
libwebp-devel
librsvg-devel
sqlite3-devel
libcurl-devel
libtiff-devel
liblcms2-devel
json-glib-devel
libexiv2-devel
xml2po
libcolord-devel
libcolord-gtk-devel
cups-devel
GraphicsMagick-devel
po4a
iso-codes-devel
openjpeg2-devel
libsecret-devel
libosmgpsmap-devel
libgphoto2-devel
libflickcurl-devel


cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Relative white balance

2018-09-20 Thread sturmflut
Hi Francois,

I usually just use the Color correction module to give the whole picture
a bit of a tint (red/yellow in this case). It's much more easy to
control than manipulating the white balance, can be used in styles and
supports split toning.

cheers,
Simon


On 9/20/18 8:25 AM, François Tissandier wrote:
> Hello !
> 
> I would like to know if there is any module which allows to apply a
> relative white balance change ? For instance if I want to make a set of
> photos a bit warmer, I can't really do that with a style. I have to open
> each photo individually and adjust each white balance. Or am I missing
> something ? 
> 
> thanks if you have any idea how to do it !
> 
>    Francois
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Re: clang vs. gcc: dramatic performance difference

2018-09-13 Thread sturmflut
Hi all,

IIRC this has something to do with clang not linking against libatomic
by default, but GCC doing so.

regards,
Simon



On 9/13/18 7:49 AM, Matthias Bodenbinder wrote:
> Am 13.09.18 um 07:38 schrieb Matthias Bodenbinder:
>> I assume I am missing some significant compiler options for clang. But dont 
>> know what that is.
>> Can somebody help me with that and tell me what I need to do to make the 
>> clang binary faster?
> 
> I found these messages with clang enabled:
> 
> -- Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES) 
> -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) 
> -- Could NOT find OpenMP (missing: OpenMP_C_FOUND OpenMP_CXX_FOUND) 
> CMake Warning at src/external/rawspeed/cmake/OpenMP.cmake:18 (message):
>   Looking for OpenMP - failed.  utilities will not use openmp-based
>   parallelization
> Call Stack (most recent call first):
>   src/external/rawspeed/CMakeLists.txt:186 (include)
> 
> 
> What is missing? I installed openmp.
> 
> 
> PS
> I am using Manjaro
> 
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: Fwd: Re: [darktable-dev] Which colour target is recommended for a proper colour matrix

2018-09-06 Thread sturmflut
Hi,

On 9/5/18 8:48 PM, openhab.doc wrote:

> Which CIE / CHT file can be used with Wolf Faust Target C1?

As far as I can tell, you would use /usr/share/argyllcms/ref/it8.cht
(the layout of all IT8.7 targets is the same) and the reference file
from Wolf Faust (the text file matching the charge number of your
target) as the CIE file.

I've placed an order for a C1 target today.

kind regards,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] darktable produces PNG files with CRC mismatch in iCCP header

2018-07-26 Thread sturmflut
Dear list,

I can confirm this and have opened bug 12273 [1] for it.

It seems strange since darktable just calls png_set_iCCP from libpng.

kind regards,
Simon


[1] https://redmine.darktable.org/issues/12273



On 26.07.2018 10:04, Sarge Borsch wrote:
> darktable produces PNG files with CRC mismatch in iCCP header. (bit depth = 8 
> bit, compression = 1) As a result, certain tools refuse to accept these PNG 
> images.
> Is that a known problem or should I add it to redmine? I've done a search and 
> it seems it's not there 
> yet.___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] basecurve tool and noise tool CMakeLists

2018-07-20 Thread sturmflut
Dear Germano,

I'm an Arch Linux, so my environment is at least as bleeding-edge as
Fedora 28 (e.g. I'm already on GCC 8.1.1). I don't get any of the buildd
errors you are getting when building the tools, so I took the time to
look at this.

The short version of the build errors you are getting is:


/usr/bin/c++  -g -Wall -fopenmp  -Wl,-z,relro  -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic
CMakeFiles/dt-curve-tool.dir/dt-curve-tool.c.o
CMakeFiles/dt-curve-tool.dir/exif-wrapper.cpp.o  -o dt-curve-tool
-lexiv2 -lm
BUILDSTDERR: /usr/bin/ld:
CMakeFiles/dt-curve-tool.dir/dt-curve-tool.c.o: relocation R_X86_64_32S
against symbol `spline_set' can not be used when making a shared object;
recompile with -fPIC
BUILDSTDERR: /usr/bin/ld:
CMakeFiles/dt-curve-tool.dir/exif-wrapper.cpp.o: relocation R_X86_64_32
against `.rodata' can not be used when making a shared object; recompile
with -fPIC
BUILDSTDERR: /usr/bin/ld: final link failed: Nonrepresentable section on
output
BUILDSTDERR: collect2: error: ld returned 1 exit status


It looks like this is caused by the use of a "hardened" build chain, one
of the bug reports [1] I found might point to the solution:

"If you are using -specs=/usr/lib/rpm/redhat/redhat-hardened-ld at link
time, you also need to use
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 at compile time, and as
you are compiling and linking at the same time, you need either both, or
drop the -specs=/usr/lib/rpm/redhat/redhat-hardened-ld."


Cheers,
Simon


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1304277




On 20.07.2018 09:16, Germano Massullo wrote:
> Hi, I am looking for help in fixing some CMakeLists problems I am
> experiencing while compiling darktable subpackages in Fedora.
> 
> I posted all infos on:
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/thread/MAALXQOLRTKJVLMKDCDLFBJZFMCJLB5Z/
> 
> Thank you
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



[darktable-dev] Re: Showing exposure bias

2018-06-29 Thread sturmflut
Dear list,

I was one step short of writing the code for this feature about five
times now, so I definitely agree that it should be added.

cheers,
Simon



On 18.05.2018 19:54, Šarūnas wrote:
> Hi, developers,
> 
> I have always missed seeing exposure bias value in darktable. Does
> anyone else think it would be good to have that shown in 'image
> information' on the left? Perhaps there is also a nifty way of
> indicating exp. bias somehow in histogram?
> 
> By mimicking source code for exposure, I was able to get exp. bias from
> exif and then output among other metadata in 'image information':
> https://gist.github.com/sarunasb/f5eb4644dbf3e07174069c46f668e89b
> 
> Of course this only lasts until images are loaded for the second time,
> as there is no exp. bias in database, if I'm correct.
> 
> At the moment I'm not too familiar with darktable's code for database
> operations. It looks like common/database.c has schema upgrades, but
> then there are multiple instances in the code, where schema has to known
> in order to be used explicitly for inserts, for example.
> 
> I have the code for displaying exposure bias in a fork on Github
> (https://github.com/sarunasb/darktable) and can make a pull request, if
> there is any interest for it.
> 
> If this is seen as a feature worth adding, would someone familiar with
> database ops be willing to pick up? I can try looking at it myself too,
> but at the moment I don't even know what I don't know, so to say...
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens Correction

2018-04-23 Thread sturmflut
Dear list,

I don't know much about lensfun, but I can confirm that in my setup
(lensfun 0.3.2-6 package as supplied by Arch Linux, darktable built
manually from the current darktable-2.4.x branch) the lens correction
module actually fails to select the right settings for this picture
(Nikon AF-S VR Zoom-Nikkor 70-200mm f/2.8G IF-ED on a Nikon D750).

I quickly hacked a couple of printf()'s into src/iop/lens.c and it looks
like lf_db_find_lenses_hd() is called with the right arguments, but
fails to return a result.

I've noticed two things.

First: lenstool recognizes this lens as an APS-C lens, but as far as I
can tell it is a full-frame lens?

$ lenstool -L "Nikon AF-S VR Zoom-Nikkor 70-200mm f/2.8G IF-ED"

Matching lens found in the database:
  Nikon / Nikkor AF-S 70-200mm f/2.8G VR IF-ED
|- Crop factor: 1,528
|- Aspect ratio: 1,5
|- Focal: 70-200mm
|- Min-Aperture: f/2,8
|- Center: 0,0
|- Compatible mounts: Nikon F AF,
|- Calibration data: tca, vign, dist,

Second: The other lenses Mark mentioned also seem to be marked as APS-C
lenses in the lensfun database, but actually seem to be full frame
lenses. There are only a few APS-C lenses listed in the drop down, e.g.
the Nikon AF-S DX Nikkor 35mm f/1.8G, but that's because this lens
actually has two entries in the Nikon database (one for crop factor
1,528 and one for crop factor 1).

Does this maybe point to the root cause?

cheers,
Simon


On 23.04.2018 14:43, Mark Feit wrote:
> On 04/23/2018 03:26 AM, sturmflut wrote:
>> Could it maybe be possible that the lensfun database got corrupted on
>> some systems?
> 
> It's not just some systems and it's not a database problem.  I've had
> this problem for a long time and, figuring it was pilot error, never got
> around to digging around to find the cause.
> 
> The DT I run (2.4.1 on Linux; I will be upgrading later this spring when
> I get a lull in shooting) is built from the sources against the lensfun
> installed on the system, which I update (binaries and data) before
> building.  That leaves no chance of a version mismatch.
> 
> DT correctly identifies the body and lens in the image information box. 
> The Lens Correction tool correctly recognizes my bodies (SLR and
> point-and-shoot) but fails to recognize any of the lenses I use regularly:
> 
> Nikkor AF 18-35mm f/3.5-4.5D IF-ED
> Nikkor AF-S 28-300mm f/3.5-5.6G ED VR
> Nikkor AF 35-70mm f/2.8D
> Nikkor AF 50mm f/1.4D
> Nikkor AF-S 70-200mm f/2.8G VR IF-ED
> 
> I've checked the XML files that make up the Lensfun database, and all
> are in there.  I also have and use a 28-105 which is not in the database
> and, as expected, isn't found and behaves the same way.
> 
> One other thing I've noticed is that the list of choices available when
> trying to select a lens manually is a subset of what's in the database. 
> The brands with a compatible mount show up (so I get Nikon, Tamron and
> Samyang but not Canon or Olympus), but the list of lenses is incomplete
> despite being in the XML.  Whether this is a problem in Lensfun or DT
> remains to be seen, but I'd be hard-pressed to believe that a Lensfun
> failure to recognize common lenses like the 70-200 or the 50 f/1.4 would
> have been left to fester for very long.
> 
> An image that illustrates the problem on my system can be downloaded
> from https://s3.wasabisys.com/darktable/lensfun.nef.
> 
> --Mark
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Lens Correction

2018-04-23 Thread sturmflut
Dear list,

for what it's worth:

I ran into a similar problem yesterday. Suddenly my Nikon 70-200/2.8 VR
II lens was missing from the lens correction module while my D750 and
other Nikon lenses were available. I remembered I had run
"lensfun-update-data" last week and it had failed because one of the
download URLs (http://wilson.bronger.org/lensfun-db/versions.json) was
down. Running lensfun-update-data again fixed the issue.

Could it maybe be possible that the lensfun database got corrupted on
some systems?

cheers,
Simon



On 23.04.2018 09:02, Maurizio Paglia wrote:
> Found this on pixls.us 
> https://discuss.pixls.us/t/lens-correction-module-camera-lens-not-found/2242
> 
> @ Daudi Amani - please give it a try.
> I am at work now so cannot carry on any sort of tests. I will try as
> soon at home
> 
> Maurizio
> 
> 2018-04-23 6:20 GMT+02:00 Daudi Amani  >:
> 
> That's what I've been trying to tell people; I have the same
> problem. No seems to understand.
> 
> On Sun, Apr 22, 2018 at 1:16 AM Maurizio Paglia  > wrote:
> 
> Hi,
> my module 'lens correction' works no more.
> I cannot see ANY camera brand in the combo list, it is empty...
> Also images previously developed have the module activated but
> with NO
> correction.
> 
> Thank you,
> 
> Maurizio
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
> 
> 
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Re: XML parser → Huge sidecar files

2018-04-16 Thread sturmflut
Hello,

I can confirm this for the latest version in the darktable-2.4.x branch
(commit edf1168371be288f071986d93a47fb3e082573de). The sidecar files
seem to contain an awful lot of masks, but I can't seem to see which
module even uses them?

cheers,
Simon


On 15.04.2018 20:28, Timur Irikovich Davletshin wrote:
> It looks like I was able to find what action causes this problem.
> 
> Steps to reproduce:
> 
> 1. Download, unpack and import as folder — https://drive.google.com/ope
> n?id=14sZLgnpZSV5W3pw1K_8owHW29Heq9EWz (don't pay attention to content
> and settings)
> 2. Choose second picture and click (in lighttable mode) copy history
> stack and choose, let's say, 'shadows and highlights' settings.
> 3. Apply it (paste) to first picture, open it, compress history stack
> and close DT.
> 4. Now compare XMP files, first one is twice bigger than second one (in
> my case ~700kB vs ~1400kB). Meanwhile in darkroom mode history stack
> looks the same.
> 
> Can anyone comment, what is going on here?
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Help needed for creating the HTML darktable manual.

2018-04-16 Thread sturmflut
Hello,

I'm a bit confused. That's not an error message, but one of the normal
build messages?

cheers,
Simon


On 14.04.2018 08:30, openhab@web.de wrote:
> Hello,
> I need help creating the HTML darktable manual.
> When I try to create the HTML documentation with command
> make darktable-usermanual-dtorg
> I get the following error message:
> [mepi@mepi-pc build (master)]$ make darktable-usermanual-dtorg
> *Building the en usermanual for darktable.org*
> 
> Do I still have to install anything under Linux? Ideas what I'm doing wrong?
> Thanks for help in advance!
> Pierre Metzner
> (mepi0011)
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Graduated density → Controls

2018-04-05 Thread sturmflut
Dear list,

for reference: this was also reported as
https://redmine.darktable.org/issues/12107 . I can reproduce it.

cheers,
Simon


On 31.03.2018 12:29, Timur Irikovich Davletshin wrote:
> Hello everybody!
> 
> Little bug report (steps to reproduce):
> 
> 1. Load any landscape oriented image
> 2. Crop it to portrait
> 3. Turn graduated density module on
> 
> Problem:
> 
> Tool handlers (little triangles) are off-screen. Still I can specify
> degrees directly in module settings but I'd expect handlers to work.
> 
> Screenshots are in the attachment, I believe they are self-explanatory.
> 
> Thanks is advance,
> 
> Timur.
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] Bug report: Geocode crash on 2.4.2 (Mac OS 10.11.6)

2018-04-05 Thread sturmflut
Dear list,

at least for the latest git master built and run on Arch Linux I cannot
confirm this (anymore?). I am able to drag geocoded NEF images around on
the map, and geocode non-geocoded NEF images by dragging them onto the
map. No crashes.

cheers,
Simon


On 29.03.2018 13:18, Henkka wrote:
> 
> 
> 
>  Välitetty viesti / Fwd.Msg 
> Aihe: Re: [darktable-user] Re: Geocode crash on 2.4.2 (Mac OS 10.11.6)
> Päiväys:  Thu, 29 Mar 2018 13:06:35 +0200
> Lähettäjä:Matej Martinovic 
> Vastaanottaja:darktable-user 
> 
> 
> 
> Please consider writing a bug report. Devs aren't necessarily reading
> these emails.
> https://redmine.darktable.org/projects/darktable/issues?set_filter=1_id=1
> 
> BR
> Matej
> 
> 
>  On Do, 29 Mär 2018 12:18:43 +0200 *J Albrecht *
> wrote 
> 
> Thanks for the confirmation, Henkka. I reinstalled 2.4.1 so that I
> can continue to work.
> 
> 
> 
> 
> > On 29 Mar 2018, at 12:16, Henkka  > wrote:
> >
> > Yup, crash crash crash. I tried it three times. Just click on
> picture and lights out instantly.
> >
> >
> > J Albrecht kirjoitti 29.3.2018 klo 12.58:
> >> That’s good to know, Hennka. Perhaps something else is awry with
> my box. Nevertheless, I’ve now noticed another problem: dt crashes
> when I try to geocode my NEF files by dragging them onto the map.
> Just for the helluvit, could you try to test this on your machine,
> please?
> >>
> >>
> >>> On 29 Mar 2018, at 11:54, Henkka  > wrote:
> >>>
> >>> Well I decided to go with it and it didn't seem to give anykind
> of effect intoperformance.
> >>> I don't know what these changes are and what kind of they are
> and how low end computers they are assigned to, but I notice nothing.
> >>>
> >>> MacOs 10.13.3
> >>>
> >>>
> >>> J Albrecht kirjoitti 29.3.2018 klo 12.35:
>  When I had first fired-up dt after upgrading, I was greeted by
> a dialogue stating something about performance enhancements being
> made to this version and I could choose to accept them or not. Well,
> I decided not to because things were operating quite well with
> 2.4.1. Bad choice, my machine now chugs and drags along wheres
> earlier it flew! Question is, how can I engage the “enhancements”
> since the one-time-only dialogue is gone? Either that or, I’ll go
> back to
> 
> 2.4.1
> 
>  darktable user mailing list
>  to unsubscribe send a mail to
> darktable-user+unsubscr...@lists.darktable.org
> 
> 
> >>>
> 
> 
> 
> >>> darktable user mailing list
> >>> to unsubscribe send a mail to
> darktable-user+unsubscr...@lists.darktable.org
> 
> >>>
> >
> 
> 
> 
> 
> darktable user mailing list
> to unsubscribe send a mail to
> darktable-user+unsubscr...@lists.darktable.org
> 
> 
> 
> 
> 
> 
> darktable user mailing list to unsubscribe send a mail to
> darktable-user+unsubscr...@lists.darktable.org
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] DNG vs RAW → Lens and focus info

2018-04-05 Thread sturmflut
Hi Timur,

On 04.04.2018 21:06, Timur Irikovich Davletshin wrote:

> 1. DT relies only on libexiv2 in extraction of EXIF metadata.
> 2. exiv2 fails to extract vendor specific information from DNG file
> (converted via Adobe DNG Converter) when compared with exiftool. But
> original NEF data is there.
> 3. As last resort for lens detection DT relies on Exif.Photo.LensModel,
> which is just ASCII string encoded by converter.
> 4. Converter writes ambiguous data in Exif.Photo.LensModel without. No
> vendor, no exact model, just '18.0-55.0 mm f/3.5-5.6'.
> 5. Feeding vague data to lensfun gives no good results.
> 6. Native DNG by Pentax use non-standard vendor specific Exif.Pentax*
> namespace.
> 7. Focus distance information is also vendor specific.
> 
> If not mistaken problem should be fixed on very root... which is
> libexiv2. But it's just MHO.

I didn't check it, but that sounds like the right direction. I guess it
could be confirmed by dumping the metadata using the libexiv2 command
line tool (exiv2) and comparing the output to what exiftool gives.

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] DNG vs RAW → Lens and focus info

2018-04-04 Thread sturmflut
Hello Timur,

On 04.04.2018 13:15, Timur Irikovich Davletshin wrote:

> Simple investigation with exiftool shows that no lens information is
> lost in DNG.

I guess if the data is there and exiftool sees the same values in both
files, but different things happen later on, that would point in the
direction of exiv2/liblensfun?

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] flatpak

2018-03-20 Thread sturmflut
Hello list,

...this pull request was merged after just 90 seconds, BTW 8O

cheers,
Simon



On 20.03.2018 14:16, sturmflut wrote:
> Hello Joel,
> 
> I guess most people will end up using Flathub, so
> https://github.com/flathub/org.darktable.Darktable seems to be the right
> place. I've created a pull request at
> https://github.com/flathub/org.darktable.Darktable/pull/11 .
> 
> cheers,
> Simon
> 
> 
> On 10.03.2018 16:32, Joel Brunetti wrote:
>> Hey Devs,
>>
>> I was wondering if one of you is the maintainer of the Darktable flatpak
>> on Flathub.
>>
>> I just started using the Darktable flatpak and I think it is a great way
>> for me to stay on Debian Stable while getting the latest Darktable
>> features. Shout out to the great new dehaze module!
>>
>> I went to export to Facebook and Google Photos and after authentication
>> failed rather silently found that the flatpak default sandboxing does
>> not allow network access. This can be fixed by a command line flag
>> (flatpak run --share=network org.darktable.Darktable) but it should
>> maybe be the default as I don't think all users want to launch from the
>> command line.
>>
>> Anyway, I was hoping someone could point me to who to talk to. There are
>> multiple github repos so it isn't exactly clear to me.
>>
>> Thanks,
>> Joel
>>
>> ___
>> darktable developer mailing list to unsubscribe send a mail to
>> darktable-dev+unsubscr...@lists.darktable.org
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] flatpak

2018-03-20 Thread sturmflut
Hello Joel,

I guess most people will end up using Flathub, so
https://github.com/flathub/org.darktable.Darktable seems to be the right
place. I've created a pull request at
https://github.com/flathub/org.darktable.Darktable/pull/11 .

cheers,
Simon


On 10.03.2018 16:32, Joel Brunetti wrote:
> Hey Devs,
> 
> I was wondering if one of you is the maintainer of the Darktable flatpak
> on Flathub.
> 
> I just started using the Darktable flatpak and I think it is a great way
> for me to stay on Debian Stable while getting the latest Darktable
> features. Shout out to the great new dehaze module!
> 
> I went to export to Facebook and Google Photos and after authentication
> failed rather silently found that the flatpak default sandboxing does
> not allow network access. This can be fixed by a command line flag
> (flatpak run --share=network org.darktable.Darktable) but it should
> maybe be the default as I don't think all users want to launch from the
> command line.
> 
> Anyway, I was hoping someone could point me to who to talk to. There are
> multiple github repos so it isn't exactly clear to me.
> 
> Thanks,
> Joel
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



Re: [darktable-dev] can't compile darktable

2017-12-22 Thread sturmflut
Hi all,

On 22.12.2017 18:29, Roman Lebedev wrote:

>> -- Performing Test DARKTABLE_HAVE_C_FLAG_WNO_FORMAT_TRUNCATION
>> -- Performing Test DARKTABLE_HAVE_C_FLAG_WNO_FORMAT_TRUNCATION - Success
>> -- Performing Test DARKTABLE_HAVE_CXX_FLAG_WNO_FORMAT_TRUNCATION
>> -- Performing Test DARKTABLE_HAVE_CXX_FLAG_WNO_FORMAT_TRUNCATION -
Success
>> ...
>> cc1: error: unrecognized command line option '-Wno-format-truncation'
>> [-Werror]
>> cc1: all warnings being treated as errors
> So it first says that the flag is supported, and then barfs at it. Touché.
>
> Given the date, i will revert the change that exposed this issue,
> but there is something *very* wrong going on here...



I just came to the same conclusion while trying to reproduce this on an
Ubuntu 16.04 install, which uses the exact same compiler version as
Linux Mint 18.3.

-Wformat-truncation doesn't seem to be a valid option for GCC 5.4.0
(it's not documented), but this version seems to silently accept the
negation under some circumstances (!):

sturmflut@hogsmeade:/tmp$ gcc -Wformat-truncation -o test test.c
gcc: error: unrecognized command line option ‘-Wformat-truncation’
sturmflut@hogsmeade:/tmp$ gcc -Wno-format-truncation -o test test.c
sturmflut@hogsmeade:/tmp$

(test.c just has an empty main() method).


So CHECK_COMPILER_FLAG_AND_ENABLE_IT(-Wno-format-truncation) in
./cmake/compiler-warnings.cmake is fooled into thinking this compiler
version actually supports -Wno-format-truncation at all times, because
the simple test case doesn't fail, but the compiler later decides to no
longer silently accept the invalid command line option for some reason.

Turns out one of the cases which trigger this is when the source file
under compilation has already generated some other warnings before. If I
do a make -j1 on a clean darktable checkout on this machine,
./src/iop/colortransfer.c actually is the first file which causes any
compiler warnings at all ("ISO C90 forbids variable length array"), so
this is why the process fails exactly there.



The minimum test case to trigger this behavior in GCC 5.4.0 is a C file
with a main() function with a parameter which has the wrong type, like
this one:


int main(int argc, int argv)
{
}



Then add -Wall to make sure the compiler will treat this as a warning,
and it fails:



sturmflut@hogsmeade:/tmp$ gcc -Wall -Wno-format-truncation -o test test.c
test.c:1:5: warning: second argument of ‘main’ should be ‘char **’ [-Wmain]
 int main(int argc, int argv)
 ^
cc1: warning: unrecognized command line option ‘-Wno-format-truncation’


If you omit -Wall, the compiler will not generate the first warning and
also not complain about -Wno-format-truncation.

I've never run into this before, but I guess Ubuntu 16.04 is going to
stay with us for a while since it is the current LTS release until may
2018, and even after that it will still be supported until 2021. So this
buggy GCC version will most likely also stay alive for quite a while.

kind regards,
Simon








___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org