[darktable-dev] Color balance wheels
Hi, I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in RecRGB 2020 into the colorbalance module. I have seen the prototype of the code for color wheels, from Tobias, and the comment : // these are not in a state to be useful. but they look nice. too bad i couldn't map the enhanced mode with // negative values to the wheels :( What exactly didn't work ? If the problem is merely mathematical, I can work on it. I'm just bad at GUIs and GTK stuff. On another note, is it mandatory to make the adjustement in sRGB ? (why not a larger RGB space ?) Cheers, Aurélien. ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Color balance wheels
Aurélien Pierre wrote: On another note, is it mandatory to make the adjustement in sRGB ? (why not a larger RGB space ?) In my opinion, any dependence on sRGB is undesirable - and sRGB should be avoided in the workflow until the files are presented through a media which cannot show a larger color space. In a not too distant future, all monitors and projectors will be able to show a color space larger than Adobe RGB. Per Inge Oestmoen, Norway ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Color balance wheels
It's not even a matter of display, because we are deep inside the pixelpipe here. It's rather a matter of available range to perform the intermediate computations and adjustments. You want to be able to do them in a smooth way and have a lot of control. The point being I have never had good results for color-grading with this module, it's always too harsh. I don't know if it is because of the color space of the lift/gamma/gain transfer function. Le 21/09/2018 à 21:11, Per Inge Oestmoen a écrit : > Aurélien Pierre wrote: > >> On another note, is it mandatory to make the adjustement in sRGB ? >> (why not a larger RGB space ?) > > In my opinion, any dependence on sRGB is undesirable - and sRGB should > be avoided in the workflow until the files are presented through a > media which cannot show a larger color space. In a not too distant > future, all monitors and projectors will be able to show a color space > larger than Adobe RGB. > > Per Inge Oestmoen, Norway ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Color balance wheels
On Saturday, September 22, 2018 2:32:16 AM CEST Aurélien Pierre wrote: > Hi, Hi Aurélien, > I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in > RecRGB 2020 into the colorbalance module. > > I have seen the prototype of the code for color wheels, from Tobias, and > the comment : > > // these are not in a state to be useful. but they look nice. too > bad i couldn't map the enhanced mode with > // negative values to the wheels :( > > What exactly didn't work ? If the problem is merely mathematical, I can > work on it. I'm just bad at GUIs and GTK stuff. > > On another note, is it mandatory to make the adjustement in sRGB ? (why > not a larger RGB space ?) Oh, this sounds interesting, I use that module to fix color casts in nightphotography shots and haven't found a better way. However often it doesn't work that well and I woul with that the tone curve would have R G B channels to modify. I find it often really hard to modify a and b in L*a*b. ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Color balance wheels
Hi everyone, The colorbalance is done and I have added HSL sliders to make it really quick to set (altough now, the UI is quite crowded). It's the closest I can go to the color wheels, given that I don't know much about cairo. The new mode works in ProPhoto RGB, I still have a problem with the colorspace conversion in the SSE2 version : converting back and forth produces a slight magenta cast. I'm bumping my head to understand why, since the pure C and OpenCL versions work flawlessly with the same algorithm. If you want to test or review : https://github.com/darktable-org/darktable/pull/1734 If someone wants to finish the color wheels, you just have to map the radius to what is passed to the current saturation slider, and the angle to what is passed to the current hue slider. The maths are ready and working. Have a nice day, Aurélien. Le 21/09/2018 à 20:32, Aurélien Pierre a écrit : > > Hi, > > I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in > RecRGB 2020 into the colorbalance module. > > I have seen the prototype of the code for color wheels, from Tobias, > and the comment : > > // these are not in a state to be useful. but they look nice. too > bad i couldn't map the enhanced mode with > // negative values to the wheels :( > > What exactly didn't work ? If the problem is merely mathematical, I > can work on it. I'm just bad at GUIs and GTK stuff. > > On another note, is it mandatory to make the adjustement in sRGB ? > (why not a larger RGB space ?) > > Cheers, > > Aurélien. > > > ___ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
Re: [darktable-dev] Color balance wheels
Regarding sRPG, dt already supports the .exr export, which requires a larger color space. I don't know how it's getting that on the screen, but it's working quite well. On 09/27/2018 12:20 AM, Aurélien Pierre wrote: Hi everyone, The colorbalance is done and I have added HSL sliders to make it really quick to set (altough now, the UI is quite crowded). It's the closest I can go to the color wheels, given that I don't know much about cairo. The new mode works in ProPhoto RGB, I still have a problem with the colorspace conversion in the SSE2 version : converting back and forth produces a slight magenta cast. I'm bumping my head to understand why, since the pure C and OpenCL versions work flawlessly with the same algorithm. If you want to test or review : https://github.com/darktable-org/darktable/pull/1734 If someone wants to finish the color wheels, you just have to map the radius to what is passed to the current saturation slider, and the angle to what is passed to the current hue slider. The maths are ready and working. Have a nice day, Aurélien. Le 21/09/2018 à 20:32, Aurélien Pierre a écrit : Hi, I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in RecRGB 2020 into the colorbalance module. I have seen the prototype of the code for color wheels, from Tobias, and the comment : // these are not in a state to be useful. but they look nice. too bad i couldn't map the enhanced mode with // negative values to the wheels :( What exactly didn't work ? If the problem is merely mathematical, I can work on it. I'm just bad at GUIs and GTK stuff. On another note, is it mandatory to make the adjustement in sRGB ? (why not a larger RGB space ?) Cheers, Aurélien. ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org -- Pete Hall p...@hallcrcus.net +1 (608) 290-0731 ___ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
