Bug#1059605: dh-runit: Consider migrating from a haskell-based testrunner

[David (Plasma) Paul]

Source: dh-runit
Version: 2.16.1
Severity: wishlist

Dear Maintainer,

Please consider modifying the testsuite infrastructure for dh-runit to
not require haskell.

Given that both dh-runit and its tests are written in perl, it's a bit
inconvenient to need a haskell compiler just to build the testrunner
program.

Thanks,

-- 
Plasma

Bug#504793: [PATCH] Re: /etc/inputrc, once installed, is never replaced by newer versions

[David (Plasma) Paul]

Dear Maintainer,

Attached is a patch which I believe fixes #504793 without requiring
dependencies on any additional packages.

Questions or comments are welcome.

Thanks,

-- 
Plasma
diff -Nru readline-8.2/debian/changelog readline-8.2/debian/changelog
--- readline-8.2/debian/changelog	2023-01-03 14:49:45.0 -0600
+++ readline-8.2/debian/changelog	2023-11-25 22:40:41.0 -0600
@@ -1,3 +1,13 @@
+readline (8.2-1.4) UNRELEASED; urgency=low
+
+  * Non-maintainer upload.
+  * Make inputrc a conffile. (Closes: #504793)
+  * d/readline-common.postinst: Remove, no longer needed.
+  * d/readline-common.postrm: Remove, no longer needed.
+  * d/rules: Remove empty /etc directory from libreadline8.
+
+ -- David (Plasma) Paul   Sat, 25 Nov 2023 22:40:41 -0600
+
 readline (8.2-1.3) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru readline-8.2/debian/readline-common.postinst readline-8.2/debian/readline-common.postinst
--- readline-8.2/debian/readline-common.postinst	2009-08-29 05:34:33.0 -0500
+++ readline-8.2/debian/readline-common.postinst	1969-12-31 18:00:00.0 -0600
@@ -1,13 +0,0 @@
-#! /bin/sh -e
-
-install_from_default() {
-  if [ ! -f $2 ]; then
-cp -p $1 $2
-  fi
-}
-
-if [ "$1" = "configure" ] && [ "$2" = "" ]; then
-  install_from_default /usr/share/readline/inputrc /etc/inputrc
-fi
-
-#DEBHELPER#
--- readline-8.2/debian/readline-common.postrm	2009-08-29 05:34:33.0 -0500
+++ readline-8.2/debian/readline-common.postrm	1969-12-31 18:00:00.0 -0600
@@ -1,8 +0,0 @@
-#! /bin/sh -e
-
-case "$1" in
-purge)
-	rm -f /etc/inputrc
-esac
-
-#DEBHELPER#
--- readline-8.2/debian/rules	2022-11-11 00:26:09.0 -0600
+++ readline-8.2/debian/rules	2023-11-25 22:40:41.0 -0600
@@ -250,7 +250,6 @@
 
 	: # move $(p_rl)
 	dh_installdirs -p$(p_rl) \
-		etc \
 		lib/$(DEB_HOST_MULTIARCH) \
 		usr/share/doc
 	cp -a $(d)/usr/lib/$(DEB_HOST_MULTIARCH)/lib{history,readline}.so.* $(d_rl)/lib/$(DEB_HOST_MULTIARCH)/
@@ -273,6 +272,7 @@
 		$(d_comm)/usr/share/man/man3/readline.3readline
 	mv $(d)/usr/share/info/rluserman.info $(d_comm)/usr/share/info/.
 	install -m 644 debian/inputrc $(d_comm)/usr/share/readline/
+	install -m 644 debian/inputrc $(d_comm)/etc/
 
 	: # move $(p_rld)
 	dh_installdirs -p$(p_rld) \
@@ -338,6 +338,7 @@
 	dh_installdirs -p$(p_commu) \
 		usr/share/readline
 	install -m 644 debian/inputrc $(d_commu)/usr/share/readline/
+	install -m 644 debian/inputrc $(d_commu)/etc/
 endif
 
 ifneq ($(build32),)

Bug#1054571: devscripts: debootsnap: Missing Recommends on python3-pycurl

[David (Plasma) Paul]

On Tue, 28 Nov 2023 12:48:31 +0100
Michael Prokop  wrote:

> Hi,
> 
> * David (Plasma) Paul [Wed Oct 25, 2023 at 11:36:48PM -0500]:
> > Package: devscripts
> > Version: 2.21.6
> > Severity: normal
> > 
> > Dear Maintainer,
> > 
> > The devscripts binary package is missing a Recommends on
> > python3-pycurl which is a dependency of the debootsnap script.  
> 
> So in devscripts v2.23.6 we have:

> | Depends: dpkg-dev (>= 1.18.19), fakeroot, file, gnupg | gnupg2,
> gpgv | gpgv2, libfile-dirlist-perl, libfile-homedir-perl,
> libfile-touch-perl, libfile-which-perl, libipc-run-perl, libmoo-perl,
> libwww-perl, patchutils, sensible-utils, wdiff, perl:any, python3:any

> | Recommends: apt (>= 1.3~pre3), dctrl-tools, dput | dupload,
> libdistro-info-perl, libdpkg-perl, libencode-locale-perl,
> libgit-wrapper-perl, libgitlab-api-v4-perl, libjson-perl,
> liblist-compare-perl, libstring-shellquote-perl, libtry-tiny-perl,
> liburi-perl, licensecheck, lintian, man-db, patch, python3-apt,
> python3-debian (>= 0.1.15), python3-magic, python3-requests,
> python3-unidiff, python3-xdg, strace, unzip, wget | curl, xz-utils,
> debian-keyring, equivs, liblwp-protocol-https-perl,
> libsoap-lite-perl, pristine-tar

> | Suggests: adequate, at, autopkgtest, bls-standalone, bsd-mailx |
> mailx, build-essential, check-all-the-things, cvs-buildpackage,
> debhelper, diffoscope, disorderfs, dose-extra (>= 4.0), duck,
> elpa-devscripts, faketime, gnuplot, how-can-i-help,
> libauthen-sasl-perl, libdbd-pg-perl, libfile-desktopentry-perl,
> libterm-size-perl, libtimedate-perl, libyaml-syck-perl, mmdebstrap,
> mozilla-devscripts, mutt, piuparts, postgresql-client, pristine-lfs,
> quilt, ratt, reprotest, ssh-client, svn-buildpackage, w3m

> And the package description for says:
> 
> | - debootsnap: Combines debootstrap and snapshot.debian.org to create a 
> chroot
> |   containing exactly the requested selection of packages. This can be used
> |   to re-create a chroot from the past, for example to reproduce a bug. The
> |   tool is also used by debrebuild to build a package in a chroot with build
> |   dependencies in the same version as recorded in the buildinfo file.
> |   [apt-utils, dpkg-dev, equivs, mmdebstrap, python3-pycurl]
> 
> I can confirm that apt-utils, equivs, mmdebstrap and python3-pycurl,
> but also python3-debian and python3-requests seem to be required.
> 
> Given that e.g. `equivs` is listed in both Recommends, but also in
> the `[...]` section of the debootsnap's description, maybe the list
> should be updated to:
> 
>   [apt-utils equivs mmdebstrap python3-debian python3-pycurl python3-requests]
> 
> ?

I concur. Given that dpkg-dev is already listed as a hard Dependency of
devscripts and given that debootsnap indeed requires python3-debian and
python3-requests, the list of packages following 'debootsnap' in the
Description stanza of devscripts' metadata should read:

[apt-utils, equivs, mmdebstrap, python3-debian, python3-pycurl, 
python3-requests]

-- 
Plasma

Bug#1055538: fanwor: Non-free music

[David (Plasma) Paul]

Package: fanwor
Version: 1.16-1
Severity: serious
Justification: Music is ineligible for inclusion in main and is not
 properly attributed in debian/copyright

Dear Maintainer,

The music for fanwor located at /usr/share/fanwor/sounds/backgrnd.mod,
while a jazzed-up remix, is unmistakably the theme tune for Nintendo's
The Legend of Zelda which has not been released by them under a
DFSG-compatible license.

Additionally, the author of the remix is left unattributed in the
package's copyright file. Opening /usr/share/fanwor/sounds/backgrnd.mod
in a tracker such as milkytracker or simply viewing it in a hex editor
reveals this embedded message:
```
ZELDA REMIX
BY MSG (C) MAR 1998
ORIGINAL VERSION BY:
TOODELOO / DHS AND...
 3LE / COMA
```
Judging from https://demozoo.org/music/10/, it appears this music
originates from a demoscene production which debuted at the OrlandoJam
event in 1998.

-- 
Plasma

Bug#1054888: fontconfig: FTBFS: Missing testsuite dependency on uuid-runtime

[David (Plasma) Paul]

Source: fontconfig
Version: 2.14.1-1
Severity: normal

Dear Maintainer,

Please add a 'uuid-runtime ' entry to the Build-Depends
stanza of fontconfig's debian/control file.

Starting from version 2.14.1-1, the testsuite for fontconfig requires
running the uuidgen command which comes from the uuid-runtime package.
fontconfig does not list uuid-runtime among its build dependencies, but
it does declare a Build-Depends on uuid-dev which Depends on libuuid1
which Recommends uuid-runtime, so this issue only arises when
Recommended packages aren't automatically installed.

Thanks,

-- 
Plasma

Bug#1053003: mmdebstrap: Support build profile

[David (Plasma) Paul]

Source: mmdebstrap
Version: 1.3.8-3
Severity: wishlist
Tags: patch

Dear Maintainer,

Please accept the attached patch to add support for the  build
profile to mmdebstrap. Please let me know if there's anything you'd
like me to clarify or change.


Some notes on the patch:
Because generating the mmtarfilter(1) manpage requires running the
mmtarfilter python script and because that script makes use of the
'match' keyword that was not introduced until Python 3.10, I've added
a (>= 3.10) version restriction to the python3 build dependency. This
mimics the existing (>= 3.10) versioned dependency on python3 for the
generated binary package. See [1]. This isn't an issue in unstable
where the current version of Python is 3.11, but is useful information
for anyone making backports [2].


[1] 
https://salsa.debian.org/debian/mmdebstrap/-/commit/cd4b44e51402e192ac6fb4cb0373eb817e72172e
[2] I initially was trying to build the stable release of mmdebstrap on
oldstable when I hit this issue with oldstable's Python 3.9 erroring
out on the 'match' statement. For my own local backport I ended up just
rewriting the 'match' statement as an 'if-elif-else' block[3].
[3] Also, FWIW, the mmtarfilter script contains a section of code
headed by a comment explaining that it is for compatibility with Python
versions older than 3.8. As the aforementioned 'match' statement makes
the script in its current form error out with any Python version
less than 3.10, this code path may no longer be necessary.


Thanks,

-- 
Plasma


mmdebstrap_1.3.8-3.1.debdiff
Description: Binary data

Bug#1035822: fontforge: Superfluous build dependency on potrace

[David (Plasma) Paul]

Source: fontforge
Version: 1:20201107~dfsg-1
Severity: minor

Dear Maintainer,

Please drop the build dependency on potrace from fontforge.

Prior to upstream fontforge's transition from Autotools to CMake in
version 20200314 [1], the Autoconf configure script contained a
compile-time check for potrace; however, AFAICT this was never anything
more than WIP code and nothing was ever done with the results of this
check. Starting with switch to a CMake buildsystem the compile-time
check for potrace is completely gone.

[1] https://github.com/fontforge/fontforge/releases/tag/20200314

-- 
Plasma

Bug#1032859: bugs.debian.org: Mis-parsing of message results in rejection

[David (Plasma) Paul]

Package: bugs.debian.org
Severity: important

Yesterday I tried several times to submit a patch to fix a bug[1] I had
I had reported moments earlier. I received automated rejections to my
first three attempts to submit the patch. After each rejection, I
modified my message slightly trying to determine what was causing the
rejection. For the fourth attempt I modified the commit message of the
change and regenerated the patch using 'git format-patch'. Previous to
this, the summary line of the commit included a "Closes:" message, but
when I moved that part of the line into the long description, my
mail was accepted. I think the original commit message in the patch was
getting mis-parsed as an email header somehow. I've attached a tarball
of the full source of all four original messages along with the
rejection responses to the first three. (I thought about just adding
the individual messages as attachments, but I wouldn't be surprised if
that resulted in this message being rejected by the same issue.)

[1] https://bugs.debian.org/1032816

-- 
Plasma


1032816-messages.tar.gz
Description: application/gzip

Bug#1032816: Add pkg.debianhelper.nonls build profile

[David (Plasma) Paul]

Let me know if there's anything you'd like me change or clarify.

-- 
Plasma
>From 8695f76d923b518bbd64971cf3da4e9e06d09371 Mon Sep 17 00:00:00 2001
From: "David (Plasma) Paul" 
Date: Sat, 11 Mar 2023 18:13:18 -0600
Subject: [PATCH] Add  build profile

Closes: #1032816
---
 debian/changelog | 4 
 debian/control   | 2 +-
 debian/rules | 4 
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index bf50f143..dab2f054 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,10 @@ debhelper (13.11.5~2.gbp4a55fa) UNRELEASED; urgency=medium
 (Closes: #1028159)
   * Update on German translation of pages (Closes: #1028564)
 
+  [ David "Plasma" Paul ]
+  * Add  build profile (Closes: #1032816)
+(See also #709557)
+
  -- Niels Thykier   Sat, 04 Mar 2023 14:07:03 +0100
 
 debhelper (13.11.4) unstable; urgency=medium
diff --git a/debian/control b/debian/control
index 4a63b296..21aaeb76 100644
--- a/debian/control
+++ b/debian/control
@@ -7,7 +7,7 @@ Build-Depends: dpkg-dev (>= 1.18.0~),
libtest-pod-perl ,
man-db ,
perl:any,
-   po4a,
+   po4a ,
 Rules-Requires-Root: no
 Standards-Version: 4.6.1
 Testsuite: autopkgtest-pkg-perl
diff --git a/debian/rules b/debian/rules
index fb4e5201..4bf56339 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,6 +9,10 @@
 # We disable autoreconf to avoid build-depending on it (it does
 # nothing for debhelper and it keeps the set of B-D smaller)
 
+ifneq (,$(filter pkg.debhelper.nonls,$(DEB_BUILD_PROFILES)))
+export USE_NLS=no
+endif
+
 PERL ?= perl
 
 %:
-- 
2.30.2

Bug#1031113: davegnukem: rules breaks parallel build

[David (Plasma) Paul]

On Fri, 17 Feb 2023 12:59:23 +0100
Matteo Bini  wrote:

> Hi Plasma,
> thanks for the patch!

Happy to help.

> Before applying your fix, I would like to ask you what is the
> difference between calling `$(MAKE)` and `dh_auto_build --`.

dh_auto_build, as a part of debhelper, automatically modifies the build
environment and sets makeflags before running the program's Makefile.
Importantly in this case, it checks the environment variable
DEB_BUILD_OPTIONS to see if it contains a "parallel=n" tag. If it does,
debhelper adds '-j' to the makeflags with the associated value n. If
DEB_BUILD_OPTIONS doesn't exist or doesn't contain a "parallel=n" tag,
debhelper sets the makeflags to build with as many CPU threads are
available. Running make directly using $(MAKE) only handles
DEB_BUILD_OPTIONS properly with additional boilerplate code. See Debian
Policy Section 4.9.1 (link below) for an example. In general it's much
easier to let debhelper do the heavy lifting rather than having to write
a bunch of the same boilerplate for each package.

https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options

> Moreover I was wondering if your patch could make davegnukem build
> reproducibly, because now it does not.

I'm not sure. I don't think so. I skimmed the build logs for
davegnukem, but I wasn't able to tell what was keeping it from building
reproducibly, sorry.

> This is one of my first packages, so please forgive my ignorance. I
> really appreciate your help.

Ignorance is easy to forgive in anyone willing and eager to learn. :-)

-- 
Plasma

Bug#678437: [PATCH] Fix #678437 and simplify debian/rules

[David (Plasma) Paul]

Tags: patch

Dear Maintainer,

I've attached a patch which resolves #678437 while greatly simplifying
the debian/rules file for src:mp3blaster.

Please let me know if there's anything you'd like me to change or
clarify.

-- 
Plasma
>From 7cced11bf3d4cb23e7556d2792adacc3ae2a9928 Mon Sep 17 00:00:00 2001
From: "David (Plasma) Paul" 
Date: Sun, 19 Feb 2023 21:48:17 -0600
Subject: [PATCH] Fix #678437 and simplify debian/rules

---
 debian/changelog   | 31 +++
 debian/control | 10 +-
 debian/mp3blaster.dirs |  2 --
 debian/mp3blaster.docs |  5 -
 debian/mp3blaster.examples |  4 ++--
 debian/mp3blaster.install  |  4 
 debian/mp3blaster.links|  1 +
 debian/mp3blaster.manpages |  2 ++
 debian/not-installed   |  1 +
 debian/rules   | 23 ---
 10 files changed, 58 insertions(+), 25 deletions(-)
 delete mode 100644 debian/mp3blaster.dirs
 create mode 100755 debian/mp3blaster.install
 create mode 100644 debian/mp3blaster.links
 create mode 100644 debian/not-installed

diff --git a/debian/changelog b/debian/changelog
index 573b9e6..a1b5708 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,34 @@
+mp3blaster (1:3.2.6-2.1) UNRELEASED; urgency=low
+
+  * debian/control: Build-Depend on dh-exec.
+  * debian/mp3blaster.dirs: Delete.
+  * debian/mp3blaster.docs: Remove doc/commands.txt.
+  * debian/mp3blaster.examples:
+- Copy charmap/ and sample.mp3blasterrc from debian/tmp.
+  * debian/mp3blaster.install:
+- Use dh-exec to move and rename nmixer/Changelog to
+  changelog.nmixer in the doc/ directory.
+- Install binaries into /usr/bin.
+- Install commands.txt into /usr/share/mp3blaster,
+  as per Policy section 12.3.
+  (Closes: #678437) (See also: #158595, #226926)
+  * debian/mp3blaster.links:
+- Link to /usr/share/mp3blaster/commands.txt from
+  /usr/share/doc/mp3blaster/commands.txt, as per
+  Policy section 12.3.
+  * debian/mp3blaster.manpages: Add mp3blaster.1 and nmixer.1.
+  * debian/not-installed: Mark splay.1 as not installed.
+  * debian/rules:
+- Greatly simplify makefile.
+- Remove the confusing hack conflating datadir and docdir
+  in the configure target.
+- Install files into debian/tmp then copy into place.
+- Eliminate duplicate installation of charmap/ and
+  sample.mp3blasterrc.
+- Exclude /usr/bin/splay from installation.
+
+ -- David (Plasma) Paul   Sun, 19 Feb 2023 21:41:41 -0600
+
 mp3blaster (1:3.2.6-2) unstable; urgency=medium
 
   * QA upload.
diff --git a/debian/control b/debian/control
index 0473baa..8bdd202 100644
--- a/debian/control
+++ b/debian/control
@@ -4,7 +4,15 @@ Priority: optional
 Maintainer: Debian QA Group 
 Standards-Version: 4.5.1
 Rules-Requires-Root: no
-Build-Depends: libncurses5-dev, libvorbis-dev (>= 1.0.0-3), debhelper-compat (= 13), libsidplay1-dev (>= 1.36.59-3), libsdl1.2-dev, autoconf, automake
+Build-Depends:
+ autoconf,
+ automake,
+ dh-exec,
+ debhelper-compat (= 13),
+ libncurses5-dev,
+ libsdl1.2-dev,
+ libsidplay1-dev (>= 1.36.59-3),
+ libvorbis-dev (>= 1.0.0-3),
 Homepage: http://mp3blaster.sf.net
 Vcs-Browser: https://browse.dgit.debian.org/mp3blaster.git/
 Vcs-Git: https://git.dgit.debian.org/mp3blaster.git
diff --git a/debian/mp3blaster.dirs b/debian/mp3blaster.dirs
deleted file mode 100644
index 98d1583..000
--- a/debian/mp3blaster.dirs
+++ /dev/null
@@ -1,2 +0,0 @@
-usr/bin
-usr/share/man/man1
diff --git a/debian/mp3blaster.docs b/debian/mp3blaster.docs
index 60f7575..c17f037 100644
--- a/debian/mp3blaster.docs
+++ b/debian/mp3blaster.docs
@@ -1 +1,4 @@
-NEWS README AUTHORS TODO doc/commands.txt
+AUTHORS
+NEWS
+README
+TODO
diff --git a/debian/mp3blaster.examples b/debian/mp3blaster.examples
index c3c6c9b..4b50ab1 100644
--- a/debian/mp3blaster.examples
+++ b/debian/mp3blaster.examples
@@ -1,2 +1,2 @@
-doc/charmap
-doc/sample.mp3blasterrc
+debian/tmp/usr/share/mp3blaster/charmap/
+debian/tmp/usr/share/mp3blaster/sample.mp3blasterrc
diff --git a/debian/mp3blaster.install b/debian/mp3blaster.install
new file mode 100755
index 000..ab14606
--- /dev/null
+++ b/debian/mp3blaster.install
@@ -0,0 +1,4 @@
+#!/usr/bin/dh-exec
+nmixer/ChangeLog => /usr/share/doc/mp3blaster/changelog.nmixer
+usr/bin
+usr/share/mp3blaster/commands.txt
diff --git a/debian/mp3blaster.links b/debian/mp3blaster.links
new file mode 100644
index 000..991f419
--- /dev/null
+++ b/debian/mp3blaster.links
@@ -0,0 +1 @@
+usr/share/mp3blaster/commands.txt  usr/share/doc/mp3blaster/commands.txt
diff --git a/debian/mp3blaster.manpages b/debian/mp3blaster.manpages
index 1708b80..8ce4d6b 100644
--- a/debian/mp3blaster.manpages
+++ b/debian/mp3blaster.manpages
@@ -1 +1,3 @@
 debian/manpages/mp3tag.1
+usr/share/man/man1/mp3blaster.1
+usr/share/man/man1/nmixer.1
diff --git a/debian/not-installed b/debian/not-installed
new file mode 100644
index 000..a910cdc
--- /dev/nul

Bug#1024672: slim: New upstream

[David (Plasma) Paul]

Source: slim
Version: 1.3.6-5.3
Severity: wishlist

Dear Maintainer,

Please consider switching the slim package's upstream to the new
development being done by Rob Pearce at
.

To quote him on that page:

"The SLiM project used to be hosted on Berlios.de with a mirror on
SourceForge. Then the code got moved to Github. Then all the
maintainers lost interest and it died. Nine years later, I'm still
using it as I find it the most easily configurable, most lightweight
option for the small Linux systems I build. But with upstream being
dead and Gentoo needing 13 patch files to make it work, there was a
risk it would vanish from the repository. So I've forked it, applied
all the patches, plus some of my own, and started my own spin-off here."


-- 
Plasma

Bug#1017377: libstb: Fix for #1017378 and #1017377

[David (Plasma) Paul]

Dear Maintainer,

Attached is a debdiff which contains a combined fix for both #1017378
and #1017377. It should be appliable with debdiff-apply(1) from the
devscripts package.

Please let me know if you'd like me to modify my fix in any way.

Thanks,

-- 
Plasma


libstb-fix-1017378-and-1017377.debdiff
Description: Binary data

Bug#1017378: libstb: stb_vorbis header missing from include directory

[David (Plasma) Paul]

Package: libstb-dev
Version: 0.0~git20210910.af1a5bc+ds-1
Severity: normal
X-Debbugs-CC: davidp...@librem.one

Dear Maintainer,

The libstb-dev package is missing a header file in /usr/include/stb
corresponding to stb_vorbis.c.

I have prepared a patch to correct this. I will submit the patch
momentarily once I update the changelog entry with the bug number
created by this report.

-- 
Plasma

Bug#1017377: libstb: incomplete clean target

[David (Plasma) Paul]

Source: libstb
Version: 0.0~git20210910.af1a5bc+ds-1
Severity: minor
X-Debbugs-CC: davidp...@librem.one

Dear Maintainer,

The 'clean' target for the libstb Makefile is incomplete and leaves
behind two files, stb_c_lexer.c and stb_divide.c, generated by the
'%.c' target.

I have prepared a patch to correct this. I will submit the patch
momentarily once I update the changelog entry with the bug number
created by this report.

-- 
Plasma

Bug#1013204: markdown-it-py: FTBFS with flit < 3.4 (<3.3?)

[David (Plasma) Paul]

On Wed, 22 Jun 2022 14:13:29 +0200 Bastian Germann 
wrote:
> On Sat, 18 Jun 2022 17:58:24 -0500 "David (Plasma) Paul"
>  wrote:
> > markdown-it-py fails to build from source with versions of flit
> > earlier than 3.4 according to the package's pyproject.toml.[0]
> > Attached is a patch to fix the declared build dependency on flit in
> > the debian/control file to match the supported versions listed in
> > the package's pyproject.toml file.
> > 
> > [0] However, I was able to get markdown-it-py to build with flit
> > 3.3.0-1~bpo11+1, so maybe the value in the pyproject.toml file is
> > higher than it strictly needs to be. Regardless of what the actual
> > exact minimum value is, I can confirm that flit 3.0.0 is
> > insufficient.
> 
> Please do not file RC bugs when a bookworm/sid only package does not
> build for bullseye-backports. If you want a backport please express
> that intend otherwise this is invalid.

Apologies for the being overzealous with regards to Build-Depends
versioning. I will file this sort of report as a wishlist severity bug
in the future. Sorry for overstepping.


FWIW, my original reasoning for filing this bug went like this: For the
sake of ensuring bootstrappability of any release N of Debian by the
previous Debian release N-1, the build-dependencies of any release N
source package ought to be satisfiable solely by some combination of

(A) binary packages from the release N-1 binary archive
(B) binary packages built from release N source packages using
build-dependencies consisting solely of some combination of A and B

In order to aid in this bootstrapping process, the allowed versions of
the declared build dependencies of release N source packages should be
constrained such that combinations of A and B which satisify the
declared dependencies but fail to build the package are eliminated.


Again, I'm sorry for being a nuisance and I will try to do better in
the future.

-- 
Plasma

Bug#1014550: claws-mail: Please drop 11mark_trashed_as_read.patch

[David (Plasma) Paul]

Source: claws-mail
Version: 4.1.0-2
Severity: wishlist

Dear Maintainer,

Please consider dropping 11mark_trashed_as_read.patch from the set of
Debian patches for claws-mail. Whether the 'marked trashed as read'
functionality is desirable is, of course, a matter of taste, but I
personally would prefer to not have it.

-- 
Plasma

Bug#1013204: markdown-it-py: FTBFS with flit < 3.4 (<3.3?)

[David (Plasma) Paul]

Source: markdown-it-py
Version: 2.1.0-2
Severity: serious
Tags: ftbfs patch

Dear Maintainer,

markdown-it-py fails to build from source with versions of flit earlier than
3.4 according to the package's pyproject.toml.[0] Attached is a patch
to fix the declared build dependency on flit in the debian/control file
to match the supported versions listed in the package's pyproject.toml
file.

[0] However, I was able to get markdown-it-py to build with flit
3.3.0-1~bpo11+1, so maybe the value in the pyproject.toml file is
higher than it strictly needs to be. Regardless of what the actual
exact minimum value is, I can confirm that flit 3.0.0 is insufficient.

-- 
Plasma
diff -Nru markdown-it-py-2.1.0/debian/control markdown-it-py-2.1.0/debian/control
--- markdown-it-py-2.1.0/debian/control	2022-05-20 14:21:22.0 -0500
+++ markdown-it-py-2.1.0/debian/control	2022-06-18 17:49:09.0 -0500
@@ -4,7 +4,8 @@
 Maintainer: Debian Python Team 
 Uploaders: Emmanuel Arias ,
 Build-Depends: debhelper-compat (= 13),
-   flit,
+   flit (>= 3.4),
+   flit (<< 4),
pybuild-plugin-pyproject,
python3-all,
python3-attr,

Bug#1013191: mdurl: FTBFS with flit < 3.2

[David (Plasma) Paul]

Source: mdurl
Version: 0.1.1-1
Severity: serious
Tags: ftbfs patch

Dear Maintainer,

mdurl fails to build from source with versions of flit earlier than
3.2. Attached is a patch to fix the declared build dependency on flit
in the debian/control file to match the supported versions listed in
the package's pyproject.toml file.

-- 
Plasma
diff -Nru mdurl-0.1.1/debian/control mdurl-0.1.1/debian/control
--- mdurl-0.1.1/debian/control	2022-04-07 04:23:21.0 -0500
+++ mdurl-0.1.1/debian/control	2022-06-18 13:14:41.0 -0500
@@ -5,7 +5,8 @@
 Maintainer: Debian Python Team 
 Build-Depends: debhelper-compat (= 13),
dh-python,
-   flit,
+   flit (>= 3.2),
+   flit (<< 4),
pybuild-plugin-pyproject,
python3-all,
 	   python3-pytest ,

Bug#1013185: python3-defaults: Python Policy missing from doc-base

[David (Plasma) Paul]

Source: python3-defaults
Version: 3.10.4-1
Severity: normal

Dear Maintainer,

The Python Policy[0] is missing from the Debian doc-base[1][2] system.
In the debian directory of the python3-defaults source package there is
a file, 'python.doc-base.python-policy'[3], that appears to have been
copied over from the earlier python-defaults source package. (The
description in that file refers to Python Policy as still having a
draft status which I don't think has been true for quite a while. The
file 'README.Debian' in the debian directory also refers to the Python
Policy as a draft. That file also refers to a python3.6 directory as if
it that is the current release of python, so that file should probably
be updated or deleted.) Because the filename
'python.doc-base.python-policy' starts with 'python.', it doesn't
correspond to any current binary package, so dh_installdocs[4] doesn't
end up installing it anywhere.

Starting with python3-defaults 3.9.2-1, the Python Policy was converted
from DocBook to Sphinx format. The file 'python.doc-base.python-policy'
still mentions the DocBook format, so that will need to be updated.
Also starting from that version, the generated HTML version of the
Python Policy files were moved to the python3-dev binary package, but
the generated plaintext version of the policy was left in the python3
package. AIUI, the doc-base system doesn't really support multiple
formats of the same document in different binary packages. All included
formats of a document need to be in the same binary package. It is,
of course, up to you how you'd like to resolve that, whether that means
moving the plaintext version to python3-dev, moving the HTML back to
python3, dropping the plaintext version, whatever.

[0] https://www.debian.org/doc/packaging-manuals/python-policy/
[1] https://www.debian.org/doc/debian-policy/ch-opersys.html#s-doc-base
[2] /usr/share/doc/doc-base/doc-base.html/index.html
[3] 
https://sources.debian.org/src/python3-defaults/3.10.4-1/debian/python.doc-base.python-policy/
[4] 
https://manpages.debian.org/bookworm/debhelper/dh_installdocs.1.en.html#debian/~5

-- 
Plasma

Bug#997264: seriousproton: ftbfs FIX

[David (Plasma) Paul]

Attached is a patch to fix Debian bug #997264.

-- 
Plasma


seriousproton_2020.01.15+dfsg-1.1.debdiff
Description: Binary data

Bug#1006904: debsnap: Add a -l option as the short version of --list

[David (Plasma) Paul]

Source: devscripts
Version: 2.22.1
Severity: wishlist
Tags: patch

Dear Maintainer,

Please accept the attached patch which adds a -l short option to debsnap
that serves the same function as the existing --list long option.

I believe this patch should be directly `git am`-able as I created it
with `git format-patch`. This is my first time using `git format-patch`
to submit a patch, so if there's anything wrong with the patch, please
let me know. (Then I'll have a reason to use the `-v` option of `git
format-patch` for the first time as well.)

Thanks,

-- 
Plasma
>From 6c04b315752a3a8ba9ca24367355d790dabcd80f Mon Sep 17 00:00:00 2001
From: "David (Plasma) Paul" 
Date: Mon, 7 Mar 2022 16:41:09 -0600
Subject: [PATCH] debsnap: Add a -l option as the short version of --list.

---
 debian/changelog   | 4 
 scripts/debsnap.1  | 2 +-
 scripts/debsnap.pl | 4 ++--
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 713b9085..b220c546 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ devscripts (2.22.2) UNRELEASED; urgency=medium
   * who-permits-upload:
 + Fix fingerprint lookup, so it actually finds the user id
 
+  [ David Paul ]
+  * debsnap:
++ Add a -l option as the short version of --list.
+
  -- Mattia Rizzolo   Sun, 23 Jan 2022 18:04:17 +0100
 
 devscripts (2.22.1) unstable; urgency=medium
diff --git a/scripts/debsnap.1 b/scripts/debsnap.1
index 11fae5b9..7958e9e9 100644
--- a/scripts/debsnap.1
+++ b/scripts/debsnap.1
@@ -45,7 +45,7 @@ Report on the \fBdebsnap\fP configuration being used and progress during the
 download operation.  Please always use this option when reporting bugs.
 
 .TP
-.BR \-\-list
+.BR \-l ", " \-\-list
 Don't download but just list versions.
 
 .TP
diff --git a/scripts/debsnap.pl b/scripts/debsnap.pl
index f687259c..09be5355 100755
--- a/scripts/debsnap.pl
+++ b/scripts/debsnap.pl
@@ -85,7 +85,7 @@ The following options are supported:
 Default is ./source-
 -f, --force Force overwriting an existing
 destdir
---list  Don't download but just list versions
+-l, --list  Don't download but just list versions
 --binaryDownload binary packages instead of
 source packages
 -a ,
@@ -215,7 +215,7 @@ Getopt::Long::Configure('no_ignore_case');
 GetOptions(
 \%opt,'verbose|v', 'destdir|d=s', 'force|f',
 'help|h', 'version',   'first=s', 'last=s',
-'list',   'binary','architecture|a=s@'
+'list|l', 'binary','architecture|a=s@'
 ) || usage(1);
 
 usage(0)  if $opt{help};
-- 
2.28.0

Bug#1003100: src:debugedit: please drop gcc-driver.diff patch

[David (Plasma) Paul]

Source: debugedit
Version: 1:5.0-4
Severity: minor

Dear Maintainer,

Please drop the 'gcc-driver.diff' debian patch from the debugedit
source package. The patch breaks testsuite tests 6, 7, 11, 14, 18, and
23, all of which involve partial linking[1], when compiling on an
oldstable Debian 10 Buster system with its gcc-8 compiler and ld version
2.31.1 linker. Additionally the patch just seems to be arbitrary and
incorrect.

[1] Test 19 is the only other test involving partial linking, but it is
skipped by default.

-- 
Plasma

Bug#1001831: debhelper: RFC: Parse 'Rules-Requires-Root: no' in debian/control

[David (Plasma) Paul]

Package: debhelper
Version: 13.5.2
Severity: wishlist

Request For Comments


For the specific, special case where "Rules-Requires-Root: no" is
explicitly declared in debian/control of a source package which uses
debhelper and no overriding DEB_RULES_REQUIRES_ROOT environment variable
is set, dh_testroot ought to return successfully. In other words, for
such a source package, when all build dependencies are met, manually
executing
```
$ debian/rules binary
```
as a non-root user and without a DEB_RULES_REQUIRES_ROOT environment
variable set should result in a successful build of the associated
binary packages.

Debhelper already parses the "Build-Depends:" header in debian/control
for what compatibility level to use, so it should be trivial to
additionally parse the "Rules-Requires-Root:" header to check for this
special case. If, however, a DEB_RULES_REQUIRES_ROOT environment
variable is present (such as for testing purposes), its value should
take precedence, of course.

This proposed change would require a minor amendment to Debian Policy §
5.6.31, in particular a modification of the final sentence.

I believe that this change would be entirely backwards-compatible with
older build environment such as backports. I will no doubt be corrected
by you, dear reader, if this is not the case.

Links:

dh_testroot(1)
https://manpages.debian.org/bookworm/debhelper/dh_testroot.1

debhelper(7) § COMPATIBILITY LEVELS
https://manpages.debian.org/bookworm/debhelper/debhelper.7#COMPATIBILITY_LEVELS

RFC: Support for selective usage of (fake)root during package build (R³)
https://lists.debian.org/debian-devel/2017/10/msg00520.html

Debian Policy § 4.9.2  debian/rules and Rules-Requires-Root
https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-rules-requires-root

Debian Policy § 5.6.31  Rules-Requires-Root
https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-rules-requires-root

-- 
Plasma

Bug#998110: debsums: obsolete dependency on ucf

[David (Plasma) Paul]

Package: debsums
Version: 3.0.2
Severity: minor

The debsums package Depends on ucf, but since commit
https://salsa.debian.org/perl-team/modules/packages/debsums/commit/718bb9e32ae7488c05cbb0403c6ead5f741d434f
(released as part of version 2.2.5) all usage of ucf has been removed
from the package. AFAICT, when ucf was last used by the package, it was
solely to handle removal of a config
file, /etc/apt/apt.conf.d/90debsums, that was removed from the package
nearly a decade ago in 2012. Would it now be appropriate to drop this
dependency?

-- 
David "Plasma" Paul

Bug#995029: git-filter-repo: add test-results to clean target

[David (Plasma) Paul]

Source: git-filter-repo
Version: 2.33.0-1
Severity: minor
Tags: patch

Dear Maintainer,

Please add 't/test-results/' to the list of files to clean.

-- 
Plasma
diff --git a/debian/clean b/debian/clean
index dd5d340..6810313 100644
--- a/debian/clean
+++ b/debian/clean
@@ -6,3 +6,4 @@ release/README.md
 release/git_filter_repo.egg-info/
 release/git_filter_repo.py
 release/git-filter-repo
+t/test-results/

Bug#995027: git-filter-repo: git Build-Dep should be increased to 1:2.28

[David (Plasma) Paul]

Source: git-filter-repo
Version: 2.33.0-1
Severity: normal
Tags: patch

Dear Maintainer,

In order to fully pass the test suite of git-filter-repo, git version
2.28 or later is required. Therefore, the git build dependency of the
git-filter-repo source package as well as the git dependency of the
git-filter-repo binary package should both be raised to ">= 1:2.28".

-- 
Plasma
diff --git a/debian/control b/debian/control
index 2c0ba21..3f9e280 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends:
  dh-python,
  docbook-xsl,
  dos2unix,
- git (>= 1:2.22),
+ git (>= 1:2.28),
  python3,
  python3-setuptools,
  python3-setuptools-scm,
@@ -23,7 +23,7 @@ Rules-Requires-Root: no
 
 Package: git-filter-repo
 Architecture: all
-Depends: git (>= 2.22), ${misc:Depends}, ${python3:Depends}
+Depends: git (>= 1:2.28), ${misc:Depends}, ${python3:Depends}
 Recommends: ${python3:Recommends}
 Suggests: ${python3:Suggests}
 Description: Quickly rewrite git repository history

Bug#994900: git-filter-repo: git Build-Depends missing version epoch

[David (Plasma) Paul]

Source: git-filter-repo
Version: 2.33.0-1
Severity: important
Tags: patch

Dear Maintainer,

In the list of Build-Depends for git-filter-repo, the version
requirement for git is listed as ">= 2.22". Because the git package's
version number contains an epoch[1], the version requirement in the
control file should be rewritten as ">= 1:2.22". Otherwise, as written,
the current version requirement is satisfiable by literally every
version of the git package that has ever been in Debian.

[1] 
https://wiki.debian.org/Teams/Dpkg/FAQ#Q:_What_are_version_epochs_and_why_and_when_are_they_needed.3F

-- 
Plasma
diff --git a/debian/control b/debian/control
index fecdb1e..2c0ba21 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,7 @@ Build-Depends:
  dh-python,
  docbook-xsl,
  dos2unix,
- git (>= 2.22),
+ git (>= 1:2.22),
  python3,
  python3-setuptools,
  python3-setuptools-scm,