Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
I'd add my vote to this. It's one of those consistent daily annoyances. Very grateful for the workaround in .config/Terminal/terminalrc though! Thanks, - Chris
Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
This bug is a couple years old, but I still would like a way to change this behavior. Has anything happened upstream? Thanks, -- Matt Taggart tagg...@debian.org
Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On Fri, Feb 15, 2013 at 12:37:00PM +, Chris Butler wrote:
On Thu, Dec 22, 2011 at 11:06:49PM +0100, Adam Borowski wrote:
Coding wise, it appears to be a trivial change: in
terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle
click, if the hidden setting is false, it would proceed to paste.
Would a patch of this kind be accepted?
On one hand, it's an itch that annoys me personally. On the other hand, no
one wants creeping featurism. You guys probably know better whether I
should stop whining and accept less convenient pastes, or help changing
that.
Just to add my $0.02, this is also an issue I've come across, and I would
love to see a config option for turning this off as well.
Did you get anywhere with writing a patch for this or sending the issue
upstream? If not I might look into it myself.
The patch I'm using on my own box is destructive and not good for public
consumption (attached). Making that depend on a hidden setting would be
easy, except for one issue: XFCE requires all strings to be translated,
at least for a release. If I recall correctly, upstream at that point was
in release mode, and I forgot about the issue (hey, on my system the problem
has been dealt with :) ).
--
ᛊᚨᚾᛁᛏᚣ᛫ᛁᛊ᛫ᚠᛟᚱ᛫ᚦᛖ᛫ᚹᛖᚨᚲ
diff -urd xfce4-terminal-0.4.8.orig/terminal/terminal-widget.c xfce4-terminal-0.4.8/terminal/terminal-widget.c
--- xfce4-terminal-0.4.8.orig/terminal/terminal-widget.c 2011-06-21 22:32:31.0 +0200
+++ xfce4-terminal-0.4.8/terminal/terminal-widget.c 2011-12-23 00:56:31.886603008 +0100
@@ -399,6 +399,7 @@
if (event-button == 2 event-type == GDK_BUTTON_PRESS)
{
+#if 0
/* middle-clicking on an URI fires the responsible application */
match = vte_terminal_match_check (VTE_TERMINAL (widget),
event-x / VTE_TERMINAL (widget)-char_width,
@@ -410,6 +411,7 @@
g_free (match);
return TRUE;
}
+#endif
}
else if (event-button == 3 event-type == GDK_BUTTON_PRESS)
{
Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On Thu, Dec 22, 2011 at 11:06:49PM +0100, Adam Borowski wrote: On Thu, Dec 22, 2011 at 10:59:23PM +0100, Yves-Alexis Perez wrote: I honestly don't think that's needed, but will report that upstream, when back from [VAC] (or if any other team member does it meanwhile). Coding wise, it appears to be a trivial change: in terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle click, if the hidden setting is false, it would proceed to paste. Would a patch of this kind be accepted? On one hand, it's an itch that annoys me personally. On the other hand, no one wants creeping featurism. You guys probably know better whether I should stop whining and accept less convenient pastes, or help changing that. Just to add my $0.02, this is also an issue I've come across, and I would love to see a config option for turning this off as well. Did you get anywhere with writing a patch for this or sending the issue upstream? If not I might look into it myself. -- Chris Butler chr...@debian.org GnuPG Key ID: 4096R/49E3ACD3 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
Package: xfce4-terminal Version: 0.4.8-1+b1 Severity: wishlist Unlike left and right mouse buttons, the middle one doesn't care about where the mouse is pointing. With one exception: if the mouse happens to be on something that looks like an email address, in which case xfce-terminal will start some useless mail program. This is infuriating, for example, when picking commits off a git log, etc. Even if this functionality actually did something useful (instead of replicating double-click + switch + compose mail + middle click), it is redundant with the very first menu entry upon right-clicking the address. It'd be great if there was a way to disable this misfeature. -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (150, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 3.1.0-1-amd64 (SMP w/6 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages xfce4-terminal depends on: ii exo-utils 0.6.2-3 ii libatk1.0-0 2.2.0-2 ii libc6 2.13-23 ii libdbus-1-3 1.4.16-1 ii libdbus-glib-1-20.98-1 ii libexo-1-0 0.6.2-3 ii libgdk-pixbuf2.0-0 2.24.0-2 ii libglib2.0-02.30.2-4 ii libgtk2.0-0 2.24.8-2 ii libpango1.0-0 1.29.4-2 ii libvte9 1:0.28.2-4 ii libx11-62:1.4.4-4 ii libxfce4util4 4.8.2-1 Versions of packages xfce4-terminal recommends: ii dbus-x11 1.4.16-1 xfce4-terminal suggests no packages. -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#652999: [Pkg-xfce-devel] Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: Package: xfce4-terminal Version: 0.4.8-1+b1 Severity: wishlist Unlike left and right mouse buttons, the middle one doesn't care about where the mouse is pointing. With one exception: if the mouse happens to be on something that looks like an email address, in which case xfce-terminal will start some useless mail program. This is infuriating, for example, when picking commits off a git log, etc. Even if this functionality actually did something useful (instead of replicating double-click + switch + compose mail + middle click), it is redundant with the very first menu entry upon right-clicking the address. It'd be great if there was a way to disable this misfeature. Actually, it works with any link. The fact that you call this a misfeature doesn't make it so, and calling it like that doesn't look to me like the best way to have it changed. -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Bug#652999: [Pkg-xfce-devel] Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On Thu, Dec 22, 2011 at 08:55:28PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: Unlike left and right mouse buttons, the middle one doesn't care about where the mouse is pointing. With one exception: if the mouse happens to be on something that looks like an email address, in which case xfce-terminal will start some useless mail program. This is infuriating, for example, when picking commits off a git log, etc. It'd be great if there was a way to disable this misfeature. Actually, it works with any link. The fact that you call this a misfeature doesn't make it so, and calling it like that doesn't look to me like the best way to have it changed. Ok, that makes two targets you have to watch out for. My problem with this feature is that it takes an untargetted command and makes it almost always untargetted but not quite one, working differently without warning. And with the usual use -- mark something in one tab, use keyboard to switch, paste -- this seriously slows the workflow down. xfce's biggest advantage over Gnome is the ability to actually configure things. For example, both xfce-terminal and gnome-terminal in their default configuration have a close button on every tab, another annoying thing that routinely causes data loss if you misclick when switching tabs. Unlike a browser where a tab can be reopened with a single command, losing a terminal can cost you a lot of time. In g-t, there is no recourse and Gnome folks actively refuse patches; in x-t you can set MiscTabCloseButtons=FALSE and all is fine. Tabs can still be closed with Ctrl-D or by right-click|close tab. So, what would you say about a way to disable middle click sometimes behaving differently? -- 1KB // Yo momma uses IPv4! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#652999: [Pkg-xfce-devel] Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: It'd be great if there was a way to disable this misfeature. Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Bug#652999: [Pkg-xfce-devel] Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On Thu, Dec 22, 2011 at 10:40:54PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: It'd be great if there was a way to disable this misfeature. Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) Oh, interesting. Its name made me think it's merely about display. However, turning that option off disables not only middle click, but also the right click menu. And that's a bad loss of functionality, since being able to click on URLs is pretty damn useful. It would be good to separate these two. Middle click is something that interferes with paste, right click has a menu where having extra options costs about nothing. -- 1KB // Yo momma uses IPv4! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#652999: [Pkg-xfce-devel] Bug#652999: Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On jeu., 2011-12-22 at 22:54 +0100, Adam Borowski wrote: On Thu, Dec 22, 2011 at 10:40:54PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: It'd be great if there was a way to disable this misfeature. Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) Oh, interesting. Its name made me think it's merely about display. However, turning that option off disables not only middle click, but also the right click menu. And that's a bad loss of functionality, since being able to click on URLs is pretty damn useful. It would be good to separate these two. Middle click is something that interferes with paste, right click has a menu where having extra options costs about nothing. I honestly don't think that's needed, but will report that upstream, when back from [VAC] (or if any other team member does it meanwhile). Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part
Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On Thu, Dec 22, 2011 at 10:59:23PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 22:54 +0100, Adam Borowski wrote: On Thu, Dec 22, 2011 at 10:40:54PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: It'd be great if there was a way to disable this misfeature. Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) Oh, interesting. Its name made me think it's merely about display. However, turning that option off disables not only middle click, but also the right click menu. And that's a bad loss of functionality, since being able to click on URLs is pretty damn useful. It would be good to separate these two. Middle click is something that interferes with paste, right click has a menu where having extra options costs about nothing. I honestly don't think that's needed, but will report that upstream, when back from [VAC] (or if any other team member does it meanwhile). Coding wise, it appears to be a trivial change: in terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle click, if the hidden setting is false, it would proceed to paste. Would a patch of this kind be accepted? On one hand, it's an itch that annoys me personally. On the other hand, no one wants creeping featurism. You guys probably know better whether I should stop whining and accept less convenient pastes, or help changing that. -- 1KB // Yo momma uses IPv4! -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#652999: [Pkg-xfce-devel] Bug#652999: xfce4-terminal: please add a way to disable (redefine?) middle click running mailto:
On jeu., 2011-12-22 at 23:06 +0100, Adam Borowski wrote: On Thu, Dec 22, 2011 at 10:59:23PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 22:54 +0100, Adam Borowski wrote: On Thu, Dec 22, 2011 at 10:40:54PM +0100, Yves-Alexis Perez wrote: On jeu., 2011-12-22 at 18:01 +0100, Adam Borowski wrote: It'd be great if there was a way to disable this misfeature. Try MiscHighlightUrls=False in ~/.config/Terminal/terminalrc (file:///usr/share/doc/xfce4-terminal/C/advanced.html#hidden-options) Oh, interesting. Its name made me think it's merely about display. However, turning that option off disables not only middle click, but also the right click menu. And that's a bad loss of functionality, since being able to click on URLs is pretty damn useful. It would be good to separate these two. Middle click is something that interferes with paste, right click has a menu where having extra options costs about nothing. I honestly don't think that's needed, but will report that upstream, when back from [VAC] (or if any other team member does it meanwhile). Coding wise, it appears to be a trivial change: in terminal/terminal-widget.c terminal_widget_button_press_event(), on a middle click, if the hidden setting is false, it would proceed to paste. Would a patch of this kind be accepted? Upstream? No idea. And I wouldn't include it on Debian if it was rejected upstream. I don't question the patch simplicity, but more the option adding. You already have a setting to manage that, adding one more just makes the code less readable. But anyway, that's upstream call :) Regards, -- Yves-Alexis Perez ANSSI/ACE/LAM signature.asc Description: This is a digitally signed message part
