Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-30 Thread Graham Inggs
I've pushed some commits to the git on collab-maint.

I added a comment about the overridden Lintian spelling error
warnings, rewrote the package descriptions, merged the changes I had
made in d/control into d/control.in and regenerated d/control, and
updated d/watch.

I did find Ubuntu bug LP: #810871 was the same as Debian bug #716543
and marked it accordingly.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-30 Thread Paul Gevers
Control: -1 pending

On 30-11-13 11:05, Graham Inggs wrote:
 I've pushed some commits to the git on collab-maint.
 
 I added a comment about the overridden Lintian spelling error
 warnings, rewrote the package descriptions, merged the changes I had
 made in d/control into d/control.in and regenerated d/control, and
 updated d/watch.

Looks good now, except that I get:
P: mtink source: duplicate-in-relation-field in source build-depends:
debhelper, debhelper (= 8)

I removed the non-versioned one from the control file, but please check
how to make the generation of the control file do the right thing.

 I did find Ubuntu bug LP: #810871 was the same as Debian bug #716543
 and marked it accordingly.

Nice.

Building and uploading. I push my changes to git and tag it.

Paul




signature.asc
Description: OpenPGP digital signature


Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-21 Thread Graham Inggs
On 20 November 2013 20:51, Paul Gevers elb...@debian.org wrote:
 Alioth is up again.

I see, thanks.

I've created a VCS [1] and have imported all of the previous versions.
I'll add my changes as individual commits.

 Additional question: have you checked if you could solve one of the
 Ubuntu bugs against mtink?

I have looked, but don't think there is anything I can fix there.

 And, as you have been working on silencing lintian, why have you not
 tried to fix the extended-description-is-probably-too-short info warning?

Override? :)

While importing the previous versions, I noticed there was a
debian/control.in file which I had overlooked previously.
It seems that debian/control needs to be generated manually from this
file. I haven't encountered this arrangement before and to me it seems
like maintaining this file is more of a hassle than it is worth.  Do I
have to maintain it, or can I remove it?


[1] http://anonscm.debian.org/gitweb/?p=collab-maint/mtink.git


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-21 Thread Paul Gevers
On 21-11-13 16:28, Graham Inggs wrote:
 I have looked, but don't think there is anything I can fix there.

Hmm, than I will leave some comments here and there.

 And, as you have been working on silencing lintian, why have you not
 tried to fix the extended-description-is-probably-too-short info warning?
 
 Override? :)

Well, , the idea would be to give a better description of course.
But maybe there is not a hell of a lot to tell more.

 While importing the previous versions, I noticed there was a
 debian/control.in file which I had overlooked previously.
 It seems that debian/control needs to be generated manually from this
 file.

Yes, people have applied such creation during building, but policy
doesn't allow that (for debian/control).

 I haven't encountered this arrangement before and to me it seems
 like maintaining this file is more of a hassle than it is worth.  Do I
 have to maintain it, or can I remove it?

If you think it doesn't help, yes, you can remove it. Usually if this is
done, it is because this way you can automate replacing variables in the
file. E.g. fpc and lazarus (which I co-maintain) use that procedure for
versioned packages.

Paul




signature.asc
Description: OpenPGP digital signature


Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-20 Thread Paul Gevers
On 14-11-13 21:56, Paul Gevers wrote:
 Would you mind creating a VCS repository on Alioth (collab-maint comes
 to mind) to ease further QA maintenance?

 That's a good idea.  I will do that.
 
 Alioth is down due to broken disk raid, so you'll have to wait for now.

Alioth is up again.

 Additional question: have you checked if you could solve one of the
 Ubuntu bugs against mtink?
 
 And, as you have been working on silencing lintian, why have you not
 tried to fix the extended-description-is-probably-too-short info warning?

[PING]

Paul




signature.asc
Description: OpenPGP digital signature


Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-14 Thread Paul Gevers
On 13-11-13 14:46, Graham Inggs wrote:
 Isn't it (easily) possible to fix these spelling errors, or are they
 false positives? If you stick to the overrides, please document why in
 the override file.
 
 Well, they occur in non-English messages so I would say false positives,
 but perhaps the best solution is for me to ask in the relevant
 debian-l10n-* mailing lists.

Fair enough. I will add a note to the override file.

 Would you mind creating a VCS repository on Alioth (collab-maint comes
 to mind) to ease further QA maintenance?
 
 That's a good idea.  I will do that.

Alioth is down due to broken disk raid, so you'll have to wait for now.
No hurry.

Additional question: have you checked if you could solve one of the
Ubuntu bugs against mtink?

And, as you have been working on silencing lintian, why have you not
tried to fix the extended-description-is-probably-too-short info warning?

Paul




signature.asc
Description: OpenPGP digital signature


Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-13 Thread Graham Inggs

 Isn't it (easily) possible to fix these spelling errors, or are they
 false positives? If you stick to the overrides, please document why in
 the override file.

Well, they occur in non-English messages so I would say false positives, 
but perhaps the best solution is for me to ask in the relevant 
debian-l10n-* mailing lists.


 Would you mind creating a VCS repository on Alioth (collab-maint comes
 to mind) to ease further QA maintenance?

That's a good idea.  I will do that.


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-12 Thread Graham Inggs

Package: sponsorship-requests
Severity: normal
Tags: patch

Dear mentors

I am looking for a sponsor for my patch to package mtink:

 * Package name: mtink
   Version : 1.0.16-8
   Upstream Author : Jean-Jacques Sarton jj.sar...@t-online.de
 * URL : http://xwtools.automatix.de/
 * License : GPL-2
   Section : misc

It builds the following binary packages:

mtink - Status monitor tool for Epson inkjet printers
mtink-doc - Documentation for mtink

The patch is attached to this bug report.

Changes since the last upload:

* QA upload.
* Really build with hardening flags.
* Override remaining Lintian spelling error warnings.
* Add keywords entries to d/*.desktop.

Regards
Graham

diff -Nru mtink-1.0.16/debian/changelog mtink-1.0.16/debian/changelog
--- mtink-1.0.16/debian/changelog	2013-09-06 20:54:56.0 +0200
+++ mtink-1.0.16/debian/changelog	2013-11-12 11:50:49.0 +0200
@@ -1,3 +1,12 @@
+mtink (1.0.16-8) UNRELEASED; urgency=low
+
+  * QA upload.
+  * Really build with hardening flags.
+  * Override remaining Lintian spelling error warnings.
+  * Add keywords entries to d/*.desktop.
+
+ -- Graham Inggs gra...@nerve.org.za  Tue, 12 Nov 2013 11:43:58 +0200
+
 mtink (1.0.16-7) unstable; urgency=low
 
   * QA upload.
diff -Nru mtink-1.0.16/debian/mtinkc.desktop mtink-1.0.16/debian/mtinkc.desktop
--- mtink-1.0.16/debian/mtinkc.desktop	2012-02-07 01:35:07.0 +0200
+++ mtink-1.0.16/debian/mtinkc.desktop	2013-11-11 16:48:33.0 +0200
@@ -9,3 +9,4 @@
 TryExec=mtinkc
 Exec=mtinkc
 Categories=Motif;Utility;HardwareSettings;Monitor;
+Keywords=Epson;inkjet;ink;status;monitor;printer;
diff -Nru mtink-1.0.16/debian/mtink.desktop mtink-1.0.16/debian/mtink.desktop
--- mtink-1.0.16/debian/mtink.desktop	2012-02-07 01:34:59.0 +0200
+++ mtink-1.0.16/debian/mtink.desktop	2013-11-11 16:48:22.0 +0200
@@ -9,3 +9,4 @@
 TryExec=mtink
 Exec=mtink
 Categories=Motif;Utility;HardwareSettings;Monitor;
+Keywords=Epson;inkjet;ink;status;monitor;printer;
diff -Nru mtink-1.0.16/debian/mtink.lintian-overrides mtink-1.0.16/debian/mtink.lintian-overrides
--- mtink-1.0.16/debian/mtink.lintian-overrides	1970-01-01 02:00:00.0 +0200
+++ mtink-1.0.16/debian/mtink.lintian-overrides	2013-11-11 17:12:56.0 +0200
@@ -0,0 +1,3 @@
+mtink: spelling-error-in-binary usr/bin/mtink proces process
+mtink: spelling-error-in-binary usr/bin/mtink Ment Meant
+mtink: spelling-error-in-binary usr/bin/ttink ment meant
diff -Nru mtink-1.0.16/debian/patches/harden-askprinter mtink-1.0.16/debian/patches/harden-askprinter
--- mtink-1.0.16/debian/patches/harden-askprinter	2013-09-06 20:40:12.0 +0200
+++ mtink-1.0.16/debian/patches/harden-askprinter	1970-01-01 02:00:00.0 +0200
@@ -1,15 +0,0 @@
-Description: compile detect/askPrinter.c with hardening flags
-Author: Graham Inggs gra...@nerve.org.za
-Forwarded: No
-Last-Update: 2013-07-31
 a/Makefile.ORG
-+++ b/Makefile.ORG
-@@ -269,7 +269,7 @@
- 
- $(DETDIR)/askPrinter: $(DETDIR)/askPrinter.c
- 	@echo Compile and link askPrinter.c
--	@$(CC) -o $(DETDIR)/askPrinter $(DETDIR)/askPrinter.c -I. -I$(DETDIR)
-+	@$(CC) -o $(DETDIR)/askPrinter $(DETDIR)/askPrinter.c $(CFLAGS) $(LDFLAGS) -I. -I$(DETDIR)
- 
- ### utilities ##
- 
diff -Nru mtink-1.0.16/debian/patches/pass-hardening-flags mtink-1.0.16/debian/patches/pass-hardening-flags
--- mtink-1.0.16/debian/patches/pass-hardening-flags	1970-01-01 02:00:00.0 +0200
+++ mtink-1.0.16/debian/patches/pass-hardening-flags	2013-11-11 17:21:07.0 +0200
@@ -0,0 +1,39 @@
+Description: pass hardening flags as required
+Author: Graham Inggs gra...@nerve.org.za
+Forwarded: No
+Last-Update: 2013-11-11
+--- a/Makefile.ORG
 b/Makefile.ORG
+@@ -235,12 +235,12 @@
+ 
+ ttink: $(TTYOBJ) $(SRCDIR)/d4lib.h $(SRCDIR)/cmd.h $(SRCDIR)/mtink.h $(SRCDIR)/model.h $(SRCDIR)/version.h Makefile
+ 	@echo Link ttink
+-	@$(CC) -o ttink $(TTYOBJ) $(CFLAGS) $(MTINK_CFLAGS) $(RDTIMEOUT) $(DEVICE) $(WRTIMEOUT) $(DEBUG) $(KERNEL_USB_BUG) $(MACOSLDFLG) -DWITH_X=0
++	@$(CC) -o ttink $(TTYOBJ) $(CFLAGS) $(MTINK_CFLAGS) $(LDFLAGS) $(RDTIMEOUT) $(DEVICE) $(WRTIMEOUT) $(DEBUG) $(KERNEL_USB_BUG) $(MACOSLDFLG) -DWITH_X=0
+ 
+ # PLUG-IN ###
+ gimp-mtink: $(SRCDIR)/gimp-mtink.c Makefile
+ 	@echo Compile and link gimp-mtink.c
+-	@-$(CC) -o gimp-mtink $(SRCDIR)/gimp-mtink.c $(GIMP_INC) $(GIMP_LIB)
++	@-$(CC) -o gimp-mtink $(SRCDIR)/gimp-mtink.c $(CFLAGS) $(LDFLAGS) $(GIMP_INC) $(GIMP_LIB)
+ 
+ # SERVER 
+ $(SVRDIR)/mtinkd.o: $(SVRDIR)/mtinkd.c Makefile
+@@ -257,7 +257,7 @@
+ 
+ mtinkd: $(SVR_OBJ) Makefile
+ 	@echo Link mtinkd
+-	@$(CC) -o mtinkd $(SVR_OBJ) $(CFLAGS) $(MTINK_CFLAGS) $(MACOSLDFLG) 
++	@$(CC) -o mtinkd $(SVR_OBJ) $(CFLAGS) $(MTINK_CFLAGS) $(LDFLAGS) $(MACOSLDFLG)
+ 
+ ### Chooser ##
+ 
+@@ -269,7 +269,7 @@
+ 
+ $(DETDIR)/askPrinter: $(DETDIR)/askPrinter.c
+ 	@echo Compile 

Bug#729359: RFS: mtink/1.0.16-8 [QA] -- Status monitor tool for Epson inkjet printers

2013-11-12 Thread Paul Gevers
Control: owner -1 !

On 12-11-13 11:01, Graham Inggs wrote:
 * Override remaining Lintian spelling error warnings.

Isn't it (easily) possible to fix these spelling errors, or are they
false positives? If you stick to the overrides, please document why in
the override file.

Would you mind creating a VCS repository on Alioth (collab-maint comes
to mind) to ease further QA maintenance?

Paul




signature.asc
Description: OpenPGP digital signature