Bug#760900: libteam: improving long description
Hi Filipus, I committed more of your suggestions here: http://anonscm.debian.org/cgit/collab-maint/libteam.git/commit/?id=3ffb0d479e10103b6f42c96713fd80654a559669 On Mon, 15 Sep 2014 23:10:40 Filipus Klutiero wrote: The noun phrase Linux kernel 3.3 or higher is missing a determiner. This could read version 3.3 or higher of the Linux kernel, or just Linux 3.3 or higher, although I'm not sure this sentence is necessary at this point. Somehow I'm not sure about this change On the side note I appreciate your changes but I wish you could bundle them together... I would be more happy to spend an hour for this ticket than to return to this task six times and spend ~10 min. each time. This is due to expensive context switches when I have to interrupt whatever I'm doing just for a minor update. Thanks. -- Best wishes, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#760900: libteam: improving long description
On Mon, 15 Sep 2014 00:56:35 Filipus Klutiero wrote: Thank you. Here are some more issues I notice: libteam is a library for communication with kernel module (Netlink).| The noun phrase kernel module is missing a determiner. Perhaps this should read with the Netlink kernel module. Also, libteam should not be quoted. This is already implemented in the Linux kernel by the bonding driver but unlike the bonding driver, libteam (user space) have the following additional features| libteam is third person singular, therefore have should read has. Updated with our 5th correction of the long description: http://anonscm.debian.org/cgit/collab-maint/libteam.git/commit/?id=00659711ac9ef2e69d0825dfe947a2ea4c469eb6 Thanks again for all your suggestions. -- Regards, Dmitry Smirnov. --- All that is necessary for the triumph of evil is that good men do nothing. signature.asc Description: This is a digitally signed message part.
Bug#760900: libteam: improving long description
Hi Dmitry, On 2014-09-15 02:02, Dmitry Smirnov wrote: On Mon, 15 Sep 2014 00:56:35 Filipus Klutiero wrote: Thank you. Here are some more issues I notice: libteam is a library for communication with kernel module (Netlink).| The noun phrase kernel module is missing a determiner. Perhaps this should read with the Netlink kernel module. Also, libteam should not be quoted. This is already implemented in the Linux kernel by the bonding driver but unlike the bonding driver, libteam (user space) have the following additional features| libteam is third person singular, therefore have should read has. Updated with our 5th correction of the long description: http://anonscm.debian.org/cgit/collab-maint/libteam.git/commit/?id=00659711ac9ef2e69d0825dfe947a2ea4c469eb6 Thanks again for all your suggestions. Thanks again for the changes. Here is libteamdctl0's description with more suggestions: | libteamdctl is a library for communication with teamd process (via D-Bus, unix socket or zeromq).| |libteamdctl should not be quoted. unix is a proper name and should be capitalized. | | It is used by `teamdctl` utility.| The noun phrase `teamdctl` utility|| is missing a determiner. This should read |the |`teamdctl` utility||, or just `teamdctl`||. | . Libteam provides a mechanism to team multiple NICs (ports) at OSI Layer 2 (Data link) into a single virtual NIC. The process is called channel bonding, Ethernet bonding, channel teaming, link aggregation, etc. This is already implemented in the Linux kernel by the bonding driver but unlike the bonding driver, libteam (user space) has the following additional features:| |unlike [...] additional| has something redundant. I'm not sure what libteam is and whether is uses the bonding driver or whether it replaces it, but if it supplements it, I would suggest the following formulation: The user-space libteam library adds the following features to the basic capabilities already implemented in the Linux kernel's bonding driver: | * load-balancing for LACP support * NS/NA (IPV6) link monitoring * port priorities and stickiness (primary option enhancement) * separate per-port link monitoring setup . Libteam requires Linux kernel 3.3 or higher.| The noun phrase Linux kernel 3.3 or higher is missing a determiner. This could read version 3.3 or higher of the Linux kernel, or just Linux 3.3 or higher, although I'm not sure this sentence is necessary at this point. -- Filipus Klutiero http://www.philippecloutier.com
Bug#760900: libteam: improving long description
On Sun, 14 Sep 2014 17:51:33 Filipus Klutiero wrote: The noun phrase bonding driver is missing a determiner such as the (this could read unlike the bonding driver). Also, I would recommend adding a comma after that. Thanks. Description updated yet again, I hope it is all good now: http://anonscm.debian.org/cgit/collab-maint/libteam.git/diff/?id=99cd2aff05febfaa8e3e8434828865aa13851c60 -- Cheers, Dmitry Smirnov. signature.asc Description: This is a digitally signed message part.
Bug#760900: libteam: improving long description
Hi Dmitry, On 2014-09-14 21:50, Dmitry Smirnov wrote: On Sun, 14 Sep 2014 17:51:33 Filipus Klutiero wrote: The noun phrase bonding driver is missing a determiner such as the (this could read unlike the bonding driver). Also, I would recommend adding a comma after that. Thanks. Description updated yet again, I hope it is all good now: http://anonscm.debian.org/cgit/collab-maint/libteam.git/diff/?id=99cd2aff05febfaa8e3e8434828865aa13851c60 Thank you. Here are some more issues I notice: | libteam is a library for communication with kernel module (Netlink).| The noun phrase kernel module is missing a determiner. Perhaps this should read with the Netlink kernel module. Also, libteam should not be quoted. | This is already implemented in the Linux kernel by the bonding driver but unlike the bonding driver, libteam (user space) have the following additional features| libteam is third person singular, therefore have should read has. -- Filipus Klutiero http://www.philippecloutier.com
