Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-11 Thread Christian Kastner 
On 2015-10-11 07:54, James Lu wrote:
>> d/copyright:
>>  - The license appears to be GPL-3, not GPL-3+ (at least in the handful
>>of files I checked). This also requires correction of the free-
>>standing license block (the last paragraph)
> 
> I see. Ubuntu's packaging wrote the license as GPL-3+ for both the
> packaging and the source, but I guess the license of the individual
> files must prevail here. Fixed.

Hm, I just realized that I overlooked something here, namely the license
of the packaging that came from Ubuntu :-/

that makes things a bit more complicated, because:
* It is clear that upstream wanted GPL-3 for the upstream source
* It is clear that Ubuntu's packager wanted GPL-3+ for the
packaging, even if this motive was inspired by the erroneous
assumption of the GPL-3+ for the upstream source (asking the
packager directly might resolve that)

IOW, my initial advice was wrong. You need to keep GPL-3+ for the
packaging, and add GPL-3 for the upstream source.

Sorry about the mixup!

>>  - There's a formatting issue in the free-standing license text (line
>>27 is not indented)
> 
> I'm not sure what this means. Is it supposed to be indented to the width
> of "X-Comment: "? That's what I did.

Oh, I see what you meant to do now -- it wasn't lacking indentation, it
was beginning a new field.

However, in that case, the field's name is just "Comment" [1], without
the "X-" prefix.

[1] 
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph

Regards,
Christian




signature.asc
Description: OpenPGP digital signature

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-11 Thread James Lu 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
 
Hi everyone,

(Hoping this is the right list for this)

Recently I've been trying to get lightdm-gtk-greeter-settings into
Debian, since it's a nifty utility! Right now, my packaging work has an
RFS (request for sponsorship) bug at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790104. If there's
anyone interested in reviewing, the source is at mentors.d.n
 and Git
at
https://anonscm.debian.org/cgit/collab-maint/lightdm-gtk-greeter-settings.git.

Best,
James
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
 
iQIcBAEBCAAGBQJWGf0rAAoJEC7D9g3nHAudm/0P/iXi6JNQ40EF8N1gq+DfSUOz
Z3CJIoN0yvZ3ajj3sqWDFiwUmfvUoJJDAt6s4gxUw5YlPVY1Nr1/Qp+1RJGzidXG
nlduRVbzKUDj9dmwoK2EL+fehhHvK62SNjeDa1lXNcqJwdMtYUlfFqBFxMBPrVpM
UGY+ZwKPjkrBFfitHeJdRm1Qb1ytfmbhYXq1Hq4kLD7OxUUIOfWCjxRLVj3PLeaY
lex2EmGxH+qor5lvx40EwuP6+qtuXGQ/QQTmcBBy02ScqgIT5F/W+HxQxToOGqK5
PPoR3kCduACfadeNjOrFzJ3HfmUNx5mgd2Qb0BEytEQ398aBlzCWFn5+9GHQtnhw
+cgsmU4I318W6rS0AmkMStAGjI4rkHVTe2M56ZqOiAoHBTMBAwicU1bfP9gFpoLw
NE0HVzNLlnLjW1ktp6VaEVvJLfwHvRxOs1H05AkYCJKvA018BQlkNdAGwYkHSVw3
WZxt7oQfuYYA9H7HqE7D7TgU+4xKqZ9PQIw9CvioQb/gptbKFOqejcb+w8yeof5c
pd+6i8StGybuIvyBt/fEMobBSPEFb2YKnTtB8s1bQ8Wt5pYqqT8K3HrGWNNkc1xs
6Q6rBLdX+KEk1TqRfaU6nOYVxY2jdm9LqUS/ghByRnS6StichxFBt9Y7a2GEqN4R
y7Gyz7s4D2C8TIXZo1DJ
=2Iyo
-END PGP SIGNATURE-

Bug#790104: Fwd: Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-11 Thread James Lu 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
 
(This was supposed to go to the maintainers for lightdm-gtk-greeter in
Debian, not the upstream list; sorry for the noise.)

Hi everyone,

Recently I've been trying to get lightdm-gtk-greeter-settings into
Debian, since it's a nifty utility! Right now, my packaging work has an
RFS (request for sponsorship) bug at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=790104. If there's
anyone interested in reviewing, the source is at mentors.d.n
 and Git
at
https://anonscm.debian.org/cgit/collab-maint/lightdm-gtk-greeter-settings.git.

Best,
James
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
 
iQIcBAEBCAAGBQJWGptZAAoJEC7D9g3nHAudT14P/2zF0ZoiOJQPqCO/o54qrGU6
ph4bQxdbWNtA7uGk3QMad0yNh6TXYapKAodTVaEGDsevDSvqVYsT9FC6bEi0fI5/
EcY89ImAg11/Zx1Mcj0UouF6hbURrDFp5K9xB+31vOET5sZoXJnfQQLaoNLwB804
QCPA6L7fsaYhfnqcf4NVE+PcILbJ1dH1/AtufFccvPii2tIAi/5eFA5/NdhsnZue
04y6G1LBTiPLHk2Eetrm4PWMZo21GbhmxouLPYKEiUL20gTR6lvh/fp8qLbTKuxu
9gIeZ/1qy64+/SHf8Fxf/xtsXXQ3K5ZeTx1V3Aw57SSdE2MnPK3P2lwl0LW8G387
Ywq6d3M8Nj8+GCEvM+aKOXb2is3VU1zT67823cUjtWosaLx19k+q0wEJCoXJFuL6
cbCsgFWUBn5kuvB9xVuJzxroGSX8HJz0BEbt4t9BJKEr7RjA9ZP6T6vfy1E+owo5
NX0bsWcD3EiunPbZumcOGPapym++JdA/1N8ddBva4+yGMqJdx4KXk5d77j425XAC
H0NslF2zU3mVZoWVnavivWZpJsGMg/Yl6NcgDF3OhKyRH3BvLFv/IVAGahrOd5Kz
wZzOol9yW97T5RpkwnjERgF/SqBmnMTdAuCD4PRV42ySxBuCHMJo4Y4BAF5O92bD
tsaGLpVbqTDOxNH0qyvO
=ys49
-END PGP SIGNATURE-

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-11 Thread James Lu 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
 
On 11/10/2015 2:37 AM, Christian Kastner wrote:
> On 2015-10-11 07:54, James Lu wrote:
>>> d/copyright:
>>>  - The license appears to be GPL-3, not GPL-3+ (at least in the handful
>>>of files I checked). This also requires correction of the free-
>>>standing license block (the last paragraph)
>>
>> I see. Ubuntu's packaging wrote the license as GPL-3+ for both the
>> packaging and the source, but I guess the license of the individual
>> files must prevail here. Fixed.
>
> Hm, I just realized that I overlooked something here, namely the license
> of the packaging that came from Ubuntu :-/
>
> that makes things a bit more complicated, because:
> * It is clear that upstream wanted GPL-3 for the upstream source
> * It is clear that Ubuntu's packager wanted GPL-3+ for the
> packaging, even if this motive was inspired by the erroneous
> assumption of the GPL-3+ for the upstream source (asking the
> packager directly might resolve that)
>
> IOW, my initial advice was wrong. You need to keep GPL-3+ for the
> packaging, and add GPL-3 for the upstream source.
>
> Sorry about the mixup!

That's what I did here (forgot to mention it more clearly). The upstream
source (*) is set to GPL-3 and the Ubuntu packaging + my changes (the
debian/ folder) is GPL-3+.

>
>>>  - There's a formatting issue in the free-standing license text (line
>>>27 is not indented)
>>
>> I'm not sure what this means. Is it supposed to be indented to the width
>> of "X-Comment: "? That's what I did.
>
> Oh, I see what you meant to do now -- it wasn't lacking indentation, it
> was beginning a new field.
>
> However, in that case, the field's name is just "Comment" [1], without
> the "X-" prefix.
>
> [1]
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#stand-alone-license-paragraph
>
> Regards,
> Christian
>
Done. I'll fix the other email too.

Best,
James
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
 
iQIcBAEBCAAGBQJWGpomAAoJEC7D9g3nHAudhHgQAKHfBGL6+thgDlU6egJVxFu8
PjGRHafdRRyyupFkxbLlTU3u4BIzPn68Mcl9+dqlUVOMiDI0YCnzBAqnH22mRAt8
VbUxt/SAwzFKb0eZOsIQcYNXkaxhkrXudqs0sPi6+HyJ++oXQLKZBfMpp+l/ndnP
r5einjxeSEKkK2uXwOoh+O4lUgubhS3cUGnIfhufaN1btl5MvBybwgOCM1q5OQ87
fn1DvqvlaAbkjvMkp7BAjDdAwMpASgcHnPW97FomO3JbdCrXzYSk0n85alLtv7xa
mEF6F7woKtwwzmj6FYTXk7F8lqV0ccMktbiTUsb0lzyGRJWeryAH9U2sptLAizm5
G46lNHLFrmnTWZ7cjHuJ/kbFRIKbJhpXSUV+oCivCfVrxnOHY1qnt2Mqb8f339Dc
Z/sXLaWqW1KSxGi3uhtGtL7F5a4xy/ME+6u7EoIAwC/KoBgbRxaNIbb8RCXx7s/S
hdvnnBAhM9hQl6hqeoR28uxy/a0BDDNAA/K+NtrjdJrmHDM/kAIkthqIhgSfUbF3
HeH20EyCEmd8yMKhXL/AllmdkWm8hZFwVUB2FdXvJqYtCsSdGJvCVpqe/6/gtVLb
U54fr8gueBSS5pDCrbIbgYwN8YePENlckxe6PVe0xPCBkWQoSnTNisszf3Zbn1gI
TUKysudqNq8OrP1riYoo
=C+Q6
-END PGP SIGNATURE-

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-10 Thread James Lu 

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
 
Hi Christian,

Thanks for the thorough review!

On Mon, 05 Oct 2015 22:47:21 +0200 Christian Kastner  wrote:
> d/control:
>  - The frontend for git at anonscm.d.o has been changed from gitweb to
>git; please update Vcs-Browser URL accordingly
>  - Developer's Reference §6.2.2 says that the synopsis is not a
>sentence, so you don't need to start it with a capital letter
>  - synopsis / long description: GTK is spelled with all-caps, however

Done.

>  - Depends seems to be missing Pango, going by PKG-INFO

Assuming this means gir1.2-pango-1.0, added.

>
> d/copyright:
>  - The license appears to be GPL-3, not GPL-3+ (at least in the handful
>of files I checked). This also requires correction of the free-
>standing license block (the last paragraph)

I see. Ubuntu's packaging wrote the license as GPL-3+ for both the
packaging and the source, but I guess the license of the individual
files must prevail here. Fixed.

>  - In the header, the field's name is "Source", not "Upstream-Source"

Done.

>  - There's a formatting issue in the free-standing license text (line
>27 is not indented)

I'm not sure what this means. Is it supposed to be indented to the width
of "X-Comment: "? That's what I did.

> d/lightdm-gtk-greeter-settings.lintian-overrides:
>  - Instead of adding lintian override for the missing man page of
>lightdm-gtk-greeter-settings-pkexec, symlinking it to the
>manpage of lightdm-gtk-greeter-settings, as some other packages do
>for -pkexec files (eg: src:mate-system-tools), would be more useful

That's a better idea, done.

> d/rules:
>  - You don't need a get-orig-source target for a mere uscan invocation.
>g-o-s is for cases in which downloading via uscan produces something
>that does _not_ match the orig tarball uploaded to the Debian
>archive: for example, when files have been removed from the original
>source (think: DFSG cleaning), or when you can only recreate the
>tarball by checking out from a repository

Removed, thanks.

>
> I'm happy to sponsor your package, but out of curiosity: have you tried
> pinging the lightdm-gtk-greeter maintainers? They could be interested in
> this package, and are probably in a much better position to assist you
> with issues related to this program than I am.

No, I'll do that now.

Best,
James
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
 
iQIcBAEBCAAGBQJWGfl+AAoJEC7D9g3nHAudff0P/1WYusM98IcyaYtc9KN1wMr0
pcisB0uyqKkFjDG2FJ0DVZb+/vLCBw1QSg49GixIHjoVKSk/hBbB1OaAhfmbxVV3
wKpWYz+2axH7pzkshN2hkXPmUsWYfCLXk1rEYqnI4DmT1ez8tH1ioyM4dGlyUCMo
HFzNUOsKfZ+1xDbsuGJkVe2FmB38+uon4kZey30lyLFVeYI7B72+a12WxV4fb3sI
sMkUPUX+6/FiM33LrDlBbroil9/YAS2EjPHSDOfjhmd9SWL3R1yZ9jbziUAMIJcy
IRDWtx0iX2WQ6z4xj1PRDJFlqHqoUxrGGaqGcgFe/DlioixdKoVLeoCvtUZwIZ4h
cH5CB8h772mJvC/FebajgCAw7fZ1gvyqqgYhUJhipvWji7+nHEqB9cPN6r5LY+lx
t+zPJ/8Dyj1Q71rD3Pz7UGqBWu/NdGvqdoGkyYzCJW9o3yUmZguWcwtlenRaf7x+
gY10LfFaevLGe2bShkgkM3HQKbpkFJyLjrrg1O9bhr84C5YZ93rwZBaI2sFmA2h3
bv8E7L8CAsQuKTZCeibz9njwjZkS3IuA3LHdO3+hxLP30imydBdpcRFmx39kfvvo
fAWOk63LGgMHUmyUwfMURnpN/QrtMxTURrLAX619Xp9KIAftiQ5E01+WaPzitxxk
eqJXyZs4nfUnMvuI2wGE
=BhiE
-END PGP SIGNATURE-

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-10-05 Thread Christian Kastner 
Hi James,

a review of your package follows:

On 2015-06-27 06:59, James Lu wrote:
> I am looking for a sponsor for my package "lightdm-gtk-greeter-settings".
> 
>  * Package name: lightdm-gtk-greeter-settings
>Version : 1.2.0-1
>Upstream Author : Andrew P. 
>  * URL : http://launchpad.net/lightdm-gtk-greeter-settings
>  * License : GPLv3
>Section : utils


> Changes since the last upload:
> 
> lightdm-gtk-greeter-settings (1.2.0-1) unstable; urgency=medium
> 
>   * Initial Debian release, imported from Ubuntu. (Closes: #788614)
>   * debian/ folder changes:
> - Add a watch file pointing to Launchpad.
> - Write a manpage (lightdm-gtk-greeter-settings.1), dropping
>   the binary-without-manpage lintian override
>   for /usr/bin/lightdm-gtk-greeter-settings.
> - Add a get-orig-source target for debian/rules.
> - Set myself as maintainer.
> - Set package source/format to 3.0 quilt.
> - debian/links: symlink the root NEWS file as an upstream changelog.
>   This fixes the no-upstream-changelog Lintian pedantic warning.
> - debian/rules: override dh_auto_clean to remove
>   po/lightdm-gtk-greeter-settings.pot, so that successive builds work.

d/control:
 - The frontend for git at anonscm.d.o has been changed from gitweb to
   git; please update Vcs-Browser URL accordingly
 - Developer's Reference §6.2.2 says that the synopsis is not a
   sentence, so you don't need to start it with a capital letter
 - synopsis / long description: GTK is spelled with all-caps, however
 - Depends seems to be missing Pango, going by PKG-INFO

d/copyright:
 - The license appears to be GPL-3, not GPL-3+ (at least in the handful
   of files I checked). This also requires correction of the free-
   standing license block (the last paragraph)
 - In the header, the field's name is "Source", not "Upstream-Source"
 - There's a formatting issue in the free-standing license text (line
   27 is not indented)

d/lightdm-gtk-greeter-settings.lintian-overrides:
 - Instead of adding lintian override for the missing man page of
   lightdm-gtk-greeter-settings-pkexec, symlinking it to the
   manpage of lightdm-gtk-greeter-settings, as some other packages do
   for -pkexec files (eg: src:mate-system-tools), would be more useful

d/rules:
 - You don't need a get-orig-source target for a mere uscan invocation.
   g-o-s is for cases in which downloading via uscan produces something
   that does _not_ match the orig tarball uploaded to the Debian
   archive: for example, when files have been removed from the original
   source (think: DFSG cleaning), or when you can only recreate the
   tarball by checking out from a repository

I'm happy to sponsor your package, but out of curiosity: have you tried
pinging the lightdm-gtk-greeter maintainers? They could be interested in
this package, and are probably in a much better position to assist you
with issues related to this program than I am.

Regards,
Christian



signature.asc
Description: OpenPGP digital signature

Bug#790104: RFS: lightdm-gtk-greeter-settings/1.2.0-1 [ITP]

2015-06-26 Thread James Lu 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package lightdm-gtk-greeter-settings.

 * Package name: lightdm-gtk-greeter-settings
   Version : 1.2.0-1
   Upstream Author : Andrew P. pan.pav@gmail.com
 * URL : http://launchpad.net/lightdm-gtk-greeter-settings
 * License : GPLv3
   Section : utils

It builds those binary packages:

lightdm-gtk-greeter-settings - Settings editor for LightDM Gtk+ Greeter

To access further information about this package, please visit the following 
URL:

http://mentors.debian.net/package/lightdm-gtk-greeter-settings

Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/l/lightdm-gtk-greeter-settings/lightdm-gtk-greeter-settings_1.2.0-1.dsc

More information about lightdm-gtk-greeter-settings can be obtained from 
http://launchpad.net/lightdm-gtk-greeter-settings.

Changes since the last upload:

lightdm-gtk-greeter-settings (1.2.0-1) unstable; urgency=medium

  * Initial Debian release, imported from Ubuntu. (Closes: #788614)
  * debian/ folder changes:
- Add a watch file pointing to Launchpad.
- Write a manpage (lightdm-gtk-greeter-settings.1), dropping
  the binary-without-manpage lintian override
  for /usr/bin/lightdm-gtk-greeter-settings.
- Add a get-orig-source target for debian/rules.
- Set myself as maintainer.
- Set package source/format to 3.0 quilt.
- debian/links: symlink the root NEWS file as an upstream changelog.
  This fixes the no-upstream-changelog Lintian pedantic warning.
- debian/rules: override dh_auto_clean to remove
  po/lightdm-gtk-greeter-settings.pot, so that successive builds work.

Regards,
James Lu
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJVji2rAAoJEC7D9g3nHAudJNQP/0JxcBJ2ZB2rnGNE/O5RYf/J
VhLVyu2V1RjOrCaMdNntha5dYR/gLM7zocD6w4227GpKQmZzPrrZtPEWvPZgj5Bp
kSLztlsBoSds0t9NE/T2S5ol/3IcTowVSkacWWL0ohV0fFc/YjaSan83tbLwX9My
E4o+6Qp57S1qCsA5NJ5Knaem3NWM3iZHeIvFFTTsnv//uAo4Mc27FgXtv+ePuj4u
cKTEqJi4neikKoyvHGFuYAZYQaQFeMqAdOhm1mxO8dhr6jwf9Be7n9BIvx2q4261
vSfbaUyg+CJDyPRluMakUHOekMik1d2JGTMMzcOdEmtBLa0uWxx2kgbDso498UZ3
DcKYIQ3JohYj92A7XicrNTkRt+agnjDYJMW/7UdbfrBXWRFVqUVZfUXPhri+wn6u
61MPwfXjBFBUDKm14I66+nJKa2wTPqMRT03y+TVTe4V3cV/FGGNMMLFARykyapbT
AmUIn9gTGNfOvYFu+PzWndoj3ljbxeCZlFT6IhXvYEwEEy2uaYnCcorR9Wh6i8e+
VIn0rO4ZVcyX9++Rex6BqIIPOdvYhNSRKsGwY14pziTz6HLBQwzb7EZs0KbWKYRS
PUmKUtuDMadGIui2CFMvTTXRv2INKP+9YMMwJqfPPaecmW5Iv/LCzUmO1lBTz07M
L+d+6DpQffdxA9KUY+cI
=V+aq
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org