Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Andrius Merkys 
On 04/23/2018 06:43 PM, Lumin wrote:
> Oh, I forgot to tell you that the failure is due to output to stderr.
> By redirecting
> the stderr to e.g. stdout, this failure can be fixed.

Thanks for pointing this out :) I had similar idea, but it would have taken me 
much longer to solve it.

> Please let me know if you think the package is ready. Then I'll check
> it again :-)

I suppose it's ready now. By the way, the package is already in NEW queue -- 
should I close this bug? Or is it possible to update a package already in the 
NEW?

Many thanks for help!
Andrius

-- 
Andrius Merkys
Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325
LT-10257 Vilnius, Lithuania

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Lumin 
On 23 April 2018 at 14:11, Andrius Merkys  wrote:
>> 6. tests: your autopkgtest testsuite failed:
>
> I will look into this. It is possible that I invoke the Python tests 
> incorrectly.

Oh, I forgot to tell you that the failure is due to output to stderr.
By redirecting
the stderr to e.g. stdout, this failure can be fixed.

Please let me know if you think the package is ready. Then I'll check
it again :-)

-- 
Best,

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Andrius Merkys 
Dear Lumin,

many thanks for reviewing the package! Please find my comments in-line.

On 04/23/2018 10:35 AM, Lumin wrote:
> 1. There seems to be ruby binding available, why isn't it packaged?

I have too little experience with Ruby. However, I will look at how to package 
it.

> 2. control: Your -dev package should also depend on the lib package.
> Depends: ${misc:Depends}, libsymspg1 (= ${binary:Version})

Fixed.

> The python package should depend on it too.

Is it really so? As I understand, all objects are linked in Python SO file and 
it alone is sufficient to use the Python binding. At least all Python tests 
pass having python3-spglib installed only.

> 3. libsymspg1.install :

Done.

>Apart from that, this looks a bit weird:
>DEBIAN/symbols DEBIAN

Fixed.

> 4. the install file of -dev package could be simplified

Done.

> 5.  I'd suggest you install the library in the multiarch directory.
> for example /usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)

Done.

> 6. tests: your autopkgtest testsuite failed:

I will look into this. It is possible that I invoke the Python tests 
incorrectly.

Thanks again!
Andrius

-- 
Andrius Merkys
Vilnius University Institute of Biotechnology, Saulėtekio al. 7, room V325
LT-10257 Vilnius, Lithuania

Bug#883840: RFS: spglib/1.10.3-1 [ITP]

2018-04-23 Thread Lumin 
control: owner -1 !
control: tag -1 +moreinfo

Hi Andrius,

Thank you for the package. Here are some nitpicking about your package:

1. There seems to be ruby binding available, why isn't it packaged?

2. control: Your -dev package should also depend on the lib package.
Depends: ${misc:Depends}, libsymspg1 (= ${binary:Version})

The python package should depend on it too.

3. libsymspg1.install :

   usr/lib/libsymspg.so.1.10.3 usr/lib
   usr/lib/libsymspg.so.1 usr/lib

   wildcard is allowed in install files. The above two lines can be
reduced to one

   usr/lib/libsymspg.so.*usr/lib

   Apart from that, this looks a bit weird:
   DEBIAN/symbols DEBIAN

   You can first create an empty file debian/libsymspg1.symbols, then
   build the package. You will get a patch for updating this symbols file.
   After applying the patch, don't forget to remove the debian revision
   in the version number :-)

4. the install file of -dev package could be simplified

usr/include usr
usr/lib/libsymspg.a usr/lib

can be simplified to

usr/include
usr/lib/libsymspg.a

debhelper would assume your destination installation path is
the same as the source path, when destination is omitted.

5.  I'd suggest you install the library in the multiarch directory.
for example /usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)

There are many ways to install the libxxx.so.* in the multiarch directory.
One of them, for example, is to write a install file like this:

usr/lib/libfoobar.so.1 usr/lib/##DEB_HOST_MULTIARCH##/

and we need to replace that placeholder in rules, for exmple

override_dh_auto_configure:
dh_auto_configure
sed -i -e "s@##DEB_HOST_MULTIARCH##@$(DEB_HOST_MULTIARCH)@g" libfoo1.install

6. tests: your autopkgtest testsuite failed:

http://debomatic-amd64.debian.net/distribution#unstable/spglib/1.10.3-1/autopkgtest

Please let me know if you have any question on these points :-)
You don't have to frequently dput to mentors, because I'll directly check
the packaging repo  https://salsa.debian.org/science-team/spglib

Have a good day!

-- 
Best,