Bug#574689: lintian: Check installed /bin files and report debian/control::Architecture problems
Package: lintian Version: 2.3.3 Severity: wishlist USE CASE A package, that consists of pure perl (or python) program is installed in usr/bin (or any *bin* directory in general). The debian/control::Architecture field is set to 'any' SUGGESTION Please check if all installed programs under */*bin/* are platform independent and compare the result against debian/control::Architecture value. Suggest 'all' (informational, pedantic, warning?) in case of they are all scripts and Architecture is not set correctly. First line starts with shebang !# -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-2 The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.5.6 Debian package development tools ii file 5.04-1Determines file type using magic ii gettext0.17-10 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.84-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.52-1module to manipulate and access UR ii locales2.10.2-6 Embedded GNU C Library: National L ii man-db 2.5.7-2 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-11 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.7-2on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100320084549.16849.51176.report...@jondo.cante.net
Re: re: cl ad
Hey, just got your email back regarding my ad, i got a heck of a lot of emails from that lol... what plans do you have tonight, interested in getting together? -Jenni
Processed: severity of 573914 is important
Processing commands for cont...@bugs.debian.org: # hinders klibc dev severity 573914 important Bug #573914 [lintian] lintian: refine embedded-zlib for libc's other then glibc Severity set to 'important' from 'normal' thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126910210627111.transcr...@bugs.debian.org
Bug#574744: [checks/rules] warn about missing versioned dependency when using scons.mk
Package: lintian Version: 2.3.3 Severity: wishlist I'm not sure we should warn about packages using their local scons.mk (they differ, maybe?) but at least it should be added to the list of stuff that requires a versioned build dependency. --- Forwarded message (begin) Subject: scons.mk is in latest cdbs package From: Jérémy Lal je...@edagames.com Date: Sat, 20 Mar 2010 12:26:48 +0100 Newsgroup: gmane.linux.debian.devel.general Hi, i just realized latest cdbs now contains the scons.mk file, and i wonder if there should be some notice sent to all package maintainers who use a custom debian/cdbs/scons.mk file, to make them use the one provided by cdbs now ? Regards, Jérémy Lal --- Forwarded message (end) Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4ba50e97.100bca0a.36f2.6...@mx.google.com
Dropping 'Testname'?
Hi, It's been a while since I wanted to bring this up. Is there any objection to dropping the 'Testname' field from the t/tests/*/desc files? IIRC the value of Testname _must_ match the name of the directory containing the desc file, otherwise runtests fails. Given this requirement, I would prefer to avoid duplicating the name (which in the past has caused me troubles when adding new tests) by making runtests guess it from the name of the directory. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/ho37d1$pu...@dough.gmane.org
Re: Dropping 'Testname'?
Raphael Geissert geiss...@debian.org writes: It's been a while since I wanted to bring this up. Is there any objection to dropping the 'Testname' field from the t/tests/*/desc files? IIRC the value of Testname _must_ match the name of the directory containing the desc file, otherwise runtests fails. Given this requirement, I would prefer to avoid duplicating the name (which in the past has caused me troubles when adding new tests) by making runtests guess it from the name of the directory. I'm okay with making it an optional field. I think it should be possible to specify it if, for some reason, we want to have the test create a source package with a package name that doesn't match the directory (maybe because it contains special characters or is 256 characters long or something). -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87pr2yaitf@windlord.stanford.edu
[SCM] Debian package checker branch, master, updated. 2.3.3-12-g44e66db
The following commit has been merged in the master branch:
commit 363388f3a64b17916ad8abda596c3c44e6cebcd9
Author: Raphael Geissert atom...@gmail.com
Date: Sat Mar 20 13:37:46 2010 -0600
Add a test for timewarp-standards-version
diff --git a/t/tests/nmu-local-version/debian/debian/changelog.in
b/t/tests/standards-version-timewarp/debian/debian/changelog.in
similarity index 77%
copy from t/tests/nmu-local-version/debian/debian/changelog.in
copy to t/tests/standards-version-timewarp/debian/debian/changelog.in
index d48bf4d..6fc94c5 100644
--- a/t/tests/nmu-local-version/debian/debian/changelog.in
+++ b/t/tests/standards-version-timewarp/debian/debian/changelog.in
@@ -5,4 +5,4 @@
* Suppress should close ITP bug messages. (Closes: #123456)
- -- Russ Allbery r...@debian.org {$date}
+ -- {$author} Fri, 15 Mar 2001 07:00:00 +
diff --git a/t/tests/standards-version-timewarp/desc
b/t/tests/standards-version-timewarp/desc
new file mode 100644
index 000..24151af
--- /dev/null
+++ b/t/tests/standards-version-timewarp/desc
@@ -0,0 +1,5 @@
+Testname: standards-version-timewarp
+Sequence: 6000
+Version: 1.0
+Description: Test newer standards version with old changelog date
+Test-For: timewarp-standards-version
diff --git a/t/tests/standards-version-timewarp/post_test
b/t/tests/standards-version-timewarp/post_test
new file mode 100644
index 000..9f30cfc
--- /dev/null
+++ b/t/tests/standards-version-timewarp/post_test
@@ -0,0 +1 @@
+s/ [0-9]{4}-[0-9]{2}-[0-9]{2}/ CURRENT/
diff --git a/t/tests/standards-version-timewarp/tags
b/t/tests/standards-version-timewarp/tags
new file mode 100644
index 000..a9d2393
--- /dev/null
+++ b/t/tests/standards-version-timewarp/tags
@@ -0,0 +1 @@
+W: standards-version-timewarp source: timewarp-standards-version (2001-03-15
CURRENT)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt5hu-0003xc...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-12-g44e66db
The following commit has been merged in the master branch:
commit 44e66dbe478349ba406aa3d8f0c2f8c3e7492ec1
Author: Raphael Geissert atom...@gmail.com
Date: Sat Mar 20 14:27:46 2010 -0600
Don't warn about timewarp-s-v but an UNRELEASED changelog
* checks/standards-version:
+ [RG] Don't warn about timewarp-standards-version when the
changelog's distribution is UNRELEASED. Thanks, Raphaël Hertzog.
(Closes: #571616)
diff --git a/checks/standards-version b/checks/standards-version
index 96c46fe..039549a 100644
--- a/checks/standards-version
+++ b/checks/standards-version
@@ -77,17 +77,20 @@ my ($major, $minor, $patch) = $stdver =~
m/^(\d+)\.(\d+)\.(\d+)/;
# file. If we can't find the changelog file, assume that the package was
# released today, since that activates the most tags.
my $changes = $info-changelog;
-my $pkgdate;
+my ($pkgdate, $dist);
if (defined $changes) {
my ($entry) = $changes-data;
$pkgdate = ($entry $entry-Timestamp) ? $entry-Timestamp : time;
+$dist = ($entry $entry-Distribution)? $entry-Distribution : '';
} else {
$pkgdate = time;
}
# Check for packages dated prior to the date of release of the standards
# version with which they claim to comply.
-if ($STANDARDS-known($stdver) $STANDARDS-value($stdver) $pkgdate) {
+if ($dist ne 'UNRELEASED' $STANDARDS-known($stdver)
+ $STANDARDS-value($stdver) $pkgdate) {
+
my $package = strftime('%Y-%m-%d', gmtime $pkgdate);
my $release = strftime('%Y-%m-%d', gmtime $STANDARDS-value($stdver));
tag 'timewarp-standards-version', ($package $release);
diff --git a/debian/changelog b/debian/changelog
index 7e91345..59179f6 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ lintian (2.3.4) UNRELEASED; urgency=low
+ [ADB] Update the list of octave interpreters, adding octave3.2
(Closes: #574048) and removing octave2.1 (only available in lenny
and earlier) and octave3.1.
+ * checks/standards-version:
++ [RG] Don't warn about timewarp-standards-version when the
+ changelog's distribution is UNRELEASED. Thanks, Raphaël Hertzog.
+ (Closes: #571616)
* debian/control:
+ [RG] Update package description to mention Policy version 3.8.4
diff --git a/t/tests/standards-version-timewarp/debian/debian/changelog.in
b/t/tests/standards-version-timewarp-unreleased/debian/debian/changelog.in
similarity index 77%
copy from t/tests/standards-version-timewarp/debian/debian/changelog.in
copy to t/tests/standards-version-timewarp-unreleased/debian/debian/changelog.in
index 6fc94c5..57fa089 100644
--- a/t/tests/standards-version-timewarp/debian/debian/changelog.in
+++ b/t/tests/standards-version-timewarp-unreleased/debian/debian/changelog.in
@@ -1,4 +1,4 @@
-{$srcpkg} ({$version}) unstable; urgency=low
+{$srcpkg} ({$version}) UNRELEASED; urgency=low
* Lintian Test Suite.
* Test: {$testname}
diff --git a/t/tests/standards-version-timewarp-unreleased/desc
b/t/tests/standards-version-timewarp-unreleased/desc
new file mode 100644
index 000..d939cfc
--- /dev/null
+++ b/t/tests/standards-version-timewarp-unreleased/desc
@@ -0,0 +1,5 @@
+Testname: standards-version-timewarp-unreleased
+Sequence: 6000
+Version: 1.0
+Description: Test newer standards version with unreleased old changelog date
+Test-Against: timewarp-standards-version
diff --git a/t/debs/deb-format-record-size/tags
b/t/tests/standards-version-timewarp-unreleased/tags
similarity index 100%
copy from t/debs/deb-format-record-size/tags
copy to t/tests/standards-version-timewarp-unreleased/tags
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt5i5-0003ye...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-16-g893e141
The following commit has been merged in the master branch: commit 55125a397b04173deea1872dcb5d537d907d7fba Author: Niko Tyni nt...@debian.org Date: Sat Feb 6 22:43:15 2010 +0200 Fix binaries-multiarch test failure on !i386 The binaries-multiarch test output depends on the host architecture: on i386 it will warn about installing to an amd64 path, while on others the warning is about an i386 path. Post process the output accordingly. diff --git a/t/tests/binaries-multiarch/post_test b/t/tests/binaries-multiarch/post_test new file mode 100644 index 000..bef12aa --- /dev/null +++ b/t/tests/binaries-multiarch/post_test @@ -0,0 +1,2 @@ +s/i486-linux-gnu/x86_64-linux-gnu/ +s/is for i386/is for amd64/ -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt5i6-0006yf...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-16-g893e141
The following commit has been merged in the master branch: commit 33b700534a2f0389158fdbd6055a9796798b781a Author: Raphael Geissert atom...@gmail.com Date: Sat Mar 20 14:36:44 2010 -0600 Add changelog for test failure fix, to close the bug with the upload * t/tests/binaries-multiarch/: + [RG] Fix test failure in non-i386 architectures by normalising the expected output. Thanks, Niko Tyni. (Closes: #568680) diff --git a/debian/changelog b/debian/changelog index 59179f6..4ed2bb7 100755 --- a/debian/changelog +++ b/debian/changelog @@ -28,6 +28,10 @@ lintian (2.3.4) UNRELEASED; urgency=low + [ADB] Replace the please mail comments to the maintainer request with a pointer to reportbug. + * t/tests/binaries-multiarch/: ++ [RG] Fix test failure in non-i386 architectures by normalising the + expected output. Thanks, Niko Tyni. (Closes: #568680) + -- Raphael Geissert geiss...@debian.org Mon, 01 Feb 2010 14:28:54 -0600 lintian (2.3.3) unstable; urgency=low -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt5i7-0006z7...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-16-g893e141
The following commit has been merged in the master branch:
commit 3296f6d116a7c27999f8c4c473dadf64aed6aee9
Author: Cyril Brulebois k...@debian.org
Date: Tue Mar 9 16:17:43 2010 +0100
Fix package-depends-on-hardcoded-libc check.
The glibc source package was renamed into eglibc.
diff --git a/checks/control-file b/checks/control-file
index 66b34a7..f893b48 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -175,7 +175,7 @@ for my $control (@binary_controls) {
tag package-depends-on-itself, $control-{package},
$dep_fields[$strong]
if $relation-implies($control-{package});
tag 'package-depends-on-hardcoded-libc', $control-{package},
$dep_fields[$strong]
- if ($relation-implies($libcs) and $pkg ne glibc);
+ if ($relation-implies($libcs) and $pkg ne eglibc);
for my $weak (($strong + 1) .. $#dep_fields) {
next unless $control-{$dep_fields[$weak]};
for my $dependency (split /\s*,\s*/,
$control-{$dep_fields[$weak]}) {
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt5i9-0006zp...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-16-g893e141
The following commit has been merged in the master branch:
commit 893e141ef62926b165e13b0c8ddf744cdcaa3052
Author: Raphael Geissert atom...@gmail.com
Date: Sat Mar 20 14:54:05 2010 -0600
Add changelog entry for eglibc exception and tweak the change
* checks/control-file:
+ [RG] Update package-depends-on-hardcoded-libc exception to also
exclude eglibc. Based on a patch from Cyril Brulebois.
(Closes: #573398)
diff --git a/checks/control-file b/checks/control-file
index f893b48..78cac18 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -175,7 +175,7 @@ for my $control (@binary_controls) {
tag package-depends-on-itself, $control-{package},
$dep_fields[$strong]
if $relation-implies($control-{package});
tag 'package-depends-on-hardcoded-libc', $control-{package},
$dep_fields[$strong]
- if ($relation-implies($libcs) and $pkg ne eglibc);
+ if ($relation-implies($libcs) and $pkg !~ /^e?glibc$/);
for my $weak (($strong + 1) .. $#dep_fields) {
next unless $control-{$dep_fields[$weak]};
for my $dependency (split /\s*,\s*/,
$control-{$dep_fields[$weak]}) {
diff --git a/debian/changelog b/debian/changelog
index 4ed2bb7..1df3bba 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
lintian (2.3.4) UNRELEASED; urgency=low
+ * checks/control-file:
++ [RG] Update package-depends-on-hardcoded-libc exception to also
+ exclude eglibc. Based on a patch from Cyril Brulebois.
+ (Closes: #573398)
* checks/scripts:
+ [ADB] Update the list of octave interpreters, adding octave3.2
(Closes: #574048) and removing octave2.1 (only available in lenny
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt5ia-00070a...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-17-gac4f93d
The following commit has been merged in the master branch: commit ac4f93d4ccfcc3f7427be574cc67874cb3941507 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 13:58:04 2010 -0700 Allow ant1.7 to satisfy an ant build dependency * checks/rules: + [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks, Rene Engelhard. (Closes: #572430) diff --git a/checks/rules b/checks/rules index 230d52e..bc4e62c 100644 --- a/checks/rules +++ b/checks/rules @@ -33,7 +33,7 @@ our $PYTHON_DEPEND = 'python | python-dev | python-all | python-all-dev | ' # than the default is required. our @GLOBAL_CLEAN_DEPENDS = ( - [ ant = qr'^include\s*/usr/share/cdbs/1/rules/ant\.mk' ], + [ 'ant | ant1.7' = qr'^include\s*/usr/share/cdbs/1/rules/ant\.mk' ], [ cdbs = qr'^include\s+/usr/share/cdbs/' ], [ cdbs = qr'^include\s+/usr/share/R/debian/r-cran\.mk' ], [ dbs = qr'^include\s+/usr/share/dbs/' ], @@ -68,7 +68,7 @@ my @GLOBAL_DEPENDS = # depend on, this package is allowed (and required) in Build-Depends. my @RULE_CLEAN_DEPENDS = ( - [ ant = qr'^\t\s*(\S+=\S+\s+)*ant\s' ], + [ 'ant | ant1.7' = qr'^\t\s*(\S+=\S+\s+)*ant\s' ], [ debhelper = qr'^\t\s*dh_.+' ], [ dpatch = qr'^\t\s*(\S+=\S+\s+)*dpatch\s' ], [ po-debconf = qr'^\t\s*debconf-updatepo\s' ], diff --git a/debian/changelog b/debian/changelog index 1df3bba..112d9db 100755 --- a/debian/changelog +++ b/debian/changelog @@ -4,6 +4,9 @@ lintian (2.3.4) UNRELEASED; urgency=low + [RG] Update package-depends-on-hardcoded-libc exception to also exclude eglibc. Based on a patch from Cyril Brulebois. (Closes: #573398) + * checks/rules: ++ [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks, + Rene Engelhard. (Closes: #572430) * checks/scripts: + [ADB] Update the list of octave interpreters, adding octave3.2 (Closes: #574048) and removing octave2.1 (only available in lenny -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt5lq-0007da...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-18-g5c1eb0d
The following commit has been merged in the master branch:
commit 5c1eb0d55dc1ad9446dc8b080b934dbbaaec6042
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 14:06:36 2010 -0700
Exclude klibc from the embedded-zlib check
* checks/binaries:
+ [RA] Exclude packages from the klibc source package from the
embedded zlib check since klibc legitimately includes its own copy.
Thanks, maximilian attems. (Closes: #573914)
diff --git a/checks/binaries b/checks/binaries
index 9deda78..7d25d40 100644
--- a/checks/binaries
+++ b/checks/binaries
@@ -273,7 +273,7 @@ foreach my $file (sort keys %{$info-file_info}) {
}
}
-if ($info-field('source') ne 'zlib'
+if ($info-field('source') ne 'zlib' and $info-field('source') ne 'klibc'
and $strings =~ /(?:in|de)flate (?:\d[ \w.\-]{1,20}[\w.\-])/m) {
tag embedded-zlib, $file;
}
diff --git a/debian/changelog b/debian/changelog
index 112d9db..8092f06 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,5 +1,9 @@
lintian (2.3.4) UNRELEASED; urgency=low
+ * checks/binaries:
++ [RA] Exclude packages from the klibc source package from the
+ embedded zlib check since klibc legitimately includes its own copy.
+ Thanks, maximilian attems. (Closes: #573914)
* checks/control-file:
+ [RG] Update package-depends-on-hardcoded-libc exception to also
exclude eglibc. Based on a patch from Cyril Brulebois.
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt5ss-0001ey...@alioth.debian.org
Re: Another lintian release for squeeze?
Raphael Geissert wrote:
I've been working on Lintian::Command::Simple but got
stuck with the interface. I should probably push it somewhere and ask for
comments.
I've also done some work on making t/runtests run multiple jobs in
parallel (using perl threads, actually). There's just one minor glitch I
should be able to fix within a few minutes.
The only downside is that the output is not clean, but unless I buffer it
(which won't make it really show in what order stuff is being done)
there's no other way around.
I'm attaching both changes. Comments? suggestions?
0007 includes the first set of changes of Lintian::Command::Simple. In the
.t file I was trying to decide the best way to handle multiple jobs while
still being able to recognise which one is reaped.
Cheers,
--
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
From 93630fcb67991bb2c68dc45706b080043298f680 Mon Sep 17 00:00:00 2001
From: Raphael Geissert atom...@gmail.com
Date: Sat, 20 Mar 2010 00:14:03 -0600
Subject: [PATCH] Run multiple tests from the testsuite in parallel
Experimental implementation using Perl threads.
Output is messy and the benefit is not _that_ great. Most of the tools
(debhelper, dpkg-*, etc) turn the speed completely CPU-bound.
---
t/runtests | 204 ++--
1 files changed, 156 insertions(+), 48 deletions(-)
diff --git a/t/runtests b/t/runtests
index 9f198e9..d29ae62 100755
--- a/t/runtests
+++ b/t/runtests
@@ -32,6 +32,8 @@ use warnings;
use Data::Dumper;
use Getopt::Long qw(GetOptions);
use Text::Template;
+use threads 'exit' = 'threads_only';
+use threads::shared;
BEGIN {
my $LINTIAN_ROOT = $ENV{'LINTIAN_ROOT'};
@@ -68,13 +70,16 @@ our $STANDARDS_VERSION = '3.8.4';
sub usage {
print unquote(END);
-: Usage: $0 [-dkv] testset-directory testing-directory [test]
-: $0 [-dkv] [-t tag] testset-directory testing-directory
+: Usage: $0 [-dkv] [-j [jobs]] testset-directory testing-directory [test]
+: $0 [-dkv] [-j [jobs]] [-t tag] testset-directory testing-directory
:
-: -dDisplay additional debugging information
-: -kDo not stop after one failed test
-: -t tag Run only tests for or against tag
-: -vBe more verbose
+: -d Display additional debugging information
+: -j [jobs] Run up to jobs jobs in parallel. Defaults to two.
+: If -j is passed without specifying jobs, the number
+: of jobs started is cpu cores+1 if /proc/cpuinfo is readable.
+: -k Do not stop after one failed test
+: -t tagRun only tests for or against tag
+: -v Be more verbose
:
: The optional 3rd parameter causes runtests to only run that particular
: test.
@@ -88,10 +93,12 @@ our $DEBUG = 0;
our $VERBOSE = 0;
our $RUNDIR;
our $TESTSET;
+our $JOBS = -1;
my ($run_all_tests, $tag);
Getopt::Long::Configure('bundling');
GetOptions('d|debug' = \$DEBUG,
+ 'j|jobs:i' = \$JOBS,
'k|keep-going' = \$run_all_tests,
't|tag=s' = \$tag,
'v|verbose'= \$VERBOSE) or usage;
@@ -110,6 +117,31 @@ unless (-d $TESTSET) {
fail(test set directory $TESTSET does not exist);
}
+# Getopt::Long assigns 0 as default value if none was specified
+if ($JOBS eq 0 -r '/proc/cpuinfo') {
+open(CPU, '', '/proc/cpuinfo')
+ or fail(failed to open /proc/cpuinfo: $!);
+while (CPU) {
+ next unless m/^cpu cores\s*:\s*(\d+)/;
+ $JOBS += $1;
+}
+close(CPU);
+
+print Apparent number of cores: $JOBS\n if $DEBUG;
+
+# Running up to twice the number of cores usually gets the most out
+# of the CPUs and disks but it might be too aggresive to be the
+# default for -j. Only use cores+1 then.
+$JOBS++;
+}
+
+# No decent number of jobs? set a default
+# Above $JOBS should be set to -1 so that this condition is always met,
+# therefore avoiding duplication.
+if ($JOBS le 0) {
+$JOBS = 2;
+}
+
# --- Display output immediately
$| = 1;
@@ -124,9 +156,16 @@ my $status = 0;
# If we don't run any tests, we'll want to warn that we couldn't find
# anything.
-my $tests_run = 0;
+my $tests_run :shared = 0;
+
+# $JOBS is the limit, $jobs is how many there are left to be started
+my $jobs = $JOBS;
+
+# a stack with the created threads
+my @threads;
+
+my @tests :shared;
-my @tests;
my $prev;
# --- Run all test scripts
@@ -145,7 +184,7 @@ if ($singletest) {
if (@tests) {
print Test scripts:\n;
-if (system('prove', '-r', '-I', $LINTIAN_ROOT/lib, @tests) != 0) {
+if (system('prove', '-j', $JOBS, '-r', '-I', $LINTIAN_ROOT/lib, @tests) != 0) {
exit 1 unless $run_all_tests;
$status = 1;
}
@@ -178,14 +217,29 @@ if ($singletest) {
}
print Found the following changes tests: @tests\n if $DEBUG;
print Changes tests:\n if @tests;
-for (@tests) {
-my $okay = test_changes($_);
-
Processed: limit source to lintian, tagging 568680, tagging 573398, tagging 572430, tagging 571616
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/control-file: #+ [RG] Update package-depends-on-hardcoded-libc exception to also # exclude eglibc. Based on a patch from Cyril Brulebois. # (Closes: #573398) # * checks/rules: #+ [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks, # Rene Engelhard. (Closes: #572430) # * checks/standards-version: #+ [RG] Don't warn about timewarp-standards-version when the # changelog's distribution is UNRELEASED. Thanks, Raphaël Hertzog. # (Closes: #571616) # * t/tests/binaries-multiarch/: #+ [RG] Fix test failure in non-i386 architectures by normalising the # expected output. Thanks, Niko Tyni. (Closes: #568680) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 568680 + pending Bug #568680 [lintian] lintian: binaries-multiarch test fails on amd64 Added tag(s) pending. tags 573398 + pending Bug #573398 [lintian] lintian: Outdated package-depends-on-hardcoded-libc check Added tag(s) pending. tags 572430 + pending Bug #572430 [lintian] too picky build-dependency-missing check Added tag(s) pending. tags 571616 + pending Bug #571616 [lintian] lintian: Don't report timewarp-standards-version when UNRELEASED Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126911877631034.transcr...@bugs.debian.org
Bug#573398: lintian: Outdated package-depends-on-hardcoded-libc check
Salut Cyril, Cyril Brulebois wrote: for the package-depends-on-hardcoded-libc tag, a check is performed on 'glibc', which is 'eglibc' now, resulting in false positives. The attached patch should fix this, although I didn't actually check eglibc's binaries afterwards. Thanks for the report and patch. I'm fixing it in a slightly different way by still excluding glibc. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4ba53582.0f0bca0a.266b.6...@mx.google.com
[SCM] Debian package checker branch, master, updated. 2.3.3-19-g45bc336
The following commit has been merged in the master branch:
commit 45bc3366a3fafdf00f21973918c1fe1ffdca18e6
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 14:25:28 2010 -0700
Globally ignore SIGPIPE
* frontend/lintian:
+ [RA] Globally ignore SIGPIPE, forcing error return codes from write.
Hopefully will resolve some unreproducible occasional crashes.
(Closes: #558360)
diff --git a/debian/changelog b/debian/changelog
index 8092f06..673df5c 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -24,6 +24,11 @@ lintian (2.3.4) UNRELEASED; urgency=low
+ [RG] Update package description to mention Policy version 3.8.4
instead of 3.8.3. Should have been done on the previous release.
+ * frontend/lintian:
++ [RA] Globally ignore SIGPIPE, forcing error return codes from write.
+ Hopefully will resolve some unreproducible occasional crashes.
+ (Closes: #558360)
+
* lib/Lintian/Tag/Info.pm:
+ [JP] Don't link to references with no URL. (Closes: #572297)
* lib/Spelling.pm:
diff --git a/frontend/lintian b/frontend/lintian
index 4144455..e0e8bdb 100755
--- a/frontend/lintian
+++ b/frontend/lintian
@@ -108,6 +108,10 @@ our $LINTIAN_AREA = undef;
#turn off file buffering
$| = 1;
+# Globally ignore SIGPIPE. We'd rather deal with error returns from write
+# than randomly delivered signals.
+$SIG{PIPE} = 'IGNORE';
+
# reset locale definition (necessary for tar)
$ENV{'LC_ALL'} = 'C';
# reset timezone definition (also for tar)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt6b4-0001hw...@alioth.debian.org
Processed: limit source to lintian, tagging 573914
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/binaries: #+ [RA] Exclude packages from the klibc source package from the # embedded zlib check since klibc legitimately includes its own copy. # Thanks, maximilian attems. (Closes: #573914) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 573914 + pending Bug #573914 [lintian] lintian: refine embedded-zlib for libc's other then glibc Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12691192362904.transcr...@bugs.debian.org
Re: Another lintian release for squeeze?
Raphael Geissert geiss...@debian.org writes: I'm attaching both changes. Comments? suggestions? 0007 includes the first set of changes of Lintian::Command::Simple. In the .t file I was trying to decide the best way to handle multiple jobs while still being able to recognise which one is reaped. Is there any way that we can fix the output handling so that at least it won't intersperse output from multiple threads? Making failures basically unreadable is unappealing, and I assume that's the possible result. Can we use some sort of locking method so that only one thread is printing stuff to the terminal at a time and finishes dumping its stuff, including its possible diff, before letting someone else go? In parallel mode, we should stop printing partial status (building, testing, OK) etc. and just print out the complete line to the point that we got and then the failure results if any all at once. That will work better with the output handling. Lintian::Command::Simple looks like a good idea to me, but please don't call the system() function exec(). I will keep expecting it to be, well, exec. :) -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/8739zur7te@windlord.stanford.edu
Bug#572430: [SCM] Debian package checker branch, master, updated. 2.3.3-17-gac4f93d
Russ Allbery wrote: The following commit has been merged in the master branch: commit ac4f93d4ccfcc3f7427be574cc67874cb3941507 Author: Russ Allbery rra-8fiuurrzop0dnm+yrof...@public.gmane.org Date: Sat Mar 20 13:58:04 2010 -0700 Allow ant1.7 to satisfy an ant build dependency * checks/rules: + [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks, Rene Engelhard. (Closes: #572430) I was working on that very same bug and had the very same patch. What stopped me from committing was that there _is_ a build-dependency on ant (ORed, yes). So it looks like there's another bug that needs to be fixed. Since you are more familiar with the Lintian::Relation module, could you please check that? thanks! Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/4ba53d2a.0d0bca0a.03c1.7...@mx.google.com
Processed: limit source to lintian, tagging 558360
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * frontend/lintian: #+ [RA] Globally ignore SIGPIPE, forcing error return codes from write. # Hopefully will resolve some unreproducible occasional crashes. # (Closes: #558360) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 558360 + pending Bug #558360 [lintian] lintian fails silently with error code 141 Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912036413350.transcr...@bugs.debian.org
Bug#558360: Debian Bug report logs - #558360
devn...@lordb.de devn...@lordb.de writes: Sorry for the delay. Today I had some time to try your approach. I've attached the log to this email (I hope this works). I've no real clue on how to read this file but I think the two last lines describe the problem: read(5, Package: ghostscript\nVersion: 1:..., 4096) = 791 --- SIGPIPE (Broken pipe) @ 0 (0) --- I'm afraid your problem continues to make absolutely no sense to me (and I've never been able to duplicate it). The trace that you included seems to indicate that Lintian is dying with a SIGPIPE, which is a signal delivered when a process tries to write to a pipe that's been closed on the other end. However, you didn't use strace -f, just a regular strace, so you're only seeing the parent process. The SIGPIPE appears to have happened during get_deb_info() on the *.deb file that you're checking. In that situation, I don't see where the parent Lintian process would ever be writing to a pipe, nor does your strace show any sign of a write. For the next release, I will have Lintian globally ignore SIGPIPE, which is generally the correct programming method anyway since it's easier to deal with write failures than signals. Maybe this will somehow solve your problem, but I don't understand how these circumstances could exist. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/877hp6r8ne@windlord.stanford.edu
Bug#574771: lintian: [new check] Warning about files/symlinks called * or *.$ext
Package: lintian Version: 2.3.3 Severity: wishlist Hi A restructure of a debian/rules file lead to one of my packages containing symlinks called usr/share/java/* and usr/share/java/*.jar pointing to ../../lib/eclipse/plugins/* and ../../lib/eclipse/plugins/*.jar respectively. I think it is fairly safe to assume that this is an issue if there are no overrides. ~Niels -- System Information: Debian Release: squeeze/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-2 The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.5.6 Debian package development tools ii file 5.04-1Determines file type using magic ii gettext0.17-10 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.84-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.52-1module to manipulate and access UR ii locales2.10.2-6 Embedded GNU C Library: National L ii man-db 2.5.7-2 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-11 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) ii libtext-template-perl 1.45-1 Text::Template perl module ii man-db2.5.7-2on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20100320212437.30905.398.report...@getsu.thykier.net
Bug#569492: lintian: Avoid checking upstart jobs linked from /etc/init.d
Dustin Kirkland kirkl...@canonical.com writes: On Thu, 2010-02-11 at 15:54 -0800, Raphael Geissert wrote: I don't think anything will be merged unless the concern about the ubuntu- specific exclusion of some of the tests is also addressed. It would be even better if ubuntu helped with the implementation of the 'lsb-header' parameter to further reduce the divergence. The way this patch is implemented, I don't think that it's necessarily Ubuntu specific. It checks to see if the init.d/$script under examination is a symlink to /lib/init/upstart-job. If it is, then it skips the traditional LSB sysvinit style checks. As explained by Raphael and by Steve in the Launchpad bug, the patch is not acceptable for Debian as-is because it bypasses the check for an update-rc.d invocation in the maintainer scripts for upstart jobs. This invocation continues to be required in Debian. I'm checking in a modified version of this patch that avoids checking the syntax of the init script if it's a symlink to upstart-job, since doing so doesn't really make any sense, but which does not suppress the check for update-rc.d. I'm afraid you will need to handle the latter in an Ubuntu-specific manner for the time being until there's some better solution that works for both distributions. Separately, I'm not sure that Debian can really reasonably accept packages with this sort of symlink yet given dependency-based boot, but that's a separate problem that I'm not sure we need to also address in this bug. If that does need some sort of check, it shouldn't be a bevy of confusing syntax errors for upstart-job anyway. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87y6hmpsgi@windlord.stanford.edu
Re: Another lintian release for squeeze?
Russ Allbery wrote: Raphael Geissert writes: I'm attaching both changes. Comments? suggestions? 0007 includes the first set of changes of Lintian::Command::Simple. In the .t file I was trying to decide the best way to handle multiple jobs while still being able to recognise which one is reaped. Is there any way that we can fix the output handling so that at least it won't intersperse output from multiple threads? Making failures basically unreadable is unappealing, and I assume that's the possible result. Can we use some sort of locking method so that only one thread is printing stuff to the terminal at a time and finishes dumping its stuff, including its possible diff, before letting someone else go? In parallel mode, we should stop printing partial status (building, testing, OK) etc. and just print out the complete line to the point that we got and then the failure results if any all at once. That will work better with the output handling. Lintian::Command::Simple looks like a good idea to me, but please don't call the system() function exec(). I will keep expecting it to be, well, exec. :) Heh, yeah. Those were terribly-chosen names but I lacked imagination that day :) What do you suggest to use as names instead of fork() and exec()? what about the interface to reap jobs? Maybe wait(), when passed a hash ref, should return the value of the hash member that was reaped, when called in scalar context. In array context it should probably return the key, value pair. It seems that the only way to achieve what I want requires wait() to: a) call CORE::wait() to get the pid and $? of the reaped process. b) call $cmd-pid() for every member of the hash it was passed to see which of the processes was the one that finished. Needs to be done this way because we could otherwise end up reaping more jobs, if waitpid($pid, WNOHANG) was used. c) tell the $cmd object what the return status was. This requires a getter and a setter to be added to the OO interface. The former should probably refuse to set the return status if $self-wait() doesn't return -1. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/ho3img$sk...@dough.gmane.org
Bug#572430: [SCM] Debian package checker branch, master, updated. 2.3.3-17-gac4f93d
Raphael Geissert geiss...@debian.org writes: I was working on that very same bug and had the very same patch. What stopped me from committing was that there _is_ a build-dependency on ant (ORed, yes). So it looks like there's another bug that needs to be fixed. Since you are more familiar with the Lintian::Relation module, could you please check that? thanks! Lintian::Relation is functioning correctly. A dependency on ant | ant1.7 does not satisfy a requirement for ant, since the ant1.7 branch could be taken. (This is more obvious if you consider that from Lintian's perspective the dependency could be ant | make, which wouldn't guarantee that a binary named ant is available.) The correct fix is to make Lintian aware of the full set of options that could provide the required binary. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87r5neprhz@windlord.stanford.edu
[SCM] Debian package checker branch, master, updated. 2.3.3-21-g63ba2e6
The following commit has been merged in the master branch:
commit 5f971aa8471483d0177e444ec1126d858ce27663
Author: Jos Boumans k...@cpan.org
Date: Sat Mar 20 15:05:54 2010 -0700
Bypass init script checks if the script is a link to upstart-job
diff --git a/checks/init.d b/checks/init.d
index b9a3df8..61098b6 100644
--- a/checks/init.d
+++ b/checks/init.d
@@ -182,6 +182,9 @@ opendir(INITD, init.d) or fail(cannot read init.d
directory: $!);
for (readdir(INITD)) {
my $script = $_;
next if grep {$script eq $_} qw(. .. README skeleton rc rcS);
+# don't check upstart jobs. See Ubuntu bug report:
+# https://bugs.launchpad.net/ubuntu/+source/lintian/+bug/496798
+next if -l init.d/$script and readlink(init.d/$script) =~
m|lib/init/upstart-job$|;
$_ = $script;
unless ($initd_postinst{$_}) {
tag script-in-etc-init.d-not-registered-via-update-rc.d,
/etc/init.d/$_;
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt7lu-0003j4...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-21-g63ba2e6
The following commit has been merged in the master branch:
commit 63ba2e6c2dff886e83350739f9ba5baed0291e86
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 15:40:14 2010 -0700
Exclude init script symlinks to upstart-job from syntax checks
* checks/init.d:
+ [RA] Exclude symlinks to upstart-job from init script syntax checks.
Based on a patch by Jos Boumans. (Closes: #569492)
diff --git a/checks/init.d b/checks/init.d
index 61098b6..8c2bd2a 100644
--- a/checks/init.d
+++ b/checks/init.d
@@ -182,13 +182,14 @@ opendir(INITD, init.d) or fail(cannot read init.d
directory: $!);
for (readdir(INITD)) {
my $script = $_;
next if grep {$script eq $_} qw(. .. README skeleton rc rcS);
-# don't check upstart jobs. See Ubuntu bug report:
-# https://bugs.launchpad.net/ubuntu/+source/lintian/+bug/496798
-next if -l init.d/$script and readlink(init.d/$script) =~
m|lib/init/upstart-job$|;
-$_ = $script;
-unless ($initd_postinst{$_}) {
- tag script-in-etc-init.d-not-registered-via-update-rc.d,
/etc/init.d/$_;
- check_init(init.d/$_) if -f init.d/$_;
+
+# If $initd_postinst is true for this script, we already checked the
+# syntax in the above loop. Check the syntax of unregistered scripts so
+# that we get more complete Lintian coverage in the first pass.
+unless ($initd_postinst{$script}) {
+ tag 'script-in-etc-init.d-not-registered-via-update-rc.d',
+ /etc/init.d/$script;
+ check_init(init.d/$script) if -f init.d/$script;
}
}
closedir(INITD);
@@ -197,6 +198,16 @@ closedir(INITD);
sub check_init {
my ($initd_file) = @_;
+
+# In an upstart system, such as Ubuntu, init scripts are symlinks to
+# upstart-job. It doesn't make sense to check the syntax of upstart-job,
+# so skip the checks of the init script itself in that case.
+if (-l $initd_file) {
+ my $target = readlink($initd_file);
+ if ($target =~ m,(?:\A|/)lib/init/upstart-job\z,) {
+ return;
+ }
+}
open(IN, '', $initd_file)
or fail(cannot open init.d file $initd_file: $!);
my (%tag, %lsb);
diff --git a/debian/changelog b/debian/changelog
index 673df5c..2e3de75 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,9 @@ lintian (2.3.4) UNRELEASED; urgency=low
+ [RG] Update package-depends-on-hardcoded-libc exception to also
exclude eglibc. Based on a patch from Cyril Brulebois.
(Closes: #573398)
+ * checks/init.d:
++ [RA] Exclude symlinks to upstart-job from init script syntax checks.
+ Based on a patch by Jos Boumans. (Closes: #569492)
* checks/rules:
+ [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks,
Rene Engelhard. (Closes: #572430)
diff --git a/t/tests/init.d-symlink/debian/debian/links
b/t/tests/init.d-symlink/debian/debian/links
index b7a740f..2fe7261 100644
--- a/t/tests/init.d-symlink/debian/debian/links
+++ b/t/tests/init.d-symlink/debian/debian/links
@@ -1 +1,2 @@
/lib/init/upstart-job etc/init.d/lintian
+/lib/init/upstart-job etc/init.d/lintian-unreg
diff --git a/t/tests/init.d-symlink/desc b/t/tests/init.d-symlink/desc
index cdfd293..b56407c 100644
--- a/t/tests/init.d-symlink/desc
+++ b/t/tests/init.d-symlink/desc
@@ -5,3 +5,5 @@ Description: Check proper handling of symlinked init scripts
Test-Against:
init.d-script-not-included-in-package
init.d-script-not-marked-as-conffile
+Test-For:
+ script-in-etc-init.d-not-registered-via-update-rc.d
diff --git a/t/tests/init.d-symlink/tags b/t/tests/init.d-symlink/tags
index e69de29..68a0c34 100644
--- a/t/tests/init.d-symlink/tags
+++ b/t/tests/init.d-symlink/tags
@@ -0,0 +1 @@
+W: init.d-symlink: script-in-etc-init.d-not-registered-via-update-rc.d
/etc/init.d/lintian-unreg
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt7lw-0003jv...@alioth.debian.org
Re: Another lintian release for squeeze?
Raphael Geissert geiss...@debian.org writes: Heh, yeah. Those were terribly-chosen names but I lacked imagination that day :) What do you suggest to use as names instead of fork() and exec()? background() and run() maybe? what about the interface to reap jobs? wait() seems fine there. It's doing basically the same thing as CORE::wait(). Maybe wait(), when passed a hash ref, should return the value of the hash member that was reaped, when called in scalar context. In array context it should probably return the key, value pair. Seems reasonable to me. It seems that the only way to achieve what I want requires wait() to: a) call CORE::wait() to get the pid and $? of the reaped process. b) call $cmd-pid() for every member of the hash it was passed to see which of the processes was the one that finished. Needs to be done this way because we could otherwise end up reaping more jobs, if waitpid($pid, WNOHANG) was used. c) tell the $cmd object what the return status was. This requires a getter and a setter to be added to the OO interface. The former should probably refuse to set the return status if $self-wait() doesn't return -1. Yup, that sounds right. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/877hp6pqcy@windlord.stanford.edu
Bug#572430: [SCM] Debian package checker branch, master, updated. 2.3.3-17-gac4f93d
On 20 March 2010 16:17, Russ Allbery r...@debian.org wrote: Lintian::Relation is functioning correctly. A dependency on ant | ant1.7 does not satisfy a requirement for ant, since the ant1.7 branch could be taken. (This is more obvious if you consider that from Lintian's perspective the dependency could be ant | make, which wouldn't guarantee that a binary named ant is available.) Right, makes sense. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e9fb436d1003201521y14078357w16c97eb1341b7...@mail.gmail.com
[SCM] Debian package checker branch, master, updated. 2.3.3-22-g23039b9
The following commit has been merged in the master branch:
commit 23039b9fd282951be16c78f4021212dfc375bdcd
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 16:11:00 2010 -0700
Check for a new upstream release without new upstream version
* checks/changelog-file{,.desc}:
+ [RA] New check for a changelog entry indicating a new upstream
release but no change in the upstream portion of the package
version. Idea from Emilio Pozuelo Monfort. (Closes: #569129)
diff --git a/checks/changelog-file b/checks/changelog-file
index e2763ce..e3b7508 100644
--- a/checks/changelog-file
+++ b/checks/changelog-file
@@ -312,6 +312,15 @@ if (@entries) {
if $native_pkg and $second_version =~ m/-/;
}
+ my $first_upstream = $first_version;
+ $first_upstream =~ s/-[^-]+$//;
+ my $second_upstream = $second_version;
+ $second_upstream =~ s/-[^-]+$//;
+ if ($first_upstream eq $second_upstream
+ and $entries[0]-Changes =~
/^\s*\*\s+new\s+upstream\s+(\S+\s+)?release\b/im) {
+ tag 'possible-new-upstream-release-without-new-version';
+ }
+
my $first_dist = lc $entries[0]-Distribution;
my $second_dist = lc $entries[1]-Distribution;
if ($first_dist eq 'unstable' and $second_dist eq 'experimental') {
diff --git a/checks/changelog-file.desc b/checks/changelog-file.desc
index 166bfa9..f13cf62 100644
--- a/checks/changelog-file.desc
+++ b/checks/changelog-file.desc
@@ -201,6 +201,16 @@ Info: The latest package has a Debian native version
number, while the
the maintainer by forgetting to append -1 when uploading a new upstream
version.
+Tag: possible-new-upstream-release-without-new-version
+Severity: normal
+Certainty: possible
+Info: The most recent changelog entry contains an entry that appears to
+ say this is a new upstream release (a comment similar to new upstream
+ release, possibly with a word between upstream and release), but the
+ upstream portion of the package version number didn't change. This may
+ indicate that the package version was not updated properly in
+ ttdebian/changelog/tt.
+
Tag: experimental-to-unstable-without-comment
Severity: pedantic
Certainty: possible
diff --git a/debian/changelog b/debian/changelog
index 2e3de75..1de7ea5 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ lintian (2.3.4) UNRELEASED; urgency=low
+ [RA] Exclude packages from the klibc source package from the
embedded zlib check since klibc legitimately includes its own copy.
Thanks, maximilian attems. (Closes: #573914)
+ * checks/changelog-file{,.desc}:
++ [RA] New check for a changelog entry indicating a new upstream
+ release but no change in the upstream portion of the package
+ version. Idea from Emilio Pozuelo Monfort. (Closes: #569129)
* checks/control-file:
+ [RG] Update package-depends-on-hardcoded-libc exception to also
exclude eglibc. Based on a patch from Cyril Brulebois.
diff --git a/t/tests/changelog-file-new-upstream/debian/debian/changelog.in
b/t/tests/changelog-file-new-upstream/debian/debian/changelog.in
new file mode 100644
index 000..54faf9d
--- /dev/null
+++ b/t/tests/changelog-file-new-upstream/debian/debian/changelog.in
@@ -0,0 +1,14 @@
+{$srcpkg} ({$version}) unstable; urgency=low
+
+ * New upstream bugfix release.
+ * Lintian Test Suite.
+ * Test: {$testname}
+
+ -- {$author} {$date}
+
+{$srcpkg} (1.0-1) unstable; urgency=low
+
+ * Old changelog entry to trigger the tag.
+
+ -- {$author} Sat, 20 Mar 2010 16:09:18 -0700
+
diff --git a/t/tests/changelog-file-new-upstream/desc
b/t/tests/changelog-file-new-upstream/desc
new file mode 100644
index 000..3e1a1ad
--- /dev/null
+++ b/t/tests/changelog-file-new-upstream/desc
@@ -0,0 +1,6 @@
+Testname: changelog-file-new-upstream
+Sequence: 6000
+Type: non-native
+Version: 1.0-2
+Description: Check a new upstream version without a version change
+Test-For: possible-new-upstream-release-without-new-version
diff --git a/t/tests/changelog-file-new-upstream/tags
b/t/tests/changelog-file-new-upstream/tags
new file mode 100644
index 000..1883933
--- /dev/null
+++ b/t/tests/changelog-file-new-upstream/tags
@@ -0,0 +1 @@
+W: changelog-file-new-upstream:
possible-new-upstream-release-without-new-version
diff --git a/t/templates/skel.upstream/.dummy
b/t/tests/changelog-file-new-upstream/upstream/.dummy
similarity index 100%
copy from t/templates/skel.upstream/.dummy
copy to t/tests/changelog-file-new-upstream/upstream/.dummy
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt7pe-0003ii...@alioth.debian.org
Bug#567485: [checks/lintian] changed-by-name-missing is not Severity: serious
tags 567485 wontfix thanks Jean-Christophe Dubacq jcduba...@free.fr writes: Though the check is correct, it should not be severity serious: the format of the Changed-By (and the Maintainer field) is not mandated by a MUST, only a SHOULD. I don't agree for two reasons: * maintainer-name-missing and uploader-name-missing are both automatic rejects in the ftp-master checks, which makes them automatically severity: serious in Lintian. That's not the specific one that you're asking about, but that's the rule that Changed-By references. * The Policy description for Changed-By says The name and email address of the person who changed the said package. That's not a should. That's a statement of what that field shall include, which means that if it doesn't have the name and e-mail address, it's a syntax error and therefore is a violation of an implicit must. I see where your reading is coming from, but suspect the best fix is to just change the Policy wording to make it clear that this is a must. There's really no reason to use a different format, and Debian elsewhere already requires names. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/871vfeppxj@windlord.stanford.edu
Processed: tagging 573088, severity of 573088 is wishlist ...
Processing commands for cont...@bugs.debian.org: # This is not yet fully baked and is still being discussed. tags 573088 - patch Bug #573088 [lintian] Allow and recommend shasums control file Removed tag(s) patch. severity 573088 wishlist Bug #573088 [lintian] Allow and recommend shasums control file Severity set to 'wishlist' from 'normal' retitle 573088 [checks/md5sums] allow and recommend shasums control file Bug #573088 [lintian] Allow and recommend shasums control file Changed Bug title to '[checks/md5sums] allow and recommend shasums control file' from 'Allow and recommend shasums control file' thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912505814155.transcr...@bugs.debian.org
Processed: Re: Bug#567485: [checks/lintian] changed-by-name-missing is not Severity: serious
Processing commands for cont...@bugs.debian.org: tags 567485 wontfix Bug #567485 [lintian] [checks/lintian] changed-by-name-missing is not Severity: serious Added tag(s) wontfix. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912550220357.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 569492
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/init.d: #+ [RA] Exclude symlinks to upstart-job from init script syntax checks. # Based on a patch by Jos Boumans. (Closes: #569492) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 569492 + pending Bug #569492 [lintian] lintian: Avoid checking upstart jobs linked from /etc/init.d Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912485610865.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-23-gd064ef0
The following commit has been merged in the master branch:
commit d064ef09819f1a44885944fc41e87bbfd2f92de1
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 16:25:14 2010 -0700
Exclude *-common packages from weak-library-dev-dependency
* checks/control-file:
+ [RA] Also exclude *-common packages from weak-library-dev-dependency
checks. Thanks, Emilio Pozuelo Monfort. (Closes: #570408)
diff --git a/checks/control-file b/checks/control-file
index 78cac18..121e63f 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -285,7 +285,7 @@ sub check_dev_depends {
$depends =~ s/\s+$//;
for my $target (@packages) {
next unless ($target =~ /^lib[\w.+-]+\d/
-and $target !~ /-(?:dev|docs?)$/);
+and $target !~ /-(?:dev|docs?|common)$/);
my @depends = grep { /(?:^|[\s|])\Q$target\E(?:[\s|\(]|\z)/ }
split (/\s*,\s*/, $depends);
diff --git a/debian/changelog b/debian/changelog
index 1de7ea5..2fd542e 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,8 @@ lintian (2.3.4) UNRELEASED; urgency=low
+ [RG] Update package-depends-on-hardcoded-libc exception to also
exclude eglibc. Based on a patch from Cyril Brulebois.
(Closes: #573398)
++ [RA] Also exclude *-common packages from weak-library-dev-dependency
+ checks. Thanks, Emilio Pozuelo Monfort. (Closes: #570408)
* checks/init.d:
+ [RA] Exclude symlinks to upstart-job from init script syntax checks.
Based on a patch by Jos Boumans. (Closes: #569492)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt830-0004ib...@alioth.debian.org
Processed: limit source to lintian, tagging 569129
Processing commands for cont...@bugs.debian.org:
#lintian (2.3.4) UNRELEASED; urgency=low
#
# * checks/changelog-file{,.desc}:
#+ [RA] New check for a changelog entry indicating a new upstream
# release but no change in the upstream portion of the package
# version. Idea from Emilio Pozuelo Monfort. (Closes: #569129)
#
limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'
tags 569129 + pending
Bug #569129 [lintian] lintian: check if changelog contains 'new upstream
release' but the upload is a new Debian revision
Added tag(s) pending.
thanks
Stopping processing here.
Please contact me if you need assistance.
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.126912670732710.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 570408
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/control-file: #+ [RG] Update package-depends-on-hardcoded-libc exception to also # exclude eglibc. Based on a patch from Cyril Brulebois. # (Closes: #573398) #+ [RA] Also exclude *-common packages from weak-library-dev-dependency # checks. Thanks, Emilio Pozuelo Monfort. (Closes: #570408) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 570408 + pending Bug #570408 [lintian] lintian: weak-library-dev-dependency false positive when -dev depends on -common Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12691275537175.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-24-g6befbc5
The following commit has been merged in the master branch: commit 6befbc54f4c33bf9b6002bba6d5fcc800bc4999f Author: Russ Allbery r...@debian.org Date: Sat Mar 20 16:43:49 2010 -0700 Fix md5sums test problems in the etcfiles legacy test suite * testset/etcfiles/: + [RA] Fix problems with the md5sums test suite construction in the legacy etcfiles test. Thanks, Frank Lin PIAT. (Closes: #573081) diff --git a/debian/changelog b/debian/changelog index 2fd542e..e693ff6 100755 --- a/debian/changelog +++ b/debian/changelog @@ -53,6 +53,9 @@ lintian (2.3.4) UNRELEASED; urgency=low + [ADB] Replace the please mail comments to the maintainer request with a pointer to reportbug. + * testset/etcfiles/: ++ [RA] Fix problems with the md5sums test suite construction in the + legacy etcfiles test. Thanks, Frank Lin PIAT. (Closes: #573081) * t/tests/binaries-multiarch/: + [RG] Fix test failure in non-i386 architectures by normalising the expected output. Thanks, Niko Tyni. (Closes: #568680) diff --git a/testset/etcfiles/debian/rules b/testset/etcfiles/debian/rules index 1e58c81..60eb147 100755 --- a/testset/etcfiles/debian/rules +++ b/testset/etcfiles/debian/rules @@ -27,14 +27,14 @@ binary-indep: install -d $(tmp)/DEBIAN install -m 644 debian/conffiles $(tmp)/DEBIAN - echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/cronfile-normal' \ -debian/tmp/DEBIAN/md5sums - echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/.cronfile-begins-with-fullstop' \ -debian/tmp/DEBIAN/md5sums - echo '68b329da9893e34099c7d8ad5cb9c940 ./etc/cron.daily/cronfile-contains.fullstop' \ -debian/tmp/DEBIAN/md5sums - echo 'ab371382468880299e5ebd05921764ce ./etc/proper' \ + echo 'd41d8cd98f00b204e9800998ecf8427e ./etc/cron.daily/cronfile-normal' \ debian/tmp/DEBIAN/md5sums + echo 'd41d8cd98f00b204e9800998ecf8427e ./etc/cron.daily/.cronfile-begins-with-fullstop' \ +debian/tmp/DEBIAN/md5sums + echo 'd41d8cd98f00b204e9800998ecf8427e ./etc/cron.daily/cronfile-contains.fullstop' \ +debian/tmp/DEBIAN/md5sums + echo '05c72cacce994208128b7d081116b04a ./etc/proper' \ +debian/tmp/DEBIAN/md5sums echo 'ab371382468880299e5ebd05921764ce etc/improper' \ debian/tmp/DEBIAN/md5sums echo 'ab371382468880299e5ebd05921764ce usr/bin/foo' \ diff --git a/testset/tags.etcfiles b/testset/tags.etcfiles index 99b3c25..04b18db 100644 --- a/testset/tags.etcfiles +++ b/testset/tags.etcfiles @@ -3,9 +3,8 @@ E: etcfiles source: not-binnmuable-all-depends-any only-etcfiles - etcfiles E: etcfiles: changelog-file-not-compressed changelog E: etcfiles: file-in-etc-not-marked-as-conffile /etc/improper E: etcfiles: file-in-etc-not-marked-as-conffile /etc/improper-link -E: etcfiles: malformed-md5sums-control-file line 4 +E: etcfiles: malformed-md5sums-control-file line 7 E: etcfiles: md5sum-mismatch etc/improper -E: etcfiles: md5sum-mismatch etc/proper E: etcfiles: md5sums-lists-nonexisting-file usr/bin/foo E: etcfiles: no-copyright-file E: etcfiles: non-etc-file-marked-as-conffile /var/lib/foo -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt8kz-0005ys...@alioth.debian.org
Bug#571280: false positive for init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop
Michael Biebl bi...@debian.org writes: the rsyslog init script has the following LSB header ### BEGIN INIT INFO # Provides: rsyslog # Required-Start:$remote_fs $time # Required-Stop: umountnfs $time # X-Stop-After: sendsigs # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: enhanced syslogd # Description: Rsyslog is an enhanced multi-threaded syslogd. #It is quite compatible to stock sysklogd and can #be» #used as a drop-in replacement. ### END INIT INFO The # Required-Stop: umountnfs $time # X-Stop-After: sendsigs statements, ensure, that rsyslog is stopped as late as possible during shut down so it can collect log messages as long as possible. I uses the sendsigs_omit feature to ensure that it is not killed by the sendsigs init script in 0/6. Afaics the LSB header of rsyslog is correct and the following error message by lintian, a false positive: E: rsyslog: init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop What the script is triggering off of in this case is that you're starting a daemon that lives in /usr/sbin but you're saying /usr can be unmounted before the daemon is stopped. Since the running rsyslogd process has an open file descriptor for the /usr/sbin/rsyslogd binary, I believe /usr could not be unmounted while it was still running, although I haven't tested. I think it has to be stopped before $remote_fs can be stopped in the general case. Incidentally, you're also saying that /var ($local_fs) can be unmounted before rsyslogd is stopped, which similarly probably isn't going to work since, at least in the default configuration, rsyslogd is holding a bunch of open file descriptors in /var/log. I'm not sure what you should actually do here, whether add an override because the problems I think I see don't actually happen or change something about the init script. But I think the Lintian analysis is correct. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87ociio986@windlord.stanford.edu
Processed: limit source to lintian, tagging 573081
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * testset/etcfiles/: #+ [RA] Fix problems with the md5sums test suite construction in the # legacy etcfiles test. Thanks, Frank Lin PIAT. (Closes: #573081) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 573081 + pending Bug #573081 [lintian] lintian: [testset/etcfiles] weird md5 checksum tests Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912867016105.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-25-g4cc4aca
The following commit has been merged in the master branch:
commit 4cc4aca61813fb9b9b064dceb155185fb0cfa5ae
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 16:58:09 2010 -0700
Suppress missing separator tag if substvars are in use
* checks/control-file:
+ [RA] Suppress missing-separator-between-items if either of the items
contain substvars other than *:Depends substvars, since substvars
may be used to assemble the components of a dependency. Thanks,
Matthias Klose. (Closes: #573815)
diff --git a/checks/control-file b/checks/control-file
index 121e63f..5d86304 100644
--- a/checks/control-file
+++ b/checks/control-file
@@ -127,12 +127,12 @@ for my $control ($header, @binary_controls) {
$value =~ s/\[[^\]]*\]//g;
if ($value =~ /(?:^|\s)
(
- (?:\w[^\s,|\(]+|\$\{\S+\})\s*
+ (?:\w[^\s,|\$\(]+|\$\{\S+:Depends\})\s*
(?:\([^\)]*\)\s*)?
)
\s+
(
- (?:\w[^\s,|\(]+|\$\{\S+\})\s*
+ (?:\w[^\s,|\$\(]+|\$\{\S+:Depends\})\s*
(?:\([^\)]*\)\s*)?
)/x) {
my ($prev, $next) = ($1, $2);
diff --git a/debian/changelog b/debian/changelog
index e693ff6..f266c7b 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -14,6 +14,10 @@ lintian (2.3.4) UNRELEASED; urgency=low
(Closes: #573398)
+ [RA] Also exclude *-common packages from weak-library-dev-dependency
checks. Thanks, Emilio Pozuelo Monfort. (Closes: #570408)
++ [RA] Suppress missing-separator-between-items if either of the items
+ contain substvars other than *:Depends substvars, since substvars
+ may be used to assemble the components of a dependency. Thanks,
+ Matthias Klose. (Closes: #573815)
* checks/init.d:
+ [RA] Exclude symlinks to upstart-job from init script syntax checks.
Based on a patch by Jos Boumans. (Closes: #569492)
diff --git a/t/tests/control-file-general/debian/debian/control.in
b/t/tests/control-file-general/debian/debian/control.in
index 7b58933..e494c0c 100644
--- a/t/tests/control-file-general/debian/debian/control.in
+++ b/t/tests/control-file-general/debian/debian/control.in
@@ -2,7 +2,7 @@ Source: {$srcpkg}
Priority: extra
Maintainer: {$author}
Standards-Version: {$standards_version}
-Build-Depends: debhelper (= 7),
+Build-Depends: debhelper (= 7.0.50~),
fiddle [amd64 powerpc mips mipsel hppa s390],
faddle
(
@@ -49,7 +49,7 @@ Section: {$section}
Architecture: {$architecture}
Depends: $\{shlibs:Depends\}, $\{misc:Depends\}, foo (= 1),
baz ( 2),
- fizz (= 2.0)
+ fizz (= 2.0), gcc-$\{pv:gcc\} $\{reqv:gcc\}
Description: {$description} (three)
This is a test package designed to exercise some feature or tag of
Lintian. It is part of the Lintian test suite and may do very odd
diff --git a/t/tests/control-file-general/debian/debian/rules
b/t/tests/control-file-general/debian/debian/rules
new file mode 100644
index 000..f5db4bb
--- /dev/null
+++ b/t/tests/control-file-general/debian/debian/rules
@@ -0,0 +1,8 @@
+#!/usr/bin/make -f
+%:
+ dh $@
+
+override_dh_gencontrol:
+ echo 'pv:gcc=4.3' debian/substvars
+ echo 'reqv:gcc=(= 4.3-1)' debian/substvars
+ dh_gencontrol
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt8z9-0006sx...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-26-g79a1d21
The following commit has been merged in the master branch:
commit 79a1d215357fc43c7098ffe6f8a0c10b8d2a3596
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 17:12:26 2010 -0700
Allow umountn?fs instead of $*_fs in LSB init headers
* checks/init.d:
+ [RA] Allow umountnfs to satisfy a $remote_fs requirement and
umountnfs or umountfs to satisfy a $local_fs requirement in LSB
headers, avoiding false positives in unusual situations such as
rsyslog. Thanks, Michael Biebl. (Closes: #571280)
diff --git a/checks/init.d b/checks/init.d
index 8c2bd2a..60323f6 100644
--- a/checks/init.d
+++ b/checks/init.d
@@ -367,10 +367,10 @@ sub check_init {
tag init.d-script-missing-dependency-on-remote_fs,
/etc/init.d/$_: $keyword
if ($needs_fs{'remote'} (!defined $lsb{$keyword}
- || $lsb{$keyword} !~ m,(?:^|\s)\$remote_fs(?:\s|$),));
+ || $lsb{$keyword} !~
m,(?:^|\s)(?:\$remote_fs|umountnfs)(?:\s|$),));
tag init.d-script-missing-dependency-on-local_fs,
/etc/init.d/$_: $keyword
if ($needs_fs{'local'} (!defined $lsb{$keyword}
- || $lsb{$keyword} !~
m,(?:^|\s)\$(local|remote)_fs(?:\s|$),));
+ || $lsb{$keyword} !~
m,(?:^|\s)(?:\$(local|remote)_fs|umountn?fs)(?:\s|$),));
}
next unless defined $lsb{$keyword};
for my $dependency (split(/\s+/, $lsb{$keyword})) {
diff --git a/debian/changelog b/debian/changelog
index f266c7b..c608ec1 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -21,6 +21,10 @@ lintian (2.3.4) UNRELEASED; urgency=low
* checks/init.d:
+ [RA] Exclude symlinks to upstart-job from init script syntax checks.
Based on a patch by Jos Boumans. (Closes: #569492)
++ [RA] Allow umountnfs to satisfy a $remote_fs requirement and
+ umountnfs or umountfs to satisfy a $local_fs requirement in LSB
+ headers, avoiding false positives in unusual situations such as
+ rsyslog. Thanks, Michael Biebl. (Closes: #571280)
* checks/rules:
+ [RA] Allow ant1.7 to satisfy a build requirement for ant. Thanks,
Rene Engelhard. (Closes: #572430)
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt8n2-0006qv...@alioth.debian.org
Bug#571280: false positive for init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop
On 21.03.2010 00:37, Russ Allbery wrote: Michael Biebl bi...@debian.org writes: the rsyslog init script has the following LSB header ### BEGIN INIT INFO # Provides: rsyslog # Required-Start:$remote_fs $time # Required-Stop: umountnfs $time # X-Stop-After: sendsigs # Default-Start: 2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: enhanced syslogd # Description: Rsyslog is an enhanced multi-threaded syslogd. #It is quite compatible to stock sysklogd and can #be» #used as a drop-in replacement. ### END INIT INFO The # Required-Stop: umountnfs $time # X-Stop-After: sendsigs statements, ensure, that rsyslog is stopped as late as possible during shut down so it can collect log messages as long as possible. I uses the sendsigs_omit feature to ensure that it is not killed by the sendsigs init script in 0/6. Afaics the LSB header of rsyslog is correct and the following error message by lintian, a false positive: E: rsyslog: init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop What the script is triggering off of in this case is that you're starting a daemon that lives in /usr/sbin but you're saying /usr can be unmounted before the daemon is stopped. Since the running rsyslogd process has an open file descriptor for the /usr/sbin/rsyslogd binary, I believe /usr could not be unmounted while it was still running, although I haven't tested. I think it has to be stopped before $remote_fs can be stopped in the general case. Incidentally, you're also saying that /var ($local_fs) can be unmounted before rsyslogd is stopped, which similarly probably isn't going to work since, at least in the default configuration, rsyslogd is holding a bunch of open file descriptors in /var/log. I don't think your analysis is correct. The rsyslog header has a Required-Stop: umountnfs i.e. it is stopped before umountnfs. As /usr can be a remote fs in Debian, this means, rsyslog is stopped before /usr (or for that matter /var) is unmounted (fwiw the rsyslog LSB header wouldn't be correct, I certainly would have gotten a bug report until now :-) ) What the rsyslog init script does though, is using the sendsigs omit interface, to not be killed by the sendsigs init scripts, so it can run longer during shutdown. I'm not quite sure where you see me saying that /usr or /var could be unmounted while rsyslogd is still running? Cheers, Michael signature.asc Description: OpenPGP digital signature
Bug#571280: false positive for init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop
Michael Biebl bi...@debian.org writes: I don't think your analysis is correct. The rsyslog header has a Required-Stop: umountnfs i.e. it is stopped before umountnfs. As /usr can be a remote fs in Debian, this means, rsyslog is stopped before /usr (or for that matter /var) is unmounted (fwiw the rsyslog LSB header wouldn't be correct, I certainly would have gotten a bug report until now :-) ) What the rsyslog init script does though, is using the sendsigs omit interface, to not be killed by the sendsigs init scripts, so it can run longer during shutdown. I'm not quite sure where you see me saying that /usr or /var could be unmounted while rsyslogd is still running? Oh, I see. You're explicitly depending on some of the components of $remote_fs instead of using $remote_fs because $remote_fs includes sendsigs, which you don't want. Sorry, I didn't look deep enough. Yes, this should be fine and Lintian should cope. Will be fixed in the next version. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87eijeo7xc@windlord.stanford.edu
Processed: limit source to lintian, tagging 573815
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/control-file: #+ [RG] Update package-depends-on-hardcoded-libc exception to also # exclude eglibc. Based on a patch from Cyril Brulebois. # (Closes: #573398) #+ [RA] Also exclude *-common packages from weak-library-dev-dependency # checks. Thanks, Emilio Pozuelo Monfort. (Closes: #570408) #+ [RA] Suppress missing-separator-between-items if either of the items # contain substvars other than *:Depends substvars, since substvars # may be used to assemble the components of a dependency. Thanks, # Matthias Klose. (Closes: #573815) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 573815 + pending Bug #573815 [lintian] missing-separator-between-items error is too strict Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126912954724882.transcr...@bugs.debian.org
Processed: retitle 563773 to [checks/patch-systems] false positive if a patch in debian/patches is a symlink
Processing commands for cont...@bugs.debian.org: retitle 563773 [checks/patch-systems] false positive if a patch in debian/patches is a symlink Bug #563773 [lintian] lintian: false positive if a patch in debian/patches is a symlink Changed Bug title to '[checks/patch-systems] false positive if a patch in debian/patches is a symlink' from 'lintian: false positive if a patch in debian/patches is a symlink' thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126913048322169.transcr...@bugs.debian.org
Bug#574572: marked as done (lintian: false positives with shared libraries)
Your message dated Sat, 20 Mar 2010 17:00:50 -0700 with message-id 87iq8qo85p@windlord.stanford.edu and subject line Re: Bug#574572: lintian: false positives with shared libraries has caused the Debian Bug report #574572, regarding lintian: false positives with shared libraries to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 574572: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=574572 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems ---BeginMessage--- Package: lintian Version: 2.3.3 Severity: normal W: libkafs0-heimdal: package-name-doesnt-match-sonames libkafs0 W: libhx509-5-heimdal: package-name-doesnt-match-sonames libhx509-5 W: libhx509-5-heimdal: shlibs-declares-dependency-on-other-package libhx509-5-heimdal (= 1.4.0git20100221.dfsg.1) W: libkdc2-heimdal: package-name-doesnt-match-sonames libkdc2 W: libkdc2-heimdal: shlibs-declares-dependency-on-other-package libkdc2-heimdal (= 1.4.0git20100221.dfsg.1) W: libotp0-heimdal: package-name-doesnt-match-sonames libotp0 W: libwind0-heimdal: package-name-doesnt-match-sonames libwind0 W: libwind0-heimdal: shlibs-declares-dependency-on-other-package libwind0-heimdal (= 1.4.0git20100221.dfsg.1) W: libheimntlm0-heimdal: package-name-doesnt-match-sonames libheimntlm0 W: libheimntlm0-heimdal: shlibs-declares-dependency-on-other-package libheimntlm0-heimdal (= 1.4.0git20100221.dfsg.1) W: libkadm5clnt7-heimdal: package-name-doesnt-match-sonames libkadm5clnt7 W: libkadm5clnt7-heimdal: shlibs-declares-dependency-on-other-package libkadm5clnt7-heimdal (= 1.4.0git20100221.dfsg.1) W: libgssapi2-heimdal: package-name-doesnt-match-sonames libgssapi2 W: libgssapi2-heimdal: shlibs-declares-dependency-on-other-package libgssapi2-heimdal (= 1.4.0git20100221.dfsg.1) W: libkrb5-26-heimdal: package-name-doesnt-match-sonames libkrb5-26 W: libkrb5-26-heimdal: shlibs-declares-dependency-on-other-package libkrb5-26-heimdal (= 1.4.0git20100221.dfsg.1) W: libroken18-heimdal: package-name-doesnt-match-sonames libroken18 W: libroken18-heimdal: shlibs-declares-dependency-on-other-package libroken18-heimdal (= 1.4.0git20100221.dfsg.1) W: libhdb9-heimdal: package-name-doesnt-match-sonames libhdb9 W: libhdb9-heimdal: shlibs-declares-dependency-on-other-package libhdb9-heimdal (= 1.4.0git20100221.dfsg.1) W: libsl0-heimdal: package-name-doesnt-match-sonames libsl0 W: libasn1-8-heimdal: package-name-doesnt-match-sonames libasn1-8 W: libasn1-8-heimdal: shlibs-declares-dependency-on-other-package libasn1-8-heimdal (= 1.4.0git20100221.dfsg.1) The package-name-doesnt-match-sonames is an old issue, the shlibs-declares-dependency-on-other-package is a new one that makes no sense to me. Have I got something wrong? -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.31.9-lxc.1 (SMP w/4 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils 2.20.1-2 The GNU assembler, linker and bina ii diffstat 1.47-1produces graph of changes introduc ii dpkg-dev 1.15.5.6 Debian package development tools ii file 5.04-1Determines file type using magic ii gettext0.17-10 GNU Internationalization utilities ii intltool-debian0.35.0+20060710.1 Help i18n of RFC822 compliant conf ii libapt-pkg-perl0.1.24Perl interface to libapt-pkg ii libclass-accessor-perl 0.34-1Perl module that automatically gen ii libipc-run-perl0.84-1Perl module for running processes ii libparse-debianchangel 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl 1.2000-1 collection of modules to manipulat ii liburi-perl1.52-1module to manipulate and access UR ii locales2.10.2-6 Embedded GNU C Library: National L ii man-db 2.5.7-2 on-line manual pager ii perl [libdigest-sha-pe 5.10.1-11 Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarchnone (no description available) pn libtext-template-perl none (no description available) ii man-db2.5.7-2on-line manual pager -- no debconf information ---End Message--- ---BeginMessage--- As discussed, I don't think there's anything here that Lintian needs to
Processed: limit source to lintian, tagging 571280
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/init.d: #+ [RA] Exclude symlinks to upstart-job from init script syntax checks. # Based on a patch by Jos Boumans. (Closes: #569492) #+ [RA] Allow umountnfs to satisfy a $remote_fs requirement and # umountnfs or umountfs to satisfy a $local_fs requirement in LSB # headers, avoiding false positives in unusual situations such as # rsyslog. Thanks, Michael Biebl. (Closes: #571280) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 571280 + pending Bug #571280 [lintian] false positive for init.d-script-missing-dependency-on-remote_fs /etc/init.d/rsyslog: required-stop Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126913041717583.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-28-g495a39f
The following commit has been merged in the master branch:
commit 6c27e7c9ea1e9d1fc91abf470bd679622ebe1275
Author: Modestas Vainius modes...@vainius.eu
Date: Sat Mar 20 17:41:08 2010 -0700
Avoid trailing whitespace for symbols dependency on other package
If dependency is not versioned,
symbols-declares-dependency-on-other-package tag will have a trailing
space. This makes it tricky to declare overrides.
diff --git a/checks/shared-libs b/checks/shared-libs
index 8c32a4f..1450f4b 100644
--- a/checks/shared-libs
+++ b/checks/shared-libs
@@ -403,10 +403,10 @@ if ($#shlibs == -1 and not %unversioned_shlibs) {
foreach my $part (split /\s*,\s*/) {
foreach my $subpart (split /\s*\|\s*/, $part) {
- $subpart =~ m,^(\S+)\s*(\(\S+\s+\S+\)|#MINVER#)?$,;
+ $subpart =~ m,^(\S+)(\s*(?:\(\S+\s+\S+\)|#MINVER#))?$,;
($dep_package, $dep) = ($1, $2 || '');
if (defined $dep_package) {
- push @symbols_depends, $dep_package . ' ' . $dep;
+ push @symbols_depends, $dep_package . $dep;
} else {
tag syntax-error-in-symbols-file, $.
unless $warned;
@@ -433,10 +433,10 @@ if ($#shlibs == -1 and not %unversioned_shlibs) {
foreach my $part (split /\s*,\s*/) {
foreach my $subpart (split /\s*\|\s*/, $part) {
- $subpart =~ m,^(\S+)\s*(\(\S+\s+\S+\)|#MINVER#)?$,;
+ $subpart =~ m,^(\S+)(\s*(?:\(\S+\s+\S+\)|#MINVER#))?$,;
($dep_package, $dep) = ($1, $2 || '');
if (defined $dep_package) {
- push @symbols_depends, $dep_package . ' ' . $dep;
+ push @symbols_depends, $dep_package . $dep;
} else {
tag syntax-error-in-symbols-file, $. unless $warned;
$warned = 1;
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt9gk-00022z...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-28-g495a39f
The following commit has been merged in the master branch: commit 495a39f7ee976092a5409ed46835e01960f566df Author: Russ Allbery r...@debian.org Date: Sat Mar 20 17:42:54 2010 -0700 Add changelog for symbols dependency tag fix diff --git a/debian/changelog b/debian/changelog index c608ec1..58ca579 100755 --- a/debian/changelog +++ b/debian/changelog @@ -32,6 +32,10 @@ lintian (2.3.4) UNRELEASED; urgency=low + [ADB] Update the list of octave interpreters, adding octave3.2 (Closes: #574048) and removing octave2.1 (only available in lenny and earlier) and octave3.1. + * checks/shared-libs: ++ [RA] symbols-declares-dependency-on-other-package should not have + trailing whitespace for unversioned dependencies. Patch from + Modestas Vainius. (Closes: #570380) * checks/standards-version: + [RG] Don't warn about timewarp-standards-version when the changelog's distribution is UNRELEASED. Thanks, Raphaël Hertzog. -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9gw-0002hc...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-30-g7179bf8
The following commit has been merged in the master branch: commit 1d4a12d3d684a021a670b31b864b65e56366acdd Author: Jari Aalto jari.aa...@cante.net Date: Tue Mar 2 23:55:16 2010 +0200 checks/cruft.desc: improve native-package-with-dash-version Signed-off-by: Jari Aalto jari.aa...@cante.net diff --git a/checks/cruft.desc b/checks/cruft.desc index 4d42a2b..f5ac35e 100644 --- a/checks/cruft.desc +++ b/checks/cruft.desc @@ -14,7 +14,8 @@ Info: Native packaging should only be used if a piece of software was . Native source packages are sometimes created by accident. In most cases the reason is the location of the original source tarball. dpkg-source - searches for this in ../package_upstream-version.orig.tar.gz. + searches debian/changelog's VERSION in ../package_VERSION.orig.tar.gz. + Check also mistakenly set '(native)' value in file debian/source/format. Tag: non-native-package-with-native-version Severity: normal -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9lz-0005yx...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-30-g7179bf8
The following commit has been merged in the master branch: commit 7179bf83c803d0c421449d528889143b1937f215 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 17:48:14 2010 -0700 Improve native-package-with-dash-version wording Rewrite the tag long description a bit more to be clearer, and add a changelog entry. diff --git a/checks/cruft.desc b/checks/cruft.desc index f5ac35e..cfd6476 100644 --- a/checks/cruft.desc +++ b/checks/cruft.desc @@ -13,9 +13,12 @@ Info: Native packaging should only be used if a piece of software was the version number should not contain a Debian revision part. . Native source packages are sometimes created by accident. In most cases - the reason is the location of the original source tarball. dpkg-source - searches debian/changelog's VERSION in ../package_VERSION.orig.tar.gz. - Check also mistakenly set '(native)' value in file debian/source/format. + the reason is the location of the original source tarball. For version + 1.0 source packages, dpkg-source determines whether they're non-native by + looking for a file named ttlt;package_lt;version.orig.tar.gz/tt + in the parent directory, where lt;version is the version from the most + recent ttdebian/changelog/tt entry. For version 3.0 packages, check + ttdebian/source/format/tt for an erroneous (native) package format. Tag: non-native-package-with-native-version Severity: normal diff --git a/debian/changelog b/debian/changelog index 58ca579..ef5cd1d 100755 --- a/debian/changelog +++ b/debian/changelog @@ -18,6 +18,10 @@ lintian (2.3.4) UNRELEASED; urgency=low contain substvars other than *:Depends substvars, since substvars may be used to assemble the components of a dependency. Thanks, Matthias Klose. (Closes: #573815) + * checks/cruft.desc: ++ [RA] Provide more information in native-package-with-dash-version + long description about how native packages can be created by + mistake. Thanks, Jari Aalto. (Closes: #573839) * checks/init.d: + [RA] Exclude symlinks to upstart-job from init script syntax checks. Based on a patch by Jos Boumans. (Closes: #569492) -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9lk-00062h...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-32-g4a9c91c
The following commit has been merged in the master branch: commit e430927c171ac520c9c05f13634cf2bebe000352 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 17:51:24 2010 -0700 Add bug closer for #572298 diff --git a/debian/changelog b/debian/changelog index ef5cd1d..710521c 100755 --- a/debian/changelog +++ b/debian/changelog @@ -67,7 +67,7 @@ lintian (2.3.4) UNRELEASED; urgency=low * reporting/templates/foot.tmpl: + [ADB] Replace the please mail comments to the maintainer request - with a pointer to reportbug. + with a pointer to reportbug. (Closes: #572298) * testset/etcfiles/: + [RA] Fix problems with the md5sums test suite construction in the -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9rp-0005wu...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-32-g4a9c91c
The following commit has been merged in the master branch: commit 4a9c91ca82d9955c9c6f388fbd9f89bb1a32d8a6 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 17:54:23 2010 -0700 Reword source-contains-prebuilt-windows-binary description * checks/cruft.desc: + [RA] Reword source-contains-prebuilt-windows-binary long description. (Closes: #574515) diff --git a/checks/cruft.desc b/checks/cruft.desc index cfd6476..8021f11 100644 --- a/checks/cruft.desc +++ b/checks/cruft.desc @@ -399,10 +399,12 @@ Tag: source-contains-prebuilt-windows-binary Severity: pedantic Certainty: certain Info: The source tarball contains a prebuilt binary for Microsoft Windows. - They are usually left by convenience for end users, although it is possible - that upstream also provides tarballs source-only tarballs which you can use. - These files usually just take up space in the tarball and are of no use in - Debian. You may want to ask upstream to provide source-only tarballs. + They are usually provided for the convenience of users. These files + usually just take up space in the tarball and are of no use in Debian. + . + Check if upstream also provides source-only tarballs that you can use as + the upstream distribution instead. If not, you may want to ask upstream + to provide source-only tarballs. Tag: tar-errors-from-source Severity: normal diff --git a/debian/changelog b/debian/changelog index 710521c..932ec42 100755 --- a/debian/changelog +++ b/debian/changelog @@ -22,6 +22,8 @@ lintian (2.3.4) UNRELEASED; urgency=low + [RA] Provide more information in native-package-with-dash-version long description about how native packages can be created by mistake. Thanks, Jari Aalto. (Closes: #573839) ++ [RA] Reword source-contains-prebuilt-windows-binary long + description. (Closes: #574515) * checks/init.d: + [RA] Exclude symlinks to upstart-job from init script syntax checks. Based on a patch by Jos Boumans. (Closes: #569492) -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9rq-0005ys...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-34-gfa28867
The following commit has been merged in the master branch:
commit 7b2e01ff676fa20dd02183f4a1ac89fcf0f838bf
Author: Frans Pop elen...@planet.nl
Date: Sat Mar 20 18:00:41 2010 -0700
Don't warn about length of short description of text templates
For udebs all cases are templates of type text that contain text
fragments that get dynamically included in other templates at
runtime. Because of that specific usage, the length of the short
description is not relevant.
To avoid these false positives, please add an exception for this
warning:
- if the template type is text AND
- the package is a udeb
Reasons to request the exception are:
- udebs cannot contain lintian exceptions for binary packages (because
we don't want them installed in the D-I environment)
- we *do* want the warning for other template types than text
Also change the name of the local variable (template) 'type' which
currently shadows the higher level (package) 'type' variable.
diff --git a/checks/debconf b/checks/debconf
index ead94f5..f1b99a9 100644
--- a/checks/debconf
+++ b/checks/debconf
@@ -290,10 +290,10 @@ foreach my $template (@templates) {
} else {
($short, $extended) = ('', '');
}
-my $type = $template-{type} || '';
+my $ttype = $template-{type} || '';
unless ($short =~ /for internal use/i) {
- my $isprompt = grep { $_ eq $type } qw(string password);
-my $isselect = grep { $_ eq $type } qw(select multiselect);
+ my $isprompt = grep { $_ eq $ttype } qw(string password);
+my $isselect = grep { $_ eq $ttype } qw(select multiselect);
if ($isprompt) {
if ($short ($short !~ m/:$/ || $short =~
m/^(what|who|when|where|which|how)/i)) {
tag malformed-prompt-in-templates, $template-{template};
@@ -304,7 +304,7 @@ foreach my $template (@templates) {
tag using-imperative-form-in-templates, $template-{template};
}
}
- if ($type eq 'boolean') {
+ if ($ttype eq 'boolean') {
if ($short !~ /\?/) {
tag malformed-question-in-templates, $template-{template};
}
@@ -312,19 +312,20 @@ foreach my $template (@templates) {
if (defined ($extended) $extended =~ /[^\?]\?(\s+|$)/) {
tag using-question-in-extended-description-in-templates,
$template-{template};
}
- if ($type eq 'note') {
+ if ($ttype eq 'note') {
if ($short =~ /[.?;:]$/) {
tag malformed-title-in-templates, $template-{template};
}
}
if (length ($short) 75) {
- tag too-long-short-description-in-templates,
$template-{template};
+ tag too-long-short-description-in-templates, $template-{template}
+ unless $type eq 'udeb' $ttype eq 'text';
}
if (defined $template-{description}) {
if ($template-{description} =~
/(\A|\s)(I|[Mm]y|[Ww]e|[Oo]ur|[Oo]urs|mine|myself|ourself|me|us)(\Z|\s)/) {
tag using-first-person-in-templates, $template-{template};
}
-if ($template-{description} =~ /[ \'\]yes[ \'\,;.]/i and $type
eq 'boolean') {
+if ($template-{description} =~ /[ \'\]yes[ \'\,;.]/i and $ttype
eq 'boolean') {
tag making-assumptions-about-interfaces-in-templates,
$template-{template};
}
}
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1nt9a4-0005br...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-34-gfa28867
The following commit has been merged in the master branch: commit fa28867552d172d2adcbf14f16699661d42844da Author: Russ Allbery r...@debian.org Date: Sat Mar 20 18:03:37 2010 -0700 Add changelog for udeb text template debconf fix diff --git a/debian/changelog b/debian/changelog index 932ec42..b84b577 100755 --- a/debian/changelog +++ b/debian/changelog @@ -24,6 +24,11 @@ lintian (2.3.4) UNRELEASED; urgency=low mistake. Thanks, Jari Aalto. (Closes: #573839) + [RA] Reword source-contains-prebuilt-windows-binary long description. (Closes: #574515) + * checks/debconf: ++ [RA] Don't warn about the length of the short description for + templates of type text in udebs, since they're frequently used by + including them into other templates at runtime. Patch from Frans + Pop. (Closes: #560414) * checks/init.d: + [RA] Exclude symlinks to upstart-job from init script syntax checks. Based on a patch by Jos Boumans. (Closes: #569492) -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1nt9a7-0005f3...@alioth.debian.org
Bug#567451: lintian: could be left without a functional locale in some cases
Raphael Geissert geiss...@debian.org writes: The other day while fixing a bug that made lintian fail to install together with locales-all (but no 'locales' package,) I only workarounded the bug. Doing the following should demonstrate a case where lintian is left without a locale: apt-get --purge remove locales locales-all apt-get install locales-all apt-get install lintian apt-get install locales apt-get remove locales-all I don't know how we should fix this problem. The easiest way is by adding a trigger so that whenever the locales package is installed, upgraded or removed the same thing is done to our local locale. What do the others think about it? A trigger seems like a good idea to me, and would also address the concern that the locale might change in some way that we care about. I don't have time at the moment to implement that, but it sounds like the right approach. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87aau2o5ur@windlord.stanford.edu
Processed: retitle 567451 to [general] could be left without a functional locale in some cases
Processing commands for cont...@bugs.debian.org: retitle 567451 [general] could be left without a functional locale in some cases Bug #567451 [lintian] lintian: could be left without a functional locale in some cases Changed Bug title to '[general] could be left without a functional locale in some cases' from 'lintian: could be left without a functional locale in some cases' thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12691326623037.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 574515, tagging 572298
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/cruft.desc: #+ [RA] Provide more information in native-package-with-dash-version # long description about how native packages can be created by # mistake. Thanks, Jari Aalto. (Closes: #573839) #+ [RA] Reword source-contains-prebuilt-windows-binary long # description. (Closes: #574515) # * reporting/templates/foot.tmpl: #+ [ADB] Replace the please mail comments to the maintainer request # with a pointer to reportbug. (Closes: #572298) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 574515 + pending Bug #574515 [lintian] lintian: typo in source-contains-prebuilt-windows-binary doc Added tag(s) pending. tags 572298 + pending Bug #572298 [lintian] [reporting] request bugs via reportbug lintian instead of e-mail Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12691329136146.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 570380
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/shared-libs: #+ [RA] symbols-declares-dependency-on-other-package should not have # trailing whitespace for unversioned dependencies. Patch from # Modestas Vainius. (Closes: #570380) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 570380 + pending Bug #570380 [lintian] [checks/shared-libs] symbols-declares-dependency-on-other-package trailing space in extra info Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126913224031578.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 573839
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/cruft.desc: #+ [RA] Provide more information in native-package-with-dash-version # long description about how native packages can be created by # mistake. Thanks, Jari Aalto. (Closes: #573839) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 573839 + pending Bug #573839 [lintian] lintian: [checks/cruft] [PATCH] improve native-package-with-dash-version Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.12691325661586.transcr...@bugs.debian.org
Processed: limit source to lintian, tagging 560414
Processing commands for cont...@bugs.debian.org: #lintian (2.3.4) UNRELEASED; urgency=low # # * checks/debconf: #+ [RA] Don't warn about the length of the short description for # templates of type text in udebs, since they're frequently used by # including them into other templates at runtime. Patch from Frans # Pop. (Closes: #560414) # limit source lintian Limiting to bugs with field 'source' containing at least one of 'lintian' Limit currently set to 'source':'lintian' tags 560414 + pending Bug #560414 [lintian] lintian: Don't warn about length of short description of text templates Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126913345011613.transcr...@bugs.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch:
commit 2e37cf41dab7efeda3f5d4d228f94bfed01de267
Author: Raphaël Hertzog hert...@debian.org
Date: Wed Mar 3 20:04:34 2010 +0100
Simplify collection/debfiles to copy the debian directory entirely
Despite the comment in the source code, the collector has always collected
the full debian directory and several scripts now depend on this behaviour:
* patch-systems use files below debian/patches/
* po-debconf use files below debian/po/
* debian-source-dir will use files below debian/source/
The line “next if -d $file” should have been “next if -d
unpacked/debian/$file” for the script to have its intended behaviour.
diff --git a/collection/debfiles b/collection/debfiles
index a7664d9..6493741 100755
--- a/collection/debfiles
+++ b/collection/debfiles
@@ -35,14 +35,5 @@ if (-e debfiles) {
or fail(cannot rm old debfiles directory);
}
-mkdir('debfiles', 0777) or fail(cannot mkdir debfiles: $!);
-
-# Don't copy the whole directory, just all files in it.
-opendir(DEBIAN, 'unpacked/debian')
- or fail(cannot open unpacked/debian/ directory: $!);
-while (my $file=readdir(DEBIAN)) {
- next if -d $file;
- copy_dir(unpacked/debian/$file, 'debfiles/')
- or fail(cannot copy unpacked/debian/$file: $!);
-}
-closedir(DEBIAN);
+# Copy the whole debian directory
+copy_dir(unpacked/debian, debfiles);
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntbk5-0003ow...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch:
commit 605002a29c854d19ed4e9968e99e35f70a5043c4
Author: Raphaël Hertzog hert...@debian.org
Date: Wed Mar 3 20:26:23 2010 +0100
New check script debian-source-dir
This script is meant to contain all checks made on debian/source/* files.
This initial implementation only covers debian/source/format.
diff --git a/checks/etcfiles b/checks/debian-source-dir
similarity index 52%
copy from checks/etcfiles
copy to checks/debian-source-dir
index bc61715..8c4281d 100644
--- a/checks/etcfiles
+++ b/checks/debian-source-dir
@@ -1,6 +1,6 @@
-# etcfiles -- lintian check script -*- perl -*-
+# debian/source directory content -- lintian check script -*- perl -*-
-# Copyright (C) 2000 by Sean 'Shaleh' Perry
+# Copyright (C) 2010 by Raphaël Hertzog
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -18,47 +18,44 @@
# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
# MA 02110-1301, USA.
-package Lintian::etcfiles;
+package Lintian::debian_source_dir;
use strict;
-use Util;
+
+use Lintian::Data;
use Lintian::Tags qw(tag);
+our %KNOWN_FORMATS = (
+1.0 = 1,
+2.0 = 1,
+3.0 (quilt) = 1,
+3.0 (native) = 1,
+3.0 (git) = 1,
+3.0 (bzr) = 1,
+);
+
sub run {
my $pkg = shift;
my $type = shift;
my $info = shift;
-my %conffiles;
-
-my $conffiles = control/conffiles;
-
-# load conffiles
-if (open(IN, '', $conffiles)) {
-while (IN) {
- chop;
- next if m/^\s*$/o;
- s,^/,,;
- $conffiles{$_} = 1;
-}
-close(IN);
-}
-
-# Read package contents...
-foreach my $file (sort keys %{$info-index}) {
-my $index_info = $info-index-{$file};
-next unless $file =~ m,^etc, and $index_info-{type}=~ m/^[-h]/;
-
-# If there is a /etc/foo, it must be a conffile (with a few exceptions).
-if (not exists($conffiles{$file})
- and $file !~ m,/README$,
- and $file ne 'etc/init.d/skeleton'
- and $file ne 'etc/init.d/rc'
- and $file ne 'etc/init.d/rcS') {
- tag file-in-etc-not-marked-as-conffile, /$file;
-}
+if (-e debfiles/source/format) {
+open(FORMAT, , debfiles/source/format) or
+ fail(cannot read debian/source/format: $!);
+my $format = FORMAT;
+chomp $format;
+tag unknown-source-format, $format unless $KNOWN_FORMATS{$format};
+tag using-old-source-format if $format eq 1.0;
+} else {
+tag missing-debian-source-format;
}
}
1;
+
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 ts=8 noet shiftround
diff --git a/checks/debian-source-dir.desc b/checks/debian-source-dir.desc
new file mode 100644
index 000..0399012
--- /dev/null
+++ b/checks/debian-source-dir.desc
@@ -0,0 +1,43 @@
+Check-Script: debian-source-dir
+Author: Raphaël Hertzog hert...@debian.org
+Abbrev: dsd
+Type: source
+Info: This script looks for mistakes in debian/source/* files.
+Needs-Info: debfiles
+
+Tag: missing-debian-source-format
+Severity: normal
+Certainty: certain
+Info: With the introduction of new source formats, it's now recommended to
+ explicitly select the desired source format in debian/source/format.
+ .
+ If you don't have a good reason to stick with the old format,
+ you should switch to 3.0 (quilt) (for packages with a separate
+ upstream tarball) or to 3.0 (native) (for Debian native packages).
+ .
+ If you plan to keep using the old format, you should still create
+ that file and put 1.0 in it. In that case, you are invited to get in
+ touch with debian-d...@lists.debian.org to discuss the (technical) reasons
+ why the new formats do not suit you.
+Ref: dpkg-source(1), http://wiki.debian.org/Projects/DebSrc3.0
+
+Tag: unknown-source-format
+Severity: serious
+Certainty: certain
+Info: debian/source/format contains an unknown source format. The
+ formats officially supported by Debian are 3.0 (quilt), 3.0 (native)
+ and 1.0. dpkg-source additionnaly supports 2.0, 3.0 (git) and
+ 3.0 (bzr).
+Ref: dpkg-source(1)
+
+Tag: using-old-source-format
+Severity: pedantic
+Certainty: certain
+Info: The source package is still using the old source format 1.0 while
+ 3.0 (quilt) and 3.0 (native) are the recommended formats for use
+ within Debian.
+ .
+ See http://wiki.debian.org/Projects/DebSrc3.0 for basic information about
+ updating packages to use the new source formats.
+Ref: dpkg-source(1)
+
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntbk8-0003os...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit 20c55612944e2cbf91e82f6a49447037b56105b2 Author: Raphaël Hertzog hert...@debian.org Date: Wed Mar 3 20:43:47 2010 +0100 Fix description of unsupported-source-format The check has been modified to allow 3.0 (quilt|native) but the description was not updated accordingly. diff --git a/checks/fields.desc b/checks/fields.desc index 663e66c..1fd2bee 100644 --- a/checks/fields.desc +++ b/checks/fields.desc @@ -9,10 +9,9 @@ Info: This script checks the syntax of the fields in package control files, Tag: unsupported-source-format Severity: serious Certainty: certain -Info: This package uses a different source package format than 1.0. At - present, only ttFormat: 1.0/tt packages are permitted by the Debian - archive software. Newer package formats are supported by dpkg, but they - should not yet be used for upload to Debian. +Info: This package uses a different source package format than 1.0, + 3.0 (quilt) or 3.0 (native). Other packages formats are supported by + dpkg-source, but they are not allowed in the Debian archive. Tag: no-package-name Severity: serious -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1ntbkc-0003pq...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit 2f987268fa5d5b2edcc726e120c6f7e0b23e36b0 Author: Raphaël Hertzog hert...@debian.org Date: Wed Mar 3 20:47:09 2010 +0100 Define source format to be 3.0 (native) This makes lintian lintian-clean again after the addition of the new checks on debian/source/format. diff --git a/t/tests/basic-3.0-native/debian/debian/source/format b/debian/source/format similarity index 100% copy from t/tests/basic-3.0-native/debian/debian/source/format copy to debian/source/format -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1ntbke-0003qb...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch:
commit 9ab83d6ef424d6e94372709c1ce525f0c615ee4a
Author: Raphaël Hertzog hert...@debian.org
Date: Wed Mar 3 21:30:23 2010 +0100
New tag unknown-file-in-debian-source
The new tag is issued for unknown/unrecognized files in debian/source/.
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 8c4281d..c07b837 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -33,6 +33,14 @@ our %KNOWN_FORMATS = (
3.0 (bzr) = 1,
);
+our %KNOWN_FILES = (
+format = 1,
+include-binaries = 1,
+lintian-overrides = 1,
+options = 1,
+patch-header = 1,
+);
+
sub run {
my $pkg = shift;
@@ -50,6 +58,17 @@ if (-e debfiles/source/format) {
tag missing-debian-source-format;
}
+if (-d debfiles/source) {
+opendir(DEBSRC, debfiles/source) or fail(cannot opendir debian/source/:
$!);
+my $file;
+while ($file = readdir(DEBSRC)) {
+ next if $file eq . or $file eq ..;
+ tag unknown-file-in-debian-source, $file
+ unless $KNOWN_FILES{$file};
+}
+closedir(DEBSRC);
+}
+
}
1;
diff --git a/checks/debian-source-dir.desc b/checks/debian-source-dir.desc
index 0399012..7e4f029 100644
--- a/checks/debian-source-dir.desc
+++ b/checks/debian-source-dir.desc
@@ -41,3 +41,19 @@ Info: The source package is still using the old source
format 1.0 while
updating packages to use the new source formats.
Ref: dpkg-source(1)
+Tag: unknown-file-in-debian-source
+Severity: important
+Certainty: possible
+Info: The source package contains a file in debian/source/ that lintian
+ doesn't know about. Currently the following files are recognized:
+ .
+ * format
+ * include-binaries
+ * lintian-overrides
+ * options
+ * patch-header
+ .
+ This tag is emitted in case you mistyped the name of one of the above
+ files. If that's not the case and if the file can be legitimately be
+ expected in source packages, please file a bug against lintian asking
+ for the file to be recognized.
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntbkf-0003ry...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch:
commit 3ce5911d688711674ace5b16ff4eb4c2b27f69c6
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 19:01:30 2010 -0700
Coding style and related cleanups for debian-source-dir
Document the new check script in lintian.1, untabify the source file,
add error checking to collection/debfiles, and rephrase the
descriptions of the new tags somewhat. Add a changelog entry.
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index c07b837..87e8617 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -24,22 +24,11 @@ use strict;
use Lintian::Data;
use Lintian::Tags qw(tag);
-our %KNOWN_FORMATS = (
-1.0 = 1,
-2.0 = 1,
-3.0 (quilt) = 1,
-3.0 (native) = 1,
-3.0 (git) = 1,
-3.0 (bzr) = 1,
-);
+our %KNOWN_FORMATS = map { $_ = 1 }
+('1.0', '2.0', '3.0 (quilt)', '3.0 (native)', '3.0 (git)', '3.0 (bzr)');
-our %KNOWN_FILES = (
-format = 1,
-include-binaries = 1,
-lintian-overrides = 1,
-options = 1,
-patch-header = 1,
-);
+our %KNOWN_FILES = map { $_ = 1 }
+qw(format include-binaries lintian-overrides options patch-header);
sub run {
@@ -49,7 +38,7 @@ my $info = shift;
if (-e debfiles/source/format) {
open(FORMAT, , debfiles/source/format) or
- fail(cannot read debian/source/format: $!);
+fail(cannot read debian/source/format: $!);
my $format = FORMAT;
chomp $format;
tag unknown-source-format, $format unless $KNOWN_FORMATS{$format};
@@ -62,9 +51,9 @@ if (-d debfiles/source) {
opendir(DEBSRC, debfiles/source) or fail(cannot opendir debian/source/:
$!);
my $file;
while ($file = readdir(DEBSRC)) {
- next if $file eq . or $file eq ..;
- tag unknown-file-in-debian-source, $file
- unless $KNOWN_FILES{$file};
+next if $file eq . or $file eq ..;
+tag unknown-file-in-debian-source, $file
+unless $KNOWN_FILES{$file};
}
closedir(DEBSRC);
}
@@ -75,6 +64,6 @@ if (-d debfiles/source) {
# Local Variables:
# indent-tabs-mode: t
-# cperl-indent-level: 4
+# cperl-indent-level: nil
# End:
-# vim: syntax=perl sw=4 ts=8 noet shiftround
+# vim: syntax=perl sw=4 ts=8 et shiftround
diff --git a/checks/debian-source-dir.desc b/checks/debian-source-dir.desc
index 7e4f029..98a4843 100644
--- a/checks/debian-source-dir.desc
+++ b/checks/debian-source-dir.desc
@@ -8,23 +8,24 @@ Needs-Info: debfiles
Tag: missing-debian-source-format
Severity: normal
Certainty: certain
-Info: With the introduction of new source formats, it's now recommended to
- explicitly select the desired source format in debian/source/format.
+Info: To allow for possible future changes in the default source format,
+ explicitly selecting a source format by creating
+ ttdebian/source/format/tt is recommended.
.
- If you don't have a good reason to stick with the old format,
- you should switch to 3.0 (quilt) (for packages with a separate
- upstream tarball) or to 3.0 (native) (for Debian native packages).
+ If you don't have a good reason to stick with the old format, you should
+ switch to 3.0 (quilt) (for packages with a separate upstream tarball)
+ or to 3.0 (native) (for Debian native packages).
.
- If you plan to keep using the old format, you should still create
- that file and put 1.0 in it. In that case, you are invited to get in
- touch with debian-d...@lists.debian.org to discuss the (technical) reasons
- why the new formats do not suit you.
+ If you plan to keep using the old format, you should still create that
+ file and put 1.0 in it. In that case, you are invited to get in touch
+ with debian-d...@lists.debian.org to discuss the (technical) reasons why
+ the new formats do not suit you.
Ref: dpkg-source(1), http://wiki.debian.org/Projects/DebSrc3.0
Tag: unknown-source-format
Severity: serious
Certainty: certain
-Info: debian/source/format contains an unknown source format. The
+Info: ttdebian/source/format/tt contains an unknown source format. The
formats officially supported by Debian are 3.0 (quilt), 3.0 (native)
and 1.0. dpkg-source additionnaly supports 2.0, 3.0 (git) and
3.0 (bzr).
diff --git a/collection/debfiles b/collection/debfiles
index 6493741..e39585a 100755
--- a/collection/debfiles
+++ b/collection/debfiles
@@ -2,17 +2,17 @@
# debfiles -- lintian collector script
# Copyright (C) 1999 by Joey Hess
-#
+#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
-#
+#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
-#
+#
# You should have received a
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit 6ed7853bb719aeced152e394c3b542061e8ed001 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 19:03:37 2010 -0700 Add a summary of tag changes so far in this release diff --git a/debian/changelog b/debian/changelog index 6a9504a..2e27c05 100755 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,12 @@ lintian (2.3.4) UNRELEASED; urgency=low + * Summary of tag changes: ++ Added: + - missing-debian-source-format + - possible-new-upstream-release-without-new-version + - unknown-file-in-debian-source + - unknown-source-format + * checks/binaries: + [RA] Exclude packages from the klibc source package from the embedded zlib check since klibc legitimately includes its own copy. -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1ntbkj-0003wy...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch:
commit 4d8d638f295b9f935333714d9ee957b97b70e199
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 19:04:13 2010 -0700
Remove using-old-source-format tag for right now
diff --git a/checks/debian-source-dir b/checks/debian-source-dir
index 87e8617..91e10c8 100644
--- a/checks/debian-source-dir
+++ b/checks/debian-source-dir
@@ -42,7 +42,6 @@ if (-e debfiles/source/format) {
my $format = FORMAT;
chomp $format;
tag unknown-source-format, $format unless $KNOWN_FORMATS{$format};
-tag using-old-source-format if $format eq 1.0;
} else {
tag missing-debian-source-format;
}
diff --git a/checks/debian-source-dir.desc b/checks/debian-source-dir.desc
index 98a4843..8fafee4 100644
--- a/checks/debian-source-dir.desc
+++ b/checks/debian-source-dir.desc
@@ -31,17 +31,6 @@ Info: ttdebian/source/format/tt contains an unknown
source format. The
3.0 (bzr).
Ref: dpkg-source(1)
-Tag: using-old-source-format
-Severity: pedantic
-Certainty: certain
-Info: The source package is still using the old source format 1.0 while
- 3.0 (quilt) and 3.0 (native) are the recommended formats for use
- within Debian.
- .
- See http://wiki.debian.org/Projects/DebSrc3.0 for basic information about
- updating packages to use the new source formats.
-Ref: dpkg-source(1)
-
Tag: unknown-file-in-debian-source
Severity: important
Certainty: possible
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntbkk-0003xb...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit ca2ae307a53faa63097ee0f2520dec6522a14717 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 19:24:35 2010 -0700 Add basic tests for debian-source-dir diff --git a/t/tests/debian-source-dir-general/debian/debian/source/formt b/t/tests/debian-source-dir-general/debian/debian/source/formt new file mode 100644 index 000..d3827e7 --- /dev/null +++ b/t/tests/debian-source-dir-general/debian/debian/source/formt @@ -0,0 +1 @@ +1.0 diff --git a/t/tests/debian-source-dir-general/desc b/t/tests/debian-source-dir-general/desc new file mode 100644 index 000..2cbcf08 --- /dev/null +++ b/t/tests/debian-source-dir-general/desc @@ -0,0 +1,7 @@ +Testname: debian-source-dir-general +Sequence: 6000 +Version: 1.0 +Description: General tests for debian/source/* checks +Test-For: + missing-debian-source-format + unknown-file-in-debian-source diff --git a/t/tests/debian-source-dir-general/pre_build b/t/tests/debian-source-dir-general/pre_build new file mode 100755 index 000..9442d4c --- /dev/null +++ b/t/tests/debian-source-dir-general/pre_build @@ -0,0 +1,2 @@ +#!/bin/sh +rm $1/debian/source/format diff --git a/t/tests/debian-source-dir-general/tags b/t/tests/debian-source-dir-general/tags new file mode 100644 index 000..ce61b85 --- /dev/null +++ b/t/tests/debian-source-dir-general/tags @@ -0,0 +1,2 @@ +E: debian-source-dir-general source: unknown-file-in-debian-source formt +W: debian-source-dir-general source: missing-debian-source-format -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1ntbkm-0003yw...@alioth.debian.org
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit 9c556fa206ed71a1cafcdce6c61d3c21f30b8e45 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 19:31:58 2010 -0700 Update test suite for new source format tag diff --git a/t/source/control-field-traversal-1/Makefile b/t/source/control-field-traversal-1/Makefile index 33ffa3f..03de3c4 100644 --- a/t/source/control-field-traversal-1/Makefile +++ b/t/source/control-field-traversal-1/Makefile @@ -6,6 +6,8 @@ all: mkdir $(dir)/debian cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format tar cfz $(name)_1.tar.gz $(dir) cp dsc.in $(name)_1.dsc perl -I$(LINTIAN_ROOT)/lib -MUtil -i -pe \ diff --git a/t/source/control-field-traversal-2/Makefile b/t/source/control-field-traversal-2/Makefile index 9535ca3..3eff987 100644 --- a/t/source/control-field-traversal-2/Makefile +++ b/t/source/control-field-traversal-2/Makefile @@ -6,6 +6,8 @@ all: mkdir $(dir)/debian cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format tar cfz $(name)_1.tar.gz $(dir) cp dsc.in $(name)_1.dsc perl -I$(LINTIAN_ROOT)/lib -MUtil -i -pe \ diff --git a/t/source/control-field-traversal-3/Makefile b/t/source/control-field-traversal-3/Makefile index d477a23..8bf06c1 100644 --- a/t/source/control-field-traversal-3/Makefile +++ b/t/source/control-field-traversal-3/Makefile @@ -6,6 +6,8 @@ all: mkdir $(dir)/debian cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format tar cfz $(name)_1.tar.gz $(dir) cp dsc.in $(name)_1.dsc perl -I$(LINTIAN_ROOT)/lib -MUtil -i -pe \ diff --git a/t/source/control-file-missing-separator/Makefile b/t/source/control-file-missing-separator/Makefile index 2c7dede..4ea045a 100644 --- a/t/source/control-file-missing-separator/Makefile +++ b/t/source/control-file-missing-separator/Makefile @@ -6,6 +6,8 @@ all: mkdir $(dir)/debian cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format tar cfz $(name)_1.tar.gz $(dir) cp dsc.in $(name)_1.dsc perl -I$(LINTIAN_ROOT)/lib -MUtil -i -pe \ diff --git a/t/source/cruft-ancient-file/Makefile b/t/source/cruft-ancient-file/Makefile index 3af9fb3..f11f631 100644 --- a/t/source/cruft-ancient-file/Makefile +++ b/t/source/cruft-ancient-file/Makefile @@ -10,6 +10,8 @@ all: cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat echo '# foo' $(dir)/debian/watch + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format dpkg-source -sp -b $(dir) clean: diff --git a/t/source/magic-architecture-srcpkg-ok/Makefile b/t/source/magic-architecture-srcpkg-ok/Makefile index b3d7eea..e40fb6d 100644 --- a/t/source/magic-architecture-srcpkg-ok/Makefile +++ b/t/source/magic-architecture-srcpkg-ok/Makefile @@ -9,6 +9,8 @@ all: cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat echo '# foo' $(dir)/debian/watch + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format dpkg-source -sp -b $(dir) clean: diff --git a/t/source/magic-architecture-srcpkg-wrong/Makefile b/t/source/magic-architecture-srcpkg-wrong/Makefile index 20f75a1..b1d7dc6 100644 --- a/t/source/magic-architecture-srcpkg-wrong/Makefile +++ b/t/source/magic-architecture-srcpkg-wrong/Makefile @@ -9,6 +9,8 @@ all: cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat echo '# foo' $(dir)/debian/watch + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format dpkg-source -DArchitecture=amd64 any -sp -b $(dir) clean: diff --git a/t/source/package-version-0/Makefile b/t/source/package-version-0/Makefile index 8c4d20c..8c41539 100644 --- a/t/source/package-version-0/Makefile +++ b/t/source/package-version-0/Makefile @@ -6,6 +6,8 @@ all: mkdir $(dir)/debian cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat + mkdir $(dir)/debian/source + echo 1.0 $(dir)/debian/source/format dpkg-source -sn -b $(dir) clean: diff --git a/t/source/unpack-srcpkg-dot-dir/Makefile b/t/source/unpack-srcpkg-dot-dir/Makefile index 32c04fb..256cfde 100644 --- a/t/source/unpack-srcpkg-dot-dir/Makefile +++ b/t/source/unpack-srcpkg-dot-dir/Makefile @@ -11,6 +11,8 @@ all: cp changelog copyright control rules $(dir)/debian/ echo 7 $(dir)/debian/compat
[SCM] Debian package checker branch, master, updated. 2.3.3-45-g5eb50bf
The following commit has been merged in the master branch: commit 5eb50bf8b687cf1ba2534a8f1c5a98aa3540f7c2 Author: Russ Allbery r...@debian.org Date: Sat Mar 20 19:32:57 2010 -0700 Escape all angle brackets in cruft tag long description The modification to native-package-with-dash-version didn't escape the closing angle brackets. Do that. diff --git a/checks/cruft.desc b/checks/cruft.desc index 8021f11..1696f07 100644 --- a/checks/cruft.desc +++ b/checks/cruft.desc @@ -15,8 +15,8 @@ Info: Native packaging should only be used if a piece of software was Native source packages are sometimes created by accident. In most cases the reason is the location of the original source tarball. For version 1.0 source packages, dpkg-source determines whether they're non-native by - looking for a file named ttlt;package_lt;version.orig.tar.gz/tt - in the parent directory, where lt;version is the version from the most + looking for a file named ttlt;packagegt;_lt;versiongt;.orig.tar.gz/tt + in the parent directory, where lt;versiongt; is the version from the most recent ttdebian/changelog/tt entry. For version 3.0 packages, check ttdebian/source/format/tt for an erroneous (native) package format. -- Debian package checker -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/e1ntbkp-00040q...@alioth.debian.org
Processed: limit source to lintian, tagging 566820
Processing commands for cont...@bugs.debian.org:
#lintian (2.3.4) UNRELEASED; urgency=low
#
# * checks/debian-source-dir{,.desc}:
#+ [RA] New check script from Raphaël Hertzog checking various things
# about debian/source/* control files including checking for a source
# format control file. (Closes: #566820)
#
limit source lintian
Limiting to bugs with field 'source' containing at least one of 'lintian'
Limit currently set to 'source':'lintian'
tags 566820 + pending
Bug #566820 [lintian] lintian: Warn about missing debian/source/format, advise
switch to new 3.0 source formats
Added tag(s) pending.
thanks
Stopping processing here.
Please contact me if you need assistance.
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive:
http://lists.debian.org/handler.s.c.12691401797479.transcr...@bugs.debian.org
Re: RFC: further parallelisation (dependency-based collection and check scripts)
[re-sending as I suspect it hit an attachment size limit] Hi everyone, With the last set of changes to Lintian::Command::Simple, it is now possible to use the dependencies-based version without regressions. So, I was wondering if these changes could make their way into the next release. The only change we previously determined as a requirement I haven't made is renaming Lintian::PDepMap. I intend to do this while waiting for further comments. Further speed improvements will be achieved once we rewrite most of the Lintian namespace as previously discussed, so that for example checks are not delayed until the overrides file is collected. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net lintian_dep-based.mbox.gz Description: GNU Zip compressed data
[SCM] Debian package checker branch, master, updated. 2.3.3-48-g71fdabf
The following commit has been merged in the master branch:
commit 71fdabfdfe19dfc21182617b95dbc7c214b4b9d1
Author: Russ Allbery r...@debian.org
Date: Sat Mar 20 20:58:06 2010 -0700
Fix multiarch test in legacy libbaz
ia32-libbaz2 triggers a multiarch error if it's arch: all. Set it to
arch: any, although I suspect that this is still going to fail on
amd64.
diff --git a/testset/libbaz/debian/control b/testset/libbaz/debian/control
index e996b8a..7feaa86 100644
--- a/testset/libbaz/debian/control
+++ b/testset/libbaz/debian/control
@@ -57,7 +57,7 @@ Description: debugging package
things. It should not be installed like a regular package.
Package: ia32-libbaz2
-Architecture: all
+Architecture: any
Depends: ${shlibs:Depends}
Description: multiarch package
Regression test for lintian's handling of libraries (multiarch).
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntcjo-0004if...@alioth.debian.org
Re: Another lintian release for squeeze?
Raphael Geissert geiss...@debian.org writes: Russ Allbery wrote: Is there any way that we can fix the output handling so that at least it won't intersperse output from multiple threads? Making failures basically unreadable is unappealing, and I assume that's the possible result. Can we use some sort of locking method so that only one thread is printing stuff to the terminal at a time and finishes dumping its stuff, including its possible diff, before letting someone else go? I don't think it's possible to lock the file descriptors. Yeah, but you don't need to. You can use a separate variable as mutex lock. Since doing this is going to take some time, is there any objection for merging the initial -j option support to at least make prove run multiple jobs? (i.e. not merging the 'use threads' part.) Oh, sure, I have no objections to that. I don't really have any objections to merging the support for parallel tests in general, just don't want to make it the default until we figure out how to handle the output. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/87k4t6migx@windlord.stanford.edu
[SCM] Debian package checker branch, master, updated. 2.3.3-49-gc42d026
The following commit has been merged in the master branch:
commit c42d026dadd710ee1f66c51628205e4a48c9324c
Author: Raphael Geissert atom...@gmail.com
Date: Sat Mar 20 22:23:42 2010 -0600
Run multiple Perl TAP tests in parallel
Defaults to two jobs and can be configured with the -j option of
t/runtests.
diff --git a/t/runtests b/t/runtests
index 9f198e9..af53b28 100755
--- a/t/runtests
+++ b/t/runtests
@@ -68,13 +68,16 @@ our $STANDARDS_VERSION = '3.8.4';
sub usage {
print unquote(END);
-: Usage: $0 [-dkv] testset-directory testing-directory [test]
-: $0 [-dkv] [-t tag] testset-directory testing-directory
+: Usage: $0 [-dkv] [-j [jobs]] testset-directory testing-directory
[test]
+: $0 [-dkv] [-j [jobs]] [-t tag] testset-directory
testing-directory
:
-: -dDisplay additional debugging information
-: -kDo not stop after one failed test
-: -t tag Run only tests for or against tag
-: -vBe more verbose
+: -d Display additional debugging information
+: -j [jobs] Run up to jobs jobs in parallel. Defaults to two.
+: If -j is passed without specifying jobs, the number
+: of jobs started is cpu cores+1 if /proc/cpuinfo is
readable.
+: -k Do not stop after one failed test
+: -t tagRun only tests for or against tag
+: -v Be more verbose
:
: The optional 3rd parameter causes runtests to only run that particular
: test.
@@ -88,10 +91,12 @@ our $DEBUG = 0;
our $VERBOSE = 0;
our $RUNDIR;
our $TESTSET;
+our $JOBS = -1;
my ($run_all_tests, $tag);
Getopt::Long::Configure('bundling');
GetOptions('d|debug' = \$DEBUG,
+ 'j|jobs:i' = \$JOBS,
'k|keep-going' = \$run_all_tests,
't|tag=s' = \$tag,
'v|verbose'= \$VERBOSE) or usage;
@@ -110,6 +115,31 @@ unless (-d $TESTSET) {
fail(test set directory $TESTSET does not exist);
}
+# Getopt::Long assigns 0 as default value if none was specified
+if ($JOBS eq 0 -r '/proc/cpuinfo') {
+open(CPU, '', '/proc/cpuinfo')
+ or fail(failed to open /proc/cpuinfo: $!);
+while (CPU) {
+ next unless m/^cpu cores\s*:\s*(\d+)/;
+ $JOBS += $1;
+}
+close(CPU);
+
+print Apparent number of cores: $JOBS\n if $DEBUG;
+
+# Running up to twice the number of cores usually gets the most out
+# of the CPUs and disks but it might be too aggresive to be the
+# default for -j. Only use cores+1 then.
+$JOBS++;
+}
+
+# No decent number of jobs? set a default
+# Above $JOBS should be set to -1 so that this condition is always met,
+# therefore avoiding duplication.
+if ($JOBS le 0) {
+$JOBS = 2;
+}
+
# --- Display output immediately
$| = 1;
@@ -145,7 +175,7 @@ if ($singletest) {
if (@tests) {
print Test scripts:\n;
-if (system('prove', '-r', '-I', $LINTIAN_ROOT/lib, @tests) != 0) {
+if (system('prove', '-j', $JOBS, '-r', '-I', $LINTIAN_ROOT/lib, @tests)
!= 0) {
exit 1 unless $run_all_tests;
$status = 1;
}
--
Debian package checker
--
To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/e1ntcir-0006wl...@alioth.debian.org
Re: Another lintian release for squeeze?
Russ Allbery wrote: Raphael Geissert writes: Russ Allbery wrote: Is there any way that we can fix the output handling so that at least it won't intersperse output from multiple threads? Making failures basically unreadable is unappealing, and I assume that's the possible result. Can we use some sort of locking method so that only one thread is printing stuff to the terminal at a time and finishes dumping its stuff, including its possible diff, before letting someone else go? I don't think it's possible to lock the file descriptors. Yeah, but you don't need to. You can use a separate variable as mutex lock. Sure. The problem is that the output of subcommands is not under the control of the thread and as such it can't lock in case of failure or unexpected writes. Since doing this is going to take some time, is there any objection for merging the initial -j option support to at least make prove run multiple jobs? (i.e. not merging the 'use threads' part.) Oh, sure, I have no objections to that. I don't really have any objections to merging the support for parallel tests in general, just don't want to make it the default until we figure out how to handle the output. Since by default it defaults to using two jobs, I'm going to hold the other changes for now. Cheers, -- Raphael Geissert - Debian Developer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/ho479i$th...@dough.gmane.org
Processed: tagging 568748
Processing commands for cont...@bugs.debian.org: tags 568748 patch Bug #568748 [lintian] lintian: check for deprecated Debian-specific Makefile.PL usage Added tag(s) patch. thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to debian-lint-maint-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/handler.s.c.126914741428021.transcr...@bugs.debian.org
