Re: Roll call for porters of architectures in sid and testing

2014-03-08 Thread Roger Leigh
On Sun, Sep 01, 2013 at 04:12:07PM +0100, Roger Leigh wrote:
 Hi,
 
 I am an active porter for the following architectures and I intend
 to continue this for the lifetime of the jessie release:
 
 For powerpc, I
   - follow debian-powerpc
   - investigate and assist with powerpc-specific issues brought to
 the attention of the list
   - test debian-installer builds when needed
   - run powerpc hardware used for the above
   - am willing to investigate and fix toolchain and arch-specific
 bugs
 
 I am not primarily a porter; I just deal with powerpc porting issues on
 occasion when requested e.g. bootstrapping things etc.

I'm afraid I'm going to have to rescind all powerpc porting commitments.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


signature.asc
Description: Digital signature


Re: Roll call for porters of architectures in sid and testing

2013-09-01 Thread Roger Leigh
Hi,

I am an active porter for the following architectures and I intend
to continue this for the lifetime of the jessie release:

For powerpc, I
  - follow debian-powerpc
  - investigate and assist with powerpc-specific issues brought to
the attention of the list
  - test debian-installer builds when needed
  - run powerpc hardware used for the above
  - am willing to investigate and fix toolchain and arch-specific
bugs

I am not primarily a porter; I just deal with powerpc porting issues on
occasion when requested e.g. bootstrapping things etc.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Stable update for sysvinit

2013-07-14 Thread Roger Leigh
On Sun, Jul 14, 2013 at 03:43:18PM +0100, Adam D. Barratt wrote:
 On Mon, 2013-06-10 at 13:37 +0100, Roger Leigh wrote:
  On Fri, Jun 07, 2013 at 07:53:45PM +0100, Adam D. Barratt wrote:
 [...]
   What's the plan for getting this fixed in sid? The change looks okay
   (although -3.3+ would presumably have sufficed) but we're getting very
   close to the cut-off for 7.1 and I just spotted that there hasn't been a
   sysvinit upload since the release.
  
  Sorry for the delay here, I've been in hospital for a few days and
 
 Apologies also for the delay in getting back to you; I'd managed to not
 have the mail flagged properly in my -release folder (as Cyril
 mentioned, filing a p-u bug is generally more helpful from a tracking
 perspective).

OK, I'll do that in the future, thanks.

 I see the corresponding change has now been made in the unstable
 packaging. Please feel free to go ahead with the stable upload,
 versioned as 2.88dsf-41+deb7u1.

This has now been tagged (debian/sysvinit-2.88dsf-41+deb7u1) and uploaded.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130714180624.gr31...@codelibre.net



Re: Stable update for sysvinit

2013-06-10 Thread Roger Leigh
On Fri, Jun 07, 2013 at 07:53:45PM +0100, Adam D. Barratt wrote:
 On Sat, 2013-05-18 at 21:33 +0100, Roger Leigh wrote:
  +sysvinit (2.88dsf-41+wheezy1) stable-proposed-updates; urgency=low
  +
  +  [ Roger Leigh ]
  +  * Correct the Breaks on bootchart to ensure that all broken
  +versions are removed on upgrade (Closes: #694252).  Break
  +bootchart  0.10~svn407-4 to ensure that 0.10~svn407-3.3
  +and earlier are removed.
 
 What's the plan for getting this fixed in sid? The change looks okay
 (although -3.3+ would presumably have sufficed) but we're getting very
 close to the cut-off for 7.1 and I just spotted that there hasn't been a
 sysvinit upload since the release.

Hi Adam,

Sorry for the delay here, I've been in hospital for a few days and
moving house immediately after, leaving me currently in a poorly
mobile state and lacking internet.  Currently using a work computer
but no means to build packages for upload or sign them here.  I should
have internet at home by next weekend, but I'm not really in a
position to be able to do the work until that point in any case.

It's all here:
http://anonscm.debian.org/gitweb/?p=collab-maint/sysvinit;a=shortlog;h=refs/heads/wheezy
it just needs building and uploading with any changes to the version
number you need.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130610123738.gr31...@codelibre.net



Stable update for sysvinit

2013-05-18 Thread Roger Leigh
Hi,

It was pointed out that #694252 was preventing some upgrades from lenny
due to preventing the enabling of dependency-based boot.  The following
one line change corrects this:


diff --git a/debian/changelog b/debian/changelog
index 437a296..459c770 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+sysvinit (2.88dsf-41+wheezy1) stable-proposed-updates; urgency=low
+
+  [ Roger Leigh ]
+  * Correct the Breaks on bootchart to ensure that all broken
+versions are removed on upgrade (Closes: #694252).  Break
+bootchart  0.10~svn407-4 to ensure that 0.10~svn407-3.3
+and earlier are removed.
+
+ -- Roger Leigh rle...@debian.org  Sat, 18 May 2013 21:19:44 +0100
+
 sysvinit (2.88dsf-41) unstable; urgency=low
 
   [ Roger Leigh ]:
diff --git a/debian/control b/debian/control
index ef089d0..0bfcf9e 100644
--- a/debian/control
+++ b/debian/control
@@ -116,7 +116,7 @@ Breaks:
 # being a symlink #668616 and #668650
  initramfs-tools ( 0.104),
 # Needed for transition to dependency-based boot for wheezy
- bootchart ( 0.10~svn407-3.3)
+ bootchart ( 0.10~svn407-4)
 Description: scripts for initializing and shutting down the system
  The scripts in this package initialize a standard Debian
  system at boot time and shut it down at halt or reboot time.


Would this be OK for wheezy r1 and OK to upload to s-p-u?  The alternative
fix would be to have an unversioned Breaks, but that might preclude
bootchart being fixed in the future.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130518203316.gb31...@codelibre.net



Re: Bug#707004: upgrade-reports: sysklogd removed when upgrading from squeeze to wheezy (system existed under lenny) NO log deamon installed to replace it

2013-05-11 Thread Roger Leigh
On Thu, May 09, 2013 at 08:27:23PM +0100, Roger Leigh wrote:
 On Thu, May 09, 2013 at 06:31:08PM +0200, Michael Biebl wrote:
  Am 09.05.2013 17:56, schrieb Roger Leigh:
  
   The transitional package does need a version higher than the initscripts
   Breaks: sysklogd ( 1.5-6.2)
   so a 1.5-7 would be OK.  This could be done as a separate sysklogd
   package or as part of rsyslog.  Since the rsyslog version is higher,
   it could provide a transitional package with its own version number,
   saving the need for nasty independently-versioned binary packages.
  
  Keep in mind, that sysklogd is still available in sid.
  So the version in wheezy would be higher than what is in sid.
  
  I'm not sure what to do about this, tbh. Maybe the least controversial
  we can do, is to at least document this issue in the release notes.
  
  But as already said, this needs input from the release team in any case.
 
 So we definitely need a transition in stable.  And since it's also
 missing in testing, if we're going to do a transition in stable,
 which we will have to, we should really also be doing this in
 unstable as well at the same time.
 
 If the sysklogd maintainers are willing, we could:
 
 · upload rsyslog update to stable-proposed updates containing the
   transitional package
 · remove sysklogd from unstable
 · upload rsyslog to unstable containing the transitional package;
   this will allow transition in testing and unstable so the
   migration to rsyslog will be completed for jessie
 
 The transitional package could also potentially add
   $IncludeConfig /etc/syslog.conf
 to /etc/rsyslog.d as suggested by Russ Allbery.

sysklogd is now removed from unstable, so if the rsyslog maintainers
wish to put a transitional package in place in unstable, that's now
possible.

Stable release managers: would rsyslog putting a transitional package
into stable be acceptable, so that sysklogd users upgrading to wheezy
won't be left in a state where they don't have an installing syslog?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130511134508.gz21...@codelibre.net



Re: [Pkg-sysvinit-devel] Bug#707004: upgrade-reports: sysklogd removed when upgrading from squeeze to wheezy (system existed under lenny) NO log deamon installed to replace it

2013-05-10 Thread Roger Leigh
On Fri, May 10, 2013 at 10:37:14AM +0200, Petter Reinholdtsen wrote:
 
 [Roger Leigh]
  sysklogd is dead upstream and unmaintained in Debian for over 2½
  years.
 
 It has been practically abandoned for a lot longer than that.  The lack
 of maintenance of sysklogd is part of the reason rsyslog took over in
 Debian, many years ago.

I opened #707655 against ftp.debian.org to request its removal.  Just
mentioning it here in case anyone has anything to add there.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130510093350.gv21...@codelibre.net



Re: Bug#707004: upgrade-reports: sysklogd removed when upgrading from squeeze to wheezy (system existed under lenny) NO log deamon installed to replace it

2013-05-09 Thread Roger Leigh
On Thu, May 09, 2013 at 06:31:08PM +0200, Michael Biebl wrote:
 Am 09.05.2013 17:56, schrieb Roger Leigh:
 
  The transitional package does need a version higher than the initscripts
  Breaks: sysklogd ( 1.5-6.2)
  so a 1.5-7 would be OK.  This could be done as a separate sysklogd
  package or as part of rsyslog.  Since the rsyslog version is higher,
  it could provide a transitional package with its own version number,
  saving the need for nasty independently-versioned binary packages.
 
 Keep in mind, that sysklogd is still available in sid.
 So the version in wheezy would be higher than what is in sid.
 
 I'm not sure what to do about this, tbh. Maybe the least controversial
 we can do, is to at least document this issue in the release notes.
 
 But as already said, this needs input from the release team in any case.

So we definitely need a transition in stable.  And since it's also
missing in testing, if we're going to do a transition in stable,
which we will have to, we should really also be doing this in
unstable as well at the same time.

If the sysklogd maintainers are willing, we could:

· upload rsyslog update to stable-proposed updates containing the
  transitional package
· remove sysklogd from unstable
· upload rsyslog to unstable containing the transitional package;
  this will allow transition in testing and unstable so the
  migration to rsyslog will be completed for jessie

The transitional package could also potentially add
  $IncludeConfig /etc/syslog.conf
to /etc/rsyslog.d as suggested by Russ Allbery.

sysklogd is dead upstream and unmaintained in Debian for over 2½
years.  I would prefer to be able to do the above, but if not we
can upload a standalone transitional package to
stable-proposed-updates only and then sysklogd would need to be
fixed in unstable and migrate to testing.  Is there anyone who would
want to fix up sysklogd and maintain it?  Unless there is, I think
it's well past time for it to be removed from unstable.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130509192723.gt21...@codelibre.net



Re: file-rc: File-rc doesn't restore rcX.d dirs at remove, breaks sysv-rc installation.

2013-03-23 Thread Roger Leigh
On Thu, Mar 21, 2013 at 01:26:30PM +, Roger Leigh wrote:
 On Thu, Mar 21, 2013 at 06:50:51AM +0100, Alexander Wirt wrote:
  On Wed, 20 Mar 2013, Roger Leigh wrote:
   Alexander, is this approach OK with you?  If you're happy with
   what this is doing, can this go into wheezy?
  its basically your feature, so if you think its working - I am happy with 
  it. 
 
 Yes, I'm happy that this allows file-rc to sysv-rc migration.
 Would you prefer to upload with the patch applied, or should I
 do it?

I'm away for the next week, so would you be able to upload this
in the meantime?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130323120114.gk23...@codelibre.net



Re: file-rc: File-rc doesn't restore rcX.d dirs at remove, breaks sysv-rc installation.

2013-03-21 Thread Roger Leigh
On Thu, Mar 21, 2013 at 06:50:51AM +0100, Alexander Wirt wrote:
 On Wed, 20 Mar 2013, Roger Leigh wrote:
  Alexander, is this approach OK with you?  If you're happy with
  what this is doing, can this go into wheezy?
 its basically your feature, so if you think its working - I am happy with it. 

Yes, I'm happy that this allows file-rc to sysv-rc migration.
Would you prefer to upload with the patch applied, or should I
do it?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130321132630.gg23...@codelibre.net



Re: file-rc: File-rc doesn't restore rcX.d dirs at remove, breaks sysv-rc installation.

2013-03-20 Thread Roger Leigh
On Wed, Mar 20, 2013 at 05:04:57PM +0100, Michael Stapelberg wrote:
 Hi,
 
 at this point I cannot spend any more time on this bug report.
 
 Given that the bug report is without maintainer reply since more than
 half a year, and there are merely 160 people voting for it via popcon, I
 wonder if we should just drop file-rc from Debian in order to reduce
 init system complexity.
 
 release-team: what do you think?

I don't want to speak for the file-rc maintainers, but just from the
POV of sysvinit and jessie:

- in wheezy, we switched to requiring insserv for dependency-based
  boot; previously it was the default (but optional) and prior to
  that it was opt-in.  So we've got to the point of dependency-based
  boot being required over several stable releases.
- we have retained static runlevel ordering in maintainer scripts and
  update-rc.d for backward compatibility.  These are going to be
  removed in jessie, since we now no longer use them at all (file-rc
  was the last user).
- file-rc was converted (by me) to use insserv in its update-rc.d
  implementation, primarily to allow the removal of static ordering
  since it's now bitrotting badly--no one is using or testing the
  static ordering.  I'll be adding lintian checks and updating
  update-rc.d and dh_installinit etc. to initially ignore and
  ultimately (jessie+1/2) error out if static ordering is used.

Given the low number of users, and that fact that it's pretty much
tied to static runlevel ordering, even with the insserv usage, file-rc
will not work gracefully with dependency-based boot (if you do manual
edits, but if you don't why not just use sysv-rc?), I'm unsure if it
can remain viable.  That is to say it will only work reliably if you
don't edit the runlevel ordering, which is pretty much equivalent to
sysv-rc but without any parallelisation.

I'm very sure that for jessie we will have a large discussion about
which init system (or systems) we will be supporting for the future.
Of all the major contenders, all of them support dynamic boot ordering
and none support static ordering, and for good reason.  As far as I'm
aware, file-rc is the only system using static ordering (even when the
ordering is now generated from insserv).  The other problem is Hurd,
which doesn't use an init system at all (which is a major issue in its
own right).

WRT this bug, I think your patch is better included even if there are
corner cases it doesn't currently handle--we can always fix those
later.  It's more important that migration back to sysv-rc is
working, even if it's imperfect.  The admin can always fix up any
problems after, whereas the alternative is an unbootable system.  It
would be good if the file-rc maintainers could take the time to make
sure if this is working properly; I'll be happy to make any changes
to the sysv-rc maintainer scripts if required to assist in this.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130320162929.gz23...@codelibre.net



Re: file-rc: File-rc doesn't restore rcX.d dirs at remove, breaks sysv-rc installation.

2013-03-20 Thread Roger Leigh
On Wed, Mar 20, 2013 at 05:04:57PM +0100, Michael Stapelberg wrote:
 at this point I cannot spend any more time on this bug report.

I've tested your patch, and it appears to work correctly in all
the cases I've tried.  I've updated it slightly (attached) to
log what's happening during transition to dependency-based boot,
particularly if things go wrong, but it's otherwise functionally
identical to your patch.  It also runs insserv in verbose mode
so that any errors/warnings are not hidden (as for sysv-rc).

Alexander, is this approach OK with you?  If you're happy with
what this is doing, can this go into wheezy?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
diff -urN file-rc-0.8.14.original/debian/changelog file-rc-0.8.15/debian/changelog
--- file-rc-0.8.14.original/debian/changelog	2012-08-19 19:56:20.0 +0100
+++ file-rc-0.8.15/debian/changelog	2013-03-20 22:39:54.191661297 +
@@ -1,3 +1,16 @@
+file-rc (0.8.15) unstable; urgency=low
+
+  [ Michael Stapelberg ]
+  * Call rcfile2link.sh followed by insserv to properly restore links
+when removing file-rc. (Closes: #688140)
+
+  [ Roger Leigh ]
+  * When migrating to dependency-based boot in the prerm, log
+what's happening, and if insserv fails issue an informative
+message (taken from sysv-rc postinst).
+
+ -- Roger Leigh rle...@debian.org  Wed, 20 Mar 2013 21:31:30 +
+
 file-rc (0.8.14) unstable; urgency=low
 
   * Depend on insserv, this prevents upgrade problems with systems
diff -urN file-rc-0.8.14.original/debian/prerm file-rc-0.8.15/debian/prerm
--- file-rc-0.8.14.original/debian/prerm	2012-07-30 06:49:08.0 +0100
+++ file-rc-0.8.15/debian/prerm	2013-03-20 22:35:07.459268780 +
@@ -16,12 +16,32 @@
 # for details, see http://www.debian.org/doc/debian-policy/ or
 # the debian-policy package
 
+# Make sure insserv is in path
+PATH=/sbin:$PATH
 
 case $1 in
 remove)
+echo info: restoring rc.d links 12
+/usr/share/file-rc/rcfile2link.sh
+echo info: running insserv 12
+if insserv -v ; then
+echo success: Enabled dependency based boot system. 12
+else
+echo error: Something failed while migrating. 12
+cat 12 EOF
+
+error: Unable to migrate to dependency based boot sequencing.
+
+See http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot for
+more information about dependency based boot sequencing. To
+reattempt the migration process run 'insserv -v' after correcting
+the cause of the problem, and then retry removing file-rc.
+
+EOF
+fi
 ;;
 upgrade|deconfigure)
-	;;
+;;
 failed-upgrade)
 ;;
 *)


Re: Bug#701936: btrfs can't fsck /run/rootdev on boot

2013-03-06 Thread Roger Leigh
reassign 701936 initscripts
severity 701936 serious
thanks

On Fri, Mar 01, 2013 at 07:50:37AM +0100, Daniel Baumann wrote:
 retitle 701936 btrfs can't fsck /run/rootdev on boot with sysvinit
 severity 701936 important
 clone 701936 -1
 reassign -1 sysvinit
 thanks
 
 works with systemd, it's sysvinit specific.

This is largely init-system agnostic.  There's only a single issue
with initscripts, and even that's arguably a Btrfs issue.  Please do
not use works with systemd as an excuse for gratuitous brokenness.
It's broken everywhere.

There are a number of serious problems here.  I'll go through each
in turn.


1) checkroot.sh creates an invalid /run/rootdev

Btrfs, unlike every other filesystem I'm aware of, reports an
invalid device with stat(2).

% findmnt / 
TARGET SOURCEFSTYPE OPTIONS
/  /dev/sda4 btrfs  rw,nodev,relatime,ssd,discard,space_cache

% stat / | grep ^Device
Device: 10h/16d Inode: 256 Links: 1

% mountpoint -qx /dev/sda4
8:4

% mountpoint -d / 
0:16

The mountpoint discrepancy triggers the creation of /run/rootdev, but
since the block device is actually *invalid*, this therefore causes
fsck to fail.  This is the root cause of this bug.  checkroot.sh makes
the assumption that the filesystem device is valid; this is not the
case with Btrfs.  Up until now, this assumption has been valid in all
the circumstances triggering this codepath.

We can teach checkroot to prefer the mount device, but this is not
always a good choice (there is a reason why we have this particular
fallback).  I have tried this, and it does allow fsck ro run.  But for
non-Btrfs rootfses, this is the wrong thing to do.


2) fsck.btrfs fails to fsck a mounted filesystem

fsck.btrfs won't check a mounted filesystem, even if mounted
read-only.  We need to be able to do this, since we are running
fsck from the rootfs.  We do this for all other filesystem types.


3) fsck.btrfs does not support the standard fsck options

fsck.btrfs does not include support for most of the options in
fsck(8), even to ignore them.  Since we make use of these options,
fsck.btrfs breaks.


4) fsck.btrfs error codes

I haven't tested this due to point (2) above, but if you look at
checkroot.sh, you'll notice that the exit codes are quite
important for doing the right thing for fsck failures and in
some cases success.  fsck.btrfs *must* use the same codes.


So, to summarise the current situation:

• systems with a btrfs root filesystem are currently *unbootable*
  without using fastboot to skip fsck
• even if the checkroot script is fixed, fsck.btrfs remains
  broken and all the unbootable systems remain unbootable
• at this late stage in the freeze, btrfs-tools should never
  have been uploaded to unstable
  · it's fundamentally broken
  · it's broken countless systems (including my own)
  · it's obviously not been tested properly; these tools are
fundamental to basic system functioning, and I expect
better quality work from a Debian developer
  · this is obviously unsuitable for wheezy
• I'm loath to make any changes to initscripts to work around this
  breakage, not only because it won't fix the root cause of the
  problems, but because to change the core scripts at this point
  would be to compromise the months of testing they have had, and
  that's simply unacceptable

I would recommend that this be immediately reverted in unstable.
If you want to put it into experimental, feel free, but please
add a big disclaimer to avoid further breakage.  Given the
brokenness, probably best not uploaded at all until it will
not break booting.

If Btrfs needs special handling in initscripts due to unique
requirements, then I'm happy to look at adding such support.
However... you should have communicated this to me /before/
uploading this and breaking lots of systems, so that the
support would have been in place ahead of time.  And you should
have also done some testing to avoid breaking so many people's
computers; this is just not acceptable.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130306200458.ga17...@codelibre.net



Re: Bug#701936: btrfs can't fsck /run/rootdev on boot

2013-03-06 Thread Roger Leigh
On Wed, Mar 06, 2013 at 09:16:01PM +0100, Daniel Baumann wrote:

  2) fsck.btrfs fails to fsck a mounted filesystem
  
  fsck.btrfs won't check a mounted filesystem, even if mounted
  read-only.  We need to be able to do this, since we are running
  fsck from the rootfs.  We do this for all other filesystem types.
 
 the common workaround that e.g. other distributions do is to do this in
 initramfs. probably debian should do that for all filesystems in future too.

What about *right now*, today.  What we should do is irrelevant
to the problem right now.  And it's not like doing it in the
initramfs is the only correct way to do this.  We've done it
the existing way since forever.  And you broke that.  That's
unacceptable.

  3) fsck.btrfs does not support the standard fsck options
 
 easy fixable, but hasn't much to do with the current remaining problem
 in sid.

Yes, it does.  We use those options.  And that breaks things.

  4) fsck.btrfs error codes
  
  I haven't tested this due to point (2) above
 
 me neither, but that's easy fixable too and hasn't much to do with the
 current remaining problem in sid.

Yes, it does.  If they don't work, then it will again break the
checkroot script.  Please do check this.

  • systems with a btrfs root filesystem are currently *unbootable*
without using fastboot to skip fsck
 
 *iff* sysvinit is used.

It's the default init system for crying out loud.  You broke
booting with the default init system for all people using a
btrfs rootfs.  And even if it was not the default, it's still
massively broken.  Would breaking booting with systemd or
upstart be any more acceptable?  No, it would not.  End this
ridiculous line of reasoning right now.

  • even if the checkroot script is fixed, fsck.btrfs remains
broken and all the unbootable systems remain unbootable
 
 the current package works fine on systems with systemd (not yet fixed
 points 3 and 4 from above are not breaking it).

That does not solve the problem for the vast majority who are not
using systemd.  Think for a minute about how much breakage you've
just caused.

  I would recommend that this be immediately reverted in unstable.
 
 i disagree.

If you are not going to revert this, then please tell me what
you are going to do to fix this, today.  Leaving people's
systems in a broken state is not on.  It must be fixed, and
fixed very quickly.  There are lots of people who can't boot
their computers thanks to this recklessness.

Please, revert it today.


Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130306205125.gb17...@codelibre.net



Re: Bug#701936: btrfs can't fsck /run/rootdev on boot

2013-03-06 Thread Roger Leigh
On Wed, Mar 06, 2013 at 10:41:05PM +0100, Daniel Baumann wrote:
 On 03/06/2013 09:51 PM, Roger Leigh wrote:
  3) fsck.btrfs does not support the standard fsck options
 
  easy fixable, but hasn't much to do with the current remaining problem
  in sid.
  
  Yes, it does.
 
 no, it does not.
 
 even if fsck.btrfs ignores all required options, it still fails because
 of sysvinits /run/rootdev.
 
  4) fsck.btrfs error codes
 
  I haven't tested this due to point (2) above
 
  me neither, but that's easy fixable too and hasn't much to do with the
  current remaining problem in sid.
  
  Yes, it does.
 
 no, it does not.
 
 even if fsck.btrfs returns equal values, it still fails because of
 sysvinits /run/rootdev.

When the /run/rootdev issue is fixed, all of the above are
points of failure.  Both point (2) and (3) in my original mail
*are* failure points *right now*, while (4) is potential.  I've
personally tested (2) and (3), and they do fail.  Thus fixing
the /run/rootdev issue (which is really also a Btrfs bug), is
only fixing the first problem.  The others are just as serious.

  You broke booting with the default init system for all people using a
  btrfs rootfs.
 
 keep in mind that eventhough it is not desirable nor intended, bugs do
 happen. also in unstable.

This one was totally avoidable.  It happened because you didn't
do your job, and you didn't respect the code freeze.  I have
wasted three nights working on this now, time which I wanted to
spend on fixing issues for the release, and which has instead
been spent on this.  And during all this time, lots of other
people have been suffering the consequences of this.

 unrelated to that, i would appreciate if you could calm down your tone a
 bit, it is more productive that way, thank you.

Err, we do have a very serious problem here.  Systems will no
longer boot.  If I appear frustrated about the situation, it's
because I am frustrated.  You don't appear to be very concerned
about the very real breakage caused here.

Please could you answer the question in my previous email which
you appear to not have addressed:

What are you going to do to rectify this?
Are you going to revert to the previous version?


Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130306215928.go23...@codelibre.net



Re: Bug#701936: btrfs can't fsck /run/rootdev on boot

2013-03-06 Thread Roger Leigh
severity 701936 critical
thanks

This is a critical bug.  Please do not lower the severity again.


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130306220803.gp23...@codelibre.net



Bug#699019: Bug#693387: Pre-approval for unblock: sysvinit/2.88dsf-35

2013-02-06 Thread Roger Leigh
On Sat, Jan 26, 2013 at 01:51:21PM +, Jonathan Wiltshire wrote:
 On Sat, Jan 26, 2013 at 01:17:44PM +, Roger Leigh wrote:
  (Using the new bug number)
  
  On Sat, Jan 26, 2013 at 12:14:59PM +, Jonathan Wiltshire wrote:
   Control: tag -1 + moreinfo
   
   On Thu, Nov 15, 2012 at 10:32:19PM +, Roger Leigh wrote:
Please unblock package sysvinit

The attached debdiff includes a correction to the init script
dependencies for the three bootclean scripts.  (#677097)
   
   Is this request still relevant for wheezy? -35 has been superceded in
   unstable with non-RC changes, so a fix will need to go through tpu now.
  
  Which changes were non-RC?  I don't think there are any changes
  here which do not cause failure on upgrade or at boot time,
  other than a single translation update.
 
 Ah, I went by e.g. the severity of #697537 (minor), I didn't take a deep
 look into the changes themselves.

I've attached a debdiff for 2.88dsf-40.  This contains a some
small changes to the sysvinit postinst to correct some problems
identifying and signalling init on Hurd and when using LXC
containers, which were not fully addressed in the previous
upload.  It should now be completely robust when restarting
for all use cases.

I'm away until Monday the 11th from now, but if there are any
issues with this, I'll be happy to look into them next week.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
diff -Nru sysvinit-2.88dsf/debian/changelog sysvinit-2.88dsf/debian/changelog
--- sysvinit-2.88dsf/debian/changelog   2012-11-16 20:51:07.0 +
+++ sysvinit-2.88dsf/debian/changelog   2013-02-03 16:35:09.0 +
@@ -1,3 +1,70 @@
+sysvinit (2.88dsf-40) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * Don't restart init on GNU/Hurd (Closes: #663009).
+  * Handle PID detection more robustly, to work better with containers
+(Closes: #699523).  Always use PID1, which avoids the need for
+fragile pidof usage.
+  * Handle ischroot more gracefully on failure (Closes: #699566).
+
+ -- Roger Leigh rle...@debian.org  Sun, 03 Feb 2013 14:52:05 +
+
+sysvinit (2.88dsf-39) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * initscripts postinst calls urandom, not urandom.sh (Closes: #698966).
+  * sysvinit postinst unconditionally creates a compatibility initctl
+link to ensure the migration to /run won't fail (Closes: #663009).
+
+ -- Roger Leigh rle...@debian.org  Sat, 26 Jan 2013 12:09:29 +
+
+sysvinit (2.88dsf-38) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * If pidof fails in the sysvinit postinst or initscripts, default
+to PID 1 (for /sbin/init) (Closes: #663009).
+  * Make fstab globbing in initscripts completely robust.
+
+ -- Roger Leigh rle...@debian.org  Wed, 23 Jan 2013 22:43:55 +
+
+sysvinit (2.88dsf-37) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts: Remove all use of shell heredocs in shell libraries;
+these require a writable /tmp which will not be guaranteed to be
+present in early boot (Closes: #697994).
+
+ -- Roger Leigh rle...@debian.org  Mon, 14 Jan 2013 21:53:59 +
+
+sysvinit (2.88dsf-36) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts:
+- Handle globbing of /etc/fstab.d/* safely.
+- Correct erroneous error that an entry for /dev/shm existed in
+  /etc/fstab when no entry was present (Closes: #697537).
+
+ -- Roger Leigh rle...@debian.org  Fri, 11 Jan 2013 23:36:28 +
+
+sysvinit (2.88dsf-35) unstable; urgency=low
+
+  [ David Prévot ]
+  * Fix German translation charset.
+
+  [ Roger Leigh ]
+  * initscripts:
+- To permit enabling of dependency-based boot, add Breaks on older
+  versions of bootchart.  Thanks to Andreas Beckmann.
+  Closes: #694252.
+- To work around a bug in the Oracle database, which has a faulty
+  check for /dev/shm, continue to mount a tmpfs on /dev/shm rather
+  than /run/shm if one is defined in /etc/fstab.  Closes: #694379.
+  * sysvinit-utils:
+- Add Breaks: upstart ( 1.5-1) to avoid breaking the boot with
+  older versions of upstart.  Closes: #694961.
+
+ -- Roger Leigh rle...@debian.org  Mon, 17 Dec 2012 22:50:49 +
+
 sysvinit (2.88dsf-34) unstable; urgency=low
 
   [ Roger Leigh ]
diff -Nru sysvinit-2.88dsf/debian/control sysvinit-2.88dsf/debian/control
--- sysvinit-2.88dsf/debian/control 2012-08-31 21:14:04.0 +0100
+++ sysvinit-2.88dsf/debian/control 2012-12-17 22:37:45.0 +
@@ -42,6 +42,7 @@
 Conflicts: last, sysvconfig, chkconfig ( 11.0-79.1-2)
 Replaces: last, sysvinit (= 2.86.ds1-65)
 Depends: ${shlibs:Depends}, ${misc:Depends}
+Breaks: upstart ( 1.5-1)
 Suggests: bootlogd, sash
 Description: System-V-like utilities
  This package contains the important System-V-like utilities.
@@ -74,7 +75,8

Bug#699019: unblock: sysvinit/2.88dsf-38

2013-01-26 Thread Roger Leigh
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package sysvinit

Bugs closed:
#694961: Don't break boot with older upstart versions
#694252: Break older bootchart versions to allow migration to
 dependency-based boot
#694379: Work around a bug in the Oracle database which has a
 buggy check for /dev/shm
#697537: Correct buggy check for /dev/shm
#697994: Remove all use of heredocs (not safe until /tmp is writable)
#663009: Default to PID1 when determining PID of init so that the
 init process is correctly restarted on upgrade
And fix globbing in /etc/fstab.d (no bug number).


Thanks,
Roger


diff -Nru sysvinit-2.88dsf/debian/changelog sysvinit-2.88dsf/debian/changelog
--- sysvinit-2.88dsf/debian/changelog   2012-11-16 20:51:07.0 +
+++ sysvinit-2.88dsf/debian/changelog   2013-01-24 21:33:09.0 +
@@ -1,3 +1,50 @@
+sysvinit (2.88dsf-38) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * If pidof fails in the sysvinit postinst or initscripts, default
+to PID 1 (for /sbin/init) (Closes: #663009).
+  * Make fstab globbing in initscripts completely robust.
+
+ -- Roger Leigh rle...@debian.org  Wed, 23 Jan 2013 22:43:55 +
+
+sysvinit (2.88dsf-37) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts: Remove all use of shell heredocs in shell libraries;
+these require a writable /tmp which will not be guaranteed to be
+present in early boot (Closes: #697994).
+
+ -- Roger Leigh rle...@debian.org  Mon, 14 Jan 2013 21:53:59 +
+
+sysvinit (2.88dsf-36) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts:
+- Handle globbing of /etc/fstab.d/* safely.
+- Correct erroneous error that an entry for /dev/shm existed in
+  /etc/fstab when no entry was present (Closes: #697537).
+
+ -- Roger Leigh rle...@debian.org  Fri, 11 Jan 2013 23:36:28 +
+
+sysvinit (2.88dsf-35) unstable; urgency=low
+
+  [ David Prévot ]
+  * Fix German translation charset.
+
+  [ Roger Leigh ]
+  * initscripts:
+- To permit enabling of dependency-based boot, add Breaks on older
+  versions of bootchart.  Thanks to Andreas Beckmann.
+  Closes: #694252.
+- To work around a bug in the Oracle database, which has a faulty
+  check for /dev/shm, continue to mount a tmpfs on /dev/shm rather
+  than /run/shm if one is defined in /etc/fstab.  Closes: #694379.
+  * sysvinit-utils:
+- Add Breaks: upstart ( 1.5-1) to avoid breaking the boot with
+  older versions of upstart.  Closes: #694961.
+
+ -- Roger Leigh rle...@debian.org  Mon, 17 Dec 2012 22:50:49 +
+
 sysvinit (2.88dsf-34) unstable; urgency=low
 
   [ Roger Leigh ]
diff -Nru sysvinit-2.88dsf/debian/control sysvinit-2.88dsf/debian/control
--- sysvinit-2.88dsf/debian/control 2012-08-31 21:14:04.0 +0100
+++ sysvinit-2.88dsf/debian/control 2012-12-17 22:37:45.0 +
@@ -42,6 +42,7 @@
 Conflicts: last, sysvconfig, chkconfig ( 11.0-79.1-2)
 Replaces: last, sysvinit (= 2.86.ds1-65)
 Depends: ${shlibs:Depends}, ${misc:Depends}
+Breaks: upstart ( 1.5-1)
 Suggests: bootlogd, sash
 Description: System-V-like utilities
  This package contains the important System-V-like utilities.
@@ -74,7 +75,8 @@
  sysvinit-utils (= 2.86.ds1-64), sysv-rc | file-rc,
  coreutils (= 5.93)
 Recommends: psmisc, e2fsprogs
-Conflicts: libdevmapper1.02.1 ( 2:1.02.24-1)
+Conflicts:
+ libdevmapper1.02.1 ( 2:1.02.24-1),
 Replaces: libc6, libc6.1, libc0.1, libc0.3
 Breaks:
 # Needed for ifquery
@@ -112,7 +114,9 @@
  autofs ( 5.0.0),
 # Older versions of initramfs-tools can't cope with /etc/mtab
 # being a symlink #668616 and #668650
- initramfs-tools ( 0.104)
+ initramfs-tools ( 0.104),
+# Needed for transition to dependency-based boot for wheezy
+ bootchart ( 0.10~svn407-3.3)
 Description: scripts for initializing and shutting down the system
  The scripts in this package initialize a standard Debian
  system at boot time and shut it down at halt or reboot time.
diff -Nru sysvinit-2.88dsf/debian/po/de.po sysvinit-2.88dsf/debian/po/de.po
--- sysvinit-2.88dsf/debian/po/de.po2012-08-31 21:14:04.0 +0100
+++ sysvinit-2.88dsf/debian/po/de.po2012-12-10 23:03:45.0 +
@@ -21,7 +21,7 @@
 #: ../sysv-rc.templates:1001
 msgid Unable to migrate to dependency-based boot system
 msgstr 
-Es konnte nicht auf abhängigkeitsbasierte Systemstartreihenfolge umgestellt 
+Es konnte nicht auf abhängigkeitsbasierte Systemstartreihenfolge umgestellt 
 werden.
 
 #. Type: note
@@ -32,7 +32,7 @@
 dependency-based boot sequencing:
 msgstr 
 Im Startsystem gibt es Probleme, die eine Umstellung auf 
-abhängigkeitsbasierte Systemstartreihenfolge verhindern:
+abhängigkeitsbasierte Systemstartreihenfolge verhindern:
 
 #. Type: note
 #. Description
@@ -43,10 +43,10 @@
 package has been removed, but not purged.  It is suggested that these are 
 removed by running:
 msgstr 
-Falls das gemeldete Problem von einer lokalen Ã

Bug#699019: unblock: sysvinit/2.88dsf-38

2013-01-26 Thread Roger Leigh
On Sat, Jan 26, 2013 at 12:42:25PM +, Adam D. Barratt wrote:
 Control: block -1 by 686387
 
 On Thu, 2013-01-24 at 22:03 +, Roger Leigh wrote:
  Please unblock package sysvinit
  
  Bugs closed:
  #694961: Don't break boot with older upstart versions
 
 For reference, this means that either the new upstart (and associated
 packages including large json-c diff) need to migrate - see #686387 - at
 the same time, or we need to find some other solution to the issue in
 upstart.

CCing Steve, since I'm unsure of the best course of action here.
I'm not too familiar with the upstart integration, and if there's
a way of solving the issue without the Breaks by
adding/modifying/removing some of that logic, we could look at
doing that.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130126131252.gp16...@codelibre.net



Bug#699019: Bug#693387: Pre-approval for unblock: sysvinit/2.88dsf-35

2013-01-26 Thread Roger Leigh
(Using the new bug number)

On Sat, Jan 26, 2013 at 12:14:59PM +, Jonathan Wiltshire wrote:
 Control: tag -1 + moreinfo
 
 On Thu, Nov 15, 2012 at 10:32:19PM +, Roger Leigh wrote:
  Please unblock package sysvinit
  
  The attached debdiff includes a correction to the init script
  dependencies for the three bootclean scripts.  (#677097)
 
 Is this request still relevant for wheezy? -35 has been superceded in
 unstable with non-RC changes, so a fix will need to go through tpu now.

Which changes were non-RC?  I don't think there are any changes
here which do not cause failure on upgrade or at boot time,
other than a single translation update.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130126131744.gq16...@codelibre.net



Bug#699019: Increase severity of RC bugs in sysvinit

2013-01-26 Thread Roger Leigh
severity 694252 serious
severity 697537 important
severity 697994 serious

thanks

694252 prevents transition to dependency-based boot
697537 is a bug mounting /dev/shm; it's not strictly doing the wrong
   thing, but tells the user that there's a boot time error
   when there isn't a problem.  This makes the user think that
   something critical failed when in fact it didn't.
697994 errors at boot due to the fact that in bash, shell heredocs
   require a writable /tmp while in dash they do not; we can't
   therefore use heredocs until after /tmp is available
697994 failure to restart init on upgrade; the fix in this unblock
   request does not solve all failure cases; an additional
   upload will be required.

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130126134947.gr16...@codelibre.net



Bug#699019: unblock: sysvinit/2.88dsf-38

2013-01-26 Thread Roger Leigh
retitle 699019 unblock: sysvinit/2.88dsf-39
severity 698966 serious
thanks

I uploaded -39 to properly fix #663009, and to also fix
#698966 which is a failure to run urandom, including during
debootstrapping (#698909).  Updated debdiff attached.


unblock sysvinit/2.88dsf-39


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
diff -Nru sysvinit-2.88dsf/debian/changelog sysvinit-2.88dsf/debian/changelog
--- sysvinit-2.88dsf/debian/changelog   2012-11-16 20:51:07.0 +
+++ sysvinit-2.88dsf/debian/changelog   2013-01-26 12:38:01.0 +
@@ -1,3 +1,59 @@
+sysvinit (2.88dsf-39) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * initscripts postinst calls urandom, not urandom.sh (Closes: #698966).
+  * sysvinit postinst unconditionally creates a compatibility initctl
+link to ensure the migration to /run won't fail (Closes: #663009).
+
+ -- Roger Leigh rle...@debian.org  Sat, 26 Jan 2013 12:09:29 +
+
+sysvinit (2.88dsf-38) unstable; urgency=low
+
+  [ Roger Leigh ]:
+  * If pidof fails in the sysvinit postinst or initscripts, default
+to PID 1 (for /sbin/init) (Closes: #663009).
+  * Make fstab globbing in initscripts completely robust.
+
+ -- Roger Leigh rle...@debian.org  Wed, 23 Jan 2013 22:43:55 +
+
+sysvinit (2.88dsf-37) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts: Remove all use of shell heredocs in shell libraries;
+these require a writable /tmp which will not be guaranteed to be
+present in early boot (Closes: #697994).
+
+ -- Roger Leigh rle...@debian.org  Mon, 14 Jan 2013 21:53:59 +
+
+sysvinit (2.88dsf-36) unstable; urgency=low
+
+  [ Roger Leigh ]
+  * initscripts:
+- Handle globbing of /etc/fstab.d/* safely.
+- Correct erroneous error that an entry for /dev/shm existed in
+  /etc/fstab when no entry was present (Closes: #697537).
+
+ -- Roger Leigh rle...@debian.org  Fri, 11 Jan 2013 23:36:28 +
+
+sysvinit (2.88dsf-35) unstable; urgency=low
+
+  [ David Prévot ]
+  * Fix German translation charset.
+
+  [ Roger Leigh ]
+  * initscripts:
+- To permit enabling of dependency-based boot, add Breaks on older
+  versions of bootchart.  Thanks to Andreas Beckmann.
+  Closes: #694252.
+- To work around a bug in the Oracle database, which has a faulty
+  check for /dev/shm, continue to mount a tmpfs on /dev/shm rather
+  than /run/shm if one is defined in /etc/fstab.  Closes: #694379.
+  * sysvinit-utils:
+- Add Breaks: upstart ( 1.5-1) to avoid breaking the boot with
+  older versions of upstart.  Closes: #694961.
+
+ -- Roger Leigh rle...@debian.org  Mon, 17 Dec 2012 22:50:49 +
+
 sysvinit (2.88dsf-34) unstable; urgency=low
 
   [ Roger Leigh ]
diff -Nru sysvinit-2.88dsf/debian/control sysvinit-2.88dsf/debian/control
--- sysvinit-2.88dsf/debian/control 2012-08-31 21:14:04.0 +0100
+++ sysvinit-2.88dsf/debian/control 2012-12-17 22:37:45.0 +
@@ -42,6 +42,7 @@
 Conflicts: last, sysvconfig, chkconfig ( 11.0-79.1-2)
 Replaces: last, sysvinit (= 2.86.ds1-65)
 Depends: ${shlibs:Depends}, ${misc:Depends}
+Breaks: upstart ( 1.5-1)
 Suggests: bootlogd, sash
 Description: System-V-like utilities
  This package contains the important System-V-like utilities.
@@ -74,7 +75,8 @@
  sysvinit-utils (= 2.86.ds1-64), sysv-rc | file-rc,
  coreutils (= 5.93)
 Recommends: psmisc, e2fsprogs
-Conflicts: libdevmapper1.02.1 ( 2:1.02.24-1)
+Conflicts:
+ libdevmapper1.02.1 ( 2:1.02.24-1),
 Replaces: libc6, libc6.1, libc0.1, libc0.3
 Breaks:
 # Needed for ifquery
@@ -112,7 +114,9 @@
  autofs ( 5.0.0),
 # Older versions of initramfs-tools can't cope with /etc/mtab
 # being a symlink #668616 and #668650
- initramfs-tools ( 0.104)
+ initramfs-tools ( 0.104),
+# Needed for transition to dependency-based boot for wheezy
+ bootchart ( 0.10~svn407-3.3)
 Description: scripts for initializing and shutting down the system
  The scripts in this package initialize a standard Debian
  system at boot time and shut it down at halt or reboot time.
diff -Nru sysvinit-2.88dsf/debian/initscripts.postinst 
sysvinit-2.88dsf/debian/initscripts.postinst
--- sysvinit-2.88dsf/debian/initscripts.postinst2012-11-16 
15:33:58.0 +
+++ sysvinit-2.88dsf/debian/initscripts.postinst2013-01-26 
12:08:54.0 +
@@ -561,9 +561,9 @@
 if [ $PREV_VER =  ]; then
if which invoke-rc.d /dev/null 21
then
-   invoke-rc.d urandom.sh start || true
+   invoke-rc.d urandom start || true
else
-   /etc/init.d/urandom.sh start || true
+   /etc/init.d/urandom start || true
fi
 fi
 
diff -Nru sysvinit-2.88dsf/debian/po/de.po sysvinit-2.88dsf/debian/po/de.po
--- sysvinit-2.88dsf/debian/po/de.po2012-08-31 21:14:04.0 +0100

Query: Can #694986 be fixed or ignored?

2013-01-26 Thread Roger Leigh
On ARM arches, the flash-kernel postinst modifies /etc/default/rcS
to set FSCKFIX=yes.  However, this is now modifying a conffile and
so buggy.

In the bug, I have a patch to get flash-kernel to update
/etc/default/fsck instead, and I would propose to add a new
configuration file, /etc/default/fsck, to contain the settings for
boot time fsck options.  This change would be in initscripts.

Given that it's quite late in the freeze, I just wanted to check
if this change would be acceptable at this point, or if the bug
could be ignored for wheezy?  The impact is low: it only affects
arm arches, and the only effect is a dpkg conffile prompt.

In general, setting FSCKFIX=yes on a per-arch basis is not correct;
not all ARM systems are embedded, likewise other arches need it but
don't set it by default.  Something other than arch needs to determine
the default setting.  Also, if it's something the user/installer
chooses, then is modifying a conffile acceptable in this case; other
tools do this on the user's behalf.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20130126213928.gb29...@codelibre.net



jessie release goal: Mount /usr in the initramfs

2012-12-30 Thread Roger Leigh
As requested on the wiki, I'm mailing the details of this proposed
release goal to -release.

The proposal draft is here:
http://wiki.debian.org/ReleaseGoals/MountUsrInInitramfs

The following is just a text copy of the above page:

Mount /usr in the initramfs
===

Introduction


Traditionally, /usr has been mounted in mountall, as for any filesystem
in /etc/fstab other than the root filesystem (or special filesystems
like /proc and /dev). This has several implications:

 • Programs, libraries and data under /usr are not available in the
   early stages of booting
 • Programs in /bin and /sbin can not assume /usr is available
 • init scripts need to cope with /usr being unavailable in early boot
 • This causes particular problems with shared libraries, PAM modules,
   NSS module dependencies, etc. as well as locale availability. 

If /usr could be guaranteed to be available by mounting it in the
initramfs, these problems can also be overcome. This permits all shared
libraries, PAM modules, NSS modules etc. to function at once. It also
allows locales to be used at once as well. Additionally, it is possible
to use C++ (libstdc++ is under /usr), and interpreters such as perl and
python, etc. In short, it makes a large number of things possible which
were previously not possible, and this will both allow greater
flexibility in what can run in the early stages of booting, as well as
removing a large number of special cases and hairy logic which existed
solely to cope with /usr not being available.

Initial implementation
--

The change to the initramfs is fairly simple. Once the root filesystem
is mounted, the /etc/fstab on the root filesystem can be read, and then
if it contains an entry for /usr, we mount it.

The -R option of /sbin/fsck, used to check all filesystems except the
root filesystem needs updating so that it will also ignore /usr, or
else at boot the checkfs script will try to fsck a mounted /usr.

The initscripts themselves need updating to treat /usr like the root
filesystem

 • Remount r/o
 • Check
 • Remount r/w
 • Remount r/o at shutdown and don't umount 

Caveats
---

The main caveat is that if you use a separately mounted /usr, you must
use an initramfs to mount it. While not using an initramfs will
continue to be supported, this will only work if you have /usr on the
root filesystem (i.e. it's a single mount). This is because mounting
/usr in the traditional way will cause startup to fail since it's
mounted too late (this will only happen once init scripts start relying
on /usr to be available immediately).

┌───┬──┐
│ initramfs │ No initramfs │
┌───┼───┼──┤
│ root only │ Supported │ Supported│
├───┼───┼──┤
│ root and /usr │ Supported │ Broken   │
└───┴───┴──┘

The initramfs will support / and /usr mounts on local/local and
nfs/nfs. However, it it not yet clear if this will extend to local/nfs
and/or nfs/local.

Required changes


 • Update initramfs to mount /usr
 • Update util-linux to skip /usr with the -R option (#697002)
 • Update initscripts to fsck /usr in checkroot and remount r/o when
   shutting down 


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121230184839.gu3...@codelibre.net



Bug#691647: unblock: schroot/1.6.4-1

2012-12-09 Thread Roger Leigh
On Sat, Nov 10, 2012 at 10:23:10AM +, Roger Leigh wrote:
 On Tue, Oct 30, 2012 at 08:24:51PM +, Roger Leigh wrote:
  On Sun, Oct 28, 2012 at 12:53:08PM +, Roger Leigh wrote:
   On Sun, Oct 28, 2012 at 12:39:28AM +0100, Roger Leigh wrote:
Please unblock package schroot

I have uploaded schroot 1.6.4-1 to unstable.  This contains some
documentation for wheezy upgrade issues, plus some fixes for
serious and important bugs in wheezy:
   
   I had to make an additional 3 line change to fix building on
   hurd and kfreebsd (attached)
  
  And an additional change to allow for symlinks in paths on the
  host.
  
  unblock schroot/1.6.4-3
 
 I do have a further portablity patch for kfreebsd:
 
 http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot.git;a=commitdiff;h=73f9ab7ff14c348c262813fdd454132edf45ef5a
 http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot.git;a=commitdiff;h=9bc4e6abef18fcb16ba8bf579dfa6946657cbfac
 
 but I was holding off on uploading it without any feedback
 regarding the above unblock request.
 
 This patch is needed to allow sbuild to work on kfreebsd.
 Without it, there are no device nodes (fatal) and no scratch
 space for building.

I've now uploaded this additional bugfix, patch follows.

All of the changes since 1.6.3-1 in testing to 1.6.4-1 in unstable
are here:
  
http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-1.6

If some of the included changes here are too big, I'll be happy to
make an upload of a subset of the changes to testing-proposed-updates,
but I do need some feedback in order to start doing that.
There are a number of bugs fixed here:

692213: essential for kFreeBSD
686148,691694: security issue
#688304: cosmetic but annoying
#689078: broken environment; breaks buildd setup scripts; not
 critical, but breaks interface.  Required refactoring to
 fix, which results in the bulk of the diff
#691376: mounts wrong filesystem on recovery.

And it also fixes a number of other issues including locking and
upgrade notes.


Regards,
Roger


diff --git a/debian/changelog b/debian/changelog
index 03decda..8ecb116 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+schroot (1.6.4-4) unstable; urgency=low
+
+  * schroot: Add sbuild profile fstab file for freebsd
+(Closes: #692213).  This mounts /dev, /dev/fd and /build.
+
+ -- Roger Leigh rle...@debian.org  Sat, 03 Nov 2012 15:19:16 +
+
 schroot (1.6.4-3) unstable; urgency=low
 
   * schroot-mount canonicalises both the base path and full
diff --git a/etc/profile-templates/sbuild/freebsd/fstab 
b/etc/profile-templates/sbuild/freebsd/fstab
new file mode 100644
index 000..778bd42
--- /dev/null
+++ b/etc/profile-templates/sbuild/freebsd/fstab
@@ -0,0 +1,5 @@
+dev/devdevfs   rw,bind 0   0
+dev/dev/fd fdescfs rw,bind 0   0
+# Mount a large scratch space for the build, so we don't use up
+# space on an LVM snapshot of the chroot itself.
+/var/lib/sbuild/build  /build  nullfs  rw  0   0

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


schroot_1.6.3-1_1.6.4-4.debdiff.gz
Description: Binary data


Re: [buildd-tools-devel] Bug#687396: Bug#687396: Bug#687396: sbuild: building pyca fails silently

2012-12-06 Thread Roger Leigh
On Wed, Dec 05, 2012 at 02:25:45PM +, Roger Leigh wrote:
 On Wed, Dec 05, 2012 at 03:17:11PM +0100, Roland Stigge wrote:
  On 12/05/2012 03:11 PM, Roland Stigge wrote:
   But don't worry - it's just a minor change and at least fixes the issue
   for the protocol. ;-) So others won't be disturbed by it during bug
   squashing.
  
  So please consider sbuild 0.63.2-1.1 for wheezy (freeze exemption).
  (Maybe Roger will override the package which is now in the DELAYED queue.)
 
 I'd certainly want some careful testing first.  Are there any corner
 cases where this breaks anything?  I'll review it later in the week
 as I said earlier.  And do note that this does not match the behaviour
 on the buildds, so while it will fix things for local builds, it won't
 work on the buildds until the patch is committed into git and merged
 onto the buildd branch and then deployed.

I just saw this uploaded; I thought you said this was in DELAYED/5
yesterday?

Even small changes can do with some level of review and testing,
which I said yesterday I would do this week.  I don't think this
warranted such a high severity, nor NMUing it as I was replying
to your mail yesterday.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121206121500.gd14...@codelibre.net



Re: [buildd-tools-devel] Bug#687396: Bug#687396: sbuild: building pyca fails silently

2012-12-05 Thread Roger Leigh
On Wed, Dec 05, 2012 at 03:17:11PM +0100, Roland Stigge wrote:
 On 12/05/2012 03:11 PM, Roland Stigge wrote:
  But don't worry - it's just a minor change and at least fixes the issue
  for the protocol. ;-) So others won't be disturbed by it during bug
  squashing.
 
 So please consider sbuild 0.63.2-1.1 for wheezy (freeze exemption).
 (Maybe Roger will override the package which is now in the DELAYED queue.)

I'd certainly want some careful testing first.  Are there any corner
cases where this breaks anything?  I'll review it later in the week
as I said earlier.  And do note that this does not match the behaviour
on the buildds, so while it will fix things for local builds, it won't
work on the buildds until the patch is committed into git and merged
onto the buildd branch and then deployed.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121205142545.gc14...@codelibre.net



Bug#694107: unblock: insserv/1.14.0-5

2012-11-23 Thread Roger Leigh
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package insserv

Closes #693371.  This corrects the dependencies for the $local_fs
runlevel, which prevents /run being cleaned out of order, causing
the udev state to be removed, and consequent problems.  This has
also been fixed additionally in sysvinit, but having this
explicitly in the system facility makes things much more robust.


Thanks,
Roger

unblock insserv/1.14.0-5

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.32.33-kvm-i386-2028-dirty (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20121123230930.29412.85467.report...@nagini.codelibre.net



Bug#693387: Pre-approval for unblock: sysvinit/2.88dsf-33

2012-11-16 Thread Roger Leigh
On Fri, Nov 16, 2012 at 01:48:43AM +0100, Michael Biebl wrote:
 On 15.11.2012 23:32, Roger Leigh wrote:
  Package: release.debian.org
  Severity: normal
  User: release.debian@packages.debian.org
  Usertags: unblock
  
  Please unblock package sysvinit
  
  The attached debdiff includes a correction to the init script
  dependencies for the three bootclean scripts.  (#677097)
 
 Why did you choose to not simply add mountall-bootclean to $local_fs?
 
 This would appear like the more obvious fix to me.

I have done that as well for safety.  But having the dependencies
correct in the script is also important, IMO.  See: #693371.  I'd
rather have it changed in both, so that if a user chooses e.g. not
to update their initscripts, the system is not rendered unbootable
or broken at boot.  It reduces the likelihood at any rate.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121116103042.gu...@codelibre.net



Bug#693387: Pre-approval for unblock: sysvinit/2.88dsf-33

2012-11-16 Thread Roger Leigh
On Fri, Nov 16, 2012 at 02:11:13AM +0100, Michael Biebl wrote:
 On 16.11.2012 01:48, Michael Biebl wrote:
  On 15.11.2012 23:32, Roger Leigh wrote:
  Package: release.debian.org
  Severity: normal
  User: release.debian@packages.debian.org
  Usertags: unblock
 
  Please unblock package sysvinit
 
  The attached debdiff includes a correction to the init script
  dependencies for the three bootclean scripts.  (#677097)
  
  Why did you choose to not simply add mountall-bootclean to $local_fs?
  
 
 As already mentioned on IRC: checkroot-bootclean is kinda odd.
 It cleans up /run/, /run/lock *after* the tmpfs has been mounted, so
 this cleanup looks entirely pointless.

The main point of this script was to clean /tmp prior to mounting a
tmpfs, as well as /lib/init/rw (for historical reasons).  It also
handles cleaning of /run and /run/lock; for platforms which don't
support a tmpfs, or where the admin has explicitly disabled tmpfs
mounting.

 An for cleaning up /tmp in checkroot-bootclean: Since the goal here is
 to cleanup /tmp before it is later shadowed by a mount (via mountall),
 the mountall script should have a dependency on checkroot-bootclean.
 Otherwise it can happen that you mount /tmp while the cleanup is still
 running. Or am I missing something?

No, I think you're correct.  This also needs a dependency.
Required-Start: checkroot-bootclean
in mountall should address this.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121116103723.gv...@codelibre.net



Bug#691647: unblock: schroot/1.6.4-1

2012-11-10 Thread Roger Leigh
On Tue, Oct 30, 2012 at 08:24:51PM +, Roger Leigh wrote:
 On Sun, Oct 28, 2012 at 12:53:08PM +, Roger Leigh wrote:
  On Sun, Oct 28, 2012 at 12:39:28AM +0100, Roger Leigh wrote:
   Please unblock package schroot
   
   I have uploaded schroot 1.6.4-1 to unstable.  This contains some
   documentation for wheezy upgrade issues, plus some fixes for
   serious and important bugs in wheezy:
  
  I had to make an additional 3 line change to fix building on
  hurd and kfreebsd (attached)
 
 And an additional change to allow for symlinks in paths on the
 host.
 
 unblock schroot/1.6.4-3

I do have a further portablity patch for kfreebsd:

http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot.git;a=commitdiff;h=73f9ab7ff14c348c262813fdd454132edf45ef5a
http://anonscm.debian.org/gitweb/?p=buildd-tools/schroot.git;a=commitdiff;h=9bc4e6abef18fcb16ba8bf579dfa6946657cbfac

but I was holding off on uploading it without any feedback
regarding the above unblock request.

This patch is needed to allow sbuild to work on kfreebsd.
Without it, there are no device nodes (fatal) and no scratch
space for building.



Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121110102310.gg...@codelibre.net



Bug#691647: unblock: schroot/1.6.4-1

2012-10-30 Thread Roger Leigh
On Sun, Oct 28, 2012 at 12:53:08PM +, Roger Leigh wrote:
 On Sun, Oct 28, 2012 at 12:39:28AM +0100, Roger Leigh wrote:
  Please unblock package schroot
  
  I have uploaded schroot 1.6.4-1 to unstable.  This contains some
  documentation for wheezy upgrade issues, plus some fixes for
  serious and important bugs in wheezy:
 
 I had to make an additional 3 line change to fix building on
 hurd and kfreebsd (attached)

And an additional change to allow for symlinks in paths on the
host.

unblock schroot/1.6.4-3

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
diff -Nru schroot-1.6.4/debian/changelog schroot-1.6.4/debian/changelog
--- schroot-1.6.4/debian/changelog  2012-10-28 11:53:31.0 +
+++ schroot-1.6.4/debian/changelog  2012-10-29 20:06:47.0 +
@@ -1,3 +1,10 @@
+schroot (1.6.4-3) unstable; urgency=low
+
+  * schroot-mount canonicalises both the base path and full
+path when sanity checking mountpoints (Closes: #691694).
+
+ -- Roger Leigh rle...@debian.org  Mon, 29 Oct 2012 19:25:30 +
+
 schroot (1.6.4-2) unstable; urgency=low
 
   * sbuild::chroot_facet_session_clonable: Include
diff -Nru schroot-1.6.4/debian/patches/1.6.4-3 
schroot-1.6.4/debian/patches/1.6.4-3
--- schroot-1.6.4/debian/patches/1.6.4-31970-01-01 01:00:00.0 
+0100
+++ schroot-1.6.4/debian/patches/1.6.4-32012-10-29 20:07:33.0 
+
@@ -0,0 +1,41 @@
+Description: 1.6.4-3
+ schroot (1.6.4-3) unstable; urgency=low
+ .
+   * schroot-mount canonicalises both the base path and full
+ path when sanity checking mountpoints (Closes: #691694).
+Author: Roger Leigh rle...@debian.org
+Bug-Debian: http://bugs.debian.org/691694
+
+---
+--- schroot-1.6.4.orig/bin/schroot-mount/schroot-mount-main.cc
 schroot-1.6.4/bin/schroot-mount/schroot-mount-main.cc
+@@ -96,9 +96,15 @@ main::resolve_path (std::string const m
+   if (absmountpoint.empty() || absmountpoint[0] != '/')
+ absmountpoint = std::string(/) + absmountpoint;
+ 
++  char *resolved_path = realpath(opts-mountpoint.c_str(), 0);
++  if (!resolved_path)
++throw error(opts-mountpoint, REALPATH, strerror(errno));
++  std::string basepath(resolved_path);
++  std::free(resolved_path);
++
+   std::string directory(opts-mountpoint + absmountpoint);
+   // Canonicalise path to remove any symlinks.
+-  char *resolved_path = realpath(directory.c_str(), 0);
++  resolved_path = realpath(directory.c_str(), 0);
+   if (resolved_path == 0)
+ {
+   // The path is either not present or is an invalid link.  If
+@@ -137,9 +143,9 @@ main::resolve_path (std::string const m
+   // If the link was absolute (i.e. points somewhere on the host,
+   // outside the chroot, make sure that this is modified to be
+   // inside.
+-  if (directory.size()  opts-mountpoint.size() ||
+-  directory.substr(0,opts-mountpoint.size()) != opts-mountpoint)
+-directory = opts-mountpoint + directory;
++  if (directory.size()  basepath.size() ||
++  directory.substr(0,basepath.size()) != basepath)
++directory = basepath + directory;
+ 
+   return directory;
+ }
diff -Nru schroot-1.6.4/debian/patches/series 
schroot-1.6.4/debian/patches/series
--- schroot-1.6.4/debian/patches/series 2012-10-28 11:53:59.0 +
+++ schroot-1.6.4/debian/patches/series 2012-10-29 20:07:06.0 +
@@ -1 +1,2 @@
 1.6.4-2
+1.6.4-3


Bug#691647: unblock: schroot/1.6.4-1

2012-10-28 Thread Roger Leigh
On Sun, Oct 28, 2012 at 12:39:28AM +0100, Roger Leigh wrote:
 Please unblock package schroot
 
 I have uploaded schroot 1.6.4-1 to unstable.  This contains some
 documentation for wheezy upgrade issues, plus some fixes for
 serious and important bugs in wheezy:

I had to make an additional 3 line change to fix building on
hurd and kfreebsd (attached)


Thanks,
Roger

unblock schroot/1.6.4-2

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
diff -Nru schroot-1.6.4/debian/changelog schroot-1.6.4/debian/changelog
--- schroot-1.6.4/debian/changelog  2012-10-27 23:39:05.0 +0100
+++ schroot-1.6.4/debian/changelog  2012-10-28 11:53:31.0 +
@@ -1,3 +1,12 @@
+schroot (1.6.4-2) unstable; urgency=low
+
+  * sbuild::chroot_facet_session_clonable: Include
+sbuild-chroot-block-device-base.h, which was missing on
+kFreeBSD and Hurd builds (it's included indirectly on Linux
+via the LVM snapshot header).
+
+ -- Roger Leigh rle...@debian.org  Sun, 28 Oct 2012 11:49:57 +
+
 schroot (1.6.4-1) unstable; urgency=low
 
   * New upstream stable release.
diff -Nru schroot-1.6.4/debian/patches/1.6.4-2 
schroot-1.6.4/debian/patches/1.6.4-2
--- schroot-1.6.4/debian/patches/1.6.4-21970-01-01 01:00:00.0 
+0100
+++ schroot-1.6.4/debian/patches/1.6.4-22012-10-28 11:54:35.0 
+
@@ -0,0 +1,23 @@
+Description: 1.6.4-2
+ schroot (1.6.4-2) unstable; urgency=low
+ .
+   * sbuild::chroot_facet_session_clonable: Include
+ sbuild-chroot-block-device-base.h, which was missing on
+ kFreeBSD and Hurd builds (it's included indirectly on Linux
+ via the LVM snapshot header).
+Author: Roger Leigh rle...@debian.org
+
+---
+
+--- schroot-1.6.4.orig/sbuild/sbuild-chroot-facet-session-clonable.cc
 schroot-1.6.4/sbuild/sbuild-chroot-facet-session-clonable.cc
+@@ -24,6 +24,9 @@
+ #include sbuild-chroot-facet-session-clonable.h
+ #include sbuild-chroot-facet-source-clonable.h
+ #include sbuild-chroot-plain.h
++#ifdef SBUILD_FEATURE_BLOCKDEV
++#include sbuild-chroot-block-device-base.h
++#endif
+ #ifdef SBUILD_FEATURE_LVMSNAP
+ #include sbuild-chroot-lvm-snapshot.h
+ #endif // SBUILD_FEATURE_LVMSNAP
diff -Nru schroot-1.6.4/debian/patches/series 
schroot-1.6.4/debian/patches/series
--- schroot-1.6.4/debian/patches/series 1970-01-01 01:00:00.0 +0100
+++ schroot-1.6.4/debian/patches/series 2012-10-28 11:53:59.0 +
@@ -0,0 +1 @@
+1.6.4-2


Bug#691647: unblock: schroot/1.6.4-1

2012-10-27 Thread Roger Leigh
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package schroot

I have uploaded schroot 1.6.4-1 to unstable.  This contains some
documentation for wheezy upgrade issues, plus some fixes for
serious and important bugs in wheezy:

schroot (1.6.4-1) unstable; urgency=low

  * New upstream stable release.
  * NEWS: Provide guidance for wheezy upgrades with regard to
use of the profile key in a backward-compatible manner also
using setup.config, to mimic the behaviour of the deprecated
script-config key.
  * schroot.conf(5) additionally updated to document script-config
deprecation and use of user keys such as setup.config.
  * schroot-mount: Canonicalise mountpoints with symlinks to avoid
mounting absolute paths on the host rather than inside the chroot
(Closes: #686148).  Note the caveat regarding paths with multiple
symlinks in schroot-script-config(5).  This permits safe use of
symlinks as mountpoints in some common circumstances, e.g. on
/var/lock, which is a symlink to /run/lock, though this is not
recommended practice.
  * 15binfmt no longer pollutes output, by redirecting stderr from
which update-binfmts (Closes: #688304).
  * Ensure that CHROOT_ALIAS (setup scripts) and SCHROOT_ALIAS_NAME
(user environment) always refer to the alias used to create the
session (Closes: #689078).  The alias is no longer canonicalised
by sbuild::chroot_config::validate_chroots.  The logic for
chroot validation and information display in sbuild::chroot_config
and schroot::main_base (and derived classes) required refactoring
to allow the unresolved alias name to be passed through to the
session clone operation in sbuild::session, so that it could be
stored in the chroot's sbuild::chroot_facet_session facet.
  * On session recovery, mount the snapshot LV rather than the source
LV for LVM snapshot chroots (Closes: #691376).  The code which
sets the mount device for all mountable chroots (with an
sbuild::chroot_facet_mountable facet) is in
sbuild::chroot_facet_session_clonable::clone_session_setup().
All chroot types refactored to set the mount device here.
  * 10mount uses a lock directory /var/lock/schroot to contain its
lockfile, rather than directly using /var/lock, which is less
secure.

 -- Roger Leigh rle...@debian.org  Sat, 27 Oct 2012 23:30:38 +0100

debdiff attached.  Note that because two of the bugfixes required
some refactoring, the patch is large due to changing some method
signatures and moving code around; I also updated the testsuite and
the po translations, which are the bulk of the diff.

unblock schroot/1.6.4-1

Thanks,
Roger


schroot_1.6.3-1..schroot_1.6.4-1.debdiff.xz
Description: application/xz


Pre-approval for schroot update in wheezy and squeeze

2012-10-15 Thread Roger Leigh
Hi,

I'd like to make an upload to unstable to address a number of
problems reported in schroot, which I would like to fix in
a point release (1.6.4-1), and have this migrate to testing.
These selected changes have been backported to the schroot-1.6
stable branch from the development branch.

  Changes: http://people.debian.org/~rleigh/schroot/schroot_1.6.4-1.dsc
  Diff: http://people.debian.org/~rleigh/schroot/schroot-1.6.4.patch

Changes:
* Documentation.  NEWS.Debian and some manpages updated to provide
  guidance for upgrading to wheezy.  Needed to update the configuration
  to retain full backward compatibility with the changes to the
  configuration file format.
* #686148.  This is quite serious.  A filesystem mountpoint inside
  the chroot which is a symlink can redirect the mount to be
  mounted on the host.  This is corrected by using realpath(3) to
  use only absolute paths and to ensure that the mountpoint is
  inside the chroot.
* #689078.  The CHROOT_ALIAS and SCHROOT_ALIAS_NAME environment
  variables were being set to the canonicalised chroot name rather
  than the alias used to create the session.  This could lead to
  misbehaviour of scripts relying upon these values, such as the
  Debian autobuilders, which can use these to customise the build
  environment.
* #688304.  Don't spew warnings in 15binfmt if the binfmt-support
  package is not installed.  Only cosmetic (just redirected stderr to
  null), but quite annoying.

(there are also some po file deltas due to the source file changes;
if OK, I may also get translator updates for these prior to upload.)

Additionally, I would also like to backport the fixes for #686148
and #689078 to squeeze and squeeze-backports for fixing in a stable
point release if possible.  I already ran #686148 past the security
team, who said it wasn't severe enough for a security update, but
would probably be OK for a point release.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20121015223835.gq18...@codelibre.net



Bug#685278: unblock: sysvinit/2.88dsf-32

2012-08-31 Thread Roger Leigh
On Sun, Aug 19, 2012 at 09:25:19AM +0100, Roger Leigh wrote:
 Package: release.debian.org
 Severity: normal
 User: release.debian@packages.debian.org
 Usertags: unblock
 
 Please unblock package sysvinit
 
 sysvinit in unstable fixes a large number of bugs:
  55707 232569 353229 385172 386368 403863 437176 438895 518249
 539261 540448 543793 545401 545438 550425 558000 562500 567539
 585540 587923 596284 596479 596480 596481 596482 596483 614895
 623051 624391 625463 630615 634146 636054 637390 652625 659480
 659490 660824 660824 664816 665635 665995 98 666871 667745
 668307 668312 668650 669162 669949 670085 671124 674039 674178
 674208 674460 674517 676463 676473 676669 676721 676725 676773
 676791 676814 676893 676910 677011 677097 677333 677590 677753
 677904 678231 678627 678680 678878 679523 679612 679972 681639
 683103
 
 including these RC bugs:
 668307 670085 671124 674517 677097 683103
 (note: not all of these affect testing)

672959 685212

Now also fixed in addition to the above bugs with the upload of
2.88dsf-32.  This fixes all the outstanding RC issues in unstable.


unblock sysvinit/2.88dsf-32

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120831222518.ga3...@codelibre.net



Bug#685278: unblock: sysvinit/2.88dsf-32

2012-08-22 Thread Roger Leigh
On Sun, Aug 19, 2012 at 09:25:19AM +0100, Roger Leigh wrote:
 Please unblock package sysvinit
 
 sysvinit in unstable does contain two bugs marked RC:
 #679409: This only appears to affect upstart; it's not yet clear
  what the root cause of this is, or if it's actually a
  bug in this package.
 #672959: Affects kFreeBSD only.  And it's also present in testing.
  This is being investigated by the kFreeBSD porters, and
  will hopefully be fixed in a future upload.
 
 I don't think the presence of either of these bugs warrants delaying
 migration, since a lot of important bugs are fixed by migration, and
 they could certainly use wider testing before release.

#679409 is not a sysvinit bug; this has been moved to lightdm.
#672959 has been fixed thanks to the effors of the kfreebsd porters,
with fixed packages being here:
  http://people.debian.org/~rleigh/sysvinit/sysvinit_2.88dsf-33.dsc
  (also fixed in git)

sysvinit 2.88dsf-32 is just coming up to being 10 days old.  I can
upload the -33 with the above fix now, or wait until -32 has
migrated, depending upon what you want.

I also have a couple of patches which add update-rc.d/invoke-rc.d
support for systemd, which are currently queued here:
  
http://anonscm.debian.org/gitweb/?p=collab-maint/sysvinit;a=shortlog;h=refs/heads/jessie-pending
Having update-rc.d and invoke-rc.d support systemd in addition to
sysvinit and upstart is quite important for systemd integration with
Debian.  If the release team could give the go-ahead, I can pull
these into -33 (or -34).


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120822074755.gf22...@codelibre.net



Bug#685278: unblock: sysvinit/2.88dsf-32

2012-08-19 Thread Roger Leigh
Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package sysvinit

sysvinit in unstable fixes a large number of bugs:
 55707 232569 353229 385172 386368 403863 437176 438895 518249
539261 540448 543793 545401 545438 550425 558000 562500 567539
585540 587923 596284 596479 596480 596481 596482 596483 614895
623051 624391 625463 630615 634146 636054 637390 652625 659480
659490 660824 660824 664816 665635 665995 98 666871 667745
668307 668312 668650 669162 669949 670085 671124 674039 674178
674208 674460 674517 676463 676473 676669 676721 676725 676773
676791 676814 676893 676910 677011 677097 677333 677590 677753
677904 678231 678627 678680 678878 679523 679612 679972 681639
683103

including these RC bugs:
668307 670085 671124 674517 677097 683103
(note: not all of these affect testing)

sysvinit in unstable does contain two bugs marked RC:
#679409: This only appears to affect upstart; it's not yet clear
 what the root cause of this is, or if it's actually a
 bug in this package.
#672959: Affects kFreeBSD only.  And it's also present in testing.
 This is being investigated by the kFreeBSD porters, and
 will hopefully be fixed in a future upload.

I don't think the presence of either of these bugs warrants delaying
migration, since a lot of important bugs are fixed by migration, and
they could certainly use wider testing before release.


Thanks,
Roger


unblock sysvinit/2.88dsf-32

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (550, 'unstable'), (500, 'testing'), (400, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: 
http://lists.debian.org/20120819082519.30677.4899.report...@ravenclaw.codelibre.net



Re: getting fixes for #596284 into wheezy before the release?

2012-07-30 Thread Roger Leigh
On Mon, Jul 30, 2012 at 06:08:53PM -0400, Daniel Kahn Gillmor wrote:
 
 Roger, do you have any plans on how to deal with the outstanding bugs in
 the wheezy version of sysvinit?

Yes, I do plan to ask for a freeze exception for sysvinit.  -28
had some additional RC bugs in it, which was why -29 added which
fixed a number of RC bugs and wheezy upgrade/install issues.
A bug was reported a few days ago about a corner case where
upgrades fail inside a chroot, which I was able to reproduce
last night, and which I should hopefully be able to fix this
week.  And there was another upgrade/regression issue (I'll have
to double-check the bug #) which needs checking and fixing as
well.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120731000624.gh25...@codelibre.net



Re: Please unblock schroot 1.6.2-1

2012-07-23 Thread Roger Leigh
On Sat, Jul 21, 2012 at 10:40:34AM +0100, Roger Leigh wrote:
 Hi,
 
 Please could you unblock schroot?  It contains the following
 changes:
 
 - PAM pam_env is used to set up additional environment from
   /etc/security/pam_env.conf and /etc/default/locale.

This single change was reverted in 1.6.3-1.  This should be the
final change for wheezy.


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120723234151.gp25...@codelibre.net



Please unblock schroot 1.6.2-1

2012-07-21 Thread Roger Leigh
Hi,

Please could you unblock schroot?  It contains the following
changes:

schroot (1.6.2-1) unstable; urgency=low

  * New upstream stable release.
  * schroot:
- PAM pam_env is used to set up additional environment from
  /etc/security/pam_env.conf and /etc/default/locale.
- /usr/bin/X11 and /usr/games have been removed from the
  default PATH.

 -- Roger Leigh rle...@debian.org  Wed, 18 Jul 2012 23:10:24 +0100

schroot (1.6.1-1) unstable; urgency=low

  * New upstream stable release.
  * schroot:
- Remove invalid and obsolete symlinks which were being created
  on install and upgrade, and no longer create them
  (Closes: #681931).
- Fix 15binfmt setup script to bind mount binfmt binary correctly
  (Closes: #677811).  Thanks to Vagrant Cascadian and Julian Andres
  Klode.
- Building from git has been documented, as has the upstream
  release process (Closes: #680882).
  * dchroot:
- Migrate dchroot.conf to schroot.conf format on upgrade
  (Closes: #681876).  Also documented caveats in NEWS.Debian.
  * dchroot-dsa:
- Migrate dchroot.conf to schroot.conf format on upgrade.
  Also documented caveats in NEWS.Debian.

 -- Roger Leigh rle...@debian.org  Wed, 18 Jul 2012 20:04:41 +0100


This contains bugfixes only, mainly to fix squeeze-wheezy upgrade
issues, and also to fix binfmt support which was causing breakage
for some people.  Steve Langasek requested the PAM and PATH changes.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120721094034.gz25...@codelibre.net



Re: Pending freeze and packages pending upload

2012-07-09 Thread Roger Leigh
On Wed, Jun 27, 2012 at 02:43:08PM +0100, Neil McGovern wrote:
 On Wed, Jun 27, 2012 at 01:21:30PM +0100, Roger Leigh wrote:

   gutenprint 5.2.8
 This is a point release with a large number of new printer
 models being supported.  It was released 2 days ago, but we've
 been waiting on it for months.  Quite important for including
 with wheezy for contemporary printer support.  I will package
 it this weekend.
  
  This is done, but I found that upstream accidentally bumped the
  major version of the libgutenprint2 ABI.  They are planning to release
  5.2.9 with my patches for correcting the mistake.  They should do this
  by the weekend, but it's possible this will miss the freeze deadline.
  It would be good to have a freeze exception for this--the work is all
  done and tested, just waiting on the update from upstream.  I can
  apply my patches directly to the 5.2.8 release any upload now, or I
  could wait for them to release properly.
  
 
 I would suggest uploading the patched version and then updating to
 increase the amount of testing it receives.

This has been done.  I've now uploaded 5.2.9-1, which is just 5.2.8
plus the Debian patches incorporated upstream and some translation
updates and very minor bugfixes.  If this could be allowed into
testing, that would be much appreciated.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120709225425.ge25...@codelibre.net



Getting dependency based boot fixed for wheezy

2012-07-03 Thread Roger Leigh
Hi,

We've been defaulting to dependency based for new installs for
several years.  Since last week, sysv-rc unconditionally uses
dependency-based boot.  file-rc is the last package using
static sequencing.

I'd like (for wheezy+1) to remove the static sequence numbers
entirely.  To do this, we need to get update-rc.d to treat the
start and stop arguments as being equivalent to defaults, so
it always uses the LSB dependencies.  We can't, however, do this
while there are packages using those numbers, and we need to fix
these packages in wheezy so that it's possible to do the
migration in wheezy+1.

file-rc now has a patch to enable insserv support (#539591).  I'd
like for this to be fixed in wheezy.  It requires the following
changes:

1) Enabling of the insserv -s option (#573004).  This is a one-
   line change to debian/patches/series, since the patch is
   already in place and tested.
2) Uploading of fixed file-rc to fix #539591
3) Disabling of the static boot reversion on removal in sysv-rc,
   since it's no longer needed when file-rc supports insserv.

Since we're frozen, I just wanted to get approval for doing the
above.  It's important for the work we want to do in wheezy+1, as
well as for properly supporting dependency-based boot in wheezy.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120703094128.gm4...@codelibre.net



Re: Pending freeze and packages pending upload

2012-06-27 Thread Roger Leigh
On Wed, Jun 20, 2012 at 08:40:50AM +0100, Roger Leigh wrote:
 Hi,
 
 I'd like the following to be permitted to be uploaded for wheezy:
 
 schroot 1.6.0
   This is just 1.5.4 in unstable with translation updates and
   a few minor bugfixes.  This is the stable release intended for
   the wheezy release.

Uploaded.  There may be a point release with translation updates
and potentially minor bugfixes at some point in the next month or so.

 gutenprint 5.2.8
   This is a point release with a large number of new printer
   models being supported.  It was released 2 days ago, but we've
   been waiting on it for months.  Quite important for including
   with wheezy for contemporary printer support.  I will package
   it this weekend.

This is done, but I found that upstream accidentally bumped the
major version of the libgutenprint2 ABI.  They are planning to release
5.2.9 with my patches for correcting the mistake.  They should do this
by the weekend, but it's possible this will miss the freeze deadline.
It would be good to have a freeze exception for this--the work is all
done and tested, just waiting on the update from upstream.  I can
apply my patches directly to the 5.2.8 release any upload now, or I
could wait for them to release properly.

 Additionally:
 sbuild.  I'll be working on this once the above two are done.  It's
 not had much work done on it over the last year due to lack of time
 finishing my PhD and moving jobs, but it does need some bugs fixing
 for wheezy.  This won't have impact on anything else.  It would be
 great if this could be considered for wheezy after the freeze starts
 because it's unlikely I'll have time until then to start work on it.

sbuild is often used by developers who are running stable to build
packages for unstable.  So it's important that the stable sbuild be
able to support all the features needed during wheezy+1 (at least as
far as that is possible).  I definitely won't have this done for the
freeze--I've got to get sysvinit fixed as a priority.  It's functional
as it stands, but could be better--there are quite a number of bugs
I'd like to get addressed for wheezy.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120627122130.gk9...@codelibre.net



Re: The future (or non-future) of ia32-libs

2012-06-22 Thread Roger Leigh
On Fri, Jun 22, 2012 at 09:32:15PM +0800, Thomas Goirand wrote:
 On 06/22/2012 05:34 PM, Goswin von Brederlow wrote:
  Step 1: upgrade/dist-upgrade with ia32-libs (wine, ...) held back
  Step 2: dpkg --add-architecture i386  apt-get update
  Step 3: dist-upgrade (ia32-libs, wine, ... is now installable)

 May I suggest that upon upgrade, we have a debconf message telling
 about it? We could add this in base-files or any essential package,
 probably one with some debconf messages already in would be a better
 pick. Instructions would show, IF ia32-libs old version is currently
 installed
 AND the --add-architecture i386 hasn't bee done.
 
 I know we have release notes, but some don't know about them or would
 simply not read them. A debconf message seem really appropriate IMO.

Could we not introduce the concept of an upgrade script into
apt-get which could be downloaded when you run apt-get update and
then run during a dist-upgrade?  This could handle automation of
any housekeeping during the upgrade which would otherwise require
manual work detailed in the release notes.

For example, if the ia32-libs package is installed, this could
automatically update dpkg and apt-get, then automatically add the
architecture and update prior to continuing with the upgrade.  It
could also handle any additional work which needs doing before and
after the upgrade of the whole distribution, or any particular
package.  i.e. handling any work which the package maintainer
scripts can't safely or sensibly handle.

Doesn't the Ubuntu updater tool do something like this already when
it does a full upgrade between releases?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120622143137.gf9...@codelibre.net



Pending freeze and packages pending upload

2012-06-20 Thread Roger Leigh
Hi,

I'd like the following to be permitted to be uploaded for wheezy:

schroot 1.6.0
  This is just 1.5.4 in unstable with translation updates and
  a few minor bugfixes.  This is the stable release intended for
  the wheezy release.

gutenprint 5.2.8
  This is a point release with a large number of new printer
  models being supported.  It was released 2 days ago, but we've
  been waiting on it for months.  Quite important for including
  with wheezy for contemporary printer support.  I will package
  it this weekend.

Additionally:
sbuild.  I'll be working on this once the above two are done.  It's
not had much work done on it over the last year due to lack of time
finishing my PhD and moving jobs, but it does need some bugs fixing
for wheezy.  This won't have impact on anything else.  It would be
great if this could be considered for wheezy after the freeze starts
because it's unlikely I'll have time until then to start work on it.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120620074050.gi30...@codelibre.net



Re: powerpc qualification for Wheezy

2012-05-23 Thread Roger Leigh
On Wed, May 23, 2012 at 07:32:17PM +0100, Adam D. Barratt wrote:
 On Wed, 2012-05-16 at 13:19 +0100, Adam D. Barratt wrote:
  With the sound of the ever approaching freeze ringing loudly in our ears,
  we're (somewhat belatedly) looking at finalising the list of release
  architectures for the Wheezy release.
  
  Comments on / additions and corrections to the content of
  http://release.debian.org/wheezy/arch_qualify.html would be appreciated,
  as would any other information you think is relevant to helping us
  determine powerpc's status for the release.
 
 *gentle prod*

I am still a regular powerpc user, and I should have sufficient time to
assist with porting issues for the foreseeable future, which I haven't
done for the last couple of releases but will now be able to.  So feel
free to put me down as a powerpc porter, I'll continue to follow
powerpc issues on debian-powerpc and be happy to undertake specific
porting and debugging as and when required.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linuxhttp://people.debian.org/~rleigh/
 `. `'   schroot and sbuild  http://alioth.debian.org/projects/buildd-tools
   `-GPG Public Key  F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120523184232.ga22...@codelibre.net



sysvinit testing migration

2012-01-08 Thread Roger Leigh
sysvinit appears to be blocked from migration by libpam-mount.

libpam-mount depends on Linux-only libraries (libpam-mount), and
additionally dropped support for BSD mount upstream, so should
no longer be considered buildable or usable on kfreebsd for the
time being at least.

libhx also appears to be blocking libpam-mount, but it's claiming
libhx27 is out of date (but it's no longer present, replaced by
libhx28).

Not sure if this needs any manual untangling or not--just to let
you know that it's blocking things.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120108122034.gd9...@codelibre.net



Re: sysvinit testing migration

2012-01-08 Thread Roger Leigh
On Sun, Jan 08, 2012 at 01:47:10PM +0100, Julien Cristau wrote:
 On Sun, Jan  8, 2012 at 13:29:42 +0100, Philipp Kern wrote:
 
  On Sun, Jan 08, 2012 at 12:20:34PM +, Roger Leigh wrote:
   libpam-mount depends on Linux-only libraries (libpam-mount), and
   additionally dropped support for BSD mount upstream, so should
   no longer be considered buildable or usable on kfreebsd for the
   time being at least.
  
  It still needs its obsolete binaries removed.
  
 Which means the maintainer needs to reportbug ftp.debian.org.

I've done this, and filed a separate bug against the package to
get them to set the Architecture for the source package correctly.


Thanks all,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20120108131134.ge9...@codelibre.net



Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-26 Thread Roger Leigh
On Sun, May 15, 2011 at 01:35:39PM +0200, Philipp Kern wrote:
 On Fri, May 13, 2011 at 11:11:58PM +0100, Roger Leigh wrote:
  Attached is a debdiff of the build in a squeeze chroot; packages
  available at http://www.codelibre.net/~rleigh/schroot-squeeze/
 
 Is this fixed in unstable already?  It needs to be.

This is fixed in unstable for 10 days and about to migrate to
testing.  Is this OK to upload?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-15 Thread Roger Leigh
On Sun, May 15, 2011 at 01:35:39PM +0200, Philipp Kern wrote:
 On Fri, May 13, 2011 at 11:11:58PM +0100, Roger Leigh wrote:
  Attached is a debdiff of the build in a squeeze chroot; packages
  available at http://www.codelibre.net/~rleigh/schroot-squeeze/
 
 Is this fixed in unstable already?  It needs to be.

I'm preparing a new 1.4.22 point release for unstable.  It should
be done today.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-15 Thread Roger Leigh
On Sun, May 15, 2011 at 01:25:27PM +0100, Roger Leigh wrote:
 On Sun, May 15, 2011 at 01:35:39PM +0200, Philipp Kern wrote:
  On Fri, May 13, 2011 at 11:11:58PM +0100, Roger Leigh wrote:
   Attached is a debdiff of the build in a squeeze chroot; packages
   available at http://www.codelibre.net/~rleigh/schroot-squeeze/
  
  Is this fixed in unstable already?  It needs to be.
 
 I'm preparing a new 1.4.22 point release for unstable.  It should
 be done today.

Now uploaded to unstable.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-13 Thread Roger Leigh
On Thu, May 12, 2011 at 02:43:34PM +0100, Roger Leigh wrote:
 On Thu, May 12, 2011 at 02:12:09PM +0100, Roger Leigh wrote:
  On Thu, May 12, 2011 at 02:09:10PM +0100, Roger Leigh wrote:
   Hi,
   
   I was informed today that dchroot-dsa was non-functional in stable,
   and the same bug is also present in unstable.  I filed this as
   #626503.  The patch is a one-liner to fix a regression in the
   dchroot.conf conffile loading (the interface changed incompatibly
   prior to squeeze being released, and this code is still using the
   older interface, which results in a fatal exception being thrown).
   
   dchroot-dsa can load both dchroot.conf for compatibility, and
   schroot.conf; presumably testing was with schroot.conf only which
   is why this was not picked up prior to release.
   
   Would it be OK to upload a fixed version of the schroot package
   to stable-proposed-updated containing just this one line fix?

Attached is a debdiff of the build in a squeeze chroot; packages
available at http://www.codelibre.net/~rleigh/schroot-squeeze/


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff -Nru schroot-1.4.19/debian/changelog schroot-1.4.19/debian/changelog
--- schroot-1.4.19/debian/changelog 2011-01-11 00:13:00.0 +
+++ schroot-1.4.19/debian/changelog 2011-05-13 22:09:28.0 +0100
@@ -1,3 +1,11 @@
+schroot (1.4.19-1+squeeze1) stable-proposed-updates; urgency=low
+
+  * dchroot-dsa: Use current interface for loading dchroot.conf,
+rather than the old, which caused a fatal exception
+(Closes: #626503).
+
+ -- Roger Leigh rle...@debian.org  Thu, 12 May 2011 14:31:01 +0100
+
 schroot (1.4.19-1) unstable; urgency=low
 
   * New upstream stable release.
diff -Nru schroot-1.4.19/debian/patches/debian-changes-1.4.19-1+squeeze1 
schroot-1.4.19/debian/patches/debian-changes-1.4.19-1+squeeze1
--- schroot-1.4.19/debian/patches/debian-changes-1.4.19-1+squeeze1  
1970-01-01 01:00:00.0 +0100
+++ schroot-1.4.19/debian/patches/debian-changes-1.4.19-1+squeeze1  
2011-05-13 22:56:15.0 +0100
@@ -0,0 +1,39 @@
+Description: Upstream changes introduced in version 1.4.19-1+squeeze1
+ This patch has been created by dpkg-source during the package build.
+ Here's the last changelog entry, hopefully it gives details on why
+ those changes were made:
+ .
+ schroot (1.4.19-1+squeeze1) stable-proposed-updates; urgency=low
+ .
+   * dchroot-dsa: Use current interface for loading dchroot.conf,
+ rather than the old, which caused a fatal exception
+ (Closes: #626503).
+ .
+ The person named in the Author field signed this changelog entry.
+Author: Roger Leigh rle...@debian.org
+Bug-Debian: http://bugs.debian.org/626503
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: vendor|upstream|other, url of original patch
+Bug: url in upstream bugtracker
+Bug-Debian: http://bugs.debian.org/bugnumber
+Bug-Ubuntu: https://launchpad.net/bugs/bugnumber
+Forwarded: no|not-needed|url proving that it has been forwarded
+Reviewed-By: name and email of someone who approved the patch
+Last-Update: -MM-DD
+
+--- schroot-1.4.19.orig/bin/dchroot-dsa/dchroot-dsa-main.cc
 schroot-1.4.19/bin/dchroot-dsa/dchroot-dsa-main.cc
+@@ -61,7 +61,7 @@ main::load_config ()
+   this-config =
+   sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config);
+   if (this-options-load_chroots == true)
+-  this-config-add(DCHROOT_CONF, false);
++  this-config-add(chroot, DCHROOT_CONF);
+ }
+   else
+ {
diff -Nru schroot-1.4.19/debian/patches/series 
schroot-1.4.19/debian/patches/series
--- schroot-1.4.19/debian/patches/series1970-01-01 01:00:00.0 
+0100
+++ schroot-1.4.19/debian/patches/series2011-05-13 22:44:01.0 
+0100
@@ -0,0 +1 @@
+debian-changes-1.4.19-1+squeeze1


signature.asc
Description: Digital signature


Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-12 Thread Roger Leigh
Hi,

I was informed today that dchroot-dsa was non-functional in stable,
and the same bug is also present in unstable.  I filed this as
#626503.  The patch is a one-liner to fix a regression in the
dchroot.conf conffile loading (the interface changed incompatibly
prior to squeeze being released, and this code is still using the
older interface, which results in a fatal exception being thrown).

dchroot-dsa can load both dchroot.conf for compatibility, and
schroot.conf; presumably testing was with schroot.conf only which
is why this was not picked up prior to release.

Would it be OK to upload a fixed version of the schroot package
to stable-proposed-updated containing just this one line fix?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-12 Thread Roger Leigh
On Thu, May 12, 2011 at 02:09:10PM +0100, Roger Leigh wrote:
 Hi,
 
 I was informed today that dchroot-dsa was non-functional in stable,
 and the same bug is also present in unstable.  I filed this as
 #626503.  The patch is a one-liner to fix a regression in the
 dchroot.conf conffile loading (the interface changed incompatibly
 prior to squeeze being released, and this code is still using the
 older interface, which results in a fatal exception being thrown).
 
 dchroot-dsa can load both dchroot.conf for compatibility, and
 schroot.conf; presumably testing was with schroot.conf only which
 is why this was not picked up prior to release.
 
 Would it be OK to upload a fixed version of the schroot package
 to stable-proposed-updated containing just this one line fix?

This is the patch:

index c2aa219..86e127d 100644
--- a/bin/dchroot-dsa/dchroot-dsa-main.cc
+++ b/bin/dchroot-dsa/dchroot-dsa-main.cc
@@ -61,7 +61,7 @@ main::load_config ()
   this-config =
sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config);
   if (this-options-load_chroots == true)
-   this-config-add(DCHROOT_CONF, false);
+   this-config-add(chroot, DCHROOT_CONF);
 }
   else
 {

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Request for update to fix dchroot-dsa bug in stable (#626503)

2011-05-12 Thread Roger Leigh
On Thu, May 12, 2011 at 02:12:09PM +0100, Roger Leigh wrote:
 On Thu, May 12, 2011 at 02:09:10PM +0100, Roger Leigh wrote:
  Hi,
  
  I was informed today that dchroot-dsa was non-functional in stable,
  and the same bug is also present in unstable.  I filed this as
  #626503.  The patch is a one-liner to fix a regression in the
  dchroot.conf conffile loading (the interface changed incompatibly
  prior to squeeze being released, and this code is still using the
  older interface, which results in a fatal exception being thrown).
  
  dchroot-dsa can load both dchroot.conf for compatibility, and
  schroot.conf; presumably testing was with schroot.conf only which
  is why this was not picked up prior to release.
  
  Would it be OK to upload a fixed version of the schroot package
  to stable-proposed-updated containing just this one line fix?

See 
http://git.debian.org/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-squeeze
(top two commits for upload are below)


diff --git a/bin/dchroot-dsa/dchroot-dsa-main.cc 
b/bin/dchroot-dsa/dchroot-dsa-main.cc
index c2aa219..86e127d 100644
--- a/bin/dchroot-dsa/dchroot-dsa-main.cc
+++ b/bin/dchroot-dsa/dchroot-dsa-main.cc
@@ -61,7 +61,7 @@ main::load_config ()
   this-config =
sbuild::chroot_config::ptr(new dchroot_dsa::chroot_config);
   if (this-options-load_chroots == true)
-   this-config-add(DCHROOT_CONF, false);
+   this-config-add(chroot, DCHROOT_CONF);
 }
   else
 {
diff --git a/debian/changelog b/debian/changelog
index fb72ab5..0c422f4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+schroot (1.4.19-1+squeeze1) stable-proposed-updates; urgency=low
+
+  * dchroot-dsa: Use current interface for loading dchroot.conf,
+rather than the old, which caused a fatal exception
+(Closes: #626503).
+
+ -- Roger Leigh rle...@debian.org  Thu, 12 May 2011 14:31:01 +0100
+
 schroot (1.4.19-1) unstable; urgency=low
 
   * New upstream stable release.


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.18-1

2011-01-11 Thread Roger Leigh
On Tue, Jan 11, 2011 at 01:01:53AM +0100, Cyril Brulebois wrote:
 Roger Leigh rle...@codelibre.net (10/01/2011):
  Thanks, I have released, tested, built and uploaded.
 
 #609619

This has been fixed and now autobuilds OK on kfreebsd-*.  Please
could you unblock 1.4.19-1 which contains just this single fix
compared against 1.4.18-1.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: C.UTF-8 in squeeze

2011-01-10 Thread Roger Leigh
On Mon, Jan 10, 2011 at 08:44:10AM +0100, Aurelien Jarno wrote:
 Roger Leigh a écrit :
  On Fri, Jan 07, 2011 at 09:14:47PM -0500, David Holland wrote:
  Can this please get done (adding a C.UTF-8 locale)? It is absolutely
  required for writing shell scripts that handle UTF-8 data, if you want
  those shell scripts to have anything like portable or reliable
  behavior.
  
  This is really in the hands of the glibc maintainers.  I thought that
  a bug had been filed months ago, but I can't find it.  I've done so
  now.
 
 I know some persons already tried to work on that, so if patches are
 already available, they will be really appreciated.
 
 Providing a C.UTF-8 locale is quite easy, d-i is already doing that.
 Providing a C.UTF-8 *by default* is more complicated, as it has to be
 done in the GNU libc code, we can't really on the locale package
 generating one. This would mean this package should always be installed,
 and that we should trust on user to correctly regenerate the locales if
 they do.

Hi Aurelien,

I think that initially, simply guaranteeing the presence of C.UTF-8
as a standard locale, generated by localedef/gen will be sufficient.
This will allow packages to rely on its presence during normal
system operation e.g. in maintainer scripts, for lintian and other
programs requiring it.

I think having it hardcoded into libc is rather more difficult and
having it prior to /usr being mounted is not that important--all
of the known use cases do not require this.  So at least initially,
I think simply providing it outside libc will be more than sufficient.

I would like to see it in libc itself eventually, but I am concerned
about the UTF-8 codeset table being duplicated for every locale.  I'd
like to see it shared so that users using it don't have to pay a
large penalty for the needless duplication.  Possibly best looked at
upstream; I did already mention it a year or so back, but I didn't get
too far--it was more of a casual enquiry about the possibilities.

Regards,
Roger
-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.18-1

2011-01-10 Thread Roger Leigh
On Mon, Jan 10, 2011 at 08:36:12PM +, Adam D. Barratt wrote:
 On Sun, 2011-01-09 at 23:39 +, Roger Leigh wrote:
  On Sun, Jan 09, 2011 at 10:38:09PM +, Adam D. Barratt wrote:
   On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote:
We also update
the 50chrootname setup script to handle non-UUID generated session
names.
   
   That's presumably this addition:
   
   's/-[0-9][0-9]*-[0-9][0-9]*//g'
 [...]
   Apologies if I'm missing something related to the context, but isn't
   there a danger of that regex being insufficiently specific?
  
  No, you're right.  The non-UUID session names we use for kfreebsd are
  made from the time (seconds since epoch) + PID to guarantee uniqueness.
  I could require more digits to make it specific.  The PID should always
  be at least three digits and the time at least 10 digits, so I can add
  the extra [0-9] to the regex to do that.
 
 That would seem cleaner, although by the sound of it the practical
 impact either way is minimal.

I have made (and tested) this change, including accounting for PID
wraparound.

 schroot 1.4.17-1 has now migrated, so please feel free to upload 1.4.18
 (although preferably without much delay).

Thanks, I have released, tested, built and uploaded.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.18-1

2011-01-09 Thread Roger Leigh
On Sun, Jan 09, 2011 at 10:38:09PM +, Adam D. Barratt wrote:
 On Fri, 2011-01-07 at 15:06 +, Roger Leigh wrote:
  Sorry to trouble you again, but I found soon after this release
  #609108 which was breaking schroot on all kfreebsd platforms.
  This is actually due to the statfs structure being broken on
  FreeBSD, limiting the mount and umount commands to paths less
  than 88 characters (80 in practice).
  
  While we can't fix that major design flaw, we can reduce the
  path length to 80 in most circumstances by not using long UUIDs
  in session names.
 [...]
  We also update
  the 50chrootname setup script to handle non-UUID generated session
  names.
 
 That's presumably this addition:
 
 's/-[0-9][0-9]*-[0-9][0-9]*//g'
 
 described in the changelog as:
 
  * 50chrootname: Strip time+PID from session name in addition to UUID.
 
 Apologies if I'm missing something related to the context, but isn't
 there a danger of that regex being insufficiently specific?

No, you're right.  The non-UUID session names we use for kfreebsd are
made from the time (seconds since epoch) + PID to guarantee uniqueness.
I could require more digits to make it specific.  The PID should always
be at least three digits and the time at least 10 digits, so I can add
the extra [0-9] to the regex to do that.

Note that the stripping is only used for putting a shortened form into
/etc/debian_chroot; this is only really used for things like a
customised prompt in the bash shell, so it has zero impact on schroot's
functioning correctly.  Since it's stripping the unique part off and
leaving the chroot base name, it's not useful for doing anything with
other than informational logging, and inside the chroot you can't do
anything with it in any case.  The full form is always available as
SCHROOT_SESSION_ID in the environment.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


C.UTF-8 in squeeze (was: Re: Bug#522776: debian-policy: mandate existence of a standardised locale)

2011-01-08 Thread Roger Leigh
clone 522776 -1
reassign -1 eglibc
retitle -1 eglibc: Please provide a C.UTF-8 locale by default
severity -1 important
thanks

On Fri, Jan 07, 2011 at 09:14:47PM -0500, David Holland wrote:
 Can this please get done (adding a C.UTF-8 locale)? It is absolutely
 required for writing shell scripts that handle UTF-8 data, if you want
 those shell scripts to have anything like portable or reliable
 behavior.

This is really in the hands of the glibc maintainers.  I thought that
a bug had been filed months ago, but I can't find it.  I've done so
now.

Note this comment from Aurelien Jarno:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=522776#342

This will only be done with the approval of the release team, who
I've copied in.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.18-1

2011-01-07 Thread Roger Leigh
On Thu, Dec 30, 2010 at 08:14:10PM +, Adam D. Barratt wrote:
 On Thu, 2010-12-30 at 15:38 +, Roger Leigh wrote:
  On Wed, Dec 08, 2010 at 08:44:48PM +, Adam D. Barratt wrote:
   As discussed on IRC, it's a shame that this resulted in a new
   translatable (and currently untranslated) string, although the fact that
   the string should rarely be seen and is in the program translation
   rather than a debconf template mitigates this slightly.
  
  I've allowed a fortnight for translation updates to come back, and
  made a new release (1.4.17-1) containing five translation updates
  and an additional RC bugfix.  Please could you unblock this to
  allow it into squeeze?
 
 Unblocked; thanks.

Sorry to trouble you again, but I found soon after this release
#609108 which was breaking schroot on all kfreebsd platforms.
This is actually due to the statfs structure being broken on
FreeBSD, limiting the mount and umount commands to paths less
than 88 characters (80 in practice).

While we can't fix that major design flaw, we can reduce the
path length to 80 in most circumstances by not using long UUIDs
in session names.

The proposed changes to this bug are in this git diff:

http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=132cb05f7908f31052998934dd10883bea4a0e93;hp=release/schroot-1.4.17

Here, we fix the libuuid autodetection and enable/disable logic in
configure.ac and also fix a similar issue in the PAM logic.  On the
Debian packaging side, we don't build-dep on uuid-dev on kfreebsd,
and deliberately disable it when running configure.  We also update
the 50chrootname setup script to handle non-UUID generated session
names.

This has been tested on native kfreebsd by Julián Moreno Patiño and
Jakub Wilk, and by myself on KVM/qemu with a kfreebsd-amd64 VM as
well as on linux-amd64.

Is this OK to upload and be allowed into testing?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.18-1

2011-01-07 Thread Roger Leigh
On Fri, Jan 07, 2011 at 04:26:18PM +0100, Julien Cristau wrote:
 On Fri, Jan  7, 2011 at 15:06:35 +, Roger Leigh wrote:
 
  Is this OK to upload and be allowed into testing?
  
 At least not until the previous version goes in (I didn't look at the
 proposed changes).

Of course.  I won't be uploading anything until then.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: sbuild in squeeze

2010-12-31 Thread Roger Leigh
On Fri, Dec 31, 2010 at 02:55:09PM +0100, Philipp Kern wrote:
 Hi,
 
 On Thu, Dec 30, 2010 at 11:48:30AM +, Roger Leigh wrote:
  I've cherry-picked all of the required changes and put them here for
  your approval (diff also attached against debian/sbuild-0.60.0-2):
  http://git.debian.org/?p=buildd-tools/sbuild.git;a=shortlog;h=refs/heads/sbuild-squeeze
 
 bin/sbuild-createchroot
 +# Create the target directory in advance so abs_path (which is buggy)
 +# won't fail.  Remove if abs_path is replaced by something better.
 +makedir($ARGV[1], 0700);
 
 Was that recently changed to 0755?

Yes.  I can backport that change too.

  This is about as minimal as it's possible to make and still have it
  non-broken.
  
  I'll need to do some testing since cherry-picking like this might have
  resulted in some needed changes being missed out.  But the number of
  features being changed is small and discrete, so testing should be
  simple and definitive to prove it's working.  Once I'm convinced it's
  working correctly, may I upload this to testing-proposed-updates?
 
 You tested that on squeeze?

Tested on unstable.  The changes being tested are self-contained within
sbuild, and when testing schroot compatibility, the version of schroot
is common between the two.  I can test on squeeze as well if necessary.

 So yeah, barring the issue above you can upload to t-p-u.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: sbuild in squeeze

2010-12-30 Thread Roger Leigh
On Wed, Dec 29, 2010 at 10:42:23AM +0100, Philipp Kern wrote:
 Hi Roger,
 
 On Mon, Nov 08, 2010 at 12:10:23PM +, Roger Leigh wrote:
  sbuild in squeeze has been neglected for some time, and it contains
  quite a large number of bugs and deficiencies.  This was mainly due
  to the fact that I couldn't devote a huge amount of time to Debian
  during my PhD, and I only found the time to begin addressing this
  properly over the last two weeks.  The version in unstable now fixes
  34 bugs present in squeeze:
 
 sorry that this issue was neglected so long.  However the changes are
 massive, which was one of the reasons we were overwhelmed by it.  As
 this point in the freeze we cannot accept such an update anymore, too.
 Given that sbuild is still moving in unstable is an indicator for us
 to err on the side of caution.
[...]

 On v3 support: that's definitely needed.  You listed two patches in
 20101115210839.gj15...@codelibre.net.  If that's sufficient, that
 would be reasonable for a targetted fix for squeeze.

OK.

 What's needed to be able to use sbuild's functionality with the stable
 schroot?

sbuild needs to be aware of schroot namespaces.  I've been through all
the changes and pulled out the needed changes.  This needs changes to
the chroot code and the utility programs.  There's also a change to the
25nssdatabases script to stop it breaking with schroot 1.4.

I've cherry-picked all of the required changes and put them here for
your approval (diff also attached against debian/sbuild-0.60.0-2):

http://git.debian.org/?p=buildd-tools/sbuild.git;a=shortlog;h=refs/heads/sbuild-squeeze

This is about as minimal as it's possible to make and still have it
non-broken.

I'll need to do some testing since cherry-picking like this might have
resulted in some needed changes being missed out.  But the number of
features being changed is small and discrete, so testing should be
simple and definitive to prove it's working.  Once I'm convinced it's
working correctly, may I upload this to testing-proposed-updates?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff --git a/bin/sbuild-apt b/bin/sbuild-apt
index f9ea814..c868a09 100755
--- a/bin/sbuild-apt
+++ b/bin/sbuild-apt
@@ -48,7 +48,7 @@ if ($command eq apt-get) {
 		Bad command $command.  Allowed commands: apt-get or apt-cache\n);
 }
 
-my $session = setup($chroot, $conf) or die Chroot setup failed;
+my $session = setup('source', $chroot, $conf) or die Chroot setup failed;
 
 $session-run_apt_command(
 { COMMAND = [$command, @ARGV],
diff --git a/bin/sbuild-checkpackages b/bin/sbuild-checkpackages
index 00a47ce..663a61d 100755
--- a/bin/sbuild-checkpackages
+++ b/bin/sbuild-checkpackages
@@ -74,7 +74,7 @@ my $chroot = $ARGV[0];
 setlocale(LC_COLLATE, POSIX);
 $ENV{'LC_COLLATE'} = POSIX;
 
-my $session = setup($chroot, $conf) or die Chroot setup failed;
+my $session = setup('source', $chroot, $conf) or die Chroot setup failed;
 
 check_packages($session, $mode);
 
diff --git a/bin/sbuild-clean b/bin/sbuild-clean
index b7e65ab..41c6785 100755
--- a/bin/sbuild-clean
+++ b/bin/sbuild-clean
@@ -108,7 +108,7 @@ foreach (@ARGV) {
 
 my $chroot = Sbuild::Utility::get_dist($_);
 
-my $session = setup($ARGV[0], $conf) or die Chroot setup failed;
+my $session = setup('source', $chroot, $conf) or die Chroot setup failed;
 
 if ($conf-get('CLEAN')) {
 	print Performing clean.\n;
diff --git a/bin/sbuild-createchroot b/bin/sbuild-createchroot
index 8c76b3b..9e3211c 100755
--- a/bin/sbuild-createchroot
+++ b/bin/sbuild-createchroot
@@ -158,6 +158,9 @@ $conf-set('INCLUDE', add_items($conf-get('INCLUDE'),
 debfoster));
 
 my $suite = $ARGV[0];
+# Create the target directory in advance so abs_path (which is buggy)
+# won't fail.  Remove if abs_path is replaced by something better.
+makedir($ARGV[1], 0700);
 my $target = abs_path($ARGV[1]);
 my $mirror = $ARGV[2];
 my $script = undef;
@@ -249,7 +252,7 @@ my $chrootname = ${suite}- . $conf-get('ARCH') . -sbuild;
 if (-d /etc/schroot/chroot.d) {
 # TODO: Don't hardcode path
 my $SCHROOT_CONF =
-	new File::Temp( TEMPLATE = $chrootname.XX,
+	new File::Temp( TEMPLATE = $chrootname-XX,
 			DIR = /etc/schroot/chroot.d,
 			UNLINK = 0)
 	or die Can't open schroot configuration file: $!\n;
@@ -259,12 +262,9 @@ if (-d /etc/schroot/chroot.d) {
 [$chrootname]
 type=directory
 description=Debian $suite/$arch autobuilder
-location=$target
-priority=3
+directory=$target
 groups=root,sbuild
 root-groups=root,sbuild
-run-setup-scripts=true
-run-exec-scripts=true
 EOF
 
 my ($personality, $personality_message);
diff --git a/bin/sbuild-distupgrade b/bin/sbuild-distupgrade
index 5e8cad7..115497e 100755
--- a/bin/sbuild-distupgrade
+++ b/bin/sbuild-distupgrade
@@ -40,7 +40,7 @@ foreach (@ARGV

Re: sbuild in squeeze

2010-12-30 Thread Roger Leigh
On Thu, Dec 30, 2010 at 11:48:30AM +, Roger Leigh wrote:
 On Wed, Dec 29, 2010 at 10:42:23AM +0100, Philipp Kern wrote:

 I've cherry-picked all of the required changes and put them here for
 your approval (diff also attached against debian/sbuild-0.60.0-2):
 
 http://git.debian.org/?p=buildd-tools/sbuild.git;a=shortlog;h=refs/heads/sbuild-squeeze
 
 This is about as minimal as it's possible to make and still have it
 non-broken.
 
 I'll need to do some testing since cherry-picking like this might have
 resulted in some needed changes being missed out.  But the number of
 features being changed is small and discrete, so testing should be
 simple and definitive to prove it's working.  Once I'm convinced it's
 working correctly, may I upload this to testing-proposed-updates?

Testing summary:

sbuild:
- format v1 and v3 (quilt) source packages fetch, unpack and build [OK]
- chroot usage with and without namespace qualifiers for clonable
  and non-clonable chroot types [OK]
  [all cloning/purging operations work on correct chroot and
  purging correctly skipped for clonable chroots]

utilities:
- sbuild-distupgrade [OK]
- sbuild-unhold [OK]
- sbuild-apt [OK]
- sbuild-hold [OK]
- sbuild-update [OK]
- sbuild-checkpackages [OK]
- sbuild-shell [OK]
- sbuild-upgrade [OK]
- sbuild-clean [OK]
- sbuild-stats [OK]
All the above tested using chroots with and without namespace
qualifiers; debug output used to confirm correct chroot selection
[they all use the same core library code to do this, so not
tested for every single possible combination; the setup code has
been tested in all combinations]
- sbuild-createchroot creates valid and working schroot 1.4
  configuration [OK]

schroot setup scripts
- 25nssdatabases copes with comments [OK]


I'm satisfied that all the core functionality is working correctly.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.16-1

2010-12-30 Thread Roger Leigh
On Wed, Dec 08, 2010 at 08:44:48PM +, Adam D. Barratt wrote:
 On Tue, 2010-12-07 at 17:31 +, Roger Leigh wrote:
  I've made a new upload of schroot to unstable which fixes a few
  security- and upgrade-related bugs.  The bulk of the changes are
  documentation (manual pages, release notes and changelogs). The
  code changes are tiny, but are important to have to upgrade from
  lenny cleanly and fully document security issues and program
  behaviour.
 
 Unblocked; thanks.
 
 As discussed on IRC, it's a shame that this resulted in a new
 translatable (and currently untranslated) string, although the fact that
 the string should rarely be seen and is in the program translation
 rather than a debconf template mitigates this slightly.

I've allowed a fortnight for translation updates to come back, and
made a new release (1.4.17-1) containing five translation updates
and an additional RC bugfix.  Please could you unblock this to
allow it into squeeze?

Changes:
http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=debian/schroot-1.4.17-1;hp=debian/schroot-1.4.16-1

Changes with generated files included:
http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=distribution/schroot-1.4.17;hp=distribution/schroot-1.4.16


Many thanks,
Roger


schroot (1.4.17-1) unstable; urgency=low

  * New upstream stable release.
  * 15killprocs: Don't kill processes in other sessions
(Closes: #608054).  Compare full chroot path in addition to device
and inode numbers, since the device and inode are not sufficiently
unique (they are shared between non-cloned sessions such as for
directory type chroots).
  * Updated translations:
- da (Closes: #606305).  Thanks to Joe Hansen.
- de (Closes: #606245).  Thanks to Holger Wansing.
- fr (Closes: #606394).  Thanks to Thomas Blein.
- it.  Thanks to Vincenzo Campanella.
- zh_CN.  Thanks to Ji ZhengYu.

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff --git a/NEWS b/NEWS
index 8fa9bba..bdc5677 100644
--- a/NEWS
+++ b/NEWS
@@ -1,12 +1,16 @@
 NEWS-*- outline -*-
 
 
-Welcome to schroot 1.4.16.  Please read these release notes carefully.
+Welcome to schroot 1.4.17.  Please read these release notes carefully.
 
 Full installation instructions are provided in the INSTALL file.  The
 README file also contains more specific notes regarding building and
 configuration.
 
+* Major changes in 1.4.17:
+
+  None.
+
 * Major changes in 1.4.16:
 
   1) Chroot naming restrictions introduced in 1.4.0 have been relaxed
diff --git a/debian/changelog b/debian/changelog
index 19022bf..fdb1c7f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,20 @@
+schroot (1.4.17-1) unstable; urgency=low
+
+  * New upstream stable release.
+  * 15killprocs: Don't kill processes in other sessions
+(Closes: #608054).  Compare full chroot path in addition to device
+and inode numbers, since the device and inode are not sufficiently
+unique (they are shared between non-cloned sessions such as for
+directory type chroots).
+  * Updated translations:
+- da (Closes: #606305).  Thanks to Joe Hansen.
+- de (Closes: #606245).  Thanks to Holger Wansing.
+- fr (Closes: #606394).  Thanks to Thomas Blein.
+- it.  Thanks to Vincenzo Campanella.
+- zh_CN.  Thanks to Ji ZhengYu.
+
+ -- Roger Leigh rle...@debian.org  Wed, 29 Dec 2010 16:41:30 +
+
 schroot (1.4.16-1) unstable; urgency=low
 
   * New upstream stable release.
diff --git a/etc/setup.d/15killprocs b/etc/setup.d/15killprocs
index 619035e..1f246b0 100755
--- a/etc/setup.d/15killprocs
+++ b/etc/setup.d/15killprocs
@@ -40,28 +40,35 @@ do_kill_all()
 info Killing processes run inside $1
 ls /proc | egrep '^[[:digit:]]+$' |
 while read pid; do
+	# Check if process root are the same device/inode as chroot
+	# root (for efficiency)
 if [ /proc/$pid/root -ef $1 ]; then
-exe=$(readlink /proc/$pid/exe || true)
-info Killing left-over pid $pid (${exe##$1})
-info   Sending SIGTERM to pid $pid
+	# Check if process and chroot root are the same (may be
+	# different even if device/inode match).
+	root=$(readlink /proc/$pid/root || true)
+	if [ $root = $1 ]; then
+		exe=$(readlink /proc/$pid/exe || true)
+		info Killing left-over pid $pid (${exe##$1})
+		info   Sending SIGTERM to pid $pid
 
-/bin/kill -TERM $pid 2/dev/null
+		/bin/kill -TERM $pid 2/dev/null
 
-count=0
-max=5
-while [ -d /proc/$pid ]; do
-count=$(( $count + 1 ))
-info   Waiting for pid $pid to shut down... ($count/$max)
-sleep 1
-# Wait for $max seconds for process to die before -9'ing

Re: Please unblock schroot 1.4.16-1

2010-12-08 Thread Roger Leigh
On Wed, Dec 08, 2010 at 08:44:48PM +, Adam D. Barratt wrote:
 On Tue, 2010-12-07 at 17:31 +, Roger Leigh wrote:
  I've made a new upload of schroot to unstable which fixes a few
  security- and upgrade-related bugs.  The bulk of the changes are
  documentation (manual pages, release notes and changelogs). The
  code changes are tiny, but are important to have to upgrade from
  lenny cleanly and fully document security issues and program
  behaviour.
 
 Unblocked; thanks.
 
 As discussed on IRC, it's a shame that this resulted in a new
 translatable (and currently untranslated) string, although the fact that
 the string should rarely be seen and is in the program translation
 rather than a debconf template mitigates this slightly.

Many thanks.

I've already received updated da, de and it translations.  I should
hopefully be able to make a new release with all of the translations
updated in the next week or so once the rest come in.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Please unblock schroot 1.4.16-1

2010-12-07 Thread Roger Leigh
Hi,

I've made a new upload of schroot to unstable which fixes a few
security- and upgrade-related bugs.  The bulk of the changes are
documentation (manual pages, release notes and changelogs). The
code changes are tiny, but are important to have to upgrade from
lenny cleanly and fully document security issues and program
behaviour.

Please could you consider unblocking for squeeze?


Thanks,
Roger


#601043, #605939: Upgrade failure when upgrading from lenny.  The
 restrictions on valid filenames were make much stricter
 in 1.4.0 (later than Lenny), meaning many configurations
 are broken when upgrading.  After auditing all validation
 and usage paths in the code, I've relaxed the naming
 restrictions such that it remains secure, but allows
 most names which were valid in lenny.  There's a complete
 rationale for the naming restrictions in schroot.conf(5).
#605950  This is a regression which results in mount options in the
 configuration file being ignored.  They are now correctly
 preserved.
#606162  This is a performance regression which caused schroot to
 run extremely poorly on large heavily loaded systems; this
 speeds up session cleanup by orders of magnitude by using
 shell builtins rather than invoking readlink once per
 running process on the system
#587758  Documentation of security issues relating to configuration
#599380  Documentation update (non-essential)


schroot (1.4.16-1) unstable; urgency=low

  * New upstream stable release.
  * Document schroot -- option delimiter in schroot(1)
(Closes: #599380).
  * Document security implications of bind-mounting /dev and other
filesystems in schroot.conf(5) (Closes: #587758).
  * Relax chroot naming restrictions (Closes: #601043, #605939).  The
name may not contain a leading period (‘.’).  The  characters ‘:’
(colon), ‘,’ (comma) and ‘/’ (forward slash) are not permitted
anywhere in the name.  The name may also not contain a trailing
tilde ('~').  Otherwise any characters are permitted.
  * 10mount: Respect mount options from configuration for all mountable
chroot types (Closes: #605950).  Thanks to Nelson Elhage for this
patch.
  * 15killprocs: Improve performance by omitting a readlink call for
each process running on the system, leading to a significant
reduction in overhead on busy systems (Closes: #606162).  Thanks
to Anders Kaseorg for this patch.

 -- Roger Leigh rle...@debian.org  Tue, 07 Dec 2010 12:29:25 +


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: sbuild in squeeze

2010-11-15 Thread Roger Leigh
On Mon, Nov 15, 2010 at 08:59:31PM +0100, Philipp Kern wrote:
 On Mon, Nov 08, 2010 at 12:10:23PM +, Roger Leigh wrote:
  I'm afraid this isn't just minimal bugfixing, it's basically three new
  upstream releases worth of changes.  But, I think it's important to
  have in squeeze for these key improvements:
  
  • dpkg-source v3 support
 
 The buildd-0.60.0 branch in production is based on... 0.60.0.  So it should
 already have that support?  Could you please clarify?

Certainly.  The buildd branch has the dpkg-source v3 code backported
into it from the master branch; the version of sbuild in unstable
and testing can not build v3 sources.  It may be able to build some
v3 packages, but it's limited to sources using
.dsc/.diff.gz/.orig.tar.gz; no .tar.bz2 or quilt or multiple tarballs
etc.

Specifically, it's missing

commit ba54dd628d1f5a3c72286242e5e6c6731fe3367a
Author: Roger Leigh rle...@debian.org
Date:   Mon May 3 13:55:48 2010 +0100

Sbuild::Build: Remove DSC filename assumptions breaking new source formats

commit 7594a18ca7b7612af3f81a637cc378d484d642c7
Author: Roger Leigh rle...@debian.org
Date:   Sat Jun 12 16:58:43 2010 +0100

Sbuild::Build: Don't use '-sn' with 'dpkg-buildpackage -x'

The latter is just cosmetic to avoid dpkg-source moaning that
-sn is unsupported with v3 sources.  The former is absolutely
required.

  • integration with the schroot version in squeeze (currently it has no
namespace support, and the sbuild-* helper programs are broken)
  • correct removal and reinstallation of Build-Conflicts
  
  and these nice to have improvements:
  
  • uses the aptitude build dependency resolver in place of the old, buggy,
and unmaintainable internal resolver
 
 Which is still used in production...

Absolutely.  As discussed on #debian-buildd, we'll be keeping it as
the default until it's replaced on the buildds.  But it's certainly
buggy and unmaintainable going forward, and the newer apt and aptitude
resolvers are far simpler, delegating all dependency resolving to the
package manager.  While there are still concerns about predictability/
determinism of the new resolvers which we have yet to fully test and
satisfy, this is not an issue for end-users running squeeze who want
to build packages.

  • direct building from unpacked source trees, á la debuild et al
  • support for running lintian and piuparts
 [...]
  If you would consider this for migration to testing, that would be
  great.  I do anticipate making another release to address any issues
  that come up over the next week, so there's no rush to get the current
  version in unstable in right now; I just want to have a less buggy
  version in the squeeze release that's worthy of putting in the release.
 
 I'm not exactly sure that the new version is fit for releasing.

Are there any particular issues which need addressing?  There's
the required libdpkg-perl issue you've already fixed in git, but this
doesn't affect squeeze/unstable, only lenny.

Regarding bugginess, I've fixed over 30 bugs in the past fortnight,
and a lot of those were hard to tackle issues, some of which had been
outstanding for years.  It's in far, far better shape than what we have
in squeeze.  It certainly won't hurt to let it sit in unstable for a
few weeks to shake out any potential regressions, but it would be nice
for squeeze users to be able to build dpkg-source v3 sources.  If
nothing else, an upload to t-p-u containing just the above two commits
would be better than leaving it.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


sbuild in squeeze

2010-11-08 Thread Roger Leigh
 to install build dependencies), to allow easier
 troubleshooting.

* Major changes in 0.60.1:

  1) Improvements in building of dpkg-source v3 source formats.

  2) sbuild includes a new option --no-source to disable building
 of source packages.  This is the reciprocal of the existing
 --source option.


sbuild (0.60.3-1) unstable; urgency=low

  * New release.
  * sbuild-createchroot:
- Allow direct creation of tarballs from chroots, with various
  options for compression (Closes: #545215).  Thanks to Andres
  Mejia.
  * sbuild-update:
- sbuild-clean functionality has been merged into sbuild-update.
  Thanks to Andres Mejia.
  * sbuild:
- Dependency resolving:
  . 'aptitude' is now the default dependency resolver.  Users
wishing to use the old resolver should set
$build_dep_resolver='internal' in their configuration.
  . The aptitude resolver can resolve complex dependencies.
A | B, where A is uninstallable now correctly falls back to B
(Closes: #403246).
  . Removal of Build-Conflicts now works, due to using apt-get
or aptitude to perform the removal (Closes: #464376).
  . Default to not enabling virtual dependency resolving with the
internal resolver ($resolve_virtual=0).  This is to avoid
changing the historical behaviour by default.
- Don't set Sbuild::debug_level to undef (Closes: #602318).
  Thanks to Andres Mejia.
- Add debuild-like feature to run sbuild on an unpacked source
  tree (Closes: #551311).  In addition to specifying a package
  version to build, or a source package .dsc, a directory may be
  used.  This will be packaged with 'dpkg-source -b' prior to
  building.  Thanks to Andres Mejia.
- Add support for running lintian after a build.  Thanks to Andres
  Mejia.
- Add support for running external commands before and after a
  build, and during chroot setup and cleanup.  These may be used
  to run piuparts, for example.  Thanks to Andres Mejia.
  * Run sbuild-* chroot maintenance commands in the 'source' chroot
namespace for chroots providing such a facility (Closes: #567505).
This means that update/distupgrade etc. operations will occur in
the source volume for lvm-snapshot and btrfs-snapshot chroot types.
Note that the sbuild chroot lock (/var/lock/sbuild) may be copied
into cloned chroots if a build is started during a maintenance
operation and the build will block until the operation is completed.

 -- Roger Leigh rle...@debian.org  Sun, 07 Nov 2010 22:33:15 +

sbuild (0.60.2-1) unstable; urgency=low

  * New release.
  * sbuild:
- Dependency resolving:
  . The aptitude build dependency resolver now sets
Aptitude::CmdLine::Ignore-Trust-Violations based upon the
$apt_allow_unauthenticated option (Closes: #588035).  Thanks to
Ansgar Burchardt for this patch.
  . Improve handling of alternative build dependencies and Provides
using the interal build dependency resolver.  (Closes: #586275,
#578810, #591187, #591188, #591189, #595863, #595866, #595872).
Thanks to Ansgar Burchardt for this patch.
  . Remove virtual build-dependency resolving using the internal
resolver using the static ALTERATIVES (%alternatives) list.  This
was already limited, non-functional, and is obsoleted by the
aptitude resolver.
  . Added the ability to resolve virtual dependencies using the
internal build dependency resolver by calling apt-cache
--names-only to get candidate packages to satisfy the
dependency.  The first package (sorted alphabetically) is
chosen (Closes: #595934).  This may be disabled using the
$resolve_virtual option.
  . Use apt-get to remove build conflicts using the internal
resolver and correctly reinstall post build.
- Log the package source version as well as binary version in the
  package build log, since these may differ when making binNMUs
  (Closes: #569823).
- Always attempt to install ESSENTIAL (build-essential) packages
  if they aren't already installed (Closes: #380113).
- Don't end session on build failure (Closes: #567506).  This allows
  examination of build trees and cloned chroots on build failure,
  rather than unconditionally deleting them, which prevents this.
  Thanks to Jan-Marek Glogowski.
- Remove support for parsing output of apt-get stderr
  (Closes: #571806).
- Check for sbuild group membership using gid and supplementary
  groups (Closes: #599350).
  * buildd:
- Read entire contents of pipes (Closes: #567821).  Thanks to
  Samuel Thibault.  This ensures receipt of complete log
  messages.
- Replace/Breaks with ubuntu-dev-tools = 0.83 (Closes: #590153).
  Thanks to Lorenzo De Liso.
  * buildd-vlog: Fix breakage (Closes: #567822).  Thanks to
Samuel Thibault.  This fix

Re: Pre-approval for schroot 1.4.13-1

2010-10-03 Thread Roger Leigh
On Thu, Sep 30, 2010 at 08:19:21PM +0100, Adam D. Barratt wrote:
 On Sun, 2010-09-26 at 17:00 +0100, Roger Leigh wrote:
  I have updated schroot to fix the RC bug #597368.  This broke buildds
  using plain type chroots which aren't really session capable.  This
  is fixed by creating proxy sessions as aliases so one may use
  --run-session and --end-session with plain chroots.
 [...]
  Is this OK to upload
 
 That's obviously an academic question now. :-)
 
  and go into squeeze?
 
 Unblocked.

Thanks.  The last translation update came in about 12 hours after
making that release and I have subsequently released version
1.4.14-1 containing just that single translation update.  Please
could you unblock this?

(This will be the last required update for squeeze barring any
unforseen issues.)


Many thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Pre-approval for schroot 1.4.13-1

2010-09-26 Thread Roger Leigh
Dear release team,

I have updated schroot to fix the RC bug #597368.  This broke buildds
using plain type chroots which aren't really session capable.  This
is fixed by creating proxy sessions as aliases so one may use
--run-session and --end-session with plain chroots.

Additionally there are
• Six language translation updates.
• A small change to a conditional to correct --all error handling
  which would do the wrong thing in some cases when
  --all-source-chroots was used.  While no bug has been filed about
  this issue, it does need fixing.
• If no sessions existed, the schroot init script would print
  an annoying warning on startup when attempting to recover
  sessions and no sessions were found.  While this is purely cosmetic,
  it would annoy a lot of squeeze users.  This has been fixed by only
  printing the warning when --verbose is used.

The source is available from
http://people.debian.org/~rleigh/schroot-1.4.13/schroot_1.4.13-1.dsc

as are amd64 binaries
http://people.debian.org/~rleigh/schroot-1.4.13/schroot_1.4.13-1_amd64.changes

Is this OK to upload and go into squeeze?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.10-2

2010-09-06 Thread Roger Leigh
On Sun, Sep 05, 2010 at 07:55:17PM +0100, Roger Leigh wrote:
 On Sun, Sep 05, 2010 at 05:09:28PM +0100, Roger Leigh wrote:
  
  #595647 is the only outstanding issue (and it's not a regression,
  just behaviour not matching documentation), and is just a two-liner
  to fix.
 
 I uploaded 1.4.12-1 to fix this issue and also #594720.  I've also
 put the following additional separated diffs at
 http://people.debian.org/~rleigh/schroot-1.4.11-patches/

If the above set of proposed changes is too large and you find
it unacceptable at this stage, I've also prepared a separate set
of patches which basically backport a minimal set of required
changes to 1.4.7-1 in testing.

You can find the full set of patches (and packages) here:
  http://people.debian.org/~rleigh/schroot-squeeze/

The git repo with the patches in is here:
  git://git.debian.org/users/rleigh/schroot.git (branch schroot-squeeze)
  
http://git.debian.org/?p=users/rleigh/schroot.git;a=shortlog;h=refs/heads/schroot-squeeze
  starting from commit 3c44ebbb
(this requires adding as a remote to the main repo at
git://git.debian.org/git/buildd-tools/schroot to tie it into the
main history)

The version number might need adjusting for upload, but I'd appreciate
some feedback so I can proceed getting these bugs fixed for squeeze.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.10-2

2010-09-05 Thread Roger Leigh
On Sun, Aug 29, 2010 at 12:46:52PM +0100, Roger Leigh wrote:
 On Sun, Aug 29, 2010 at 12:07:22PM +0200, Marc 'HE' Brockschmidt wrote:
  Roger Leigh rle...@codelibre.net writes:
   On Sat, Aug 28, 2010 at 01:33:10PM +0200, Marc 'HE' Brockschmidt wrote:
   Roger Leigh rle...@codelibre.net writes:
   Please could you unblock schroot 1.4.10-2? 
127 files changed, 6132 insertions(+), 6896 deletions(-)
   
   *cough* This is a bit much and far away from properly reviewable - even
   if we filter out all autoconf crop and documentation updates. Are all of
   these changes really needed?
   Yes.  If you look at the diffstat (below),
  
  We always do that when reviewing changes. In this case, this ends up with 
  h...@franck:~$ filterdiff -i *.cc -i *.h  schroot-diff  | diffstat
  [...]
   79 files changed, 1255 insertions(+), 726 deletions(-)
  
  As schroot is an important part of the Debian infrastructure, I'm even
  more reluctant to just accept these changes into stable. How have these
  changes been tested?
 
 I've done hand testing of all changes myself in addition to testing
 with the included testsuite. […]

 I've also tested it with sbuild, and all the releases are all
 known to function correctly when run with sbuild.
 
 Releases later than 1.4.7 also deprecate features for removal in
 squeeze+1.  If we don't have an update in squeeze, I'll need to
 postpone some changes until squeeze+2 which I would really prefer
 not to do.

I'm afraid I've been ill for the last few days, but what I have done
is to separate the big diff into separate sets of changes, which
means you can look at things with most of the noise taken out.

The patches are available from
  http://people.debian.org/~rleigh/schroot-1.4.11-patches/

Summary of each patch:

race-fix.diff
  Work around a kernel bug
  Fixes bugs: #593516
  Changes
  • Use an flock file lock when reading /proc/mounts to reduce the
change of racing reading /proc/mounts, which could potentially
lead to catastrophic dataloss if we rm -rf a mounted filesystem
the kernel skipped when reading /proc/mounts.  This isn't a true
fix, since programs mounting/unmounting without taking the same
lock will still trigger this, but the chances are vastly reduced.
  Required: Yes.  This is a very serious bug, and needs fixing for
  squeeze.  Chance of triggering is low, but if running many parallel
  schroot instances, the chance of beginning/ending a session at the
  same time is greatly increased.  Independently tested, and tested by
  me.

session-name-check.diff
  Add strict checking for chroot names
  Fixes bugs: #589889
  Changes
  • Add is_valid_sessionname function; based on is_valid_filename
  Required: Yes.  Closes potential security hole by preventing session
  names from containing relative pathnames which could be abused to
  overwrite files with root privileges.  1.4.7 is not vulnerable, but
  uses a rather stricter check which means many valid session names
  are not permitted.  Tested.

environment.diff
  Correctly set up user environment in chroot
  Fixes bugs: #589830, #589917
  Changes:
  • sbuild::auth::get_minimal_environment unconditionally preserves
TERM and SHELL in the environment.  LOGNAME and USER are also
unconditionally preserved.
  Severity: very important (bad environment under some circumstances,
  fixes a regression introduced in 1.4.7)
  Required for squeeze: Yes (1.4.7 is buggy)

chroot-namespace.diff
  Fixes bugs: #512131
  Addition of support for chroot namespaces.
  Changes
  • sbuild::chroot_config methods now include a namespace argument
  • Validate session names (for security; see above)
  • New functions to search namespaces (find*/lookup*)
  • Chroot listing/info functions also print namespaces
  • Add compatibility aliases to preserve full backward compatibility
with earlier releases
  Required: No.  However, this feature has been long requested by
  several buildd admins (to allow all source chroots to be updated
  using the accompanying --all-source-chroots option (below) which
  this enables).  If it's not in squeeze, we won't be able to update
  dependent tools and deprecate the compatibility aliases until
  squeeze+1, which is IMO too long for a relatively simple change.
  Most changes here are simply adding a chroot_namespace parameter
  which touches most functions, and adjusting existing code to use the
  new find_*/lookup_* functions.  This has been extensively tested.

namespace-session.diff
  Session support for chroot namespaces
  Fixes bugs: N/A
  Changes
  • Don't use a copy of the chroot_config; pass in chroot objects
directly.  This means a number of failure modes are no longer
possible, increasing robustness and security.  Replace string_list
with chroot_list
  • Remove a number of static assertions and checks which are no
longer required.
  • Changes to dchroot session classes; update to use updated
interfaces
  Required: It's a prerequisite for namespace support

Re: Please unblock schroot 1.4.10-2

2010-09-05 Thread Roger Leigh
On Sun, Sep 05, 2010 at 05:09:28PM +0100, Roger Leigh wrote:
 
 #595647 is the only outstanding issue (and it's not a regression,
 just behaviour not matching documentation), and is just a two-liner
 to fix.

I uploaded 1.4.12-1 to fix this issue and also #594720.  I've also
put the following additional separated diffs at
http://people.debian.org/~rleigh/schroot-1.4.11-patches/

1.4.12-autogenerated.diff
  Autogenerated changes.

1.4.12-build.diff
  Build changes.  Version number bump and backport of git release
  script from the mainline needed for making releases (not used
  by end users or for building).

1.4.12-changes.diff
  Code fixes for #595647 and #594720 and Debian changelog update


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock gutenprint 5.2.6-1

2010-08-29 Thread Roger Leigh
On Sun, Aug 29, 2010 at 12:03:48PM +0200, Marc 'HE' Brockschmidt wrote:
 Roger Leigh rle...@codelibre.net writes:
  On Sat, Aug 28, 2010 at 01:34:10PM +0200, Marc 'HE' Brockschmidt wrote:
  Roger Leigh rle...@codelibre.net writes:
   Please could you unblock gutenprint 5.2.6-1?
   245 files changed, 114059 insertions(+), 82843 deletions(-)
  
  Why?
  It's a new upstream release which adds new support for
  5 Canon printers
 12 Epson printers
111 PCL printers
  as well as a number of changes for existing supported models.
 
  These are mainly new models which won't be supported in squeeze
  without this update.
 
 Yes, and the same argument holds for the new features of $foobar which
 will not be supported in squeeze because we have frozen.

Sure, but this is hardware support, and users will be stuck with
unusable printers if they don't have the current stable release
(and I must emphasise that this is a stable upstream release that
they have tested extensively--gutenprint upstream is very
conservative and this is just a point release of a very well
tested stable series).  This should not be a risky update--
it does not introduce new features, and it almost all purely
support for new printer models; the core logic is unchanged.

Gutenprint has an extensive testsuite--it takes several tens of hours
to run--and it's passed that.

 I disagree. Sorry, I really don't see how we can reasonably review
 this.

(I have looked over the diffs, and I was the original author of
a good chunk of it.)

The driver logic is separated into two parts
1) XML metadata
2) Code
The XML metadata for each model references code (generally static
tables) that describe inks, paper types, print head features etc.
Support for a new model involves addition of the XML description
and also addition of new tables in code (if different than already
supported models).  The changes in this release are mainly XML, plus
some new data tables.

Upstream have also refactored some debugging/assertion macros in
this release, so most of the code changes are just changes in
capitalisation for that.  There are also some changes to the
Foomatic generator code to keep up-to-date with current foomatic
(this is just glue logic to integrate with print spoolers other
than CUPS)


It's up to you, but I don't personally think this is a major risk;
I think having support for new hardware is important to have, and
it was just bad timing that we froze 4 days before this 6 month
update.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Please unblock gutenprint 5.2.6-1

2010-08-28 Thread Roger Leigh
Dear release team,

Please could you unblock gutenprint 5.2.6-1?

This is a new upstream point release which adds support for
many new printers, fixes support for some existing printers
and adds a new translation.  There's also some trivial
cleanup of the Debian packaging.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock schroot 1.4.10-2

2010-08-28 Thread Roger Leigh
On Sat, Aug 28, 2010 at 01:33:10PM +0200, Marc 'HE' Brockschmidt wrote:
 Hi Roger,
 
 Roger Leigh rle...@codelibre.net writes:
  Please could you unblock schroot 1.4.10-2?
 
  127 files changed, 6132 insertions(+), 6896 deletions(-)
 
 *cough* This is a bit much and far away from properly reviewable - even
 if we filter out all autoconf crop and documentation updates. Are all of
 these changes really needed?

Yes.  If you look at the diffstat (below), you'll see that the
majority of the changes are translation and doxygen template
changes.  The source changes are mainly confined to
- additions and updates to the doxygen documentation
- namespace support (sbuild-chroot-config.cc)
- unifying chroot name and session name (a number of single line
  changes to most of the source files below)

I have reviewed all the source changes myself, being the upstream
as well as the Debian packager.  As in, I've been through the diffs
several times over line by line with each release.  1.4.11-1 should
be as stable as 1.4.7-1 and it contains a good number of bugfixes
(some RC).

There was a long list of wishlist bugs I wanted to fix for squeeze
in the BTS in addition to a number of actual bugs in the software
of various severities.  I've fixed all the outstanding bugs and
added/updated several features in order to complete all the
outstanding issues.  This new release is the result of that, and
it's what I'd like to be released with squeeze.  This work was
completed in the 1.4.8 release with the subsequent 4 releases
over the past few weeks being confined to translation updates and
a few small one liner bugfixes.

(Note I just uploaded 1.4.11-1 to fix a single new issue).


Regards,
Roger



% git diff --stat release/schroot-1.4.7..release/schroot-1.4.11
 Makefile.am|5 +-
 NEWS   |   62 +-
 README |   25 +-
 TODO   |   13 +-
 bin/dchroot-dsa/dchroot-dsa-chroot-config.cc   |   16 +-
 bin/dchroot-dsa/dchroot-dsa-chroot-config.h|   12 +-
 bin/dchroot-dsa/dchroot-dsa-main.cc|3 +-
 bin/dchroot-dsa/dchroot-dsa-main.h |3 +
 bin/dchroot-dsa/dchroot-dsa-session.cc |5 +-
 bin/dchroot-dsa/dchroot-dsa-session.h  |4 +-
 bin/dchroot/dchroot-chroot-config.cc   |   16 +-
 bin/dchroot/dchroot-chroot-config.h|   12 +-
 bin/dchroot/dchroot-main.cc|5 +-
 bin/dchroot/dchroot-main.h |3 +
 bin/dchroot/dchroot-session-base.cc|5 +-
 bin/dchroot/dchroot-session-base.h |4 +-
 bin/dchroot/dchroot-session.cc |   11 +-
 bin/dchroot/dchroot-session.h  |   12 +-
 bin/schroot-base/schroot-base-main.h   |7 +
 bin/schroot-base/schroot-base-option-action.h  |   24 +-
 bin/schroot-base/schroot-base-options.h|1 +
 bin/schroot-listmounts/schroot-listmounts-main.h   |3 +
 bin/schroot-mount/schroot-mount-main.h |3 +
 bin/schroot-releaselock/schroot-releaselock-main.h |3 +
 bin/schroot/schroot-main-base.cc   |  103 +-
 bin/schroot/schroot-main-base.h|   11 +-
 bin/schroot/schroot-main.cc|4 +-
 bin/schroot/schroot-main.h |3 +
 bin/schroot/schroot-options-base.cc|   53 +-
 bin/schroot/schroot-options-base.h |4 +-
 bin/schroot/schroot-options.cc |7 +-
 configure.ac   |   74 +-
 debian/.gitignore  |2 +
 debian/changelog   |   66 +
 debian/control |7 +-
 debian/rules   |   46 +-
 doc/Makefile.am|   27 +-
 doc/sbuild.dox.in  | 1412 ++--
 doc/schroot.dox.in | 1390 ++--
 etc/schroot.conf   |8 -
 etc/setup.d/10mount|   29 +-
 man/schroot.1.in   |   85 +-
 man/schroot.conf.5.in  |4 +-
 po/LINGUAS |1 +
 po/Makevars|2 +-
 po/cs.po   |  813 +++
 po/da.po   | 1377 +++
 po/de.po   |  429 +--
 po/en.po   |  396 +-
 po/eu.po   |  398 +-
 po/fr.po   |  515

Re: Please unblock gutenprint 5.2.6-1

2010-08-28 Thread Roger Leigh
On Sat, Aug 28, 2010 at 01:34:10PM +0200, Marc 'HE' Brockschmidt wrote:
 Roger Leigh rle...@codelibre.net writes:
  Please could you unblock gutenprint 5.2.6-1?
 
  245 files changed, 114059 insertions(+), 82843 deletions(-)
 
 Why?

It's a new upstream release which adds new support for
5 Canon printers
   12 Epson printers
  111 PCL printers
as well as a number of changes for existing supported models.

These are mainly new models which won't be supported in squeeze
without this update.

Looking at the diffstat, the number of code changes is minimal;
the vast majority of those changes are translation updates,
followed by updates and additions to the plain text printer
definitions in XML format.

  There's also some trivial cleanup of the Debian packaging.
 
 That's not something you should do during the freeze.

It was simply dropping unused dpatch logic given that the
package has been in git for some time now and fixing how
we called the configure script (which was broken).  The
addition of debian/source/format and update of Standards-Version
was probably superfluous, but that's it.  The small diff of those
changes is attached.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff --git a/debian/changelog b/debian/changelog
index 703de6d..8936f72 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+gutenprint (5.2.6-1) unstable; urgency=low
+
+  * New upstream stable release.
+  * Use source format 3.0 (quilt), drop dpatch support.
+  * Upgrade to Standards Version 3.9.1 (no changes).
+  * Drop unused --with-ijs configure argument.
+  * debian/rules install-stamp rule depends on build-stamp
+rather than build (which is phony).
+
+ -- Roger Leigh rle...@debian.org  Sun, 15 Aug 2010 14:15:09 +0100
+
 gutenprint (5.2.5-1) unstable; urgency=low
 
   * New upstream stable release. 
diff --git a/debian/control b/debian/control
index 924ac20..d70a3ed 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: graphics
 Priority: optional
 Maintainer: Debian Printing Group debian-print...@lists.debian.org
 Uploaders: Roger Leigh rle...@debian.org, W. van den Akker 
wvdak...@wilsoft.nl
-Standards-Version: 3.8.4
+Standards-Version: 3.9.1
 Build-Depends: libcups2-dev, libcupsimage2-dev, libgimp2.0-dev, 
libreadline-dev, libijs-dev, debhelper (= 7.0.0), zlib1g-dev, flex, gettext, 
foomatic-db-engine, chrpath, quilt
 Vcs-Browser: http://git.debian.org/?p=collab-maint/gutenprint.git
 Vcs-Git: git://git.debian.org/git/collab-maint/gutenprint
diff --git a/debian/rules b/debian/rules
index d284038..596964b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,9 +7,6 @@
 # This has to be exported to make some magic below work.
 export DH_OPTIONS
 
-# Use dpatch.
-include /usr/share/quilt/quilt.make
-
 # These are used for cross-compiling and for saving the configure script
 # from having to guess our platform (since we know it already)
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
@@ -56,14 +53,14 @@ debian/autoconfigure-stamp: debian/control
  --with-modules=dlopen \
  --enable-libgutenprintui2 --with-gimp2 \
  --with-cups --enable-cups-level3-ppds --enable-globalized-cups-ppds \
- --with-ijs --with-foomatic --with-foomatic3 \
+ --with-foomatic --with-foomatic3 \
  --disable-test
 
touch $@
 
 
 build: debian/build-stamp
-debian/build-stamp: patch debian/autoconfigure-stamp
+debian/build-stamp: debian/autoconfigure-stamp
dh_testdir
 
cd debian/build; \
@@ -71,7 +68,7 @@ debian/build-stamp: patch debian/autoconfigure-stamp
 
touch $@
 
-clean: realclean unpatch
+clean: realclean
 realclean: debian/control
dh_testdir
 
@@ -101,7 +98,7 @@ install-common: debian/install-stamp
dh_installdirs
dh_install
 
-debian/install-stamp: build debian/control
+debian/install-stamp: debian/build-stamp debian/control
cd debian/build; \
$(MAKE) DESTDIR=$(CURDIR)/debian/install install
 
@@ -148,4 +145,4 @@ binary-arch: install-arch
 
 binary: binary-indep binary-arch
 
-.PHONY: build clean binary-indep binary-arch binary install install-arch 
install-indep install-common autoconfigure patch unpatch update-patch-series
+.PHONY: build clean binary-indep binary-arch binary install install-arch 
install-indep install-common autoconfigure update-patch-series
diff --git a/debian/source/format b/debian/source/format
new file mode 100644
index 000..163aaf8
--- /dev/null
+++ b/debian/source/format
@@ -0,0 +1 @@
+3.0 (quilt)


signature.asc
Description: Digital signature


Re: freeze exception for gcc-4.5 (i386, amd64 only)

2010-08-23 Thread Roger Leigh
On Mon, Aug 23, 2010 at 10:03:05AM +0200, Mike Hommey wrote:
 On Mon, Aug 23, 2010 at 04:05:32AM +0200, Matthias Klose wrote:
  On 21.08.2010 14:56, Julien Cristau wrote:
  On Fri, Aug 20, 2010 at 19:33:12 +0200, Arthur Loiret wrote:
  
  Now, to be clear, what nice things would gcc-4.5 bring to our users?
  There is a complete list here [0], but those ones are, in my opinion,
  very nice:
- The new link time optimiser.
- Improved C++0x support.
- Plugins support.
  
  My understanding is that lto in 4.5 is not quite there yet.  Not that
  I've tried it or anything.
  
  I don't share your understanding. I tried it for some builds.
 
 Maybe it works on small things, but I heard it doesn't work very well
 for stuff like mozilla. 4.6 is supposed to get better.

I'm certainly concerned about issues such as #593876 where the
stricter linking breaks existing code.  I'm not sure about the
rationale for this extra strictness, but it does cause
unwanted breakage by breaking existing assumptions about
indirect linking.

Other than that, it's working fine for me.  It would be nice to
have in the release as an optional and non-default compiler for
developers who need it.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: [Pkg-postgresql-public] Dropping postgresql 8.3 for squeeze

2010-01-02 Thread Roger Leigh
On Wed, Dec 30, 2009 at 09:06:38PM +0100, Dimitri Fontaine wrote:
 Martin Pitt mp...@debian.org writes:
 
  Dimitri Fontaine [2009-12-30 10:52 +0100]:
  That's why I proposed having a single binary package for any extension,
  embedding support for more than one major version of PostgreSQL. That
  would match how the code is maintained.
 
  That would be a major regression wrt. upgrades, though, since an
  upgrade from e. g. etch (8.1) to lenny (8.3) would upgrade
  postgresql-foo and thus the 8.1 extension wouldn't be available any
  more. With postgresql-foo-{8.1,8.3} you can install both side by side.
 
 Yeah. I'm too much into trying to have this deprecation policy in order
 to have all upstream maintained debian packages into debian stable it
 seems.
 
 Let's pursue the debian/control.in all automated build-depends and
 dynamic binary packages list idea then.

I'll adopt whatever the consensus is once agreed upon in my
postgresql-debversion package.  I can also put in conditionals
to make it build with older versions again, but I'd like a
pointer to an example to see what's needed to conditionally
build  8.4.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: [Pkg-postgresql-public] Dropping postgresql 8.3 for squeeze

2010-01-02 Thread Roger Leigh
On Sat, Jan 02, 2010 at 09:18:35PM +0100, Dimitri Fontaine wrote:
 Roger Leigh rle...@codelibre.net writes:
  to make it build with older versions again, but I'd like a
  pointer to an example to see what's needed to conditionally
  build  8.4.
 
 That depends a lot on what features of 8.4 you're specifically talking
 about, but I guess the following example could help you there:
 
   http://github.com/dimitri/prefix/blob/master/prefix.c

That's just what I was looking for, thanks!


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: [Pkg-postgresql-public] Dropping postgresql 8.3 for squeeze

2009-12-30 Thread Roger Leigh
On Wed, Dec 30, 2009 at 10:52:27AM +0100, Dimitri Fontaine wrote:
 That's why I proposed having a single binary package for any extension,
 embedding support for more than one major version of PostgreSQL. That
 would match how the code is maintained.

But is this true universally?  Take my postgresql-debversion
extension, for example.  In lenny-backports and squeeze, I
supported building against both 8.3 and 8.4 (possibly earlier as
well--untested).  For the new version now in unstable, I use
8.4-specific features which means it /won't build/ with 8.3 or
earlier releases.

You still need to know exactly which versions a given release
of a given extension supports--it's not a given that it will
support all versions.

While I think it might be possible to introduce a versionless
extension package name, IMO this should only be a dependency-only
package which installs the extension for the current server version
(like postgresql-client et al).

I have to confess, I'm still not entirely clear what the problem
is here; when you install a new server version, the old extensions
are still available; one just needs to install the equivalent set
for the new server version prior to migrating data.  Is the lack
of automation here the problem?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Incompatible change to Boost library names

2009-08-30 Thread Roger Leigh
Hi,

Boost used to contain regular library names without an -st or -mt
suffix to indicate building for single- or multi-threaded use.

Boost 1.57/58 (if not earlier) switched to only providing libraries
with an -mt suffix.  This was fine, but did mean as an upstream I
was required to patch my packages to find the -mt library variants
and make sure my code was built with -pthread.

Boost 1.59 appears to have reverted this change:
% dpkg -L libboost-program-options1.39-dev | grep .so
/usr/lib/libboost_program_options.so

/usr/share/doc/libboost-program-options1.39-dev/README.Debian
still lists '-lboost_program_options-mt' as the name to use,
however.

Is this change intentional, or just a bug in the 1.59 packaging?

Does this retain or break compatibility with other distributions
using Boost, and/or a stock build of Boost?

If it's intentional, I'm going to have to make (another) incompatible
change to my configure script to make my stuff build again :(
And it also means code can't build with any version prior to 1.59 once
you update your configure code.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Incompatible change to Boost library names

2009-08-30 Thread Roger Leigh
On Sun, Aug 30, 2009 at 11:59:35AM -0500, Steve M. Robbins wrote:
 On Sun, Aug 30, 2009 at 02:04:18PM +0200, Andreas Barth wrote:
  * Roger Leigh (rle...@codelibre.net) [090830 11:09]:
 
   Is this change intentional, or just a bug in the 1.39 packaging?
  
   Does this retain or break compatibility with other distributions
   using Boost, and/or a stock build of Boost?
 
 The change was made upstream, so yes it is intentional and Debian will
 have the same link names as other distributions.

Ah, OK.  If it's going to improve compatibility with others, then
that's fine.  

 I'm open to suggestions.  Perhaps the best way forward is to
 re-introduce an -mt variant name as a symlink to the non-mt name.  If
 that's agreeable, I'll get it done today.

I can't speak for the release team, but if that could be done for
1.59 and then dropped for 1.60, it would at least keep existing
packages building during a transition period.  If the other boost
package maintainers could be notified of this, it then gives us a
month or so of breathing space to fix everything up.  I guess then
moving to 1.60 should then be relatively pain-free.


Thanks!
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: sbuild bug #395271 on various buildds

2009-08-13 Thread Roger Leigh
On Thu, Aug 13, 2009 at 11:19:11PM +0200, Luk Claes wrote:
 Tim Retout wrote:
  There is a bug in sbuild on various buildds (at least hppa, ia64, mips,
  mipsel, s390, sparc) with versioned dependencies and virtual packages.
  The details are in bug #395271, and it was fixed in sbuild 0.57.4-1.
 
 versioned dependencies on virtual packages are not supported and are
 still a bug AFAICS.

Yes, and (correct me if I'm wrong), but I don't think there's any
prospect of it becoming supported.  Since it's virtual, each package
providing it will have a different version number, so it makes no
sense to have one in the dependency.  If you need a versioned
depdendency, you need to depend upon a real package, or set of
alternative packages perhaps with each having a version requirement.

Does apt even support this?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: sbuild bug #395271 on various buildds

2009-08-13 Thread Roger Leigh
On Thu, Aug 13, 2009 at 11:42:25PM +0200, Philipp Kern wrote:
 isn't the problem rather that an older version is provided by perl-modules
 which is overridden by a real package which has a newer version?  Still
 broken IMHO, though.

That rings a bell, but I can't recall the specifics offhand.  We've
certainly seen stuff like that in the past, though I thought we handled
provides a bit better now.


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: [buildd-tools-devel] octave3.2 autobuild problems

2009-07-21 Thread Roger Leigh
On Tue, Jul 21, 2009 at 08:26:43PM +0300, Riku Voipio wrote:
 On Tue, Jul 21, 2009 at 02:04:24PM +0300, Riku Voipio wrote:
  On Tue, Jul 21, 2009 at 12:53:19PM +0200, Thomas Weber wrote:
correct. It might have something to do with what packages have been 
unpacked
before octave 3.2 postinst is run.
 
   Can you make the build log(s) available up until the hang (I assume there
   is such a thing, but I'm not familiar with buildd's handling of blocking
   builds). If possible, for octave-audio, but I'll take whatever you have,
   obviously :)
 
  experimental build logs can be found from experimental.debian.net:
 
  http://experimental.debian.net/fetch.php?pkg=octave-audiover=1.1.4-1arch=armelstamp=1248003676file=logas=raw
  
 
 I can't reproduce this in a chroot. However, I can reproduce it
 with the sbuild. both installing octave3.2 and running by hand:
 
 octave-3.2.0-silent --no-history --no-init-file --eval pkg ('rebuild');
 
 work just fine. But during the install of octave3.2 when doing
 
   sbuild -d experimental octave-audio_1.1.4-1
 
 octave hangs on the above command during postinst! notice that experimental
 buildd's use a old sbuild patched for experimental:

Yes.  We have included some changes to better support dependency
resolution when building experimental packages.  However, we haven't
AFAIK included all the changes yet.  I'll be happy to integrate them;
I just need the patches.

Is it known what the postinst is blocking on?  What's happening here
that's different between the unstable and experimental sbuilds?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: What about default-syslog [Re: new release goal default-mta?]

2009-05-05 Thread Roger Leigh
On Tue, May 05, 2009 at 10:36:51AM +0200, Michael Biebl wrote:
 martin f krafft wrote:
  [moving debian-rele...@l.d.o to Bcc, continuing discussion in bug log]
  
  also sprach Andreas Metzler ametz...@downhill.at.eu.org [2009.05.04.1856 
  +0200]:
  FWIW as previously discussed on debian-devel starting with the
  lastest upload (4.69-10) exim4-daemon-light provides default-mta.
  
  Excellent. If there are no objections, I'll formulate a squeeze
  release goal and file the bugs.
  
 
 As maintainer of rsyslog I followed this discussion with great interest.
 Atm there are around 30 packages which depend/recommend
 rsyslog | system-log-daemon
 (or still use sysklogd | system-log-daemon, for which I have filed bugs in the
 past to change that to rsyslog | system-log-daemon).
 
 My generell feeling I got from the discussion, is that the (virtual) 
 default-mta
  package is considered a good idea, so should we use the some approach for
 system-log-daemons and introduce a default-syslog package?

I think it is a problem extending to all virtual packages, and I would
like to see a more general solution which is applicable to all.  It
might be worth revisiting past discussion, for example this thread:

http://lists.debian.org/debian-devel/2006/08/msg01281.html

(I've CCd -devel and -policy because it's a general issue which should
ideally be in policy)

The above discussion proposed a solution like default-mta.  At the time,
I also wrote a sample virtual-default package which generated these
-defaults packages for all virtual packages in the archive.  At the time
I held off actually implementing this because Anthony Towns said he was
implementing a better method in dpkg itself.  However, I've not seen any
more about this other than that single time, and if mta-defaults is being
created it looks like we are still looking for a solution.

It would be great if we can have a general method for specifying
distribution-wide virtual package defaults, of which
mail-transport-agent-default is just one.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: What about default-syslog [Re: new release goal default-mta?]

2009-05-05 Thread Roger Leigh
On Tue, May 05, 2009 at 09:07:34PM +0900, Osamu Aoki wrote:

 On Tue, May 05, 2009 at 11:52:29AM +0100, Roger Leigh wrote:
  On Tue, May 05, 2009 at 10:36:51AM +0200, Michael Biebl wrote:
   martin f krafft wrote:
[moving debian-rele...@l.d.o to Bcc, continuing discussion in bug log]
 ...
  I think it is a problem extending to all virtual packages, and I would
  like to see a more general solution which is applicable to all.  It
  might be worth revisiting past discussion, for example this thread:
  
  http://lists.debian.org/debian-devel/2006/08/msg01281.html
  
  (I've CCd -devel and -policy because it's a general issue which should
  ideally be in policy)
  
  The above discussion proposed a solution like default-mta.  At the time,
  I also wrote a sample virtual-default package which generated these
  -defaults packages for all virtual packages in the archive.  At the time
  I held off actually implementing this because Anthony Towns said he was
  implementing a better method in dpkg itself.  However, I've not seen any
  more about this other than that single time, and if mta-defaults is being
  created it looks like we are still looking for a solution.
 
 A word like default tends to create tension.  Extending existing idea
 like sensible-utils package for sensible-* command wrapper seems to
 be good idea. 

I'm not sure I understand what you mean here.  The sensible-* command
wrappers are wrappers for individual commands.  The above discussion
isn't about default commands, but packages.  For each virtual package,
we (as a distribution) need to choose a default package to provide a
concrete implementation.  It /is/ a default, and I'm not sure I
understand the need to name it differently.  It is always possible for
the system administrator to install any other package also providing
the virtual package, but a default /must/ exist.

  It would be great if we can have a general method for specifying
  distribution-wide virtual package defaults, of which
  mail-transport-agent-default is just one.
 
 As I read this and looking at our archive, we have:
 
 Package sensible-mda (Priority: extra)
 * Packaged by: Richard Nelson cow...@debian.org
 * Sendmail source package
 * On and after lenny (stable) (mail): Mail Delivery Agent wrapper
   used by dspam and sendmail
   procmail | maildrop | deliver
 
 Package sensible-utils (Priority: required)
 * Packaged by: Clint Adams sch...@debian.org
 * Sensible-utils  source package
 * On and after squeeze (testing) (utils): Utilities for sensible 
 alternative selection
   these scripts used to be part of debianutils
   this provides sensible-{browser,editor,pager}
 
 If a command is expected to be always on the system, integrate it into
 sensible-utils seems good idea ... especially for mta and syslog if
 Clint agrees.
 
 (If a command is an optional one on the system, create package like
 sensible-mda.)

While it's typically the case that an MTA and system logger are installer,
it isn't /required/.  It also doesn't cover the more general case for
all virtual packages.  Where a package provides a network service, for
example, the common feature between the packages is that they listen
on the same port and talk the same protocol.  A sensible-* command is
not useful in this scenario--the init script, executable binaries etc.
might have nothing in common.

A virtual package provides an implementation of something.  That might be
a command, network service, or any other facility so long as the packages
providing it agree on what the something is.  This can only be solved
at the level of package dependencies (or a configurable virtual defaults
mapping in dpkg, but this doesn't exist).


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: upcoming point releases

2009-03-28 Thread Roger Leigh
On Sat, Mar 28, 2009 at 02:50:47PM +0100, Philipp Kern wrote:
 On Mon, Mar 23, 2009 at 10:18:55AM +, Roger Leigh wrote:
  Could I have the go-ahead to upload schroot_1.2.2-0+lenny1 to
  stable-proposed-updates please?
 
 Go ahead.

Thanks.  The final package is at

http://www.codelibre.net/~rleigh/schroot_1.2.2-0+lenny1.dsc

with the upstream diff as attached.

I've double checked the full debdiff and the changes are
summarised as follows:

Upstream changes:
schroot-1.2.1/NEWS
schroot-1.2.1/configure.ac
schroot-1.2.1/debian/changelog
schroot-1.2.1/m4/acx_pthread.m4
schroot-1.2.1/scripts/global.mk

Generated files:

schroot-1.2.1/ChangeLog (generated from git)
schroot-1.2.1/m4/schroot_release.m4 (generated prior to autotools bootstrap)

Autotools rebootstrap:
schroot-1.2.1/*/Makefile.in
schroot-1.2.1/aclocal.m4
schroot-1.2.1/config.h.in
schroot-1.2.1/configure
schroot-1.2.1/m4/inttypes.m4
schroot-1.2.1/m4/isc-posix.m4
schroot-1.2.1/m4/signed.m4
schroot-1.2.1/scripts/mkinstalldirs

Doxygen documentation:
schroot-1.2.1/doc/sbuild/*
schroot-1.2.1/doc/schroot/*


I've reviewed all the changes by hand, and it all looks OK.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff --git a/NEWS b/NEWS
index c8a0cc4..3988f4e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,12 +1,16 @@
 NEWS-*- outline -*-
 
 
-Welcome to schroot 1.2.1.  Please read these release notes carefully.
+Welcome to schroot 1.2.2.  Please read these release notes carefully.
 
 Full installation instructions are provided in the INSTALL file.  The
 README file also contains more specific notes regarding building and
 configuration.
 
+* Major changes in 1.2.2:
+
+  None.
+
 * Major changes in 1.2.1:
 
   1) A new chroot type, loopback, has been added.  This is similar
diff --git a/configure.ac b/configure.ac
index 74ff1a0..059bae3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
 #  -*- Autoconf -*-
-# Copyright © 2004-2008  Roger Leigh rle...@debian.org
+# Copyright © 2004-2009  Roger Leigh rle...@debian.org
 #
 # schroot is free software: you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -40,7 +40,7 @@ dnl
 pushdef([SBUILD_NAME],  [schroot])
 pushdef([SBUILD_MAJOR_VERSION], [1])
 pushdef([SBUILD_MINOR_VERSION], [2])
-pushdef([SBUILD_MICRO_VERSION], [1])
+pushdef([SBUILD_MICRO_VERSION], [2])
 pushdef([SBUILD_EXTRA_VERSION], [])
 pushdef([SBUILD_CURRENT_INTERFACE], [1])
 pushdef([SBUILD_INTERFACE_AGE], [0])
@@ -177,6 +177,7 @@ fi
 # Checks for programs.
 AC_PROG_CXX
 AC_LANG([C++])
+ACX_PTHREAD([], [AC_MSG_ERROR([POSIX thread support is required for correct 
std::tr1::shared_ptr operation])])
 AC_ENABLE_SHARED
 AC_DISABLE_STATIC
 AC_PROG_LIBTOOL
diff --git a/debian/changelog b/debian/changelog
index 33ba87c..4281097 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,25 @@
+schroot (1.2.2-0+lenny1) stable; urgency=low
+
+  * Backport of #520713 for stable:
+Compile and link with POSIX thread support (Closes: #520713).
+libstdc++ std::tr1::shared_ptr does not appear to work
+correctly on Alpha without -pthread, failing during shared_ptr
+construction or assignment due to a failed internal glibc
+assertion while locking a pthread mutex.
+
+ -- Roger Leigh rle...@debian.org  Thu, 26 Mar 2009 15:22:31 +
+
+schroot (1.2.2-1) unstable; urgency=low
+
+  * New upstream stable release. 
+  * Compile and link with POSIX thread support (Closes: #520713).
+libstdc++ std::tr1::shared_ptr does not appear to work
+correctly on Alpha without -pthread, failing during shared_ptr
+construction or assignment due to a failed internal glibc
+assertion while locking a pthread mutex.
+
+ -- Roger Leigh rle...@debian.org  Sun, 22 Mar 2009 16:56:38 +
+
 schroot (1.2.1-1) unstable; urgency=low
 
   * New upstream stable release.
diff --git a/m4/acx_pthread.m4 b/m4/acx_pthread.m4
new file mode 100644
index 000..eb09f5a
--- /dev/null
+++ b/m4/acx_pthread.m4
@@ -0,0 +1,275 @@
+# ===
+#  http://autoconf-archive.cryp.to/acx_pthread.html
+# ===
+#
+# SYNOPSIS
+#
+#   ACX_PTHREAD([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]])
+#
+# DESCRIPTION
+#
+#   This macro figures out how to build C programs using POSIX threads. It
+#   sets the PTHREAD_LIBS output variable to the threads library and linker
+#   flags, and the PTHREAD_CFLAGS output variable to any special C compiler
+#   flags that are needed. (The user can also force certain compiler
+#   flags

Re: Bug#520713: init script start hangs (request for stable update)

2009-03-25 Thread Roger Leigh
On Tue, Mar 24, 2009 at 04:49:10PM +0100, Philipp Kern wrote:
 On Sun, Mar 22, 2009 at 05:34:24PM +, Roger Leigh wrote:
  Following finding the cause of this failure, I'd like to propose
  the following patch (attached)  to correct it.  This is also in
  git; the last five commits on the schroot-lenny branch:
  
  http://git.debian.org/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-lenny
  
  This is a new upstream 1.2.2 release, with a corresponding
  1.2.2-1 version for upload to unstable.
 
 Empty .diff.gz files.  Not something I like.

This is because while it's effectively Debian-native, having
an upstream/debian sepatation does make patching prior
releases, backporting, etc. easier.  Especially with regard
to versioning and making new releases.

  http://www.codelibre.net/~rleigh/schroot_1.2.2-1.dsc
  http://www.codelibre.net/~rleigh/schroot_1.2.2-1.diff.gz
  http://www.codelibre.net/~rleigh/schroot_1.2.2.orig.tar.gz
 
  1653 files changed, 23349 insertions(+), 43811 deletions(-)
 
  Stable release managers: I would like to upload the exact same
  package to stable with a version of 1.2.2-1~lenny1 (or whatever
  number is most appropriate for you).  This will fix the current
  breakage on Alpha systems.
 
 Somehow I'd like a backported fix more (with 1.2.1-1+lenny1), but if it's
 really only a really huge chunk of documentation and autotools foo and
 you convince me that nothing else is burried in there...

The files changed are as in the diff I attached.  I did a new upstream
release, rather than patching in the diff, because it required changing
the upstream configure with a new m4 macro, and then regenerating by
re-bootstrapping with the autotools.  Also, the bug was really an
upstream bug rather than specifically Debian-related, so it did
warrant a new upstream release.

All the changed files are from autotools rebootstrapping, plus
regenerating the documentation with doxygen.

I will go through the debdiff and verify that this is the case;
I have no reason to suspect it is not, but I'll double check.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Bug#520713: init script start hangs (request for stable update)

2009-03-25 Thread Roger Leigh
On Wed, Mar 25, 2009 at 10:52:47AM +, Roger Leigh wrote:
 On Tue, Mar 24, 2009 at 04:49:10PM +0100, Philipp Kern wrote:
  On Sun, Mar 22, 2009 at 05:34:24PM +, Roger Leigh wrote:
   Following finding the cause of this failure, I'd like to propose
   the following patch (attached)  to correct it.  This is also in
   git; the last five commits on the schroot-lenny branch:
   
   http://git.debian.org/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-lenny
   
   This is a new upstream 1.2.2 release, with a corresponding
   1.2.2-1 version for upload to unstable.
  
   http://www.codelibre.net/~rleigh/schroot_1.2.2-1.dsc
   http://www.codelibre.net/~rleigh/schroot_1.2.2-1.diff.gz
   http://www.codelibre.net/~rleigh/schroot_1.2.2.orig.tar.gz
  
   1653 files changed, 23349 insertions(+), 43811 deletions(-)
  
   Stable release managers: I would like to upload the exact same
   package to stable with a version of 1.2.2-1~lenny1 (or whatever
   number is most appropriate for you).  This will fix the current
   breakage on Alpha systems.
  
  Somehow I'd like a backported fix more (with 1.2.1-1+lenny1), but if it's
  really only a really huge chunk of documentation and autotools foo and
  you convince me that nothing else is burried in there...
 
 The files changed are as in the diff I attached.  I did a new upstream
 release, rather than patching in the diff, because it required changing
 the upstream configure with a new m4 macro, and then regenerating by
 re-bootstrapping with the autotools.  Also, the bug was really an
 upstream bug rather than specifically Debian-related, so it did
 warrant a new upstream release.
 
 All the changed files are from autotools rebootstrapping, plus
 regenerating the documentation with doxygen.

 I will go through the debdiff and verify that this is the case;
 I have no reason to suspect it is not, but I'll double check.

OK, I looked through the debdiff.  Other than the files patched
by me in the new releases, all of those other changes are

a) autotools reboostrap
b) doxygen documentation regeneration

I can backport this to 1.2.1, since it's a minor change, but all
that autotools rebootstrapping will just go into the debian
.diff.gz instead of the upstream tarball, which is IMO messier.
The same files will change either way; the only difference is
where they get put.

This is excluding the doxygen docs.  With a backport, these
wouldn't get regenerated.  However, this is just due to a
change in the unstable doxygen; the actual content is the
same.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: upcoming point releases

2009-03-23 Thread Roger Leigh
On Sun, Mar 22, 2009 at 08:26:21PM +0100, Luk Claes wrote:
 The upcoming point releases for both Etch and Lenny are planned for
 April 4th.
 
 [1] http://release.debian.org/proposed-updates/stable.html

I'd like to get #520713 fixed in a stable update (schroot failure on
alpha due to pthread mutex locking bug in libstdc++).  The tested
patch is attached to the bug report, and has also been uploaded to
unstable.

Could I have the go-ahead to upload schroot_1.2.2-0+lenny1 to
stable-proposed-updates please?


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Re: Bug#520713: init script start hangs (request for stable update)

2009-03-22 Thread Roger Leigh
tags 520713 + fixed-upstream patch pending
thanks

On Sun, Mar 22, 2009 at 10:54:52AM +0100, Peter Palfrader wrote:
 Package: schroot
 Version: 1.2.1-1
 Severity: critical
 
 On goetz (our alpha buildd) the init script's start action hangs, causing the
 system to not boot up cleanly.

Following finding the cause of this failure, I'd like to propose
the following patch (attached)  to correct it.  This is also in
git; the last five commits on the schroot-lenny branch:

http://git.debian.org/?p=buildd-tools/schroot.git;a=shortlog;h=refs/heads/schroot-lenny

This is a new upstream 1.2.2 release, with a corresponding
1.2.2-1 version for upload to unstable.

http://www.codelibre.net/~rleigh/schroot_1.2.2-1.dsc
http://www.codelibre.net/~rleigh/schroot_1.2.2-1.diff.gz
http://www.codelibre.net/~rleigh/schroot_1.2.2.orig.tar.gz

Peter, please could you build and test these to confirm that it's
fixed for you?

Stable release managers: I would like to upload the exact same
package to stable with a version of 1.2.2-1~lenny1 (or whatever
number is most appropriate for you).  This will fix the current
breakage on Alpha systems.

These changes will be forward-ported to the current master branch
as well.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.
diff --git a/NEWS b/NEWS
index c8a0cc4..3988f4e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,12 +1,16 @@
 NEWS-*- outline -*-
 
 
-Welcome to schroot 1.2.1.  Please read these release notes carefully.
+Welcome to schroot 1.2.2.  Please read these release notes carefully.
 
 Full installation instructions are provided in the INSTALL file.  The
 README file also contains more specific notes regarding building and
 configuration.
 
+* Major changes in 1.2.2:
+
+  None.
+
 * Major changes in 1.2.1:
 
   1) A new chroot type, loopback, has been added.  This is similar
diff --git a/configure.ac b/configure.ac
index 74ff1a0..059bae3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
 #  -*- Autoconf -*-
-# Copyright © 2004-2008  Roger Leigh rle...@debian.org
+# Copyright © 2004-2009  Roger Leigh rle...@debian.org
 #
 # schroot is free software: you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
@@ -40,7 +40,7 @@ dnl
 pushdef([SBUILD_NAME],  [schroot])
 pushdef([SBUILD_MAJOR_VERSION], [1])
 pushdef([SBUILD_MINOR_VERSION], [2])
-pushdef([SBUILD_MICRO_VERSION], [1])
+pushdef([SBUILD_MICRO_VERSION], [2])
 pushdef([SBUILD_EXTRA_VERSION], [])
 pushdef([SBUILD_CURRENT_INTERFACE], [1])
 pushdef([SBUILD_INTERFACE_AGE], [0])
@@ -177,6 +177,7 @@ fi
 # Checks for programs.
 AC_PROG_CXX
 AC_LANG([C++])
+ACX_PTHREAD([], [AC_MSG_ERROR([POSIX thread support is required for correct std::tr1::shared_ptr operation])])
 AC_ENABLE_SHARED
 AC_DISABLE_STATIC
 AC_PROG_LIBTOOL
diff --git a/debian/changelog b/debian/changelog
index 33ba87c..9d543c9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+schroot (1.2.2-1) unstable; urgency=low
+
+  * New upstream stable release. 
+  * Compile and link with POSIX thread support (Closes: #520713).
+libstdc++ std::tr1::shared_ptr does not appear to work
+correctly on Alpha without -pthread, failing during shared_ptr
+construction or assignment due to an failed internal glibc
+assertion while locking a pthread mutex.
+
+ -- Roger Leigh rle...@debian.org  Sun, 22 Mar 2009 16:56:38 +
+
 schroot (1.2.1-1) unstable; urgency=low
 
   * New upstream stable release.
diff --git a/m4/acx_pthread.m4 b/m4/acx_pthread.m4
new file mode 100644
index 000..eb09f5a
--- /dev/null
+++ b/m4/acx_pthread.m4
@@ -0,0 +1,275 @@
+# ===
+#  http://autoconf-archive.cryp.to/acx_pthread.html
+# ===
+#
+# SYNOPSIS
+#
+#   ACX_PTHREAD([ACTION-IF-FOUND[, ACTION-IF-NOT-FOUND]])
+#
+# DESCRIPTION
+#
+#   This macro figures out how to build C programs using POSIX threads. It
+#   sets the PTHREAD_LIBS output variable to the threads library and linker
+#   flags, and the PTHREAD_CFLAGS output variable to any special C compiler
+#   flags that are needed. (The user can also force certain compiler
+#   flags/libs to be tested by setting these environment variables.)
+#
+#   Also sets PTHREAD_CC to any special C compiler that is needed for
+#   multi-threaded programs (defaults to the value of CC otherwise). (This
+#   is necessary on AIX to use the special cc_r compiler alias.)
+#
+#   NOTE: You are assumed to not only compile your program with these flags,
+#   but also link it with them

Re: Upload of Boost 1.38

2009-03-10 Thread Roger Leigh
On Tue, Mar 10, 2009 at 09:31:39PM +0100, Adeodato Simó wrote:
 * Steve M. Robbins [Sun, 22 Feb 2009 21:25:39 -0600]:

 I have a couple concerns with your proposal, though. Let me start the
 first of these with a question: given a new version of boost, eg. 1.38,
 how likely is it that a package will rebuild just fine against this new
 version? In other words, what percentage of packages are expected to
 rebuild without changes?

Just as a datapoint for you, I updated schroot to build with 1.37
yesterday (I'll repeat for 1.38 when it enters the archive).  The
changes were:

1) Update debian Build-Deps

http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=a60ff806cec2f1bca79e7ee458e8209fbe4f71d9

Here, I'm using the versioned -dev packages, but I might well move
to the unversioned packages but with a versioned dependency if that's
better for future rebuilding.  I would be interested to know what's
officially recommended here (sorry if this was previously mentioned).

2) Update of configure to cope with changed sonames

http://git.debian.org/?p=buildd-tools/schroot.git;a=commitdiff;h=ddc24070583534c222464164b43dff42c9f9b5ad

This is slightly more annoying.  In this case, we need to use
-lboost_foo-mt in place of -lboost_foo.  It's not a problem for us
to do this, but I do have a concern about being portable to
systems other than Debian.  While I understand the old (non -mt/-st)
names are non-portable, I'd just like to check how compatible with
upstream the new names are?

If the new names are going to be supported by Debian in future
boost releases, I'll be very happy.  Ideally, I would like to have
the configure script work with as many previous Boost versions as
possible to ease backporting (since the actual code is completely
compatible, it's just the library link names).

So it's been pretty easy to port to the new version, and if 1.38 is
similar to 1.37, it will be as simple as just updating the
Build-Deps.


BTW, thanks for all your work on Boost Steve, it's much appreciated!


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


signature.asc
Description: Digital signature


Re: Please unblock sbuild

2008-08-16 Thread Roger Leigh
Roger Leigh [EMAIL PROTECTED] writes:

 Please could you unblock sbuild 0.57.5-1?

I have since uploaded 0.57.6-1 to unstable.  Compared with 0.57.5,
this is just two hunks (excluding changelog and version bump).  I
would really like to get this into Lenny.

diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index 792d4c4..d1b1367 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -1310,6 +1310,10 @@ sub check_dependencies (\$\@) {
if (!$dep-{'Rel'}) {
$fail .= $name(still installed) ;
}
+   elsif ($stat-{'Version'} eq '~*=PROVIDED=*=') {
+   # It's a versioned build-conflict, but we installed
+   # a package that provides the conflicted package. It's ok.
+   }
elsif (version_compare($stat-{'Version'}, $dep-{'Rel'},
   $dep-{'Version'})) {
$fail .= $name(inst $stat-{'Version'} $dep-{'Rel'} .
diff --git a/man/sbuild-stats.1.in b/man/sbuild-stats.1.in
index e4a8899..926b97e 100644
--- a/man/sbuild-stats.1.in
+++ b/man/sbuild-stats.1.in
@@ -56,7 +56,7 @@ Print version information.
 Add an entry for a package. time is in the format HH:MM:SS, where
 hours and minutes are optional.
 .TP
-.BR\-d ,  \-\-delete PACKAGE1  [ PACKAGE2  [ PACKAGE\f[BI]n\fP... ]]]
+.BR \-d ,  \-\-delete PACKAGE1  [ PACKAGE2  [ PACKAGE\f[BI]n\fP... ]]]
 Remove the data for a package from the database.
 .TP
 .BR \-\-dump  [ PACKAGE1  [ PACKAGE2  [ PACKAGE\f[BI]n\fP... ]]]

 The changes are here:
 http://git.debian.org/?p=buildd-tools/sbuild.git;a=shortlog;h=refs/heads/sbuild-lenny

The changes for 0.57.6-1 are also on this branch.

Every change between 0.57.4-1 (testing) and 0.57.6-1 (unstable) has
been reviewed, tested and verified to work.  The git shortlog is at
the end of this mail.  I have personally tested every change.

Each change is either

1) a bugfix.  There are a number of important and serious bugs fixed,
   as well as a similar number of bugs fixing not reported bugs
   (including some things broken for several years)
2) Getopt::Long support for utilities adding --help and --version
   options (at a minimum) for all utilities
3) manual page updates

I'm aware that this includes more than just bugfixes, but all of this
work was done to get sbuild into the best shape possible for Lenny; I
just didn't have the time to meet the freeze deadline, and I really
wouldn't want Lenny users to use 0.57.4-1 because there are a number
of serious bugs in that that make it break under very common use
cases.


Regards,
Roger


Enrico Zini (1):
  [Sbuild::Conf] New parameter apt_allow_unauthenticated

Francois-Denis Gonthier (1):
  [Sbuild::Build] Use 'DSC' rather than 'DSC File' when checking sources

Greg Hudson (1):
  [Sbuild::Options] --make-binNMU should not assign an lvalue

Lucas Nussbaum (1):
  [Sbuild::Build] ~*=PROVIDED=*= does not break Build-Conflicts

Roger Leigh (44):
  [build] Bump version to 0.57.5
  [debian] Close #489794
  [Sbuild::Sysconfig] Export release date
  [sbuild] Don't use $Sysconfig::hostname
  [sbuild-createchroot] Rewrite in perl
  [NEWS] Document sbuild-createchroot changes
  [man] Bring sbuild-setup.7.in up to date
  [man] Document sbuild-createchroot options
  [Sbuild] Move dump_file, help_text and version_text from 
sbuild-createchroot
  [Sbuild::Options] Use isin from Sbuild
  [sbuild-createchroot] Set up sources.list with --components values
  [sbuild] Exit with 0 status when no build object exists
  [TODO] Add option parsing items
  [Sbuild] Move usage_error from sbuild-createchroot to Sbuild
  [Sbuild::Options] Add --help and --version options
  [sbuild-hold] Add --help and --version options
  [sbuild-createchroot] Use sensible @ARGV option counting
  [man] Document sbuild --help and --version options
  [sbuild-shell] Add --help and --version options
  [sbuild-hold] Update copyrights
  [sbuild-update] Add --help and --version options
  [sbuild-stats] Add --help and --version options
  [sbuild-apt] Add --help and --version options
  [sbuild-checkpackages] Add --help and --version options
  [sbuild-checkpackages] Update copyrights
  [sbuild-adduser] Add --help and --version options
  [sbuild-abort] Rewrite in perl
  [man] Update sbuild option formatting and copyrights
  [man] Update sbuild-shell option formatting
  [sbuild] run_command is a method of $build_object, not a function
  [TODO] Add new items
  [debian] debian/rules: Remove avg* command symlinks
  [build] Remove avg* command symlinks
  Merge branch 'long-options'
  [Sbuild::Log] Correctly format date in package log filename
  [sbuild] $maintainer_name, $uploader_name and $key_id are now optional
  [debian] sbuild.postrm: Correct use of local to remove bashisms
  [man] Clean up synopsis

Re: Please unblock sbuild

2008-08-14 Thread Roger Leigh
On Mon, Aug 11, 2008 at 09:02:38AM +0200, Marc 'HE' Brockschmidt wrote:
 Roger Leigh [EMAIL PROTECTED] writes:
  Please could you unblock sbuild 0.57.5-1?
 
  45 files changed, 1143 insertions(+), 365 deletions(-)
 
 You are kidding, right?

No.  This is a point release, which missed the freeze deadline by just a
few days.  I've been too busy with my PhD work to do more than a few
hours each weekend (sometimes each month) for the past six months.  I
have spent quite a lot of time testing it.

Half the changes are manual page updates.
The bulk of the other changes is switching the small /usr/[s]bin/sbuild-*
utilities to use Getopt::Long for options parsing, adding --help and
--version options amongst others.  sbuild itself was already using
Getopt::Long.  I also rewrote sbuild-createchroot in perl rather than
shell, which adds a number of new improvements and features, including
setting up keyring checking when running debootstrap.

  This has a number of bugfixes, the most noteworthy being:
 
  #492327: [security] Allow APT package authentication
  #489794, #493325: [bugfixes] serious regressions resulting in breakage
under certain circumstances
 
 If you really want those, prepare an upload to tpu containing only those
 changes and not the few hundred lines of diff against bin/sbuild-*.

I will if that is required, but there are quite a number of other
bugfixes in the release that I would like to get into Lenny.


Many thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Please unblock sbuild

2008-08-07 Thread Roger Leigh
Hi,

Please could you unblock sbuild 0.57.5-1?

This has a number of bugfixes, the most noteworthy being:

#492327: [security] Allow APT package authentication
#489794, #493325: [bugfixes] serious regressions resulting in breakage
  under certain circumstances

The changes are here:
http://git.debian.org/?p=buildd-tools/sbuild.git;a=shortlog;h=refs/heads/sbuild-lenny


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?   http://gutenprint.sourceforge.net/
   `-GPG Public Key: 0x25BFB848   Please GPG sign your mail.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



  1   2   >