Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Hi again, Am 17.06.24 um 20:29 schrieb Rene Engelhard: Apologies if I'm missing something, but + - recommend kio >> 5.103.0-1 in -kf5 makes the package uninstallable on a default bookworm setup (i.e. Recommends are installed by APT). apt TTBOMK doesn't complain if a Recommends isn't fullfillable. I also asked on #debian-devel about that because I wasn't sure either. AFAICR I did this in sid before the matching sid Recommendation was in place and no complaints from apt. (Except telling me that "kio" is Recommended) As per our IRC conversation, I'm still very surprised by this. Looks like stable behaves different and/or I implicitely did dist-upgrade on sid anyway because of other stuff, too Just tried: [...] For the record on IRC: 0:33 < adsb> and whether tools tend to do just upgrades or d-u (e.g unattended-upgrades, but also others) 20:33 < _rene_> the ideal way(tm) would just be to make kio do their stuff... 20:35 < _rene_> but if it helps I can back out the recommends. but that probably will make the actual bug in -kf5 still cause havoc 20:36 < _rene_> s/bug in -kf5/bug in kio still cause havoc with -kf5/ 20:43 < _rene_> can't get unattended-upgrades to upgrade from my local (non-signed, non-Release, etc) apt repo to try that one 20:46 < adsb> ah 20:46 < _rene_> ah, there. orgin=* 20:46 < _rene_> Option --dry-run given, *not* performing real actions 20:46 < _rene_> Packages that will be upgraded: fonts-opensymbol libreoffice-base-core libreoffice-calc libreoffice-common libreoffice-core libreoffice-draw libreoffice-gnome libreoffice-gtk3 libreoffice-help-common libreoffice-help-de libreoffice-help-en-us libreoffice-impress libreoffice-kf5 libreoffice-l10n-de libreoffice-math libreoffice-plasma libreoffice-qt5 libreoffice-style-breeze libreoffice-style-colibre 20:46 < _rene_> libreoffice-style-elementary libreoffice-writer libuno-cppu3 libuno-cppuhelpergcc3-3 libuno-purpenvhelpergcc3-3 libuno-sal3 libuno-salhelpergcc3-3 python3-uno uno-libs-private ure 20:46 < _rene_> s/orgin/origin/ 20:46 < adsb> promising 20:46 < _rene_> unatteded-upgrades seems to wrk 20:46 < _rene_> work 20:46 < adsb> I guess we can try it and see what qa tooling does 20:47 < _rene_> so I should upload and we can back out the recommends "in emergency"? 20:47 < adsb> sure 20:47 < _rene_> k 20:47 < adsb> neither way is great, as you say 20:48 < adsb> without the other half of the fix 20:48 < _rene_> didn't want to upload prematurely, even with your "half-ACK" in the bug :) 20:48 < _rene_> better safe than sorry :) 20:49 < adsb> coucouf: were you planning on submitting a p-u request for kio 5.103.0-1+deb12u1? 20:49 < _rene_> they wanted andi to do that 20:50 < _rene_> (fwiw, without --dry-run it actually upgrades all that) 20:50 < _rene_> all that in a clean stable VM 20:50 < adsb> I don't really mind who requests it :) 20:50 * _rene_ neither :) 20:51 < _rene_> Uploading libreoffice_7.4.7-1+deb12u3_source.changes: done. 20:51 < _rene_> Successfully uploaded packages. Regards, Rene
Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Hi, Am 17.06.24 um 19:05 schrieb Adam D. Barratt: Control: tags -1 -moreinfo +confirmed On Sat, 2024-06-15 at 17:44 +0200, Rene Engelhard wrote: Hi, Am 15.06.24 um 17:28 schrieb Adam D. Barratt: Control: tags -1 + moreinfo On Sat, 2024-05-25 at 10:35 +0200, Rene Engelhard wrote: I'd like to fix 2 libreoffice bugs in stable. Most important is the SMB fix (which - for kf5 - also needs a kio stable update, but those can be done in parallel or kio later as there's no updated (build)-dependency needed. Merely I added a Recommends: for documentation purposes. Apologies if I'm missing something, but + - recommend kio >> 5.103.0-1 in -kf5 makes the package uninstallable on a default bookworm setup (i.e. Recommends are installed by APT). apt TTBOMK doesn't complain if a Recommends isn't fullfillable. I also asked on #debian-devel about that because I wasn't sure either. AFAICR I did this in sid before the matching sid Recommendation was in place and no complaints from apt. (Except telling me that "kio" is Recommended) As per our IRC conversation, I'm still very surprised by this. Looks like stable behaves different and/or I implicitely did dist-upgrade on sid anyway because of other stuff, too Just tried: root@debian12:~# dpkg -l libreoffice-kf5 Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-===-=--= ii libreoffice-kf5 4:7.4.7-1+deb12u2 amd64 office productivity suite -- KDE Frameworks 5 integration root@debian12:~# apt upgrade Reading package lists... Done Building dependency tree... Done Reading state information... Done Calculating upgrade... Done The following packages were automatically installed and are no longer required: libwpe-1.0-1 libwpebackend-fdo-1.0-1 Use 'apt autoremove' to remove them. The following packages have been kept back: libreoffice-base-core libreoffice-calc libreoffice-core libreoffice-draw libreoffice-gnome libreoffice-gtk3 libreoffice-impress libreoffice-kf5 libreoffice-math libreoffice-plasma libreoffice-qt5 libreoffice-writer python3-uno The following packages will be upgraded: fonts-opensymbol libreoffice-common libreoffice-help-common libreoffice-help-de libreoffice-help-en-us libreoffice-l10n-de libreoffice-style-breeze libreoffice-style-colibre libreoffice-style-elementary libuno-cppu3 libuno-cppuhelpergcc3-3 libuno-purpenvhelpergcc3-3 libuno-sal3 libuno-salhelpergcc3-3 uno-libs-private ure 16 upgraded, 0 newly installed, 0 to remove and 13 not upgraded. Need to get 54.8 MB of archives. After this operation, 9216 B disk space will be freed. Do you want to continue? [Y/n] ^C root@debian12:~# apt dist-upgrade Reading package lists... Done Building dependency tree... Done Reading state information... Done Calculating upgrade... Done The following packages were automatically installed and are no longer required: libwpe-1.0-1 libwpebackend-fdo-1.0-1 Use 'apt autoremove' to remove them. The following packages will be upgraded: fonts-opensymbol libreoffice-base-core libreoffice-calc libreoffice-common libreoffice-core libreoffice-draw libreoffice-gnome libreoffice-gtk3 libreoffice-help-common libreoffice-help-de libreoffice-help-en-us libreoffice-impress libreoffice-kf5 libreoffice-l10n-de libreoffice-math libreoffice-plasma libreoffice-qt5 libreoffice-style-breeze libreoffice-style-colibre libreoffice-style-elementary libreoffice-writer libuno-cppu3 libuno-cppuhelpergcc3-3 libuno-purpenvhelpergcc3-3 libuno-sal3 libuno-salhelpergcc3-3 python3-uno uno-libs-private ure 29 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 110 MB of archives. After this operation, 50.2 kB of additional disk space will be used. Do you want to continue? [Y/n] ^C root@debian12:~# apt install libreoffice-kf5 Reading package lists... Done Building dependency tree... Done Reading state information... Done The following packages were automatically installed and are no longer required: libwpe-1.0-1 libwpebackend-fdo-1.0-1 Use 'apt autoremove' to remove them. The following additional packages will be installed: fonts-opensymbol libreoffice-base-core libreoffice-calc libreoffice-common libreoffice-core libreoffice-draw libreoffice-gnome libreoffice-gtk3 libreoffice-help-common libreoffice-help-de libreoffice-help-en-us libreoffice-impress libreoffice-l10n-de libreoffice-math libreoffice-plasma libreoffice-qt5 libreoffice-style-breeze libreoffice-style-colibre libreoffice-style-elementary libreoffice-writer libuno-cppu3 libuno-cppuhelpergcc3-3 libuno-purpenvhelpergcc3-3 libuno-sal3 libuno-salhelpergcc3-3 python3-uno uno-libs-private ure Suggested packages: libreoffice-base libreoffice-evolution libreoffice
Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Control: tags -1 -moreinfo +confirmed On Sat, 2024-06-15 at 17:44 +0200, Rene Engelhard wrote: > Hi, > > Am 15.06.24 um 17:28 schrieb Adam D. Barratt: > > Control: tags -1 + moreinfo > > > > On Sat, 2024-05-25 at 10:35 +0200, Rene Engelhard wrote: > > > I'd like to fix 2 libreoffice bugs in stable. Most important is > > > the SMB fix (which - for kf5 - also needs a kio stable update, > > > but > > > those > > > can be done in parallel or kio later as there's no updated > > > (build)-dependency needed. Merely I added a Recommends: for > > > documentation purposes. > > Apologies if I'm missing something, but > > > > + - recommend kio >> 5.103.0-1 in -kf5 > > > > makes the package uninstallable on a default bookworm setup (i.e. > > Recommends are installed by APT). > > apt TTBOMK doesn't complain if a Recommends isn't fullfillable. I > also asked on #debian-devel about that because I wasn't sure either. > > AFAICR I did this in sid before the matching sid Recommendation was > in place and no complaints from apt. > > (Except telling me that "kio" is Recommended) As per our IRC conversation, I'm still very surprised by this. I guess we can try it and see what ci.d.n and piuparts make of it. Regards, Adam
Processed: Re: Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Processing control commands: > tags -1 -moreinfo +confirmed Bug #1071826 [release.debian.org] bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3 Removed tag(s) moreinfo. Bug #1071826 [release.debian.org] bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3 Added tag(s) confirmed. -- 1071826: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071826 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Hi, Am 15.06.24 um 17:28 schrieb Adam D. Barratt: Control: tags -1 + moreinfo On Sat, 2024-05-25 at 10:35 +0200, Rene Engelhard wrote: I'd like to fix 2 libreoffice bugs in stable. Most important is the SMB fix (which - for kf5 - also needs a kio stable update, but those can be done in parallel or kio later as there's no updated (build)-dependency needed. Merely I added a Recommends: for documentation purposes. Apologies if I'm missing something, but +- recommend kio >> 5.103.0-1 in -kf5 makes the package uninstallable on a default bookworm setup (i.e. Recommends are installed by APT). apt TTBOMK doesn't complain if a Recommends isn't fullfillable. I also asked on #debian-devel about that because I wasn't sure either. AFAICR I did this in sid before the matching sid Recommendation was in place and no complaints from apt. (Except telling me that "kio" is Recommended) But I can back that out, that's for documentation only anyways. Regards, Ren
Processed: Re: Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Processing control commands: > tags -1 + moreinfo Bug #1071826 [release.debian.org] bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3 Added tag(s) moreinfo. -- 1071826: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1071826 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Control: tags -1 + moreinfo On Sat, 2024-05-25 at 10:35 +0200, Rene Engelhard wrote: > I'd like to fix 2 libreoffice bugs in stable. Most important is > the SMB fix (which - for kf5 - also needs a kio stable update, but > those > can be done in parallel or kio later as there's no updated > (build)-dependency needed. Merely I added a Recommends: for > documentation purposes. Apologies if I'm missing something, but +- recommend kio >> 5.103.0-1 in -kf5 makes the package uninstallable on a default bookworm setup (i.e. Recommends are installed by APT). Regards, Adam
Bug#1071826: bookworm-pu: package libreoffice/4:7.4.7-1+deb12u3
Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: libreoff...@packages.debian.org, k...@packages.debian.org
Control: affects -1 + src:libreoffice
Hi,
I'd like to fix 2 libreoffice bugs in stable. Most important is
the SMB fix (which - for kf5 - also needs a kio stable update, but those
can be done in parallel or kio later as there's no updated
(build)-dependency needed. Merely I added a Recommends: for
documentation purposes.
[ Reason ]
a) #1059158
If using python3-uno, loadComponentFromURL apparently needs the
internal libforuilo.so ("formula ui") library to actually open it
since it tried to open that one.
Unfortunately this file if left out in the -nogui packages because it
is*ui.so. (In 32bit packages that is; in 64bit LO due to
--enable-mergelibs this is already in a bigger library called
libmergedlo.so)
b) 1069835
We shouldn't leave people having documents on SMB shares loose their
files :-)
[ Impact ]
a) opening calc files via python3-uno remaining broken
b) possible file loss for files on SMB shares
[ Tests ]
No test coverage. But a) is pretty straightforward abd b) was confirmed
that it
fixes it by the submitter.
[ Risks ]
a) would be better fixed by upstream not requiring that but the bug I
filed upstream (https://bugs.documentfoundation.org/show_bug.cgi?id=158795)
didn't really get any serious attention.
b) more SMB surprises can be possible, though I have not seen any since
this is in unstable since 24.2.2 is there.
(And that exact patch caused a 32bit FTBFS which I backported the fix of
which went into 24.2.2~rc1-2 packages and is upstream since 24.2.2 rc2
anyways, too.)
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
a) see above. It it just excluded from the find which removes *.ui.so.
b) patches from upstream applied verbatim (from 24.2.2)
[ Other info ]
kio needs one update, too for complete fix of 1069835 in
libreoffice-kf5. I see
https://salsa.debian.org/qt-kde-team/kde/kio/-/commi
t/082a2b7e9208a9d0a552049aafd898960fc15998
(debian/patches/fix_cifs_file_locks.patch).
According to
https://salsa.debian.org/qt-kde-team/kde/kio/-/commit/9db715803c0c87298dbf70644b98a95bb984322c
this was already supposed to be "released to bookworm" but I don't see a
release.debian.org bug nor the package in p-u either.
Debdiff attached.
Regards,
Renediff -Nru libreoffice-7.4.7/debian/changelog libreoffice-7.4.7/debian/changelog
--- libreoffice-7.4.7/debian/changelog 2024-04-01 11:05:27.0 +0200
+++ libreoffice-7.4.7/debian/changelog 2024-05-24 21:06:45.0 +0200
@@ -1,3 +1,18 @@
+libreoffice (4:7.4.7-1+deb12u3) bookworm; urgency=medium
+
+ * debian/patches/Fix-backup-copy-creation-for-files-on-mounted-samba-shares.diff:
+as name says, from 24.2.2+ (closes: #1069835)
+ * debian/patches/fix-32bit-build.diff: as name says; fix 32bit build with
+above
+
+ * debian/rules:
+- don't remove libforuilo.so in -core-nogui. (closes: #1059158)
+ It's subsumed in libmerged on 64bit archs anyway which we definitely
+ need to keep anyway (similar as libuuilo.so).
+- recommend kio >> 5.103.0-1 in -kf5
+
+ -- Rene Engelhard Fri, 24 May 2024 21:06:45 +0200
+
libreoffice (4:7.4.7-1+deb12u2) bookworm-security; urgency=high
* debian/patches/add-notify-for-script-use.diff: add fix for
diff -Nru libreoffice-7.4.7/debian/control libreoffice-7.4.7/debian/control
--- libreoffice-7.4.7/debian/control 2024-04-01 11:05:27.0 +0200
+++ libreoffice-7.4.7/debian/control 2024-05-22 18:16:51.0 +0200
@@ -5028,7 +5028,7 @@
${kf5-qt5-depends},
${misc:Depends},
${shlibs:Depends}
-Recommends: ${plasma-iconset-dep}
+Recommends: kio (>> 5.103.0-1), ${plasma-iconset-dep}
Replaces: libreoffice-kde (<< 1:6.1.0~alpha1-1)
Section: kde
Enhances: libreoffice
diff -Nru libreoffice-7.4.7/debian/patches/fix-32bit-build.diff libreoffice-7.4.7/debian/patches/fix-32bit-build.diff
--- libreoffice-7.4.7/debian/patches/fix-32bit-build.diff 1970-01-01 01:00:00.0 +0100
+++ libreoffice-7.4.7/debian/patches/fix-32bit-build.diff 2024-05-22 09:46:59.0 +0200
@@ -0,0 +1,54 @@
+From 0f5dfaebd61b9cabbe9762865563c2296ebb0112 Mon Sep 17 00:00:00 2001
+From: Stephan Bergmann
+Date: Fri, 8 Mar 2024 08:38:44 +0100
+Subject: [PATCH] Blind fix for Linux 32-bit builds
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+...which, according to
+ "32
+bit build failure (smb, narrowing)", started to fail with
+
+> /<>/sal/osl/unx/file.cxx: In function ‘void osl_file_adjustLockFlags(const rtl::OString&, int*, sal_uInt32*)’:
+> /<>/sal/osl/unx/file
