Re: ruby-gettext-setup: FTBFS

[Sebastien Badia]

On Wed, Apr 11, 2018 at 10:34:06AM (+0300), Hleb Valoshka wrote:
> Please see attached file. It fixes the failure.

Hi,

Thanks Hleb !!
Just added your patch here 
https://salsa.debian.org/puppet-team/ruby-gettext-setup/blob/master/debian/patches/0003-fix-invalid-byte-sequence-in-US-ASCII.patch

Cheers,

Seb


signature.asc
Description: PGP signature

Re: ruby-gettext-setup: FTBFS

[Hleb Valoshka]

On 4/5/18, Georg Faerber  wrote:
>> /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb is UTF-8 file,

Oops, wrong file. spec/lib/gettext-setup/gettext_setup_spec.rb is a proper one.

> Please go ahead and feel free to fix the package; I failed to do so
> yesterday, but I've to admit, I didn't spent much time. Also, my local
> setup is currently broken.

Please see attached file. It fixes the failure.
diff -uNr gettext-setup-0.30.orig/spec/lib/gettext-setup/gettext_setup_spec.rb gettext-setup-0.30.new/spec/lib/gettext-setup/gettext_setup_spec.rb
--- gettext-setup-0.30.orig/spec/lib/gettext-setup/gettext_setup_spec.rb	2018-02-21 05:04:10.0 +0300
+++ gettext-setup-0.30.new/spec/lib/gettext-setup/gettext_setup_spec.rb	2018-04-11 10:19:09.407049739 +0300
@@ -1,3 +1,4 @@
+# encoding: utf-8
 require 'rspec/expectations'
 require 'spec_helper'
 

Re: ruby-gettext-setup: FTBFS

[Georg Faerber]

Hi,

On 18-04-04 23:58:32, Hleb Valoshka wrote:
> On 4/4/18, Georg Faerber <ge...@riseup.net> wrote:
> > ruby-gettext-setup FTBFS now, with errors like
> >
> > /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb:50:in `gsub':
> > invalid byte sequence in US-ASCII (ArgumentError)
> >
> > See #894829 for details.
> >
> 
> /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb is UTF-8 file,
> it contains japanese letters (こんにちは世界), of course these letters
> can't be processed in C locale.
> 
> So you either patch it to remove UTF-8 characters or run tests in
> C.UTF-8.

Please go ahead and feel free to fix the package; I failed to do so
yesterday, but I've to admit, I didn't spent much time. Also, my local
setup is currently broken.

> I don't think that the last ruby-gettext update introduced a
> regression as in the previous version it had a terrible insecure
> parser for ruby strings:
> begin; s = eval(s); rescue Exception; end

I don't get the relation between "no regression" and "previous version
had a terrible insecure parser".

> Now it has a proper one.

No doubt -- thanks for your work and the upload.

The point I was trying to make: Let's work together, better (in the
future). For example: Before uploading such a change, communicate about
it especially if it introduces a breaking change.

Cheers,
Georg


signature.asc
Description: Digital signature

Re: ruby-gettext-setup: FTBFS [Re: RFS: ruby-tzinfo, ruby-gettext, ruby-kgio, ruby-solve]

[Hleb Valoshka]

On 4/4/18, Georg Faerber <ge...@riseup.net> wrote:

>> I've checked ruby-gettext-setup and can say that it doesn't actually
>> use anything from gettext gem, only from fast-gettext. So its test
>> failures caused by something else, not the new gettext version.
> I would be interested in how you came to this conclusion:

I did `fgrep -R require | fgrep gettext` and saw nothing (actually
this gem uses rxgettext from ruby-gettext).

> ruby-gettext-setup FTBFS now, with errors like
>
> /usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb:50:in `gsub': invalid
> byte sequence in US-ASCII (ArgumentError)
>
> See #894829 for details.
>

/usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb is UTF-8 file,
it contains japanese letters (こんにちは世界), of course these letters can't
be processed in C locale.

So you either patch it to remove UTF-8 characters or run tests in C.UTF-8.

I don't think that the last ruby-gettext update introduced a
regression as in the previous version it had a terrible insecure
parser for ruby strings:
begin; s = eval(s); rescue Exception; end

Now it has a proper one.

ruby-gettext-setup: FTBFS [Re: RFS: ruby-tzinfo, ruby-gettext, ruby-kgio, ruby-solve]

[Georg Faerber]

Hi Hleb, all,

On 18-03-21 23:29:33, Hleb Valoshka wrote:
> On 3/21/18, Cédric Boutillier <bou...@debian.org> wrote:
> > Is it "normal" that ruby-gettext-setup tests fail with the new
> > ruby-gettext? They seem to pass with the current version on
> > ci.debian.net.
> 
> I've checked ruby-gettext-setup and can say that it doesn't actually
> use anything from gettext gem, only from fast-gettext. So its test
> failures caused by something else, not the new gettext version.

I would be interested in how you came to this conclusion:
ruby-gettext-setup FTBFS now, with errors like 

/usr/lib/ruby/vendor_ruby/gettext/tools/parser/ruby.rb:50:in `gsub': invalid 
byte sequence in US-ASCII (ArgumentError)

See #894829 for details.

IOW: We should take regressions in autopkgtests seriously. If we don't,
chances are high we're just running into situations like this one,
causing extra work for all people involved.

Cheers,
Georg


signature.asc
Description: Digital signature