[GitHub] activemq-artemis pull request: Set default password properly in se...
Github user clebertsuconic commented on the pull request: https://github.com/apache/activemq-artemis/pull/61#issuecomment-119250191 Great Work! Since this is a big task, I would like to have as many people reviewing this... Input is appreciated from anyone! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[DISCUSS] enabling svngit2jira integration?
Hey, awhile back Robbie brought this up on the dev list but it didn't
get much attention so I thought I'd bring it up and see if anyone had
any issues with us asking infra to enable the svngit2jira bit on our
various repos? If not I'm happy to open the request with infra and
provide them the info on our various source repositories to link to
their respective Jira spaces.
Having worked over in QPid land for awhile where they have this turned
on I've found it much more useful than Fisheye. Below I've quoted in
Robbie's original message.
{quote}
Hi all,
I was wondering what people thought about asking for the svngit2jira
integration[1] being turned on for the ActiveMQ repo/JIRA? I find it
very useful to know what work if any has been done against a JIRA so
far, and it can make tracking things down later much nicer.
For those that don't know of it, it essentially comments on a JIRA each
time a commit is made with a JIRA key (and I think also supports
mentioning peoples names to notify them), e.g. look at
https://issues.apache.org/jira/browse/QPID-6334 for examples.
I know that Fisheye is set up for the JIRA project but I find that
less useful generally, and the information may also get lost in future
if that goes away (such as all the historic svn commit info was lost
when the related JIRA plugin was removed)
Thoughts?
Robbie
[1] http://www.apache.org/dev/svngit2jira.html
{quote}
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com twitter: @tabish121
blog: http://timbish.blogspot.com/
Re: [DISCUSS] enabling svngit2jira integration?
This sounds good to me. Fisheye has always been far too slow in my experience. I take it this will only apply to new commits and no history will be back-filled, right? That's probably a good thing. -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-enabling-svngit2jira-integration-tp4698723p4698727.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
Re: [DISCUSS] enabling svngit2jira integration?
On 07/07/2015 03:48 PM, artnaseef wrote: This sounds good to me. Fisheye has always been far too slow in my experience. I take it this will only apply to new commits and no history will be back-filled, right? That's probably a good thing. -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-enabling-svngit2jira-integration-tp4698723p4698727.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com. No, the process will not back-fill all the past commits. -- Tim Bish Sr Software Engineer | RedHat Inc. tim.b...@redhat.com | www.redhat.com twitter: @tabish121 blog: http://timbish.blogspot.com/
[GitHub] activemq pull request: Added a getMessageSize method to MessageSto...
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq pull request: https://issues.apache.org/jira/browse/AMQ-5...
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [DISCUSS] enabling svngit2jira integration?
+1, I think this would be useful. On Tue, Jul 7, 2015 at 4:16 PM, Timothy Bish tabish...@gmail.com wrote: On 07/07/2015 03:48 PM, artnaseef wrote: This sounds good to me. Fisheye has always been far too slow in my experience. I take it this will only apply to new commits and no history will be back-filled, right? That's probably a good thing. -- View this message in context: http://activemq.2283324.n4.nabble.com/DISCUSS-enabling-svngit2jira-integration-tp4698723p4698727.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com. No, the process will not back-fill all the past commits. -- Tim Bish Sr Software Engineer | RedHat Inc. tim.b...@redhat.com | www.redhat.com twitter: @tabish121 blog: http://timbish.blogspot.com/
Re: [DISCUSS] enabling svngit2jira integration?
Would this apply to all activemq repos, including Artemis and Apollo?
On Jul 7, 2015 1:34 PM, Timothy Bish tabish...@gmail.com wrote:
Hey, awhile back Robbie brought this up on the dev list but it didn't
get much attention so I thought I'd bring it up and see if anyone had
any issues with us asking infra to enable the svngit2jira bit on our
various repos? If not I'm happy to open the request with infra and
provide them the info on our various source repositories to link to
their respective Jira spaces.
Having worked over in QPid land for awhile where they have this turned
on I've found it much more useful than Fisheye. Below I've quoted in
Robbie's original message.
{quote}
Hi all,
I was wondering what people thought about asking for the svngit2jira
integration[1] being turned on for the ActiveMQ repo/JIRA? I find it
very useful to know what work if any has been done against a JIRA so
far, and it can make tracking things down later much nicer.
For those that don't know of it, it essentially comments on a JIRA each
time a commit is made with a JIRA key (and I think also supports
mentioning peoples names to notify them), e.g. look at
https://issues.apache.org/jira/browse/QPID-6334 for examples.
I know that Fisheye is set up for the JIRA project but I find that
less useful generally, and the information may also get lost in future
if that goes away (such as all the historic svn commit info was lost
when the related JIRA plugin was removed)
Thoughts?
Robbie
[1] http://www.apache.org/dev/svngit2jira.html
{quote}
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com twitter: @tabish121
blog: http://timbish.blogspot.com/
Re: [DISCUSS] enabling svngit2jira integration?
All of them please
+1 from me.
-- Clebert Suconic typing on the iPhone.
On Jul 7, 2015, at 19:00, Timothy Bish tabish...@gmail.com wrote:
On 07/07/2015 06:58 PM, John D. Ament wrote:
Would this apply to all activemq repos, including Artemis and Apollo?
I'd request it for all of them unless someone has an objection to doing so.
On Jul 7, 2015 1:34 PM, Timothy Bish tabish...@gmail.com wrote:
Hey, awhile back Robbie brought this up on the dev list but it didn't
get much attention so I thought I'd bring it up and see if anyone had
any issues with us asking infra to enable the svngit2jira bit on our
various repos? If not I'm happy to open the request with infra and
provide them the info on our various source repositories to link to
their respective Jira spaces.
Having worked over in QPid land for awhile where they have this turned
on I've found it much more useful than Fisheye. Below I've quoted in
Robbie's original message.
{quote}
Hi all,
I was wondering what people thought about asking for the svngit2jira
integration[1] being turned on for the ActiveMQ repo/JIRA? I find it
very useful to know what work if any has been done against a JIRA so
far, and it can make tracking things down later much nicer.
For those that don't know of it, it essentially comments on a JIRA each
time a commit is made with a JIRA key (and I think also supports
mentioning peoples names to notify them), e.g. look at
https://issues.apache.org/jira/browse/QPID-6334 for examples.
I know that Fisheye is set up for the JIRA project but I find that
less useful generally, and the information may also get lost in future
if that goes away (such as all the historic svn commit info was lost
when the related JIRA plugin was removed)
Thoughts?
Robbie
[1] http://www.apache.org/dev/svngit2jira.html
{quote}
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com twitter: @tabish121
blog: http://timbish.blogspot.com/
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com
twitter: @tabish121
blog: http://timbish.blogspot.com/
[GitHub] activemq pull request: https://issues.apache.org/jira/browse/AMQ-5...
GitHub user cshannon opened a pull request: https://github.com/apache/activemq/pull/128 https://issues.apache.org/jira/browse/AMQ-5748 Fixing a potential Null pointer exception in MemoryMessageStore You can merge this pull request into a Git repository by running: $ git pull https://github.com/cshannon/activemq AMQ-5748-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #128 commit bd28c3b0ba317c3f07329c083d7097c12beee5b8 Author: Christopher L. Shannon christopher.l.shan...@gmail.com Date: 2015-07-07T22:54:06Z https://issues.apache.org/jira/browse/AMQ-5748 Fixing a potential Null pointer exception in MemoryMessageStore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [DISCUSS] enabling svngit2jira integration?
On 07/07/2015 06:58 PM, John D. Ament wrote:
Would this apply to all activemq repos, including Artemis and Apollo?
I'd request it for all of them unless someone has an objection to doing so.
On Jul 7, 2015 1:34 PM, Timothy Bish tabish...@gmail.com wrote:
Hey, awhile back Robbie brought this up on the dev list but it didn't
get much attention so I thought I'd bring it up and see if anyone had
any issues with us asking infra to enable the svngit2jira bit on our
various repos? If not I'm happy to open the request with infra and
provide them the info on our various source repositories to link to
their respective Jira spaces.
Having worked over in QPid land for awhile where they have this turned
on I've found it much more useful than Fisheye. Below I've quoted in
Robbie's original message.
{quote}
Hi all,
I was wondering what people thought about asking for the svngit2jira
integration[1] being turned on for the ActiveMQ repo/JIRA? I find it
very useful to know what work if any has been done against a JIRA so
far, and it can make tracking things down later much nicer.
For those that don't know of it, it essentially comments on a JIRA each
time a commit is made with a JIRA key (and I think also supports
mentioning peoples names to notify them), e.g. look at
https://issues.apache.org/jira/browse/QPID-6334 for examples.
I know that Fisheye is set up for the JIRA project but I find that
less useful generally, and the information may also get lost in future
if that goes away (such as all the historic svn commit info was lost
when the related JIRA plugin was removed)
Thoughts?
Robbie
[1] http://www.apache.org/dev/svngit2jira.html
{quote}
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com twitter: @tabish121
blog: http://timbish.blogspot.com/
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com
twitter: @tabish121
blog: http://timbish.blogspot.com/
Re: Please review: Unix Init Script Improvements - strange options export and create
One thought here. There's a lot of complexity and functionality in the existing scripts. Perhaps it would make sense to start a new set of smaller scripts that are more focused on individual tasks. If we want to have a master script so the command-name is the same across multiple functions, that would be easy enough to do. One concern here is breaking backward compatibility and ease-of-upgrade for users. The 5.11.1 script updates (maybe earlier?) did make at least one non-backward-compatible change. I have a lot of thoughts on the scripts (I was a Unix C dev longer than I've been a Java dev). Let's chat on IRC if you're interested. -- View this message in context: http://activemq.2283324.n4.nabble.com/Please-review-Unix-Init-Script-Improvements-tp4698378p4698743.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
[GitHub] activemq pull request: https://issues.apache.org/jira/browse/AMQ-5...
Github user asfgit closed the pull request at: https://github.com/apache/activemq/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Artemis Export/Import tool
Hi, To help some migration process with Artemis, we want to add a feature in our app server to export and import its journal files. My idea was to leverage the XmlDataExporter and XmlDataImporter from artemis-cli so that the generated XML is opaque to us and we just have to deal with the generated files. First, what is your requirements for this generated XML? Can I be sure that it will remain compatible with newer versions? i.e. I can export from Artemis 1.0.0 and import it to Artemis 2.0.0. There are a few issues with the tools in their current state that prevents me to use them. * The exporter only prints to System.out. This is a bug as it should be able to print to its ActionContext's out stream instead. * The error are written to System.err. Again, this should be printed to the ActionContext's err stream instead. * The commands uses the io.airlift library to display errors. = that one is a problem for us. We have our own library to deal with user input and output. If a problem occurs in the command, I would like to have access to the exception directly and handle the presentation to the user myself. Would it make sense to split these exporter/importer into 2 classes? * one doing the actual job of reading files and creating the XML. I would then use this class * a wrapper built with io.airlift that would be used by artemis-cli I also noticed a problem with the check in DataAbstract that expects all directories (journal, paging, bindings, largeMessages) to exist before exporting their content. That's actually not true. Artemis will autocreate the journal and paging directories if the corresponding parameters (create-journal-dir and create-bindings-dir) is set to true in its configuration. There is no such parameters for the paging and largemessages directories. Somehow when our app server starts Artemis, Artemis also creates the largemessages directory but the paging dir is not created until paging is actually performed. Note that you don't see that when using standalone Artemis as the artemis run command explicitly creates them. What is the correct way to deal with this? * should the exporter tool accept that some directories do not exist? * should artemis also allow to auto create the paging and largemessages dir? thanks, jeff -- Jeff Mesnil jmes...@gmail.com http://jmesnil.net/weblog/
Re: Artemis Export/Import tool
First, what is your requirements for this generated XML? Can I be sure that it will remain compatible with newer versions? i.e. I can export from Artemis 1.0.0 and import it to Artemis 2.0.0. I would say the tool is part of the user interface. There is a request to improve the format a bit (use a zip file and have each message being its own file on the zip), to be similar to what's being used on Apollo. But if we implement such thing the current format would still be supported as it's part of the current public interface There are a few issues with the tools in their current state that prevents me to use them. * The exporter only prints to System.out. This is a bug as it should be able to print to its ActionContext's out stream instead. * The error are written to System.err. Again, this should be printed to the ActionContext's err stream instead. * The commands uses the io.airlift library to display errors. = that one is a problem for us. We have our own library to deal with user input and output. If a problem occurs in the command, I would like to have access to the exception directly and handle the presentation to the user myself. I have had a refactoring for the examples on the CLI, that I believe would address some of that. Would it make sense to split these exporter/importer into 2 classes? * one doing the actual job of reading files and creating the XML. I would then use this class * a wrapper built with io.airlift that would be used by artemis-cli I have done some of that on the CLI.. a method that would take parameters.. etc. I also noticed a problem with the check in DataAbstract that expects all directories (journal, paging, bindings, largeMessages) to exist before exporting their content. That's actually not true. Artemis will autocreate the journal and paging directories if the corresponding parameters (create-journal-dir and create-bindings-dir) is set to true in its configuration. There is no such parameters for the paging and largemessages directories. I'm not sure this is an issue on master. Did you check it recently? Somehow when our app server starts Artemis, Artemis also creates the largemessages directory but the paging dir is not created until paging is actually performed. it's changed on master already. Note that you don't see that when using standalone Artemis as the artemis run command explicitly creates them. What is the correct way to deal with this? * should the exporter tool accept that some directories do not exist? I think so, yeah. * should artemis also allow to auto create the paging and largemessages dir? the CLI is laready creating those now... Can you check master? Im planning a release soon.
[GitHub] activemq-artemis pull request: Set default password properly in se...
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/61 Set default password properly in security manager The current Security Manager implementation was returning the username instead of the default password when validating the default user. This patch returns the correct value and cleans up the validate method. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis validate-default-user Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit ac167fda16459530bd547ae0682eeb20daa4e924 Author: Martyn Taylor mtay...@redhat.com Date: 2015-07-07T14:18:02Z Set default password properly in security manager The current Security Manager implementation was returning the username instead of the default password when validating the default user. This patch returns the correct value and cleans up the validate method. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Message Groups and long running transactions
This is an interesting mix of needs. Using message groups to ensure ordered processing of messages while at least some of the messages take excessive periods of time to process. Can the slow-processing messages be separated from the message-groups? Note the default message group handling uses a hash bucket of group assignments to consumers, meaning multiple groups are assigned as a unit. So, assigning the slow messages to only one group will not prevent mixing with fast messages (remember one consumer may be assigned multiple groups). The -1 sequence on the group only takes effect as that message is dispatched to the assigned owner (when it has prefetch space available), meaning it goes to the same old owner as the message immediately before it, but then new messages may go to a different owner. So, actually, a higher prefetch may be needed so that the -1 sequence message can be dispatched, but then it will only affect messages that come after it, not those from before. Assigning a sequence number of -1 for the group on the slow messages would do the trick - if combined with a prefect of 1. Of course, if the fast and slow messages are in the same group, then the fast messages need to wait for the slow ones to process. That's the point of message groups. Another thought - is it possible eliminate the use of message groups adding a message aggregator (camel) to collect all of the messages that require sequential processing and feed them back out as a single message? -- View this message in context: http://activemq.2283324.n4.nabble.com/Message-Groups-and-long-running-transactions-tp3499325p4698769.html Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
[GitHub] activemq-artemis pull request: Added Initial MQTT Protocol Support
GitHub user mtaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/62 Added Initial MQTT Protocol Support Creates a new MQTT protocol module. There is currently no support (at least tested support) for using MQTT to/from other protocols. There are a number of outstanding items of work outlined in TODO/FIXME in the PR. These will be transferred to JIRA when/if the code is accepted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mtaylor/activemq-artemis initial-mqtt-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/62.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #62 commit e1ea2895cc404ddcb22f6cf99aa7c214f528711c Author: Martyn Taylor mtay...@redhat.com Date: 2015-07-06T16:01:08Z Added Initial MQTT Protocol Support --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
