[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...
Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/2084 ---
[GitHub] activemq-artemis issue #2440: ARTEMIS-2181 Add `static` storage class for an...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/2440 Works on my machine... ---
[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2441#discussion_r237521038
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageTest.java
---
@@ -2231,14 +2232,14 @@ private boolean isEquals(Section left, Section
right) {
byte[] leftArray = leftValue.getValue().getArray();
byte[] rightArray = rightValue.getValue().getArray();
- if (leftArray == null && leftArray == null) {
+ if (leftArray == null && rightArray == null) {
--- End diff --
@tabish121 I figure this is what you've meant to say here (error prone
screams if there are duplicated subexpressions in ifs, like this)
---
[GitHub] activemq-artemis pull request #2441: Assorted Error Prone-related NO-JIRA fi...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2441 Assorted Error Prone-related NO-JIRA fixes to tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_errorprone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2441.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2441 commit 0e7446d6f9354ae74b753996f4607a51f2efaa24 Author: Jiri Danek Date: 2018-11-22T21:52:45Z NO-JIRA Fix errorprone error (duplicated expression in condition) commit c1dbc1b54bd4e044a529f773121f7ab4aaa36eb0 Author: Jiri Danek Date: 2018-07-14T21:52:02Z NO-JIRA Add forgotten @Test annotation and make helper methods private ---
[GitHub] activemq-artemis pull request #2440: ARTEMIS-2181 Add `static` storage class...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2440 ARTEMIS-2181 Add `static` storage class for an inline function internal to the compile unit You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_static_inline Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2440.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2440 commit 17855709494538a316d5b29108357858edd09ca7 Author: Jiri Danek Date: 2018-11-24T20:54:44Z ARTEMIS-2181 Add `static` storage class for an inline function internal to the compile unit ---
[GitHub] activemq-artemis pull request #2387: ARTEMIS-2142 Support JMSXGroupSeq -1to ...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2387#discussion_r231901536
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java
---
@@ -289,6 +289,12 @@ public SimpleString getGroupID() {
return this.getSimpleStringProperty(Message.HDR_GROUP_ID);
}
+ @Override
+ public int getGroupSequence() {
+ final Integer integer =
this.getIntProperty(Message.HDR_GROUP_SEQUENCE);
--- End diff --
This just blew up for me. It is not Mike's bug per se, it just possibly
sends execution to this little function which cannot handle `null`s
https://github.com/apache/activemq-artemis/blob/10ecb358cb587c8417deeb799723d8274b0a44a5/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java#L211-L214
In my JVM,
```
public static Integer valueOf(String var0) throws NumberFormatException
{
return parseInt(var0, 10);
}
```
and
```
public static int parseInt(String var0, int var1) throws
NumberFormatException {
if (var0 == null) {
throw new NumberFormatException("null");
```
Here is a failing test (from cli-java project) on travis ci,
https://travis-ci.org/rh-messaging/cli-java/jobs/451880325 at around
> 13:28:41,911 ERROR Error while sending a message!
> java.lang.NumberFormatException: null
It was not supposed to fetch a 2.7.0 snapshot of artemis-cli-java, but
somehow it did... mystery for the next time, for me or @michalxo.
---
[GitHub] activemq-artemis pull request #2340: ARTEMIS-1018 de-duplicate logging codes
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2340#discussion_r222116889 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java --- @@ -69,6 +54,21 @@ import org.jboss.logging.annotations.MessageLogger; import org.w3c.dom.Node; +/** + * Logger Code 22 + * + * each message id must be 6 digits long starting with 10, the 3rd digit donates the level so --- End diff -- > starting with 10 this is no longer true, I think ---
[GitHub] activemq-artemis pull request #2249: ARTEMIS-2023 Fix NPE
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2249#discussion_r210198098
--- Diff:
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java
---
@@ -640,7 +640,7 @@ public void decode(final ActiveMQBuffer buffer) {
deserializationWhiteList =
BufferHelper.readNullableSimpleStringAsString(buffer);
- enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: null;
+ enable1xPrefixes = buffer.readableBytes() > 0 ? buffer.readBoolean()
: ActiveMQClient.DEFAULT_ENABLE_1X_PREFIXES;
--- End diff --
Btw, there was an ErrorProne warning for this,
```
[17:16:53][Step 3/3]
artemis-jms-server/src/main/java/org/apache/activemq/artemis/jms/server/config/impl/ConnectionFactoryConfigurationImpl.java:643:
error: [NullTernary] This conditional expression may evaluate to null, which
will result in an NPE when the result is unboxed.
[17:16:53][Step 3/3] enable1xPrefixes = buffer.readableBytes() > 0 ?
buffer.readBoolean() : null;
[17:16:53][Step 3/3] ^
[17:16:53][Step 3/3] (see http://errorprone.info/bugpattern/NullTernary)
```
---
[GitHub] activemq-artemis issue #2241: Added a Spring Boot Sample integration
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/2241 You cannot add comments to json files, due to https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr It depends what does the parsing. Some parsers do recognize a comment syntax, such as the one used in vscode, as whitnessed by https://github.com/apache/activemq-artemis/blob/781e5e64a42f7cbbfac40294a6ce6e33074731ba/examples/protocols/amqp/dotnet/.vscode/tasks.json ---
[GitHub] activemq-artemis issue #2084: ARTEMIS-1859 Adding testAnonymousProducerWithQ...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/2084 trying to add commit ---
[GitHub] activemq-artemis pull request #2225: Fix flaky QueueControl tests
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2225
Fix flaky QueueControl tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis
jd_flaky_queue_control_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2225
commit fba805cb85a1d7ef5425e9e16f39697b49ea0ef0
Author: Jiri Danek
Date: 2018-08-07T14:56:20Z
NO-JIRA fix flaky test QueueControlTest#testListMessagesWithEmptyFilter
The below error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
java.lang.AssertionError:
Expected :2
Actual :1
[...]
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testListMessagesWithEmptyFilter(QueueControlTest.java:827)
commit 2c8930f7081c081b49ce1c9117aa6098d4690ae6
Author: Jiri Danek
Date: 2018-08-07T14:59:30Z
NO-JIRA fix flaky test QueueControlTest#testListMessagesWithNullFilter
The below error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
java.lang.AssertionError:
Expected :2
Actual :1
[...]
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testListMessagesWithNullFilter(QueueControlTest.java:804)
commit 7222133993b54fdb51979c69a02764670a32ee2e
Author: Jiri Danek
Date: 2018-08-07T15:10:00Z
NO-JIRA fix flaky test QueueControlTest#testResetMessagesAdded
The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
I did not observe the timing issue on all asserts (only on the first
two), but there is no harm in replacing them all.
java.lang.AssertionError:
Expected :2
Actual :1
commit f8e97abbf381a8bf6eb4fb955d9108de1aa33f8c
Author: Jiri Danek
Date: 2018-08-07T16:22:57Z
ARTEMIS-2016 fix flaky test QueueControlTest#testRemoveAllWithPagingMode
Parameters going into Wait.waitFor were originally wrong, because
`durationMillis: 3, sleepMillis: 100` means you would test the condition
only once. This commit is changing the durationMillis from 3ms to 3s,
swapping the two numbers (duration 100ms, sleep 3ms) would also be
reasonable, I think.
Next, Wait.assertEquals is here being used, instead of Assert.assertTrue.
I saw the test fail only once, and never was able to reproduce it again,
but I think this commit does improve the test and so it is worthwhile.
java.lang.AssertionError
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMetrics(QueueControlTest.java:2651)
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMessageMetrics(QueueControlTest.java:2615)
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testRemoveAllWithPagingMode(QueueControlTest.java:1554)
commit 099b7640cf5936b402c8c820e3679db41e963a98
Author: Jiri Danek
Date: 2018-08-07T18:02:41Z
NO-JIRA fix flaky tests
QueueControlTest#testChangeMessagePriority{,WithInvalidValue}
The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
commit d1a0356f1cd8c25dc7a33f8d97a3cca91f8ff575
Author: Jiri Danek
Date: 2018-08-07T18:16:18Z
NO-JIRA fix flaky tests QueueControlTest#testResetMessagesExpired
The occasional assertion error is prevented by using Wait.assertEquals
where Assert.assertEquals was used previously.
java.lang.AssertionError:
Expected :1
Actual :0
[...]
at org.junit.Assert.assertEquals(Assert.java:542)
at
org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testResetMessagesExpired(QueueControlTest.java:2370)
---
[GitHub] activemq-artemis pull request #2226: ARTEMIS-2016 fix flaky test QueueContro...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2226 ARTEMIS-2016 fix flaky test QueueControlTest#testRemoveAllWithPagingMode Parameters going into Wait.waitFor were originally wrong, because `durationMillis: 3, sleepMillis: 100` means you would test the condition only once. This commit is changing the durationMillis from 3ms to 3s, swapping the two numbers (duration 100ms, sleep 3ms) would also be reasonable, I think. Next, Wait.assertEquals is here being used, instead of Assert.assertTrue. I saw the test fail only once, and never was able to reproduce it again, but I think this commit does improve the test and so it is worthwhile. java.lang.AssertionError at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMetrics(QueueControlTest.java:2651) at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMessageMetrics(QueueControlTest.java:2615) at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testRemoveAllWithPagingMode(QueueControlTest.java:1554) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_maybe_swapped_wait_args Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2226.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2226 commit baaefa15595da5ec30218ca1b35d9fe80512007e Author: Jiri Danek Date: 2018-08-07T16:22:57Z ARTEMIS-2016 fix flaky test QueueControlTest#testRemoveAllWithPagingMode Parameters going into Wait.waitFor were originally wrong, because `durationMillis: 3, sleepMillis: 100` means you would test the condition only once. This commit is changing the durationMillis from 3ms to 3s, swapping the two numbers (duration 100ms, sleep 3ms) would also be reasonable, I think. Next, Wait.assertEquals is here being used, instead of Assert.assertTrue. I saw the test fail only once, and never was able to reproduce it again, but I think this commit does improve the test and so it is worthwhile. java.lang.AssertionError at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMetrics(QueueControlTest.java:2651) at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.assertMessageMetrics(QueueControlTest.java:2615) at org.apache.activemq.artemis.tests.integration.management.QueueControlTest.testRemoveAllWithPagingMode(QueueControlTest.java:1554) ---
[GitHub] activemq-artemis pull request #2224: Two small improvements to tests
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/2224
Two small improvements to tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis
jd_various_small_improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2224
commit 78ddb155db6a0eec568d99d28b7cb9b7b4a74181
Author: Jiri Danek
Date: 2018-08-07T14:42:04Z
NO-JIRA fix unused parameter `durable` in AmqpClientTestSupport#sendMessages
commit 4fb3f5efe786bfd36c8699650e4675bea7058109
Author: Jiri Danek
Date: 2018-08-07T19:01:04Z
NO-JIRA improve assertions in QueueControlTest
This commit replaces assert{True,Equals} with more specific assertion
methods.
---
[GitHub] activemq-artemis pull request #2207: NO-JIRA fix flaky test HeuristicXATest....
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2207 NO-JIRA fix flaky test HeuristicXATest.testRecoverHeuristicCommitWithRestart java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.activemq.artemis.tests.integration.client.HeuristicXATest.doRecoverHeuristicCompletedTxWithRestart(HeuristicXATest.java:306) at org.apache.activemq.artemis.tests.integration.client.HeuristicXATest.testRecoverHeuristicCommitWithRestart(HeuristicXATest.java:251) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_testRecoverHeuristicCommitWithRestart Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2207.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2207 commit 723ccae2a41dc70e8dacd23c73c0166977411c5e Author: Jiri Danek Date: 2018-07-22T08:57:14Z NO-JIRA fix flaky test HeuristicXATest.testRecoverHeuristicCommitWithRestart java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:743) at org.junit.Assert.assertEquals(Assert.java:118) at org.junit.Assert.assertEquals(Assert.java:555) at org.junit.Assert.assertEquals(Assert.java:542) at org.apache.activemq.artemis.tests.integration.client.HeuristicXATest.doRecoverHeuristicCompletedTxWithRestart(HeuristicXATest.java:306) at org.apache.activemq.artemis.tests.integration.client.HeuristicXATest.testRecoverHeuristicCommitWithRestart(HeuristicXATest.java:251) ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/177e6820b541e0a71b952eebf503a4d2235910c5#commitcomment-29554432 In hornetq-server/src/main/java/org/hornetq/core/server/impl/RefsOperation.java: In hornetq-server/src/main/java/org/hornetq/core/server/impl/RefsOperation.java on line 194: This really looks wrong. The auto-suggested fix seems wrong too. The code is in the latest master still. >artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java:184: error: [ModifyingCollectionWithItself] Using a collection function with itself as the argument. > listRet.addAll(listRet); >^ >(see http://errorprone.info/bugpattern/ModifyingCollectionWithItself) > Did you mean 'this.refsToAck.addAll(listRet);'? ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/f9af366f07368bfaed197cb1eddfde17506c9d84#commitcomment-29551294 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2973: Coverity does not like this. `user` may be null, such as in https://github.com/apache/activemq-artemis/blob/576cf7e73ddabdcbd67ea24a9111889d6c4c7e48/artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java#L837-L845 and `SimpleString` constructor does https://github.com/apache/activemq-artemis/blob/b7401819295e9ff32fb023beb22087afbdbaa4e9/artemis-commons/src/main/java/org/apache/activemq/artemis/api/core/SimpleString.java#L78-L84 ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/576cf7e73ddabdcbd67ea24a9111889d6c4c7e48#commitcomment-29469395 In artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java on line 515: `user.equals(queue.getUser())` won't work. Variable `user` is a `String` and `queue.getUser()` gives `SimpleString`, so these will be never equal according to String#equals. and there is extra pair of parenthesis around the whole expression ---
[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2084#discussion_r187648801
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageProducerTest.java
---
@@ -70,10 +70,31 @@ public void testAnonymousProducer() throws Exception {
}
@Test(timeout = 3)
- public void testAnonymousProducerWithAutoCreation() throws Exception {
- Connection connection = createConnection();
+ public void testAnonymousProducerWithQueueAutoCreation() throws
Exception {
+ try (Connection connection = createConnection()) {
+ Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
+ Queue queue = session.createQueue(UUID.randomUUID().toString());
+ MessageProducer p = session.createProducer(null);
- try {
+ TextMessage message = session.createTextMessage();
+ message.setText("hello");
+ // this will auto-create the address
+ p.send(queue, message);
--- End diff --
Thanks, I get it now. Ok, I don't need it.
---
[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2084#discussion_r187642736
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/JMSMessageProducerTest.java
---
@@ -70,10 +70,31 @@ public void testAnonymousProducer() throws Exception {
}
@Test(timeout = 3)
- public void testAnonymousProducerWithAutoCreation() throws Exception {
- Connection connection = createConnection();
+ public void testAnonymousProducerWithQueueAutoCreation() throws
Exception {
+ try (Connection connection = createConnection()) {
+ Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
+ Queue queue = session.createQueue(UUID.randomUUID().toString());
+ MessageProducer p = session.createProducer(null);
- try {
+ TextMessage message = session.createTextMessage();
+ message.setText("hello");
+ // this will auto-create the address
+ p.send(queue, message);
--- End diff --
How so? I do need at least one send when dealing with anonymous producer.
That is the point of the test, to send a message on the broker, that is the
point where any auto-creation happens.
---
[GitHub] activemq-artemis pull request #2084: ARTEMIS-1859 Adding testAnonymousProduc...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2084 ARTEMIS-1859 Adding testAnonymousProducerWithQueueAutoCreation You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_ARTEMIS-1859_anonymous_autocreate_queue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2084.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2084 commit d35566ce11b75701aeaf663757eeec672e327e96 Author: Jiri Danek Date: 2018-05-11T09:20:35Z ARTEMIS-1859 Adding testAnonymousProducerWithQueueAutoCreation ---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2080#discussion_r187455572
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -946,7 +946,7 @@ public boolean isReplicaSync() {
} else if (activation instanceof SharedNothingBackupActivation) {
return ((SharedNothingBackupActivation)
activation).isRemoteBackupUpToDate();
} else {
- throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
--- End diff --
Makes sense, although ARTEMIS-1018 Duplicate error ids on different error
mesages. Thanks for not making it worse, I guess.
---
[GitHub] activemq-artemis pull request #2080: ARTEMIS-1851 avoid exception in isRepli...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2080#discussion_r187450038
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
---
@@ -946,7 +946,7 @@ public boolean isReplicaSync() {
} else if (activation instanceof SharedNothingBackupActivation) {
return ((SharedNothingBackupActivation)
activation).isRemoteBackupUpToDate();
} else {
- throw ActiveMQMessageBundle.BUNDLE.methodNotApplicable();
--- End diff --
Isn't this the only place where this error message was generated? If so,
then it may be also deleted at
https://github.com/apache/activemq-artemis/blob/e5ef7d37ae255b9ed478bc4b45586cf8a179b18b/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQMessageBundle.java#L383-L384
---
[GitHub] activemq-artemis issue #2071: ARTEMIS-1804 don't call deprecated SslHandler#...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/2071 The deprecation commit in Netty is https://github.com/netty/netty/commit/1b313972492c1259db23c5481986bb21d2309dec ---
[GitHub] activemq-artemis pull request #2071: ARTEMIS-1804 don't call deprecated SslH...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2071 ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty The stacktrace of the exception involves a deprecated method. For some reason, using the recommended alternative does not produce the exception... Could this PR be step in the right direction? The Netty exception appears when OpenWire client which is using SSL disconnects: 2018-05-04 09:56:44,424 WARN [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617 ! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) [netty-all-4.1.24.Final.jar:4.1.24.Final] at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT] You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_netty_flush_woodo Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2071.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2071 commit b38a424a34fe0a6d3cef220e13bc906164b99e8c Author: Jiri Danek Date: 2018-05-04T12:15:43Z ARTEMIS-1804 don't call deprecated SslHandler#close() to avoid NPE in Netty The Netty exception appears when OpenWire client which is using SSL disconnects: 2018-05-04 09:56:44,424 WARN [io.netty.handler.ssl.SslHandler] [id: 0x1dcd30fa, L:/127.0.0.1:61617 ! R:/127.0.0.1:33006] flush() raised a masked exception.: java.lang.NullPointerException at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:760) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:752) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1625) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler.access$600(SslHandler.java:165) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.handler.ssl.SslHandler$1.run(SslHandler.java:649) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309) [netty-all-4.1.24.Final.jar:4.1.24.Final] at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884) [netty-all-4.1.24.Final.jar:4.1.24.Final] at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) [artemis-commons-2.6.0-SNAPSHOT.jar:2.6.0-SNAPSHOT] ---
[GitHub] activemq-artemis pull request #2055: ARTEMIS-1449 Artemis does not start on ...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/2055 ARTEMIS-1449 Artemis does not start on Oracle JDK 9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_ARTEMIS-1449_jdk9_run Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/2055.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2055 commit 5d668389b27d10526e157d4abf5efcf94a108c64 Author: Jiri Danek Date: 2018-05-01T06:15:51Z ARTEMIS-1449 Add the classes JRE 11 will remove as explicit dependencies Since the classes in question are marked for removal, using the ``--add-modules java.xml.bind` JVM option would be only a temporary solution. Pulling them as dependencies from repo1.maven.org and distributing them with Artemis should be more permanent one. commit db32c7221e7edfcdfa42c209efea68f588f92581 Author: Jiri Danek Date: 2018-05-01T06:27:20Z ARTEMIS-1449 Remove deprecated -XX:+UseFastAccessorMethods JVM option This option was removed in JRE 10 and its presence causes error on startup. Artemis still does not compile on JDK 9 and up, so what I tried was to compile on JDK 1.8 and then start Artemis on 1.8 and 10. That now works for me. ---
[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/2010#discussion_r180652792 --- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java --- @@ -2769,7 +2769,7 @@ public Queue createQueue(final AddressInfo addrInfo, throw ActiveMQMessageBundle.BUNDLE.invalidRoutingTypeForAddress(rt, info.getName().toString(), info.getRoutingTypes()); } - final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); + final QueueConfig queueConfig = queueConfigBuilder.filter(filter).pagingManager(pagingManager).user(user).durable(durable).temporary(temporary).autoCreated(autoCreated).routingType(addrInfo == null ? RoutingType.ANYCAST :addrInfo.getRoutingType()).maxConsumers(maxConsumers).purgeOnNoConsumers(purgeOnNoConsumers).exclusive(exclusive).lastValue(lastValue).build(); --- End diff -- About 20 lines above this one is RoutingType rt = (routingType == null ? ActiveMQDefaultConfiguration.getDefaultRoutingType() : routingType); [here](https://github.com/apache/activemq-artemis/blob/fa3e37fdb91c285bcfe87cab3d771dfe80019e18/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java#L2754) and [here](https://github.com/apache/activemq-artemis/blob/fa3e37fdb91c285bcfe87cab3d771dfe80019e18/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java#L2865) So maybe that one? ---
[GitHub] activemq-artemis pull request #2006: ARTEMIS-1798 DEBUG message bad write me...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2006#discussion_r180483597
--- Diff:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
---
@@ -84,6 +85,10 @@
import org.apache.activemq.util.LongSequenceGenerator;
public class OpenWireProtocolManager implements
ProtocolManager, ClusterTopologyListener {
+ static {
+ // this is not really a property, needs to be ignored
+
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
"setUpInactivityParams");
--- End diff --
@stanlyDoge told you so ))
---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/63e0c0d310850fb59f800d2cc5cf9c5cfc0060ec#commitcomment-27458675 In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java on line 282: >>> CID 1465080: Concurrent data access violations (GUARDED_BY_VIOLATION) >>> Accessing "message" without holding lock "PagedReferenceImpl.this". Elsewhere, "org.apache.activemq.artemis.core.paging.cursor.PagedReferenceImpl.message" is accessed with "PagedReferenceImpl.this" held 3 out of 4 times. https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/63e0c0d310850fb59f800d2cc5cf9c5cfc0060ec#commitcomment-27458655 In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java on line 285: >>> CID 1465081: Null pointer dereferences (FORWARD_NULL) >>> Unboxing null object "largeMessage". https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27450542 There are ways. Suppressions can be provided, in multiple ways (special form commits in source, or what Coverity calls "modeling files"), the daily report e-mail could be copied to project mailinglist for quick triage, ... FindBugs/SpotBugs can be executed locally on dev machines. There is fairly massive backlog of things in Coverity already (over 1000 items) and that can be used to get an idea of things it flags and to estimate future false positive rate. ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446263 Issues created and linked onto https://issues.apache.org/jira/browse/ARTEMIS-1400. ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446067 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2753: It is the right line. It was preexisting, after closer examination. (Coverity marked the previous item it had for this as fixed and created a new item, which is absolutely identical, barring the item id. Apparently, the item IDs are not completely stable between scan runs, if the code around changes.) ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27446032 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2862: bq. If you want to flag coverity issues in code suggest raising it as sepate jira and issue I am usually doing that, after I've investigated and decided it is a real issue. I am subscribed to the daily Coverity email, which includes any new items it found since the previous day. (With the day boundary at 20:00 CET.) This time I decided to try to go to the commits and try to "move the investigative burden" onto the authors, just to see what happens... Also, the Boolean comparisons seemed clear cut. This one is not a clear cut, I must admit. If I do investigate it and think it is a real problem, I will report it. ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request:
https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434879
Finally, there are the three following warnings, which are not directly
related to any of the changed lines
> Hi,
>
> Please find the latest report on new defect(s) introduced to
ApacheActiveMQArtemis found with Coverity Scan.
>
> 11 new defect(s) introduced to ApacheActiveMQArtemis found with Coverity
Scan.
> 4 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
```
*** CID 1465016: Null pointer dereferences (FORWARD_NULL)
/activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java:
1775 in
org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.loadPreparedTransactions(org.apache.activemq.artemis.core.postoffice.PostOffice,
org.apache.activemq.artemis.core.paging.PagingManager,
org.apache.activemq.artemis.core.transaction.ResourceManager, java.util.Map,
java.util.List, java.util.Map, java.util.Map, java.util.Set,
org.apache.activemq.artemis.core.server.impl.JournalLoader)()
1769 encoding.position.setRecordID(record.id);
1770
1771 PageSubscription sub =
locateSubscription(encoding.queueID, pageSubscriptions, queueInfos,
pagingManager);
1772
1773 if (sub != null) {
1774 sub.reloadPreparedACK(tx, encoding.position);
>>> CID 1465016: Null pointer dereferences (FORWARD_NULL)
>>> Passing "null" to "PagedReferenceImpl", which dereferences it.
1775 referencesToAck.add(new
PagedReferenceImpl(encoding.position, null, sub));
1776 } else {
1777
ActiveMQServerLogger.LOGGER.journalCannotFindQueueReloadingACK(encoding.queueID);
1778 }
1779 break;
1780}
```
To view the defects in Coverity Scan, visit
https://scan.coverity.com/projects/apacheactivemqartemis
```
*** CID 1465014: Null pointer dereferences (REVERSE_INULL)
/activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java:
2795 in
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.createQueue(org.apache.activemq.artemis.core.server.impl.AddressInfo,
org.apache.activemq.artemis.api.core.SimpleString,
org.apache.activemq.artemis.api.core.SimpleString,
org.apache.activemq.artemis.api.core.SimpleString, boolean, boolean, boolean,
boolean, boolean, int, boolean, boolean, boolean, boolean)()
2789 } catch (Throwable ignored) {
2790 logger.debug(ignored.getMessage(), ignored);
2791 }
2792 throw e;
2793 }
2794
>>> CID 1465014: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "addrInfo" suggests that it may be null, but it has
already been dereferenced on all paths leading to the check.
2795 if (addrInfo == null || !addrInfo.isInternal()) {
2796 managementService.registerQueue(queue,
queue.getAddress(), storageManager);
2797 }
2798
2799 callBrokerPlugins(hasBrokerPlugins() ? plugin ->
plugin.afterCreateQueue(queue) : null);
2800
```
To view the defects in Coverity Scan, visit
https://scan.coverity.com/projects/apacheactivemqartemis
```
*** CID 1465012: Null pointer dereferences (NULL_RETURNS)
/activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageSubscriptionImpl.java:
366 in
org.apache.activemq.artemis.core.paging.cursor.impl.PageSubscriptionImpl.getReference(org.apache.activemq.artemis.core.paging.cursor.PagePosition)()
360@Override
361public String toString() {
362 return "PageSubscriptionImpl [cursorId=" + cursorId + ",
queue=" + queue + ", filter = " + filter + "]";
363}
364
365private PagedReference getReference(PagePosition pos) {
>>> CID 1465012: Null pointer dereferences (NULL_RETURNS)
>>
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434723 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java on line 201: CID 1465015:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434650 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2522: There is one more case of this ``` *** CID 1465020:(FB.BX_UNBOXING_IMMEDIATELY_REBOXED) /activemq-artemis/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java: 1187 in org.apache.activemq.artemis.jms.client.ActiveMQSession.createSharedQueue(org.apache.activemq.artemis.jms.client.ActiveMQDestination, org.apache.activemq.artemis.api.core.RoutingType, org.apache.activemq.artemis.api.core.SimpleString, org.apache.activemq.artemis.api.core.SimpleString, boolean, int, boolean, java.lang.Boolean, java.lang.Boolean)() 1181 session.createSharedQueue( 1182 destination.getSimpleAddress(), 1183 routingType, 1184 queueName, 1185 filter, 1186 durable, >>> CID 1465020:(FB.BX_UNBOXING_IMMEDIATELY_REBOXED) >>> Boxed value is unboxed and then immediately reboxed. 1187 queueAttributes.getMaxConsumers() == null ? maxConsumers : queueAttributes.getMaxConsumers(), 1188 queueAttributes.getPurgeOnNoConsumers() == null ? purgeOnNoConsumers : queueAttributes.getPurgeOnNoConsumers(), 1189 queueAttributes.getExclusive() == null ? exclusive : queueAttributes.getExclusive(), 1190 queueAttributes.getLastValue() == null ? lastValue : queueAttributes.getLastValue() 1191 ); 1192 } /activemq-artemis/artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java: 1188 in org.apache.activemq.artemis.jms.client.ActiveMQSession.createSharedQueue(org.apache.activemq.artemis.jms.client.ActiveMQDestination, org.apache.activemq.artemis.api.core.RoutingType, org.apache.activemq.artemis.api.core.SimpleString, org.apache.activemq.artemis.api.core.SimpleString, boolean, int, boolean, java.lang.Boolean, java.lang.Boolean)() 1182 destination.getSimpleAddress(), 1183 routingType, 1184 queueName, 1185 filter, 1186 durable, 1187 queueAttributes.getMaxConsumers() == null ? maxConsumers : queueAttributes.getMaxConsumers(), >>> CID 1465020:(FB.BX_UNBOXING_IMMEDIATELY_REBOXED) >>> Boxed value is unboxed and then immediately reboxed. 1188 queueAttributes.getPurgeOnNoConsumers() == null ? purgeOnNoConsumers : queueAttributes.getPurgeOnNoConsumers(), 1189 queueAttributes.getExclusive() == null ? exclusive : queueAttributes.getExclusive(), 1190 queueAttributes.getLastValue() == null ? lastValue : queueAttributes.getLastValue() 1191 ); 1192 } 1193} ``` ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434598 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2522: >>> CID 1465021: FindBugs: Performance (FB.BX_UNBOXING_IMMEDIATELY_REBOXED) >>> Boxed value is unboxed and then immediately reboxed. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434602 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2522: Personally, I think this is not a problem... ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434497 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V4.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V4.java on line 145: >>> CID 1465018:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) >>> Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434477 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V4.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V4.java on line 143: >>> CID 1465018:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) >>> Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434442 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2753: >>> CID 1465017:(FORWARD_NULL) >>> Calling a method on null object "addrInfo". To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434447 In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java: In artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java on line 2862: >>> CID 1465017:(FORWARD_NULL) >>> Calling a method on null object "addrInfo". To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434355 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java on line 199: >>> CID 1465015:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) >>> Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434303 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateQueueMessage_V2.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateQueueMessage_V2.java on line 187: >>> CID 1465015:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) >>> Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434216 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateSharedQueueMessage_V2.java on line 195: >>> CID 1465013: FindBugs: Correctness (FB.RC_REF_COMPARISON) >>> Suspicious comparison of Integer references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/dc41f3ca491e96e199290a225fdaa07ac05d66df#commitcomment-27434102 In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V3.java: In artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionQueueQueryResponseMessage_V3.java on line 222: >>> CID 1465011:(FB.RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN) >>> Suspicious comparison of Boolean references. To view the defects in Coverity Scan, visit https://scan.coverity.com/projects/apacheactivemqartemis ---
[GitHub] activemq-artemis pull request #:
Github user jdanekrh commented on the pull request: https://github.com/apache/activemq-artemis/commit/8f47cd6e14d4f51995272feaae9460dd95e03fe5#commitcomment-27330540 In artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java: In artemis-ra/src/main/java/org/apache/activemq/artemis/ra/inflow/ActiveMQActivationSpec.java on line 938: @michaelandrepearce Looks like a typo. Should be `topicPrefix` in both places on the line. This got highlighted by Coverity. ---
[GitHub] activemq-artemis issue #1825: ARTEMIS-1643 Compaction must check against NUL...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1825 BTW, there was open Coverity defect for the NPE (which this commit resolved). There may be more such there. https://scan7.coverity.com/reports.htm#v26656/p14213/fileInstanceId=47048784&defectInstanceId=9867247&mergedDefectId=1455452&fileStart=501&fileEnd=578 (The page requires login, I sent @franz1981 an invite.) ---
[GitHub] activemq-artemis issue #1765: NO-JIRA fix warnings from w3c/link-checker in ...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1765 These are essentially trivial changes. But there were some broken links that are fixed, e.g. http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/ThreadPoolExecutor.htm. ---
[GitHub] activemq-artemis pull request #1765: NO-JIRA fix warnings from w3c/link-chec...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1765 NO-JIRA fix warnings from w3c/link-checker in docs also update URLs and `s/http/https` in docs wherever possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_docs_https Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1765.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1765 commit 472e42954079e3dd338f327360dadd928a2e8968 Author: Jiri Danek Date: 2017-12-22T21:25:21Z NO-JIRA fix warnings from w3c/link-checker in docs also update URLs and `s/http/https` in docs wherever possible ---
[GitHub] activemq-artemis issue #1740: ARTEMIS-1181 Fix broken links in user-manual
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1740 There is one link which I did not fix www-didc.lbl.gov/TCP-tuning/ in `configuring-transports.md`. The page is dead and there is no alternative besides archive.org version... ---
[GitHub] activemq-artemis pull request #1740: ARTEMIS-1181 Fix broken links in user-m...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1740 ARTEMIS-1181 Fix broken links in user-manual Either caused by improper escaping, or the #fragment is wrong You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_doc_fragment_links Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1740.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1740 commit 706b822fc319d77000aaeec780792a451976e1b2 Author: Jiri Danek Date: 2017-12-22T17:27:50Z ARTEMIS-1181 Fix broken links in user-manual Either caused by improper escaping, or the #fragment is wrong ---
[GitHub] activemq-artemis issue #1737: NO-JIRA fixing master
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1737 Thanks, I've pulled most recent changes and now I see the fix in place. Weird that there are some special parameters that can be configured through system properties, while most cannot... I guess somebody had reason when asking for it. ---
[GitHub] activemq-artemis issue #1737: NO-JIRA fixing master
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1737 The test seems to have been never running (never was annotated with `@Test`, maybe previous test runner did not require it?) and nobody complained when it was broken so long ago, apparently. I propose deleting the `SystemPropertyOverrideTest#testSystemPropertyOverride` test. ---
[GitHub] activemq-artemis issue #1737: NO-JIRA fixing master
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1737
The test was broken in 2013 by @jbertram 's commit
https://github.com/hornetq/hornetq/pull/1879 for Jira
https://issues.jboss.org/browse/HORNETQ-1411.
The relevant diff is (abbreviated)
```diff
- private final long timeout;
+ private long timeout =
HornetQDefaultConfiguration.getDefaultGroupingHandlerTimeout();
[...]
+ public GroupingHandlerConfiguration()
{
- this.type = type;
- this.name = name;
- this.address = address;
- this.timeout = timeout;
- if (System.getProperty(GROUP_TIMEOUT_PROP_NAME) != null)
- {
- this.groupTimeout =
Long.parseLong(System.getProperty(GROUP_TIMEOUT_PROP_NAME));
- }
- else
- {
- this.groupTimeout = groupTimeout;
- }
-
- if (System.getProperty(REAPER_PERIOD_PROP_NAME) != null)
- {
- this.reaperPeriod =
Long.parseLong(System.getProperty(REAPER_PERIOD_PROP_NAME));
- }
- else
- {
- this.reaperPeriod = reaperPeriod;
- }
}
```
---
[GitHub] activemq-artemis pull request #1727: ARTEMIS-1183 Delete empty "queue-attrib...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1727 ARTEMIS-1183 Delete empty "queue-attributes.html" doc page This is a follow-up to ARTEMIS-780 Added section on latest address model You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_queue_attributes_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1727.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1727 commit 1df2c2603328bba06407d16ca33e26a037c89b43 Author: Jiri Danek Date: 2017-12-19T12:50:47Z ARTEMIS-1183 Delete empty "queue-attributes.html" doc page This is a follow-up to ARTEMIS-780 Added section on latest address model ---
[GitHub] activemq-artemis pull request #1723: ARTEMIS-1463 Fix broker's mBean domain ...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1723 ARTEMIS-1463 Fix broker's mBean domain name You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_broker_mBean Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1723 commit 303a493f165d1edb7170d9be780441bb35717567 Author: Jiri Danek Date: 2017-12-15T19:52:20Z ARTEMIS-1463 Fix broker's mBean domain name ---
[GitHub] activemq-artemis issue #1688: ARTEMIS-1537 broker was less strict while relo...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1688 wow! such fix! thanks much! ---
[GitHub] activemq-artemis issue #1697: ARTEMIS-1341 fix test for getBytes
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1697 > Likewise i don't understand why OpenWire is skipped Skipping OpenWire is appropriate here, as [`Message#getBody`](https://docs.oracle.com/javaee/7/api/javax/jms/Message.html#getBody-java.lang.Class-) was added in JMS 2.0, and activemq-client implements only the 1.1 version of the JMS spec. ---
[GitHub] activemq-artemis pull request #1688: ARTEMIS-1537 broker was less strict whi...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r155199713
--- Diff:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/config/impl/ConfigurationValidationTest.java
---
@@ -57,4 +57,23 @@ public void testFullConfiguration() throws Exception {
Assert.assertEquals(true, fc.isPersistDeliveryCountBeforeDelivery());
}
+
+ @Test
+ public void testChangeConfiguration() throws Exception {
+ FileConfiguration fc = new FileConfiguration();
+ FileDeploymentManager deploymentManager = new
FileDeploymentManager("ConfigurationTest-full-config.xml");
+ deploymentManager.addDeployable(fc);
+ deploymentManager.readConfiguration();
+
+ boolean success = false; // test should fail because config contains
wrong element
+
+ deploymentManager = new
FileDeploymentManager("ConfigurationTest-full-config-wrong-address.xml");
+ deploymentManager.addDeployable(fc);
+ try {
+ deploymentManager.readConfiguration();
+ } catch (Exception e) {
+ success = true;
+ }
+ Assert.assertTrue(success);
--- End diff --
Tests like that seem to be usually written a bit differently, like this
https://github.com/apache/activemq-artemis/blob/f698a7f8189af7b70160ba18596be371642776bb/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/jms2client/BodyTest.java#L66
It can be worth it to name the exception variable `ignored`, not `e`,
because that is a hint to unused variable inspection in IntelliJ.
https://www.reddit.com/r/ProgrammerHumor/comments/2so5tu/mildly_amusing_intellij_suggests_to_rename_a/
Not sure what it would suggest if you have multiple ignored exceptions in
scope... It is less verbose than
https://docs.oracle.com/javase/7/docs/api/java/lang/SuppressWarnings.html
("unused")
---
[GitHub] activemq-artemis pull request #1684: ARTEMIS-1498: Openwire internal headers...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1684#discussion_r154599253
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
---
@@ -95,7 +95,7 @@
public class CoreAmqpConverter {
private static Logger logger =
Logger.getLogger(CoreAmqpConverter.class);
-
+ public static final String INTERNAL_HEADER = "__HDR_";
--- End diff --
I am thinking whether this variable should have a broader scope and be
consistently used instead of the string constant. I know of at least one other
such place, the `__HDR_` stripping code in
https://github.com/apache/activemq-artemis/pull/1320/files.
---
[GitHub] activemq-artemis issue #1683: ARTEMIS-1532 Enable tests which are unintentio...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1683 Well, I might've guessed the intent wrong in one or two cases, I guess. If I thought it is unintentional, I've either renamed the class (so that Surefire would pick it) or added the @Test annotation. If I thought it is intentional, I've added @Ignored annotation instead of whichever other method was used to disable that test. ---
[GitHub] activemq-artemis pull request #1683: ARTEMIS-1532 Enable tests which are uni...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1683 ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire This is not ready to be merged, because `HAAutomaticBackupSharedStoreTest` and `testSystemPropertyOverride` are failing after these changes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_skipped_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1683.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1683 commit 63cdbc4c26cbd419a8303a8b9796a0cdf4613b99 Author: Jiri Danek Date: 2017-12-03T18:44:58Z ARTEMIS-1532 Enable tests which are unintentionally skipped by Surefire These tests used to have a wrong name, so they weren't executed by Surefire during a `mvn test` run. After enablement, the following tests are now failing: org.apache.activemq.artemis.tests.integration.cluster.ha.HAAutomaticBackupSharedStoreTest org.apache.activemq.artemis.tests.integration.ra.OutgoingConnectionNoJTATest commit 380980b2c58a716cdbf8b81b2f5a9cba080d16c6 Author: Jiri Danek Date: 2017-12-03T18:56:47Z ARTEMIS-1532 Fix OutgoingConnectionNoJTATest ---
[GitHub] activemq-artemis pull request #1516: ARTEMIS-1398 Reproducer for the Jira ti...
Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/1516 ---
[GitHub] activemq-artemis pull request #1516: ARTEMIS-1398 Reproducer for the Jira ti...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1516 ARTEMIS-1398 Reproducer for the Jira ticket [WIP] Test is unfinished (haven't figured what exception is connect() supposed to throw) and currently failing on jUnit timeout. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_mqtt_wrong_password Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1516.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1516 commit 4571073339026132853ec528b3fb984b6dc65439 Author: Jiri Danek Date: 2017-09-06T20:35:15Z ARTEMIS-1398 Reproducer for the Jira ticket ---
[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136984584 --- Diff: artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/etc/commented-ping-settings.txt --- @@ -1,6 +1,6 @@
[GitHub] activemq-artemis pull request #1509: ARTEMIS-1385 fixed uncomplete comment a...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1509#discussion_r136912715 --- Diff: docs/user-manual/en/configuration-index.md --- @@ -112,7 +112,7 @@ system-property-prefix | Prefix for replacing configuration settings using Bean [transaction-timeout](transaction-config.md "Resource Manager Configuration") | how long (in ms) before a transaction can be removed from the resource manager after create time. Default=30 [transaction-timeout-scan-period](transaction-config.md "Resource Manager Configuration") | how often (in ms) to scan for timeout transactions. Default=1000 [wild-card-routing-enabled](wildcard-routing.md "Routing Messages With Wild Cards")| true means that the server supports wild card routing. Default=true -[network-check-NIC](network-isolation.md) | The network internet card to be used on InetAddress.isReacheable +[network-check-NIC](network-isolation.md) | The network internet controller to be used on InetAddress.isReacheable --- End diff -- NIC is Network Interface Controller. I had to google that and I guess it won't be obvious to more people. Maybe write the abbreviation and the meaning in parens after it, so that people learn this right away. Also, it may not be entirely obvious what are the NIC names. Something like eth0 on Linux? What it is on Windows? How can I list them? Any alternatives to this for older systems, that do not have the more robust "enp0s25" style naming and eth0 and eth1 may be randomly switched; or is that no longer a problem? ---
[GitHub] activemq-artemis issue #1507: NO-JIRA: Add non-null check to ServerSessionIm...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1507 This appears to fix ARTEMIS-1376. With the patch, I no longer see the AMQ224014: Failed to close session: java.lang.NullPointerException ---
[GitHub] activemq-artemis pull request #1458: NO-JIRA Add asserts to SessionTest#test...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1458 NO-JIRA Add asserts to SessionTest#testIllegalStateException The test used to pass before, and is still passing now. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_add_fails Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1458.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1458 commit ee9ac065fa92dad59f665bd94924318be9da27c4 Author: Jiri Danek Date: 2017-08-10T05:52:40Z NO-JIRA Add asserts to SessionTest#testIllegalStateException --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1441: NO-JIRA Updates to management.md doc [WIP]
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1441 Sorry, have missed your yesterday's comment. Unless nobody is taking issue with it, then yes. I can do Web Console related doc update in new PR later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1441: NO-JIRA Updates to management.md doc [W...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1441 NO-JIRA Updates to management.md doc [WIP] (I am marking this as WIP because I would like to hear first if these are changes in right direction, and also would want to link (create) doc page for the web console at the same time.) * add Jolokia to the initial list of ways to access management API * remove mentions of core queues, etc. (pre-addressing change) * activemq.notifications can be consumed with any client * activemq.management can be accessed only with Core or Core JMS clients * *.management.*Control are interfaces, not classes * remove ObjectNames from the summary of management methods. IMO that made the short paragraphs hard to read. And one can intuitively find them in jconsole, or use the Builder class to construct them in code. * move the note about empty filter to the queue management section * add code snippet for creating ObjectName with ObjectNameBuilder * mention web console and bin/artemis for interactive management * fix few typos You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_doc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1441.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1441 commit aa00fc18b22909d9518ea10d00d4eddee7a2824b Author: Jiri Danek Date: 2017-07-31T10:26:28Z NO-JIRA Updates to management.md doc * add Jolokia to the initial list of ways to access management API * remove mentions of core queues, etc. (pre-addressing change) * activemq.notifications can be consumed with any client * activemq.management can be accessed only with Core or Core JMS clients * *.management.*Control are interfaces, not classes * remove ObjectNames from the summary of management methods. IMO that made the short paragraphs hard to read. And one can intuitively find them in jconsole, or use the Builder class to construct them in code. * move the note about empty filter to the queue management section * add code snippet for creating ObjectName with ObjectNameBuilder * mention web console and bin/artemis for interactive management * fix few typos --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1439: ARTEMIS-1317 Expire messages that got expiredA...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1439 Yes, I run `mvn -Ptests -Pextra-tests -Popenwire-tests test` which includes integration-tests and activemq5-openwire tests you mentioned I should run. The fails are either fails that happen "always"", but somehow did not happen in the run with which I was comparing, or they did not happen when I rerun that pariticular test from the IDE afterwards. ## List of fails, before/after PR ```diff --- +++ @@ -1,34 +1,30 @@ -org.apache.activemq.ActiveMQXAConnectionFactoryTest.testRollbackXaErrorCode -org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit +org.apache.activemq.ActiveMQXAConnectionFactoryTest.testRollbackXaErrorCode +org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnCommit2 org.apache.activemq.artemis.tests.extras.byteman.BMFailoverTest.testFailoverOnReceiveCommit org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage org.apache.activemq.artemis.tests.extras.byteman.RaceOnSyncLargeMessageOverReplication2Test.testSendLargeMessage org.apache.activemq.artemis.tests.extras.byteman.RaceOnSyncLargeMessageOverReplicationTest.testSendLargeMessage +org.apache.activemq.artemis.tests.integration.amqp.AmqpReceiverDrainTest.testReceiverCanDrainMessagesQueue org.apache.activemq.artemis.tests.integration.client.LibaioDependencyCheckTest.testDependency -org.apache.activemq.artemis.tests.integration.client.NettyConsumerWindowSizeTest.testSlowConsumerNoBuffer org.apache.activemq.artemis.tests.integration.cluster.failover.AutomaticColocatedQuorumVoteTest.testSimpleDistributionOfBackupsMaxBackupsExceeded[replicated=true] org.apache.activemq.artemis.tests.integration.cluster.failover.BackupSyncJournalTest.testFailBack -org.apache.activemq.artemis.tests.integration.cluster.failover.BackupSyncJournalTest.testMessageSyncSimple -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedAsynchronousFailoverTest.testTransactional -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedFailoverTest.testTransactedMessagesWithConsumerStartedBeforeFailover -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageFailoverTest.testFailBack -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testLiveAndBackupLiveComesBack -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testNonTransacted -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageWithDelayFailoverTest.testTimeoutOnFailover +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedFailoverUsingNodeGroupNameTest.testXAMessagesSentSoRollbackOnEnd2 +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedLargeMessageFailoverTest.testFailThenReceiveMoreMessagesAfterFailover +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartBackupFirst +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartLiveFirst org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverNoNodeGroupNameTest.testStartLiveFirst org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverTest.testStartLiveFirst -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedManyMultipleServerFailoverTest.testStartLiveFirst -org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testReplicatedFailback -org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testForceFailover +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testFailBackLiveRestartsBackupIsGone +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedPagedFailoverTest.testXAMessagesSentSoRollbackOnEnd2 +org.apache.activemq.artemis.tests.integration.cluster.failover.ReplicatedWithDelayFailoverTest.testXAMessagesSentSoRollbackOnEnd2 +org.apache.activemq.artemis.tests.integration.divert.DivertTest.testInje
[GitHub] activemq-artemis pull request #1439: ARTEMIS-1317 Expire messages that got e...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1439 ARTEMIS-1317 Expire messages that got expiredAck() from OpenWire client This fixes org.apache.activemq.JmsSendReceiveWithMessageExpirationTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_ow_expiry Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1439.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1439 commit 62d831fc5f8d99b8fdf2b4c9751c1c753c124b3d Author: Jiri Danek Date: 2017-08-02T08:19:07Z ARTEMIS-1317 Expire messages that got expiredAck() from OpenWire client This fixes org.apache.activemq.JmsSendReceiveWithMessageExpirationTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1407: ARTEMIS-1276 fix JmsSendReceiveWithMessageExpi...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1407 The only change to test is adding line `commonSettings.setExpiryAddress(dla);` in broker creation. That causes the test to progress further (passes assert) and then the test tries to cast `Broker` it got from calling `getRegionBroker` to `RegionBroker`, so that had to be implemented (using mockito). And then it looks at statistics (messages in flight) so then I had to write a wrapper/fake/whatever-it-should-be-called for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1407: ARTEMIS-1276 fix JmsSendReceiveWithMessageExpi...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1407 I'd prefer to put the fix into a new PR, if you don't mind. I think there is already enough things in this one already. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1380: ARTEMIS-1265 JaCoCo profile for getting...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1380#discussion_r128638701
--- Diff: pom.xml ---
@@ -948,6 +966,169 @@
true
+
+
+ jacoco
+
+
+ org.jacoco
+ org.jacoco.core
+
+
+
+
+
+ org.jacoco
+ jacoco-maven-plugin
+
+
+jacoco-prepare
+validate
+
+ prepare-agent
+
+
+
${project.build.directory}/jacoco.exec
+
+ jacoco.agent
+
+
+
+merge
+none
+
+ merge
+
+
+
+
+
+
+ ${activemq.basedir}
+
+ **/*.exec
--- End diff --
The plugin looks at all dependencies of the current module and examines
them for jacoco.exec files.
New module or reusing existing one.
As I said, this was just a suggestion. Whatever works is fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1407: ARTEMIS-1276 fix JmsSendReceiveWithMessageExpi...
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1407
Right. Yeah, I think this one is actual OpenWire handling bug in Artemis.
If the message expires while it is being prefetched on client, server drops it
and never tries to expire it.
i may even have a fix, but this message lifecycle is quite complicated, so
it is likely I am missing something...
```diff
---
a/artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
+++
b/artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
@@ -298,8 +298,9 @@ public class AMQConsumer {
}
}
if (ack.isExpiredAck()) {
- //adjust delivering count for expired messages
- this.serverConsumer.getQueue().decDelivering(ackList.size());
+ for (MessageReference ref : ackList) {
+ref.getQueue().expire(ref);
+ }
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1380: ARTEMIS-1265 JaCoCo profile for getting...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1380#discussion_r128558584
--- Diff: pom.xml ---
@@ -948,6 +966,169 @@
true
+
+
+ jacoco
+
+
+ org.jacoco
+ org.jacoco.core
+
+
+
+
+
+ org.jacoco
+ jacoco-maven-plugin
+
+
+jacoco-prepare
+validate
+
+ prepare-agent
+
+
+
${project.build.directory}/jacoco.exec
+
+ jacoco.agent
+
+
+
+merge
+none
+
+ merge
+
+
+
+
+
+
+ ${activemq.basedir}
+
+ **/*.exec
--- End diff --
> So it generates separate report for each module with tests.
It generates report for all module's dependencies together. So, if you run
it in module that does not have any sources of its own, and it depends on all
other modules in the project, there is only the dependencies report, which ends
up being report for your whole project.
See for yourself:
```
$ git clone g...@github.com:jacoco/jacoco.git
$ cd jacoco
$ mvn verify
$ firefox org.jacoco.doc/target/site/jacoco-aggregate/index.html
```
> Element Missed Instructions Cov.
> org.jacoco.examples 411563 57%
> org.jacoco.agent.rt 187966 83%
> jacoco-maven-plugin 1741,680 90%
> ...
> Total 1,002 of 23,389 95%
(I noticed that the Jacoco project is using some ant magic too, so it looks
even using this target does not get rid of all ant.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1380: ARTEMIS-1265 JaCoCo profile for getting...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1380#discussion_r128500482
--- Diff: pom.xml ---
@@ -948,6 +966,169 @@
true
+
+
+ jacoco
+
+
+ org.jacoco
+ org.jacoco.core
+
+
+
+
+
+ org.jacoco
+ jacoco-maven-plugin
+
+
+jacoco-prepare
+validate
+
+ prepare-agent
+
+
+
${project.build.directory}/jacoco.exec
+
+ jacoco.agent
+
+
+
+merge
+none
+
+ merge
+
+
+
+
+
+
+ ${activemq.basedir}
+
+ **/*.exec
--- End diff --
afaik, the merge+ant thing is a workaround for . latest jacoco has
`report-aggregate` goal which should take care of it,
http://www.eclemma.org/jacoco/trunk/doc/report-aggregate-mojo.html. The way
this tends to be used is that one selects a module which does not hold any code
(something with docs, or artemis-distribution, in our case, maybe) and makes it
depend on all other modules (to ensure that the coverage report is written only
after .exec files were generated for all modules). JaCoCo itself does it this
way,
https://github.com/jacoco/jacoco/blob/86856fef9959d90acdddc9d15c7b3c5f587fe086/org.jacoco.doc/pom.xml#L130.
I do not know if it is any way better or worse than this solution. Just a
thought.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1411: NO-JIRA use random available port in We...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1411 NO-JIRA use random available port in WebServerComponentTest This should put a stop to the Apache Jenkins failing with > Test Result (2 failures / + 2) > org.apache.activemq.cli.test.WebServerComponentTest.testComponentStopBehavior > org.apache.activemq.cli.test.WebServerComponentTest.simpleServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_random_port_webserver_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1411.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1411 commit 443ac5ec5a6cfed1debdae276f72cf30fd3b44a8 Author: Jiri Danek Date: 2017-07-19T21:57:16Z NO-JIRA use random available port in WebServerComponentTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1407: ARTEMIS-1276 fix JmsSendReceiveWithMessageExpi...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1407 > messages only expire on client on activemq5 while it's on server & client on artemis Did you mean expire on _server_ on activemq5? If it expired on client, how would it then get to DLQ queue on server? --- I think get it now. When the test receives for the first time (first `for` loop), the client gets first 10 messages sent, which are those with short expiration time. One of them is delivered ok, the 9 remaining expire on the client while it is in sleep(). That means these 9 never get into the DLQ, because for that they would have to expire on the server. Which explains the `actual: 90, expected: 99` result when it is then receiving from DLQ. I did not know about this difference between 5 and Artemis. From user point of view, the fact that prefetch changes behavior (and is not just performance optimization) and that it can cause what can be thought of as a message loss (these 9 messages have irrevocably disappeared, right?) could be considered a bug, I think. I guess there is nothing to be done about it here, so removing [wip]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1409#discussion_r128231365 --- Diff: tests/activemq5-unit-tests/pom.xml --- @@ -460,6 +460,8 @@ **/org/apache/activemq/ProducerFlowControlTest.java **/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java + + **/org/apache/activemq/MessageEvictionTest.java --- End diff -- done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1409#discussion_r128155276 --- Diff: tests/activemq5-unit-tests/pom.xml --- @@ -460,6 +460,8 @@ **/org/apache/activemq/ProducerFlowControlTest.java **/org/apache/activemq/transport/tcp/TransportConnectorInvalidSocketOptionsTest.java + + **/org/apache/activemq/MessageEvictionTest.java --- End diff -- if that is how it is done regarding non-applicable activemq5 tests in Artemis, then sure, I can just delete the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1407: ARTEMIS-1276 fix JmsSendReceiveWithMessageExpi...
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1407 > it's probably an issue on the test. I was not sure. The same test is passing with ActiveMQ 5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1409: ARTEMIS-1276 avoid System.exit in tests...
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1409
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
Before
> Tests run: 662, Failures: 14, Errors: 4, Skipped: 1
After
> Tests run: 1166, Failures: 38, Errors: 1, Skipped: 2
(the second commit in the PR disables one of the erroring tests, because it
tests feature that Artemis does not implement)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_fix_exit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1409.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1409
commit 4bf4ec552612f5001897b195d27c61e48efdb00e
Author: Jiri Danek
Date: 2017-07-17T09:51:55Z
ARTEMIS-1276 avoid System.exit in tests as Surefire cannot deal with that
This change results in many more tests being run. Previously, 662 tests
were executed. Now, 1166 tests is executed. The running time has increased
from ~20 minutes to ~50 minutes.
commit 3ec9137a4656a5c7b35a469cde34ce2ab86177b8
Author: Jiri Danek
Date: 2017-07-18T11:55:07Z
ARTEMIS-1276 disable MessageEvictionTest
The test is broken. It can be fixed by doing
```java
FakeTransportConnector(URI uri) {
setServer(new TransportServer {
@Override
public URI getConnectURI() {
return uri;
}
but then the test would fail because message
eviction is not supported by Artemis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1408: NO-JIRA Fix documentation for
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1408 NO-JIRA Fix documentation for ... Followup to #553, eliminate all occurrences of the old connector-ref config (that used to use connector-name attribute) in broker.xml. CC @zhabba Can you have a look please? I hope I eliminated it all... at least grep -R says so. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_connector-ref_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1408.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1408 commit 4ec71e14043e2a91f4e03c30413e6fbd8dd7bfac Author: Jiri Danek Date: 2017-07-18T13:18:32Z NO-JIRA Fix documentation for ... Followup to #553, eliminate all occurrences of the old connector-ref config (that used to use connector-name attribute) in broker.xml. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1407: ARTEMIS-1276 fix JmsSendReceiveWithMess...
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1407
ARTEMIS-1276 fix JmsSendReceiveWithMessageExpirationTest [wip]
The JmsSendReceiveWithMessageExpirationTest#testConsumeExpiredQueueAndDlq
test used to fail with
>
JmsQueueCompositeSendReceiveTest>CombinationTestSupport.runBare:144->CombinationTestSupport.runBare:138->testSendReceive:86->JmsSendReceiveTestSupport.testSendReceive:
>
115->JmsSendReceiveTestSupport.assertMessagesAreReceived:156->JmsSendReceiveTestSupport.assertMessagesReceivedAreValid:176
Invalid number of messages received
> expected:<100> but was:<0>
After the changes in this PR, it is now failing with
junit.framework.AssertionFailedError: got dlq messages
Expected :99
Actual :90
I can get it to pass if I disable prefetch, that is, I also change
```
diff --git
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsSendReceiveWithMessageExpirationTest.java
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsSendReceiveWithMessageExpirationTest.java
index dffd72296..3ff305810 100644
---
a/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsSendReceiveWithMessageExpirationTest.java
+++
b/tests/activemq5-unit-tests/src/test/java/org/apache/activemq/JmsSendReceiveWithMessageExpirationTest.java
@@ -126,7 +126,7 @@ public class JmsSendReceiveWithMessageExpirationTest
extends TestSupport {
Connection consumerConnection = createConnection();
ActiveMQPrefetchPolicy prefetchPolicy = new ActiveMQPrefetchPolicy();
- prefetchPolicy.setAll(10);
+ prefetchPolicy.setAll(0);
((ActiveMQConnection)
consumerConnection).setPrefetchPolicy(prefetchPolicy);
Session consumerSession = consumerConnection.createSession(false,
Session.CLIENT_ACKNOWLEDGE);
MessageConsumer consumer =
consumerSession.createConsumer(consumerDestination);
```
I do not understand why prefetch breaks the test, and I do not know how to
begin investigating this effectively...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis
jd_JmsSendReceiveWithMessageExpirationTest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1407.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1407
commit b629c1b2835af5e60593ec6c79adce83d7962ece
Author: Jiri Danek
Date: 2017-06-26T13:16:44Z
ARTEMIS-1276 fix JmsSendReceiveWithMessageExpirationTest
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1393#discussion_r126614869
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyAcceptor.java
---
@@ -300,7 +300,7 @@ public synchronized void start() throws Exception {
if (useInvm) {
acceptorType = INVM_ACCEPTOR_TYPE;
channelClazz = LocalServerChannel.class;
- eventLoopGroup = new LocalEventLoopGroup();
+ eventLoopGroup = new DefaultEventLoopGroup();
--- End diff --
thanks. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1393: NO-JIRA deprecation fixes
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1393 Same as previous PR, Jenkins failed because of >Tests in error: > WebServerComponentTest.simpleServer:87 » Bind Address already in use > WebServerComponentTest.testComponentStopBehavior:124 » Bind Address already in... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1392: NO-JIRA fix few typos and a docstring
Github user jdanekrh commented on the issue: https://github.com/apache/activemq-artemis/pull/1392 Jenkins failed because of >Tests in error: > WebServerComponentTest.simpleServer:87 » Bind Address already in use > WebServerComponentTest.testComponentStopBehavior:124 » Bind Address already in... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1393: NO-JIRA deprecation fixes
GitHub user jdanekrh opened a pull request:
https://github.com/apache/activemq-artemis/pull/1393
NO-JIRA deprecation fixes
This is kind of a followup to #307. I am putting each fix into separate
commit for easier review (which is probably not necessary anymore, because the
previous PR fixed a lot of what I originally had prepared here too, so there is
not much to review).
I am wondering. What is the opinion about using `//noinspection
deprecation` magic comment that IntelliJ likes? (It can apply to a single
statement, while the annotation form `@SuppressWarnings("deprecation")` cannot.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jdanekrh/activemq-artemis jd_deprecated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1393.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1393
commit ffae6ef74f89a34a4036f1c0eb4a093f59f0f2e0
Author: Jiri Danek
Date: 2016-07-07T14:52:51Z
PROTOCOL_PROP_NAME
commit bc9a285659aec776b8bfefb1603866f733855a26
Author: Jiri Danek
Date: 2016-07-07T14:55:05Z
ConnectionLifeCycleListener
commit e8136355bcf63d6310bcf13f4615084a7bde259f
Author: Jiri Danek
Date: 2017-02-17T17:19:01Z
GENERIC_IGNORED_FILTER
commit b55240f6cacd030d934a44cfb78d26943721208a
Author: Jiri Danek
Date: 2017-02-17T17:23:13Z
HttpHeaders.Names
commit f40f104cac2592a7ebcc1ae28ef067c0749f09c6
Author: Jiri Danek
Date: 2017-02-17T17:23:52Z
HttpHeaders.Names and similar
commit be55734b28fd490373d66a01de57ad23d996ecd0
Author: Jiri Danek
Date: 2017-06-28T12:03:18Z
LocalEventLoopGroup
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1392: NO-JIRA fix few typos and a docstring
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1392 NO-JIRA fix few typos and a docstring You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis jd_typos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1392 commit b18d854fe1e46028675f6c181452a43ebae6a89d Author: Jiri Danek Date: 2017-06-28T12:09:37Z NO-JIRA fix few typos and a docstring --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...
Github user jdanekrh commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1358#discussion_r123471949
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java
---
@@ -256,6 +258,7 @@ void handlePubAck(int messageId) throws Exception {
private void sendServerMessage(int messageId, CoreMessage message, int
deliveryCount, int qos) {
String address =
MQTTUtil.convertCoreAddressFilterToMQTT(message.getAddress().toString(),
session.getWildcardConfiguration());
+ boolean isRetain = message.getBooleanProperty(new
SimpleString(MQTT_MESSAGE_RETAIN_KEY));
--- End diff --
I thought about it, and my conclusion was that since `getBooleanProperty`
starts like this
```java
... Boolean getBooleanProperty(final SimpleString key) throws ... {
Object value = doGetProperty(key);
if (value == null) {
return Boolean.valueOf(null);
```
then the only way to get `null` for isRetain would be if somebody
explicitly stored a `null` `Boolean` into the `MQTT_MESSAGE_RETAIN_KEY`
property. In which case I though passing the `null` along is appropriate.
Are you suggesting to do something like
isRetain = Boolean.valueOf(message.getBooleanProperty(...))
to be extra sure? I guess it can do no harm adding it... I'll try do it in
CET evening today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1358: ARTEMIS-1244 propagate retain flag of r...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1358 ARTEMIS-1244 propagate retain flag of received message You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis ARTEMIS-1244_fix-only Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1358.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #617: ARTEMIS-607 Added interceptor support fo...
Github user jdanekrh commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/617#discussion_r123258336 --- Diff: docs/user-manual/en/intercepting-operations.md --- @@ -9,7 +9,9 @@ makes interceptors powerful, but also potentially dangerous. ## Implementing The Interceptors -An interceptor must implement the `Interceptor interface`: +All interceptors are protocol specific. + +An interceptor for the core protocol must implement the interface `Interceptor`: --- End diff -- I'd change that to implement the `Interceptor` interface sounds more like standard Java-speak to me that way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis issue #1351: ARTEMIS-1220 Diverted LargeMessage file corrup...
Github user jdanekrh commented on the issue:
https://github.com/apache/activemq-artemis/pull/1351
This commit fixes integration-test
ReplicationWithDivertTest#testSendLargeMessage for me. Previously, the test
used to fail with `java.lang.NullPointerException` on `message.getBytes("test"
+ i).length` at
org.apache.activemq.artemis.tests.integration.divert.ReplicationWithDivertTest.testSendLargeMessage(ReplicationWithDivertTest.java:237).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1338: ARTEMIS-1212 add a jms.queue. workaroun...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1338 ARTEMIS-1212 add a jms.queue. workaround to HornetQProtocolManagerTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis ARTEMIS-1212 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1338.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1338 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1327: ARTEMIS-1219 set queue routing type in ...
Github user jdanekrh closed the pull request at: https://github.com/apache/activemq-artemis/pull/1327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1327: ARTEMIS-1219 set queue routing type in ...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1327 ARTEMIS-1219 set queue routing type in LargeMessageOverReplicationTest You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis ARTEMIS-1219 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1327.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1327 commit 0bd58a02c80d42c654fa57d2f7c55ca06c841224 Author: Jiri Danek Date: 2017-06-08T20:04:55Z ARTEMIS-1219 set queue routing type in LargeMessageOverReplicationTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] activemq-artemis pull request #1315: ARTEMIS-1193 upgrade byteman 2.2.0 -> 3...
GitHub user jdanekrh opened a pull request: https://github.com/apache/activemq-artemis/pull/1315 ARTEMIS-1193 upgrade byteman 2.2.0 -> 3.0.10 Version 3.x of Byteman adds ability to instrument classes with Java 8 features, notably lambdas. One of the previous commits added lambdas in class that is often instrumented by byteman extra-tests. This change fixes those tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jdanekrh/activemq-artemis ARTEMIS-1193 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1315.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1315 commit 2dbc7c12936b3665a79c0c6ffaa7c67e9bccb87b Author: Jiri Danek Date: 2017-06-03T16:33:32Z ARTEMIS-1193 upgrade byteman 2.2.0 -> 3.0.10 Version 3.x adds ability to instrument code with Java 8 features, notably lambdas. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
