Re: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread J Pai
Thanks everyone for the inputs.

I’m trying to get a proper build going locally for the site generation (and 
running into issues). Once I get a proper build and the fixes to the issues 
noted in that JIRA, I’ll send out an update. Hopefully soon.

-Jaikiran
On 25-May-2017, at 5:26 PM, Nicolas Lalevée  wrote:

The entire Ant site is in svn:
https://svn.apache.org/repos/asf/ant/site

There is a Readme.txt explaining a little bit stuff, but seems outdated since 
the migration to git. For Ivy and IvyDE, part of the site is built from the 
source for the projects. It used to be managed via svn:externals. Now there are 
ant tasks to run to the fetch of the sources. I have found an old discussion 
[1] we had about it which should help you.

By the way, the Ivy documentation is managed by an hand crafted html editor, 
xooki, just is good but quite slow. I did some work some time ago (2 years ago, 
time flies!) to try to migrate to asciidoc [2]. I can even see that locally I 
have a commit which for some reason I didn’t pushed. If we are still 
interested, I can revive this.

Nicolas

[1] 
http://ant.1045680.n5.nabble.com/stuck-with-site-generation-issue-for-ivy-td5715758.html
 

[2] https://github.com/apache/ant-ivy/tree/xooki2asciidoc 



> Le 25 mai 2017 à 06:12, J Pai  a écrit :
> 
> What would be the process of having the live docs of Ivy project updated to 
> fix/update an issue in the documentation[1]? 
> 
> The quickstart documentation refers to certain log files that get 
> auto-generated during the doc build process. It looks like those log files 
> weren’t uploaded and are resulting in a blank text area showing up. I can run 
> the doc generation target locally (on 2.4.0 tag) and have someone upload 
> those files and see if shows up fine.
> 
> [1] https://issues.apache.org/jira/browse/IVY-1542
> 
> -Jaikiran
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: IVYDE-382 proposed patch

2017-05-25 Thread J Pai
Hi Alexander,

Thank you for volunteering to provide this feature patch. I had a look a the 
repo you pointed to and read the README. It does seem to contain a good amount 
of work in that branch in multiple commits. 

To make it easier for whoever will decide about merging these to upstream 
ant-ivyde project, would it to be possible for you to do the following:

1. *Fork* the ant-ivyde project (on github) 
https://github.com/apache/ant-ivyde/ into your account. There’s a “Fork” button 
on the right corner of the github page for the repo.
2. Once forked into your account, you can push your enhancement and bug fix 
related commits to either your master branch of your repo or any specific 
branch of your choice.
- If the bug fixes are independent of the feature, then it would be 
good if they are done in separate branches, so that a separate pull request 
(PR) can be issued.
3. Once you are ready with the commits, you can then issue a pull request (PR) 
from your repo to the “master” branch of the ant-ivyde upstream repo 
https://github.com/apache/ant-ivyde/.  Typically PRs are meant to contain 
commits that are all specific to a single feature or for a specific bug fix.

Once the PRs are submitted, I’m sure one or more members of the development 
team who have relevant knowledge of Eclipse and the project will review this 
and either merge it or provide inputs.

Thanks again for this, both Ivy and IvyDE project has been stagnant for a while 
and with contributions like these, we should be able to release out a new 
version soon.

-Jaikiran


On 25-May-2017, at 1:12 PM, alexander.bl...@arctis.at wrote:

Dear Sir or Madam,

as it was suggested in 
https://issues.apache.org/jira/browse/IVYDE-382?focusedCommentId=16018847=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16018847,
 we are sending you our proposed patch for 
https://issues.apache.org/jira/browse/IVYDE-382. The corresponding patch-file 
is attached to this email. The source code is available at 
https://github.com/alex-bl/ivyDEextension/tree/ivyDECredentials in the branch 
"ivyDECredentials". 

Yours sincerely,

Alexander Blaas


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request:

https://github.com/apache/ant-ivy/pull/20

Fix IVY-1522

The commit here contains a potential fix for the issue reported in 
https://issues.apache.org/jira/browse/IVY-1522. This PR also contains a test 
case to verify the fix. 

**Note that this issue isn't reproducible on my \*nix system and as such 
the fix/PR itself needs to be tested on a Windows OS before being merged. That 
plus the fact that this commit deals with the part of the code which gets used 
in multiple places. Tests on my local \*nix have gone fine with this change and 
as such don't seem to introduce any regressions.**



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1522

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit c1765c71ba4394597409de790bf4529ff97e866e
Author: Jaikiran Pai 
Date:   2017-05-18T14:42:41Z

IVY-1522 Fix FileUtil.normalize to not base its normalization logic on ":" 
character




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #20: Fix IVY-1522

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at:

https://github.com/apache/ant-ivy/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request:

https://github.com/apache/ant-ivy/pull/21

Fix IVY-1495

The commit here is a potential fix for the issue reported in 
https://issues.apache.org/jira/browse/IVY-1495. The issue happens when the 
`ivysettings.xml` is being parsed and the `IvySettings` instance isn't yet 
available for getting hold of a relevant `matcher` referred to in the `ttl` 
config.

The commit here delays the access to the `matcher` from the `settings` 
instance, to when the settings instance is available.

The commit also includes a test case to verify the change.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1495

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #21


commit 0a50b2b3b5ecb67565505217876f355f74f5078f
Author: Jaikiran Pai 
Date:   2017-05-19T09:00:33Z

IVY-1495 Delay the processing of configured cache ttls, until the 
IvySettings object is usable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/21
  
Reopening this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #21: Fix IVY-1495

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at:

https://github.com/apache/ant-ivy/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
GitHub user jaikiran reopened a pull request:

https://github.com/apache/ant-ivy/pull/27

Fix IVY-1540

The commit here fixes the issue reported in 
https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now 
takes into account any potential circular dependencies that could result into a 
indefinite recursive calls.

This also includes a test case to verify such a use case.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaikiran/ant-ivy ivy-1540

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #27


commit 6cb32bd33e0e1d1758a3ed1d50df03b65032d9ac
Author: Jaikiran Pai 
Date:   2017-05-23T08:15:39Z

IVY-1540 Fix infinite loop in dependencytree, caused to due circular 
dependencies (coming in via Maven module descriptors)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/27
  
Now that the transient failure fixes have been merged and the Jenkins PR 
jobs are working, going to reopen this to trigger a new run of Jenkins.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #27: Fix IVY-1540

2017-05-25 Thread jaikiran
Github user jaikiran closed the pull request at:

https://github.com/apache/ant-ivy/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code

2017-05-25 Thread twogee
Github user twogee commented on the issue:

https://github.com/apache/ant-ivy/pull/31
  
Thanks for a nice summary and pointing out a paradigm that I did not 
investigate entirely. The essential work also included checking that all 
appropriate setUp() and tearDown() were public and/or necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



AW: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread jhm
+1 for asciidoc.
Using xooki means using a tool only few people know ...

Jan

> -Ursprüngliche Nachricht-
> Von: J Pai [mailto:jai.forums2...@gmail.com]
> Gesendet: Donnerstag, 25. Mai 2017 14:03
> An: Ant Developers List
> Betreff: Re: Ivy website - fixing a Quickstart documentation live
> 
> 
> On 25-May-2017, at 5:26 PM, Nicolas Lalevée
>  wrote:
> 
> 
> 
> > By the way, the Ivy documentation is managed by an hand crafted html
> editor, xooki, just is good but quite slow. I did some work some time
> ago (2 years ago, time flies!) to try to migrate to asciidoc [2]. I can
> even see that locally I have a commit which for some reason I didn’t
> pushed. If we are still interested, I can revive this.
> >
> 
> I’m very much interested in having the docs moved to asciidoc. I use it
> in almost every other project I deal with and it’s a big motivation to
> continue to write documentation and is definitely a big improvement on
> what we currently have. It doesn’t have to be something that we
> push/force in this release, but if we can transition to this
> documentation system, it’s going to be great.
> 
> -Jaikiran
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> commands, e-mail: dev-h...@ant.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #31: Convert tests to JUnit 4, clean up code

2017-05-25 Thread janmaterne
Github user janmaterne commented on the issue:

https://github.com/apache/ant-ivy/pull/31
  
That was a lot of work (or writing/using a transformator ;)
Basically it
- removes the "extends TestCase" and
- uses JUnit annotations
- change string.indexOf()!=-1 to string.contains()
- use foreach instead of for-i
- small improvements
- spell check

test/java/org/apache/ivy/ant/IvyCacheFilesetTest.java
In testFailure() you use @Test(expect=BuildException.class). Therefor the 
last fail() statement is obsolete.

This pattern occurs several more times. 
Could you change that?

Nice use of @Rule ExpectedException in IvyCleanCacheTest.
Could you use that in IvyConfigureTest#testOverrideNotAllowed() and Co?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #31: Convert tests to JUnit 4, clean up code

2017-05-25 Thread twogee
GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/31

Convert tests to JUnit 4, clean up code

JUnit 4 has primarily two benefits, clarity through annotations and more 
fine grained control of failures 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #31


commit 1543f528963246eacfdc3228d716d78ceba824b3
Author: twogee 
Date:   2017-05-25T15:25:59Z

Convert tests to JUnit 4, clean up code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy issue #30: Fix transient test failures

2017-05-25 Thread nlalevee
Github user nlalevee commented on the issue:

https://github.com/apache/ant-ivy/pull/30
  
I don't find the fix fully satisfying because it doesn't address the 
fragile static set of circularDependencyId, it might produce some side effect 
errors in the future. At least we should keep it mind that this is a weak spot 
in the code.
Nevertheless this patch nicely address the issue at hand so I merged it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant-ivy pull request #30: Fix transient test failures

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/30


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ivy documentation with asciidoc

2017-05-25 Thread Nicolas Lalevée

> Le 25 mai 2017 à 16:17, Matt Sicker  a écrit :
> 
> Merge commits always spam the commits list which, while annoying, I've
> learned to mass-delete whenever it happens. ;)
> 
> I looked at some random changes and found a couple markup typos, but
> otherwise it looks like it converted well enough.

Yes, I have stopped one too. Some things will need to be manually fixed after 
the automatic conversion.

> I'm more familiar with the maven plugins for site management, so I'm not
> sure about the integration aspects, but worst case scenario, can't you just
> commit the parts to svnpubsub on release?

If you look at the menu on the left, it is present on each page, so it means 
that for any new file or deleted file, every page has to be regenerated. The 
consequence it that generating a page of the site has to be aware of the list 
of all the pages of the documentation.

But we can imagine that we uncouple the documentation, like it is being done 
for the old versions of the documentation, in the « history » section, by just 
having a link. So yes we could some manual copy and publish to svnpubsub on 
release.

Nicolas

> 
> On 25 May 2017 at 09:00, Nicolas Lalevée  wrote:
> 
>> I have updated the branch xooki2asciidoc. The merge generated 50 emails,
>> which I still find weird, I would expect just one mail about the commit of
>> the merge.
>> 
>> I can see the current status of the transformation of the xooki source
>> into asciidoc source and then the generated html from that here:
>> http://hibnet.org/tmp/ivy-asciidoc/index.html > asciidoc/index.html>
>> 
>> It seems pretty good, but I didn’t looked to most of the pages.
>> 
>> Before going further, we need to figure out how it would be integrated to
>> the website since it is also managed by xooki. The site and the
>> documentation are tidily coupled by the toc which is managed by xooki.
>> 
>> Nicolas
>> 
>> 
> 
> 
> -- 
> Matt Sicker 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ivy documentation with asciidoc

2017-05-25 Thread Matt Sicker
Merge commits always spam the commits list which, while annoying, I've
learned to mass-delete whenever it happens. ;)

I looked at some random changes and found a couple markup typos, but
otherwise it looks like it converted well enough.

I'm more familiar with the maven plugins for site management, so I'm not
sure about the integration aspects, but worst case scenario, can't you just
commit the parts to svnpubsub on release?

On 25 May 2017 at 09:00, Nicolas Lalevée  wrote:

> I have updated the branch xooki2asciidoc. The merge generated 50 emails,
> which I still find weird, I would expect just one mail about the commit of
> the merge.
>
> I can see the current status of the transformation of the xooki source
> into asciidoc source and then the generated html from that here:
> http://hibnet.org/tmp/ivy-asciidoc/index.html  asciidoc/index.html>
>
> It seems pretty good, but I didn’t looked to most of the pages.
>
> Before going further, we need to figure out how it would be integrated to
> the website since it is also managed by xooki. The site and the
> documentation are tidily coupled by the toc which is managed by xooki.
>
> Nicolas
>
>


-- 
Matt Sicker 


Ivy documentation with asciidoc

2017-05-25 Thread Nicolas Lalevée
I have updated the branch xooki2asciidoc. The merge generated 50 emails, which 
I still find weird, I would expect just one mail about the commit of the merge.

I can see the current status of the transformation of the xooki source into 
asciidoc source and then the generated html from that here:
http://hibnet.org/tmp/ivy-asciidoc/index.html 


It seems pretty good, but I didn’t looked to most of the pages.

Before going further, we need to figure out how it would be integrated to the 
website since it is also managed by xooki. The site and the documentation are 
tidily coupled by the toc which is managed by xooki.

Nicolas



Re: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread J Pai

On 25-May-2017, at 5:26 PM, Nicolas Lalevée  wrote:



> By the way, the Ivy documentation is managed by an hand crafted html editor, 
> xooki, just is good but quite slow. I did some work some time ago (2 years 
> ago, time flies!) to try to migrate to asciidoc [2]. I can even see that 
> locally I have a commit which for some reason I didn’t pushed. If we are 
> still interested, I can revive this.
> 

I’m very much interested in having the docs moved to asciidoc. I use it in 
almost every other project I deal with and it’s a big motivation to continue to 
write documentation and is definitely a big improvement on what we currently 
have. It doesn’t have to be something that we push/force in this release, but 
if we can transition to this documentation system, it’s going to be great.

-Jaikiran


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



Re: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread Nicolas Lalevée
The entire Ant site is in svn:
https://svn.apache.org/repos/asf/ant/site

There is a Readme.txt explaining a little bit stuff, but seems outdated since 
the migration to git. For Ivy and IvyDE, part of the site is built from the 
source for the projects. It used to be managed via svn:externals. Now there are 
ant tasks to run to the fetch of the sources. I have found an old discussion 
[1] we had about it which should help you.

By the way, the Ivy documentation is managed by an hand crafted html editor, 
xooki, just is good but quite slow. I did some work some time ago (2 years ago, 
time flies!) to try to migrate to asciidoc [2]. I can even see that locally I 
have a commit which for some reason I didn’t pushed. If we are still 
interested, I can revive this.

Nicolas

[1] 
http://ant.1045680.n5.nabble.com/stuck-with-site-generation-issue-for-ivy-td5715758.html
 

[2] https://github.com/apache/ant-ivy/tree/xooki2asciidoc 



> Le 25 mai 2017 à 06:12, J Pai  a écrit :
> 
> What would be the process of having the live docs of Ivy project updated to 
> fix/update an issue in the documentation[1]? 
> 
> The quickstart documentation refers to certain log files that get 
> auto-generated during the doc build process. It looks like those log files 
> weren’t uploaded and are resulting in a blank text area showing up. I can run 
> the doc generation target locally (on 2.4.0 tag) and have someone upload 
> those files and see if shows up fine.
> 
> [1] https://issues.apache.org/jira/browse/IVY-1542
> 
> -Jaikiran
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 



Re: Versioning scheme in Ivy

2017-05-25 Thread Gintautas Grigelionis
Sorry for a roundabout way of getting to the point, but wouldn't the
characters used in matchers be treated in a special way, thus restricting
their use in version strings?

On a related theme, should Ivy support semver ranges [1]? (that would
include >, <, >=, <=, =, ||, &, !, and shorthands [2] *, ^, ~, " - ") There
seems to be at least one Java implementation [3], but it might be too
opinionated about version strings :-)

[1] https://github.com/npm/node-semver
[2] https://nodesource.com/blog/semver-tilde-and-caret
[3] https://github.com/zafarkhaja/jsemver

2017-05-25 12:16 GMT+02:00 Nicolas Lalevée :

> Almost everything in Ivy is configurable, like the version matchers [1].
>
> Ivy provide some sane default, but if some has a weird use case, he will
> be able to tweak thing to make it work.
>
> Nicolas
>
> [1] https://ant.apache.org/ivy/history/latest-milestone/
> settings/version-matchers.html  history/latest-milestone/settings/version-matchers.html>
>
>
> > Le 24 mai 2017 à 10:22, Gintautas Grigelionis 
> a écrit :
> >
> > Sorry, I meant to ask what may happen if special characters from range
> > specification are used randomly in a version string?
> >
> > Gintas
> >
> > 2017-05-24 10:15 GMT+02:00 Gintautas Grigelionis <
> g.grigelio...@gmail.com>:
> >
> >> I was thinking about the discussion which touched upon restricted
> >> characters in version strings. While Ivy does not place any
> restrictions on
> >> those strings, Ivy does support versions ranges as specified by OSGi.
> So,
> >> what happens if version range is used as a version string?
> >>
> >> Gintas
> >>
>
>


Re: Versioning scheme in Ivy

2017-05-25 Thread Nicolas Lalevée
Almost everything in Ivy is configurable, like the version matchers [1].

Ivy provide some sane default, but if some has a weird use case, he will be 
able to tweak thing to make it work.

Nicolas

[1] 
https://ant.apache.org/ivy/history/latest-milestone/settings/version-matchers.html
 



> Le 24 mai 2017 à 10:22, Gintautas Grigelionis  a 
> écrit :
> 
> Sorry, I meant to ask what may happen if special characters from range
> specification are used randomly in a version string?
> 
> Gintas
> 
> 2017-05-24 10:15 GMT+02:00 Gintautas Grigelionis :
> 
>> I was thinking about the discussion which touched upon restricted
>> characters in version strings. While Ivy does not place any restrictions on
>> those strings, Ivy does support versions ranges as specified by OSGi. So,
>> what happens if version range is used as a version string?
>> 
>> Gintas
>> 



Re: Ivy - Goals for the upcoming release?

2017-05-25 Thread Nicolas Lalevée
Thank you very much Jaikiran for your detailed explanation.

I have to admit that I don’t know the answer to which is the source of truth 
about the resolution report. I have also wondered why the resolve report should 
have to be always wrote and then read from file. I’ll try to get an answer 
myself too while reading the code.

Nicolas

> Le 22 mai 2017 à 07:37, J Pai  a écrit :
> 
> One other thing about this issue - this is reproducible (as shown in the test 
> case) with static revisions too and isn’t specific to any dynamic revision 
> resolution.
> 
> -Jaikiran
> On 22-May-2017, at 11:02 AM, J Pai  wrote:
> 
> I have had a look at that issue, this last week and I have been able to 
> reproduce it in a simple test case[1]. I kind of understand what the issue is 
> in there, but given my lack of knowledge of the Ivy codebase, I haven’t been 
> able to figure how to fix this correctly. In fact, this issue is what 
> prompted me to ask this question [2] in the dev list a day or so back, since 
> basically comes down to those files. Here’s my understanding of the problem 
> (backed by that test case[1] which reproduces it).
> 
> Imagine you have a module org:hello-world and imagine it has 2 configurations 
> conf1 and conf2. Now consider the case where this hello-world module depends 
> on org:module1:1.0 in conf1 (a direct dependency) and on org:module2:1.0 in 
> conf2 (a direct dependency). That translates to a module descriptor like:
> 
> 
>module="hello-world"
> revision="1.2.3"
> 
>   />
>   
>   
>   
>   
>   
>   
>   
>   
> 
> 
> Now take this one step further and consider that org:module2:1.0 (that 
> hello-world depends on, in conf2) has a dependency of its own on 
> org:module1:2.0. So module2’s module descriptor looks like:
> 
> 
> module="module2"
>revision="1.0"
> />
>   
>   
>   
> 
>   
> 
> 
> 
> So ultimately, when you resolve the hello-world module, you expect it to have 
> org:module1:1.0 as an dependency in conf1 and org:module1:2.0 as an 
> dependency in conf2 (transitively via org:module2:1.0).
> 
> Does the resolve work as expected for this use case? Yes it does and the 
> resolution pulls in the right set of dependencies in the right 
> configurations. Internally it creates resolution report (as an xml) plus a 
> resolution properties file for this resolution. No (obvious/apparent) issues 
> at this point. 
> 
> Now, let’s say a “deliver” is triggered against this resolution, for conf1. 
> What I would expect is, that it would deliver a file for hello-world which 
> then has a dependency on org:module1:1.0 in conf1 (because that’s what it was 
> correctly resolved to previously). However, the delivered file instead has a 
> dependency on org:module1:2.0 in conf1 and I believe that’s the issue being 
> reported in that JIRA.
> 
> So is this a bug in the deliver task itself? I don’t think so. So far what I 
> have narrowed it down to is that the resolve task that happened previously 
> creates more than one representation of that resolution (one a resolution 
> report xml and one a resolution properties file). The resolution report XML 
> has all the necessary and correct information about which dependency (either 
> direct or transitive) belongs to which configuration. However, the resolution 
> properties file contains the “wrong” dependency for module1 - it stores the 
> dependency as org:module1:2.0. I am not even sure if the properties file is 
> capable enough of supporting/understanding dependencies per configuration. 
> The deliver task then uses this properties file (instead of the resolution 
> report XML) to decide what dependencies to write out. I’m guessing some other 
> (post-resolve) tasks too use this properties file for their decision making, 
> so this really boils down to a potential bug in what gets written out to this 
> resolution properties file, during resolve.
> 
> Unfortunately, my reading of the code so far hasn’t given me answers on what 
> role this file plays and why can’t it be just skipped and the resolution 
> report XML instead be considered the single source of truth. Hence that 
> question [2] in the dev list. I can’t really think of a solution/fix for this 
> issue, without reading more of the current Ivy code to understand what role 
> these files play.
> 
> [1] 
> https://github.com/jaikiran/ant-ivy/commit/529a3fa05ed5dd115bdf8046d0cf0ffe034905e0#diff-6ed8218b6bb9460014cf3558ff227172R571
> [2] https://www.mail-archive.com/dev@ant.apache.org/msg45402.html
> 
> -Jaikiran
> 
> On 21-May-2017, at 10:49 PM, Nicolas Lalevée  
> wrote:
> 
> One thing though.
> 
> This revival of the community has been triggered by the comments on this 
> issue:
> https://issues.apache.org/jira/browse/IVY-1485 
> 
> It would be a shame if it is not fixed within the next release.
> 
> 

IVYDE-382 proposed patch

2017-05-25 Thread alexander . blaas
Dear Sir or Madam, 

as it was suggested in
https://issues.apache.org/jira/browse/IVYDE-382?focusedCommentId=16018847=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16018847,
we are sending you our proposed patch for
https://issues.apache.org/jira/browse/IVYDE-382. The corresponding
patch-file is attached to this email. The source code is available at
https://github.com/alex-bl/ivyDEextension/tree/ivyDECredentials in the
branch "ivyDECredentials".  

Yours sincerely, 

Alexander Blaasdiff --git a/org.apache.ivyde.eclipse/.classpath b/org.apache.ivyde.eclipse/.classpath
index 85c53c9..16c3e8e 100644
--- a/org.apache.ivyde.eclipse/.classpath
+++ b/org.apache.ivyde.eclipse/.classpath
@@ -1,22 +1,4 @@
 
-
 
 	
 	
diff --git a/org.apache.ivyde.eclipse/.settings/org.eclipse.jdt.core.prefs b/org.apache.ivyde.eclipse/.settings/org.eclipse.jdt.core.prefs
index ac46b41..3eff64b 100644
--- a/org.apache.ivyde.eclipse/.settings/org.eclipse.jdt.core.prefs
+++ b/org.apache.ivyde.eclipse/.settings/org.eclipse.jdt.core.prefs
@@ -1,21 +1,3 @@
-#***
-#* Licensed to the Apache Software Foundation (ASF) under one
-#* or more contributor license agreements.  See the NOTICE file
-#* distributed with this work for additional information
-#* regarding copyright ownership.  The ASF licenses this file
-#* to you under the Apache License, Version 2.0 (the
-#* "License"); you may not use this file except in compliance
-#* with the License.  You may obtain a copy of the License at
-#*
-#*   http://www.apache.org/licenses/LICENSE-2.0
-#*
-#* Unless required by applicable law or agreed to in writing,
-#* software distributed under the License is distributed on an
-#* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-#* KIND, either express or implied.  See the License for the
-#* specific language governing permissions and limitations
-#* under the License.
-#***
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
@@ -95,7 +77,12 @@
 org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_cases=true
 org.eclipse.jdt.core.formatter.indent_switchstatements_compare_to_switch=true
 org.eclipse.jdt.core.formatter.indentation.size=4
-org.eclipse.jdt.core.formatter.insert_new_line_after_annotation=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_field=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_local_variable=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_method=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_package=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_parameter=insert
+org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_type=insert
 org.eclipse.jdt.core.formatter.insert_new_line_after_opening_brace_in_array_initializer=do not insert
 org.eclipse.jdt.core.formatter.insert_new_line_at_end_of_file_if_missing=do not insert
 org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement=do not insert
diff --git a/org.apache.ivyde.eclipse/META-INF/MANIFEST.MF b/org.apache.ivyde.eclipse/META-INF/MANIFEST.MF
index f354d8e..94b6ae8 100644
--- a/org.apache.ivyde.eclipse/META-INF/MANIFEST.MF
+++ b/org.apache.ivyde.eclipse/META-INF/MANIFEST.MF
@@ -1,8 +1,8 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Apache IvyDE
-Bundle-SymbolicName: org.apache.ivyde.eclipse; singleton:=true
-Bundle-Version: 2.3.0.qualifier
+Bundle-SymbolicName: org.apache.ivyde.eclipse;singleton:=true
+Bundle-Version: 2.3.1.qualifier
 Bundle-ClassPath: ivyde-eclipse.jar
 Bundle-Activator: org.apache.ivyde.internal.eclipse.IvyPlugin
 Bundle-Vendor: Apache Software Foundation
@@ -33,6 +33,11 @@
  org.eclipse.debug.core;bundle-version="[3.4.0,4.0.0)",
  org.eclipse.jdt.launching;bundle-version="[3.4.0,4.0.0)",
  org.eclipse.debug.ui;bundle-version="[3.4.0,4.0.0)",
- org.eclipse.core.variables;bundle-version="[3.2.0,4.0.0)"
+ org.eclipse.core.variables;bundle-version="[3.2.0,4.0.0)",
+ org.eclipse.equinox.security;bundle-version="[1.1.100,2.0.0)",
+ org.eclipse.core.databinding;bundle-version="[1.4.1,2.0.0)",
+ org.eclipse.core.databinding.property;bundle-version="[1.4.100,2.0.0)",
+ org.eclipse.core.databinding.beans;bundle-version="[1.2.200,2.0.0)",
+ org.eclipse.jface.databinding;bundle-version="[1.6.0,2.0.0)"
 Bundle-ActivationPolicy: lazy
 Bundle-RequiredExecutionEnvironment: JavaSE-1.6
diff --git a/org.apache.ivyde.eclipse/build.properties b/org.apache.ivyde.eclipse/build.properties
index bf2f878..0cf07a1 100644
--- a/org.apache.ivyde.eclipse/build.properties
+++ 

Re: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread Gintautas Grigelionis
By the way... we'll need ant-ivy-site-styles
, too :-)

Gintas


Re: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread Gintautas Grigelionis
The files mentioned in JIRA were absent for a couple of years. If they're
available, let's get them into the site repo, otherwise the css files must
be adjusted.

I remember there was a discussion about gitpubsub... perhaps if we
understand how current svnpubsub hooks are set up, going to gitpubsub
shouldn't be complicated. We'll need a dedicated repo to publish to
(ant-site-live), for starters, because that repo would aggregate publishing
from Ant, Ivy, and IvyDE. Then, we'll need a ant-site-source, and the
routines for getting parts of ant-site-live updated either from
ant-site-source or from documentation generated by builds for respective
project.

Gintas

2017-05-25 8:30 GMT+02:00 Jan Matèrne (jhm) :

> The whole site is in svn and a server process (svnpubsub i think) is
> getting
> the 'publish' files and pushing them to the webserver which brings them
> online.
>
> We havent thought about a migrating that to git in the last few years ;)
>
> If these files are really required, I could upload them.
>
>
> Jan
>
>
>
> > -Ursprüngliche Nachricht-
> > Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
> > Gesendet: Donnerstag, 25. Mai 2017 06:29
> > An: Ant Developers List
> > Betreff: Re: Ivy website - fixing a Quickstart documentation live
> >
> > Is the documentation still in SVN? IVY-1542 is about site/sources/style
> > which is shared by Ivy and IvyDE. Are there any plans about migrating
> > this to Git and separating the source repo from publication repo?
> >
> > Gintas
> >
> > 2017-05-25 6:12 GMT+02:00 J Pai :
> >
> > > What would be the process of having the live docs of Ivy project
> > > updated to fix/update an issue in the documentation[1]?
> > >
> > > The quickstart documentation refers to certain log files that get
> > > auto-generated during the doc build process. It looks like those log
> > > files weren’t uploaded and are resulting in a blank text area showing
> > > up. I can run the doc generation target locally (on 2.4.0 tag) and
> > > have someone upload those files and see if shows up fine.
> > >
> > > [1] https://issues.apache.org/jira/browse/IVY-1542
> > >
> > > -Jaikiran
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > > commands, e-mail: dev-h...@ant.apache.org
> > >
> > >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
>
>


AW: Ivy website - fixing a Quickstart documentation live

2017-05-25 Thread jhm
The whole site is in svn and a server process (svnpubsub i think) is getting
the 'publish' files and pushing them to the webserver which brings them online.

We havent thought about a migrating that to git in the last few years ;)

If these files are really required, I could upload them.


Jan



> -Ursprüngliche Nachricht-
> Von: Gintautas Grigelionis [mailto:g.grigelio...@gmail.com]
> Gesendet: Donnerstag, 25. Mai 2017 06:29
> An: Ant Developers List
> Betreff: Re: Ivy website - fixing a Quickstart documentation live
> 
> Is the documentation still in SVN? IVY-1542 is about site/sources/style
> which is shared by Ivy and IvyDE. Are there any plans about migrating
> this to Git and separating the source repo from publication repo?
> 
> Gintas
> 
> 2017-05-25 6:12 GMT+02:00 J Pai :
> 
> > What would be the process of having the live docs of Ivy project
> > updated to fix/update an issue in the documentation[1]?
> >
> > The quickstart documentation refers to certain log files that get
> > auto-generated during the doc build process. It looks like those log
> > files weren’t uploaded and are resulting in a blank text area showing
> > up. I can run the doc generation target locally (on 2.4.0 tag) and
> > have someone upload those files and see if shows up fine.
> >
> > [1] https://issues.apache.org/jira/browse/IVY-1542
> >
> > -Jaikiran
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional
> > commands, e-mail: dev-h...@ant.apache.org
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org