Re: vmwatcher junit patch
Here is the patch (currently not in the state that i could apply it..)
On 12/12/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Hi,
I have prepared a patch for the vmwatcher file missing, will apply it
after 1.7.0 is released.
Hi Martijn,
what does it consist of?
The times that I have seen missing vmwatcher files is due to a classpath
problem - either a) the junitrunner class cannot be loaded or b) an
old junitrunner class is loaded.
I fear that b) may happen with people getting ant.1.6 jars in by accident.
Peter
Martijn
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Index: src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java
===
--- src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java
(revision 486298)
+++ src/main/org/apache/tools/ant/taskdefs/optional/junit/JUnitTask.java
(working copy)
@@ -1025,13 +1025,20 @@
String vmCrashString = unknown;
BufferedReader br = null;
try {
-br = new BufferedReader(new FileReader(vmWatcher));
-vmCrashString = br.readLine();
+if (vmWatcher.exists()) {
+br = new BufferedReader(new FileReader(vmWatcher));
+vmCrashString = br.readLine();
+} else {
+vmCrashString = Monitor file
(+vmWatcher.getAbsolutePath()+) missing, location writable? Alternatively
testcase not started!;
+}
} catch (Exception e) {
e.printStackTrace();
// ignored.
} finally {
FileUtils.close(br);
+if (vmWatcher.exists()) {
+vmWatcher.delete();
+}
}
if (watchdog != null watchdog.killedProcess()) {
result.timedOut = true;
@@ -1040,7 +1047,6 @@
result.crashed = true;
logVmCrash(feArray, test, vmCrashString);
}
-vmWatcher.delete();
if (!propsFile.delete()) {
throw new BuildException(Could not delete temporary
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Release of Apache Ant 1.7.0 - new upload done
Hi I thought Kev just (say) he would pull the HasFreeSpace for 1.7.0 to be added after 1.7.0 is released? shouldn't we wait for that? Martijn On Wed, 13 Dec 2006, Steve Loughran wrote: Antoine Levy-Lambert wrote: Hello, I did a third upload where the HasFreeSpace condition will be present. Regards, Antoine ok. is this the artifact I should be voting on? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: AW: svn commit: r486146 - /ant/core/trunk/src/main/org/apache/tools/ant/util/StringUtils.java
On Tue, 12 Dec 2006, [EMAIL PROTECTED] wrote: Doesnt work on my JDK-1.2.1_004 Hi Jan, were you able to run the official 1.7.0 RC with JDK-1.2.1? Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Ant 1.7.0 ?
I do think we should not be adding any functionality between a RC and the final build, would I be the only one (I already have my doubts on doing non-essential things between the RCs). Martijn Hello, I will build a candidate for 1.7.0 this evening then. Regards, Antoine Original-Nachricht Datum: Tue, 12 Dec 2006 15:58:26 + Von: Peter Reilly [EMAIL PROTECTED] An: Ant Developers List dev@ant.apache.org Betreff: Re: Ant 1.7.0 ? On 12/12/06, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: Hello Peter, my plan was to build Ant 1.7.0 final last Sunday, but I delayed this. What are the critical changes we are waiting for ? I assumed that there was to be another RC from emails sent (delay the RC (steve).) I do not know of any critical changes, except maybe to suppress caching resource collections. We need: to add extra diagnostics for junit (the missing vmwatcher file issue), manual pages for the new script options for scriptdef, scriptselector etc. However these are not critical. Peter Regards, Antoine On Dec 12, 2006, at 3:52 AM, Peter Reilly wrote: I thought that the plan was to have an RC2. Peter On 12/12/06, Kevin Jackson [EMAIL PROTECTED] wrote: Hi all, JDK6 has just been released (I'm downloading now), can we hold final 1.7.0 until we've done a smoke test on Java6/JDK6 on major platforms? This will also give us more time to test Peters javax.scripting work on a compliant platform. Thanks, Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r486141 - /ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
Hi
Could those tests be please be written in such way that these will not
fail / error under jdk 1.5 or lower?
And do you feel 100% comfortable in adding this while working on the
release candidates?
Br Martijn
Author: kevj
Date: Tue Dec 12 05:53:13 2006
New Revision: 486141
URL: http://svn.apache.org/viewvc?view=revrev=486141
Log:
-test for hasfreespace condition
Added:
ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
Added: ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
URL:
http://svn.apache.org/viewvc/ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml?view=autorev=486141
==
--- ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
(added)
+++ ant/core/trunk/src/tests/antunit/taskdefs/condition/hasfreespace-test.xml
Tue Dec 12 05:53:13 2006
@@ -0,0 +1,36 @@
+?xml version=1.0?
+project name=hasfreespace-test default=all basedir=.
xmlns:au=antlib:org.apache.ant.antunit
+
+ target name=test-not-enough-space-human
+au:assertFalse
+ hasfreespace partition=c: needed=1P/
+/au:assertFalse
+ /target
+
+ target name=test-enough-space-human
+au:assertTrue
+ hasfreespace partition=c: needed=1K/
+/au:assertTrue
+ /target
+
+ target name=test-not-enough-space
+ property name=long.max-value value=9223372036854775807/
+au:assertFalse
+ hasfreespace partition=c: needed=${long.max-value}/
+/au:assertFalse
+ /target
+
+ target name=test-enough-space
+au:assertTrue
+ hasfreespace partition=c: needed=1/
+/au:assertTrue
+ /target
+
+ target name=all
+au:antunit
+ fileset file=${ant.file}/
+ au:plainlistener/
+/au:antunit
+ /target
+
+/project
\ No newline at end of file
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Ant 1.7.0 ?
On Tue, 12 Dec 2006, Peter Reilly wrote: My comment was on the define feature in macrodef it has been in the build for a while (~a year). It was placed there as an experiment, but I do not think that people have used it (as there is no comments, and it does not fullfill its usecase - it leaves removable properties). If it is left in now, it will be there forever! (due to BC). Peter Looks like a very good reason to not make the final build until it is removed, I would call this essential. On 12/12/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: I do think we should not be adding any functionality between a RC and the final build, would I be the only one (I already have my doubts on doing non-essential things between the RCs). Martijn Hello, I will build a candidate for 1.7.0 this evening then. Regards, Antoine Original-Nachricht Datum: Tue, 12 Dec 2006 15:58:26 + Von: Peter Reilly [EMAIL PROTECTED] An: Ant Developers List dev@ant.apache.org Betreff: Re: Ant 1.7.0 ? On 12/12/06, Antoine Levy-Lambert [EMAIL PROTECTED] wrote: Hello Peter, my plan was to build Ant 1.7.0 final last Sunday, but I delayed this. What are the critical changes we are waiting for ? I assumed that there was to be another RC from emails sent (delay the RC (steve).) I do not know of any critical changes, except maybe to suppress caching resource collections. We need: to add extra diagnostics for junit (the missing vmwatcher file issue), manual pages for the new script options for scriptdef, scriptselector etc. However these are not critical. Peter Regards, Antoine On Dec 12, 2006, at 3:52 AM, Peter Reilly wrote: I thought that the plan was to have an RC2. Peter On 12/12/06, Kevin Jackson [EMAIL PROTECTED] wrote: Hi all, JDK6 has just been released (I'm downloading now), can we hold final 1.7.0 until we've done a smoke test on Java6/JDK6 on major platforms? This will also give us more time to test Peters javax.scripting work on a compliant platform. Thanks, Kev - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [RE-VOTE] AntUnit 1.0 Beta 2
Stefan Bodewig wrote: Hi, I've re-built AntUnit with -source 1.2 and uploaded everything to http://people.apache.org/~bodewig/antunit/. I'd like to release those files as 1.0Beta2. Sorry, do not have the time to look at this at the moment, don't wait for me so: +0 Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils)
Ist es nicht schrecklich, dass der menschlichen Klugheit so enge Grenzen gesetzt sind und der menschlichen Dummheit überhaupt keine? (Konrad Adenauer) Isn't it terrible that so close borders are set to the human intelligence and the human stupidity at all none? On Fri, 21 Apr 2006, Kev Jackson wrote: I'm viewing the cleanest split as using an interface, from your perspective you think a master FileUtils (class not interface) that delegates all the real work to a specialization class. Not exactly, I am thinking about delegating to different specialization classes. Some aspects depend on java version, some aspects on os version, some aspects on availability of 3pp. To be able to handle that I think it is better to split functionality up. Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Marking deprecated with since tags
On Fri, 21 Apr 2006, Kev Jackson wrote: * @deprecated since 1.4.x Use getGlobalFilterSet().addFilter(token,value) Is this seen as useful. And how do you look at the proposal to drop the deprecated since 1.4.x in 1.7? +1 There's a fair bit of old code that has been deprecated for a while - I seriously doubt that users are going to suddenly update from Ant 1.3 to Ant 1.7 and expect all their builds to work. Kev This is not about normal users of ant, but of 3pp using the code of ant, for instance to provide ant tasks. If someone made an Ant task on 1.3 it continues to function until we remove these items. So it could very well be that the user is using this task originally designed for ant 1.3, rebuild by someone else against ant 1.6.5 (ignoring the deprication warnings), gets intro trouble. otoh if we never can clean up anthing... Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [patch] NioFileUtils, Java6FileUtils, FileUtilsAdapter + factory, build.xml (was Re: AW: Adding a methof to StringUtils)
Ist es nicht schrecklich, dass der menschlichen Klugheit so enge Grenzen gesetzt sind und der menschlichen Dummheit überhaupt keine? (Konrad Adenauer) Isn't it terrible that so close borders are set to the human intelligence and the human stupidity at all none? This is a nice quote (totally OT I hope :) It never is totally off topic, and is definitely including myself. The sheer fact that it came through is my own stupidity. (For some reason one of my mail clients puts this signature on top of every reply, which I normally kill out when sending things to mailing lists). Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] removal of icontract based task in ant
+1 Martijn On Fri, 14 Apr 2006, Antoine Levy-Lambert wrote: Hello, Do you want to remove from ant the usage of icontract : see the documentation of the optional task icontract [1]. The link [2] contained in the page [3] listing the library dependencies of ant is dead. [ ] Yes [ ] No I consider this a code change, requiring lazy approval and then lazy consensus from the active committers. Let me start with my +1. Regards, Antoine [1] http://ant.apache.org/manual/OptionalTasks/icontract.html [2] http://www.reliable-systems.com/tools/ [3] http://ant.apache.org/manual/install.html#librarydependencies - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] removal of Visual for Java based tasks
+1, Martijn On Fri, 14 Apr 2006, Antoine Levy-Lambert wrote: Hello, Do you want to remove from ant the usage of Visual Age for Java : see this document : [1] I believe that IBM has replaced Visual Age for Java with WSAD since a long time. Stefan Bodewig also wrote that the Visual Age Tasks in ant cannot work any more any way because they require Java 1.1 [ ] Yes [ ] No I consider this a code change, requiring lazy approval and then lazy consensus from the active committers. Let me start with my +1. Regards, Antoine [1] http://ant.apache.org/manual/Integration/VAJAntTool.html#tasks [2] http://article.gmane.org/gmane.comp.jakarta.ant.devel/43832 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Ant 1.6.5 release
+1 Martijn Hello, I propose to release Ant 1.6.5 on Thursday, June 2nd. This will be a pure bug fix release. [] Yes [] No Let's begin with my +1 Cheers, Antoine - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Shut down the 1.6 branch after 1.6.5
+1 Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Ant 1.6.3 release candidate
Should we wait a few more days? Maybe yes. I do have a few bug assigned to me that I want to fix, basically javadoc and cvstagdiff. The later will involve adding a new class and has the potential to cause trouble, so I'd feel more comfortable if we waited two more days (either I get things done until tomorrow evening my time, or I won't this week). And then I'm holding back two patches that I want to see confirmed before I merge them. If we don't get confirmation, they'll stay in CVS HEAD - if we get confirmation that the nightly builds work, I don't have a problem with merging them between RC and final release. After that there will still be about ten or twenty reports that I could look into, but I should get real and say I won't manage to do so before 1.6.3. If we want to get this ready by April, that is. My query ant_open_bug yields 736 bugs. Which of the bugs are worth looking into? btw I'd also be in favour of having RC1 out this month, 23 seems a bit too short given the other reactions. +1 on any date this month Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: When to move Ant to SVN?
If we do keep CVS open for 1.6 maintenance it will mean merging changes between svn (1.7) and cvs (1.6). That will be difficult, IMHO. I don't think we want to straddle CVS and SVN. Just a single jump across before the release will be cleaner. Would this really be a problem if we would only fix serious bugs on 1.6 after the 1.6.3 release. (This includes no more nice to haves on 1.6.x) Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [VOTE] Start a subproject for Ant libraries
+1 I'd rather have only one version control system though, (and a version control system that is supported by a non sandbox part of ant). This is not meant as a no against svn, but more as ant should in that case also be migrated to svn lets say this calender year, and the svn tasks should be moved to a normal ant library before that. Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
