Re: cvs commit: ant/docs/manual install.html

2005-05-13 Thread Stefan Bodewig
On Thu, 12 May 2005, Steve Cohen [EMAIL PROTECTED] wrote:

 I don't know, though, guys.  What do you think?  Is it really worth
 it to avoid making the users upgrade?

For me it depends on when you wanted to see the new task.

If you wanted to include it in 1.6.4 (which is unlikely to happen
anyway, given Steve's and Matt's comments) then you wouldn't get a +1
from me if it forced people to upgrade commons-net.  This is just too
fresh IMHO.

If you are shooting for 1.7, having the code depend on commons-net
1.4.x is fine with me.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2005-05-13 Thread Steve Cohen
Stefan Bodewig wrote:
On Thu, 12 May 2005, Steve Cohen [EMAIL PROTECTED] wrote:

I don't know, though, guys.  What do you think?  Is it really worth
it to avoid making the users upgrade?

For me it depends on when you wanted to see the new task.
If you wanted to include it in 1.6.4 (which is unlikely to happen
anyway, given Steve's and Matt's comments) then you wouldn't get a +1
from me if it forced people to upgrade commons-net.  This is just too
fresh IMHO.
If you are shooting for 1.7, having the code depend on commons-net
1.4.x is fine with me.
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Well, I've done it.  1.4.0 is no longer required.  Have a look.  It 
isn't too ugly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: ant/docs/manual install.html

2005-05-12 Thread Stefan Bodewig
On 12 May 2005, [EMAIL PROTECTED] wrote:

   +For all users, a minimum version of commons-net of 1.4.0 is now 
 required.

Is this really true?

I understand it is required to compile ftp or if you use one of
the new features.  But if you use ftp the same way you did
before and use a binary installation of Ant, 1.2.x should work as
well, not?

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2005-05-12 Thread Steve Cohen
Stefan Bodewig wrote:
On 12 May 2005, [EMAIL PROTECTED] wrote:

 +For all users, a minimum version of commons-net of 1.4.0 is now required.

Is this really true?
I understand it is required to compile ftp or if you use one of
the new features.  But if you use ftp the same way you did
before and use a binary installation of Ant, 1.2.x should work as
well, not?
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

You are correct, sir.  It won't compile but it will run against the 
older jar, as long as the new functionalities are not called.  I forget 
that not everyone wants to build ant :-).

The existing tests can be run successfully if you ignore the errors. 
You see, Antoine, your tests have already proven their value!

I will revise this documentation, and also change the code to output a 
more meaningful error message if anyone tries to use the new features 
with an older jar.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: ant/docs/manual install.html

2005-05-12 Thread Steve Cohen
Steve Cohen wrote:
Stefan Bodewig wrote:
On 12 May 2005, [EMAIL PROTECTED] wrote:

 +For all users, a minimum version of commons-net of 1.4.0 is now 
required.

Is this really true?
I understand it is required to compile ftp or if you use one of
the new features.  But if you use ftp the same way you did
before and use a binary installation of Ant, 1.2.x should work as
well, not?
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

You are correct, sir.  It won't compile but it will run against the 
older jar, as long as the new functionalities are not called.  I forget 
that not everyone wants to build ant :-).

The existing tests can be run successfully if you ignore the errors. You 
see, Antoine, your tests have already proven their value!

I will revise this documentation, and also change the code to output a 
more meaningful error message if anyone tries to use the new features 
with an older jar.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Nope, spoke too soon.  I wasn't running against what I thought I was.
With commons-net-1.2.2 jar, the bad import statement makes the test 
constructor throw.

This is so ugly.
I wonder if I could do a Class.forName(), and if it doesn't throw, I 
know I can use reflection to do the new stuff, and avoid importing the 
new class.

This is so ugly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: ant/docs/manual install.html

2005-05-12 Thread Steve Cohen
Steve Cohen wrote:
Steve Cohen wrote:
Stefan Bodewig wrote:
On 12 May 2005, [EMAIL PROTECTED] wrote:

 +For all users, a minimum version of commons-net of 1.4.0 is 
now required.


Is this really true?
I understand it is required to compile ftp or if you use one of
the new features.  But if you use ftp the same way you did
before and use a binary installation of Ant, 1.2.x should work as
well, not?
Stefan
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

You are correct, sir.  It won't compile but it will run against the 
older jar, as long as the new functionalities are not called.  I 
forget that not everyone wants to build ant :-).

The existing tests can be run successfully if you ignore the errors. 
You see, Antoine, your tests have already proven their value!

I will revise this documentation, and also change the code to output a 
more meaningful error message if anyone tries to use the new features 
with an older jar.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Nope, spoke too soon.  I wasn't running against what I thought I was.
With commons-net-1.2.2 jar, the bad import statement makes the test 
constructor throw.

This is so ugly.
I wonder if I could do a Class.forName(), and if it doesn't throw, I 
know I can use reflection to do the new stuff, and avoid importing the 
new class.

This is so ugly.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

OK.  I found a way that isn't quite so ugly.  I moved all the code that 
references the new class in commons-net off to a separate compilation 
unit, a new class in the org.apache.tools.ant.taskdefs.optional.net 
package.  Now there are no issues with bad import statements in the FTP 
class itself.

Since the new class is in the same package as FTP.java it doesn't need 
to be imported in order to compile.  The new class isn't referenced 
unless the right commons-net version is present.

As long as the new code isn't called, there is no problem when using 
older versions of commons-net.  Otherwise, a BuildException is thrown.

I don't know, though, guys.  What do you think?  Is it really worth it 
to avoid making the users upgrade?

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


Re: cvs commit: ant/docs/manual install.html

2004-06-29 Thread Antoine Levy-Lambert
Hi Steve,
glad to read a commit mail from you on the ant list.
Can you merge your change on the ANT_16 branch ?
Cheers,
Antoine

 scohen  2004/06/28 19:27:45
 
   Modified:docs/manual install.html
   Log:
   update to reflect the latest release of commons-net which fixed some
   bugs that interfered with the Ant interface.
   
   Revision  ChangesPath
   1.71  +1 -1  ant/docs/manual/install.html
   
   Index: install.html
   ===
   RCS file: /home/cvs/ant/docs/manual/install.html,v
   retrieving revision 1.70
   retrieving revision 1.71
   diff -u -r1.70 -r1.71
   --- install.html2 Jun 2004 21:18:41 -   1.70
   +++ install.html29 Jun 2004 02:27:45 -  1.71
   @@ -403,7 +403,7 @@
tda name=commons-netcommons-net.jar/td
tdftp, rexec and telnet tasksbr
jakarta-oro 2.0.1 or later is required in any case together with
 commons-net.br
   -For a use with a Microsoft FTP server, a minimum version of
 commons-net of 1.2.1 is required.
   +For all users, a minimum version of commons-net of 1.2.2 is
 recommended.
/td
tda href=http://jakarta.apache.org/commons/net/index.html;
  
 target=_tophttp://jakarta.apache.org/commons/net/index.html/a/td
   
   
   
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread Stefan Bodewig
On 28 Jun 2003, [EMAIL PROTECTED] wrote:

   bsf2.3 is recommended.

Uhm, bsf 2.3 or higher is required would be better.  1.6's script
doesn't compile against BSF 2.2.

   rhino 1.5R3 is the recommended version. Do not use 1.5R4.

I'll look into rephrasing that.  This is true for 2.3.0-rc1, but will
hopefully not be true for the final release - BSF's CVS HEAD compiles
fine against Rhino 1.5R4.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread Antoine Levy-Lambert
Hi Stefan,
my information regarding versions of bsj.jar and js.jar came from this
source :
an email of Peter Reilly :
http://article.gmane.org/gmane.comp.jakarta.ant.user/13887
This information was helpful for me setting up the use of Javascript in ant.
Concerning Rhino 1.5R4, the question is : does ant javascript !!! run !!!
(not compile) properly
with it ?
Cheers,
Antoine

- Original Message -
From: Stefan Bodewig [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Monday, June 30, 2003 8:44 AM
Subject: Re: cvs commit: ant/docs/manual install.html


 On 28 Jun 2003, [EMAIL PROTECTED] wrote:

bsf2.3 is recommended.

 Uhm, bsf 2.3 or higher is required would be better.  1.6's script
 doesn't compile against BSF 2.2.

rhino 1.5R3 is the recommended version. Do not use 1.5R4.

 I'll look into rephrasing that.  This is true for 2.3.0-rc1, but will
 hopefully not be true for the final release - BSF's CVS HEAD compiles
 fine against Rhino 1.5R4.

 Stefan

 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread Stefan Bodewig
On Mon, 30 Jun 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
wrote:

 This information was helpful for me setting up the use of Javascript
 in ant.

Oh, I'm sure it was.

 Concerning Rhino 1.5R4, the question is : does ant javascript !!! 
 run !!!  (not compile) properly with it ?

We have a simplistic test case for javascript that also gets run by
Gump IIRC.  Gump uses the CVS versions of Apache BSF as well as Rhino.

Stefan

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread peter reilly
Yep it works with CVS versions,
but the latest released versions of both
do not work together.

bsf 2.3.0 rc1 
and Rhino 1.5R4 or Rhino 1.5R41
gives the error:
java.lang.NoSuchMethodError:
org.mozilla.javascript.Context.getDebuggableEngine()Lorg/mozilla/javascript/debug/DebuggableEngine;
Peter

On Mon, 2003-06-30 at 10:19, Stefan Bodewig wrote:
 On Mon, 30 Jun 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
 wrote:
 
  This information was helpful for me setting up the use of Javascript
  in ant.
 
 Oh, I'm sure it was.
 
  Concerning Rhino 1.5R4, the question is : does ant javascript !!! 
  run !!!  (not compile) properly with it ?
 
 We have a simplistic test case for javascript that also gets run by
 Gump IIRC.  Gump uses the CVS versions of Apache BSF as well as Rhino.
 
 Stefan
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread Antoine Levy-Lambert
In this case, I will fill a bug report against bsf in bugzilla, asking them
to support the latest version of rhino. Comments ?

Antoine
- Original Message -
From: peter reilly [EMAIL PROTECTED]
To: Ant Developers List [EMAIL PROTECTED]
Sent: Monday, June 30, 2003 12:28 PM
Subject: Re: cvs commit: ant/docs/manual install.html


 Yep it works with CVS versions,
 but the latest released versions of both
 do not work together.

 bsf 2.3.0 rc1
 and Rhino 1.5R4 or Rhino 1.5R41
 gives the error:
 java.lang.NoSuchMethodError:

org.mozilla.javascript.Context.getDebuggableEngine()Lorg/mozilla/javascript/
debug/DebuggableEngine;
 Peter

 On Mon, 2003-06-30 at 10:19, Stefan Bodewig wrote:
  On Mon, 30 Jun 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
  wrote:
 
   This information was helpful for me setting up the use of Javascript
   in ant.
 
  Oh, I'm sure it was.
 
   Concerning Rhino 1.5R4, the question is : does ant javascript !!!
   run !!!  (not compile) properly with it ?
 
  We have a simplistic test case for javascript that also gets run by
  Gump IIRC.  Gump uses the CVS versions of Apache BSF as well as Rhino.
 
  Stefan
 
  -
  To unsubscribe, e-mail: [EMAIL PROTECTED]
  For additional commands, e-mail: [EMAIL PROTECTED]
 
 


 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread Stefan Bodewig
On Mon, 30 Jun 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
wrote:

 In this case, I will fill a bug report against bsf in bugzilla,
 asking them to support the latest version of rhino. Comments ?

They already know - and BSF's CVS works, no need for an additional bug
report IMHO.

Stefan

Apart from that, the bugzilla setup for BSF is still broken and the
only one receiving your report would be me. 8-(

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: cvs commit: ant/docs/manual install.html

2003-06-30 Thread peter reilly
The only thing thats needs to be done is that
the ant manual for 1.6 should be correct.

The contents of the manual would indicate the
versions that do work - this will depend
on when ant 1.6 is released ;-)
and when newer versions of BSF are released.

Peter

On Mon, 2003-06-30 at 12:17, Stefan Bodewig wrote:
 On Mon, 30 Jun 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
 wrote:
 
  In this case, I will fill a bug report against bsf in bugzilla,
  asking them to support the latest version of rhino. Comments ?
 
 They already know - and BSF's CVS works, no need for an additional bug
 report IMHO.
 
 Stefan
 
 Apart from that, the bugzilla setup for BSF is still broken and the
 only one receiving your report would be me. 8-(
 
 -
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 
 


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]