Re: [C++] Help with windows build failure
Yeah, I can do that (or at least a close approximation to help the next person). Created ARROW-4745 [1] to track it. [1] https://issues.apache.org/jira/browse/ARROW-4745 On Sat, Mar 2, 2019 at 2:38 PM Wes McKinney wrote: > Would it be possible to round up this information and put it in the > wiki or under https://github.com/apache/arrow/tree/master/docs/source/cpp > somewhere for the next person who needs to debug the static CRT build > on Windows? I haven't had to do this personally yet and I can imagine > similarly losing a bunch of time to it =) > > On Fri, Mar 1, 2019 at 10:49 PM Micah Kornfield > wrote: > > > > Just to finish off this thread. Antoine's advice was spot on (need to > pass > > Debug and Static to b2). There was still another build issue with doube > > precision but I was able to bypass it my making the specific test that > was > > failing. > > > > > > > > On Tue, Feb 26, 2019 at 3:49 AM Antoine Pitrou > wrote: > > > > > > > > Le 26/02/2019 à 05:42, Micah Kornfield a écrit : > > > > The issue I'm blocked on is getting boost installed properly. I've > > > > included all of the steps I've run below, if anyone has some > thoughts or > > > > the magical script to build and install the appropriate boost > libraries > > > > appropriate for the Static_Crt_Build i would greatly appreciate it. > > > > > > > > With a Windows 10 MSVC 2017 VM: > > > > Download and install cmake and Anaconda3 via visual installers. > > > > Download Boost 1.67 and extract it. > > > > Run "Developer Command Prompt for MSVC 2017" from the start menu. > > > > 1. CD to the boost directory > > > > 2. Run: .\bootstrap.bat > > > > 3. Run: .\b2.exe > > > > 4. run: .\b2.exe install > > > > > > Does this also build the libraries in debug mode? > > > According to > > > > https://www.boost.org/doc/libs/1_69_0/more/getting_started/windows.html, > > > you can "choose a specific build variant by adding release or debug to > > > the command line". > > > > > > Regards > > > > > > Antoine. > > > >
Re: [C++] Help with windows build failure
Would it be possible to round up this information and put it in the wiki or under https://github.com/apache/arrow/tree/master/docs/source/cpp somewhere for the next person who needs to debug the static CRT build on Windows? I haven't had to do this personally yet and I can imagine similarly losing a bunch of time to it =) On Fri, Mar 1, 2019 at 10:49 PM Micah Kornfield wrote: > > Just to finish off this thread. Antoine's advice was spot on (need to pass > Debug and Static to b2). There was still another build issue with doube > precision but I was able to bypass it my making the specific test that was > failing. > > > > On Tue, Feb 26, 2019 at 3:49 AM Antoine Pitrou wrote: > > > > > Le 26/02/2019 à 05:42, Micah Kornfield a écrit : > > > The issue I'm blocked on is getting boost installed properly. I've > > > included all of the steps I've run below, if anyone has some thoughts or > > > the magical script to build and install the appropriate boost libraries > > > appropriate for the Static_Crt_Build i would greatly appreciate it. > > > > > > With a Windows 10 MSVC 2017 VM: > > > Download and install cmake and Anaconda3 via visual installers. > > > Download Boost 1.67 and extract it. > > > Run "Developer Command Prompt for MSVC 2017" from the start menu. > > > 1. CD to the boost directory > > > 2. Run: .\bootstrap.bat > > > 3. Run: .\b2.exe > > > 4. run: .\b2.exe install > > > > Does this also build the libraries in debug mode? > > According to > > https://www.boost.org/doc/libs/1_69_0/more/getting_started/windows.html, > > you can "choose a specific build variant by adding release or debug to > > the command line". > > > > Regards > > > > Antoine. > >
Re: [C++] Help with windows build failure
Just to finish off this thread. Antoine's advice was spot on (need to pass Debug and Static to b2). There was still another build issue with doube precision but I was able to bypass it my making the specific test that was failing. On Tue, Feb 26, 2019 at 3:49 AM Antoine Pitrou wrote: > > Le 26/02/2019 à 05:42, Micah Kornfield a écrit : > > The issue I'm blocked on is getting boost installed properly. I've > > included all of the steps I've run below, if anyone has some thoughts or > > the magical script to build and install the appropriate boost libraries > > appropriate for the Static_Crt_Build i would greatly appreciate it. > > > > With a Windows 10 MSVC 2017 VM: > > Download and install cmake and Anaconda3 via visual installers. > > Download Boost 1.67 and extract it. > > Run "Developer Command Prompt for MSVC 2017" from the start menu. > > 1. CD to the boost directory > > 2. Run: .\bootstrap.bat > > 3. Run: .\b2.exe > > 4. run: .\b2.exe install > > Does this also build the libraries in debug mode? > According to > https://www.boost.org/doc/libs/1_69_0/more/getting_started/windows.html, > you can "choose a specific build variant by adding release or debug to > the command line". > > Regards > > Antoine. >
Re: [C++] Help with windows build failure
Le 26/02/2019 à 05:42, Micah Kornfield a écrit : > The issue I'm blocked on is getting boost installed properly. I've > included all of the steps I've run below, if anyone has some thoughts or > the magical script to build and install the appropriate boost libraries > appropriate for the Static_Crt_Build i would greatly appreciate it. > > With a Windows 10 MSVC 2017 VM: > Download and install cmake and Anaconda3 via visual installers. > Download Boost 1.67 and extract it. > Run "Developer Command Prompt for MSVC 2017" from the start menu. > 1. CD to the boost directory > 2. Run: .\bootstrap.bat > 3. Run: .\b2.exe > 4. run: .\b2.exe install Does this also build the libraries in debug mode? According to https://www.boost.org/doc/libs/1_69_0/more/getting_started/windows.html, you can "choose a specific build variant by adding release or debug to the command line". Regards Antoine.
Re: [C++] Help with windows build failure
The issue I'm blocked on is getting boost installed properly. I've included all of the steps I've run below, if anyone has some thoughts or the magical script to build and install the appropriate boost libraries appropriate for the Static_Crt_Build i would greatly appreciate it. With a Windows 10 MSVC 2017 VM: Download and install cmake and Anaconda3 via visual installers. Download Boost 1.67 and extract it. Run "Developer Command Prompt for MSVC 2017" from the start menu. 1. CD to the boost directory 2. Run: .\bootstrap.bat 3. Run: .\b2.exe 4. run: .\b2.exe install 5. Activate anaconda nd Set environment variables: C:\Users\User\Anaconda3\Scripts\activate SET JOB=Static_Crt_Build SET GENERATOR=Ninja SET APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2017 SET USE_CLCACHE=false SET ARROW_BUILD_GANDIVA=OFF SET ARROW_LLVM_VERSION=7.0.* SET PYTHON=3.6 SET ARCH=64 SET ARROW_BUILD_TOOLCHAIN=%CONDA_PREFIX%\Library SET "PATH=C:\Users\User\Anaconda3;C:\Users\User\Anaconda3\Scripts;C:\Users\User\Anaconda3\Library\bin;%PATH%" 6. CD to arrow source code 7. Run .\ci\appveyor-install.bat 8. Set boost directories: SET BOOST_LIBRARYDIR=C:\Boost\lib SET BOOST_ROOT=C:\Boost 9. Run .\ci\appveyor-build.bat I get the following error message: CMake Error at C:/Program Files/CMake/share/cmake-3.13/Modules/FindBoost.cmake:2100 (message): Unable to find the requested Boost libraries. Boost version: 1.67.0 Boost include path: C:/Boost/include/boost-1_67 Could not find the following static Boost libraries: boost_regex boost_system boost_filesystem No Boost libraries were found. You may need to set BOOST_LIBRARYDIR to the directory containing Boost libraries or BOOST_ROOT to the location of Boost. Call Stack (most recent call first): cmake_modules/ThirdpartyToolchain.cmake:516 (find_package) CMakeLists.txt:506 (include) -- Boost include dir: C:/Boost/include/boost-1_67 -- Boost libraries: CMake Error at cmake_modules/BuildUtils.cmake:102 (message): No static or shared library provided for boost_system Call Stack (most recent call first): cmake_modules/ThirdpartyToolchain.cmake:537 (ADD_THIRDPARTY_LIB) CMakeLists.txt:506 (include) On Wed, Feb 20, 2019 at 6:42 AM Wes McKinney wrote: > There are both Debug and Release configurations here > > https://github.com/apache/arrow/blob/master/ci/appveyor-cpp-build.bat#L32 > > If you try those CMake commands in your VM, you do not reproduce the issue? > > On Wed, Feb 20, 2019 at 5:01 AM Micah Kornfield > wrote: > > > > I seem to recall at least one appveyor job passing (which seems to > > correspond with my ability to get a build on windows passing), but it is > > hard to tell because appveyor cancels all other jobs once one fails. > > > > On Wed, Feb 20, 2019 at 2:44 AM Antoine Pitrou > wrote: > > > > > > > > Hi Micah, > > > > > > Le 20/02/2019 à 11:30, Micah Kornfield a écrit : > > > > I've been working on a PR [1] that passes CI under linux/mac builds > (when > > > > the master build isn't broken). I've been able to run it locally > (linux > > > > VM), using both ASAN and Valgrind without issues. But I'm getting > > > > consistent errors (looks like a segfault) when building on windows on > > > under > > > > static_crt_build [2]. I can't seem to get that version of the build > > > > working on a Windows 10 VM with MSVC 2017 (it does pass when i > follow the > > > > normal windows build instructions with Ninja and CLcache [3]). > > > > > > > > I would appreciate help in any of the following ways (and other > > > suggestions > > > > welcome): > > > > 1. Give detailed instructions on how to replicate the > static_crt_build > > > > appveyor build in a VM (I use virtual box). > > > > 2. Take a look at the pull request to see if they can spot anything > I'm > > > > doing wrong. > > > > 3. Try to replicate this locally in there own Windows setup. > > > > 4. General advice on what might cause this type of disparity (or > suggest > > > > cmake flags on linux that might give s similar issue). > > > > > > Does this happen on other AppVeyor jobs or only the static CRT build? > > > > > > Regards > > > > > > Antoine. > > > >
Re: [C++] Help with windows build failure
There are both Debug and Release configurations here https://github.com/apache/arrow/blob/master/ci/appveyor-cpp-build.bat#L32 If you try those CMake commands in your VM, you do not reproduce the issue? On Wed, Feb 20, 2019 at 5:01 AM Micah Kornfield wrote: > > I seem to recall at least one appveyor job passing (which seems to > correspond with my ability to get a build on windows passing), but it is > hard to tell because appveyor cancels all other jobs once one fails. > > On Wed, Feb 20, 2019 at 2:44 AM Antoine Pitrou wrote: > > > > > Hi Micah, > > > > Le 20/02/2019 à 11:30, Micah Kornfield a écrit : > > > I've been working on a PR [1] that passes CI under linux/mac builds (when > > > the master build isn't broken). I've been able to run it locally (linux > > > VM), using both ASAN and Valgrind without issues. But I'm getting > > > consistent errors (looks like a segfault) when building on windows on > > under > > > static_crt_build [2]. I can't seem to get that version of the build > > > working on a Windows 10 VM with MSVC 2017 (it does pass when i follow the > > > normal windows build instructions with Ninja and CLcache [3]). > > > > > > I would appreciate help in any of the following ways (and other > > suggestions > > > welcome): > > > 1. Give detailed instructions on how to replicate the static_crt_build > > > appveyor build in a VM (I use virtual box). > > > 2. Take a look at the pull request to see if they can spot anything I'm > > > doing wrong. > > > 3. Try to replicate this locally in there own Windows setup. > > > 4. General advice on what might cause this type of disparity (or suggest > > > cmake flags on linux that might give s similar issue). > > > > Does this happen on other AppVeyor jobs or only the static CRT build? > > > > Regards > > > > Antoine. > >
Re: [C++] Help with windows build failure
I seem to recall at least one appveyor job passing (which seems to correspond with my ability to get a build on windows passing), but it is hard to tell because appveyor cancels all other jobs once one fails. On Wed, Feb 20, 2019 at 2:44 AM Antoine Pitrou wrote: > > Hi Micah, > > Le 20/02/2019 à 11:30, Micah Kornfield a écrit : > > I've been working on a PR [1] that passes CI under linux/mac builds (when > > the master build isn't broken). I've been able to run it locally (linux > > VM), using both ASAN and Valgrind without issues. But I'm getting > > consistent errors (looks like a segfault) when building on windows on > under > > static_crt_build [2]. I can't seem to get that version of the build > > working on a Windows 10 VM with MSVC 2017 (it does pass when i follow the > > normal windows build instructions with Ninja and CLcache [3]). > > > > I would appreciate help in any of the following ways (and other > suggestions > > welcome): > > 1. Give detailed instructions on how to replicate the static_crt_build > > appveyor build in a VM (I use virtual box). > > 2. Take a look at the pull request to see if they can spot anything I'm > > doing wrong. > > 3. Try to replicate this locally in there own Windows setup. > > 4. General advice on what might cause this type of disparity (or suggest > > cmake flags on linux that might give s similar issue). > > Does this happen on other AppVeyor jobs or only the static CRT build? > > Regards > > Antoine. >
Re: [C++] Help with windows build failure
Hi Micah, Le 20/02/2019 à 11:30, Micah Kornfield a écrit : > I've been working on a PR [1] that passes CI under linux/mac builds (when > the master build isn't broken). I've been able to run it locally (linux > VM), using both ASAN and Valgrind without issues. But I'm getting > consistent errors (looks like a segfault) when building on windows on under > static_crt_build [2]. I can't seem to get that version of the build > working on a Windows 10 VM with MSVC 2017 (it does pass when i follow the > normal windows build instructions with Ninja and CLcache [3]). > > I would appreciate help in any of the following ways (and other suggestions > welcome): > 1. Give detailed instructions on how to replicate the static_crt_build > appveyor build in a VM (I use virtual box). > 2. Take a look at the pull request to see if they can spot anything I'm > doing wrong. > 3. Try to replicate this locally in there own Windows setup. > 4. General advice on what might cause this type of disparity (or suggest > cmake flags on linux that might give s similar issue). Does this happen on other AppVeyor jobs or only the static CRT build? Regards Antoine.
