Re: [VOTE] Graduate Apache Atlas Project from Incubator

[Vimal Sharma]

nt, Apache Atlas" be and
>> hereby is created, the person holding such office to serve at the
>> direction of the Board of Directors as the chair of the Apache Atlas
>> Project, and to have primary responsibility for management of the projects
>> within the scope of responsibility of the Apache Atlas Project; and be it
>> Further.
>>
>>>RESOLVED,that the persons listed immediately below be and hereby are
>>>appointed to serve as the initial members of the Apache Atlas Project:
>>
>> Aaron Dossett adoss...@target.com <mailto:adoss...@target.com>
>> Andrew Ahn a...@apache.org <mailto:a...@apache.org>
>> Anil Varma ava...@slb.com <mailto:ava...@slb.com>
>> Arun C. Murthy acmur...@apache.org <mailto:acmur...@apache.org>
>> Apoorv Naik apoorvn...@apache.org <mailto:apoorvn...@apache.org>
>> Ayub Pathan ayubpat...@apache.org <mailto:ayubpat...@apache.org>
>> Barbara Stortz bsto...@sap.com <mailto:bsto...@sap.com>
>> Chris Hyzer chy...@aetna.com <mailto:chy...@aetna.com>
>> Daniel Markwat dmark...@aetna.com <mailto:dmark...@aetna.com>
>> Darshan Kumar darshanku...@apache.org <mailto:darshanku...@apache.org>
>> Dave Kantor dkan...@apache.org <mailto:dkan...@apache.org>
>> David Kaspar dkas...@merck.com <mailto:dkas...@merck.com>
>> Dennis Fusaro dfus...@aetna.com <mailto:dfus...@aetna.com>
>> Greg Senia gse...@aetna.com <mailto:gse...@aetna.com>
>> Harish Butani rhbut...@apache.org <mailto:rhbut...@apache.org>
>> Hemanth Yamijala yhema...@apache.org <mailto:yhema...@apache.org>
>> Ivo Lasek ila...@merck.com <mailto:ila...@merck.com>
>> James Vollmer ja...@target.com <mailto:ja...@target.com>
>> Jeffrey Hagelberg jnhagelb...@apache.org <mailto:jnhagelb...@apache.org>
>> Jitendra Pandey jiten...@apache.org <mailto:jiten...@apache.org>
>> Jon Maron jma...@apache.org <mailto:jma...@apache.org>
>> Kalyani Kalshikar kalyanikashi...@apache.org <mailto:kalyanikashikar@
>> apache.org>
>> Keval Bhatt kbhatt kbh...@apache.org <mailto:kbh...@apache.org>
>> Madhan Neethiraj mad...@apache.org <mailto:mad...@apache.org>
>> Mitch Schussler mschuss...@apache.org <mailto:mschuss...@apache.org>
>> Neeru Gupta guptane...@us.ibm.com <mailto:guptane...@us.ibm.com>
>> Nixon Rodrigues ni...@apache.org <mailto:ni...@apache.org>
>> Sarath Subramanian sar...@apache.org <mailto:sar...@apache.org>
>> Shwetha GS  shweth...@apache.org <mailto:shweth...@apache.org>
>> Srikanth Sundarrajan srik...@apache.org <mailto:srik...@apache.org>
>> Suma Shivaprasad suma...@apache.org <mailto:suma...@apache.org>
>> Suresh Srinivas ssur...@apache.org <mailto:ssur...@apache.org>
>> Tom Beerbower tbeerbo...@apache.org <mailto:tbeerbo...@apache.org>
>> Venkat Ranganathan vranganat...@apache.org <mailto:vranganat...@apache.org>
>> Venkatesh Seetharam venkat...@apache.org <mailto:venkat...@apache.org>
>> Vimal Sharma svimal2...@apache.org <mailto:svimal2...@apache.org>
>> Vinod Kumar Vavilapalli vino...@apache.org <mailto:vino...@apache.org>
>> Viswanath Avasarala vavasar...@slb.com <mailto:vavasar...@slb.com>
>>
>>
>> NOW, THEREFORE, BE IT FURTHER RESOLVED, that "Madhan Neethiraj" be
>> appointed to the office of Vice President, Apache Atlas, to serve in
>> accordance with and
>> subject to the direction of the Board of Directors and the Bylaws of the
>> Foundation until death, resignation, retirement, removal or
>> disqualification, or until a successor is appointed; and be it further
>> RESOLVED, that the initial Apache Atlas PMC be and hereby is tasked with
>> the creation of a set of bylaws intended to encourage open development and
>> increased participation in the Apache Atlas Project; and be it further
>>
>> RESOLVED, that the Apache Atlas Project be and hereby is tasked with the
>> migration of the Apache Incubator Atlas podling; and be it further
>>
>> RESOLVED, that all responsibilities pertaining to the Apache Incubator
>> Atlas polling encumbered upon the Apache Incubator Project are hereafter
>> discharged.
>>
>> Thanks
>> Suma
>>
>>
>

Re: [DISCUSS] Ready to graduate?

[Vimal Sharma]

+1 for graduation.

Atlas community has been a pleasure to work with and we have rapidly developed 
new features and improvements to the project.

Thanks
Vimal




On 4/27/17, 9:47 AM, "Hemanth Yamijala"  wrote:

>+1 from me as well.
>
>It has been a pleasure  being involved with Atlas and see the product and 
>community grow.
>
>Thanks, Chris, for starting this thread.
>
>Hemanth
>
>From: Jakob Homan 
>Sent: Thursday, April 27, 2017 4:27 AM
>To: dev@atlas.incubator.apache.org
>Subject: Re: [DISCUSS] Ready to graduate?
>
>+1.
>
>I've not been very involved with the day-to-day bits of the project as
>Mentor, so when the new PMC is constituted, there's no need to include
>me.  But I'll stay a fan of Atlas after graduation.
>
>-Jakob
>
>On 26 April 2017 at 15:29, Suma Shivaprasad
> wrote:
>> +1. Agreed
>>
>> The community is really vibrant/active with many companies involved in
>> shaping the roadmap and features.
>>  It has also grown a lot from past year with a lot of interest from users
>> and this is a great time to propose for graduation
>>
>> I volunteer to start working on the graduation and take this forward if no
>> one else has any objections.
>>
>> Thanks
>> Suma
>>
>>
>>
>>
>>
>> On Wed, Apr 26, 2017 at 2:03 AM, Nigel L Jones  wrote:
>>
>>>
>>>
>>> +1 from me.
>>>
>>> The Atlas community is vibrant, we have engagement from multiple companies,
>>> and the industry interest around governance is immense, as witnessed at
>>> recent conferences. It's exciting to see it evolve and getting it into a
>>> TLP will be another tick in the box as seen by potential users.
>>>
>>> Let's go for it!
>>>
>>> -Original Message-
>>> From: Mandy Chessell [mailto:mandy_chess...@uk.ibm.com]
>>> Sent: 26 April 2017 07:30
>>> To: dev@atlas.incubator.apache.org
>>> Subject: Re: [DISCUSS] Ready to graduate?
>>>
>>> Hello Chris,
>>> No concerns at all ... we have a vibrant, multi-company community that is
>>> working together to expand Atlas's capability to be THE open metadata and
>>> governance platform for data and analytics.  Many other
>>> people/organizations are eager to consume the results.   Moving the
>>> project out of incubation sends a strong message to our stakeholders and
>>> users that Atlas is here to stay and through that we can strengthen the
>>> community further.
>>>
>>> All the best
>>> Mandy
>>> ___
>>> Mandy Chessell CBE FREng CEng FBCS
>>> IBM Distinguished Engineer
>>>
>>> Master Inventor
>>> Member of the IBM Academy of Technology
>>> Visiting Professor, Department of Computer Science, University of Sheffield
>>>
>>> Email: mandy_chess...@uk.ibm.com
>>> LinkedIn: http://www.linkedin.com/pub/mandy-chessell/22/897/a49
>>>
>>> Assistant: Janet Brooks - jsbrook...@uk.ibm.com
>>>
>>>
>>>
>>> From:   Chris Douglas 
>>> To: dev@atlas.incubator.apache.org
>>> Date:   26/04/2017 01:45
>>> Subject:[DISCUSS] Ready to graduate?
>>>
>>>
>>>
>>> Hey Atlas folk-
>>>
>>> The name search JIRA is filled in [1] (thanks Madhan!), pending approval
>>> from VP trademarks. Independent of its resolution, does the community feel
>>> it is ready to graduate?
>>>
>>> As far as I've observed, the project is more than ready to be a top-level
>>> project. Are there any concerns we should discuss before we proceed?
>>>
>>> The process, roughly:
>>> 1. Community discussion of graduation
>>> 2. [VOTE] to graduate (PPMC votes binding) 3. Cite thread in
>>> general@incubator for discussion/vote (IPMC votes
>>> binding)
>>> 4. Add a resolution to the board agenda establishing Atlas as a top-level
>>> project 5. ASF board approves the resolution at its next meeting, Atlas
>>> becomes a TLP
>>>
>>> The project will also need to pick a chair for the new PMC. We can discuss
>>> that when we post the resolution. -C
>>>
>>> [1] https://issues.apache.org/jira/browse/PODLINGNAMESEARCH-118
>>>
>>>
>>> Unless stated otherwise above:
>>> IBM United Kingdom Limited - Registered in England and Wales with number
>>> 741598.
>>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>>>
>>>
>
>

Re: New PPMC member to Apache Atlas: Madhan Neethiraj

[Vimal Sharma]

Congrats Madhan!




On 3/17/17, 11:08 AM, "Sharmadha Sainath"  wrote:

>
>Congrats Madhan !! :)
>
>
>
>On 3/17/17, 11:07 AM, "Apoorv Naik"  wrote:
>
>>Congratulations Madhan!!!
>>
>>Sent from Nine
>>
>>From: Nixon Rodrigues 
>>Sent: Mar 16, 2017 10:07 PM
>>To: dev@atlas.incubator.apache.org
>>Subject: Re: New PPMC member to Apache Atlas: Madhan Neethiraj
>>
>>Congratulations Madhan!, Thanks for all your hard work and guidance to take
>>Atlas to new orbit.
>>
>>Best wishes,
>>Nixon
>>
>>
>>On Fri, Mar 17, 2017 at 9:27 AM, Hemanth Yamijala 
>>wrote:
>>
>>> Atlas dev community,
>>>
>>> Atlas PPMC has invited Madhan Neethiraj to join us as a PPMC member
>>> and we are glad that he has accepted.
>>>
>>> Congratulations, Madhan! Thanks for all your hard work on Atlas.
>>>
>>> Hemanth
>>>

Re: New committer to Apache Atlas: Apoorv Naik

[Vimal Sharma]

Congrats Apoorv!

-Vimal




On 3/17/17, 12:07 AM, "Ayub Khan Pathan"  wrote:

>Congratulations, Apoorv!
>
>On 3/16/17, 11:29 PM, "Suma Shivaprasad"  wrote:
>
>Congrats, Apoorv!
>
>On Wed, Mar 15, 2017 at 11:37 PM, Keval Bhatt 
>wrote:
>
>> Congratulation, Apoorv!
>>
>> On Wed, Mar 15, 2017 at 11:23 AM, Apoorv Naik 
>> wrote:
>>
>> > Thanks Hemanth. I’m very happy and proud to be a part of the Apache 
> Atlas
>> > community. Looking forward to grow and help the community.
>> >
>> >
>> >
>> >
>> > On 3/14/17, 9:47 PM, "Hemanth Yamijala"  wrote:
>> >
>> > >Atlas dev community,
>> > >
>> > >The Project Management Committee (PMC) for Apache Atlas
>> > >has invited Apoorv Naik to become a committer and we are pleased
>> > >to announce that he has accepted.
>> > >
>> > >Congratulations, Apoorv!
>> > >
>> > >thanks,
>> > >Hemanth
>> > >
>> >
>>
>>
>>
>> --
>>
>> *From:*
>>
>> *Keval P. Bhatt*
>>
>> *Mumbai*
>>
>
>

Re: [VOTE] Release Apache Atlas 0.8 (incubating) - release candidate 1 (dev group vote)

[Vimal Sharma]

+1(non binding) for the release

- Verified checksum and signature
- Build successful and all tests are passing (One IT in webapp failed but 
succeeded in rerun)
- Built with external Hbase and Solr
- Verified basic functionality using QuickStart


Thanks
Vimal




On 3/9/17, 11:53 AM, "Sarath Kumar Subramanian"  
wrote:

>   - Verified md5 checksum and signature.
>   - No binaries in source
>   - Build successful with embedded hbase-solr
>   - Verified Quickstart, lineage, tags and search
>   - Basic Sanity test
>
>+1 (non-binding) for the release.
>
>
>Thanks,
>Sarath Subramanian
>
>
>On Wed, Mar 8, 2017 at 9:10 PM, Ayub Khan Pathan 
>wrote:
>
>>   +1 (non-binding vote) for the release.
>>
>> - Verified “incubating” tag existence
>> - Verified for successful build
>> - Sanity tests are successful.
>>
>> Thanks
>> Ayub Khan
>>
>> On 3/8/17, 1:30 PM, "Madhan Neethiraj"  wrote:
>>
>> Atlas team,
>>
>>
>>
>> Apache Atlas 0.8 (incubating) release candidate #1 is now available
>> for a vote within dev community. Links to the release artifacts are given
>> below. Can you please review and vote?
>>
>>
>>
>> This update includes fix for the following JIRAS: ATLAS-1648,
>> ATLAS-1655, ATLAS-1656, ATLAS-1657, ATLAS-1658
>>
>>
>>
>> The vote will be open for at least 72 hours or until necessary votes
>> are reached.
>>
>> [ ] +1  approve
>>
>> [ ] +0  no opinion
>>
>> [ ] -1  disapprove (and reason why)
>>
>>
>>
>> Here is my +1
>>
>>
>>
>> Thanks,
>>
>> Madhan
>>
>>
>>
>>
>>
>> List of improvements and issues addressed in this release:
>> https://issues.apache.org/jira/issues/?jql=project%20%
>> 3D%20Atlas%20AND%20status%20%3D%20Resolved%20AND%
>> 20resolution%20%3D%20Fixed%20AND%20fixVersion%20%3D%200.
>> 8-incubating%20ORDER%20BY%20key%20DESC
>>
>>
>>
>> Git tag for the release: https://github.com/apache/
>> incubator-atlas/tree/release-0.8-rc1
>>
>>
>>
>> Sources for the release: https://dist.apache.org/repos/
>> dist/dev/incubator/atlas/0.8-incubating-rc1/apache-atlas-0.
>> 8-incubating-sources.tar.gz
>>
>>
>>
>> Source release verification:
>>
>>   PGP Signature:  https://dist.apache.org/repos/
>> dist/dev/incubator/atlas/0.8-incubating-rc1/apache-atlas-0.
>> 8-incubating-sources.tar.gz.asc
>>
>>   MD5 Hash:   https://dist.apache.org/repos/
>> dist/dev/incubator/atlas/0.8-incubating-rc1/apache-atlas-0.
>> 8-incubating-sources.tar.gz.md5
>>
>>
>>
>> Keys to verify the signature of the release artifacts are available
>> at: https://dist.apache.org/repos/dist/dev/incubator/atlas/KEYS
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>

[jira] [Commented] (ATLAS-1612) Regression: DSL search using a non-unique attribute of user-defined types results in empty response

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897026#comment-15897026
 ] 

Vimal Sharma commented on ATLAS-1612:
-

[~ayubkhan]
The issue is that the DSL query is not correct. The correct DSL query should be 
"sample where name = \"simple_column\"" and not
"sample where name = \"sample_column\"". The first query produces the expected 
results.

Please verify with the correct query. Marking the issue as resolved

> Regression: DSL search using a non-unique attribute of user-defined types 
> results in empty response
> ---
>
> Key: ATLAS-1612
> URL: https://issues.apache.org/jira/browse/ATLAS-1612
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 0.8-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
>
> Steps to repro:
> 1. Create a user defined type like below
> {noformat}
> {
> "enumTypes":[
>   ],
>   "structTypes":[
>   ],
>   "traitTypes":[
>   ],
>   "classTypes":[
> {
>   "superTypes":[
>   ],
>   
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
>   "typeName":"sample",
>   "typeDescription":null,
>   "typeVersion":"1.0",
>   "attributeDefinitions":[
> {
>   "name":"name",
>   "dataTypeName":"string",
>   "multiplicity":"required",
>   "isComposite":false,
>   "isUnique":false,
>   "isIndexable":false,
>   "reverseAttributeName":null
> }
>   ]
> }
>   ]
> }
> {noformat}
> 2. create an entity of above type
> {noformat}
>   {
> 
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id":{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
>   "id":"-16993187400044476",
>   "version":0,
>   "typeName":"sample",
>   "state":"ACTIVE"
> },
> "typeName":"sample",
> "values":{
>   "name":"simple_column"
> },
> "traitNames":[
> ],
> "traits":{
> },
> "systemAttributes":{
>   "createdBy":null,
>   "modifiedBy":null,
>   "createdTime":null,
>   "modifiedTime":null
> }
>   }
> {noformat}
> 3. Now perform a dsl search using below query - "query": "sample where name = 
> \"sample_column\"",



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ATLAS-1612) Regression: DSL search using a non-unique attribute of user-defined types results in empty response

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1612.
-
Resolution: Fixed

> Regression: DSL search using a non-unique attribute of user-defined types 
> results in empty response
> ---
>
> Key: ATLAS-1612
> URL: https://issues.apache.org/jira/browse/ATLAS-1612
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 0.8-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
>
> Steps to repro:
> 1. Create a user defined type like below
> {noformat}
> {
> "enumTypes":[
>   ],
>   "structTypes":[
>   ],
>   "traitTypes":[
>   ],
>   "classTypes":[
> {
>   "superTypes":[
>   ],
>   
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
>   "typeName":"sample",
>   "typeDescription":null,
>   "typeVersion":"1.0",
>   "attributeDefinitions":[
> {
>   "name":"name",
>   "dataTypeName":"string",
>   "multiplicity":"required",
>   "isComposite":false,
>   "isUnique":false,
>   "isIndexable":false,
>   "reverseAttributeName":null
> }
>   ]
> }
>   ]
> }
> {noformat}
> 2. create an entity of above type
> {noformat}
>   {
> 
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id":{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
>   "id":"-16993187400044476",
>   "version":0,
>   "typeName":"sample",
>   "state":"ACTIVE"
> },
> "typeName":"sample",
> "values":{
>   "name":"simple_column"
> },
> "traitNames":[
> ],
> "traits":{
> },
> "systemAttributes":{
>   "createdBy":null,
>   "modifiedBy":null,
>   "createdTime":null,
>   "modifiedTime":null
> }
>   }
> {noformat}
> 3. Now perform a dsl search using below query - "query": "sample where name = 
> \"sample_column\"",



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ATLAS-1612) Regression: DSL search using a non-unique attribute of user-defined types results in empty response

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma reassigned ATLAS-1612:
---

Assignee: Vimal Sharma

> Regression: DSL search using a non-unique attribute of user-defined types 
> results in empty response
> ---
>
> Key: ATLAS-1612
> URL: https://issues.apache.org/jira/browse/ATLAS-1612
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 0.8-incubating
>Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
>
> Steps to repro:
> 1. Create a user defined type like below
> {noformat}
> {
> "enumTypes":[
>   ],
>   "structTypes":[
>   ],
>   "traitTypes":[
>   ],
>   "classTypes":[
> {
>   "superTypes":[
>   ],
>   
> "hierarchicalMetaTypeName":"org.apache.atlas.typesystem.types.ClassType",
>   "typeName":"sample",
>   "typeDescription":null,
>   "typeVersion":"1.0",
>   "attributeDefinitions":[
> {
>   "name":"name",
>   "dataTypeName":"string",
>   "multiplicity":"required",
>   "isComposite":false,
>   "isUnique":false,
>   "isIndexable":false,
>   "reverseAttributeName":null
> }
>   ]
> }
>   ]
> }
> {noformat}
> 2. create an entity of above type
> {noformat}
>   {
> 
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Reference",
> "id":{
>   
> "jsonClass":"org.apache.atlas.typesystem.json.InstanceSerialization$_Id",
>   "id":"-16993187400044476",
>   "version":0,
>   "typeName":"sample",
>   "state":"ACTIVE"
> },
> "typeName":"sample",
> "values":{
>   "name":"simple_column"
> },
> "traitNames":[
> ],
> "traits":{
> },
> "systemAttributes":{
>   "createdBy":null,
>   "modifiedBy":null,
>   "createdTime":null,
>   "modifiedTime":null
> }
>   }
> {noformat}
> 3. Now perform a dsl search using below query - "query": "sample where name = 
> \"sample_column\"",



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57187: ATLAS-1603: fix to handle null value for object_id type attributes

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57187/#review167242
---


Ship it!




Ship It!

- Vimal Sharma


On March 1, 2017, 9:22 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57187/
> ---
> 
> (Updated March 1, 2017, 9:22 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1603
> https://issues.apache.org/jira/browse/ATLAS-1603
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Updated EntityGraphMapper to handle null value for object_id type attributes
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  e6a7f41 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  94d313f 
> 
> 
> Diff: https://reviews.apache.org/r/57187/diff/2/
> 
> 
> Testing
> ---
> 
> - added unit test to validate the fix
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 57103: Implementation for classification in V2 API

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57103/#review167035
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 (line 847)
<https://reviews.apache.org/r/57103/#comment239172>

Can result of traitNames be put into a HashMap instead so that we can avoid 
the expensive membership check operation in validateClassificationExists


- Vimal Sharma


On Feb. 28, 2017, 7:01 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57103/
> ---
> 
> (Updated Feb. 28, 2017, 7:01 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1601
> https://issues.apache.org/jira/browse/ATLAS-1601
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add support for classification store, REST API for addition, deletion and gets
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java d58c514 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  621b32f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  6c372b3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  c84f169 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  09f69db 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  3ba2190 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityMutationContext.java
>  23e825e 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> d7adb3a 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java d1bef78 
> 
> Diff: https://reviews.apache.org/r/57103/diff/
> 
> 
> Testing
> ---
> 
> Tested through TestEntityREST
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

[jira] [Updated] (ATLAS-1572) sqoop metadata ingest fails with "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; found org.apache.atlas.typesystem.Referenceable"

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1572:

Attachment: ATLAS-1572.1.patch

Updating the patch to handle the issue on the server side. When an Object is 
supplied to V1 to V2 Array converter, it handles the case where the given 
Object is not a Collection. 

> sqoop metadata ingest fails with 
> "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; 
> found org.apache.atlas.typesystem.Referenceable"
> 
>
> Key: ATLAS-1572
> URL: https://issues.apache.org/jira/browse/ATLAS-1572
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8-incubating
>    Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
> Attachments: ATLAS-1572.1.patch, ATLAS-1572.patch
>
>
> Sqoop import succeeds but the metadata ingest fails with below error
> {noformat}
> 2017-02-20 11:20:43,179 WARN  - [NotificationHookConsumer thread-0:] ~ Max 
> retries exceeded for message [{Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, description=, 
> source=createSqoopTablejmnwwf8rji, storeUse=TABLE}}, {Id='(type: hive_db, id: 
> )', traits=[], values={name=default, qualifiedName=default@cl1, 
> clusterName=cl1}}, {Id='(type: hive_table, id: )', traits=[], 
> values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, {Id='(type: sqoop_process, 
> id: )', traits=[], values={outputs={Id='(type: hive_table, id: 
> )', traits=[], values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, 
> commandlineOpts={db.clear.staging.table=false, hive.import=true, 
> db.require.password=true, codegen.output.delimiters.enclose=0, 
> codegen.input.delimiters.field=0, customtool.options.jsonmap={}, 
> hive.compute.stats.table=false, 
> db.connect.string=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  incremental.mode=None, db.table=createSqoopTablejmnwwf8rji, verbose=false, 
> codegen.output.delimiters.enclose.required=false, mapreduce.num.mappers=4, 
> hdfs.append.dir=false, direct.import=false, hive.drop.delims=false, 
> hive.overwrite.table=false, hbase.bulk.load.enabled=false, 
> hive.fail.table.exists=false, relaxed.isolation=false, 
> hdfs.delete-target.dir=false, split.limit=null, db.username=sqoop, 
> codegen.input.delimiters.enclose.required=false, codegen.output.dir=., 
> import.direct.split.size=0, reset.onemapper=false, 
> codegen.output.delimiters.record=10, temporary.dirRoot=_sqoop, 
> hcatalog.create.table=false, db.batch=false, import.fetch.size=-2147483648, 
> accumulo.max.latency=5000, hdfs.file.format=TextFile, 
> codegen.output.delimiters.field=1, mainframe.input.dataset.type=p, 
> codegen.output.delimiters.escape=0, hcatalog.drop.and.create.table=false, 
> import.max.inline.lob.size=16777216, hbase.create.table=false, 
> codegen.auto.compile.dir=true, 
> codegen.compile.dir=/tmp/sqoop-hrt_qa/compile/f7c5181710812973a20a3e4776c5a6ef,
>  codegen.input.delimiters.enclose=0, export.new.update=UpdateOnly, 
> enable.compression=false, skip.dist.cache=false, 
> accumulo.batch.size=1024, hdfs.warehouse.dir=/user/hrt_qa, 
> codegen.input.delimiters.record=0, codegen.input.delimiters.escape=0, 
> accumulo.create.table=false}, inputs={Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualified

[jira] [Updated] (ATLAS-1599) Unit test failure in AuditRepositoryTestBase

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1599:

Attachment: ATLAS-1599.patch

> Unit test failure in AuditRepositoryTestBase
> 
>
> Key: ATLAS-1599
> URL: https://issues.apache.org/jira/browse/ATLAS-1599
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1599.patch
>
>
> Unit tests in AuditRepositoryTestBase are failing. The reason being that 
> although variable of interface EntityAuditRepository is declared but it is 
> not initialized. This results in NullPointerException in all the UTs in this 
> file



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ATLAS-1599) Unit test failure in AuditRepositoryTestBase

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1599:
---

 Summary: Unit test failure in AuditRepositoryTestBase
 Key: ATLAS-1599
 URL: https://issues.apache.org/jira/browse/ATLAS-1599
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma


Unit tests in AuditRepositoryTestBase are failing. The reason being that 
although variable of interface EntityAuditRepository is declared but it is not 
initialized. This results in NullPointerException in all the UTs in this file



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ATLAS-1572) sqoop metadata ingest fails with "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; found org.apache.atlas.typesystem.Referenceable"

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885396#comment-15885396
 ] 

Vimal Sharma commented on ATLAS-1572:
-

Function deserializeClassInstances in GraphHelper.java is the culprit. Added a 
couple of LOG statements to debug the issue:
{code}
LOG.info("Deserialized JSON {}", entityInstance.toString());
ITypedReferenceableInstance typedInstrance = 
getTypedReferenceableInstance(typeSystem, entityInstance);
LOG.info("ITypedReferenceable instance {}", 
((ReferenceableInstance)typedInstrance).toString());
{code}


Got the below logs
{code}
2017-02-27 08:24:11,731 INFO  - [NotificationHookConsumer thread-0:] ~ 
Deserialized JSON {Id='(type: sqoop_process, id: )', traits=[], 
values={outputs={Id='(type: hive_table, id: )', traits=[], 
values={name=sqoopregression, 
qualifiedName=default.sqoopregression@Sqoop_Regression, db={Id='(type: hive_db, 
id: )', traits=[], values={name=default, 
qualifiedName=default@Sqoop_Regression, clusterName=Sqoop_Regression, 
commandlineOpts={db.clear.staging.table=false, hive.import=true, 
db.require.password=true, codegen.output.delimiters.enclose=0, 
codegen.input.delimiters.field=0, customtool.options.jsonmap={}, 
hive.compute.stats.table=false, 
db.connect.string=jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest, 
incremental.mode=None, db.table=sqoopRegression, verbose=false, 
codegen.output.delimiters.enclose.required=false, mapreduce.num.mappers=1, 
hdfs.append.dir=false, direct.import=false, hive.drop.delims=false, 
hive.overwrite.table=false, hbase.bulk.load.enabled=false, 
hive.fail.table.exists=false, relaxed.isolation=false, 
hdfs.delete-target.dir=false, jdbc.driver.class=com.mysql.jdbc.Driver, 
split.limit=null, db.username=sqoop, 
codegen.input.delimiters.enclose.required=false, codegen.output.dir=., 
import.direct.split.size=0, reset.onemapper=false, 
codegen.output.delimiters.record=10, temporary.dirRoot=_sqoop, 
hcatalog.create.table=false, db.batch=false, import.fetch.size=1000, 
accumulo.max.latency=5000, hdfs.file.format=TextFile, 
codegen.output.delimiters.field=1, mainframe.input.dataset.type=p, 
codegen.output.delimiters.escape=0, hcatalog.drop.and.create.table=false, 
import.max.inline.lob.size=16777216, hbase.create.table=false, 
codegen.auto.compile.dir=true, 
codegen.compile.dir=/tmp/sqoop-hdfs/compile/ad793204f04ae1977f4abd2fc0715113, 
codegen.input.delimiters.enclose=0, export.new.update=UpdateOnly, 
enable.compression=false, skip.dist.cache=false, accumulo.batch.size=1024, 
hdfs.warehouse.dir=/apps/hive/warehouse/, codegen.input.delimiters.record=0, 
codegen.input.delimiters.escape=0, accumulo.create.table=false}, 
inputs={Id='(type: sqoop_dbdatastore, id: )', traits=[], 
values={owner=hdfs, 
storeUri=jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest, 
dbStoreType=mysql, qualifiedName=mysql --url 
jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest --table 
sqoopRegression, name=mysql --url 
jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest --table 
sqoopRegression, description=, source=sqoopRegression, storeUse=TABLE}}, 
qualifiedName=sqoop import --connect 
jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest --table 
sqoopRegression --hive-import --hive-database default --hive-table 
sqoopregression --hive-cluster Sqoop_Regression, name=sqoop import --connect 
jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest --table 
sqoopRegression --hive-import --hive-database default --hive-table 
sqoopregression --hive-cluster Sqoop_Regression, 
startTime=2017-02-27T08:23:23.538Z, endTime=2017-02-27T08:24:07.007Z, 
userName=hdfs, operation=import}} (GraphHelper:948)

2017-02-27 08:24:12,086 INFO  - [NotificationHookConsumer thread-0:] ~ 
ITypedReferenceable instance {
id : (type: sqoop_process, id: )
operation : import
commandlineOpts :   {accumulo.batch.size=1024, 
accumulo.create.table=false, accumulo.max.latency=5000, 
codegen.auto.compile.dir=true, 
codegen.compile.dir=/tmp/sqoop-hdfs/compile/ad793204f04ae1977f4abd2fc0715113, 
codegen.input.delimiters.enclose=0, 
codegen.input.delimiters.enclose.required=false, 
codegen.input.delimiters.escape=0, codegen.input.delimiters.field=0, 
codegen.input.delimiters.record=0, codegen.output.delimiters.enclose=0, 
codegen.output.delimiters.enclose.required=false, 
codegen.output.delimiters.escape=0, codegen.output.delimiters.field=1, 
codegen.output.delimiters.record=10, codegen.output.dir=., 
customtool.options.jsonmap={}, db.batch=false, db.clear.staging.table=false, 
db.connect.string=jdbc:mysql://sqoop-regression-1.openstacklocal/sqoopTest, 
db.require.password=true, db.table=sqoopRegression, db.username=sqoop, 
direct.import=false, enable.compression=false, export.new.update=Upda

Re: Review Request 56910: Fix issues with owned map reference and add tests

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/#review166346
---


Ship it!




- Vimal Sharma


On Feb. 22, 2017, 2:09 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56910/
> ---
> 
> (Updated Feb. 22, 2017, 2:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1584
> https://issues.apache.org/jira/browse/ATLAS-1584
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixed map model validation and added tests for map
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  555f0ac 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  845bbb4 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java
>  fd685c6 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java
>  eba9c77 
> 
> Diff: https://reviews.apache.org/r/56910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Review Request 56910: Fix issues with owned map reference and add tests

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/#review166342
---




repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
 (line 814)
<https://reviews.apache.org/r/56910/#comment238286>

Can we add an assertion here to check whether the mapValueGuid(using 
mapOwner attributes) is equal to guid in vertex obtained in line 813


- Vimal Sharma


On Feb. 22, 2017, 2:09 a.m., Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56910/
> ---
> 
> (Updated Feb. 22, 2017, 2:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1584
> https://issues.apache.org/jira/browse/ATLAS-1584
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fixed map model validation and added tests for map
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  555f0ac 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  845bbb4 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java
>  fd685c6 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java
>  eba9c77 
> 
> Diff: https://reviews.apache.org/r/56910/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

[jira] [Commented] (ATLAS-1572) sqoop metadata ingest fails with "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; found org.apache.atlas.typesystem.Referenceable"

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877525#comment-15877525
 ] 

Vimal Sharma commented on ATLAS-1572:
-

[~madhan.neethiraj] The issue will be there only for the builds after the patch 
for Hook notification rewiring https://issues.apache.org/jira/browse/ATLAS-1499.

It seems like the earlier Atlas server used to accept single value even though 
the attribute was marked as list/set. I suspect that proper validation was not 
present in the InstanceSerialization code where we convert Referenceable 
objects to JSON string.

> sqoop metadata ingest fails with 
> "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; 
> found org.apache.atlas.typesystem.Referenceable"
> 
>
> Key: ATLAS-1572
> URL: https://issues.apache.org/jira/browse/ATLAS-1572
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8-incubating
>    Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
> Attachments: ATLAS-1572.patch
>
>
> Sqoop import succeeds but the metadata ingest fails with below error
> {noformat}
> 2017-02-20 11:20:43,179 WARN  - [NotificationHookConsumer thread-0:] ~ Max 
> retries exceeded for message [{Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, description=, 
> source=createSqoopTablejmnwwf8rji, storeUse=TABLE}}, {Id='(type: hive_db, id: 
> )', traits=[], values={name=default, qualifiedName=default@cl1, 
> clusterName=cl1}}, {Id='(type: hive_table, id: )', traits=[], 
> values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, {Id='(type: sqoop_process, 
> id: )', traits=[], values={outputs={Id='(type: hive_table, id: 
> )', traits=[], values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, 
> commandlineOpts={db.clear.staging.table=false, hive.import=true, 
> db.require.password=true, codegen.output.delimiters.enclose=0, 
> codegen.input.delimiters.field=0, customtool.options.jsonmap={}, 
> hive.compute.stats.table=false, 
> db.connect.string=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  incremental.mode=None, db.table=createSqoopTablejmnwwf8rji, verbose=false, 
> codegen.output.delimiters.enclose.required=false, mapreduce.num.mappers=4, 
> hdfs.append.dir=false, direct.import=false, hive.drop.delims=false, 
> hive.overwrite.table=false, hbase.bulk.load.enabled=false, 
> hive.fail.table.exists=false, relaxed.isolation=false, 
> hdfs.delete-target.dir=false, split.limit=null, db.username=sqoop, 
> codegen.input.delimiters.enclose.required=false, codegen.output.dir=., 
> import.direct.split.size=0, reset.onemapper=false, 
> codegen.output.delimiters.record=10, temporary.dirRoot=_sqoop, 
> hcatalog.create.table=false, db.batch=false, import.fetch.size=-2147483648, 
> accumulo.max.latency=5000, hdfs.file.format=TextFile, 
> codegen.output.delimiters.field=1, mainframe.input.dataset.type=p, 
> codegen.output.delimiters.escape=0, hcatalog.drop.and.create.table=false, 
> import.max.inline.lob.size=16777216, hbase.create.table=false, 
> codegen.auto.compile.dir=true, 
> codegen.compile.dir=/tmp/sqoop-hrt_qa/compile/f7c5181710812973a20a3e4776c5a6ef,
>  codegen.input.delimiters.enclose=0, export.new.update=UpdateOnly, 
> enable.compression=false, skip.dist.cache=false, 
> accumulo.batch.size=1024, hdfs.warehouse.dir=/user/hrt_qa, 
> codegen.input.delimiters.record=0, codegen.input.delimiters.escape=0, 
> accumulo.create.table=false}, inputs={I

[jira] [Updated] (ATLAS-1572) sqoop metadata ingest fails with "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; found org.apache.atlas.typesystem.Referenceable"

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1572:

Attachment: ATLAS-1572.patch

Attaching the patch. Sqoop IT tests are passing

> sqoop metadata ingest fails with 
> "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; 
> found org.apache.atlas.typesystem.Referenceable"
> 
>
> Key: ATLAS-1572
> URL: https://issues.apache.org/jira/browse/ATLAS-1572
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8-incubating
>Reporter: Ayub Khan
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
> Attachments: ATLAS-1572.patch
>
>
> Sqoop import succeeds but the metadata ingest fails with below error
> {noformat}
> 2017-02-20 11:20:43,179 WARN  - [NotificationHookConsumer thread-0:] ~ Max 
> retries exceeded for message [{Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, description=, 
> source=createSqoopTablejmnwwf8rji, storeUse=TABLE}}, {Id='(type: hive_db, id: 
> )', traits=[], values={name=default, qualifiedName=default@cl1, 
> clusterName=cl1}}, {Id='(type: hive_table, id: )', traits=[], 
> values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, {Id='(type: sqoop_process, 
> id: )', traits=[], values={outputs={Id='(type: hive_table, id: 
> )', traits=[], values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, 
> commandlineOpts={db.clear.staging.table=false, hive.import=true, 
> db.require.password=true, codegen.output.delimiters.enclose=0, 
> codegen.input.delimiters.field=0, customtool.options.jsonmap={}, 
> hive.compute.stats.table=false, 
> db.connect.string=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  incremental.mode=None, db.table=createSqoopTablejmnwwf8rji, verbose=false, 
> codegen.output.delimiters.enclose.required=false, mapreduce.num.mappers=4, 
> hdfs.append.dir=false, direct.import=false, hive.drop.delims=false, 
> hive.overwrite.table=false, hbase.bulk.load.enabled=false, 
> hive.fail.table.exists=false, relaxed.isolation=false, 
> hdfs.delete-target.dir=false, split.limit=null, db.username=sqoop, 
> codegen.input.delimiters.enclose.required=false, codegen.output.dir=., 
> import.direct.split.size=0, reset.onemapper=false, 
> codegen.output.delimiters.record=10, temporary.dirRoot=_sqoop, 
> hcatalog.create.table=false, db.batch=false, import.fetch.size=-2147483648, 
> accumulo.max.latency=5000, hdfs.file.format=TextFile, 
> codegen.output.delimiters.field=1, mainframe.input.dataset.type=p, 
> codegen.output.delimiters.escape=0, hcatalog.drop.and.create.table=false, 
> import.max.inline.lob.size=16777216, hbase.create.table=false, 
> codegen.auto.compile.dir=true, 
> codegen.compile.dir=/tmp/sqoop-hrt_qa/compile/f7c5181710812973a20a3e4776c5a6ef,
>  codegen.input.delimiters.enclose=0, export.new.update=UpdateOnly, 
> enable.compression=false, skip.dist.cache=false, 
> accumulo.batch.size=1024, hdfs.warehouse.dir=/user/hrt_qa, 
> codegen.input.delimiters.record=0, codegen.input.delimiters.escape=0, 
> accumulo.create.table=false}, inputs={Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> j

[jira] [Assigned] (ATLAS-1572) sqoop metadata ingest fails with "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; found org.apache.atlas.typesystem.Referenceable"

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma reassigned ATLAS-1572:
---

Assignee: Vimal Sharma

> sqoop metadata ingest fails with 
> "org.apache.atlas.exception.AtlasBaseException: expected type List or Set; 
> found org.apache.atlas.typesystem.Referenceable"
> 
>
> Key: ATLAS-1572
> URL: https://issues.apache.org/jira/browse/ATLAS-1572
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 0.8-incubating
>    Reporter: Ayub Khan
>Assignee: Vimal Sharma
>Priority: Blocker
> Fix For: trunk, 0.8-incubating
>
> Attachments: ATLAS-1572.patch
>
>
> Sqoop import succeeds but the metadata ingest fails with below error
> {noformat}
> 2017-02-20 11:20:43,179 WARN  - [NotificationHookConsumer thread-0:] ~ Max 
> retries exceeded for message [{Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, description=, 
> source=createSqoopTablejmnwwf8rji, storeUse=TABLE}}, {Id='(type: hive_db, id: 
> )', traits=[], values={name=default, qualifiedName=default@cl1, 
> clusterName=cl1}}, {Id='(type: hive_table, id: )', traits=[], 
> values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, {Id='(type: sqoop_process, 
> id: )', traits=[], values={outputs={Id='(type: hive_table, id: 
> )', traits=[], values={name=createsqooptablejmnwwf8rji, 
> qualifiedName=default.createsqooptablejmnwwf8rji@cl1, db={Id='(type: hive_db, 
> id: )', traits=[], values={name=default, 
> qualifiedName=default@cl1, clusterName=cl1, 
> commandlineOpts={db.clear.staging.table=false, hive.import=true, 
> db.require.password=true, codegen.output.delimiters.enclose=0, 
> codegen.input.delimiters.field=0, customtool.options.jsonmap={}, 
> hive.compute.stats.table=false, 
> db.connect.string=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  incremental.mode=None, db.table=createSqoopTablejmnwwf8rji, verbose=false, 
> codegen.output.delimiters.enclose.required=false, mapreduce.num.mappers=4, 
> hdfs.append.dir=false, direct.import=false, hive.drop.delims=false, 
> hive.overwrite.table=false, hbase.bulk.load.enabled=false, 
> hive.fail.table.exists=false, relaxed.isolation=false, 
> hdfs.delete-target.dir=false, split.limit=null, db.username=sqoop, 
> codegen.input.delimiters.enclose.required=false, codegen.output.dir=., 
> import.direct.split.size=0, reset.onemapper=false, 
> codegen.output.delimiters.record=10, temporary.dirRoot=_sqoop, 
> hcatalog.create.table=false, db.batch=false, import.fetch.size=-2147483648, 
> accumulo.max.latency=5000, hdfs.file.format=TextFile, 
> codegen.output.delimiters.field=1, mainframe.input.dataset.type=p, 
> codegen.output.delimiters.escape=0, hcatalog.drop.and.create.table=false, 
> import.max.inline.lob.size=16777216, hbase.create.table=false, 
> codegen.auto.compile.dir=true, 
> codegen.compile.dir=/tmp/sqoop-hrt_qa/compile/f7c5181710812973a20a3e4776c5a6ef,
>  codegen.input.delimiters.enclose=0, export.new.update=UpdateOnly, 
> enable.compression=false, skip.dist.cache=false, 
> accumulo.batch.size=1024, hdfs.warehouse.dir=/user/hrt_qa, 
> codegen.input.delimiters.record=0, codegen.input.delimiters.escape=0, 
> accumulo.create.table=false}, inputs={Id='(type: sqoop_dbdatastore, id: 
> )', traits=[], values={owner=hrt_qa, 
> storeUri=jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull,
>  dbStoreType=mysql, qualifiedName=mysql --url 
> jdbc:mysql://ctr-e129-1487033772569-11862-01-02.hwx.site/sqoopTests?zeroDateTimeBehavior=convertToNull
>  --table createSqoopTablejmnwwf8rji, name=mysql --url 
> jdbc:my

Re: Review Request 56818: ATLAS-1569: updates to clear contents of RequestContextV2 at the end of a request

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56818/#review166037
---




webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
 (line 259)
<https://reviews.apache.org/r/56818/#comment237944>

Does it make sense to record audit only after the entity 
creation/updation/deletion was successful


- Vimal Sharma


On Feb. 19, 2017, 7:09 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56818/
> ---
> 
> (Updated Feb. 19, 2017, 7:09 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1569
> https://issues.apache.org/jira/browse/ATLAS-1569
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - cleared the contents of RequestContextV2 at the end of each servlet request 
> and notification processing
> - updated notification processing to generate audit log only on the first 
> attempt (and not during retries)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasEntitiesClientV2.java 9ad9c16 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  c16fd66 
>   webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 030788a 
> 
> Diff: https://reviews.apache.org/r/56818/diff/
> 
> 
> Testing
> ---
> 
> Verified that the unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56815: ATLAS-1568: moved helper methods from org.apache.atlas.model package classes into an utility class

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56815/#review166036
---


Fix it, then Ship it!





repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
 (line 243)
<https://reviews.apache.org/r/56815/#comment237943>

Since this is printing to STDOUT, consider removing it


- Vimal Sharma


On Feb. 18, 2017, 7:46 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56815/
> ---
> 
> (Updated Feb. 18, 2017, 7:46 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1568
> https://issues.apache.org/jira/browse/ATLAS-1568
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Moved the following methods to AtlasTypeUtil class:
> - AtlasEntity.getObjectId()
> - AtlasEntityHeader.getObjectId()
> - AtlasObjectId.isValidGuid(guid)
> - AtlasObjectId.isAssignedGuid(guid)
> - AtlasObjectId.isUnassignedGuid(guid)
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/CreateUpdateEntitiesResult.java 
> a1aef61 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java e74813a 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java 
> 94b3aa6 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 
> dea3a93 
>   intg/src/main/java/org/apache/atlas/model/instance/GuidMapping.java 43ce3b0 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 626f18e 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 0a82f40 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 6d85672 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityGraphDiscoveryV1.java
>  436de49 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  8a6501c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  8c96c7b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  527ce15 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/IDBasedEntityResolver.java
>  e773f02 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  1ac9bd1 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java
>  c55e3f7 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  7f76236 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 26bf496 
>   webapp/src/main/java/org/apache/atlas/web/resources/EntityResource.java 
> b90627f 
>   webapp/src/main/java/org/apache/atlas/web/resources/ExportService.java 
> 04bb4d3 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 2d48770 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 1df9d2f 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java 
> 5e57518 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityJerseyResourceIT.java
>  96e6f9b 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/EntityV2JerseyResourceIT.java
>  639d581 
> 
> Diff: https://reviews.apache.org/r/56815/diff/
> 
> 
> Testing
> ---
> 
> verified that unit tests pass successfully
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Updated] (ATLAS-1566) Use Jackson ObjectMapper for serialization and deserailization

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1566:

Attachment: ATLAS-1566.1.patch

Attaching the patch.
No additional test failures were observed with the patch

> Use Jackson ObjectMapper for serialization and deserailization
> --
>
> Key: ATLAS-1566
> URL: https://issues.apache.org/jira/browse/ATLAS-1566
> Project: Atlas
>  Issue Type: Improvement
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1566.1.patch
>
>
> Currently, GSON is used for serialization and deserialization of AtlasType 
> POJOs at REST layer. ObjectMapper from Jackson library is used at other 
> places in the Atlas code. Use ObjectMapper in AtlasType to make the 
> serialization/deserialization consistent across Atlas code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ATLAS-1565) Create EntityREST endpoints for delete operations

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871656#comment-15871656
 ] 

Vimal Sharma commented on ATLAS-1565:
-

Committed to master 
https://github.com/apache/incubator-atlas/commit/e4cc16ac7bd133964bf02eda360fe660d9225484
Thanks Sarath

> Create EntityREST endpoints for delete operations
> -
>
> Key: ATLAS-1565
> URL: https://issues.apache.org/jira/browse/ATLAS-1565
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.8-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Attachments: ATLAS-1565.1.patch
>
>
> EntityREST delete endpoints need to hook to the v2 delete methods in v2 
> entitiesStore.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ATLAS-1566) Use Jackson ObjectMapper for serialization and deserailization

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1566:

Issue Type: Improvement  (was: Bug)

> Use Jackson ObjectMapper for serialization and deserailization
> --
>
> Key: ATLAS-1566
> URL: https://issues.apache.org/jira/browse/ATLAS-1566
> Project: Atlas
>  Issue Type: Improvement
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
>
> Currently, GSON is used for serialization and deserialization of AtlasType 
> POJOs at REST layer. ObjectMapper from Jackson library is used at other 
> places in the Atlas code. Use ObjectMapper in AtlasType to make the 
> serialization/deserialization consistent across Atlas code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ATLAS-1566) Use Jackson ObjectMapper for serialization and deserailization

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1566:
---

 Summary: Use Jackson ObjectMapper for serialization and 
deserailization
 Key: ATLAS-1566
 URL: https://issues.apache.org/jira/browse/ATLAS-1566
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.8-incubating


Currently, GSON is used for serialization and deserialization of AtlasType 
POJOs at REST layer. ObjectMapper from Jackson library is used at other places 
in the Atlas code. Use ObjectMapper in AtlasType to make the 
serialization/deserialization consistent across Atlas code.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56672: ATLAS-1370: Atlas REST documentation

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56672/#review165854
---


Ship it!




Ship It!

- Vimal Sharma


On Feb. 16, 2017, 4:18 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56672/
> ---
> 
> (Updated Feb. 16, 2017, 4:18 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1370
> https://issues.apache.org/jira/browse/ATLAS-1370
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently there's no easy way of figuring the REST interactions for atlas 
> unless you know the exact place where to look the REST interfaces. Enunciate 
> is a build plugin that allows a project to create such html docs for easier 
> understanding of the REST endpoints.
> 
> Currently the enunciate version being used has some limitations when building 
> with JDK8 thus it's activated using a profile called jdk7. The latest version 
> of enunciate has no such limitation and hence the profile activation might 
> not be necessary (added a skipEnunciate property for enable/disable control).
> 
> This review is mainly for the TypesREST, LineageREST and DiscoveryREST. 
> 
> HOWTO:
> 
> mvn clean install -DskipTests -DskipSite=false -DskipEnunciate=false
> 
> Docs generated under webapp/target/api/v2/ (open the index.html page in your 
> favorite browser)
> 
> 
> Diffs
> -
> 
>   build-tools/src/main/resources/enunciate.xml 777b496a 
>   docs/src/site/twiki/index.twiki d45f4dae 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ae6be843 
>   pom.xml 834ecae0 
>   webapp/pom.xml 5dc74019 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 440d75ce 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 48d8d493 
>   webapp/src/main/java/org/apache/atlas/web/rest/LineageREST.java 0904b693 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java 3203b712 
> 
> Diff: https://reviews.apache.org/r/56672/diff/
> 
> 
> Testing
> ---
> 
> No testing needed as there's no functionality change.
> 
> Will run mvn clean install -DskipTests for build sanity.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 56184: ATLAS-1499: Notification processing using V2 Store

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56184/#review165848
---


Ship it!




Please rebase as there are some compilation errors due to further changes.

Verified that the table creation/updation/deletion are captured correctly by 
the Atlas Hook.

- Vimal Sharma


On Feb. 15, 2017, 10:18 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56184/
> ---
> 
> (Updated Feb. 15, 2017, 10:18 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma 
> Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1499
> https://issues.apache.org/jira/browse/ATLAS-1499
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1499: Notification processing using V2 Store
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ae6be843 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> edaede0c 
>   
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java
>  74acfdce 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
>  1ef803c0 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> cf85b2fc 
>   server-api/src/main/java/org/apache/atlas/RequestContextV1.java bf731746 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java
>  f2416810 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java
>  f1f3d18a 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java
>  aa14aff4 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java
>  dc740f55 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
>  cb1390d1 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java
>  6d8e3aee 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 
> a7157a36 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 
> 968d74fe 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java
>  b1dae56d 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java
>  6967c4f5 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasObjectIdConverter.java
>  11a020d8 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
>  2b70c5e1 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
>  920b48b0 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 440d75ce 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 852b124f 
>   webapp/src/test/java/org/apache/atlas/LocalAtlasClientTest.java c5616dfe 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerKafkaTest.java
>  873e5625 
>   
> webapp/src/test/java/org/apache/atlas/notification/NotificationHookConsumerTest.java
>  f06f7912 
> 
> Diff: https://reviews.apache.org/r/56184/diff/
> 
> 
> Testing
> ---
> 
> mvn clean install -DskipITs executed successfully.
> 
> UI/Manual testing details
> 
> 1. Manually created table in hive, showed up in graph and as an entity from 
> the search UI
> 2. Created a view from the above table and the lineage showed up in atlas 
> dashboard
> 3. added a column to the above table (changes could be seen on the UI)
> 4. altered table columns (changes couldn't be seen on the UI) **Error**
> 
> 
> Will be running HiveHookIT to verify more cases.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

[jira] [Resolved] (ATLAS-1555) Move classification endpoint from Entities API to Entity API and remove Entities API

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1555.
-
Resolution: Fixed

Committed to master 
https://github.com/apache/incubator-atlas/commit/2a93a6aa4090612c5c013037b40dfd687fc7f399

Thanks Madhan for review

> Move classification endpoint from Entities API to Entity API and remove 
> Entities API
> 
>
> Key: ATLAS-1555
> URL: https://issues.apache.org/jira/browse/ATLAS-1555
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1555.patch
>
>
> Entities API has a single method(API endpoint) to associate a classification 
> to multiple entities.
> Move this classification endpoint from Entities API to Entity API and remove 
> Entities API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ATLAS-1555) Move classification endpoint from Entities API to Entity API and remove Entities API

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1555:

Attachment: ATLAS-1555.patch

> Move classification endpoint from Entities API to Entity API and remove 
> Entities API
> 
>
> Key: ATLAS-1555
> URL: https://issues.apache.org/jira/browse/ATLAS-1555
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Attachments: ATLAS-1555.patch
>
>
> Entities API has a single method(API endpoint) to associate a classification 
> to multiple entities.
> Move this classification endpoint from Entities API to Entity API and remove 
> Entities API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ATLAS-1555) Move classification endpoint from Entities API to Entity API and remove Entities API

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1555:
---

 Summary: Move classification endpoint from Entities API to Entity 
API and remove Entities API
 Key: ATLAS-1555
 URL: https://issues.apache.org/jira/browse/ATLAS-1555
 Project: Atlas
  Issue Type: Improvement
Reporter: Vimal Sharma
Assignee: Vimal Sharma


Entities API has a single method(API endpoint) to associate a classification to 
multiple entities.

Move this classification endpoint from Entities API to Entity API and remove 
Entities API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1542:

Affects Version/s: 0.8-incubating
   0.7-incubating

> Atlas server fails to start if duplicate types are found during Typesystem 
> bootstrap
> 
>
> Key: ATLAS-1542
> URL: https://issues.apache.org/jira/browse/ATLAS-1542
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.7-incubating, 0.8-incubating
>Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1542.1.patch, ATLAS-1542.patch
>
>
> When Atlas server is restarted, types in the existing typesystem are 
> bootstrapped from the underlying graph. When a duplicate type is 
> found(probably due to a stray vertex in the graph), Atlas server throws an 
> exception and server refuses to start.
> Atlas server should log a warning when a duplicate type is encountered. The 
> server should come up normally without throwing an exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1542.
-
Resolution: Fixed

Committed to master and 0.7-incubating and master branch. Thanks Madhan for 
review

> Atlas server fails to start if duplicate types are found during Typesystem 
> bootstrap
> 
>
> Key: ATLAS-1542
> URL: https://issues.apache.org/jira/browse/ATLAS-1542
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1542.1.patch, ATLAS-1542.patch
>
>
> When Atlas server is restarted, types in the existing typesystem are 
> bootstrapped from the underlying graph. When a duplicate type is 
> found(probably due to a stray vertex in the graph), Atlas server throws an 
> exception and server refuses to start.
> Atlas server should log a warning when a duplicate type is encountered. The 
> server should come up normally without throwing an exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1542:

Attachment: ATLAS-1542.1.patch

> Atlas server fails to start if duplicate types are found during Typesystem 
> bootstrap
> 
>
> Key: ATLAS-1542
> URL: https://issues.apache.org/jira/browse/ATLAS-1542
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1542.1.patch, ATLAS-1542.patch
>
>
> When Atlas server is restarted, types in the existing typesystem are 
> bootstrapped from the underlying graph. When a duplicate type is 
> found(probably due to a stray vertex in the graph), Atlas server throws an 
> exception and server refuses to start.
> Atlas server should log a warning when a duplicate type is encountered. The 
> server should come up normally without throwing an exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1542:

Attachment: ATLAS-1542.patch

> Atlas server fails to start if duplicate types are found during Typesystem 
> bootstrap
> 
>
> Key: ATLAS-1542
> URL: https://issues.apache.org/jira/browse/ATLAS-1542
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1542.patch
>
>
> When Atlas server is restarted, types in the existing typesystem are 
> bootstrapped from the underlying graph. When a duplicate type is 
> found(probably due to a stray vertex in the graph), Atlas server throws an 
> exception and server refuses to start.
> Atlas server should log a warning when a duplicate type is encountered. The 
> server should come up normally without throwing an exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ATLAS-1542) Atlas server fails to start if duplicate types are found during Typesystem bootstrap

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1542:
---

 Summary: Atlas server fails to start if duplicate types are found 
during Typesystem bootstrap
 Key: ATLAS-1542
 URL: https://issues.apache.org/jira/browse/ATLAS-1542
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.8-incubating


When Atlas server is restarted, types in the existing typesystem are 
bootstrapped from the underlying graph. When a duplicate type is found(probably 
due to a stray vertex in the graph), Atlas server throws an exception and 
server refuses to start.

Atlas server should log a warning when a duplicate type is encountered. The 
server should come up normally without throwing an exception



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56380: ATLAS-1526: removed foreignKey/mappedFromRef constraints and brought back legacy flags isComposite/reverseAttributeName using constraints owner/inverseRef(attribute=attr1)

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56380/#review164492
---


Fix it, then Ship it!




Rest looks good to me


addons/models/0060-hbase_model.json 
<https://reviews.apache.org/r/56380/#comment236263>

hbase_model.json is a placeholder for now, right?
I suggest we file a JIRA to revise the HBase model later



intg/src/main/java/org/apache/atlas/type/AtlasStructType.java (line 114)
<https://reviews.apache.org/r/56380/#comment236290>

Code in Line 115-125 and 127-137 is common.
Please move it outside the if check


- Vimal Sharma


On Feb. 7, 2017, 11:06 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56380/
> ---
> 
> (Updated Feb. 7, 2017, 11:06 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1526
> https://issues.apache.org/jira/browse/ATLAS-1526
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> constraints foreignKey/mappedFromRef introduced in v2 doesn't handle all use 
> cases of legacy flags isComposite/reverseAttributeName. Hence replace these 
> constrainsts with new constraints "owner" and "inverserRef(attribute=attr)"
> 
> 
> Diffs
> -
> 
>   addons/models/0030-hive_model.json 5ae16cf 
>   addons/models/0060-hbase_model.json 5febbbc 
>   addons/models/0080-storm_model.json 344227d 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 
> 2c00f54 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 761eef5 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java f444e93 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java b4aa8aa 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 032dce0 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
>  d48c87e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  f507ae0 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java
>  2e9e5e4 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 1559eb9 
>   webapp/src/main/java/org/apache/atlas/util/RestUtils.java cecf636 
> 
> Diff: https://reviews.apache.org/r/56380/diff/
> 
> 
> Testing
> ---
> 
> updated unit tests and verified that existing unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 56102: ATLAS-1388 : Cache entities that are created/updated

[Vimal Sharma]

> On Feb. 1, 2017, 10:42 a.m., Vimal Sharma wrote:
> > The cache size can grow large if the number of registered entities is high. 
> > It would be good to have a cache eviction policy just like it was done for 
> > DSL Query caching in ATLAS-1387
> 
> Jeff Hagelberg wrote:
> We could do that.  It seems like overkill though.  The big difference is 
> that RequestContext is thread local, and a new RequestContext is created 
> every time a http request comes in.  Once the http request finishes, 
> RequestContext.clear() is called, and the cache goes out of scope and will be 
> garbage collected.  (See AuditFilter for details).  The cache is limited to 
> the instances used for processsing the request.  In the case of the compiled 
> query cache, there is one effectively static instance of the cache that is 
> used for all requests.  Without the eviction policy, that would continue 
> growing until the JVM runs out of memory.
> 
> Jeff Hagelberg wrote:
> Is there a specific use case you are concerned about?  For example, if 
> someone runs a DSL query that needs to return 100,000 entities, those 
> entities would be cached.  However, even without the cache we would still 
> need to have the 100,000 entities in memory so they can be serialized to json 
> and sent back to the client.  I'm not sure that the cache increases the 
> amount of memory required by much.  What it does do, though, is keep the 
> instances that are created in the java heap for a longer period of time.
> 
> David Kantor wrote:
> There no need for a cache eviction policy as this cache is only active 
> for the duration of the request.   Perhaps to address the comment, the cache 
> could be cleared upon completion of the request to make the entries available 
> for garbage collection sooner.
> 
> Jeff Hagelberg wrote:
> Sure, I've changed it so that we explicitly clear the cache.

Got it. I didn't observe that the scope of cache is limited to a single request 
context. The current implementation looks good.


- Vimal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56102/#review163800
---


On Feb. 1, 2017, 9:41 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56102/
> ---
> 
> (Updated Feb. 1, 2017, 9:41 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Bugs: ATLAS-1388
> https://issues.apache.org/jira/browse/ATLAS-1388
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cache created entities in RequestContext when they are created.
> Update/refactor DefaultMetadataService.loadEntities() to use the cached 
> created entities.
> Use the cache in the following places:
> FullTextMapper
> DefaultMetadataService.onEntitiesAdded - check cache before calling 
> DefaultMetadataService.loadEntities
> DefaultMetadataService.onEntitiesUpdated - check cache before calling 
> DefaultMetadataService.loadEntities
> EntityResource.getEntityDefinition - check cache before calling 
> DefaultMetadataService.getEntityDefinition
> EntityResource.getResponse - check cache before calling 
> DefaultMetadataService.getEntityDefinition
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
>  f4d8f00da863deeb98209aec2dfc4ccb22734cfa 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  5be8d0bc349294dc4340ffe5831bfb1265825ed8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  6608551be44033f07ddbd2ac3f3764d1ac3b0f22 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  38a553abf0151221c5d802e9ce1977a693d1a698 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  bae8b2ac0cae6bf6392f91f24030d81089ae660b 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> cda9eac38861fd55c1494d6d90b5e750e6133545 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  d447c2d90fec6c03c7fecb8d8ef57a6ea072d35a 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
>  9e850a9dc0ac122cf3fcdbf7df72a93643abc98d 
>   
> repository/src/test/java/org/

Re: Apache Atlas Bridge for Flink

[Vimal Sharma]

Hi Stefan,
Apache Atlas does not have a bridge for Flink currently.

I don’t think there has been any request for this feature in the past.

Hope this helps. Thanks
Vimal





On 2/1/17, 4:05 PM, "Stefan Papp"  wrote:

>Hi,
>
>
>Is an Apache Atlas Bridge for Flink available?
>
>Has this feature already been requested.
>
>Stefan
>
>Stefan Papp
>Data Architect
>
>The unbelievable Machine Company GmbH
>Museumsplatz 1/10/13
>1070 Wien
>
>Tel: +43 - 1 - 361 99 77 - 215
>Mobil: +43664 2614367
>
>https://www.unbelievable-machine.com 
>
>*Blog  | *Karriere 
> | *Facebook 
> | *Twitter 
>
>
>Geschäftsführer: Ravin Mehta, Benno Wiedfeld
>Sitz der Gesellschaft: Berlin, Deutschland
>Handelsregister: Amtsgericht Charlottenburg HRB 115071B
>Umsatzsteuer-Identifikationsnummer: DE261090159
>
>Ausgezeichnet: *um ist zweifacher „Big Data Leader 2017“ 
>

Re: Review Request 56102: ATLAS-1388 : Cache entities that are created/updated

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56102/#review163800
---



The cache size can grow large if the number of registered entities is high. It 
would be good to have a cache eviction policy just like it was done for DSL 
Query caching in ATLAS-1387

- Vimal Sharma


On Jan. 30, 2017, 10:42 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56102/
> ---
> 
> (Updated Jan. 30, 2017, 10:42 p.m.)
> 
> 
> Review request for atlas and David Kantor.
> 
> 
> Bugs: ATLAS-1388
> https://issues.apache.org/jira/browse/ATLAS-1388
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cache created entities in RequestContext when they are created.
> Update/refactor DefaultMetadataService.loadEntities() to use the cached 
> created entities.
> Use the cache in the following places:
> FullTextMapper
> DefaultMetadataService.onEntitiesAdded - check cache before calling 
> DefaultMetadataService.loadEntities
> DefaultMetadataService.onEntitiesUpdated - check cache before calling 
> DefaultMetadataService.loadEntities
> EntityResource.getEntityDefinition - check cache before calling 
> DefaultMetadataService.getEntityDefinition
> EntityResource.getResponse - check cache before calling 
> DefaultMetadataService.getEntityDefinition
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/DefaultGraphPersistenceStrategy.java
>  f4d8f00da863deeb98209aec2dfc4ccb22734cfa 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  5be8d0bc349294dc4340ffe5831bfb1265825ed8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  be02891cad3020e50d5244fd2aaf3c4af3a5954f 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  7b2b753b930467e015d364819c5baa983fce0cf8 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  bae8b2ac0cae6bf6392f91f24030d81089ae660b 
>   repository/src/test/java/org/apache/atlas/TestUtils.java 
> cda9eac38861fd55c1494d6d90b5e750e6133545 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  f2ca6a8fb1573755d16497236358358a07881e9c 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryDeleteTestBase.java
>  9e850a9dc0ac122cf3fcdbf7df72a93643abc98d 
>   
> repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java
>  7444bf38834f59454d67cf763c932d665d7ef31c 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  c902f8126f6b516e84ab9d89b0ec80ac8ed819fd 
>   
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
>  aa1cdaa7848aeb767725b3161ccd904c8750536f 
>   
> repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java 
> c926f4d7d793ef095b20853277f3ba979483e039 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java 
> 651a71dc238a3adaac9504a77ba439785fa07ca8 
> 
> Diff: https://reviews.apache.org/r/56102/diff/
> 
> 
> Testing
> ---
> 
> Ran full build, no regresssions found.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>

Re: Review Request 56113: Fixed issues with deletion during updates

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56113/#review163797
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 (line 242)
<https://reviews.apache.org/r/56113/#comment235303>

Didn't understand why the code has been commented. Won't this result into 
stray edges of reverse attribute references


- Vimal Sharma


On Feb. 1, 2017, midnight, Suma Shivaprasad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56113/
> ---
> 
> (Updated Feb. 1, 2017, midnight)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1509
> https://issues.apache.org/jira/browse/ATLAS-1509
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Added tests for deletion during updates and fixed issues found
> 
> 
> Diffs
> -
> 
>   intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  48bb77e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  34e02c6 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  c98d340 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/StructVertexMapper.java
>  22851ca 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
>  25bae44 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  c902f81 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> bb8c223 
>   server-api/src/main/java/org/apache/atlas/RequestContextV1.java 1fc11a2 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
>  75a7183 
>   
> webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
>  8777510 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 47e1fa3 
> 
> Diff: https://reviews.apache.org/r/56113/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Suma Shivaprasad
> 
>

Re: Using .7.1rc3 with import-hive.sh - Lineage is produced from EXTERNAL tables only - not MANAGED tables : by desing or bug ?

[Vimal Sharma]

Hi Russell,
Can you please file a JIRA to document this as a limitation. The documentation 
will get updated in the next release.

I am not aware of the branch_intersect example are you referring to.

Thanks
Vimal




On 1/30/17, 4:52 PM, "Russell Anderson"  wrote:

>Hi Vimal
>
>This is very helpful understanding why lineage is not created.
>
>I appreciate your explanation and will follow through with the creation of a 
>bug/enhancement against the import-hive
>
>I suggest at least two things be done immediately:
>
>1) document this as a limitation in the limitations section
>
>2) the example that is on-line for branch_intersect by Horton works be 
>modified to only use external tables 
>
>Regards 
>
>Russ
>
>Sent from my iPhone
>
>> On Jan 30, 2017, at 12:04 AM, Vimal Sharma  wrote:
>> 
>> Hi Russell,
>> I responded to this question on HCC at 
>> https://community.hortonworks.com/questions/66547/hivemetastorebridge-code-only-creating-lineage-for.html#answer-70360.
>> 
>> When using import_hive.sh, lineage is created only for external tables. This 
>> is indeed by design. For external tables, it makes sense to mark the source 
>> HDFS path as the “source” node in lineage diagram.
>> 
>> For MANAGED tables, I am not sure how much value it adds to create lineage 
>> diagram since the source HDFS path will inherently be 
>> {HIVE_DATA_ROOT}/{TABLENAME}. 
>> 
>> 
>> For managed tables created using CTAS as shown below:
>> 
>> > create table dest as select * from source;
>> 
>> We don’t have corresponding lineage after import_hive.sh 
>> 
>> source —>  CTAS Process —> dest
>> 
>> This is because we don’t process the tables present in Hive metastore in a 
>> specific order which is necessary to get the above lineage. It would be a 
>> good improvement to the import_hive.sh utility and you can raise a bug to 
>> track it.
>> 
>> Hope this helps
>> - Vimal
>> 
>> 
>> From: Russell Anderson 
>> Date: Sunday, January 29, 2017 at 11:14 PM
>> To: "dev@atlas.incubator.apache.org" 
>> Cc: Ashutosh Mestry , Barry Rosen 
>> , David Radley , Madhan 
>> Neethiraj , Apoorv Naik , Sarath 
>> Subramanian , default , 
>> Russell Anderson 
>> Subject: Using .7.1rc3 with import-hive.sh - Lineage is produced from 
>> EXTERNAL tables only - not MANAGED tables : by desing or bug ?
>> 
>> Hi,
>> 
>> Using the latest .7.1rc3 source - after building and installing on test 
>> system I have found that 'lineage' is only generated from EXTERNAL tables 
>> and not from MANAGED tables.
>> 
>> I repeat 'lineage' - meaning the left to right flow. I get Metadata of the 
>> assets from MANAGED table but not left to right lineage.
>> 
>> I do get lineage from External tables.
>> 
>> Is this by design or is this a P1 bug?
>> 
>> In prior release there was a code fix around that area of the Hive Bridge 
>> that checks this, and I am wondering has this been re-introduced ?
>> 
>> If no one responds I will assume it is a bug, and will created one.
>> 
>> Regards,
>> 
>> Russ.
>> 
>> Russell Anderson---01/24/2017 04:05:11 PM---Hi, What used to work in .7rc2 
>> no longer seems to work with the Hive Hook: [ see stack trace below f
>> 
>> From: Russell Anderson/Worcester/IBM
>> To: dev@atlas.incubator.apache.org
>> Cc: Ashutosh Mestry , Barry 
>> Rosen/Worcester/IBM@IBMUS, David Radley , Madhan 
>> Neethiraj , Apoorv Naik , Sarath 
>> Subramanian , "Vimal Sharma" 
>> 
>> Date: 01/24/2017 04:05 PM
>> Subject: Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException 
>> - Table not found in Atlas .7.1rc3
>> 
>> 
>> Hi,
>> 
>> What used to work in .7rc2 no longer seems to work with the Hive Hook: [ see 
>> stack trace below from hiveserver2.log]
>> 
>> Looking at the code it cannot find the new table 'russ88' - this simple test 
>> case worked in the .7rc2 version.
>> 
>> I have complete permission to make this happen in the HIVEVIEW but somehow 
>> the Hive Hook cannot deal with it.
>> 
>> Any ideas?
>> 
>> 
>> 
>> 
>> 
>> 2017-01-24 12:30:25,917 INFO bridge.HiveMetaStoreBridge 
>> (HiveMetaStoreBridge.java:createOrUpdate\
>> DBInstance(166)) - Importing objects from databaseName : bigsql
>> 2017-01-24 12:30:25,917 INFO metastore.HiveMetaStore 
>> (HiveMetaStore.java:logInfo(746)) - 5: get_\
>>

Re: Review Request 55443: ATLAS-1387 : Compiled Query Cache

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55443/#review163480
---



This is a great improvement. Thanks Jeffrey for implementing

- Vimal Sharma


On Jan. 29, 2017, 12:18 a.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55443/
> ---
> 
> (Updated Jan. 29, 2017, 12:18 a.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-1387
> https://issues.apache.org/jira/browse/ATLAS-1387
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Adds a compiled query cache to Atlas.  This avoids the overhead of parsing 
> and translating DSL queries that have been previously executed.
> 
> 
> Diffs
> -
> 
>   common/pom.xml 0226541b2dd73e8a01f050982cb8b37f5fed9cab 
>   common/src/main/java/org/apache/atlas/utils/LruCache.java PRE-CREATION 
>   common/src/test/java/org/apache/atlas/utils/LruCacheTest.java PRE-CREATION 
>   distro/src/conf/atlas-application.properties 
> 303ce7b00c93f2499e7b18c5f3a131b50c150b69 
>   
> repository/src/main/java/org/apache/atlas/discovery/graph/GraphBackedDiscoveryService.java
>  fb488cdfc7cef195ffc5221afb9a9109a6e92fc9 
>   
> repository/src/main/java/org/apache/atlas/util/AtlasRepositoryConfiguration.java
>  6655085ee11c94addca1564cf77bbdb001c4586f 
>   repository/src/main/java/org/apache/atlas/util/CompiledQueryCacheKey.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/util/NoopGremlinQuery.java 
> PRE-CREATION 
>   repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala 
> 5693c9ecc1a96154a8b0ac48256e5074dc041c5f 
>   
> repository/src/test/java/org/apache/atlas/util/CompiledQueryCacheKeyTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/55443/diff/
> 
> 
> Testing
> ---
> 
> Ran all atlas tests, no regressions found.  There were some tests that failed 
> both with and without these changes.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>

Re: Using .7.1rc3 with import-hive.sh - Lineage is produced from EXTERNAL tables only - not MANAGED tables : by desing or bug ?

[Vimal Sharma]

Hi Russell,
I responded to this question on HCC at 
https://community.hortonworks.com/questions/66547/hivemetastorebridge-code-only-creating-lineage-for.html#answer-70360.

When using import_hive.sh, lineage is created only for external tables. This is 
indeed by design. For external tables, it makes sense to mark the source HDFS 
path as the “source” node in lineage diagram.

For MANAGED tables, I am not sure how much value it adds to create lineage 
diagram since the source HDFS path will inherently be 
{HIVE_DATA_ROOT}/{TABLENAME}.


For managed tables created using CTAS as shown below:

> create table dest as select * from source;

We don’t have corresponding lineage after import_hive.sh

source —>  CTAS Process —> dest

This is because we don’t process the tables present in Hive metastore in a 
specific order which is necessary to get the above lineage. It would be a good 
improvement to the import_hive.sh utility and you can raise a bug to track it.

Hope this helps
- Vimal


From: Russell Anderson mailto:r...@us.ibm.com>>
Date: Sunday, January 29, 2017 at 11:14 PM
To: "dev@atlas.incubator.apache.org<mailto:dev@atlas.incubator.apache.org>" 
mailto:dev@atlas.incubator.apache.org>>
Cc: Ashutosh Mestry mailto:ames...@hortonworks.com>>, 
Barry Rosen mailto:rose...@us.ibm.com>>, David Radley 
mailto:david_rad...@uk.ibm.com>>, Madhan Neethiraj 
mailto:mad...@apache.org>>, Apoorv Naik 
mailto:naik.apo...@gmail.com>>, Sarath Subramanian 
mailto:sarath.ku...@gmail.com>>, default 
mailto:visha...@hortonworks.com>>, Russell Anderson 
mailto:r...@us.ibm.com>>
Subject: Using .7.1rc3 with import-hive.sh - Lineage is produced from EXTERNAL 
tables only - not MANAGED tables : by desing or bug ?


Hi,

Using the latest .7.1rc3 source - after building and installing on test system 
I have found that 'lineage' is only generated from EXTERNAL tables and not from 
MANAGED tables.

I repeat 'lineage' - meaning the left to right flow. I get Metadata of the 
assets from MANAGED table but not left to right lineage.

I do get lineage from External tables.

Is this by design or is this a P1 bug?

In prior release there was a code fix around that area of the Hive Bridge that 
checks this, and I am wondering has this been re-introduced ?

If no one responds I will assume it is a bug, and will created one.

Regards,

Russ.

[Inactive hide details for Russell Anderson---01/24/2017 04:05:11 PM---Hi, What 
used to work in .7rc2 no longer seems to work wi]Russell Anderson---01/24/2017 
04:05:11 PM---Hi, What used to work in .7rc2 no longer seems to work with the 
Hive Hook: [ see stack trace below f

From: Russell Anderson/Worcester/IBM
To: dev@atlas.incubator.apache.org<mailto:dev@atlas.incubator.apache.org>
Cc: Ashutosh Mestry mailto:ames...@hortonworks.com>>, 
Barry Rosen/Worcester/IBM@IBMUS, David Radley 
mailto:david_rad...@uk.ibm.com>>, Madhan Neethiraj 
mailto:mad...@apache.org>>, Apoorv Naik 
mailto:naik.apo...@gmail.com>>, Sarath Subramanian 
mailto:sarath.ku...@gmail.com>>, "Vimal Sharma" 
mailto:visha...@hortonworks.com>>
Date: 01/24/2017 04:05 PM
Subject: Caused by: org.apache.hadoop.hive.ql.metadata.InvalidTableException - 
Table not found in Atlas .7.1rc3




Hi,

What used to work in .7rc2 no longer seems to work with the Hive Hook: [ see 
stack trace below from hiveserver2.log]

Looking at the code it cannot find the new table 'russ88' - this simple test 
case worked in the .7rc2 version.

I have complete permission to make this happen in the HIVEVIEW but somehow the 
Hive Hook cannot deal with it.

Any ideas?



[cid:2__=8FBB0A24DFF36A868f9e8a93df938690918c8FB@]

2017-01-24 12:30:25,917 INFO bridge.HiveMetaStoreBridge 
(HiveMetaStoreBridge.java:createOrUpdate\
DBInstance(166)) - Importing objects from databaseName : bigsql
2017-01-24 12:30:25,917 INFO metastore.HiveMetaStore 
(HiveMetaStore.java:logInfo(746)) - 5: get_\
table : db=bigsql tbl=russ88
2017-01-24 12:30:25,917 INFO HiveMetaStore.audit 
(HiveMetaStore.java:logAuditEvent(371)) - ugi=h\
ive ip=unknown-ip-addr cmd=get_table : db=bigsql tbl=russ88
2017-01-24 12:30:25,919 ERROR metadata.Hive (Hive.java:getTable(1119)) - Table 
russ88 not found: \
bigsql.russ88 table not found
2017-01-24 12:30:25,920 ERROR hook.HiveHook (HiveHook.java:run(207)) - Atlas 
hook failed due to e\
rror
java.lang.reflect.UndeclaredThrowableException
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1672)
at org.apache.atlas.hive.hook.HiveHook$2.run(HiveHook.java:197)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.ru

Re: Review Request 55928: Notification processing to use new instance API for create and full-update

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55928/
---

(Updated Jan. 27, 2017, 12:31 p.m.)


Review request for atlas.


Changes
---

Added test to verify that the Entity change listener records entity 
create/update when create/update is perfomed using the new Instance API


Bugs: ATLAS-1499
https://issues.apache.org/jira/browse/ATLAS-1499


Repository: atlas


Description
---

Atlas Server notifies the entity change 
listeners(NotificationEntityChangeListener, EntityAuditListener) after any 
create/update operation on entities.
The create/update routines have been changed in ATLAS-1467. The corresponding 
changes are required in notification processing.


Diffs (updated)
-

  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 4f2916c 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasAbstractFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasArrayFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasClassificationFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEntityFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEnumFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverters.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasInstanceRestAdapters.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasMapFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasPrimitiveFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasStructFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
 1ef803c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 48bb77e 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
 c902f81 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java
 f1f3d18 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java
 e3b4efa 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java
 da71c31 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
 75a7183 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java
 4f22437 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 
079f3be 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 
7c3f536 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java
 7368c72 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java 
f390e82 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
 382d1ef 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
 8777510 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a 

Diff: https://reviews.apache.org/r/55928/diff/


Testing (updated)
---

Testing done.


Thanks,

Vimal Sharma

[jira] [Updated] (ATLAS-1499) Notification processing to use new instance API for create and full-update

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1499:

Attachment: ATLAS-1499.1.patch

> Notification processing to use new instance API for create and full-update
> --
>
> Key: ATLAS-1499
> URL: https://issues.apache.org/jira/browse/ATLAS-1499
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1499.1.patch
>
>
> Atlas Server notifies the entity change 
> listeners(NotificationEntityChangeListener, EntityAuditListener) after any 
> create/update operation on entities. 
> The create/update routines have been changed in ATLAS-1467. The corresponding 
> changes are required in notification processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 55928: Notification processing to use new instance API for create and full-update

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55928/
---

Review request for atlas.


Bugs: ATLAS-1499
https://issues.apache.org/jira/browse/ATLAS-1499


Repository: atlas


Description
---

Atlas Server notifies the entity change 
listeners(NotificationEntityChangeListener, EntityAuditListener) after any 
create/update operation on entities.
The create/update routines have been changed in ATLAS-1467. The corresponding 
changes are required in notification processing.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasAbstractFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasArrayFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasClassificationFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEntityFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasEnumFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasFormatConverters.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasInstanceRestAdapters.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasMapFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasPrimitiveFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/adapters/AtlasStructFormatConverter.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 18e397b 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasAbstractFormatConverter.java
 f1f3d18 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasArrayFormatConverter.java
 e3b4efa 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasClassificationFormatConverter.java
 da71c31 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEntityFormatConverter.java
 74ab740 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasEnumFormatConverter.java
 4f22437 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverter.java 
079f3be 
  webapp/src/main/java/org/apache/atlas/web/adapters/AtlasFormatConverters.java 
7c3f536 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasInstanceRestAdapters.java
 2b13552 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasMapFormatConverter.java 
f390e82 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasPrimitiveFormatConverter.java
 382d1ef 
  
webapp/src/main/java/org/apache/atlas/web/adapters/AtlasStructFormatConverter.java
 8777510 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 5107767 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ee1174a 

Diff: https://reviews.apache.org/r/55928/diff/


Testing
---

Testing not done.

public AtlasEntity getById(final String guid) is not yet implemented. Will be 
looking into implementing it and then testing the patch


Thanks,

Vimal Sharma

[jira] [Created] (ATLAS-1499) notification processing to use new instance API for create and full-update

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1499:
---

 Summary: notification processing to use new instance API for 
create and full-update
 Key: ATLAS-1499
 URL: https://issues.apache.org/jira/browse/ATLAS-1499
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.8-incubating


Atlas Server notifies the entity change 
listeners(NotificationEntityChangeListener, EntityAuditListener) after any 
create/update operation on entities. 

The create/update routines have been changed in ATLAS-1467. The corresponding 
changes are required in notification processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1499) Notification processing to use new instance API for create and full-update

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1499:

Summary: Notification processing to use new instance API for create and 
full-update  (was: notification processing to use new instance API for create 
and full-update)

> Notification processing to use new instance API for create and full-update
> --
>
> Key: ATLAS-1499
> URL: https://issues.apache.org/jira/browse/ATLAS-1499
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
>
> Atlas Server notifies the entity change 
> listeners(NotificationEntityChangeListener, EntityAuditListener) after any 
> create/update operation on entities. 
> The create/update routines have been changed in ATLAS-1467. The corresponding 
> changes are required in notification processing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1494) Data models of types inheriting Process have Inputs,Outputs which are of very generic type.

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834206#comment-15834206
 ] 

Vimal Sharma commented on ATLAS-1494:
-

[~ssainath] I think this is by design. Types inheriting from type Process can 
connect cross component entities. For example, type "storm_topology" inherits 
from "Process" and its inputs/outputs can be entities of type "hive_table", 
"kafka_spout", "hdfs_path".

Imposing constraints on "inputs" and "outputs" of types derived from "Process" 
sounds reasonable and needs discussion. As you mentioned, we can consider 
imposing additional constraints on derived types like "falcon_process" to allow 
specific types in "inputs/outputs".

> Data models of types inheriting Process have Inputs,Outputs which are of very 
> generic type. 
> 
>
> Key: ATLAS-1494
> URL: https://issues.apache.org/jira/browse/ATLAS-1494
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Sharmadha Sainath
>
> Types which are inheriting from Process have Inputs,Outputs as attributes of 
> datatype array which is very generic. For example, falcon_process' 
> input and output should be falcon_feed. In case of generic DataSet , input 
> and output can be any DataSet like hive_table, hbase_column_family , 
> jms_topic etc., which is faulty when associated to the falcon_process. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55759: ATLAS-1489 : Show create/edit entity button based on role

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55759/#review162606
---


Ship it!




Ship It!

- Vimal Sharma


On Jan. 23, 2017, 8:29 a.m., Kalyani Kashikar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55759/
> ---
> 
> (Updated Jan. 23, 2017, 8:29 a.m.)
> 
> 
> Review request for atlas, keval bhatt and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1489
> https://issues.apache.org/jira/browse/ATLAS-1489
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> # This patch is dependent on ATLAS-1437.patch 
> UI to show create / edit entity button based on permission of the loggedin 
> user. The attribute atlas.entity.update.allowed & atlas.entity.create.allowed 
> are set with flag true/false in response json.
> 
> This patch also include change for v2/search api to set resourceType in 
> getAtlasResourceType method.
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
>  9f33115 
>   dashboardv2/public/js/main.js fe08754 
>   dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
> e47b0c2 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 8d7f874 
>   dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js d63bb5a 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 38bf6b5 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js f389515 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 02d7488 
> 
> Diff: https://reviews.apache.org/r/55759/diff/
> 
> 
> Testing
> ---
> 
> Changed permission in policy-store and verified the UI with create and edit 
> button.
> 
> Verified response for session api from curl commands.
> 
>  * curl -kv -u admin:admin http://localhost:21000/api/atlas/admin/session
> 
> {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":true,"atlas.entity.create.allowed":true,"userName":"admin","groups":["ADMIN"]}
> 
>  * curl -kv -u rangertagsync:rangertagsync 
> http://localhost:21000/api/atlas/admin/session
> 
>  
> {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":false,"atlas.entity.create.allowed":false,"userName":"rangertagsync","groups":["RANGER_TAG_SYNC"]}
> 
> 
> Thanks,
> 
> Kalyani Kashikar
> 
>

Re: Review Request 55830: ATLAS-1436 Metrics collection for Atlas

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55830/#review162599
---




distro/src/conf/atlas-application.properties (line 214)
<https://reviews.apache.org/r/55830/#comment233968>

Can the result of atlas.metric.query.general.entityCount be used to compute 
atlas.metric.query.general.entityDeleted instead of computing the whole query 
altogether


- Vimal Sharma


On Jan. 23, 2017, 4:57 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55830/
> ---
> 
> (Updated Jan. 23, 2017, 4:57 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Suma 
> Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1436
> https://issues.apache.org/jira/browse/ATLAS-1436
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-1436: Metrics collection using gremlin
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 19f95758 
>   client/src/main/java/org/apache/atlas/AtlasBaseClient.java d055b789 
>   distro/src/conf/atlas-application.properties 6fa066b6 
>   intg/src/main/java/org/apache/atlas/model/metrics/AtlasMetrics.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 02d74883 
>   webapp/src/main/resources/spring-security.xml 4ed88ece 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> eb2b2f6d 
> 
> Diff: https://reviews.apache.org/r/55830/diff/
> 
> 
> Testing
> ---
> 
> mvn clean install -DskipITs executes successfully.
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 55811: ATLAS-1478: REST API to add classification to multiple entities

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55811/#review162542
---


Ship it!




Ship It!

- Vimal Sharma


On Jan. 21, 2017, 1:17 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55811/
> ---
> 
> (Updated Jan. 21, 2017, 1:17 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1478
> https://issues.apache.org/jira/browse/ATLAS-1478
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added a REST API to add a classification to multiple entities (author: Vimal 
> Sharma)
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java f0aae0c 
>   
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
>  PRE-CREATION 
>   release-log.txt 55ac3da 
>   
> repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
> 886a8d1 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  b9671b2 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  8307835 
>   server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
> e653184 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java 21f8977 
>   webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
> 90a46f8 
> 
> Diff: https://reviews.apache.org/r/55811/diff/
> 
> 
> Testing
> ---
> 
> - added unit tests
> - deployed Atlas with the new API and verified via curl that the API works 
> correctly
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Updated] (ATLAS-1478) REST API endpoint to support adding a tag to multiple entities

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1478:

Attachment: ATLAS-1478-v2.patch

Fixed review comments

> REST API endpoint to support adding a tag to multiple entities
> --
>
> Key: ATLAS-1478
> URL: https://issues.apache.org/jira/browse/ATLAS-1478
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1478.patch, ATLAS-1478-v2.patch
>
>
> Currently, there is no REST endpoint to add a tag to multiple entities. Add a 
> REST endpoint in V2 APIs to support adding a tag to multiple entities in a 
> single call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55671: REST API endpoint to support adding a tag to multiple entities

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55671/
---

(Updated Jan. 20, 2017, 4:11 p.m.)


Review request for atlas.


Changes
---

Updated patch to fix issues raised in the reviews. Thanks Madhan and Keval for 
the review and suggestions


Bugs: ATLAS-1478
https://issues.apache.org/jira/browse/ATLAS-1478


Repository: atlas


Description
---

Currently, there is no REST endpoint to add a tag to multiple entities. Add a 
REST endpoint in V2 APIs to support adding a tag to multiple entities in a 
single call.


Diffs (updated)
-

  
intg/src/main/java/org/apache/atlas/model/instance/ClassificationGuidListObject.java
 PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/MetadataRepository.java 
886a8d1 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
 b9671b2 
  
repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java 
8307835 
  server-api/src/main/java/org/apache/atlas/services/MetadataService.java 
e653184 
  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java f6acd07 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
265b650 

Diff: https://reviews.apache.org/r/55671/diff/


Testing
---

Tested using POSTMAN client.
Added a test in TestEntitiesREST to validate the same


Thanks,

Vimal Sharma

Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache lookups

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review162264
---


Ship it!




Ship It!

- Vimal Sharma


On Jan. 18, 2017, 1 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> ---
> 
> (Updated Jan. 18, 2017, 1 p.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are 
> executed as part of DSL query translated that are for things that cannot 
> possibly be types, for example field names and aliases.  These changes 
> eliminate unnecessary queries and consolidate the type lookup for trait and 
> class types where it makes sense.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 
> 6770c41d254de13e66eb80d8927f73965fa644a2 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 
> 9f3b90e6c82a8a4f7489467fedc3f7fb0515db2b 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 
> 569d3f947e49f205b3d48c7387ee4df39938deff 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> ce21a597e79b684eaadc54f208f4a540d402f1b9 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9 
>   repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala 
> ee95a20a0bdd447d907b21a5d5a0642f4142bade 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> 0957c57156381bfae82409a3c88083f564d790e8 
>   repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 
> dfa7093bec25e8954634af2a3f55f357eb7d46a1 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  1217e4af1c8bd63b191025ab9098b16ec0867a4c 
>   repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
> PRE-CREATION 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 1358159d9cdc6f36f3a34d7946707d329b10f9d3 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> dcb126454b9efc0b50f6835e6dd1371f3e16d359 
> 
> Diff: https://reviews.apache.org/r/55436/diff/
> 
> 
> Testing
> ---
> 
> All Atlas tests run, no regressions found.  There were some tests that failed 
> both with and without these changes.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>

Review Request 55671: REST API endpoint to support adding a tag to multiple entities

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55671/
---

Review request for atlas.


Bugs: ATLAS-1478
https://issues.apache.org/jira/browse/ATLAS-1478


Repository: atlas


Description
---

Currently, there is no REST endpoint to add a tag to multiple entities. Add a 
REST endpoint in V2 APIs to support adding a tag to multiple entities in a 
single call.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/rest/EntitiesREST.java f6acd07 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestEntitiesREST.java 
265b650 

Diff: https://reviews.apache.org/r/55671/diff/


Testing
---

Tested using POSTMAN client.
Added a test in TestEntitiesREST to validate the same


Thanks,

Vimal Sharma

[jira] [Updated] (ATLAS-1478) REST API endpoint to support adding a tag to multiple entities

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1478:

Attachment: ATLAS-1478.patch

> REST API endpoint to support adding a tag to multiple entities
> --
>
> Key: ATLAS-1478
> URL: https://issues.apache.org/jira/browse/ATLAS-1478
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1478.patch
>
>
> Currently, there is no REST endpoint to add a tag to multiple entities. Add a 
> REST endpoint in V2 APIs to support adding a tag to multiple entities in a 
> single call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1478) REST API endpoint to support adding a tag to multiple entities

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1478:
---

 Summary: REST API endpoint to support adding a tag to multiple 
entities
 Key: ATLAS-1478
 URL: https://issues.apache.org/jira/browse/ATLAS-1478
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.8-incubating


Currently, there is no REST endpoint to add a tag to multiple entities. Add a 
REST endpoint in V2 APIs to support adding a tag to multiple entities in a 
single call.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache lookups

[Vimal Sharma]

> On Jan. 12, 2017, 11:15 a.m., Vimal Sharma wrote:
> > webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java, 
> > line 414
> > <https://reviews.apache.org/r/55436/diff/2/?file=1603249#file1603249line414>
> >
> > Alphanumeric characters should be fine. Didn't understand the change
> 
> Jeff Hagelberg wrote:
> This was causing intermittent test failures in at least the following two 
> tests:
> testUpdate(org.apache.atlas.web.resources.TypesJerseyResourceIT)  Time 
> elapsed: 0.031 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API 
> org.apache.atlas.AtlasBaseClient$APIInfo@619bfe29 failed with status 400 (Bad 
> Request) Response Body ({"error":"0fghLoh1UH: invalid name for ENTITY. Only 
> alphanumeric and _ are allowed."})
>   at 
> org.apache.atlas.web.resources.TypesJerseyResourceIT.testUpdate(TypesJerseyResourceIT.java:117)
> 
> 
> testDuplicateCreate(org.apache.atlas.web.resources.TypedefsJerseyResourceIT)  
> Time elapsed: 0.064 sec  <<< FAILURE!
> org.apache.atlas.AtlasServiceException: Metadata service API 
> org.apache.atlas.AtlasBaseClient$APIInfo@2f6e28bc failed with status 400 (Bad 
> Request) Response Body 
> ({"errorCode":"ATLAS40025E","errorMessage":"11ZoK6bFah: invalid name for 
> ENTITY. Only alphanumeric and _ are allowed."})
>   at 
> org.apache.atlas.web.resources.TypedefsJerseyResourceIT.testDuplicateCreate(TypedefsJerseyResourceIT.java:93)
> 
> This change fixes these intermittent failures.
> 
> Jeff Hagelberg wrote:
> These tests were failing because the initial character in the randomly 
> generated entity name was a digit.

Got it. The error message in AtlasTypeUtil.java (line 64) is misleading. It 
would be fixed


- Vimal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review161364
---


On Jan. 12, 2017, 7:21 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> ---
> 
> (Updated Jan. 12, 2017, 7:21 p.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are 
> executed as part of DSL query translated that are for things that cannot 
> possibly be types, for example field names and aliases.  These changes 
> eliminate unnecessary queries and consolidate the type lookup for trait and 
> class types where it makes sense.
> 
> 
> Diffs
> -
> 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 
> 569d3f947e49f205b3d48c7387ee4df39938deff 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> ce21a597e79b684eaadc54f208f4a540d402f1b9 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9 
>   repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala 
> ee95a20a0bdd447d907b21a5d5a0642f4142bade 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> 0957c57156381bfae82409a3c88083f564d790e8 
>   repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 
> dfa7093bec25e8954634af2a3f55f357eb7d46a1 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  1217e4af1c8bd63b191025ab9098b16ec0867a4c 
>   repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
> PRE-CREATION 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 1358159d9cdc6f36f3a34d7946707d329b10f9d3 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> dcb126454b9efc0b50f6835e6dd1371f3e16d359 
> 
> Diff: https://reviews.apache.org/r/55436/diff/
> 
> 
> Testing
> ---
> 
> All Atlas tests run, no regressions found.  There were some tests that failed 
> both with and without these changes.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>

Re: Review Request 55436: ATLAS-1386: Avoid uunnecessary type cache lookups

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55436/#review162047
---


Ship it!




Thanks for adding the appropriate tests

- Vimal Sharma


On Jan. 12, 2017, 7:21 p.m., Jeff Hagelberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55436/
> ---
> 
> (Updated Jan. 12, 2017, 7:21 p.m.)
> 
> 
> Review request for atlas, David Kantor and Neeru Gupta.
> 
> 
> Bugs: ATLAS-1386
> https://issues.apache.org/jira/browse/ATLAS-1386
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When using the GraphBackedTypeStore, many unnecessary gremlin queries are 
> executed as part of DSL query translated that are for things that cannot 
> possibly be types, for example field names and aliases.  These changes 
> eliminate unnecessary queries and consolidate the type lookup for trait and 
> class types where it makes sense.
> 
> 
> Diffs
> -
> 
>   repository/src/main/scala/org/apache/atlas/query/ClosureQuery.scala 
> 569d3f947e49f205b3d48c7387ee4df39938deff 
>   repository/src/main/scala/org/apache/atlas/query/Expressions.scala 
> ce21a597e79b684eaadc54f208f4a540d402f1b9 
>   repository/src/main/scala/org/apache/atlas/query/QueryParser.scala 
> 42d76c84d48b1e13c3666be8de00fcc3f2bcdea9 
>   repository/src/main/scala/org/apache/atlas/query/QueryProcessor.scala 
> ee95a20a0bdd447d907b21a5d5a0642f4142bade 
>   repository/src/main/scala/org/apache/atlas/query/Resolver.scala 
> 0957c57156381bfae82409a3c88083f564d790e8 
>   repository/src/main/scala/org/apache/atlas/query/TypeUtils.scala 
> dfa7093bec25e8954634af2a3f55f357eb7d46a1 
>   
> repository/src/test/java/org/apache/atlas/discovery/GraphBackedDiscoveryServiceTest.java
>  1217e4af1c8bd63b191025ab9098b16ec0867a4c 
>   repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
> PRE-CREATION 
>   typesystem/src/main/java/org/apache/atlas/typesystem/types/TypeSystem.java 
> 1358159d9cdc6f36f3a34d7946707d329b10f9d3 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> dcb126454b9efc0b50f6835e6dd1371f3e16d359 
> 
> Diff: https://reviews.apache.org/r/55436/diff/
> 
> 
> Testing
> ---
> 
> All Atlas tests run, no regressions found.  There were some tests that failed 
> both with and without these changes.
> 
> 
> Thanks,
> 
> Jeff Hagelberg
> 
>

Re: Review Request 55662: ATLAS-1471: avoid unnecessary overhead in debug log calls

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55662/#review162043
---


Fix it, then Ship it!




This patch handles the files only in module repository. It might be good to 
make similar changes in all modules


repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
<https://reviews.apache.org/r/55662/#comment233295>

Any specific reason for removing @Monitored annotation from these methods


- Vimal Sharma


On Jan. 18, 2017, 5:08 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55662/
> ---
> 
> (Updated Jan. 18, 2017, 5:08 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-1471
> https://issues.apache.org/jira/browse/ATLAS-1471
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Surronding calls to LOG.debug() with "if (LOG.isDebugEnabled())", to avoid 
> unnecessary overhead in debug log calls.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/DeleteHandler.java 
> 74a9cd1 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapper.java
>  7c4bdc1 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepository.java
>  d20e913 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  42a22a8 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> bcdf344 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphToTypedInstanceMapper.java
>  f7b1ff0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/TypedInstanceToGraphMapper.java
>  3d35f36 
> 
> Diff: https://reviews.apache.org/r/55662/diff/
> 
> 
> Testing
> ---
> 
> Verified that all unit tests pass.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

[jira] [Commented] (ATLAS-1472) Atlas went into irrecoverable state after creating 2 tags with same name accidentally.

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827607#comment-15827607
 ] 

Vimal Sharma commented on ATLAS-1472:
-

[~ssainath] Is it an old build. If yes, can you please try with a fresh build

> Atlas went into irrecoverable state after creating 2 tags with same name 
> accidentally.
> --
>
> Key: ATLAS-1472
> URL: https://issues.apache.org/jira/browse/ATLAS-1472
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Sharmadha Sainath
>Priority: Critical
> Attachments: redefine_tag_exception.txt
>
>
> Atlas was slow and while creating a tag , I clicked "create" button twice 
> which created the same tag twice. From then on , no queries are working.
> Attaching the exception stack trace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1472) Atlas went into irrecoverable state after creating 2 tags with same name accidentally.

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15827602#comment-15827602
 ] 

Vimal Sharma commented on ATLAS-1472:
-

[~ssainath] I tried to reproduce the error but Atlas doesn't go into 
irrecoverable state. I get the below exception when trying to create second tag 
with the same name :
{code}
2017-01-18 13:46:26,763 ERROR - [qtp785451259-27 - 
16574858-7c51-496f-8874-5750cd4810c8:] ~ graph rollback due to exception  
(GraphTransactionInterceptor:58)
org.apache.atlas.exception.AtlasBaseException: Given type Sample already exists
at 
org.apache.atlas.repository.store.graph.v1.AtlasClassificationDefStoreV1.preCreate(AtlasClassificationDefStoreV1.java:71)
at 
org.apache.atlas.repository.store.graph.v1.AtlasClassificationDefStoreV1.create(AtlasClassificationDefStoreV1.java:95)
at 
org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.createClassificationDef(AtlasTypeDefGraphStore.java:335)
at 
org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:51)
at 
org.apache.atlas.web.rest.TypesREST.createClassificationDef(TypesREST.java:228)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
at 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
at 
com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
at 
com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
at 
com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
at 
com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
at 
com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)
at 
com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)
at 
com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)
at 
com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)
at 
com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)
at 
org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:77)
at 
com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
at 
com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:120)
at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:135)
at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
at 
org.apache.atlas.web.filters.AtlasAuthorizationFilter.doFilter(AtlasAuthorizationFilter.java:154)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:342)
at 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:118)
at 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:84)
at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain

Re: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release candidate 1 (dev group vote)

[Vimal Sharma]

+1
- Verified the signature and checksum
- Built the package
- Started a single node Atlas with external Hbase and Solr
- Ran QuickStart and inspected basic functionality

Thanks
Vimal





On 1/18/17, 12:42 PM, "Hemanth Yamijala"  wrote:

>Thanks Madhan for looking into the README fix. Appreciate your patience with 
>seeing this through.
>
>I understand fixing the tests is a continuous affair. I am fine covering these 
>later, especially, as I can see the base functionality is fine.
>
>Thanks
>Hemanth
>
>From: Madhan Neethiraj  on behalf of Madhan 
>Neethiraj 
>Sent: Wednesday, January 18, 2017 12:37 PM
>To: dev@atlas.incubator.apache.org
>Subject: Re: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release 
>candidate 1 (dev group vote)
>
>Hemanth,
>
>I will add build instructions in README.txt and create another release 
>candidate shortly. You are right about inconsistent test failures due to 
>timing issues; community is looking into fixing these tests and these will be 
>addressed in subsequent releases.
>
>Thanks,
>Madhan
>
>
>
>On 1/17/17, 10:21 PM, "Hemanth Yamijala"  wrote:
>
>Madhan,
>
>I verified the following:
>
>* SHA/MD5 checksums
>* incubating in release name
>* no binaries in release
>* 3rd party licenses for the JS / CSS files I could identify
>* build from source - a few minor points which I have pointed below. Build 
> compile and package passed fine.
>* single node Atlas instance with HBase and Solr - came up fine.
>* Ran quickstart, browsed the UI - looks fine.
>
>Couple of minor issues:
>
>* The following tests failed: 
> EntityJerseyResourceIT.testDeleteExistentTraitNonExistentForEntity, 
> HiveHookIT.testCreateExternalTable, HiveHookIT.testInsertIntoTempTable. I 
> know the community is working on some timing oriented test failures, and this 
> seems a continuous effort. Given the basic functionality is fine, I think 
> these are red herrings and will ignore them. Rest of the build was fine 
> (including tests)
>
>* For the 0.7.0 release, there was feedback from IPMC to make the build 
> instructions more explicit in the README itself, as opposed to having them 
> only the website. We had filed ATLAS-1000 for this. Although this JIRA is 
> marked for 0.8 release, since we are doing this anyway - maybe better to 
> address it now. (Apologies for not pointing it out earlier - slipped my mind).
>
>Please let me know if you think ATLAS-1000 is worth covering now.
>
>Thanks
>Hemanth
>
>From: Madhan Neethiraj 
>Sent: Tuesday, January 17, 2017 11:57 PM
>To: dev@atlas.incubator.apache.org
>Subject: [VOTE] Release Apache Atlas 0.7.1 (incubating) - release 
> candidate 1 (dev group vote)
>
>Atlas team,
>
>
>
>Apache Atlas 0.7.1 (incubating) release candidate #1 is now available for 
> a vote within dev community.
>
>
>
>Changes since last release-candidate:
>
>-  files/directories that were inadvertently included in the last 
> release candidate were removed. Thanks Hemanth for finding this issue
>
>
>
>Links to the release artifacts are given below. Can you please review and 
> vote?
>
>
>
>The vote will be open for at least 72 hours or until necessary votes are 
> reached.
>
> [ ] +1  approve
>
> [ ] +0  no opinion
>
> [ ] -1  disapprove (and reason why)
>
>
>
>Here is my +1
>
>
>
>Thanks,
>
>Madhan
>
>
>
>
>
>List of issues addressed in this release: 
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Atlas%20AND%20fixVersion%20%3D%200.7.1-incubating%20ORDER%20BY%20key%20DESC
>
>
>
>Git tag for the release: 
> https://github.com/apache/incubator-atlas/tree/release-0.7.1-rc1
>
>
>
>Sources for the release: 
> https://dist.apache.org/repos/dist/dev/incubator/atlas/0.7.1-incubating-rc1/apache-atlas-0.7.1-incubating-sources.tar.gz
>
>
>
>Source release verification:
>
>  PGP Signature: 
> https://dist.apache.org/repos/dist/dev/incubator/atlas/0.7.1-incubating-rc1/apache-atlas-0.7.1-incubating-sources.tar.gz.asc
>
>  MD5 Hash: 
> https://dist.apache.org/repos/dist/dev/incubator/atlas/0.7.1-incubating-rc1/apache-atlas-0.7.1-incubating-sources.tar.gz.mds
>
>
>
>  Keys to verify the signature of the release artifacts are available 
> at: https://dist.apache.org/repos/dist/dev/incubator/atlas/KEYS
>
>
>
>
>
>
>
>
>

Re: Review Request 55588: [ATLAS-1464] Mechanism to include only specified attributes in the notification message during entity create/update/delete operations

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55588/#review161825
---




webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java
 (line 168)
<https://reviews.apache.org/r/55588/#comment233127>

Instead of setting the attribute value to null, why don't we skip the 
attribute altogether. Currently, "someAttribute : null" would be present in the 
notification message which will take up space.


- Vimal Sharma


On Jan. 16, 2017, 7:59 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55588/
> ---
> 
> (Updated Jan. 16, 2017, 7:59 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1464
> https://issues.apache.org/jira/browse/ATLAS-1464
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When entities are created/updated/deleted, a notification message is sent to 
> notification listener informing of the operation and passing the entity 
> object with all its attributes.
> When size of the entity is greater than the max.request.size configured in 
> Kafka, then the entity creation fails with "RecordTooLargeException"
> A property needs to be set in atlas-application.properties to specify list of 
> attributes to be included in the notification message sent to Kafka.
> 
> 
> This patch check for property 
> atlas.notification.entity..attributes.include in 
> atlas-application.properties and if the property exists includes only the 
> attributes listed in notification message
> 
> 
> Diffs
> -
> 
>   
> webapp/src/main/java/org/apache/atlas/notification/NotificationEntityChangeListener.java
>  d10194d 
> 
> Diff: https://reviews.apache.org/r/55588/diff/
> 
> 
> Testing
> ---
> 
> tested using POSTMAN rest client, created hive_db, hive_table and hive_column 
> entities and only the attributes specified were sent in notification message.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

[jira] [Updated] (ATLAS-1460) V2 Search API results don't contain attributes like name, description, owner and Traitslist

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1460:

Attachment: ATLAS-1460.v2.patch

Thanks [~sarath.ku...@gmail.com] for the review.
Updated the patch to address the review comments

> V2 Search API results don't contain attributes like name, description, owner 
> and Traitslist
> ---
>
> Key: ATLAS-1460
> URL: https://issues.apache.org/jira/browse/ATLAS-1460
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1460.patch, ATLAS-1460.v2.patch
>
>
> DSL and FullText Search results don't contain attributes specific to an 
> entity like name, description, owner and list of associated traits



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Review Request 55559: V2 Search API results don't contain attributes like name, description, owner and Traitslist

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---

Review request for atlas.


Bugs: ATLAS-1460
https://issues.apache.org/jira/browse/ATLAS-1460


Repository: atlas


Description
---

DSL and FullText Search results don't contain attributes specific to an entity 
like name, description, owner and list of associated traits


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java bcdf08c 
  intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
c4c0063 
  
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeaderWithAssociations.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
be9fed2 
  
webapp/src/test/java/org/apache/atlas/web/resources/EntityDiscoveryJerseyResourceIT.java
 a576dd0 

Diff: https://reviews.apache.org/r/9/diff/


Testing
---

No new test failures are introduced.


Thanks,

Vimal Sharma

Re: 0.7.1 release of Apache Atlas

[Vimal Sharma]

+1 for the release

Thanks
Vimal




On 1/11/17, 7:29 PM, "Jean-Baptiste Onofré"  wrote:

>Hi Madhan,
>
>I was so late on this, sorry about that. So, please, go ahead.
>
>+1 on my side.
>
>Regards
>JB
>
>On 01/11/2017 08:06 AM, Madhan Neethiraj wrote:
>> Atlas team,
>>
>>
>>
>> About 3 weeks back, I sent a note about updating 0.7 branch with critical 
>> fixes and backports from master branch. Now about 110 commits have gone into 
>> 0.7 branch – here is the link to see the list of JIRAs 
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Atlas%20AND%20fixVersion%20%3D%200.7.1-incubating%20ORDER%20BY%20key%20DESC
>>
>>
>>
>> I propose that we make a release of Apache Atlas from 0.7-incubating branch, 
>> as these commits result in a more stable, performant and secure Apache Atlas.
>>
>>
>>
>> I volunteer to be the release-manager for this release. Please share your 
>> comments and thoughts.
>>
>>
>>
>> Thanks,
>>
>> Madhan
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On 12/22/16, 5:16 PM, "Madhan Neethiraj"  wrote:
>>
>>
>>
>> Team Atlas,
>>
>>
>>
>> A number of fixes went into master branch since we released 0.7 version of 
>> Apache Atlas. Some fixes like ATLAS-1298 are critical to unblock folks from 
>> building from 0.7-incubating branch. ATLAS-1403, which significantly 
>> improves the  performance/stability of DSL queries, would also be a good 
>> candidate to consider; Suma is currently working on this patch.
>>
>>
>>
>> I am going through master commits and backporting as many to 0.7-incubating 
>> branch. You might shortly see a good number of commit notifications from 
>> this backport. If you think any critical fix has been missed in this 
>> backport, please let me know.
>>
>>
>>
>> Thanks,
>>
>> Madhan
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>-- 
>Jean-Baptiste Onofré
>jbono...@apache.org
>http://blog.nanthrax.net
>Talend - http://www.talend.com
>

[jira] [Commented] (ATLAS-1391) Add exclusion mechanism for Atlas audit mechanism

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820327#comment-15820327
 ] 

Vimal Sharma commented on ATLAS-1391:
-

+1 for the new patch

> Add exclusion mechanism for Atlas audit mechanism
> -
>
> Key: ATLAS-1391
> URL: https://issues.apache.org/jira/browse/ATLAS-1391
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Neeru Gupta
>Assignee: Neeru Gupta
> Fix For: 0.8-incubating
>
> Attachments: rb54907(1).patch, rb55227.patch
>
>
> As a consumer of Atlas, I want to be able to exclude certain operations, such 
> as ping, from the audit log so that it does not get filled up with noise.
> This should be a general mechanism. It should be possible to configure the 
> endpoints being excluded in the Atlas configuration file. The only 
> requirement at this time is to be able to filter based on the high level 
> operation being invoked (ie ping, version, etc). There is no need to be able 
> to filter based on the arguments to the operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1280) Atlas changes to support Hive hook for Hive2

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820293#comment-15820293
 ] 

Vimal Sharma commented on ATLAS-1280:
-

+1 for the patch

> Atlas changes to support Hive hook for Hive2
> 
>
> Key: ATLAS-1280
> URL: https://issues.apache.org/jira/browse/ATLAS-1280
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1280-v1.patch, ATLAS-1280.patch
>
>
> Atlas is currently built with Hive version 1.2
> Due to significant changes in Hive2(LLAP), some changes are required in Atlas 
> Hive Hook code to ensure that hook works correctly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55353: Fix for ATLAS-1434.

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55353/#review161354
---




intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java (line 64)
<https://reviews.apache.org/r/55353/#comment232598>

Please change the message to "Only Alphabets, numbers and '_' are allowed. 

"Characters" includes everything!



repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
 (line 1148)
<https://reviews.apache.org/r/55353/#comment232597>

Please add a test for the case where a trait with "." in name is created 
successfully


- Vimal Sharma


On Jan. 9, 2017, 7:46 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55353/
> ---
> 
> (Updated Jan. 9, 2017, 7:46 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1434
> https://issues.apache.org/jira/browse/ATLAS-1434
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Fix for ATLAS-1434. Updated validation for Trait type. Updated error messages 
> to indicate the operation in which the validation failure was encountered.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf 
>   
> repository/src/main/java/org/apache/atlas/services/DefaultMetadataService.java
>  edd12ab 
>   
> repository/src/test/java/org/apache/atlas/service/DefaultMetadataServiceTest.java
>  4b500ff 
> 
> Diff: https://reviews.apache.org/r/55353/diff/
> 
> 
> Testing
> ---
> 
> - Executed unit tests.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Updated] (ATLAS-1280) Atlas changes to support Hive hook for Hive2

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1280:

Attachment: ATLAS-1280-v1.patch

Attaching patch from [~madhan.neethiraj]

> Atlas changes to support Hive hook for Hive2
> 
>
> Key: ATLAS-1280
> URL: https://issues.apache.org/jira/browse/ATLAS-1280
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1280-v1.patch, ATLAS-1280.patch
>
>
> Atlas is currently built with Hive version 1.2
> Due to significant changes in Hive2(LLAP), some changes are required in Atlas 
> Hive Hook code to ensure that hook works correctly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1280) Atlas changes to support Hive hook for Hive2

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1280:

Description: 
Atlas is currently built with Hive version 1.2
Due to significant changes in Hive2(LLAP), some changes are required in Atlas 
Hive Hook code to ensure that hook works correctly

  was:
Atlas is currently built with Hive version 1.2
Due to significant changes in Hive2(LLAP), it might be useful to build Atlas 
using the Hive 2.1.0 release.


> Atlas changes to support Hive hook for Hive2
> 
>
> Key: ATLAS-1280
> URL: https://issues.apache.org/jira/browse/ATLAS-1280
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1280.patch
>
>
> Atlas is currently built with Hive version 1.2
> Due to significant changes in Hive2(LLAP), some changes are required in Atlas 
> Hive Hook code to ensure that hook works correctly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1280) Atlas changes to support Hive hook for Hive2

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1280:

Summary: Atlas changes to support Hive hook for Hive2  (was: Build Atlas 
with Hive2)

> Atlas changes to support Hive hook for Hive2
> 
>
> Key: ATLAS-1280
> URL: https://issues.apache.org/jira/browse/ATLAS-1280
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1280.patch
>
>
> Atlas is currently built with Hive version 1.2
> Due to significant changes in Hive2(LLAP), it might be useful to build Atlas 
> using the Hive 2.1.0 release.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1442) Update pom.xml to change version number to 0.7.1-incubating

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817656#comment-15817656
 ] 

Vimal Sharma commented on ATLAS-1442:
-

+1 for patch

> Update pom.xml to change version number to 0.7.1-incubating
> ---
>
> Key: ATLAS-1442
> URL: https://issues.apache.org/jira/browse/ATLAS-1442
> Project: Atlas
>  Issue Type: Sub-task
>  Components:  atlas-core
>Affects Versions: 0.7.1-incubating
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
> Fix For: 0.7.1-incubating
>
> Attachments: ATLAS-1442.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1396) [V2 API] GET v2/types/{type}/guid/{guid} not working

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1396:

Summary: [V2 API] GET v2/types/{type}/guid/{guid} not working  (was: [V2 
API] GET v2/types/enumdef/guid/{guid}  not working as expected)

> [V2 API] GET v2/types/{type}/guid/{guid} not working
> 
>
> Key: ATLAS-1396
> URL: https://issues.apache.org/jira/browse/ATLAS-1396
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1396.patch
>
>
> POST  v2/types/enumdef
> {
>   "name" : "creation_order1",
>   "typeVersion" : "1.1",
>   "elementDefs" : [
>   {
>   "ordinal" : 1,
>   "value" : "PRE"
>   },
>   {
>   "ordinal" : 2,
>   "value" : "POST"
>   },
>   {
>   "ordinal" : 3,
>   "value" : "UNKNOWN"
>   }
>   ]
> }
> returns the response
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "description": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }
> But GET v2/types/enumdef/guid/c5642d55-9f8e-45b1-b4a9-709c97b46233 returns
> {
>   "errorCode": "ATLAS4042E",
>   "errorMessage": "Given type guid c5642d55-9f8e-45b1-b4a9-709c97b46233 was 
> invalid"
> }
> GET v2/types/enumdef/name/creation_order1  returns
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55358: [ATLAS-1312] Update QuickStart to use the new APIs for type and entities creation

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55358/#review161056
---



What is the need for separate clients for different services like lineage, type 
and entity. This way clients/tests have to create separate instances for 
querying lineage/entity/type and switch between them to get required data.


webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java (line 189)
<https://reviews.apache.org/r/55358/#comment232317>

Remove the print statement


- Vimal Sharma


On Jan. 10, 2017, 1:24 a.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55358/
> ---
> 
> (Updated Jan. 10, 2017, 1:24 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and 
> Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1312
> https://issues.apache.org/jira/browse/ATLAS-1312
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> The quick start currently uses old APIs to create types and entities. This 
> needs to be updated to use the v2 APIs for types and entities.
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasLineageClientV2.java 
> PRE-CREATION 
>   distro/src/bin/quick_start.py 14c8464 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 19553bf 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 
> PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java 
> PRE-CREATION 
>   webapp/src/test/java/org/apache/atlas/web/resources/BaseResourceIT.java 
> dcb1264 
> 
> Diff: https://reviews.apache.org/r/55358/diff/
> 
> 
> Testing
> ---
> 
> Tested using POstman REST Client and new ITs added
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

[jira] [Updated] (ATLAS-1396) [V2 API] GET v2/types/enumdef/guid/{guid} not working as expected

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1396:

Attachment: ATLAS-1396.patch

> [V2 API] GET v2/types/enumdef/guid/{guid}  not working as expected
> --
>
> Key: ATLAS-1396
> URL: https://issues.apache.org/jira/browse/ATLAS-1396
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1396.patch
>
>
> POST  v2/types/enumdef
> {
>   "name" : "creation_order1",
>   "typeVersion" : "1.1",
>   "elementDefs" : [
>   {
>   "ordinal" : 1,
>   "value" : "PRE"
>   },
>   {
>   "ordinal" : 2,
>   "value" : "POST"
>   },
>   {
>   "ordinal" : 3,
>   "value" : "UNKNOWN"
>   }
>   ]
> }
> returns the response
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "description": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }
> But GET v2/types/enumdef/guid/c5642d55-9f8e-45b1-b4a9-709c97b46233 returns
> {
>   "errorCode": "ATLAS4042E",
>   "errorMessage": "Given type guid c5642d55-9f8e-45b1-b4a9-709c97b46233 was 
> invalid"
> }
> GET v2/types/enumdef/name/creation_order1  returns
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1396) [V2 API] GET v2/types/enumdef/guid/{guid} not working as expected

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1396:

Attachment: (was: ATLAS-1396.patch)

> [V2 API] GET v2/types/enumdef/guid/{guid}  not working as expected
> --
>
> Key: ATLAS-1396
> URL: https://issues.apache.org/jira/browse/ATLAS-1396
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
>
> POST  v2/types/enumdef
> {
>   "name" : "creation_order1",
>   "typeVersion" : "1.1",
>   "elementDefs" : [
>   {
>   "ordinal" : 1,
>   "value" : "PRE"
>   },
>   {
>   "ordinal" : 2,
>   "value" : "POST"
>   },
>   {
>   "ordinal" : 3,
>   "value" : "UNKNOWN"
>   }
>   ]
> }
> returns the response
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "description": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }
> But GET v2/types/enumdef/guid/c5642d55-9f8e-45b1-b4a9-709c97b46233 returns
> {
>   "errorCode": "ATLAS4042E",
>   "errorMessage": "Given type guid c5642d55-9f8e-45b1-b4a9-709c97b46233 was 
> invalid"
> }
> GET v2/types/enumdef/name/creation_order1  returns
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1396) [V2 API] GET v2/types/enumdef/guid/{guid} not working as expected

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1396:

Attachment: ATLAS-1396.patch

The same issue as mentioned in the description was occurring for StructType, 
ClassificationType and EntityType as well.

The attached patch fixes the issue. Verified using Postman client

> [V2 API] GET v2/types/enumdef/guid/{guid}  not working as expected
> --
>
> Key: ATLAS-1396
> URL: https://issues.apache.org/jira/browse/ATLAS-1396
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1396.patch
>
>
> POST  v2/types/enumdef
> {
>   "name" : "creation_order1",
>   "typeVersion" : "1.1",
>   "elementDefs" : [
>   {
>   "ordinal" : 1,
>   "value" : "PRE"
>   },
>   {
>   "ordinal" : 2,
>   "value" : "POST"
>   },
>   {
>   "ordinal" : 3,
>   "value" : "UNKNOWN"
>   }
>   ]
> }
> returns the response
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "description": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }
> But GET v2/types/enumdef/guid/c5642d55-9f8e-45b1-b4a9-709c97b46233 returns
> {
>   "errorCode": "ATLAS4042E",
>   "errorMessage": "Given type guid c5642d55-9f8e-45b1-b4a9-709c97b46233 was 
> invalid"
> }
> GET v2/types/enumdef/name/creation_order1  returns
> {
>   "category": "ENUM",
>   "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
>   "createTime": 1481885315377,
>   "updateTime": 1481885315377,
>   "version": 1,
>   "name": "creation_order1",
>   "typeVersion": "1.1",
>   "elementDefs": [
> {
>   "value": "PRE",
>   "ordinal": 1
> },
> {
>   "value": "POST",
>   "ordinal": 2
> },
> {
>   "value": "UNKNOWN",
>   "ordinal": 3
> }
>   ]
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1432) Responsive Loader and css changes

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15814135#comment-15814135
 ] 

Vimal Sharma commented on ATLAS-1432:
-

+1 for the patch

> Responsive Loader and css changes
> -
>
> Key: ATLAS-1432
> URL: https://issues.apache.org/jira/browse/ATLAS-1432
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.7-incubating
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Fix For: 0.7.1-incubating
>
> Attachments: ATLAS-1432.1.patch, ATLAS-1432.patch
>
>
> Showing loader sign for all crud operation of entity,Tag and search to make 
> the user experience smooth. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1435) Include common attributes in the v2 API response

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1435:

Attachment: ATLAS-1435.patch

> Include common attributes in the v2 API response
> 
>
> Key: ATLAS-1435
> URL: https://issues.apache.org/jira/browse/ATLAS-1435
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8-incubating
>    Reporter: Vimal Sharma
>Assignee: Vimal Sharma
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1435.patch
>
>
> Currently attributes like Entity Status, version, created by, modified by, 
> created time, updated time are not present in the GET entity response. These 
> are common attributes across all the entities and should be present in the 
> GET response



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1435) Include common attributes in the v2 API response

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1435:
---

 Summary: Include common attributes in the v2 API response
 Key: ATLAS-1435
 URL: https://issues.apache.org/jira/browse/ATLAS-1435
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8-incubating
Reporter: Vimal Sharma
Assignee: Vimal Sharma
 Fix For: 0.8-incubating


Currently attributes like Entity Status, version, created by, modified by, 
created time, updated time are not present in the GET entity response. These 
are common attributes across all the entities and should be present in the GET 
response



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1427) Support an option to exclude protocols in SSL mode

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15811018#comment-15811018
 ] 

Vimal Sharma commented on ATLAS-1427:
-

+1 for fix for test failures

> Support an option to exclude protocols in SSL mode
> --
>
> Key: ATLAS-1427
> URL: https://issues.apache.org/jira/browse/ATLAS-1427
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.8-incubating
>Reporter: Madhan Neethiraj
>Assignee: Nixon Rodrigues
> Fix For: 0.8-incubating, 0.7.1-incubating
>
> Attachments: ATLAS-1427-0.7-incubating.patch, ATLAS-1427.1.patch, 
> ATLAS-1427.patch
>
>
> Atlas server should support an option to exclude protocols in SSL mode, which 
> can be used to disable less secure protocols like TLSv1, TLSv1.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ATLAS-1427) Support an option to exclude protocols in SSL mode

[Vimal Sharma (JIRA)]

[ 
https://issues.apache.org/jira/browse/ATLAS-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801145#comment-15801145
 ] 

Vimal Sharma commented on ATLAS-1427:
-

+1 for patch

> Support an option to exclude protocols in SSL mode
> --
>
> Key: ATLAS-1427
> URL: https://issues.apache.org/jira/browse/ATLAS-1427
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.8-incubating
>Reporter: Madhan Neethiraj
>Assignee: Nixon Rodrigues
> Fix For: 0.8-incubating
>
> Attachments: ATLAS-1427.patch
>
>
> Atlas server should support an option to exclude protocols in SSL mode, which 
> can be used to disable less secure protocols like TLSv1, TLSv1.1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 54899: Atlas-1401: Document setting up development environment with Eclipse

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54899/#review160479
---


Ship it!




Ship It!

- Vimal Sharma


On Jan. 4, 2017, 9:38 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54899/
> ---
> 
> (Updated Jan. 4, 2017, 9:38 a.m.)
> 
> 
> Review request for atlas and Hemanth Yamijala.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> new file:   docs/src/site/twiki/EclipseSetup.twiki
> 
> 
> Diffs
> -
> 
>   docs/src/site/twiki/EclipseSetup.twiki PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54899/diff/
> 
> 
> Testing
> ---
> 
> Ran the Maven build and check the site content is as expected.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Review Request 54969: Atlas-1412: remove unused file AtlasApiEntities.java

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54969/#review160478
---



File AtlasApiEntities is already deleted from the latest codebase. Can you 
please verify

- Vimal Sharma


On Jan. 4, 2017, 9:39 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54969/
> ---
> 
> (Updated Jan. 4, 2017, 9:39 a.m.)
> 
> 
> Review request for atlas and Apoorv Naik.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> deleted:intg/src/main/java/org/apache/atlas/api/AtlasApiEntities.java
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/api/AtlasApiEntities.java 
> 8eb460488af1f7689a3f5a7deadf7451dcc6b1e5 
> 
> Diff: https://reviews.apache.org/r/54969/diff/
> 
> 
> Testing
> ---
> 
> build compiles successfully.
> 
> 
> Thanks,
> 
> David Radley
> 
>

Re: Column Level Lineage

[Vimal Sharma]

Hi Karthik,
Column level lineage is supported in Atlas for Hive 1.2 version. Which Hive 
version are you using?

If you are using Hive 1.2 version, you would have to apply the patch at 
https://issues.apache.org/jira/browse/HIVE-13112 and re-build Hive to get 
Column level lineage in Atlas.

For Hive2, column level dependency information is not available from Hive due 
to significant changes in APIs. A bug has been filed at 
https://issues.apache.org/jira/browse/HIVE-14706 to track the lineage 
information support in Hive2.

Thanks
Vimal




On 1/2/17, 11:47 AM, "Karthik K"  wrote:

>Team,
>
>Is there anyway to capture column level lineage. Am able to see lineage in
>Table level but when it comes to column always am getting lineage is not
>found.
>
>Thanks & Regards,
>K.Karthikeyan

[jira] [Resolved] (ATLAS-1422) test

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1422.
-
Resolution: Invalid

> test
> 
>
> Key: ATLAS-1422
> URL: https://issues.apache.org/jira/browse/ATLAS-1422
> Project: Atlas
>  Issue Type: Bug
>Reporter: Varsha
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ATLAS-1397) [V2 API] DELETE should return deleted type guid with proper message

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1397.
-
Resolution: Fixed

Thanks Apoorv for clarification. 

> [V2 API] DELETE should return deleted type guid with proper message
> ---
>
> Key: ATLAS-1397
> URL: https://issues.apache.org/jira/browse/ATLAS-1397
> Project: Atlas
>  Issue Type: Improvement
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
>
> POST v2/types/enumdef
> {
> "name" : "creation_order1",
> "typeVersion" : "1.1",
> "elementDefs" : [
> { "ordinal" : 1, "value" : "PRE" }
> ,
> { "ordinal" : 2, "value" : "POST" }
> ,
> { "ordinal" : 3, "value" : "UNKNOWN" }
> ]
> }
> returns the response
> {
> "category": "ENUM",
> "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
> "createTime": 1481885315377,
> "updateTime": 1481885315377,
> "version": 1,
> "name": "creation_order1",
> "description": "creation_order1",
> "typeVersion": "1.1",
> "elementDefs": [
> { "value": "PRE", "ordinal": 1 }
> ,
> { "value": "POST", "ordinal": 2 }
> ,
> { "value": "UNKNOWN", "ordinal": 3 }
> ]
> }
> DELETE v2/types/enumdef/name/creation_order1 is successful but doesn't return 
> anything. DELETE request should return some response in the below format:
> {
> "result" : "SUCCESS/FAIL"
> "guid" : "{guid}"
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ATLAS-1409) Entity creation for a new type

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma resolved ATLAS-1409.
-
Resolution: Not A Bug

Thanks Nixon for the suggestion. Closing as this is not an issue

> Entity creation for a new type
> --
>
> Key: ATLAS-1409
> URL: https://issues.apache.org/jira/browse/ATLAS-1409
> Project: Atlas
>  Issue Type: Bug
>        Reporter: Vimal Sharma
>
> I created a "spark_dataframe" type using POST
> POST /v2/types/entitydef
> {
> "name": "spark_dataframe",
> "superTypes": [
> "DataSet"
> ],
> "typeVersion": "1.0",
> "attributeDefs": [
> {
> "name": "source",
> "typeName": "string",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": false,
> "isUnique": false
> },
> {
> "name": "destination",
> "typeName": "string",
> "cardinality": "SINGLE",
> "isIndexable": false,
> "isOptional": true,
> "isUnique": false
> }
> ]
> }
> But when I try to create an entity using the request
> POST v2/entity/
> {
>   "typeName": "spark_dataframe",
>   "attributes" : {
> "source" : 
> "hdfs://vimal-fenton-4-1.openstacklocal:8020/apps/hive/warehouse/source",
> "destination" : 
> "hdfs://vimal-fenton-4-1.openstacklocal:8020/apps/hive/warehouse/destination"
>   },
>   "classifications": [
> 
>   ]
> }
> The server throws a type not found exception
> 2016-12-21 10:45:44,388 ERROR - [pool-2-thread-4 - 
> b00d8b4a-6ba5-416f-9186-1fff2c9b4e3b:] ~ Exception while getting a typed 
> reference for the entity  (AtlasInstanceRestAdapters:82)
> org.apache.atlas.typesystem.exception.TypeNotFoundException: Unknown 
> datatype: spark_dataframe
>   at 
> org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:192)
>   at 
> org.apache.atlas.repository.graph.GraphHelper.getTypedReferenceableInstance(GraphHelper.java:730)
>   at 
> org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:285)
>   at 
> org.apache.atlas.web.adapters.AtlasInstanceRestAdapters.getITypedReferenceable(AtlasInstanceRestAdapters.java:80)
>   at 
> org.apache.atlas.web.adapters.AtlasInstanceRestAdapters.getITypedReferenceables(AtlasInstanceRestAdapters.java:67)
>   at 
> org.apache.atlas.web.rest.EntityREST.createOrUpdate(EntityREST.java:91)
>   at sun.reflect.GeneratedMethodAccessor150.invoke(Unknown Source)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
>   at 
> com.sun.jersey.spi.container.serv

[jira] [Created] (ATLAS-1409) Entity creation for a new type

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1409:
---

 Summary: Entity creation for a new type
 Key: ATLAS-1409
 URL: https://issues.apache.org/jira/browse/ATLAS-1409
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma


I created a "spark_dataframe" type using POST

POST /v2/types/entitydef
{
"name": "spark_dataframe",
"superTypes": [
"DataSet"
],
"typeVersion": "1.0",
"attributeDefs": [
{
"name": "source",
"typeName": "string",
"cardinality": "SINGLE",
"isIndexable": false,
"isOptional": false,
"isUnique": false
},
{
"name": "destination",
"typeName": "string",
"cardinality": "SINGLE",
"isIndexable": false,
"isOptional": true,
"isUnique": false
}
]
}

But when I try to create an entity using the request
POST v2/entity/

{
  "typeName": "spark_dataframe",
  "attributes" : {
"source" : 
"hdfs://vimal-fenton-4-1.openstacklocal:8020/apps/hive/warehouse/source",
"destination" : 
"hdfs://vimal-fenton-4-1.openstacklocal:8020/apps/hive/warehouse/destination"
  },
  "classifications": [

  ]
}

The server throws a type not found exception

2016-12-21 10:45:44,388 ERROR - [pool-2-thread-4 - 
b00d8b4a-6ba5-416f-9186-1fff2c9b4e3b:] ~ Exception while getting a typed 
reference for the entity  (AtlasInstanceRestAdapters:82)
org.apache.atlas.typesystem.exception.TypeNotFoundException: Unknown datatype: 
spark_dataframe
at 
org.apache.atlas.typesystem.types.TypeSystem.getDataType(TypeSystem.java:192)
at 
org.apache.atlas.repository.graph.GraphHelper.getTypedReferenceableInstance(GraphHelper.java:730)
at 
org.apache.atlas.services.DefaultMetadataService.getTypedReferenceableInstance(DefaultMetadataService.java:285)
at 
org.apache.atlas.web.adapters.AtlasInstanceRestAdapters.getITypedReferenceable(AtlasInstanceRestAdapters.java:80)
at 
org.apache.atlas.web.adapters.AtlasInstanceRestAdapters.getITypedReferenceables(AtlasInstanceRestAdapters.java:67)
at 
org.apache.atlas.web.rest.EntityREST.createOrUpdate(EntityREST.java:91)
at sun.reflect.GeneratedMethodAccessor150.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
at 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
at 
com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
at 
com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
at 
com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
at 
com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
at 
com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
at 
com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:286)
at 
com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:276)
at 
com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:181)
at 
com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)
at 
com.google.inject.servlet.FilterChainInvoc

[jira] [Updated] (ATLAS-1399) [V2 API] PUT /v2/types/structdef/guid/{guid} fails while PUT /v2/types/structdef/name/{structGUID} suceeds

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1399:

Issue Type: Bug  (was: Improvement)

> [V2 API] PUT /v2/types/structdef/guid/{guid} fails while PUT 
> /v2/types/structdef/name/{structGUID} suceeds
> --
>
> Key: ATLAS-1399
> URL: https://issues.apache.org/jira/browse/ATLAS-1399
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Vimal Sharma
>
> For the below JSON
> {
>   "category": "STRUCT",
>   "guid": "9527b5c2-49f7-4e25-bab0-a352d58fc2bf",
>   "createTime": 1481887151201,
>   "updateTime": 1481887819834,
>   "version": 3,
>   "name": "table_creation_order",
>   "description": "table_creation_order",
>   "typeVersion": "1.0",
>   "attributeDefs": [
> {
>   "name": "order",
>   "typeName": "int",
>   "isOptional": false,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 1,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": false
> },
> {
>   "name": "tablename",
>   "typeName": "string",
>   "isOptional": false,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 1,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": false
> },
> {
>   "name": "before_tablename_guid",
>   "typeName": "string",
>   "isOptional": true,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 0,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": false
> },
> {
>   "name": "before_tablename_guid2",
>   "typeName": "string",
>   "isOptional": true,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 0,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": false
> }
>   ]
> }
> PUT /v2/types/structdef/name/{structGUID} succeeds but 
> PUT /v2/types/structdef/guid/9527b5c2-49f7-4e25-bab0-a352d58fc2bf fails with 
> the below exception
> 2016-12-16 11:34:08,381 ERROR - [pool-2-thread-7 - 
> 2d2851fc-caf8-4460-a11e-facb60eeb223:] ~ graph rollback due to exception  
> (GraphTransactionInterceptor:57)
> java.lang.NullPointerException
>   at 
> org.apache.atlas.repository.store.graph.v1.AtlasStructDefStoreV1.updateByGuid(AtlasStructDefStoreV1.java:235)
>   at 
> org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.updateStructDefByGuid(AtlasTypeDefGraphStore.java:283)
>   at 
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
>   at 
> org.apache.atlas.web.rest.TypesREST.updateStructDefByGuid(TypesREST.java:197)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:498)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(Ro

[jira] [Created] (ATLAS-1399) [V2 API] PUT /v2/types/structdef/guid/{guid} fails while PUT /v2/types/structdef/name/{structGUID} suceeds

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1399:
---

 Summary: [V2 API] PUT /v2/types/structdef/guid/{guid} fails while 
PUT /v2/types/structdef/name/{structGUID} suceeds
 Key: ATLAS-1399
 URL: https://issues.apache.org/jira/browse/ATLAS-1399
 Project: Atlas
  Issue Type: Improvement
Reporter: Vimal Sharma


For the below JSON
{
  "category": "STRUCT",
  "guid": "9527b5c2-49f7-4e25-bab0-a352d58fc2bf",
  "createTime": 1481887151201,
  "updateTime": 1481887819834,
  "version": 3,
  "name": "table_creation_order",
  "description": "table_creation_order",
  "typeVersion": "1.0",
  "attributeDefs": [
{
  "name": "order",
  "typeName": "int",
  "isOptional": false,
  "cardinality": "SINGLE",
  "valuesMinCount": 1,
  "valuesMaxCount": 1,
  "isUnique": false,
  "isIndexable": false
},
{
  "name": "tablename",
  "typeName": "string",
  "isOptional": false,
  "cardinality": "SINGLE",
  "valuesMinCount": 1,
  "valuesMaxCount": 1,
  "isUnique": false,
  "isIndexable": false
},
{
  "name": "before_tablename_guid",
  "typeName": "string",
  "isOptional": true,
  "cardinality": "SINGLE",
  "valuesMinCount": 0,
  "valuesMaxCount": 1,
  "isUnique": false,
  "isIndexable": false
},
{
  "name": "before_tablename_guid2",
  "typeName": "string",
  "isOptional": true,
  "cardinality": "SINGLE",
  "valuesMinCount": 0,
  "valuesMaxCount": 1,
  "isUnique": false,
  "isIndexable": false
}
  ]
}

PUT /v2/types/structdef/name/{structGUID} succeeds but 
PUT /v2/types/structdef/guid/9527b5c2-49f7-4e25-bab0-a352d58fc2bf fails with 
the below exception

2016-12-16 11:34:08,381 ERROR - [pool-2-thread-7 - 
2d2851fc-caf8-4460-a11e-facb60eeb223:] ~ graph rollback due to exception  
(GraphTransactionInterceptor:57)
java.lang.NullPointerException
at 
org.apache.atlas.repository.store.graph.v1.AtlasStructDefStoreV1.updateByGuid(AtlasStructDefStoreV1.java:235)
at 
org.apache.atlas.repository.store.graph.AtlasTypeDefGraphStore.updateStructDefByGuid(AtlasTypeDefGraphStore.java:283)
at 
org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:50)
at 
org.apache.atlas.web.rest.TypesREST.updateStructDefByGuid(TypesREST.java:197)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
at 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$TypeOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:185)
at 
com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
at 
com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
at 
com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
at 
com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
at 
com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(Se

[jira] [Created] (ATLAS-1398) POST request for Struct type accepts Enum type in request JSON

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1398:
---

 Summary: POST request for Struct type accepts Enum type in request 
JSON
 Key: ATLAS-1398
 URL: https://issues.apache.org/jira/browse/ATLAS-1398
 Project: Atlas
  Issue Type: Improvement
Reporter: Vimal Sharma


POST  v2/types/structdef
{
"name" : "creation_order2",
"typeVersion" : "1.1",
"elementDefs" : [
{
"ordinal" : 1,
"value" : "PRE"
},
{
"ordinal" : 2,
"value" : "POST"
},
{
"ordinal" : 3,
"value" : "UNKNOWN"
}
]
}

return response
{
  "category": "STRUCT",
  "guid": "63d0755e-8e54-4f5f-9266-fa8d5df20969",
  "createTime": 1481886280574,
  "updateTime": 1481886280574,
  "version": 1,
  "name": "creation_order2",
  "description": "creation_order2",
  "typeVersion": "1.1",
  "attributeDefs": []
}

The response suggests that and empty Struct is created.The POST request should 
not create an empty Struct and should fail with the message "Invalid JSON"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1397) [V2 API] DELETE should return deleted type guid with proper message

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1397:
---

 Summary: [V2 API] DELETE should return deleted type guid with 
proper message
 Key: ATLAS-1397
 URL: https://issues.apache.org/jira/browse/ATLAS-1397
 Project: Atlas
  Issue Type: Improvement
Reporter: Vimal Sharma
Assignee: Vimal Sharma


POST v2/types/enumdef
{
"name" : "creation_order1",
"typeVersion" : "1.1",
"elementDefs" : [
{ "ordinal" : 1, "value" : "PRE" }
,
{ "ordinal" : 2, "value" : "POST" }
,
{ "ordinal" : 3, "value" : "UNKNOWN" }
]
}
returns the response
{
"category": "ENUM",
"guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
"createTime": 1481885315377,
"updateTime": 1481885315377,
"version": 1,
"name": "creation_order1",
"description": "creation_order1",
"typeVersion": "1.1",
"elementDefs": [
{ "value": "PRE", "ordinal": 1 }
,
{ "value": "POST", "ordinal": 2 }
,
{ "value": "UNKNOWN", "ordinal": 3 }
]
}

DELETE v2/types/enumdef/name/creation_order1 is successful but doesn't return 
anything. DELETE request should return some response in the below format:

{
"result" : "SUCCESS/FAIL"
"guid" : "{guid}"
}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ATLAS-1396) [V2 API] GET v2/types/enumdef/guid/{guid} not working as expected

[Vimal Sharma (JIRA)]

Vimal Sharma created ATLAS-1396:
---

 Summary: [V2 API] GET v2/types/enumdef/guid/{guid}  not working as 
expected
 Key: ATLAS-1396
 URL: https://issues.apache.org/jira/browse/ATLAS-1396
 Project: Atlas
  Issue Type: Bug
Reporter: Vimal Sharma
Assignee: Vimal Sharma


POST  v2/types/enumdef
{
"name" : "creation_order1",
"typeVersion" : "1.1",
"elementDefs" : [
{
"ordinal" : 1,
"value" : "PRE"
},
{
"ordinal" : 2,
"value" : "POST"
},
{
"ordinal" : 3,
"value" : "UNKNOWN"
}
]
}

returns the response
{
  "category": "ENUM",
  "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
  "createTime": 1481885315377,
  "updateTime": 1481885315377,
  "version": 1,
  "name": "creation_order1",
  "description": "creation_order1",
  "typeVersion": "1.1",
  "elementDefs": [
{
  "value": "PRE",
  "ordinal": 1
},
{
  "value": "POST",
  "ordinal": 2
},
{
  "value": "UNKNOWN",
  "ordinal": 3
}
  ]
}

But GET v2/types/enumdef/guid/c5642d55-9f8e-45b1-b4a9-709c97b46233 returns
{
  "errorCode": "ATLAS4042E",
  "errorMessage": "Given type guid c5642d55-9f8e-45b1-b4a9-709c97b46233 was 
invalid"
}

GET v2/types/enumdef/name/creation_order1  returns
{
  "category": "ENUM",
  "guid": "c5642d55-9f8e-45b1-b4a9-709c97b46233",
  "createTime": 1481885315377,
  "updateTime": 1481885315377,
  "version": 1,
  "name": "creation_order1",
  "typeVersion": "1.1",
  "elementDefs": [
{
  "value": "PRE",
  "ordinal": 1
},
{
  "value": "POST",
  "ordinal": 2
},
{
  "value": "UNKNOWN",
  "ordinal": 3
}
  ]
}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 53789: [ATLAS-1304] Redundant code removal and code simplification

[Vimal Sharma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53789/#review159262
---


Ship it!




Ship It!

- Vimal Sharma


On Dec. 14, 2016, 8:40 p.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53789/
> ---
> 
> (Updated Dec. 14, 2016, 8:40 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, 
> Suma Shivaprasad, and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1304
> https://issues.apache.org/jira/browse/ATLAS-1304
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Redundant code removal and code simplification
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/event/FalconEvent.java
>  0b918ba0 
>   
> addons/falcon-bridge/src/test/java/org/apache/atlas/falcon/hook/FalconHookIT.java
>  8d0a47a6 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  cbc51cc4 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> cf8851c0 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java
>  79a1afe7 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
> 5abf2dfe 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
>  0cba27ea 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> 23a13ea3 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormTopologyUtil.java
>  edd95ba4 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasActionTypes.java 
> b42162fd 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
> 9c50a040 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasResourceTypes.java
>  e34c7403 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java
>  e48c5ae7 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/FileReaderUtil.java
>  68362491 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyParser.java
>  2a6929a6 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/PolicyUtil.java 
> 9508eb3e 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizer.java
>  57156b78 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyParserTest.java
>  453364d7 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/PolicyUtilTest.java
>  3453bf0e 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/SimpleAtlasAuthorizerTest.java
>  8b27e2ea 
>   catalog/src/main/java/org/apache/atlas/catalog/BaseResourceProvider.java 
> ee9fbba6 
>   catalog/src/main/java/org/apache/atlas/catalog/DefaultTypeSystem.java 
> f111eb61 
>   catalog/src/main/java/org/apache/atlas/catalog/TermVertexWrapper.java 
> d60e3f3c 
>   
> catalog/src/main/java/org/apache/atlas/catalog/definition/TaxonomyResourceDefinition.java
>  47d182cc 
>   catalog/src/main/java/org/apache/atlas/catalog/query/QueryExpression.java 
> 78436c0c 
>   
> catalog/src/test/java/org/apache/atlas/catalog/EntityTagResourceProviderTest.java
>  510378e4 
>   client/src/main/java/org/apache/atlas/AtlasAdminClient.java 63e9213b 
>   client/src/main/java/org/apache/atlas/security/SecureClientUtils.java 
> e13d826e 
>   client/src/test/java/org/apache/atlas/AtlasClientTest.java 3a676891 
>   common/src/main/java/org/apache/atlas/groovy/FunctionCallExpression.java 
> b60edef9 
>   
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java 
> fb32ff55 
>   common/src/main/java/org/apache/atlas/utils/AuthenticationUtil.java 
> bf1175f4 
>   common/src/main/java/org/apache/atlas/utils/PropertiesUtil.java 43569c43 
>   dashboardv2/public/js/views/tag/addTagModalView.js fdaea5bd 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  5d60c678 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  f2e0f9d6 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  39c309d6 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  c205b975 
>

[jira] [Updated] (ATLAS-1366) Documentation for new REST API

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1366:

Attachment: ATLAS-1366.patch

I could create swagger.json using the jaxrs analyzer tool. Thanks a lot 
[~apoorvnaik] for suggesting jaxrs analyzer.

NOTE: jaxrs analyzer tool works only with Java 8. 

Additional changes are required for proper annotation and examples. I will be 
updating this patch accordingly


> Documentation for new REST API
> --
>
> Key: ATLAS-1366
> URL: https://issues.apache.org/jira/browse/ATLAS-1366
> Project: Atlas
>  Issue Type: Improvement
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1366.patch, swagger.json
>
>
> New REST API documentation preferably with Swagger integration



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ATLAS-1366) Documentation for new REST API

[Vimal Sharma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vimal Sharma updated ATLAS-1366:

Attachment: swagger.json

> Documentation for new REST API
> --
>
> Key: ATLAS-1366
> URL: https://issues.apache.org/jira/browse/ATLAS-1366
> Project: Atlas
>  Issue Type: Improvement
>        Reporter: Vimal Sharma
>    Assignee: Vimal Sharma
> Attachments: ATLAS-1366.patch, swagger.json
>
>
> New REST API documentation preferably with Swagger integration



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)