Re: Python 3 reviewers
Oops, sent the email too early. As I was saying, I'm willing to do some sort of early review and hand over to committers to reduce their load. -P. On Thu, Feb 22, 2018, 8:54 PM Holden Karau wrote: > So I've been hesistant to do large chunks of Python 3 reviews for the same > reason I've been hesistant to do large chunks of Python 3 work (on the > commit side seems to move more slowly than the devs), but I suppose that > does become somewhat of a self fulfilling prophecy. I'll dedicate some more > cycles to helping with the reviews :) > > On Fri, Feb 23, 2018 at 1:49 PM, Ahmet Altay wrote: > >> Thank you Holden for doing this work. I agree with Robert's comment. I >> know there are a few folks working on this now (you, @luke-zhu and >> @cclauss). Perhaps you could do python 3 related code reviews within that >> group. I would be happy to chime in and review some chunks as well. >> >> On Thu, Feb 22, 2018 at 4:54 PM, Robert Bradshaw >> wrote: >> >>> I'd really like to see Python 3 support sooner rather than later, and >>> have been reviewing some (simple) PRs in this direction. As long as >>> they're broken up into small enough chunks, feel free to send some my >>> way. >>> >>> On Thu, Feb 22, 2018 at 3:59 PM, Holden Karau >>> wrote: >>> > Hi Y'all, >>> > >>> > I'm trying to make some progress on Python 3 support for Beam but I'm >>> having >>> > a bit of difficulty finding people with review bandwidth. Are there any >>> > committers with time to spare who would be willing to work on this? If >>> not >>> > no worries I'll refocus my efforts elsewhere :) >>> > >>> > Cheers, >>> > >>> > Holden :) >>> > >>> > -- >>> > Twitter: https://twitter.com/holdenkarau >>> >> >> > > > -- > Twitter: https://twitter.com/holdenkarau > -- Got feedback? go/pabloem-feedback
Re: Python 3 reviewers
I'm not a committer, but willing to help review and On Thu, Feb 22, 2018, 8:54 PM Holden Karau wrote: > So I've been hesistant to do large chunks of Python 3 reviews for the same > reason I've been hesistant to do large chunks of Python 3 work (on the > commit side seems to move more slowly than the devs), but I suppose that > does become somewhat of a self fulfilling prophecy. I'll dedicate some more > cycles to helping with the reviews :) > > On Fri, Feb 23, 2018 at 1:49 PM, Ahmet Altay wrote: > >> Thank you Holden for doing this work. I agree with Robert's comment. I >> know there are a few folks working on this now (you, @luke-zhu and >> @cclauss). Perhaps you could do python 3 related code reviews within that >> group. I would be happy to chime in and review some chunks as well. >> >> On Thu, Feb 22, 2018 at 4:54 PM, Robert Bradshaw >> wrote: >> >>> I'd really like to see Python 3 support sooner rather than later, and >>> have been reviewing some (simple) PRs in this direction. As long as >>> they're broken up into small enough chunks, feel free to send some my >>> way. >>> >>> On Thu, Feb 22, 2018 at 3:59 PM, Holden Karau >>> wrote: >>> > Hi Y'all, >>> > >>> > I'm trying to make some progress on Python 3 support for Beam but I'm >>> having >>> > a bit of difficulty finding people with review bandwidth. Are there any >>> > committers with time to spare who would be willing to work on this? If >>> not >>> > no worries I'll refocus my efforts elsewhere :) >>> > >>> > Cheers, >>> > >>> > Holden :) >>> > >>> > -- >>> > Twitter: https://twitter.com/holdenkarau >>> >> >> > > > -- > Twitter: https://twitter.com/holdenkarau > -- Got feedback? go/pabloem-feedback
Re: Python 3 reviewers
So I've been hesistant to do large chunks of Python 3 reviews for the same reason I've been hesistant to do large chunks of Python 3 work (on the commit side seems to move more slowly than the devs), but I suppose that does become somewhat of a self fulfilling prophecy. I'll dedicate some more cycles to helping with the reviews :) On Fri, Feb 23, 2018 at 1:49 PM, Ahmet Altay wrote: > Thank you Holden for doing this work. I agree with Robert's comment. I > know there are a few folks working on this now (you, @luke-zhu and > @cclauss). Perhaps you could do python 3 related code reviews within that > group. I would be happy to chime in and review some chunks as well. > > On Thu, Feb 22, 2018 at 4:54 PM, Robert Bradshaw > wrote: > >> I'd really like to see Python 3 support sooner rather than later, and >> have been reviewing some (simple) PRs in this direction. As long as >> they're broken up into small enough chunks, feel free to send some my >> way. >> >> On Thu, Feb 22, 2018 at 3:59 PM, Holden Karau >> wrote: >> > Hi Y'all, >> > >> > I'm trying to make some progress on Python 3 support for Beam but I'm >> having >> > a bit of difficulty finding people with review bandwidth. Are there any >> > committers with time to spare who would be willing to work on this? If >> not >> > no worries I'll refocus my efforts elsewhere :) >> > >> > Cheers, >> > >> > Holden :) >> > >> > -- >> > Twitter: https://twitter.com/holdenkarau >> > > -- Twitter: https://twitter.com/holdenkarau
Re: Python 3 reviewers
Thank you Holden for doing this work. I agree with Robert's comment. I know there are a few folks working on this now (you, @luke-zhu and @cclauss). Perhaps you could do python 3 related code reviews within that group. I would be happy to chime in and review some chunks as well. On Thu, Feb 22, 2018 at 4:54 PM, Robert Bradshaw wrote: > I'd really like to see Python 3 support sooner rather than later, and > have been reviewing some (simple) PRs in this direction. As long as > they're broken up into small enough chunks, feel free to send some my > way. > > On Thu, Feb 22, 2018 at 3:59 PM, Holden Karau > wrote: > > Hi Y'all, > > > > I'm trying to make some progress on Python 3 support for Beam but I'm > having > > a bit of difficulty finding people with review bandwidth. Are there any > > committers with time to spare who would be willing to work on this? If > not > > no worries I'll refocus my efforts elsewhere :) > > > > Cheers, > > > > Holden :) > > > > -- > > Twitter: https://twitter.com/holdenkarau >
Re: Python 3 reviewers
I'd really like to see Python 3 support sooner rather than later, and have been reviewing some (simple) PRs in this direction. As long as they're broken up into small enough chunks, feel free to send some my way. On Thu, Feb 22, 2018 at 3:59 PM, Holden Karau wrote: > Hi Y'all, > > I'm trying to make some progress on Python 3 support for Beam but I'm having > a bit of difficulty finding people with review bandwidth. Are there any > committers with time to spare who would be willing to work on this? If not > no worries I'll refocus my efforts elsewhere :) > > Cheers, > > Holden :) > > -- > Twitter: https://twitter.com/holdenkarau