Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Stamatis Zampetakis]

Regarding the problem with the build unfortunately I didn't take any dumps
(I was in a rush sorry). It could be the same problem reported in
CALCITE-3581. If it appears again, I will log a new issue.

Best,
Stamatis

[1] https://issues.apache.org/jira/browse/CALCITE-3581

On Thu, Mar 5, 2020 at 2:51 AM Chunwei Lei  wrote:

> +1 (non-binding)
>
> macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4
>  * Went over release note OK
>  * Run Calcite tests OK
> * Checked signatures and checksums OK
>
>
> Best,
> Chunwei
>
>
> On Wed, Mar 4, 2020 at 2:50 PM Vladimir Sitnikov <
> sitnikov.vladi...@gmail.com> wrote:
>
> > Stamatis>It is worth mentioning that the build passed with the 3rd
> attempt.
> > In the
> > Stamatis>first attempts the build was stuck while performing style
> > checking.
> >
> > Do you have threaddumps?
> > Have you filed JIRA for the locking?
> >
> > Vladimir
> >
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Chunwei Lei]

+1 (non-binding)

macOS 10.14.6, jdk 1.8.0_151, maven 3.5.4
 * Went over release note OK
 * Run Calcite tests OK
* Checked signatures and checksums OK


Best,
Chunwei


On Wed, Mar 4, 2020 at 2:50 PM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:

> Stamatis>It is worth mentioning that the build passed with the 3rd attempt.
> In the
> Stamatis>first attempts the build was stuck while performing style
> checking.
>
> Do you have threaddumps?
> Have you filed JIRA for the locking?
>
> Vladimir
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Vladimir Sitnikov]

Stamatis>It is worth mentioning that the build passed with the 3rd attempt.
In the
Stamatis>first attempts the build was stuck while performing style checking.

Do you have threaddumps?
Have you filed JIRA for the locking?

Vladimir

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Danny Chan]

I also agree that some commit messages are not that clear.

But, I what to make cleat that: keeping the commit message understandable is 
the duty of the code reviewer, if the commit message is problematic, how could 
the code be merged.

It is so hard to re-think what these commits really do because long time passes 
and there are 260+ commits, how could a release manager to keep every commit 
message “readable”.

So I would just ignore that ~

Best,
Danny Chan
在 2020年3月4日 +0800 AM7:20，Stamatis Zampetakis ，写道：
> Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper
>
> * Checked signatures and checksums OK
> * Build and run unit tests (./gradlew clean build) on git repo and staged
> sources OK
> It is worth mentioning that the build passed with the 3rd attempt. In the
> first attempts the build was stuck while performing style checking. I
> assume there is somewhere a race condition coming from the fact that I have
> many cores available on my machine (Intel Core i7-8850H) and the
> multi-threaded Gradle build.
> * Run slow tests on git repo (./gradlew testSlow) OK
> By the way on my machine the slow tests run in 7 minutes which is quite
> impressive and I think comes mostly from Vladimir's effort of enabling
> parallel execution and other improvements.
> * Checked diff between git commit and staged sources OK
> Small differences in the license structure but I brought this before and
> there does not seem to be a problem.
> * Went over the release note OK
> I outline at the end of this email a few minor remarks regarding the
> release notes.
>
> A big thanks to Danny for being the release manager and for also fixing the
> various problems that we encountered in the previous release candidates!
> Another big thanks to all those who tested this, and the previous RCs,
> against downstream projects. Ideally, we should be able to detect
> regressions before the RC phase but in any case it is better late than
> ever.
>
> I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
> shooted down release candidates for less obvious reasons. I think we are
> lowering a bit our standards biased from the fact that we didn't have a
> release for quite some time. Anyways, I don't see CALCITE-3839 as a
> critical bug so I am fine with having another release rather soon.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> * The release date should be updated after the to reflect the actual
> release date.
> * Should we really mention that the release has been tested with Apache
> Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
> tried to do it a few weeks ago but I had a few problems with setting up the
> VM in calcite-test-dataset.
> * I was under the impression that the Hint API would be experimental for
> some time but it seems in the end it was decided not to do so. I am not
> against it but I am just mentioning it to be sure that we are all in the
> same page.
>
> Below a few comments (nitpicking) for the following commits (entries of the
> release note).
> I am not saying that we should go and change everything now but as Julian
> mentioned in another email we should try to be more pedantic with the
> commit messages since they become our release notes (and should be
> understandable by end-users).
>
> [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
> (Shlok Srivastava)
> > The use of period could be avoided: Support MatchQuery in ElasticSearch
> adapter
> [CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> > The message is not self-contained. Not sure if it is a bug or feature, or
> in general what has changed.
> Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> > Should we capitalize HSQLDB?
> [CALCITE-3606] Derive target table column list by mistake when convert
> TableModify to Sql string (JinXing)
> > The message is not clear.
> [CALCITE-3630] Improve ReduceExpressionsRule
> > The message is too general. What is the improvement?
> [CALCITE-3246] NullPointerException while deserializing udf operator (Wang
> Yanlin).
> > We do not use periods at the first line of the commit message nor at the
> summary of the JIRA.
> [CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
> implementation of nested loop join that, unlike the existing one, does not
> require to build the complete result as a list before returning it.
> Instead, it iterates through the outer and inner enumerables and returns
> the results step by step.
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
> (Jin Xing)
> > This change has been reverted (and the JIRA has been reopened) so it
> shouldn't appear in the release notes.
> [CALCITE-3479] Stack overflow error thrown when running join queryi
> (Xiening Dai)
> > Typo queryi -> query and a bit general description. Every join query
> leads to stack overflow?
> 

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Danny Chan]

Thanks Julian and Stamatis, would fix the release note though ~

Best,
Danny Chan
在 2020年3月4日 +0800 AM7:20，Stamatis Zampetakis ，写道：
> Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper
>
> * Checked signatures and checksums OK
> * Build and run unit tests (./gradlew clean build) on git repo and staged
> sources OK
> It is worth mentioning that the build passed with the 3rd attempt. In the
> first attempts the build was stuck while performing style checking. I
> assume there is somewhere a race condition coming from the fact that I have
> many cores available on my machine (Intel Core i7-8850H) and the
> multi-threaded Gradle build.
> * Run slow tests on git repo (./gradlew testSlow) OK
> By the way on my machine the slow tests run in 7 minutes which is quite
> impressive and I think comes mostly from Vladimir's effort of enabling
> parallel execution and other improvements.
> * Checked diff between git commit and staged sources OK
> Small differences in the license structure but I brought this before and
> there does not seem to be a problem.
> * Went over the release note OK
> I outline at the end of this email a few minor remarks regarding the
> release notes.
>
> A big thanks to Danny for being the release manager and for also fixing the
> various problems that we encountered in the previous release candidates!
> Another big thanks to all those who tested this, and the previous RCs,
> against downstream projects. Ideally, we should be able to detect
> regressions before the RC phase but in any case it is better late than
> ever.
>
> I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
> shooted down release candidates for less obvious reasons. I think we are
> lowering a bit our standards biased from the fact that we didn't have a
> release for quite some time. Anyways, I don't see CALCITE-3839 as a
> critical bug so I am fine with having another release rather soon.
>
> 0 (binding)
>
> Best,
> Stamatis
>
> * The release date should be updated after the to reflect the actual
> release date.
> * Should we really mention that the release has been tested with Apache
> Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
> tried to do it a few weeks ago but I had a few problems with setting up the
> VM in calcite-test-dataset.
> * I was under the impression that the Hint API would be experimental for
> some time but it seems in the end it was decided not to do so. I am not
> against it but I am just mentioning it to be sure that we are all in the
> same page.
>
> Below a few comments (nitpicking) for the following commits (entries of the
> release note).
> I am not saying that we should go and change everything now but as Julian
> mentioned in another email we should try to be more pedantic with the
> commit messages since they become our release notes (and should be
> understandable by end-users).
>
> [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
> (Shlok Srivastava)
> > The use of period could be avoided: Support MatchQuery in ElasticSearch
> adapter
> [CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> > The message is not self-contained. Not sure if it is a bug or feature, or
> in general what has changed.
> Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> > Should we capitalize HSQLDB?
> [CALCITE-3606] Derive target table column list by mistake when convert
> TableModify to Sql string (JinXing)
> > The message is not clear.
> [CALCITE-3630] Improve ReduceExpressionsRule
> > The message is too general. What is the improvement?
> [CALCITE-3246] NullPointerException while deserializing udf operator (Wang
> Yanlin).
> > We do not use periods at the first line of the commit message nor at the
> summary of the JIRA.
> [CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
> implementation of nested loop join that, unlike the existing one, does not
> require to build the complete result as a list before returning it.
> Instead, it iterates through the outer and inner enumerables and returns
> the results step by step.
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
> (Jin Xing)
> > This change has been reverted (and the JIRA has been reopened) so it
> shouldn't appear in the release notes.
> [CALCITE-3479] Stack overflow error thrown when running join queryi
> (Xiening Dai)
> > Typo queryi -> query and a bit general description. Every join query
> leads to stack overflow?
> [CALCITE-3376] VolcanoPlanner CannotPlanException: best rel is null even
> though there is an option with non-infinite cost Problem solved via
> CALCITE-2018, just add a unit test for this specific scenario
> > Very long entry. Seems like a copy-edit problem or bug in the script
> generating the release notes.
> [CALCITE-3383] Plural time units
> > The message is not self-contained. 

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Stamatis Zampetakis]

Ubuntu 18.04.4 LTS, jdk 1.8.0_212, Gradle wrapper

* Checked signatures and checksums OK
* Build and run unit tests (./gradlew clean build) on git repo and staged
sources OK
It is worth mentioning that the build passed with the 3rd attempt. In the
first attempts the build was stuck while performing style checking. I
assume there is somewhere a race condition coming from the fact that I have
many cores available on my machine (Intel Core i7-8850H) and the
multi-threaded Gradle build.
* Run slow tests on git repo (./gradlew testSlow) OK
By the way on my machine the slow tests run in 7 minutes which is quite
impressive and I think comes mostly from Vladimir's effort of enabling
parallel execution and other improvements.
* Checked diff between git commit and staged sources OK
Small differences in the license structure but I brought this before and
there does not seem to be a problem.
* Went over the release note OK
I outline at the end of this email a few minor remarks regarding the
release notes.

A big thanks to Danny for being the release manager and for also fixing the
various problems that we encountered in the previous release candidates!
Another big thanks to all those who tested this, and the previous RCs,
against downstream projects. Ideally, we should be able to detect
regressions before the RC phase but in any case it is better late than
ever.

I cannot give a +1 vote due to CALCITE-3839 and given that in the past we
shooted down release candidates for less obvious reasons. I think we are
lowering a bit our standards biased from the fact that we didn't have a
release for quite some time. Anyways, I don't see CALCITE-3839 as a
critical bug so I am fine with having another release rather soon.

0 (binding)

Best,
Stamatis

* The release date should be updated after the to reflect the actual
release date.
* Should we really mention that the release has been tested with Apache
Druid version 0.14.0-incubating? Did anybody run the tests against Druid? I
tried to do it a few weeks ago but I had a few problems with setting up the
VM in calcite-test-dataset.
* I was under the impression that the Hint API would be experimental for
some time but it seems in the end it was decided not to do so. I am not
against it but I am just mentioning it to be sure that we are all in the
same page.

Below a few comments (nitpicking) for the following commits (entries of the
release note).
I am not saying that we should go and change everything now but as Julian
mentioned in another email we should try to be more pedantic with the
commit messages since they become our release notes (and should be
understandable by end-users).

[CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticsearch
(Shlok Srivastava)
> The use of period could be avoided: Support MatchQuery in ElasticSearch
adapter
[CALCITE-3434] ElasticSearch schema with pathPrefix (Jeffery Zhang)
> The message is not self-contained. Not sure if it is a bug or feature, or
in general what has changed.
Add hsqldb data sets (scott, foodmart and chinook) to SQLLine's path
> Should we capitalize HSQLDB?
[CALCITE-3606] Derive target table column list by mistake when convert
TableModify to Sql string (JinXing)
> The message is not clear.
[CALCITE-3630] Improve ReduceExpressionsRule
> The message is too general. What is the improvement?
[CALCITE-3246] NullPointerException while deserializing udf operator (Wang
Yanlin).
> We do not use periods at the first line of the commit message nor at the
summary of the JIRA.
[CALCITE-3546] Improve EnumerableDefaults nested loop join Provide a new
implementation of nested loop join that, unlike the existing one, does not
require to build the complete result as a list before returning it.
Instead, it iterates through the outer and inner enumerables and returns
the results step by step.
> Very long entry. Seems like a copy-edit problem or bug in the script
generating the release notes.
[CALCITE-3285] EnumerableMergeJoin should support non-equi join condions
(Jin Xing)
> This change has been reverted (and the JIRA has been reopened) so it
shouldn't appear in the release notes.
[CALCITE-3479] Stack overflow error thrown when running join queryi
(Xiening Dai)
> Typo queryi -> query and a bit general description. Every join query
leads to stack overflow?
[CALCITE-3376] VolcanoPlanner CannotPlanException: best rel is null even
though there is an option with non-infinite cost Problem solved via
CALCITE-2018, just add a unit test for this specific scenario
> Very long entry. Seems like a copy-edit problem or bug in the script
generating the release notes.
[CALCITE-3383] Plural time units
> The message is not self-contained. Cannot understand what happend without
looking in the diff or in the JIRA issue.
[CALCITE-3389] Test may fail if HashSet iterates in different order
(contextshuffling)
> Which test?
[CALCITE-3381] When using BigQuery dialect, Rel2SQL converter converts SQL
types to BigQuery types (Rui Wang)
> The message is not 

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Ruben Q L]

 +1 (non binding)
Local Calcite build with tests (Windows10 + JDK8): OK
Calcite-based application test suite: OK



Le mar. 3 mars 2020 à 11:11, Enrico Olivelli  a écrit :

> +1 (non binding)
> Run tests locally (on Mac + JDK13)
> Run tests of HerdDB and a bunch of know applications that are using HerdDB
>
> Thank you Danny
>
> Enrico
>
> Il giorno mar 3 mar 2020 alle ore 11:06 Feng Zhu
>  ha scritto:
> >
> > Hi Danny, thanks for your continuous effort!
> >
> > +1 (non-binding)
> >
> > - Build and Test (./gradlew build) - OK
> > - Checked Release Notes - OK
> > - Checked README - OK
> > - Validate gpg signature - OK
> > Environment 1: Windows 7, JDK 1.8.0_121
> > Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11
> >
> > Bests,
> > Feng
> >
> > Danny Chan  于2020年3月2日周一 下午9:28写道：
> >
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.22.0, release
> > > candidate 3.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/v1.22.0-rc3
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > > (revision 38350)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > >
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > > *apache-calcite-1.22.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > >
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/danny0405.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > N.B.
> > > To create the jars and test Apache Calcite: "./gradlew build".
> > >
> > > If you do not have a Java environment available, you can run the tests
> > > using docker. To do so, install docker and docker-compose, then run
> > > "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite 1.22.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.22.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Best,
> > > Danny Chan
> > >
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Enrico Olivelli]

+1 (non binding)
Run tests locally (on Mac + JDK13)
Run tests of HerdDB and a bunch of know applications that are using HerdDB

Thank you Danny

Enrico

Il giorno mar 3 mar 2020 alle ore 11:06 Feng Zhu
 ha scritto:
>
> Hi Danny, thanks for your continuous effort!
>
> +1 (non-binding)
>
> - Build and Test (./gradlew build) - OK
> - Checked Release Notes - OK
> - Checked README - OK
> - Validate gpg signature - OK
> Environment 1: Windows 7, JDK 1.8.0_121
> Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11
>
> Bests,
> Feng
>
> Danny Chan  于2020年3月2日周一 下午9:28写道：
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.22.0, release
> > candidate 3.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Tag:
> > https://github.com/apache/calcite/tree/v1.22.0-rc3
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > (revision 38350)
> >
> > The hashes of the artifacts are as follows:
> >
> > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > *apache-calcite-1.22.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/danny0405.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.22.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.22.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Best,
> > Danny Chan
> >

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Feng Zhu]

Hi Danny, thanks for your continuous effort!

+1 (non-binding)

- Build and Test (./gradlew build) - OK
- Checked Release Notes - OK
- Checked README - OK
- Validate gpg signature - OK
Environment 1: Windows 7, JDK 1.8.0_121
Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11

Bests,
Feng

Danny Chan  于2020年3月2日周一 下午9:28写道：

> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release
> candidate 3.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Tag:
> https://github.com/apache/calcite/tree/v1.22.0-rc3
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> (revision 38350)
>
> The hashes of the artifacts are as follows:
>
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
> https://www.apache.org/dist/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Anton Haidai]

While it is not a part of our daily CI, we are taking measures to detect
Calcite's regressions early, including several preliminary integrations
with Calcite's master between Calcite's releases.
Let me once again highlight that this unfortunate situation with the late
detection of CALCITE-3839
 was caused by an
unlucky timing of our new feature merge and not by a lack of CI.

On Tue, Mar 3, 2020 at 3:49 AM Francis Chuang 
wrote:

> On 3/03/2020 12:31 pm, Julian Hyde wrote:
> > We can discuss the proposal to add other products' test suites to CI.
> > I think it would cause more work for us (triaging false-negative
> > problems). And lots of important downstream projects do not have a
> > public test suite.
>
> Apologies for not being clearer, the comment regarding testing against
> Calcite master in CI daily was directed towards Anton.
>
> It would not be practical for Calcite to run test suites for all of its
> consumers. Consumers should be proactive in testing against our master
> to detect regressions and breaking changes.
>


-- 
Best regards,
Anton.

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Francis Chuang]

On 3/03/2020 12:31 pm, Julian Hyde wrote:

We can discuss the proposal to add other products' test suites to CI.
I think it would cause more work for us (triaging false-negative
problems). And lots of important downstream projects do not have a
public test suite.


Apologies for not being clearer, the comment regarding testing against 
Calcite master in CI daily was directed towards Anton.


It would not be practical for Calcite to run test suites for all of its 
consumers. Consumers should be proactive in testing against our master 
to detect regressions and breaking changes.

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Julian Hyde]

+1 (binding)

I downloaded, checked LICENSE, NOTICE, copyright dates, built & ran
tests using JDK 13 on Ubuntu Linux.

Release notes need some work:
* Back-quotes around keywords and identifiers,
* capitalize SQL keywords,
* add brackets around JIRA cases,
* wrap lines to ~80,
* remove raw HTML characters (e.g. '->') and smart quotes;
* there are so many items that it would be useful to group into
subject areas (I would remove the 'Adapters' section and put some of
its items in 'New features' and some items in an 'Adapters' or 'JDBC
adapter' section of 'Bug fixes' section);
* "adaptors" should be spelled "adapters";
* "migrate build scripts to gradle" should be in "build and test" section;
* there are several "minor enhancements" for hints that should all be
under the "hints" feature.

I don't think we provided user documentation for hints. The need
documentation; maybe in reference.md.

I take Francis' point that this release process has gone on too long.
Therefore I am not voting -1 due to 3839, even though I think people
are fairly likely to hit it. But if there is an RC4 I would like to
include fixes for 3839 and 3412.

We can discuss the proposal to add other products' test suites to CI.
I think it would cause more work for us (triaging false-negative
problems). And lots of important downstream projects do not have a
public test suite.

Julian

On Mon, Mar 2, 2020 at 2:33 PM Rui Wang  wrote:
>
> +1 (non-binding)
>
> - check sha512 OK
> - check gpg signature OK (last timely I forgot to import calcite KEYS
> locally, sorry about that)
> - ./gradlew build OK
> - check the rc3 tag with right commit OK
> - compare git tag files with files extracted from artifacts, There is a
> difference about LICENSE file. Also the artifact has one extra "licenses"
> directory . By reading the diff I think it is still OK. (Also it should be
> a known case that appeared in a past release)
> - Tested the artifact with Apache Beam. There are breaks but none is
> regression (e.g. break due to some API evolutions, which is
> understandable). OK
>
>
> -Rui
>
>
>
>
> On Mon, Mar 2, 2020 at 2:10 PM Francis Chuang 
> wrote:
>
> > My vote is +1 (binding)
> >
> > Thanks for making this rc available for voting, Danny!
> >
> > Checked GPG signature - OK
> > Checked hash - OK
> > Ran tests per HOWTO (./gradlew check) - OK
> > Release notes (quick skim) - OK
> > Maven artifacts (spot checked a few files on nexus) - OK
> >
> > Environment (gradle:latest docker container):
> > Gradle 6.1.1 (via gradlew)
> > Ubuntu 18.04.4 LTS
> > openjdk version "1.8.0_232"
> > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
> > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)
> >
> > Great work, Danny!
> >
> > My reasons for voting +1:
> > - This release is overdue and since we are at rc3 already, this is
> > probably causing the RM a lot of release fatigue. I've been RM for a few
> > releases where a lot of RCs were created and it's discouraging to have
> > another rc rejected and having to go back and build another one.
> >
> > - This is a pretty big release and there endless improvements and bugs
> > that can be added to this release. We should get this release out and
> > aim for the next release to clean up these regressions.
> >
> > - CALCITE-3839 is a regression, but as this release is already quite
> > delayed and we are planning to make the next release (1.23.0) available
> > soon after this release, it's possible to skip this release and wait for
> > the next one.
> >
> > - I'd suggest adding a daily job in CI that integrates with Calcite
> > master to catch regressions such as CALCITE-3839.
> >
> >
> > On 3/03/2020 12:28 am, Danny Chan wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.22.0, release
> > > candidate 3.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/v1.22.0-rc3
> > >
> > > The artifacts to be voted on are located here:
> > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > > (revision 38350)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > > *apache-calcite-1.22.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/danny0405.asc
> > > 

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Rui Wang]

+1 (non-binding)

- check sha512 OK
- check gpg signature OK (last timely I forgot to import calcite KEYS
locally, sorry about that)
- ./gradlew build OK
- check the rc3 tag with right commit OK
- compare git tag files with files extracted from artifacts, There is a
difference about LICENSE file. Also the artifact has one extra "licenses"
directory . By reading the diff I think it is still OK. (Also it should be
a known case that appeared in a past release)
- Tested the artifact with Apache Beam. There are breaks but none is
regression (e.g. break due to some API evolutions, which is
understandable). OK


-Rui




On Mon, Mar 2, 2020 at 2:10 PM Francis Chuang 
wrote:

> My vote is +1 (binding)
>
> Thanks for making this rc available for voting, Danny!
>
> Checked GPG signature - OK
> Checked hash - OK
> Ran tests per HOWTO (./gradlew check) - OK
> Release notes (quick skim) - OK
> Maven artifacts (spot checked a few files on nexus) - OK
>
> Environment (gradle:latest docker container):
> Gradle 6.1.1 (via gradlew)
> Ubuntu 18.04.4 LTS
> openjdk version "1.8.0_232"
> OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
> OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)
>
> Great work, Danny!
>
> My reasons for voting +1:
> - This release is overdue and since we are at rc3 already, this is
> probably causing the RM a lot of release fatigue. I've been RM for a few
> releases where a lot of RCs were created and it's discouraging to have
> another rc rejected and having to go back and build another one.
>
> - This is a pretty big release and there endless improvements and bugs
> that can be added to this release. We should get this release out and
> aim for the next release to clean up these regressions.
>
> - CALCITE-3839 is a regression, but as this release is already quite
> delayed and we are planning to make the next release (1.23.0) available
> soon after this release, it's possible to skip this release and wait for
> the next one.
>
> - I'd suggest adding a daily job in CI that integrates with Calcite
> master to catch regressions such as CALCITE-3839.
>
>
> On 3/03/2020 12:28 am, Danny Chan wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.22.0, release
> > candidate 3.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Tag:
> > https://github.com/apache/calcite/tree/v1.22.0-rc3
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > (revision 38350)
> >
> > The hashes of the artifacts are as follows:
> >
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > *apache-calcite-1.22.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/danny0405.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.22.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.22.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Best,
> > Danny Chan
> >
>

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Francis Chuang]

My vote is +1 (binding)

Thanks for making this rc available for voting, Danny!

Checked GPG signature - OK
Checked hash - OK
Ran tests per HOWTO (./gradlew check) - OK
Release notes (quick skim) - OK
Maven artifacts (spot checked a few files on nexus) - OK

Environment (gradle:latest docker container):
Gradle 6.1.1 (via gradlew)
Ubuntu 18.04.4 LTS
openjdk version "1.8.0_232"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_232-b09)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.232-b09, mixed mode)

Great work, Danny!

My reasons for voting +1:
- This release is overdue and since we are at rc3 already, this is 
probably causing the RM a lot of release fatigue. I've been RM for a few 
releases where a lot of RCs were created and it's discouraging to have 
another rc rejected and having to go back and build another one.


- This is a pretty big release and there endless improvements and bugs 
that can be added to this release. We should get this release out and 
aim for the next release to clean up these regressions.


- CALCITE-3839 is a regression, but as this release is already quite 
delayed and we are planning to make the next release (1.23.0) available 
soon after this release, it's possible to skip this release and wait for 
the next one.


- I'd suggest adding a daily job in CI that integrates with Calcite 
master to catch regressions such as CALCITE-3839.



On 3/03/2020 12:28 am, Danny Chan wrote:

Hi all,

I have created a build for Apache Calcite 1.22.0, release
candidate 3.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff

Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff

Tag:
https://github.com/apache/calcite/tree/v1.22.0-rc3

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
(revision 38350)

The hashes of the artifacts are as follows:
a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
*apache-calcite-1.22.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/danny0405.asc
https://www.apache.org/dist/calcite/KEYS

N.B.
To create the jars and test Apache Calcite: "./gradlew build".

If you do not have a Java environment available, you can run the tests
using docker. To do so, install docker and docker-compose, then run
"docker-compose run test" from the root of the directory.

Please vote on releasing this package as Apache Calcite 1.22.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.22.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Best,
Danny Chan

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Vladimir Sitnikov]

Danny>I have created a build for Apache Calcite 1.22.0, release
Danny>candidate 3.

Great.
Checksums, pgp match.

tests pass (modulo known issues like OsAdapterTest), mat-calcite-tests pass

So +1 (binding)

There's an issue that -Prc=.. parameter is always required for building a
release version.
However, it can be resolved after making the release by bumping release
plugins (the fix is already published).

Vladimir

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Julian Hyde]

On Mon, Mar 2, 2020 at 11:43 AM Anton Haidai  wrote:
>
> Sorry for reporting the bug too late, but the test that detected it was
> related to a new feature of our system finalized just days ago so the right
> test was not there when I voted on RC1.

Ah, makes sense.

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Anton Haidai]

Sorry for reporting the bug too late, but the test that detected it was
related to a new feature of our system finalized just days ago so the right
test was not there when I voted on RC1.

On Mon, 2 Mar 2020 at 21:13, Vladimir Sitnikov 
wrote:

> Julian>Can we keep it consistent please?
>
> It's good to find bugs like this, but it's depressing to only be
> finding them in RC3.
>
> Frankly speaking, I find it too much repetition to have calcite- in a
> version name.
> We do not have Avatica in the repository, so why should we have long
> versions like calcite-...-...--.. ?
>
> >It's good to find bugs like this, but it's depressing to only be
> >finding them in RC3
>
> I think the approach here is:
> 1) Integrate the checks (e.g. Zoomdata) to PR CI and/or to daily CI job
> 2) Ensure that the vote email contains the exact sequence of commands to
> validate the release. For instance: download, verify checksum, verify pgp,
> unzip, build, test, etc, etc. The sequence can easily be automated, and I
> don't really see much point in everybody doing those checks manually.
>
> Note: the current release archive is reproducible. That means everybody who
> creates the release archive should end up with exactly the same file.
>
> Vladimir
>
-- 
Best regards,
Anton.

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Vladimir Sitnikov]

Julian>Can we keep it consistent please?

It's good to find bugs like this, but it's depressing to only be
finding them in RC3.

Frankly speaking, I find it too much repetition to have calcite- in a
version name.
We do not have Avatica in the repository, so why should we have long
versions like calcite-...-...--.. ?

>It's good to find bugs like this, but it's depressing to only be
>finding them in RC3

I think the approach here is:
1) Integrate the checks (e.g. Zoomdata) to PR CI and/or to daily CI job
2) Ensure that the vote email contains the exact sequence of commands to
validate the release. For instance: download, verify checksum, verify pgp,
unzip, build, test, etc, etc. The sequence can easily be automated, and I
don't really see much point in everybody doing those checks manually.

Note: the current release archive is reproducible. That means everybody who
creates the release archive should end up with exactly the same file.

Vladimir

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Julian Hyde]

It's good to find bugs like this, but it's depressing to only be
finding them in RC3. The bug probably existed in RC0, RC1 and RC2. If
there are lots of release iterations our volunteers start to burn out.

Folks, if you have an extensive test suite please run it as early in
the process as you can, and log any bugs that you find. A week or two
before RC0 is ideal.

Danny, if's your call as RM, but I suggest that you let this RC run
for several days, even if we find show-stoppers, to flush out as many
issues as possible.

Regarding 3839. It's a regression, it's probably a show-stopper, and I
probably caused it.

Lastly, the tag format is now "v-rc". In the past we have
had other formats, such as "rel/calcite-" and
"calcite-". Can we keep it consistent please?

Julian

On Mon, Mar 2, 2020 at 10:17 AM Anton Haidai  wrote:
>
> Hello,
>
> Local Calcite build with tests enabled on Linux: *OK*
> Calcite-based system (Zoomdata) test suite: *FAIL*
>
> Our test suite detected a regression. It is easily reproducible in a unit
> test. This test works fine in 1.21 branch.
> https://issues.apache.org/jira/browse/CALCITE-3839
>
> Vote:
> 0 (non-binding)
>
> On Mon, Mar 2, 2020 at 3:28 PM Danny Chan  wrote:
>
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.22.0, release
> > candidate 3.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
> >
> > Tag:
> > https://github.com/apache/calcite/tree/v1.22.0-rc3
> >
> > The artifacts to be voted on are located here:
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> > (revision 38350)
> >
> > The hashes of the artifacts are as follows:
> >
> > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> > *apache-calcite-1.22.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/danny0405.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > N.B.
> > To create the jars and test Apache Calcite: "./gradlew build".
> >
> > If you do not have a Java environment available, you can run the tests
> > using docker. To do so, install docker and docker-compose, then run
> > "docker-compose run test" from the root of the directory.
> >
> > Please vote on releasing this package as Apache Calcite 1.22.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.22.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
> >
> > Here is my vote:
> >
> > +1 (binding)
> >
> > Best,
> > Danny Chan
> >
>
>
> --
> Best regards,
> Anton.

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

[Anton Haidai]

Hello,

Local Calcite build with tests enabled on Linux: *OK*
Calcite-based system (Zoomdata) test suite: *FAIL*

Our test suite detected a regression. It is easily reproducible in a unit
test. This test works fine in 1.21 branch.
https://issues.apache.org/jira/browse/CALCITE-3839

Vote:
0 (non-binding)

On Mon, Mar 2, 2020 at 3:28 PM Danny Chan  wrote:

> Hi all,
>
> I have created a build for Apache Calcite 1.22.0, release
> candidate 3.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff
>
> Tag:
> https://github.com/apache/calcite/tree/v1.22.0-rc3
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3
> (revision 38350)
>
> The hashes of the artifacts are as follows:
>
> a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f
> *apache-calcite-1.22.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/danny0405.asc
> https://www.apache.org/dist/calcite/KEYS
>
> N.B.
> To create the jars and test Apache Calcite: "./gradlew build".
>
> If you do not have a Java environment available, you can run the tests
> using docker. To do so, install docker and docker-compose, then run
> "docker-compose run test" from the root of the directory.
>
> Please vote on releasing this package as Apache Calcite 1.22.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.22.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
>
> Here is my vote:
>
> +1 (binding)
>
> Best,
> Danny Chan
>


-- 
Best regards,
Anton.