zone-wide primary storage: 2 possible UI bugs

[Ryan Lei]

I have observed two possible UI bugs that have to do with 4.2's new feature
"zone-wide primary storage":

1. Volumes with zone-wide primary storage show no Hypervisor type in
Storage tab.

In the Storage tab, volumes that are placed in zone-wide primary storage
have their Hypervisor field empty. So is in the Volume Details.

Although a zone is allowed to have heterogeneous hypervisor types, is this
behavior normal?


2. UI does not allow storage migration between cluster-wide and zone-wide
storages (while VM migration does).

At first I have cluster1 + host1 with cluster-wide primary storage. Later
within the same zone, I add cluster2 + host2 and a zone-wide primary
storage.
If I try to migrate a VM from host 1 to host 2, the UI does allow it,
saying "Suitable, Storage migration required," and it works perfectly by
triggering implicit storage migration before VM migration.

However, if I try to only migrate the volume (cluster-wide -> zone-wide) in
the Storage tab, the UI does not show the zone-wide storage as a candidate.

Also, if I want to migrate the volume from zone-wide back to cluster-wide
primary storage (both are accessible to the cluster), the UI does not show
the cluster-wide storage as a candidate, either.


Are these potential bugs or flaws? Or are they by design?

---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw or ryanlei750...@gmail.com

Re: Review Request 14874: Marvin Plugin Changes: Adding timestamp and timetaken in seconds for a given testcase run to console

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14874/#review28510
---


4.2: ae852adabb70f43d6d349dd4ab56dc3116e10aed

- Girish Shilamkar


On Oct. 23, 2013, 1:53 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14874/
> ---
> 
> (Updated Oct. 23, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding fix for the bug 4885. This will  add timestamp and timetaken in 
> seconds for a given testcase run.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/marvinPlugin.py aded17c 
> 
> Diff: https://reviews.apache.org/r/14874/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15342/#review28509
---


Commit 3c350ab0b8ce1687a8f7e27e9e2f8e8d0fa68c47 in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3c350ab ]

CLOUDSTACK-4648: Fixed Snapshots test cases

Fixed following test cases:
1) test_01_volume_from_snapshot
2) test_03_snapshot_detachedDisk
3) test_07_template_from_snapshot

All three test cases are running successfully on XenServer but test cases (01 
and 07) failing on KVM due to a common issue.
Product defect logged for this: 
https://issues.apache.org/jira/browse/CLOUDSTACK-5097

test_03 is running ok on KVM too, the problem was - disk was not getting 
detached because it was not unmounted before detaching. Added code to unmount 
the disk.

Signed-off-by: Girish Shilamkar 


- ASF Subversion and Git Services


On Nov. 8, 2013, 7:07 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15342/
> ---
> 
> (Updated Nov. 8, 2013, 7:07 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4648
> https://issues.apache.org/jira/browse/CLOUDSTACK-4648
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed following test cases:
> 1) test_01_volume_from_snapshot
> 2) test_03_snapshot_detachedDisk
> 3) test_07_template_from_snapshot
> 
> All three test cases are running successfully on XenServer but test cases (01 
> and 07) failing on KVM due to a common issue.
> Product defect logged for this: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5097
> 
> test_03 is running ok on KVM too, the problem was - disk was not getting 
> detached because it was not unmounted before detaching. Added code to unmount 
> the disk.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots.py 1c2537c 
>   tools/marvin/marvin/integration/lib/common.py 164ef20 
> 
> Diff: https://reviews.apache.org/r/15342/diff/
> 
> 
> Testing
> ---
> 
> Log on Xen:
> 
> test_01_createVM_snapshotTemplate 
> (test_snapshots.TestCreateVMSnapshotTemplate)
> Test create VM, Snapshot and Template ... ok
> test_05_snapshot_events (test_snapshots.TestSnapshotEvents)
> Test snapshot events ... skipped 'Skip'
> test_01_volume_from_snapshot (test_snapshots.TestSnapshots)
> Test Creating snapshot from volume having spaces in name(KVM) ... skipped 
> 'Skip'
> test_02_snapshot_data_disk (test_snapshots.TestSnapshots)
> Test Snapshot Data Disk ... skipped 'Skip'
> test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots)
> Test snapshot from detached disk ... ok
> test_04_delete_snapshot (test_snapshots.TestSnapshots)
> Test Delete Snapshot ... skipped 'Skip'
> test_07_template_from_snapshot (test_snapshots.TestSnapshots)
> Create Template from snapshot ... ok
> 
> --
> Ran 7 tests in 529.398s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15342/#review28508
---


Commit b9547b07c059d229e6aed6213366cc3ab59fa26e in branch refs/heads/4.2 from 
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b9547b0 ]

CLOUDSTACK-4648: Fixed Snapshots test cases

Fixed following test cases:
1) test_01_volume_from_snapshot
2) test_03_snapshot_detachedDisk
3) test_07_template_from_snapshot

All three test cases are running successfully on XenServer but test cases (01 
and 07) failing on KVM due to a common issue.
Product defect logged for this: 
https://issues.apache.org/jira/browse/CLOUDSTACK-5097

test_03 is running ok on KVM too, the problem was - disk was not getting 
detached because it was not unmounted before detaching. Added code to unmount 
the disk.

Signed-off-by: Girish Shilamkar 


- ASF Subversion and Git Services


On Nov. 8, 2013, 7:07 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15342/
> ---
> 
> (Updated Nov. 8, 2013, 7:07 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4648
> https://issues.apache.org/jira/browse/CLOUDSTACK-4648
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed following test cases:
> 1) test_01_volume_from_snapshot
> 2) test_03_snapshot_detachedDisk
> 3) test_07_template_from_snapshot
> 
> All three test cases are running successfully on XenServer but test cases (01 
> and 07) failing on KVM due to a common issue.
> Product defect logged for this: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5097
> 
> test_03 is running ok on KVM too, the problem was - disk was not getting 
> detached because it was not unmounted before detaching. Added code to unmount 
> the disk.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots.py 1c2537c 
>   tools/marvin/marvin/integration/lib/common.py 164ef20 
> 
> Diff: https://reviews.apache.org/r/15342/diff/
> 
> 
> Testing
> ---
> 
> Log on Xen:
> 
> test_01_createVM_snapshotTemplate 
> (test_snapshots.TestCreateVMSnapshotTemplate)
> Test create VM, Snapshot and Template ... ok
> test_05_snapshot_events (test_snapshots.TestSnapshotEvents)
> Test snapshot events ... skipped 'Skip'
> test_01_volume_from_snapshot (test_snapshots.TestSnapshots)
> Test Creating snapshot from volume having spaces in name(KVM) ... skipped 
> 'Skip'
> test_02_snapshot_data_disk (test_snapshots.TestSnapshots)
> Test Snapshot Data Disk ... skipped 'Skip'
> test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots)
> Test snapshot from detached disk ... ok
> test_04_delete_snapshot (test_snapshots.TestSnapshots)
> Test Delete Snapshot ... skipped 'Skip'
> test_07_template_from_snapshot (test_snapshots.TestSnapshots)
> Create Template from snapshot ... ok
> 
> --
> Ran 7 tests in 529.398s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
---

(Updated Nov. 8, 2013, 7:16 a.m.)


Review request for cloudstack and SrikanteswaraRao Talluri.


Changes
---

Added missing patch file


Bugs: CLOUDSTACK-5099
https://issues.apache.org/jira/browse/CLOUDSTACK-5099


Repository: cloudstack-git


Description
---

1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here 
its not. Changed it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be 
to local as well remote


Diffs
-


Diff: https://reviews.apache.org/r/15341/diff/


Testing
---


File Attachments (updated)


patch file
  
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch
patchfile
  
https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch


Thanks,

Santhosh Edukulla

Re: Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

[Girish Shilamkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15342/#review28507
---

Ship it!


Ship It!

- Girish Shilamkar


On Nov. 8, 2013, 7:07 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15342/
> ---
> 
> (Updated Nov. 8, 2013, 7:07 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-4648
> https://issues.apache.org/jira/browse/CLOUDSTACK-4648
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed following test cases:
> 1) test_01_volume_from_snapshot
> 2) test_03_snapshot_detachedDisk
> 3) test_07_template_from_snapshot
> 
> All three test cases are running successfully on XenServer but test cases (01 
> and 07) failing on KVM due to a common issue.
> Product defect logged for this: 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5097
> 
> test_03 is running ok on KVM too, the problem was - disk was not getting 
> detached because it was not unmounted before detaching. Added code to unmount 
> the disk.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_snapshots.py 1c2537c 
>   tools/marvin/marvin/integration/lib/common.py 164ef20 
> 
> Diff: https://reviews.apache.org/r/15342/diff/
> 
> 
> Testing
> ---
> 
> Log on Xen:
> 
> test_01_createVM_snapshotTemplate 
> (test_snapshots.TestCreateVMSnapshotTemplate)
> Test create VM, Snapshot and Template ... ok
> test_05_snapshot_events (test_snapshots.TestSnapshotEvents)
> Test snapshot events ... skipped 'Skip'
> test_01_volume_from_snapshot (test_snapshots.TestSnapshots)
> Test Creating snapshot from volume having spaces in name(KVM) ... skipped 
> 'Skip'
> test_02_snapshot_data_disk (test_snapshots.TestSnapshots)
> Test Snapshot Data Disk ... skipped 'Skip'
> test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots)
> Test snapshot from detached disk ... ok
> test_04_delete_snapshot (test_snapshots.TestSnapshots)
> Test Delete Snapshot ... skipped 'Skip'
> test_07_template_from_snapshot (test_snapshots.TestSnapshots)
> Create Template from snapshot ... ok
> 
> --
> Ran 7 tests in 529.398s
> 
> OK (skipped=4)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/#review28506
---


i can't see the diff 

- SrikanteswaraRao Talluri


On Nov. 8, 2013, 7:01 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15341/
> ---
> 
> (Updated Nov. 8, 2013, 7:01 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-5099
> https://issues.apache.org/jira/browse/CLOUDSTACK-5099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
> 2. We followed uniform naming convention of Camel casing for classes but here 
> its not. Changed it.
> 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can 
> be to local as well remote
> 
> 
> Diffs
> -
> 
> 
> Diff: https://reviews.apache.org/r/15341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Review Request 15342: CLOUDSTACK-4648: Fixed Snapshots test cases

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15342/
---

Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-4648
https://issues.apache.org/jira/browse/CLOUDSTACK-4648


Repository: cloudstack-git


Description
---

Fixed following test cases:
1) test_01_volume_from_snapshot
2) test_03_snapshot_detachedDisk
3) test_07_template_from_snapshot

All three test cases are running successfully on XenServer but test cases (01 
and 07) failing on KVM due to a common issue.
Product defect logged for this: 
https://issues.apache.org/jira/browse/CLOUDSTACK-5097

test_03 is running ok on KVM too, the problem was - disk was not getting 
detached because it was not unmounted before detaching. Added code to unmount 
the disk.


Diffs
-

  test/integration/component/test_snapshots.py 1c2537c 
  tools/marvin/marvin/integration/lib/common.py 164ef20 

Diff: https://reviews.apache.org/r/15342/diff/


Testing
---

Log on Xen:

test_01_createVM_snapshotTemplate (test_snapshots.TestCreateVMSnapshotTemplate)
Test create VM, Snapshot and Template ... ok
test_05_snapshot_events (test_snapshots.TestSnapshotEvents)
Test snapshot events ... skipped 'Skip'
test_01_volume_from_snapshot (test_snapshots.TestSnapshots)
Test Creating snapshot from volume having spaces in name(KVM) ... skipped 'Skip'
test_02_snapshot_data_disk (test_snapshots.TestSnapshots)
Test Snapshot Data Disk ... skipped 'Skip'
test_03_snapshot_detachedDisk (test_snapshots.TestSnapshots)
Test snapshot from detached disk ... ok
test_04_delete_snapshot (test_snapshots.TestSnapshots)
Test Delete Snapshot ... skipped 'Skip'
test_07_template_from_snapshot (test_snapshots.TestSnapshots)
Create Template from snapshot ... ok

--
Ran 7 tests in 529.398s

OK (skipped=4)


Thanks,

Gaurav Aradhye

Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15341/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-5099
https://issues.apache.org/jira/browse/CLOUDSTACK-5099


Repository: cloudstack-git


Description
---

1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation
2. We followed uniform naming convention of Camel casing for classes but here 
its not. Changed it.
3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be 
to local as well remote


Diffs
-


Diff: https://reviews.apache.org/r/15341/diff/


Testing
---


Thanks,

Santhosh Edukulla

Re: pool.storage.capacity.disablethreshold global config

[Koushik Das]

>From what I understand, now there is a new interface Configurable that exposes 
>the config parameters. In this case if you look at the 
>CapacityManagerImpl.java, there is a method getCongigKeys() that return the 
>config parameters. During MS startup all these are automatically populated in 
>the db. Looks like pool.storage.capacity.disablethreshold was missed out from 
>the list. Add it in the list and it should be available.

 
On 08-Nov-2013, at 4:14 AM, Alena Prokharchyk  
wrote:

> I've run into the problem in master where I can't deploy the VM due to 
> insufficient capacity:
> 
> 2013-11-07 14:21:20,439 DEBUG [c.c.s.StorageManagerImpl] 
> (Job-Executor-27:ctx-e5d8814d ctx-e5375ad7) Insufficient space on pool: 1 
> since its usage percentage: 4.875950712239125 has crossed the 
> pool.storage.capacity.disablethreshold: 0.85
> 
> But there is no way to change "pool.storage.capacity.disablethreshold" as 
> this parameter is hardcoded in CapacityManager, and you can't change its 
> value.
> 
> Alex, seems you were the last person who modified it. Before we used to keep 
> all capacity thresholds in global config table, can you explain how it works 
> now?
> 
> commit 6e8ca994660afc468530944542e232596e8f1176
> Author: Alex Huang 
> Date:   Tue Aug 27 17:33:24 2013 -0700
> 
>Got all of the config stuff out of the way
> 
> -alena.

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14872/#review28500
---


Commit 8f76c49a994a630bfdd583c3515ac06c11c7c662 in branch refs/heads/4.2 from 
Girish Shilamkar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f76c49 ]

CLOUDSTACK-4934: Renamed Limit Resources tests so that they have unique name.

Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On Oct. 23, 2013, 8:35 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14872/
> ---
> 
> (Updated Oct. 23, 2013, 8:35 a.m.)
> 
> 
> Review request for cloudstack and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-4934
> https://issues.apache.org/jira/browse/CLOUDSTACK-4934
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Patch for master branch.
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_limits.py d721a45 
>   test/integration/component/cpu_limits/test_domain_limits.py 4e8fc6d 
>   test/integration/component/cpu_limits/test_maximum_limits.py 9161cee 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_domain_limits.py d87db84 
>   test/integration/component/memory_limits/test_maximum_limits.py b1ebbb4 
>   test/integration/component/memory_limits/test_memory_limits.py 18eab4c 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
>   test/integration/component/test_cpu_domain_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_max_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_project_limits.py PRE-CREATION 
>   test/integration/component/test_memory_limits.py PRE-CREATION 
>   test/integration/component/test_mm_domain_limits.py PRE-CREATION 
>   test/integration/component/test_mm_max_limits.py PRE-CREATION 
>   test/integration/component/test_mm_project_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

[Santhosh Edukulla]

> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote:
> > Ship It!
> 
> SrikanteswaraRao Talluri wrote:
> These two files are already covered as part of 
> https://reviews.apache.org/r/14872/

ok.


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
---


On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> ---
> 
> (Updated Nov. 6, 2013, 2:37 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> It was told that reporting results for a given test run with same module 
> names is confusing. 
> Renamed them with few prefixes to avoid confusion.
> 
> Note: There are still files with name as below for cpu limits related testing 
> and similarly available for memory as well. Need to check the difference 
> between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_project_limits.py 
> PRE-CREATION 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_mem_project_limits.py 
> PRE-CREATION 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
> 
> Diff: https://reviews.apache.org/r/15241/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

RE: Reviewboard needs your attention

[Animesh Chaturvedi]

I can see it fine, were you logged in at that time

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Thursday, November 07, 2013 6:03 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Reviewboard needs your attention
> 
> Hi Animesh,
> 
> For whatever reason, I can no longer edit
> https://reviews.apache.org/r/13865/.
> 
> Any thoughts on this?
> 
> Thanks!
> 
> 
> On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu  wrote:
> 
> > 2013/11/8 Animesh Chaturvedi 
> >
> > > Given that we are approaching the 4.3 feature freeze tomorrow if you
> > > have submitted patches and are still pending reviews please reach
> > > out to your reviewers
> >
> >
> > Dear Sebastien & Hugo,
> >
> > I have two pending patches on review board need to review:
> >
> > Rebase OVS (sdnextensions branch) to master branch:
> > https://reviews.apache.org/r/15205/
> > AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
> >
> > Thanks,
> >
> >
> > --
> >
> > N.g.U.y.e.N.A.n.H.t.U
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

[SrikanteswaraRao Talluri]

> On Nov. 8, 2013, 4:30 a.m., SrikanteswaraRao Talluri wrote:
> > Ship It!

These two files are already covered as part of 
https://reviews.apache.org/r/14872/


- SrikanteswaraRao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
---


On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> ---
> 
> (Updated Nov. 6, 2013, 2:37 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> It was told that reporting results for a given test run with same module 
> names is confusing. 
> Renamed them with few prefixes to avoid confusion.
> 
> Note: There are still files with name as below for cpu limits related testing 
> and similarly available for memory as well. Need to check the difference 
> between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_project_limits.py 
> PRE-CREATION 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_mem_project_limits.py 
> PRE-CREATION 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
> 
> Diff: https://reviews.apache.org/r/15241/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14872/#review28497
---


Commit 5d6d14bc1f1579006406a68cd069fba14ba3fa0c in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5d6d14b ]

CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names.

Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On Oct. 23, 2013, 8:35 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14872/
> ---
> 
> (Updated Oct. 23, 2013, 8:35 a.m.)
> 
> 
> Review request for cloudstack and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-4934
> https://issues.apache.org/jira/browse/CLOUDSTACK-4934
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Patch for master branch.
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_limits.py d721a45 
>   test/integration/component/cpu_limits/test_domain_limits.py 4e8fc6d 
>   test/integration/component/cpu_limits/test_maximum_limits.py 9161cee 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_domain_limits.py d87db84 
>   test/integration/component/memory_limits/test_maximum_limits.py b1ebbb4 
>   test/integration/component/memory_limits/test_memory_limits.py 18eab4c 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
>   test/integration/component/test_cpu_domain_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_max_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_project_limits.py PRE-CREATION 
>   test/integration/component/test_memory_limits.py PRE-CREATION 
>   test/integration/component/test_mm_domain_limits.py PRE-CREATION 
>   test/integration/component/test_mm_max_limits.py PRE-CREATION 
>   test/integration/component/test_mm_project_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

[ACS4.2.1]RC Date

[Abhinandan Prateek]

We are coming close to a RC. There are still some criticals open, have spoken 
to assignees and they are confident that these will be closed this week.
Sudha has already asked for volunteers to test 4.1.1->4.2.1 upgrade paths and 
we have folks who have volunteered.

I will also request the community to take some time out and test out 
functionality that interests them.

-abhi

Re: Review Request 15241: Renamed two modules with same name to avoid confusion while reporting test results

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15241/#review28495
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Nov. 6, 2013, 2:37 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15241/
> ---
> 
> (Updated Nov. 6, 2013, 2:37 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> It was told that reporting results for a given test run with same module 
> names is confusing. 
> Renamed them with few prefixes to avoid confusion.
> 
> Note: There are still files with name as below for cpu limits related testing 
> and similarly available for memory as well. Need to check the difference 
> between these two contents.
> That will be different check again.
> "test_cpu_project_limits.py"
> "test_cpu_limits.py"
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_project_limits.py 
> PRE-CREATION 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_mem_project_limits.py 
> PRE-CREATION 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
> 
> Diff: https://reviews.apache.org/r/15241/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 14872: CLOUDSTACK-4934: Rename Limit resources tests so that they have unique names

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14872/#review28496
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Oct. 23, 2013, 8:35 a.m., Girish Shilamkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14872/
> ---
> 
> (Updated Oct. 23, 2013, 8:35 a.m.)
> 
> 
> Review request for cloudstack and Rayees Namathponnan.
> 
> 
> Bugs: CLOUDSTACK-4934
> https://issues.apache.org/jira/browse/CLOUDSTACK-4934
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Patch for master branch.
> 
> 
> Diffs
> -
> 
>   test/integration/component/cpu_limits/test_cpu_limits.py d721a45 
>   test/integration/component/cpu_limits/test_domain_limits.py 4e8fc6d 
>   test/integration/component/cpu_limits/test_maximum_limits.py 9161cee 
>   test/integration/component/cpu_limits/test_project_limits.py 63d1a98 
>   test/integration/component/memory_limits/test_domain_limits.py d87db84 
>   test/integration/component/memory_limits/test_maximum_limits.py b1ebbb4 
>   test/integration/component/memory_limits/test_memory_limits.py 18eab4c 
>   test/integration/component/memory_limits/test_project_limits.py 1c0ed92 
>   test/integration/component/test_cpu_domain_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_max_limits.py PRE-CREATION 
>   test/integration/component/test_cpu_project_limits.py PRE-CREATION 
>   test/integration/component/test_memory_limits.py PRE-CREATION 
>   test/integration/component/test_mm_domain_limits.py PRE-CREATION 
>   test/integration/component/test_mm_max_limits.py PRE-CREATION 
>   test/integration/component/test_mm_project_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14872/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Girish Shilamkar
> 
>

Re: Review Request 15263: Added fix for bug 5056.

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15263/#review28494
---

Ship it!


- SrikanteswaraRao Talluri


On Nov. 6, 2013, 1:44 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15263/
> ---
> 
> (Updated Nov. 6, 2013, 1:44 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5056
> https://issues.apache.org/jira/browse/CLOUDSTACK-5056
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1. The library( remoteSSHClient ) in its current form has some issues. Fixed 
> few of them. As part of that, did clean up of the code. 
> 2. Added tcp timeout flag as an additional parameter to help establish the 
> tcp connections and retry if failed. It retries even otherwise failed. 
> 3. Renamed few variables and maintained uniform usage and convention. 
> 4. Added few new member functions runCommand,createConnection 
> 5. Current, way of creating connection and raising exception from constructor 
> along with return was removed and added a new way of handling it. 
> 6. Currently, result list was returned for execute command, but we dont know 
> the status of command execution, whether the output contains error or output 
> etc. Now, provided more information in the return with new implementation. 
> 7. Added few codes for proper return status. 
> 
> 
> TODO: 
> 1. Remove establishing connection from constructor altogether. This will 
> effect the current modules using it. 
> 2. Need to change is_server_ssh_ready function for proper and adequate 
> checks, currently the name and functionality is little different. It can add 
> more adequate checks before returning ssh object. 
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py b6580d0 
>   tools/marvin/marvin/integration/lib/utils.py 4d048f0 
>   tools/marvin/marvin/remoteSSHClient.py fea9b12 
> 
> Diff: https://reviews.apache.org/r/15263/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Added New File
>   
> https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 15263: Added fix for bug 5056.

[SrikanteswaraRao Talluri]

> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote:
> > tools/marvin/marvin/remoteSSHClient.py, line 116
> > 
> >
> > it should be self.keyPairFiles instead of keyPairFiles
> > 
> > again keyPairFiles is not defined at this point and it is resulting in 
> > exception.
> 
> Santhosh Edukulla wrote:
> It says self.keyPiarFiles only in the patch. I didnt see this line in 
> patch1, did it changed after applying patch2 related to this?

but this diff reflects it as  jus keyPairFiles . Anyways, if it is 
self.keyPairFiles after two patches, that is fine.


> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote:
> > tools/marvin/marvin/remoteSSHClient.py, line 115
> > 
> >
> > self.keyPairFiles is not defined at this moment we are getting an 
> > exception here. 
> > 
> > remove this here
> 
> Santhosh Edukulla wrote:
> self.keyPairFiles is defined in constructor and we are calling 
> createConnection later, so its not an issue i believe.

agreed


- SrikanteswaraRao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15263/#review28380
---


On Nov. 6, 2013, 1:44 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15263/
> ---
> 
> (Updated Nov. 6, 2013, 1:44 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5056
> https://issues.apache.org/jira/browse/CLOUDSTACK-5056
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1. The library( remoteSSHClient ) in its current form has some issues. Fixed 
> few of them. As part of that, did clean up of the code. 
> 2. Added tcp timeout flag as an additional parameter to help establish the 
> tcp connections and retry if failed. It retries even otherwise failed. 
> 3. Renamed few variables and maintained uniform usage and convention. 
> 4. Added few new member functions runCommand,createConnection 
> 5. Current, way of creating connection and raising exception from constructor 
> along with return was removed and added a new way of handling it. 
> 6. Currently, result list was returned for execute command, but we dont know 
> the status of command execution, whether the output contains error or output 
> etc. Now, provided more information in the return with new implementation. 
> 7. Added few codes for proper return status. 
> 
> 
> TODO: 
> 1. Remove establishing connection from constructor altogether. This will 
> effect the current modules using it. 
> 2. Need to change is_server_ssh_ready function for proper and adequate 
> checks, currently the name and functionality is little different. It can add 
> more adequate checks before returning ssh object. 
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py b6580d0 
>   tools/marvin/marvin/integration/lib/utils.py 4d048f0 
>   tools/marvin/marvin/remoteSSHClient.py fea9b12 
> 
> Diff: https://reviews.apache.org/r/15263/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Added New File
>   
> https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Storage overprovisioning for RBD / disable threshold?

[Nitin Mehta]

Please find answers inline

On 07/11/13 3:32 AM, "Indra Pramana"  wrote:

>Dear all,
>
>I am using CloudStack 4.2.0, KVM hypervisors, Ceph RBD primary storage and
>NFS secondary storage.
>
>I tried to change the storage.overprovisioning.factor from 1 to 2 under
>Global Settings, and it doesn't seem to work on my primary storage. The
>total amount of disk space seems to be remain the same, unlike the
>secondary storage which increases by double. Is there a way how I can
>enable overprovisioning on my RBD primary storage?

Last I recall storage over provisioning was for NFS and VMFS only. You
might want to check documentation and open an improvement bug as well.

>
>Is it possible for us to disable the threshold of
>pool.storage.allocated.capacity.disablethreshold? At the moment we can set
>an amount between 0 and 1 but we cannot disable it.

Setting it to 1 in a way disables it.

>
>Looking forward to your reply, thank you.
>
>Cheers.

Re: ComponentContext :: getComponent() ?

[Darren Shepherd]

Not really.  There is a away but it's intended for only framework code.  The 
API framework uses it.  For regular business logic, I've yet to see any good 
reason on why you need to look up things in the application context.  There is 
typically a cleaner way.

Darren

> On Nov 6, 2013, at 2:19 PM, Prachi Damle  wrote:
> 
> But in general, is there a way to get hold of a particular bean by name or 
> type?
> 
> -Original Message-
> From: Prachi Damle 
> Sent: Wednesday, November 06, 2013 1:19 PM
> To: dev@cloudstack.apache.org
> Subject: RE: ComponentContext :: getComponent() ?
> 
> I used to call getComponent() to get the current list of 
> AffinityGroupProcessors enabled by the admin. The injected processor list was 
> added later to the class, I think I can use that for this purpose.
> 
> Thanks,
> Prachi
> -Original Message-
> From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com]
> Sent: Tuesday, November 05, 2013 10:09 PM
> To: dev@cloudstack.apache.org
> Subject: Re: ComponentContext :: getComponent() ?
> 
> All other uses of getComponent() you listed should work fine.
> 
> In org.apache.cloudstack.affinity.AffinityGroupServiceImpl, why do you even 
> call getComponent()?  You already have a list of AffinityGroupProcessors 
> injected to the class.  Can't you just loop through those?
> 
> Darren
> 
> 
> On Tue, Nov 5, 2013 at 5:49 PM, Prachi Damle wrote:
> 
>> Thanks Darren, it is the listAffinityGroupTypes API, specific code is 
>> in AffinityGroupServiceImpl :: listAffinityGroupTypes() Code lists the 
>> beans implementing 'AffinityGroupProcessor' adapter interface.
>> 
>> 
>> I also dug up few other callers that rely on ComponentContext ::
>> getComponent()...
>> 
>> com.cloud.baremetal.networkservice.BareMetalResourceBase.fullSync()
>> com.cloud.network.NetworkStateListener.pubishOnEventBus(String,
>> String, Network, State, State) 
>> com.cloud.storage.listener.SnapshotStateListener.pubishOnEventBus(Stri
>> ng,
>> String, Snapshot, State, State)
>> com.cloud.vm.UserVmStateListener.pubishOnEventBus(String, String, 
>> VirtualMachine, State, State) 
>> com.cloud.storage.listener.VolumeStateListener.pubishOnEventBus(String
>> ,
>> String, Volume, State, State)
>> com.cloud.event.AlertGenerator.publishAlertOnEventBus(String, long, 
>> Long, String, String) 
>> com.cloud.event.ActionEventUtils.publishOnEventBus(long, long, String, 
>> String, State, String) 
>> com.cloud.event.UsageEventUtils.publishUsageEvent(String, Long, Long, 
>> String, String)
>> 
>> -Original Message-
>> From: Darren Shepherd [mailto:darren.s.sheph...@gmail.com]
>> Sent: Tuesday, November 05, 2013 4:40 PM
>> To: dev@cloudstack.apache.org
>> Cc: dev@cloudstack.apache.org
>> Subject: Re: ComponentContext :: getComponent() ?
>> 
>> Can you point me to the code that is failing.  The short of it is that 
>> you shouldn't use ComponentContext.  If you show me the failing code I 
>> can offer a better solution or if needed a work around.
>> 
>> Darren
>> 
 On Nov 5, 2013, at 4:18 PM, Prachi Damle 
>>> wrote:
>>> 
>>> Hi,
>>> 
>>> Before the Spring modularization, we have some usecases that were 
>>> using
>> the com.cloud.utils.component.ComponentContext class directly to 
>> inject or to find a bean of given type or name by invoking ComponentContext  
>> ::
>> getComponent().
>>> How should these usecases be ported now after the modularization
>> changes? What should we use instead of ComponentContext, to say find 
>> beans of certain type.
>>> 
>>> This is the root cause for bug
>> https://issues.apache.org/jira/browse/CLOUDSTACK-5045 as the code is 
>> still relying on ComponentContext
>>> 
>>> Thanks,
>>> Prachi
>> 

RE: [ACS 421] Upgrade testing

[Sudha Ponnaganti]

Hi,

Looks like Schuberg  Philis is covering 4. 1.1 -> 4.2.1 upgrade
We ( Citrix systems) would cover 4.2 -> 4.2.1

I think these two paths might be enough for this minor release.  I think RC is 
going to cut soon so these need to be covered before that. 

Thanks
/sudha


-Original Message-
From: Sudha Ponnaganti 
To: dev
Subject: RE: [ACS 421] Upgrade testing

Thanks Daan 

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, October 31, 2013 2:33 PM
To: dev
Subject: Re: [ACS 421] Upgrade testing

H Sudha,

We will at Schuberg Philis but probably not before next friday. We will be 
upgrading from 4.1.1. I hope we can free up some people to test that scenario 
soon.

Daan

On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti  
wrote:
> Hi All,
>
> Want to check if anyone is testing upgrades from prior versions to 4.2.1. As 
> Release date is getting close, If there are gaps, would like to cover some 
> scenarios in our lab.
>
> Thanks
> /sudha

Re: Review Request 12883: DNS value in Zone is not getting set in the Network created for the Zone

[Amogh Vasekar]

> On July 30, 2013, 3:57 a.m., Soheil Eizadi wrote:
> > In researching this more look like there is a code in NetworkManager that 
> > will set the Network DNS Domain, given proper DNS Capabilities 
> > (Capability.AllowDnsSuffixModification) is set in the DNS Offering. I need 
> > to investigate what happens when the DNS value for Zone is modified, so 
> > perhaps the code in the prepare/release is not needed.
> > 
> > // If networkDomain is not specified, take it from the global 
> > configuration
> > if 
> > (_networkModel.areServicesSupportedByNetworkOffering(networkOfferingId, 
> > Service.Dns)) {
> > Map dnsCapabilities = 
> > _networkModel.getNetworkOfferingServiceCapabilities
> > (_configMgr.getNetworkOffering(networkOfferingId), 
> > Service.Dns);
> > String isUpdateDnsSupported = 
> > dnsCapabilities.get(Capability.AllowDnsSuffixModification);
> > if (isUpdateDnsSupported == null || 
> > !Boolean.valueOf(isUpdateDnsSupported)) {
> > if (networkDomain != null) {
> > // TBD: NetworkOfferingId and zoneId. Send uuids 
> > instead.
> > throw new InvalidParameterValueException("Domain name 
> > change is not supported by network offering id="
> > + networkOfferingId + " in zone id=" + zoneId);
> > }

Reminder - 
Hi,
This review has been pending for long. Please update to "submitted" if this has 
already been committed.
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12883/#review24205
---


On July 26, 2013, 10:22 p.m., Soheil Eizadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12883/
> ---
> 
> (Updated July 26, 2013, 10:22 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3754
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-3754
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> DNS value in Zone is not getting set in the Network created for the Zone. Due 
> to this the prepare and release calls to the Network Plugins are missing this 
> information for the VMs.
> 
> see Jira bug https://issues.apache.org/jira/browse/CLOUDSTACK-3754 for 
> additional details.
> 
> diff --git a/server/src/com/cloud/network/NetworkManagerImpl.java 
> b/server/src/com/cloud/network/NetworkManagerImpl.java
> index 8e90cb7..53715c2 100755
> --- a/server/src/com/cloud/network/NetworkManagerImpl.java
> +++ b/server/src/com/cloud/network/NetworkManagerImpl.java
> @@ -2041,6 +2041,12 @@ public class NetworkManagerImpl extends ManagerBase 
> implements NetworkManager, L
>  dest, ReservationContext context, long nicId, NetworkVO network)
>  throws InsufficientVirtualNetworkCapcityException, 
> InsufficientAddressCapacityException,
>  ConcurrentOperationException, InsufficientCapacityException, 
> ResourceUnavailableException {
> +   
> +   if (dest.getDataCenter().getNetworkType() == NetworkType.Basic) {
> +   if ((network.getNetworkDomain() == null) && 
> (dest.getDataCenter().getDomain() != null)) {
> +   
> network.setNetworkDomain(dest.getDataCenter().getDomain());
> +   }
> +   }
>  
>  Integer networkRate = _networkModel.getNetworkRate(network.getId(), 
> vmProfile.getId());
>  NetworkGuru guru = AdapterBase.getAdapterByName(_networkGurus, 
> network.getGuruName());
> @@ -2116,6 +2122,13 @@ public class NetworkManagerImpl extends ManagerBase 
> implements NetworkManager, L
>  s_logger.error("NetworkGuru "+guru+" prepareForMigration 
> failed."); // XXX: Transaction error
>  }
>  }
> +
> +   if (dest.getDataCenter().getNetworkType() == 
> NetworkType.Basic) {
> +   if ((network.getNetworkDomain() == null) && 
> (dest.getDataCenter().getDomain() != null)) {
> +   
> network.setNetworkDomain(dest.getDataCenter().getDomain());
> +   }
> +   }
> +   
>  for (NetworkElement element : _networkElements) {
>  if(element instanceof NetworkMigrationResponder){
>  if(!((NetworkMigrationResponder) 
> element).prepareMigration(profile, network, vm, dest, context)){
> @@ -2238,7 +2251,14 @@ public class NetworkManagerImpl extends ManagerBase 
> implements NetworkManager, L
>  //commit the transaction before proceeding releasing nic 
> profile on the network ele

Re: Review Request 13865: Extend support of CloudStack-managed storage to KVM

[Mike Tutkowski]

Hi,

I just sent an e-mail to Animesh about this as I can no longer edit this
review for some reason.

Thanks!


On Thu, Nov 7, 2013 at 7:04 PM, Amogh Vasekar wrote:

>This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13865/
>
> Reminder -
> Hi,
> This review has been pending for long. Please update to "submitted" if this 
> has already been committed.
> Thanks
>
>
> - Amogh Vasekar
>
> On August 27th, 2013, 9:17 p.m. UTC, Mike Tutkowski wrote:
>   Review request for cloudstack.
> By Mike Tutkowski.
>
> *Updated Aug. 27, 2013, 9:17 p.m.*
>  *Bugs: * 
> CLOUDSTACK-4527
>  *Repository: * cloudstack-git
> Description
>
> This patch is part two of the SolidFire plug-in. Part one is described in 
> Review Request 11479 and was implemented in CS 4.2.
>
> The focus of this patch is to support a one-to-one mapping between a 
> CloudStack volume and a SolidFire volume when using KVM.
>
> The hypervisor plug-ins were initially developed to expect storage was 
> preallocated from a storage device. In 4.2, with the storage plug-in 
> framework, this model has changed to additionally support Primary Storage 
> representing a storage device itself (ex. a SAN) as opposed to it having to 
> represent preallocated storage (ex. a volume from a SAN).
>
> In the new model, Primary Storage can represent a SAN like SolidFire's. When 
> a CloudStack volume is attached to a VM for the first time, the storage 
> framework asks the storage plug-in to execute some logic. In the SolidFire 
> case, this is where a volume is created on the SolidFire SAN.
>
> In CS 4.2, I created the SolidFire plug-in and modified necessary parts of 
> the storage framework as well as XenServer and VMware plug-in logic to enable 
> a one-to-one mapping between a CS volume and a SolidFire volume when using 
> XenServer and ESX(i).
>
> This patch aims to extend this support to KVM.
>
> Support is offered in the form of Disk Offerings (not Compute Offerings).
>
>   Diffs
>
>
> View Diff 
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: Review Request 14023: NetworkManager Exception Fix Due to call to getDhcpServiceProvider()

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14023/#review28485
---


Reminder - 
Hi,
This review has been pending for long. Please update to "submitted" if this has 
already been committed.
Thanks

- Amogh Vasekar


On Sept. 6, 2013, 10:26 p.m., Soheil Eizadi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14023/
> ---
> 
> (Updated Sept. 6, 2013, 10:26 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> I ran the master branch with my NetworkElement integrated which provides DHCP 
> service. In my use case I was able to create a VM but when I deleted it there 
> was an exception in the NetworkManager when it called:
> 
> isDhcpAccrossMultipleSubnetsSupported() >> getDhcpServiceProvider()
> 
> 
> My DHCP Provider is a NetworkElement but does not implement the 
> DhcpServiceProvider interface.
> 
> 
>public DhcpServiceProvider getDhcpServiceProvider(Network network) {
> 
> String DhcpProvider = 
> _ntwkSrvcDao.getProviderForServiceInNetwork(network.getId(), Service.Dhcp);
> 
> 
> if (DhcpProvider == null) {
> 
> s_logger.debug("Network " + network + " doesn't support service " 
> + Service.Dhcp.getName());
> 
> return null;
> 
> }
> 
> 
> return 
> (DhcpServiceProvider)_networkModel.getElementImplementingProvider(DhcpProvider);
> 
> 
> }
> 
> 
> There is a check in the NetworkManager in the Prepare stage but a similar 
> check is missing in Release stage.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java ae27554 
> 
> Diff: https://reviews.apache.org/r/14023/diff/
> 
> 
> Testing
> ---
> 
> I verified in my environment where due to VM expunge failing to 
> NetworkManager exception the system would retry on a timer. After the fix the 
> VM was removed from the system after the first retry.
> 
> 
> Thanks,
> 
> Soheil Eizadi
> 
>

Re: Review Request 12098: Add PCI Passthrough to CloudStack on KVM Hypervisor

[Amogh Vasekar]

> On Aug. 7, 2013, 10:30 a.m., Pawit Pornkitprasan wrote:
> > I will rebase it in a few days.
> > 
> > This patch only includes support for KVM, but the concepts used can apply 
> > for all hypervisors supporting PCI Passthrough so additional patches can 
> > add support for XenServer. (Just to be clear, I'm not planning on adding 
> > support for other hypervisors myself.)
> > 
> > When used with other hypervisors, any attempt to start any VM requesting 
> > PCI Passthrough will gracefully fail in planning step as no host will be 
> > able to provide the request PCI devices.

Reminder - 
Hi,
This review has been pending for long. Please update to "submitted" if this has 
already been committed.
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12098/#review24788
---


On Aug. 8, 2013, 3:44 p.m., Pawit Pornkitprasan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12098/
> ---
> 
> (Updated Aug. 8, 2013, 3:44 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch adds PCI Passthrough support to CloudStack on the KVM Hypervisor 
> as previously mentioned on the mailing list
> 
> PCI Passthrough may be useful for high-performance networking devices
> or other hardware accelerators. This patch does not care what kind of
> the device it is or attempt to configure it, leaving it to the guest.
> 
> Because the devices available at each agent may be different, the
> available devices for passthrough are configured at the agent
> configuration file (/etc/cloudstack/agent/agent.properties).
> Configuration is a comma separated list of available PCI devices and
> its given name.
> 
> pci.devices=28:00.1|10GE,28:00.2|10GE,28:00.3|10GE,28:00.4|10GE,28:00.5|10GE,28:00.6|10GE,28:00.7|10GE,28:01.0|10GE
> 
> At agent startup, the list of PCI devices is parsed and sent together
> with StartupRoutingCommand (in a new field, not in details). The
> management server then stores it in a new table “op_host_pci_devices”.
> If a device is added, removed, or renamed, the table is updated
> accordingly. The agent also probes libvirt which devices are currently
> in-use and send it with the command in attempt to synchronize any
> potential difference between the database and the actual status.
> 
> The “name” of the PCI device is what is used to assign a device. In a
> compute offering, the user can specify the name of one or more PCI
> devices (as a comma-separated list) and CloudStack will find a host
> with the PCI device of the specified name available and assign it.
> 
> A new manager, PciDeviceManager, is created to handle the
> allocation of PCI device. The manager implements StateListener and
> assigns PCI devices on state change to “starting” and also release the
> devices VM stop. First fit allocator and first fit planner are also
> modified to check for PCI device availability accordingly.
> 
> For migration, intrusive migration is implementated. The PCI device is
> detached before migration and attached it again at the target host.
> This will interrupt whatever is using the device on the VM. However,
> it may be desirable for networking devices where the VM can use a
> bonding device to channel network traffic through the normal
> virtualized network device while the PCI Passthrough device is down.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/agent/api/to/PciDeviceTO.java PRE-CREATION 
>   api/src/com/cloud/agent/api/to/VirtualMachineTO.java e6240ff 
>   api/src/com/cloud/offering/ServiceOffering.java 45d5f38 
>   api/src/com/cloud/pci/PciDevice.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 00d526d 
>   
> api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java
>  decac29 
>   api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java 
> 5c5b369 
>   client/WEB-INF/classes/resources/messages.properties 4fc09ee 
>   client/tomcatconf/applicationContext.xml.in b832b09 
>   core/src/com/cloud/agent/api/AttachPciDevicesCommand.java PRE-CREATION 
>   core/src/com/cloud/agent/api/StartupRoutingCommand.java 5961ab0 
>   engine/schema/src/com/cloud/host/HostPciDeviceVO.java PRE-CREATION 
>   engine/schema/src/com/cloud/host/HostVO.java c814b94 
>   engine/schema/src/com/cloud/host/dao/HostDaoImpl.java dd26941 
>   engine/schema/src/com/cloud/host/dao/HostPciDevicesDao.java PRE-CREATION 
>   engine/schema/src/com/cloud/host/dao/HostPciDevicesDaoImpl.java 
> PRE-CREATION 
>   engine/schema/src/com/cloud/migration/ServiceOffering21VO.java 7a49e63 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 
>   
> plugins/hypervisors/k

Re: Review Request 13865: Extend support of CloudStack-managed storage to KVM

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13865/#review28483
---


Reminder - 
Hi,
This review has been pending for long. Please update to "submitted" if this has 
already been committed.
Thanks

- Amogh Vasekar


On Aug. 27, 2013, 9:17 p.m., Mike Tutkowski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13865/
> ---
> 
> (Updated Aug. 27, 2013, 9:17 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-4527
> https://issues.apache.org/jira/browse/CLOUDSTACK-4527
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch is part two of the SolidFire plug-in. Part one is described in 
> Review Request 11479 and was implemented in CS 4.2.
> 
> The focus of this patch is to support a one-to-one mapping between a 
> CloudStack volume and a SolidFire volume when using KVM.
> 
> The hypervisor plug-ins were initially developed to expect storage was 
> preallocated from a storage device. In 4.2, with the storage plug-in 
> framework, this model has changed to additionally support Primary Storage 
> representing a storage device itself (ex. a SAN) as opposed to it having to 
> represent preallocated storage (ex. a volume from a SAN).
> 
> In the new model, Primary Storage can represent a SAN like SolidFire's. When 
> a CloudStack volume is attached to a VM for the first time, the storage 
> framework asks the storage plug-in to execute some logic. In the SolidFire 
> case, this is where a volume is created on the SolidFire SAN.
> 
> In CS 4.2, I created the SolidFire plug-in and modified necessary parts of 
> the storage framework as well as XenServer and VMware plug-in logic to enable 
> a one-to-one mapping between a CS volume and a SolidFire volume when using 
> XenServer and ESX(i).
> 
> This patch aims to extend this support to KVM.
> 
> Support is offered in the form of Disk Offerings (not Compute Offerings).
> 
> 
> Diffs
> -
> 
> 
> Diff: https://reviews.apache.org/r/13865/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mike Tutkowski
> 
>

Re: Review Request 13072: Print agent host name in logging of agent commands

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13072/#review28482
---


Reminder - 
Hi,
This review has been pending for long. Request the reviewer to provide comments.
Thanks

- Amogh Vasekar


On Aug. 6, 2013, 10:32 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13072/
> ---
> 
> (Updated Aug. 6, 2013, 10:32 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-3872
> https://issues.apache.org/jira/browse/CLOUDSTACK-3872
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Print agent name when logging Commands sent to VM hosts. See bug description. 
>  I'm not super familiar with this code, so I'd like someone to look over it 
> and verify it's the right thing.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/transport/Request.java b0fa4cc 
>   server/src/com/cloud/agent/manager/AgentAttache.java 1785bcf 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b157838 
>   server/src/com/cloud/agent/manager/ClusteredAgentAttache.java 058a904 
>   server/src/com/cloud/agent/manager/ClusteredAgentManagerImpl.java 4fdb3c6 
>   server/src/com/cloud/agent/manager/ClusteredDirectAgentAttache.java 9012433 
>   server/src/com/cloud/agent/manager/ConnectedAgentAttache.java c98307b 
>   server/src/com/cloud/agent/manager/DirectAgentAttache.java 9b7d69f 
>   server/src/com/cloud/agent/manager/DummyAttache.java 14286d2 
> 
> Diff: https://reviews.apache.org/r/13072/diff/
> 
> 
> Testing
> ---
> 
> Tested on KVM zone, need help testing others.
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

Re: Reviewboard needs your attention

[Mike Tutkowski]

Hi Animesh,

For whatever reason, I can no longer edit
https://reviews.apache.org/r/13865/.

Any thoughts on this?

Thanks!


On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu  wrote:

> 2013/11/8 Animesh Chaturvedi 
>
> > Given that we are approaching the 4.3 feature freeze tomorrow if you have
> > submitted patches and are still pending reviews please reach out to your
> > reviewers
>
>
> Dear Sebastien & Hugo,
>
> I have two pending patches on review board need to review:
>
> Rebase OVS (sdnextensions branch) to master branch:
> https://reviews.apache.org/r/15205/
> AutoScaling without NetScaler: https://reviews.apache.org/r/14628/
>
> Thanks,
>
>
> --
>
> N.g.U.y.e.N.A.n.H.t.U
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*

Re: [PROPOSAL] Liaison with ETSI NFV ISG

[Nguyen Anh Tu]

2013/11/7 Chiradeep Vittal 

> While I appreciate the confidence, there are weekly calls to attend.
> The particularly interesting one (MANO WG) happens on Wednesdays at 6am
> PST.
> I've tried but there's very little chance that I can attend these
> meetings.
> Anybody in a more agreeable timezone?
>

Not sure if I have permitted to join, I'm in agreeable timezone (9pm at
local time). It's great and I'm willing to join to liaison team.

-- 

N.g.U.y.e.N.A.n.H.t.U

Jenkins build is back to normal : build-master-noredist #1740

[jenkins]

See 

Re: Reviewboard needs your attention

[Nguyen Anh Tu]

2013/11/8 Animesh Chaturvedi 

> Given that we are approaching the 4.3 feature freeze tomorrow if you have
> submitted patches and are still pending reviews please reach out to your
> reviewers


Dear Sebastien & Hugo,

I have two pending patches on review board need to review:

Rebase OVS (sdnextensions branch) to master branch:
https://reviews.apache.org/r/15205/
AutoScaling without NetScaler: https://reviews.apache.org/r/14628/

Thanks,


-- 

N.g.U.y.e.N.A.n.H.t.U

Re: Router requires upgrade. Unable to send command to router Error

[Alena Prokharchyk]

Nitin, I had the same problem, but I fixed it by uploading 4.2 system templates 
to my secondary storage. Make sure you have the latest too.

-alena.

From: Nitin Mehta mailto:nitin.me...@citrix.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday, November 7, 2013 4:16 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Router requires upgrade. Unable to send command to router Error

Unable to deploy vms in the latest master because of the commit below. Is 
anyone noticing this on the latest master.
I checked the code  and there was a commit made recently 3f5b8f which is where 
the exception points to.

WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 // 
dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System Alert: 
Low Available Storage in cluster c3 pod p of availability zone z3
INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add job-44 
into job monitoring
WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331) Detecting a 
change in xstoolsversion for r-6-VM
ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc 
ctx-d9a00f18) Failed to start instance 
VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
com.cloud.utils.exception.CloudRuntimeException: Router requires upgrade. 
Unable to send command to router:6
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(VirtualNetworkApplianceManagerImpl.java:3003)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3848)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

[Sheng Yang]

Hi Daan,

I think your patch is completely wrong.

The BroadcastDomainType.getValue() would accept format of URI, not the
number. I don't think your change would work, either in code or by semantic.

I think your commit would break all elements your code touched. The current
assumption of vlanId and secondaryVlanId are both numbers, not URI.

Please revert it.

--Sheng


On Thu, Nov 7, 2013 at 4:07 PM, Min Chen  wrote:

> Then we need to clearly define the semantic of parameter "vlanId" of
> HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not
> other format. The invoker method should pass the correct one to this
> utility to make it work.
>
> Thanks
> -min
>
> On 11/7/13 3:43 PM, "Daan Hoogland"  wrote:
>
> >Doesn't sound like a guarantee, If the stack is build otherwise there
> >might come in a different (non-integer-representing) string.
> >
> >On Thu, Nov 7, 2013 at 6:08 PM, Min Chen  wrote:
> >> Yes. From callstack,
> >> BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is
> >> already called before going to that routine.
> >>
> >> Thanks
> >> -min
> >>
> >> On 11/7/13 1:51 AM, "Daan Hoogland"  wrote:
> >>
> >>>H Min,
> >>>
> >>>Your fix will work if you can guarantee that the String passed is a
> >>>integer. if it has the chance of being in the form of for instance
> >>>vlan:// , you should use:
> >>>vid =
> >>>Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromSt
> >>>ri
> >>>ng(vlanId)));
> >>>
> >>>regards,
> >>>Daan
> >>>
> >>>
> >>>On Wed, Nov 6, 2013 at 3:25 AM, Min Chen  wrote:
>  Hi Daan,
> 
>  Your commit
> 
> 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c
> 8c
> ee01a450ee924fe108cafe54b046485ab2b
>  broke Vmware advanced zone setup on Master, where system vm starts
> failed
>  with "NumberFormatException", see details in
>  https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this
> blocker
>  bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting
> part
> of
>  your change on HypervisorHostHelper method, but not sure if there is
> any
>  side effect on your another functionality fixed in your commit. Can
> you
>  please review to make sure that it is ok?
> 
>  Thanks
>  -min
> >>
>
>

Router requires upgrade. Unable to send command to router Error

[Nitin Mehta]

Unable to deploy vms in the latest master because of the commit below. Is 
anyone noticing this on the latest master.
I checked the code  and there was a commit made recently 3f5b8f which is where 
the exception points to.

WARN  [o.a.c.alerts] (CapacityChecker:ctx-4f1ef01f)  alertType:: 2 // 
dataCenterId:: 3 // podId:: 3 // clusterId:: null // message:: System Alert: 
Low Available Storage in cluster c3 pod p of availability zone z3
INFO  [o.a.c.f.j.i.AsyncJobMonitor] (Job-Executor-1:ctx-f118d6dc) Add job-44 
into job monitoring
WARN  [c.c.h.x.r.CitrixResourceBase] (DirectAgent-26:ctx-3e786331) Detecting a 
change in xstoolsversion for r-6-VM
ERROR [c.c.v.VirtualMachineManagerImpl] (Job-Executor-1:ctx-f118d6dc 
ctx-d9a00f18) Failed to start instance 
VM[User|VM-4d5d5db2-e5ba-4bbd-b1dc-e749ac42a74c]
com.cloud.utils.exception.CloudRuntimeException: Router requires upgrade. 
Unable to send command to router:6
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.sendCommandsToRouter(VirtualNetworkApplianceManagerImpl.java:3567)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl$7.execute(VirtualNetworkApplianceManagerImpl.java:3003)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyRules(VirtualNetworkApplianceManagerImpl.java:3848)
at 
com.cloud.network.router.VirtualNetworkApplianceManagerImpl.applyDhcpEntry(VirtualNetworkApplianceManagerImpl.java:2995)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

[Min Chen]

Then we need to clearly define the semantic of parameter "vlanId" of
HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not
other format. The invoker method should pass the correct one to this
utility to make it work.

Thanks
-min

On 11/7/13 3:43 PM, "Daan Hoogland"  wrote:

>Doesn't sound like a guarantee, If the stack is build otherwise there
>might come in a different (non-integer-representing) string.
>
>On Thu, Nov 7, 2013 at 6:08 PM, Min Chen  wrote:
>> Yes. From callstack,
>> BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is
>> already called before going to that routine.
>>
>> Thanks
>> -min
>>
>> On 11/7/13 1:51 AM, "Daan Hoogland"  wrote:
>>
>>>H Min,
>>>
>>>Your fix will work if you can guarantee that the String passed is a
>>>integer. if it has the chance of being in the form of for instance
>>>vlan:// , you should use:
>>>vid =
>>>Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromSt
>>>ri
>>>ng(vlanId)));
>>>
>>>regards,
>>>Daan
>>>
>>>
>>>On Wed, Nov 6, 2013 at 3:25 AM, Min Chen  wrote:
 Hi Daan,

 Your commit

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c
8c
ee01a450ee924fe108cafe54b046485ab2b
 broke Vmware advanced zone setup on Master, where system vm starts
failed
 with "NumberFormatException", see details in
 https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this
blocker
 bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting
part
of
 your change on HypervisorHostHelper method, but not sure if there is
any
 side effect on your another functionality fixed in your commit. Can
you
 please review to make sure that it is ok?

 Thanks
 -min
>>

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

[Daan Hoogland]

Doesn't sound like a guarantee, If the stack is build otherwise there
might come in a different (non-integer-representing) string.

On Thu, Nov 7, 2013 at 6:08 PM, Min Chen  wrote:
> Yes. From callstack,
> BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is
> already called before going to that routine.
>
> Thanks
> -min
>
> On 11/7/13 1:51 AM, "Daan Hoogland"  wrote:
>
>>H Min,
>>
>>Your fix will work if you can guarantee that the String passed is a
>>integer. if it has the chance of being in the form of for instance
>>vlan:// , you should use:
>>vid =
>>Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromStri
>>ng(vlanId)));
>>
>>regards,
>>Daan
>>
>>
>>On Wed, Nov 6, 2013 at 3:25 AM, Min Chen  wrote:
>>> Hi Daan,
>>>
>>> Your commit
>>>
>>>https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c8c
>>>ee01a450ee924fe108cafe54b046485ab2b
>>> broke Vmware advanced zone setup on Master, where system vm starts
>>>failed
>>> with "NumberFormatException", see details in
>>> https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this
>>>blocker
>>> bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part
>>>of
>>> your change on HypervisorHostHelper method, but not sure if there is any
>>> side effect on your another functionality fixed in your commit. Can you
>>> please review to make sure that it is ok?
>>>
>>> Thanks
>>> -min
>

Build failed in Jenkins: build-master-noredist #1739

[jenkins]

See 

Changes:

[sudison] Add quiencevm option on createsnapshotcmd

[min.chen] CLOUDSTACK-4833:[Automation][BVT] Template and ISO test cases failing

--
[...truncated 415 lines...]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudstack-framework 
---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloudstack-framework ---
[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ 
cloudstack-framework ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloudstack-framework ---
[INFO] Installing 
 
to 
/jenkins/.m2/repository/org/apache/cloudstack/cloudstack-framework/4.3.0-SNAPSHOT/cloudstack-framework-4.3.0-SNAPSHOT.pom
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Event Notification 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-framework-db ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-framework-db ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-framework-db ---
[INFO] Compiling 43 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-framework-db ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-framework-db ---
[INFO] Compiling 12 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-framework-db 
---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ cloud-framework-db ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.1:attach-descriptor (attach-descriptor) @ 
cloud-framework-db ---
[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
cloud-framework-db ---
[INFO] Installing 

 to 
/jenkins/.m2/repository/org/apache/cloudstack/cloud-framework-db/4.3.0-SNAPSHOT/cloud-framework-db-4.3.0-SNAPSHOT.jar
[INFO] Installing 

 to 
/jenkins/.m2/repository/org/apache/cloudstack/cloud-framework-db/4.3.0-SNAPSHOT/cloud-framework-db-4.3.0-SNAPSHOT.pom
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Configuration 4.3.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-config ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes

Re: [jira] [Updated] (CLOUDSTACK-4982) Top of dialogs cut off

[Luis]

Hi

I will appreciate your help to fix this problem


CloudStack 4.2
Ubuntu 12.04
single machine

The errors


10.0.0.20:/export/primary/ 684G  2.5G  646G   1% 
/mnt/primary
10.0.0.20:/export/secondary/   684G  2.5G  646G   1% 
/mnt/secondary
10.0.0.20:/export/primary  684G  2.5G  646G   1%
 /mnt/0b89f7ac-67a7-3790-9f49-ad66af4319c5
10.0.0.20:/export/secondary/template/tmpl/1/3  684G  2.5G  646G   1% 
/mnt/96340021-0249-366b-b4b7-f271271634a2


2013-11-06 21:55:04,386 INFO  [cloud.vm.VirtualMachineManagerImpl] 
(secstorage-1:null) Unable to contact resource.
com.cloud.exception.StorageUnavailableException:
 Resource [StoragePool:1] is unreachable: Unable to create 
Vol[6|vm=6|ROOT]:Failed to get volumes from pool: 
96340021-0249-366b-b4b7-f271271634a2


2013-11-06 21:55:34,178 INFO  [cloud.vm.VirtualMachineManagerImpl] 
(secstorage-1:null) Unable to contact resource.
com.cloud.exception.StorageUnavailableException:
 Resource [StoragePool:1] is unreachable: Unable to create 
Vol[6|vm=6|ROOT]:Failed to get volumes from pool: 
96340021-0249-366b-b4b7-f271271634a2


2013-11-06 21:55:34,558 WARN  [storage.secondary.SecondaryStorageManagerImpl] 
(secstorage-1:null) Exception while trying to start secondary storage vm
com.cloud.exception.InsufficientServerCapacityException:
 Unable to create a deployment for 
VM[SecondaryStorageVm|s-6-VM]Scope=interface com.cloud.dc.DataCenter; 
id=1
    at 
com.cloud.vm.VirtualMachineManagerImpl.advanceStart(VirtualMachineManagerImpl.java:842)

2013-11-06 21:55:34,666 INFO  [cloud.vm.VirtualMachineManagerImpl] 
(consoleproxy-1:null) Unable to contact resource.
com.cloud.exception.StorageUnavailableException:
 Resource [StoragePool:1] is unreachable: Unable to create 
Vol[2|vm=2|ROOT]:Failed to get volumes from pool: 
96340021-0249-366b-b4b7-f271271634a2

2013-11-06 21:55:35,049 WARN  [cloud.consoleproxy.ConsoleProxyManagerImpl] 
(consoleproxy-1:null) Exception while trying to start console proxy
com.cloud.exception.InsufficientServerCapacityException:
 Unable to create a deployment for 
VM[ConsoleProxy|v-2-VM]Scope=interface com.cloud.dc.DataCenter; id=1




On Thursday, November 7, 2013 5:30 PM, Animesh Chaturvedi (JIRA) 
 wrote:
 

     [ 
https://issues.apache.org/jira/browse/CLOUDSTACK-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Animesh Chaturvedi updated CLOUDSTACK-4982:
---


BULK EDIT> These issues are open to be picked up. Help in resolution is 
appreciated.

> Top of dialogs cut off
> --
>
>                 Key: CLOUDSTACK-4982
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4982
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
>default.) 
>          Components: UI
>    Affects Versions: 4.3.0
>         Environment: Chrome Version 30.0.1599.101 on Mac OS X 10.8.3
>            Reporter: Mike Tutkowski
>            Priority: Minor
>             Fix For: 4.3.0
>
>         Attachments: Top of Dialog.png
>
>
> Please see the attached screen shot.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

pool.storage.capacity.disablethreshold global config

[Alena Prokharchyk]

I've run into the problem in master where I can't deploy the VM due to 
insufficient capacity:

2013-11-07 14:21:20,439 DEBUG [c.c.s.StorageManagerImpl] 
(Job-Executor-27:ctx-e5d8814d ctx-e5375ad7) Insufficient space on pool: 1 since 
its usage percentage: 4.875950712239125 has crossed the 
pool.storage.capacity.disablethreshold: 0.85

But there is no way to change "pool.storage.capacity.disablethreshold" as this 
parameter is hardcoded in CapacityManager, and you can't change its value.

Alex, seems you were the last person who modified it. Before we used to keep 
all capacity thresholds in global config table, can you explain how it works 
now?

commit 6e8ca994660afc468530944542e232596e8f1176
Author: Alex Huang 
Date:   Tue Aug 27 17:33:24 2013 -0700

Got all of the config stuff out of the way

-alena.

Re: Bug? Should we allow detaching volumes when VMs have snapshots

[Nux!]

On 07.11.2013 21:17, Mike Tutkowski wrote:
Especially since it appears to have been working for XenServer and I'd 
hate

to take that functionality away from people who might be using it.


+100, removing functionality will not gain you any extra points; 
especially doing it for what is probably the least deployed hypervisor 
(quotation needed).


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15309/#review28458
---

Ship it!


Ship It!

- edison su


On Nov. 7, 2013, 9:30 p.m., Chris Suich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15309/
> ---
> 
> (Updated Nov. 7, 2013, 9:30 p.m.)
> 
> 
> Review request for cloudstack and edison su.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> A bug was introduced in a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 which does 
> not allow VMWare VM snapshots to be deleted.
> 
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a6ce66e55a65eb0fbae9ead92de6ceac7a87c531
> 
> In refactoring, volumeTo.getPoolUuid() was supposed to be changed to 
> store.getUuid() but was actually changed to volumeTo.getUuid().
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
>  0e2423e 
> 
> Diff: https://reviews.apache.org/r/15309/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chris Suich
> 
>

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15313/#review28457
---

Ship it!


Ship It!

- edison su


On Nov. 7, 2013, 9 p.m., Chris Suich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15313/
> ---
> 
> (Updated Nov. 7, 2013, 9 p.m.)
> 
> 
> Review request for cloudstack and edison su.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> VMSnapshotDetailsDao/Impl/VO were not using the ResourceDetails/Dao/Base 
> pattern which caused issues with adding details and did not give access to 
> useful methods like the detail getters/deleters.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/vm/snapshot/VMSnapshotDetailsVO.java 934dd92 
>   engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDao.java 
> e84178c 
>   engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDaoImpl.java 
> b528b39 
>   
> engine/storage/integration-test/test/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java
>  fc52f89 
> 
> Diff: https://reviews.apache.org/r/15313/diff/
> 
> 
> Testing
> ---
> 
> This has been tested locally with a custom plugin. However, the changes are 
> not used by the existing CloudStack codebase and should not impact any 
> existing workflows or use cases. They are simply for plugins to take 
> advantage of.
> 
> 
> Thanks,
> 
> Chris Suich
> 
>

Re: Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

[edison su]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15326/#review28456
---

Ship it!


Ship It!

- edison su


On Nov. 7, 2013, 9 p.m., Chris Suich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15326/
> ---
> 
> (Updated Nov. 7, 2013, 9 p.m.)
> 
> 
> Review request for cloudstack and edison su.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added option to reload VM during in RevertToVMSnapshotCommand. For now, only 
> in VMWare as I don't believe that XenServer supports anything similar.
> 
> This gives plugins which may have unique snapshot strategies the ability to 
> request the hypervisor to reload the VM's state before attempting to revert 
> to a snapshot.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/RevertToVMSnapshotCommand.java 1e5fd6c 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
>  0e2423e 
> 
> Diff: https://reviews.apache.org/r/15326/diff/
> 
> 
> Testing
> ---
> 
> This has been tested locally with a custom plugin. However, the changes are 
> not used by the existing CloudStack codebase and should not impact any 
> existing workflows or use cases. They are simply for plugins to take 
> advantage of.
> 
> 
> Thanks,
> 
> Chris Suich
> 
>

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

[Chris Suich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15309/
---

(Updated Nov. 7, 2013, 9:30 p.m.)


Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

A bug was introduced in a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 which does not 
allow VMWare VM snapshots to be deleted.

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a6ce66e55a65eb0fbae9ead92de6ceac7a87c531

In refactoring, volumeTo.getPoolUuid() was supposed to be changed to 
store.getUuid() but was actually changed to volumeTo.getUuid().


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 0e2423e 

Diff: https://reviews.apache.org/r/15309/diff/


Testing (updated)
---


Thanks,

Chris Suich

api incompatibility between 4.1 and 4.2 in ACLs

[Marcus Sorensen]

Maybe this has been discussed already, but we seem to have run into an
api incompatibility. In 4.1, you could create ad-hoc ACL rules that
applied to a network. In 4.2, you have to first create an 'ACL list',
then add those rules to the list, then apply the list to a network. Or
so it seems.  This means that applications that are coded to the
cloudstack API and utilize createNetworkACL will break, because the
flow has changed.

Am I correct on this? And if so, shouldn't we have deployed 4.2 as
5.0, since the stated versioning is based on API compatibility?

Re: Bug? Should we allow detaching volumes when VMs have snapshots

[Mike Tutkowski]

Especially since it appears to have been working for XenServer and I'd hate
to take that functionality away from people who might be using it.


On Thu, Nov 7, 2013 at 2:15 PM, Mike Tutkowski  wrote:

> I can see the appeal in consistent behavior, but I'm not sure we want
> CloudStack to always follow a least-common-denominator approach.
>
> Personally I recommend we leave XenServer's functionality here as is.
>
>
> On Thu, Nov 7, 2013 at 6:14 AM, SuichII, Christopher <
> chris.su...@netapp.com> wrote:
>
>> Thanks for replying, Kelvin.
>>
>> Now, should we only not allow this on VMWare, or should we prohibit it on
>> XenServer as well. It appears to work fine on XenServer, but it may be a
>> good idea to have a consistent experience, regardless of hypervisor.
>>
>> -Chris
>> --
>> Chris Suich
>> chris.su...@netapp.com
>> NetApp Software Engineer
>> Data Center Platforms – Cloud Solutions
>> Citrix, Cisco & Red Hat
>>
>> On Nov 6, 2013, at 9:09 PM, Kelven Yang  wrote:
>>
>> > We should dis-allow detaching volume from VM when it has VM snapshots.
>> > VMware keeps VM snapshot meta information at VM basis, disk membership
>> > change behind its back will cause problem and it does not provide
>> official
>> > API to manipulate at volume level for a VM snapshot.
>> >
>> > This is a bug
>> >
>> > Kelven
>> >
>> > On 11/6/13, 5:58 AM, "SuichII, Christopher" 
>> wrote:
>> >
>> >> Bumping this. I believe we need the imput of a VMWare expert, please.
>> >>
>> >> -Chris
>> >> --
>> >> Chris Suich
>> >> chris.su...@netapp.com
>> >> NetApp Software Engineer
>> >> Data Center Platforms ­ Cloud Solutions
>> >> Citrix, Cisco & Red Hat
>> >>
>> >> On Nov 5, 2013, at 1:46 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com>
>> >> wrote:
>> >>
>> >>> OK, well, depending on if we can or can't get a VMware person to chime
>> >>> in
>> >>> on this issue, we may have to disallow disks from being detached from
>> >>> VMware VMs with snapshots in 4.3.
>> >>>
>> >>>
>> >>> On Tue, Nov 5, 2013 at 11:44 AM, SuichII, Christopher <
>> >>> chris.su...@netapp.com> wrote:
>> >>>
>>  Correct.
>> 
>>  #6 FAILS with VMWare and SUCCEEDS with Xen
>> 
>>  --
>>  Chris Suich
>>  chris.su...@netapp.com
>>  NetApp Software Engineer
>>  Data Center Platforms ­ Cloud Solutions
>>  Citrix, Cisco & Red Hat
>> 
>>  On Nov 5, 2013, at 1:35 PM, Mike Tutkowski
>>  
>>  wrote:
>> 
>> > I assume 6 fails with VMware, as well?
>> >
>> > Is Xen OK with 6?
>> >
>> >
>> > On Tue, Nov 5, 2013 at 11:26 AM, SuichII, Christopher <
>> > chris.su...@netapp.com> wrote:
>> >
>> >> FWIW, after looking into this more with Xen, when the VM is
>> restored
>> >> in
>> >> step 4, it simply no longer has the volume attached, so this
>> appears
>> >> to
>> >> really be a VMWare issue. Any VMWare experts out there know how we
>> >> can
>> >> handle this?
>> >>
>> >> -Chris
>> >> --
>> >> Chris Suich
>> >> chris.su...@netapp.com
>> >> NetApp Software Engineer
>> >> Data Center Platforms ­ Cloud Solutions
>> >> Citrix, Cisco & Red Hat
>> >>
>> >> On Nov 5, 2013, at 1:05 PM, SuichII, Christopher <
>>  chris.su...@netapp.com>
>> >> wrote:
>> >>
>> >>> We currently don¹t allow volumes to be attached to VMs with
>> >>> snapshots
>> >> and allowing volumes to be detached causes quite a bug:
>> >>>
>> >>> 1) Attach a data disk to a VM
>> >>> 2) Snapshot the VM
>> >>> 3) Detach the data disk
>> >>> 4) Attempt to restore the VM from the snapshot ‹ FAILS since the
>> >>> data
>> >> disk is no longer there, although it is expected to be
>> >>> 5) Attempt to re-attach the volume to the VM ‹ FAILS since you
>> >>> cannot
>> >> attach volumes to VMs with snapshots
>> >>> 6) Attempt to delete the VM snapshot ‹ FAILS since the data disk
>> is
>> >>> no
>> >> longer there, although it is expected to be
>> >>>
>> >>> I have verified the above steps on VMWare, however Xen does not
>> >>> appear
>> >> to fail on step 4, presumably because VMWare handles snapshots
>> quite
>> >> differently than Xen.
>> >>>
>> >>> Does anyone else have any thoughts on whether this is a bug or
>> not?
>>  IMO,
>> >> on VMWare, this set of steps can get users into a state where they
>> >> can
>>  no
>> >> longer attach new data disks to their VM, so it appears to be a bug
>> >> of
>>  some
>> >> kind.
>> >>>
>> >>> -Chris
>> >>> --
>> >>> Chris Suich
>> >>> chris.su...@netapp.com
>> >>> NetApp Software Engineer
>> >>> Data Center Platforms ­ Cloud Solutions
>> >>> Citrix, Cisco & Red Hat
>> >>>
>> >>
>> >>
>> >
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> >

Re: Bug? Should we allow detaching volumes when VMs have snapshots

[Mike Tutkowski]

I can see the appeal in consistent behavior, but I'm not sure we want
CloudStack to always follow a least-common-denominator approach.

Personally I recommend we leave XenServer's functionality here as is.


On Thu, Nov 7, 2013 at 6:14 AM, SuichII, Christopher  wrote:

> Thanks for replying, Kelvin.
>
> Now, should we only not allow this on VMWare, or should we prohibit it on
> XenServer as well. It appears to work fine on XenServer, but it may be a
> good idea to have a consistent experience, regardless of hypervisor.
>
> -Chris
> --
> Chris Suich
> chris.su...@netapp.com
> NetApp Software Engineer
> Data Center Platforms – Cloud Solutions
> Citrix, Cisco & Red Hat
>
> On Nov 6, 2013, at 9:09 PM, Kelven Yang  wrote:
>
> > We should dis-allow detaching volume from VM when it has VM snapshots.
> > VMware keeps VM snapshot meta information at VM basis, disk membership
> > change behind its back will cause problem and it does not provide
> official
> > API to manipulate at volume level for a VM snapshot.
> >
> > This is a bug
> >
> > Kelven
> >
> > On 11/6/13, 5:58 AM, "SuichII, Christopher" 
> wrote:
> >
> >> Bumping this. I believe we need the imput of a VMWare expert, please.
> >>
> >> -Chris
> >> --
> >> Chris Suich
> >> chris.su...@netapp.com
> >> NetApp Software Engineer
> >> Data Center Platforms ­ Cloud Solutions
> >> Citrix, Cisco & Red Hat
> >>
> >> On Nov 5, 2013, at 1:46 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com>
> >> wrote:
> >>
> >>> OK, well, depending on if we can or can't get a VMware person to chime
> >>> in
> >>> on this issue, we may have to disallow disks from being detached from
> >>> VMware VMs with snapshots in 4.3.
> >>>
> >>>
> >>> On Tue, Nov 5, 2013 at 11:44 AM, SuichII, Christopher <
> >>> chris.su...@netapp.com> wrote:
> >>>
>  Correct.
> 
>  #6 FAILS with VMWare and SUCCEEDS with Xen
> 
>  --
>  Chris Suich
>  chris.su...@netapp.com
>  NetApp Software Engineer
>  Data Center Platforms ­ Cloud Solutions
>  Citrix, Cisco & Red Hat
> 
>  On Nov 5, 2013, at 1:35 PM, Mike Tutkowski
>  
>  wrote:
> 
> > I assume 6 fails with VMware, as well?
> >
> > Is Xen OK with 6?
> >
> >
> > On Tue, Nov 5, 2013 at 11:26 AM, SuichII, Christopher <
> > chris.su...@netapp.com> wrote:
> >
> >> FWIW, after looking into this more with Xen, when the VM is restored
> >> in
> >> step 4, it simply no longer has the volume attached, so this appears
> >> to
> >> really be a VMWare issue. Any VMWare experts out there know how we
> >> can
> >> handle this?
> >>
> >> -Chris
> >> --
> >> Chris Suich
> >> chris.su...@netapp.com
> >> NetApp Software Engineer
> >> Data Center Platforms ­ Cloud Solutions
> >> Citrix, Cisco & Red Hat
> >>
> >> On Nov 5, 2013, at 1:05 PM, SuichII, Christopher <
>  chris.su...@netapp.com>
> >> wrote:
> >>
> >>> We currently don¹t allow volumes to be attached to VMs with
> >>> snapshots
> >> and allowing volumes to be detached causes quite a bug:
> >>>
> >>> 1) Attach a data disk to a VM
> >>> 2) Snapshot the VM
> >>> 3) Detach the data disk
> >>> 4) Attempt to restore the VM from the snapshot ‹ FAILS since the
> >>> data
> >> disk is no longer there, although it is expected to be
> >>> 5) Attempt to re-attach the volume to the VM ‹ FAILS since you
> >>> cannot
> >> attach volumes to VMs with snapshots
> >>> 6) Attempt to delete the VM snapshot ‹ FAILS since the data disk is
> >>> no
> >> longer there, although it is expected to be
> >>>
> >>> I have verified the above steps on VMWare, however Xen does not
> >>> appear
> >> to fail on step 4, presumably because VMWare handles snapshots quite
> >> differently than Xen.
> >>>
> >>> Does anyone else have any thoughts on whether this is a bug or not?
>  IMO,
> >> on VMWare, this set of steps can get users into a state where they
> >> can
>  no
> >> longer attach new data disks to their VM, so it appears to be a bug
> >> of
>  some
> >> kind.
> >>>
> >>> -Chris
> >>> --
> >>> Chris Suich
> >>> chris.su...@netapp.com
> >>> NetApp Software Engineer
> >>> Data Center Platforms ­ Cloud Solutions
> >>> Citrix, Cisco & Red Hat
> >>>
> >>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > * *
> 
> 
> >>>
> >>>
> >>> --
> >>> *Mike Tutkowski*
> >>> *Senior CloudStack Developer, SolidFire Inc.*
> >>> e: mike.tutkow...@solidfire.com
> >>> o: 303.746.7302
> >>> Advancing the way the world uses the
> >>> cloud
> >

RE: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Animesh Chaturvedi]

Ok I closed out the review as "submitted"

> -Original Message-
> From: Mike Tutkowski [mailto:nore...@reviews.apache.org] On Behalf Of
> Mike Tutkowski
> Sent: Thursday, November 07, 2013 1:03 PM
> To: Edison Su; Mike Tutkowski
> Cc: Marcus Sorensen; cloudstack
> Subject: Re: Review Request 14381: KVM: add connect/disconnect
> capabilities to StorageAdaptors so that external storage services can
> attach/detach devices on-demand
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14381/#review28443
> ---
> 
> Ship it!
> 
> 
> Ship It!
> 
> - Mike Tutkowski
> 
> 
> On Sept. 30, 2013, 5:14 p.m., Marcus Sorensen wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/14381/
> > ---
> >
> > (Updated Sept. 30, 2013, 5:14 p.m.)
> >
> >
> > Review request for cloudstack, edison su and Mike Tutkowski.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > ---
> >
> > With custom storage plugins comes the need to prep the KVM host prior
> to utilizing the disks. e.g. an iscsi initiator needs to log into the
> target and scan for the lun before it can be used on the host. This
> patch is an example I developed against 4.2, minor changes may be
> necessary to apply to master, but I want to share with others who are
> working on storage so they can ensure it works for them. Please tweak as
> you see fit.
> >
> > MigrateCommand: pass vmTO object so we can see which disks/storage
> pool types belong to the vm when migrating a VM. This facilitates being
> able to call disconnectPhysicalDisksViaVmSpec
> >
> > VirtualMachineManagerImpl: pass VirtualMachineTO when migrating so
> that we can see which disks belong to the VM and what storage
> pools/adaptors should be used
> >
> > LibvirtComputingResource: add calls KVMStoragePoolManager's
> connectPhysicalDiskViaVmSpec and disconnectPhysicalDiskViaVmSpec calls
> where appropriate (when starting a vm, migrating a vm). Ensure that we
> create 'raw' format XML disk definitions when the storage format is RAW.
> Move cleanupDisk logic to storage adaptors so that each adaptor type can
> clean up its disks in is own way.
> >
> > KVMStoragePoolManager:  add connectPhysicalDisk,
> disconnectPhysicalDisk, connectPhysicalDiskViaVmSpec,
> disconnectPhysicalDiskViaVmSpec, disconnectPhysicalDiskByPath. These all
> call the specific StorageAdaptor's connectPhysicalDisk,
> disconnectPhysicalDisk, or disconnectPhysicalDiskByPath calls.
> >
> > KVMStorageProcessor: Call connectPhysicalDisk/disconnectPhysicalDisk
> on the storage adaptor. Whether or not this is implemented is up to the
> storage adaptor.
> >
> > LibvirtStorageAdaptor: implement dummy
> connectPhysicalDisk/disconnectPhysicalDisk, move cleanupDisk logic from
> LibvirtComputingResource to disconnectPhysicalDiskByPath
> >
> > StorageAdaptor: define
> connectPhysicalDisk/disconnectPhysicalDisk/disconnectPhysicalDiskByPath
> in the interface
> >
> >
> > Diffs
> > -
> >
> >   core/src/com/cloud/agent/api/MigrateCommand.java 5042b8c
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtCom
> putingResource.java 3ee811f
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageP
> oolManager.java e09c9ba
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageP
> rocessor.java c69f9b0
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStor
> ageAdaptor.java 123a9f1
> >
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdap
> tor.java 4956d8d
> >   server/src/com/cloud/vm/VirtualMachineManagerImpl.java d46bbb0
> >
> > Diff: https://reviews.apache.org/r/14381/diff/
> >
> >
> > Testing
> > ---
> >
> > Basic testing with my storage adaptor
> >
> >
> > Thanks,
> >
> > Marcus Sorensen
> >
> >

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Mike Tutkowski]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14381/#review28443
---

Ship it!


Ship It!

- Mike Tutkowski


On Sept. 30, 2013, 5:14 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14381/
> ---
> 
> (Updated Sept. 30, 2013, 5:14 p.m.)
> 
> 
> Review request for cloudstack, edison su and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> With custom storage plugins comes the need to prep the KVM host prior to 
> utilizing the disks. e.g. an iscsi initiator needs to log into the target and 
> scan for the lun before it can be used on the host. This patch is an example 
> I developed against 4.2, minor changes may be necessary to apply to master, 
> but I want to share with others who are working on storage so they can ensure 
> it works for them. Please tweak as you see fit.
> 
> MigrateCommand: pass vmTO object so we can see which disks/storage pool types 
> belong to the vm when migrating a VM. This facilitates being able to call 
> disconnectPhysicalDisksViaVmSpec
> 
> VirtualMachineManagerImpl: pass VirtualMachineTO when migrating so that we 
> can see which disks belong to the VM and what storage pools/adaptors should 
> be used
> 
> LibvirtComputingResource: add calls KVMStoragePoolManager's 
> connectPhysicalDiskViaVmSpec and disconnectPhysicalDiskViaVmSpec calls where 
> appropriate (when starting a vm, migrating a vm). Ensure that we create 'raw' 
> format XML disk definitions when the storage format is RAW. Move cleanupDisk 
> logic to storage adaptors so that each adaptor type can clean up its disks in 
> is own way.
> 
> KVMStoragePoolManager:  add connectPhysicalDisk, disconnectPhysicalDisk, 
> connectPhysicalDiskViaVmSpec, disconnectPhysicalDiskViaVmSpec, 
> disconnectPhysicalDiskByPath. These all call the specific StorageAdaptor's 
> connectPhysicalDisk, disconnectPhysicalDisk, or disconnectPhysicalDiskByPath 
> calls.
> 
> KVMStorageProcessor: Call connectPhysicalDisk/disconnectPhysicalDisk on the 
> storage adaptor. Whether or not this is implemented is up to the storage 
> adaptor.
> 
> LibvirtStorageAdaptor: implement dummy 
> connectPhysicalDisk/disconnectPhysicalDisk, move cleanupDisk logic from 
> LibvirtComputingResource to disconnectPhysicalDiskByPath
> 
> StorageAdaptor: define 
> connectPhysicalDisk/disconnectPhysicalDisk/disconnectPhysicalDiskByPath in 
> the interface
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/MigrateCommand.java 5042b8c 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
>  3ee811f 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
>  e09c9ba 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
>  c69f9b0 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  123a9f1 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java
>  4956d8d 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java d46bbb0 
> 
> Diff: https://reviews.apache.org/r/14381/diff/
> 
> 
> Testing
> ---
> 
> Basic testing with my storage adaptor
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Mike Tutkowski]

> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote:
> > This looks reasonable to me, Marcus.
> > 
> > When do you think you might start the process of getting this into master?
> 
> Animesh Chaturvedi wrote:
> is this expected for 4.3? then this should be in master soon

This code has been committed to master. We are good to go. :)


- Mike


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14381/#review26748
---


On Sept. 30, 2013, 5:14 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14381/
> ---
> 
> (Updated Sept. 30, 2013, 5:14 p.m.)
> 
> 
> Review request for cloudstack, edison su and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> With custom storage plugins comes the need to prep the KVM host prior to 
> utilizing the disks. e.g. an iscsi initiator needs to log into the target and 
> scan for the lun before it can be used on the host. This patch is an example 
> I developed against 4.2, minor changes may be necessary to apply to master, 
> but I want to share with others who are working on storage so they can ensure 
> it works for them. Please tweak as you see fit.
> 
> MigrateCommand: pass vmTO object so we can see which disks/storage pool types 
> belong to the vm when migrating a VM. This facilitates being able to call 
> disconnectPhysicalDisksViaVmSpec
> 
> VirtualMachineManagerImpl: pass VirtualMachineTO when migrating so that we 
> can see which disks belong to the VM and what storage pools/adaptors should 
> be used
> 
> LibvirtComputingResource: add calls KVMStoragePoolManager's 
> connectPhysicalDiskViaVmSpec and disconnectPhysicalDiskViaVmSpec calls where 
> appropriate (when starting a vm, migrating a vm). Ensure that we create 'raw' 
> format XML disk definitions when the storage format is RAW. Move cleanupDisk 
> logic to storage adaptors so that each adaptor type can clean up its disks in 
> is own way.
> 
> KVMStoragePoolManager:  add connectPhysicalDisk, disconnectPhysicalDisk, 
> connectPhysicalDiskViaVmSpec, disconnectPhysicalDiskViaVmSpec, 
> disconnectPhysicalDiskByPath. These all call the specific StorageAdaptor's 
> connectPhysicalDisk, disconnectPhysicalDisk, or disconnectPhysicalDiskByPath 
> calls.
> 
> KVMStorageProcessor: Call connectPhysicalDisk/disconnectPhysicalDisk on the 
> storage adaptor. Whether or not this is implemented is up to the storage 
> adaptor.
> 
> LibvirtStorageAdaptor: implement dummy 
> connectPhysicalDisk/disconnectPhysicalDisk, move cleanupDisk logic from 
> LibvirtComputingResource to disconnectPhysicalDiskByPath
> 
> StorageAdaptor: define 
> connectPhysicalDisk/disconnectPhysicalDisk/disconnectPhysicalDiskByPath in 
> the interface
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/MigrateCommand.java 5042b8c 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
>  3ee811f 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
>  e09c9ba 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
>  c69f9b0 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  123a9f1 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java
>  4956d8d 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java d46bbb0 
> 
> Diff: https://reviews.apache.org/r/14381/diff/
> 
> 
> Testing
> ---
> 
> Basic testing with my storage adaptor
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

Re: Review Request 15313: Updated VMSnapshotDetails* to match *Details* pattern (e.g. UserVMDetails*)

[Chris Suich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15313/
---

(Updated Nov. 7, 2013, 9 p.m.)


Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

VMSnapshotDetailsDao/Impl/VO were not using the ResourceDetails/Dao/Base 
pattern which caused issues with adding details and did not give access to 
useful methods like the detail getters/deleters.


Diffs
-

  engine/schema/src/com/cloud/vm/snapshot/VMSnapshotDetailsVO.java 934dd92 
  engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDao.java e84178c 
  engine/schema/src/com/cloud/vm/snapshot/dao/VMSnapshotDetailsDaoImpl.java 
b528b39 
  
engine/storage/integration-test/test/com/cloud/vm/snapshot/dao/VmSnapshotDaoTest.java
 fc52f89 

Diff: https://reviews.apache.org/r/15313/diff/


Testing (updated)
---

This has been tested locally with a custom plugin. However, the changes are not 
used by the existing CloudStack codebase and should not impact any existing 
workflows or use cases. They are simply for plugins to take advantage of.


Thanks,

Chris Suich

Re: Review Request 15309: Fixed bug with deleting VMWare VM Snapshots

[Chris Suich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15309/
---

(Updated Nov. 7, 2013, 9 p.m.)


Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

A bug was introduced in a6ce66e55a65eb0fbae9ead92de6ceac7a87c531 which does not 
allow VMWare VM snapshots to be deleted.

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=a6ce66e55a65eb0fbae9ead92de6ceac7a87c531

In refactoring, volumeTo.getPoolUuid() was supposed to be changed to 
store.getUuid() but was actually changed to volumeTo.getUuid().


Diffs
-

  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 0e2423e 

Diff: https://reviews.apache.org/r/15309/diff/


Testing (updated)
---

This has been tested locally with a custom plugin. However, the changes are not 
used by the existing CloudStack codebase and should not impact any existing 
workflows or use cases. They are simply for plugins to take advantage of.


Thanks,

Chris Suich

Review Request 15326: Added option to reload VM during in RevertToVMSnapshotCommand

[Chris Suich]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15326/
---

Review request for cloudstack and edison su.


Repository: cloudstack-git


Description
---

Added option to reload VM during in RevertToVMSnapshotCommand. For now, only in 
VMWare as I don't believe that XenServer supports anything similar.

This gives plugins which may have unique snapshot strategies the ability to 
request the hypervisor to reload the VM's state before attempting to revert to 
a snapshot.


Diffs
-

  core/src/com/cloud/agent/api/RevertToVMSnapshotCommand.java 1e5fd6c 
  
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 0e2423e 

Diff: https://reviews.apache.org/r/15326/diff/


Testing
---

This has been tested locally with a custom plugin. However, the changes are not 
used by the existing CloudStack codebase and should not impact any existing 
workflows or use cases. They are simply for plugins to take advantage of.


Thanks,

Chris Suich

Re: Review Request 15068: Change labels for VLAN to vNet

[Yoshikazu Nojima]

> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote:
> > Ship It!
> 
> Animesh Chaturvedi wrote:
> Has this been applied?

Yes, it has.
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=5ccf3a90abb79eace839a8e61cf950248aa913c8


- Yoshikazu


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review28144
---


On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> ---
> 
> (Updated Nov. 1, 2013, 4:52 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, 
> Pranav Saxena, and Toshiaki Hatano.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> We would like to change the labels for VLAN to vNet to make the term more 
> generic for VXLAN and VLAN. This relates to the work being done to add in 
> VXLAN support to Cloudstack.
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 3210aca 
>   ui/dictionary.jsp 35cba22 
>   ui/scripts/network.js 12e5389 
>   ui/scripts/system.js 479883c 
> 
> Diff: https://reviews.apache.org/r/15068/diff/
> 
> 
> Testing
> ---
> 
> Checked through the GUI for changed elements.
> 
> 
> Thanks,
> 
> Chris Cameron
> 
>

Review Request 15323: CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator

[David Grizzanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15323/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-5080
https://issues.apache.org/jira/browse/CLOUDSTACK-5080


Repository: cloudstack-git


Description
---

CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator
- Added new SQL file to db/setup so that a row gets inserted during simulator 
DB setup for a 'Simulator' hypervisor (in hypervisor_capabilities).
- Updated developer/pom.xml to include this new file


Diffs
-

  developer/pom.xml 0eb18bf 
  setup/db/hypervisor_capabilities.simulator.sql PRE-CREATION 

Diff: https://reviews.apache.org/r/15323/diff/


Testing
---

Tested on master and 4.2


Thanks,

David Grizzanti

Re: Question: Error when creating templates from ROOT volumes in the Simulator

[David Grizzanti]

Prasanna,

I took a look at the SimulatorImageStoreDriverImpl, but it seems like it's
setting size correctly in that case.  Also, in trying to step through the
code, that section doesn't appear to be called when creating a template
from a ROOT volume (I could be doing something wrong though when stepping
through the code in debug mode).  You mentioned that it may have been
something you missed when updating aft erhte 4.2 storage refactor - is
there some other plugin code that I can look at for one of the other
hypervisors that might shed some light on the correct way to do this?

Thanks!


On Tue, Nov 5, 2013 at 9:09 AM, David Grizzanti  wrote:

> Ok, thanks Prasanna. Will have a look and let you know what I find.
>
>
> On Tuesday, November 5, 2013, Prasanna Santhanam wrote:
>
>> This is a bug. Likely something I missed when adopting the simulator
>> to the storage refactor in 4.2. You'd want to look at the
>> SimulatorImageStoreDriverImpl.java#createTemplate() and see how the
>> template gets registered with 0 size.
>>
>> On Tue, Nov 05, 2013 at 02:54:00AM -0500, Sebastien Goasguen wrote:
>> > Pinging Prasanna on this,
>> >
>> >
>> > On Oct 31, 2013, at 5:07 PM, David Grizzanti <
>> david.grizza...@sungard.com> wrote:
>> >
>> > > Hi All,
>> > >
>> > > I have been seeing an issue with the Simulator that I was hoping
>> someone
>> > > could provide some insight into.
>> > >
>> > > Some background. I'm running from the 4.2.0 tag on rhel 6.3, building
>> from
>> > > source/enabling the simulator.
>> > >
>> > > Overall, most operations seem to work fine, however, I noticed that
>> when
>> > > creating a template from the ROOT volume on a VM, the template can't
>> then
>> > > be used to create a subsequent VM.  The reason for this seems to be
>> that
>> > > the "size" of the template is set to 0.  After digging through the
>> database
>> > > a bit, I discovered that the size and physical_size columns in
>> > > the template_store_ref table are set to 0 for these templates.  If I
>> > > correct those values for my entry after the fact, everything appears
>> to
>> > > work.
>> > >
>> > > I dug around in the code a bit as well, but nothing obvious was
>> jumping out
>> > > at me as to why this was happening.
>> > >
>> > > Any thoughts?
>> > >
>> > > Thanks!
>> > >
>> > > --
>> > > David Grizzanti
>> > > Software Engineer
>> > > Sungard Availability Services
>> > >
>> > > e: david.grizza...@sungard.com
>> > > w: 215.446.1431
>> > > c: 570.575.0315
>>
>> --
>> Prasanna.,
>>
>> 
>> Powered by BigRock.com
>>
>>
>>
>
> --
> David Grizzanti
> Software Engineer
> Sungard Availability Services
>
> e: david.grizza...@sungard.com
> w: 215.446.1431
> c: 570.575.0315
>
>


-- 
David Grizzanti
Software Engineer
Sungard Availability Services

e: david.grizza...@sungard.com
w: 215.446.1431
c: 570.575.0315

Re: [Merge] Palo Alto Networks firewall integration to master

[Chip Childers]

On Thu, Nov 07, 2013 at 06:59:25PM +, Animesh Chaturvedi wrote:
> mvn --projects='org.apache.cloudstack:cloudstack' 
> org.apache.rat:apache-rat-plugin:0.8:check

s/0.8/0.10 if you want the latest

Re: Enabling AMQP/RabbitMQ Events on master

[David Grizzanti]

Alena,

I don't think these steps will work on master (not installing packages of
cloudstack), I'm building from source.  The componentContext XML file
doesn't seem to exist anymore since some of the Spring refactoring was done.

Thanks


On Thu, Nov 7, 2013 at 12:42 PM, Alena Prokharchyk <
alena.prokharc...@citrix.com> wrote:

>  David,
>
>  Here are the instructions that I've got from one of the CS QA engineers,
> hope it helps.
>
>  FS -
> http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Admin_Guide/events.html#event-framework
>
>
>
> Test cases relating to this feature was covered as part of Regions Feature
> testing -
> https://cwiki.apache.org/confluence/download/attachments/30757955/Regions-Test-Execution-42.xlsx
>
>
>
>
>
> Steps to set up RabbitMQ Server:
>
>
>
> Have a RabbitMQ server set up.
>
> Enable rabbitmq_management plugin
>
> C:\Program Files\RabbitMQ
> Server\rabbitmq_server-3.0.3\sbin>rabbitmq-plugins enable
> rabbitmq_management
>
> Restart RabbitMQ service.
>
> In management server :
> Added the following in
> /usr/share/cloudstack-management/webapps/client/WEB-INF/classes/componentContext.xml
>
>
>  class="org.apache.cloudstack.mom.rabbitmq.RabbitMQEventBus">
> 
> 
> 
>
> 
> 
>
>   
>
> Restart management server.
>
>
>  -Alena.
>
>   From: David Grizzanti 
> Reply-To: "dev@cloudstack.apache.org" 
> Date: Thursday, November 7, 2013 5:04 AM
> To: "dev@cloudstack.apache.org" 
> Subject: Enabling AMQP/RabbitMQ Events on master
>
>   Hi,
>
>  I was looking for some help in enabling the AMQP/RabbitMQ events in
> CloudStack.  I'm familiar with enabling these events in 4.2, however, I'm
> not all the familiar with Spring and given the new modularized changes I'm
> not really sure where the XML snippet belongs for the eventNotificationBus.
> Previously I had been placing this in applicationContext.xml (or the
> simulatorComponentContext.xml in the case of the Simulator).
>
>  If you could point me in the right direction that would be great.
>
>  Thanks!
>
>  XML sample for reference:
>  class="org.apache.cloudstack.mom.rabbitmq.RabbitMQEventBus">
> 
> 
> 
> 
> 
>
> 
>
>  --
> David Grizzanti
> Software Engineer
> Sungard Availability Services
>
>  e: david.grizza...@sungard.com
> w: 215.446.1431
> c: 570.575.0315
>
>


-- 
David Grizzanti
Software Engineer
Sungard Availability Services

e: david.grizza...@sungard.com
w: 215.446.1431
c: 570.575.0315

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

[Travis Graham]

> On Nov. 7, 2013, 2:38 p.m., Sebastien Goasguen wrote:
> > this does not seem to apply. Can you please pull the latest and see what's 
> > going on 
> > 
> > thanks

Do you want this based against master or 4.2? The patch was originally created 
against 4.2.


- Travis


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14784/#review28433
---


On Nov. 7, 2013, 1:53 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14784/
> ---
> 
> (Updated Nov. 7, 2013, 1:53 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> (section 4.5.7.2) reflect steps for RHEL/CentOS and Ubuntu.
> 
> 
> Diffs
> -
> 
>   en-US/nfs-shares-on-management-server.xml 881ca8d 
> 
> Diff: https://reviews.apache.org/r/14784/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

[Chip Childers]

On Thu, Nov 7, 2013 at 2:37 PM, Chiradeep Vittal
 wrote:
> It may be an admin burden, but it has to be optional. There are other ways
> to achieve global sync (e.g., LDAP/AD/Oauth).
> A lot of service providers who run cloudstack have their own user database
> / portal. In their implementations the CloudStack database is not the
> master source of user records, but a slave.

+1 to it being optional.

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

[Sebastien Goasguen]

> On Nov. 7, 2013, 7:34 p.m., Sebastien Goasguen wrote:
> > Ship It!

applied to master docs repo: 1f4822a75e2c100e19f2af8044ea6d767762d6ef


- Sebastien


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14786/#review28430
---


On Nov. 7, 2013, 6:52 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14786/
> ---
> 
> (Updated Nov. 7, 2013, 6:52 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> (sections 2.3 and 2.4) Updated references to organization unit within 
> CloudStack for Pods and Clusters
> 
> 
> Diffs
> -
> 
>   en-US/about-clusters.xml d2f0220 
>   en-US/about-pods.xml 57ae1a3 
> 
> Diff: https://reviews.apache.org/r/14786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14783/#review28435
---

Ship it!


applied to master: 5e6d003c57474c2e6c0d75e009e390468f67ab2e
please mark review as submitted
thanks

- Sebastien Goasguen


On Nov. 7, 2013, 6:53 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14783/
> ---
> 
> (Updated Nov. 7, 2013, 6:53 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> (Section 12.13.2) Removes the windows MSI link from the linux section and 
> corrects the MSI link in the windows section.
> 
> 
> Diffs
> -
> 
>   en-US/linux-installation.xml 14a2f51 
>   en-US/windows-installation.xml bcecc80 
> 
> Diff: https://reviews.apache.org/r/14783/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

[Chiradeep Vittal]

It may be an admin burden, but it has to be optional. There are other ways
to achieve global sync (e.g., LDAP/AD/Oauth).
A lot of service providers who run cloudstack have their own user database
/ portal. In their implementations the CloudStack database is not the
master source of user records, but a slave.

On 11/5/13 12:41 PM, "Chip Childers"  wrote:

>Alex,
>
>I've moved your page to the "Designs not committed to a release"
>parent (instead of the 4.3 designs page), to align with both the Jira
>record *and* the fact that feature freeze is about to happen for 4.3.
>
>As for the proposal itself, I have a couple of suggestions:
>
>1) I'd like to see the implementation be part of the ACS runtime.
>Having a separate python app for this sync feature seems like an admin
>burden.
>
>2) As far as the design document itself, I think that we need to see
>more details on the proposed approach to sync, failure condition
>handling, etc...
>
>-chip
>
>
>On Mon, Nov 4, 2013 at 3:16 PM, Alex Ough  wrote:
>> All,
>>
>> Among the 2 approaches, I uploaded the implemented codes of the first
>> approach, master-slave architecture, here.
>> https://github.com/alexoughsg/albatross
>>
>> And here is the design doc in the wiki.
>> 
>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-Use
>>r+Sync+Up+Among+Multiple+Regions
>>
>> Please review them and let me know what you think if you're interested!
>> Thanks
>> Alex Ough
>>
>>
>>
>> On Thu, Oct 31, 2013 at 6:51 PM, Alex Ough 
>>wrote:
>>
>>> Great! Thanks a lot, Daan.
>>>
>>>
>>> On Thu, Oct 31, 2013 at 4:58 PM, Daan Hoogland
>>>wrote:
>>>
 you are added to jira, Alex

 On Thu, Oct 31, 2013 at 8:31 PM, Alex Ough 
wrote:
 > Thanks Chip, and can you also give a permission in Jira so that I
can
 > assign myself in its jira?
 >
 > Alex Ough
 >
 >
 > On Thu, Oct 31, 2013 at 2:00 PM, Chip Childers
>>> >wrote:
 >
 >> Permission added.
 >>
 >> On Wed, Oct 30, 2013 at 12:19:23PM -0500, Alex Ough wrote:
 >> > And I'd like to write the design document in the wiki page, but I
 don't
 >> > seem to have a permission to create pages.
 >> > So can anyone give me the permission?
 >> >
 >> > My account in the wiki is alex.o...@sungard.com
 >> >
 >> > Thanks in advance.
 >> > Alex Ough
 >> >
 >> >
 >> > On Tue, Oct 29, 2013 at 3:38 PM, Alex Ough

 >> wrote:
 >> >
 >> > > I created a jira for this feature.
 >> > >
 >> > > https://issues.apache.org/jira/browse/CLOUDSTACK-4992
 >> > >
 >> > > But it doesn't allow for me to assign it to myself, so any
 permission
 >> do I
 >> > > need for this?
 >> > > If so, can anyone give me this permission?
 >> > >
 >> > > If there is anything missing, let me know.
 >> > > Thanks
 >> > > Alex Ough
 >> > >
 >> > >
 >> > > On Fri, Oct 18, 2013 at 9:30 AM, Kishan Kavala <
 >> kishan.kav...@citrix.com>wrote:
 >> > >
 >> > >> > -Original Message-
 >> > >> > From: Alex Ough [mailto:alex.o...@sungard.com]
 >> > >> > Sent: Thursday, 17 October 2013 11:25 PM
 >> > >> > To: dev@cloudstack.apache.org; u...@cloudstack.apache.org
 >> > >> > Subject: Fwd: [DISCUSS] Domain/Account/User Sync Up Among
 Multiple
 >> > >> > Regions
 >> > >> >
 >> > >> > All,
 >> > >> >
 >> > >> > Currently, under the environment of cloudstack with multiple
 >> regions,
 >> > >> each
 >> > >> > region has its own management server running with a separate
 >> database.
 >> > >> So if
 >> > >> > we want to support multiple regions and provide one point of
 entry
 >> for a
 >> > >> > customer, we need to duplicate domain/account/user
information
 of
 >> that
 >> > >> > customer to all of the databases of regions the customer
 accesses,
 >> > >> which will
 >> > >> > cause data discrepancies when users update those data
 independently
 >> in
 >> > >> each
 >> > >> > management server.
 >> > >> >
 >> > >> > So I'd like to provide a way to sync up the data using the
 messaging
 >> > >> system
 >> > >> > introduced in 4.1.0. Using the events from each management
 server,
 >> > >> updates
 >> > >> > from each region can be propagated to the rest regions and
they
 can
 >> be
 >> > >> > executed accordingly.
 >> > >> >
 >> > >> > I hope you guys have a chance to think about this and give
some
 >> > >> feedbacks if
 >> > >> > interested.
 >> > >> > Thanks in advance.
 >> > >> > Alex Ough
 >> > >>
 >> > >> [KK] Alex, it was discussed sometime back. Related thread [1].
 Sync up
 >> > >> using messaging system is the right way to go.
 >> > >>
 >> > >>
 >> > >> [1]
 >> > >>
 >>
 
http://www.mail-archive.com/cloudstack-dev@incubator.apache.org/msg2019
>

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14784/#review28433
---


this does not seem to apply. Can you please pull the latest and see what's 
going on 

thanks

- Sebastien Goasguen


On Nov. 7, 2013, 6:53 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14784/
> ---
> 
> (Updated Nov. 7, 2013, 6:53 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> (section 4.5.7.2) reflect steps for RHEL/CentOS and Ubuntu.
> 
> 
> Diffs
> -
> 
>   en-US/nfs-shares-on-management-server.xml 881ca8d 
> 
> Diff: https://reviews.apache.org/r/14784/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14785/#review28432
---

Ship it!


applied to master: 7229caff6eef3d5ed9b0bb282a593eb3425365a0
thanks please mark review as submitted

- Sebastien Goasguen


On Nov. 7, 2013, 6:52 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14785/
> ---
> 
> (Updated Nov. 7, 2013, 6:52 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> Corrects the two references in Release Notes.
> 
> 
> Diffs
> -
> 
>   release-notes/en-US/Release_Notes.xml a65cca9 
> 
> Diff: https://reviews.apache.org/r/14785/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14786/#review28430
---

Ship it!


Ship It!

- Sebastien Goasguen


On Nov. 7, 2013, 6:52 p.m., Travis Graham wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14786/
> ---
> 
> (Updated Nov. 7, 2013, 6:52 p.m.)
> 
> 
> Review request for cloudstack and Joe Brockmeier.
> 
> 
> Repository: cloudstack-docs
> 
> 
> Description
> ---
> 
> (sections 2.3 and 2.4) Updated references to organization unit within 
> CloudStack for Pods and Clusters
> 
> 
> Diffs
> -
> 
>   en-US/about-clusters.xml d2f0220 
>   en-US/about-pods.xml 57ae1a3 
> 
> Diff: https://reviews.apache.org/r/14786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Travis Graham
> 
>

Re: Reviewboard needs your attention

[Sebastien Goasguen]

I hate to move deadline, but it might be good to have couple days to try to 
clean review board.

-Sebastien

On 7 Nov 2013, at 19:26, Animesh Chaturvedi  
wrote:

> There are large number of patches in review board. I went through some of 
> them and followed up and closed out few that are already checked in, but the 
> list is huge. Given that we are approaching the 4.3 feature freeze tomorrow 
> if you have submitted patches and are still pending reviews please reach out 
> to your reviewers. If you have received feedback on your patch please provide 
> an updated patch. Reviewers take a moment to review the patches under your 
> name and help clear up the reviews.
> 
> 
> If you are unsure how to help please check Review Board Guidelines [1]
> 
> [1] 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

[Amogh Vasekar]

> On Aug. 1, 2013, 8:31 a.m., daan Hoogland wrote:
> > I think you need to rework this. Jenkins can't apply your patch and build 
> > it.

Reminder-
Hi,
The review has been pending for long. Please update the patch since the build 
fails.
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12185/#review24427
---


On June 29, 2013, 2:34 a.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12185/
> ---
> 
> (Updated June 29, 2013, 2:34 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code relies on classes in backport-util-concurrent, when these classes are 
> now available in the jdk supported by cloudstack.
> 
> Just switch the imports to the built in classes.
> 
> 
> Diffs
> -
> 
>   api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 
> 90759fe 
>   api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 
>   engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java
>  362f7a6 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java
>  d46048e 
>   
> plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java
>  0e4f8fd 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 
>   server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa 
>   server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 
>   server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d 
>   server/src/com/cloud/server/ManagementServerImpl.java 40bc437 
>   tools/whisker/descriptor-for-packaging.xml 66099ae 
>   utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 
>   utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 
>   utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 
>   vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java 
> cf5ffde 
> 
> Diff: https://reviews.apache.org/r/12185/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/#review28418
---


Reminder-
Hi,
The review has been pending for long. Please update the patch since the build 
is failing.
Thanks

- Amogh Vasekar


On June 29, 2013, 9:08 p.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12192/
> ---
> 
> (Updated June 29, 2013, 9:08 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> code checks the parameter 'state' and if null, set it to Allocated, even 
> though that parameter is never accessed. Meant to set the field 'state'.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 
> 
> Diff: https://reviews.apache.org/r/12192/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

Re: Review Request 14451: Some test for NetUtils

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14451/#review28417
---


Reminder-
Hi,
The review has been pending for long. Please update the patch based on the 
review comments.
Thanks

- Amogh Vasekar


On Oct. 4, 2013, 11:12 a.m., Laszlo Hornyak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14451/
> ---
> 
> (Updated Oct. 4, 2013, 11:12 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-4807
> https://issues.apache.org/jira/browse/CLOUDSTACK-4807
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> - tests added for mac2Long, byte2Mac, long2Mac, ip2Long and long2Ip
> - isWindows static method removed - it was not used
> - minor changes in the implementations of the tested methods
> 
> 
> Diffs
> -
> 
>   utils/src/com/cloud/utils/net/NetUtils.java 1e72e22 
>   utils/test/com/cloud/utils/net/NetUtilsTest.java 3cfc98f 
> 
> Diff: https://reviews.apache.org/r/14451/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 14603: fixed Rules

[Amogh Vasekar]

> On Oct. 13, 2013, 6:32 p.m., daan Hoogland wrote:
> > Ship It!

Reminder-
Hi,
The review has been pending for long. Please update the review status to 
"submitted" if it has already been committed.
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14603/#review26964
---


On Oct. 11, 2013, 6:39 p.m., Laszlo Hornyak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14603/
> ---
> 
> (Updated Oct. 11, 2013, 6:39 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> the implementation was broken, fixed for those who actually want to read the 
> output
> 
> 
> Diffs
> -
> 
>   engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5 
> 
> Diff: https://reviews.apache.org/r/14603/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 14604: Removing coded documentation

[Amogh Vasekar]

> On Oct. 13, 2013, 6:34 p.m., daan Hoogland wrote:
> > :)

Reminder-
Hi,
The review has been pending for long. Please update the review status if it has 
already been committed.
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14604/#review26965
---


On Oct. 11, 2013, 6:41 p.m., Laszlo Hornyak wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14604/
> ---
> 
> (Updated Oct. 11, 2013, 6:41 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the output of the program, the developer documentation may be a 
> better place
> 
> -
> 
> When developing against the CloudStack Orchestration Platform, you must 
> following the following rules:
> API Rule: Always be prepared to handle RuntimeExceptions.
> 
> When writing APIs, you must follow these rules:
> API Rule: You may think you're the greatest developer in the world but every 
> change to the API must be reviewed and approved.
> API Rule: Every API must have unit tests written against it.  And not it's 
> unit tests
> API Rule:
> 
> -
> 
> 
> Diffs
> -
> 
>   engine/api/src/org/apache/cloudstack/engine/Rules.java b700fa5 
> 
> Diff: https://reviews.apache.org/r/14604/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>

Re: Review Request 8294: Store NetworkServiceProvider connectivity service configuration in database.

[Amogh Vasekar]

> On Jan. 29, 2013, 9:43 a.m., Hugo Trippaers wrote:
> > The change looks good. Could you update the patch to the latest state of 
> > master?
> 
> Animesh Chaturvedi wrote:
> Hiroaki can you update the patch to latetst master.
> 
> Animesh Chaturvedi wrote:
> Any updates Hiroaki?

Reminder-
Hi,
The review has been pending for long. Hugo / Hiroaki - can you please update if 
this is still necessary, or needs to be discarded?
Thanks


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8294/#review15794
---


On Nov. 30, 2012, 12:17 p.m., Hiroaki Kawai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8294/
> ---
> 
> (Updated Nov. 30, 2012, 12:17 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> There are 13 services defined in com.cloud.network.Network.Service , but db 
> schema has 12 services with connecitivity missing in 
> `cloud`.`physical_network_service_providers` . This patch will fix this. In 
> the cloudstack api response, we'll see Connectivity service is enabled in 
> NiciraNvp network service provider servicelist like this:
> 
> {
> "listnetworkserviceprovidersresponse": {
> "count": 1,
> "networkserviceprovider": [
> {
> "physicalnetworkid": "80bf64a1-c5ca-4eb1-810e-76917a317d59",
> "servicelist": [
> "Connectivity"
> ],
> "name": "NiciraNvp",
> "destinationphysicalnetworkid": "0",
> "state": "Disabled",
> "id": "efb45f75-9fd7-43aa-9937-b5c871971c00"
> }
> ]
> }
> }
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/PhysicalNetworkServiceProvider.java 1b91311 
>   packaging/centos63/package.sh 83c0e5e 
>   server/src/com/cloud/network/dao/PhysicalNetworkServiceProviderVO.java 
> 12b08af 
>   server/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39 
>   setup/db/create-schema.sql fff084e 
>   setup/db/db/schema-40to41.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/8294/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

[Animesh Chaturvedi]

That's what I thought because you had said 7th morning

> -Original Message-
> From: Chip Childers [mailto:chip.child...@gmail.com]
> Sent: Thursday, November 07, 2013 10:59 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
> 11/08
> 
> I was off - this morning it cleared.  Sorry.
> 
> Merge away.
> 
> On Thu, Nov 7, 2013 at 1:55 PM, Chip Childers 
> wrote:
> > Please wait for tomorrow morning US time. 72 hours is not up yet.
> >
> >> On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi
>  wrote:
> >>
> >> Chip can you confirm if the IP clearance is done, should Devdeep
> proceed with merging into master?
> >>
> >>> -Original Message-
> >>> From: Chip Childers [mailto:chipchild...@apache.org]
> >>> Sent: Tuesday, November 05, 2013 9:36 AM
> >>> To: dev@cloudstack.apache.org
> >>> Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
> >>> 11/08
> >>>
> >>> One thing to note, and perhaps this becomes a minor exception to the
> >>> merge timing.  IP Clearance for the RDP client won't be done until
> >>> the morning of the 7th.
> >>>
> >>> I'd propose that it is brought in to master at that time.  I won't
> >>> have time to do the actual commit myself, but perhaps someone can
> >>> own handling this on the morning of the 7th (ET).  Any takers?
> >>>
> >>> -chip
> >>>
> >>> On Mon, Nov 4, 2013 at 9:58 PM, Animesh Chaturvedi
> >>>  wrote:
>  Folks
> 
>  Friday 11/8 is the feature freeze date for ACS 4.3. If your
> >>> contribution is unlikely to make it to 4.3 feature freeze on 11/8
> >>> please move them out of 4.3 release to 'Future'.
> 
>  Do remember that we have a 72 hour notice period to solicit
>  feedback
> >>> for MERGE requests. So the absolute last day for merge requests for
> >>> 4.3 features/ improvements is tomorrow 11/05. Contributors if you
> >>> have patches in reviewboard that you had planned for 4.3 make sure
> >>> to follow up with reviewers. The contribution has to be in master
> >>> after satisfying any merge concerns / review comments  by 11/08 to
> >>> be included  in 4.3.0 release.
> 
> 
>  For detailed branch merge requirement check [1]
> 
>  [1]
>  https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge
>  +Ex
>  pectations
> 
> 
>  Thanks
>  Animesh
> 
> 

Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11861/#review28410
---


Reminder-
Hi,
The review has been pending for long. Please update the request if this patch 
is still necessary or is to be discarded.
Thanks

- Amogh Vasekar


On Aug. 1, 2013, 11:39 a.m., daan Hoogland wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11861/
> ---
> 
> (Updated Aug. 1, 2013, 11:39 a.m.)
> 
> 
> Review request for cloudstack and John Burwell.
> 
> 
> Bugs: CLOUDSTACK-2968
> https://issues.apache.org/jira/browse/CLOUDSTACK-2968
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> double slash breaks windows based nfs servers [CLOUDSTACK-2968]
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 
>   core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 
> 98a957f 
>   core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 
>   core/src/com/cloud/storage/template/TemplateLocation.java 58d023a 
>   engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 
>   
> engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
>  a6880c3 
>   server/src/com/cloud/storage/download/DownloadListener.java 1d48803 
>   server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 
>   server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e 
>   server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba 
>   utils/src/com/cloud/utils/FileUtil.java 74f4088 
>   utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11861/diff/
> 
> 
> Testing
> ---
> 
> database analysis
> 
> 
> Thanks,
> 
> daan Hoogland
> 
>

Re: Review Request 14628: AutoScaling without NetScaler

[Amogh Vasekar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14628/#review28408
---


Reminder-
Hi,
The review has been pending for long. Please update the review status if it has 
already been committed.
Thanks

- Amogh Vasekar


On Oct. 15, 2013, 11:20 a.m., tuna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14628/
> ---
> 
> (Updated Oct. 15, 2013, 11:20 a.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> I made a patch to add autoscale feature without Netscaler.
> 
> Requirement:
> - Xenserver or XCP
> - Template with pre-installed PVdriver
> - don't use SNMP or NetScaler counters when configuring AutoScale
> - AutoScale acts within a Cluster
> 
> All configuration parameters (durations, interval, destroy_vm_grace_period, 
> quiet_time) are kept as normal.
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/network/as/AutoScaleCounter.java 
> ca7b65a39d4c063029293da1e1eb6832c11425a7 
>   api/src/com/cloud/network/as/AutoScalePolicy.java 
> 7f94f355921bba1ce149ff44f60a5c0e9a5cde28 
>   api/src/com/cloud/network/as/AutoScaleVmGroup.java 
> faa166d2baeb9e49cc064cf9da802a8e56219e00 
>   api/src/com/cloud/network/as/Counter.java 
> 207ec57b5920ad0a28088f37b1c3d5bb59c916fc 
>   client/tomcatconf/applicationContext.xml.in 
> 6dda5c707afddd1c20c97cb9a553590730682db3 
>   core/src/com/cloud/agent/api/PerformanceMonitorAnswer.java PRE-CREATION 
>   core/src/com/cloud/agent/api/PerformanceMonitorCommand.java PRE-CREATION 
>   engine/schema/src/com/cloud/network/as/AutoScalePolicyVO.java 
> f8fbcb483f52ddba3528e2f10644a7322716ce71 
>   engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVO.java 
> d1d85f9e2932f5ce5347e0b0be25af31a5f07066 
>   engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVmMapVO.java 
> PRE-CREATION 
>   engine/schema/src/com/cloud/network/as/CounterVO.java 
> b7b03f716b09c8600f8587b3c47124e228d643bb 
>   
> engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDao.java
>  30251984807f9556e8856b1a987ea01ca914a26b 
>   
> engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDaoImpl.java
>  00fee3db6c7e6ee6ab7493d38060267b78fd4ebb 
>   engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDao.java 
> PRE-CREATION 
>   
> engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java 
> PRE-CREATION 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  92fbab28bd24a115d6e933d58ab94390e357c9f7 
>   scripts/vm/hypervisor/xenserver/perfmon.py PRE-CREATION 
>   scripts/vm/hypervisor/xenserver/vmopspremium 
> 38ec2e8c1d8d4dfc9bf60df94bf9412d877d128e 
>   server/src/com/cloud/network/as/AutoScaleManager.java 
> 5b84b30d74415b7d3c278b6c2dd78fb39bea3668 
>   server/src/com/cloud/network/as/AutoScaleManagerImpl.java 
> 859211bd572a8a0d56ae6fd154788944db58fb24 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 
> 0cd3bcf6db05eddb5f6dfdd3e747d509d84c1164 
>   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 
> c685ee3e40ba1f1f597d25864957c0f04bea7825 
>   server/src/com/cloud/server/StatsCollector.java 
> b4ec9155faf829dd6da14d9aeb79fefb0a257db1 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 
> 6e879161276920c6baf6194fe8a73acec0dd0964 
>   setup/db/create-schema.sql 79550aee1bb53b9a707eb56911a3186f3475a5d9 
>   setup/db/db/schema-40to410.sql 24f6d4c5e1942232695279ce4dd926e591c4fcd0 
> 
> Diff: https://reviews.apache.org/r/14628/diff/
> 
> 
> Testing
> ---
> 
> Testing done with some simple scenario. Need help in testing units.
> 
> 
> Thanks,
> 
> tuna
> 
>

Re: [Merge] Palo Alto Networks firewall integration to master

[Will Stevens]

Perfect.  Thank you for the details.


On Thu, Nov 7, 2013 at 1:59 PM, Sheng Yang  wrote:

> Oh, that means something wrong with the license header of the file(header
> missing in this case).
>
> http://creadur.apache.org/rat/
>
> --Sheng
>
>
> On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens 
> wrote:
>
> > Just so I know, can you explain what it means to 'Fail RAT'?  Thx...
> >
> >
> > On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang  wrote:
> >
> > > Fixed.
> > >
> > > --Sheng
> > >
> > >
> > > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi <
> > > animesh.chaturv...@citrix.com> wrote:
> > >
> > > > Fails RAT on
> > > >
> > >
> >
> plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java
> > > >
> > > >
> > > > > -Original Message-
> > > > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com]
> On
> > > > > Behalf Of Will Stevens
> > > > > Sent: Wednesday, November 06, 2013 10:15 AM
> > > > > To: dev@cloudstack.apache.org
> > > > > Subject: Re: [Merge] Palo Alto Networks firewall integration to
> > master
> > > > >
> > > > > Great!  Thank you Sheng...
> > > > >
> > > > >
> > > > > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang 
> wrote:
> > > > >
> > > > > > Looks good to me.
> > > > > >
> > > > > > Applied to MASTER branch. Thanks!
> > > > > >
> > > > > > --Sheng
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens <
> > wstev...@cloudops.com>
> > > > > > wrote:
> > > > > >
> > > > > > > @Sheng:  This should be ready to go now.  I built the patch
> from
> > > > > > tonight's
> > > > > > > master and I included a more detailed commit message as you
> > > > > requested.
> > > > > >  Let
> > > > > > > me know if you have any questions/problems...
> > > > > > >
> > > > > > > @David:  As per this discussion (and a previous one [1]), I
> have
> > > > > > > moved
> > > > > > this
> > > > > > > code from being built with the depreciated 'nonoss' flag to
> core
> > > > > > > since it does not depend on any 3rd party libraries at build or
> > > > > runtime.
> > > > > > >
> > > > > > > Cheers,
> > > > > > >
> > > > > > > Will
> > > > > > >
> > > > > > > [1]
> > > > > > >
> > > > > > >
> > > > > >
> > > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > > > > > ubator%2Ecloudstack-%2A+Palo+Alto
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > > > > > 
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Thanks for that David.  You are absolutely correct, this
> plugin
> > > > > > > > has no dependencies on any 3rd party code at build or
> runtime.
> > > > > > > > Everything the plugin requires is built into the plugin.  I
> was
> > > > > > > > unclear if its
> > > > > > > dependance
> > > > > > > > on a 3rd party API and appliance to be functional was
> relevant.
> > > > > > > >
> > > > > > > > I think you are right.  I think it should probably be in the
> > core
> > > > > > build.
> > > > > > > >  I will make that change when I merge in the latest master
> for
> > > > > > > > Sheng
> > > > > > and
> > > > > > > > rebuild the patch.
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > >
> > > > > > > > Will
> > > > > > > >
> > > > > > > >
> > > > > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley  >
> > > > > wrote:
> > > > > > > >
> > > > > > > >> So perhaps a bit of history.
> > > > > > > >>
> > > > > > > >> nonoss/noredist is for targets that aren't built 'by
> default'
> > > > > (e.g.
> > > > > > > >> you must explicitly turn them on). We do this because the
> ASF
> > > > > > > >> wants the default build to be truly unencumbered and where
> > there
> > > > > > > >> are dependencies on non-open source, or non-Apache
> compatible
> > > > > > > >> code, we typically turn them off. In example: historically,
> > > > > > > >> Netscaler libraries were not open source, and we had a
> > > dependency
> > > > > > > >> on those libraries, so we placed the netscaler plugin into
> the
> > > > > > > >> nonoss. Since then the netscaler libraries have been open
> > > > > > > >> sourced, and we could move those out of noredist.
> > > > > > > >>
> > > > > > > >> So - is there third party code that you have as a build or
> > > > > > > >> runtime dependency? If so what is the license for that third
> > > > > > > >> party code? (My really fast perusal didn't catch anything
> that
> > > > > > > >> was immediately
> > > > > > > >> troubling)
> > > > > > > >>
> > > > > > > >> --David
> > > > > > > >>
> > > > > > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > > > > > >> 
> > > > > > > >> wrote:
> > > > > > > >> > Its dependence on a third party API and appliance, similar
> > to
> > > > > > > >> > the
> > > > > > srx
> > > > > > > >> and
> > > > > > > >> > netscaler. I am not convinced it should be in noredist,
> but
> > I
> > > > > > > >> > was
> > > > > > > >> following
> > > > > > > >> > the same model as other similar plugins.  Feedback on this
> > > > > > > >> > would be helpful.
> > 

Re: [Merge] Palo Alto Networks firewall integration to master

[Sheng Yang]

Oh, that means something wrong with the license header of the file(header
missing in this case).

http://creadur.apache.org/rat/

--Sheng


On Thu, Nov 7, 2013 at 10:50 AM, Will Stevens  wrote:

> Just so I know, can you explain what it means to 'Fail RAT'?  Thx...
>
>
> On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang  wrote:
>
> > Fixed.
> >
> > --Sheng
> >
> >
> > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi <
> > animesh.chaturv...@citrix.com> wrote:
> >
> > > Fails RAT on
> > >
> >
> plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java
> > >
> > >
> > > > -Original Message-
> > > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > > > Behalf Of Will Stevens
> > > > Sent: Wednesday, November 06, 2013 10:15 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: [Merge] Palo Alto Networks firewall integration to
> master
> > > >
> > > > Great!  Thank you Sheng...
> > > >
> > > >
> > > > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang  wrote:
> > > >
> > > > > Looks good to me.
> > > > >
> > > > > Applied to MASTER branch. Thanks!
> > > > >
> > > > > --Sheng
> > > > >
> > > > >
> > > > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens <
> wstev...@cloudops.com>
> > > > > wrote:
> > > > >
> > > > > > @Sheng:  This should be ready to go now.  I built the patch from
> > > > > tonight's
> > > > > > master and I included a more detailed commit message as you
> > > > requested.
> > > > >  Let
> > > > > > me know if you have any questions/problems...
> > > > > >
> > > > > > @David:  As per this discussion (and a previous one [1]), I have
> > > > > > moved
> > > > > this
> > > > > > code from being built with the depreciated 'nonoss' flag to core
> > > > > > since it does not depend on any 3rd party libraries at build or
> > > > runtime.
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Will
> > > > > >
> > > > > > [1]
> > > > > >
> > > > > >
> > > > >
> > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > > > > ubator%2Ecloudstack-%2A+Palo+Alto
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > > > > 
> > > > > > wrote:
> > > > > >
> > > > > > > Thanks for that David.  You are absolutely correct, this plugin
> > > > > > > has no dependencies on any 3rd party code at build or runtime.
> > > > > > > Everything the plugin requires is built into the plugin.  I was
> > > > > > > unclear if its
> > > > > > dependance
> > > > > > > on a 3rd party API and appliance to be functional was relevant.
> > > > > > >
> > > > > > > I think you are right.  I think it should probably be in the
> core
> > > > > build.
> > > > > > >  I will make that change when I merge in the latest master for
> > > > > > > Sheng
> > > > > and
> > > > > > > rebuild the patch.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Will
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley 
> > > > wrote:
> > > > > > >
> > > > > > >> So perhaps a bit of history.
> > > > > > >>
> > > > > > >> nonoss/noredist is for targets that aren't built 'by default'
> > > > (e.g.
> > > > > > >> you must explicitly turn them on). We do this because the ASF
> > > > > > >> wants the default build to be truly unencumbered and where
> there
> > > > > > >> are dependencies on non-open source, or non-Apache compatible
> > > > > > >> code, we typically turn them off. In example: historically,
> > > > > > >> Netscaler libraries were not open source, and we had a
> > dependency
> > > > > > >> on those libraries, so we placed the netscaler plugin into the
> > > > > > >> nonoss. Since then the netscaler libraries have been open
> > > > > > >> sourced, and we could move those out of noredist.
> > > > > > >>
> > > > > > >> So - is there third party code that you have as a build or
> > > > > > >> runtime dependency? If so what is the license for that third
> > > > > > >> party code? (My really fast perusal didn't catch anything that
> > > > > > >> was immediately
> > > > > > >> troubling)
> > > > > > >>
> > > > > > >> --David
> > > > > > >>
> > > > > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > > > > >> 
> > > > > > >> wrote:
> > > > > > >> > Its dependence on a third party API and appliance, similar
> to
> > > > > > >> > the
> > > > > srx
> > > > > > >> and
> > > > > > >> > netscaler. I am not convinced it should be in noredist, but
> I
> > > > > > >> > was
> > > > > > >> following
> > > > > > >> > the same model as other similar plugins.  Feedback on this
> > > > > > >> > would be helpful.
> > > > > > >> >
> > > > > > >> > Ws
> > > > > > >> >
> > > > > > >> > On Tuesday, November 5, 2013, David Nalley wrote:
> > > > > > >> >
> > > > > > >> >> On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens <
> > > > > wstev...@cloudops.com
> > > > > > >> >
> > > > > > >> >> wrote:
> > > > > > >> >> > Sheng, I will rebuild the patch for the latest master.
>  The
> > > > > latest
> > > > > > >> master
> > > > > > >> >

RE: [Merge] Palo Alto Networks firewall integration to master

[Animesh Chaturvedi]

RAT is release audit tool and checks for missing license headers. You can run 
it as below


mvn --projects='org.apache.cloudstack:cloudstack' 
org.apache.rat:apache-rat-plugin:0.8:check


The build should FAIL if there are any non-compliant files that are not 
specifically excluded from the ASF license header requirement. You can 
optionally review the target/rat.txt file after the run completes. 


> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: Thursday, November 07, 2013 10:51 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [Merge] Palo Alto Networks firewall integration to master
> 
> Just so I know, can you explain what it means to 'Fail RAT'?  Thx...
> 
> 
> On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang  wrote:
> 
> > Fixed.
> >
> > --Sheng
> >
> >
> > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi <
> > animesh.chaturv...@citrix.com> wrote:
> >
> > > Fails RAT on
> > >
> > plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpCli
> > entWrapper.java
> > >
> > >
> > > > -Original Message-
> > > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com]
> > > > On Behalf Of Will Stevens
> > > > Sent: Wednesday, November 06, 2013 10:15 AM
> > > > To: dev@cloudstack.apache.org
> > > > Subject: Re: [Merge] Palo Alto Networks firewall integration to
> > > > master
> > > >
> > > > Great!  Thank you Sheng...
> > > >
> > > >
> > > > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang 
> wrote:
> > > >
> > > > > Looks good to me.
> > > > >
> > > > > Applied to MASTER branch. Thanks!
> > > > >
> > > > > --Sheng
> > > > >
> > > > >
> > > > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens
> > > > > 
> > > > > wrote:
> > > > >
> > > > > > @Sheng:  This should be ready to go now.  I built the patch
> > > > > > from
> > > > > tonight's
> > > > > > master and I included a more detailed commit message as you
> > > > requested.
> > > > >  Let
> > > > > > me know if you have any questions/problems...
> > > > > >
> > > > > > @David:  As per this discussion (and a previous one [1]), I
> > > > > > have moved
> > > > > this
> > > > > > code from being built with the depreciated 'nonoss' flag to
> > > > > > core since it does not depend on any 3rd party libraries at
> > > > > > build or
> > > > runtime.
> > > > > >
> > > > > > Cheers,
> > > > > >
> > > > > > Will
> > > > > >
> > > > > > [1]
> > > > > >
> > > > > >
> > > > >
> > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > > > > ubator%2Ecloudstack-%2A+Palo+Alto
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > > > > 
> > > > > > wrote:
> > > > > >
> > > > > > > Thanks for that David.  You are absolutely correct, this
> > > > > > > plugin has no dependencies on any 3rd party code at build or
> runtime.
> > > > > > > Everything the plugin requires is built into the plugin.  I
> > > > > > > was unclear if its
> > > > > > dependance
> > > > > > > on a 3rd party API and appliance to be functional was
> relevant.
> > > > > > >
> > > > > > > I think you are right.  I think it should probably be in the
> > > > > > > core
> > > > > build.
> > > > > > >  I will make that change when I merge in the latest master
> > > > > > > for Sheng
> > > > > and
> > > > > > > rebuild the patch.
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Will
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley
> > > > > > > 
> > > > wrote:
> > > > > > >
> > > > > > >> So perhaps a bit of history.
> > > > > > >>
> > > > > > >> nonoss/noredist is for targets that aren't built 'by
> default'
> > > > (e.g.
> > > > > > >> you must explicitly turn them on). We do this because the
> > > > > > >> ASF wants the default build to be truly unencumbered and
> > > > > > >> where there are dependencies on non-open source, or
> > > > > > >> non-Apache compatible code, we typically turn them off. In
> > > > > > >> example: historically, Netscaler libraries were not open
> > > > > > >> source, and we had a
> > dependency
> > > > > > >> on those libraries, so we placed the netscaler plugin into
> > > > > > >> the nonoss. Since then the netscaler libraries have been
> > > > > > >> open sourced, and we could move those out of noredist.
> > > > > > >>
> > > > > > >> So - is there third party code that you have as a build or
> > > > > > >> runtime dependency? If so what is the license for that
> > > > > > >> third party code? (My really fast perusal didn't catch
> > > > > > >> anything that was immediately
> > > > > > >> troubling)
> > > > > > >>
> > > > > > >> --David
> > > > > > >>
> > > > > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > > > > >> 
> > > > > > >> wrote:
> > > > > > >> > Its dependence on a third party API and appliance,
> > > > > > >> > similar to the
> > > > > srx
> > > > > > >> and
> > > > > > >> > netscaler. I am not convinced it should be in noredist,
> > > > > > >> > but I was
>

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

[Chip Childers]

I was off - this morning it cleared.  Sorry.

Merge away.

On Thu, Nov 7, 2013 at 1:55 PM, Chip Childers  wrote:
> Please wait for tomorrow morning US time. 72 hours is not up yet.
>
>> On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi 
>>  wrote:
>>
>> Chip can you confirm if the IP clearance is done, should Devdeep proceed 
>> with merging into master?
>>
>>> -Original Message-
>>> From: Chip Childers [mailto:chipchild...@apache.org]
>>> Sent: Tuesday, November 05, 2013 9:36 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
>>> 11/08
>>>
>>> One thing to note, and perhaps this becomes a minor exception to the
>>> merge timing.  IP Clearance for the RDP client won't be done until the
>>> morning of the 7th.
>>>
>>> I'd propose that it is brought in to master at that time.  I won't have
>>> time to do the actual commit myself, but perhaps someone can own
>>> handling this on the morning of the 7th (ET).  Any takers?
>>>
>>> -chip
>>>
>>> On Mon, Nov 4, 2013 at 9:58 PM, Animesh Chaturvedi
>>>  wrote:
 Folks

 Friday 11/8 is the feature freeze date for ACS 4.3. If your
>>> contribution is unlikely to make it to 4.3 feature freeze on 11/8 please
>>> move them out of 4.3 release to 'Future'.

 Do remember that we have a 72 hour notice period to solicit feedback
>>> for MERGE requests. So the absolute last day for merge requests for 4.3
>>> features/ improvements is tomorrow 11/05. Contributors if you have
>>> patches in reviewboard that you had planned for 4.3 make sure to follow
>>> up with reviewers. The contribution has to be in master after satisfying
>>> any merge concerns / review comments  by 11/08 to be included  in 4.3.0
>>> release.


 For detailed branch merge requirement check [1]

 [1]
 https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Ex
 pectations


 Thanks
 Animesh

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

[Chip Childers]

Yes - please do.

On Thu, Nov 07, 2013 at 05:45:27PM +, Animesh Chaturvedi wrote:
> Chip can you confirm if the IP clearance is done, should Devdeep proceed with 
> merging into master?
> 
> > -Original Message-
> > From: Chip Childers [mailto:chipchild...@apache.org]
> > Sent: Tuesday, November 05, 2013 9:36 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
> > 11/08
> > 
> > One thing to note, and perhaps this becomes a minor exception to the
> > merge timing.  IP Clearance for the RDP client won't be done until the
> > morning of the 7th.
> > 
> > I'd propose that it is brought in to master at that time.  I won't have
> > time to do the actual commit myself, but perhaps someone can own
> > handling this on the morning of the 7th (ET).  Any takers?
> > 
> > -chip
> > 
> > On Mon, Nov 4, 2013 at 9:58 PM, Animesh Chaturvedi
> >  wrote:
> > > Folks
> > >
> > > Friday 11/8 is the feature freeze date for ACS 4.3. If your
> > contribution is unlikely to make it to 4.3 feature freeze on 11/8 please
> > move them out of 4.3 release to 'Future'.
> > >
> > > Do remember that we have a 72 hour notice period to solicit feedback
> > for MERGE requests. So the absolute last day for merge requests for 4.3
> > features/ improvements is tomorrow 11/05. Contributors if you have
> > patches in reviewboard that you had planned for 4.3 make sure to follow
> > up with reviewers. The contribution has to be in master after satisfying
> > any merge concerns / review comments  by 11/08 to be included  in 4.3.0
> > release.
> > >
> > >
> > > For detailed branch merge requirement check [1]
> > >
> > > [1]
> > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Ex
> > > pectations
> > >
> > >
> > > Thanks
> > > Animesh
> > >
> > >

Re: [ACS43] Schedule reminder : feature freeze this Friday 11/08

[Chip Childers]

Please wait for tomorrow morning US time. 72 hours is not up yet. 

> On Nov 7, 2013, at 12:45 PM, Animesh Chaturvedi 
>  wrote:
> 
> Chip can you confirm if the IP clearance is done, should Devdeep proceed with 
> merging into master?
> 
>> -Original Message-
>> From: Chip Childers [mailto:chipchild...@apache.org]
>> Sent: Tuesday, November 05, 2013 9:36 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
>> 11/08
>> 
>> One thing to note, and perhaps this becomes a minor exception to the
>> merge timing.  IP Clearance for the RDP client won't be done until the
>> morning of the 7th.
>> 
>> I'd propose that it is brought in to master at that time.  I won't have
>> time to do the actual commit myself, but perhaps someone can own
>> handling this on the morning of the 7th (ET).  Any takers?
>> 
>> -chip
>> 
>> On Mon, Nov 4, 2013 at 9:58 PM, Animesh Chaturvedi
>>  wrote:
>>> Folks
>>> 
>>> Friday 11/8 is the feature freeze date for ACS 4.3. If your
>> contribution is unlikely to make it to 4.3 feature freeze on 11/8 please
>> move them out of 4.3 release to 'Future'.
>>> 
>>> Do remember that we have a 72 hour notice period to solicit feedback
>> for MERGE requests. So the absolute last day for merge requests for 4.3
>> features/ improvements is tomorrow 11/05. Contributors if you have
>> patches in reviewboard that you had planned for 4.3 make sure to follow
>> up with reviewers. The contribution has to be in master after satisfying
>> any merge concerns / review comments  by 11/08 to be included  in 4.3.0
>> release.
>>> 
>>> 
>>> For detailed branch merge requirement check [1]
>>> 
>>> [1]
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Ex
>>> pectations
>>> 
>>> 
>>> Thanks
>>> Animesh
>>> 
>>> 

Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu

[Travis Graham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14784/
---

(Updated Nov. 7, 2013, 1:53 p.m.)


Review request for cloudstack and Joe Brockmeier.


Repository: cloudstack-docs


Description
---

(section 4.5.7.2) reflect steps for RHEL/CentOS and Ubuntu.


Diffs
-

  en-US/nfs-shares-on-management-server.xml 881ca8d 

Diff: https://reviews.apache.org/r/14784/diff/


Testing
---


Thanks,

Travis Graham

Re: Review Request 14783: [CLOUDSTACK-4844] Docs show incorrect URL for Windows password reset service download

[Travis Graham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14783/
---

(Updated Nov. 7, 2013, 1:53 p.m.)


Review request for cloudstack and Joe Brockmeier.


Repository: cloudstack-docs


Description
---

(Section 12.13.2) Removes the windows MSI link from the linux section and 
corrects the MSI link in the windows section.


Diffs
-

  en-US/linux-installation.xml 14a2f51 
  en-US/windows-installation.xml bcecc80 

Diff: https://reviews.apache.org/r/14783/diff/


Testing
---


Thanks,

Travis Graham

Re: Review Request 14785: [CLOUDSTACK-4692] Release notes refer to componentsContext.xml instead of componentContext.xml

[Travis Graham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14785/
---

(Updated Nov. 7, 2013, 1:52 p.m.)


Review request for cloudstack and Joe Brockmeier.


Repository: cloudstack-docs


Description
---

Corrects the two references in Release Notes.


Diffs
-

  release-notes/en-US/Release_Notes.xml a65cca9 

Diff: https://reviews.apache.org/r/14785/diff/


Testing
---


Thanks,

Travis Graham

Re: Review Request 14786: [CLOUDSTACK-4609] [doc] Review Comments on Dedicated Resources: POD, CLUSTER

[Travis Graham]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14786/
---

(Updated Nov. 7, 2013, 1:52 p.m.)


Review request for cloudstack and Joe Brockmeier.


Repository: cloudstack-docs


Description
---

(sections 2.3 and 2.4) Updated references to organization unit within 
CloudStack for Pods and Clusters


Diffs
-

  en-US/about-clusters.xml d2f0220 
  en-US/about-pods.xml 57ae1a3 

Diff: https://reviews.apache.org/r/14786/diff/


Testing
---


Thanks,

Travis Graham

Re: [Merge] Palo Alto Networks firewall integration to master

[Will Stevens]

Just so I know, can you explain what it means to 'Fail RAT'?  Thx...


On Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang  wrote:

> Fixed.
>
> --Sheng
>
>
> On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
> > Fails RAT on
> >
> plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java
> >
> >
> > > -Original Message-
> > > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > > Behalf Of Will Stevens
> > > Sent: Wednesday, November 06, 2013 10:15 AM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: [Merge] Palo Alto Networks firewall integration to master
> > >
> > > Great!  Thank you Sheng...
> > >
> > >
> > > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang  wrote:
> > >
> > > > Looks good to me.
> > > >
> > > > Applied to MASTER branch. Thanks!
> > > >
> > > > --Sheng
> > > >
> > > >
> > > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens 
> > > > wrote:
> > > >
> > > > > @Sheng:  This should be ready to go now.  I built the patch from
> > > > tonight's
> > > > > master and I included a more detailed commit message as you
> > > requested.
> > > >  Let
> > > > > me know if you have any questions/problems...
> > > > >
> > > > > @David:  As per this discussion (and a previous one [1]), I have
> > > > > moved
> > > > this
> > > > > code from being built with the depreciated 'nonoss' flag to core
> > > > > since it does not depend on any 3rd party libraries at build or
> > > runtime.
> > > > >
> > > > > Cheers,
> > > > >
> > > > > Will
> > > > >
> > > > > [1]
> > > > >
> > > > >
> > > >
> http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > > > ubator%2Ecloudstack-%2A+Palo+Alto
> > > > >
> > > > >
> > > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > > > 
> > > > > wrote:
> > > > >
> > > > > > Thanks for that David.  You are absolutely correct, this plugin
> > > > > > has no dependencies on any 3rd party code at build or runtime.
> > > > > > Everything the plugin requires is built into the plugin.  I was
> > > > > > unclear if its
> > > > > dependance
> > > > > > on a 3rd party API and appliance to be functional was relevant.
> > > > > >
> > > > > > I think you are right.  I think it should probably be in the core
> > > > build.
> > > > > >  I will make that change when I merge in the latest master for
> > > > > > Sheng
> > > > and
> > > > > > rebuild the patch.
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Will
> > > > > >
> > > > > >
> > > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley 
> > > wrote:
> > > > > >
> > > > > >> So perhaps a bit of history.
> > > > > >>
> > > > > >> nonoss/noredist is for targets that aren't built 'by default'
> > > (e.g.
> > > > > >> you must explicitly turn them on). We do this because the ASF
> > > > > >> wants the default build to be truly unencumbered and where there
> > > > > >> are dependencies on non-open source, or non-Apache compatible
> > > > > >> code, we typically turn them off. In example: historically,
> > > > > >> Netscaler libraries were not open source, and we had a
> dependency
> > > > > >> on those libraries, so we placed the netscaler plugin into the
> > > > > >> nonoss. Since then the netscaler libraries have been open
> > > > > >> sourced, and we could move those out of noredist.
> > > > > >>
> > > > > >> So - is there third party code that you have as a build or
> > > > > >> runtime dependency? If so what is the license for that third
> > > > > >> party code? (My really fast perusal didn't catch anything that
> > > > > >> was immediately
> > > > > >> troubling)
> > > > > >>
> > > > > >> --David
> > > > > >>
> > > > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > > > >> 
> > > > > >> wrote:
> > > > > >> > Its dependence on a third party API and appliance, similar to
> > > > > >> > the
> > > > srx
> > > > > >> and
> > > > > >> > netscaler. I am not convinced it should be in noredist, but I
> > > > > >> > was
> > > > > >> following
> > > > > >> > the same model as other similar plugins.  Feedback on this
> > > > > >> > would be helpful.
> > > > > >> >
> > > > > >> > Ws
> > > > > >> >
> > > > > >> > On Tuesday, November 5, 2013, David Nalley wrote:
> > > > > >> >
> > > > > >> >> On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens <
> > > > wstev...@cloudops.com
> > > > > >> >
> > > > > >> >> wrote:
> > > > > >> >> > Sheng, I will rebuild the patch for the latest master.  The
> > > > latest
> > > > > >> master
> > > > > >> >> > has depreciated the 'nonoss' flag in favour of 'noredist'.
> I
> > > > > >> >> > was
> > > > > >> building
> > > > > >> >> > in nonoss previously. I am guessing I should use the
> > > > > >> >> > noredist
> > > > flag
> > > > > >> now?
> > > > > >> >> >
> > > > > >> >>
> > > > > >> >> Will - what is causing this to be noredist/nonoss? My quick
> > > > > >> >> perusal
> > > > > of
> > > > > >> >> your patch didn't surface anything that would push it into
> > > > > >> >> that category.
> > > > > >> >>
>

Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk

[Animesh Chaturvedi]

> On July 26, 2013, 10:24 p.m., Jenkins Cloudstack.org wrote:
> > Review 12660 failed the build test : FAILURE
> > The url of build cloudstack-master-with-patch #55 is : 
> > http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/

Patch needs to br updated, fails the build


- Animesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12660/#review23982
---


On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12660/
> ---
> 
> (Updated July 18, 2013, 3:57 p.m.)
> 
> 
> Review request for cloudstack and Wido den Hollander.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Replaced multiple grep/awk/head commands by one awk.
> 
> 
> Diffs
> -
> 
>   scripts/vm/network/security_group.py c1c87da 
> 
> Diff: https://reviews.apache.org/r/12660/diff/
> 
> 
> Testing
> ---
> 
> Tested output. Not able to test using cloudstack function execute() or real 
> ebtables output.
> 
> 
> Thanks,
> 
> Rene Diepstraten
> 
>

Re: [Merge] Palo Alto Networks firewall integration to master

[Sheng Yang]

Fixed.

--Sheng


On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> Fails RAT on
> plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java
>
>
> > -Original Message-
> > From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> > Behalf Of Will Stevens
> > Sent: Wednesday, November 06, 2013 10:15 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [Merge] Palo Alto Networks firewall integration to master
> >
> > Great!  Thank you Sheng...
> >
> >
> > On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang  wrote:
> >
> > > Looks good to me.
> > >
> > > Applied to MASTER branch. Thanks!
> > >
> > > --Sheng
> > >
> > >
> > > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens 
> > > wrote:
> > >
> > > > @Sheng:  This should be ready to go now.  I built the patch from
> > > tonight's
> > > > master and I included a more detailed commit message as you
> > requested.
> > >  Let
> > > > me know if you have any questions/problems...
> > > >
> > > > @David:  As per this discussion (and a previous one [1]), I have
> > > > moved
> > > this
> > > > code from being built with the depreciated 'nonoss' flag to core
> > > > since it does not depend on any 3rd party libraries at build or
> > runtime.
> > > >
> > > > Cheers,
> > > >
> > > > Will
> > > >
> > > > [1]
> > > >
> > > >
> > > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > > ubator%2Ecloudstack-%2A+Palo+Alto
> > > >
> > > >
> > > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > > 
> > > > wrote:
> > > >
> > > > > Thanks for that David.  You are absolutely correct, this plugin
> > > > > has no dependencies on any 3rd party code at build or runtime.
> > > > > Everything the plugin requires is built into the plugin.  I was
> > > > > unclear if its
> > > > dependance
> > > > > on a 3rd party API and appliance to be functional was relevant.
> > > > >
> > > > > I think you are right.  I think it should probably be in the core
> > > build.
> > > > >  I will make that change when I merge in the latest master for
> > > > > Sheng
> > > and
> > > > > rebuild the patch.
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Will
> > > > >
> > > > >
> > > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley 
> > wrote:
> > > > >
> > > > >> So perhaps a bit of history.
> > > > >>
> > > > >> nonoss/noredist is for targets that aren't built 'by default'
> > (e.g.
> > > > >> you must explicitly turn them on). We do this because the ASF
> > > > >> wants the default build to be truly unencumbered and where there
> > > > >> are dependencies on non-open source, or non-Apache compatible
> > > > >> code, we typically turn them off. In example: historically,
> > > > >> Netscaler libraries were not open source, and we had a dependency
> > > > >> on those libraries, so we placed the netscaler plugin into the
> > > > >> nonoss. Since then the netscaler libraries have been open
> > > > >> sourced, and we could move those out of noredist.
> > > > >>
> > > > >> So - is there third party code that you have as a build or
> > > > >> runtime dependency? If so what is the license for that third
> > > > >> party code? (My really fast perusal didn't catch anything that
> > > > >> was immediately
> > > > >> troubling)
> > > > >>
> > > > >> --David
> > > > >>
> > > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > > >> 
> > > > >> wrote:
> > > > >> > Its dependence on a third party API and appliance, similar to
> > > > >> > the
> > > srx
> > > > >> and
> > > > >> > netscaler. I am not convinced it should be in noredist, but I
> > > > >> > was
> > > > >> following
> > > > >> > the same model as other similar plugins.  Feedback on this
> > > > >> > would be helpful.
> > > > >> >
> > > > >> > Ws
> > > > >> >
> > > > >> > On Tuesday, November 5, 2013, David Nalley wrote:
> > > > >> >
> > > > >> >> On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens <
> > > wstev...@cloudops.com
> > > > >> >
> > > > >> >> wrote:
> > > > >> >> > Sheng, I will rebuild the patch for the latest master.  The
> > > latest
> > > > >> master
> > > > >> >> > has depreciated the 'nonoss' flag in favour of 'noredist'. I
> > > > >> >> > was
> > > > >> building
> > > > >> >> > in nonoss previously. I am guessing I should use the
> > > > >> >> > noredist
> > > flag
> > > > >> now?
> > > > >> >> >
> > > > >> >>
> > > > >> >> Will - what is causing this to be noredist/nonoss? My quick
> > > > >> >> perusal
> > > > of
> > > > >> >> your patch didn't surface anything that would push it into
> > > > >> >> that category.
> > > > >> >>
> > > > >> >> --David
> > > > >> >>
> > > > >>
> > > > >
> > > > >
> > > >
> > >
>

Re: Review Request 12679: CLOUDSTACK-904: Changed multiple vcpus to one vcpu with multiple sockets

[Animesh Chaturvedi]

> On July 17, 2013, 4:43 p.m., Wido den Hollander wrote:
> > Hmm, I'm not sure about this one.
> > 
> > In the UI we indeed mention the amount of cores, however, the API parameter 
> > is "cpunumber".
> > 
> > So I get the reasoning, but we would be changing a lot here. I don't know 
> > if this changes anything by the way Qemu spreads out threads over the 
> > hypervisor's cores?
> 
> Rene Diepstraten wrote:
> Perhaps it's best if it's decided that a complete review of the cpu cores 
> model is needed.
> The API should in my opinion accept both cpu sockets and cpu cores as 
> parameters. It should for example be possible to create a vm with 2 sockets 
> and 16 cores.
> Qemu/KVM does support this for quite some time, as do for example Red Hat 
> Enterprise Virtualization and Proxmox VE, which both use KVM .
>

May be this should be brought to mailing list as a DISCUSS topic?


- Animesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12679/#review23290
---


On July 18, 2013, 4:06 p.m., Rene Diepstraten wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12679/
> ---
> 
> (Updated July 18, 2013, 4:06 p.m.)
> 
> 
> Review request for cloudstack and Wido den Hollander.
> 
> 
> Bugs: CLOUDSTACK-904
> https://issues.apache.org/jira/browse/CLOUDSTACK-904
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Cloudstack defines a vm with multiple CPUs instead of one CPU with multiple 
> cores. 
> For Windows as well as RHEL guests, the license is based on the amount of CPU 
> sockets.
> The definition of VCPUs should therefore translate to the amount of cores, 
> not CPUs.
> 
> 
> Diffs
> -
> 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
>  5120870 
> 
> Diff: https://reviews.apache.org/r/12679/diff/
> 
> 
> Testing
> ---
> 
> Only tested the output of the append rule.
> 
> 
> Thanks,
> 
> Rene Diepstraten
> 
>

Re: Review Request 14381: KVM: add connect/disconnect capabilities to StorageAdaptors so that external storage services can attach/detach devices on-demand

[Animesh Chaturvedi]

> On Oct. 7, 2013, 7:49 p.m., Mike Tutkowski wrote:
> > This looks reasonable to me, Marcus.
> > 
> > When do you think you might start the process of getting this into master?

is this expected for 4.3? then this should be in master soon


- Animesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14381/#review26748
---


On Sept. 30, 2013, 5:14 p.m., Marcus Sorensen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14381/
> ---
> 
> (Updated Sept. 30, 2013, 5:14 p.m.)
> 
> 
> Review request for cloudstack, edison su and Mike Tutkowski.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> With custom storage plugins comes the need to prep the KVM host prior to 
> utilizing the disks. e.g. an iscsi initiator needs to log into the target and 
> scan for the lun before it can be used on the host. This patch is an example 
> I developed against 4.2, minor changes may be necessary to apply to master, 
> but I want to share with others who are working on storage so they can ensure 
> it works for them. Please tweak as you see fit.
> 
> MigrateCommand: pass vmTO object so we can see which disks/storage pool types 
> belong to the vm when migrating a VM. This facilitates being able to call 
> disconnectPhysicalDisksViaVmSpec
> 
> VirtualMachineManagerImpl: pass VirtualMachineTO when migrating so that we 
> can see which disks belong to the VM and what storage pools/adaptors should 
> be used
> 
> LibvirtComputingResource: add calls KVMStoragePoolManager's 
> connectPhysicalDiskViaVmSpec and disconnectPhysicalDiskViaVmSpec calls where 
> appropriate (when starting a vm, migrating a vm). Ensure that we create 'raw' 
> format XML disk definitions when the storage format is RAW. Move cleanupDisk 
> logic to storage adaptors so that each adaptor type can clean up its disks in 
> is own way.
> 
> KVMStoragePoolManager:  add connectPhysicalDisk, disconnectPhysicalDisk, 
> connectPhysicalDiskViaVmSpec, disconnectPhysicalDiskViaVmSpec, 
> disconnectPhysicalDiskByPath. These all call the specific StorageAdaptor's 
> connectPhysicalDisk, disconnectPhysicalDisk, or disconnectPhysicalDiskByPath 
> calls.
> 
> KVMStorageProcessor: Call connectPhysicalDisk/disconnectPhysicalDisk on the 
> storage adaptor. Whether or not this is implemented is up to the storage 
> adaptor.
> 
> LibvirtStorageAdaptor: implement dummy 
> connectPhysicalDisk/disconnectPhysicalDisk, move cleanupDisk logic from 
> LibvirtComputingResource to disconnectPhysicalDiskByPath
> 
> StorageAdaptor: define 
> connectPhysicalDisk/disconnectPhysicalDisk/disconnectPhysicalDiskByPath in 
> the interface
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/MigrateCommand.java 5042b8c 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
>  3ee811f 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java
>  e09c9ba 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
>  c69f9b0 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
>  123a9f1 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java
>  4956d8d 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java d46bbb0 
> 
> Diff: https://reviews.apache.org/r/14381/diff/
> 
> 
> Testing
> ---
> 
> Basic testing with my storage adaptor
> 
> 
> Thanks,
> 
> Marcus Sorensen
> 
>

Reviewboard needs your attention

[Animesh Chaturvedi]

There are large number of patches in review board. I went through some of them 
and followed up and closed out few that are already checked in, but the list is 
huge. Given that we are approaching the 4.3 feature freeze tomorrow if you have 
submitted patches and are still pending reviews please reach out to your 
reviewers. If you have received feedback on your patch please provide an 
updated patch. Reviewers take a moment to review the patches under your name 
and help clear up the reviews.


If you are unsure how to help please check Review Board Guidelines [1]

[1] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Review+Board+Guidelines

RE: [Merge] Palo Alto Networks firewall integration to master

[Animesh Chaturvedi]

Fails RAT on 
plugins/network-elements/palo-alto/src/com/cloud/network/utils/HttpClientWrapper.java


> -Original Message-
> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> Behalf Of Will Stevens
> Sent: Wednesday, November 06, 2013 10:15 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [Merge] Palo Alto Networks firewall integration to master
> 
> Great!  Thank you Sheng...
> 
> 
> On Wed, Nov 6, 2013 at 1:10 PM, Sheng Yang  wrote:
> 
> > Looks good to me.
> >
> > Applied to MASTER branch. Thanks!
> >
> > --Sheng
> >
> >
> > On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens 
> > wrote:
> >
> > > @Sheng:  This should be ready to go now.  I built the patch from
> > tonight's
> > > master and I included a more detailed commit message as you
> requested.
> >  Let
> > > me know if you have any questions/problems...
> > >
> > > @David:  As per this discussion (and a previous one [1]), I have
> > > moved
> > this
> > > code from being built with the depreciated 'nonoss' flag to core
> > > since it does not depend on any 3rd party libraries at build or
> runtime.
> > >
> > > Cheers,
> > >
> > > Will
> > >
> > > [1]
> > >
> > >
> > http://markmail.org/message/fxphjkba7bonlesd?q=list:org%2Eapache%2Einc
> > ubator%2Ecloudstack-%2A+Palo+Alto
> > >
> > >
> > > On Tue, Nov 5, 2013 at 11:42 AM, Will Stevens
> > > 
> > > wrote:
> > >
> > > > Thanks for that David.  You are absolutely correct, this plugin
> > > > has no dependencies on any 3rd party code at build or runtime.
> > > > Everything the plugin requires is built into the plugin.  I was
> > > > unclear if its
> > > dependance
> > > > on a 3rd party API and appliance to be functional was relevant.
> > > >
> > > > I think you are right.  I think it should probably be in the core
> > build.
> > > >  I will make that change when I merge in the latest master for
> > > > Sheng
> > and
> > > > rebuild the patch.
> > > >
> > > > Thanks,
> > > >
> > > > Will
> > > >
> > > >
> > > > On Tue, Nov 5, 2013 at 10:19 AM, David Nalley 
> wrote:
> > > >
> > > >> So perhaps a bit of history.
> > > >>
> > > >> nonoss/noredist is for targets that aren't built 'by default'
> (e.g.
> > > >> you must explicitly turn them on). We do this because the ASF
> > > >> wants the default build to be truly unencumbered and where there
> > > >> are dependencies on non-open source, or non-Apache compatible
> > > >> code, we typically turn them off. In example: historically,
> > > >> Netscaler libraries were not open source, and we had a dependency
> > > >> on those libraries, so we placed the netscaler plugin into the
> > > >> nonoss. Since then the netscaler libraries have been open
> > > >> sourced, and we could move those out of noredist.
> > > >>
> > > >> So - is there third party code that you have as a build or
> > > >> runtime dependency? If so what is the license for that third
> > > >> party code? (My really fast perusal didn't catch anything that
> > > >> was immediately
> > > >> troubling)
> > > >>
> > > >> --David
> > > >>
> > > >> On Tue, Nov 5, 2013 at 7:08 AM, Will Stevens
> > > >> 
> > > >> wrote:
> > > >> > Its dependence on a third party API and appliance, similar to
> > > >> > the
> > srx
> > > >> and
> > > >> > netscaler. I am not convinced it should be in noredist, but I
> > > >> > was
> > > >> following
> > > >> > the same model as other similar plugins.  Feedback on this
> > > >> > would be helpful.
> > > >> >
> > > >> > Ws
> > > >> >
> > > >> > On Tuesday, November 5, 2013, David Nalley wrote:
> > > >> >
> > > >> >> On Mon, Nov 4, 2013 at 7:32 PM, Will Stevens <
> > wstev...@cloudops.com
> > > >> >
> > > >> >> wrote:
> > > >> >> > Sheng, I will rebuild the patch for the latest master.  The
> > latest
> > > >> master
> > > >> >> > has depreciated the 'nonoss' flag in favour of 'noredist'. I
> > > >> >> > was
> > > >> building
> > > >> >> > in nonoss previously. I am guessing I should use the
> > > >> >> > noredist
> > flag
> > > >> now?
> > > >> >> >
> > > >> >>
> > > >> >> Will - what is causing this to be noredist/nonoss? My quick
> > > >> >> perusal
> > > of
> > > >> >> your patch didn't surface anything that would push it into
> > > >> >> that category.
> > > >> >>
> > > >> >> --David
> > > >> >>
> > > >>
> > > >
> > > >
> > >
> >

Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions

[Alex Ough]

I don't mind implementing it in the core server unless there is anyone who
thinks differently.
Anyone with another thought?

Thank Daan for your suggestion.
Alex Ough


On Thu, Nov 7, 2013 at 11:23 AM, Daan Hoogland wrote:

> Alex,
>
> Why would you want to make this a plugin? It sounds like a function of
> the core server. Don't you agree?
>
> regards,
> Daan
>
> On Wed, Nov 6, 2013 at 10:59 PM, Alex Ough  wrote:
> > I'm having a difficulty finding documents about how to develop a plug-in.
> > Anyone to help me find one?
> >
> > Thanks in advance.
> > Alex Ough
> >
> >
> > On Tue, Nov 5, 2013 at 2:18 PM, Alex Ough  wrote:
> >
> >> OK.
> >>
> >> 1) Do you mean the plug-in? If so, let me find out how to develop a
> >> plug-in and work on this.
> >> 2) Sure, let me add more information in the document.
> >>
> >> Thanks for your suggestions.
> >> Alex Ough
> >>
> >>
> >> On Tue, Nov 5, 2013 at 11:41 AM, Chip Childers  >wrote:
> >>
> >>> Alex,
> >>>
> >>> I've moved your page to the "Designs not committed to a release"
> >>> parent (instead of the 4.3 designs page), to align with both the Jira
> >>> record *and* the fact that feature freeze is about to happen for 4.3.
> >>>
> >>> As for the proposal itself, I have a couple of suggestions:
> >>>
> >>> 1) I'd like to see the implementation be part of the ACS runtime.
> >>> Having a separate python app for this sync feature seems like an admin
> >>> burden.
> >>>
> >>> 2) As far as the design document itself, I think that we need to see
> >>> more details on the proposed approach to sync, failure condition
> >>> handling, etc...
> >>>
> >>> -chip
> >>>
> >>>
> >>> On Mon, Nov 4, 2013 at 3:16 PM, Alex Ough 
> wrote:
> >>> > All,
> >>> >
> >>> > Among the 2 approaches, I uploaded the implemented codes of the first
> >>> > approach, master-slave architecture, here.
> >>> > https://github.com/alexoughsg/albatross
> >>> >
> >>> > And here is the design doc in the wiki.
> >>> >
> >>>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Domain-Account-User+Sync+Up+Among+Multiple+Regions
> >>> >
> >>> > Please review them and let me know what you think if you're
> interested!
> >>> > Thanks
> >>> > Alex Ough
> >>> >
> >>> >
> >>> >
> >>> > On Thu, Oct 31, 2013 at 6:51 PM, Alex Ough 
> >>> wrote:
> >>> >
> >>> >> Great! Thanks a lot, Daan.
> >>> >>
> >>> >>
> >>> >> On Thu, Oct 31, 2013 at 4:58 PM, Daan Hoogland <
> >>> daan.hoogl...@gmail.com>wrote:
> >>> >>
> >>> >>> you are added to jira, Alex
> >>> >>>
> >>> >>> On Thu, Oct 31, 2013 at 8:31 PM, Alex Ough 
> >>> wrote:
> >>> >>> > Thanks Chip, and can you also give a permission in Jira so that I
> >>> can
> >>> >>> > assign myself in its jira?
> >>> >>> >
> >>> >>> > Alex Ough
> >>> >>> >
> >>> >>> >
> >>> >>> > On Thu, Oct 31, 2013 at 2:00 PM, Chip Childers <
> >>> chipchild...@apache.org
> >>> >>> >wrote:
> >>> >>> >
> >>> >>> >> Permission added.
> >>> >>> >>
> >>> >>> >> On Wed, Oct 30, 2013 at 12:19:23PM -0500, Alex Ough wrote:
> >>> >>> >> > And I'd like to write the design document in the wiki page,
> but I
> >>> >>> don't
> >>> >>> >> > seem to have a permission to create pages.
> >>> >>> >> > So can anyone give me the permission?
> >>> >>> >> >
> >>> >>> >> > My account in the wiki is alex.o...@sungard.com
> >>> >>> >> >
> >>> >>> >> > Thanks in advance.
> >>> >>> >> > Alex Ough
> >>> >>> >> >
> >>> >>> >> >
> >>> >>> >> > On Tue, Oct 29, 2013 at 3:38 PM, Alex Ough <
> >>> alex.o...@sungard.com>
> >>> >>> >> wrote:
> >>> >>> >> >
> >>> >>> >> > > I created a jira for this feature.
> >>> >>> >> > >
> >>> >>> >> > > https://issues.apache.org/jira/browse/CLOUDSTACK-4992
> >>> >>> >> > >
> >>> >>> >> > > But it doesn't allow for me to assign it to myself, so any
> >>> >>> permission
> >>> >>> >> do I
> >>> >>> >> > > need for this?
> >>> >>> >> > > If so, can anyone give me this permission?
> >>> >>> >> > >
> >>> >>> >> > > If there is anything missing, let me know.
> >>> >>> >> > > Thanks
> >>> >>> >> > > Alex Ough
> >>> >>> >> > >
> >>> >>> >> > >
> >>> >>> >> > > On Fri, Oct 18, 2013 at 9:30 AM, Kishan Kavala <
> >>> >>> >> kishan.kav...@citrix.com>wrote:
> >>> >>> >> > >
> >>> >>> >> > >> > -Original Message-
> >>> >>> >> > >> > From: Alex Ough [mailto:alex.o...@sungard.com]
> >>> >>> >> > >> > Sent: Thursday, 17 October 2013 11:25 PM
> >>> >>> >> > >> > To: dev@cloudstack.apache.org;
> u...@cloudstack.apache.org
> >>> >>> >> > >> > Subject: Fwd: [DISCUSS] Domain/Account/User Sync Up Among
> >>> >>> Multiple
> >>> >>> >> > >> > Regions
> >>> >>> >> > >> >
> >>> >>> >> > >> > All,
> >>> >>> >> > >> >
> >>> >>> >> > >> > Currently, under the environment of cloudstack with
> multiple
> >>> >>> >> regions,
> >>> >>> >> > >> each
> >>> >>> >> > >> > region has its own management server running with a
> separate
> >>> >>> >> database.
> >>> >>> >> > >> So if
> >>> >>> >> > >> > we want to support multiple regions and provide one
> point of
> >>> >>> entry
> >>> >>> >> for a
> >>> >>> >> > >> > customer, 

Re: Review Request 15068: Change labels for VLAN to vNet

[Animesh Chaturvedi]

> On Nov. 4, 2013, 10:24 p.m., Jessica Wang wrote:
> > Ship It!

Has this been applied? 


- Animesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review28144
---


On Nov. 1, 2013, 4:52 p.m., Chris Cameron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> ---
> 
> (Updated Nov. 1, 2013, 4:52 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle, Jessica Wang, Marcus Sorensen, 
> Pranav Saxena, and Toshiaki Hatano.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> We would like to change the labels for VLAN to vNet to make the term more 
> generic for VXLAN and VLAN. This relates to the work being done to add in 
> VXLAN support to Cloudstack.
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 3210aca 
>   ui/dictionary.jsp 35cba22 
>   ui/scripts/network.js 12e5389 
>   ui/scripts/system.js 479883c 
> 
> Diff: https://reviews.apache.org/r/15068/diff/
> 
> 
> Testing
> ---
> 
> Checked through the GUI for changed elements.
> 
> 
> Thanks,
> 
> Chris Cameron
> 
>

RE: [ACS43] Schedule reminder : feature freeze this Friday 11/08

[Animesh Chaturvedi]

Chip can you confirm if the IP clearance is done, should Devdeep proceed with 
merging into master?

> -Original Message-
> From: Chip Childers [mailto:chipchild...@apache.org]
> Sent: Tuesday, November 05, 2013 9:36 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS43] Schedule reminder : feature freeze this Friday
> 11/08
> 
> One thing to note, and perhaps this becomes a minor exception to the
> merge timing.  IP Clearance for the RDP client won't be done until the
> morning of the 7th.
> 
> I'd propose that it is brought in to master at that time.  I won't have
> time to do the actual commit myself, but perhaps someone can own
> handling this on the morning of the 7th (ET).  Any takers?
> 
> -chip
> 
> On Mon, Nov 4, 2013 at 9:58 PM, Animesh Chaturvedi
>  wrote:
> > Folks
> >
> > Friday 11/8 is the feature freeze date for ACS 4.3. If your
> contribution is unlikely to make it to 4.3 feature freeze on 11/8 please
> move them out of 4.3 release to 'Future'.
> >
> > Do remember that we have a 72 hour notice period to solicit feedback
> for MERGE requests. So the absolute last day for merge requests for 4.3
> features/ improvements is tomorrow 11/05. Contributors if you have
> patches in reviewboard that you had planned for 4.3 make sure to follow
> up with reviewers. The contribution has to be in master after satisfying
> any merge concerns / review comments  by 11/08 to be included  in 4.3.0
> release.
> >
> >
> > For detailed branch merge requirement check [1]
> >
> > [1]
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Ex
> > pectations
> >
> >
> > Thanks
> > Animesh
> >
> >

Re: Enabling AMQP/RabbitMQ Events on master

[Alena Prokharchyk]

David,

Here are the instructions that I've got from one of the CS QA engineers, hope 
it helps.

FS - 
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Admin_Guide/events.html#event-framework

Test cases relating to this feature was covered as part of Regions Feature 
testing - 
https://cwiki.apache.org/confluence/download/attachments/30757955/Regions-Test-Execution-42.xlsx


Steps to set up RabbitMQ Server:

Have a RabbitMQ server set up.

Enable rabbitmq_management plugin

C:\Program Files\RabbitMQ Server\rabbitmq_server-3.0.3\sbin>rabbitmq-plugins 
enable rabbitmq_management

Restart RabbitMQ service.

In management server :
Added the following in 
/usr/share/cloudstack-management/webapps/client/WEB-INF/classes/componentContext.xml







   
  

Restart management server.

-Alena.

From: David Grizzanti 
mailto:david.grizza...@sungard.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday, November 7, 2013 5:04 AM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Enabling AMQP/RabbitMQ Events on master

Hi,

I was looking for some help in enabling the AMQP/RabbitMQ events in
CloudStack.  I'm familiar with enabling these events in 4.2, however, I'm
not all the familiar with Spring and given the new modularized changes I'm
not really sure where the XML snippet belongs for the eventNotificationBus.
Previously I had been placing this in applicationContext.xml (or the
simulatorComponentContext.xml in the case of the Simulator).

If you could point me in the right direction that would be great.

Thanks!

XML sample for reference:






   


--
David Grizzanti
Software Engineer
Sungard Availability Services

e: david.grizza...@sungard.com
w: 215.446.1431
c: 570.575.0315

Re: Review Request 15263: Added fix for bug 5056.

[Santhosh Edukulla]

> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote:
> > tools/marvin/marvin/remoteSSHClient.py, line 115
> > 
> >
> > self.keyPairFiles is not defined at this moment we are getting an 
> > exception here. 
> > 
> > remove this here

self.keyPairFiles is defined in constructor and we are calling createConnection 
later, so its not an issue i believe.


> On Nov. 7, 2013, 5:05 p.m., SrikanteswaraRao Talluri wrote:
> > tools/marvin/marvin/remoteSSHClient.py, line 116
> > 
> >
> > it should be self.keyPairFiles instead of keyPairFiles
> > 
> > again keyPairFiles is not defined at this point and it is resulting in 
> > exception.

It says self.keyPiarFiles only in the patch. I didnt see this line in patch1, 
did it changed after applying patch2 related to this?


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15263/#review28380
---


On Nov. 6, 2013, 1:44 p.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15263/
> ---
> 
> (Updated Nov. 6, 2013, 1:44 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5056
> https://issues.apache.org/jira/browse/CLOUDSTACK-5056
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 
> 1. The library( remoteSSHClient ) in its current form has some issues. Fixed 
> few of them. As part of that, did clean up of the code. 
> 2. Added tcp timeout flag as an additional parameter to help establish the 
> tcp connections and retry if failed. It retries even otherwise failed. 
> 3. Renamed few variables and maintained uniform usage and convention. 
> 4. Added few new member functions runCommand,createConnection 
> 5. Current, way of creating connection and raising exception from constructor 
> along with return was removed and added a new way of handling it. 
> 6. Currently, result list was returned for execute command, but we dont know 
> the status of command execution, whether the output contains error or output 
> etc. Now, provided more information in the return with new implementation. 
> 7. Added few codes for proper return status. 
> 
> 
> TODO: 
> 1. Remove establishing connection from constructor altogether. This will 
> effect the current modules using it. 
> 2. Need to change is_server_ssh_ready function for proper and adequate 
> checks, currently the name and functionality is little different. It can add 
> more adequate checks before returning ssh object. 
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/codes.py b6580d0 
>   tools/marvin/marvin/integration/lib/utils.py 4d048f0 
>   tools/marvin/marvin/remoteSSHClient.py fea9b12 
> 
> Diff: https://reviews.apache.org/r/15263/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Added New File
>   
> https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>