Re: Creating or customising OS type

2014-04-24 Thread Marcus
I have an agent for you to try. you can force install the RPM over the top
of your existing 4.3 one and restart the agent. If you have an issue you
can just reinstall the stock RPM and restart the agent again. It reads the
details per Ilya's register template method, if they don't exist it does
the default thing.

http://marcus.mlsorensen.com/cloudstack-extras/nux/cloudstack-agent-4.3.0-1.el6.x86_64.rpm

If that works I can commit the fix. It worked for me, but I was testing
master.


On Wed, Apr 23, 2014 at 10:59 PM, Marcus  wrote:

> I see you mention 4.3, is it your own build or from the release artifacts?
>
>
> On Wed, Apr 23, 2014 at 10:13 PM, Marcus  wrote:
>
>> Guest OS types that will get Virtio disks include:
>>
>> Ubuntu
>> Fedora
>> CentOS
>> RedHat 6
>> Debian
>> Other PV
>>
>> And unfortunately, they also get virtio nics since they both run the OS
>> through the same isPVEnabled() method to decide between hardware.
>>
>> This random "details" parameter is kind of interesting. I'll have to see
>> if it gets passed along with StartCommand. I really dislike the trend of
>> using a 'details' dumping ground for undocumented tweaks, but if it's
>> already something that VMware is using then we could parse the details for
>> the same info, if it's being passed along.
>>
>> What version of cloudstack are you using? And what OS is the guest agent
>> running on?
>>
>>
>>
>> On Wed, Apr 23, 2014 at 7:42 PM, ilya musayev <
>> ilya.mailing.li...@gmail.com> wrote:
>>
>>> I'm KVM useless, perhaps Marcus knows the way.
>>>
>>> My mysql output is very different from yours btw.
>>>
>>> Regards
>>> ilya
>>>
>>> On 4/23/14, 4:44 AM, Nux! wrote:
>>>
 On 23.04.2014 11:35, Nux! wrote:

> 2) If you building out the VMs via templates, when you go through
>> import process, you can try altering vm_details tag. For example this
>> is how i did it in cloudmonkey:
>> register template format=ova hypervisor=vmware name=OL63-26-TMPLT
>> url=http://reposerver.example.com/6.3-26/ol-6.3-26.ova ispublic=true
>> isfeatured=true passwordenabled=false
>> details[0].rootDiskController=scsi details[0].nicAdapter=E1000
>> details[0].keyboard=us ostypeid=148 zoneid=-1
>> displaytext=OL63-26-TMPLT
>> see if you can change details[0].rootDiskController=scsi to
>> details[0].rootDiskController=virtio
>>
>
> I'll go this route and see if it helps. Thanks a lot!
>

 I can confirm it doesn't work, but thank you anyway, it was worth
 trying. :-)

 Lucian


>>>
>>
>


Re: Review Request 20410: CLOUDSTACK-6282 - Added automated tests for Instances API calls in test_escalations.py

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20410/#review41274
---


Commit 2e95b5b707087bab2408ed2895091195c6afab4c in cloudstack's branch 
refs/heads/master from unknown
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=2e95b5b ]

0001-JiraId-CLOUDSTACK-6282.patch Added automated tests for Instances API calls 
to test_escalations.py file and added utility functions to base.py file


- ASF Subversion and Git Services


On April 18, 2014, 10:06 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20410/
> ---
> 
> (Updated April 18, 2014, 10:06 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added automated tests for Instances API calls in test_escalations.py
> Modified an existing test for Volumes to handle the non-exists check
> Added few utility functions in base.py which are currently not present
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations.py f2ae801 
>   tools/marvin/marvin/lib/base.py 26f920e 
> 
> Diff: https://reviews.apache.org/r/20410/diff/
> 
> 
> Testing
> ---
> 
> Executed all the Added tests on both basic and Advance zones and attached the 
> results for the same
> 
> 
> File Attachments
> 
> 
> Advance Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/16/21eaf8f7-691f-4d4d-927b-0aadffe589ec__AdvZoneResults.txt
> Basic Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/16/f8754d7e-5fe3-48e6-bdfe-f822171b50cd__BasicZoneResults.txt
> AdvanceZone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/18/7d2247d1-f143-4818-b6b2-e1b529882ed2__AdvZoneResults.txt
> Basic Zone results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/18/d391d89c-6ad3-456b-b84e-021c8eb5ff57__BasicZoneResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>



Re: [DISCUSS] Cloudmonkey release

2014-04-24 Thread Sebastien Goasguen
+1

On Apr 23, 2014, at 7:21 PM, Chiradeep Vittal  
wrote:

> Hi folks,
> 
> Yichi¹s fix to [1] uses signature version 3 in Cloudmonkey.
> I have also coded and tested a way [2] to use username/password in
> cloudmonkey instead of apikey and secret key.
> I have some PEP8 fixes ready.
> 
> I propose we make a new release of Cloudmonkey using the process outlined
> in [3]
> Any concerns?
> 
> 
> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6202
> [2] http://goo.gl/U2VpJf
> [3] https://cwiki.apache.org/confluence/x/2ykHAg
> 



RE: Oracle VM (OVM) Server support

2014-04-24 Thread Paul Angus
We certainly get clients/potential clients asking us about OVM for both x86 and 
SPARC, so there's certainly at least some demand out there for it.

I think we ultimately need both to be able to talk at the 19th hole with the 
suits.

Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: Funs Kessen [mailto:f...@barred.org]
Sent: 23 April 2014 23:35
To: dev@cloudstack.apache.org
Cc: Paul Angus
Subject: Re: Oracle VM (OVM) Server support

Hi Paul,

It kind of depends on if we're able to get the code up to snuff to go in there 
I guess. Which is something I can't manage myself I think. All sanity put 
aside, I'm not a full time coder, but do see value in having this in CS.

Main focus is on x86, although sparc should be workable looking at the agent. 
I'm in the process of arranging an m4000/m5000 to see if the domp stuff is 
something that can work or if I can get it to work, because I also see a case 
there.

Cheers,

Funs

On Wed, Apr 23, 2014 at 06:08:28PM +, Paul Angus wrote:
> So the million euro question is... which CloudStack release are you aiming 
> for?
>
> The 100,000 euro question is... are you looking at x86 and/or SPARC 
> architectures?
>
> Regards
>
> Paul Angus
> Cloud Architect
> S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
> paul.an...@shapeblue.com
>
> -Original Message-
> From: Funs Kessen [mailto:]
> Sent: 23 April 2014 14:00
> To: dev@cloudstack.apache.org
> Cc: Donal Lafferty
> Subject: Re: Oracle VM (OVM) Server support
>
> Hi Donal and others,
>
> I've been working part timeon the code for literally a bit over a month, 
> based on snippets I had. The need for the OVM3 integration was initially 
> something that had quite some pressure behind it when the discussion started, 
> but unfortunately evaporated.
> The initial work I did started on the shoulders of the old Ovm plugin, but 
> changed partially, so the outline of the framework used there is still 
> visible in the ResourceBase, Discoverer, Helper, Guru and Fencer although 
> modified. The rest is not quite the same. I do have to say that some *cough* 
> refactoring *cough* is in order.
>
> On Tue, Apr 22, 2014 at 09:24:02PM +, Donal Lafferty wrote:
> > I took this approach with the Hyper-V plugin.  Based on my experience, I 
> > think the following advice is of great value.  Could you please pass it on 
> > to Funs.
> >
> Thanks for reaching out, it was the thing I needed to push me over the
> edge and get it out there :)
>
> > First, take Rajesh up on his request for information, because he can help 
> > with the systemVM.  Without a system VM, you can only run a QuickCloud 
> > deployment, which lacks networking and secondary storage flexibility.  
> > Also, rolling a system VM requires quite different expertise than operating 
> > the hypervisor itself.  I don't think it's useful to learn both when there 
> > are a few system VM experts already kicking around.
> >
> The Console Proxy, SSVM and RouterVM all work and run once the template has 
> been converted to RAW, which is the only format Ovm3 supports. RAW is only 
> supported due to lack of the tapdisk kernel module, the tools are there but 
> the module is not.
> Under the hood Ovm3 is xen with a python agent combined with xm and a couple 
> of shared object libs. The agent is conceptually a pluggable framework.
>
> > Be clear on how you'll support the console VM.  It would be preferable to 
> > give someone a chance to amend an existing console VM than have to write 
> > one from scratch.
> >
> The console VM works :).
>
> > Make it clear what instructions you'll support.  A base plugin need only 
> > create/start/stop/delete, but maybe your users are expecting a richer 
> > features set.  There seem to be four or so potential users on this mailing 
> > list.  Why not ask them what they need.
> >
> That is a good point indeed, for now I've kept our environement partially in 
> the back of my mind.
> * NFS for Primary and Secondary Storage
> * VLANs for VIFs on bridges (no OpenVswitch yet)
> * Native Pooling and loose CS clusters (native clusters are on the
> list)
> * VM migrations
> The README.md on the github page, https://github.com/snuf/ovm3, has more 
> detail. I'm very open to suggestions on what should be in there, some things 
> are however "complicated" due to the limitations of what is bundeled with 
> dom0 and is natively supported by Oracle VM Manager. Some form of keeping in 
> line with regard to not modifying dom0 would be required for the use case I 
> have in mind.
>
> > Get a sanity check on the agent architecture you're going to use.  Will we 
> > have to install a remote agent?  Will it speak CloudStack message bus or 
> > take HTTP requests?  It's worth checking with the community that there 
> > won't be any breaking changes to this architecture when it comes time to 
> > integrate.  The same applies to storage.  In fact

RE: Oracle VM (OVM) Server support

2014-04-24 Thread Kristoffer Sheather @ CloudCentral
+1 for x86 first, then SPARC if there is "proven" demand for it. 
  
  


 From: "Paul Angus" 
Sent: Thursday, April 24, 2014 3:59 PM
To: "Funs Kessen" , "dev@cloudstack.apache.org" 

Subject: RE: Oracle VM (OVM) Server support   
We certainly get clients/potential clients asking us about OVM for both x86 
and SPARC, so there's certainly at least some demand out there for it.

I think we ultimately need both to be able to talk at the 19th hole with 
the suits.

Regards,

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: @CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: Funs Kessen [mailto:f...@barred.org]
Sent: 23 April 2014 23:35
To: dev@cloudstack.apache.org
Cc: Paul Angus
Subject: Re: Oracle VM (OVM) Server support

Hi Paul,

It kind of depends on if we're able to get the code up to snuff to go in 
there I guess. Which is something I can't manage myself I think. All sanity 
put aside, I'm not a full time coder, but do see value in having this in 
CS.

Main focus is on x86, although sparc should be workable looking at the 
agent. I'm in the process of arranging an m4000/m5000 to see if the domp 
stuff is something that can work or if I can get it to work, because I also 
see a case there.

Cheers,

Funs

On Wed, Apr 23, 2014 at 06:08:28PM +, Paul Angus wrote:
> So the million euro question is... which CloudStack release are you 
aiming for?
>
> The 100,000 euro question is... are you looking at x86 and/or SPARC 
architectures?
>
> Regards
>
> Paul Angus
> Cloud Architect
> S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
> paul.an...@shapeblue.com
>
> -Original Message-
> From: Funs Kessen [mailto:]
> Sent: 23 April 2014 14:00
> To: dev@cloudstack.apache.org
> Cc: Donal Lafferty
> Subject: Re: Oracle VM (OVM) Server support
>
> Hi Donal and others,
>
> I've been working part timeon the code for literally a bit over a month, 
based on snippets I had. The need for the OVM3 integration was initially 
something that had quite some pressure behind it when the discussion 
started, but unfortunately evaporated.
> The initial work I did started on the shoulders of the old Ovm plugin, 
but changed partially, so the outline of the framework used there is still 
visible in the ResourceBase, Discoverer, Helper, Guru and Fencer although 
modified. The rest is not quite the same. I do have to say that some 
*cough* refactoring *cough* is in order.
>
> On Tue, Apr 22, 2014 at 09:24:02PM +, Donal Lafferty wrote:
> > I took this approach with the Hyper-V plugin. Based on my experience, I 
think the following advice is of great value. Could you please pass it on 
to Funs.
> >
> Thanks for reaching out, it was the thing I needed to push me over the
> edge and get it out there :)
>
> > First, take Rajesh up on his request for information, because he can 
help with the systemVM. Without a system VM, you can only run a QuickCloud 
deployment, which lacks networking and secondary storage flexibility. Also, 
rolling a system VM requires quite different expertise than operating the 
hypervisor itself. I don't think it's useful to learn both when there are a 
few system VM experts already kicking around.
> >
> The Console Proxy, SSVM and RouterVM all work and run once the template 
has been converted to RAW, which is the only format Ovm3 supports. RAW is 
only supported due to lack of the tapdisk kernel module, the tools are 
there but the module is not.
> Under the hood Ovm3 is xen with a python agent combined with xm and a 
couple of shared object libs. The agent is conceptually a pluggable 
framework.
>
> > Be clear on how you'll support the console VM. It would be preferable 
to give someone a chance to amend an existing console VM than have to write 
one from scratch.
> >
> The console VM works :).
>
> > Make it clear what instructions you'll support. A base plugin need only 
create/start/stop/delete, but maybe your users are expecting a richer 
features set. There seem to be four or so potential users on this mailing 
list. Why not ask them what they need.
> >
> That is a good point indeed, for now I've kept our environement partially 
in the back of my mind.
> * NFS for Primary and Secondary Storage
> * VLANs for VIFs on bridges (no OpenVswitch yet)
> * Native Pooling and loose CS clusters (native clusters are on the
> list)
> * VM migrations
> The README.md on the github page, https://github.com/snuf/ovm3, has more 
detail. I'm very open to suggestions on what should be in there, some 
things are however "complicated" due to the limitations of what is bundeled 
with dom0 and is natively supported by Oracle VM Manager. Some form of 
keeping in line with regard to not modifying dom0 would be required for the 
use case I have in mind.
>
> > Get a sanity check on the agent architecture you're going to use. Will 
we have to install a remote agent? Will it speak CloudStack message bus or 
take HTTP requests? It's worth chec

Re: Live migration failed to newly provisioned KVM host

2014-04-24 Thread Indra Pramana
Hi Lucian and Marcus,

Good day to you, and thank you for your email!

Yes, different version of QEMU is the culprit. I have upgraded QEMU to the
same version as the other hosts and live migration is now working fine.
Thanks for all your help.

Cheers.



On Sat, Apr 19, 2014 at 6:10 AM, Marcus  wrote:

> Yes, it looks as though the two machines are running different
> versions of qemu/libvirt, as the destination doesn't support the
> machine type that the VM has defined in it's XML on the source host.
>
> On Fri, Apr 18, 2014 at 3:43 PM, Nux!  wrote:
> > On 18.04.2014 19:45, Indra Pramana wrote:
> >>
> >> Unable to migrate due to internal error Process exited while reading
> >> console log output: Supported machines are:
> >> pc Standard PC (alias of pc-1.0)
> >> pc-1.0 Standard PC (default)
> >> pc-0.14Standard PC
> >> pc-0.13Standard PC
> >> pc-0.12Standard PC
> >> pc-0.11Standard PC, qemu 0.11
> >> pc-0.10Standard PC, qemu 0.10
> >> isapc  ISA-only PC
> >
> >
> > What OS versions are you running and also what KVM versions, do you have
> > anything extra enabled in the agent (eg a specific CPU type vs the
> generic
> > KVM cpu)?
> > Additionally do check
> >
> https://access.redhat.com/site/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Virtualization_Administration_Guide/sect-Live_migration_and_RHEL_compatibility.html#Live_Migration_Compatibility
> >
> > --
> > Sent from the Delta quadrant using Borg technology!
> >
> > Nux!
> > www.nux.ro
>


Re: Creating or customising OS type

2014-04-24 Thread Nux!

On 24.04.2014 07:58, Marcus wrote:
I have an agent for you to try. you can force install the RPM over the 
top
of your existing 4.3 one and restart the agent. If you have an issue 
you
can just reinstall the stock RPM and restart the agent again. It reads 
the
details per Ilya's register template method, if they don't exist it 
does

the default thing.

http://marcus.mlsorensen.com/cloudstack-extras/nux/cloudstack-agent-4.3.0-1.el6.x86_64.rpm

If that works I can commit the fix. It worked for me, but I was 
testing

master.


Hi Marcus and thanks, but I'm not following here. What does the agent 
have to do with my problem?
I'm just trying to find a profile that would give me virtio_blk+e1000; 
in 4.2 "Windows PV" did this, but not in 4.3 (which, again, is great, 
but doesn't help me right now).


I'm on 4.3 release + ipset patch[1].

Anyway, this is not really a tragedy, I can just move them on the 
"Windows 2008" profile which gives me IDE blk (I know..) and E1000 nic.



Lucian

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-6240


--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


[ACS4.4] cherry pick commit 608500c107f5bbffdb453c00f0f5038243295197

2014-04-24 Thread Sanjay Tripathi
Hi Daan,

Could you please cherry-pick following commit to 4.4 branch.

Commit: 608500c107f5bbffdb453c00f0f5038243295197

CLOUDSTACK-6494: Typing a pipe '|' character in VM console returns a question 
mark and pipe '?|'.

--Sanjay


Review Request 20659: CLOUDSTACK-5674: Fixed cloudstackConnection.py to return FAILED in case of well handled exceptions returning from server having jobresultcode as 530

2014-04-24 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20659/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-5674
https://issues.apache.org/jira/browse/CLOUDSTACK-5674


Repository: cloudstack-git


Description
---

In case of well handled exceptions returned from the server with proper error 
message, the response was as it is returned. Instead, it should check the 
jobresultcode. If the jobresultcode is 530, it means that exception is returned 
from server. In this case we should return FAILED.


Diffs
-

  tools/marvin/marvin/cloudstackConnection.py d006002 
  tools/marvin/marvin/codes.py 4d44c58 

Diff: https://reviews.apache.org/r/20659/diff/


Testing
---

Yes


Thanks,

Gaurav Aradhye



Re: Review Request 20547: improved ldap logging.

2014-04-24 Thread Abhinandan Prateek

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20547/#review41277
---

Ship it!


Ship It!

- Abhinandan Prateek


On April 22, 2014, 6:27 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20547/
> ---
> 
> (Updated April 22, 2014, 6:27 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-6471
> https://issues.apache.org/jira/browse/CLOUDSTACK-6471
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> added stacktrace in debug level incase of exceptions.
> 
> 
> Diffs
> -
> 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java
>  ceeed68 
>   
> plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
>  578ebce 
> 
> Diff: https://reviews.apache.org/r/20547/diff/
> 
> 
> Testing
> ---
> 
> manually tested the following cases incase of success or failure
> 
> 1a. configure ldap when server is not reachable
> 1b. configuration when server is reachable
> 2a. user authentication with wrong password
> 2b. user authentication with correct password
> 3a. no users displayed in list users due to ldap server going offline
> 3b. no users displayed in list users due to user object class configuration
> 
> 1a to 3a, stacktrace is logged in debug mode incase of failures.
> for 3b, no error will be logged as this is not an exception incase of ldap. 
> cloudstack will successfully bind but, will not see any users for the 
> specified config.
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>



Review Request 20660: Fixed issues for CLOUDSTACK-6489

2014-04-24 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/
---

Review request for cloudstack and SrikanteswaraRao Talluri.


Repository: cloudstack-git


Description
---

1. Fixed issue mentioned in CLOUDSTACK-6489.
2. There were few indentation issues, fixed them as well.


Diffs
-

  test/integration/smoke/test_deploy_vm.py 6a8d8e2 
  test/integration/smoke/test_disk_offerings.py 42c950b 
  test/integration/smoke/test_volumes.py 127a721 
  tools/marvin/marvin/config/test_data.py 711227c 
  tools/marvin/marvin/marvinInit.py ba7c4de 
  tools/marvin/marvin/marvinLog.py 6168987 
  tools/marvin/marvin/marvinPlugin.py ae839e8 

Diff: https://reviews.apache.org/r/20660/diff/


Testing
---

Tested pep8, deployed a datacenter with new changes, ran few tests, verified 
logs are accumulated as mentioned.


Thanks,

Santhosh Edukulla



Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41280
---


Commit ef9e2a9367d4990631209322cdc9516fa8c91c28 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef9e2a9 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> ---
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> ---
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified 
> logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41279
---


Commit ef9e2a9367d4990631209322cdc9516fa8c91c28 in cloudstack's branch 
refs/heads/master from Santhosh Edukulla
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ef9e2a9 ]

Fixed issues in CLOUDSTACK-6489

Fixed issues for CLOUDSTACK-6489
Along with fixed few indent issues.

Signed-off-by: Santhosh Edukulla 
Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> ---
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> ---
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified 
> logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



Re: Review Request 20660: Fixed issues for CLOUDSTACK-6489

2014-04-24 Thread SrikanteswaraRao Talluri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20660/#review41278
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On April 24, 2014, 9:24 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20660/
> ---
> 
> (Updated April 24, 2014, 9:24 a.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1. Fixed issue mentioned in CLOUDSTACK-6489.
> 2. There were few indentation issues, fixed them as well.
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_deploy_vm.py 6a8d8e2 
>   test/integration/smoke/test_disk_offerings.py 42c950b 
>   test/integration/smoke/test_volumes.py 127a721 
>   tools/marvin/marvin/config/test_data.py 711227c 
>   tools/marvin/marvin/marvinInit.py ba7c4de 
>   tools/marvin/marvin/marvinLog.py 6168987 
>   tools/marvin/marvin/marvinPlugin.py ae839e8 
> 
> Diff: https://reviews.apache.org/r/20660/diff/
> 
> 
> Testing
> ---
> 
> Tested pep8, deployed a datacenter with new changes, ran few tests, verified 
> logs are accumulated as mentioned.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>



RE: Getting error while adding Netscaler with the new 10.1 API

2014-04-24 Thread Rajesh Battala
Syed, 

I have tried with NS 10.0 version. 
Its failing to add NS device with error 

"sun.security.validator.ValidatorException: PKIX path building failed: 
sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
valid certification path to requested target"}
"
Your patch will take care of NS 10.0 version also or only 10.1. 
On latest master/4.4 adding NS10.0 is failing to add as CS is not able to login 
to NS due to above error.

Thanks
Rajesh Battala

-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com] 
Sent: Thursday, November 28, 2013 7:07 AM
To: dev@cloudstack.apache.org
Cc: Vijay Venkatachalam
Subject: Re: Getting error while adding Netscaler with the new 10.1 API

Got it Vijay.  I have submitted another patch for certificate chaining. 
I have tested with 10.1 and it works. I send a patch for the move to
10.1 as well.

Thanks,
-Syed

On Wed 27 Nov 2013 04:52:47 AM EST, Vijay Venkatachalam wrote:
> In order to continue with the old behavior, use HTTPS but have cert and 
> hostname validation turned off, the following has to be done
>   nitro_service.set_certvalidation(false);
>   nitro_service.set_hostnameverification(false);
>
>> -Original Message-
>> From: Syed Ahmed [mailto:sah...@cloudops.com]
>> Sent: Wednesday, November 27, 2013 5:58 AM
>> To: dev@cloudstack.apache.org
>> Subject: Getting error while adding Netscaler with the new 10.1 API
>>
>> Hi,
>>
>> I am trying to move the Netscaler to the 10.1 Nitro API and while 
>> using the new API I am getting the following error when adding 
>> Netscaler device
>>
>> PKIX
>>path building failed:
>> sun.security.provider.certpath.SunCertPathBuilderException: unable to 
>> find valid certification path to requested target
>>
>>
>> I have changed to use HTTP instead of HTTPS in nitro to temporarily 
>> work around this problem. Is HTTPS absolutely required for 
>> communication with external devices? or does my workaround is a valid fix?
>>
>> Thanks,
>> -Syed




Re: Review Request 20651: CLOUDSTACK-6470: fixed while stopping vm hyper-v agent, vm is now gracefully shutting down

2014-04-24 Thread Anshul Gangwar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20651/
---

(Updated April 24, 2014, 11:07 a.m.)


Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Changes
---

added the license header in newly created file


Bugs: CLOUDSTACK-6470
https://issues.apache.org/jira/browse/CLOUDSTACK-6470


Repository: cloudstack-git


Description
---

When we stop VM in case of hyper-v, then it is always force shut downed i.e. 
turn off. Even if the integration services are installed in hyper-v. Directly 
turning of VM may result in corruption of disk. This patch fixes this issue. I 
have used new management class ShutdownComponent to achieve this.


Diffs (updated)
-

  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 
4795073 
  
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_ShutdownComponent.cs
 PRE-CREATION 
  
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/WmiWrappers.csproj 
70ae8e8 

Diff: https://reviews.apache.org/r/20651/diff/


Testing
---

verified on my local setup by looking into the console of VM. When stopping the 
VM it shows that the shutdown process is initiated.


Thanks,

Anshul Gangwar



Build failed in Jenkins: build-master #675

2014-04-24 Thread jenkins
See 

Changes:

[aprateek] improved ldap logging. added stacktrace in debug level incase of 
exceptions.

--
[...truncated 3490 lines...]
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.044 sec
Running org.apache.cloudstack.network.element.SspClientTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec

Results :

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Network Opendaylight 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-opendaylight ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-network-opendaylight ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-opendaylight ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-opendaylight ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-opendaylight ---
[INFO] Compiling 41 source files to 

[INFO] 
[INFO] --- license-maven-plugin:2.5:check (cloudstack-checklicence) @ 
cloud-plugin-network-opendaylight ---
[INFO] Checking licenses...
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-opendaylight ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-opendaylight ---
[INFO] Compiling 6 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-network-opendaylight ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.cloudstack.network.opendaylight.api.test.NeutronRestApiTest
log4j:WARN No appenders could be found for logger 
(org.apache.commons.httpclient.params.DefaultHttpParams).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.499 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronNetworkAdapterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronPortAdapterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronNodeAdapterTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running org.apache.cloudstack.network.opendaylight.api.test.NeutronEnumsTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec

Results :

Tests run: 24, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Allocator Random 
4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-allocator-random ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes

Review Request 20662: CLOUDSTACK-6282 - Added automated tests for Templates, ISO's, Security Groups, VPN Customer Gateways API calls in test_escalations.py

2014-04-24 Thread Vinay Varma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20662/
---

Review request for cloudstack and Santhosh Edukulla.


Bugs: cloudstack-6282
https://issues.apache.org/jira/browse/cloudstack-6282


Repository: cloudstack-git


Description
---

Automated API calls for Templates, ISO's, Security Groups, VPN Customer 
Gateways in test_escalations.py
Added utility functions/class in base.py which are not already present.
Added tests data in test_data.py which was used in automating tests


Diffs
-

  test/integration/component/test_escalations.py c3e3066 
  tools/marvin/marvin/config/test_data.py eb5ce26 
  tools/marvin/marvin/lib/base.py 1ac5737 

Diff: https://reviews.apache.org/r/20662/diff/


Testing
---

Attached are the results on Advance Zone and Basic Zone for the tests automated.


File Attachments


Advance Zone Results
  
https://reviews.apache.org/media/uploaded/files/2014/04/24/93db81f4-5b58-44b5-b6ed-1a93aa467966__AdvZoneResults.txt
Basic Zone Results
  
https://reviews.apache.org/media/uploaded/files/2014/04/24/28013ac2-49a7-4e0a-b557-c9b200138694__BasicZoneResults.txt


Thanks,

Vinay Varma



[ACS4.4] cherry pick commit ca6e6e2b7cccbec7d065465d547ef7149383f7ae

2014-04-24 Thread Rajesh Battala
Hi Daan, 

Please cherry-pick the commit to 4.4 branch

ca6e6e2b7cccbec7d065465d547ef7149383f7ae 

this will fix the issue while adding netscaler to 4.4
CLOUDSTACK-6338  [Automation] Failed to NetScaler Device with error
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=ca6e6e2b7cccbec7d065465d547ef7149383f7ae

Thanks
Rajesh Battala


Re: Review Request 20662: CLOUDSTACK-6282 - Added automated tests for Templates, ISO's, Security Groups, VPN Customer Gateways API calls in test_escalations.py

2014-04-24 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20662/#review41283
---

Ship it!


Ship It!

- Santhosh Edukulla


On April 24, 2014, 11:38 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20662/
> ---
> 
> (Updated April 24, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automated API calls for Templates, ISO's, Security Groups, VPN Customer 
> Gateways in test_escalations.py
> Added utility functions/class in base.py which are not already present.
> Added tests data in test_data.py which was used in automating tests
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations.py c3e3066 
>   tools/marvin/marvin/config/test_data.py eb5ce26 
>   tools/marvin/marvin/lib/base.py 1ac5737 
> 
> Diff: https://reviews.apache.org/r/20662/diff/
> 
> 
> Testing
> ---
> 
> Attached are the results on Advance Zone and Basic Zone for the tests 
> automated.
> 
> 
> File Attachments
> 
> 
> Advance Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/24/93db81f4-5b58-44b5-b6ed-1a93aa467966__AdvZoneResults.txt
> Basic Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/24/28013ac2-49a7-4e0a-b557-c9b200138694__BasicZoneResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>



Build failed in Jenkins: build-master #676

2014-04-24 Thread jenkins
See 

Changes:

[rajesh.battala] CLOUDSTACK-6338  [Automation] Failed to NetScaler Device with 
error

--
[...truncated 3490 lines...]
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.044 sec
Running org.apache.cloudstack.network.element.SspClientTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.167 sec

Results :

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Network Opendaylight 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-opendaylight ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-network-opendaylight ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-opendaylight ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-opendaylight ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-opendaylight ---
[INFO] Compiling 41 source files to 

[INFO] 
[INFO] --- license-maven-plugin:2.5:check (cloudstack-checklicence) @ 
cloud-plugin-network-opendaylight ---
[INFO] Checking licenses...
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-network-opendaylight ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-network-opendaylight ---
[INFO] Compiling 6 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-network-opendaylight ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.cloudstack.network.opendaylight.api.test.NeutronRestApiTest
log4j:WARN No appenders could be found for logger 
(org.apache.commons.httpclient.params.DefaultHttpParams).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.502 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronNetworkAdapterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronPortAdapterTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec
Running 
org.apache.cloudstack.network.opendaylight.api.test.NeutronNodeAdapterTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
Running org.apache.cloudstack.network.opendaylight.api.test.NeutronEnumsTest
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 sec

Results :

Tests run: 24, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Storage Allocator Random 
4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-storage-allocator-random ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = 

Re: Review Request 20557: CLOUDSTACK-6472 listUsageRecords generates NPEs for expunging instances

2014-04-24 Thread Sebastien Goasguen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20557/#review41285
---


Rajesh, can you make sure to apply this to master and 4.4-forward as well as 
4.3 ?
thx

- Sebastien Goasguen


On April 23, 2014, 12:47 p.m., Pierre-Yves Ritschard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20557/
> ---
> 
> (Updated April 23, 2014, 12:47 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-6472
> https://issues.apache.org/jira/browse/CLOUDSTACK-6472
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is a review request for CLOUDSTACK-6472 "listUsageRecords generates NPEs 
> for expunging instances"
> 
> The patch is against the 4.3 branch
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/api/ApiResponseHelper.java e543d1c 
> 
> Diff: https://reviews.apache.org/r/20557/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Ritschard
> 
>



Re: Review Request 20662: CLOUDSTACK-6282 - Added automated tests for Templates, ISO's, Security Groups, VPN Customer Gateways API calls in test_escalations.py

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20662/#review41286
---


Commit e9e8c65b4d63c7bd49c68d0ecd97b1971138d9eb in cloudstack's branch 
refs/heads/master from unknown
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e9e8c65 ]

CLOUDSTACK-6282: Added Automated tests to test_escalations.py for Security 
Groups, VPN Customer Gateways, Templates, ISO's CS API calls

Signed-off-by: SrikanteswaraRao Talluri 


- ASF Subversion and Git Services


On April 24, 2014, 11:38 a.m., Vinay Varma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20662/
> ---
> 
> (Updated April 24, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: cloudstack-6282
> https://issues.apache.org/jira/browse/cloudstack-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Automated API calls for Templates, ISO's, Security Groups, VPN Customer 
> Gateways in test_escalations.py
> Added utility functions/class in base.py which are not already present.
> Added tests data in test_data.py which was used in automating tests
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_escalations.py c3e3066 
>   tools/marvin/marvin/config/test_data.py eb5ce26 
>   tools/marvin/marvin/lib/base.py 1ac5737 
> 
> Diff: https://reviews.apache.org/r/20662/diff/
> 
> 
> Testing
> ---
> 
> Attached are the results on Advance Zone and Basic Zone for the tests 
> automated.
> 
> 
> File Attachments
> 
> 
> Advance Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/24/93db81f4-5b58-44b5-b6ed-1a93aa467966__AdvZoneResults.txt
> Basic Zone Results
>   
> https://reviews.apache.org/media/uploaded/files/2014/04/24/28013ac2-49a7-4e0a-b557-c9b200138694__BasicZoneResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>



Jenkins build is back to normal : build-master #677

2014-04-24 Thread jenkins
See 



[ACS4.4] cherry pick

2014-04-24 Thread Rajani Karuturi
Hi Daan,

Can you cherry-pick the following two commits from 4.4-forward to 4.4?

f7f84fba89cf9eea856075d45bf623ff9ed7a632 checkstyle fix for commit 
8e2e8e5e8ab492fa40dedc0788c0ac61f912487b

8e2e8e5e8ab492fa40dedc0788c0ac61f912487b improved ldap logging. added 
stacktrace in debug level incase of exceptions.

~Rajani





Re: Hypervisor version and XenServer

2014-04-24 Thread Tim Mackey
It's an ApiConstant (ApiConstants.HYPERVISOR_VERSION), and is exposed in a
number of places such as the HostForMigration, HypervisorCapabilities and
GuestOSMapping responses.  It's set for XenServer in the
XcpServerDiscoverer, and for XenServer 6.2 it really says the hypervisor
version is 4.1.5, not 6.2.0.  Once I've gotten everything working in the
Xen->XenServer work, I'll look a bit deeper into how we use it internally
(if at all).

-tim


On Wed, Apr 23, 2014 at 11:11 PM, Yitao Jiang  wrote:

> cloud.host table contains hypervisor_version column.
> Hopes can help.
>
>
> ---
> Thanks,
> Yitao
> jiangyt.github.io
>
>
> On Thu, Apr 24, 2014 at 7:22 AM, Chiradeep Vittal <
> chiradeep.vit...@citrix.com> wrote:
>
> > Where is this HYPERVISOR_VERSION? In the code? Docs?
> >
> > From: Tim Mackey mailto:tmac...@gmail.com>>
> > Reply-To: "dev@cloudstack.apache.org"
> <
> > dev@cloudstack.apache.org>
> > Date: Wednesday, April 23, 2014 at 2:50 PM
> > To: "dev@cloudstack.apache.org" <
> > dev@cloudstack.apache.org>
> > Subject: Hypervisor version and XenServer
> >
> > I'm running through some bugs with my Xen->XenServer work and just ran
> > across the HYPERVISOR_VERSION being the Xen version and not the XenServer
> > version.  Does anyone know why that is?  Given that feature/function in
> > XenServer is tied to the XenServer version, I see using the Xen version
> as
> > a bug waiting to bite us.  Since I don't want to break API compatability,
> > I'm not inclined to change it for this work, but do wonder if we
> shouldn't
> > change it when the API revs next.
> >
> > Thoughts?
> >
> > -tim
> >
> >
>


How to securely implement: Role based access control using XACML and SAML over rest for cloud

2014-04-24 Thread Priya Sharma
Hello Sir,



Herein i am attaching the architectural diagram of role based access control in 
cloud that I came up with,I want to Know how i can implement role based access 
control in cloud .My Project topic is "Role based access control using XACML 
and SAML over rest for cloud".

I have doubts: how this things(RBAC,SAML,XACML) will work in cloud.



1.how to use this in cloud, setting up all this in cloud

2.How will be the interfacing between private, public cloud

3.How role management will work in cloud.

4.What is required for cloud cluster setup.



Or whatever i want to implement for cloud is that even possible?

I don’t want to use AWS, Azure as they already have their own access control am 
thinking to setup own cluster.



My idea is to store sensitive information in private cloud, and un sensitive 
which in public cloud. Is it very difficult to use two clouds??

Can you please tell ,how to do all this securely am mainly focusing on security.



I have attached diagram, please suggest me more from security point of view in 
that.

I know that RBAC is already being used, but I want to develop a new secure 
solution







Any inputs from your side, will be of great help for me.



Thanks

​Priya



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Persistent Systems Ltd. It is intended only for the use of the 
individual or entity to which it is addressed. If you are not the intended 
recipient, you are not authorized to read, retain, copy, print, distribute or 
use this message. If you have received this communication in error, please 
notify the sender and delete all copies of this message. Persistent Systems 
Ltd. does not accept any liability for virus infected mails.



Re: [DISCUSS] Cloudmonkey release

2014-04-24 Thread Chip Childers
Chiradeep - give me your pypi username so I can add you to the list of
admins for the project there.

-chip

On Wed, Apr 23, 2014 at 11:21:22PM +, Chiradeep Vittal wrote:
> Hi folks,
> 
> Yichi¹s fix to [1] uses signature version 3 in Cloudmonkey.
> I have also coded and tested a way [2] to use username/password in
> cloudmonkey instead of apikey and secret key.
> I have some PEP8 fixes ready.
> 
> I propose we make a new release of Cloudmonkey using the process outlined
> in [3]
> Any concerns?
> 
> 
> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6202
> [2] http://goo.gl/U2VpJf
> [3] https://cwiki.apache.org/confluence/x/2ykHAg
> 


Re: [DISCUSS] Cloudmonkey release

2014-04-24 Thread Yichi Lu
+1


On Thu, Apr 24, 2014 at 8:41 AM, Chip Childers wrote:

> Chiradeep - give me your pypi username so I can add you to the list of
> admins for the project there.
>
> -chip
>
> On Wed, Apr 23, 2014 at 11:21:22PM +, Chiradeep Vittal wrote:
> > Hi folks,
> >
> > Yichi¹s fix to [1] uses signature version 3 in Cloudmonkey.
> > I have also coded and tested a way [2] to use username/password in
> > cloudmonkey instead of apikey and secret key.
> > I have some PEP8 fixes ready.
> >
> > I propose we make a new release of Cloudmonkey using the process outlined
> > in [3]
> > Any concerns?
> >
> >
> > [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6202
> > [2] http://goo.gl/U2VpJf
> > [3] https://cwiki.apache.org/confluence/x/2ykHAg
> >
>
>


Re: Creating or customising OS type

2014-04-24 Thread Marcus
Well, the agent is what decides. The 'vm start' command is sent to the
agent will all of the relevant details, and the agent creates the libvirt
xml to start the vm.


On Thu, Apr 24, 2014 at 2:30 AM, Nux!  wrote:

> On 24.04.2014 07:58, Marcus wrote:
>
>> I have an agent for you to try. you can force install the RPM over the top
>> of your existing 4.3 one and restart the agent. If you have an issue you
>> can just reinstall the stock RPM and restart the agent again. It reads the
>> details per Ilya's register template method, if they don't exist it does
>> the default thing.
>>
>> http://marcus.mlsorensen.com/cloudstack-extras/nux/
>> cloudstack-agent-4.3.0-1.el6.x86_64.rpm
>>
>> If that works I can commit the fix. It worked for me, but I was testing
>> master.
>>
>
> Hi Marcus and thanks, but I'm not following here. What does the agent have
> to do with my problem?
> I'm just trying to find a profile that would give me virtio_blk+e1000; in
> 4.2 "Windows PV" did this, but not in 4.3 (which, again, is great, but
> doesn't help me right now).
>
> I'm on 4.3 release + ipset patch[1].
>
> Anyway, this is not really a tragedy, I can just move them on the "Windows
> 2008" profile which gives me IDE blk (I know..) and E1000 nic.
>
>
> Lucian
>
> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6240
>
>
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>


Re: Review Request 20522: Bugfix CLOUDSTACK-6467: User VM state listener publishes to event bus incompletely

2014-04-24 Thread Murali Reddy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20522/#review41302
---

Ship it!


pushed to master commit 9c4de764f74bffd5cd547f8514d4a6897fb961c2

- Murali Reddy


On April 21, 2014, 4:20 p.m., Jeff Hair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20522/
> ---
> 
> (Updated April 21, 2014, 4:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch fixes both issues in the bug CLOUDSTACK-6467. It is a simple 
> change to UserVmStateListener that moves the publishOnEventBus call to before 
> returning in the post transition event, and the publishOnEventBus method now 
> puts the status into the description map to be published on the bus.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/vm/UserVmStateListener.java 202391f 
> 
> Diff: https://reviews.apache.org/r/20522/diff/
> 
> 
> Testing
> ---
> 
> Complete single-node environment set up in virtual machine with KVM, with a 
> test listener to check that the UserVmStateListener sends the status as part 
> of the event description map, as well as receives post-transition events for 
> virtual routers from the event bus.
> 
> 
> Thanks,
> 
> Jeff Hair
> 
>



Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-04-24 Thread Karl Harris
Using the Cloudstack definition of Network
Serviceas
a foundation my question is: Should the VPC Virtual Redundant Router
be
considered a Network Service?

I'm conflicted. The user can turn on redundancy however the redundant
functionality is really a type of router, not a L2-L7 network function.

If not, should the implementation be implemented as an additional router
(virtual device, separate router vm template image, etc)  or additional
functionality (the ability to provide redundant services
without L2-L7 knowing about it) to the existing virtual router modifying
the existing router vm template?

A related question is should the vrr
protocol
used
by Keepalived  be passed on the Cloudstack
Management network or an isolated network between the master and
backup router?


On Tue, Apr 22, 2014 at 5:57 AM, Daan Hoogland wrote:

> Sounds like a single guru should do the job.
> Also I would think of some offerings that contain affinity so that the
> guru has a guideline as to where to deploy the pair of routers. For a
> certain type of network design a admin may already know where the
> routers should be deployed and in that case it makes no sense to let
> the guru do any calculations on that. The admin should be able to
> specify it with tags or the likes. Of course the criteria you mention
> must not conflict but I think it makes sense to have a admin created
> offering override the standard algorithm.
>
> regards,
> Daan
>
> On Mon, Apr 21, 2014 at 9:21 PM, Karl Harris 
> wrote:
> > The functional spec for Redundant Virtual Router for VPC's states:
> > Deployment for RvR
> >
> >- Mgmt server would try to deploy two VR in the physical devices as
> far
> >apart as possible. It would try different pod, different cluster,
> different
> >storage, different host first, until there is none of above condition
> can
> >be met, it would deploy both of them in the same host.
> >
> >
> >
> > Is a design method in a PrivateRedundantNetworkGuru NetworkGuru class(es)
> > the most appropriate place to put this code?
> >
> > Separate Guru's for each of the pod,cluster,storage, host entities or a
> > single Guru that "designs" using the above criteria?
> >
> > Karl
> >
> >
> > On Wed, Mar 5, 2014 at 3:20 PM, Karl Harris 
> wrote:
> >
> >>
> >> ---
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/18795/
> >> ---
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Repository: cloudstack-git
> >>
> >>
> >> Description
> >> ---
> >>
> >> Changes/additions to BASH scripts and .java files as well as pseudo code
> >> comments. This posting is a sanity check review posting; before I get
> too
> >> far along with making the changes required for this JIRA CloudStack-764
> >> nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd publish
> my
> >> intentions to the community to review and comment.
> >>
> >>
> >> Diffs
> >> -
> >>
> >>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
> >> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
> >>
> >>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> >> 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
> >>
> >>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> >> 69b7c9e07c753c0f0c93197a809acfb3399cf555
> >>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh
> >> e5da2e096b30f6fdb15226e889517537d04f2e3e
> >>
> >> Diff: https://reviews.apache.org/r/18795/diff/
> >>
> >>
> >> Testing
> >> ---
> >>
> >> None, yet still coding
> >>
> >>
> >> Thanks,
> >>
> >> Karl Harris
> >>
> >>
>
>
>
> --
> Daan
>
>


Re: Creating or customising OS type

2014-04-24 Thread Nux!

On 24.04.2014 15:14, Marcus wrote:

Well, the agent is what decides. The 'vm start' command is sent to the
agent will all of the relevant details, and the agent creates the 
libvirt

xml to start the vm.


Ahh, alright, makes sense.
Well, it'd be great if it was possible, but I believe the cases this 
feature would address are quite rare, especially as everything supports 
VirtIO more and more.
I personally can live without it. Having said that, if you think you 
have a good patch available I can test it out, but I'd need to apply it 
to my 4.3+ipset build.


Thanks!

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


[master]management sever is failing to come up

2014-04-24 Thread Srikanteswararao Talluri
Management server is failing to  come up after a restart. Observed couple of 
mysql exceptions.
Filed a bug for this [1]. Daily  Automation runs are blocked due to this issue.


[1]: https://issues.apache.org/jira/browse/CLOUDSTACK-6498

Thanks,
~Talluri


Re: Creating or customising OS type

2014-04-24 Thread Marcus
I like the idea of it. I don't like the magic strings in 'details', but it
sounds like VMware supports it so this patch allows for it as well. It
seems pretty useful to be able to specify the desired nic/storage driver
when registering a template, rather than just saying 'all CentOS is virtio
nic and virtio disk', especially with upcoming things like virtio-scsi,
where newer operating systems will have multiple good options to choose
from.

If you need to build your own agent, you can use this patch:

http://marcus.mlsorensen.com/cloudstack-extras/models.43.patch


On Thu, Apr 24, 2014 at 9:33 AM, Nux!  wrote:

> On 24.04.2014 15:14, Marcus wrote:
>
>> Well, the agent is what decides. The 'vm start' command is sent to the
>> agent will all of the relevant details, and the agent creates the libvirt
>> xml to start the vm.
>>
>
> Ahh, alright, makes sense.
> Well, it'd be great if it was possible, but I believe the cases this
> feature would address are quite rare, especially as everything supports
> VirtIO more and more.
> I personally can live without it. Having said that, if you think you have
> a good patch available I can test it out, but I'd need to apply it to my
> 4.3+ipset build.
>
> Thanks!
>
> Lucian
>
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>


Re: Review Request 20443: Integrate Deploy DB Into windows msi installer

2014-04-24 Thread Damodar Reddy Talakanti

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20443/
---

(Updated April 24, 2014, 4:35 p.m.)


Review request for cloudstack, Abhinandan Prateek, Frank Zhang, and Koushik Das.


Changes
---

Added Frank to the reviewer's list


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6271

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6271


Repository: cloudstack-git


Description
---

Currently MSI Installer assumes that the back end DB is already created. But 
going further deploy db should be part of installation instead of assumption. 
of existence


Diffs
-

  Wix-cloudstack-maven-plugin/src/org/apache/cloudstack/wix/HeatMojo.java 
9bfe382 
  client/pom.xml aee2672 
  scripts/installer/windows/Setup_Databases.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs PRE-CREATION 
  scripts/installer/windows/acs.wxs 0e7dea7 

Diff: https://reviews.apache.org/r/20443/diff/


Testing
---

Tested against Windows 2008 R2 server as changes are related to build process.


Thanks,

Damodar Reddy Talakanti



Re: Review Request 20316: CLOUDSTACK-1466: Adding "Domain Limits" and "Resize Volume" test suits for Primary Storage Limits

2014-04-24 Thread Gaurav Aradhye


> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 82
> > 
> >
> > Please call teardown in case of exception.

I didn't call in this case because there will be nothing to cleanup in case of 
exception. We are adding only service offering to cleanup list and if there is 
exception, it means the service offering is not created and we don't have to do 
any cleanup.


> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 106
> > 
> >
> > Not calling teardown in case of exception.

self.fail will execute tearDown and tearDownClass.


> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 269
> > 
> >
> > We didnt added it to clean up. Is that ok?

VM will be cleaned up as part of account cleanup. No need to add it explicitly 
to cleanup list.


> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 357
> > 
> >
> > We are not adding it to cleanup?

Are you pointing to VM? As above explained, no need to add it to cleanup.


> On April 16, 2014, 10:35 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_ps_domain_limits.py, line 559
> > 
> >
> > Does clean up is not required here?

it is cleaned up as part of Account/project cleanup. Here we are cleaning up 
the account, so nned to add volume expicitly to cleanup list. Same applies for 
VM.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/#review40563
---


On April 14, 2014, 3:52 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20316/
> ---
> 
> (Updated April 14, 2014, 3:52 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-1466
> https://issues.apache.org/jira/browse/CLOUDSTACK-1466
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding test suits in Primary Storage Limits test cases.
> 1)Domain Limits
> 2)Resize volume
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ps_domain_limits.py PRE-CREATION 
>   test/integration/component/test_ps_resize_volume.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20316/diff/
> 
> 
> Testing
> ---
> 
> Yes
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Re: Review Request 20316: CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits

2014-04-24 Thread Gaurav Aradhye

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20316/
---

(Updated April 24, 2014, 11:01 p.m.)


Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.


Changes
---

Review changes with inclusion of 3 more test suites.


Summary (updated)
-

CLOUDSTACK-1466: Adding automation test cases for Primary Storage Limits


Bugs: CLOUDSTACK-1466
https://issues.apache.org/jira/browse/CLOUDSTACK-1466


Repository: cloudstack-git


Description (updated)
---

Adding test suits in Primary Storage Limits test cases.
1)Root/Domain admin limits
2)Domain Limits
3)Resize volume
4)Project Limits
5)Maximum Limits


Diffs (updated)
-

  test/integration/component/test_ps_domain_limits.py PRE-CREATION 
  test/integration/component/test_ps_limits.py PRE-CREATION 
  test/integration/component/test_ps_max_limits.py PRE-CREATION 
  test/integration/component/test_ps_project_limits.py PRE-CREATION 
  test/integration/component/test_ps_resize_volume.py PRE-CREATION 
  tools/marvin/marvin/codes.py 4d44c58 
  tools/marvin/marvin/lib/base.py d753098 
  tools/marvin/marvin/lib/common.py 8868d2d 

Diff: https://reviews.apache.org/r/20316/diff/


Testing
---

Yes


Thanks,

Gaurav Aradhye



Re: Hypervisor version and XenServer

2014-04-24 Thread Amogh Vasekar
I can talk for GuestOSMapping response - HYPERVISOR_VERSION mimics the
behavior in HypervisorCapabilities.

Thanks,
Amogh

On 4/24/14 5:32 AM, "Tim Mackey"  wrote:

>It's an ApiConstant (ApiConstants.HYPERVISOR_VERSION), and is exposed in a
>number of places such as the HostForMigration, HypervisorCapabilities and
>GuestOSMapping responses.  It's set for XenServer in the
>XcpServerDiscoverer, and for XenServer 6.2 it really says the hypervisor
>version is 4.1.5, not 6.2.0.  Once I've gotten everything working in the
>Xen->XenServer work, I'll look a bit deeper into how we use it internally
>(if at all).
>
>-tim
>
>
>On Wed, Apr 23, 2014 at 11:11 PM, Yitao Jiang 
>wrote:
>
>> cloud.host table contains hypervisor_version column.
>> Hopes can help.
>>
>>
>> ---
>> Thanks,
>> Yitao
>> jiangyt.github.io
>>
>>
>> On Thu, Apr 24, 2014 at 7:22 AM, Chiradeep Vittal <
>> chiradeep.vit...@citrix.com> wrote:
>>
>> > Where is this HYPERVISOR_VERSION? In the code? Docs?
>> >
>> > From: Tim Mackey mailto:tmac...@gmail.com>>
>> > Reply-To: 
>>"dev@cloudstack.apache.org"
>> <
>> > dev@cloudstack.apache.org>
>> > Date: Wednesday, April 23, 2014 at 2:50 PM
>> > To: "dev@cloudstack.apache.org" <
>> > dev@cloudstack.apache.org>
>> > Subject: Hypervisor version and XenServer
>> >
>> > I'm running through some bugs with my Xen->XenServer work and just ran
>> > across the HYPERVISOR_VERSION being the Xen version and not the
>>XenServer
>> > version.  Does anyone know why that is?  Given that feature/function
>>in
>> > XenServer is tied to the XenServer version, I see using the Xen
>>version
>> as
>> > a bug waiting to bite us.  Since I don't want to break API
>>compatability,
>> > I'm not inclined to change it for this work, but do wonder if we
>> shouldn't
>> > change it when the API revs next.
>> >
>> > Thoughts?
>> >
>> > -tim
>> >
>> >
>>



Re: [DISCUSS] Cloudmonkey release

2014-04-24 Thread Ian Duffy
+1

On 24 April 2014 14:47, Yichi Lu  wrote:
> +1
>
>
> On Thu, Apr 24, 2014 at 8:41 AM, Chip Childers wrote:
>
>> Chiradeep - give me your pypi username so I can add you to the list of
>> admins for the project there.
>>
>> -chip
>>
>> On Wed, Apr 23, 2014 at 11:21:22PM +, Chiradeep Vittal wrote:
>> > Hi folks,
>> >
>> > Yichi¹s fix to [1] uses signature version 3 in Cloudmonkey.
>> > I have also coded and tested a way [2] to use username/password in
>> > cloudmonkey instead of apikey and secret key.
>> > I have some PEP8 fixes ready.
>> >
>> > I propose we make a new release of Cloudmonkey using the process outlined
>> > in [3]
>> > Any concerns?
>> >
>> >
>> > [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6202
>> > [2] http://goo.gl/U2VpJf
>> > [3] https://cwiki.apache.org/confluence/x/2ykHAg
>> >
>>
>>


[VMware] chain_info column in volumes table

2014-04-24 Thread Mike Tutkowski
Hi,

Is it a problem that we only ever update the chain_info column in the
volumes table after a VM has successfully been started?

For example, if I take a VM snapshot and then examine this column, it is
not up to date.

Thanks,

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-04-24 Thread Daan Hoogland
One answer inline...

mobile bilingual spell checker used

Op 24 apr. 2014 16:54 schreef "Karl Harris" :

> A related question is should the vrr
> protocol
> used
> by Keepalived  be passed on the Cloudstack
> Management network or an isolated network between the master and
> backup router?
On all the networks that should be served redundantly, e.g. all.

>
>
> On Tue, Apr 22, 2014 at 5:57 AM, Daan Hoogland wrote:
>
> > Sounds like a single guru should do the job.
> > Also I would think of some offerings that contain affinity so that the
> > guru has a guideline as to where to deploy the pair of routers. For a
> > certain type of network design a admin may already know where the
> > routers should be deployed and in that case it makes no sense to let
> > the guru do any calculations on that. The admin should be able to
> > specify it with tags or the likes. Of course the criteria you mention
> > must not conflict but I think it makes sense to have a admin created
> > offering override the standard algorithm.
> >
> > regards,
> > Daan
> >
> > On Mon, Apr 21, 2014 at 9:21 PM, Karl Harris 
> > wrote:
> > > The functional spec for Redundant Virtual Router for VPC's states:
> > > Deployment for RvR
> > >
> > >- Mgmt server would try to deploy two VR in the physical devices as
> > far
> > >apart as possible. It would try different pod, different cluster,
> > different
> > >storage, different host first, until there is none of above
condition
> > can
> > >be met, it would deploy both of them in the same host.
> > >
> > >
> > >
> > > Is a design method in a PrivateRedundantNetworkGuru NetworkGuru
class(es)
> > > the most appropriate place to put this code?
> > >
> > > Separate Guru's for each of the pod,cluster,storage, host entities or
a
> > > single Guru that "designs" using the above criteria?
> > >
> > > Karl
> > >
> > >
> > > On Wed, Mar 5, 2014 at 3:20 PM, Karl Harris 
> > wrote:
> > >
> > >>
> > >> ---
> > >> This is an automatically generated e-mail. To reply, visit:
> > >> https://reviews.apache.org/r/18795/
> > >> ---
> > >>
> > >> Review request for cloudstack.
> > >>
> > >>
> > >> Repository: cloudstack-git
> > >>
> > >>
> > >> Description
> > >> ---
> > >>
> > >> Changes/additions to BASH scripts and .java files as well as pseudo
code
> > >> comments. This posting is a sanity check review posting; before I get
> > too
> > >> far along with making the changes required for this JIRA
CloudStack-764
> > >> nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd
publish
> > my
> > >> intentions to the community to review and comment.
> > >>
> > >>
> > >> Diffs
> > >> -
> > >>
> > >>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
> > >> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
> > >>
> > >>
> >
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> > >> 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
> > >>
> > >>
> >
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> > >> 69b7c9e07c753c0f0c93197a809acfb3399cf555
> > >>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh
> > >> e5da2e096b30f6fdb15226e889517537d04f2e3e
> > >>
> > >> Diff: https://reviews.apache.org/r/18795/diff/
> > >>
> > >>
> > >> Testing
> > >> ---
> > >>
> > >> None, yet still coding
> > >>
> > >>
> > >> Thanks,
> > >>
> > >> Karl Harris
> > >>
> > >>
> >
> >
> >
> > --
> > Daan
> >
> >


Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-04-24 Thread Karl Harris
Daan,

I appears your response was truncated.

Karl



On Thu, Apr 24, 2014 at 3:41 PM, Daan Hoogland wrote:

> One answer inline...
>
> mobile bilingual spell checker used
>
> Op 24 apr. 2014 16:54 schreef "Karl Harris" :
> 
> > A related question is should the vrr
> > protocol >
> > used
> > by Keepalived  be passed on the Cloudstack
> > Management network or an isolated network between the master and
> > backup router?
> On all the networks that should be served redundantly, e.g. all.
>
> >
> >
> > On Tue, Apr 22, 2014 at 5:57 AM, Daan Hoogland  >wrote:
> >
> > > Sounds like a single guru should do the job.
> > > Also I would think of some offerings that contain affinity so that the
> > > guru has a guideline as to where to deploy the pair of routers. For a
> > > certain type of network design a admin may already know where the
> > > routers should be deployed and in that case it makes no sense to let
> > > the guru do any calculations on that. The admin should be able to
> > > specify it with tags or the likes. Of course the criteria you mention
> > > must not conflict but I think it makes sense to have a admin created
> > > offering override the standard algorithm.
> > >
> > > regards,
> > > Daan
> > >
> > > On Mon, Apr 21, 2014 at 9:21 PM, Karl Harris <
> karl.har...@sungardas.com>
> > > wrote:
> > > > The functional spec for Redundant Virtual Router for VPC's states:
> > > > Deployment for RvR
> > > >
> > > >- Mgmt server would try to deploy two VR in the physical devices
> as
> > > far
> > > >apart as possible. It would try different pod, different cluster,
> > > different
> > > >storage, different host first, until there is none of above
> condition
> > > can
> > > >be met, it would deploy both of them in the same host.
> > > >
> > > >
> > > >
> > > > Is a design method in a PrivateRedundantNetworkGuru NetworkGuru
> class(es)
> > > > the most appropriate place to put this code?
> > > >
> > > > Separate Guru's for each of the pod,cluster,storage, host entities or
> a
> > > > single Guru that "designs" using the above criteria?
> > > >
> > > > Karl
> > > >
> > > >
> > > > On Wed, Mar 5, 2014 at 3:20 PM, Karl Harris  >
> > > wrote:
> > > >
> > > >>
> > > >> ---
> > > >> This is an automatically generated e-mail. To reply, visit:
> > > >> https://reviews.apache.org/r/18795/
> > > >> ---
> > > >>
> > > >> Review request for cloudstack.
> > > >>
> > > >>
> > > >> Repository: cloudstack-git
> > > >>
> > > >>
> > > >> Description
> > > >> ---
> > > >>
> > > >> Changes/additions to BASH scripts and .java files as well as pseudo
> code
> > > >> comments. This posting is a sanity check review posting; before I
> get
> > > too
> > > >> far along with making the changes required for this JIRA
> CloudStack-764
> > > >> nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd
> publish
> > > my
> > > >> intentions to the community to review and comment.
> > > >>
> > > >>
> > > >> Diffs
> > > >> -
> > > >>
> > > >>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
> > > >> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
> > > >>
> > > >>
> > >
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> > > >> 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
> > > >>
> > > >>
> > >
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> > > >> 69b7c9e07c753c0f0c93197a809acfb3399cf555
> > > >>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh
> > > >> e5da2e096b30f6fdb15226e889517537d04f2e3e
> > > >>
> > > >> Diff: https://reviews.apache.org/r/18795/diff/
> > > >>
> > > >>
> > > >> Testing
> > > >> ---
> > > >>
> > > >> None, yet still coding
> > > >>
> > > >>
> > > >> Thanks,
> > > >>
> > > >> Karl Harris
> > > >>
> > > >>
> > >
> > >
> > >
> > > --
> > > Daan
> > >
> > >
>


[ACS44] cherry pick CLOUDSTACK-6458

2014-04-24 Thread Prachi Damle
Hi Hugo/Daan,

Could you please cherry-pick following 2 commits to 4.4 branch?

Commit bc3a8378d0e58ad53f862b6102c0dfa39d97a06a
Commit 81adee346cd5135234207717d0243d174e0f116c
CLOUDSTACK-6458 IAM - 
When a domain is deleted , the group created for this domian is not removed
This is needed to avoid any issues evaluating permissions in the domain tree, 
possibly when a domain with same path is created later.

Thanks,
Prachi



Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Brian Federle


> On April 22, 2014, 5:55 p.m., Brian Federle wrote:
> > Gabor, for the most part the UI is good. However, I did notice the 
> > 'provider' fields on 'add VPC offering' are just simple text fields, 
> > instead of dropdowns -- is this intentional?
> 
> Gabor Apati-Nagy wrote:
> Thanks for reviewing. Yes this is intentional. On that screen, we allow 
> only VpcVirtualRouter for all services except Connectivity that has 3 
> providers available.

Thanks Gabor. The only modification to make then is to add the 
readonly="readonly" attribute to the input box, assuming the user cannot change 
this value.


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41038
---


On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> ---
> 
> (Updated April 15, 2014, 10:41 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
> https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
> enabled VPC and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties bfa9600 
>   ui/dictionary.jsp f4d380c 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 6494704 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 50e12f9 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>



HypervisorType - possible feature idea

2014-04-24 Thread Sam Schmit
Hello everyone,

I've recently started working with Cloudstack, and was going through the
codebase and had a question about a possible feature for future versions -
making the HypervisorType more dynamic.  Right now, it seems there are
several places where specific types are referenced.  I would like to make
it more dynamic - have hypervisors be a pluggable type so that any
hypervisor can be added using the Cloudstack plugin architecture.

I've taken a look at the existing code, and it seems as though the enum is
used not just by the hypervisor's "discoverer" class, but also by other
classes/methods to say which hypervisors they work with or are looking for.

Is there a reason it's done this way, instead of generating a dynamic list
of hypervisors that are supported at run-time?  Have there been attempts to
make this change in the past?  Has anyone begun work on this feature
already?  Anyone have thoughts on where the easy/difficult areas for such
an undertaking would reside?

Thanks for any thoughts on this, and I look forward to working with
everyone in the near future.

Sam Schmit


Re: HypervisorType - possible feature idea

2014-04-24 Thread Laszlo Hornyak
Hi Sam,

I think it would take a big lot of work but the direction is nice.
A lot of classes would have to be modified to be plugable, and possibly the
Hypervisor interface would grow big to support all these cases.

There are 1097 references to HypervisorType according to eclipse.


On Thu, Apr 24, 2014 at 10:57 PM, Sam Schmit  wrote:

> Hello everyone,
>
> I've recently started working with Cloudstack, and was going through the
> codebase and had a question about a possible feature for future versions -
> making the HypervisorType more dynamic.  Right now, it seems there are
> several places where specific types are referenced.  I would like to make
> it more dynamic - have hypervisors be a pluggable type so that any
> hypervisor can be added using the Cloudstack plugin architecture.
>
> I've taken a look at the existing code, and it seems as though the enum is
> used not just by the hypervisor's "discoverer" class, but also by other
> classes/methods to say which hypervisors they work with or are looking for.
>
> Is there a reason it's done this way, instead of generating a dynamic list
> of hypervisors that are supported at run-time?  Have there been attempts to
> make this change in the past?  Has anyone begun work on this feature
> already?  Anyone have thoughts on where the easy/difficult areas for such
> an undertaking would reside?
>
> Thanks for any thoughts on this, and I look forward to working with
> everyone in the near future.
>
> Sam Schmit
>



-- 

EOF


[XenServer] Taking a VM snapshot that includes memory

2014-04-24 Thread Mike Tutkowski
Hi,

I noticed today while trying to take a VM snapshot that included memory
that I received an exception that said I needed a license for that feature
(I'm running 6.1).

There are several editions of XenServer. Does anyone know off the top of
his/her head if this feature is included in the Enterprise Edition?

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


RE: [XenServer] Taking a VM snapshot that includes memory

2014-04-24 Thread Conrad Geiger
Yes, in 6.1, it is in both Enterprise and Platinum.

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Thursday, April 24, 2014 5:23 PM
To: dev@cloudstack.apache.org
Subject: [XenServer] Taking a VM snapshot that includes memory

Hi,

I noticed today while trying to take a VM snapshot that included memory that I 
received an exception that said I needed a license for that feature (I'm 
running 6.1).

There are several editions of XenServer. Does anyone know off the top of 
his/her head if this feature is included in the Enterprise Edition?

Thanks!

--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*



RE: Oracle VM (OVM) Server support

2014-04-24 Thread Donal Lafferty
Start with something stable, yet recent, e.g. 4.3  and not Master.  A lot of 
developers use existing tools such as DevCloud or their local test bed.  As a 
consequence, Master is not used nearly often as you'd expect.  For instance, in 
the summer of 2013, I would see Master not run, not build according to 
instructions, and sometimes not build at all.  Work with Master if you want to 
do QA or you understand CloudStack/Maven/Java and our pom.xml enough to make 
fixes.  However, you want something recent to catch subtle changes.  For 
instance, JSON instruction serialisation changed midway through 4.2.  If your 
tests targeted 4.1, they have been broken by the end of 4.2.

Start with the most common hardware architecture for CloudStack developers.  
Otherwise no one can duplicate the problem you are seeing.  Also, you really 
need a DevCloud for your development to scale well.  I haven't seen a lot of 
SPARC laptops, so I'd guess you will want to pursue x86 :)

WRT system VMs, it sounds like you can run the existing Xen system VMs as is 
provided the template is converted to RAW.  Since you're using NFS, you'll have 
to seed the system templates, which suggests that the conversion is in the bash 
script that sets up the system VMs.  Is that correct?

WRT supported environment, I suggest simply trying to start a VM on a basic 
network.  To start that VM you will have implemented support discovery 
(handshaking required to create an agent that will communicate with the 
hypervisor), storage (primary storage setup / secondary storage setup boils 
down to a mount command), and interface with the OVM API.  The network should 
be free, since basic networking will make use of your start VM instructions.  I 
would guess the hard bit is interfacing with the OVM API, since it might use a 
different schema for VM configuration and startup.  

WRT agent architecture, since OVM's agent talks XML-RPC, you should try a 
direct connect agent.  Direct connection agent handle remote communications.  
Where the remote API cannot handle CloudStack commands, they include a 
translation layer to convert between CloudStack's RPC and the remote API.  In 
contrast, a "connected agent" is a bare proxy for the CloudStack Agent, which 
uses the CloudStack message bus for communications.   For example, the Hyper-V 
plugin implements a direct connect agent, which allows it to send JSON-RPC via 
HTTP requests.  The XenServer plugin is also a direct connect agent, but it 
also includes a data translation layer to convert from CloudStack commands to 
XAPI.  I suggest looking at the Hyper-V agent to understand the instructions 
you have to implement, because they are all in one place.  In contrast, 
XenServer agent's implementation is implemented in five or so classes that 
inherit from each other.  Where you interact with the OVM API, it might be 
useful to see what the XenServer instruction is doing.  They're trying to 
control the same hypervisor, no?

But... can you control OVM with libvirt?  If so, could you simply reuse the KVM 
agent instead of writing your own?  It's a lot easier to reuse than write from 
scratch :)


DL



> -Original Message-
> From: Paul Angus [mailto:paul.an...@shapeblue.com]
> Sent: 23 April 2014 19:08
> To: dev@cloudstack.apache.org
> Cc: f...@barred.org
> Subject: RE: Oracle VM (OVM) Server support
> 
> So the million euro question is... which CloudStack release are you aiming
> for?
> 
> The 100,000 euro question is... are you looking at x86 and/or SPARC
> architectures?
> 
> Regards
> 
> Paul Angus
> Cloud Architect
> S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
> paul.an...@shapeblue.com
> 
> -Original Message-
> From: Funs Kessen [mailto:]
> Sent: 23 April 2014 14:00
> To: dev@cloudstack.apache.org
> Cc: Donal Lafferty
> Subject: Re: Oracle VM (OVM) Server support
> 
> Hi Donal and others,
> 
> I've been working part timeon the code for literally a bit over a month, based
> on snippets I had. The need for the OVM3 integration was initially something
> that had quite some pressure behind it when the discussion started, but
> unfortunately evaporated.
> The initial work I did started on the shoulders of the old Ovm plugin, but
> changed partially, so the outline of the framework used there is still 
> visible in
> the ResourceBase, Discoverer, Helper, Guru and Fencer although modified.
> The rest is not quite the same. I do have to say that some *cough*
> refactoring *cough* is in order.
> 
> On Tue, Apr 22, 2014 at 09:24:02PM +, Donal Lafferty wrote:
> > I took this approach with the Hyper-V plugin.  Based on my experience, I
> think the following advice is of great value.  Could you please pass it on to
> Funs.
> >
> Thanks for reaching out, it was the thing I needed to push me over the edge
> and get it out there :)
> 
> > First, take Rajesh up on his request for information, because he can help
> with the systemVM.  Without a system VM, you can only run a QuickCloud
> de

Re: [XenServer] Taking a VM snapshot that includes memory

2014-04-24 Thread Mike Tutkowski
Great - thanks!


On Thu, Apr 24, 2014 at 3:29 PM, Conrad Geiger wrote:

> Yes, in 6.1, it is in both Enterprise and Platinum.
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Thursday, April 24, 2014 5:23 PM
> To: dev@cloudstack.apache.org
> Subject: [XenServer] Taking a VM snapshot that includes memory
>
> Hi,
>
> I noticed today while trying to take a VM snapshot that included memory
> that I received an exception that said I needed a license for that feature
> (I'm running 6.1).
>
> There are several editions of XenServer. Does anyone know off the top of
> his/her head if this feature is included in the Enterprise Edition?
>
> Thanks!
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Gabor Apati-Nagy


> On April 22, 2014, 6:55 p.m., Brian Federle wrote:
> > Gabor, for the most part the UI is good. However, I did notice the 
> > 'provider' fields on 'add VPC offering' are just simple text fields, 
> > instead of dropdowns -- is this intentional?
> 
> Gabor Apati-Nagy wrote:
> Thanks for reviewing. Yes this is intentional. On that screen, we allow 
> only VpcVirtualRouter for all services except Connectivity that has 3 
> providers available.
> 
> Brian Federle wrote:
> Thanks Gabor. The only modification to make then is to add the 
> readonly="readonly" attribute to the input box, assuming the user cannot 
> change this value.

Good catch. But instead of making them readonly, I decided to change these back 
to dropdowns (with one item in them)- so it is displayed like at all other 
places, so there is no chance for confusion. Please see the modified patch. 
Thanks


- Gabor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41038
---


On April 15, 2014, 11:41 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> ---
> 
> (Updated April 15, 2014, 11:41 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
> https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
> enabled VPC and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties bfa9600 
>   ui/dictionary.jsp f4d380c 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 6494704 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 50e12f9 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>



Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Gabor Apati-Nagy

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/
---

(Updated April 24, 2014, 10:47 p.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Changes
---

Changed provider selectors from inconsistent textboxes to dropdowns on Add vpc 
Offering page


Bugs: CLOUDSTACK-6255
https://issues.apache.org/jira/browse/CLOUDSTACK-6255


Repository: cloudstack-git


Description
---

CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
enabled VPC and stretched L2 neworks (ui for SDN)
(UI for SDN)


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages.properties 8abe874 
  ui/dictionary.jsp ebe71b6 
  ui/scripts/configuration.js ba6bdce 
  ui/scripts/docs.js df4bcf0 
  ui/scripts/network.js 0276684 
  ui/scripts/regions.js 66dae8c 
  ui/scripts/ui/dialog.js 82e7fd4 
  ui/scripts/vpc.js 73d34df 

Diff: https://reviews.apache.org/r/20391/diff/


Testing
---


Thanks,

Gabor Apati-Nagy



[ACS44] cherry pick 98d9b8fc3fe9bf5e016d7541c1c2c369139e65af for CLOUDSTACK-6436

2014-04-24 Thread Alena Prokharchyk
Daan/Hugo,

Can you please cherry-pick the commit 98d9b8fc3fe9bf5e016d7541c1c2c369139e65af 
for the https://issues.apache.org/jira/browse/CLOUDSTACK-6436 to 4.4 branch?

The commit contains the fix for the listResourceDetails API call – details 
marked with display=false flag, shouldn’t be returned by default, only when 
forDisplay=false is passed to the call explicitly.

Thanks,
Alena.


Re: CloudStack 4.3+ Plugins

2014-04-24 Thread Nate Gordon
With spring you can externalize values like this in a properties file. You
can then use classpath loading of the properties file in your spring xml
which allows you to have a properties file in your jar that provides sane
defaults, and a properties file in the WEB-INF/classes folder that
overrides it. You can check out the config at:
http://docs.spring.io/spring/docs/3.2.8.RELEASE/spring-framework-reference/htmlsingle/#beans-factory-placeholderconfigurer

We are doing something similar to configure some custom plugins we are
working on, but with groovy and spring java config. For example something
like this (I didn't even remotely test this example conversion for syntax
or typos):

context.xml:


  









  

myplugin.properties:
myplugin.esmanagementip=10.10.171.180
...



On Thu, Apr 24, 2014 at 12:34 AM, Punith S  wrote:

> hi,
>
> its good to have privately modularized context for plugins, but how do we
> inject the required variables from the component context after building the
> jars in 4.3 ?
> in 4.2 i used to inject the required params for my plugin from the
> componentcontext.xml after building the jars. so that params values can be
> changed at any point of time.
> all you need to do was to just restart the management server.
> ref - 
>  
> class="org.apache.cloudstack.storage.datastore.provider.ElastistorPrimaryDataStoreProvider">
> 
> 
> value="PubSInZaCji8hrRfOsCxgbug2I2k_sRJ0i2a9qmAzZIiCTcFPmZelzx6uNK9TYgqkdohCmq1L2J9eYmUe9YO6A"/>
>  value="9e9f67d5-e06f-4d63-a0b8-e7255cba84b8"/>
>  value="d2d15d11-0f06-3426-a097-3e6e8b36f85c"/>
> 
> 
> 
>   
>
> but in 4.3 i'm not able to access my context.xml for injecting param values
> once i build my jars. !!
> any workaround available to do this ?
>
> thanks.
>
>
> On Thu, Apr 24, 2014 at 12:34 AM, Chris Suich  wrote:
>
> > Hey Matt,
> >
> > Your correct in seeing that some improvements were made in 4.3 to
> > support more modularized plugins. This wiki page and its two child
> > pages should help you get started:
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modularize+Spring
> >
> > You no longer NEED to put your commands in the commands.properties.in
> > file as they can be specified in the API annotation now (they can be
> > put in the file to allow users to white/blacklist the file per use
> > role if they desire). Each module can also specify its own application
> > context so that everything is privately modularized.
> >
> > Take a look at the SolidFire storage plugin. That module is using the
> > new form of Spring extensions.
> >
> > -Chris
> >
> > On Wed, Apr 23, 2014 at 10:00 AM, Matt Spurlin  >
> > wrote:
> > > In version 4.2 and below to get a plugin to work, I was adding a
> > dependency in the pom.xml of the Client project and modifying
> > applicationContext.xml.inand commands.properties.in. 4.3 appears to have
> > introduces discoverable plugins. What needs to be done differently in
> order
> > to take advantage of this?
> > > Thank you for your time,
> > > Matt
> >
> >
> >
> > --
> > Chris Suich
> > 919-334-8193
> > csui...@gmail.com
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 


*Nate Gordon*Director of Technology | Appcore - the business of cloud
computing®

Office +1.800.735.7104  |  Direct +1.515.612.7787
nate.gor...@appcore.com  |  www.appcore.com

--

The information in this message is intended for the named recipients only.
It may contain information that is privileged, confidential or otherwise
protected from disclosure. If you are not the intended recipient, you are
hereby notified that any disclosure, copying, distribution, or the taking
of any action in reliance on the contents of this message is strictly
prohibited. If you have received this e-mail in error, do not print it or
disseminate it or its contents. In such event, please notify the sender by
return e-mail and delete the e-mail file immediately thereafter. Thank you.


Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Brian Federle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41400
---

Ship it!


Ship It!

- Brian Federle


On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> ---
> 
> (Updated April 24, 2014, 9:47 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
> https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
> enabled VPC and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 8abe874 
>   ui/dictionary.jsp ebe71b6 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 0276684 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 82e7fd4 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>



Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41401
---


Commit 156b08af5f3cbc76ee341cfda8da3f8d15a7ed8b in cloudstack's branch 
refs/heads/master from Gabor Apati-Nagy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=156b08a ]

CLOUDSTACK-6255

UI for supporting region level VPC, distributed routing enabled VPC and
stretched L2 neworks


- ASF Subversion and Git Services


On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> ---
> 
> (Updated April 24, 2014, 9:47 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
> https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
> enabled VPC and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 8abe874 
>   ui/dictionary.jsp ebe71b6 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 0276684 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 82e7fd4 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>



Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20391/#review41402
---


Commit 83e5ea9812cb57eb214ec9548671b0404914ae9b in cloudstack's branch 
refs/heads/4.4-forward from Gabor Apati-Nagy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=83e5ea9 ]

CLOUDSTACK-6255

UI for supporting region level VPC, distributed routing enabled VPC and
stretched L2 neworks


- ASF Subversion and Git Services


On April 24, 2014, 9:47 p.m., Gabor Apati-Nagy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20391/
> ---
> 
> (Updated April 24, 2014, 9:47 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Bugs: CLOUDSTACK-6255
> https://issues.apache.org/jira/browse/CLOUDSTACK-6255
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing 
> enabled VPC and stretched L2 neworks (ui for SDN)
> (UI for SDN)
> 
> 
> Diffs
> -
> 
>   client/WEB-INF/classes/resources/messages.properties 8abe874 
>   ui/dictionary.jsp ebe71b6 
>   ui/scripts/configuration.js ba6bdce 
>   ui/scripts/docs.js df4bcf0 
>   ui/scripts/network.js 0276684 
>   ui/scripts/regions.js 66dae8c 
>   ui/scripts/ui/dialog.js 82e7fd4 
>   ui/scripts/vpc.js 73d34df 
> 
> Diff: https://reviews.apache.org/r/20391/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabor Apati-Nagy
> 
>



Re: Creating or customising OS type

2014-04-24 Thread Nux!

On 24.04.2014 17:28, Marcus wrote:
I like the idea of it. I don't like the magic strings in 'details', 
but it

sounds like VMware supports it so this patch allows for it as well. It
seems pretty useful to be able to specify the desired nic/storage 
driver
when registering a template, rather than just saying 'all CentOS is 
virtio
nic and virtio disk', especially with upcoming things like 
virtio-scsi,
where newer operating systems will have multiple good options to 
choose

from.

If you need to build your own agent, you can use this patch:

http://marcus.mlsorensen.com/cloudstack-extras/models.43.patch


I've patched ACS with this and generated a new set of RPMs, after the 
update however I was not only unable to create the custom type, but all 
templates failed.

See agent logs here:
http://fpaste.org/96815/13983790/raw/

This is how I added the template:
cloudmonkey register template 
ostypeid=73188ae8-a44f-11e3-bae5-f6145f6a2f37 passwordenabled=true 
isfeatured=true ispublic=true 
url=http://10.193.172.130/templates/windows_migration_50G.qcow2 
name=virto_e1000_50 hypervisor=kvm 
zoneid=a6572c99-b268-4a6b-8bd0-bf2cafa4c04b format=qcow2 
details[0].rootDiskController=virtio displaytext=virto_e1000_50


"ostypeid=73188ae8-a44f-11e3-bae5-f6145f6a2f37" means Windows 2008.

Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


Re: Creating or customising OS type

2014-04-24 Thread Marcus
updated the patch. You can also see if specifying nicAdapter works in your
existing build.


On Thu, Apr 24, 2014 at 4:43 PM, Nux!  wrote:

> On 24.04.2014 17:28, Marcus wrote:
>
>> I like the idea of it. I don't like the magic strings in 'details', but it
>> sounds like VMware supports it so this patch allows for it as well. It
>> seems pretty useful to be able to specify the desired nic/storage driver
>> when registering a template, rather than just saying 'all CentOS is virtio
>> nic and virtio disk', especially with upcoming things like virtio-scsi,
>> where newer operating systems will have multiple good options to choose
>> from.
>>
>> If you need to build your own agent, you can use this patch:
>>
>> http://marcus.mlsorensen.com/cloudstack-extras/models.43.patch
>>
>
> I've patched ACS with this and generated a new set of RPMs, after the
> update however I was not only unable to create the custom type, but all
> templates failed.
> See agent logs here:
> http://fpaste.org/96815/13983790/raw/
>
> This is how I added the template:
> cloudmonkey register template ostypeid=73188ae8-a44f-11e3-bae5-f6145f6a2f37
> passwordenabled=true isfeatured=true ispublic=true url=
> http://10.193.172.130/templates/windows_migration_50G.qcow2name=virto_e1000_50
>  hypervisor=kvm zoneid=a6572c99-b268-4a6b-8bd0-bf2cafa4c04b
> format=qcow2 details[0].rootDiskController=virtio
> displaytext=virto_e1000_50
>
> "ostypeid=73188ae8-a44f-11e3-bae5-f6145f6a2f37" means Windows 2008.
>
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>


Re: Creating or customising OS type

2014-04-24 Thread Nux!

On 25.04.2014 00:37, Marcus wrote:
updated the patch. You can also see if specifying nicAdapter works in 
your

existing build.


I've broken the existing build, but the new patch works a treat, 
thanks!

I tried both with just disk=virtio and with disk & net of type virtio.

Good job! Do you see this feature important enough to be relied upon? 
Just so I know if I should use it in production or not, ideally it 
should make it in subsequent releases.


Lucian

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro


[VOTE] Release Apache CloudStack CloudMonkey 5.1.0

2014-04-24 Thread Chiradeep Vittal
Hi All,

I've created a 5.1.0 release of CloudMonkey, with the following artifacts
up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shor
tlog;h=refs/heads/5.1.0
Commit: 0b7a6bce246bbf261e6f096d1c18a85949ed5a22

List of changes:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob
_plain;f=CHANGES;hb=5.1.0

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.1.0/

PGP release keys (signed using E8DAE809):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)



Re: Creating or customising OS type

2014-04-24 Thread Marcus
Since other hypervisors are already doing it, I have no problem making the
KVM agent 'aware' of the magic strings. I'll commit this for future
releases.


On Thu, Apr 24, 2014 at 6:10 PM, Nux!  wrote:

> On 25.04.2014 00:37, Marcus wrote:
>
>> updated the patch. You can also see if specifying nicAdapter works in your
>> existing build.
>>
>
> I've broken the existing build, but the new patch works a treat, thanks!
> I tried both with just disk=virtio and with disk & net of type virtio.
>
> Good job! Do you see this feature important enough to be relied upon? Just
> so I know if I should use it in production or not, ideally it should make
> it in subsequent releases.
>
>
> Lucian
>
> --
> Sent from the Delta quadrant using Borg technology!
>
> Nux!
> www.nux.ro
>


[ACS44] cherry pick 3 bug fixes

2014-04-24 Thread Min Chen
Hi Hugo/Daan,

Could you please cherry-pick the following 3 bug fixes from 4.4-forward
to 4.4?


1. Commit 5728ed33e9dd09d0d3ac42b5d82da42b37641519
   CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used
with listall=true and account and domainId , Vms owned by the account
account is not listed.

2. Commit 4f2a20f7b35c2a250614b7cf32879d7bb87b7a62
   CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
not working.  (This is needed to write IAM marvin test)

3. Commit f3e9c84cddbc0ab7b89f8000dd0db42ba1570d28
   CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one
zone on Vmware.  (I requested this two days back, you have some questions
about commit, and I have answered)

Thanks
-min




[ACS44] cherry pick bug fix

2014-04-24 Thread Nitin Mehta
Hi Hugo/Daan,

Could you please cherry-pick the following bug fix from 4.4-forward to 4.4?

commit b8a1cbe81a03580a25cb473b59f8702734d665dc
Author: Nitin Mehta 
Date:   Thu Apr 24 17:20:41 2014 -0700

CLOUDSTACK-6499:
Made changes so that uploading custom certificate works for ssvm.
1. Reboot ssvm only when private key is passed meaning the server cert 
is passed. This is because while uploading the server cert is the last to be 
uploaded. And we want   to propagate the entire chain once uploading is done.
2. Change the SecStorageSetupCommand sent to ssvm so that it also 
carries the root cert apart from having the chain and the server cert and key.
3. Change ssvm agent code to be able to configure root cert to the java 
key store.
4. Change ssvm configure ssl script to insert the chain certs correctly.
5. Fix order of chain certificates for apache webserver in SSVM
6. Remove double encoding and decoding for uploadCustomCertificate API 
from UI and server code respectively, so that API call without UI works fine
7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.



Thanks,
-Nitin


Re: HypervisorType - possible feature idea

2014-04-24 Thread Koushik Das
Ideally the API and orchestration layers shouldn't have any HV specific code.

You may have already seen that there are places in the code which checks if an 
operation is supported based on HV type like below.
if (Vmware)
  throw ex
All these checks should rely on hypervisor_capabilities table instead.

Then there is another kind where based on HV type the logic differs.
if (XS)
  foo()
else
  bar()
These kind of code needs to go to the plugin module specific to HV.

Some of these may be simple but for the rest you need to be careful not to 
break anything.

On 25-Apr-2014, at 2:47 AM, Laszlo Hornyak  wrote:

> Hi Sam,
> 
> I think it would take a big lot of work but the direction is nice.
> A lot of classes would have to be modified to be plugable, and possibly the
> Hypervisor interface would grow big to support all these cases.
> 
> There are 1097 references to HypervisorType according to eclipse.
> 
> 
> On Thu, Apr 24, 2014 at 10:57 PM, Sam Schmit  wrote:
> 
>> Hello everyone,
>> 
>> I've recently started working with Cloudstack, and was going through the
>> codebase and had a question about a possible feature for future versions -
>> making the HypervisorType more dynamic.  Right now, it seems there are
>> several places where specific types are referenced.  I would like to make
>> it more dynamic - have hypervisors be a pluggable type so that any
>> hypervisor can be added using the Cloudstack plugin architecture.
>> 
>> I've taken a look at the existing code, and it seems as though the enum is
>> used not just by the hypervisor's "discoverer" class, but also by other
>> classes/methods to say which hypervisors they work with or are looking for.
>> 
>> Is there a reason it's done this way, instead of generating a dynamic list
>> of hypervisors that are supported at run-time?  Have there been attempts to
>> make this change in the past?  Has anyone begun work on this feature
>> already?  Anyone have thoughts on where the easy/difficult areas for such
>> an undertaking would reside?
>> 
>> Thanks for any thoughts on this, and I look forward to working with
>> everyone in the near future.
>> 
>> Sam Schmit
>> 
> 
> 
> 
> -- 
> 
> EOF



Re: [VOTE] Release Apache CloudStack CloudMonkey 5.1.0

2014-04-24 Thread Rajani Karuturi
+1 
Tested the username password support and works fine. This is very useful during 
development.

~Rajani



On 25-Apr-2014, at 5:42 am, Chiradeep Vittal  
wrote:

> Hi All,
> 
> I've created a 5.1.0 release of CloudMonkey, with the following artifacts
> up for a vote:
> 
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shor
> tlog;h=refs/heads/5.1.0
> Commit: 0b7a6bce246bbf261e6f096d1c18a85949ed5a22
> 
> List of changes:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob
> _plain;f=CHANGES;hb=5.1.0
> 
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.1.0/
> 
> PGP release keys (signed using E8DAE809):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
> Vote will be open for 72 hours.
> 
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
> 
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
> 



RE: Getting error while adding Netscaler with the new 10.1 API

2014-04-24 Thread Rajesh Battala
I have fixed this issue
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=ca6e6e2b7cccbec7d065465d547ef7149383f7ae
 


-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Thursday, April 24, 2014 3:27 PM
To: dev@cloudstack.apache.org; Syed Ahmed
Cc: Vijay Venkatachalam
Subject: RE: Getting error while adding Netscaler with the new 10.1 API

Syed, 

I have tried with NS 10.0 version. 
Its failing to add NS device with error 

"sun.security.validator.ValidatorException: PKIX path building failed: 
sun.security.provider.certpath.SunCertPathBuilderException: unable to find 
valid certification path to requested target"} "
Your patch will take care of NS 10.0 version also or only 10.1. 
On latest master/4.4 adding NS10.0 is failing to add as CS is not able to login 
to NS due to above error.

Thanks
Rajesh Battala

-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com]
Sent: Thursday, November 28, 2013 7:07 AM
To: dev@cloudstack.apache.org
Cc: Vijay Venkatachalam
Subject: Re: Getting error while adding Netscaler with the new 10.1 API

Got it Vijay.  I have submitted another patch for certificate chaining. 
I have tested with 10.1 and it works. I send a patch for the move to
10.1 as well.

Thanks,
-Syed

On Wed 27 Nov 2013 04:52:47 AM EST, Vijay Venkatachalam wrote:
> In order to continue with the old behavior, use HTTPS but have cert and 
> hostname validation turned off, the following has to be done
>   nitro_service.set_certvalidation(false);
>   nitro_service.set_hostnameverification(false);
>
>> -Original Message-
>> From: Syed Ahmed [mailto:sah...@cloudops.com]
>> Sent: Wednesday, November 27, 2013 5:58 AM
>> To: dev@cloudstack.apache.org
>> Subject: Getting error while adding Netscaler with the new 10.1 API
>>
>> Hi,
>>
>> I am trying to move the Netscaler to the 10.1 Nitro API and while 
>> using the new API I am getting the following error when adding 
>> Netscaler device
>>
>> PKIX
>>path building failed:
>> sun.security.provider.certpath.SunCertPathBuilderException: unable to 
>> find valid certification path to requested target
>>
>>
>> I have changed to use HTTP instead of HTTPS in nitro to temporarily 
>> work around this problem. Is HTTPS absolutely required for 
>> communication with external devices? or does my workaround is a valid fix?
>>
>> Thanks,
>> -Syed




Review Request 20701: CLOUDSTACK-6504: removed the warnings coming in building hyper-v agent code

2014-04-24 Thread Anshul Gangwar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20701/
---

Review request for cloudstack, Devdeep Singh and Rajesh Battala.


Bugs: CLOUDSTACK-6504
https://issues.apache.org/jira/browse/CLOUDSTACK-6504


Repository: cloudstack-git


Description
---

 removed the warnings coming in building hyper-v agent code. One warning 
related to System.Net.Http dependency is still there. All other warnings have 
been removed.


Diffs
-

  
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs
 c222102 
  
plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs
 0f084db 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs 
d0d3d83 
  plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs 
4795073 

Diff: https://reviews.apache.org/r/20701/diff/


Testing
---

tested by creating the fresh setup after the removal of warnings.


Thanks,

Anshul Gangwar



Re: [VOTE] Release Apache CloudStack CloudMonkey 5.1.0

2014-04-24 Thread Chiradeep Vittal
Thanks. I did put together a test procedure (incomplete / wrong due to copy 
paste) here:
https://cwiki.apache.org/confluence/x/2iNqAg

Unfortunately Confluence is preventing me from editing this page any further. I 
have sent a request to infra for a fix.

From: Rajani Karuturi 
mailto:rajani.karut...@citrix.com>>
Reply-To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Date: Thursday, April 24, 2014 at 9:33 PM
To: "dev@cloudstack.apache.org" 
mailto:dev@cloudstack.apache.org>>
Subject: Re: [VOTE] Release Apache CloudStack CloudMonkey 5.1.0

+1
Tested the username password support and works fine. This is very useful during 
development.

~Rajani



On 25-Apr-2014, at 5:42 am, Chiradeep Vittal 
mailto:chiradeep.vit...@citrix.com>> wrote:

Hi All,
I've created a 5.1.0 release of CloudMonkey, with the following artifacts
up for a vote:
Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shor
tlog;h=refs/heads/5.1.0
Commit: 0b7a6bce246bbf261e6f096d1c18a85949ed5a22
List of changes:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob
_plain;f=CHANGES;hb=5.1.0
Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.1.0/
PGP release keys (signed using E8DAE809):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS
Vote will be open for 72 hours.
For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?
[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)




Re: [VOTE] Release Apache CloudStack CloudMonkey 5.1.0

2014-04-24 Thread Rohit Yadav
+1

IMO changelog should be sorted by descending versions, so log wrt newer
version is at the beginning of CHANGES

Regards.


On Fri, Apr 25, 2014 at 5:42 AM, Chiradeep Vittal <
chiradeep.vit...@citrix.com> wrote:

> Hi All,
>
> I've created a 5.1.0 release of CloudMonkey, with the following artifacts
> up for a vote:
>
> Git Branch and Commit SH:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shor
> tlog;h=refs/heads/5.1.0
> Commit: 0b7a6bce246bbf261e6f096d1c18a85949ed5a22
>
> List of changes:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob
> _plain;f=CHANGES;hb=5.1.0
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.1.0/
>
> PGP release keys (signed using E8DAE809):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>
>


Re: [VOTE] Release Apache CloudStack CloudMonkey 5.1.0

2014-04-24 Thread ilya musayev

Huge +1 (binding)
On 4/24/14, 5:12 PM, Chiradeep Vittal wrote:

Hi All,

I've created a 5.1.0 release of CloudMonkey, with the following artifacts
up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=shor
tlog;h=refs/heads/5.1.0
Commit: 0b7a6bce246bbf261e6f096d1c18a85949ed5a22

List of changes:
https://git-wip-us.apache.org/repos/asf?p=cloudstack-cloudmonkey.git;a=blob
_plain;f=CHANGES;hb=5.1.0

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/cloudmonkey-5.1.0/

PGP release keys (signed using E8DAE809):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)