Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

[Pradeep HK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23257/
---

Review request for cloudstack.


Bugs: CLOUDSTACK-5398
https://issues.apache.org/jira/browse/CLOUDSTACK-5398


Repository: cloudstack-git


Description
---

Pls refer to the Design document available @
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29

This feature is about a Cloudstack network-element plugin to orchestrate 
Juniper's switches.

As a first-cut, we are focussing on L2 services and we will write a 
NetworkGuru. As part of it's implement() method we will:
(1)Create the required logical interfaces on the Juniper switches (EX,QFX)
(2)Create the required VLANs on the Juniper switches (EX,QFX).
(3)Configure VLAN membership on the interfaces

Our customers need this plugin in Cloudstack deployments to automatically 
orchestrate the Juniper switches to create Virtual Networks.
Without this plugin, there will be a manual intervention needed to configure 
the switches (after figuring out the
current configuration of the switch).

We have a Network Management Platform (called JUNOS SPACE) which is heavily 
used by customers to orchestrate Juniper's networking devices.
It also exposes REST-ful APIs for integration with 3rdParty tools.
The proposed Juniper's Cloudstack network-element plugin leverages these 
REST-ful APIs to appropriately orchestrate Juniper's switches to
create Virtual Networks


Diffs
-

  plugins/network-elements/juniper-networkguru/pom.xml PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/module.properties
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/spring-junipernetworkguru-context.xml
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/JuniperNetworkGuru.properties 
PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/guru/JuniperNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDao.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/DeviceInterfacesMap.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ELSJunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JuniperNDAPIConstants.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/LLDPNeighbors.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ShowHardwareModel.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/Utils.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/netconfOperations/NetconfOperations.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/23257/diff/


Testing
---

When a Network created from Cloudstack UI is assigned a vlan-id, the same gets 
orchestrated on the Juniper switches.

We have tested the above scenarios :
(1)Various Hypervisors like KVM,VMWare,Xen
(2)LLDP is enabled on switches and hosts (to get info abt the switch-port 
connected to hosts)
(3)Integration with Network Director API 1.6


Thanks,

Pradeep HK

RE: Doc on Network Throttling

[Rajesh Battala]

Hi Alena,
I have updated wiki for Hyper-V

Thanks
Rajesh Battala

From: Alena Prokharchyk
Sent: Wednesday, July 2, 2014 3:43 AM
To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
dev@cloudstack.apache.org
Subject: Doc on Network Throttling

As I remember seeing the question on how Network throttling works in CS, so 
I've created a wiki page explaining the CS implementation. Feel free to 
review/update/fix:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack

Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is set 
on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors accordingly? 
As I don't have enough expertise on this part.

-Alena.

Re: Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

[Pradeep HK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23257/
---

(Updated July 3, 2014, 8:19 a.m.)


Review request for cloudstack.


Changes
---

I had missed out doing a "git add" for the modified files before doing a "git 
commit"
(I am coming from svn !!!)

So regenerated the diff using
git diff master > juniper-networkguru-plugin.diff


Bugs: CLOUDSTACK-5398
https://issues.apache.org/jira/browse/CLOUDSTACK-5398


Repository: cloudstack-git


Description
---

Pls refer to the Design document available @
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29

This feature is about a Cloudstack network-element plugin to orchestrate 
Juniper's switches.

As a first-cut, we are focussing on L2 services and we will write a 
NetworkGuru. As part of it's implement() method we will:
(1)Create the required logical interfaces on the Juniper switches (EX,QFX)
(2)Create the required VLANs on the Juniper switches (EX,QFX).
(3)Configure VLAN membership on the interfaces

Our customers need this plugin in Cloudstack deployments to automatically 
orchestrate the Juniper switches to create Virtual Networks.
Without this plugin, there will be a manual intervention needed to configure 
the switches (after figuring out the
current configuration of the switch).

We have a Network Management Platform (called JUNOS SPACE) which is heavily 
used by customers to orchestrate Juniper's networking devices.
It also exposes REST-ful APIs for integration with 3rdParty tools.
The proposed Juniper's Cloudstack network-element plugin leverages these 
REST-ful APIs to appropriately orchestrate Juniper's switches to
create Virtual Networks


Diffs (updated)
-

  client/pom.xml 29fef4f 
  debian/cloudstack-management.install ea3f93b 
  debian/rules 197e243 
  deps/install-non-oss.sh 940bd32 
  plugins/network-elements/juniper-networkguru/pom.xml PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/module.properties
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/spring-junipernetworkguru-context.xml
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/JuniperNetworkGuru.properties 
PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/guru/JuniperNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDao.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/DeviceInterfacesMap.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ELSJunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JuniperNDAPIConstants.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/LLDPNeighbors.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ShowHardwareModel.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/Utils.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/netconfOperations/NetconfOperations.java
 PRE-CREATION 
  plugins/pom.xml b5e6a61 

Diff: https://reviews.apache.org/r/23257/diff/


Testing
---

When a Network created from Cloudstack UI is assigned a vlan-id, the same gets 
orchestrated on the Juniper switches.

We have tested the above scenarios :
(1)Various Hypervisors like KVM,VMWare,Xen
(2)LLDP is enabled on switches and hosts (to get info abt the switch-port 
connected to hosts)
(3)Integration with Network Director API 1.6


Thanks,

Pradeep HK

Re: git commit: updated refs/heads/4.3 to 85bed5f

[Rajani Karuturi]

If you see the code above try block, placeholder is getting set only when 
VmJobEnabled.value() is true.

so, doing a not null check on placeholder will imply that VmJobEnabled.value() 
is true.

Here is the complete code block

755
 VmWorkJobVO placeHolder = null;
756
 if (VmJobEnabled.value()) {
757
 VirtualMachine vm = _vmDao.findByUuid(vmUuid);
758
 placeHolder = createPlaceHolderWork(vm.getId());
759
 }
760
 try {
761
 orchestrateStart(vmUuid, params, planToDeploy, planner);
762
 } finally {
763
 if (placeHolder != null) {
764
 _workJobDao.expunge(placeHolder.getId());
765
 }
766
 }


~Rajani



On 02-Jul-2014, at 7:50 pm, Santhosh Edukulla 
mailto:santhosh.eduku...@citrix.com>> wrote:

Rajani,

One note though: Here, null check should be for placeHolder value,  I believe 
we still need "VmJobEnabled.value()", otherwise the respective behavior may get 
changed, here null dereference is happening for placeHolder value, so may be 
changing like "if ( (VmJobEnabled.value() && (placeHolder!=null)) correct? 
thoughts?

if (VmJobEnabled.value())
+if (placeHolder != null) {

Thanks!
Santhosh


From: seb...@apache.org 
[seb...@apache.org]
Sent: Wednesday, July 02, 2014 10:07 AM
To: comm...@cloudstack.apache.org
Subject: git commit: updated refs/heads/4.3 to 85bed5f

Repository: cloudstack
Updated Branches:
 refs/heads/4.3 44c8e1f67 -> 85bed5fa2


COVERITY: Fixed issues reported by coverity NPEs, unwritten field access and 
self assignment

Signed-off-by: Sebastien Goasguen mailto:run...@gmail.com>>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/85bed5fa
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/85bed5fa
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/85bed5fa

Branch: refs/heads/4.3
Commit: 85bed5fa2b8d61a867e2d53b2402eced0c4b6704
Parents: 44c8e1f
Author: Rajani Karuturi 
mailto:rajanikarut...@gmail.com>>
Authored: Tue Jun 10 13:52:43 2014 +0530
Committer: Sebastien Goasguen mailto:run...@gmail.com>>
Committed: Wed Jul 2 16:07:06 2014 +0200

--
.../com/cloud/vm/VirtualMachineManagerImpl.java | 43 +++-
1 file changed, 24 insertions(+), 19 deletions(-)
-

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Koushik Das]

> On July 1, 2014, 10:36 a.m., Koushik Das wrote:
> > Why are tests using simulator mock moved to 'maint' folder?
> > 
> > If you remove test_deploy_vm.py make sure that the following test is moved 
> > to another file. This is meant to test list VM with multiple 'ids'.
> > 
> > @attr(tags = ['advanced', 'basic', 'sg'], required_hardware="false")
> > def test_deploy_vm_multiple(self):
> > 
> >
> 
> Gaurav Aradhye wrote:
> Sure, I will move that test case to different suite.
> 
> The test cases using SimulatorMock fail when run along with other test 
> suites in parallel. Also, due to them other test cases fail, e.g. the test 
> case which simulate host failure. Hence these need to be moved to separate 
> folder, so that these test cases can be run serially.
> 
> Are you suggesting a different folder name other than maint?
> 
> Koushik Das wrote:
> As long as the the simulator tests gets executed no issues. The name of 
> the folder is misleading, if the purpose is to put all tests that needs 
> serial execution then name it appropriately.
> 
> Gaurav Aradhye wrote:
> I have moved test to test_vm_life_cycle.py as it already had test related 
> to deploy and list the VM.
> Also renamed it to "test_list_vms_multiple_ids".
> 
> Renamed to maint to SimulatorMockTests
> 
> Please review the updated patch.

I am ok with the changes.


- Koushik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47049
---


On July 2, 2014, 6:55 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Doc on Network Throttling

[Rajani Karuturi]

Thanks for the wiki alena and rajesh.
Can this be moved to docs? 
http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling


~Rajani



On 03-Jul-2014, at 1:27 pm, Rajesh Battala 
mailto:rajesh.batt...@citrix.com>> wrote:

Hi Alena,
I have updated wiki for Hyper-V

Thanks
Rajesh Battala

From: Alena Prokharchyk
Sent: Wednesday, July 2, 2014 3:43 AM
To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
dev@cloudstack.apache.org
Subject: Doc on Network Throttling

As I remember seeing the question on how Network throttling works in CS, so 
I've created a wiki page explaining the CS implementation. Feel free to 
review/update/fix:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack

Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is set 
on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors accordingly? 
As I don't have enough expertise on this part.

-Alena.

Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

[Rajani Karuturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/
---

(Updated July 3, 2014, 8:59 a.m.)


Review request for cloudstack, Kishan Kavala, Rayees Namathponnan, and 
Sebastien Goasguen.


Changes
---

uploaded a patch for 4.3


Bugs: CLOUDSTACK-6926
https://issues.apache.org/jira/browse/CLOUDSTACK-6926


Repository: cloudstack-git


Description
---

used to readlink -e and dirname to get the JAVA_HOME
if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
else jre home if java is present.
if nothing is present, it exits with error


Diffs (updated)
-

  packaging/centos63/cloud-usage.rc e78f8c1 
  packaging/debian/init/cloud-usage 1cc75cc 

Diff: https://reviews.apache.org/r/22721/diff/


Testing
---


tested it when java is not installed, jre is installed, jdk installed or when a 
older version is installed on centos 6.4 and ubuntu 14.04 


Thanks,

Rajani Karuturi

[ACS431]CLOUDSTACK-6360: Usage server failed to start with 4.4 build

[Rajani Karuturi]

Hi Sebastien,

while rebasing the fix for CLOUDSTACK-6926, I observed that mysql connector 
related changes aren’t done in the debian cloud-usage script.
I reopened the related issue 
https://issues.apache.org/jira/browse/CLOUDSTACK-6360?focusedCommentId=14051219

I think it would be good to have the fix for CLOUDSTACK-6360 in 4.3.1

~Rajani



On 02-Jul-2014, at 7:33 pm, Sebastien Goasguen 
mailto:run...@gmail.com>> wrote:

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/22721/


Hi, no it does not apply cleanly to current 4.3 branch. Can you rebase.

thanks


- Sebastien Goasguen


On June 18th, 2014, 10:15 a.m. UTC, Rajani Karuturi wrote:

Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
By Rajani Karuturi.

Updated June 18, 2014, 10:15 a.m.

Bugs: CLOUDSTACK-6926
Repository: cloudstack-git
Description

used to readlink -e and dirname to get the JAVA_HOME
if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
else jre home if java is present.
if nothing is present, it exits with error


Testing

tested it when java is not installed, jre is installed, jdk installed or when a 
older version is installed on centos 6.4 and ubuntu 14.04


Diffs

  *   packaging/centos63/cloud-usage.rc (6170379)
  *   packaging/debian/init/cloud-usage (1cc75cc)

View Diff

Release 4.5 / 4.6

[Hugo Trippaers]

Hey all,

Just checking the schedule. Sticking to the fourth month release cycle means 
that the feature freeze for 4.5 is coming up really fast.

The feature freeze for 4.4 was March 19
That makes the feature freeze date for 4.5 July 19
And the feature freeze for 4.6 November 19

Do we have any volunteers for being the release manager for release 4.5?

Cheers,

Hugo

RE: git commit: updated refs/heads/4.3 to 85bed5f

[Santhosh Edukulla]

Though logically it is correct, but still it makes sense to use expunge based 
upon the business condition i.e., vmjobenabled.value() , we are using 
intermediate statement reference to expunge which may do the task, but the 
logic  of expunge when to expunge or when not to expunge is based on 
vmjobenabled.value() i believe, as well, there is a chance in between 
placeholder can be null but vmjobenabled.value() can be still be true, in that 
case we may want to throw some exception.

Santhosh

From: Rajani Karuturi [rajani.karut...@citrix.com]
Sent: Thursday, July 03, 2014 4:39 AM
To: dev@cloudstack.apache.org
Subject: Re: git commit: updated refs/heads/4.3 to 85bed5f

If you see the code above try block, placeholder is getting set only when 
VmJobEnabled.value() is true.

so, doing a not null check on placeholder will imply that VmJobEnabled.value() 
is true.

Here is the complete code block

755
 VmWorkJobVO placeHolder = null;
756
 if (VmJobEnabled.value()) {
757
 VirtualMachine vm = _vmDao.findByUuid(vmUuid);
758
 placeHolder = createPlaceHolderWork(vm.getId());
759
 }
760
 try {
761
 orchestrateStart(vmUuid, params, planToDeploy, planner);
762
 } finally {
763
 if (placeHolder != null) {
764
 _workJobDao.expunge(placeHolder.getId());
765
 }
766
 }


~Rajani



On 02-Jul-2014, at 7:50 pm, Santhosh Edukulla 
mailto:santhosh.eduku...@citrix.com>> wrote:

Rajani,

One note though: Here, null check should be for placeHolder value,  I believe 
we still need "VmJobEnabled.value()", otherwise the respective behavior may get 
changed, here null dereference is happening for placeHolder value, so may be 
changing like "if ( (VmJobEnabled.value() && (placeHolder!=null)) correct? 
thoughts?

if (VmJobEnabled.value())
+if (placeHolder != null) {

Thanks!
Santhosh


From: seb...@apache.org 
[seb...@apache.org]
Sent: Wednesday, July 02, 2014 10:07 AM
To: comm...@cloudstack.apache.org
Subject: git commit: updated refs/heads/4.3 to 85bed5f

Repository: cloudstack
Updated Branches:
 refs/heads/4.3 44c8e1f67 -> 85bed5fa2


COVERITY: Fixed issues reported by coverity NPEs, unwritten field access and 
self assignment

Signed-off-by: Sebastien Goasguen mailto:run...@gmail.com>>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-

Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/#review47282
---

Ship it!


Ship It!

- Santhosh Edukulla


On July 2, 2014, 10:16 p.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22692/
> ---
> 
> (Updated July 2, 2014, 10:16 p.m.)
> 
> 
> Review request for cloudstack, Doug Clark, Girish Shilamkar, Raja Pullela, 
> sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, 
> SrikanteswaraRao Talluri, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Test Suite for Testing Remote Access VPN on VPC. 
> 
> I successfully automated the following components:
> 
> 1.VPN Client Installation on Linux
> 2.Component that efficiently verifies Remote VPN Access between client and 
> the Server.
> 3.Developed a component that automates VPN Client Configuration and services.
> 4.Test Cases of the Feature
> 5.Tested the Code multiple times on XenServer and fixed the bugs.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22692/diff/
> 
> 
> Testing
> ---
> 
> Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: 
> test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
> ok
> Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser 
> | Status : SUCCESS ===
> ok
> Test case 03 : Add a Different VPN User and Test Access with already existing 
> VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
> ===
> ok
> Test case 04 : Add a Previously Removed VPN User from the VPC and Test the 
> VPN Connectivity ... === TestName: 
> test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
> ok
> Test case 05 : Disable the VPN Service on the VPC ... === TestName: 
> test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
> ok
> Test case 06 : Enabled Previously Disabled VPN Access to VPC. ... === 
> TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : 
> SUCCESS ===
> ok
> Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 
> Configuration parameter ... === TestName: 
> test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
> ok
> 
> --
> Ran 7 tests in 2495.099s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>

Re: Review Request 22692: Test Suite for Testing Remote Access VPN on VPC

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22692/#review47283
---

Ship it!


Ship It!

- Santhosh Edukulla


On July 2, 2014, 10:16 p.m., Chandan Purushothama wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22692/
> ---
> 
> (Updated July 2, 2014, 10:16 p.m.)
> 
> 
> Review request for cloudstack, Doug Clark, Girish Shilamkar, Raja Pullela, 
> sangeetha hariharan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, 
> SrikanteswaraRao Talluri, and Sheng Yang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Test Suite for Testing Remote Access VPN on VPC. 
> 
> I successfully automated the following components:
> 
> 1.VPN Client Installation on Linux
> 2.Component that efficiently verifies Remote VPN Access between client and 
> the Server.
> 3.Developed a component that automates VPN Client Configuration and services.
> 4.Test Cases of the Feature
> 5.Tested the Code multiple times on XenServer and fixed the bugs.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_remotevpn_vpc.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22692/diff/
> 
> 
> Testing
> ---
> 
> Test case 01 : Enable VPN for Public IP Address on the VPC ... === TestName: 
> test_01_RemoteAccessVPN_VPC_EnableVPNAndConnecttoVM | Status : SUCCESS ===
> ok
> Test case 02 : Remote a VPN User ... === TestName: test_02_VPC_RemoveVPNUser 
> | Status : SUCCESS ===
> ok
> Test case 03 : Add a Different VPN User and Test Access with already existing 
> VPN User ... === TestName: test_03_VPC_AddDifferentVPNUser | Status : SUCCESS 
> ===
> ok
> Test case 04 : Add a Previously Removed VPN User from the VPC and Test the 
> VPN Connectivity ... === TestName: 
> test_04_VPC_AddPreviouslyRemovedVPNUserTestConnectivity | Status : SUCCESS ===
> ok
> Test case 05 : Disable the VPN Service on the VPC ... === TestName: 
> test_05_VPC_DisableVPNServiceOnVPC | Status : SUCCESS ===
> ok
> Test case 06 : Enabled Previously Disabled VPN Access to VPC. ... === 
> TestName: test_06_VPC_EnablePreviouslyDisabledVPNAccesstoVPC | Status : 
> SUCCESS ===
> ok
> Test case 07 : Create Nine VPN Users to test the remote.vpn.user.limit=8 
> Configuration parameter ... === TestName: 
> test_07_ConfigParam_TestRemoteVPNUserLimit | Status : SUCCESS ===
> ok
> 
> --
> Ran 7 tests in 2495.099s
> 
> OK
> 
> 
> Thanks,
> 
> Chandan Purushothama
> 
>

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Santhosh Edukulla]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---

Ship it!


Ship It!

- Santhosh Edukulla


On July 2, 2014, 6:55 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity

[Santhosh Edukulla]

> On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote:
> > Good stuff, but there seem to be a number of places where the 
> > PreparedStatement should be inside the try clause to actually guarantee 
> > closing the resource i think.  Can you have a look?

Hugo,

Please let me know if the comments are ok, if yes, i will push the changes. 
Thanks again!
Santhosh


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/#review47181
---


On July 2, 2014, 8:44 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23226/
> ---
> 
> (Updated July 2, 2014, 8:44 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
> 
> 
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed resource leaks, null dererence issues, performance issues and bugs 
> reported by coverity. Simple bug in generic dao was found during these 
> changes, fixed that as well.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e 
>   engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74 
>   engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d 
>   engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8 
>   engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java 
> c868ac0 
>   engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java 
> f27fd60 
>   engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java 
> 803288a 
>   engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java 
> 0fc2ce0 
>   engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f 
>   engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd 
>   engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  92793f1 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java
>  b4ef595 
>   
> engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
>  6b12975 
>   
> framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java 
> 3d0c3f5 
>   framework/db/src/com/cloud/utils/db/DbUtil.java 792573c 
>   framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
>  e684b8d 
>   
> plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java
>  579cc24 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e 
>   server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d 
> 
> Diff: https://reviews.apache.org/r/23226/diff/
> 
> 
> Testing
> ---
> 
> Built the management server, ran the simulator and deployed dc.
> 
> 
> Thanks,
> 
> Santhosh Edukulla
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---

(Updated July 3, 2014, 10:22 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Changes
---

Ignored readme.txt from rat build


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834


Repository: cloudstack-git


Description
---

Incorporated some Changes to include things like runservice readme checkbox, 
changing the default installation location etc..


Diffs (updated)
-

  client/pom.xml 29fef4f 
  pom.xml 0b3b56e 
  scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
  scripts/installer/windows/acs.wxs bf09afc 
  scripts/installer/windows/dependencies.wxs 987c561 
  scripts/installer/windows/en-us.wxl 2f34575 
  scripts/installer/windows/optionstheme_en-us.wxl c822929 
  scripts/installer/windows/readme.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/23192/diff/


Testing
---

Tested on Windows 2012 Server


Thanks,

Damodar Reddy Talakanti

Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23258/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7062
https://issues.apache.org/jira/browse/CLOUDSTACK-7062


Repository: cloudstack-git


Description
---

Tagging test_01_primary_storage_iscsi with BugId


Diffs
-

  test/integration/smoke/test_primary_storage.py 66aec59 

Diff: https://reviews.apache.org/r/23258/diff/


Testing
---


Thanks,

Gaurav Aradhye

Re: Review Request 23226: Fixed resource leaks, null dererence issues, performance issues and bugs reported by coverity

[Hugo Trippaers]

> On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote:
> > engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java, line 310
> > 
> >
> > Shouldn't this be inside the try-with-resources bit of the try keyword?
> 
> Santhosh Edukulla wrote:
> Here we are taking care of closing the resource with 
> "prepareAutoCloseStatement", compared to normal call of "prepareStatement" i 
> believe. We used try with resource where prepare through auto close was not 
> followed. Going ahead, we can change it to try with resource, to make it 
> uniform, but here other leak issue is fixed i believe.

I think we should avoid using the prepareAutoCloseStatement in favor of the 
try-with-resources. The prepareAutoCloseStatement doesn't really close the 
statement unless it is called a second time if i understand the code correctly.


> On July 2, 2014, 12:50 p.m., Hugo Trippaers wrote:
> > engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java,
> >  line 71
> > 
> >
> > To make it more clear for the readers of the code why not write 'if 
> > (params == null) { throw blabla }'
> > 
> >
> 
> Santhosh Edukulla wrote:
> We can, As such possibility of null referencing is fixed, going ahead, i 
> can add a log and throw accordingly, but on second note, i assume that the 
> calling function based upon the callable output can log and throw accordingly 
> there, rather we take care in the called function. Let me know your thoughts.

This function is apparently called by plugins directly, so we should be 
prepared to handle params being null in this function. So your solution is 
correct, it's just coding style..  Instead of if (x != null) { 
do_lots_of_stuff(); } throw exception, it's better to write if (x==null) { 
throw exception} do_lots_of_stuff();


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23226/#review47181
---


On July 2, 2014, 8:44 a.m., Santhosh Edukulla wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23226/
> ---
> 
> (Updated July 2, 2014, 8:44 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and daan Hoogland.
> 
> 
> Bugs: coverity
> https://issues.apache.org/jira/browse/coverity
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixed resource leaks, null dererence issues, performance issues and bugs 
> reported by coverity. Simple bug in generic dao was found during these 
> changes, fixed that as well.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/dc/dao/VlanDaoImpl.java a38a96e 
>   engine/schema/src/com/cloud/storage/dao/StoragePoolWorkDaoImpl.java c6e1b74 
>   engine/schema/src/com/cloud/upgrade/DatabaseCreator.java b04607d 
>   engine/schema/src/com/cloud/usage/dao/UsageIPAddressDaoImpl.java 17d5dc8 
>   engine/schema/src/com/cloud/usage/dao/UsageLoadBalancerPolicyDaoImpl.java 
> c868ac0 
>   engine/schema/src/com/cloud/usage/dao/UsageNetworkOfferingDaoImpl.java 
> f27fd60 
>   engine/schema/src/com/cloud/usage/dao/UsagePortForwardingRuleDaoImpl.java 
> 803288a 
>   engine/schema/src/com/cloud/usage/dao/UsageSecurityGroupDaoImpl.java 
> 0fc2ce0 
>   engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 77fc56f 
>   engine/schema/src/com/cloud/usage/dao/UsageVPNUserDaoImpl.java 64d3ecd 
>   engine/schema/src/com/cloud/usage/dao/UsageVolumeDaoImpl.java 7bf058c 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  92793f1 
>   
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/allocator/StorageCacheRandomAllocator.java
>  b4ef595 
>   
> engine/storage/src/org/apache/cloudstack/storage/volume/datastore/PrimaryDataStoreHelper.java
>  6b12975 
>   
> framework/cluster/src/com/cloud/cluster/dao/ManagementServerHostDaoImpl.java 
> 3d0c3f5 
>   framework/db/src/com/cloud/utils/db/DbUtil.java 792573c 
>   framework/db/src/com/cloud/utils/db/GenericDaoBase.java 2052aad 
>   
> plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
>  e684b8d 
>   
> plugins/storage/volume/sample/src/org/apache/cloudstack/storage/datastore/lifecycle/SamplePrimaryDataStoreLifeCycleImpl.java
>  579cc24 
>   server/src/com/cloud/storage/VolumeApiServiceImpl.java a557c0e 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java b77c55e 
>   server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java e085b8d 
> 
> Diff: https://reviews.apache.org/r/23226/diff/
> 
> 
> Testing
> ---
> 
> Built the management server, ran the simulator and deployed dc.
> 
> 
> Th

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Santhosh Edukulla]

> On July 3, 2014, 10:02 a.m., Santhosh Edukulla wrote:
> > Ship It!

Patch didnt apply cleanly. Please check. As well, do we need two folders now 
one maint and one misc? Is both the purpose same beneath to run them separately 
and sequentially. If yes, we can have one folder for now. What say?


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---


On July 2, 2014, 6:55 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23257/#review47287
---


Thanks for submitting this review, great to see this happening.

Besides a few points line by line there is a general remark i want to make. 
This plugin doesn't follow the agent resource model. Plugin generally follow 
this pattern to ensure that the code calling the external device is registered 
as an agent (this also gives you access to configuration parameters) and the 
orchestration bits are happening in the network guru layer. As i can see it 
this plugin should also follow that pattern, but if you have a reason not to 
work that way i'm interested to discuss this.

Also configuration should be available in the API so administrators can 
programmatically use this plugin. It should not be something that is based on a 
configuration outside CloudStack.

Hope you can address these items. If you want to discuss catch me on IRC or on 
the dev list.

Cheers,

Hugo


debian/cloudstack-management.install


Why do you need a separate configuration file? This is typically done using 
the cloudstack configuration mechanism. Either by adding a network service 
provider or using configuration properties.

Using separate configuration files means cloudstack administrators can't 
configure the system from within the UI or with APIs. Breaking a fundamental 
design principle.



deps/install-non-oss.sh


Any possibility of getting this publicly available from a maven repository? 
What are the licensing restrictions that require this to be in the noredist 
build?



plugins/network-elements/juniper-networkguru/pom.xml


It would be best to avoid repository statements in the pom files. This will 
break compilation for people using proxys and other maven management tools.  
Which dependency is not available on the regular maven systems?



plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java


Possible to fix this TODO before submitting?


- Hugo Trippaers


On July 3, 2014, 8:19 a.m., Pradeep HK wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23257/
> ---
> 
> (Updated July 3, 2014, 8:19 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5398
> https://issues.apache.org/jira/browse/CLOUDSTACK-5398
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Pls refer to the Design document available @
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29
> 
> This feature is about a Cloudstack network-element plugin to orchestrate 
> Juniper's switches.
> 
> As a first-cut, we are focussing on L2 services and we will write a 
> NetworkGuru. As part of it's implement() method we will:
> (1)Create the required logical interfaces on the Juniper switches (EX,QFX)
> (2)Create the required VLANs on the Juniper switches (EX,QFX).
> (3)Configure VLAN membership on the interfaces
> 
> Our customers need this plugin in Cloudstack deployments to automatically 
> orchestrate the Juniper switches to create Virtual Networks.
> Without this plugin, there will be a manual intervention needed to configure 
> the switches (after figuring out the
> current configuration of the switch).
> 
> We have a Network Management Platform (called JUNOS SPACE) which is heavily 
> used by customers to orchestrate Juniper's networking devices.
> It also exposes REST-ful APIs for integration with 3rdParty tools.
> The proposed Juniper's Cloudstack network-element plugin leverages these 
> REST-ful APIs to appropriately orchestrate Juniper's switches to
> create Virtual Networks
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   debian/cloudstack-management.install ea3f93b 
>   debian/rules 197e243 
>   deps/install-non-oss.sh 940bd32 
>   plugins/network-elements/juniper-networkguru/pom.xml PRE-CREATION 
>   
> plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/module.properties
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/spring-junipernetworkguru-context.xml
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-networkguru/src/JuniperNetworkGuru.properties
>  PRE-CREATION 
>   
> plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java
>  PRE-CREATION 
>   
> plugins/network-element

Re: Review Request 23257: Cloudstack network-element plugin to orchestrate Juniper's switches (for L2 services)

[Pradeep HK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23257/
---

(Updated July 3, 2014, 11:54 a.m.)


Review request for cloudstack and Hugo Trippaers.


Bugs: CLOUDSTACK-5398
https://issues.apache.org/jira/browse/CLOUDSTACK-5398


Repository: cloudstack-git


Description
---

Pls refer to the Design document available @
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Cloudstack+network-element+plugin+to+orchestrate+Juniper%27s+switches+%28for+L2+services%29

This feature is about a Cloudstack network-element plugin to orchestrate 
Juniper's switches.

As a first-cut, we are focussing on L2 services and we will write a 
NetworkGuru. As part of it's implement() method we will:
(1)Create the required logical interfaces on the Juniper switches (EX,QFX)
(2)Create the required VLANs on the Juniper switches (EX,QFX).
(3)Configure VLAN membership on the interfaces

Our customers need this plugin in Cloudstack deployments to automatically 
orchestrate the Juniper switches to create Virtual Networks.
Without this plugin, there will be a manual intervention needed to configure 
the switches (after figuring out the
current configuration of the switch).

We have a Network Management Platform (called JUNOS SPACE) which is heavily 
used by customers to orchestrate Juniper's networking devices.
It also exposes REST-ful APIs for integration with 3rdParty tools.
The proposed Juniper's Cloudstack network-element plugin leverages these 
REST-ful APIs to appropriately orchestrate Juniper's switches to
create Virtual Networks


Diffs
-

  client/pom.xml 29fef4f 
  debian/cloudstack-management.install ea3f93b 
  debian/rules 197e243 
  deps/install-non-oss.sh 940bd32 
  plugins/network-elements/juniper-networkguru/pom.xml PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/module.properties
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/resources/META-INF/cloudstack/junipernetworkguru/spring-junipernetworkguru-context.xml
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/JuniperNetworkGuru.properties 
PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/JuniperNDAPINaasServiceNetworkMapVO.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/guru/JuniperNetworkGuru.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDao.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/naas/dao/JuniperNDAPINaasServiceNetworkMapDaoImpl.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/DeviceInterfacesMap.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ELSJunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JuniperNDAPIConstants.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/JunosL2XMLConfigs.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/LLDPNeighbors.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/ShowHardwareModel.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/Utils.java
 PRE-CREATION 
  
plugins/network-elements/juniper-networkguru/src/com/cloud/network/utils/netconfOperations/NetconfOperations.java
 PRE-CREATION 
  plugins/pom.xml b5e6a61 

Diff: https://reviews.apache.org/r/23257/diff/


Testing
---

When a Network created from Cloudstack UI is assigned a vlan-id, the same gets 
orchestrated on the Juniper switches.

We have tested the above scenarios :
(1)Various Hypervisors like KVM,VMWare,Xen
(2)LLDP is enabled on switches and hosts (to get info abt the switch-port 
connected to hosts)
(3)Integration with Network Director API 1.6


Thanks,

Pradeep HK

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Hugo Trippaers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
---


I'm not sure we can actually have a dependency on the mysql connector like this 
because of it's GPL license. I'll check this and get back on this before we can 
accept this patch.

- Hugo Trippaers


On July 3, 2014, 10:22 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 10:22 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Damodar Reddy Talakanti]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/
---

(Updated July 3, 2014, 11:58 a.m.)


Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
Trippaers.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834


Repository: cloudstack-git


Description
---

Incorporated some Changes to include things like runservice readme checkbox, 
changing the default installation location etc..


Diffs
-

  client/pom.xml 29fef4f 
  pom.xml 0b3b56e 
  scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
  scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
  scripts/installer/windows/acs.wxs bf09afc 
  scripts/installer/windows/dependencies.wxs 987c561 
  scripts/installer/windows/en-us.wxl 2f34575 
  scripts/installer/windows/optionstheme_en-us.wxl c822929 
  scripts/installer/windows/readme.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/23192/diff/


Testing
---

Tested on Windows 2012 Server


Thanks,

Damodar Reddy Talakanti

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Gaurav Aradhye]

> On July 3, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > Ship It!
> 
> Santhosh Edukulla wrote:
> Patch didnt apply cleanly. Please check. As well, do we need two folders 
> now one maint and one misc? Is both the purpose same beneath to run them 
> separately and sequentially. If yes, we can have one folder for now. What say?
>

maint folder is currently under component (regression tests) and misc is under 
smoke. I did not put the test cases in maint because not mixing BVT and 
regression test suites.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---


On July 2, 2014, 12:25 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 12:25 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23258/#review47291
---


Commit f5139f78395146ee99b9e0fdc376351b28c34063 in cloudstack's branch 
refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f5139f7 ]

CLOUDSTACK-7062: Tagging test case with BugId


- ASF Subversion and Git Services


On July 3, 2014, 10:45 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23258/
> ---
> 
> (Updated July 3, 2014, 10:45 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7062
> https://issues.apache.org/jira/browse/CLOUDSTACK-7062
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Tagging test_01_primary_storage_iscsi with BugId
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_primary_storage.py 66aec59 
> 
> Diff: https://reviews.apache.org/r/23258/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Santhosh Edukulla]

> On July 3, 2014, 10:02 a.m., Santhosh Edukulla wrote:
> > Ship It!
> 
> Santhosh Edukulla wrote:
> Patch didnt apply cleanly. Please check. As well, do we need two folders 
> now one maint and one misc? Is both the purpose same beneath to run them 
> separately and sequentially. If yes, we can have one folder for now. What say?
>
> 
> Gaurav Aradhye wrote:
> maint folder is currently under component (regression tests) and misc is 
> under smoke. I did not put the test cases in maint because not mixing BVT and 
> regression test suites.

ok, some how we need to find a cleaner representation i believe, instead of 
multiple folders with different names, now can we check whether patch is 
applying cleanly or not?


- Santhosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---


On July 2, 2014, 6:55 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 6:55 a.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23258/
---

(Updated July 3, 2014, 5:49 p.m.)


Review request for cloudstack and Girish Shilamkar.


Changes
---

Adding patch for master


Bugs: CLOUDSTACK-7062
https://issues.apache.org/jira/browse/CLOUDSTACK-7062


Repository: cloudstack-git


Description
---

Tagging test_01_primary_storage_iscsi with BugId


Diffs
-

  test/integration/smoke/test_primary_storage.py 66aec59 

Diff: https://reviews.apache.org/r/23258/diff/


Testing
---


File Attachments (updated)


Patch for master
  
https://reviews.apache.org/media/uploaded/files/2014/07/03/172621ab-42ad-4d11-91b9-1f43f5d290b1__0001-CLOUDSTACK-7062-Tagging-test-case-with-bug-Id.patch


Thanks,

Gaurav Aradhye

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Gaurav Aradhye]

> On July 3, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > Ship It!
> 
> Santhosh Edukulla wrote:
> Patch didnt apply cleanly. Please check. As well, do we need two folders 
> now one maint and one misc? Is both the purpose same beneath to run them 
> separately and sequentially. If yes, we can have one folder for now. What say?
>
> 
> Gaurav Aradhye wrote:
> maint folder is currently under component (regression tests) and misc is 
> under smoke. I did not put the test cases in maint because not mixing BVT and 
> regression test suites.
> 
> Santhosh Edukulla wrote:
> ok, some how we need to find a cleaner representation i believe, instead 
> of multiple folders with different names, now can we check whether patch is 
> applying cleanly or not?

Yes will add new clean patch.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---


On July 2, 2014, 12:25 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 2, 2014, 12:25 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Koushik Das]

> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
> > I'm not sure we can actually have a dependency on the mysql connector like 
> > this because of it's GPL license. I'll check this and get back on this 
> > before we can accept this patch.

Hugo, I committed this patch (on master 
ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this 
comment from you. If there is going to be a license issue then please feel free 
to revert.


- Koushik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
---


On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 11:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
> Trippaers.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23258: CLOUDSTACK-7062: Tagging test case with BugId

[ASF Subversion and Git Services]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23258/#review47295
---


Commit 8c61566d612700f79b26e4e074502274cd676dcb in cloudstack's branch 
refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8c61566 ]

CLOUDSTACK-7062: Tagging test case with bug Id


- ASF Subversion and Git Services


On July 3, 2014, 12:19 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23258/
> ---
> 
> (Updated July 3, 2014, 12:19 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7062
> https://issues.apache.org/jira/browse/CLOUDSTACK-7062
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Tagging test_01_primary_storage_iscsi with BugId
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_primary_storage.py 66aec59 
> 
> Diff: https://reviews.apache.org/r/23258/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Patch for master
>   
> https://reviews.apache.org/media/uploaded/files/2014/07/03/172621ab-42ad-4d11-91b9-1f43f5d290b1__0001-CLOUDSTACK-7062-Tagging-test-case-with-bug-Id.patch
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Damodar Reddy Talakanti]

> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
> > I'm not sure we can actually have a dependency on the mysql connector like 
> > this because of it's GPL license. I'll check this and get back on this 
> > before we can accept this patch.
> 
> Koushik Das wrote:
> Hugo, I committed this patch (on master 
> ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this 
> comment from you. If there is going to be a license issue then please feel 
> free to revert.

Hugo,

 We are not packaging the connector with MSI, indeed we are downloading it from 
the Internet during installation similar to Linux environments.


- Damodar Reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47289
---


On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 11:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
> Trippaers.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Hugo Trippaers]

Hey Koushik,

No problem, will do if required.

The review doesn’t have a “ship it” state, so thats why i assumed it was not 
committed. Also a lot of folks adopted the common practice to put the commit id 
in a comment after committing a review. That makes it easier to trace.

Cheers,

Hugo


On 3 jul. 2014, at 14:29, Koushik Das  wrote:

> 
> 
>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
>>> I'm not sure we can actually have a dependency on the mysql connector like 
>>> this because of it's GPL license. I'll check this and get back on this 
>>> before we can accept this patch.
> 
> Hugo, I committed this patch (on master 
> ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this 
> comment from you. If there is going to be a license issue then please feel 
> free to revert.
> 
> 
> - Koushik
> 
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/#review47289
> ---
> 
> 
> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/
>> ---
>> 
>> (Updated July 3, 2014, 11:58 a.m.)
>> 
>> 
>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
>> Trippaers.
>> 
>> 
>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>
>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>> 
>> 
>> Repository: cloudstack-git
>> 
>> 
>> Description
>> ---
>> 
>> Incorporated some Changes to include things like runservice readme checkbox, 
>> changing the default installation location etc..
>> 
>> 
>> Diffs
>> -
>> 
>>  client/pom.xml 29fef4f 
>>  pom.xml 0b3b56e 
>>  scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>>  scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>>  scripts/installer/windows/acs.wxs bf09afc 
>>  scripts/installer/windows/dependencies.wxs 987c561 
>>  scripts/installer/windows/en-us.wxl 2f34575 
>>  scripts/installer/windows/optionstheme_en-us.wxl c822929 
>>  scripts/installer/windows/readme.txt PRE-CREATION 
>> 
>> Diff: https://reviews.apache.org/r/23192/diff/
>> 
>> 
>> Testing
>> ---
>> 
>> Tested on Windows 2012 Server
>> 
>> 
>> Thanks,
>> 
>> Damodar Reddy Talakanti
>> 
>> 
> 

Build error

[Mohamed Ali Saidi]

 Hi,

I'm trying to build Coudstack and i got this error:

  File "/home/cloudstack/tools/apidoc/gen_toc.py", line 223
with file(out, 'w') as f:
^
SyntaxError: invalid syntax

any idea?

regards,

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Hugo Trippaers]

On to the actual point behind my comment, ASF policy is not very clear about 
when we can or can’t put anything in our code that points to something with a 
(L)GPL license. I would like some feedback from people with a finer grasp of 
the policy to see if we can actually include this dependency on mysql and the 
mysql connection in our wix script.

Cheers,

Hugo

On 3 jul. 2014, at 14:33, Hugo Trippaers  wrote:

> Hey Koushik,
> 
> No problem, will do if required.
> 
> The review doesn’t have a “ship it” state, so thats why i assumed it was not 
> committed. Also a lot of folks adopted the common practice to put the commit 
> id in a comment after committing a review. That makes it easier to trace.
> 
> Cheers,
> 
> Hugo
> 
> 
> On 3 jul. 2014, at 14:29, Koushik Das  wrote:
> 
>> 
>> 
>>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
 I'm not sure we can actually have a dependency on the mysql connector like 
 this because of it's GPL license. I'll check this and get back on this 
 before we can accept this patch.
>> 
>> Hugo, I committed this patch (on master 
>> ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this 
>> comment from you. If there is going to be a license issue then please feel 
>> free to revert.
>> 
>> 
>> - Koushik
>> 
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/#review47289
>> ---
>> 
>> 
>> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>>> 
>>> ---
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/23192/
>>> ---
>>> 
>>> (Updated July 3, 2014, 11:58 a.m.)
>>> 
>>> 
>>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
>>> Trippaers.
>>> 
>>> 
>>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>>   
>>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> ---
>>> 
>>> Incorporated some Changes to include things like runservice readme 
>>> checkbox, changing the default installation location etc..
>>> 
>>> 
>>> Diffs
>>> -
>>> 
>>> client/pom.xml 29fef4f 
>>> pom.xml 0b3b56e 
>>> scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>>> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>>> scripts/installer/windows/acs.wxs bf09afc 
>>> scripts/installer/windows/dependencies.wxs 987c561 
>>> scripts/installer/windows/en-us.wxl 2f34575 
>>> scripts/installer/windows/optionstheme_en-us.wxl c822929 
>>> scripts/installer/windows/readme.txt PRE-CREATION 
>>> 
>>> Diff: https://reviews.apache.org/r/23192/diff/
>>> 
>>> 
>>> Testing
>>> ---
>>> 
>>> Tested on Windows 2012 Server
>>> 
>>> 
>>> Thanks,
>>> 
>>> Damodar Reddy Talakanti
>>> 
>>> 
>> 
> 

Re: Review Request 22721: removed hard coded jdk_dirs in cloud-usage script

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22721/#review47297
---

Ship it!


Applied to 4.3 branch for 4.3.1 release

thanks, you can mark the review as submitted

- Sebastien Goasguen


On July 3, 2014, 8:59 a.m., Rajani Karuturi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22721/
> ---
> 
> (Updated July 3, 2014, 8:59 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala, Rayees Namathponnan, and 
> Sebastien Goasguen.
> 
> 
> Bugs: CLOUDSTACK-6926
> https://issues.apache.org/jira/browse/CLOUDSTACK-6926
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> used to readlink -e and dirname to get the JAVA_HOME
> if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
> else jre home if java is present.
> if nothing is present, it exits with error
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-usage.rc e78f8c1 
>   packaging/debian/init/cloud-usage 1cc75cc 
> 
> Diff: https://reviews.apache.org/r/22721/diff/
> 
> 
> Testing
> ---
> 
> 
> tested it when java is not installed, jre is installed, jdk installed or when 
> a older version is installed on centos 6.4 and ubuntu 14.04 
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>

Re: Review Request 23168: Update cloudstack-usage JAVA_HOME to find JRE for Java 7

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23168/#review47298
---


Ok, there was actually an earlier patch https://reviews.apache.org/r/22721/
Which I think was a bit nicer, so I used that one instead.
It has been committed to 4.3.1

thanks, can you close the review?

- Sebastien Goasguen


On June 30, 2014, 3:54 p.m., Olivier Lemasle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23168/
> ---
> 
> (Updated June 30, 2014, 3:54 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> cloudstack-usage is currently configured to search JAVA_HOME only in a small 
> set of paths corresponding to Java 6 (/usr/lib/jvm/java-6-openjdk, 
> /usr/lib/jvm/java-6-openjdk-i386, etc).
> 
> If cloudstack-usage is installed on a server with only Java 7, the service 
> cannot start and fails with the following error:
> jsvc error: Cannot locate Java Home
> 
> This commit adds Java 7 paths to the possible set of JAVA_HOME locations.
> 
> 
> Diffs
> -
> 
>   packaging/centos63/cloud-usage.rc e78f8c1 
> 
> Diff: https://reviews.apache.org/r/23168/diff/
> 
> 
> Testing
> ---
> 
> Package CloudStack RPMs for CentOS and install them on a system with 
> java-1.7.0-openjdk and no Java 6 JRE.
> Check that cloudstack-usage works correctly.
> 
> 
> Thanks,
> 
> Olivier Lemasle
> 
>

Re: [ACS431]CLOUDSTACK-6360: Usage server failed to start with 4.4 build

[sebgoa]

On Jul 3, 2014, at 11:10 AM, Rajani Karuturi  wrote:

> Hi Sebastien,
> 
> while rebasing the fix for CLOUDSTACK-6926, I observed that mysql connector 
> related changes aren’t done in the debian cloud-usage script. 
> I reopened the related issue 
> https://issues.apache.org/jira/browse/CLOUDSTACK-6360?focusedCommentId=14051219
>  
> 
> I think it would be good to have the fix for CLOUDSTACK-6360 in 4.3.1
> 

Happy to apply the patch if you give me one.

> ~Rajani
> 
> 
> 
> On 02-Jul-2014, at 7:33 pm, Sebastien Goasguen  wrote:
> 
>> This is an automatically generated e-mail. To reply, visit: 
>> https://reviews.apache.org/r/22721/
>> Hi, no it does not apply cleanly to current 4.3 branch. Can you rebase.
>> 
>> thanks
>> 
>> 
>> - Sebastien Goasguen
>> 
>> 
>> On June 18th, 2014, 10:15 a.m. UTC, Rajani Karuturi wrote:
>> 
>> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
>> By Rajani Karuturi.
>> Updated June 18, 2014, 10:15 a.m.
>> 
>> Bugs: CLOUDSTACK-6926
>> Repository: cloudstack-git
>> Description
>> 
>> used to readlink -e and dirname to get the JAVA_HOME
>> if JAVA_HOME is not already defined, sets it to jdk home if javac is present 
>> else jre home if java is present.
>> if nothing is present, it exits with error
>> 
>> Testing
>> 
>> tested it when java is not installed, jre is installed, jdk installed or 
>> when a older version is installed on centos 6.4 and ubuntu 14.04 
>> Diffs
>> 
>>  • packaging/centos63/cloud-usage.rc (6170379)
>>  • packaging/debian/init/cloud-usage (1cc75cc)
>> View Diff
>> 
> 

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/
---

(Updated July 3, 2014, 7:02 p.m.)


Review request for cloudstack, Koushik Das and Santhosh Edukulla.


Changes
---

Adding patch for master


Bugs: CLOUDSTACK-6873
https://issues.apache.org/jira/browse/CLOUDSTACK-6873


Repository: cloudstack-git


Description
---

Moving tests using SimulatorMock into maint folder. Also removed duplicate test 
cases from test_deploy_vm.py. These tests are already covered in 
test_vm_life_cycle.py


Diffs
-

  test/integration/smoke/misc/__init__.py PRE-CREATION 
  test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
  test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
  test/integration/smoke/test_deploy_vm.py ed5dfaf 
  test/integration/smoke/test_vm_ha.py 1d9021c 
  test/integration/smoke/test_vm_life_cycle.py 240ab68 

Diff: https://reviews.apache.org/r/23195/diff/


Testing
---


File Attachments (updated)


Patch for master
  
https://reviews.apache.org/media/uploaded/files/2014/07/03/1fba76b3-3eab-4281-afa9-7a3f38dc2c0d__0001-CLOUDSTACK-6873-Moving-the-tests-using-SimulatorMock.patch


Thanks,

Gaurav Aradhye

Re: Review Request 23195: CLOUDSTACK-6873: Moving the tests using SimulatorMock to different folder so that they can be run separately and serially

[Gaurav Aradhye]

> On July 3, 2014, 3:32 p.m., Santhosh Edukulla wrote:
> > Ship It!
> 
> Santhosh Edukulla wrote:
> Patch didnt apply cleanly. Please check. As well, do we need two folders 
> now one maint and one misc? Is both the purpose same beneath to run them 
> separately and sequentially. If yes, we can have one folder for now. What say?
>
> 
> Gaurav Aradhye wrote:
> maint folder is currently under component (regression tests) and misc is 
> under smoke. I did not put the test cases in maint because not mixing BVT and 
> regression test suites.
> 
> Santhosh Edukulla wrote:
> ok, some how we need to find a cleaner representation i believe, instead 
> of multiple folders with different names, now can we check whether patch is 
> applying cleanly or not?
> 
> Gaurav Aradhye wrote:
> Yes will add new clean patch.

Added separate patch for master.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23195/#review47284
---


On July 3, 2014, 7:02 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23195/
> ---
> 
> (Updated July 3, 2014, 7:02 p.m.)
> 
> 
> Review request for cloudstack, Koushik Das and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6873
> https://issues.apache.org/jira/browse/CLOUDSTACK-6873
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Moving tests using SimulatorMock into maint folder. Also removed duplicate 
> test cases from test_deploy_vm.py. These tests are already covered in 
> test_vm_life_cycle.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/misc/__init__.py PRE-CREATION 
>   test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION 
>   test/integration/smoke/misc/test_vm_ha.py PRE-CREATION 
>   test/integration/smoke/test_deploy_vm.py ed5dfaf 
>   test/integration/smoke/test_vm_ha.py 1d9021c 
>   test/integration/smoke/test_vm_life_cycle.py 240ab68 
> 
> Diff: https://reviews.apache.org/r/23195/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Patch for master
>   
> https://reviews.apache.org/media/uploaded/files/2014/07/03/1fba76b3-3eab-4281-afa9-7a3f38dc2c0d__0001-CLOUDSTACK-6873-Moving-the-tests-using-SimulatorMock.patch
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47300
---

Ship it!


master -> ce5061e107f743e52b23445fd97fcf60d8160ec6

- Koushik Das


On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 11:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
> Trippaers.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Koushik Das]

I was about to give the "ship it" and then saw your comment. Anyways have done 
it now.

On 03-Jul-2014, at 6:03 PM, Hugo Trippaers  wrote:

> Hey Koushik,
> 
> No problem, will do if required.
> 
> The review doesn’t have a “ship it” state, so thats why i assumed it was not 
> committed. Also a lot of folks adopted the common practice to put the commit 
> id in a comment after committing a review. That makes it easier to trace.
> 
> Cheers,
> 
> Hugo
> 
> 
> On 3 jul. 2014, at 14:29, Koushik Das  wrote:
> 
>> 
>> 
>>> On July 3, 2014, 11:58 a.m., Hugo Trippaers wrote:
 I'm not sure we can actually have a dependency on the mysql connector like 
 this because of it's GPL license. I'll check this and get back on this 
 before we can accept this patch.
>> 
>> Hugo, I committed this patch (on master 
>> ce5061e107f743e52b23445fd97fcf60d8160ec6) a while back and then saw this 
>> comment from you. If there is going to be a license issue then please feel 
>> free to revert.
>> 
>> 
>> - Koushik
>> 
>> 
>> ---
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/23192/#review47289
>> ---
>> 
>> 
>> On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
>>> 
>>> ---
>>> This is an automatically generated e-mail. To reply, visit:
>>> https://reviews.apache.org/r/23192/
>>> ---
>>> 
>>> (Updated July 3, 2014, 11:58 a.m.)
>>> 
>>> 
>>> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
>>> Trippaers.
>>> 
>>> 
>>> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>>   
>>> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
>>> 
>>> 
>>> Repository: cloudstack-git
>>> 
>>> 
>>> Description
>>> ---
>>> 
>>> Incorporated some Changes to include things like runservice readme 
>>> checkbox, changing the default installation location etc..
>>> 
>>> 
>>> Diffs
>>> -
>>> 
>>> client/pom.xml 29fef4f 
>>> pom.xml 0b3b56e 
>>> scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>>> scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>>> scripts/installer/windows/acs.wxs bf09afc 
>>> scripts/installer/windows/dependencies.wxs 987c561 
>>> scripts/installer/windows/en-us.wxl 2f34575 
>>> scripts/installer/windows/optionstheme_en-us.wxl c822929 
>>> scripts/installer/windows/readme.txt PRE-CREATION 
>>> 
>>> Diff: https://reviews.apache.org/r/23192/diff/
>>> 
>>> 
>>> Testing
>>> ---
>>> 
>>> Tested on Windows 2012 Server
>>> 
>>> 
>>> Thanks,
>>> 
>>> Damodar Reddy Talakanti
>>> 
>>> 
>> 
> 

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Chip Childers]

On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
> 
> On to the actual point behind my comment, ASF policy is not very clear
> about when we can or can’t put anything in our code that points to
> something with a (L)GPL license. I would like some feedback from
> people with a finer grasp of the policy to see if we can actually
> include this dependency on mysql and the mysql connection in our wix
> script.
> 
> Cheers,
> 
> Hugo

This is a bit tricky (and splitting hairs)... Obviously all of this is
based on my understanding of past discussions and the relevant policies
/ licenses...  but INAL and certainly not an expert here.  Comments /
disagreements welcome.


In a non-platform specific sense, we have said that the MySQL
connector jar file is a *system dependency*.  Meaning...  for our
software to work, it needs to be installed by the user on the system
before-hand.

We have allowed it to be downloaded in certain maven profiles
(specifically, IIRC, developer-centric profiles), as a convenience only
(since those profiles aren't required for normal users).

For the non-developer profiles, it is expected that mysql connector is
already on your system prior to using the software.

Above is all about users building from source, based on what we
officially release

Now, we DO provide scripts to help downstream projects and users build 
packages:

Our DEB/RPM packaging scripts *do* reference this dependency.  Since the
project itself does *not* distribute packages, and since packages are
designed to specify *system dependencies*, we believe this satisfies the
ASF policies. OpenJDK is also a *system dependency* that we specify in
our packages, and nobody would be confused about us expecting java to
exist on the target environment for our software to work. (This was
discussed with mentors back during incubation, but I can't seem to find
the relevant links at the moment.)

We do *NOT* include MySQL itself in our package scripts, only the
connector.

Now, dealing with the whole MSI thing (including the specific review in
question, but also looking in other places related to the MSI), we have
a different situation.

*MySQL Itself*
First, we are specifically taking action to download and install MySQL.
This has to be taken out IMO, since it's quite a bit different from
saying "here's a system package we expect to be there, like java
itself".  Since Windows doesn't have "package management" that pulls
from a central repo, I understand why the download is there...  but I'm
-1 on it being in a release.

*MySQL Connector*
I see that we are doing the same thing with the connector in the pom
files and the MSI - explicitly pulling it into the system.

I'll defer to someone else about the specifics of that in the pom files,
because I'm not a maven guy that knows what exactly is ocurring there.
Can someone review and talk about how that directive behaves (and
compare / contrast with the developer profiles)?

In the packaging, same problem as MySQL...  we are explicitly
downloading GPL code.  That also needs to be removed IMO.  I'm -1 on
that being in the codebase.

Unfortunately, I *think* that we need to document MySQL and MySQL
Connector.jar installations are being pre-requisites to installing ACS
from an MSI.  If a *downstream* project / product wants to include them
in an installer, fine... but the Apache CloudStack project needs to
remove them and add them as documented pre-requisites.

-chip

Re: [ACS 4.4] cherry-pick CLOUDSTACK-7047

[Daan Hoogland]

On Thu, Jul 3, 2014 at 3:27 AM, Prachi Damle  wrote:
...
> Commit# 40e28de7275804f4483868ba8a737878ff54fba8
You are intrroducing windows line endings! picking anyway.

> Commit# f37b1524892ab805615dbff2c59e5a1d10c116d3

regards,
-- 
Daan

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Chip Childers]

On Thu, Jul 03, 2014 at 01:37:27PM +, Koushik Das wrote:
> I was about to give the "ship it" and then saw your comment. Anyways have 
> done it now.

We are likely to need to revert (or at least change through a new
commit) a bunch of things introduced within the pom and msi files.  See
my last email on the topic.

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Chip Childers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47301
---


-1 to this commit until legal policy issues are resolved

- Chip Childers


On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 11:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
> Trippaers.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: [VOTE] Apache Cloudstack 4.4.0

[Daan Hoogland]

Ove, you are talking of the xapi version(?), strange I didn't catch
that one. I did a test compile and then redid my dist creation. I'll
look into this.

If it didn't compile it is not nitpicking!
Daan

On Thu, Jul 3, 2014 at 6:06 AM, Ove Ewerlid  wrote:
> -1
>
> The top level pom.xml still contains a -SNAPSHOT suffix.
>
>  https://github.com/apache/cloudstack/blob/4.4-RC20140702T2107/pom.xml
>
> line 63.
>
> Removing the -SNAPSHOT suffix allows compilation.
>
> /Ove (Nitpicking)
>
>
>
>
> On 07/02/2014 10:18 PM, Daan Hoogland wrote:
>>
>> Hi All,
>>
>> I've created a 4.4.0 release, with the following artifacts up for a vote:
>>
>> Git Branch and Commit SH:
>>
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
>> Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
>>
>> List of changes:
>>
>> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
>>
>> Source release (checksums and signatures are available at the same
>> location):
>> https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
>>
>> PGP release keys (signed using 4096R/AA4736F3):
>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>> Vote will be open for 72 hours.
>>
>> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
>>
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>>
>>
>> I will ad my key to the mentioned KEYS file as soon as possible,
>>
>
>
> --
> Ove Everlid
> System Administrator / Architect / SDN- & Automation- & Linux-hacker
> Mobile: +46706668199 (dedicated work mobile)
> Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)



-- 
Daan

Re: [VOTE] Apache Cloudstack 4.4.0

[Mike Tutkowski]

Thanks for clarifying, Hugo!

On Thursday, July 3, 2014, Hugo Trippaers  wrote:

> Hey Mike,
>
> That is technically not the way this vote works. Release votes a a “Lazy
> Majority” vote. This means that the vote requires at least 3 binding +1
> votes and more +1 votes than -1 votes.  For the exact working see
> paragraphs 3.4.4 and 3.2.2 of the Apache CloudStack bylaws.
>
>
>
> Cheers,
>
> Hugo
>
>
> On 3 jul. 2014, at 02:13, Mike Tutkowski  > wrote:
>
> > We have at least one binding -1, so this VOTE won't pass.
> >
> > We should continue to test on this RC, though, as Marcus mentioned, in an
> > effort to reduce RC spin.
> >
> > We also shouldn't spin up a new RC until next week as many in the U.S.
> are
> > on a long weekend starting tomorrow.
> >
> > On Wednesday, July 2, 2014, Marcus >
> wrote:
> >
> >> -1
> >>
> >> I'm unable to add a KVM host. It seems to be related to changes in the
> >> SshCmdHelper. The mgmt server issues an ssh check to see of the host has
> >> kvm modules installed, which it shows it does, but there is a null
> pointer
> >> in the SshCmdHelper and it doesn't interpret the result correctly.  I
> saw
> >> this once, over a month ago, and commented on CLOUDSTACK-6804. They say
> the
> >> null pointer is fixed in CLOUDSTACK-6844, but it looks like it was
> >> committed in 4.4-forward and never pulled in to the release branch.
> >>
> >> I tested this release with
> >> cherry-picking 2ec7359b4eb501b0d9e80ed87af7a54938e9d505 from
> 4.4-forward.
> >> It seems to work, though the fix seems a bit hacky (sleep loop for up to
> >> 1s, waiting for null pointer to not be null), but perhaps I just don't
> >> understand the problem well enough. In the interest of reducing RC
> >> iterations, I went ahead and continued to test per the devcloud-kvm
> docs.
> >> So far everything looks good as far as basic deployment and built-in
> >> storage types.
> >>
> >> * Launched VPC with a default-allow network and a default-deny network
> >> * launched an nfs-based vm in default-deny and clvm based in
> default-allow
> >> with qcow2 template
> >> * registered vmdk template for KVM, launched a vm based on it, for both
> nfs
> >> and lvm
> >> * registered raw image template, launched one for nfs and lvm
> >> * set up port forward for 22 on half of vms, static nat on the other
> half,
> >> verified default-allow/deny worked as needed
> >> * updated acls to allow 22 into everything, logged in to all servers to
> >> verify they deployed correctly
> >>
> >> I don't believe CLOUDSTACK-6036 should block this release, FWIW. First,
> >> there's no indication from the bug that it still affects 4.4.0, second,
> >> it's not a regression, third, it didn't block the 4.3 release either,
> >> fourth, from the sound of it, the worst of the issue is that a vm is
> >> inadvertently stopped if it previously had an issue stopping and upgrade
> >> timing happens to be just right, with a fix of simply restarting the vm.
> >>
> >>
> >> On Wed, Jul 2, 2014 at 3:51 PM, Tomasz Zięba  
> >> > wrote:
> >>
> >>> -1 because CLOUDSTACK-6036
> >>>
> >>>
> >>> 2014-07-02 22:18 GMT+02:00 Daan Hoogland  
> >> >:
> >>>
>  Hi All,
> 
>  I've created a 4.4.0 release, with the following artifacts up for a
> >> vote:
> 
>  Git Branch and Commit SH:
> 
> 
> >>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
>  Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
> 
>  List of changes:
> 
> 
> >>>
> >>
> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
> 
>  Source release (checksums and signatures are available at the same
>  location):
>  https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
> 
>  PGP release keys (signed using 4096R/AA4736F3):
>  https://dist.apache.org/repos/dist/release/cloudstack/KEYS
> 
>  Vote will be open for 72 hours.
> 
>  For sanity in tallying the vote, can PMC members please be sure to
>  indicate "(binding)" with their vote?
> 
>  [ ] +1  approve
>  [ ] +0  no opinion
>  [ ] -1  disapprove (and reason why)
> 
> 
>  I will ad my key to the mentioned KEYS file as soon as possible,
>  --
>  Daan
> 
> >>>
> >>>
> >>>
> >>> --
> >>> Regards,
> >>> Tomasz Zięba
> >>> Twitter: @TZieba
> >>> LinkedIn: pl.linkedin.com/pub/tomasz-zięba-ph-d/3b/7a8/ab6/
> 
> >> 
> >>> 
> >>> 
> >>>
> >>
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com 
> > o: 303.746.7302
> > Advancing the way the world uses the cloud
> > *™*
>
>

-- 
*Mike Tutkowski*

Re: Doc on Network Throttling

[David Nalley]

Rajani:

No reason you can't do that. Submit a pull request:
https://github.com/apache/cloudstack-docs-admin

--David

On Thu, Jul 3, 2014 at 4:52 AM, Rajani Karuturi
 wrote:
> Thanks for the wiki alena and rajesh.
> Can this be moved to docs? 
> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling
>
>
> ~Rajani
>
>
>
> On 03-Jul-2014, at 1:27 pm, Rajesh Battala 
> mailto:rajesh.batt...@citrix.com>> wrote:
>
> Hi Alena,
> I have updated wiki for Hyper-V
>
> Thanks
> Rajesh Battala
>
> From: Alena Prokharchyk
> Sent: Wednesday, July 2, 2014 3:43 AM
> To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
> dev@cloudstack.apache.org
> Subject: Doc on Network Throttling
>
> As I remember seeing the question on how Network throttling works in CS, so 
> I've created a wiki page explaining the CS implementation. Feel free to 
> review/update/fix:
>
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack
>
> Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is 
> set on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors 
> accordingly? As I don't have enough expertise on this part.
>
> -Alena.
>

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Leo Simons]

Heya,

On 7/3/14, 4:11 PM, "Chip Childers"  wrote:
>On Thu, Jul 03, 2014 at 02:59:55PM +0200, Hugo Trippaers wrote:
>> 
>> On to the actual point behind my comment, ASF policy is not very clear
>> about when we can or can¹t put anything in our code that points to
>> something with a (L)GPL license. I would like some feedback from
>> people with a finer grasp of the policy to see if we can actually
>> include this dependency on mysql and the mysql connection in our wix
>> script.
>> 
>> Cheers,
>> 
>> Hugo
>
>This is a bit tricky (and splitting hairs)... Obviously all of this is
>based on my understanding of past discussions and the relevant policies
>/ licenses...  but INAL and certainly not an expert here.  Comments /
>disagreements welcome.
>
>
>In a non-platform specific sense, we have said that the MySQL
>connector jar file is a *system dependency*.
>...
>For the non-developer profiles, it is expected that mysql connector is
>already on your system prior to using the software.
>...
>Now, we DO provide scripts to help downstream projects and users build
>packages:
>..
>Now, dealing with the whole MSI thing (including the specific review in
>question, but also looking in other places related to the MSI), we have
>a different situation.
>
>*MySQL Itself*
>First, we are specifically taking action to download and install MySQL.
>This has to be taken out IMO, since it's quite a bit different from
>saying "here's a system package we expect to be there, like java
>itself".  Since Windows doesn't have "package management" that pulls
>from a central repo, I understand why the download is there...  but I'm
>-1 on it being in a release.
>
>*MySQL Connector*
>I see that we are doing the same thing with the connector in the pom
>files and the MSI - explicitly pulling it into the system.

Yup, this is all spot on. For reference, mysql has been discussed _a lot_
in the past

  
http://apache.markmail.org/search/?q=mysql+list%3Aorg.apache.legal-discuss

>I'll defer to someone else about the specifics of that in the pom files,
>because I'm not a maven guy that knows what exactly is ocurring there.
>Can someone review and talk about how that directive behaves (and
>compare / contrast with the developer profiles)?

It looks like that maven pom on windows _by default_ downloads and
installs a variety of non-apache-license (and/or non-mit/bsd/variant
license) software. That shouldn¹t really happen. The principle is one of
³least surprise²: As a user or developer who does not RTFM, following the
default commands/tools/etc, you should end up with a more-or-less
apache-licensed build result (*) that you can redistribute the result
under.

But apache policy is that it is acceptable to provide scripts/build
tools/assistance to help those same users/developers do things that they
want to do. As long as they understand the legal situation they end up in.

I would recommend adding a "nonoss" maven profile that the developer/user
has to explicitly select in order to do those downloads. As long as that
option is described clearly, that¹s then ok. See

  http://svn.apache.org/repos/asf/apr/apr/trunk/README

for an example of how to point out the license situation.

Something similar is true by the way (IMHO, but as a project cloudstack
can definitely decide differently), for a possible MSI script. Making an
MSI script that prompts the user whether to download mysql at the point of
install, **clearly pointing out the license situation** if they choose to
do so, seems reasonable, and I personally would not object to shipping
_that_ kind of script as part of an apache source release.

Finally, the _spirit_ behind the apache policies is that there should be
an option to use cloudstack with a license-compatible database (say,
postgres), even if most users will use mysql (just like most people that
use dbm with httpd will use berkely dbm, but you _can_ use something
else). It¹s perhaps unfortunate that this isn¹t supported, but that¹s not
apache policy, and given the license situation of other system
dependencies, I can imagine no-one here wants to make it a priority.


cheers,


Leo

PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
about choice/policy, and the policy is supposed to be based on common
sense much more than license stuff tends to be :)

(*) technically, LICENSE-file-licensed result, which could include BSD,
MIT, and a bunch of other such compatible license terms

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Chip Childers]

On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
> It looks like that maven pom on windows _by default_ downloads and
> installs a variety of non-apache-license (and/or non-mit/bsd/variant
> license) software. That shouldn¹t really happen. The principle is one of
> ³least surprise²: As a user or developer who does not RTFM, following the
> default commands/tools/etc, you should end up with a more-or-less
> apache-licensed build result (*) that you can redistribute the result
> under.

+1

> 
> But apache policy is that it is acceptable to provide scripts/build
> tools/assistance to help those same users/developers do things that they
> want to do. As long as they understand the legal situation they end up in.
> 
> I would recommend adding a "nonoss" maven profile that the developer/user
> has to explicitly select in order to do those downloads. As long as that
> option is described clearly, that¹s then ok. See
> 
>   http://svn.apache.org/repos/asf/apr/apr/trunk/README
> 
> for an example of how to point out the license situation.

We already have the nonoss profile, so this is a pretty good fix for the
windows build issues noted above IMO.

Damoder/Koushik - please make this change.

> 
> Something similar is true by the way (IMHO, but as a project cloudstack
> can definitely decide differently), for a possible MSI script. Making an
> MSI script that prompts the user whether to download mysql at the point of
> install, **clearly pointing out the license situation** if they choose to
> do so, seems reasonable, and I personally would not object to shipping
> _that_ kind of script as part of an apache source release.
> 

+1 - that's a reasonable approach as well.  Damoder / Koushik - what do
you think about this approach?

> Finally, the _spirit_ behind the apache policies is that there should be
> an option to use cloudstack with a license-compatible database (say,
> postgres), even if most users will use mysql (just like most people that
> use dbm with httpd will use berkely dbm, but you _can_ use something
> else). It¹s perhaps unfortunate that this isn¹t supported, but that¹s not
> apache policy, and given the license situation of other system
> dependencies, I can imagine no-one here wants to make it a priority.

Yeah, that would be nice...  but somebody would have to decide that they
want to do that.

> 
> 
> cheers,
> 
> 
> Leo
> 
> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
> about choice/policy, and the policy is supposed to be based on common
> sense much more than license stuff tends to be :)

Agreed - this is about policy not legality.

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[David Nalley]

On Thu, Jul 3, 2014 at 12:08 PM, Chip Childers  wrote:
> On Thu, Jul 03, 2014 at 03:14:30PM +, Leo Simons wrote:
>> It looks like that maven pom on windows _by default_ downloads and
>> installs a variety of non-apache-license (and/or non-mit/bsd/variant
>> license) software. That shouldnąt really happen. The principle is one of
>> łleast surprise˛: As a user or developer who does not RTFM, following the
>> default commands/tools/etc, you should end up with a more-or-less
>> apache-licensed build result (*) that you can redistribute the result
>> under.
>
> +1
>
>>
>> But apache policy is that it is acceptable to provide scripts/build
>> tools/assistance to help those same users/developers do things that they
>> want to do. As long as they understand the legal situation they end up in.
>>
>> I would recommend adding a "nonoss" maven profile that the developer/user
>> has to explicitly select in order to do those downloads. As long as that
>> option is described clearly, thatąs then ok. See
>>
>>   http://svn.apache.org/repos/asf/apr/apr/trunk/README
>>
>> for an example of how to point out the license situation.
>
> We already have the nonoss profile, so this is a pretty good fix for the
> windows build issues noted above IMO.
>
> Damoder/Koushik - please make this change.
>
>>
>> Something similar is true by the way (IMHO, but as a project cloudstack
>> can definitely decide differently), for a possible MSI script. Making an
>> MSI script that prompts the user whether to download mysql at the point of
>> install, **clearly pointing out the license situation** if they choose to
>> do so, seems reasonable, and I personally would not object to shipping
>> _that_ kind of script as part of an apache source release.
>>
>
> +1 - that's a reasonable approach as well.  Damoder / Koushik - what do
> you think about this approach?
>

I like this approach. We have a number of things that aren't in the
'default' build because of policy reasons. This is just another of
them.



>> Finally, the _spirit_ behind the apache policies is that there should be
>> an option to use cloudstack with a license-compatible database (say,
>> postgres), even if most users will use mysql (just like most people that
>> use dbm with httpd will use berkely dbm, but you _can_ use something
>> else). Itąs perhaps unfortunate that this isnąt supported, but thatąs not
>> apache policy, and given the license situation of other system
>> dependencies, I can imagine no-one here wants to make it a priority.
>
> Yeah, that would be nice...  but somebody would have to decide that they
> want to do that.
>
>>
>>
>> cheers,
>>
>>
>> Leo
>>
>> PS: IANAL, but, a lot of this discussion is a bit beyond legal, and is
>> about choice/policy, and the policy is supposed to be based on common
>> sense much more than license stuff tends to be :)
>
> Agreed - this is about policy not legality.
>

[ANNOUNCE] New PMC Member: Mark Hinkle

[John Burwell]

The Project Management Committee (PMC) for Apache CloudStack has asked Mark 
Hinkle to join the PMC and we are pleased to announce that he has accepted. 

Join me in congratulating Mark! 


-The CloudStack PMC

Re: Regarding UI for SSL termination/offloading feature

[Syed Ahmed]

Hey Rajesh,

I had the UI in my dev branch but could not send that for review as I 
got busy with other work. I will dig that code up and send the request 
sometime next week.


Thanks,
-Syed

On Wed 02 Jul 2014 03:23:20 AM EDT, Rajesh Battala wrote:

Hi Syed,

In FS, there are screenshots regarding the UI support for certificates
management for accounts.

But in deployment(master) am not able to see any such UI.

Is this a model or you have missed committing the changes.

Thanks

Rajesh Battala

Re: createTemplate API lacks sshkeyenabled?

[Harikrishna Patnala]

Yes Demetrius, please raise a bug at https://issues.apache.org/jira

-Harikrishna

On 03-Jul-2014, at 12:52 am, Demetrius Tsitrelis 
 wrote:

> OK, should I raise a bug to remove the parameter (at least from the 
> documentation)?
> 
> -Original Message-
> From: Harikrishna Patnala [mailto:harikrishna.patn...@citrix.com] 
> Sent: Tuesday, July 01, 2014 11:14 PM
> To: 
> Subject: Re: createTemplate API lacks sshkeyenabled?
> 
> sshkeyenabled flag is no where used in the code.
> So even if sshkeyenabled flag is set false we send the SSH public key to VR. 
> 
> IMHO there is no need of this flag, if a user wants to set SSH key to VM, ssh 
> key ( "keypair" param ) is passed while deploying the VM and CS sends the 
> same to VR. 
> 
> -Harikrishna
> 
> 
> On 02-Jul-2014,at 4:45 am, Demetrius Tsitrelis 
>  wrote:
> 
>> I see - thanks.  But what if I created a VM from an .ISO?  It still seems 
>> that I have to use createTemplate to make a template which CloudStack could 
>> use, but that API will not let me tell CloudStack that my new VM is running 
>> the SSH key reset script!  Or is there some other API which I could use to 
>> modify CloudStack's details about the new template?
>> 
>> -Original Message-
>> From: Nux! [mailto:n...@li.nux.ro]
>> Sent: Tuesday, July 01, 2014 2:57 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: createTemplate API lacks sshkeyenabled?
>> 
>> There are no stupid questions. :)
>> 
>> Inheritable from the source template of the VM.
>> 
>> 
>> --
>> Sent from the Delta quadrant using Borg technology!
>> 
>> Nux!
>> www.nux.ro
>> 
>> 
>> - Original Message -
>>> From: "Demetrius Tsitrelis" 
>>> To: dev@cloudstack.apache.org
>>> Sent: Tuesday, 1 July, 2014 10:48:11 PM
>>> Subject: RE: createTemplate API lacks sshkeyenabled?
>>> 
>>> Is it OK if I ask a stupid question?  Inheritable from what?
>>> 
>>> -Original Message-
>>> From: Nux! [mailto:n...@li.nux.ro]
>>> Sent: Tuesday, July 01, 2014 1:35 PM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: createTemplate API lacks sshkeyenabled?
>>> 
>>> Isn't this feature inheritable?
>>> 
>>> Lucian
>>> 
>>> --
>>> Sent from the Delta quadrant using Borg technology!
>>> 
>>> Nux!
>>> www.nux.ro
>>> 
>>> 
>>> - Original Message -
 From: "Demetrius Tsitrelis" 
 To: dev@cloudstack.apache.org
 Sent: Tuesday, 1 July, 2014 9:24:55 PM
 Subject: RE: createTemplate API lacks sshkeyenabled?
 
 Thanks, but I am not talking about the UI but the API.
 
 -Original Message-
 From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
 Sent: Tuesday, July 01, 2014 1:18 PM
 To: dev@cloudstack.apache.org
 Subject: Re: createTemplate API lacks sshkeyenabled?
 
 ssh key is not fully implemented on UI.
 for example, on instance Wizard, create/register/delete ssh key, 
 resetsshkey for vm, register template, etc.
 I have implemented some of them on 4.2 , it need to be changed for 
 4.3/4.4/master
 
 -Wei
 
 
 2014-07-01 22:06 GMT+02:00 Demetrius Tsitrelis <
 demetrius.tsitre...@citrix.com>:
 
> registerTemplate has both the passwordenabled and sshkeyenabled 
> parameters.
> So why doesn't createTemplate have both?  Reference:
> http://cloudstack.apache.org/docs/api/apidocs-4.3/root_admin/creat
> eT
> em
> plate.html
> 
> 
 
>>> 
> 

Re: Review Request 20099: Domain-Account-User Sync Up Among Multiple Regions (Core Changes)

[John Burwell]

Alex,

You still have not answered my most important question — why is this 
replication being performed by the management server and not through the 
underlying datastore?  There are mature, battle tested master-master 
replication facilities available for MySQL.  CloudStack is an infrastructure 
orchestration system not a database.  I am struggling to understand why we 
would take on this complexity when we have a database that is already capable 
of performing this function.

As for the remainder of my responses, please see my responses in-line below.

Thanks,
-John

On June 27, 2014 at 4:30:54 PM, Alex Ough (alex.o...@sungardas.com) wrote:

John,

I don't think you understand my frustration and I'm really sorry that you think 
those are issues enough to make this development unable to be wrapped up.


#1-3 : Don't you think it is not appropriate to talk about the spec after 
almost 8 months have passed?
Specs should always be under review until a feature is accepted because our 
knowledge of problem is always improving.  I am seeking the correct solution to 
a problem.  I am certainly not accepting the waterfall philosophy of “Well, as 
we developed the feature, we determined the spec was incomplete/wrong.  
However, it was closed/accept so we just kept following it."

To my reading, the spec seems functionally incomplete.  I am simply asking for 
the history as to why events and projects were not included in this 
enhancement.  


#4,5,7 : The changes in domain/account/user objects do not happen everyday and 
the chances you're worried is very minimum.
Change frequency is orthogonal to data corruption.  A conflict resolution 
strategy either correct and robust or it is not.  I am very concerned the 
critical data changes will be reverted or otherwise corrupted by the mechanism 
as designed and implemented.  For example, locking an account due to compromise 
by a third party (i.e. the CodeSpaces[1] debacle) where by the account is 
locked in Region A, a partition occurs between the regions, and due to clock 
skew, the replication mechanism believes Region B representation to be 
authoritative — unlocking the account.  The same scenarios could also hit 
password reset/change.  These are critical operations that must be 100% 
reliable.

[1]: http://www.codespaces.com/

#6 : Isn't this the matter of overall RabbitMQ in cloudstack not just for this 
feature?


This enhancement is the first to use RabbitMQ to address partition tolerance.  
Previously, it has been used within a partition to provide background 
process/event notification.

Thanks
Alex Ough


On Fri, Jun 27, 2014 at 2:21 PM, John Burwell  wrote:
Alex,

Regardless of the implementation being a plugin or part of the core management 
server codebase, acceptance of this patch into master shifts responsibility for 
its on-going support and maintenance to the community.  Until the issues 
outlined in my previous email are adequately explained/understood, it will not 
be accepted into the CloudStack codebase because the design may have 
fundamental flaws that corrupt user data.  

Our community develops CloudStack by collaborating to find the best solutions 
to our user’s problems.  Development is not “wrapped” until we arrive at a 
consensus (i.e. no open design questions/review issues) that a proposed patch 
is acceptable.  Attempting to push aside valid functional and technical 
questions about a proposed feature or patch is not an acceptable response.  It 
is understandable that you want to complete this effort as it has been under 
review for quite sometime.  Personally, I apologize for my lack of promptness 
in providing feedback.  However, these circumstances do not absolve anyone from 
collaborating with the community.  We want to accept your work, and appreciate 
your effort, but we have to understand it, verify that the functionality meets 
the needs of our user community, and ensure its quality.

Thanks,
-John

On June 27, 2014 at 12:08:20 PM, Alex Ough (alex.o...@sungardas.com) wrote:

Hi John,

Thanks a lot for your detailed feedback, but I strongly suggest to continue to 
discuss about them after this development is wrapped up
because this feature is provided as a plugin and and will not work unless you 
turn it on in case you don't want to use.

Thanks
Alex Ough


On Fri, Jun 27, 2014 at 11:49 AM, John Burwell  wrote:
Alex,

I appreciate you taking the time to answer my questions since I am late joining 
this conversation.  I wanted to make sure I understand the underlying design 
and its assumptions before commenting in depth. My detailed followups are 
in-line below.  TL;DR I am concerned that the design does not properly address 
the myriad of network partition or conflict resolution scenarios that will 
inevitably arise in real world operation.  Furthermore, you did not answer my 
biggest question — why isn’t something like Percona master-master replication 
[1] not sufficient for this capability?  

I apologize again for missing t

Re: Build error

[Erik Weber]

Old Python installed?

Not sure what the required version is, what version do you have installed?

Erik
3. juli 2014 14:52 skrev "Mohamed Ali Saidi" 
følgende:

>  Hi,
>
> I'm trying to build Coudstack and i got this error:
>
>   File "/home/cloudstack/tools/apidoc/gen_toc.py", line 223
> with file(out, 'w') as f:
> ^
> SyntaxError: invalid syntax
>
> any idea?
>
> regards,
>

Re: [ANNOUNCE] New PMC Member: Mark Hinkle

[Mike Tutkowski]

Congratulations, Mark!

On Thursday, July 3, 2014, John Burwell  wrote:

> The Project Management Committee (PMC) for Apache CloudStack has asked
> Mark Hinkle to join the PMC and we are pleased to announce that he has
> accepted.
>
> Join me in congratulating Mark!
>
>
> -The CloudStack PMC



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

[Silvano Nogueira Buback]

Hi guys,

I think you are busy because 4.4 release tasks, but I'm worried about
the time to 4.5 feature freeze. I put the documentation of feature in wiki
as requested and I hoped people read there and make some comments here.

To help, I will put design issues that are in document, one by one, and we
can discuss in this thread. After each discussion I will change the
document.

   I have one question about removing DNS domain when network has been
deleted. In my current implementation I remove DNS domain when network is
removed. But if the DNS domain is shared with another network or maybe is a
dns domain used outside ACS this can be a problem. What I can do with DNS
domain when network is removed:

   1. Keep the current implementation. Always deleted DNS domain when
   network is removed (works well if the ACS is the only manager for the DNS
   (one network domain per network).
   2. Remove DNS domain only if the domain was created by ACS. This can be
   a problem if someone put records after ACS creation.
   3. Remove DNS domain only if there is no more records there. Maybe DNS
   domain can stay forever there because an inconsistency that keep only one
   record.


Which one is the best?

[]'s,

Silvano Buback



On Thu, Jun 26, 2014 at 11:34 AM, Silvano Nogueira Buback <
silv...@corp.globo.com> wrote:

> Thank you David.
>
> I put design documents on wiki:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI.
> I create an issue https://issues.apache.org/jira/browse/CLOUDSTACK-6998
> too.
>
> I look forward to hearing your feedbacks.
>
> []'s,
>
> Silvano Buback
>
>
> On Wed, Jun 25, 2014 at 5:50 PM, David Nalley  wrote:
>
>> On Wed, Jun 25, 2014 at 4:38 PM, Silvano Nogueira Buback
>>  wrote:
>> > Hi guys,
>> >
>> >I finish the first version of design document:
>> >
>> https://docs.google.com/document/d/1kbPQJrBC87ZtR-t7LwHFDzAmT436ShtjwKE84FVfByM/pub
>> > .
>> >
>> >Someone could give me access to put design documents in wiki? Bellow
>> the
>> > username of people work with Cloudstack in Globo.com and need access.
>> >
>> > snbuback silv...@corp.globo.com
>> > daniel.simoes daniel.sim...@corp.globo.com
>> > lokama - lok...@gmail.com
>> >
>> > Regards,
>> >
>> > Silvano Buback
>> >
>> >
>> >
>> > On Thu, Jun 19, 2014 at 11:29 AM, Silvano Buback 
>> wrote:
>> >
>> >> Of course, I forgotten my account info:
>> >> snbuback / silv...@corp.globo.com
>> >>
>>
>>
>> Done.
>>
>> --David
>>
>
>

Re: [DISCUSS] [PROPOSAL] Implementation of DNS Provider for Bind (for 4.5)

[Erik Weber]

To push that choice over to the operator you could add it as a
global/zone/network option.

As an operator i would prefer to have my own logic to handle cleanup, but
this varies for everyone hence the option :-)

Erik
3. juli 2014 21:45 skrev "Silvano Nogueira Buback" 
følgende:

> Hi guys,
>
> I think you are busy because 4.4 release tasks, but I'm worried about
> the time to 4.5 feature freeze. I put the documentation of feature in wiki
> as requested and I hoped people read there and make some comments here.
>
> To help, I will put design issues that are in document, one by one, and we
> can discuss in this thread. After each discussion I will change the
> document.
>
>I have one question about removing DNS domain when network has been
> deleted. In my current implementation I remove DNS domain when network is
> removed. But if the DNS domain is shared with another network or maybe is a
> dns domain used outside ACS this can be a problem. What I can do with DNS
> domain when network is removed:
>
>1. Keep the current implementation. Always deleted DNS domain when
>network is removed (works well if the ACS is the only manager for the
> DNS
>(one network domain per network).
>2. Remove DNS domain only if the domain was created by ACS. This can be
>a problem if someone put records after ACS creation.
>3. Remove DNS domain only if there is no more records there. Maybe DNS
>domain can stay forever there because an inconsistency that keep only
> one
>record.
>
>
> Which one is the best?
>
> []'s,
>
> Silvano Buback
>
>
>
> On Thu, Jun 26, 2014 at 11:34 AM, Silvano Nogueira Buback <
> silv...@corp.globo.com> wrote:
>
> > Thank you David.
> >
> > I put design documents on wiki:
> >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Bind+and+PowerDNS+integration+by+Globo+DNSAPI
> .
> > I create an issue https://issues.apache.org/jira/browse/CLOUDSTACK-6998
> > too.
> >
> > I look forward to hearing your feedbacks.
> >
> > []'s,
> >
> > Silvano Buback
> >
> >
> > On Wed, Jun 25, 2014 at 5:50 PM, David Nalley  wrote:
> >
> >> On Wed, Jun 25, 2014 at 4:38 PM, Silvano Nogueira Buback
> >>  wrote:
> >> > Hi guys,
> >> >
> >> >I finish the first version of design document:
> >> >
> >>
> https://docs.google.com/document/d/1kbPQJrBC87ZtR-t7LwHFDzAmT436ShtjwKE84FVfByM/pub
> >> > .
> >> >
> >> >Someone could give me access to put design documents in wiki?
> Bellow
> >> the
> >> > username of people work with Cloudstack in Globo.com and need access.
> >> >
> >> > snbuback silv...@corp.globo.com
> >> > daniel.simoes daniel.sim...@corp.globo.com
> >> > lokama - lok...@gmail.com
> >> >
> >> > Regards,
> >> >
> >> > Silvano Buback
> >> >
> >> >
> >> >
> >> > On Thu, Jun 19, 2014 at 11:29 AM, Silvano Buback 
> >> wrote:
> >> >
> >> >> Of course, I forgotten my account info:
> >> >> snbuback / silv...@corp.globo.com
> >> >>
> >>
> >>
> >> Done.
> >>
> >> --David
> >>
> >
> >
>

Re: [VOTE] Apache Cloudstack 4.4.0

[Daan Hoogland]

Ove, any target specific? mvn clean test works.

On Thu, Jul 3, 2014 at 6:06 AM, Ove Ewerlid  wrote:
> -1
>
> The top level pom.xml still contains a -SNAPSHOT suffix.
>
>  https://github.com/apache/cloudstack/blob/4.4-RC20140702T2107/pom.xml
>
> line 63.
>
> Removing the -SNAPSHOT suffix allows compilation.
>
> /Ove (Nitpicking)
>
>
>
>
> On 07/02/2014 10:18 PM, Daan Hoogland wrote:
>>
>> Hi All,
>>
>> I've created a 4.4.0 release, with the following artifacts up for a vote:
>>
>> Git Branch and Commit SH:
>>
>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
>> Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a
>>
>> List of changes:
>>
>> http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/
>>
>> Source release (checksums and signatures are available at the same
>> location):
>> https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/
>>
>> PGP release keys (signed using 4096R/AA4736F3):
>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>>
>> Vote will be open for 72 hours.
>>
>> For sanity in tallying the vote, can PMC members please be sure to
>> indicate "(binding)" with their vote?
>>
>> [ ] +1  approve
>> [ ] +0  no opinion
>> [ ] -1  disapprove (and reason why)
>>
>>
>> I will ad my key to the mentioned KEYS file as soon as possible,
>>
>
>
> --
> Ove Everlid
> System Administrator / Architect / SDN- & Automation- & Linux-hacker
> Mobile: +46706668199 (dedicated work mobile)
> Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)



-- 
Daan

Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily

[Alena Prokharchyk]

Daan, there are similar problem in saveaccount/saveuser methods in thr same 
class - introduced by this commit as well. I can fix it myself on Monday (Its 
holiday days today and tomorrow at Citrix, usa); or you can revert them as well 
along with the fix you do for network groups.

Let me know, and thank you for the follow up.

-alena

> On Jul 2, 2014, at 11:43 PM, "Daan Hoogland"  wrote:
> 
> On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
>  wrote:
>> In any case, fixes done to ConfigurationManagerImpl are not correct, and
>> logging should be fixed by reverting/reapplying the commit by following
>> the rules defined in a) or b).
> 
> 
> changing to
> } catch (Exception ex) {
>// if network_groups table exists, create the
> default security group there
>s_logger.debug("Caught (SQL?)Exception: no
> network_group  " + ex.getLocalizedMessage());
>}
> for now
> 
> -- 
> Daan

Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily

[Daan Hoogland]

Alena, I really want to fix issues in this line, because I really want
us to use exceptions properly and never ignore them. So I would like
handle them or log at least. Thanks for your patients.

I am not sure of what you mean. Is this close:

diff --git a/server/src/com/cloud/server/ConfigurationServerImpl.java
b/server/src/com/cloud/server/ConfigurationServerImpl.java
index b66e52d..a166372 100755
--- a/server/src/com/cloud/server/ConfigurationServerImpl.java
+++ b/server/src/com/cloud/server/ConfigurationServerImpl.java
@@ -462,21 +462,21 @@

 try {
 PreparedStatement stmt =
txn.prepareAutoCloseStatement(insertSql);
 stmt.executeUpdate();
 } catch (SQLException ex) {
-s_logger.debug("Caught SQLException when
inserting system account ", ex);
+s_logger.debug("Caught SQLException when
inserting system account: " + ex.getLocalizedMessage());
 }
 // insert system user
 insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
username, password, account_id, firstname, lastname, created,
user.default)"
 + " VALUES (1, UUID(), 'system', RAND(), 1,
'system', 'cloud', now(), 1)";

 try {
 PreparedStatement stmt =
txn.prepareAutoCloseStatement(insertSql);
 stmt.executeUpdate();
 } catch (SQLException ex) {
-s_logger.debug("Caught SQLException when
inserting system user ", ex);
+s_logger.debug("Caught SQLException when
inserting system user: " + ex.getLocalizedMessage());
 }

 // insert admin user, but leave the account disabled
until we set a
 // password with the user authenticator
 long id = 2;
@@ -489,22 +489,22 @@
 + "', '1', '1', 1)";
 try {
 PreparedStatement stmt =
txn.prepareAutoCloseStatement(insertSql);
 stmt.executeUpdate();
 } catch (SQLException ex) {
-s_logger.debug("Caught SQLException when creating
admin account ", ex);
+s_logger.debug("Caught SQLException when creating
admin account: " + ex.getLocalizedMessage());
 }

 // now insert the user
 insertSql = "INSERT INTO `cloud`.`user` (id, uuid,
username, password, account_id, firstname, lastname, created, state,
user.default) " + "VALUES (" + id
 + ", UUID(), '" + username + "', RAND(), 2,
'" + firstname + "','" + lastname + "',now(), 'disabled', 1)";

 try {
 PreparedStatement stmt =
txn.prepareAutoCloseStatement(insertSql);
 stmt.executeUpdate();
 } catch (SQLException ex) {
-s_logger.debug("Caught SQLException when
inserting user ", ex);
+s_logger.debug("Caught SQLException when
inserting user " + ex.getLocalizedMessage());
 }

 try {
 String tableName = "security_group";
 try {

On Thu, Jul 3, 2014 at 10:23 PM, Alena Prokharchyk
 wrote:
> Daan, there are similar problem in saveaccount/saveuser methods in thr same 
> class - introduced by this commit as well. I can fix it myself on Monday (Its 
> holiday days today and tomorrow at Citrix, usa); or you can revert them as 
> well along with the fix you do for network groups.
>
> Let me know, and thank you for the follow up.
>
> -alena
>
>> On Jul 2, 2014, at 11:43 PM, "Daan Hoogland"  wrote:
>>
>> On Thu, Jul 3, 2014 at 12:27 AM, Alena Prokharchyk
>>  wrote:
>>> In any case, fixes done to ConfigurationManagerImpl are not correct, and
>>> logging should be fixed by reverting/reapplying the commit by following
>>> the rules defined in a) or b).
>>
>>
>> changing to
>> } catch (Exception ex) {
>>// if network_groups table exists, create the
>> default security group there
>>s_logger.debug("Caught (SQL?)Exception: no
>> network_group  " + ex.getLocalizedMessage());
>>}
>> for now
>>
>> --
>> Daan



-- 
Daan

[ANNOUNCE] Will Stevens as committer

[sebgoa]

The Project Management Committee (PMC) for Apache CloudStack has
asked Will Stevens to become a committer and we are pleased to announce
that he has accepted.

Being a committer allows many contributors to contribute more autonomously. For
developers, it makes it easier to submit changes and eliminates the need to
have contributions reviewed via the patch submission process. Whether
contributions are development-related or otherwise, it is a recognition of a
contributor's participation in the project and commitment to the project and
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it up :)

-Sebastien
For the CloudStack PMC

Re: [ANNOUNCE] Will Stevens as committer

[Daan Hoogland]

Will, felicitations and enjoy the ride.

On Thu, Jul 3, 2014 at 10:43 PM, sebgoa  wrote:
> The Project Management Committee (PMC) for Apache CloudStack has
> asked Will Stevens to become a committer and we are pleased to announce
> that he has accepted.
>
> Being a committer allows many contributors to contribute more autonomously. 
> For
> developers, it makes it easier to submit changes and eliminates the need to
> have contributions reviewed via the patch submission process. Whether
> contributions are development-related or otherwise, it is a recognition of a
> contributor's participation in the project and commitment to the project and
> the Apache Way.
>
> Please join me in congratulating Will!
>
> PS: Good job on the Palo Alto feature and the documentation, keep it up :)
>
> -Sebastien
> For the CloudStack PMC



-- 
Daan

RE: [ANNOUNCE] Will Stevens as committer

[Alex Hitchins]

Congratulations!


Alex Hitchins | 07788 423 969 | 01892 523 587

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: 03 July 2014 21:43
To: cloudstack
Subject: [ANNOUNCE] Will Stevens as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Will
Stevens to become a committer and we are pleased to announce that he has
accepted.

Being a committer allows many contributors to contribute more autonomously.
For developers, it makes it easier to submit changes and eliminates the need
to have contributions reviewed via the patch submission process. Whether
contributions are development-related or otherwise, it is a recognition of a
contributor's participation in the project and commitment to the project and
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it up :)

-Sebastien
For the CloudStack PMC

Re: [VOTE] Apache Cloudstack 4.4.0

[Ove Ewerlid]

On 07/03/2014 10:16 PM, Daan Hoogland wrote:

Ove, any target specific? mvn clean test works.


No target specifics AFAIK. Below is a short script that repeats the issue.

For the example run below a Fedora 20 system was used, the same error is 
seen on OEL65 (Oracle variant of RHEL65).


This could be ~/.m2 cache madness but on the other hand, we can probably 
agree that the top level pom.xml shall not contain any traces of 
"-SNAPSHOT" in an RC for 4.4.0 irregardless of presence of compile 
failures or not.


The fix to the compile failure seen below is to remove the single 
occurrence of "-SNAPSHOT" in the top level pom.xml (as seen in 
4.4-RC20140702T2107).


/Ove


[oewerlid@amd-a git]$ cat rc44-compile-issue-repeat.sh
#!/bin/bash
cat /etc/issue|grep Fedora
sudo yum -y install mvn java-1.7.0 > /dev/null
rm -rf ~/.m2
rm -rf ~/acs44test; mkdir ~/acs44test; cd ~/acs44test
git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
cd cloudstack
git checkout 4.4-RC20140702T2107
mvn -D skipTests -P developer | grep '^\[ERROR\]' | grep -- -SNAPSHOT
[oewerlid@amd-a git]$ ./rc44-compile-issue-repeat.sh
Fedora release 20 (Heisenbug)
Cloning into 'cloudstack'...
remote: Counting objects: 508606, done.
remote: Compressing objects: 100% (101172/101172), done.
remote: Total 508606 (delta 339589), reused 500432 (delta 333829)
Receiving objects: 100% (508606/508606), 378.44 MiB | 1.25 MiB/s, done.
Resolving deltas: 100% (339589/339589), done.
Checking connectivity... done.
Branch 4.4-RC20140702T2107 set up to track remote branch 
4.4-RC20140702T2107 from origin.

Switched to a new branch '4.4-RC20140702T2107'
[ERROR] Failed to execute goal on project cloud-plugin-hypervisor-ovm: 
Could not resolve dependencies for project 
org.apache.cloudstack:cloud-plugin-hypervisor-ovm:jar:4.4.0: Could not 
find artifact org.apache.cloudstack:xapi:jar:6.2.0-\
1-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) 
-> [Help 1]

[oewerlid@amd-a git]$



On Thu, Jul 3, 2014 at 6:06 AM, Ove Ewerlid  wrote:

-1

The top level pom.xml still contains a -SNAPSHOT suffix.

  https://github.com/apache/cloudstack/blob/4.4-RC20140702T2107/pom.xml

line 63.

Removing the -SNAPSHOT suffix allows compilation.

/Ove (Nitpicking)




On 07/02/2014 10:18 PM, Daan Hoogland wrote:


Hi All,

I've created a 4.4.0 release, with the following artifacts up for a vote:

Git Branch and Commit SH:

https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a

List of changes:

http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/

PGP release keys (signed using 4096R/AA4736F3):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)


I will ad my key to the mentioned KEYS file as soon as possible,




--
Ove Everlid
System Administrator / Architect / SDN- & Automation- & Linux-hacker
Mobile: +46706668199 (dedicated work mobile)
Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)







--
Ove Everlid
System Administrator / Architect / SDN- & Automation- & Linux-hacker
Mobile: +46706668199 (dedicated work mobile)
Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)

RE: [ANNOUNCE] Will Stevens as committer

[Nguyen Anh Tu]

Congrats Will!

--Tuna

Sent from my GT-N7000
On Jul 4, 2014 4:26 AM, "Alex Hitchins"  wrote:

> Congratulations!
>
>
> Alex Hitchins | 07788 423 969 | 01892 523 587
>
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com]
> Sent: 03 July 2014 21:43
> To: cloudstack
> Subject: [ANNOUNCE] Will Stevens as committer
>
> The Project Management Committee (PMC) for Apache CloudStack has asked Will
> Stevens to become a committer and we are pleased to announce that he has
> accepted.
>
> Being a committer allows many contributors to contribute more autonomously.
> For developers, it makes it easier to submit changes and eliminates the
> need
> to have contributions reviewed via the patch submission process. Whether
> contributions are development-related or otherwise, it is a recognition of
> a
> contributor's participation in the project and commitment to the project
> and
> the Apache Way.
>
> Please join me in congratulating Will!
>
> PS: Good job on the Palo Alto feature and the documentation, keep it up :)
>
> -Sebastien
> For the CloudStack PMC
>
>

RE: Regarding UI for SSL termination/offloading feature

[Rajesh Battala]

Please do that. It will be great help to community so that no need to re-invent 
the UI for this feature.
I can test the UI part.

Thanks
Rajesh Battala

-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com] 
Sent: Thursday, July 3, 2014 11:26 PM
To: Rajesh Battala
Cc: dev@cloudstack.apache.org
Subject: Re: Regarding UI for SSL termination/offloading feature

Hey Rajesh,

I had the UI in my dev branch but could not send that for review as I got busy 
with other work. I will dig that code up and send the request sometime next 
week.

Thanks,
-Syed

On Wed 02 Jul 2014 03:23:20 AM EDT, Rajesh Battala wrote:
> Hi Syed,
>
> In FS, there are screenshots regarding the UI support for certificates 
> management for accounts.
>
> But in deployment(master) am not able to see any such UI.
>
> Is this a model or you have missed committing the changes.
>
> Thanks
>
> Rajesh Battala
>

Re: [ANNOUNCE] Will Stevens as committer

[Francois Gaudreault]

Finally! :)

Good Job Will!

Francois

On 2014-07-03, 8:25 PM, Nguyen Anh Tu wrote:

Congrats Will!

--Tuna

Sent from my GT-N7000
On Jul 4, 2014 4:26 AM, "Alex Hitchins"  wrote:


Congratulations!


Alex Hitchins | 07788 423 969 | 01892 523 587

-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: 03 July 2014 21:43
To: cloudstack
Subject: [ANNOUNCE] Will Stevens as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Will
Stevens to become a committer and we are pleased to announce that he has
accepted.

Being a committer allows many contributors to contribute more autonomously.
For developers, it makes it easier to submit changes and eliminates the
need
to have contributions reviewed via the patch submission process. Whether
contributions are development-related or otherwise, it is a recognition of
a
contributor's participation in the project and commitment to the project
and
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it up :)

-Sebastien
For the CloudStack PMC





--
Francois Gaudreault
Gestionnaire de Produit | Product Manager - Cloud Platform & Services
t:514-629-6775

CloudOps Votre partenaire infonuagique | Cloud Solutions Experts
420 rue Guy | Montreal | Quebec | H3J 1S6
w: cloudops.com | tw: @CloudOps_

Re: [ANNOUNCE] Will Stevens as committer

[Syed Ahmed]

Congratulations Will :D

-Syed

On 14-07-03 10:56 PM, Francois Gaudreault wrote:

Finally! :)

Good Job Will!

Francois

On 2014-07-03, 8:25 PM, Nguyen Anh Tu wrote:

Congrats Will!

--Tuna

Sent from my GT-N7000
On Jul 4, 2014 4:26 AM, "Alex Hitchins"  wrote:


Congratulations!


Alex Hitchins | 07788 423 969 | 01892 523 587

-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: 03 July 2014 21:43
To: cloudstack
Subject: [ANNOUNCE] Will Stevens as committer

The Project Management Committee (PMC) for Apache CloudStack has 
asked Will
Stevens to become a committer and we are pleased to announce that he 
has

accepted.

Being a committer allows many contributors to contribute more 
autonomously.

For developers, it makes it easier to submit changes and eliminates the
need
to have contributions reviewed via the patch submission process. 
Whether
contributions are development-related or otherwise, it is a 
recognition of

a
contributor's participation in the project and commitment to the 
project

and
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it 
up :)


-Sebastien
For the CloudStack PMC

Re: Doc on Network Throttling

[Rajani Karuturi]

It would be better if its in the original authors name instead of me copy 
pasting stuff. Its very easy to submit a doc pull request.

~Rajani



On 03-Jul-2014, at 8:09 pm, David Nalley  wrote:

> Rajani:
> 
> No reason you can't do that. Submit a pull request:
> https://github.com/apache/cloudstack-docs-admin
> 
> --David
> 
> On Thu, Jul 3, 2014 at 4:52 AM, Rajani Karuturi
>  wrote:
>> Thanks for the wiki alena and rajesh.
>> Can this be moved to docs? 
>> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling
>> 
>> 
>> ~Rajani
>> 
>> 
>> 
>> On 03-Jul-2014, at 1:27 pm, Rajesh Battala 
>> mailto:rajesh.batt...@citrix.com>> wrote:
>> 
>> Hi Alena,
>> I have updated wiki for Hyper-V
>> 
>> Thanks
>> Rajesh Battala
>> 
>> From: Alena Prokharchyk
>> Sent: Wednesday, July 2, 2014 3:43 AM
>> To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
>> dev@cloudstack.apache.org
>> Subject: Doc on Network Throttling
>> 
>> As I remember seeing the question on how Network throttling works in CS, so 
>> I've created a wiki page explaining the CS implementation. Feel free to 
>> review/update/fix:
>> 
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack
>> 
>> Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is 
>> set on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors 
>> accordingly? As I don't have enough expertise on this part.
>> 
>> -Alena.
>> 

Re: Doc on Network Throttling

[Rajani Karuturi]

It would be better if its in the original authors name instead of me copy 
pasting stuff. Its very easy to submit a doc pull request.

~Rajani



On 03-Jul-2014, at 8:09 pm, David Nalley  wrote:

> Rajani:
> 
> No reason you can't do that. Submit a pull request:
> https://github.com/apache/cloudstack-docs-admin
> 
> --David
> 
> On Thu, Jul 3, 2014 at 4:52 AM, Rajani Karuturi
>  wrote:
>> Thanks for the wiki alena and rajesh.
>> Can this be moved to docs? 
>> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling
>> 
>> 
>> ~Rajani
>> 
>> 
>> 
>> On 03-Jul-2014, at 1:27 pm, Rajesh Battala 
>> mailto:rajesh.batt...@citrix.com>> wrote:
>> 
>> Hi Alena,
>> I have updated wiki for Hyper-V
>> 
>> Thanks
>> Rajesh Battala
>> 
>> From: Alena Prokharchyk
>> Sent: Wednesday, July 2, 2014 3:43 AM
>> To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
>> dev@cloudstack.apache.org
>> Subject: Doc on Network Throttling
>> 
>> As I remember seeing the question on how Network throttling works in CS, so 
>> I've created a wiki page explaining the CS implementation. Feel free to 
>> review/update/fix:
>> 
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack
>> 
>> Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is 
>> set on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors 
>> accordingly? As I don't have enough expertise on this part.
>> 
>> -Alena.
>> 

Re: [ACS431]CLOUDSTACK-6360: Usage server failed to start with 4.4 build

[Rajani Karuturi]

I was thinking that Rayees would commit the fix as the bug is reopened. Will 
wait for him to comment. 

~Rajani



On 03-Jul-2014, at 6:43 pm, sebgoa  wrote:

> 
> On Jul 3, 2014, at 11:10 AM, Rajani Karuturi  
> wrote:
> 
>> Hi Sebastien,
>> 
>> while rebasing the fix for CLOUDSTACK-6926, I observed that mysql connector 
>> related changes aren’t done in the debian cloud-usage script. 
>> I reopened the related issue 
>> https://issues.apache.org/jira/browse/CLOUDSTACK-6360?focusedCommentId=14051219
>>  
>> 
>> I think it would be good to have the fix for CLOUDSTACK-6360 in 4.3.1
>> 
> 
> Happy to apply the patch if you give me one.
> 
>> ~Rajani
>> 
>> 
>> 
>> On 02-Jul-2014, at 7:33 pm, Sebastien Goasguen  wrote:
>> 
>>> This is an automatically generated e-mail. To reply, visit: 
>>> https://reviews.apache.org/r/22721/
>>> Hi, no it does not apply cleanly to current 4.3 branch. Can you rebase.
>>> 
>>> thanks
>>> 
>>> 
>>> - Sebastien Goasguen
>>> 
>>> 
>>> On June 18th, 2014, 10:15 a.m. UTC, Rajani Karuturi wrote:
>>> 
>>> Review request for cloudstack, Kishan Kavala and Rayees Namathponnan.
>>> By Rajani Karuturi.
>>> Updated June 18, 2014, 10:15 a.m.
>>> 
>>> Bugs: CLOUDSTACK-6926
>>> Repository: cloudstack-git
>>> Description
>>> 
>>> used to readlink -e and dirname to get the JAVA_HOME
>>> if JAVA_HOME is not already defined, sets it to jdk home if javac is 
>>> present else jre home if java is present.
>>> if nothing is present, it exits with error
>>> 
>>> Testing
>>> 
>>> tested it when java is not installed, jre is installed, jdk installed or 
>>> when a older version is installed on centos 6.4 and ubuntu 14.04 
>>> Diffs
>>> 
>>> • packaging/centos63/cloud-usage.rc (6170379)
>>> • packaging/debian/init/cloud-usage (1cc75cc)
>>> View Diff
>>> 
>> 
> 

Re: To disable ISO on booting up the vm

[Giri Prasad]

Thanks for the reply. detach ISO option worked.





- Original Message -
From: Suresh Sadhu 
To: "dev@cloudstack.apache.org" ; Giri Prasad 

Cc: "us...@cloudstack.apache.org" 
Sent: Thursday, 3 July 2014 9:41 AM
Subject: RE: To disable ISO on booting up the vm

Detach the attached ISO from VM  from UI using detach ISO option.




-Original Message-
From: Giri Prasad [mailto:g_p...@yahoo.com.INVALID] 
Sent: 03 July 2014 09:38
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org
Subject: To disable ISO on booting up the vm

Hello All,

 I have installed cloudstack 4.1 on Ubuntu 12.04 LTS. I have created two vm's 
and installed ubuntu and centos 6.5 on these vm's.

 When I start the instance from the cloudstack gui, the ISO is getting booted. 
After selecting the reset option from the ISO install menu or screen, the 
installed kernel boots up. 


Since I have already installed ubuntu and centos on these vm's, I want vm to 
boot from the installed kernel, not from the ISO. Can anybody provide insights, 
as how to disable the booting from the ISO (in vm) or to delete the ISO from 
the VM.

Thanks in advance.

Regards,
D.Giriprasad

Re: Review Request 23192: Adding Readme and run checkbox at the end of the installation. Also installing mysql connector

[Koushik Das]

> On July 3, 2014, 2:18 p.m., Chip Childers wrote:
> > -1 to this commit until legal policy issues are resolved

Reverted the commit

commit 4607c26949b6b925fdc0eb2a5253d536dd333439
Author: Koushik Das 
Date:   Fri Jul 4 10:04:04 2014 +0530

Revert "CLOUDSTACK-6834 : 3. Some description changes words like CloudStack 
etc 4. Change Default installation location if possible include version number 
5. Mysql Connector Installer along with oth

This reverts commit ce5061e107f743e52b23445fd97fcf60d8160ec6.


- Koushik


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23192/#review47301
---


On July 3, 2014, 11:58 a.m., Damodar Reddy Talakanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23192/
> ---
> 
> (Updated July 3, 2014, 11:58 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Hugo 
> Trippaers.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6834
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Incorporated some Changes to include things like runservice readme checkbox, 
> changing the default installation location etc..
> 
> 
> Diffs
> -
> 
>   client/pom.xml 29fef4f 
>   pom.xml 0b3b56e 
>   scripts/installer/windows/ExitDialog.wxs PRE-CREATION 
>   scripts/installer/windows/WixInstallerDialog.wxs 0282d8a 
>   scripts/installer/windows/acs.wxs bf09afc 
>   scripts/installer/windows/dependencies.wxs 987c561 
>   scripts/installer/windows/en-us.wxl 2f34575 
>   scripts/installer/windows/optionstheme_en-us.wxl c822929 
>   scripts/installer/windows/readme.txt PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23192/diff/
> 
> 
> Testing
> ---
> 
> Tested on Windows 2012 Server
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>

Re: [ANNOUNCE] New PMC Member: Mark Hinkle

[Rohit Yadav]

Congratulations Mark!

Regards.

John Burwell wrote:

The Project Management Committee (PMC) for Apache CloudStack has asked Mark 
Hinkle to join the PMC and we are pleased to announce that he has accepted.

Join me in congratulating Mark!


-The CloudStack PMC


--
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended solely 
for the use of the individual to whom it is addressed. Any views or opinions 
expressed are solely those of the author and do not necessarily represent those of 
Shape Blue Ltd or related companies. If you are not the intended recipient of this 
email, you must neither take any action based upon its contents, nor copy or show 
it to anyone. Please contact the sender if you believe you have received this email 
in error. Shape Blue Ltd is a company incorporated in England & Wales. 
ShapeBlue Services India LLP is a company incorporated in India and is operated 
under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company 
incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue 
is a registered trademark.

Re: [ANNOUNCE] Will Stevens as committer

[Rohit Yadav]

Congrats Will!

Regards.

sebgoa wrote:

The Project Management Committee (PMC) for Apache CloudStack has
asked Will Stevens to become a committer and we are pleased to announce
that he has accepted.

Being a committer allows many contributors to contribute more autonomously. For
developers, it makes it easier to submit changes and eliminates the need to
have contributions reviewed via the patch submission process. Whether
contributions are development-related or otherwise, it is a recognition of a
contributor's participation in the project and commitment to the project and
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it up :)

-Sebastien
For the CloudStack PMC


--
Rohit Yadav
Software Architect, ShapeBlue
M. +91 88 262 30892 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended solely 
for the use of the individual to whom it is addressed. Any views or opinions 
expressed are solely those of the author and do not necessarily represent those of 
Shape Blue Ltd or related companies. If you are not the intended recipient of this 
email, you must neither take any action based upon its contents, nor copy or show 
it to anyone. Please contact the sender if you believe you have received this email 
in error. Shape Blue Ltd is a company incorporated in England & Wales. 
ShapeBlue Services India LLP is a company incorporated in India and is operated 
under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company 
incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue 
is a registered trademark.

RE: [ANNOUNCE] New PMC Member: Mark Hinkle

[Rajesh Battala]

Hearty Congratulations Mark 

-Original Message-
From: John Burwell [mailto:jburw...@basho.com] 
Sent: Thursday, July 3, 2014 11:21 PM
To: dev@cloudstack.apache.org
Cc: market...@cloudstack.apache.org
Subject: [ANNOUNCE] New PMC Member: Mark Hinkle

The Project Management Committee (PMC) for Apache CloudStack has asked Mark 
Hinkle to join the PMC and we are pleased to announce that he has accepted. 

Join me in congratulating Mark! 


-The CloudStack PMC

RE: [ANNOUNCE] Will Stevens as committer

[Rajesh Battala]

Hearty Congratulations Will.

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Friday, July 4, 2014 2:13 AM
To: cloudstack
Subject: [ANNOUNCE] Will Stevens as committer

The Project Management Committee (PMC) for Apache CloudStack has asked Will 
Stevens to become a committer and we are pleased to announce that he has 
accepted.

Being a committer allows many contributors to contribute more autonomously. For 
developers, it makes it easier to submit changes and eliminates the need to 
have contributions reviewed via the patch submission process. Whether 
contributions are development-related or otherwise, it is a recognition of a 
contributor's participation in the project and commitment to the project and 
the Apache Way.

Please join me in congratulating Will!

PS: Good job on the Palo Alto feature and the documentation, keep it up :)

-Sebastien
For the CloudStack PMC

RE: Regarding UI for SSL termination/offloading feature

[Rajesh Battala]

Sayed, 
There is a bug I found in feature, I have fixed it and pushed to master. 
CLOUDSTACK-7037 - Unable to add new vm/service to existing LB rule of SSL 
protocol

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Friday, July 4, 2014 8:09 AM
To: Syed Ahmed
Cc: dev@cloudstack.apache.org
Subject: RE: Regarding UI for SSL termination/offloading feature

Please do that. It will be great help to community so that no need to re-invent 
the UI for this feature.
I can test the UI part.

Thanks
Rajesh Battala

-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com]
Sent: Thursday, July 3, 2014 11:26 PM
To: Rajesh Battala
Cc: dev@cloudstack.apache.org
Subject: Re: Regarding UI for SSL termination/offloading feature

Hey Rajesh,

I had the UI in my dev branch but could not send that for review as I got busy 
with other work. I will dig that code up and send the request sometime next 
week.

Thanks,
-Syed

On Wed 02 Jul 2014 03:23:20 AM EDT, Rajesh Battala wrote:
> Hi Syed,
>
> In FS, there are screenshots regarding the UI support for certificates 
> management for accounts.
>
> But in deployment(master) am not able to see any such UI.
>
> Is this a model or you have missed committing the changes.
>
> Thanks
>
> Rajesh Battala
>

Re: Doc on Network Throttling

[Sebastien Goasguen]

> On 4 Jul 2014, at 05:37, Rajani Karuturi  wrote:
> 
> It would be better if its in the original authors name instead of me copy 
> pasting stuff. Its very easy to submit a doc pull request.
> 

Agreed, it's super easy :)


> ~Rajani
> 
> 
> 
>> On 03-Jul-2014, at 8:09 pm, David Nalley  wrote:
>> 
>> Rajani:
>> 
>> No reason you can't do that. Submit a pull request:
>> https://github.com/apache/cloudstack-docs-admin
>> 
>> --David
>> 
>> On Thu, Jul 3, 2014 at 4:52 AM, Rajani Karuturi
>>  wrote:
>>> Thanks for the wiki alena and rajesh.
>>> Can this be moved to docs? 
>>> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling
>>> 
>>> 
>>> ~Rajani
>>> 
>>> 
>>> 
>>> On 03-Jul-2014, at 1:27 pm, Rajesh Battala 
>>> mailto:rajesh.batt...@citrix.com>> wrote:
>>> 
>>> Hi Alena,
>>> I have updated wiki for Hyper-V
>>> 
>>> Thanks
>>> Rajesh Battala
>>> 
>>> From: Alena Prokharchyk
>>> Sent: Wednesday, July 2, 2014 3:43 AM
>>> To: Anthony Xu; Kelven Yang; Edison Su; Rajesh Battala; 
>>> dev@cloudstack.apache.org
>>> Subject: Doc on Network Throttling
>>> 
>>> As I remember seeing the question on how Network throttling works in CS, so 
>>> I've created a wiki page explaining the CS implementation. Feel free to 
>>> review/update/fix:
>>> 
>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Network+throttling+in+CloudStack
>>> 
>>> Anthony/Kelven/Edison/Rajesh, can you please update the "How throttling is 
>>> set on Hypervisor level" section for Xen/VmWare/KVM/HyperV hypervisors 
>>> accordingly? As I don't have enough expertise on this part.
>>> 
>>> -Alena.
>>> 
> 

RE: Regarding UI for SSL termination/offloading feature

[Saksham Srivastava]

We also have few gaps in the FS.
There is no reference API in the FS which makes it difficult to use the feature 
given that there is no UI still.
Will update the FS in a couple of days.

Thanks,
Saksham 

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com] 
Sent: Friday, July 4, 2014 10:48 AM
To: dev@cloudstack.apache.org; Syed Ahmed
Subject: RE: Regarding UI for SSL termination/offloading feature

Sayed,
There is a bug I found in feature, I have fixed it and pushed to master. 
CLOUDSTACK-7037 - Unable to add new vm/service to existing LB rule of SSL 
protocol

Thanks
Rajesh Battala

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: Friday, July 4, 2014 8:09 AM
To: Syed Ahmed
Cc: dev@cloudstack.apache.org
Subject: RE: Regarding UI for SSL termination/offloading feature

Please do that. It will be great help to community so that no need to re-invent 
the UI for this feature.
I can test the UI part.

Thanks
Rajesh Battala

-Original Message-
From: Syed Ahmed [mailto:sah...@cloudops.com]
Sent: Thursday, July 3, 2014 11:26 PM
To: Rajesh Battala
Cc: dev@cloudstack.apache.org
Subject: Re: Regarding UI for SSL termination/offloading feature

Hey Rajesh,

I had the UI in my dev branch but could not send that for review as I got busy 
with other work. I will dig that code up and send the request sometime next 
week.

Thanks,
-Syed

On Wed 02 Jul 2014 03:23:20 AM EDT, Rajesh Battala wrote:
> Hi Syed,
>
> In FS, there are screenshots regarding the UI support for certificates 
> management for accounts.
>
> But in deployment(master) am not able to see any such UI.
>
> Is this a model or you have missed committing the changes.
>
> Thanks
>
> Rajesh Battala
>

Re: [ACS431]CLOUDSTACK-6360: Usage server failed to start with 4.4 build

[Shanker Balan]

Comments inline.

On 04-Jul-2014, at 9:09 am, Rajani Karuturi  wrote:

> I was thinking that Rayees would commit the fix as the bug is reopened. Will 
> wait for him to comment.
>
> ~Rajani


As a side note, packaging/centos63/cloud-usage.rc refers to
/etc/sysconfig/default/"$SHORTNAME”.

There is no such folder "/etc/sysconfig/default/“ on CentOS/RHEL systems AFAIK.

Can this be fixed to use /etc/sysconfig/"$SHORTNAME”?



--
@shankerbalan

M: +91 98860 60539 | O: +91 (80) 67935867
shanker.ba...@shapeblue.com | www.shapeblue.com | Twitter:@shapeblue
ShapeBlue Services India LLP, 22nd floor, Unit 2201A, World Trade Centre, 
Bangalore - 560 055

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [VOTE] Apache Cloudstack 4.4.0

[Daan Hoogland]

In principle, yes. You descibed earlier that the -SNAPSHOT that is
your problem is in 6.2.0-SNAPSHOT, the version for the xapi jar, not a
4.4.0-SNAPSHOT detailing cloudstacks version. The code for setting
this version hasn't changed so I suspect that 4.3.0 has in the top
level pom 4.3.0-SNAPSHOT.

@Tim: you happen to know whether this xapi version has to change in
the top level pom, or whether it maybe shouldn't have in other places?

Daan

On Thu, Jul 3, 2014 at 11:46 PM, Ove Ewerlid  wrote:
> On 07/03/2014 10:16 PM, Daan Hoogland wrote:
>>
>> Ove, any target specific? mvn clean test works.
>
>
> No target specifics AFAIK. Below is a short script that repeats the issue.
>
> For the example run below a Fedora 20 system was used, the same error is
> seen on OEL65 (Oracle variant of RHEL65).
>
> This could be ~/.m2 cache madness but on the other hand, we can probably
> agree that the top level pom.xml shall not contain any traces of "-SNAPSHOT"
> in an RC for 4.4.0 irregardless of presence of compile failures or not.
>
> The fix to the compile failure seen below is to remove the single occurrence
> of "-SNAPSHOT" in the top level pom.xml (as seen in 4.4-RC20140702T2107).
>
> /Ove
>
>
> [oewerlid@amd-a git]$ cat rc44-compile-issue-repeat.sh
> #!/bin/bash
> cat /etc/issue|grep Fedora
> sudo yum -y install mvn java-1.7.0 > /dev/null
> rm -rf ~/.m2
> rm -rf ~/acs44test; mkdir ~/acs44test; cd ~/acs44test
> git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
> cd cloudstack
> git checkout 4.4-RC20140702T2107
> mvn -D skipTests -P developer | grep '^\[ERROR\]' | grep -- -SNAPSHOT
> [oewerlid@amd-a git]$ ./rc44-compile-issue-repeat.sh
> Fedora release 20 (Heisenbug)
> Cloning into 'cloudstack'...
> remote: Counting objects: 508606, done.
> remote: Compressing objects: 100% (101172/101172), done.
> remote: Total 508606 (delta 339589), reused 500432 (delta 333829)
> Receiving objects: 100% (508606/508606), 378.44 MiB | 1.25 MiB/s, done.
> Resolving deltas: 100% (339589/339589), done.
> Checking connectivity... done.
> Branch 4.4-RC20140702T2107 set up to track remote branch 4.4-RC20140702T2107
> from origin.
> Switched to a new branch '4.4-RC20140702T2107'
> [ERROR] Failed to execute goal on project cloud-plugin-hypervisor-ovm: Could
> not resolve dependencies for project
> org.apache.cloudstack:cloud-plugin-hypervisor-ovm:jar:4.4.0: Could not find
> artifact org.apache.cloudstack:xapi:jar:6.2.0-\
> 1-SNAPSHOT in apache.snapshots (http://repository.apache.org/snapshots) ->
> [Help 1]
> [oewerlid@amd-a git]$
>
>
>
>> On Thu, Jul 3, 2014 at 6:06 AM, Ove Ewerlid 
>> wrote:
>>>
>>> -1
>>>
>>> The top level pom.xml still contains a -SNAPSHOT suffix.
>>>
>>>   https://github.com/apache/cloudstack/blob/4.4-RC20140702T2107/pom.xml
>>>
>>> line 63.
>>>
>>> Removing the -SNAPSHOT suffix allows compilation.
>>>
>>> /Ove (Nitpicking)
>>>
>>>
>>>
>>>
>>> On 07/02/2014 10:18 PM, Daan Hoogland wrote:


 Hi All,

 I've created a 4.4.0 release, with the following artifacts up for a
 vote:

 Git Branch and Commit SH:


 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.4-RC20140702T2107
 Commit: 379387961bd05d1f84fe2e9a1997e9ecdceef91a

 List of changes:


 http://docs.cloudstack.apache.org/projects/cloudstack-release-notes/en/latest/

 Source release (checksums and signatures are available at the same
 location):
 https://dist.apache.org/repos/dist/dev/cloudstack/4.4.0/

 PGP release keys (signed using 4096R/AA4736F3):
 https://dist.apache.org/repos/dist/release/cloudstack/KEYS

 Vote will be open for 72 hours.

 For sanity in tallying the vote, can PMC members please be sure to
 indicate "(binding)" with their vote?

 [ ] +1  approve
 [ ] +0  no opinion
 [ ] -1  disapprove (and reason why)


 I will ad my key to the mentioned KEYS file as soon as possible,

>>>
>>>
>>> --
>>> Ove Everlid
>>> System Administrator / Architect / SDN- & Automation- & Linux-hacker
>>> Mobile: +46706668199 (dedicated work mobile)
>>> Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)
>>
>>
>>
>>
>
>
> --
> Ove Everlid
> System Administrator / Architect / SDN- & Automation- & Linux-hacker
> Mobile: +46706668199 (dedicated work mobile)
> Country: Sweden, timezone; Middle Europan Time (MET or GMT+1)



-- 
Daan