date:20150916

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/817#issuecomment-140648696
  
@borisroman not sure about the apache repo error, I'm having build failures 
when building locally due to getPreferredCharset method not avialable in 
StringUtils class (utils package). Please test locally and update the PR thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8857 listProjects doesn't retu...

2015-09-16 Thread bvbharatk

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/838#issuecomment-140649167
  
@wilderrodrigues 
this jira ticket will give some insight on how to test it.
https://issues.apache.org/jira/browse/CLOUDSTACK-8857 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/836#discussion_r39598913
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh ---
@@ -93,4 +93,16 @@ done < $cfg
 #remove the configuration file, log file should have all the records as 
well
 rm -f $cfg
 
+# Flush kernel conntrack table
+log_it "VR config: Flushing conntrack table"
+ps cax | grep conntrackd > /dev/null
+if [ $? -eq 0 ]; then
--- End diff --

instead of ps  | grep, why not use status result and start, like: 
service conntrackd status || service conntrackd start (or other commands) etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140649852
  
Forgive me for my double negative in, "Be assured that I won't :-1: on 
this.", I did mean to say that I won't stop others merging it, as @bhaisaab 
explained. I didn't +1 it myself because of my lack of understanding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/831#issuecomment-140650077
  
LGTM cc @wilderrodrigues @wido @ustcweizhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/817#issuecomment-140650340
  
Also there seems to be a license header issue (missing new line between 
header and package definition in the utils class).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/824#issuecomment-140650501
  
provided we release 4.5.3 before 4.6.0; LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/818#issuecomment-140650519
  
LGTM, @kansal can you git commit --amend the message to reflect the JIRA ID


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-140650617
  
LGTM cc @abhinandanprateek 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/813#issuecomment-140650649
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/812#issuecomment-140650851
  
LGTM, given the if conditions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-16 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/804#issuecomment-140650784
  
@bhaisaab I would say unit-tests are necessary to any software project this 
big, and with this many independent contributions. You putting the issue of 
asking for unit-tests, or not, as a matter of personal conduct was rather 
unfortunate. The people that take the time to write and run unit-tests, to 
review PRs and ask contributors to pay attention to such tests, don't do that 
out of mercilessness. They do it for the sake of the project and ultimate 
everyone that works with/in it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/813


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] stable master and 4.6 release

I agree with our esteemed RMs and want to add that it might be usefull to
mark any PR with [4.6] or [future] so it is clear to everybody what it is
intended for.

On Wed, Sep 16, 2015 at 8:17 AM, Rajani Karuturi  wrote:

> Hi all,
> There is little progress on 4.6 blockers this week. To release 4.6, we all
> should come together and fix the blockers. In recent days, master has
> broken multiple times with compilation failures/regressions. If master
> breaks, time spent on figuring out what happened and fixing it is time
> *not* spent on 4.6.
>
> Here is what we propose:
>
> 1. Only BLOCKER fixes to master. If there's something else that needs to
> get in, it can be discussed with the RMs on a case-by-case basis.
> 2. Atleast one of the reviewers of a PR should do the actual tests. We do
> not have good CI in place and travis just does simulator tests. Until we
> have a real hypervisor CI in place, manually testing the PR is a must.
> Also, LGTM(or +1) should be accompanied with whats tested and why you are
> giving LGTM.
>
> Let us all work together on getting 4.6 out.
>
> Thanks
>
> Regards from the 4.6 RMs,
> Remi and Rajani.
>
>
>
> On Thu, Sep 10, 2015 at 2:52 PM, Remi Bergsma  >
> wrote:
>
> > Hi all,
> >
> >
> > A lot of work is being done to make 4.6 ready for a release. It's great
> to
> > see it's getting better every day!
> >
> >
> > Today Rajani and myself looked at all blocker and critical issues on 4.6.
> > We decided to bump some of them to blocker. Two more issues need to
> > verified against current master. In case still broken, they will be
> marked
> > blocker as well. This means we'll have 6-8 blocker issues to resolve.
> Most
> > of them are virtual router related and we feel we cannot do a RC without
> > properly fixing them.
> >
> >
> > If you have some time, please:
> >
> >
> > Look at the 4.6 release dashboard:
> >
> >
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765
> >
> >
> > Fix one of the blockers (or critical issues):
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-8697?filter=12332940
> >
> >
> > It also helps if people help reviewing PRs:
> >
> > https://github.com/apache/cloudstack/pulls
> >
> >
> > Apart from these issues, 4.6 (aka master) is pretty stable. Feel free to
> > test-drive it and verify your key functionality.
> >
> >
> > Thanks!
> >
> >
> > Regards from the 4.6 RMs,
> >
> >
> > Rajani / Remi
> >
> >
>



-- 
Daan

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Miguel Ferreira

I totally agree with this proposal.

By the way, until there is a reliable CI build, PR reviews should always follow 
point 2.

Cheers,
\ Miguel Ferreira
   mferre...@schubergphilis.com




On 16 Sep 2015, at 08:17, Rajani Karuturi 
mailto:raj...@apache.org>> wrote:

Hi all,
There is little progress on 4.6 blockers this week. To release 4.6, we all
should come together and fix the blockers. In recent days, master has
broken multiple times with compilation failures/regressions. If master
breaks, time spent on figuring out what happened and fixing it is time
*not* spent on 4.6.

Here is what we propose:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.
2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests. Until we
have a real hypervisor CI in place, manually testing the PR is a must.
Also, LGTM(or +1) should be accompanied with whats tested and why you are
giving LGTM.

Let us all work together on getting 4.6 out.

Thanks

Regards from the 4.6 RMs,
Remi and Rajani.



On Thu, Sep 10, 2015 at 2:52 PM, Remi Bergsma 
mailto:rberg...@schubergphilis.com>>
wrote:

Hi all,


A lot of work is being done to make 4.6 ready for a release. It's great to
see it's getting better every day!


Today Rajani and myself looked at all blocker and critical issues on 4.6.
We decided to bump some of them to blocker. Two more issues need to
verified against current master. In case still broken, they will be marked
blocker as well. This means we'll have 6-8 blocker issues to resolve. Most
of them are virtual router related and we feel we cannot do a RC without
properly fixing them.


If you have some time, please:


Look at the 4.6 release dashboard:

https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765


Fix one of the blockers (or critical issues):

https://issues.apache.org/jira/browse/CLOUDSTACK-8697?filter=12332940


It also helps if people help reviewing PRs:

https://github.com/apache/cloudstack/pulls


Apart from these issues, 4.6 (aka master) is pretty stable. Feel free to
test-drive it and verify your key functionality.


Thanks!


Regards from the 4.6 RMs,


Rajani / Remi

[PROPOSAL]VMware cluster level traffic override settings design change

2015-09-16 Thread Suresh Kumar Anaparti

Hi All,

Currently, in cloudstack, the support for cluster level override settings 
(introduced in 4.2.0 with VMware DVS Integration) for guest and public traffic 
types blocks support for multiple physical networks defined in the zone for 
these traffic types over VMware deployments. It is required to support multiple 
physical networks defined in the zone for these traffic types at zone and 
cluster level(when defined) without impacting existing cluster level override 
settings. This would also fix the issue CLOUDSTACK-7151 - vmware: Type of 
vSwitch was not detected correctly while preparing public/guest virtual 
networks.

Also, renaming of vSwitch name for guest and public traffic type overridden at 
cluster in current cloudstack deployment has become troublesome, requiring 
manual update to database. This need to be addressed such that admin would be 
able to seamlessly re-name vSwitch name at cluster in Cloudstack whenever 
required, even in production cloud.

There is a design change required for existing cluster level traffic override 
settings. I'm working on the implementaton. Please take a look at the FS/Design 
details @ 
"https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+multiple+physical+networks+at+cluster+level+for+guest+traffic+over+VMware+deployments";
 and share your feedback.


Thanks,
Suresh

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/835#discussion_r39599783
  
--- Diff: 
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
 ---
@@ -115,7 +115,7 @@ public void setLocale(String locale) {
 
 public String getClientMapKey() {
 if (clientTag != null && !clientTag.isEmpty())
-return clientTag;
+return clientTag + ":" + clientHostPort;
--- End diff --

if this is really how it should be it should be in a unit test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/833


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

Hi all,

I did not say that the issues are not VR related, because they are. What I said 
was to not try fixing it by calling the bash scripts form within the python 
files.

Those changes landed on master a few months ago, or more. The thing is that 
most of us rely on the simulator and there was few people actually testing 
them. We tested a lot, as much as we could at that time, but unfortunately the 
effort did not cover all the cases.

By the way, that’s not an excuse. We just lacked support from the community 
before, which is actually being great now.

>From 6 blocker issues, 3 are VR related!

https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765

1 I already fixed, but cannot create a PR because master VPC router was broken 
after the 9th September - which by the way, I have been reporting/looking into 
since Friday.

We have 52 PRs opened and few people reviewing them, I mean, really reviewing. 
Most of the PRs haven’t been tested properly, which causes pain at the end.

Now, if we want 4.6 out, without issues, let’s work together and stop LGTM PRs 
that do not contain:

1. Jira ticket
2. Proper description of what it fixes/improves
3. Unit and/or Integration tests
4. And was tested

After 4.6 our first priority should be to get a proper CI environment that not 
only run simulator, but also KVM - at least.

my 0.20 cents

Cheers,
Wilder


On 16 Sep 2015, at 06:54, Rajani Karuturi 
mailto:rajani.karut...@citrix.com>> wrote:

I agree. Most of the blockers we see now are VR related.

~Rajani



On 16-Sep-2015, at 10:15 am, Raja Pullela 
mailto:raja.pull...@citrix.com>> wrote:

I agree with jayapal, so far none of the BVTs for the hypervisors are at 100% 
except for the simulator's.
Also, changes/refactoring some of the very core functionality such as VR should 
be thought through and thoroughly tested before being pushed as the impact will 
be huge and stabilization will take time.  At this point we are not sure what 
else is broken ???

Also, we should review/critic such changes to make sure we don't spend time on 
it later on...
Please note that Travis tests passing at 100% cannot be taken as the basis to 
think that the changes are good.

my 2cents!
Raja
-Original Message-
From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com]
Sent: Wednesday, September 16, 2015 9:46 AM
To: dev@cloudstack.apache.org
Subject: Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not 
opened in VR

Hi Wilder,

CLOUDSTACK-8843 This 
ticket is actually NOT regression. It is not implemented/tested for the basic 
zone VR.
What I have observed in the VR refactor is that sanity testing of components 
the code affects is not done.
Now we are spending time on fixing issues which were stable earlier.

Thanks,
Jayapal


On 15-Sep-2015, at 6:55 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>>
 wrote:

Hi Jayapal,

I would not suggest to move back to the sceptres, but focus on fixing and for 
every fix test it very well so we get confidence. If we start calling scripts 
com the python code it will have a huge chance to become a real mess!

Let’s stick to it and fix it and once it’s stable we can discuss a refactor of 
the thing from scratch - we already have some ideas.

The most important point is: for everyone touching Java/Python code, please 
test your changes before creating PRs or LGTM other’s committers PRs.

Cheers,
Wilder


On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>>
 wrote:

Wilder, That is true.

All these issues are because of the VR refactoring. I don’t know what are the 
unit test cases run on VR refactor code.
VR (shell) scripts  are stabilized over years and now suddenly moved to new 
implementation. What we have figured out is that this new implementation is 
done only partially. What I am suggesting now to move ahead is to call the 
existing/old shell  scripts in new implementation for configuring the VR to 
avoid spending time on unnecessary bugs.
With current implementation we may see many issues in production for some time 
to come.

Thanks,
Jayapal

On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>>
 wrote:

I have the feeling that we are fixing 1 issue and created 2.

Please, make sure the routers tests are executed and green before creating the 
PR. I will do the same.

Cheers,
Wilder


On 15 Sep 2015, at 14:23, Jayapal Reddy Uradi 
mailto:jayapalreddy.ur...@citrix.com>>
 wrote:

Assigned to myself.

Thanks,
Jayapal
On 15-Sep-2015, at 2:49 pm, Raja Pullela 
mailto:raja.pull...@citrix.com>>
 wrote:

Hi,

JIRA - ticket https://issues.apache.org/jira/browse/CLOUDSTACK-8843
Can someone please pick up th

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/806


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] stable master and 4.6 release

I just replied the other email about the VRs, where I actually mentioned the 
current mess that our github is due to the number of PRs and lack of proper 
reviews.

So, +100 for that approach! If one cannot test a PR, so do not LGTM it!

I would also add that a PR shall contain:

1. Jira ticket
2. Proper description of what it fixes/improves
3. Unit and/or Integration tests
4. And was tested by the committer!!

Although we already said that, I now feel the need to repeat it.

Cheers,
Wilder


On 16 Sep 2015, at 09:15, Miguel Ferreira 
mailto:mferre...@schubergphilis.com>> wrote:

I totally agree with this proposal.

By the way, until there is a reliable CI build, PR reviews should always follow 
point 2.

Cheers,
\ Miguel Ferreira
  
mferre...@schubergphilis.com




On 16 Sep 2015, at 08:17, Rajani Karuturi 
mailto:raj...@apache.org>> wrote:

Hi all,
There is little progress on 4.6 blockers this week. To release 4.6, we all
should come together and fix the blockers. In recent days, master has
broken multiple times with compilation failures/regressions. If master
breaks, time spent on figuring out what happened and fixing it is time
*not* spent on 4.6.

Here is what we propose:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.
2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests. Until we
have a real hypervisor CI in place, manually testing the PR is a must.
Also, LGTM(or +1) should be accompanied with whats tested and why you are
giving LGTM.

Let us all work together on getting 4.6 out.

Thanks

Regards from the 4.6 RMs,
Remi and Rajani.



On Thu, Sep 10, 2015 at 2:52 PM, Remi Bergsma 
mailto:rberg...@schubergphilis.com>>
wrote:

Hi all,


A lot of work is being done to make 4.6 ready for a release. It's great to
see it's getting better every day!


Today Rajani and myself looked at all blocker and critical issues on 4.6.
We decided to bump some of them to blocker. Two more issues need to
verified against current master. In case still broken, they will be marked
blocker as well. This means we'll have 6-8 blocker issues to resolve. Most
of them are virtual router related and we feel we cannot do a RC without
properly fixing them.


If you have some time, please:


Look at the 4.6 release dashboard:

https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765


Fix one of the blockers (or critical issues):

https://issues.apache.org/jira/browse/CLOUDSTACK-8697?filter=12332940


It also helps if people help reviewing PRs:

https://github.com/apache/cloudstack/pulls


Apart from these issues, 4.6 (aka master) is pretty stable. Feel free to
test-drive it and verify your key functionality.


Thanks!


Regards from the 4.6 RMs,


Rajani / Remi

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/799#issuecomment-140654799
  
@sudhansu7 holding merging this PR, until we've the CentOS7 files fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-16 Thread Rajani Karuturi

completely agree.
We lack dev support for fixing and testing networking issues :(


PS: I feel like there should be document in github describing contributor /
reviewer / jira guidelines

~Rajani

On Wed, Sep 16, 2015 at 12:51 PM, Wilder Rodrigues <
wrodrig...@schubergphilis.com> wrote:

> Hi all,
>
> I did not say that the issues are not VR related, because they are. What I
> said was to not try fixing it by calling the bash scripts form within the
> python files.
>
> Those changes landed on master a few months ago, or more. The thing is
> that most of us rely on the simulator and there was few people actually
> testing them. We tested a lot, as much as we could at that time, but
> unfortunately the effort did not cover all the cases.
>
> By the way, that’s not an excuse. We just lacked support from the
> community before, which is actually being great now.
>
> From 6 blocker issues, 3 are VR related!
>
> https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765
>
> 1 I already fixed, but cannot create a PR because master VPC router was
> broken after the 9th September - which by the way, I have been
> reporting/looking into since Friday.
>
> We have 52 PRs opened and few people reviewing them, I mean, really
> reviewing. Most of the PRs haven’t been tested properly, which causes pain
> at the end.
>
> Now, if we want 4.6 out, without issues, let’s work together and stop LGTM
> PRs that do not contain:
>
> 1. Jira ticket
> 2. Proper description of what it fixes/improves
> 3. Unit and/or Integration tests
> 4. And was tested
>
> After 4.6 our first priority should be to get a proper CI environment that
> not only run simulator, but also KVM - at least.
>
> my 0.20 cents
>
> Cheers,
> Wilder
>
>
> On 16 Sep 2015, at 06:54, Rajani Karuturi 
> wrote:
>
> I agree. Most of the blockers we see now are VR related.
>
> ~Rajani
>
>
>
> On 16-Sep-2015, at 10:15 am, Raja Pullela  wrote:
>
> I agree with jayapal, so far none of the BVTs for the hypervisors are at
> 100% except for the simulator's.
> Also, changes/refactoring some of the very core functionality such as VR
> should be thought through and thoroughly tested before being pushed as the
> impact will be huge and stabilization will take time.  At this point we are
> not sure what else is broken ???
>
> Also, we should review/critic such changes to make sure we don't spend
> time on it later on...
> Please note that Travis tests passing at 100% cannot be taken as the basis
> to think that the changes are good.
>
> my 2cents!
> Raja
> -Original Message-
> From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com
> ]
> Sent: Wednesday, September 16, 2015 9:46 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is
> not opened in VR
>
> Hi Wilder,
>
> CLOUDSTACK-8843
> This ticket is actually NOT regression. It is not implemented/tested for
> the basic zone VR.
> What I have observed in the VR refactor is that sanity testing of
> components the code affects is not done.
> Now we are spending time on fixing issues which were stable earlier.
>
> Thanks,
> Jayapal
>
>
> On 15-Sep-2015, at 6:55 pm, Wilder Rodrigues <
> wrodrig...@schubergphilis.com >> wrote:
>
> Hi Jayapal,
>
> I would not suggest to move back to the sceptres, but focus on fixing and
> for every fix test it very well so we get confidence. If we start calling
> scripts com the python code it will have a huge chance to become a real
> mess!
>
> Let’s stick to it and fix it and once it’s stable we can discuss a
> refactor of the thing from scratch - we already have some ideas.
>
> The most important point is: for everyone touching Java/Python code,
> please test your changes before creating PRs or LGTM other’s committers PRs.
>
> Cheers,
> Wilder
>
>
> On 15 Sep 2015, at 14:52, Jayapal Reddy Uradi <
> jayapalreddy.ur...@citrix.com >> wrote:
>
> Wilder, That is true.
>
> All these issues are because of the VR refactoring. I don’t know what are
> the unit test cases run on VR refactor code.
> VR (shell) scripts  are stabilized over years and now suddenly moved to
> new implementation. What we have figured out is that this new
> implementation is done only partially. What I am suggesting now to move
> ahead is to call the existing/old shell  scripts in new implementation for
> configuring the VR to avoid spending time on unnecessary bugs.
> With current implementation we may see many issues in production for some
> time to come.
>
> Thanks,
> Jayapal
>
> On 15-Sep-2015, at 5:57 pm, Wilder Rodrigues <
> wrodrig...@schubergphilis.com >> wrote:
>
> I have the feeling that we are fixing 1 issue and created 2.
>
> Please, make sure the routers tests are executed and green before creating
> the PR. I will do the same.
>
> Cheers,
> Wilder
>
>
> On 15 Sep 20

[DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

Ladies and gentlemen,

A ticket was entered by Rene Moser [1] on the way ACS handles missing power
state reports. His issue is that VMs ma at times be regarded as off while
they are registered as running and actually running as well. The missing
report has to be handled in some way so right now it is handled as if the
VM is down. I made a PR [2] that does minimal handling by only logging the
fact. This seems an improvement but I have no idea if it is and how to test
it.

so two questions:
- is this a blocker?
- is the ignoring after logging the appropriate way to handle this?

I would be very pleased with all and any of your opinions.

regards,

[1] https://issues.apache.org/jira/browse/CLOUDSTACK-8848
[2] https://github.com/apache/cloudstack/pull/829

-- 
Daan

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Rohit Yadav


On 16-Sep-2015, at 11:47 am, Rajani Karuturi 
mailto:raj...@apache.org>> wrote:

Here is what we propose:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.

-1 -ish
What you’re effectively saying is to freeze/block master from new changes until 
4.6.0 releases which could take anywhere from one week to many weeks. In 
reality that may be undesirable and can contribute to loss of developer 
productivity time.

Few suggestions, though I’m not sure that best way to go forward: why not 
create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively, 
create a development branch on which development can continue and we merge it 
back to master when that branch is stable enough and 4.6.0 has released?

2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests.

+1 some of us talking in the background to setup an automated QA system to use 
existing marvin tests to do long running integration tests but other than 
Travis or Jenkins (b.a.o) we don’t have anything.

Until we
have a real hypervisor CI in place, manually testing the PR is a must.
Also, LGTM(or +1) should be accompanied with whats tested and why you are
giving LGTM.

+1 at least one person other than the author should have run the PR and tested 
it manually or otherwise to increase reliance of the patch quality.

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Build failed in Jenkins: build-4.5 #528

See 

Changes:

[Rohit Yadav] CLOUDSTACK-8820: Showing error when try to add advance zone using 
VMWare ESXi 6.0 host

[Rohit Yadav] CLOUDSTACK-8820: Updated the code for vCenter6 data center 
support.

--
[...truncated 3744 lines...]
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-syslog-alerts ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-syslog-alerts ---
Running src.com.cloud.server.auth.test.AuthenticatorTest
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-syslog-alerts ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-syslog-alerts ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-snmp-alerts ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-snmp-alerts ---
[INFO] Compiling 2 source files to 

log4j:WARN No appenders could be found for logger 
(com.cloud.server.auth.SHA256SaltedUserAuthenticator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-user-authenticator-saml2 ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.956 sec

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Network VXLAN 4.5.3-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-network-vxlan ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-network-vxlan ---
Running org.apache.cloudstack.SAML2AuthManagerImplTest
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-network-vxlan ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-syslog-alerts ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-syslog-alerts ---
[INFO] Compiling 1 source file to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-network-vxlan ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-snmp-alerts ---
[INFO] Copying 2 resources
[INFO] Surefire report directory: 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-network-vxlan ---
[INFO] Compiling 1 source file to

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rohit Yadav


On 16-Sep-2015, at 1:06 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:


so two questions:
- is this a blocker?

A missing state handler is definitely a corner case, and IMO a blocker (so, for 
both 4.6.0 and future 4.5.3).

- is the ignoring after logging the appropriate way to handle this?

It may be undesirable for all cases; so either introducing another global 
setting to control logic (just log, vs update state in the db vs do any 
operation?); or simply find out if the VM is actually running (or any other 
state) just mark it as running in the DB.

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge - rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-16 Thread wilderrodrigues

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140658135
  
All,

Given the current blocker issues we have to fix on master in order to 
release 4.6.0 and the fact that those changes don't really improve the current 
code base, I will :-1:  this PR and will object if this PR gets 2 LGTMs.

@rafaelweingartner, please have a look at the dev-list in order to see the 
proposal for PRs and how they should be created.

In addition, for your students with less experience with 
Java/Eclipse/Maven/Git, try to avoid giving them such a huge task.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/812#issuecomment-140658229
  
I agree with @rafaelweingartner that this can have (and deserves) a unit 
test maybe it can even be generalized to dynamically find nic prefixes or at 
least have a list of them ourside the condition. It will make the code clearer 
and thus better maintainable


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/824#issuecomment-140659167
  
@DaanHoogland I think that will work; and also the stubs would allow 4.5.3 
users to upgrade to 4.6.0 provided there is no schema changes between 4.5.2 and 
4.6.0 (which is an assumption, of course)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/824


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-4.5 #529

See 

Changes:

[Rohit Yadav] tools/appliance: update Debian 7 iso URLs based on 615261

--
[...truncated 3676 lines...]
[INFO] Surefire report directory: 


---
 T E S T S
---
log4j:WARN No appenders could be found for logger 
(org.apache.cloudstack.server.auth.PBKDF2UserAuthenticator).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 16.883 sec

Results :

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - SNMP Alerts 4.5.3-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-snmp-alerts ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-snmp-alerts ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-plugin-example-dns-notifier ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-plugin-example-dns-notifier ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-plugin-example-dns-notifier ---
[INFO] Surefire report directory: 


---
 T E S T S
---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-snmp-alerts ---
Running src.com.cloud.server.auth.test.AuthenticatorTest
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-snmp-alerts ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-snmp-alerts ---
[INFO] Compiling 5 source files to 


Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Plugin - Syslog Alerts 4.5.3-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-syslog-alerts ---
[INFO] Deleting 

 (includes = [**/*], excludes = [])
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-plugin-syslog-alerts ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-syslog-alerts ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-syslog-alerts ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-syslog-alerts ---
[INFO] Compiling 1 source file to

Re: [PROPOSAL] stable master and 4.6 release

On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav 
wrote:

> 1. Only BLOCKER fixes to master. If there's something else that needs to
> get in, it can be discussed with the RMs on a case-by-case basis.
>
>
> -1 -ish
> What you’re effectively saying is to freeze/block master from new changes
> until 4.6.0 releases which could take anywhere from one week to many weeks.
> In reality that may be undesirable and can contribute to loss of developer
> productivity time.
>
agree and


>
> Few suggestions, though I’m not sure that best way to go forward: why not
> create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively,
> create a development branch on which development can continue and we merge
> it back to master when that branch is stable enough and 4.6.0 has released?
>
I don't feel we should create a developer branch, branching 4.6.0 now and
fixing blockers there to merge them back to master as they are fixed seems
the way to go to me.



>
> 2. Atleast one of the reviewers of a PR should do the actual tests. We do
> not have good CI in place and travis just does simulator tests.
>
>
> +1 some of us talking in the background to setup an automated QA system to
> use existing marvin tests to do long running integration tests but other
> than Travis or Jenkins (b.a.o) we don’t have anything.
>
I hate this but still +1 (CI is/should be there so we don't need this)



-- 
Daan

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Sebastien Goasguen


> On Sep 16, 2015, at 9:58 AM, Daan Hoogland  wrote:
> 
> On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav 
> wrote:
> 
>> 1. Only BLOCKER fixes to master. If there's something else that needs to
>> get in, it can be discussed with the RMs on a case-by-case basis.
>> 
>> 
>> -1 -ish
>> What you’re effectively saying is to freeze/block master from new changes
>> until 4.6.0 releases which could take anywhere from one week to many weeks.
>> In reality that may be undesirable and can contribute to loss of developer
>> productivity time.
>> 
> agree and
> 

Since we are so close to 4.6, it seems freezing it is totally legitimate.
You can keep on working on your own branch and bring master changes in as they 
are made.
Once 4.6.0 is out, you can submit your PR and merge back in master...

I don’t think this slows you down, it just delays your changes to get into 
master.

> 
>> 
>> Few suggestions, though I’m not sure that best way to go forward: why not
>> create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively,
>> create a development branch on which development can continue and we merge
>> it back to master when that branch is stable enough and 4.6.0 has released?
>> 
> I don't feel we should create a developer branch, branching 4.6.0 now and
> fixing blockers there to merge them back to master as they are fixed seems
> the way to go to me.
> 
> 
> 
>> 
>> 2. Atleast one of the reviewers of a PR should do the actual tests. We do
>> not have good CI in place and travis just does simulator tests.
>> 
>> 
>> +1 some of us talking in the background to setup an automated QA system to
>> use existing marvin tests to do long running integration tests but other
>> than Travis or Jenkins (b.a.o) we don’t have anything.
>> 
> I hate this but still +1 (CI is/should be there so we don't need this)
> 
> 
> 
> -- 
> Daan

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Rohit Yadav

Based on some discussion from slack, I think there is no harm in experimenting 
this for let’s say 2-4 weeks; at worst we would have blocked people from 
merging new features etc.

Remi/Rajani - do you think we can pull this off (fix blockers and do a 4.6.0 
release) in next 2-4 weeks?

On 16-Sep-2015, at 1:28 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:

On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>>
wrote:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.


-1 -ish
What you’re effectively saying is to freeze/block master from new changes
until 4.6.0 releases which could take anywhere from one week to many weeks.
In reality that may be undesirable and can contribute to loss of developer
productivity time.

agree and



Few suggestions, though I’m not sure that best way to go forward: why not
create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively,
create a development branch on which development can continue and we merge
it back to master when that branch is stable enough and 4.6.0 has released?

I don't feel we should create a developer branch, branching 4.6.0 now and
fixing blockers there to merge them back to master as they are fixed seems
the way to go to me.




2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests.


+1 some of us talking in the background to setup an automated QA system to
use existing marvin tests to do long running integration tests but other
than Travis or Jenkins (b.a.o) we don’t have anything.

I hate this but still +1 (CI is/should be there so we don't need this)



--
Daan

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [PROPOSAL] stable master and 4.6 release

Then we create a 4.6.0 branch, fix all of it and allow people to continue to 
merge broken code on master. Once we merge 4.6 back to master, most probably 
the 4.6 stuff won’t work anymore. I have seen it before.

I would still say +1 for the freeze and suggest that we get the contributors 
aligned on the procedures. If a contributor doesn’t have time to:

1. Jira ticket
2. Proper description of what it fixes/improves
3. Unit and/or Integration tests
4. Test the fix + other basic features

So what is the point in contributing? It brings a burden to the whole community.

If ACS wouldn’t be so tightly couple, perhaps we would care a bit less about 
the contributions that break stuff. However, when a simple change on a HyperV 
class - which is not even used in our infrastructure - breaks the hell out of 
ACS, yes.. we have to be a bit more careful about the code we get in.

When we have a proper CI in place, we can be a bit more soft on the rules.

Cheers,
Wilder



On 16 Sep 2015, at 09:38, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:


On 16-Sep-2015, at 11:47 am, Rajani Karuturi 
mailto:raj...@apache.org>> wrote:

Here is what we propose:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.

-1 -ish
What you’re effectively saying is to freeze/block master from new changes until 
4.6.0 releases which could take anywhere from one week to many weeks. In 
reality that may be undesirable and can contribute to loss of developer 
productivity time.

Few suggestions, though I’m not sure that best way to go forward: why not 
create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively, 
create a development branch on which development can continue and we merge it 
back to master when that branch is stable enough and 4.6.0 has released?

2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests.

+1 some of us talking in the background to setup an automated QA system to use 
existing marvin tests to do long running integration tests but other than 
Travis or Jenkins (b.a.o) we don’t have anything.

Until we
have a real hypervisor CI in place, manually testing the PR is a must.
Also, LGTM(or +1) should be accompanied with whats tested and why you are
giving LGTM.

+1 at least one person other than the author should have run the PR and tested 
it manually or otherwise to increase reliance of the patch quality.

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [PROPOSAL] stable master and 4.6 release

I think you are being an optimist saying 2-4 weeks but I second the
attempt. +1

On Wed, Sep 16, 2015 at 10:07 AM, Rohit Yadav 
wrote:

> Based on some discussion from slack, I think there is no harm in
> experimenting this for let’s say 2-4 weeks; at worst we would have blocked
> people from merging new features etc.
>
> Remi/Rajani - do you think we can pull this off (fix blockers and do a
> 4.6.0 release) in next 2-4 weeks?
>
> On 16-Sep-2015, at 1:28 pm, Daan Hoogland  wrote:
>
> On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav 
> wrote:
>
> 1. Only BLOCKER fixes to master. If there's something else that needs to
> get in, it can be discussed with the RMs on a case-by-case basis.
>
>
> -1 -ish
> What you’re effectively saying is to freeze/block master from new changes
> until 4.6.0 releases which could take anywhere from one week to many weeks.
> In reality that may be undesirable and can contribute to loss of developer
> productivity time.
>
> agree and
>
>
>
> Few suggestions, though I’m not sure that best way to go forward: why not
> create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively,
> create a development branch on which development can continue and we merge
> it back to master when that branch is stable enough and 4.6.0 has released?
>
> I don't feel we should create a developer branch, branching 4.6.0 now and
> fixing blockers there to merge them back to master as they are fixed seems
> the way to go to me.
> 
>
>
>
> 2. Atleast one of the reviewers of a PR should do the actual tests. We do
> not have good CI in place and travis just does simulator tests.
>
>
> +1 some of us talking in the background to setup an automated QA system to
> use existing marvin tests to do long running integration tests but other
> than Travis or Jenkins (b.a.o) we don’t have anything.
>
> I hate this but still +1 (CI is/should be there so we don't need this)
>
>
>
> --
> Daan
>
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> 
> CSForge – rapid IaaS deployment framework 
> CloudStack Consulting 
> CloudStack Software Engineering
> 
> CloudStack Infrastructure Support
> 
> CloudStack Bootcamp Training Courses
> 
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread anshul1886

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140665483
  
Currently we report only PowerOn VMs and do not report PowerOff VMs that's 
why we consider Missing and PowerOff as same And that's how whole code is 
written and each Hypervisor resource has same understanding. This will effect 
HA and many more unknown places. So please do not even consider to merge this 
change.

So Now coming to bug we can fix that by changing global setting 
pingInterval to appropriate value according to hypervisor settings which takes 
care of these transitional period of missing report here or can be handled by 
introducing gracePeriod global setting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

Currently we report only PowerOn VMs and do not report PowerOff VMs that's why 
we consider Missing and PowerOff as same And that's how most of the code is 
written for VM sync and each Hypervisor resource has same understanding. This 
will effect HA and many more unknown places. So please do not even consider to 
merge this change.

So Now coming to bug we can fix that by changing global setting pingInterval to 
appropriate value according to hypervisor settings which takes care of these 
transitional period of missing report here or can be handled by introducing 
gracePeriod global setting.

Regards,
Anshul

On 16-Sep-2015, at 1:11 PM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>> wrote:


On 16-Sep-2015, at 1:06 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:


so two questions:
- is this a blocker?

A missing state handler is definitely a corner case, and IMO a blocker (so, for 
both 4.6.0 and future 4.5.3).

- is the ignoring after logging the appropriate way to handle this?

It may be undesirable for all cases; so either introducing another global 
setting to control logic (just log, vs update state in the db vs do any 
operation?); or simply find out if the VM is actually running (or any other 
state) just mark it as running in the DB.

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

On Wed, Sep 16, 2015 at 10:17 AM, Anshul Gangwar 
wrote:

> Currently we report only PowerOn VMs and do not report PowerOff VMs that's
> why we consider Missing and PowerOff as same

This is not the behavior reported in the ticket. It is intermittend.


> And that's how most of the code is written for VM sync and each Hypervisor
> resource has same understanding. This will effect HA and many more unknown
> places. So please do not even consider to merge this change.
>
sure, I will hold. We do need to not regard a missing report the same as
power off however.



> So Now coming to bug we can fix that by changing global setting
> pingInterval to appropriate value according to hypervisor settings which
> takes care of these transitional period of missing report here or can be
> handled by introducing gracePeriod global setting.
>
I can see what you are talking about but not what you are saying here. Do
you mean that we need to keep track of ping interval and grace period in
the statemachine for a particular VM?



>
> Regards,
> Anshul
>
> On 16-Sep-2015, at 1:11 PM, Rohit Yadav  rohit.ya...@shapeblue.com>> wrote:
>
>
> On 16-Sep-2015, at 1:06 pm, Daan Hoogland  daan.hoogl...@gmail.com>> wrote:
>
>
> so two questions:
> - is this a blocker?
>
> A missing state handler is definitely a corner case, and IMO a blocker
> (so, for both 4.6.0 and future 4.5.3).
>
> - is the ignoring after logging the appropriate way to handle this?
>
> It may be undesirable for all cases; so either introducing another global
> setting to control logic (just log, vs update state in the db vs do any
> operation?); or simply find out if the VM is actually running (or any other
> state) just mark it as running in the DB.
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
>
>
>
>
> M. +91 88 262 30892 | rohit.ya...@shapeblue.com rohit.ya...@shapeblue.com>
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Software Engineering<
> http://shapeblue.com/cloudstack-software-engineering/>
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>
>


-- 
Daan

Re: VPC router issue

Thanks for the effort, Raja!

I’m testing other PRs trying to find where the problem was introduced. Will 
keep you posted.

Cheers,
Wilder

On 16 Sep 2015, at 06:35, Raja Pullela 
mailto:raja.pull...@citrix.com>> wrote:

Hi Wilder,   BTW, I just checked my setup and it was passing on Sep 9th and was 
regressed after that.

Thanks for checking this out,
Raja
-Original Message-
From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com]
Sent: Tuesday, September 15, 2015 7:12 PM
To: dev@cloudstack.apache.org
Cc: Remi Bergsma 
mailto:rberg...@schubergphilis.com>>; Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>>; Rajani Karuturi 
mailto:raj...@apache.org>>; Daan Hoogland 
mailto:daan.hoogl...@gmail.com>>
Subject: Re: VPC router issue

6 days ago test_pc_routers.py succeeded with  PR 788:

https://github.com/apache/cloudstack/pull/788

It’s in the test results I put there.

I’m now testing Master to verify if it’s still occurring there. I tested the PR 
#808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
tests executed against, but not the test_vpc_routers, and there it fails.

So, the problem occurred between 788 and 805.

Will keep digging.

Cheers,
Wilder


On 15 Sep 2015, at 14:18, Wilder Rodrigues 
mailto:wrodrig...@schubergphilis.com>>
 wrote:

Hi all,

This morning I shared a message on our Slack channel about the current issue 
I’m facing with VPC routers. The problem was caught by the test_vpc_routers.py 
tests, which are unable to verify the following:

* Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
* Stop the VPC router
* Start the VPC router

I have been busy trying to figure out when it stopped working when I then 
stopped at commit 
https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
 - although it’s not really the one causing the issue given what I have changed 
there.

The only way to get it working is by restarting the VPC with the cleanup option 
- os destroying the VPC router and just restarting the VPC.

Since not many people have been testing the routers as much as I do, it seems 
no one is aware of this issue.

Long story short: current master is broken.

/me digging through PRs to find the root cause.

Cheers,
Wilder

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/831#issuecomment-140669424
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

2015-09-16 Thread bvbharatk

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/839

CLOUDSTACK-8851 Redundant VR getting started in the same cluster or hâ¦

we are not populating the deployment destination of the previous rvr in the 
avoid set of the rvr that is being created. This was resulting in both the rvrs 
getting deployed to same host sometimes even when it 
could have gone to a different one.

Now we are updating the avoids set of the deployment plan  to fix this 
issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-8851

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/839.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #839


commit 7439a9bbec6cd9f7b61ab2035eaf668c9408f674
Author: Bharat Kumar 
Date:   2015-09-15T08:54:13Z

CLOUDSTACK-8851 Redundant VR getting started in the same cluster or host 
even when there are suitable hosts available




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

2015-09-16 Thread bvbharatk

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/840

CLOUDSTACK-8852 Database shows that management server is UP when it iâ¦

â¦s actually stopped from the CCP GUI

This was happening as the stop method in clusterMnanagerImpl was not 
getting callled. Added shutdown hooks to all sub contexts,
this enables spring to call the stop mehtods of the beans when 
management server is shutting down.

Conflicts:

framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-8852

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/840.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #840


commit 17a5d29b7008971cd7de963aa5a8db9f6cd3bd65
Author: Bharat Kumar 
Date:   2015-04-21T11:15:12Z

CLOUDSTACK-8852 Database shows that management server is UP when it is 
actually stopped from the CCP GUI

This was happening as the stop method in clusterMnanagerImpl was not 
getting callled. Added shutdown hooks to all sub contexts,
this enables spring to call the stop mehtods of the beans when 
management server is shutting down.

Conflicts:

framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/web/CloudStackContextLoaderListener.java




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: VPC router issue

2015-09-16 Thread Rajani Karuturi

Raja,
Do you know the commit ids between the last successful and first failed builds?

~Rajani



On 16-Sep-2015, at 10:05 am, Raja Pullela  wrote:

> Hi Wilder,   BTW, I just checked my setup and it was passing on Sep 9th and 
> was regressed after that.
> 
> Thanks for checking this out,
> Raja
> -Original Message-
> From: Wilder Rodrigues [mailto:wrodrig...@schubergphilis.com] 
> Sent: Tuesday, September 15, 2015 7:12 PM
> To: dev@cloudstack.apache.org
> Cc: Remi Bergsma ; Rohit Yadav 
> ; Rajani Karuturi ; Daan 
> Hoogland 
> Subject: Re: VPC router issue
> 
> 6 days ago test_pc_routers.py succeeded with  PR 788:
> 
> https://github.com/apache/cloudstack/pull/788
> 
> It’s in the test results I put there.
> 
> I’m now testing Master to verify if it’s still occurring there. I tested the 
> PR #808 (https://github.com/apache/cloudstack/pull/805), which had a bunch of 
> tests executed against, but not the test_vpc_routers, and there it fails.
> 
> So, the problem occurred between 788 and 805.
> 
> Will keep digging.
> 
> Cheers,
> Wilder
> 
> 
> On 15 Sep 2015, at 14:18, Wilder Rodrigues 
> mailto:wrodrig...@schubergphilis.com>> wrote:
> 
> Hi all,
> 
> This morning I shared a message on our Slack channel about the current issue 
> I’m facing with VPC routers. The problem was caught by the 
> test_vpc_routers.py tests, which are unable to verify the following:
> 
> * Create a VPC with 2 Tiers, 3 VMs, 2Pub IPs, and 1 ACL
> * Stop the VPC router
> * Start the VPC router
> 
> I have been busy trying to figure out when it stopped working when I then 
> stopped at commit 
> https://github.com/apache/cloudstack/commit/f5e5f4d0026f8ffd6f3aa7e8e4c7be0cd809d6c9
>  - although it’s not really the one causing the issue given what I have 
> changed there.
> 
> The only way to get it working is by restarting the VPC with the cleanup 
> option - os destroying the VPC router and just restarting the VPC.
> 
> Since not many people have been testing the routers as much as I do, it seems 
> no one is aware of this issue.
> 
> Long story short: current master is broken.
> 
> /me digging through PRs to find the root cause.
> 
> Cheers,
> Wilder
>

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140675073
  
@remibergsma @bhaisaab Could you take a look? It's almost similar to the 
Agent systemd profile :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140675342
  
@wido looks similar so looking at the changes LGTM, but I lack infra and 
time to test it out right now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

Please find my answers inline

Regards,
Anshul

On 16-Sep-2015, at 1:53 PM, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:

On Wed, Sep 16, 2015 at 10:17 AM, Anshul Gangwar 
mailto:anshul.gang...@citrix.com>>
wrote:

Currently we report only PowerOn VMs and do not report PowerOff VMs that's
why we consider Missing and PowerOff as same

This is not the behavior reported in the ticket. It is intermittent.

[Anshul] Your PR is changing this behaviour. It is intermittent because of the 
ping interval.


And that's how most of the code is written for VM sync and each Hypervisor
resource has same understanding. This will effect HA and many more unknown
places. So please do not even consider to merge this change.

sure, I will hold. We do need to not regard a missing report the same as
power off however.

[Anshul] Initially this was the case that PowerOff and PowerResportMissing 
states were different but later when many issues were reported in vmSync it 
makes more sense to consider PowerReportMissing and PowerOff as same.
So if you are thinking of considering these states to be different then make 
sure you have considered all these scenarios and tested it on every Hypervisor 
that we support as each Hypervisor reports states according to this 
understanding.

Kaushik can give a better understanding around this.




So Now coming to bug we can fix that by changing global setting
pingInterval to appropriate value according to hypervisor settings which
takes care of these transitional period of missing report here or can be
handled by introducing gracePeriod global setting.

I can see what you are talking about but not what you are saying here. Do
you mean that we need to keep track of ping interval and grace period in
the statemachine for a particular VM?

[Anshul] Here I am just talking about changing global setting “ping.interval” 
value or adding one more global setting for grace period to get more finer 
control for these kind of scenarios.






Regards,
Anshul

On 16-Sep-2015, at 1:11 PM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>mailto:rohit.ya...@shapeblue.com>>> wrote:


On 16-Sep-2015, at 1:06 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>mailto:daan.hoogl...@gmail.com>>> wrote:


so two questions:
- is this a blocker?

A missing state handler is definitely a corner case, and IMO a blocker
(so, for both 4.6.0 and future 4.5.3).

- is the ignoring after logging the appropriate way to handle this?

It may be undesirable for all cases; so either introducing another global
setting to control logic (just log, vs update state in the db vs do any
operation?); or simply find out if the VM is actually running (or any other
state) just mark it as running in the DB.

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | 
rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com>>
Blog: bhaisaab.org | Twitter: 
@_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build<
http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software Engineering<
http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<
http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<
http://shapeblue.com/cloudstack-training/>

This email and any attachments to it may be confidential and are intended
solely for the use of the individual to whom it is addressed. Any views or
opinions expressed are solely those of the author and do not necessarily
represent those of Shape Blue Ltd or related companies. If you are not the
intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender
if you believe you have received this email in error. Shape Blue Ltd is a
company incorporated in England & Wales. ShapeBlue Services India LLP is a
company incorporated in India and is operated under license from Shape Blue
Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
a company registered by The Republic of South Africa and is traded under
license from Shape Blue Ltd. ShapeBlue is a registered trademark.




--
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140676140
  
@bhaisaab Tnx! I tested it on a CentOS 7 system:

```
[root@vm-d818122e-51ca-479f-9618-051b4eed7c10 system]# systemctl status 
cloudstack-usage
cloudstack-usage.service - CloudStack Usage Server
   Loaded: loaded (/etc/systemd/system/cloudstack-usage.service; disabled)
   Active: active (running) since wo 2015-09-16 10:38:48 CEST; 3s ago
 Docs: http://www.cloudstack.org/
 Main PID: 2492 (sh)
   CGroup: /system.slice/cloudstack-usage.service
```

@remibergsma Can you verify if the packages now build properly? I would 
love to get this into 4.6 so that we are systemdified :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/841

Cloudstack 8868: use PasswordGenerator.generateRandomPassword() to generate 
systemvm passwords

generateRandomPassword() is supposed to create root user passwords. Right 
now it is only used on the guest VMs. The format of the passwords it creates 
are of the form "random 3-character string with a lowercase character, 
uppercase character, and a digit" + random n-character string with only 
lowercase characters".

For whatever reason it was that we use generateRandomPassword() for guest 
VM root user passwords(maybe more secure?) we should use the same function for 
system VM root user passwords.

Tests:
manually tested that password is generated in proper format and am able to 
login to cpvm with the new password. ex: zD2ztm, tR8snbwhq

```
$ mvn -pl server test 
-Dtest=ConfigurationServerImplTest#testUpdateSystemvmPassword
---
 T E S T S
---
Running com.cloud.server.ConfigurationServerImplTest
log4j:WARN No appenders could be found for logger 
(com.cloud.utils.crypt.EncryptionSecretKeyChecker).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.487 sec - 
in com.cloud.server.ConfigurationServerImplTest

Results :

Tests run: 1, Failures: 0, Errors: 0, Skipped: 0

[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 7.781 s
[INFO] Finished at: 2015-09-16T14:17:07+05:30
[INFO] Final Memory: 60M/466M
[INFO] 

```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuturi/cloudstack CLOUDSTACK-8868

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #841


commit c2e36f2bb96070b5ff30fe7dbf1417ecb720b817
Author: Rajani Karuturi 
Date:   2015-09-16T06:58:03Z

CLOUDSTACK-8868: use same method to generate passwords for system/guest vms

generateRandomPassword() is supposed to create root user passwords.
Right now it is only used on the guest VMs. The format of the passwords
it creates are of the form "random 3-character string with a lowercase
character, uppercase character, and a digit" + random n-character string
with only lowercase characters".

For whatever reason it was that we use generateRandomPassword() for
guest VM root user passwords(maybe more secure?) we should use the same
function for system VM root user passwords.

commit 4a6af1b6e368d773a26fced5ca4f7486c03bf873
Author: Rajani Karuturi 
Date:   2015-09-16T07:04:49Z

removed commented code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Remi Bergsma

If we all go for it, fix the blocker issues and test 4.6, then we should be 
able to do it! The CCCEU conference is in ~4 weeks, seems like a great deadline 
to work towards. But again, we all need to work together to make it happen.

Let’s not forget that making master stable is hard. Just as hard as it used to 
be in a release branch. Once we achieve a stable master, we need to keep it 
that wat which means we need to improve Travis and Jenkins so that at PR review 
time we get the right feedback from the automated systems. Until that is in 
place, we should be extra careful and show each other how things are tested and 
reviewed. Once master is stable and 4.6 is out, merging new features and 
prepping 4.7 should be a lot easier.

Let’s focus on 4.6 and make it a great release!

Regards,
Remi



From: Rohit Yadav
Reply-To: "dev@cloudstack.apache.org"
Date: Wednesday 16 September 2015 10:07
To: "dev@cloudstack.apache.org"
Subject: Re: [PROPOSAL] stable master and 4.6 release

Based on some discussion from slack, I think there is no harm in experimenting 
this for let’s say 2-4 weeks; at worst we would have blocked people from 
merging new features etc.

Remi/Rajani - do you think we can pull this off (fix blockers and do a 4.6.0 
release) in next 2-4 weeks?

On 16-Sep-2015, at 1:28 pm, Daan Hoogland 
mailto:daan.hoogl...@gmail.com>> wrote:

On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav 
mailto:rohit.ya...@shapeblue.com>>
wrote:

1. Only BLOCKER fixes to master. If there's something else that needs to
get in, it can be discussed with the RMs on a case-by-case basis.


-1 -ish
What you’re effectively saying is to freeze/block master from new changes
until 4.6.0 releases which could take anywhere from one week to many weeks.
In reality that may be undesirable and can contribute to loss of developer
productivity time.

agree and



Few suggestions, though I’m not sure that best way to go forward: why not
create a 4.6 branch and merge it back when 4.6.0 releases? Alternatively,
create a development branch on which development can continue and we merge
it back to master when that branch is stable enough and 4.6.0 has released?

I don't feel we should create a developer branch, branching 4.6.0 now and
fixing blockers there to merge them back to master as they are fixed seems
the way to go to me.




2. Atleast one of the reviewers of a PR should do the actual tests. We do
not have good CI in place and travis just does simulator tests.


+1 some of us talking in the background to setup an automated QA system to
use existing marvin tests to do long running integration tests but other
than Travis or Jenkins (b.a.o) we don’t have anything.

I hate this but still +1 (CI is/should be there so we don't need this)



--
Daan

Regards,
Rohit Yadav
Software Architect, ShapeBlue


[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]


M. +91 88 262 30892 | 
rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab




Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Software 
Engineering
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140678150
  
@wido Sure, will do my tests again today!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rene Moser

Hi René

On 09/16/2015 10:17 AM, Anshul Gangwar wrote:
> Currently we report only PowerOn VMs and do not report PowerOff VMs that's 
> why we consider Missing and PowerOff as same And that's how most of the code 
> is written for VM sync and each Hypervisor resource has same understanding. 
> This will effect HA and many more unknown places. So please do not even 
> consider to merge this change.
> 
> So Now coming to bug we can fix that by changing global setting pingInterval 
> to appropriate value according to hypervisor settings which takes care of 
> these transitional period of missing report here or can be handled by 
> introducing gracePeriod global setting.

This is interesting, I also wrote in the bug report gracePeriod
calculation might be related.
https://github.com/apache/cloudstack/blob/4.5.2/engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L110.

IMHO making this value configurable would might solve it, but it is hard
to "guess" what a good grace period would be.

In terms of VMware it depends on amounts of esx in the clusters, and
they can be different.

But another question is, why make one _global_ grace period for every
hypervisor. Think about, users can have mixed hypervisors setups.

So to me, a global grace period setting might not be the best solution,
instead we should take care hypervisor functionality, in this case
VMware, it handels HA by itself.

I know a VR in 4.5 would be broken after an VMware HA event, but there
is another global setting, which can be enabled if you like for out of
band migrations router restarts.

So to me, in 4.5 I am +1 for the patch of daan makes sense, if
hypervisor is VMware.

Yours
René

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/841#issuecomment-140684521
  
I think the PasswordGenerator.generateRandomPassword (from utils) is not 
secure at all for small lengths (such as the default 6), since it's not really 
random ("random 3-character string with a lowercase character, uppercase 
character, and a digit" + random n-character string with only lowercase 
characters") and one could create a rainbow table to attempt to get into 
systemvms. In case of uservms, it is advised to change the password; but in 
case of systemvms it will be an issue. In case of systemvms, may be we can 
still directly use the PasswordGenerator util but increase the length to 24 or 
32 or 24+rand integer?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-16 Thread SudharmaJain

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/836#issuecomment-140687549
  
@bhaisaab, using service conntrackd status don't provide the status and 
always gives the usage information for conntrackd. So i have added the changes 
by starting conntrackd in deamon mode with (-d) switch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

It’s not difficult to find a good grace period. It will simply depend on your 
Hypervisor settings how it is configured for HA. You can easily figure out for 
how much time there will be no VM on any Host from your settings and simply put 
2-3 times of that period as grace period.

It seems you have considered only one aspect of change i.e. User VMs HA. 
Did you consider System VMs HA? 
Did you consider that we have already explored that territory of separate 
handling of PowerOff and PowerReportMissing?

And even if you are still thinking of this change then add marvin tests for 
this change. Unit tests will not tell anything about the change.

Regards,
Anshul

> On 16-Sep-2015, at 2:48 PM, Rene Moser  wrote:
> 
> 
> Hi René
> 
> On 09/16/2015 10:17 AM, Anshul Gangwar wrote:
>> Currently we report only PowerOn VMs and do not report PowerOff VMs that's 
>> why we consider Missing and PowerOff as same And that's how most of the code 
>> is written for VM sync and each Hypervisor resource has same understanding. 
>> This will effect HA and many more unknown places. So please do not even 
>> consider to merge this change.
>> 
>> So Now coming to bug we can fix that by changing global setting pingInterval 
>> to appropriate value according to hypervisor settings which takes care of 
>> these transitional period of missing report here or can be handled by 
>> introducing gracePeriod global setting.
> 
> This is interesting, I also wrote in the bug report gracePeriod
> calculation might be related.
> https://github.com/apache/cloudstack/blob/4.5.2/engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L110.
> 
> IMHO making this value configurable would might solve it, but it is hard
> to "guess" what a good grace period would be.
> 
> In terms of VMware it depends on amounts of esx in the clusters, and
> they can be different.
> 
> But another question is, why make one _global_ grace period for every
> hypervisor. Think about, users can have mixed hypervisors setups.
> 
> So to me, a global grace period setting might not be the best solution,
> instead we should take care hypervisor functionality, in this case
> VMware, it handels HA by itself.
> 
> I know a VR in 4.5 would be broken after an VMware HA event, but there
> is another global setting, which can be enabled if you like for out of
> band migrations router restarts.
> 
> So to me, in 4.5 I am +1 for the patch of daan makes sense, if
> hypervisor is VMware.
> 
> Yours
> René
>

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/842

CLOUDSTACK-8843: Fixed issue in default iptables rules on shared network VR

On basic zone share network VR default iptables rules are not applied 
correctly. Due to this ssh to VR got failed.
In shared network the VR type is 'dhcpsrvr' not router. So corrected it in 
the ''del_standard' method to select the correct type.

Testing:
1. VR is deployed correctly.
2. Tested restart, stop, start VR.
3. New VM deployment is success.
4. ssh to VR from the host is successful.
5. iptables rules on the VR came up correctly.
below is the output from the VR:
iptables -L INPUT -nv
Chain INPUT (policy DROP 16 packets, 1056 bytes)
 pkts bytes target prot opt in out source   
destination
0 0 ACCEPT all  --  *  *   0.0.0.0/0
224.0.0.18
0 0 ACCEPT all  --  *  *   0.0.0.0/0
225.0.0.50
  104  9800 ACCEPT all  --  eth0   *   0.0.0.0/0
0.0.0.0/0state RELATED,ESTABLISHED
  281 36500 ACCEPT all  --  eth1   *   0.0.0.0/0
0.0.0.0/0state RELATED,ESTABLISHED
0 0 ACCEPT all  --  eth2   *   0.0.0.0/0
0.0.0.0/0state RELATED,ESTABLISHED
6   504 ACCEPT icmp --  *  *   0.0.0.0/0
0.0.0.0/0
0 0 ACCEPT all  --  lo *   0.0.0.0/0
0.0.0.0/0
2   656 ACCEPT udp  --  eth0   *   0.0.0.0/0
0.0.0.0/0udp dpt:67
   13   780 ACCEPT tcp  --  eth1   *   0.0.0.0/0
0.0.0.0/0tcp dpt:3922 state NEW,ESTABLISHED
0 0 ACCEPT tcp  --  eth0   *   0.0.0.0/0
0.0.0.0/0tcp dpt:80 state NEW
0 0 ACCEPT tcp  --  eth0   *   10.147.40.0/23   
0.0.0.0/0state NEW tcp dpt:8080

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayapalu/cloudstack shareNwVR

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/842.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #842


commit a15df0569fa0e56b14a9a119858c53e8ae6085c3
Author: Jayapal 
Date:   2015-09-16T09:52:33Z

CLOUDSTACK-8843: Fixed issue in default iptables rules on shared network VR




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

On Wed, Sep 16, 2015 at 11:46 AM, Anshul Gangwar 
wrote:

> It’s not difficult to find a good grace period. It will simply depend on
> your Hypervisor settings how it is configured for HA. You can easily figure
> out for how much time there will be no VM on any Host from your settings
> and simply put 2-3 times of that period as grace period.
>
That seems kludgey.



> It seems you have considered only one aspect of change i.e. User VMs HA.
> Did you consider System VMs HA?
> Did you consider that we have already explored that territory of separate
> handling of PowerOff and PowerReportMissing?
>
for VMware or for all hypervisors? Do you have a link to the discussion?
These states are different.

Why was it decided to treat them the same?


> And even if you are still thinking of this change then add marvin tests
> for this change. Unit tests will not tell anything about the change.
>
Yes, that I definitely agree on.



> Regards,
> Anshul
>
> > On 16-Sep-2015, at 2:48 PM, Rene Moser  wrote:
> >
> >
> > Hi René
> >
> > On 09/16/2015 10:17 AM, Anshul Gangwar wrote:
> >> Currently we report only PowerOn VMs and do not report PowerOff VMs
> that's why we consider Missing and PowerOff as same And that's how most of
> the code is written for VM sync and each Hypervisor resource has same
> understanding. This will effect HA and many more unknown places. So please
> do not even consider to merge this change.
> >>
> >> So Now coming to bug we can fix that by changing global setting
> pingInterval to appropriate value according to hypervisor settings which
> takes care of these transitional period of missing report here or can be
> handled by introducing gracePeriod global setting.
> >
> > This is interesting, I also wrote in the bug report gracePeriod
> > calculation might be related.
> >
> https://github.com/apache/cloudstack/blob/4.5.2/engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L110
> .
> >
> > IMHO making this value configurable would might solve it, but it is hard
> > to "guess" what a good grace period would be.
> >
> > In terms of VMware it depends on amounts of esx in the clusters, and
> > they can be different.
> >
> > But another question is, why make one _global_ grace period for every
> > hypervisor. Think about, users can have mixed hypervisors setups.
> >
> > So to me, a global grace period setting might not be the best solution,
> > instead we should take care hypervisor functionality, in this case
> > VMware, it handels HA by itself.
> >
> > I know a VR in 4.5 would be broken after an VMware HA event, but there
> > is another global setting, which can be enabled if you like for out of
> > band migrations router restarts.
> >
> > So to me, in 4.5 I am +1 for the patch of daan makes sense, if
> > hypervisor is VMware.
> >
> > Yours
> > René
> >
>
>


-- 
Daan

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/841#issuecomment-140696212
  
should we add another global setting for systemvm password length (like 
vm.password.length for uservms) and use it to generate systemvm passwords?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

I don’t think there was any discussion around this. Kelven have made fixes
around VMSync. So to find details look into FS
https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+VMSync+improvement .

Regards,
Anshul

On 16-Sep-2015, at 3:32 PM, Daan Hoogland
mailto:daan.hoogl...@gmail.com>> wrote:

On Wed, Sep 16, 2015 at 11:46 AM, Anshul Gangwar
mailto:anshul.gang...@citrix.com>>
wrote:

It’s not difficult to find a good grace period. It will simply depend on
your Hypervisor settings how it is configured for HA. You can easily figure
out for how much time there will be no VM on any Host from your settings
and simply put 2-3 times of that period as grace period.

That seems kludgey.

It seems you have considered only one aspect of change i.e. User VMs HA.
Did you consider System VMs HA?
Did you consider that we have already explored that territory of separate
handling of PowerOff and PowerReportMissing?

for VMware or for all hypervisors? Do you have a link to the discussion?
These states are different.

Why was it decided to treat them the same?

And even if you are still thinking of this change then add marvin tests
for this change. Unit tests will not tell anything about the change.

Yes, that I definitely agree on.

Regards,
Anshul

On 16-Sep-2015, at 2:48 PM, Rene Moser
mailto:m...@renemoser.net>> wrote:

Hi René

On 09/16/2015 10:17 AM, Anshul Gangwar wrote:
Currently we report only PowerOn VMs and do not report PowerOff VMs
that's why we consider Missing and PowerOff as same And that's how most of
the code is written for VM sync and each Hypervisor resource has same
understanding. This will effect HA and many more unknown places. So please
do not even consider to merge this change.

So Now coming to bug we can fix that by changing global setting
pingInterval to appropriate value according to hypervisor settings which
takes care of these transitional period of missing report here or can be
handled by introducing gracePeriod global setting.

This is interesting, I also wrote in the bug report gracePeriod
calculation might be related.

https://github.com/apache/cloudstack/blob/4.5.2/engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java#L110
.

IMHO making this value configurable would might solve it, but it is hard
to "guess" what a good grace period would be.

In terms of VMware it depends on amounts of esx in the clusters, and
they can be different.

But another question is, why make one _global_ grace period for every
hypervisor. Think about, users can have mixed hypervisors setups.

So to me, a global grace period setting might not be the best solution,
instead we should take care hypervisor functionality, in this case
VMware, it handels HA by itself.

I know a VR in 4.5 would be broken after an VMware HA event, but there
is another global setting, which can be enabled if you like for out of
band migrations router restarts.

So to me, in 4.5 I am +1 for the patch of daan makes sense, if
hypervisor is VMware.

Yours
René

--
Daan

Build failed in Jenkins: build-systemvm-master #626

See 

Changes:

[sureshkumar.anaparti] CLOUDSTACK-8820: Showing error when try to add advance 
zone using VMWare ESXi 6.0 host

[wido] CLOUDSTACK-8625: Systemd profile for CloudStack Agent

[wido] CLOUDSTACK-8443: Install the systemd wrapper script in RPM

[wido] CLOUDSTACK-8625: Updated spec file for systemd profile

[sureshkumar.anaparti] CLOUDSTACK-8820: Updated the code for vCenter6 data 
center support.

[wido] CLOUDSTACK-8625: Remove the need of a wrapper script for the Agent

[Rajani Karuturi] changed the base iso file from debian-7.8.0 to debian-7.9.0

[Rohit Yadav] schema: add 4.5.2 to 4.5.3 upgrade path stubs

[Rohit Yadav] schema: add 4.5.3 to 4.6.0 upgrade path stubs

[Rohit Yadav] changed the base iso file from debian-7.8.0 to debian-7.9.0

[Rohit Yadav] Revert "changed the base iso file from debian-7.8.0 to 
debian-7.9.0"

--
[...truncated 5951 lines...]
+ local level=INFO
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:34:56] INFO: systemvmtemplate exported for HyperV: 
dist/systemvmtemplate-master-4.6.0-hyperv.vhd.zip'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:34:56] INFO: systemvmtemplate exported for HyperV: 
dist/systemvmtemplate-master-4.6.0-hyperv.vhd.zip'
[2015-09-16 10:34:56] INFO: systemvmtemplate exported for HyperV: 
dist/systemvmtemplate-master-4.6.0-hyperv.vhd.zip
+ md5sum dist/systemvmtemplate-master-4.6.0.box 
dist/systemvmtemplate-master-4.6.0-hyperv.vhd.zip 
dist/systemvmtemplate-master-4.6.0-kvm.qcow2.bz2 
dist/systemvmtemplate-master-4.6.0-ovm.raw.bz2 
dist/systemvmtemplate-master-4.6.0-vmware.ova 
dist/systemvmtemplate-master-4.6.0-vmware.vmdk.bz2 
dist/systemvmtemplate-master-4.6.0-xen.vhd.bz2
+ add_on_exit log INFO 'BUILD SUCCESSFUL'
+ local n=9
+ on_exit_items[${n}]='log INFO BUILD SUCCESSFUL'
+ '[' 9 -eq 0 ']'
+ on_exit
+ (( i=10-1  ))
+ (( i>=0  ))
+ sleep 2
+ log DEBUG 'on_exit: log INFO BUILD SUCCESSFUL'
+ local level=DEBUG
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:35:07] DEBUG: on_exit: log INFO BUILD SUCCESSFUL'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:35:07] DEBUG: on_exit: log INFO BUILD SUCCESSFUL'
[2015-09-16 10:35:07] DEBUG: on_exit: log INFO BUILD SUCCESSFUL
+ eval log INFO BUILD SUCCESSFUL
++ log INFO BUILD SUCCESSFUL
++ local level=INFO
++ shift
++ [[ 1 != \1 ]]
++ local code=
+++ date '+%F %T'
++ local 'line=[2015-09-16 10:35:07] INFO: BUILD SUCCESSFUL'
++ '[' -t 2 ']'
++ echo '[2015-09-16 10:35:07] INFO: BUILD SUCCESSFUL'
[2015-09-16 10:35:07] INFO: BUILD SUCCESSFUL
+ (( i--  ))
+ (( i>=0  ))
+ sleep 2
+ log DEBUG 'on_exit: rm systemvmtemplate-master-4.6.0-hyperv.vhd'
+ local level=DEBUG
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:35:09] DEBUG: on_exit: rm 
systemvmtemplate-master-4.6.0-hyperv.vhd'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:35:09] DEBUG: on_exit: rm 
systemvmtemplate-master-4.6.0-hyperv.vhd'
[2015-09-16 10:35:09] DEBUG: on_exit: rm 
systemvmtemplate-master-4.6.0-hyperv.vhd
+ eval rm systemvmtemplate-master-4.6.0-hyperv.vhd
++ rm systemvmtemplate-master-4.6.0-hyperv.vhd
+ (( i--  ))
+ (( i>=0  ))
+ sleep 2
+ log DEBUG 'on_exit: rm -f systemvmtemplate-master-4.6.0-vmware.ovf-orig'
+ local level=DEBUG
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:35:11] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf-orig'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:35:11] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf-orig'
[2015-09-16 10:35:11] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf-orig
+ eval rm -f systemvmtemplate-master-4.6.0-vmware.ovf-orig
++ rm -f systemvmtemplate-master-4.6.0-vmware.ovf-orig
+ (( i--  ))
+ (( i>=0  ))
+ sleep 2
+ log DEBUG 'on_exit: rm -f systemvmtemplate-master-4.6.0-vmware-disk3.vmdk'
+ local level=DEBUG
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:35:13] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware-disk3.vmdk'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:35:13] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware-disk3.vmdk'
[2015-09-16 10:35:13] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware-disk3.vmdk
+ eval rm -f systemvmtemplate-master-4.6.0-vmware-disk3.vmdk
++ rm -f systemvmtemplate-master-4.6.0-vmware-disk3.vmdk
+ (( i--  ))
+ (( i>=0  ))
+ sleep 2
+ log DEBUG 'on_exit: rm -f systemvmtemplate-master-4.6.0-vmware.ovf'
+ local level=DEBUG
+ shift
+ [[ 1 != \1 ]]
+ local code=
++ date '+%F %T'
+ local 'line=[2015-09-16 10:35:15] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf'
+ '[' -t 2 ']'
+ echo '[2015-09-16 10:35:15] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf'
[2015-09-16 10:35:15] DEBUG: on_exit: rm -f 
systemvmtemplate-master-4.6.0-vmware.ovf
+ eval rm -f systemvmtemplate-master-4.6.0-vmware.ovf
++ rm -f systemvmte

Build failed in Jenkins: build-master-slowbuild #2320

See 

Changes:

[sureshkumar.anaparti] CLOUDSTACK-8820: Showing error when try to add advance 
zone using VMWare ESXi 6.0 host

[wido] CLOUDSTACK-8625: Systemd profile for CloudStack Agent

[wido] CLOUDSTACK-8443: Install the systemd wrapper script in RPM

[wido] CLOUDSTACK-8625: Updated spec file for systemd profile

[sureshkumar.anaparti] CLOUDSTACK-8820: Updated the code for vCenter6 data 
center support.

[wido] CLOUDSTACK-8625: Remove the need of a wrapper script for the Agent

[Rajani Karuturi] changed the base iso file from debian-7.8.0 to debian-7.9.0

[Rohit Yadav] schema: add 4.5.2 to 4.5.3 upgrade path stubs

[Rohit Yadav] schema: add 4.5.3 to 4.6.0 upgrade path stubs

[Rohit Yadav] Revert "changed the base iso file from debian-7.8.0 to 
debian-7.9.0"

--
[...truncated 22036 lines...]
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'globoDnsElementTest.TestConfiguration'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 
'componentContext' to allow for resolving potential circular references
2015-09-16 11:04:08 INFO  ComponentContext:59 - Setup Spring Application context
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:460 - Finished creating 
instance of bean 'componentContext'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:215 - Creating shared 
instance of singleton bean 'transactionContextBuilder'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:432 - Creating instance of 
bean 'transactionContextBuilder'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'globoDnsElementTest.TestConfiguration'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:506 - Eagerly caching bean 
'transactionContextBuilder' to allow for resolving potential circular references
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:460 - Finished creating 
instance of bean 'transactionContextBuilder'
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'instantiatePostProcessor'
2015-09-16 11:04:08 DEBUG GenericApplicationContext:860 - Unable to locate 
LifecycleProcessor with name 'lifecycleProcessor': using default 
[org.springframework.context.support.DefaultLifecycleProcessor@10dc8850]
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'lifecycleProcessor'
2015-09-16 11:04:08 DEBUG PropertySourcesPropertyResolver:81 - Searching for 
key 'spring.liveBeansView.mbeanDomain' in [systemProperties]
2015-09-16 11:04:08 DEBUG PropertySourcesPropertyResolver:81 - Searching for 
key 'spring.liveBeansView.mbeanDomain' in [systemEnvironment]
2015-09-16 11:04:08 DEBUG PropertySourcesPropertyResolver:103 - Could not find 
key 'spring.liveBeansView.mbeanDomain' in any property source. Returning [null]
2015-09-16 11:04:08 DEBUG CacheAwareContextLoaderDelegate:97 - Storing 
ApplicationContext in cache under key [[MergedContextConfiguration@16b2145c 
testClass = GloboDnsElementTest, locations = '{}', classes = '{class 
com.globo.globodns.cloudstack.element.GloboDnsElementTest$TestConfiguration}', 
contextInitializerClasses = '[]', activeProfiles = '{}', contextLoader = 
'org.springframework.test.context.support.AnnotationConfigContextLoader', 
parent = [null]]]
2015-09-16 11:04:08 DEBUG cache:114 - Spring test ApplicationContext cache 
statistics: [ContextCache@1bba5fad size = 1, hitCount = 0, missCount = 17, 
parentContextCount = 0]
2015-09-16 11:04:08 DEBUG InjectionMetadata:85 - Processing injected method of 
bean 'com.globo.globodns.cloudstack.element.GloboDnsElementTest': 
AutowiredFieldElement for com.cloud.dc.dao.DataCenterDao 
com.globo.globodns.cloudstack.element.GloboDnsElementTest._datacenterDao
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'dataCenterDao'
2015-09-16 11:04:08 DEBUG AutowiredAnnotationBeanPostProcessor:445 - Autowiring 
by type from bean name 
'com.globo.globodns.cloudstack.element.GloboDnsElementTest' to bean named 
'dataCenterDao'
2015-09-16 11:04:08 DEBUG InjectionMetadata:85 - Processing injected method of 
bean 'com.globo.globodns.cloudstack.element.GloboDnsElementTest': 
AutowiredFieldElement for com.globo.globodns.cloudstack.element.GloboDnsElement 
com.globo.globodns.cloudstack.element.GloboDnsElementTest._globodnsElement
2015-09-16 11:04:08 DEBUG DefaultListableBeanFactory:243 - Returning cached 
instance of singleton bean 'globoDnsElement'
2015-09-16 11:04:08 DEBUG AutowiredAnnotationBeanPostProcessor:445 - Autowiring 
by type from bean name 
'com.globo.globodns.cloudstack.element.GloboDnsElementTest' to bean named 
'globoDnsElement'
2015-09-16 11:04:08 DEBUG InjectionMetadata:85 - Processing injected method of 
bean 'com.globo.globodns.cloudstack.element.GloboDnsElementTest':

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/841#issuecomment-140711369
  
I would avoid adding one more global setting; maybe what we can do is add 
like a static multiplier to the global setting value "vm.password.length" and 
use that as the length of the systemvm password; like 4 or 5 times that length? 
Comments?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rene Moser


On 09/16/2015 11:46 AM, Anshul Gangwar wrote:
> It’s not difficult to find a good grace period. It will simply depend on your 
> Hypervisor settings how it is configured for HA. You can easily figure out 
> for how much time there will be no VM on any Host from your settings and 
> simply put 2-3 times of that period as grace period.

I still think I would not that easy as it seems in every case but to
stay constructive, I would like to give it a shot.

René

3 weeks away from CCC Dublin

2015-09-16 Thread Sebastien Goasguen

Hi everyone,

We are 3 weeks away to CCC Dublin.

Many thanks to our sponsors:
-Citrix
-Cloud Foundry
-Nuage Networks
-Cloudian
-ShapeBlue
-Soldfire
-iKoula
-LPI-Japan
-PCextreme

I look forward to seeing you all there, don’t forget to register you still have 
time.
Cheers,

-Sebastien

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/841#issuecomment-140715229
  
mm.. I really think we should change the way we generate password both for 
uservms and systemvms. May be would could track that separately and for now 
increase the default length to 8? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140719214
  
@wido No luck yet:

```
error: File not found: 
/data/git/cs2/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/usr/sbin/cloudstack-usage-sysd

RPM build errors:
Binaries arch (1) not matching the package arch (2).
File not found: 
/data/git/cs2/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/usr/sbin/cloudstack-usage-sysd
RPM Build Failed 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/843

Security group ingress/egress issues with xenserver 6.2

There is issue with the xenserver 6.2 ipset type nethash. Fixed it by 
adding nethash for ipset version 6 which is xenserver 6.5. For ipset version 
4.x use iptreemap. 

1. Tested configuring egress/ingress rules.
2. Tested the traffic for the configured rules from the VM.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jayapalu/cloudstack SGIssue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/843.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #843


commit a15df0569fa0e56b14a9a119858c53e8ae6085c3
Author: Jayapal 
Date:   2015-09-16T09:52:33Z

CLOUDSTACK-8843: Fixed issue in default iptables rules on shared network VR

commit f0d5d5942e6ef39f1ff8b92335656b1d233782c1
Author: Jayapal 
Date:   2015-09-16T11:26:54Z

CLOUDSTACK-8871: fixed issue with the xenserver 6.2 ipset nethash




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/843#issuecomment-140724480
  
@bhaisaab  can you please review this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/818#issuecomment-140727278
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/843#issuecomment-140729245
  
@jayapalu isn't nethash type not supported on XenServer 6.2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/778#issuecomment-140729409
  
Dear @wilderrodrigues, As I said I get your point and the moment that you 
guys are on closing a version. 

A mistake was made, the moment I noticed that I jumped in and checked the 
problem and tried to fix it with this PR. No need to cut someoneâs head with 
adamantium claws.

Sure the task was huge, but simple. That was the point on giving it to a 
less experienced student. I want them to see that even in huge systems like 
CloudStack and others; there are codes that are not pretty and shiny.

The improvement factor depends on the concept you use, removing few lines 
of code and using a more intuitive and standard name for a variable in a 
hierarchic of classes can be considered an improvement.  The same occur if we 
remove the @Local annotation of that hierarchic, the task will affect 600+ 
classes, but it is a simple one.

Since you said that there is no way this PR will get accepted, I am closing 
it.
Thanks for your time.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/843#issuecomment-140729493
  
Also, what if the protocol version is greater than 6; what's the idea 
behind using protocol version to determine which data-structure type to use?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

Github user rafaelweingartner closed the pull request at:

https://github.com/apache/cloudstack/pull/778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-16 Thread sureshanaparti

Github user sureshanaparti commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/828#discussion_r39624157
  
--- Diff: 
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java ---
@@ -598,6 +601,19 @@ public static void 
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
 vmConfig.setGuestId(guestOsIdentifier);
 }
 
+public static void addUSBController(VirtualMachineConfigSpec 
vmConfigSpec) {
--- End diff --

@sateesh-chodapuneedi all the prepareXyzDevice() methods in VmwareHelper 
class returns VirtualDevice. So to be consistent, i think it is better to 
return a VirtualDevice when preparing USB controller and this device is added 
to the device config spec same as other devices.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-16 Thread ustcweizhou

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/844

CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups

This commit contains the following changes:
(1) implementation of assignVM in Advanced zone with Security Groups
(2) keep the default nic on shared network when assignVM
(3) allow migrate vm from/to project;
(4) UI change for selecting account/project/network

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack assignvm-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/844.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #844


commit e7f1454b68edbcea33a952973f5fc05bfaff304d
Author: Wei Zhou 
Date:   2015-09-16T12:43:55Z

CLOUDSTACK-7985: (1) allow migrate vm from/to project; (2) UI change for 
selecting account/project/network

commit 7a4b38611a640e723ba0a46ebc5f47ee56c0070c
Author: Wei Zhou 
Date:   2015-09-16T12:44:49Z

CLOUDSTACK-7985: keep the default nic on shared network when assignVM

commit 4896e478690184f4e766c492befe8b9534ec697e
Author: Wei Zhou 
Date:   2015-09-16T12:45:24Z

CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Usage service not working in CS 4.3.1

2015-09-16 Thread anil lakineni

Dears,

>From past three days, I have been facing issues with usage service in
CS4.3.1 with Xen host 6.2.0

In the CS mgmt server when check with usage service status, it is saying
running. But usage records are not generating in the cloud_usage

In the management-server.log I am getting below error,

*2015-09-16 02:48:09,180 INFO  [c.c.h.HighAvailabilityManagerImpl]
(HA-5:ctx-9e572072) checking health of usage server*
*2015-09-16 02:48:09,184 DEBUG [c.c.h.HighAvailabilityManagerImpl]
(HA-5:ctx-9e572072) usage server running? false, heartbeat: Mon Sep 14
22:46:09 GMT-08:00 2015*
*2015-09-16 02:48:09,184 WARN  [o.a.c.alerts] (HA-5:ctx-9e572072)
 alertType:: 13 // dataCenterId:: 0 // podId:: 0 // clusterId:: null //
message:: No usage server process running*
*2015-09-16 02:48:09,187 DEBUG [c.c.a.AlertManagerImpl] (HA-5:ctx-9e572072)
Have already sent: 1 emails for alert type '13' -- skipping send email*

When I was check at vi /var/log/cloudstack/usage/cloudstack-usage.err, the
below error is showing

*com.mysql.jdbc.exceptions.jdbc4.MySQLNonTransientConnectionException:
Could not create connection to database server. Attempted reconnect 3
times. Giving up*
**
**
*Caused by: com.mysql.jdbc.exceptions.jdbc4.CommunicationsException:
Communications link failure*

The full log of cloudstack-usage.err is copied and pasted in
http://pastebin.com/y9t7ebN4

I have checked and symbolic link mysql-connector-java.jar is available for
usage server at usage lib.

Please help me if I am missing something to fix this issue and let me know
if you need any other information from my side.

Thanks in advance,

Regards,
Anil.

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/839#issuecomment-140743242
  
- Deployed Advanced zone with two KVM clusters
- Created redundant router offering
- Created network
- Created VM in network

Two routers were started, each on one cluster:
```
MariaDB [cloud]> select name,host_id from vm_instance;
+-+-+
| name| host_id |
+-+-+
| s-1-VM  |   1 |
| v-2-VM  |   1 |
| testvm1 |   4 |
| r-4-VM  |   4 |
| r-5-VM  |   1 |
+-+-+
5 rows in set (0.00 sec)

MariaDB [cloud]> select name,id,cluster_id from host;
++++
| name   | id | cluster_id |
++++
| kvm3   |  1 |  1 |
| v-2-VM |  2 |   NULL |
| s-1-VM |  3 |   NULL |
| kvm1   |  4 |  2 |
++++
4 rows in set (0.00 sec)

MariaDB [cloud]> select id,name from cluster;
+++
| id | name   |
+++
|  2 | MCCT-KVM-1 |
|  1 | MCCT-KVM-3 |
+++
2 rows in set (0.00 sec)
```

Log message:
```
2015-09-16 13:17:49,543 DEBUG [c.c.v.VirtualMachineManagerImpl] 
(Work-Job-Executor-3:ctx-fbf1d659 job-16/job-17 ctx-a4481789) Deploy avoids 
pods: null, clusters: [2], hosts: null
```

So, the second router (r-5-VM) avoids cluster 2 (because r-4-VM runs on 
host 4 which is part of cluster 2).

Seems perfectly fine: LGTM

Thanks @bvbharat 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/839#issuecomment-140743582
  
@karuturi Please have a look, seems like a small bug fix that can go into 
4.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/837#issuecomment-140745806
  
@bvbharatk Any advise on how to test this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140746033
  
@remibergsma Thank you for testing. Stupid mistake indeed. That should be 
fixed now.

I checked on a CentOS 7 machine:

```
+ exit 0
RPM Build Done
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8872: Replaced all occurences ...

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/832#issuecomment-140758129
  
Hi @wilderrodrigues 

Thank you for your extensive comment. I've read through the thread you 
mentioned and added the required Jira ticket and PR description.

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/817#issuecomment-140777872
  
@bhaisaab Updated the PR. Tests run fine now. Thanks for your time!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140791892
  
@koushik-das could you comment, please. Regarding power off and no power 
state equal in some case might make sense but in general it certainly doesn't 
as we have seen an occasion were a missing report on a running VM was delivered 
(see RenÃ©'s logs in CLOUDSTACK-8848). As per Anshul's comments most or at 
least a lot of the times the handlers should act the same. This is considered a 
blocker for 4.6 so help is appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-140824594
  
@DaanHoogland and @nitin-maharana, I was thinking about this PR. I do not 
think that it is easy to write unit test for this.

First the method is huge (around 100 lines), and second it is a method that 
performs database access (it builds "queries" to retrive data).  Maybe, if you 
extract the creation of sc1 from lines 356 â 357 and then test the search 
criteria that was created. But still, that might not seem a pretty test case.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-16 Thread miguelaferreira

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/844#issuecomment-140833060
  
Apache Jenkins build reports 5 failing tests 
(https://builds.apache.org/job/cloudstack-pull-analysis/575/testReport/)
 
https://cloud.githubusercontent.com/assets/4670993/9914214/0d743c84-5cb1-11e5-9e8b-40cc4a69fba4.png";>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/820#issuecomment-140842317
  
@wido Yep, works fine now!

```
+ exit 0
RPM Build Done
```

Here they are:

```
[root@cs4 packaging]# ls -la ../dist/rpmbuild/RPMS/x86_64/
total 288928
drwxr-xr-x. 2 root root  4096 Sep 16 18:44 .
drwxr-xr-x. 3 root root  4096 Sep 16 18:43 ..
-rw-r--r--. 1 root root  50700428 Sep 16 18:44 
cloudstack-agent-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
-rw-r--r--. 1 root root  5364 Sep 16 18:44 
cloudstack-baremetal-agent-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
-rw-r--r--. 1 root root 38276 Sep 16 18:44 
cloudstack-cli-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
-rw-r--r--. 1 root root 111008452 Sep 16 18:44 
cloudstack-common-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
-rw-r--r--. 1 root root  88693724 Sep 16 18:43 
cloudstack-management-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
-rw-r--r--. 1 root root  45395296 Sep 16 18:44 
cloudstack-usage-4.6.0-SNAPSHOT.el7.centos.x86_64.rpm
```

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/818#issuecomment-140858308
  
Did anyone validate the functionality or do you want me to do that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/790#issuecomment-140862396
  
@nitin-maharana I see also PR #775, can this be closed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/790#issuecomment-140866855
  
Both are valid solutions for the very same problem, we would have to choose 
between one of them. @nitin-maharana said that he tested with the other 
solution, so I think this one can be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140867296
  
@DaanHoogland @resmo Not sure if this is related, but in 4.4 (and running 
XenServer/KVM probably any hypervisor) I see sometimes alerts when a router is 
live-migrated even from CloudStack. This happens because during live migrate 
two instances of the VM co-exist (one read/only the other the running) due to 
the nature of how live migrate works. Here CloudStack gets confused as two 
hypervisors report the power state now. When the power report is during the 
live migrate you see this alert, otherwise you will not see it. Could be the 
same issue.

Is this also relevant to 4.6? We kicked the code out recently (@koushik-das 
helped me out). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

GitHub user borisroman opened a pull request:

https://github.com/apache/cloudstack/pull/845

[4.6][BLOCKER]CLOUDSTACK-8763: Resolved POD/ZONE deletion failure.

Instead of having both checkIfPodIsDeletable() and checkIfZoneIsDeletable 
have there own SQL query, I've refactored them so they use DAO SQL Queries.

This resolves the SQL Exception thrown by both classes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8763

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #845


commit 0648cb98042eba19eb581c9d7f5b4d0c69ccd4e1
Author: Boris Schrijver 
Date:   2015-09-16T20:13:10Z

Added findByPodId(Long podId) to HostDao and HostDaoImpl.

commit 45861fa1b7e82250f404e22dd13ef4925c60da4e
Author: Boris Schrijver 
Date:   2015-09-16T20:14:05Z

Refactored checkIfPodIsDeletable().

It now makes use of various DAO DB function instead of running a self build 
query.

commit 473f1937e2c13bc7cca0b42c7585fe16accf7415
Author: Boris Schrijver 
Date:   2015-09-16T20:15:00Z

Added countIPs(long dcId, boolean onlyCountAllocated) to 
DataCenterIpAddressDao and DataCenterIpAddressDaoImpl.

commit 12fc2b4c26145721622b34f1a4f40d4e06faea93
Author: Boris Schrijver 
Date:   2015-09-16T20:15:53Z

Added countIPs(long dcId, boolean onlyCountAllocated) to IPAddressDao and 
IPAddressDaoImpl.

commit 0df3357cac73a2191cf4e01d5ef8db48a0bcbc64
Author: Boris Schrijver 
Date:   2015-09-16T20:17:27Z

Added findByDc(long dcId) to VolumeDao and VolumeDaoImpl.

commit b31e64d49df4f9cf1e16179354bf7916f19b0b3b
Author: Boris Schrijver 
Date:   2015-09-16T20:19:14Z

Refactored checkIfZoneIsDeletable().

It now makes use of various DAO DB function instead of running a self build 
query.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread resmo

Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140879864
  
@remibergsma does not look related to me, the keyword seems to be 
PowerReportMissing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-140910285
  
@rafaelweingartner we keep growing methods and not writing unit tests. Thus 
our code base is worsening in quality or at least in maintainability. However 
trivial we should keep refactorring and adding unit test in order to prevent 
things like "First the method is huge (around 100 lines), and second it is a 
method that performs database access (it builds "queries" to retrieve data). 
Maybe,...". I dont want to mis-quote you but am getting weary of all the 
reasons not to write unit tests. There is a lot of valid reasons and we should 
break through and focus on writing more (unit-)tests anyway (not discarding 
integration tests on the way). So as you say let's refactor the method and add 
the unit tests. even when trivial at the moment and discarding 90% of them 
along the way we will not regret putting in the effort.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/775#issuecomment-140915157
  
@ DaanHoogland, I understand you, I just commented that to show to 
@nitin-maharana that âweâ (I) understand that writing a test case to a 
method like that can be pretty hard, and that we are open to discuss and help 
with that. 

I just wanted to show support, because I have seen in other open source 
projects people rejecting PRs, just because the guy that created the PR is not 
well-known in the community and he/she had not written test cases for huge 
methods in which the developer had just made a pretty small fix like 
@nitin-maharana is doing. Most of the time developers debug the code, looking 
for the crux of the problem he/she is having, find and fix it without knowing 
the whole idea of the method, especially when methods have generic names, 
perform a lot of tasks and do not have proper java docs.

For instance: when I read, âcleanupDomainâ, I do not fully understand 
what the method is doing. Is it a periodical task that is intended to remove 
dirty from domains? Is it meant to remove resources that are no longer used by 
users of a domain?

I know that one of the tasks of that method is to remove/disable domains 
and their sub-domains, but to disable/remove something for me is different from 
cleaning something up.

Every time I review a code and see a clear opportunity to extract code and 
write test cases I suggest that, but when that does not happens, I do not feel 
comfortable asking for them and blocking a PR. That might not feel welcoming 
for a new contributor that is devoting some of his/her time for free in a 
project.

Bottom line is that we liked the job he has done and are here to help him 
with ideas in how to write at least one test case for the change he has made.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/845#discussion_r39714178
  
--- Diff: engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java ---
@@ -282,6 +289,14 @@ public IPAddressVO findByVmIp(String vmIp) {
 }
 
 @Override
+public int countIPs(long dcId, boolean onlyCountAllocated) {
+SearchCriteria sc = onlyCountAllocated ? 
AllocatedIpCount.create() : AllIpCount.create();
--- End diff --

Needs to be AllocatedIpCountForDc.create()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/829#issuecomment-140983520
  
@resmo You're right and I wasn't clear enough I guess. Because I think the 
'PowerReportMissing' comes from the VM on the hypervisor that you are migrating 
_to_, as in the beginning it is in a non-running state (probably 'paused', 
'stopped' or similar). This happens in order to get all memory over and promote 
it to 'running' later on, in which case we have one VM left again.

The confusing part is that two hypervisors report about the same VM during 
live migrate of which one is running and one non-running.

Just wanted to share.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...