Few BVTs failing

[Raja Pullela]

Hi,

In the latest BVTs, following tests are failing consistently -

* 2015-10-29 00:27:43,987 - CRITICAL - FAILED: 
test_vpc_remote_access_vpn: ['Traceback (most recent call last):\n', '  File 
"/usr/lib/python2.7/unittest/case.py", line 329, in run\ntestMethod()\n', ' 
 File "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 333, in 
test_vpc_remote_access_vpn\nself.fail(e)\n', '  File 
"/usr/lib/python2.7/unittest/case.py", line 410, in fail\nraise 
self.failureException(msg)\n', 'AssertionError: Execute cmd: 
deployvirtualmachine failed, due to: errorCode: 530, errorText:Template 202 has 
not been completely downloaded to zone 1\n']

* 2015-10-29 00:28:02,194 - CRITICAL - EXCEPTION: 
test_vpc_site2site_vpn: ['Traceback (most recent call last):\n', '  File 
"/usr/lib/python2.7/unittest/case.py", line 329, in run\ntestMethod()\n', ' 
 File "/root/cloudstack/test/integration/smoke/test_vpc_vpn.py", line 589, in 
test_vpc_site2site_vpn\nself.assert_(vm1 is not None, "VM failed to 
deploy")\n', "UnboundLocalError: local variable 'vm1' referenced before 
assignment\n"]

* 2015-10-29 02:02:15,167 - CRITICAL - EXCEPTION: 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80: ['Traceback (most recent 
call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
run\ntestMethod()\n', '  File 
"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 576, in 
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80\nclient_vm = 
self.deployvm_in_network(vpc, network_guestnet.id)\n', '  File 
"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 382, in 
deployvm_in_network\nraise Exception("Deployment failed of VM: %s" % e)\n', 
"Exception: Deployment failed of VM: Job failed: {jobprocstatus : 0, created : 
u'2015-10-29T02:02:09+', jobresult : {errorcode : 533, errortext : u'Unable 
to create a deployment for VM[User|i-36-69-VM]'}, cmd : 
u'org.apache.cloudstack.api.command.admin.vm.DeployVMCmdByAdmin', userid : 
u'afe432e8-7dd7-11e5-9ca5-b230fb1ebb83', jobstatus : 2, jobid : 
u'de5a239a-c70c-4039-9e8e-2ea9b80ed28b', jobresultcode : 530, jobinstanceid : 
u'47770620-0c37-4e7c-91e0-666bf7fe5eaa', jobresulttype : u'object', 
jobinstancetype : u'VirtualMachine', accountid : 
u'afe422b2-7dd7-11e5-9ca5-b230fb1ebb83'}\n"]

* 2015-10-29 02:00:33,135 - CRITICAL - EXCEPTION: 
test02_internallb_haproxy_stats_on_all_interfaces: ['Traceback (most recent 
call last):\n', '  File "/usr/lib/python2.7/unittest/case.py", line 329, in 
run\ntestMethod()\n', '  File 
"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 686, in 
test02_internallb_haproxy_stats_on_all_interfaces\nsettings = 
self.get_lb_stats_settings()\n', '  File 
"/root/cloudstack/test/integration/smoke/test_internal_lb.py", line 646, in 
get_lb_stats_settings\nself.fail("Failed to retrieve stats settings " % 
e)\n', 'TypeError: not all arguments converted during string formatting\n']

Looks like these were added by Michael.

Michael,
Can you optimize the tests with the following

1)  Before the VM Deployment or right after Template Register, can you put 
a loop to check if the Template is in a ready state before continuing with the 
test ? The reason is Template download is not getting completed and as a result 
the test cases are failing.

2)  Any reason for not using test_data.py to have all the 
configuration/settings you have defined the test file ?

Please let me know if you have any questions,
Raja

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43352356
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/"; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

Hi @bhaisaab,

I will create an improvement ticket to tackle your point. After 4.6 we are 
planning to rewrite it in a proper way and get rid of all those things that 
mixes bash/python code. So, adding few lines now is not going to add to the 
whole picture as they will also been removed afterwards.

My personal goal for 4.7/5.0, which is also the goal of my colleagues, is 
to rip ou the whole Python code and also the bash scripts - no longer used - 
from the ACS.

It cannot be done right in a few lines. It would be like a drop in an ocean.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-152089236
  
Ping @serbaut and @remibergsma

Tests results

* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

Three tests failed, but those are irrelevant since the PR #989 which fixes 
it is not part of this PR.

So, based on all the test done, this PR LGTM :+1: 

```
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
```

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-152087954
  
Ping @remibergsma @karuturi @miguelaferreira

Test results

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common built from source

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vp

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-152082434
  
@wido @wilderrodrigues @borisroman reviews please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/1000

CLOUDSTACK-9005: Modifying tearDown function

Modifying tearDown function to check if data volume is in detached state 
before deleting the volume


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-9005-Modifying-tearDown-function

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1000


commit d793c7f50ff56a3ecdd6c8862df1ee67ebcc9ac4
Author: Priti Sarap 
Date:   2015-10-29T05:28:15Z

CLOUDSTACK-9005: Modifying tearDown function




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43349249
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/"; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

While it fixes the issue, if it's not too much of a pain let's do it right 
otherwise it gets difficult to change in future as an enhancement.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

[pdion891]

GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack/pull/999

squashed commit for dockerfiles part#2 including comments from PR#910

This PR replace PR#910 which include fix from comments in PR#910.

This PR simplify download of systemvm templates, work with docker-compose 
and enable integration-api port and use of localstorage without reconfiguration 
of cloudstack.

Rebased on Oct28.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack dockerfile7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/999.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #999


commit fb2e5d2aad7920f3896d5da157ea874fb45d505e
Author: Pierre-Luc Dion 
Date:   2015-10-29T02:34:31Z

squashed commit for dockerfiles part#2 including comments from PR#910




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dockerfile part2

[pdion891]

Github user pdion891 commented on the pull request:

https://github.com/apache/cloudstack/pull/910#issuecomment-152054216
  
remote branch broken. closing this PR...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dockerfile part2

[pdion891]

Github user pdion891 closed the pull request at:

https://github.com/apache/cloudstack/pull/910


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build fails on LocalTemplateDownloadTest

[Josh Harshman]

Is anyone else experiencing the same behavior?

Building off master, get the following build failure:



---snip---

[INFO] Apache CloudStack Framework - IPC . SUCCESS [5.250s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.042s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [5.073s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [2.782s]
[INFO] Apache CloudStack Core  FAILURE [15.655s]
[INFO] Apache CloudStack Agents .. SKIPPED
[INFO] Apache CloudStack Framework - Clustering .. SKIPPED
---snip---


com.cloud.storage.template.LocalTemplateDownloaderTest.txt:

---
Test set: com.cloud.storage.template.LocalTemplateDownloaderTest
---
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.028 sec <<< 
FAILURE! - in com.cloud.storage.template.LocalTemplateDownloaderTest
localTemplateDownloaderTest(com.cloud.storage.template.LocalTemplateDownloaderTest)
  Time elapsed: 0.026 sec  <<< FAILURE!
java.lang.AssertionError: Failed download
at org.junit.Assert.fail(Assert.java:88)
at 
com.cloud.storage.template.LocalTemplateDownloaderTest.localTemplateDownloaderTest(LocalTemplateDownloaderTest.java:37)




Josh Harshman

Cloud Engineer
Security+


Intrinium
Tel: (509) 465-1234 x5259
Fax: (866) 565-4578
Lync / Skype: josh.harsh...@intrinium.com
Web: http://intrinium.com


[Intrinium Long Sig Logo]


[Facebook] [Twitter] 
  [Linkedin] 
  
[Youtube]   [Blog] 


Information Security and Compliance Consulting | Managed IT and Security 
Services | Cloud Services







This email and any files transmitted with it are confidential and intended 
solely for the use of the individual or entity to whom they are addressed. If 
you have received this email in error please notify the system manager. This 
message contains confidential information and is intended only for the 
individual named. If you are not the named addressee you should not 
disseminate, distribute or copy this e-mail. Please notify the sender 
immediately by e-mail if you have received this e-mail by mistake and delete 
this e-mail from your system. If you are not the intended recipient you are 
notified that disclosing, copying, distributing or taking any action in 
reliance on the contents of this information is strictly prohibited.

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/989


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/864#issuecomment-151993447
  
@bvbharatk we are almost ready to merge. Could you please respond to the 
comment made by @wido? Thanks! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/864#issuecomment-151993024
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11468.153s

FAILED (failures=3)

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:
  

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

[K0zka]

Github user K0zka commented on the pull request:

https://github.com/apache/cloudstack/pull/961#issuecomment-151989108
  
thank you for the response, then that prehistoric tomcat may not be able to 
compile the jsp.

Could you try if it works well with 
4eb707a567663cb4da0e548281f001b27196ba3d ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151974900
  
Ping @remibergsma @DaanHoogland @karuturi @miguelaferreira 

Test results

* Hardware required: false
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common built from source

```
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
```

Three tests failed, but that was expected since the fix is in the PR #989 

I will also run the [hardware require=true] tests.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151969250
  
@remibergsma and @serbaut 

There might have been some garbage in my environment. I cleaned it up and 
re-run the test. All fine!

```
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
ok

--
Ran 1 test in 243.898s

OK
/tmp//MarvinLogs/test_privategw_acl_JLJG18/results.txt (END)
```

I will now run the tests that require hardware.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Mentor

[Yiping Zhang]

Hi, David:

I am speaking as a CloudStack user/admin/operator here.

Here is an issue which really really drives me crazy, but should be relatively 
easy for a java developer to work on:  improving error log messages!

Here is a specific example: when deploying a VM instance fails, often the error 
message simply says “InsufficientServerCapacityException: Unable to create a 
deployment”  along with a stack trace, but without any easily understandable 
information.  I have encountered this error for at least a dozen different 
reasons.  This message really can be improved to provide more context and human 
understandable output to help CloudStack admins to troubleshoot the real 
problem.

Good luck.

Yiping



On 10/27/15, 3:27 PM, "Erik Weber"  wrote:

>On Tue, Oct 27, 2015 at 10:34 PM, David Willard 
>wrote:
>
>> Hi B. Prakash, Daan, Erik,
>>
>> I have emailed many time requesting a mentor and still no responses. I
>> have been following cloudstack for a few months. I am entry-level java
>> completed a Java class as I have earned my bachelor in IT from Northeastern
>> University. I earned a 4.0 for the Java course. Even if I have to start
>> troubleshooting code I am a quick learner and in a few months be able to
>> code. I am a member of the OSI and my ultimate goal is to obtain a job in
>> information security.
>>
>>
>Hi David,
>
>I am sorry that your efforts to get into the community hasn't given the
>wanted results yet.
>
>Coding CloudStack is beyond my skill set, so I can't really offer any
>mentoring, but if you are looking for simple tasks to carry out to get more
>familiar with the project I am sure we could come up with some issues for
>you :-)
>
>Your first matter of business should be to get a CloudStack cloud up and
>running so that you can test any changes you do.
>This can be done on a single machine if needed.
>
>-- 
>Erik

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

[xenserverarmy]

Github user xenserverarmy commented on the pull request:

https://github.com/apache/cloudstack/pull/982#issuecomment-151967711
  
@remibergsma How did the tests work out?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [wip][4.6] CLOUDSTACK-8994 Add logging fo...

[borisroman]

Github user borisroman closed the pull request at:

https://github.com/apache/cloudstack/pull/983


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151958257
  
Nice one, @borisroman. Thanks for the tests!

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151959579
  
Hi @serbaut and @remibergsma 

First tests have been executed. I got 1 error, related to private gateway 
ACL, but I think it was just a weird glitch on Marvin. Why? First thing, the 
test worked fine with @remibergsma's tests; Second, the error only says None 
etc.

Test Results:

```
Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : FAILED ===
FAIL
Test reset virtual machine on reboot ... === TestName: 
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: 
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | 
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: 
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: 
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: 
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: 
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status 
: SUCCE

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

[bhaisaab]

Github user bhaisaab closed the pull request at:

https://github.com/apache/cloudstack/pull/990


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151957189
  
@wilderrodrigues @remibergsma LGTM :+1: 

Tested VM password manually => working!

```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-kvm1-basic.cfg -s -a 
tags=basic,required_hardware=false smoke/test_vm_life_cycle.py
```
```
cat /tmp/MarvinLogs/test_vm_life_cycle_5PP3X0/results.txt 
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : 
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: 
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : 
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : 
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : 
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status 
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status 
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone 
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm 
| Status : SUCCESS ===
ok

--
Ran 9 tests in 572.101s

OK (SKIP=1)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/990#issuecomment-151957243
  
Merged on 4.5 since, PR for master has been merged on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151953800
  
@wilderrodrigues Ok! Code LGTM :+1: @remibergsma 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151953539
  
@borisroman and @remibergsma, the 2 commits have been squashed.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151952219
  
@borisroman: the fix typos can be squashed and the one that says "use 
correct ip address" as well, the other two won't because they are independent: 
1 for the test and 1 for the fix.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-151950464
  
@remibergsma I think it might be the problem, which also caused my vr to 
not restart... Looking into it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151944891
  
@remibergsma The comments I placed are fixed in 
50827f7e4ba90e2cbf163a9946c84d1835630ead. Though this introduces my new 
comment; can the commits be squashed? As they fix a single issue...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/991


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-8999: Don't overr...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/991#issuecomment-151940210
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11573.694s

FAILED (failures=3)

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:
  

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-151939066
  
@borisroman Isn't there already another process logging to 
`/var/log/cloud.log` ? Will this work properly if multiple processes write to 
it at the same time? Haven't verified it yet, so might be wrong but just wanted 
to check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151936598
  
@borisroman Can you please review again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8991 - IP address is not remov...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/989#issuecomment-151936406
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py
```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 27 tests in 11795.204s

OK

```

No more errors!

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

```
Test router internal advanced zone ... === TestName: 
test_02_router_

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151928213
  
Travis failed due to a timeout:


![image](https://cloud.githubusercontent.com/assets/5129209/10797761/6835b74c-7da4-11e5-9fd6-080b807739f1.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151927952
  
@remibergsma @insom I deleted the other pull jobs to avoid this confusion. 
Sometimes jenkins reports the wrong build being busy. Let's see if this 
behaviour is gone now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43290720
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/"; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

Good point, @bhaisaab .

I don't have the energy to update it now, but will do it tomorrow. I just 
used the same stuff we had in the previous passwd bash file, but it makes more 
sense to Pythonise the whole thing. :)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151907240
  
@bhaisaab 

Squashed and pushed again.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151906835
  
Ping @bhaisaab @DaanHoogland @remibergsma @miguelaferreira 

Does anyone know why this error happened? Read it but I can't take much of 
it. It has nothing to do with the PR content.


![image](https://cloud.githubusercontent.com/assets/5129209/10795936/43afbba0-7d9c-11e5-88a8-3622c5bc5ba8.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151906311
  
Got 2 red checks. Will have a look why.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151904579
  
(forgot to mention, just reviewed code but yet to test it)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151904440
  
LGTM, you may squash the commits as it's a single logical fix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/998#discussion_r43282110
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -41,27 +41,37 @@
 from cs.CsMonitor import CsMonitor
 from cs.CsLoadBalancer import CsLoadBalancer
 from cs.CsConfig import CsConfig
+from cs.CsProcess import CsProcess
 
 
 class CsPassword(CsDataBag):
-"""
-  Update the password cache
-
-  A stupid step really as we should just rewrite the password server to
-  use the databag
-"""
-cache = "/var/cache/cloud/passwords"
-
+
+TOKEN_FILE="/tmp/passwdsrvrtoken"
+
 def process(self):
-file = CsFile(self.cache)
 for item in self.dbag:
 if item == "id":
 continue
-self.__update(file, item, self.dbag[item])
-file.commit()
+self.__update(item, self.dbag[item])
 
-def __update(self, file, ip, password):
-file.search("%s=" % ip, "%s=%s" % (ip, password))
+def __update(self, vm_ip, password):
+token = ""
+try:
+tokenFile = open(self.TOKEN_FILE)
+token = tokenFile.read()
+except IOError:
+logging.debug("File %s does not exist" % self.TOKEN_FILE)
+
+ips_cmd = "ip addr show | grep inet | awk '{print $2}'"
+ips = CsHelper.execute(ips_cmd)
+for ip in ips:
+server_ip = ip.split('/')[0]
+proc = CsProcess(['/opt/cloud/bin/passwd_server_ip.py', 
server_ip])
+if proc.find():
+update_command = 'curl --header "DomU_Request: 
save_password" "http://{SERVER_IP}:8080/"; -F "ip={VM_IP}" -F 
"password={PASSWORD}" ' \
--- End diff --

while this works, since we are using python; we can simply make a HTTP call 
as well using requests or urllib etc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/998#issuecomment-151900260
  
Ping @remibergsma @borisroman @wido @miguelaferreira @DaanHoogland 
@bhaisaab @karuturi @NuxRo 

Could you please have a look at this PR? I already have the results for the 
new tests that was added, but will run more tests overnight.

Test Results
* Management Server + MySQL on CentOS 7.1
* One KVM host on CentOS 7.1
* ACS Agent + Common RPMs built from source

```
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok

--
Ran 1 test in 423.831s

OK
/tmp//MarvinLogs/test_password_server_1ANC53/results.txt (END)
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-151893972
  
@terbolous It doesn't effect log-rotating at all. This just let's the 
password_server_ip.py logs to be written to /var/log/cloud.log instead of 
/dev/nul


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

[wilderrodrigues]

GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/998

CLOUDSTACK-8957 - VR password server feature is broken

This PR implements the update of the password as it use to be done with the 
bash file, but using the Python code for it.

A new integration test was added in order to cover the fix. The test can be 
found at component/test_password_server.py and does the following:

* Creates an Account
* Creates a Service Offering
* Creates a Network Offering
* Creates a Network
* Creates two Virtual Machines
* Creates two FW rules
* Creates two PF rules
* SSH into each VM and checks the default routes (by pinging 8.8.8.8)
* SSH to the host and executes a command in the router to check the 
password-[gateway] file
  - The file is under /var/cache/cloud/passwords-[gateway]

The [gateway] is replaced by the gateway from each virtual machine NIC.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
fix/vr_passwd_server-CLOUDSTACK-8957

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #998


commit ea132cc4789e3c2161a0618ac02e7a68a8d67aed
Author: Wilder Rodrigues 
Date:   2015-10-27T12:31:31Z

CLOUDSTACK-8957 - Implement password server in configure.py

commit 92ccd45db5dd0aa175d7702e2723af4d01528b8b
Author: Wilder Rodrigues 
Date:   2015-10-28T07:43:26Z

CLOUDSTACK-8957 - Make some improvements in the way the process is checked

  - Fix import of CsProcess module

commit ac3e352125261fc34527a56028998b644371e2d7
Author: Wilder Rodrigues 
Date:   2015-10-28T15:31:04Z

CLOUDSTACK-8957 - Add integration test that cheks if the password file is 
present and not empty




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151896039
  
Thanks @remibergsma the jenkins build still failed due to JVM crashing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151894479
  
Thank you. Sorry I could not write a test for it. Maybe the instructions 
for running tests need to be updated because I ran into all sorts of problems. 
Can't even get Jenkins to execute the tests it seems :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8994 Add logging for the...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/983#issuecomment-151894028
  
@karuturi I'll check again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151890952
  
Thanks for the details, @serbaut!

I will test you PR as well.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151879029
  
Hi @Insom, Jenkins succeeded, see: 
https://builds.apache.org/job/cloudstack-pull-analysis/1034/ There is a 
different job with a slightly different name ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-151871826
  
@remibergsma Ok, that is odd.

A proper XML should look like this:

```

  
  
  
  

```

path is not required, that is computed by libvirt. But the state connected 
is probably the issue. I'll fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-151864368
  
@remibergsma no problem. I am working on some changes , I will push the 
commits with rebase tomorrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[insom]

Github user insom commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151859204
  
Hi @remibergsma - it looks like this Jenkins job is disabled? 
https://builds.apache.org/job/cloudstack-pull-requests/ -- I can confirm the 
tests pass on my rebased branch from a regular `mvn clean test` but Jenkins 
looks like it's stuck since the 18th August?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Build failure for plugin ovm3

[Sateesh Chodapuneedi]

Ok, will try downgrade option as well.
Thanks again for looking at it Daan.

Regards,
Sateesh

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Wednesday, October 28, 2015 1:01 PM
To: dev
Subject: Re: Build failure for plugin ovm3

Sateesh, I really don't know what the root cause of your problem is.
Downgrading is worth a try but no guarantees.

I don't see anything in your reported platform that rings alarms.

On Wed, Oct 28, 2015 at 2:03 AM, Sateesh Chodapuneedi < 
sateesh.chodapune...@citrix.com> wrote:

> Hi Daan,
>
> Thanks for looking at this. Per your suggestion updated mvn from 3.0.4 
> to 3.0.5, but still seeing same problem.
>
> Currently the versions look like below,
>
> # mvn -version
> Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 
> 2013-02-19
> 19:21:28+0530)
> Maven home: /usr/local/maven/apache-maven-3.0.5
> Java version: 1.7.0_79, vendor: Oracle Corporation Java home: 
> /usr/lib/jvm/java-7-openjdk-i386/jre
> Default locale: en_US, platform encoding: UTF-8 OS name: "linux", 
> version: "3.2.0-83-generic-pae", arch: "i386", family:
> "unix"
>
> The java version is latest provided by ubuntu on 12.04. Should I try 
> upgrade or downgrade from 1.7.0_79 ?
>
> Regards,
> Sateesh
> 
> From: Daan Hoogland [daan.hoogl...@gmail.com]
> Sent: Tuesday, October 27, 2015 10:24 PM
> To: dev
> Subject: Re: Build failure for plugin ovm3
>
> H Sateesh,
>
> It looks like you hit a maven bug. you better check if you need to up- 
> or downgrade. Also you may want to look at your java version.
> Can you share those?
>
> On Tue, Oct 27, 2015 at 3:32 PM, Sateesh Chodapuneedi < 
> sateesh.chodapune...@citrix.com> wrote:
>
> > Hi Daan,
> > There are no errors reported while compiling the test classes in 
> > ovm3 module. That's bit confusing and not clear what is failing over there.
> I've
> > added -X flag and re-built. Please find the verbose build output below.
> >
> >
> --
> Daan
>



--
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151855358
  
Wtf Jenkins, no means no.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

[pdube]

Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-151854916
  
@remibergsma I rebased and repushed. I will take some screen shots later! 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151845449
  
@serbaut Sorry to hear that! Good that the deploy actually works. I'm not 
using DevCloud so I cannot help with that. I do know that I have no issues 
running Marvin tests from CentOS 7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151843789
  
Yes I have a running zone with advanced networking. Giving up on the tests, 
too much breakage everywhere. I must be doing something wrong.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151843525
  
Hi @serbaut Did the deployDatacenter.py actually work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151842878
  
Hi @serbaut I sometimes have trouble with nose after installing marvin. So 
what I do, is to install marvin, and then reinstall nose (forcing it to 
actually reinstall).
Could you please try that to see if the error goes away?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151841925
  
Hi @insom It might be rotated already. Usually when you force push your 
commits to the branch again, Jenkins will notice this and run again. I think 
that is the best thing to do now: make sure the tests run again and it will 
probably be green then :-) Let me know if you need help.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-151838470
  
Hi @wido :

SELinux is off:
```
[root@kvm1 channel]# getenforce 
Permissive
```

The generated XML:
```
2015-10-28 13:02:00,216 DEBUG [resource.wrapper.LibvirtStartCommandWrapper] 
(agentRequest-Handler-5:null) st
arting s-324-VM: 
s-324-VM
acdaffdf-9676-42eb-a386-f8aee0aaccca
Debian GNU/Linux 5.0 (64-bit)


Apache Software Foundation
CloudStack KVM Hypervisor
acdaffdf-9676-42eb-a386-f8aee0aaccca



hvm




restart
destroy
destroy
524288



1






500






/usr/libexec/qemu-kvm


















































```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151836687
  
LGTM, tested on `CentOS 7` and the logrotate file gets properly installed:

```
[root@kvm1 logrotate.d]# pwd
/etc/logrotate.d
[root@kvm1 logrotate.d]# cat cloudstack-agent 
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.

/var/log/cloudstack/agent/cloudstack-agent.out
/var/log/cloudstack/agent/cloudstack-agent.err
{
copytruncate
daily
rotate 5
compress
missingok
}
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-151836172
  
@remibergsma Hmm, was SELinux enabled on that system? Can't see any reason 
why it wouldn't work. All the directories exist.

Do you by any chance have the XML the Agent generated for the SSVM for 
example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/985#issuecomment-151832340
  
@wido Thanks for working on this, awesome!

I was testing this PR and found that the SSVM and CPVM systemvms do not 
start properly. This is the error:

```
2015-10-28 12:36:30,145 WARN  [resource.wrapper.LibvirtStartCommandWrapper] 
(agentRequest-Handler-4:null) Li
bvirtException 
org.libvirt.LibvirtException: internal error: process exited while 
connecting to monitor: 2015-10-28T12:36:2
9.904910Z qemu-kvm: -chardev 
socket,id=charchannel0,path=/var/lib/libvirt/qemu/channel/target/v-273-VM.org.qemu.guest_agent.0,server,nowait:
 Failed to bind socket: Permission denied
2015-10-28T12:36:29.904949Z qemu-kvm: -chardev 
socket,id=charchannel0,path=/var/lib/libvirt/qemu/channel/target/v-273-VM.org.qemu.guest_agent.0,server,nowait:
 chardev: opening backend "socket" failed

at org.libvirt.ErrorHandler.processError(Unknown Source)
at org.libvirt.Connect.processError(Unknown Source)
at org.libvirt.Connect.processError(Unknown Source)
at org.libvirt.Connect.domainCreateXML(Unknown Source)
at 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.startVM(LibvirtComputingResource.java:1292)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:82)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStartCommandWrapper.execute(LibvirtStartCommandWrapper.java:46)
at 
com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:75)
at 
com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1316)
at com.cloud.agent.Agent.processRequest(Agent.java:518)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:823)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
```

Here is the channel dir:

```
[root@kvm1 channel]# ls -al /var/lib/libvirt/qemu/channel/
total 12
drwxr-x---. 3 qemu qemu 4096 Oct 28 09:55 .
drwxr-x---. 7 root root 4096 Oct 28 12:39 ..
drwxr-x---. 2 qemu qemu 4096 Sep 15 14:03 target
```

The `target` folder was empty.

I've installed the rpm package that I've built from this branch. The agent 
seems to run as root:

```
root  9815  0.4  3.1 4815960 255916 ?  Sl   10:17   0:41 
/usr/lib/jvm/jre/bin/java -Xms256m -Xmx2048 
```

It was tested on a KVM hypervisor on CentOS 7. Ping me if you need more 
details.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add all tests in /test/integration/smoke ...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/997#issuecomment-151826908
  
@runseb Travis is green but no tests are running.

I checked all the builds and the first few say this:
```
$ ./tools/travis/script.sh $TESTS
./tools/travis/script.sh: line 42: nosetests: command not found
+--++
| Test | Result |
+==++
+--++
```

And the rest say this:
```
/home/travis/build.sh: line 108:  2390 Terminated  
travis_jigger $! $timeout $cmd
The command "travis_wait 30 sleep 30" exited with 0.
$ ./tools/travis/script.sh $TESTS
Skipping tests ... SUCCESS !
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151816807
  
@remibergsma looks like JVM crashed - 
https://builds.apache.org/job/cloudstack-pull-analysis/1031/org.apache.cloudstack$cloud-server/console
forcing pushing again to kick another job


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151812042
  
@bhaisaab Maybe you can force push again, because it failed 
(https://builds.apache.org/job/cloudstack-pull-analysis/1031/). probably not 
related to what you did, but still nice to see it pass. 

Will build some packages and test this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

[ProjectMoon]

Github user ProjectMoon commented on the pull request:

https://github.com/apache/cloudstack/pull/988#issuecomment-151810393
  
I can create a ticket, yes.

I plan to push more work to this pull request today/tomorrow that moves the 
VirtualMachineName service and probably the UUID manager into its own module. 
This would make it very easy for 3rd party developers to override the default 
VM naming and UUID creation policies in CloudStack by excluding the module and 
providing their own in its place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/988#issuecomment-151807919
  
@ProjectMoon impressive work. Can you create a jira ticket and describe it 
(including functional incentive) and prepend the PR with the ticket id?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/988#discussion_r43242947
  
--- Diff: 
plugins/network-elements/internal-loadbalancer/test/resources/lb_mgr.xml ---
@@ -36,7 +36,7 @@
 
 
   
-
+  
--- End diff --

trailing space


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Make VirtualMachineName into an injectabl...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/988#issuecomment-151806516
  
@ProjectMoon THe stuff built and is running tests. You should be able to 
force push it and it should build. unsure what we are looking for but probably 
a problem on the build slave.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151806586
  
@remibergsma Jenkins seems quite happy - 
https://builds.apache.org/job/cloudstack-pull-analysis/1026/ ?
See this rpm build (4.5 actually) - 
http://sb.bhaisaab.org:/job/rpm-shapeblue-build-patch-noredist/100/console 
or rpms: 
http://sb.bhaisaab.org/cloudstack/kvmagentrot/centos/4.5-logrotate-kvm-agent-erroutlogs/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151805630
  
@bhaisaab Thanks, can you please make Jenkins happy? ;-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[serbaut]

Github user serbaut commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151805357
  
Thanks. I still haven't given up on writing a test for this. Just found one 
issue with running

python2.7 marvin/marvin/deployDataCenter.py -i 
devcloud-kvm/devcloud-kvm-advanced.cfg

That config uses a logger config that doesn't work with marvin.

Now I can't get nose to use python2.7, even when running nosetest2.7:

[root@devcloud-kvm cloudstack]# nosetests-2.7 --with-marvin 
--marvin-config=tools/devcloud-kvm/devcloud-kvm-advanced.cfg -a tags='devcloud'
 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//Oct_28_2015_05_10_35_QWNYQ4. 
All logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
Traceback (most recent call last):
  File 
"/root/cloudstack/test/integration/component/find_hosts_for_migration.py", line 
21, in 
from nose.plugins.attrib import attr
ImportError: cannot import name attr
Traceback (most recent call last):
  File 
"/root/cloudstack/test/integration/component/maint/test_bugs.py", line 19, in 

from marvin.cloudstackTestCase import cloudstackTestCase, unittest
ImportError: No module named marvin.cloudstackTestCase
^C  File 
"/root/cloudstack/test/integration/component/maint/test_dedicate_guest_vlan_ranges.py",
 line 26, in 
from nose.plugins.attrib import attr

Is there a better/simpler way to run the tests? Should i not use 
devcloud-kvm? Should I not use advanced networking? Just trying to follow 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/devcloud-kvm

A "make test" that just worked would have been nice :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[insom]

Github user insom commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151805043
  
@remibergsma Travis seems happy but Jenkins isn't (but I can't view the 
Jenkins output, it's 404ing :|). I'll run the tests for the rebased version 
manually and see if that throws any light, before pushing again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/879#issuecomment-151804656
  
@pdube @pdion891 Could you please look at this PR? Would be nice to include 
it soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-151804289
  
@ustcweizhou Can you please rebase against current master (and resolve 
conflict)? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8992 Allow 32 disks to b...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/980


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/996#issuecomment-151803068
  
@karuturi Thanks! Will test soon :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/848#issuecomment-151801262
  
@michaelandersen can you review this please?
@insom Travis failed, please investigate or push again. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8941: fix NPE when migrate vm ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/918


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8990: start a stopped machine ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/978


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/979


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8989 test_ps_limits.py t...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/979#issuecomment-151798750
  
LGTM, test runs fine:

```
=== TestName: test_deploy_vm | Status : SUCCESS ===

=== TestName: test_deploy_vm_multiple | Status : SUCCESS ===

=== TestName: test_01_stop_vm | Status : SUCCESS ===

=== TestName: test_02_start_vm | Status : SUCCESS ===

=== TestName: test_03_reboot_vm | Status : SUCCESS ===

=== TestName: test_06_destroy_vm | Status : SUCCESS ===

=== TestName: test_07_restore_vm | Status : SUCCESS ===

=== TestName: test_09_expunge_vm | Status : SUCCESS ===
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] personal mentoring program (was: Mentor)

[Daan Hoogland]

people, I have answered David and Prakesh on a personal note to get them
started.

When I started at cloudstack I had the luck to be in close quarters with a
fellow developer. Not everybody is. Is there a wider call for mentoring on
a personal level?

Several people have proposed to be a google summer of code mentor but this
year no projects were admitted. Maybe we can provide a structured way of
providing mentoring for people wanting to start. I don't know if we can
prevent frustration to occur but we might find a way to reduce the pain of
starting working on cloudstack a bit.

On Tue, Oct 27, 2015 at 10:34 PM, David Willard 
wrote:

> Hi B. Prakash, Daan, Erik,
>
​...​



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/981#issuecomment-151798263
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11818.695s

FAILED (failures=3)

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:
  

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/968


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8985: Deleted volume's removed...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/968#issuecomment-151795514
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11819.895s

FAILED (failures=3)
```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

  

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/895


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: TransactionContextInterceptor Keeps Releasing My Lock

[Jeff Hair]

My experience is this:
 - If I call the method directly from within the class, @DB seems to apply
and the lock in the op_lock table stays active as long as it is needed.
 - If I call the method on another thread (internal class implementing
Runnable), @DB does not apply and I have to wrap the acquireInLock call and
associated code in Transaction.doInTransaction.

On Wed, Oct 28, 2015 at 10:02 AM, Frank Maximus <
frank.maxi...@nuagenetworks.net> wrote:

> Would you happen to call the method annotated with @DB from within the same
> class? If so,  you would directly go to the method, instead of using the
> proxy which applies AOP.
>
> Regards,
> Frank
> On 26 Oct 2015 12:53, "Jeff Hair"  wrote:
>
> > I have narrowed it down to multithreading being the cause. I have a set
> of
> > workers running through an executor service, and it seems cglib is not
> > respecting the @DB annotation on the method being called by the thread.
> >
> > I can force the lock to be acquired if the entire method is executed in a
> > transaction, or if I remove the producer-consumer BlockingQueue. Is
> there a
> > way that makes sense besides one of these two options?
> >
> > On Wed, Oct 14, 2015 at 5:04 PM, Jeff Hair  wrote:
> >
> > > I'm using the DAO API to create a lock in the lock table as per
> > >
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Data+Access+Layer
> > .
> > > However, the lock seems to mysteriously vanish after acquireInLockTable
> > or
> > > lockInLockTable method returns. Looking at the code, I've discovered
> that
> > > TransactionContextInterceptor is closing the TransactionLegacy after
> the
> > > method returns.
> > >
> > > I have @DB on the method calling acquireFromLockTable. What am I doing
> > > wrong?
> > >
> >
> >
> >
> > --
> > *Jeff Hair*
> > Technical Lead and Software Developer
> >
> > Tel: (+354) 415 0200
> > j...@greenqloud.com
> > www.greenqloud.com
> >
>



-- 
*Jeff Hair*
Technical Lead and Software Developer

Tel: (+354) 415 0200
j...@greenqloud.com
www.greenqloud.com

[GitHub] cloudstack pull request: CLOUDSTACK-8911: VM start job got stuck i...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/895#issuecomment-151794288
  
LGTM, based on a set of tests that I run on this branch (which I rebased 
myself first):

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
--
Ran 27 tests in 11840.144s

FAILED (failures=3)

```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:
  

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/977#issuecomment-151792666
  
FYI,run a set of tests that on this branch (which I rebased myself first), 
just to make sure no existing functionality is broken by this PR. Looking good!

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === 
TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : FAILED ===
FAIL
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
FAILED ===
FAIL
```

The 3 errors at the bottom are due to CLOUDSTACK-8991 and unrelated to this 
PR.

And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py
```

Result:

```
Test router internal advanced zone ... === TestName: 
test

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/993#issuecomment-151791418
  
@bhaisaab With systemd we no longer write a out and err file. We did this 
with JSVC, but now it's send to stdout and stderr which is then picked up by 
journald.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9000: logrotate cloudsta...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/993#issuecomment-151790777
  
@wido fixed now. Do you mean with systemd, there is no point in using 
logrotate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [master/4.6] CLOUDSTACK-9000: logrotate c...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/992#issuecomment-151790553
  
@wido fixed now 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: TransactionContextInterceptor Keeps Releasing My Lock

[Frank Maximus]

Would you happen to call the method annotated with @DB from within the same
class? If so,  you would directly go to the method, instead of using the
proxy which applies AOP.

Regards,
Frank
On 26 Oct 2015 12:53, "Jeff Hair"  wrote:

> I have narrowed it down to multithreading being the cause. I have a set of
> workers running through an executor service, and it seems cglib is not
> respecting the @DB annotation on the method being called by the thread.
>
> I can force the lock to be acquired if the entire method is executed in a
> transaction, or if I remove the producer-consumer BlockingQueue. Is there a
> way that makes sense besides one of these two options?
>
> On Wed, Oct 14, 2015 at 5:04 PM, Jeff Hair  wrote:
>
> > I'm using the DAO API to create a lock in the lock table as per
> > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Data+Access+Layer
> .
> > However, the lock seems to mysteriously vanish after acquireInLockTable
> or
> > lockInLockTable method returns. Looking at the code, I've discovered that
> > TransactionContextInterceptor is closing the TransactionLegacy after the
> > method returns.
> >
> > I have @DB on the method calling acquireFromLockTable. What am I doing
> > wrong?
> >
>
>
>
> --
> *Jeff Hair*
> Technical Lead and Software Developer
>
> Tel: (+354) 415 0200
> j...@greenqloud.com
> www.greenqloud.com
>

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8999: Don't override res...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/990#issuecomment-151784690
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---