[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-201139141
  
_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

### ACS CI BVT Run
 **Sumarry:**
 Build Number 126
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=2
 Skipped=4


**Failed tests:**
* integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange

 * test_dedicateGuestVlanRange Failed

* integration.smoke.test_volumes.TestCreateVolume

 * test_06_download_detached_volume Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: External fork of Cloudstack (was Re: [GitHub] cloudstack pull request: Is the project attempting a fork on Githu...)

[Pierre-Luc Dion]

Hi,

Sorry to step in late on that thread. I have a question for Jim, David,
Sam.

As it seams, a lot of us in the "CloudStack community" would love to work
with github features to speedup the project development cycle, The fact
that some other ASF projects are interested too. Would it be  thinkable to
get a hosted github on the ASF infra? To me it's kind on 1 + 1
I know hosted github is not free and opensource, neither confluence or
jira.  There are alternatives to github such as gitlab or gogs that might
work too ??

Regards,

Pierre-Luc


On Sat, Mar 19, 2016 at 4:02 PM, Daan Hoogland 
wrote:

> Ok Jim, it seems we are on one line here. Sorry to bother but I wanted to
> make sure. In my understanding the moving was only about the part already
> on github. I'll hold my peace for a while unless we are actually talking
> about the technical implementation of a convenient developer workflow again
> ;)
>
>
>
> On Sat, Mar 19, 2016 at 8:35 PM, Jim Jagielski  wrote:
>
> > As Sam indicated, there was a lot of hush-and-rush about all
> > this, with little communicated and much assumed. It appears that
> > now things are more well known and the matters are being
> > addressed. But for the record, yes, there was the impression
> > and (mis)understanding that "moving" to GH was indeed what
> > was desired and "demanded".
> >
> > My post was in direct response to Sebastien's query, as was hopefully
> > indicated by including that paragraph in my post.
> >
> > > On Mar 19, 2016, at 3:09 PM, Daan Hoogland 
> > wrote:
> > >
> > > On Sat, Mar 19, 2016 at 7:50 PM, Jim Jagielski 
> wrote:
> > >
> > >>
> > >>> On Mar 19, 2016, at 2:12 PM, sebgoa  wrote:
> > >>>
> > >>>
> > >>> Personally I have always thought that this is a very serious issue
> and
> > >> trend in open source projects and that ASF (and the board in
> particular)
> > >> should try to proactively address. What is the future of ASF in a
> GitHub
> > >> world ? Can an ASF project live outside of ASF infra, especially in a
> > Cloud
> > >> world ? Sadly I never saw any clear proactivity from the board.
> > >>>
> > >>
> > >> I can answer this by asking you one question: What value, if
> > >> any, do you see the ASF providing to Cloudstack?
> > >>
> > >> I will avoid the very Mom-like retort: "If all your friends were
> > >> going to jump off a roof, would you too?"  :) :)
> > >>
> > >> Real Open Source collaboration, and community, is more than
> > >> just developer workflow. Hopefully, one day people will
> > >> remember that... The ASF, however, will never forget it.
> > >>
> > >> Meanwhile, I still boggle at people who paint Microsoft as
> > >> (still) enemies of Open Source, yet bend over backwards to
> > >> portray Github as true, passionate open source liberators.
> > >> People passionate about open source are seriously pushing
> > >> that projects be hosted on a single-vendor, closed-source,
> > >> proprietary environment. If that vendor's name was "Microsoft"
> > >> or "Oracle" people would be loosing their sh*t; because it's
> > >> called "Github" well, that's OK then.
> > >>
> > >> Kinds of reminds me, as a libertarian, as those people who
> > >> are willing to give up some (real) rights and liberties
> > >> for some (perceived) additional security.
> > >>
> > >> I'm not saying that GH isn't useful, but it's not the holy
> > >> grail, nor is it a workflow and platform that we should
> > >> be encouraging the next-gen of developers to swallow hook,
> > >> line and sinker.
> > >
> > >
> > > ​Jim, you sound like someone gave you the impression that they didn't
> > want
> > > ​the wip-us repo to be the primary source of cloudstack code any more.
> I
> > > wonder who and how? I do not care if IBM, Oracle or Microsoft would
> host
> > > mirrors or clones or forks or whatever. On the contrary, it would be an
> > > honour. I am also very pleased to be able to have a fork on github.
> > Besides
> > > all that, how would you plea that the Apache foundation isn't trying to
> > > bind 'em all with a single repository like all the commercial
> > governments,
> > > as well? As a libertarian I don't trust 'not for profit' any more then
> > any
> > > other business objective. The writing above is yet another sound from
> the
> > > board that makes me believe there is discontent and I don't understand.
> > >
> > >
> > > --
> > > ​​
> > >
> > > Daan
> >
> >
>
>
> --
> Daan
>

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1332#issuecomment-201084616
  
_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

### ACS CI BVT Run
 **Sumarry:**
 Build Number 125
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=1
 Skipped=4


**Failed tests:**
* integration.smoke.test_volumes.TestCreateVolume

 * test_01_create_volume Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_loadbalance.TestLoadBalance
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSSION] cloudstackcollab.org

[Pierre-Luc Dion]

Hi,

Since we are going ahead with a CCCNA16 in Montreal, we would like to
revive the website http://cloudstackcollab.org/.  The url is curently
pointing to linuxfoundation events site but our event and the one in
SaoPaolo on September will not use linuxfoundation services :-S

So we were thinking on doing a new site using gohugo, source will be github
too.

Does any one already start some work for the site related to SaoPaolo event?

Does anyone see any problem going forward with a new site ? Help would be
more than welcome :-)

Thanks!

Pierre-Luc

Re: introduction

[Syed Mushtaq]

Welcome back Murali.

On Thu, Mar 24, 2016 at 12:28 PM, Sateesh Chodapuneedi <
sateesh.chodapune...@accelerite.com> wrote:

> Welcome back Murali :)
> Looking forward to work with you.
>
> Regards,
> Sateesh
> Chief Product Engineer, CloudPlatform Development, Accelerite.
> Off: +91 80 6772 1329 | EMail: sateesh.chodapune...@accelerite.com
>
>
> > -Original Message-
> > From: Somesh Naidu [mailto:somesh.na...@citrix.com]
> > Sent: Thursday, March 24, 2016 8:24 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: introduction
> >
> > Good to have you back Murali :)
> >
> > Regards,
> > Somesh
> >
> > -Original Message-
> > From: Kishan Kavala [mailto:kishan.kav...@accelerite.com]
> > Sent: Thursday, March 24, 2016 3:03 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: introduction
> >
> > Welcome back Murali!
> >
> > -Original Message-
> > From: Abhinav Roy [mailto:abhinav@accelerite.com]
> > Sent: 24 March 2016 10:53 AM
> > To: dev@cloudstack.apache.org
> > Subject: RE: introduction
> >
> >
> > Welcome back Murali :)
> >
> > Regards,
> > Abhinav
> >
> > -Original Message-
> > From: Murali Reddy [mailto:murali.re...@shapeblue.com]
> > Sent: Wednesday, March 23, 2016 5:21 PM
> > To: dev@cloudstack.apache.org
> > Subject: introduction
> >
> > All,
> >
> > Just wanted to let the community know that I have decided to work on
> Apache
> > CloudStack again. I have taken up a position at ShapeBlue, so you will
> be seeing
> > me around @dev and @users. For the new members of the community and
> > others who I have not interacted with, here is small self introduction.
> I started
> > my journey with CloudStack, in late 2010 as cloud.com employee. Later
> spent 4
> > years till late 2014 working on various CloudStack features (EIP, GSLB,
> NAAS,
> > NetScaler integration, native SDN controller, distributed virtual
> router, event bus
> > to name few). I was working on NFV solution on OpenStack over a year. I
> am
> > excited to join back the community, looking forward to interact with you.
> >
> > Thanks,
> > Murali
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> the
> > property of Accelerite, a Persistent Systems business. It is intended
> only for the
> > use of the individual or entity to which it is addressed. If you are not
> the
> > intended recipient, you are not authorized to read, retain, copy, print,
> distribute
> > or use this message. If you have received this communication in error,
> please
> > notify the sender and delete all copies of this message. Accelerite, a
> Persistent
> > Systems business does not accept any liability for virus infected mails.
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> the
> > property of Accelerite, a Persistent Systems business. It is intended
> only for the
> > use of the individual or entity to which it is addressed. If you are not
> the
> > intended recipient, you are not authorized to read, retain, copy, print,
> distribute
> > or use this message. If you have received this communication in error,
> please
> > notify the sender and delete all copies of this message. Accelerite, a
> Persistent
> > Systems business does not accept any liability for virus infected mails.
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> the
> > property of Accelerite, a Persistent Systems business. It is intended
> only for the
> > use of the individual or entity to which it is addressed. If you are not
> the
> > intended recipient, you are not authorized to read, retain, copy, print,
> distribute
> > or use this message. If you have received this communication in error,
> please
> > notify the sender and delete all copies of this message. Accelerite, a
> Persistent
> > Systems business does not accept any liability for virus infected mails.
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persistent Systems business does not accept any
> liability for virus infected mails.
>

[GitHub] cloudstack pull request: CLOUDSTACK-9228: Network update with mist...

[bvbharatk]

Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/1333#issuecomment-201016129
  
_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

### ACS CI BVT Run
 **Sumarry:**
 Build Number 124
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=3
 Skipped=4


**Failed tests:**
* integration.smoke.test_loadbalance.TestLoadBalance

 * test_01_create_lb_rule_src_nat Failed

 * test_02_create_lb_rule_non_nat Failed

 * test_assign_and_removal_lb Failed


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_deploy_vgpu_enabled_vm
test_06_copy_template
test_06_copy_iso

**Passed test suits:**
integration.smoke.test_deploy_vm_with_userdata.TestDeployVmWithUserData

integration.smoke.test_affinity_groups_projects.TestDeployVmWithAffinityGroup
integration.smoke.test_portable_publicip.TestPortablePublicIPAcquire
integration.smoke.test_over_provisioning.TestUpdateOverProvision
integration.smoke.test_global_settings.TestUpdateConfigWithScope
integration.smoke.test_guest_vlan_range.TestDedicateGuestVlanRange
integration.smoke.test_scale_vm.TestScaleVm
integration.smoke.test_service_offerings.TestCreateServiceOffering
integration.smoke.test_routers.TestRouterServices
integration.smoke.test_reset_vm_on_reboot.TestResetVmOnReboot
integration.smoke.test_snapshots.TestSnapshotRootDisk

integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners
integration.smoke.test_network.TestDeleteAccount
integration.smoke.test_non_contigiousvlan.TestUpdatePhysicalNetwork
integration.smoke.test_deploy_vm_iso.TestDeployVMFromISO
integration.smoke.test_public_ip_range.TestDedicatePublicIPRange
integration.smoke.test_multipleips_per_nic.TestDeployVM
integration.smoke.test_regions.TestRegions
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup
integration.smoke.test_network_acl.TestNetworkACL
integration.smoke.test_pvlan.TestPVLAN
integration.smoke.test_volumes.TestCreateVolume
integration.smoke.test_ssvm.TestSSVMs
integration.smoke.test_nic.TestNic
integration.smoke.test_deploy_vm_root_resize.TestDeployVM
integration.smoke.test_resource_detail.TestResourceDetail
integration.smoke.test_secondary_storage.TestSecStorageServices
integration.smoke.test_vm_life_cycle.TestDeployVM
integration.smoke.test_disk_offerings.TestCreateDiskOffering


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57369359
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java ---
@@ -211,7 +201,7 @@ public Boolean getDisplayNetwork() {
 
 @Override
 public boolean isDisplay() {
-if(displayNetwork == null)
+if (displayNetwork == null)
--- End diff --

Either add the curly braces per coding conventions or reduce a ternary.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57368469
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigUpdateCmd.java
 ---
@@ -0,0 +1,204 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.QuaggaZoneConfig;
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfigUpdate", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true)
+public class VPCQuaggaConfigUpdateCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(VPCQuaggaConfigUpdateCmd.class.getName());
+private static final String s_name = "vpcquaggaconfigresponse";
--- End diff --

This constant appears to be used only by the ``getName`` method.  Remove 
the constant and in-line to value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57368304
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigUpdateCmd.java
 ---
@@ -0,0 +1,204 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.QuaggaZoneConfig;
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfigUpdate", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true)
+public class VPCQuaggaConfigUpdateCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(VPCQuaggaConfigUpdateCmd.class.getName());
+private static final String s_name = "vpcquaggaconfigresponse";
+
+/
+ API parameters /
+/
+
+@Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID, 
entityType = ZoneResponse.class, required = true, description = "the ID of the 
Zone")
+private Long zoneid;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaProtocol, type = 
CommandType.STRING, required = false, description = "the password used to 
secure inter quagga communication(default ospf)")
+private String quaggaProtocol;
+
+@Parameter(name = QuaggaZoneConfig.s_ospfArea, type = 
CommandType.STRING, required = false, description = "Specify the OSPF Area ID")
+private String ospfArea;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaHelloInterval, type = 
CommandType.SHORT, required = false, description = "Set number of seconds for 
HelloInterval timer value.(default 10)")
+private Short quaggaHelloInterval;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaDeadInterval, type = 
CommandType.SHORT, required = false, description = "Set number of seconds for 
RouterDeadInterval timer value used for Wait Timer and Inactivity 
Timer.(default 40)")
+private Short quaggaDeadInterval;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaRetransmitInterval, type = 
CommandType.SHORT, required = false, description = "Set number of seconds for 
RxmtInterval timer value.(default 5)")
+private Short quaggaRetransmitInterval;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaTransitDelay, type = 
CommandType.SHORT, required = false, description = "Set number of seconds for 
InfTransDelay value.(default 1)")
+private Short quaggaTransitDelay;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaAuthentication, type = 
CommandType.STRING, required = false, description = "Md5 or PlainText (default 
MD5)")
+private String quaggaAuthentication;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaPassword, type = 
CommandType.STRING, required = false, description = "The password used to 
secure inter quagga communication")
+private String quaggaPassword;
+
+@Parameter(name = QuaggaZoneConfig.s_ospfSuperCIDR, type = 
CommandType.STRING, required = false, description = "The super zone level CIDR 
for ospf enabled VPCs")
+private String ospfSuperCIDR;
+
+@Parameter(name = QuaggaZoneConfig.s_quaggaEnabled, type = 
CommandType.BOOLEAN, required = false, description = "The flag to enable or 
disable quagga for this zone")
+private Boolean quaggaEnabled;
+
+

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

[Will Stevens]

Thank you for all the support everyone.  This vote is now closed.  We have
unanimous support for this proposal with the following votes:

Totals
--
+1: 20 (including myself)
+0: 0
-1: 0

I have opened a support ticket with github to get a clearer understanding
of what the process will be to switch the mirror from 'git://
git.apache.org/cloudstack.git' to point to 'apache-cloudstack/cloudstack'
instead of 'apache/cloudstack' after the move.  I have not heard back from
them yet, so I will keep everyone updated with the details they outline
once they get back to me.

I will begin working with the ASF Infra team to work through the technical
and logistical details to make the move.

Cheers,

Will

On Mon, Mar 21, 2016 at 12:56 PM, Erik Weber  wrote:

> +1
>
> Den fredag 18. mars 2016 skrev Will Stevens 
> følgende:
>
> > We are discussing this proposal in 3 or 4 threads, so I will not try to
> > recap everything.  Instead I will try to give a brief overview of the
> > problem and a proposal for solving it.
> >
> > *Problem:*
> > The Apache CloudStack community needs additional github permissions in
> > order to integrate CI for the purpose of maintaining code quality.  The
> ASF
> > does not have enough granular control via the 'apache' github
> organization
> > to give the 'apache/cloudstack' repository the needed permissions.
> >
> > *Proposal:*
> > Transfer ownership of the 'apache/cloudstack' mirrored repository out of
> > the 'apache' github organization into the 'apache-cloudstack' github
> > organization (which I have already setup and started inviting users to).
> > Both members of the ACS community and the ASF board will have 'owner'
> > permissions on this new organization.  This will allow for permissions to
> > be applied specifically to the 'apache-cloudstack' organization and not
> > have to be applied to the entire 'apache' organization.
> >
> > By transferring ownership, all of the PRs will be copied to the new
> > repository and redirects will be created on github from
> 'apache/cloudstack'
> > to 'apache-cloudstack/cloudstack'.
> >
> > The developer workflow and commit workflow will remain unchanged.  The
> > canonical ASF repository (git://git.apache.org/cloudstack.git) will
> remain
> > the source of truth and commits will be made to that repository.
> >
> > Please ask if anything is unclear or needs to be better defined in order
> > for you to cast a vote.
> >
>

[GitHub] cloudstack pull request: CLOUDSTACK-8302: Removing snapshots on RB...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1230#issuecomment-200958562
  
Yes, @kiwiflyer, the naming XenserverSnapshotStrategy appears to be old and 
no longer accurate. I believe it should be renamed to something like 
DefaultSnapshotStrategy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200956335
  
@swill Yes, I'll work on this either today or tomorrow and get a new PR 
submitted.

Thanks guys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57362918
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigUpdateCmd.java
 ---
@@ -0,0 +1,204 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.QuaggaZoneConfig;
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfigUpdate", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true)
--- End diff --

The since should be increased to ``4.9.0.`` since ``4.8.0`` has already 
shipped.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57362722
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfig", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true, responseHasSensitiveInfo = false)
+public class VPCQuaggaConfigCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(VPCQuaggaConfigCmd.class.getName());
+private static final String s_name = "vpcquaggaconfigresponse";
--- End diff --

This constant only appears to be used in the ``getName`` method.  Since it 
used in one place, inline it in ``getName`` and remove the constant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57362292
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfig", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true, responseHasSensitiveInfo = false)
+public class VPCQuaggaConfigCmd extends BaseCmd {
+public static final Logger s_logger = 
Logger.getLogger(VPCQuaggaConfigCmd.class.getName());
--- End diff --

The call to ``getName`` is unnecessary since ``getLogger`` has an override 
for accepting the ``Class`` instance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57362193
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCQuaggaConfigCmd.java ---
@@ -0,0 +1,73 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.admin.vpc;
+
+import java.util.Map;
+
+import javax.inject.Inject;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.VPCQuaggaConfigResponse;
+import org.apache.cloudstack.api.response.ZoneResponse;
+import org.apache.log4j.Logger;
+
+import com.cloud.network.vpc.VpcProvisioningService;
+import com.cloud.user.Account;
+
+@APICommand(name = "vpcQuaggaConfig", description = "Captures config 
informaton for quagga", responseObject = VPCQuaggaConfigResponse.class, since = 
"4.8.0", requestHasSensitiveInfo = true, responseHasSensitiveInfo = false)
--- End diff --

The since should be increased to ``4.9.0.`` since ``4.8.0`` has already 
shipped.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57360954
  
--- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
@@ -49,4 +46,9 @@ public VpcOffering createVpcOffering(String name, String 
displayText, List quaggaConfigUpdate(Long id, String protocol, 
String ospfArea, Short helloInterval, Short deadInterval, Short 
retransmitInterval, Short transitDelay,
+String authentication, String password, String superCIDR, 
Boolean enabled);
+
+Map quaggaConfig(Long id);
--- End diff --

Please rename to conform to  method naming idiom (e.g. 
updateQuaggaConfig).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57360933
  
--- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
@@ -49,4 +46,9 @@ public VpcOffering createVpcOffering(String name, String 
displayText, List quaggaConfigUpdate(Long id, String protocol, 
String ospfArea, Short helloInterval, Short deadInterval, Short 
retransmitInterval, Short transitDelay,
--- End diff --

Please rename to conform to  method naming idiom (e.g. 
updateQuaggaConfig).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57360755
  
--- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
@@ -26,13 +25,11 @@
 
 public VpcOffering getVpcOffering(long vpcOfferingId);
 
-public VpcOffering createVpcOffering(String name, String displayText, 
List supportedServices,
- Map 
serviceProviders,
- Map serviceCapabilitystList,
- Long serviceOfferingId);
+public VpcOffering createVpcOffering(String name, String displayText, 
List supportedServices, Map serviceProviders, Map 
serviceCapabilitystList,
+Long serviceOfferingId);
--- End diff --

This appears to be a spurious formatting change that violates our coding 
standards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57360768
  
--- Diff: api/src/com/cloud/network/vpc/VpcProvisioningService.java ---
@@ -26,13 +25,11 @@
 
 public VpcOffering getVpcOffering(long vpcOfferingId);
 
-public VpcOffering createVpcOffering(String name, String displayText, 
List supportedServices,
- Map 
serviceProviders,
- Map serviceCapabilitystList,
- Long serviceOfferingId);
+public VpcOffering createVpcOffering(String name, String displayText, 
List supportedServices, Map serviceProviders, Map 
serviceCapabilitystList,
+Long serviceOfferingId);
 
-Pair listVpcOfferings(Long id, 
String name, String displayText, List supportedServicesStr, Boolean 
isDefault, String keyword,
-String state, Long startIndex, Long pageSizeVal);
+Pair listVpcOfferings(Long id, 
String name, String displayText, List supportedServicesStr, Boolean 
isDefault, String keyword,
+String state, Long startIndex, Long pageSizeVal);
--- End diff --

This appears to be a spurious formatting change that violates our coding 
standards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57354938
  
--- Diff: api/src/com/cloud/network/vpc/QuaggaZoneConfig.java ---
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.vpc;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.StringUtils;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.utils.net.NetUtils;
+
+public class QuaggaZoneConfig {
+
+private long zoneId;
+private String protocol;
+private String ospfArea;
+private String helloInterval;
+private String deadInterval;
+private String retransmitInterval;
+private String transitDelay;
+private String authentication;
+private String password;
+private String[] ospfSuperCIDRList;
+private String enabled;
--- End diff --

Is ``enabled`` representing a ``boolean`` value?  If so, why are using a 
``String`` to represent it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57354705
  
--- Diff: api/src/com/cloud/network/vpc/QuaggaZoneConfig.java ---
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.vpc;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.StringUtils;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.utils.net.NetUtils;
+
+public class QuaggaZoneConfig {
+
+private long zoneId;
+private String protocol;
+private String ospfArea;
+private String helloInterval;
+private String deadInterval;
+private String retransmitInterval;
+private String transitDelay;
+private String authentication;
+private String password;
+private String[] ospfSuperCIDRList;
--- End diff --

Why are we using an ``Array`` instead of a ``List`` or a ``Set``?  Ideally, 
it seems like we would use a ``Set`` to ensure uniqueness of the CIDRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57354506
  
--- Diff: api/src/com/cloud/network/vpc/QuaggaZoneConfig.java ---
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.vpc;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.StringUtils;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.utils.net.NetUtils;
+
+public class QuaggaZoneConfig {
+
+private long zoneId;
+private String protocol;
+private String ospfArea;
+private String helloInterval;
+private String deadInterval;
+private String retransmitInterval;
+private String transitDelay;
--- End diff --

Assuming ``helloInterval``, ``deadInterval``, ``retransmitInterval`, and 
``transitDelay`` are numeric values, why are they represented using ``String``? 
 Consider refactoring to [Joda-Time](http://www.joda.org/joda-time)'s 
[Duration](http://www.joda.org/joda-time/apidocs/org/joda/time/Duration.html) 
to provide a more precise time and conversion semantics.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200936609
  
Thank you sir.  I really appreciate it.  Once I get my CI online I will be 
able to start getting through this backlog in a much more efficient manner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200931266
  
You are welcome.
I try to go over as many PRs as I can, but I always end up overlooking 
some. You can always ping me on slack or mail to check a PR before a merge.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200926830
  
@rafaelweingartner I agree.  I think it makes the most sense to open a new 
PR to add the exception log.  @kiwiflyer would you mind doing that for us?  
Would you mind giving the output as you did before to show what is displayed in 
the logs when this code is hit? 

Thanks for the quick and quality discussion on this guys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200919876
  
@kiwiflyer, it is nice that we achieved a consensus. 
What do you think @swill?

How do we proceed now? This PR has already been merged and forwarded.
I believe the easiest approach would be to open a new one just adding the 
exceptions to the log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Request for comments : VPC Inline LoadBalancer (new plugin)

[ilya]

Hi Nick,

Being fan of SDN, I gave this proposal a thorough read.

I do have only 1 comment - that you can perhaps can use to reconsider:

"Each appliance will have 2 nics, one for management, and one in the
guest network. "

In general, 2 nics - one going to management and one going to guest - is
looked very negatively upon by internal InfoSec team. This
implementation will make an LB non-compliant from SOX or PCI perspective.

Proposed alternate solution:
Deploy a VM with 2 NICs but put them both on the same guest network (I
believe the support 2 NICs on the *same* guest network has already been
submitted upstream). 1 NIC for MGMT and 1 NIC for GUEST.

Using SDNs ability to restrict communication flow (openvswitch or what
not), only allow specific connections from CloudStack MS to Inline LB on
MGMT NIC. You will need to block all external GUEST communication to
MGMT NIC and only make it talk to CloudStack MS on specific ports.

This approach should preserve the internal compliance and wont raise any
red flags.

Perhaps reach out to a client who requested this feature and ask what
they think, maybe they have not thought this through.

Regards
ilya

PS: If we were to entertain the idea of InLine LB, we would most likely
ask for approach mentioned above.




On 3/24/16 1:18 AM, Nick LIVENS wrote:
> Hi all,
> 
> I'd like to propose a new plugin called the "VPC Inline LB" plugin.
> The design document can be found at :
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61340894
> 
> Looking forward to hear your reviews / thoughts.
> 
> Thanks!
> 
> Kind regards,
> Nick Livens
> 

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200918379
  
@rafaelweingartner Yes, you are correct. I like your suggestion. I'll log 
the exception with the failure.

In terms of the persistent connections, I believe the management server 
pushes to the agents. It also relies on the agent connection to determine 
health information for the agent and the VMs located on each host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57346679
  
--- Diff: api/src/com/cloud/network/vpc/QuaggaZoneConfig.java ---
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.vpc;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.StringUtils;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.utils.net.NetUtils;
+
+public class QuaggaZoneConfig {
+
+private long zoneId;
+private String protocol;
--- End diff --

Assuming that the list of protocols is constrained, why isn't the type an 
enumeration?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57346529
  
--- Diff: api/src/com/cloud/network/vpc/QuaggaZoneConfig.java ---
@@ -0,0 +1,331 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.vpc;
+
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.commons.lang.ArrayUtils;
+import org.apache.commons.lang.StringUtils;
+
+import com.cloud.exception.InvalidParameterValueException;
+import com.cloud.utils.net.NetUtils;
+
+public class QuaggaZoneConfig {
+
+private long zoneId;
+private String protocol;
+private String ospfArea;
+private String helloInterval;
+private String deadInterval;
+private String retransmitInterval;
+private String transitDelay;
+private String authentication;
+private String password;
+private String[] ospfSuperCIDRList;
+private String enabled;
+
+public static final String s_quaggaProtocol = "quaggaprotocol";
+public static final String s_ospfArea = "ospfarea";
+public static final String s_quaggaHelloInterval = 
"quaggahellointerval";
+public static final String s_quaggaDeadInterval = "quaggadeadinterval";
+public static final String s_quaggaRetransmitInterval = 
"quaggaretransmitinterval";
+public static final String s_quaggaTransitDelay = "quaggatransitdelay";
+public static final String s_quaggaAuthentication = 
"quaggaauthentication";
+public static final String s_ospfSuperCIDR = "ospfsupercidr";
+public static final String s_quaggaPassword = "quaggapassword";
+public static final String s_quaggaEnabled = "quaggaenabled";
--- End diff --

Why not collapse these constants into the ``Params`` enumeration with a 
lookup method to return the enumeration value for the parameter key?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1371#discussion_r57346137
  
--- Diff: api/src/com/cloud/network/Network.java ---
@@ -243,7 +245,7 @@ public static Capability getCapability(String 
capabilityName) {
 
 Allocated("Indicates the network configuration is in allocated but 
not setup"), Setup("Indicates the network configuration is setup"), 
Implementing(
 "Indicates the network configuration is being 
implemented"), Implemented("Indicates the network configuration is in use"), 
Shutdown(
-"Indicates the network configuration is being destroyed"), 
Destroy("Indicates that the network is destroyed");
+"Indicates the network configuration is being 
destroyed"), Destroy("Indicates that the network is destroyed");
--- End diff --

This appears to be an unnecessary formatting change that actually misaligns 
the code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200914880
  
Ok,
So, this agent class is executed as a service in the operating system (OS) 
the OS will call a service that calls the main method that instantiates and 
executes that agent right? 

If an exception is thrown and it is not handled properly the agent dies. If 
the agent dies, ACS does not deal with it, right? 

In that case, I would be inclined to accept the infinite loop when starting 
a connection. I would only suggest not hiding the exception there, and logging 
it together with messages at lines 239, 238 and 415.

I just wonder why we need to maintain a connection like this one always 
open. For me, it seems that if we only opened it when sending a command, then 
we could send the command, and after that we could close the connection. 
Therefore, if it is not possible to open a connection we could just lose a 
command. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: introduction

[Sateesh Chodapuneedi]

Welcome back Murali :)
Looking forward to work with you.

Regards,
Sateesh 
Chief Product Engineer, CloudPlatform Development, Accelerite.
Off: +91 80 6772 1329 | EMail: sateesh.chodapune...@accelerite.com 


> -Original Message-
> From: Somesh Naidu [mailto:somesh.na...@citrix.com]
> Sent: Thursday, March 24, 2016 8:24 PM
> To: dev@cloudstack.apache.org
> Subject: RE: introduction
> 
> Good to have you back Murali :)
> 
> Regards,
> Somesh
> 
> -Original Message-
> From: Kishan Kavala [mailto:kishan.kav...@accelerite.com]
> Sent: Thursday, March 24, 2016 3:03 AM
> To: dev@cloudstack.apache.org
> Subject: RE: introduction
> 
> Welcome back Murali!
> 
> -Original Message-
> From: Abhinav Roy [mailto:abhinav@accelerite.com]
> Sent: 24 March 2016 10:53 AM
> To: dev@cloudstack.apache.org
> Subject: RE: introduction
> 
> 
> Welcome back Murali :)
> 
> Regards,
> Abhinav
> 
> -Original Message-
> From: Murali Reddy [mailto:murali.re...@shapeblue.com]
> Sent: Wednesday, March 23, 2016 5:21 PM
> To: dev@cloudstack.apache.org
> Subject: introduction
> 
> All,
> 
> Just wanted to let the community know that I have decided to work on Apache
> CloudStack again. I have taken up a position at ShapeBlue, so you will be 
> seeing
> me around @dev and @users. For the new members of the community and
> others who I have not interacted with, here is small self introduction. I 
> started
> my journey with CloudStack, in late 2010 as cloud.com employee. Later spent 4
> years till late 2014 working on various CloudStack features (EIP, GSLB, NAAS,
> NetScaler integration, native SDN controller, distributed virtual router, 
> event bus
> to name few). I was working on NFV solution on OpenStack over a year. I am
> excited to join back the community, looking forward to interact with you.
> 
> Thanks,
> Murali
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the
> use of the individual or entity to which it is addressed. If you are not the
> intended recipient, you are not authorized to read, retain, copy, print, 
> distribute
> or use this message. If you have received this communication in error, please
> notify the sender and delete all copies of this message. Accelerite, a 
> Persistent
> Systems business does not accept any liability for virus infected mails.
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the
> use of the individual or entity to which it is addressed. If you are not the
> intended recipient, you are not authorized to read, retain, copy, print, 
> distribute
> or use this message. If you have received this communication in error, please
> notify the sender and delete all copies of this message. Accelerite, a 
> Persistent
> Systems business does not accept any liability for virus infected mails.
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the
> use of the individual or entity to which it is addressed. If you are not the
> intended recipient, you are not authorized to read, retain, copy, print, 
> distribute
> or use this message. If you have received this communication in error, please
> notify the sender and delete all copies of this message. Accelerite, a 
> Persistent
> Systems business does not accept any liability for virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200908383
  
@swill  This exception is thrown when the NIO operations used to establish 
the connection to the management server on port 8250 fail.When this exception 
gets thrown, the agent is dead and has to be manually restarted. The tomcat 
container, however, is still up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200906752
  
@rafaelweingartner This is used in both the system VM agent and the host 
(hypervisor) agent.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200905706
  
That is it; 
Well, giving that the “_shell.getBackoffAlgorithm().waitBeforeRetry()” 
uses a parameter that indicates the amount of time between retries, I would try 
for 10-20 times before throwing an exception.
If after “n” times the error keeps happening, I see no reason to keep 
trying. The administrator should be able to see that error and act to solve it.

@ kiwiflyer, I do not know that class. Is that the agent we use in system 
VMs? Or the ones we install in some hypervisors?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200903313
  
so you are basically saying that if the connection can not be established, 
it is not functional anyway, so there is no point in this timing out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200897012
  
I see your point and I agree with you.  What do you think is a reasonable 
amount of time to check before we throw the error?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[kiwiflyer]

Github user kiwiflyer commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200901622
  
I want to point out that this is taking care of the case where you have a 
load balancer between the agents and the management server (see original issue 
notes). I'm personally not convinced that letting an exception be thrown that 
causes the agent to fail, that is most likely caused by an underlying network 
connectivity issue is a great solution either. Tomcat doesn't get taken down, 
so the agent container is functional, but the application is dead.

If a set number of retries is added, there has to be a clean termination of 
the agent so some other health checking application can restart the agent, 
without requiring manual intervention (very painful if you have lots of hosts).





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200888647
  
The test output you mean was the one posted by @kiwiflyer ?
I had not reviewed this PR (sorry for that), but there are two (2) things 
here that called my attention.

At class “Agent.java” lines, 230, 238 and 451, (despite being the very 
same piece of code) I worry about the exception that is not being logged. I 
mean, we will see that message, but the exception stack that might be useful 
for debugging will not be logged.

Additionally, the code between lines 232 and 239, it seems that it might 
occur an infinite loop there (before the commit the throw new 
CloudRuntimeException would break it). I know that when we deal with a 
connection to a resource, there are hundreds of things that can go wrong and 
sometimes if we try once or twice it might solve the problem. However, a code 
that may enter into an infinite loop with a hidden exception does not sound a 
neat solution for me. 

Would not it be better to retry a few times and then, if nothing changes, 
let an exception happens to break that flow of execution?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200884247
  
i will make sure that integration test are run against everything going 
forward.  this judgment call may have been premature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1430


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200883526
  
output was posted for test run against master and 4.7.  maybe I jumped the 
gun?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9285 for 4.7.x

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1430#issuecomment-200882489
  
this was merged without functional tests (integration tests)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: introduction

[Somesh Naidu]

Good to have you back Murali :)

Regards,
Somesh

-Original Message-
From: Kishan Kavala [mailto:kishan.kav...@accelerite.com] 
Sent: Thursday, March 24, 2016 3:03 AM
To: dev@cloudstack.apache.org
Subject: RE: introduction

Welcome back Murali!

-Original Message-
From: Abhinav Roy [mailto:abhinav@accelerite.com] 
Sent: 24 March 2016 10:53 AM
To: dev@cloudstack.apache.org
Subject: RE: introduction


Welcome back Murali :)

Regards,
Abhinav

-Original Message-
From: Murali Reddy [mailto:murali.re...@shapeblue.com] 
Sent: Wednesday, March 23, 2016 5:21 PM
To: dev@cloudstack.apache.org
Subject: introduction

All,

Just wanted to let the community know that I have decided to work on Apache 
CloudStack again. I have taken up a position at ShapeBlue, so you will be 
seeing me around @dev and @users. For the new members of the community and 
others who I have not interacted with, here is small self introduction. I 
started my journey with CloudStack, in late 2010 as cloud.com employee. Later 
spent 4 years till late 2014 working on various CloudStack features (EIP, GSLB, 
NAAS, NetScaler integration, native SDN controller, distributed virtual router, 
event bus to name few). I was working on NFV solution on OpenStack over a year. 
I am excited to join back the community, looking forward to interact with you.

Thanks,
Murali



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57319355
  
--- Diff: server/test/com/cloud/network/IpAddressManagerTest.java ---
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.rules.StaticNat;
+import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.utils.net.Ip;
+
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.mockito.Mockito.anyLong;
+import static org.mockito.Mockito.mock;
+
+public class IpAddressManagerTest {
+
+@Mock
+IPAddressDao _ipAddrDao;
+
+@InjectMocks
+IpAddressManagerImpl _ipManager;
+
+@Before
+public void setup() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+public void testGetStaticNatSourceIps() {
+String publicIpAddress = "192.168.1.3";
+IPAddressVO vo = mock(IPAddressVO.class);
+when(vo.getAddress()).thenReturn(new Ip(publicIpAddress));
+when(vo.getId()).thenReturn(1l);
+
+when(_ipAddrDao.findById(anyLong())).thenReturn(vo);
+StaticNat snat = new StaticNatImpl(1, 1, 1, 1, publicIpAddress, 
false);
+
+List ips = 
_ipManager.getStaticNatSourceIps(Collections.singletonList(snat));
+Assert.assertNotNull(ips);
+Assert.assertEquals(1, ips.size());
+
--- End diff --

You do not use JUnit for that.
You use your mock API such as easy mock or mockito that we use here.

you can do something like this:
Mockito.verify(mock, Mockito.times(1)).method(parameter);


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57317877
  
--- Diff: server/test/com/cloud/network/IpAddressManagerTest.java ---
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.rules.StaticNat;
+import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.utils.net.Ip;
+
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.mockito.Mockito.anyLong;
+import static org.mockito.Mockito.mock;
+
+public class IpAddressManagerTest {
+
+@Mock
+IPAddressDao _ipAddrDao;
+
+@InjectMocks
+IpAddressManagerImpl _ipManager;
+
+@Before
+public void setup() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+public void testGetStaticNatSourceIps() {
+String publicIpAddress = "192.168.1.3";
+IPAddressVO vo = mock(IPAddressVO.class);
+when(vo.getAddress()).thenReturn(new Ip(publicIpAddress));
+when(vo.getId()).thenReturn(1l);
+
+when(_ipAddrDao.findById(anyLong())).thenReturn(vo);
+StaticNat snat = new StaticNatImpl(1, 1, 1, 1, publicIpAddress, 
false);
+
+List ips = 
_ipManager.getStaticNatSourceIps(Collections.singletonList(snat));
+Assert.assertNotNull(ips);
+Assert.assertEquals(1, ips.size());
+
--- End diff --

How is it possible to do that with JUnit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57313299
  
--- Diff: server/test/com/cloud/network/IpAddressManagerTest.java ---
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import com.cloud.network.dao.IPAddressDao;
+import com.cloud.network.dao.IPAddressVO;
+import com.cloud.network.rules.StaticNat;
+import com.cloud.network.rules.StaticNatImpl;
+import com.cloud.utils.net.Ip;
+
+import static org.mockito.Mockito.when;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.mockito.Mockito.anyLong;
+import static org.mockito.Mockito.mock;
+
+public class IpAddressManagerTest {
+
+@Mock
+IPAddressDao _ipAddrDao;
+
+@InjectMocks
+IpAddressManagerImpl _ipManager;
+
+@Before
+public void setup() {
+MockitoAnnotations.initMocks(this);
+}
+
+@Test
+public void testGetStaticNatSourceIps() {
+String publicIpAddress = "192.168.1.3";
+IPAddressVO vo = mock(IPAddressVO.class);
+when(vo.getAddress()).thenReturn(new Ip(publicIpAddress));
+when(vo.getId()).thenReturn(1l);
+
+when(_ipAddrDao.findById(anyLong())).thenReturn(vo);
+StaticNat snat = new StaticNatImpl(1, 1, 1, 1, publicIpAddress, 
false);
+
+List ips = 
_ipManager.getStaticNatSourceIps(Collections.singletonList(snat));
+Assert.assertNotNull(ips);
+Assert.assertEquals(1, ips.size());
+
--- End diff --

I would also add a check here to confirm that the ipAddrDao was called only 
once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1450#issuecomment-200825346
  
It is always great to see parts of a bigger method being extracted to 
smaller ones, and then test cases and java docs being used.

I believe the tests like you did are ok, I would only add another assert 
there as I pointed out at line 67 of the test class.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9317: Enable/disable static NA...

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1450#discussion_r57313534
  
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -1698,6 +1698,22 @@ public String acquireGuestIpAddress(Network network, 
String requestedIp) {
 
 Random _rand = new Random(System.currentTimeMillis());
 
+/**
+ * Get the list of public IPs that need to be applied for a static NAT 
enable/disable operation.
+ * Manipulating only these ips prevents concurrency issues when 
disabling static nat at the same time.
+ * @param staticNats
+ * @return The list of IPs that need to be applied for the static NAT 
to work.
+ */
+public List getStaticNatSourceIps(List staticNats) {
+List userIps = new ArrayList<>();
+
+for (StaticNat snat : staticNats) {
+
userIps.add(_ipAddressDao.findById(snat.getSourceIpAddressId()));
+}
+
+return userIps;
+}
+
 @Override
 public boolean applyStaticNats(List staticNats, 
boolean continueOnError, boolean forRevoke) throws ResourceUnavailableException 
{
 if (staticNats == null || staticNats.size() == 0) {
--- End diff --

I know this is not your code; but, what about changing "staticNats == null 
|| staticNats.size() == 0" to "CollectionUtils.isEmpty(staticNats)"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Migrating CloudStack content from download.cloud.com

[Wido den Hollander]

> Op 24 maart 2016 om 13:33 schreef Raja Pullela :
> 
> 
> Hi,
> 
> Citrix has been hosting   "download.cloud.com"  for  quite  some time  now
>  and  it holds  the  System Templates for all the releases and  some  tools.
>   Going forward,  this  content  needs  to  be  moved  from
> "download.cloud.com".So, we will be moving  this content  to
>  "cloudstack.accelerite.com".I  will also be  updating  the  links in the
>  documentation  to reflect  these  changes and will provide an update  once
>  the  content  move  is complete.
> 
> @Wido, if you could also copy this content to "cloudstack.apt-get.eu"  that
>  will be great.  I can provide you the details in a separate email.

Super! If you have a rsync source I will set it up.

Wido

> 
> Best,
> Raja
> Senior Manager, Product Development,
> Accelerite,
> www.accelerite.com
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the
> property of Accelerite, a Persistent Systems business. It is intended only for
> the use of the individual or entity to which it is addressed. If you are not
> the intended recipient, you are not authorized to read, retain, copy, print,
> distribute or use this message. If you have received this communication in
> error, please notify the sender and delete all copies of this message.
> Accelerite, a Persistent Systems business does not accept any liability for
> virus infected mails.

Migrating CloudStack content from download.cloud.com

[Raja Pullela]

Hi,

Citrix has been hosting   "download.cloud.com"  for  quite  some time  now  and 
 it holds  the  System Templates for all the releases and  some  tools.   Going 
forward,  this  content  needs  to  be  moved  from "download.cloud.com".
So, we will be moving  this content  to  "cloudstack.accelerite.com".I  
will also be  updating  the  links in the  documentation  to reflect  these  
changes and will provide an update  once  the  content  move  is complete.

@Wido, if you could also copy this content to "cloudstack.apt-get.eu"  that  
will be great.  I can provide you the details in a separate email.

Best,
Raja
Senior Manager, Product Development,
Accelerite,
www.accelerite.com




DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.

[DISCUSS] Request for comments : VPC Inline LoadBalancer (new plugin)

[Nick LIVENS]

Hi all,

I'd like to propose a new plugin called the "VPC Inline LB" plugin.
The design document can be found at :
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61340894

Looking forward to hear your reviews / thoughts.

Thanks!

Kind regards,
Nick Livens

RE: introduction

[Kishan Kavala]

Welcome back Murali!

-Original Message-
From: Abhinav Roy [mailto:abhinav@accelerite.com] 
Sent: 24 March 2016 10:53 AM
To: dev@cloudstack.apache.org
Subject: RE: introduction


Welcome back Murali :)

Regards,
Abhinav

-Original Message-
From: Murali Reddy [mailto:murali.re...@shapeblue.com] 
Sent: Wednesday, March 23, 2016 5:21 PM
To: dev@cloudstack.apache.org
Subject: introduction

All,

Just wanted to let the community know that I have decided to work on Apache 
CloudStack again. I have taken up a position at ShapeBlue, so you will be 
seeing me around @dev and @users. For the new members of the community and 
others who I have not interacted with, here is small self introduction. I 
started my journey with CloudStack, in late 2010 as cloud.com employee. Later 
spent 4 years till late 2014 working on various CloudStack features (EIP, GSLB, 
NAAS, NetScaler integration, native SDN controller, distributed virtual router, 
event bus to name few). I was working on NFV solution on OpenStack over a year. 
I am excited to join back the community, looking forward to interact with you.

Thanks,
Murali



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.



DISCLAIMER
==
This e-mail may contain privileged and confidential information which is the 
property of Accelerite, a Persistent Systems business. It is intended only for 
the use of the individual or entity to which it is addressed. If you are not 
the intended recipient, you are not authorized to read, retain, copy, print, 
distribute or use this message. If you have received this communication in 
error, please notify the sender and delete all copies of this message. 
Accelerite, a Persistent Systems business does not accept any liability for 
virus infected mails.