[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1654
  
There seems to be build failure around db path or marvin, I can check this 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1654
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1654
  
LGTM
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin issue #40: index.po and ui.po translated in FR

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack-docs-admin/pull/40
  
@milamber can you take a look at this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Eliminating Support for Ubuntu 12.04

[Wido den Hollander]

> Op 23 augustus 2016 om 1:02 schreef John Burwell :
> 
> 
> All,
> 
> PR 1647 [1] proposes dropping support for Ubuntu 12.04 from 4.9.2.0+.  The 
> primary motivation for its removal is that the age of its libvirt and qemu 
> versions greatly complicate maintenance of the KVM integration.  However, 
> Ubuntu 12.04 will be supported until April 2017 [2]. What would be the impact 
> to our user community of removing support for Ubuntu 12.04 before its EOL in 
> April 2017?  If we don’t drop support for it in 4.x, would it be acceptable 
> to drop support for it in 5.0.0 which is currently scheduled for release at 
> the end of 2016 [3]?
> 

The PR was supposed to go into 4.9 already, it just took way to long to get 
merged. So that's why it would now go into 4.9.2

> If we do chose to drop support for Ubuntu 12.04 in 4.x, I propose that we 
> remove it in 4.10.0.0 rather than 4.9.2.0.  First, it is reasonable for users 
> to expect that upgrading between patch releases (i.e. 4.9.x.x -> 4.9.x+1.x) 
> would not require system changes.  Dropping a distribution would violate such 
> an expectation.  Second, 4.9 is an LTS branch.  Therefore, maintaining 12.04 
> support in 4.9 would provide LTS users with support for Ubuntu 12.04 until 
> May 2018 — well after its EOL.  Does this approach seem reasonable if we 
> elect drop Ubuntu 12.04 in 4.x?

Again, this PR had to be merged earlier, not later. It's just very difficult 
packaging wise to keep supporting 12.04 and 16.04 at the same time.

The Qemu and libvirt versions in 12.04 are truly ancient. I doubt anybody is 
running stock 12.04 with CloudStack 4.8 right now for example.

The Ubuntu 12.04 debate has been popping up multiple times in the last year.

This PR has been open way to long, that's imho the main problem here.

I'm in favor of dropping 12.04, should have been done in 4.9 already and not 
wait any longer.

Wido

> 
> Thanks,
> -John
> 
> [1]: https://github.com/apache/cloudstack/pull/1647
> [2]: https://wiki.ubuntu.com/Releases
> [3]: 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BPROPOSAL%5D+2016-2017+Release+Cycle+and+Calendar
> 
> 
> 
> john.burw...@shapeblue.com 
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
> @shapeblue
>   
>  
>

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  

@jburwell I repush with force, but the build error still alive on Travis
"> Processing SQL file at 
/home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql

Unable to execute 
/home/travis/build/apache/cloudstack/developer/target/db/templates.simulator.sql:
 Unknown column 'state' in 'field list'"

I suppose it's an issue on 4.8 branch? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
There should be only one default VPC offering, unless I am missing out 
something obvious :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
Also since the automated test coverage of this area is less, changes should 
be made after taking into account all possible scenarios. Otherwise there might 
be regressions in some valid scenarios. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@jburwell The issue that has been reported is on a custom branch, probably 
@marcaurele needs to cherry-pick some additional commits from ACS. Master/4.9 
doesn't have this issue, so in that way the PR is not needed.

@marcaurele Please read my last comment again and go through the restart() 
method logic in HA manager code.
>>> If the management server cannot determine the state of the VM, it could 
mark them as stopped (even though I don't think it should). But it should not 
create a StopVM job, because that might trigger a proper stop of the VM if the 
agent is reconnecting while the job is picked by async job workers.
The above is not correct. If the MS is not able to determine the state of 
the VM, it tries fencing off the VM (using the various fencers available). If 
VM cannot be fenced off successfully, the state of the VM is left unchanged. 
Also if any of the investigators is able to determine the VM state as Down then 
only the VM is marked as stopped. Hope that clarifies things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1654: Updating pom.xml version numbers for release ...

[jburwell]

GitHub user jburwell opened a pull request:

https://github.com/apache/cloudstack/pull/1654

Updating pom.xml version numbers for release 4.8.2.0-SNAPSHOT

Adopt the new four position version number for the 4.8.2.0 release.

Signed-off-by: John Burwell 

/cc @rhtyd @karuturi

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack jsb/4.8.2.0-version

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1654.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1654


commit 214c4db4f614ebe2a9d7fc1afaf4b7a10244e013
Author: John Burwell 
Date:   2016-08-23T04:29:20Z

Updating pom.xml version numbers for release 4.8.2.0-SNAPSHOT

Signed-off-by: John Burwell 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
@kiwiflyer are there Marvin tests that verify this behavior?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
If possible, I would like to get this fix into 4.8.2.0/4.9.1.0, but I will 
be cutting the RC shortly.

@ProjectMoon could you please amend your commit message to include the JIRA 
ticket ID and an explanation of the motivation for the change?

@rhtyd @borisstoyanov can we push this PR through Trillian with smoke tests 
and the following test suites:

* ``test_redundant_router_cleanups``
* ``test_redundant_router_services`` 
* ``test_redundant_router_upgrades``

@murali-reddy Do you think we need to run any other test VR test cases for 
proper regression testing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
@nathanejohnson please amend your commit message to explain the change(s) 
made and their motivation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

[B Prakash]

Hi Rohit,  thank you!  I am using the main master branch.  I have all the 
latest files.  I am having this problem only since last few weeks, earlier my 
build was running fine.I tried this and I still have the same problem.  I 
will will install nonoss deps and try again, meanwhile, following is the build 
error I have now;



Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-client/3.1.3/xmlrpc-client-3.1.3.jar
 (58 KB at 681.0 KB/sec)
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/xmlrpc/xmlrpc-common/3.1.3/xmlrpc-common-3.1.3.jar
 (107 KB at 1005.4 KB/sec)
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:13 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:15:21 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:30:55 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: No route to host
Aug 22, 2016 9:31:06 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
Downloaded: 
https://repo.maven.apache.org/maven2/org/apache/ws/commons/util/ws-commons-util/1.0.2/ws-commons-util-1.0.2.jar
 (34 KB at 0.0 KB/sec)
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: I/O exception (java.net.SocketException) caught when processing request 
to {s}->https://repo.maven.apache.org:443: Connection timed out
Aug 22, 2016 9:46:47 PM 
org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec 
execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443


Thanks and regards,

 B Prakash



From: Rohit Yadav 
Sent: Monday, August 22, 2016 1:04 PM
To: dev@cloudstack.apache.org
Subject: Re: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi B, how are you building CloudStack? Which branch is it?

Can you try a full clean build: mvn clean install -Dnoredist -Dsimulator -P 
developer,systemvm

You may install nonoss dependencies from here: 
https://github.com/rhtyd/cloudstack-nonoss
[https://avatars1.githubusercontent.com/u/95203?v=3&s=400]

GitHub - rhtyd/cloudstack-nonoss: Apache CloudStack - Non 
...
github.com
cloudstack-nonoss - Apache CloudStack - Non OSS libraries ... Clone with HTTPS 
Use Git or checkout with SVN using the web URL.





Regards.


From: B Prakash 
Sent: 22 August 2016 21:17:50
To: dev@cloudstack.apache.org
Subject: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi, I am unable to compile latest source due to the following error, please can 
someone help me with this?

[ERROR] Failed to execute goal com.mycila:license-maven-plugin:2.11:check 
(cloudstack-checklicence) on project cloud-plugin-network-nvp: Execution 
cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check 
failed: Plugin com.mycila:license-maven-plugin:2.11 or one of its dependencies 
could not be resolved: Could not transfer artifact 
javax.enterprise:cdi-api:jar:1.0 from/to central 
(https://repo.maven.apache.org/maven2): Connection timed out -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
[ERROR]
[ERROR] After correcting th

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1624
  
@ProjectMoon I would like to get this PR merged for the 4.8.2.0 release, 
but I need to cut an RC ASAP.  Will it be possible for you to address the PR 
comments in time?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1591: Updating Alert codes

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1591
  
I would like to get this PR merged as part of the 4.8.2.0 release, but we 
don't have much time to get it completed.

@dcarbone could you please create a JIRA ticket explaining the 
bug/enhancement motivation of this PR?  Also, could you please investigate the 
cause of the Travis build failure?

@rhtyd were you able to complete your analysis?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1636: Fix a quote issue with Spanish L10N (from transifex ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1636
  
@milamberspace the Jenkins build build failed.  Could you please force push 
the change to trigger another attempt?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1407: 4.8.0 fix i18n es

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1407
  
@ntavares am I correct in understanding that this PR fixes a bug in 4.8?  
If so, could you please rebase and retarget this PR to the 4.8 branch?  The fix 
will be forward merged to 4.9 and master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1650
  
We tried macchinina template during test cases on ESX with E1000 adapter 
and VMs doesn't come with eth0 causing test_internal_lb.py and test_vpc_vpn.py 
to fail on a real hypervisor test. Has anyone actually tried it running on 
Vmware?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
@jburwell The support for passing vGPU parameters is already implemented 
via PR1310 which has  a test  case. This PR is only performance optimization by 
reducing an extra reconfgtask which save about 5 sec during VM startup.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1650
  
@abhinandanprateek are these two test suites where we should be using 
``vm.instance`` config variable instead specifying the template directly in the 
test suite?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

[serg38]

Github user serg38 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1605#discussion_r75796954
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2042,49 +2043,46 @@ protected void 
postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, Virtu
  * Search for vm video card iterating through vm device list
  * @param vmMo virtual machine mo
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
  */
-private void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize) throws Exception {
+protected void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec) throws Exception {
 for (VirtualDevice device : vmMo.getAllDeviceList()){
 if (device instanceof VirtualMachineVideoCard){
 VirtualMachineVideoCard videoCard = 
(VirtualMachineVideoCard) device;
-modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize);
+modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize, 
vmConfigSpec);
 }
 }
 }
 
 /**
- * Modifies vm vram size if it was set to a different size to the one 
provided in svga.vramSize (user_vm_details or template_vm_details)
+ * Modifies vm vram size if it was set to a different size to the one 
provided in svga.vramSize (user_vm_details or template_vm_details) on {@code 
vmConfigSpec}
  * @param videoCard vm's video card device
  * @param vmMo virtual machine mo
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
  */
-private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard 
videoCard, VirtualMachineMO vmMo, long svgaVmramSize) throws Exception {
+private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard 
videoCard, VirtualMachineMO vmMo, long svgaVmramSize, VirtualMachineConfigSpec 
vmConfigSpec) throws Exception {
 if (videoCard.getVideoRamSizeInKB().longValue() != svgaVmramSize){
 s_logger.info("Video card memory was set " + 
videoCard.getVideoRamSizeInKB().longValue() + "kb instead of " + svgaVmramSize 
+ "kb");
-VirtualMachineConfigSpec newSizeSpecs = 
configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize);
-boolean res = vmMo.configureVm(newSizeSpecs);
-if (res) {
-s_logger.info("Video card memory successfully updated to " 
+ svgaVmramSize + "kb");
-}
+configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize, 
vmConfigSpec);
 }
 }
 
 /**
- * Returns a VirtualMachineConfigSpec to edit its svga vram size
+ * Add edit spec on {@code vmConfigSpec} to modify svga vram size
  * @param videoCard video card device to edit providing the svga vram 
size
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine spec
  */
-private VirtualMachineConfigSpec 
configSpecVideoCardNewVRamSize(VirtualMachineVideoCard videoCard, long 
svgaVmramSize){
+private void configSpecVideoCardNewVRamSize(VirtualMachineVideoCard 
videoCard, long svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec){
 videoCard.setVideoRamSizeInKB(svgaVmramSize);
 videoCard.setUseAutoDetect(false);
 
 VirtualDeviceConfigSpec arrayVideoCardConfigSpecs = new 
VirtualDeviceConfigSpec();
 arrayVideoCardConfigSpecs.setDevice(videoCard);
 
arrayVideoCardConfigSpecs.setOperation(VirtualDeviceConfigSpecOperation.EDIT);
 
-VirtualMachineConfigSpec changeVideoCardSpecs = new 
VirtualMachineConfigSpec();
-
changeVideoCardSpecs.getDeviceChange().add(arrayVideoCardConfigSpecs);
-return changeVideoCardSpecs;
+vmConfigSpec.getDeviceChange().add(arrayVideoCardConfigSpecs);
--- End diff --

I don't think so. Device change done in the structure locally  and 
exception  occurs during the VM reconfiguration on the hypervisor if anything 
in the config is wrong. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
@nvazquez could you please create Marvin test case to verify the use case 
in the PR description?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1605#discussion_r75796008
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2042,49 +2043,46 @@ protected void 
postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, Virtu
  * Search for vm video card iterating through vm device list
  * @param vmMo virtual machine mo
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
  */
-private void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize) throws Exception {
+protected void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec) throws Exception {
 for (VirtualDevice device : vmMo.getAllDeviceList()){
 if (device instanceof VirtualMachineVideoCard){
 VirtualMachineVideoCard videoCard = 
(VirtualMachineVideoCard) device;
-modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize);
+modifyVmVideoCardVRamSize(videoCard, vmMo, svgaVmramSize, 
vmConfigSpec);
 }
 }
 }
 
 /**
- * Modifies vm vram size if it was set to a different size to the one 
provided in svga.vramSize (user_vm_details or template_vm_details)
+ * Modifies vm vram size if it was set to a different size to the one 
provided in svga.vramSize (user_vm_details or template_vm_details) on {@code 
vmConfigSpec}
  * @param videoCard vm's video card device
  * @param vmMo virtual machine mo
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
  */
-private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard 
videoCard, VirtualMachineMO vmMo, long svgaVmramSize) throws Exception {
+private void modifyVmVideoCardVRamSize(VirtualMachineVideoCard 
videoCard, VirtualMachineMO vmMo, long svgaVmramSize, VirtualMachineConfigSpec 
vmConfigSpec) throws Exception {
 if (videoCard.getVideoRamSizeInKB().longValue() != svgaVmramSize){
 s_logger.info("Video card memory was set " + 
videoCard.getVideoRamSizeInKB().longValue() + "kb instead of " + svgaVmramSize 
+ "kb");
-VirtualMachineConfigSpec newSizeSpecs = 
configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize);
-boolean res = vmMo.configureVm(newSizeSpecs);
-if (res) {
-s_logger.info("Video card memory successfully updated to " 
+ svgaVmramSize + "kb");
-}
+configSpecVideoCardNewVRamSize(videoCard, svgaVmramSize, 
vmConfigSpec);
 }
 }
 
 /**
- * Returns a VirtualMachineConfigSpec to edit its svga vram size
+ * Add edit spec on {@code vmConfigSpec} to modify svga vram size
  * @param videoCard video card device to edit providing the svga vram 
size
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine spec
  */
-private VirtualMachineConfigSpec 
configSpecVideoCardNewVRamSize(VirtualMachineVideoCard videoCard, long 
svgaVmramSize){
+private void configSpecVideoCardNewVRamSize(VirtualMachineVideoCard 
videoCard, long svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec){
 videoCard.setVideoRamSizeInKB(svgaVmramSize);
 videoCard.setUseAutoDetect(false);
 
 VirtualDeviceConfigSpec arrayVideoCardConfigSpecs = new 
VirtualDeviceConfigSpec();
 arrayVideoCardConfigSpecs.setDevice(videoCard);
 
arrayVideoCardConfigSpecs.setOperation(VirtualDeviceConfigSpecOperation.EDIT);
 
-VirtualMachineConfigSpec changeVideoCardSpecs = new 
VirtualMachineConfigSpec();
-
changeVideoCardSpecs.getDeviceChange().add(arrayVideoCardConfigSpecs);
-return changeVideoCardSpecs;
+vmConfigSpec.getDeviceChange().add(arrayVideoCardConfigSpecs);
--- End diff --

Is it possible for ``getDeviceChange`` to return ``null``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1605#discussion_r75795908
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -2042,49 +2043,46 @@ protected void 
postVideoCardMemoryConfigBeforeStart(VirtualMachineMO vmMo, Virtu
  * Search for vm video card iterating through vm device list
  * @param vmMo virtual machine mo
  * @param svgaVmramSize new svga vram size (in KB)
+ * @param vmConfigSpec virtual machine config spec
  */
-private void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize) throws Exception {
+protected void setNewVRamSizeVmVideoCard(VirtualMachineMO vmMo, long 
svgaVmramSize, VirtualMachineConfigSpec vmConfigSpec) throws Exception {
--- End diff --

``throws Exception`` is ambiguous.  Please refine to the specific checked 
exceptions that can be thrown by ``setNewVRamSizeVmVideoCard``.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@nvazquez could you please squash your commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1593#discussion_r75795653
  
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase 
checkCase) throws SQLException
 try (PreparedStatement pstmt = 
conn.prepareStatement(checkCase.sqlTemplate)) {
 if(checkCase.checkId) {
 pstmt.setInt(1, lastId);
-pstmt.setInt(2, maxId);
+if (maxId > 0) {
+pstmt.setInt(2, maxId);
+}
--- End diff --

@nvazquez I understand now.  When ``maxId <= 0`` a different prepared 
statement will be used which has only one placeholder.  A bit convoluted, but 
you are just working with the existing complexity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1646
  
@rhtyd I understand the reasoning for two commits, and it makes sense.  
Since you understand the process required for the forward merge, I think it 
makes sense for you to perform it.

LGTM for code.

@karuturi @swill @wido are you able to provide a test LGTM?  This PR is a 
blocker for cutting the 4.9.1.0 release candidate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1653#discussion_r75794286
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -452,9 +452,9 @@ def fw_vpcrouter(self):
 self.fw.append(
 ["filter", "", "-A INPUT -i %s -p udp -m udp --dport 67 -j 
ACCEPT" % self.dev])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
--- End diff --

@rhtyd I agree that keeping it limited to the scope of the PR is the most 
pragmatic approach.  The intention of my comment was to encourage test case 
improvement  in small increments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
@rhtyd thanks for the clarification of the commit message.  However, the 
Travis failed for the commit.  Could you please investigate and fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1643
Job ID-96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1645
Job ID-97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1635: CLOUDSTACK-9451

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1635
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1635
Job ID-95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Eliminating Support for Ubuntu 12.04

[John Burwell]

All,

PR 1647 [1] proposes dropping support for Ubuntu 12.04 from 4.9.2.0+.  The 
primary motivation for its removal is that the age of its libvirt and qemu 
versions greatly complicate maintenance of the KVM integration.  However, 
Ubuntu 12.04 will be supported until April 2017 [2]. What would be the impact 
to our user community of removing support for Ubuntu 12.04 before its EOL in 
April 2017?  If we don’t drop support for it in 4.x, would it be acceptable to 
drop support for it in 5.0.0 which is currently scheduled for release at the 
end of 2016 [3]?

If we do chose to drop support for Ubuntu 12.04 in 4.x, I propose that we 
remove it in 4.10.0.0 rather than 4.9.2.0.  First, it is reasonable for users 
to expect that upgrading between patch releases (i.e. 4.9.x.x -> 4.9.x+1.x) 
would not require system changes.  Dropping a distribution would violate such 
an expectation.  Second, 4.9 is an LTS branch.  Therefore, maintaining 12.04 
support in 4.9 would provide LTS users with support for Ubuntu 12.04 until May 
2018 — well after its EOL.  Does this approach seem reasonable if we elect drop 
Ubuntu 12.04 in 4.x?

Thanks,
-John

[1]: https://github.com/apache/cloudstack/pull/1647
[2]: https://wiki.ubuntu.com/Releases
[3]: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BPROPOSAL%5D+2016-2017+Release+Cycle+and+Calendar



john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido While I understand that it is quite old and presents maintenance 
challenges, it remains supported until [April 
2017](https://wiki.ubuntu.com/Releases).  Therefore, it would be reasonable for 
users to expect us to continue to support it until EOL.  I have opened 
conversation on dev@ and user@ in an effort to determine the impact (if any) to 
users post 4.9.  

In the meantime, would it be possible to split this PR into Ubuntu 16.04 
support and removal of Ubuntu 12.04 support?  If we decide to remove it, I 
propose that we introduce it in the 4.10.x release.  Not only is 4.9 an LTS 
branch, it doesn't seem reasonable to drop support for a distribution in a 
patch release (i.e. 4.9.0.0 supports Ubuntu 12.04 and 4.9.1.0 does not).  
Conversely, Ubuntu 16.04 support seems like a worthy addition to LTS.  
Splitting these two issues will provide the flexibility to implement such 
removal of Ubuntu 12.04 in 4.10.x and the addition of Ubuntu 16.04 in 4.9.x+.  
Does this approach seem reasonable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1599
  
@rhtyd thanks for the expanded commit message.  The change makes complete 
sense to me now.  LGTM for code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@mike-tutkowski determining the required tests to run for a PR is at the 
top of my TODO list.  For now,   I would say running all smoke tests and 
associated component tests on hardware would be required for this PR.

As an aside, do we have Marvin test cases to verify this enhancement?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
@rhtyd the test results from blueorangutan are looking pretty good.  A 
couple of observations:

1. The markdown for the table seems to be invalid as it is not rendering to 
a table
2. Would it be possible to sort the rows in Failure, Skip, Success order?  
We are most interested in failures and skips.  Placing them at the top will 
speed visual scanning up a bit.
3.  Include a summary of the environment used to run the tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@marcaurele per @koushik-das, what is the issue with re-pointing this PR to 
the 4.9 release branch?  When the PR is merged, it will be forward merged to 
master.  Therefore, the concern you expressed about the change getting to 
master is not an issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@marcaurele I agree that an ``UNKNOWN`` state is proper way to handle a 
network partition.  As an example, out-of-band management uses this approach 
which the management server loses connectivity with the IPMI interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stop...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1640#discussion_r75758946
  
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work) {
 
 boolean fenced = false;
 if (alive == null) {
-s_logger.debug("Fencing off VM that we don't know the 
state of");
+s_logger.debug("Fencing off VM " + vm + " that we 
don't know the state of");
--- End diff --

In my view, the ``Supplier`` approach is just as complex, but in another 
way.  In the long term, we will be adopting SLF4J which supports string 
templates -- allowing constructs as such as:

```
LOG.debug("I am having a problem VM %s", vm.getId());
```

This approach defers string concatenation in a more straight forward manner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #:

[serg38]

Github user serg38 commented on the pull request:


https://github.com/apache/cloudstack/commit/db854a35790c77099e9f82a4e2dd77edd5be3eed#commitcomment-18732552
  
Don't you need to put a space in from of 0 to exclude e.g 100% packet loss ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Trillian test result (trillian-pr1653-36-vmware-55u3-cs49): 
Test completed. 32 look ok, 20 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | Success | 428.373
test_create_pvlan_network | Success | 5.160
test_DeployVmAntiAffinityGroup | Success | 178.132
test_dedicatePublicIpRange | `Error` | 0.216
test_deploy_vgpu_enabled_vm | Skipped | 0.004
test_deploy_vm_from_iso | Success | 348.045
test_01_scale_vm | Skipped | 66.545
test_00_deploy_vm_root_resize | Success | 6.484
test_01_deploy_vm_root_resize | Success | 6.569
test_02_deploy_vm_root_resize | Success | 6.240
test_01_router_internal_basic | Success | 0.413
test_02_router_internal_adv | Success | 0.939
test_03_restart_network_cleanup | Success | 191.231
test_04_restart_network_wo_cleanup | Success | 5.598
test_05_router_basic | Success | 0.030
test_06_router_advanced | Success | 0.053
test_07_stop_router | Success | 30.235
test_08_start_router | Success | 135.816
test_09_reboot_router | Success | 160.970
test_deployvm_firstfit | Success | 161.175
test_deployvm_userconcentrated | Success | 90.952
test_deployvm_userdispersing | Success | 50.704
test_deployvm_userdata | Success | 141.327
test_deployvm_userdata_post | Success | 25.499
test_01_sys_vm_start | Success | 0.133
test_02_sys_template_ready | Success | 0.111
test_01_create_disk_offering | Success | 0.087
test_02_create_sparse_type_disk_offering | Success | 0.059
test_04_create_fat_type_disk_offering | Success | 0.058
test_02_edit_disk_offering | Success | 0.046
test_03_delete_disk_offering | Success | 0.036
test_default_role_deletion | Success | 6.376
test_role_account_acls | Success | 8.546
test_role_account_acls_multiple_mgmt_servers | `Error` | 1.137
test_role_inuse_deletion | Success | 6.302
test_role_lifecycle_create | Success | 6.224
test_role_lifecycle_delete | Success | 11.430
test_role_lifecycle_list | Success | 6.335
test_role_lifecycle_update | Success | 6.332
test_role_lifecycle_update_role_inuse | Success | 6.696
test_rolepermission_lifecycle_concurrent_updates | Success | 6.730
test_rolepermission_lifecycle_create | Success | 6.331
test_rolepermission_lifecycle_delete | Success | 6.234
test_rolepermission_lifecycle_list | Success | 6.327
test_rolepermission_lifecycle_update | Success | 6.815
test_01_create_service_offering | Success | 0.090
test_02_edit_service_offering | Success | 0.059
test_03_delete_service_offering | Success | 0.035
test_04_change_offering_small | Success | 98.049
test_UpdateConfigParamWithScope | Success | 0.123
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_01_snapshot_root_disk | `Error` | 150.951
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 314.192
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 546.268
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 151.572
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 561.917
test_01_list_sec_storage_vm | Success | 0.124
test_02_list_cpvm_vm | Success | 0.175
test_03_ssvm_internals | Success | 3.233
test_04_cpvm_internals | Success | 0.967
test_05_stop_ssvm | `Error` | 416.021
test_06_stop_cpvm | Success | 166.612
test_07_reboot_ssvm | Success | 158.412
test_08_reboot_cpvm | Success | 126.325
test_09_destroy_ssvm | Success | 299.035
test_10_destroy_cpvm | Success | 196.608
test_01_create_iso | Success | 66.344
test_02_edit_iso | Success | 0.061
test_03_delete_iso | Success | 95.159
test_04_extract_Iso | Success | 5.201
test_05_iso_permissions | Success | 0.053
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.047
test_01_list_volumes | Success | 0.025
test_02_list_templates | Success | 0.033
test_03_list_snapshots | Success | 0.057
test_static_role_account_acls | Skipped | 0.018
test_01_create_lb_rule_src_nat | Success | 207.967
test_02_create_lb_rule_non_nat | Success | 208.359
test_assign_and_removal_lb | Success | 149.755
login_test_saml_user | `Error` | 1.047
test_01_create_template | `Error` | 5.107
test_CreateTemplateWithDuplicateName | `Error` | 5.119
ContextSuite context=TestTemplates>:setup | `Error` | 205.285
test_nic_secondaryip_add_remove | Success | 238.232
test_network_acl | Success | 186.616
test_delete_account | Success | 293.164
test_01_port_fwd_on_src_nat | Success | 112.030
test_02_port_fwd_on_non_src_nat | Success | 55.675
test_public_ip_admin_account | Success | 40.238
test_public_ip_user_account | Success | 10.224
test_reboot_router | `Error` | 444.0

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1621
  
Trillian test result (trillian-pr1621-31-vmware-55u3-cs49): 
Test completed. 40 look ok, 12 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | Success | 373.303
test_create_pvlan_network | Success | 5.252
test_DeployVmAntiAffinityGroup | Success | 368.077
test_dedicatePublicIpRange | 
`marvin.cloudstackException.CloudstackAPIException` | 0.258
test_deploy_vgpu_enabled_vm | Skipped | 0.006
test_deploy_vm_from_iso | Success | 814.038
test_01_scale_vm | Skipped | 66.518
test_00_deploy_vm_root_resize | Success | 6.467
test_01_deploy_vm_root_resize | Success | 6.245
test_02_deploy_vm_root_resize | Success | 6.257
test_01_router_internal_basic | Success | 0.524
test_02_router_internal_adv | Success | 0.996
test_03_restart_network_cleanup | Success | 166.062
test_04_restart_network_wo_cleanup | Success | 5.657
test_05_router_basic | Success | 0.027
test_06_router_advanced | Success | 0.045
test_07_stop_router | Success | 20.208
test_08_start_router | Success | 125.800
test_09_reboot_router | Success | 155.991
test_deployvm_firstfit | Success | 256.851
test_deployvm_userconcentrated | Success | 111.206
test_deployvm_userdispersing | Success | 60.731
test_deployvm_userdata | Success | 176.604
test_deployvm_userdata_post | Success | 25.461
test_01_sys_vm_start | Success | 0.125
test_02_sys_template_ready | Success | 0.100
test_01_create_disk_offering | Success | 0.095
test_02_create_sparse_type_disk_offering | Success | 0.091
test_04_create_fat_type_disk_offering | Success | 0.073
test_02_edit_disk_offering | Success | 0.043
test_03_delete_disk_offering | Success | 0.031
test_default_role_deletion | Success | 6.420
test_role_account_acls | Success | 7.948
test_role_account_acls_multiple_mgmt_servers | Success | 7.787
test_role_inuse_deletion | Success | 6.283
test_role_lifecycle_create | Success | 6.316
test_role_lifecycle_delete | Success | 12.140
test_role_lifecycle_list | Success | 6.311
test_role_lifecycle_update | Success | 11.458
test_role_lifecycle_update_role_inuse | Success | 6.324
test_rolepermission_lifecycle_concurrent_updates | Success | 6.490
test_rolepermission_lifecycle_create | Success | 6.278
test_rolepermission_lifecycle_delete | Success | 6.240
test_rolepermission_lifecycle_list | Success | 6.452
test_rolepermission_lifecycle_update | Success | 6.586
test_01_create_service_offering | Success | 0.107
test_02_edit_service_offering | Success | 0.072
test_03_delete_service_offering | Success | 0.033
test_04_change_offering_small | Success | 97.643
test_UpdateConfigParamWithScope | Success | 0.136
ContextSuite context=TestDedicateGuestVlanRange>:setup | 
`exceptions.AttributeError` | 0.000
test_01_snapshot_root_disk | Success | 202.120
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 441.611
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 702.684
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.TypeError` | 436.238
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.TypeError` | 551.995
test_01_list_sec_storage_vm | Success | 0.097
test_02_list_cpvm_vm | Success | 0.115
test_03_ssvm_internals | Success | 4.202
test_04_cpvm_internals | Success | 1.357
test_05_stop_ssvm | Success | 214.221
test_06_stop_cpvm | Success | 237.023
test_07_reboot_ssvm | Success | 159.024
test_08_reboot_cpvm | Success | 156.759
test_09_destroy_ssvm | Success | 264.121
test_10_destroy_cpvm | Success | 267.044
test_01_create_iso | Success | 66.439
test_02_edit_iso | Success | 0.080
test_03_delete_iso | Success | 95.202
test_04_extract_Iso | Success | 5.165
test_05_iso_permissions | Success | 0.045
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.038
test_01_list_volumes | Success | 0.023
test_02_list_templates | Success | 0.032
test_03_list_snapshots | Success | 0.067
test_static_role_account_acls | Skipped | 0.020
test_01_create_lb_rule_src_nat | Success | 208.747
test_02_create_lb_rule_non_nat | Success | 207.669
test_assign_and_removal_lb | Success | 149.310
login_test_saml_user | Success | 21.728
test_01_create_template | Success | 226.419
test_CreateTemplateWithDuplicateName | Success | 357.211
test_02_edit_template | Success | 90.203
test_03_delete_template | Success | 5.094
test_04_extract_template | Success | 55.705
test_05_template_permissions | Success | 0.039
test_06_copy_template | Skipped | 0.000
test_07_list_public_templates | Success | 0.023
test_08_list_system_templates | Success | 0.018
test_nic_s

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[PaulAngus]

Github user PaulAngus commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
Thanks frank, would you make that change to the Nuage Network offering or 
shall I?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Trillian test result (trillian-pr1653-34-xenserver-65sp1-cs49): 
Test completed. 41 look ok, 11 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | Success | 191.851
test_create_pvlan_network | Success | 5.210
test_DeployVmAntiAffinityGroup | Success | 201.681
test_dedicatePublicIpRange | `Error` | 0.293
test_deploy_vgpu_enabled_vm | Skipped | 0.004
test_deploy_vm_from_iso | `Error` | 458.479
test_01_scale_vm | Success | 5.190
test_00_deploy_vm_root_resize | Success | 6.396
test_01_deploy_vm_root_resize | Success | 6.252
test_02_deploy_vm_root_resize | Success | 6.303
test_01_router_internal_basic | Success | 0.593
test_02_router_internal_adv | Success | 0.767
test_03_restart_network_cleanup | Success | 116.260
test_04_restart_network_wo_cleanup | Success | 5.496
test_05_router_basic | Success | 0.029
test_06_router_advanced | Success | 0.048
test_07_stop_router | Success | 15.167
test_08_start_router | Success | 50.404
test_09_reboot_router | Success | 75.506
test_deployvm_firstfit | Success | 271.988
test_deployvm_userconcentrated | Success | 101.006
test_deployvm_userdispersing | Success | 45.671
test_deployvm_userdata | Success | 116.193
test_deployvm_userdata_post | Success | 20.380
test_01_sys_vm_start | Success | 0.136
test_02_sys_template_ready | Success | 0.099
test_01_create_disk_offering | Success | 0.119
test_02_create_sparse_type_disk_offering | Success | 0.088
test_04_create_fat_type_disk_offering | Success | 0.090
test_02_edit_disk_offering | Success | 0.053
test_03_delete_disk_offering | Success | 0.038
test_default_role_deletion | Success | 6.423
test_role_account_acls | Success | 8.189
test_role_account_acls_multiple_mgmt_servers | Success | 7.805
test_role_inuse_deletion | Success | 6.256
test_role_lifecycle_create | Success | 6.293
test_role_lifecycle_delete | Success | 6.291
test_role_lifecycle_list | Success | 6.276
test_role_lifecycle_update | Success | 11.448
test_role_lifecycle_update_role_inuse | Success | 6.332
test_rolepermission_lifecycle_concurrent_updates | Success | 7.395
test_rolepermission_lifecycle_create | Success | 6.434
test_rolepermission_lifecycle_delete | Success | 6.380
test_rolepermission_lifecycle_list | Success | 6.486
test_rolepermission_lifecycle_update | Success | 6.584
test_01_create_service_offering | Success | 0.074
test_02_edit_service_offering | Success | 0.084
test_03_delete_service_offering | Success | 0.048
test_04_change_offering_small | Success | 126.082
test_UpdateConfigParamWithScope | Success | 0.140
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_01_snapshot_root_disk | Success | 61.380
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 157.244
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Error` | 167.471
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 287.671
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Error` | 297.856
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 141.649
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 146.758
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 282.539
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 287.635
test_01_list_sec_storage_vm | Success | 0.106
test_02_list_cpvm_vm | Success | 0.095
test_03_ssvm_internals | Success | 3.406
test_04_cpvm_internals | Success | 1.012
test_05_stop_ssvm | Success | 168.918
test_06_stop_cpvm | Success | 166.673
test_07_reboot_ssvm | Success | 154.144
test_08_reboot_cpvm | Success | 141.467
test_09_destroy_ssvm | Success | 199.000
test_10_destroy_cpvm | Success | 196.600
test_01_create_iso | Success | 66.395
test_02_edit_iso | Success | 0.073
test_03_delete_iso | Success | 95.172
test_04_extract_Iso | Success | 5.161
test_05_iso_permissions | Success | 0.068
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.074
test_01_list_volumes | Success | 0.032
test_02_list_templates | Success | 0.034
test_03_list_snapshots | Success | 0.074
test_static_role_account_acls | Skipped | 0.017
test_01_create_lb_rule_src_nat | Success | 208.204
test_02_create_lb_rule_non_nat | Success | 207.507
test_assign_and_removal_lb | Success | 148.821
login_test_saml_user | Success | 21.745
test_01_create_template | Success | 65.513
test_CreateTemplateWithDuplicateName | Success | 100.747
test_02_edit_template | Success | 90.143
test_03_delete_template | Success | 5.092
test_04_extract_template | Success | 5.180
tes

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
Trillian test result (trillian-pr1634-33-vmware-55u3-cs49): 
Test completed. 39 look ok, 13 have errors
Test | Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | Success | 242.223
test_create_pvlan_network | Success | 5.174
test_DeployVmAntiAffinityGroup | Success | 222.027
test_dedicatePublicIpRange | `Error` | 0.260
test_deploy_vgpu_enabled_vm | Skipped | 0.003
test_deploy_vm_from_iso | Success | 373.043
test_01_scale_vm | Skipped | 66.406
test_00_deploy_vm_root_resize | Success | 6.358
test_01_deploy_vm_root_resize | Success | 6.338
test_02_deploy_vm_root_resize | Success | 6.345
test_01_router_internal_basic | Success | 0.494
test_02_router_internal_adv | Success | 0.903
test_03_restart_network_cleanup | Success | 140.928
test_04_restart_network_wo_cleanup | Success | 5.591
test_05_router_basic | Success | 0.032
test_06_router_advanced | Success | 0.042
test_07_stop_router | Success | 25.274
test_08_start_router | Success | 120.878
test_09_reboot_router | Success | 140.902
test_deployvm_firstfit | Success | 206.794
test_deployvm_userconcentrated | Success | 96.038
test_deployvm_userdispersing | Success | 60.780
test_deployvm_userdata | Success | 151.369
test_deployvm_userdata_post | Success | 25.429
test_01_sys_vm_start | Success | 0.122
test_02_sys_template_ready | Success | 0.098
test_01_create_disk_offering | Success | 0.127
test_02_create_sparse_type_disk_offering | Success | 0.065
test_04_create_fat_type_disk_offering | Success | 0.067
test_02_edit_disk_offering | Success | 0.058
test_03_delete_disk_offering | Success | 0.037
test_default_role_deletion | Success | 6.364
test_role_account_acls | Success | 7.961
test_role_account_acls_multiple_mgmt_servers | Success | 7.946
test_role_inuse_deletion | Success | 6.231
test_role_lifecycle_create | Success | 6.400
test_role_lifecycle_delete | Success | 11.345
test_role_lifecycle_list | Success | 6.348
test_role_lifecycle_update | Success | 11.434
test_role_lifecycle_update_role_inuse | Success | 6.291
test_rolepermission_lifecycle_concurrent_updates | Success | 6.465
test_rolepermission_lifecycle_create | Success | 6.343
test_rolepermission_lifecycle_delete | Success | 6.226
test_rolepermission_lifecycle_list | Success | 6.391
test_rolepermission_lifecycle_update | Success | 6.513
test_01_create_service_offering | Success | 0.102
test_02_edit_service_offering | Success | 0.078
test_03_delete_service_offering | Success | 0.045
test_04_change_offering_small | Success | 96.948
test_UpdateConfigParamWithScope | Success | 0.145
ContextSuite context=TestDedicateGuestVlanRange>:setup | `Error` | 0.000
test_01_snapshot_root_disk | Success | 157.389
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 473.466
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 642.115
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 355.933
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 487.776
test_01_list_sec_storage_vm | Success | 0.133
test_02_list_cpvm_vm | Success | 0.106
test_03_ssvm_internals | Success | 3.458
test_04_cpvm_internals | Success | 1.075
test_05_stop_ssvm | Success | 168.743
test_06_stop_cpvm | Success | 201.889
test_07_reboot_ssvm | Success | 158.628
test_08_reboot_cpvm | Success | 156.591
test_09_destroy_ssvm | Success | 269.128
test_10_destroy_cpvm | Success | 266.909
test_01_create_iso | Success | 66.612
test_02_edit_iso | Success | 0.083
test_03_delete_iso | Success | 95.198
test_04_extract_Iso | Success | 5.164
test_05_iso_permissions | Success | 0.050
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.037
test_01_list_volumes | Success | 0.021
test_02_list_templates | Success | 0.029
test_03_list_snapshots | Success | 0.064
test_static_role_account_acls | Skipped | 0.020
test_01_create_lb_rule_src_nat | Success | 208.166
test_02_create_lb_rule_non_nat | Success | 207.423
test_assign_and_removal_lb | Success | 148.813
login_test_saml_user | Success | 21.747
test_01_create_template | Success | 135.939
test_CreateTemplateWithDuplicateName | Success | 221.472
test_02_edit_template | Success | 90.116
test_03_delete_template | Success | 5.123
test_04_extract_template | Success | 10.319
test_05_template_permissions | Success | 0.047
test_06_copy_template | Skipped | 0.000
test_07_list_public_templates | Success | 0.029
test_08_list_system_templates | Success | 0.068
test_nic_secondaryip_add_remove | Success | 222.996
test_network_acl | Success | 156.582
test_delete_

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

[PaulAngus]

Github user PaulAngus commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
that works for me. I'll adjust the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

[Rohit Yadav]

Hi B, how are you building CloudStack? Which branch is it?

Can you try a full clean build: mvn clean install -Dnoredist -Dsimulator -P 
developer,systemvm

You may install nonoss dependencies from here: 
https://github.com/rhtyd/cloudstack-nonoss


Regards.


From: B Prakash 
Sent: 22 August 2016 21:17:50
To: dev@cloudstack.apache.org
Subject: Compilation error "Execution cloudstack-checklicence of goal 
com.mycila:license-maven-plugin:2.11:check failed"

Hi, I am unable to compile latest source due to the following error, please can 
someone help me with this?

[ERROR] Failed to execute goal com.mycila:license-maven-plugin:2.11:check 
(cloudstack-checklicence) on project cloud-plugin-network-nvp: Execution 
cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check 
failed: Plugin com.mycila:license-maven-plugin:2.11 or one of its dependencies 
could not be resolved: Could not transfer artifact 
javax.enterprise:cdi-api:jar:1.0 from/to central 
(https://repo.maven.apache.org/maven2): Connection timed out -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command




Thanks and regards,

 B Prakash

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1646
  
@jburwell I've kept the changes into two commits (1) for pom.xml related 
version changes and (2) for db upgrade path, as when doing fwd-merging this 
will cause conflict with other pom files so on fwd-merging we can use a merging 
strategy to pick changes on (ours) master for the pom related changes while 
take the db upgrade path changes. I'll further require to fix the upgrade path 
on master branch to be like --> 4.9.0->4.9.1(.0)->4.10.0(.0) which is right now 
set as 4.9.0->4.10.0. I can also help with doing the fwd-merging so you can 
avoid dealing with the conflicts yourself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo can you give me push permission on your repository once again to 
push the refactoring change, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1653#discussion_r75715632
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -452,9 +452,9 @@ def fw_vpcrouter(self):
 self.fw.append(
 ["filter", "", "-A INPUT -i %s -p udp -m udp --dport 67 -j 
ACCEPT" % self.dev])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
--- End diff --

@jburwell there were several places where such minor refactoring could be 
done, I've kept the scope limited to the change in the PR. @NuxRo I've 
refactored it as per John's comment. I'll see if we've an existing marvin test 
for this, otherwise I'll add one tomorrow/later-this-week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo np, I'll help with the refactoring fixes etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[fmaximus]

Github user fmaximus commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
As Nuage plugin developer, I can't come up with any good reason why it 
should be default.
Also I see that Redundant VPC Offering is set to be a default.
Both are most likely just copied from defaultVPCOfferingName creation.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo understood.  I am working to get you some assistance.  That work for 
you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Compilation error "Execution cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check failed"

[B Prakash]

Hi, I am unable to compile latest source due to the following error, please can 
someone help me with this?

[ERROR] Failed to execute goal com.mycila:license-maven-plugin:2.11:check 
(cloudstack-checklicence) on project cloud-plugin-network-nvp: Execution 
cloudstack-checklicence of goal com.mycila:license-maven-plugin:2.11:check 
failed: Plugin com.mycila:license-maven-plugin:2.11 or one of its dependencies 
could not be resolved: Could not transfer artifact 
javax.enterprise:cdi-api:jar:1.0 from/to central 
(https://repo.maven.apache.org/maven2): Connection timed out -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/PluginResolutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command




Thanks and regards,

 B Prakash

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@jburwell I am afraid I do not have the coding skills to do what you want 
re that variable, I am just submitting @ustcweizhou's code from that Jira issue.

Right now basic/sg zones are vulnerable to this and need manual patching, 
so it must be a regression I guess.

I've opened a new issue:

https://issues.apache.org/jira/browse/CLOUDSTACK-9464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo is it possible to create/update a Marvin test case to verify this 
change?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1653: Prevent DNS reflection attacks

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1653#discussion_r75690054
  
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -452,9 +452,9 @@ def fw_vpcrouter(self):
 self.fw.append(
 ["filter", "", "-A INPUT -i %s -p udp -m udp --dport 67 -j 
ACCEPT" % self.dev])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p udp -m udp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
 self.fw.append(
-["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -j 
ACCEPT" % self.dev])
+["filter", "", "-A INPUT -i %s -p tcp -m tcp --dport 53 -s 
%s -j ACCEPT" % (self.dev, self.address['network'])])
--- End diff --

Minor nit: extract the value of ``self.address['network']`` to a local 
variable?  Not only will change ensure consistency of the value across the four 
rules, but it will make the code more literate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1646
  
@rhtyd could you please squash the commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
Debian returns: 1 packets transmitted, 1 packets received, 0% packet loss
CentOs returns: 1 packets transmitted, 1 received, 0% packet loss, time 4ms

Between those 2 we could be  simply checking for 0% loss: check_string = ", 
0% packet loss"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@wido that seems to be the case, yes.


https://github.com/myENA/cloudstack/blob/44220a41c119020404c55e7a82a808ddee828116/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java#L727

The section starts there, and down on line 747 it calls convert.  Keep in 
mind the above link is the code as if this PR was applied.  From my testing, 
this seems to work well, but please let me know if after revisiting the code 
you have any concerns.  Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: CCC Brasil

[Tutkowski, Mike]

I believe that is the old date. It should probably be updated to TBD.

On Aug 22, 2016, at 2:39 AM, Erik Weber 
mailto:terbol...@gmail.com>> wrote:

On the web page, the date is updated to Sept 29-30, is this correct? If so, it 
should be advertised.

--
Erik

On Tue, Aug 16, 2016 at 5:32 PM, Marco Sinhoreli 
mailto:marco.sinhor...@shapeblue.com>> wrote:
All,

I am very sorry to have to say that we have had to postpone the upcoming CCC 
conference in Sao Paluo.

Over the past few months we have been working very hard with an events 
organiser to try and get the conference off the ground. Conferences are very 
expensive to stage here in Brasil so we were relying on a number of large 
sponsors. Unfortunately , we are unable to get enough sponsors for the proposed 
September dates due to multiple schedule conflicts.

I appreciate that this is very late notice. Up until this week we were hoping 
to have enough sponsorship to run the event but we were also conscious that 
this would have left only a little time for CFP and people to make travel 
arrangements. We have therefore decided to cancel the September conference. 
We're working with local sponsors and our venue hosts to try and find some 
dates either later in 2016 or in 2017.

Best regards,


[cid:D163DEC9-811D-4BA2-9505-94F51109CA0B]

Marco Sinhoreli
Managing Consultant
marco.sinhor...@shapeblue.com
mobile: +55 21 98276 3636


Praia de Botafogo 501, bloco 1 - sala 101 - Botafogo
Rio de Janeiro, RJ - Brazil - CEP 22250-040
office: + 55 21 2586 6390 | fax: +55 21 2586 
6002
http://www.shapeblue.com/ | twitter: @shapeblue

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs56sp1, centos7 mgmt 
+ vmware55u3, ubuntu mgmt + kvmcentos7) has been kicked to run smoke tests 
against packages at http://packages.shapeblue.com/cloudstack/pr/1653


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@blueorangutan test matrix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Packaging result: ✔centos6 ✔centos7 ✔debian repo: 
http://packages.shapeblue.com/cloudstack/pr/1653
Job ID-94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

[PaulAngus]

Github user PaulAngus commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
The best way to fix this would be a ping function that gets called. 
However, that's not something that i can personally do and this will work 
for (at least) Ubuntu, CentOS/RHEL and macchinina - making it infinitely better 
that it was.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo thanks, fixed the branch, you may remove my access  now :)

@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo okay, can you grant me push access on your fork: 
https://github.com/NuxRo/cloudstack/tree/patch-4 and I can help fix it for you?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Rohit unfortunately I do not have git setup properly, I am limited to what 
the github interface offers me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo there are still several commits which have come from master; can you 
export the commit (git format-patch -1) and reset --hard origin/4.9 and 
re-apply the commit (git am ) and then git push -f.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Done?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[PaulAngus]

Github user PaulAngus commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
Without full understanding of the Nuage plugin, fixing the test seemed the 
safest path, one hopes that the nuage offering was configured that way for a 
good reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Thanks @NuxRo can you rebase against latest 4.9, looks like some more 
commits came in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1630: Add projectid to project details page

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1630
  
Manually tested, LGTM. We can merge this, the failing Travis tests are not 
related to the change (which is purely UI).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
Rohit, done, go right ahead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@abhinandanprateek can you reopen/edit the PR for 4.9? thanks.
LGTM. /cc @jburwell @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
@rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been 
kicked to run smoke tests against packages at 
http://packages.shapeblue.com/cloudstack/pr/1634


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1634
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido with this change will we have to host two versions of deb repository 
-- one built on ubuntu without systemd (such as 14.04) and one built on ubuntu 
with systemd (16.04+)? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
@NuxRo if you can change the base-branch of the PR to 4.9, I can initiate 
some tests on VR/trillian.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate sc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1649


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1649
  
Test run:

python scripts/util/migrate-dynamicroles.py -d -f commands.properties
Apache CloudStack Role Permission Migration Tool
(c) Apache CloudStack Authors and the ASF, under the Apache License, 
Version 2.0

Running this migration tool will remove any default-role permissions from 
cloud.role_permissions. Do you want to continue? [y/N]y
The commands.properties file has been deprecated and moved at: 
commands.properties.deprecated
Running SQL query: DELETE FROM `cloud`.`role_permissions` WHERE `role_id` 
in (1,2,3,4);
Running SQL query: INSERT INTO `cloud`.`role_permissions` (`uuid`, 
`role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 1, '*', 'ALLOW', 
0);
Running SQL query: INSERT INTO `cloud`.`role_permissions` (`uuid`, 
`role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 2, 
'deleteAccount', 'ALLOW', 0);
Running SQL query: INSERT INTO `cloud`.`role_permissions` (`uuid`, 
`role_id`, `rule`, `permission`, `sort_order`) values (UUID(), 2, 
'markDefaultZoneForAccount', 'ALLOW', 1);
Static role permissions from commands.properties have been migrated into 
the db
Running SQL query: UPDATE `cloud`.`configuration` SET value='true' where 
name='dynamic.apichecker.enabled'
Dynamic role based API checker has been enabled!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1649
  
This change is limited to the migration script and does not impact 
CloudStack. Manual tests confirmed the fix works with both new and old 
commands.properties.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
I've tested this in Adv zone with Security Groups and it works. Can't vouch 
for "pure" Adv zones. Perhaps @ustcweizhou can say more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
@jburwell thanks fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
LGTM based on code review, the order of cleanup is fixed so that the 
resources are released in right order.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
@rhtyd could you please amend the commit message to explain the defect 
being fixed?  It's hard to review the code without understanding the scope of 
the problem being addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1648
  
The specific tests run with simulator only, so travis test results should 
be acceptable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1653
  
LGTM, we need to also test for users who connect to VPN on that network 
(will DNS work for them as well?).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1621
  
@rhtyd a Trillian-Jenkins test job (centos6 mgmt + vmware-55u3) has been 
kicked to run smoke tests against packages at 
http://packages.shapeblue.com/cloudstack/pr/1621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1621
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Hiding buttons based on role

[Frank Maximus]

Filters on action are already used for vm's.
See vmActionfilter in instances.js.
Also for the sections I can find a sectionPreFilter in cloudStack.js
That seems to check the response of listCapabilities for
'allowusercreateprojects'.

Kind Regards,
Frank



*Frank Maximus *

Senior Software Development Engineer



*nuage*networks.net
​Copernicuslaan 50

2018 Antwerp

Belgium



p: +32 3 240 73 81


On Fri, Aug 19, 2016 at 1:41 AM, Marty Godsey  wrote:

> That would be great. I think adding the ability hide GUI elements based on
> role inside the GUI would be a great step.
>
> Regards,
> Marty Godsey
>
> -Original Message-
> From: Rashmi Dixit [mailto:rashmi_di...@accelerite.com]
> Sent: Thursday, August 18, 2016 8:15 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Hiding buttons based on role
>
> Hi Marty,
>
> We could add an "actionPreFilter" for "actions" defined in the widgets
> which will filter out the buttons based on role.
>
> There are preFilters already implemented for fields in a listView - we
> need to follow the same principle. We need to check for this filter where
> the buttons are built in the listView (look for "if (listViewData.actions)
> {" in listView.js).
>
> Hope this helps!
> Rashmi
>
>
>
> -Original Message-
> From: Marty Godsey [mailto:ma...@gonsource.com]
> Sent: Thursday, August 18, 2016 6:04 AM
> To: dev@cloudstack.apache.org
> Subject: RE: Hiding buttons based on role
>
> Not elegant but will work. This is not a one off to a degree. It's for my
> own servers but I will have at least 10-20 management server across the
> country in different zones  but this allows me to "hide" some elements that
> won't be used until a more elegant way is created/available.
>
> Thank you for the direction Will.
>
> Regards,
> Marty Godsey
>
> -Original Message-
> From: Will Stevens [mailto:williamstev...@gmail.com]
> Sent: Wednesday, August 17, 2016 8:29 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Hiding buttons based on role
>
> If I was doing a one off solution for my own use case with a limited
> scope, I would do it he following.
>
> Apply a CSS class to the  tag which corresponds to the role. Then I
> would use CSS to 'display:none' on the elements you want to turn off by
> referencing the body role class (and keep the permissions applied so if
> they unhide it won't work).
>
> It is not an elegant solution, but it will work.
>
> On Aug 17, 2016 8:19 PM, "Marty Godsey"  wrote:
>
> >
>
> > Ok. Thank you.
> >
> > I think for the time being I will enable all the project APIs again
> > but
> deny access to create a project.. this way at least he API errors on page
> load go away.
> >
> > This is something I think would be nice to have in the permissions
> > area
> now since we have granular rules. A way to "turn off" certain areas of the
> GUI and/or ACS functionality.
> >
> > Regards,
> > Marty Godsey
> >
> > -Original Message-
> > From: Will Stevens [mailto:williamstev...@gmail.com]
> > Sent: Wednesday, August 17, 2016 8:10 PM
> > To: dev@cloudstack.apache.org
> > Subject: RE: Hiding buttons based on role
> >
> > Yes. Most of the UI is built using huge json structures. These will
> > need
> to be adapted to account for a user's role. I don't think there has been
> work done on that yet, but I could be wrong.
> >
> > @rohit, do you know if anyone has looked into this at all yet?
> >
> > On Aug 17, 2016 7:41 PM, "Marty Godsey"  wrote:
> >
> > > With that being said, we are now getting into the area of UI
> > > modification to hide the button huh?
> > >
> > > Regards,
> > > Marty Godsey
> > >
> > > -Original Message-
> > > From: Will Stevens [mailto:williamstev...@gmail.com]
> > > Sent: Wednesday, August 17, 2016 7:23 PM
> > > To: dev@cloudstack.apache.org
> > > Subject: Re: Hiding buttons based on role
> > >
> > > My understanding is that the permissions can be set, but they
> > > currently do not modify the UI in any way. I believe what you are
> > > experiencing is the expected behavior.
> > >
> > > Cheers,
> > >
> > > Will
> > >
> > > On Aug 17, 2016 6:47 PM, "Marty Godsey"  wrote:
> > >
> > > > Is it possible to hide a button based upon a role? As an example I
> > > > want to hide and deny access to the projects tab. I can modify the
> > > > role access to the API but the button is still present. In fact I
> > > > get an API error that states I don't have access.
> > > >
> > > > Regards,
> > > > Marty Godsey
> > > >
> > > >
> > >
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is
> the property of Accelerite, a Persistent Systems business. It is intended
> only for the use of the individual or entity to which it is addressed. If
> you are not the intended recipient, you are not authorized to read, retain,
> copy, print, distribute or use this message. If you have received this
> communication in error, please notify the sender and delete all copies of
> this message. Accelerite, a Persisten

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
@karuturi a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests against packages at 
http://packages.shapeblue.com/cloudstack/pr/1593


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1620
  
Merging based on review and test results above, thanks @blueorangutan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1620
  
Trillian test result (trillian-pr1638-29-xenserver-65sp1-cs410): Test | 
Result | Time
--- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | Success | 282.569
test_create_pvlan_network | Success | 5.224
test_DeployVmAntiAffinityGroup | Success | 136.402
test_dedicatePublicIpRange | 
`marvin.cloudstackException.CloudstackAPIException` | 0.245
test_deploy_vgpu_enabled_vm | Skipped | 0.004
test_deploy_vm_from_iso | `exceptions.Exception` | 519.082
test_01_scale_vm | Success | 5.209
test_00_deploy_vm_root_resize | Success | 6.418
test_01_deploy_vm_root_resize | Success | 6.271
test_02_deploy_vm_root_resize | Success | 6.509
test_01_router_internal_basic | Success | 0.321
test_02_router_internal_adv | Success | 0.548
test_03_restart_network_cleanup | Success | 120.830
test_04_restart_network_wo_cleanup | Success | 5.404
test_05_router_basic | Success | 0.032
test_06_router_advanced | Success | 0.063
test_07_stop_router | Success | 15.174
test_08_start_router | Success | 50.420
test_09_reboot_router | Success | 65.510
test_deployvm_firstfit | Success | 181.469
test_deployvm_userconcentrated | Success | 95.964
test_deployvm_userdispersing | Success | 45.720
test_deployvm_userdata | Success | 126.146
test_deployvm_userdata_post | Success | 25.496
test_01_sys_vm_start | Success | 0.146
test_02_sys_template_ready | Success | 0.103
test_01_create_disk_offering | Success | 0.119
test_02_create_sparse_type_disk_offering | Success | 0.077
test_04_create_fat_type_disk_offering | Success | 0.071
test_02_edit_disk_offering | Success | 0.086
test_03_delete_disk_offering | Success | 0.040
test_default_role_deletion | Success | 6.490
test_role_account_acls | Success | 8.130
test_role_account_acls_multiple_mgmt_servers | Success | 7.846
test_role_inuse_deletion | Success | 6.309
test_role_lifecycle_create | Success | 6.329
test_role_lifecycle_delete | Success | 11.347
test_role_lifecycle_list | Success | 6.332
test_role_lifecycle_update | Success | 11.459
test_role_lifecycle_update_role_inuse | Success | 6.292
test_rolepermission_lifecycle_concurrent_updates | Success | 6.557
test_rolepermission_lifecycle_create | Success | 6.329
test_rolepermission_lifecycle_delete | Success | 6.292
test_rolepermission_lifecycle_list | Success | 6.408
test_rolepermission_lifecycle_update | Success | 6.634
test_01_create_service_offering | Success | 0.087
test_02_edit_service_offering | Success | 0.078
test_03_delete_service_offering | Success | 0.042
test_04_change_offering_small | Success | 126.087
test_UpdateConfigParamWithScope | Success | 0.145
ContextSuite context=TestDedicateGuestVlanRange>:setup | 
`exceptions.AttributeError` | 0.000
test_01_snapshot_root_disk | Success | 66.466
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `exceptions.Exception` 
| 161.948
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `exceptions.Exception` 
| 172.282
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | 
`exceptions.Exception` | 272.445
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | 
`exceptions.Exception` | 282.629
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.Exception` | 161.681
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.Exception` | 166.779
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.Exception` | 247.162
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | 
`exceptions.Exception` | 252.263
test_01_list_sec_storage_vm | Success | 0.092
test_02_list_cpvm_vm | Success | 0.119
test_03_ssvm_internals | Success | 3.824
test_04_cpvm_internals | Success | 0.936
test_05_stop_ssvm | Success | 138.763
test_06_stop_cpvm | Success | 196.832
test_07_reboot_ssvm | Success | 148.905
test_08_reboot_cpvm | Success | 146.425
test_09_destroy_ssvm | Success | 198.831
test_10_destroy_cpvm | Success | 201.686
test_01_create_iso | Success | 66.416
test_02_edit_iso | Success | 0.079
test_03_delete_iso | Success | 95.187
test_04_extract_Iso | Success | 5.127
test_05_iso_permissions | Success | 0.056
test_06_copy_iso | Skipped | 0.000
test_07_list_default_iso | Success | 0.050
test_01_list_volumes | Success | 0.025
test_02_list_templates | Success | 0.040
test_03_list_snapshots | Success | 0.074
test_static_role_account_acls | Skipped | 0.020
test_01_create_lb_rule_src_nat | Success | 208.003
test_02_create_lb_rule_non_nat | Success | 207.487
test_assign_and_removal_lb | Success | 148.681
login_test_saml_user | Success | 21.730
test_01_create_template | Success | 70.600
test_CreateTemplateWithDuplicateName | Succ

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1620
  
Trillian test result (trillian-pr1638-29-xenserver-65sp1-cs410): Test 
completed. 41 look ok, 11 have errors

+-+-+-+
|  Test   | Result  |  Time 
  |

+=+=+=+
| test_DeployVmAntiAffini | Success | 282.569   
  |
| tyGroup_in_project  | |   
  |

+-+-+-+
| test_create_pvlan_netwo | Success | 5.224 
  |
| rk  | |   
  |

+-+-+-+
| test_DeployVmAntiAffini | Success | 136.402   
  |
| tyGroup | |   
  |

+-+-+-+
| test_dedicatePublicIpRa | marvin.cloudstackExcept | 0.245 
  |
| nge | ion.CloudstackAPIExcept |   
  |
| | ion |   
  |

+-+-+-+
| test_deploy_vgpu_enable | Skipped | 0.004 
  |
| d_vm| |   
  |

+-+-+-+
| test_deploy_vm_from_iso | exceptions.Exception| 519.082   
  |

+-+-+-+
| test_01_scale_vm| Success | 5.209 
  |

+-+-+-+
| test_00_deploy_vm_root_ | Success | 6.418 
  |
| resize  | |   
  |

+-+-+-+
| test_01_deploy_vm_root_ | Success | 6.271 
  |
| resize  | |   
  |

+-+-+-+
| test_02_deploy_vm_root_ | Success | 6.509 
  |
| resize  | |   
  |

+-+-+-+
| test_01_router_internal | Success | 0.321 
  |
| _basic  | |   
  |

+-+-+-+
| test_02_router_internal | Success | 0.548 
  |
| _adv| |   
  |

+-+-+-+
| test_03_restart_network | Success | 120.830   
  |
| _cleanup| |   
  |

+-+-+-+
| test_04_restart_network | Success | 5.404 
  |
| _wo_cleanup | |   
  |

+-+-+-+
| test_05_router_basic| Success | 0.032 
  |

+-+-+-+
| test_06_router_advanced | Success | 0.063 
  |

+-+-+-+
| test_07_stop_router | Success | 15.174
  |

+-+-+-+
| test_08_start_router| Success | 50.420
  |

+-+-+-+
| test_09_reboot_router   | Success | 65.510
  |

+-+-+-+
| test_deployvm_firstfit  | Success | 181.469   
  |

+-+-+-+
| test_deployvm_u